[Qemu-devel] About the IO queue inside qemu

2013-10-01 Thread Yaodong Yang
Hi all, I'm wondering is there any io queue inside qemu? Is there any IO scheduling inside it? I notice that there is an IO track feature inside block.c, but I do not know the purpose of it. Could someone explain it for me? Thanks a lot! Yaodong

Re: [Qemu-devel] [PULL 0/1] seabios update to 1.7.3.2

2013-10-01 Thread Gerd Hoffmann
On Di, 2013-10-01 at 17:21 +0100, Alex Bennée wrote: > kra...@redhat.com writes: > > > Hi, > > > > New seabios release is out, here comes the update for qemu. > > > > please pull, > > Gerd > > This has broken qemu/master as the sub-project commit: > > ece025f5980bae88fa677bc9c0d24d2e580e205d

Re: [Qemu-devel] [OpenRISC] [PATCH] Correction of the TLB handling of the OpenRISC target

2013-10-01 Thread Jia Liu
Hi Sebastian, On Wed, Oct 2, 2013 at 1:12 PM, Sebastian Macke wrote: > Hi, > > this patch corrects two problems for the OpenRISC Target in QEMU. The first > one corrects one obvious bug > concerning the handling of page faults while reading from a page. @@ -102,7 +102,7 @@ int cpu_openrisc_get_p

Re: [Qemu-devel] [PATCH v7 07/27] loader: support for unmapped ROM blobs

2013-10-01 Thread Michael S. Tsirkin
On Tue, Oct 01, 2013 at 03:28:34PM -0600, Eric Blake wrote: > On 10/01/2013 03:26 PM, Michael S. Tsirkin wrote: > > Support ROM blobs not mapped into guest memory: > > same as ROM files really but use caller's buffer. > > > > Support incoking callback on access and > > s/incoking/incoming/ > > >

Re: [Qemu-devel] [Bug 1233225] Re: mips/mipsel linux user float division problem

2013-10-01 Thread Stefan Weil
Am 02.10.2013 03:39, schrieb Peter Maydell: > On 2 October 2013 02:51, Stefan Weil <1233...@bugs.launchpad.net> wrote: >> I can confirm that something is strange with MIPS Linux user emulation, >> but get a different result (which is also wrong): >> >> # Your test code is in file divtest.c. >> $ mi

Re: [Qemu-devel] [Build bug] Problem checking out submodules

2013-10-01 Thread Lucas Meneghel Rodrigues
On 10/01/2013 10:32 PM, Anthony Liguori wrote: Should be better now. Thanks, Anthony!

Re: [Qemu-devel] [PATCH v2 0/6] Improve getauxval support

2013-10-01 Thread Peter Maydell
On 2 October 2013 06:25, Richard Henderson wrote: > Ping. Does this need updating now that commit 03cfd8faa (which manually walks through the auxval in get_execfd()) has been committed? thanks -- PMM

Re: [Qemu-devel] [Bug 1233225] Re: mips/mipsel linux user float division problem

2013-10-01 Thread Peter Maydell
On 2 October 2013 02:51, Stefan Weil <1233...@bugs.launchpad.net> wrote: > I can confirm that something is strange with MIPS Linux user emulation, > but get a different result (which is also wrong): > > # Your test code is in file divtest.c. > $ mipsel-linux-gnu-gcc-4.7 -g -static divtest.c > $ mip

Re: [Qemu-devel] [Build bug] Problem checking out submodules

2013-10-01 Thread Anthony Liguori
Should be better now. Regards, Anthony Liguori On Tue, Oct 1, 2013 at 1:12 PM, Lucas Meneghel Rodrigues wrote: > Hello: > > In the daily qemu.git autotest run, I started to see the following problem > while checking out the qemu.git tree and checking out the submodules: > > $ git submodule up

Re: [Qemu-devel] [PULL 00/01] seccomp: trivial changes

2013-10-01 Thread Anthony Liguori
On Tue, Oct 1, 2013 at 3:04 PM, Paul Moore wrote: > On Tuesday, September 24, 2013 03:30:57 PM Eduardo Otubo wrote: > > Anthony, > > > > The following changes since commit > f828a4c8faa118e0ebab3e353ac6840f3b2a0318: > > > > Merge remote-tracking branch 'stefanha/tracing' into staging > (2013-09

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

2013-10-01 Thread Alexey Kardashevskiy
On 10/02/2013 07:23 AM, Benjamin Herrenschmidt wrote: > On Wed, 2013-10-02 at 00:23 +1000, Alexey Kardashevskiy wrote: > >> SLOF is what is loaded from the very beginning, it configures PCI, cooks >> the device tree and boots the guest system (directly or via yaboot/grub, >> from disk, network or

[Qemu-devel] [PULL 4/8] tcg-arm: Use QEMU_BUILD_BUG_ON to verify constraints on tlb

2013-10-01 Thread Richard Henderson
One of the two constraints we already checked via #if, but the tlb offset distance was only checked at runtime. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target

[Qemu-devel] [PATCH v7 09/27] pcie_host: expose address format

2013-10-01 Thread Michael S. Tsirkin
Callers pass in the address so it's helpful for them to be able to decode it. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie_host.h | 21 + hw/pci/pcie_host.c | 21 - 2 files changed,

[Qemu-devel] [PULL 8/8] tcg-arm: Move the tlb addend load earlier

2013-10-01 Thread Richard Henderson
There are free scheduling slots between the sequence of comparison instructions. This requires changing the register in use to avoid conflict with those compares. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --

[Qemu-devel] [PATCH v7 15/27] acpi: ssdt pcihp: updat generated file

2013-10-01 Thread Michael S. Tsirkin
update generated file, not sure what changed Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- hw/i386/ssdt-pcihp.hex.generated | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/i386/ssdt-pcihp.hex.generated b/hw/i386/ssdt-pc

[Qemu-devel] [PATCH v7 13/27] acpi: add rules to compile ASL source

2013-10-01 Thread Michael S. Tsirkin
Detect presence of IASL compiler and use it to process ASL source. If not there, use pre-compiled files in-tree. Add script to update the in-tree files. Note: distros are known to silently update iasl so detect correct iasl flags for the installed version on each run as opposed to at configure tim

[Qemu-devel] [PATCH v7 05/27] pci: fix up w64 size calculation helper

2013-10-01 Thread Michael S. Tsirkin
BAR base was calculated incorrectly. Use existing pci_bar_address to get it right. Tested-by: Igor Mammedov Signed-off-by: Michael S. Tsirkin --- hw/pci/pci.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 00554a0..c3f

Re: [Qemu-devel] [PATCH v7 07/27] loader: support for unmapped ROM blobs

2013-10-01 Thread Eric Blake
On 10/01/2013 03:26 PM, Michael S. Tsirkin wrote: > Support ROM blobs not mapped into guest memory: > same as ROM files really but use caller's buffer. > > Support incoking callback on access and s/incoking/incoming/ > return memory pointer making it easier > for caller to update memory if neces

[Qemu-devel] [PATCH v7 08/27] pcie_host: expose UNMAPPED macro

2013-10-01 Thread Michael S. Tsirkin
Make it possible to test unmapped status through QMP. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie_host.h | 3 +++ hw/pci/pcie_host.c | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/hw/pci/

Re: [Qemu-devel] [PATCH] turn firmware image filename into a machine option

2013-10-01 Thread Benjamin Herrenschmidt
On Wed, 2013-10-02 at 00:23 +1000, Alexey Kardashevskiy wrote: > SLOF is what is loaded from the very beginning, it configures PCI, cooks > the device tree and boots the guest system (directly or via yaboot/grub, > from disk, network or ram). Normal firmware, as usual. It knows all the > details a

[Qemu-devel] [PATCH v7 27/27] ssdt-proc: update generated file

2013-10-01 Thread Michael S. Tsirkin
Update generated ssdt proc hex file (used for systems lacking IASL) after P_BLK length change. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- hw/i386/ssdt-proc.hex.generated | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[Qemu-devel] [PULL 2/8] tcg-arm: Rearrange slow-path qemu_ld/st

2013-10-01 Thread Richard Henderson
Use the new helper_ret_*_mmu routines. Use a conditional call to arrange for a tail-call from the store path, and to load the return address for the helper for the load path. Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 16 + tcg/arm/tcg-target.c| 177

[Qemu-devel] [PULL 3/8] tcg-arm: Use strd for tcg_out_arg_reg64

2013-10-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 9d2fe8a..f953f4e 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/arm/tcg-target.c @@ -1149,9 +1149,16 @@ stati

[Qemu-devel] [PULL 0/8] tcg-arm qemu_ld/st improvements

2013-10-01 Thread Richard Henderson
Merely rebased from the last patch set posted, fixing trivial conflicts with the ppc/ppc64 qemu_ld/st patch set. r~ The following changes since commit a684f3cf9b9b9c3cb82be87aafc463de8974610c: Merge remote-tracking branch 'kraxel/seabios-1.7.3.2' into staging (2013-09-30 17:15:27 -0500) ar

[Qemu-devel] [PULL 1/8] tcg-arm: Use ldrd/strd for appropriate qemu_ld/st64

2013-10-01 Thread Richard Henderson
Reviewed-by: Aurelien Jarno Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 48 +++- 1 file changed, 43 insertions(+), 5 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index eb0e84c..ea0d9b4 100644 --- a/tcg/arm/tcg-

[Qemu-devel] [PULL 5/8] tcg-arm: Move load of tlb addend into tcg_out_tlb_read

2013-10-01 Thread Richard Henderson
This allows us to make more intelligent decisions about the relative offsets of the tlb comparator and the addend, avoiding any need of writeback addressing. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 60 1 file changed, 23 in

Re: [Qemu-devel] [PATCH] qemu-ga: execute fsfreeze-freeze in reverse order of mounts

2013-10-01 Thread Eric Blake
On 10/01/2013 03:09 PM, Tomoki Sekiyama wrote: > Currently, fsfreeze-freeze may cause deadlock if a guest has loopback mounts > of image files in its disk; e.g.: > > # mount | grep ^/ > /dev/vda1 / type ext4 (rw,noatime,seclabel,data=ordered) > /tmp/disk.img on /mnt type ext4 (rw,relat

[Qemu-devel] [PATCH v7 22/27] ich9: APIs for pc guest info

2013-10-01 Thread Michael S. Tsirkin
This adds APIs that will be used to fill in acpi tables, implemented using QOM, to various ich9 components. Some information is still missing in QOM, so we fall back on lookups by type instead. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw

[Qemu-devel] [PATCH v7 21/27] piix: APIs for pc guest info

2013-10-01 Thread Michael S. Tsirkin
This adds APIs that will be used to fill in guest acpi tables. Some required information is still lacking in QOM, so we fall back on lookups by type and returning explicit types. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/piix4.h |

[Qemu-devel] [PATCH v7 19/27] i386: define pc guest info

2013-10-01 Thread Michael S. Tsirkin
This defines a structure that will be used to fill in acpi tables where relevant properties are not yet available using QOM. Reviewed-by: Laszlo Ersek Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 10 ++ hw/i386/pc.c

[Qemu-devel] [PULL 7/8] tcg-arm: Remove restriction on qemu_ld output register

2013-10-01 Thread Richard Henderson
The main intent of the patch is to allow the tlb addend register to be changed, without tying that change to the constraint. But the most common side-effect seems to be to enable usage of ldrd with the r0,r1 pair. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 58 ++

[Qemu-devel] [PULL 6/8] tcg-arm: Return register containing tlb addend

2013-10-01 Thread Richard Henderson
Preparatory to rescheduling the tlb load, and changing said register. Continues to use R1 for now. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 59 ++-- 1 file changed, 30 insertions(+), 29 deletions(-) diff --git a/tcg/arm/tcg-targ

[Qemu-devel] [PATCH v7 26/27] ssdt: fix PBLK length

2013-10-01 Thread Michael S. Tsirkin
We don't really support CPU throttling, so supply 0 PBLK length. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- hw/i386/ssdt-proc.dsl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/ssdt-proc.dsl b/hw/i386/ssdt-proc.dsl ind

[Qemu-devel] [PATCH v7 17/27] i386: add bios linker/loader

2013-10-01 Thread Michael S. Tsirkin
This adds a dynamic bios linker/loader. This will be used by acpi table generation code to: - load each table in the appropriate memory segment - link tables to each other - fix up checksums after said linking Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael

Re: [Qemu-devel] [PATCH v2 0/6] Improve getauxval support

2013-10-01 Thread Richard Henderson
Ping. r~ On 09/10/2013 03:07 PM, Richard Henderson wrote: > Changes from v1: > * Fix silly error in patch 1. > > Tested on arm with and without CONFIG_GETAUXVAL commented out > in config-host.mak. Tested on ppc only with CONFIG_GETAUXVAL. > > > r~ > > > Richard Henderson (6): > osdep: C

[Qemu-devel] [PATCH v7 24/27] hpet: add API to find it

2013-10-01 Thread Michael S. Tsirkin
Add API to find HPET using QOM. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/timer/hpet.h | 2 ++ hw/timer/hpet.c | 5 + 2 files changed, 7 insertions(+) diff --git a/include/hw/timer/hpet.h b/include/hw/timer/hpet.h index 75

[Qemu-devel] [PATCH v7 18/27] loader: allow adding ROMs in done callbacks

2013-10-01 Thread Michael S. Tsirkin
Don't abort if machine done callbacks add ROMs. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/loader.h | 1 + hw/core/loader.c| 6 +- vl.c| 3 +++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/includ

[Qemu-devel] [PATCH v7 23/27] pvpanic: add API to access io port

2013-10-01 Thread Michael S. Tsirkin
Add API to find pvpanic device and get its io port. Will be used to fill in guest info structure. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 1 + hw/misc/pvpanic.c| 13 - 2 files changed, 13 insertions(+), 1

[Qemu-devel] [PATCH v7 16/27] loader: use file path size from fw_cfg.h

2013-10-01 Thread Michael S. Tsirkin
Avoid a bit of code duplication, make max file path constant reusable. Suggested-by: Laszlo Ersek Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/nvram/fw_cfg.h | 4 +++- hw/core/loader.c | 2 +- 2 files changed, 4 insertions(+), 2

[Qemu-devel] [PATCH v7 10/27] q35: use macro for MCFG property name

2013-10-01 Thread Michael S. Tsirkin
Useful to make it accessible through QOM. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie_host.h | 2 ++ hw/pci-host/q35.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/hw/pci/pcie_host.h b/i

[Qemu-devel] [PATCH v7 20/27] acpi/piix: add macros for acpi property names

2013-10-01 Thread Michael S. Tsirkin
Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 10 ++ hw/acpi/piix4.c | 6 +++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 7a343f8..f966cef 10

[Qemu-devel] [PATCH v7 06/27] fw_cfg: interface to trigger callback on read

2013-10-01 Thread Michael S. Tsirkin
Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/nvram/fw_cfg.h | 4 hw/nvram/fw_cfg.c | 33 - 2 files changed, 32 insertions(+), 5 deletions(-) diff --git a/include/hw/nvram/fw_cfg.h b/include/hw

[Qemu-devel] [PATCH v7 11/27] q35: expose mmcfg size as a property

2013-10-01 Thread Michael S. Tsirkin
Address is already exposed, expose size for symmetry. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pcie_host.h | 1 + hw/pci-host/q35.c | 14 ++ 2 files changed, 15 insertions(+) diff --git a/include/hw/pci/pcie

[Qemu-devel] [PATCH v7 03/27] qom: cleanup struct Error references

2013-10-01 Thread Michael S. Tsirkin
now that a typedef for struct Error is available, use it in qom/object.h to match coding style rules. Reviewed-by: Paolo Bonzini Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/qom/object.h | 51 +---

[Qemu-devel] [PATCH v7 07/27] loader: support for unmapped ROM blobs

2013-10-01 Thread Michael S. Tsirkin
Support ROM blobs not mapped into guest memory: same as ROM files really but use caller's buffer. Support incoking callback on access and return memory pointer making it easier for caller to update memory if necessary. Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Reviewed-by: Laszlo Erse

[Qemu-devel] [PATCH v7 04/27] qom: add pointer to int property helpers

2013-10-01 Thread Michael S. Tsirkin
Make it easy to add read-only helpers for simple integer properties in memory. Reviewed-by: Paolo Bonzini Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/qom/object.h | 21 ++ qom/object.c | 60 +

[Qemu-devel] [PATCH v7 02/27] qom: pull in qemu/typedefs

2013-10-01 Thread Michael S. Tsirkin
As usual so we can use typedefs without header dependencies. Reviewed-by: Paolo Bonzini Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/qom/object.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/qom/object.h b/include/qom/object.

[Qemu-devel] [PATCH v7 01/27] qemu: add Error to typedefs

2013-10-01 Thread Michael S. Tsirkin
This is so qom headers can use it without pulling in extra headers. Reviewed-by: Paolo Bonzini Reviewed-by: Gerd Hoffmann Tested-by: Gerd Hoffmann Signed-off-by: Michael S. Tsirkin --- include/qapi/error.h| 6 -- include/qemu/typedefs.h | 1 + 2 files changed, 5 insertions(+), 2 delet

[Qemu-devel] [PATCH v7 00/27] qemu: generate acpi tables for the guest

2013-10-01 Thread Michael S. Tsirkin
This code can also be found here: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi While this patch still uses info not available in QOM, I think it's reasonable to merge it and then refactor as QOM properties cover more ground. In particular, merging this patchset blocks other projects so

Re: [Qemu-devel] Attaching PCI devices to the PCIe root complex

2013-10-01 Thread Michael S. Tsirkin
On Tue, Sep 24, 2013 at 06:01:02AM -0400, Laine Stump wrote: > When I added support for the Q35-based machinetypes to libvirt, I > specifically prohibited attaching any PCI devices (with the exception of > graphics controllers) to the PCIe root complex, and had planned to > prevent attaching them t

[Qemu-devel] [PATCH] qemu-ga: execute fsfreeze-freeze in reverse order of mounts

2013-10-01 Thread Tomoki Sekiyama
Currently, fsfreeze-freeze may cause deadlock if a guest has loopback mounts of image files in its disk; e.g.: # mount | grep ^/ /dev/vda1 / type ext4 (rw,noatime,seclabel,data=ordered) /tmp/disk.img on /mnt type ext4 (rw,relatime,seclabel) To avoid the deadlock, this freeze filesyste

Re: [Qemu-devel] [Bug 1233225] Re: mips/mipsel linux user float division problem

2013-10-01 Thread Stefan Weil
Am 01.10.2013 20:14, schrieb Stefan Weil: > Here is the related commit found by git bisect: > > $ git bisect bad > 68473f15d4c9948986618f63828825beafcaf1cf is the first bad commit > commit 68473f15d4c9948986618f63828825beafcaf1cf > Author: Richard Henderson > Date: Sun Feb 10 10:30:46 2013 -0800

Re: [Qemu-devel] [Build bug] Problem checking out submodules

2013-10-01 Thread Lucas Meneghel Rodrigues
On 10/01/2013 04:52 PM, Alex Bennée wrote: l...@redhat.com writes: On 10/01/2013 04:37 PM, Alex Bennée wrote: l...@redhat.com writes: Hello: In the daily qemu.git autotest run, I started to see the following problem while checking out the qemu.git tree and checking out the submodules: O

Re: [Qemu-devel] [PULL 00/01] seccomp: trivial changes

2013-10-01 Thread Paul Moore
On Tuesday, September 24, 2013 03:30:57 PM Eduardo Otubo wrote: > Anthony, > > The following changes since commit f828a4c8faa118e0ebab3e353ac6840f3b2a0318: > > Merge remote-tracking branch 'stefanha/tracing' into staging (2013-09-23 > 11:53:22 -0500) > > are available in the git repository at:

Re: [Qemu-devel] [Build bug] Problem checking out submodules

2013-10-01 Thread Alex Bennée
l...@redhat.com writes: > On 10/01/2013 04:37 PM, Alex Bennée wrote: >> >> l...@redhat.com writes: >> >>> Hello: >>> >>> In the daily qemu.git autotest run, I started to see the following >>> problem while checking out the qemu.git tree and checking out the >>> submodules: Oh I just noticed that

Re: [Qemu-devel] [Build bug] Problem checking out submodules

2013-10-01 Thread Lucas Meneghel Rodrigues
On 10/01/2013 04:37 PM, Alex Bennée wrote: l...@redhat.com writes: Hello: In the daily qemu.git autotest run, I started to see the following problem while checking out the qemu.git tree and checking out the submodules: $ git submodule update fatal: reference is not a tree: ece025f5980bae88

Re: [Qemu-devel] [Build bug] Problem checking out submodules

2013-10-01 Thread Alex Bennée
l...@redhat.com writes: > Hello: > > In the daily qemu.git autotest run, I started to see the following > problem while checking out the qemu.git tree and checking out the > submodules: > >> $ git submodule update >> >> fatal: reference is not a tree: ece025f5980bae88fa677bc9c0d24d2e580e205d >

[Qemu-devel] [Bug 1233225] Re: mips/mipsel linux user float division problem

2013-10-01 Thread Stefan Weil
Here is the related commit found by git bisect: $ git bisect bad 68473f15d4c9948986618f63828825beafcaf1cf is the first bad commit commit 68473f15d4c9948986618f63828825beafcaf1cf Author: Richard Henderson Date: Sun Feb 10 10:30:46 2013 -0800 mips64-linux-user: Enable 64-bit address mode and

[Qemu-devel] [Build bug] Problem checking out submodules

2013-10-01 Thread Lucas Meneghel Rodrigues
Hello: In the daily qemu.git autotest run, I started to see the following problem while checking out the qemu.git tree and checking out the submodules: $ git submodule update Submodule path 'dtc': checked out 'bc895d6d09695d05ceb8b52486ffe861d6cfbdde' Submodule path 'pixman': checked out '97

[Qemu-devel] [Bug 1233225] Re: mips/mipsel linux user float division problem

2013-10-01 Thread Stefan Weil
I can confirm that something is strange with MIPS Linux user emulation, but get a different result (which is also wrong): # Your test code is in file divtest.c. $ mipsel-linux-gnu-gcc-4.7 -g -static divtest.c $ mipsel-linux-user/qemu-mipsel a.out 0.00 Some more tests: printf("%f\n", a * 1

Re: [Qemu-devel] [PATCH v4 3/7] mirror: don't close target

2013-10-01 Thread Eric Blake
On 09/30/2013 06:02 AM, Fam Zheng wrote: > Let reference count manage target and don't call bdrv_close here. > > Signed-off-by: Fam Zheng > --- > block/mirror.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Eric Blake > > diff --git a/block/mirror.c b/block/mirror.c > index fdc7fa8..af

[Qemu-devel] [PATCH v2 9/9] target-s390: Force TCG to report Z9-109

2013-10-01 Thread Richard Henderson
Fedora 19 targets Z9-109 as the minimum supported cpu, and the kernel will exit very early in the boot process if facilities do not match. This is a hack until we properly implement distinct qom cpu types. Signed-off-by: Richard Henderson --- target-s390x/cpu.c | 10 ++ 1 file changed,

[Qemu-devel] [PATCH v2 7/9] target-s390: Implement LURA, LURAG, STURG

2013-10-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-s390x/helper.h | 3 +++ target-s390x/insn-data.def | 4 target-s390x/mem_helper.c | 16 target-s390x/translate.c | 26 ++ 4 files changed, 49 insertions(+) diff --git a/target-s390x/helper.h b/tar

[Qemu-devel] [PATCH v2 8/9] target-s390: Implement ECAG

2013-10-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-s390x/insn-data.def | 2 ++ target-s390x/translate.c | 7 +++ 2 files changed, 9 insertions(+) diff --git a/target-s390x/insn-data.def b/target-s390x/insn-data.def index a405f64..d3bc5b1 100644 --- a/target-s390x/insn-data.def +++ b/target-s390x/

[Qemu-devel] [PATCH v2 4/9] target-s390: Implement EPSW

2013-10-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-s390x/insn-data.def | 2 ++ target-s390x/translate.c | 18 ++ 2 files changed, 20 insertions(+) diff --git a/target-s390x/insn-data.def b/target-s390x/insn-data.def index c528eb4..48850ff 100644 --- a/target-s390x/insn-data.def +++ b

[Qemu-devel] [PATCH v2 6/9] target-s390: Fix STURA

2013-10-01 Thread Richard Henderson
We were storing 16 bits instead of 32. Signed-off-by: Richard Henderson --- target-s390x/mem_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-s390x/mem_helper.c b/target-s390x/mem_helper.c index 1422ae9..408836c 100644 --- a/target-s390x/mem_helper.c +++ b/targ

[Qemu-devel] [PATCH v2 5/9] target-s390: Fix STIDP

2013-10-01 Thread Richard Henderson
The implementation had been incomplete, as we did not store the machine type. Note that the machine_type member is still unset during initialization, so this has no effect yet. Signed-off-by: Richard Henderson --- target-s390x/cpu.h | 4 +++- target-s390x/translate.c | 6 ++ 2 files c

[Qemu-devel] [PATCH v2 3/9] target-s390: Implement SAM31 and SAM64

2013-10-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-s390x/insn-data.def | 8 target-s390x/translate.c | 26 ++ 2 files changed, 30 insertions(+), 4 deletions(-) diff --git a/target-s390x/insn-data.def b/target-s390x/insn-data.def index 4b462d4..c528eb4 100644 --- a/ta

[Qemu-devel] [PATCH v2 1/9] target-s390: Add facilities data to env

2013-10-01 Thread Richard Henderson
Name the facilities bits, collect the set of bits for tcg and the various real processor revisions. Update the set of facilities reported for TCG. Validate the insns we execute against the facilities enabled. Report the correct facilities via STFL. Signed-off-by: Richard Henderson --- target-s

[Qemu-devel] [PATCH v2 2/9] target-s390: Implement STFLE

2013-10-01 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-s390x/helper.h | 1 + target-s390x/insn-data.def | 2 ++ target-s390x/misc_helper.c | 13 + target-s390x/translate.c | 8 4 files changed, 24 insertions(+) diff --git a/target-s390x/helper.h b/target-s390x/helper.h index

[Qemu-devel] [PATCH v2 0/9] target-s390 tcg improvements

2013-10-01 Thread Richard Henderson
Changes v1-v2: * Squashed patches 1, 2, 4. The feedback from patch 1 called for a re-ordering of the patch set to better deal with STFL, but I could not find an ordering that worked well. I think this is probably just as clear as 3 separate patches. * STFL and STIDP implementatio

Re: [Qemu-devel] [PATCH v4 4/7] mirror: Add commit_job_type to perform commit with mirror code

2013-10-01 Thread Eric Blake
On 09/30/2013 06:02 AM, Fam Zheng wrote: > Commit active layer will be implemented in block/mirror.c, prepare a new > job type to let it have a right type name for the user. > > Signed-off-by: Fam Zheng > --- > block/mirror.c| 12 +++- > blockdev.c| 2 +- > i

Re: [Qemu-devel] [PATCH v2 17/17] blockdev: blockdev_init() error conversion

2013-10-01 Thread Eric Blake
On 10/01/2013 07:20 AM, Kevin Wolf wrote: > This gives us meaningful error messages for the blockdev-add QMP > command. > > Signed-off-by: Kevin Wolf > Reviewed-by: Max Reitz > --- > blockdev.c | 59 +-- > 1 file changed, 33 insertions(+),

Re: [Qemu-devel] [PATCH v2 16/17] blockdev: Don't disable COR automatically with blockdev-add

2013-10-01 Thread Eric Blake
On 10/01/2013 07:20 AM, Kevin Wolf wrote: > If a read-only device is configured with copy-on-read=on, the old code > only prints a warning and automatically disables copy on read. Make it > a real error for blockdev-add. > > Signed-off-by: Kevin Wolf > Reviewed-by: Max Reitz > --- > block.c

Re: [Qemu-devel] [PATCH v2 15/17] blockdev: Remove 'media' parameter from blockdev_init()

2013-10-01 Thread Eric Blake
On 10/01/2013 07:20 AM, Kevin Wolf wrote: > The remaining users shouldn't be there with blockdev-add and are easy to > move to drive_init(). > > Bonus bug fix: As a side effect, CD-ROM drives can now use block drivers > on the read-only whitelist without explicitly specifying read-only=on, > even

Re: [Qemu-devel] [PATCH v2 14/17] qemu-iotests: Check autodel behaviour for device_del

2013-10-01 Thread Eric Blake
On 10/01/2013 07:20 AM, Kevin Wolf wrote: > Block devices creates with -drive and drive_add should automatically > disappear if the guest device is unplugged. blockdev-add ones shouldn't. > > Signed-off-by: Kevin Wolf > Reviewed-by: Max Reitz > --- > tests/qemu-iotests/064 | 133 > ++

Re: [Qemu-devel] [PATCH v2 13/17] blockdev: Remove IF_* check for read-only blockdev_init

2013-10-01 Thread Eric Blake
On 10/01/2013 07:20 AM, Kevin Wolf wrote: > IF_NONE allows read-only, which makes forbidding it in this place > for other types pretty much pointless. > > Instead, make sure that all devices for which the check would have > errored out check in their init function that they don't get a read-only >

Re: [Qemu-devel] [PATCH v5 0/5] Do not set SO_REUSEADDR on Windows

2013-10-01 Thread Stefan Weil
Am 01.10.2013 10:11, schrieb Sebastian Ottlik: > On 23.09.2013 12:33, Sebastian Ottlik wrote: >> On 18.09.2013 18:58, Stefan Weil wrote: >>> If failures only happen when something is very wrong (like an invalid >>> socket id), >>> an assertion might be better, and we could remove the 'silent' >>> p

Re: [Qemu-devel] [Bug 599958] Re: Timedrift problems with Win7: hpet missing time drift fixups

2013-10-01 Thread Gleb Natapov
On Tue, Oct 01, 2013 at 11:36:39AM -0500, Ben "Root" Anderson wrote: > Agh, I forgot reply all. > I have to re reply now :) > Seems like something that should be changed, no? It would've saved me > a lot of headache if there was a switch e.g. > -optimize-for=[linux,winxp, > win7,etc] that changed

Re: [Qemu-devel] [PATCH] coroutine: add ./configure --disable-coroutine-pool

2013-10-01 Thread Stefan Weil
Am 01.10.2013 09:29, schrieb Gabriel Kerneis: > On Tue, Oct 01, 2013 at 07:51:24AM +0200, Stefan Weil wrote: >> $ wine i386-softmmu/qemu-system-i386 -L pc-bios -cdrom /var/tmp/mini.iso >> -sdl # or -vnc :1 >> >> => Assertion in qemu-coroutine-lock.c:99. > Could you please provide the backtrace for

Re: [Qemu-devel] [Bug 599958] Re: Timedrift problems with Win7: hpet missing time drift fixups

2013-10-01 Thread Ben "Root" Anderson
Agh, I forgot reply all. Seems like something that should be changed, no? It would've saved me a lot of headache if there was a switch e.g. -optimize-for=[linux,winxp, win7,etc] that changed the defaults to be most accomodating to the specified OS as a guest. On Tue, Oct 1, 2013 at 11:33 AM, Gleb

Re: [Qemu-devel] [PATCH v2 11/17] blockdev: Move bus/unit/index processing to drive_init

2013-10-01 Thread Eric Blake
On 10/01/2013 07:20 AM, Kevin Wolf wrote: > This requires moving the automatic ID generation at the same time, so > let's do that as well. > > Signed-off-by: Kevin Wolf > Reviewed-by: Max Reitz > --- > blockdev.c | 157 > - > 1 file c

Re: [Qemu-devel] [PATCH v2 12/17] blockdev: Move virtio-blk device creation to drive_init

2013-10-01 Thread Eric Blake
On 10/01/2013 07:20 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > Reviewed-by: Max Reitz > --- > blockdev.c | 54 +++--- > 1 file changed, 27 insertions(+), 27 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-9

Re: [Qemu-devel] [Bug 599958] Re: Timedrift problems with Win7: hpet missing time drift fixups

2013-10-01 Thread Gleb Natapov
On Tue, Oct 01, 2013 at 11:23:07AM -0500, Ben "Root" Anderson wrote: > Fair enough in itself, but if HPET is known to have problems with > arguably the most popular OS family to use as a guest, why is it > enabled by default? > Arguably :) But QEMU defaults are arguably far from been optimal for a

Re: [Qemu-devel] [PATCH] hw/9pfs: Fix errno value for xattr functions

2013-10-01 Thread Aneesh Kumar K.V
"Daniel P. Berrange" writes: > From: "Daniel P. Berrange" > > If there is no operation driver for the xattr type the > functions return '-1' and set errno to '-EOPNOTSUPP'. > When the calling code sets 'ret = -errno' this turns > into a large positive number. > > In Linux 3.11, the kernel has sw

Re: [Qemu-devel] [PULL 0/1] seabios update to 1.7.3.2

2013-10-01 Thread Alex Bennée
kra...@redhat.com writes: > Hi, > > New seabios release is out, here comes the update for qemu. > > please pull, > Gerd This has broken qemu/master as the sub-project commit: ece025f5980bae88fa677bc9c0d24d2e580e205d Doesn't exist in the qemu mirror of seabios in .gitmodules. I discovered t

Re: [Qemu-devel] [Bug 599958] Re: Timedrift problems with Win7: hpet missing time drift fixups

2013-10-01 Thread Ben "Root" Anderson
Fair enough in itself, but if HPET is known to have problems with arguably the most popular OS family to use as a guest, why is it enabled by default? On Tue, Oct 1, 2013 at 10:56 AM, Gleb Natapov wrote: > On Tue, Oct 01, 2013 at 09:34:06AM -, Ben A wrote: >> Apparently this bug's still alive

[Qemu-devel] [PATCH -V4 RESEND 3/6] target-ppc: Check for error on address translation in memsave command

2013-10-01 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" When we translate the virtual address to physical check for error. Signed-off-by: Aneesh Kumar K.V --- cpus.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cpus.c b/cpus.c index e566297..52470a6 100644 --- a/cpus.c +++ b/cpus.c @@ -1333,7 +133

[Qemu-devel] [PATCH -V4 RESEND 6/6] target-ppc: dump-guest-memory support

2013-10-01 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" This patch add support for dumping guest memory using dump-guest-memory monitor command. Before patch: (qemu) dump-guest-memory testcrash this feature or command is not currently supported (qemu) After patch: (qemu) dump-guest-memory testcrash (qemu) crash was able t

[Qemu-devel] [PATCH -V4 RESEND 5/6] dump-guest-memory: Check for the correct return value

2013-10-01 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" We should check for error with s->note_size Signed-off-by: Aneesh Kumar K.V --- dump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dump.c b/dump.c index 846155c..80a9116 100644 --- a/dump.c +++ b/dump.c @@ -66,7 +66,7 @@ typedef struct DumpS

[Qemu-devel] [PATCH -V4 RESEND 1/6] target-ppc: Update slb array with correct index values.

2013-10-01 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" Without this, a value of rb=0 and rs=0 results in replacing the 0th index. This can be observed when using gdb remote debugging support. (gdb) x/10i do_fork 0xc0085330 :Cannot access memory at address 0xc0085330 (gdb) This is because when we

[Qemu-devel] [PATCH -V4 RESEND 0/6] target-ppc: Add support for dumping guest memory using qemu gdb server

2013-10-01 Thread Aneesh Kumar K.V
Hi, This patch series implement support for dumping guest memory using qemu gdb server. The last patch also enable qemu monitor command dump-guest-memory With this patch series we can now do (gdb) x/4i htab_call_hpte_insert1 0xc00470d8 <.htab_call_hpte_insert1>:bl 0xc00

[Qemu-devel] [PATCH -V4 RESEND 2/6] target-ppc: Fix page table lookup with kvm enabled

2013-10-01 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" With kvm enabled, we store the hash page table information in the hypervisor. Use ioctl to read the htab contents. Without this we get the below error when trying to read the guest address (gdb) x/10 do_fork 0xc0098660 : Cannot access memory at address 0xc00

[Qemu-devel] [PATCH -V4 RESEND 4/6] target-ppc: Use #define for max slb entries

2013-10-01 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" Instead of opencoding 64 use MAX_SLB_ENTRIES. We don't update the kernel header here. Signed-off-by: Aneesh Kumar K.V --- target-ppc/cpu.h | 3 ++- target-ppc/kvm.c | 4 ++-- target-ppc/machine.c | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --

Re: [Qemu-devel] [PATCH v2 10/17] blockdev: Move parsing of 'boot' option to drive_init

2013-10-01 Thread Eric Blake
On 10/01/2013 07:20 AM, Kevin Wolf wrote: > It's already ignored and only prints a deprecation message. No use in > making it available in new interfaces. > > Signed-off-by: Kevin Wolf > --- > blockdev.c | 21 +++-- > 1 file changed, 11 insertions(+), 10 deletions(-) > Reviewed

Re: [Qemu-devel] [Xen-devel] RESEND [Xen-unstable][Qemu-xen] HVM Guest reading of Expansion ROM from passthroughed PCI device returns data from emulated VGA rom

2013-10-01 Thread Pasi Kärkkäinen
On Tue, Sep 24, 2013 at 11:24:46PM +0200, Sander Eikelenboom wrote: > > > Can you send out the all the logs when using qemu-dm-traditional as well as > > the guest configuration file used by xl ? > > Sure, here is the complete set for qemu-dm-traditional. > I have added some extra printk's (see

Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array

2013-10-01 Thread Fabien Chouteau
On 10/01/2013 05:21 PM, Peter Maydell wrote: > The declaration should go in cpu-qom.h (again, compare > the gdb stuff), and it should be called "arm_monitor_defs", > "ppc_monitor_defs" etc, not arch_monitor_defs. (This > avoids issues if we ever manage to compile more than one > target CPU into a s

Re: [Qemu-devel] [PATCH v2 09/17] blockdev: Moving parsing of geometry options to drive_init

2013-10-01 Thread Eric Blake
On 10/01/2013 07:20 AM, Kevin Wolf wrote: > This moves all of the geometry options (cyls/heads/secs/trans) to > drive_init so that they can only be accessed using legacy functions, but > never with anything blockdev-add related. > > Signed-off-by: Kevin Wolf > --- > blockdev.c | 136 > +

Re: [Qemu-devel] [PATCH V3 5/7] qemu-img: add -L for snapshot in convert

2013-10-01 Thread Paolo Bonzini
Il 26/09/2013 02:16, Wenchao Xia ha scritto: > +c = getopt(argc, argv, "f:O:B:s:hce6o:pS:t:qnL:"); > if (c == -1) { > break; > } > @@ -1183,6 +1184,9 @@ static int img_convert(int argc, char **argv) > case 's': > snapshot_name = optarg; >

Re: [Qemu-devel] [PATCH V3 2/7] qemu-nbd: support internal snapshot export

2013-10-01 Thread Paolo Bonzini
Il 26/09/2013 02:16, Wenchao Xia ha scritto: > Now it is possible to directly export an internal snapshot, which > can be used to probe the snapshot's contents without qemu-img > convert. > > Signed-off-by: Wenchao Xia > --- > block/snapshot.c | 18 ++ > include/block/s

  1   2   3   >