Re: [Qemu-devel] [PATCH 2/2] machine type dependant bios

2013-09-30 Thread Paolo Bonzini
Il 01/10/2013 00:57, Anthony Liguori ha scritto: > On Mon, Sep 30, 2013 at 5:43 PM, Paolo Bonzini > wrote: > > Il 01/10/2013 00:08, Anthony Liguori ha scritto: > > Wouldn't this be logical as a machine option? They way you are > > introducing it makes it i

Re: [Qemu-devel] [PATCH] coroutine: add ./configure --disable-coroutine-pool

2013-09-30 Thread Stefan Weil
Am 30.09.2013 11:06, schrieb Stefan Hajnoczi: > On Fri, Sep 27, 2013 at 06:49:18PM +0200, Stefan Weil wrote: >> Am 27.09.2013 11:11, schrieb Stefan Hajnoczi: >>> On Fri, Sep 27, 2013 at 07:20:21AM +0200, Stefan Weil wrote: Am 11.09.2013 16:42, schrieb Stefan Hajnoczi: > The 'gthread' corou

Re: [Qemu-devel] Virtio Polling Mode

2013-09-30 Thread Hu Yaohui
Hi Anthony, Thanks for your reply! What I am looking for is that whether there is one mechanism that when virtio-blk host side finished the requests. Instead of using irq to notify the guest. Is there any other method to notify the guest (guest_notifer)? Thanks for your time! Best Wishes, Yaohui H

Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array

2013-09-30 Thread Richard Henderson
On 09/30/2013 08:57 AM, Fabien Chouteau wrote: > +extern const MonitorDef arch_monitor_defs[]; This is supplied by target-foo/monitor.c, right? Why in the world is it declared in generic code? Especially if it's only ever accessed via the cpu->monitor_defs member? r~

Re: [Qemu-devel] [PATCH -V4 1/4] target-ppc: Update slb array with correct index values.

2013-09-30 Thread Aneesh Kumar K.V
Alexander Graf writes: > On 09/25/2013 05:41 PM, Aneesh Kumar K.V wrote: >> Hi Alex, >> >> Any update on this ? > > The patch itself never made it to the qemu-devel mailing list which I > pull things off of (through patchworks). Please resend. > > My mistake, my alias in .gitconfig had the erro

Re: [Qemu-devel] [PATCH -V4 2/4] target-ppc: Fix page table lookup with kvm enabled

2013-09-30 Thread Aneesh Kumar K.V
Alexander Graf writes: > On 09/05/2013 10:16 AM, Aneesh Kumar K.V wrote: >> From: "Aneesh Kumar K.V" >> >> With kvm enabled, we store the hash page table information in the hypervisor. >> Use ioctl to read the htab contents. Without this we get the below error when >> trying to read the guest add

Re: [Qemu-devel] [PATCH 4/4] Add ARM registers definitions for Monitor commands

2013-09-30 Thread Peter Maydell
On 1 October 2013 00:57, Fabien Chouteau wrote: > > Signed-off-by: Fabien Chouteau > --- > target-arm/Makefile.objs |2 +- > target-arm/cpu.c |5 + > target-arm/monitor.c | 40 > 3 files changed, 46 insertions(+), 1 deletion(-) >

Re: [Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array

2013-09-30 Thread Peter Maydell
On 1 October 2013 00:57, Fabien Chouteau wrote: > +#define MD_I64 0 > +#define MD_I32 1 > -#define MD_TLONG 0 > -#define MD_I32 1 > -{ "eax", offsetof(CPUX86State, regs[0]) }, > -{ "ecx", offsetof(CPUX86State, regs[1]) }, > +{ "eax", offsetof(CPUX86State, regs[0]) }, > +{ "ec

Re: [Qemu-devel] [PATCH v3 02/11] AARCH64: add a57core

2013-09-30 Thread Peter Maydell
On 1 October 2013 00:53, Mian M. Hamayun wrote: > Also there are multiple patches under review for providing the -cpu host > or equivalent support in QEMU and/or KVM such as the one posted by Peter > Maydell and another CPU=Host patch from Anup Patel. Yeah, I agree it's a bit up in the air at the

Re: [Qemu-devel] [lttng-dev] [PATCH] trace: drop LTTng Userspace Tracer backend

2013-09-30 Thread Mohamad Gebai
Hi Stefan, Sorry for the delay but I rewrote all the patches to make the merge as non-intrusive as possible, which wasn't the case in the patches I wrote for my personal use. I submitted them in a different thread on the mailing list. Mohamad On 13-09-26 04:01 AM, Stefan Hajnoczi wrote: On We

Re: [Qemu-devel] [PATCH 2/2] machine type dependant bios

2013-09-30 Thread Anthony Liguori
On Mon, Sep 30, 2013 at 5:43 PM, Paolo Bonzini wrote: > Il 01/10/2013 00:08, Anthony Liguori ha scritto: > > Wouldn't this be logical as a machine option? They way you are > > introducing it makes it impossible to control with -global. > > You still have -bios. > Which cannot be versioned. >

Re: [Qemu-devel] [PATCH 2/2] machine type dependant bios

2013-09-30 Thread Paolo Bonzini
Il 01/10/2013 00:08, Anthony Liguori ha scritto: > Wouldn't this be logical as a machine option? They way you are > introducing it makes it impossible to control with -global. You still have -bios. We should introduce a machine object and convert unknown "-machine" options to -global on that obj

Re: [Qemu-devel] [PATCH V3 7/7] qemu-iotests: add test for qcow2 snapshot

2013-09-30 Thread Eric Blake
On 09/08/2013 08:58 PM, Wenchao Xia wrote: > This test will focus on the low level procedure of qcow2 snapshot > operations, now it covers only the create operation. Overlap error > paths are not checked since no good way to trigger those errors. > > Signed-off-by: Wenchao Xia > --- > tests/qemu

[Qemu-devel] Debugging QEMU Exits

2013-09-30 Thread Thilak Raj Surendrababu
Hi All, I am new to qemu, I am trying to understand virtio_net. I am seeing a lot of KVM_EXITS due to IO_INSTRUCTION, when I transmit packets from the guest. Can you please let me know on how to understand instruction in the guest, which leads to the KVM exit. >From the /sys/kernel/debug/tracing/

Re: [Qemu-devel] [PATCH v2 2/4] Curling: cmdline interface.

2013-09-30 Thread Eric Blake
On 09/29/2013 02:14 PM, Jules Wang wrote: > Add an option '-f' to migration cmdline. > Indicating whether to enable fault tolerant or not. > > Signed-off-by: Jules Wang > --- > .help = "migrate to URI (using -d to not wait for completion)" > "\n\t\t\t -b for mig

Re: [Qemu-devel] [PATCH V3 6/7] qcow2: print message for error path in snapshot creation

2013-09-30 Thread Eric Blake
On 09/08/2013 08:58 PM, Wenchao Xia wrote: > The message will be print out with a macro enabled, which can s/print/printed/ > be used to check which error path is taken. > > Signed-off-by: Wenchao Xia > --- > block/qcow2-snapshot.c | 46 ++ > 1 fil

Re: [Qemu-devel] [PATCH 2/2] machine type dependant bios

2013-09-30 Thread Anthony Liguori
Wouldn't this be logical as a machine option? They way you are introducing it makes it impossible to control with -global. Regards, Anthony Liguori On Mon, Sep 30, 2013 at 5:46 AM, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > hw/i386/pc_piix.c| 1 + > hw/i386/pc_q35.c

Re: [Qemu-devel] Virtio Polling Mode

2013-09-30 Thread Anthony Liguori
On Mon, Sep 30, 2013 at 2:00 PM, Hu Yaohui wrote: > Hi Anthony, > Thanks for your reply! Could you please be more specific about this? Which > flag, > You should read the virtio spec. It's all clearly spelled out there. > where can I find the research projects and papers that has virtio > ,es

[Qemu-devel] [Bug 1233225] [NEW] mips/mipsel linux user float division problem

2013-09-30 Thread Johannes Schauer
Public bug reported: Hi, I tested the following with the qemu git HEAD as of 2013-09-30 on Debian stable and testing. My host runs amd64 but I also tried this out inside a i386 chroot with the same result. The problem occurs for mips and mipsel. Given the following program: #include int main(in

[Qemu-devel] [RFC PATCH 2/3] Modified the tracetool framework for LTTng 2.x.

2013-09-30 Thread Mohamad Gebai
* A new format is required to generate definitions for ust tracepoints. Files ust_events_h.py and ust_events_c.py define common macros, while new function ust_events_h in events.py does the actual definition of each tracepoint. * ust.py generates the new interface for calling userspace tracep

Re: [Qemu-devel] [PATCH V3 5/7] qcow2: use debug events for snapshot

2013-09-30 Thread Eric Blake
On 09/08/2013 08:58 PM, Wenchao Xia wrote: > For those error paths which can't be triggered by other debug event, > use snapshot debug events. > > Signed-off-by: Wenchao Xia > --- > block/qcow2-snapshot.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > Reviewed-by: Eric Blake

Re: [Qemu-devel] [PATCH v4 1/7] block: add bdrv_common_ancestor()

2013-09-30 Thread Eric Blake
On 09/30/2013 06:02 AM, Fam Zheng wrote: > This function finds the common ancestor in backing chain of two BDSes. > If there's no common ancestor, NULL is returned. > > Signed-off-by: Fam Zheng > --- > block.c | 15 +++ > include/block/block.h | 2 ++ > 2 files changed

Re: [Qemu-devel] [PATCH V3 4/7] blkdebug: add debug events for snapshot

2013-09-30 Thread Eric Blake
On 09/08/2013 08:57 PM, Wenchao Xia wrote: > Some code in qcow2-snapshot.c directly access bs->file, so in those > points error can't be injected by other events. Since the code in > qcow2-snapshot.c is qcow2's internal detail similar as L1 table, > so add some debug events. > > Signed-off-by: Wen

[Qemu-devel] [BUG/PATCH] Fix i386 SSE status flag corruption

2013-09-30 Thread Richard Purdie
This is a combination of bug report and patch. I'm not sure if you'll want to fix it like this but it illustrates the problem and should be easy to fix based on this. When we restore the mxcsr register with FXRSTOR, we need to update the various SSE status flags in CPUX86State by calling updat

[Qemu-devel] [RFC PATCH 0/3] Fix UST backend for LTTng 2.x

2013-09-30 Thread Mohamad Gebai
These patches fix the UST backend which got broken by LTTng 2.x. An interesting new feature in LTTng 2.x is that tracepoints now need to belong to a provider. A provider is a way to group tracepoints in a logical way, for instance tracepoints that belong to a specific file or subsystem. This would

[Qemu-devel] [RFC PATCH 3/3] Adapt Makefiles to the new LTTng ust interface.

2013-09-30 Thread Mohamad Gebai
Add generation of new files for LTTng ust. Signed-off-by: Mohamad Gebai --- Makefile|5 + trace/Makefile.objs | 29 +++-- 2 files changed, 32 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 60fb87e..0c797c5 100644 --- a/Makefile

[Qemu-devel] [RFC PATCH 1/3] Fix configure script for LTTng 2.x

2013-09-30 Thread Mohamad Gebai
Signed-off-by: Mohamad Gebai --- configure |9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 05e16da..b3c9b80 100755 --- a/configure +++ b/configure @@ -3283,15 +3283,14 @@ fi # For 'ust' backend, test if ust headers are present if test

Re: [Qemu-devel] [PATCH V3 3/7] qcow2: cancel the modification on fail in qcow2_snapshot_create()

2013-09-30 Thread Eric Blake
On 09/08/2013 08:57 PM, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > block/qcow2-snapshot.c | 20 > 1 files changed, 16 insertions(+), 4 deletions(-) > > > +restore_refcount: > +if (qcow2_update_snapshot_refcount(bs, s->l1_table_offset, s->l1_size, > -1)

Re: [Qemu-devel] [PATCH V3 2/7] qcow2: free allocated cluster on fail in qcow2_write_snapshots()

2013-09-30 Thread Eric Blake
On 09/08/2013 08:57 PM, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > block/qcow2-snapshot.c |7 +-- > 1 files changed, 5 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.

[Qemu-devel] [PATCH] qemu-char: Fix potential out of bounds access to local arrays

2013-09-30 Thread Stefan Weil
Latest gcc-4.8 supports a new option -fsanitize=address which activates an AddressSanitizer. This AddressSanitizer stops the QEMU system emulation very early because two character arrays of size 8 are potentially written with 9 bytes. Commit 6ea314d91439741e95772dfbab98b4135e04bebb added the code.

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix compiler warning ('caps' may be used uninitialized)

2013-09-30 Thread Stefan Weil
Am 30.09.2013 11:59, schrieb Markus Armbruster: > Stefan Weil writes: >> Am 29.09.2013 22:13, schrieb Michael Tokarev: >>> 29.09.2013 19:41, Stefan Weil wrote: The QEMU buildbot default_i386_debian_6_0 shows this warning: CCmigration.o migration.c: In function 'qmp_query

Re: [Qemu-devel] [PATCH 07/10] target-s390: Fix STIDP

2013-09-30 Thread Richard Henderson
On 09/30/2013 11:13 AM, Alexander Graf wrote: >> -int cpu_num; >> +union { >> +uint64_t cpuid; >> +struct { >> +#ifdef HOST_WORDS_BIGENDIAN >> +uint32_t cpu_num; >> +uint32_t machine_type; >> +#else >> +uint32_t machine_type; >> +

Re: [Qemu-devel] [PATCH 01/10] target-s390: Move facilities bits to env

2013-09-30 Thread Richard Henderson
On 09/30/2013 11:03 AM, Alexander Graf wrote: > On 09/23/2013 04:04 PM, Richard Henderson wrote: >> Rather than simply hard-coding them in STFL instruction. >> >> Signed-off-by: Richard Henderson >> --- >> target-s390x/cpu.c | 3 +++ >> target-s390x/cpu.h | 1 + >> target-s390x/tr

Re: [Qemu-devel] Virtio Polling Mode

2013-09-30 Thread Hu Yaohui
Hi Jason, Thanks for your reply! I am more concerned with polling mode about virtio-blk right now. Later I will focus on polling mode on virtio-net. I don't know whether the polling mode is already existed for virtio-blk or we should implement it by ourselves if we need this feature. Thanks for you

Re: [Qemu-devel] Virtio Polling Mode

2013-09-30 Thread Hu Yaohui
Hi Anthony, Thanks for your reply! Could you please be more specific about this? Which flag, where can I find the research projects and papers that has virtio ,especiall virtio-blk, working in polling mode. Thanks for your time! Best Wishes, Yaohui Hu On Sat, Sep 28, 2013 at 8:54 AM, Anthony Lig

Re: [Qemu-devel] [PATCH 0/9] target-s390 tcg improvements

2013-09-30 Thread Alexander Graf
On 09/23/2013 04:04 PM, Richard Henderson wrote: With this patch set we can boot the fedora 19 kernel, and make it all the way to /bin/init. At which point the process either hangs or crashes; in either case the kernel winds up with no runnable processes and spends its time in the idle loop. Th

Re: [Qemu-devel] [PATCH 07/10] target-s390: Fix STIDP

2013-09-30 Thread Alexander Graf
On 09/23/2013 04:04 PM, Richard Henderson wrote: The implementation had been incomplete, as we did not store the machine type. Signed-off-by: Richard Henderson --- target-s390x/cpu.c | 2 ++ target-s390x/cpu.h | 14 +- target-s390x/translate.c | 2 +- 3 files chang

Re: [Qemu-devel] [PATCH v3 02/11] AARCH64: add a57core

2013-09-30 Thread Andreas Färber
Am 30.09.2013 17:53, schrieb Mian M. Hamayun: > On 28/09/2013 02:16, Peter Maydell wrote: >> On 28 September 2013 00:53, Andreas Färber wrote: >>> Am 27.09.2013 12:10, schrieb Mian M. Hamayun: From: John Rigby Just an copy of a15 with a57 substituting a15 for now. >>> I had previou

Re: [Qemu-devel] [PATCH 01/10] target-s390: Move facilities bits to env

2013-09-30 Thread Alexander Graf
On 09/23/2013 04:04 PM, Richard Henderson wrote: Rather than simply hard-coding them in STFL instruction. Signed-off-by: Richard Henderson --- target-s390x/cpu.c | 3 +++ target-s390x/cpu.h | 1 + target-s390x/translate.c | 10 +- 3 files changed, 9 insertions(+), 5 de

Re: [Qemu-devel] [PATCH v2 1/4] target-ppc: Fill in OpenFirmware names for some PowerPCCPU families

2013-09-30 Thread Alexander Graf
On 09/25/2013 11:01 AM, Alexey Kardashevskiy wrote: On 09/17/2013 12:16 AM, Alexey Kardashevskiy wrote: On 09/10/2013 02:15 PM, Alexey Kardashevskiy wrote: On 08/16/2013 08:35 AM, Andreas Färber wrote: Set the expected values for POWER7, POWER7+, POWER8 and POWER5+. Note that POWER5+ and POWER

Re: [Qemu-devel] [PATCH] target-ppc: dump-guest-memory support

2013-09-30 Thread Alexander Graf
On 09/25/2013 05:40 PM, Aneesh Kumar K.V wrote: Hi Alex, Any update on this ? Sent to qemu-de...@nongnu.og instead of qemu-devel@nongnu.org. I can't (and won't) apply patches that didn't land on qemu-devel@nongnu.org. The patch itself looks reasonable to me though :). Alex

Re: [Qemu-devel] [PATCH -V4 2/4] target-ppc: Fix page table lookup with kvm enabled

2013-09-30 Thread Alexander Graf
On 09/05/2013 10:16 AM, Aneesh Kumar K.V wrote: From: "Aneesh Kumar K.V" With kvm enabled, we store the hash page table information in the hypervisor. Use ioctl to read the htab contents. Without this we get the below error when trying to read the guest address (gdb) x/10 do_fork 0xc000

Re: [Qemu-devel] [PATCH -V4 2/4] target-ppc: Fix page table lookup with kvm enabled

2013-09-30 Thread Alexander Graf
On 09/05/2013 10:16 AM, Aneesh Kumar K.V wrote: From: "Aneesh Kumar K.V" With kvm enabled, we store the hash page table information in the hypervisor. Use ioctl to read the htab contents. Without this we get the below error when trying to read the guest address (gdb) x/10 do_fork 0xc000

Re: [Qemu-devel] [PATCH] qcow2: Switch L1 table in a single sequence

2013-09-30 Thread Eric Blake
On 09/30/2013 09:57 AM, Max Reitz wrote: > Switching the L1 table in memory should be an atomic operation, as far > as possible. Calling qcow2_free_clusters on the old L1 table on disk is > not a good idea when the old L1 table is no longer valid and the address > to the new one hasn't yet been wri

Re: [Qemu-devel] [PATCH V3] block: Add BlockDriver.bdrv_check_ext_snapshot.

2013-09-30 Thread Jeff Cody
On Mon, Sep 30, 2013 at 01:36:55PM +0200, Benoît Canet wrote: > This field is used by blkverify to disable external snapshots creation. > I will also be used by block filters like quorum to disable external snapshots > creation. > > Signed-off-by: Benoit Canet Reviewed-by: Jeff Cody > --- > b

Re: [Qemu-devel] [PATCH -V4 1/4] target-ppc: Update slb array with correct index values.

2013-09-30 Thread Alexander Graf
On 09/25/2013 05:41 PM, Aneesh Kumar K.V wrote: Hi Alex, Any update on this ? The patch itself never made it to the qemu-devel mailing list which I pull things off of (through patchworks). Please resend. Alex -aneesh "Aneesh Kumar K.V" writes: From: "Aneesh Kumar K.V" Without this,

Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs

2013-09-30 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Mon, Sep 30, 2013 at 05:49:26PM +0200, Markus Armbruster wrote: >> Peter Maydell writes: >> >> > On 30 September 2013 23:40, Michael S. Tsirkin wrote: >> >> diff --git a/include/qapi/error.h b/include/qapi/error.h >> >> index 7d4c696..b85e996 100644 >> >> ---

Re: [Qemu-devel] [PATCH v5 00/14] xics: reworks and in-kernel support

2013-09-30 Thread Alexander Graf
On 09/26/2013 08:18 AM, Alexey Kardashevskiy wrote: Yet another try with XICS and XICS-KVM. Thanks, applied to ppc-next. Alex v4->v5: Rebased onto upstream; Put few "reviewed-by: Andreas"; Added IRQFD enablement patches. v3->v4: Addressed multiple comments from Alex; Split out many tiny p

[Qemu-devel] bochs BIOS configuration and initialization

2013-09-30 Thread Min LI
Dear all, I am very interested in QEMU and trying to figure out the boot process of guest VM. According to my understanding about QEMU code, bochs BIOS is loaded into memory by pc_system_firmware_init(…). However, I notice QEMU handles hardware initialization, allocates memory and stores

Re: [Qemu-devel] [PATCH V3 1/7] qcow2: restore nb_snapshots when fail in snapshot creation

2013-09-30 Thread Eric Blake
On 09/08/2013 08:57 PM, Wenchao Xia wrote: > If it is not restored after qcow2_write_snapshots() fail, a core > dump will happen in bdrv_close() since access of invalid pointer. > > Signed-off-by: Wenchao Xia > --- > block/qcow2-snapshot.c |4 +++- > 1 files changed, 3 insertions(+), 1 delet

Re: [Qemu-devel] [PATCH v5 6/6] qemu-iotests: Additional info from qemu-img info

2013-09-30 Thread Eric Blake
On 09/23/2013 06:09 AM, Max Reitz wrote: > Add a test for the additional information now provided by qemu-img info > when used on qcow2 images. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/065 | 72 > ++ > tests/qemu-iotests/065.out | 2

Re: [Qemu-devel] [PATCH v5 5/6] qemu-iotests: Discard specific info in _img_info

2013-09-30 Thread Eric Blake
On 09/23/2013 06:09 AM, Max Reitz wrote: > In _img_info, filter out additional information specific to the image > format provided by qemu-img info, since tests designed for multiple > image formats would produce different outputs for every image format > else. s/else/otherwise/ > > Signed-off-b

Re: [Qemu-devel] [PATCH v5 4/6] qcow2: Add support for ImageInfoSpecific

2013-09-30 Thread Eric Blake
On 09/23/2013 06:09 AM, Max Reitz wrote: > Add a new ImageInfoSpecificQCow2 type as a subtype of ImageInfoSpecific. > This contains the compatibility level as a string and an optional > lazy_refcounts boolean (optional means mandatory for compat >= 1.1 and > not available for compat == 0.10). > >

Re: [Qemu-devel] [PATCH 1/6] kvm: Add KVM_GET_EMULATED_CPUID

2013-09-30 Thread Borislav Petkov
On Mon, Sep 30, 2013 at 01:13:34PM -0300, Eduardo Habkost wrote: > I have added it to my TODO-list. :-) Cool, thanks. Let me know if I can test stuff and help out somehow. > > > > Also, there's another aspect, while we're here: now that QEMU emulates > > MOVBE with TCG too, how do we specify on

Re: [Qemu-devel] [PATCH v5 3/6] block/qapi: Human-readable ImageInfoSpecific dump

2013-09-30 Thread Eric Blake
On 09/23/2013 06:09 AM, Max Reitz wrote: > Add a function for generically dumping the ImageInfoSpecific information > in a human-readable format to block/qapi.c. > > Use this function in bdrv_image_info_dump and qemu-io-cmds.c:info_f to > allow qemu-img info resp. qemu-io -c info to print that for

Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs

2013-09-30 Thread Markus Armbruster
Andreas Färber writes: > Am 30.09.2013 17:50, schrieb Michael S. Tsirkin: >> On Tue, Oct 01, 2013 at 12:10:52AM +0900, Peter Maydell wrote: >>> On 30 September 2013 23:40, Michael S. Tsirkin wrote: diff --git a/include/qapi/error.h b/include/qapi/error.h index 7d4c696..b85e996 100644 >

Re: [Qemu-devel] [PATCH 1/6] kvm: Add KVM_GET_EMULATED_CPUID

2013-09-30 Thread Eduardo Habkost
On Sat, Sep 28, 2013 at 12:49:04PM +0200, Borislav Petkov wrote: > On Fri, Sep 27, 2013 at 11:21:34AM -0300, Eduardo Habkost wrote: > > The problem here is that "requested_features" doesn't include just > > the explicit "+flag" flags, but any flag included in the CPU model > > definition. See the "

Re: [Qemu-devel] [PATCH v5 2/6] block: Add bdrv_get_specific_info

2013-09-30 Thread Eric Blake
On 09/23/2013 06:09 AM, Max Reitz wrote: > Add a function for retrieving an ImageInfoSpecific object from a block > driver. > > Signed-off-by: Max Reitz > --- > block.c | 9 + > block/qapi.c | 3 +++ > include/block/block.h | 1 + > include/block/block_

Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs

2013-09-30 Thread Michael S. Tsirkin
On Mon, Sep 30, 2013 at 05:49:26PM +0200, Markus Armbruster wrote: > Peter Maydell writes: > > > On 30 September 2013 23:40, Michael S. Tsirkin wrote: > >> diff --git a/include/qapi/error.h b/include/qapi/error.h > >> index 7d4c696..b85e996 100644 > >> --- a/include/qapi/error.h > >> +++ b/inclu

Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs

2013-09-30 Thread Michael S. Tsirkin
On Mon, Sep 30, 2013 at 05:55:50PM +0200, Andreas Färber wrote: > Am 30.09.2013 17:50, schrieb Michael S. Tsirkin: > > On Tue, Oct 01, 2013 at 12:10:52AM +0900, Peter Maydell wrote: > >> On 30 September 2013 23:40, Michael S. Tsirkin wrote: > >>> diff --git a/include/qapi/error.h b/include/qapi/er

Re: [Qemu-devel] [PATCH v5 1/6] qapi: Add ImageInfoSpecific type

2013-09-30 Thread Eric Blake
On 09/23/2013 06:09 AM, Max Reitz wrote: > Add a new type ImageInfoSpecific as a union for image format specific > information in ImageInfo. > > Signed-off-by: Max Reitz > --- > qapi-schema.json | 18 +- > 1 file changed, 17 insertions(+), 1 deletion(-) > @@ -238,6 +250,9 @@ >

Re: [Qemu-devel] Attaching PCI devices to the PCIe root complex

2013-09-30 Thread Michael S. Tsirkin
On Mon, Sep 30, 2013 at 06:01:17PM +0200, Gerd Hoffmann wrote: > Hi, > > > Yes but, same as in the initial design, > > it really makes it user's problem. > > > > So we'd have > > virtio-net-pci-conventional > > virtio-net-pci-express > > virtio-net-pci-integrated > > > > > > All this while us

[Qemu-devel] [PATCH 1/4] Fix coding style

2013-09-30 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau --- disas.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/disas.c b/disas.c index 0203ef2..32407de 100644 --- a/disas.c +++ b/disas.c @@ -506,12 +506,13 @@ void monitor_disas(Monitor *mon, CPUArchState *env, return; #endif

[Qemu-devel] [PATCH 0/4] Few minor improvements of monitor disas command (v3)

2013-09-30 Thread Fabien Chouteau
I finaly managed to move the target depend code in 'target-*/'. Fabien Chouteau (4): Fix coding style Improve Monitor disas with symbol lookup Refactoring MonitorDef array Add ARM registers definitions for Monitor commands disas.c | 19 ++- include/monitor/monitor.h

[Qemu-devel] [PATCH 2/4] Improve Monitor disas with symbol lookup

2013-09-30 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau --- disas.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/disas.c b/disas.c index 32407de..c83bf5b 100644 --- a/disas.c +++ b/disas.c @@ -507,7 +507,15 @@ void monitor_disas(Monitor *mon, CPUArchState *env, #endif for (i =

[Qemu-devel] [PATCH 3/4] Refactoring MonitorDef array

2013-09-30 Thread Fabien Chouteau
Everything has been moved to cpu specific directories (SPARC, PPC, i386). Signed-off-by: Fabien Chouteau --- include/monitor/monitor.h | 16 ++ include/qemu/typedefs.h |1 + include/qom/cpu.h |3 + monitor.c | 399 +

[Qemu-devel] [PATCH 4/4] Add ARM registers definitions for Monitor commands

2013-09-30 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau --- target-arm/Makefile.objs |2 +- target-arm/cpu.c |5 + target-arm/monitor.c | 40 3 files changed, 46 insertions(+), 1 deletion(-) create mode 100644 target-arm/monitor.c diff --git a/target-a

Re: [Qemu-devel] Attaching PCI devices to the PCIe root complex

2013-09-30 Thread Gerd Hoffmann
Hi, > Yes but, same as in the initial design, > it really makes it user's problem. > > So we'd have > virtio-net-pci-conventional > virtio-net-pci-express > virtio-net-pci-integrated > > > All this while users just really want to say "virtio" > (that's the expert user, what most people want i

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-09-30 Thread Michael S. Tsirkin
On Mon, Sep 30, 2013 at 05:48:03PM +0200, Paolo Bonzini wrote: > Il 30/09/2013 11:30, Michael S. Tsirkin ha scritto: > > I was really only talking about q35 here. > > I thought it's ugly that users can control intcap > > directly. Can object_set_property be used after > > qdev_try_create? > > Yes,

[Qemu-devel] [PATCH] qcow2: Switch L1 table in a single sequence

2013-09-30 Thread Max Reitz
Switching the L1 table in memory should be an atomic operation, as far as possible. Calling qcow2_free_clusters on the old L1 table on disk is not a good idea when the old L1 table is no longer valid and the address to the new one hasn't yet been written into the corresponding BDRVQcowState field.

Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs

2013-09-30 Thread Andreas Färber
Am 30.09.2013 17:50, schrieb Michael S. Tsirkin: > On Tue, Oct 01, 2013 at 12:10:52AM +0900, Peter Maydell wrote: >> On 30 September 2013 23:40, Michael S. Tsirkin wrote: >>> diff --git a/include/qapi/error.h b/include/qapi/error.h >>> index 7d4c696..b85e996 100644 >>> --- a/include/qapi/error.h >

Re: [Qemu-devel] [PATCH v3 02/11] AARCH64: add a57core

2013-09-30 Thread Mian M. Hamayun
On 28/09/2013 02:16, Peter Maydell wrote: On 28 September 2013 00:53, Andreas Färber wrote: Hi, Am 27.09.2013 12:10, schrieb Mian M. Hamayun: From: John Rigby Just an copy of a15 with a57 substituting a15 for now. I had previously gently nack'ed this patch - conversions are still queued o

Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs

2013-09-30 Thread Markus Armbruster
Peter Maydell writes: > On 30 September 2013 23:40, Michael S. Tsirkin wrote: >> diff --git a/include/qapi/error.h b/include/qapi/error.h >> index 7d4c696..b85e996 100644 >> --- a/include/qapi/error.h >> +++ b/include/qapi/error.h >> @@ -13,14 +13,15 @@ >> #define ERROR_H >> >> #include "qemu/

Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs

2013-09-30 Thread Michael S. Tsirkin
On Tue, Oct 01, 2013 at 12:10:52AM +0900, Peter Maydell wrote: > On 30 September 2013 23:40, Michael S. Tsirkin wrote: > > diff --git a/include/qapi/error.h b/include/qapi/error.h > > index 7d4c696..b85e996 100644 > > --- a/include/qapi/error.h > > +++ b/include/qapi/error.h > > @@ -13,14 +13,15 @

Re: [Qemu-devel] [PATCH v5 2/5] hpet: entitle more irq pins for hpet

2013-09-30 Thread Paolo Bonzini
Il 30/09/2013 11:30, Michael S. Tsirkin ha scritto: > I was really only talking about q35 here. > I thought it's ugly that users can control intcap > directly. Can object_set_property be used after > qdev_try_create? Yes, after that and before qdev_init. This is how Ping Fan is doing PIIX right n

Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs

2013-09-30 Thread Peter Maydell
On 30 September 2013 23:40, Michael S. Tsirkin wrote: > diff --git a/include/qapi/error.h b/include/qapi/error.h > index 7d4c696..b85e996 100644 > --- a/include/qapi/error.h > +++ b/include/qapi/error.h > @@ -13,14 +13,15 @@ > #define ERROR_H > > #include "qemu/compiler.h" > +#include "qemu/type

Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs

2013-09-30 Thread Igor Mammedov
On Mon, 30 Sep 2013 17:40:50 +0300 "Michael S. Tsirkin" wrote: > On Mon, Sep 30, 2013 at 03:10:56PM +0200, Igor Mammedov wrote: > > On Sun, 29 Sep 2013 13:58:24 +0300 > > "Michael S. Tsirkin" wrote: > > > > > This is so qom headers can use it without pulling in > > > extra headers. > > > > > >

[Qemu-devel] Questions about Spice pv domUs

2013-09-30 Thread Fabio Fantoni
I'm trying to implement basic spice support on xen pv domUs. Test seems ok on Ubuntu 12.04 pv domU except mouse which is not visible. I also tried agent-mouse=off on qemu spice options but is not working or maybe spicy (from spice-gtk 0.20) has problem in this case (option to grab mouse is alre

Re: [Qemu-devel] [PATCH] spapr: add "compat" machine option

2013-09-30 Thread Alexander Graf
On 09/30/2013 03:22 PM, Alexey Kardashevskiy wrote: On 30.09.2013 21:25, Alexander Graf wrote: On 27.09.2013, at 10:06, Alexey Kardashevskiy wrote: To be able to boot on newer hardware that the software support, PowerISA defines a logical PVR, one per every PowerISA specification version from

Re: [Qemu-devel] [PATCH v4 2/7] qmp: add internal sync mode "common" to mirror_start

2013-09-30 Thread Eric Blake
On 09/30/2013 06:02 AM, Fam Zheng wrote: > This adds a new sync mode "common" which only copies data that is above > the common ancestor of source and target. In general, this could be useful > in cases like: > > base_bs ---> common_ancestor ---> foo ---> bar --->source >

Re: [Qemu-devel] drive-backup locks VM if target has issues?

2013-09-30 Thread Wolfgang Richter
On Mon, Sep 30, 2013 at 3:41 AM, Paolo Bonzini wrote: > Il 30/09/2013 00:46, Wolfgang Richter ha scritto: > All writes to the drive-backup source have to first copy the pre-write > data to the target. Thus, drive-backup usually works best if you are > using werror=stop on the source. That said,

Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs

2013-09-30 Thread Michael S. Tsirkin
On Mon, Sep 30, 2013 at 03:10:56PM +0200, Igor Mammedov wrote: > On Sun, 29 Sep 2013 13:58:24 +0300 > "Michael S. Tsirkin" wrote: > > > This is so qom headers can use it without pulling in > > extra headers. > > > > Reviewed-by: Paolo Bonzini > > Signed-off-by: Michael S. Tsirkin > > --- > >

Re: [Qemu-devel] [PATCH v4 2/3] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-09-30 Thread Mike Day
On Mon, Sep 30, 2013 at 9:34 AM, Alex Bligh wrote: >>> > void qemu_clock_notify(QEMUClockType type) > > ... >>> >>> > int64_t qemu_clock_deadline_ns_all(QEMUClockType type) > > ... > >>> > I think these functions are always called now with the BQL held, so I >>> > wonder if they are good candidate

Re: [Qemu-devel] [PATCH v3 00/18] qtest: Test all targets

2013-09-30 Thread Andreas Färber
Am 23.09.2013 15:35, schrieb Andreas Färber: > Andreas Färber (18): > mips_mipssim: Silence BIOS loading warning for qtest > arm/boot: Turn arm_load_kernel() into no-op for qtest without -kernel With the exception of this patch for which PMM provided a replacement... > puv3: Turn puv3_load

Re: [Qemu-devel] [PATCH 1/2] roms: build two seabios binaries

2013-09-30 Thread Paolo Bonzini
Il 30/09/2013 15:44, Gerd Hoffmann ha scritto: >>> > > +# for qemu machine types 1.6 + older >>> > > +# need to turn off features (xhci) to make it fit into 128k >>> > > +CONFIG_QEMU=y >>> > > +CONFIG_ROM_SIZE=128 >>> > > +CONFIG_USB_XHCI=n >> > >> > Is it enough to disable Xen or perhaps OHCI? >

Re: [Qemu-devel] [PATCH v3 02/18] arm/boot: Turn arm_load_kernel() into no-op for qtest without -kernel

2013-09-30 Thread Andreas Färber
Am 24.09.2013 01:55, schrieb Peter Maydell: > On 23 September 2013 23:51, Andreas Färber wrote: >> Am 23.09.2013 15:35, schrieb Andreas Färber: >>> Signed-off-by: Andreas Färber >>> --- >>> hw/arm/boot.c | 4 >>> 1 file changed, 4 insertions(+) >> >> Sorry, I forgot that Grant Likely had an

Re: [Qemu-devel] [PATCH 0/2] make -kernel optional for all ARM boards

2013-09-30 Thread Andreas Färber
Am 24.09.2013 02:01, schrieb Peter Maydell: > Make -kernel optional for all ARM boards, by allowing > arm_load_kernel() to return without doing anything if no > kernel filename was provided. In this case we will start > execution at address zero (as the hardware does). This > allows the user to pro

Re: [Qemu-devel] Minimal Qemu build for Plan9

2013-09-30 Thread Peter Maydell
On 30 September 2013 17:00, Ashish Kaila wrote: > Additionally if someone could point me to a to-do list of things to look out > for while porting Qemu on a new platform (new OS/hardware), I would be > extremely grateful. It doesn't get ported to new OSes very often, so there's no todo list alrea

Re: [Qemu-devel] [PATCH 1/2] roms: build two seabios binaries

2013-09-30 Thread Gerd Hoffmann
> > diff --git a/roms/config.seabios-128k b/roms/config.seabios-128k > > new file mode 100644 > > index 000..23ca812 > > --- /dev/null > > +++ b/roms/config.seabios-128k > > @@ -0,0 +1,5 @@ > > +# for qemu machine types 1.6 + older > > +# need to turn off features (xhci) to make it fit into 128

Re: [Qemu-devel] Minimal Qemu build for Plan9

2013-09-30 Thread Andreas Färber
Hi, Am 30.09.2013 10:00, schrieb Ashish Kaila: > I am a graduate student from CMU and currently working on trying to port > Qemu on plan9. I was trying to initially build a minimal Qemu with the > least set of devices that are necessary to support a machine, however I > noticed that I couldn’t und

Re: [Qemu-devel] [PATCH v4 2/3] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-09-30 Thread Alex Bligh
Mike, > void qemu_clock_notify(QEMUClockType type) ... > int64_t qemu_clock_deadline_ns_all(QEMUClockType type) ... > I think these functions are always called now with the BQL held, so I > wonder if they are good candidates for RCU? These routines iterate through the list of timerlists hel

Re: [Qemu-devel] [PATCH] spapr: add "compat" machine option

2013-09-30 Thread Alexey Kardashevskiy
On 30.09.2013 21:25, Alexander Graf wrote: > > On 27.09.2013, at 10:06, Alexey Kardashevskiy wrote: > >> To be able to boot on newer hardware that the software support, >> PowerISA defines a logical PVR, one per every PowerISA specification >> version from 2.04. >> >> This adds the "compat" optio

Re: [Qemu-devel] [PATCH v4 2/3] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-09-30 Thread Mike Day
> > > On Mon, Sep 30, 2013 at 8:55 AM, Alex Bligh wrote: > > > > > > On 30 Sep 2013, at 13:45, Mike Day wrote: > > > > > I've applied this set to Paolo's rcu tree - I see a couple of routines > > > that appear to need the active_timers_lock: > > > > > > (line 137 of qemu-timer.c in my tree) > > >

Re: [Qemu-devel] [PATCH v6 01/26] qemu: add Error to typedefs

2013-09-30 Thread Igor Mammedov
On Sun, 29 Sep 2013 13:58:24 +0300 "Michael S. Tsirkin" wrote: > This is so qom headers can use it without pulling in > extra headers. > > Reviewed-by: Paolo Bonzini > Signed-off-by: Michael S. Tsirkin > --- > include/qemu/typedefs.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/i

Re: [Qemu-devel] [RFC V8 06/13] quorum: Add quorum mechanism.

2013-09-30 Thread Benoît Canet
Le Friday 08 Feb 2013 à 13:07:03 (+0100), Kevin Wolf a écrit : > Am 28.01.2013 18:07, schrieb Benoît Canet: > > Use gnutls's SHA-256 to compare versions. > > > > Signed-off-by: Benoit Canet > > --- > > block/quorum.c | 303 > > +++- > > confi

Re: [Qemu-devel] [PATCH] spapr: add "compat" machine option

2013-09-30 Thread Alexey Kardashevskiy
On 30.09.2013 21:52, Paolo Bonzini wrote: > Il 30/09/2013 13:25, Alexander Graf ha scritto: >> On 27.09.2013, at 10:06, Alexey Kardashevskiy wrote: >> To be able to boot on newer hardware that the software support, PowerISA defines a logical PVR, one per every PowerISA specification

Re: [Qemu-devel] [PATCH v4 2/3] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-09-30 Thread Alex Bligh
On 30 Sep 2013, at 13:45, Mike Day wrote: > I've applied this set to Paolo's rcu tree - I see a couple of routines > that appear to need the active_timers_lock: > > (line 137 of qemu-timer.c in my tree) > void qemu_clock_notify(QEMUClockType type) > { >QEMUTimerList *timer_list; >QEMUClo

Re: [Qemu-devel] mail to Paul Brook p...@codesourcery.com bouncing [postmas...@relay1.mentorg.com: Delivery Status Notification (Failure)]

2013-09-30 Thread Andreas Färber
Am 30.09.2013 12:55, schrieb Michael S. Tsirkin: > Anyone knows what's going on? I've already ping'ed him on IRC without success and wrote to another email address that I found on GitHub, where there was some recent activity. > If no mail should be sent to p...@codesourcery.com, > let's add .mail

Re: [Qemu-devel] [RFC V8 03/13] quorum: Add quorum_aio_writev and its dependencies.

2013-09-30 Thread Benoît Canet
Le Friday 27 Sep 2013 à 12:03:07 (+0200), Kevin Wolf a écrit : > Am 26.09.2013 um 18:29 hat Benoît Canet geschrieben: > > Le Friday 08 Feb 2013 à 11:38:38 (+0100), Kevin Wolf a écrit : > > > Am 28.01.2013 18:07, schrieb Benoît Canet: > > > > Signed-off-by: Benoit Canet > > > > --- > > > > block/q

Re: [Qemu-devel] [PATCH v4 2/3] qemu-timer: make qemu_timer_mod_ns() and qemu_timer_del() thread-safe

2013-09-30 Thread Mike Day
Stefan Hajnoczi writes: > Introduce QEMUTimerList->active_timers_lock to protect the linked list > of active timers. This allows qemu_timer_mod_ns() to be called from any > thread. > > Note that vm_clock is not thread-safe and its use of > qemu_clock_has_timers() works fine today but is also no

  1   2   >