[Qemu-devel] [PATCH v5 2/4] timer: protect timers_state's clock with seqlock

2013-09-24 Thread Liu Ping Fan
QEMU_CLOCK_VIRTUAL may be read outside BQL. This will make its foundation, i.e. cpu_clock_offset exposed to race condition. Using private lock to protect it. After this patch, reading QEMU_CLOCK_VIRTUAL is thread safe unless use_icount is true, in which case the existing callers still rely on the

[Qemu-devel] [Bug 1191606] Re: qemu crashes with iscsi initiator (libiscsi) when using virtio

2013-09-24 Thread Klaus Hochlehnert
I had a chance to test it again. I used qemu 1.6.0 now for this. And the installation works now for virtio and ide. Thanks for fixing this, Klaus -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/119160

Re: [Qemu-devel] [PATCH v5 0/5] bugs fix for hpet

2013-09-24 Thread liu ping fan
Hi, is hpet orphan? Or who can help me to merge this patch-set if my patch is fine. Thanks. On Thu, Sep 12, 2013 at 11:25 AM, Liu Ping Fan wrote: > v5: > use stand compat property to fix hpet intcap on pc-q35, while on pc-piix, > hard code intcap as IRQ2 > > v4: > use stand compat property

Re: [Qemu-devel] [PATCH 05/10] xhci: emulate intr endpoint intervals correctly

2013-09-24 Thread Gerd Hoffmann
On Di, 2013-09-24 at 19:55 -0500, Michael Roth wrote: > Quoting Gerd Hoffmann (2013-08-28 07:43:01) > > Respect the interval for interrupt endpoints, so we don't finish > > transfers as fast as possible but at the rate configured by the guest. > > > > Fixes guest deadlocks triggered by interrupt s

Re: [Qemu-devel] [PATCH 06/17] blockdev: Pass QDict to blockdev_init()

2013-09-24 Thread Fam Zheng
On Fri, 09/20 13:54, Kevin Wolf wrote: > Working on a QDict instead of a QemuOpts that accepts anything is more > in line with bdrv_open(). A QDict is what qmp_blockdev_add() already has > anyway, so this saves additional conversions. And last, but not least, > it allows later patches to easily ext

[Qemu-devel] [PATCH v5 3/4] qemu-thread: add QemuEvent

2013-09-24 Thread Liu Ping Fan
From: Paolo Bonzini This emulates Win32 manual-reset events using futexes or conditional variables. Typical ways to use them are with multi-producer, single-consumer data structures, to test for a complex condition whose elements come from different threads: for (;;) { qemu_event_re

[Qemu-devel] [PATCH v5 1/4] seqlock: introduce read-write seqlock

2013-09-24 Thread Liu Ping Fan
From: Paolo Bonzini Seqlock implementation for QEMU. Usage idiom reader: do{ start = seqlock_read_begin() }while(seqlock_read_try(start)) writer: seqlock_write_lock() ... seqlock_write_unlock() initialization: seqlock_init(QemuSeqLock *sl, QemuMutex *mutex) where mutex could

[Qemu-devel] [PATCH v5 4/4] timer: make qemu_clock_enable sync between disable and timer's cb

2013-09-24 Thread Liu Ping Fan
After disabling the QemuClock, we should make sure that no QemuTimers are still in flight. To implement that with light overhead, we resort to QemuEvent. The caller of disabling will wait on QemuEvent of each timerlist. Note, qemu_clock_enable(foo,false) can _not_ be called from timer's cb. And th

[Qemu-devel] [PATCH v5 0/4] timers thread-safe stuff

2013-09-24 Thread Liu Ping Fan
v5: fine rename some variable in patch2&4. fix commit log for patch1&2 v4: fix commit log for "protect timers_state's clock with seqlock" (Thanks for Alex) v3: 1. rename seqlock_read_check as seqlock_read_retry 2. Document timerlist were protected by BQL, and discard private lock aro

[Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2013-09-24 Thread Chris J Arges
** Changed in: qemu-kvm (Ubuntu) Assignee: (unassigned) => Chris J Arges (arges) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1100843 Title: Live Migration Causes Performance Issues Status i

Re: [Qemu-devel] [PATCH v2 0/2] tests: Fixes for in-tree build

2013-09-24 Thread Andreas Färber
Am 25.09.2013 02:38, schrieb Michael Roth: > Quoting Laszlo Ersek (2013-08-28 05:49:05) >> On 08/20/13 13:43, arm...@redhat.com wrote: >>> From: Markus Armbruster >>> >>> v2: Nominate for qemu-stable (Andreas) >>> >>> Markus Armbruster (2): >>> tests: Fix schema parser test for in-tree build >>>

Re: [Qemu-devel] [PATCH V13 00/13] Add support for binding guest numa nodes to host numa nodes

2013-09-24 Thread Wanlong Gao
Hi folks, Any comments on this version? Thanks, Wanlong Gao > As you know, QEMU can't direct it's memory allocation now, this may cause > guest cross node access performance regression. > And, the worse thing is that if PCI-passthrough is used, > direct-attached-device uses DMA transfer between

[Qemu-devel] [PATCH v2 2/2] qemu-iotests: add monolithicFlat creation test to 059

2013-09-24 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/059 | 5 + tests/qemu-iotests/059.out | 7 +++ 2 files changed, 12 insertions(+) diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059 index b03429d..4bab098 100755 --- a/tests/qemu-iotests/059 +++ b/tests/qemu-iotests/059 @@ -66

[Qemu-devel] [PATCH v2 0/2] Fix and add test into 059.

2013-09-24 Thread Fam Zheng
The first fixes 059 to follow latest error message change in block layer. The second adds a test for monolithiFlat vmdk. v2: Drop space changes Fam Zheng (2): qemu-iotests: fix test case 059 qemu-iotests: add monolithicFlat creation test to 059 tests/qemu-iotests/059 | 5 + tests/

[Qemu-devel] [PATCH v2 1/2] qemu-iotests: fix test case 059

2013-09-24 Thread Fam Zheng
Since commit "block: Error parameter for open functions", error output is more verbose. Update test case output file to follow the change. Signed-off-by: Fam Zheng --- tests/qemu-iotests/059.out | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/059.out

Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: fix test case 059

2013-09-24 Thread Fam Zheng
On Tue, 09/24 14:49, Stefan Hajnoczi wrote: > On Tue, Sep 24, 2013 at 10:49:33AM +0800, Fam Zheng wrote: > > Since commit "block: Error parameter for open functions", error output > > is more verbose. Update test case output file to follow the change. > > This doesn't explain the "Formatting ..."

Re: [Qemu-devel] [PATCH 05/10] xhci: emulate intr endpoint intervals correctly

2013-09-24 Thread Michael Roth
Quoting Gerd Hoffmann (2013-08-28 07:43:01) > Respect the interval for interrupt endpoints, so we don't finish > transfers as fast as possible but at the rate configured by the guest. > > Fixes guest deadlocks triggered by interrupt storms. > > Cc: Was this meant to go to qemu-stable? > Signed-

Re: [Qemu-devel] [PATCH v3 0/3] char: fix segfault on chardev detach

2013-09-24 Thread Michael Roth
Quoting Amit Shah (2013-08-28 07:37:19) > This series fixes a segfault when a frontend is detached from a > chardev while the chardev had a pending callback registered. Further > details in patch 3. > > Please review. Reviewed-by: Michael Roth Ping for 1.6.1 > > v3: > * fix whitespace issue

Re: [Qemu-devel] [PATCH v2 0/2] tests: Fixes for in-tree build

2013-09-24 Thread Michael Roth
Quoting Laszlo Ersek (2013-08-28 05:49:05) > On 08/20/13 13:43, arm...@redhat.com wrote: > > From: Markus Armbruster > > > > v2: Nominate for qemu-stable (Andreas) > > > > Markus Armbruster (2): > > tests: Fix schema parser test for in-tree build > > tests: Update .gitignore for test-int128

Re: [Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-09-24 Thread Luiz Capitulino
On Tue, 24 Sep 2013 16:07:29 -0500 Michael Roth wrote: > > >> +bool qmp_command_has_success_response(const char *name) > > >> +{ > > >> +QmpCommand *cmd; > > >> + > > >> +QTAILQ_FOREACH(cmd, &qmp_commands, node) { > > >> +if (strcmp(cmd->name, name) == 0) { > > >> +ret

Re: [Qemu-devel] [PATCH] rbd: avoid qemu_rbd_snap_list() memory leak when no snapshots

2013-09-24 Thread Michael Roth
Quoting Stefan Hajnoczi (2013-08-14 07:13:52) > When there are no snapshots qemu_rbd_snap_list() returns 0 and the > snapshot table pointer is NULL. Don't forget to free the snaps buffer > we allocated for librbd rbd_snap_list(). > > Cc: qemu-sta...@nongnu.org > Signed-off-by: Stefan Hajnoczi P

Re: [Qemu-devel] [PATCH ] hw: Modified usb-tablet category from Misc to Input

2013-09-24 Thread Michael Roth
Quoting Michael Roth (2013-09-24 19:04:28) > Quoting Andreas Färber (2013-08-22 08:16:38) > > Am 22.08.2013 14:14, schrieb Marcel Apfelbaum: > > > Thanks to Markus Armbruster > > > for finding this bug. > > > > The simplest way to record that is: > > Reported-by: Markus Armbruster > > > > And s

Re: [Qemu-devel] [PATCH ] hw: Modified usb-tablet category from Misc to Input

2013-09-24 Thread Michael Roth
Quoting Andreas Färber (2013-08-22 08:16:38) > Am 22.08.2013 14:14, schrieb Marcel Apfelbaum: > > Thanks to Markus Armbruster > > for finding this bug. > > The simplest way to record that is: > Reported-by: Markus Armbruster > > And since this doesn't affect all of hw/, something like "usb/dev-

Re: [Qemu-devel] [PATCH 3/3] Add ARM registers definitions in Monitor commands

2013-09-24 Thread Peter Maydell
On 25 September 2013 01:46, Fabien Chouteau wrote: > --- a/monitor.c > +++ b/monitor.c > @@ -3351,6 +3351,23 @@ static const MonitorDef monitor_defs[] = { > { "cleanwin", offsetof(CPUSPARCState, cleanwin) }, > { "fprs", offsetof(CPUSPARCState, fprs) }, > #endif > +#elif defined(TARGET_A

Re: [Qemu-devel] [PATCH] .travis.yml: basic compile and check recipes

2013-09-24 Thread Peter Maydell
On 25 September 2013 01:31, wrote: > +# Debug related options > +- env: TARGETS=i386-softmmu,x86_64-softmmu > + EXTRA_CONFIG="--enable-debug --enable-debug-tcg > --enable-tcg-interpreter" --enable-debug implies --enable-debug-tcg, you don't need to specify it separately. I th

Re: [Qemu-devel] [PATCH] hw/pci: completed master-abort emulation

2013-09-24 Thread Michael S. Tsirkin
On Wed, Sep 25, 2013 at 08:36:09AM +0900, Peter Maydell wrote: > On 25 September 2013 00:41, Michael S. Tsirkin wrote: > > On Tue, Sep 24, 2013 at 08:21:50PM +0900, Peter Maydell wrote: > > Right. You might be able to use MR hierarchy to find the last bridge to > > claim transaction. That should

Re: [Qemu-devel] [PATCH] icount: disable icount with multiprocessor guests

2013-09-24 Thread Peter Maydell
On 25 September 2013 00:52, Paolo Bonzini wrote: > If -icount is enabled with multiprocessor guests, all CPUs increment > the same counter, which then basically runs too fast by a factor of > smp_cpus. This makes little sense and complicates further a feature > whose implementation is pretty obsc

Re: [Qemu-devel] [PATCH] hw/pci: completed master-abort emulation

2013-09-24 Thread Peter Maydell
On 25 September 2013 00:41, Michael S. Tsirkin wrote: > On Tue, Sep 24, 2013 at 08:21:50PM +0900, Peter Maydell wrote: > Right. You might be able to use MR hierarchy to find the last bridge to > claim transaction. That should to be enough for PCI, for express you > then need to find all devices o

[Qemu-devel] [PATCH] vnc: Add support for color map

2013-09-24 Thread Alexander Graf
Our current VNC code does not handle color maps (aka non-true-color) at all and aborts if a client requests them. There are 2 major issues with this: 1) A VNC viewer on an 8-bit X11 system may request color maps 2) RealVNC _always_ starts requesting color maps, then moves on to full color In or

Re: [Qemu-devel] [Qemu-stable] [PATCH for-1.6] qemu-timer: fix get_clock() gettimeofday() fallback #ifdef

2013-09-24 Thread Michael Roth
Quoting Michael Roth (2013-09-24 16:58:22) > Quoting Stefan Hajnoczi (2013-08-06 06:48:58) > > If CLOCK_MONOTONIC is not defined by system headers we use > > gettimeofday(2). Apparently this is not used very often since no one > > noticed the #ifdef was actually broken and left the function defini

Re: [Qemu-devel] [Qemu-stable] [PATCH for-1.6] qemu-timer: fix get_clock() gettimeofday() fallback #ifdef

2013-09-24 Thread Michael Roth
Quoting Stefan Hajnoczi (2013-08-06 06:48:58) > If CLOCK_MONOTONIC is not defined by system headers we use > gettimeofday(2). Apparently this is not used very often since no one > noticed the #ifdef was actually broken and left the function definition > unterminated. > > Signed-off-by: Stefan Haj

[Qemu-devel] [PATCH v2 4/4] qom: add pointer to int property helpers

2013-09-24 Thread Michael S. Tsirkin
Make it easy to add read-only helpers for simple integer properties in memory. Reviewed-by: Paolo Bonzini Signed-off-by: Michael S. Tsirkin --- include/qom/object.h | 21 ++ qom/object.c | 60 2 files changed, 81 inser

[Qemu-devel] [PATCH v2 1/4] qemu: add Error to typedefs

2013-09-24 Thread Michael S. Tsirkin
This is so qom headers can use it without pulling in extra headers. Reviewed-by: Paolo Bonzini Signed-off-by: Michael S. Tsirkin --- include/qemu/typedefs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h index a4c1b84..46c3599 100644 --- a/

[Qemu-devel] [PATCH v2 3/4] qom: cleanup struct Error references

2013-09-24 Thread Michael S. Tsirkin
now that a typedef for struct Error is available, use it in qom/object.h to match coding style rules. Reviewed-by: Paolo Bonzini Signed-off-by: Michael S. Tsirkin --- include/qom/object.h | 51 +-- 1 file changed, 25 insertions(+), 26 deletions(-)

[Qemu-devel] [PATCH v2 2/4] qom: pull in qemu/typedefs

2013-09-24 Thread Michael S. Tsirkin
As usual so we can use typedefs without header dependencies. Reviewed-by: Paolo Bonzini Signed-off-by: Michael S. Tsirkin --- include/qom/object.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/qom/object.h b/include/qom/object.h index 1a7b71a..5b3b743 100644 --- a/include/qom/obje

[Qemu-devel] [PATCH v2 0/4] qom: add helpers for integer properties

2013-09-24 Thread Michael S. Tsirkin
Add helper functions for adding read-only properties, that work in the case where the value is in memory. This is part of the ACPI series, since there was a bug here I'm resending just this chunk for more review. Changes from v1: don't pass pointer to visitor directly since it writes there

Re: [Qemu-devel] [PATCH v4 00/23] qemu: generate acpi tables for the guest

2013-09-24 Thread Michael S. Tsirkin
On Tue, Sep 24, 2013 at 11:23:29AM +0200, Gerd Hoffmann wrote: > On So, 2013-09-22 at 16:37 +0300, Michael S. Tsirkin wrote: > > This code can also be found here: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi > > Program received signal SIGSEGV, Segmentation fault. Fixed now, thanks

Re: [Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-09-24 Thread Michael Roth
Quoting Eric Blake (2013-09-24 14:13:08) > On 09/24/2013 01:00 PM, Michael Roth wrote: > > Quoting Mark Wu (2013-09-22 01:50:54) > >> Now we have several qemu-ga commands not returning response on success. > >> It has been documented in qga/qapi-schema.json already. This patch exposes > >> the 'suc

Re: [Qemu-devel] [PATCH v2 3/3] block: qemu-iotests - quote $TEST_IMG* and $TEST_DIR usage

2013-09-24 Thread Jeff Cody
On Mon, Sep 23, 2013 at 02:45:13PM +0200, Stefan Hajnoczi wrote: > On Fri, Sep 20, 2013 at 01:12:40PM -0400, Jeff Cody wrote: > > diff --git a/tests/qemu-iotests/043 b/tests/qemu-iotests/043 > > index 478773d..ae7cf27 100755 > > --- a/tests/qemu-iotests/043 > > +++ b/tests/qemu-iotests/043 > > @@ -

Re: [Qemu-devel] Qemu-KVM VETH

2013-09-24 Thread Tim Epkes
Stefan, I just tested the most recent version of qemu (1.4). I have 2 virtual images back to back via a tcp socket. They can ping eachother, but when I down the listener and bring it back up (meaning killing the kvm and relaunching) it cannot ping anymore. The connector never retries to connect

Re: [Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-09-24 Thread Eric Blake
On 09/24/2013 01:00 PM, Michael Roth wrote: > Quoting Mark Wu (2013-09-22 01:50:54) >> Now we have several qemu-ga commands not returning response on success. >> It has been documented in qga/qapi-schema.json already. This patch exposes >> the 'success-response' flag by extending 'guest-info' comma

Re: [Qemu-devel] [PATCH] Extend qemu-ga's 'guest-info' command to expose flag 'success-response'

2013-09-24 Thread Michael Roth
Quoting Mark Wu (2013-09-22 01:50:54) > Now we have several qemu-ga commands not returning response on success. > It has been documented in qga/qapi-schema.json already. This patch exposes > the 'success-response' flag by extending 'guest-info' command. With this > change, the clients can handle th

[Qemu-devel] [PULL 01/01] seccomp: fine tuning whitelist by adding times()

2013-09-24 Thread Eduardo Otubo
From: Eduardo Otubo This was causing Qemu process to hang when using -sandbox on as discribed on RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1004175 Signed-off-by: Eduardo Otubo Tested-by: Paul Moore Acked-by: Paul Moore --- qemu-seccomp.c |1 + 1 files changed, 1 insertions(+), 0

[Qemu-devel] [PULL 00/01] seccomp: trivial changes

2013-09-24 Thread Eduardo Otubo
Anthony, The following changes since commit f828a4c8faa118e0ebab3e353ac6840f3b2a0318: Merge remote-tracking branch 'stefanha/tracing' into staging (2013-09-23 11:53:22 -0500) are available in the git repository at: git://github.com/otubo/qemu.git seccomp Eduardo Otubo (1): seccomp:

Re: [Qemu-devel] [Qemu-stable] [PATCH] rdma: fix multiple VMs parallel migration

2013-09-24 Thread Michael R. Hines
On 09/04/2013 04:10 AM, Frank Yang wrote: On 2013-9-3 13:03, Lei Li wrote: Hi Frank, I failed to apply this patch. Please make sure to use git-send-email, otherwise it's a little hard to review. :) On 08/30/2013 08:39 PM, Frank Yang wrote: When several VMs migrate with RDMA at the same time,

Re: [Qemu-devel] [Qemu-stable] [PATCH] rdma: memory leak InetSocketAddress

2013-09-24 Thread Michael R. Hines
On 09/12/2013 09:51 AM, Frank wrote: > It is allocated by g_new0() in inet_parse(), so needs to be freed in > qemu_rdma_data_init(). > > From d7a8d1aad11fbe9af389cf9dd6cee14cc3249b1f Mon Sep 17 00:00:00 2001 > From: Frank Yang > Date: Thu, 12 Sep 2013 21:37:56 +0800 > Subject: [PATCH] rdma: memor

Re: [Qemu-devel] [PATCH 1/2] rdma: constify ram_chunk_{index, start, end}

2013-09-24 Thread Michael R. Hines
On 09/24/2013 01:38 PM, Juan Quintela wrote: "Michael R. Hines" wrote: On 09/24/2013 12:36 PM, Juan Quintela wrote: "Michael R. Hines" wrote: On 09/20/2013 03:55 AM, Isaku Yamahata wrote: On Wed, Sep 18, 2013 at 10:28:51AM -0400, Michael R. Hines wrote: On 09/03/2013 10:32 PM, Isaku Yamaha

Re: [Qemu-devel] [PATCH 1/2] rdma: constify ram_chunk_{index, start, end}

2013-09-24 Thread Juan Quintela
"Michael R. Hines" wrote: > On 09/24/2013 12:36 PM, Juan Quintela wrote: >> "Michael R. Hines" wrote: >>> On 09/20/2013 03:55 AM, Isaku Yamahata wrote: On Wed, Sep 18, 2013 at 10:28:51AM -0400, Michael R. Hines wrote: > On 09/03/2013 10:32 PM, Isaku Yamahata wrote: >> Signed-off-by:

Re: [Qemu-devel] [PATCH 1/3] Fix coding style

2013-09-24 Thread Andreas Färber
Am 24.09.2013 18:45, schrieb Fabien Chouteau: > Signed-off-by: Fabien Chouteau > --- > disas.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) Reviewed-by: Andreas Färber Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer

Re: [Qemu-devel] [PATCH 1/2] rdma: constify ram_chunk_{index, start, end}

2013-09-24 Thread Michael R. Hines
On 09/24/2013 12:36 PM, Juan Quintela wrote: "Michael R. Hines" wrote: On 09/20/2013 03:55 AM, Isaku Yamahata wrote: On Wed, Sep 18, 2013 at 10:28:51AM -0400, Michael R. Hines wrote: On 09/03/2013 10:32 PM, Isaku Yamahata wrote: Signed-off-by: Isaku Yamahata There's no need to rebase again

[Qemu-devel] [PATCH 3/3] Add ARM registers definitions in Monitor commands

2013-09-24 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau --- monitor.c | 17 + 1 file changed, 17 insertions(+) diff --git a/monitor.c b/monitor.c index 74f3f1b..e40c20d 100644 --- a/monitor.c +++ b/monitor.c @@ -3351,6 +3351,23 @@ static const MonitorDef monitor_defs[] = { { "cleanwin", offsetof(

[Qemu-devel] [PATCH 1/3] Fix coding style

2013-09-24 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau --- disas.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/disas.c b/disas.c index 0203ef2..32407de 100644 --- a/disas.c +++ b/disas.c @@ -506,12 +506,13 @@ void monitor_disas(Monitor *mon, CPUArchState *env, return; #endif

[Qemu-devel] [PATCH 2/3] Improve Monitor disas with symbol lookup

2013-09-24 Thread Fabien Chouteau
Signed-off-by: Fabien Chouteau --- disas.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/disas.c b/disas.c index 32407de..c83bf5b 100644 --- a/disas.c +++ b/disas.c @@ -507,7 +507,15 @@ void monitor_disas(Monitor *mon, CPUArchState *env, #endif for (i =

[Qemu-devel] [PATCH 0/3] Few minor improvements of monitor disas command (v2)

2013-09-24 Thread Fabien Chouteau
1. Fix coding style (missing space and tab indentation) 2. Add symbole lookup (when possible) 3. Add ARM registers definitions I tried to abstract monitor_defs in a CPU field, but I got lost in the dependencies maze. I still think this patch is a step forward. Fabien Chouteau (3): Fix

Re: [Qemu-devel] [PATCH 1/2] rdma: constify ram_chunk_{index, start, end}

2013-09-24 Thread Juan Quintela
"Michael R. Hines" wrote: > On 09/20/2013 03:55 AM, Isaku Yamahata wrote: >> On Wed, Sep 18, 2013 at 10:28:51AM -0400, Michael R. Hines wrote: >>> On 09/03/2013 10:32 PM, Isaku Yamahata wrote: Signed-off-by: Isaku Yamahata > > There's no need to rebase against github or track my branches. >

[Qemu-devel] [PATCH v3 0/0] .travis.yml: basic compile and check recipies

2013-09-24 Thread alex . bennee
Assuming there are no further comments from this submission I shall likely make my next posting a PULL request. v3 - re-based on current origin/master - squashed all .travis commits and re-worded commit - added clang builds - disabled "make check" for ftrace back-end - fixed broken build

[Qemu-devel] [PATCH] .travis.yml: basic compile and check recipes

2013-09-24 Thread alex . bennee
From: Alex Bennée This adds a build matrix definition for travis-ci.org continuous integration service. It is usable on any public repository hosted on GitHub. Once you have created an account signed into Travis you can enable it on selected projects via travis-ci.org/profile. Alternatively you c

Re: [Qemu-devel] [PATCH] hw/pci: completed master-abort emulation

2013-09-24 Thread Michael S. Tsirkin
On Tue, Sep 24, 2013 at 06:41:11PM +0300, Michael S. Tsirkin wrote: > On Tue, Sep 24, 2013 at 08:21:50PM +0900, Peter Maydell wrote: > > On 24 September 2013 20:17, Marcel Apfelbaum wrote: > > > I was suggesting an algorithm to find the MA device in order > > > to set MA Received Bit in its Status

[Qemu-devel] [PATCH] icount: disable icount with multiprocessor guests

2013-09-24 Thread Paolo Bonzini
If -icount is enabled with multiprocessor guests, all CPUs increment the same counter, which then basically runs too fast by a factor of smp_cpus. This makes little sense and complicates further a feature whose implementation is pretty obscure already. Signed-off-by: Paolo Bonzini --- cpus.c |

Re: [Qemu-devel] qemu-1.6.0 under Cygwin64 ./configure failed

2013-09-24 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 24/09/2013 16:41, Eric Blake ha scritto: > -mno-cygwin is an obsolete command line option, formerly used for > cross-compiling from cygwin to mingw. It is NOT used when building > for cygwin, and these days, building for mingw should use a proper

Re: [Qemu-devel] [PATCH] hw/pci: completed master-abort emulation

2013-09-24 Thread Michael S. Tsirkin
On Tue, Sep 24, 2013 at 08:21:50PM +0900, Peter Maydell wrote: > On 24 September 2013 20:17, Marcel Apfelbaum wrote: > > I was suggesting an algorithm to find the MA device in order > > to set MA Received Bit in its Status(Sec_Status) register. > > > > The algorithm was to traverse the PCI buses f

Re: [Qemu-devel] [PATCH V4] block: introduce BlockDriver.bdrv_needs_filename to enable some drivers.

2013-09-24 Thread Eric Blake
On 09/24/2013 09:07 AM, Benoît Canet wrote: > Some drivers will have driver specifics options but no filename. > This new bool allow the block layer to treat them correctly. > > The .bdrv_needs_filename is set in drivers not having .bdrv_parse_filename and > not having .bdrv_open. > > The first e

[Qemu-devel] [PATCH V4] block: introduce BlockDriver.bdrv_needs_filename to enable some drivers.

2013-09-24 Thread Benoît Canet
Some drivers will have driver specifics options but no filename. This new bool allow the block layer to treat them correctly. The .bdrv_needs_filename is set in drivers not having .bdrv_parse_filename and not having .bdrv_open. The first exception to this rule will be the quorum driver. Signed-o

[Qemu-devel] [PATCH V4] introduce .bdrv_needs_filename

2013-09-24 Thread Benoît Canet
v4: Fix comment [Eric] Simplify if like the assertion [Kevin] v3: Add comment [Eric] v1-2: simplify assertion [Kevin] add .bdrv_needs_filename only to driver to having .bdrv_parse_filename nor .bdrv_open [Kevin] Tested that raw, qed and ssh protocols works fine. Benoî

Re: [Qemu-devel] qemu-1.6.0 under Cygwin64 ./configure failed

2013-09-24 Thread Alexander Voropay
2013/9/24 Eric Blake > -mno-cygwin is an obsolete command line option, formerly used for > cross-compiling from cygwin to mingw. It is NOT used when building for > cygwin, and these days, building for mingw should use a proper cross > compiler (available from cygwin.com) rather than the -mno-cy

Re: [Qemu-devel] [PATCH] qcow2: Don't shadow return value

2013-09-24 Thread Kevin Wolf
Am 24.09.2013 um 13:50 hat Max Reitz geschrieben: > When trying to update the refcounts for a snapshot, the return value of > update_refcount on a compressed cluster was pretty much ignored, > cancelling the update on error but returning 0. This is caused by an > inner "ret" variable shadowing the

Re: [Qemu-devel] [PATCH] qemu-iotests: Do not execute 052 with -nocache

2013-09-24 Thread Kevin Wolf
Am 23.09.2013 um 16:38 hat Max Reitz geschrieben: > Test 052 uses qemu-io -s which will result in bdrv_open trying to create > a temporary snapshot file in /tmp. However, since O_DIRECT and tmpfs > do not work well together, disable this test for -nocache. > > Signed-off-by: Max Reitz Thanks, ap

Re: [Qemu-devel] qemu-1.6.0 under Cygwin64 ./configure failed

2013-09-24 Thread Eric Blake
On 09/24/2013 07:56 AM, Alexander Voropay wrote: > Hi! > > Can anyone please correct a building qemu-1.6.0 under Cygwin64 ? > > ./configure reports non-working "cc" . The gcc is installed and working > > $ uname -a > CYGWIN_NT-6.1 MYWIN-A2 1.7.25(0.270/5/3) 2013-08-31 20:37 x86_64 Cygwin > ^

Re: [Qemu-devel] [PATCH 3/3] block/stream.c: ensure copy always set

2013-09-24 Thread Alex Bennée
stefa...@redhat.com writes: > On Mon, Sep 23, 2013 at 05:07:30PM +0100, alex.ben...@linaro.org wrote: >> From: Alex Bennée >> >> This only showed up when compiling with >> --enable-trace-backend=stderr|ftrace at which point the compiler >> complains with the following: > > Stefan Weil already

[Qemu-devel] [PATCHv3 09/20] iscsi: simplify iscsi_co_discard

2013-09-24 Thread Peter Lieven
now that bdrv_co_discard can handle limits we do not need the request split logic here anymore. Reviewed-by: Eric Blake Signed-off-by: Peter Lieven --- block/iscsi.c | 67 + 1 file changed, 25 insertions(+), 42 deletions(-) diff --git a

Re: [Qemu-devel] [PATCH v2 0/0] .travis and minor compile fixes

2013-09-24 Thread Alex Bennée
stefa...@redhat.com writes: > On Mon, Sep 23, 2013 at 05:07:27PM +0100, alex.ben...@linaro.org wrote: >> Given I found a couple of issues while doing this I think this is >> useful alongside the existing buildbot efforts. It allows developers >> to run simple smoke-tests without access to the bui

[Qemu-devel] [PATCHv3 06/20] block: add BlockLimits structure to BlockDriverState

2013-09-24 Thread Peter Lieven
this patch adds BlockLimits which introduces discard and write_zeroes limits and alignment information to the BlockDriverState. Signed-off-by: Peter Lieven --- include/block/block_int.h | 17 + 1 file changed, 17 insertions(+) diff --git a/include/block/block_int.h b/include/b

[Qemu-devel] KVM call for agenda for 2013-10-01

2013-09-24 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. Last week I forgot to send the call for topics. We still have a topic there. Thanks, Juan. Agenda so far: - Talk about qemu reverse executing (1st description was done this week) How to handle IO when we want to do reverse execu

[Qemu-devel] [PATCHv3 00/20] block: logical block provisioning enhancements

2013-09-24 Thread Peter Lieven
this patch adds the ability for targets to stay sparse during block migration (if the zero_blocks capability is set) and qemu-img convert even if the target does not have has_zero_init = 1. the series was especially developed for iSCSI, but it should also work with other drivers with little or no

Re: [Qemu-devel] [RFC] [PATCHv10 00/31] aio / timers: Add AioContext timers and use ppoll

2013-09-24 Thread Stefan Hajnoczi
On Wed, Sep 18, 2013 at 09:23:09AM +0100, Alex Bligh wrote: > Paolo, > > On 18 Sep 2013, at 08:57, Paolo Bonzini wrote: > > > Il 17/09/2013 19:32, Alex Bligh ha scritto: > >> > >> On 17 Sep 2013, at 18:04, Paolo Bonzini wrote: > >> > >>> Alex, what's missing before block.c and QED can use aio_t

[Qemu-devel] [PATCHv3 08/20] block: honour BlockLimits in bdrv_co_discard

2013-09-24 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block.c | 37 - 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index 580570a..784e545 100644 --- a/block.c +++ b/block.c @@ -4224,6 +4224,11 @@ static void coroutine_fn bdrv_discard_co_entry(voi

Re: [Qemu-devel] [RFC] [PATCHv10 00/31] aio / timers: Add AioContext timers and use ppoll

2013-09-24 Thread Stefan Hajnoczi
On Wed, Sep 18, 2013 at 11:25:25AM +0200, Paolo Bonzini wrote: > Il 18/09/2013 11:02, Alex Bligh ha scritto: > > Paolo, > > > > On 18 Sep 2013, at 09:23, Alex Bligh wrote: > > > >>> Yes, that was my understanding too. Can we do it for 1.7? > > > > Whilst we are changing the calling semantics, d

[Qemu-devel] [PATCHv3 10/20] iscsi: set limits in BlockDriverState

2013-09-24 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/iscsi.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index ce8823d..90dc7c2 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1367,6 +1367,20 @@ static int iscsi_open(BlockDriverState *bs, QDict *option

[Qemu-devel] [PATCHv3 05/20] block/raw: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes

2013-09-24 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/raw_bsd.c | 56 +-- 1 file changed, 34 insertions(+), 22 deletions(-) diff --git a/block/raw_bsd.c b/block/raw_bsd.c index d5ab295..8dc7bba 100644 --- a/block/raw_bsd.c +++ b/block/raw_bsd.c @@ -131,6 +13

[Qemu-devel] [PATCHv3 12/20] iscsi: add bdrv_co_write_zeroes

2013-09-24 Thread Peter Lieven
Reviewed-by: Eric Blake Signed-off-by: Peter Lieven --- block/iscsi.c | 59 + 1 file changed, 59 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index f6cd322..8f52ef8 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -56,6 +56,

[Qemu-devel] [PATCHv3 15/20] block/get_block_status: avoid segfault if there is no backing_hd

2013-09-24 Thread Peter Lieven
Reviewed-by: Eric Blake Signed-off-by: Peter Lieven --- block.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 3499c90..3bf1163 100644 --- a/block.c +++ b/block.c @@ -3266,7 +3266,7 @@ static int64_t coroutine_fn bdrv_co_get_block_status(BlockDriv

[Qemu-devel] [PATCHv3 19/20] qemu-img: conditionally zero out target on convert

2013-09-24 Thread Peter Lieven
If the target has_zero_init = 0, but supports efficiently writing zeroes by unmapping we call bdrv_zeroize to avoid fully allocating the target. Ihis currently is designed especially for iscsi. Reviewed-by: Eric Blake Signed-off-by: Peter Lieven --- qemu-img.c | 10 +- 1 file changed,

[Qemu-devel] [PATCHv3 20/20] block/raw: copy BlockLimits on raw_open

2013-09-24 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/raw_bsd.c |1 + 1 file changed, 1 insertion(+) diff --git a/block/raw_bsd.c b/block/raw_bsd.c index 8dc7bba..7af26ad 100644 --- a/block/raw_bsd.c +++ b/block/raw_bsd.c @@ -159,6 +159,7 @@ static int raw_open(BlockDriverState *bs, QDict *options, int fla

[Qemu-devel] [PATCHv3 17/20] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks

2013-09-24 Thread Peter Lieven
this patch does 2 things: a) only do additional call outs if BDRV_BLOCK_ZERO is not already set. b) use the newly introduced bdrv_has_discard_zeroes() to return the zero state of an unallocated block. the used callout to bdrv_has_zero_init() is only valid right after bdrv_create. Reviewed-by

[Qemu-devel] [PATCHv3 13/20] block: introduce bdrv_zeroize

2013-09-24 Thread Peter Lieven
this patch adds a call to completely zero out a block device. the operation is sped up by checking the block status and only writing zeroes to the device if they currently do not return zeroes. optionally the zero writing can be sped up by setting the flag BDRV_REQ_MAY_UNMAP to emulate the zero wri

[Qemu-devel] [PATCHv3 14/20] block/get_block_status: set *pnum = 0 on error

2013-09-24 Thread Peter Lieven
if the call is invoked through bdrv_is_allocated the caller might expect *pnum = 0 on error. however, a new implementation of bdrv_get_block_status might only return a negative exit value on error while keeping *pnum untouched. Reviewed-by: Eric Blake Signed-off-by: Peter Lieven --- block.c |

[Qemu-devel] [PATCHv3 07/20] block: honour BlockLimits in bdrv_co_do_write_zeroes

2013-09-24 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block.c | 65 +++ 1 file changed, 49 insertions(+), 16 deletions(-) diff --git a/block.c b/block.c index ac35cb5..580570a 100644 --- a/block.c +++ b/block.c @@ -2710,32 +2710,65 @@ int coroutine_fn bdrv

[Qemu-devel] [PATCHv3 18/20] qemu-img: add support for fully allocated images

2013-09-24 Thread Peter Lieven
Signed-off-by: Peter Lieven --- qemu-img.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 926f0a0..c6eff15 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -100,8 +100,10 @@ static void help(void) " '-h' with or without a comma

[Qemu-devel] [PATCHv3 16/20] block/get_block_status: avoid redundant callouts on raw devices

2013-09-24 Thread Peter Lieven
if a raw device like an iscsi target or host device is used the current implementation makes a second call out to get the block status of bs->file. however, the raw driver already has called bdrv_get_block_status on bs->file. Reviewed-by: Eric Blake Signed-off-by: Peter Lieven --- block.c |

[Qemu-devel] [PATCHv3 11/20] iscsi: add bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes

2013-09-24 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/iscsi.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index 90dc7c2..f6cd322 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1449,6 +1449,18 @@ static int iscsi_has_zero_init(BlockDrive

[Qemu-devel] [PATCHv3 03/20] block: introduce BDRV_REQ_MAY_UNMAP request flag

2013-09-24 Thread Peter Lieven
Reviewed-by: Eric Blake Signed-off-by: Peter Lieven --- block-migration.c |3 ++- block.c |4 block/backup.c|2 +- include/block/block.h |7 +++ 4 files changed, 14 insertions(+), 2 deletions(-) diff --git a/block-migration.c b/block-migration.

[Qemu-devel] [PATCHv3 04/20] block: introduce bdrv_has_discard_zeroes and bdrv_has_discard_write_zeroes

2013-09-24 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block.c | 29 + include/block/block.h |2 ++ include/block/block_int.h | 13 + 3 files changed, 44 insertions(+) diff --git a/block.c b/block.c index e7bf6af..ac35cb5 100644 --- a/block.c +++ b/

[Qemu-devel] [PATCHv3 02/20] block: add flags to bdrv_*_write_zeroes

2013-09-24 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block-migration.c |2 +- block.c | 20 +++- block/backup.c|3 ++- block/qcow2-cluster.c |2 +- block/qcow2.c |2 +- block/qed.c |3 ++- block/raw_bsd.c

[Qemu-devel] [PATCHv3 01/20] block: make BdrvRequestFlags public

2013-09-24 Thread Peter Lieven
Reviewed-by: Eric Blake Signed-off-by: Peter Lieven --- block.c |5 - include/block/block.h |5 + 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index ea4956d..8eefb97 100644 --- a/block.c +++ b/block.c @@ -51,11 +51,6 @@ #define

Re: [Qemu-devel] [RFC 00/16] TCG indirect registers

2013-09-24 Thread Artyom Tarasenko
On Mon, Sep 23, 2013 at 8:06 PM, Richard Henderson wrote: > On 09/23/2013 10:23 AM, Blue Swirl wrote: >> On Fri, Sep 20, 2013 at 12:24 AM, Richard Henderson wrote: >>> >>> This is an attempt to improve performance of target-sparc >>> by exposing the windowed registers as TCG globals, and all >>>

Re: [Qemu-devel] [PATCH V3] block: introduce BlockDriver.bdrv_needs_filename to enable some drivers.

2013-09-24 Thread Eric Blake
On 09/24/2013 06:27 AM, Benoît Canet wrote: > Some drivers will have driver specifics options but no filename. > This new bool allow the block layer to treat them correctly. > > The .bdrv_needs_filename is set in drivers not having .bdrv_parse_filename and > not having .bdrv_open. > > The first e

Re: [Qemu-devel] [PATCH v2] vmdk: fix cluster size check for flat extents

2013-09-24 Thread Stefan Hajnoczi
On Mon, Sep 23, 2013 at 05:18:29PM +0800, Fam Zheng wrote: > We use the extent size as cluster size for flat extents (where no L1/L2 > table is allocated so it's safe) reuse sector calculating code with > sparse extents. > > Don't pass in the cluster size for adding flat extent, just set it to > s

Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: fix test case 059

2013-09-24 Thread Stefan Hajnoczi
On Tue, Sep 24, 2013 at 10:49:33AM +0800, Fam Zheng wrote: > Since commit "block: Error parameter for open functions", error output > is more verbose. Update test case output file to follow the change. This doesn't explain the "Formatting ..." trailing space change. If this has changed, please sp

Re: [Qemu-devel] [PATCH v2 0/0] .travis and minor compile fixes

2013-09-24 Thread Stefan Hajnoczi
On Mon, Sep 23, 2013 at 05:07:27PM +0100, alex.ben...@linaro.org wrote: > I've updated the .travis.yml following feedback from Stefan to greatly > increase the number of compiles it does. In the process: > > * Disabled ust backend (horribly broken) > * Found gov/gprof builds don't enforce --disabl

Re: [Qemu-devel] [PATCH] tracing: start trace processing thread in final child process

2013-09-24 Thread Stefan Hajnoczi
On Mon, Sep 23, 2013 at 04:36:54PM +0200, Christian Borntraeger wrote: > From: Michael Mueller > > When running with trace backend e.g. "simple" the writer thread needs to be > implemented in the same process context as the trace points that will be > processed. Under libvirtd control, qemu gets

  1   2   >