Re: [Qemu-devel] [PATCH v2 0/7] tcg-ppc qemu_ldst improvements

2013-09-09 Thread Paolo Bonzini
Il 10/09/2013 02:28, Richard Henderson ha scritto: > I'm not 100% sure what was wrong with v1 -- possibly some silly typo > fixed during rebasing on top of Paolo's patches. I did that since at > minimum his patches are necessary for AIX fixes. Great, thank you very much! Paolo

Re: [Qemu-devel] [PATCH v3 0/3] vfio: fixes for better support for 128 bit memory section sizes

2013-09-09 Thread Paolo Bonzini
Il 10/09/2013 06:23, Alexey Kardashevskiy ha scritto: > On 08/29/2013 12:29 AM, Paolo Bonzini wrote: >> Il 28/08/2013 16:10, Alex Williamson ha scritto: >>> On Wed, 2013-08-28 at 13:09 +0200, Paolo Bonzini wrote: Il 28/08/2013 11:46, Alexey Kardashevskiy ha scritto: > On 08/22/2013 09:29 P

Re: [Qemu-devel] [RFC PATCH v3 5/5] block: build qed and curl as shared library

2013-09-09 Thread Paolo Bonzini
Il 10/09/2013 03:02, Fam Zheng ha scritto: > Curl and qed block drivers are built as shared object module. We have > per object cflags and libs support now, move CURL_CFLAGS and CURL_LIBS > from global option variables to a per object basis. > > "make install" is not installing them yet, manually

Re: [Qemu-devel] [RFC PATCH v3 3/5] Makefile: introduce common-obj-m and block-obj-m for DSO

2013-09-09 Thread Paolo Bonzini
Il 10/09/2013 03:02, Fam Zheng ha scritto: > -all: $(DOCS) $(TOOLS) $(HELPERS-y) recurse-all > +# static linked mods are expanded to .o list > +dummy := $(call expand-mod-obj,common-obj-y) > +dummy := $(call expand-mod-obj,block-obj-y) > + > +modules-m = $(patsubst %.o,%$(DSOSUF),$(filter %.o,$(blo

Re: [Qemu-devel] [RFC PATCH v3 1/5] make.rule: fix $(obj) to a real relative path

2013-09-09 Thread Paolo Bonzini
Il 10/09/2013 03:02, Fam Zheng ha scritto: > Makefile.target includes rule.mak and unnested common-obj-y, then prefix > them with '../', this will ignore object specific QEMU_CFLAGS in subdir > Makefile.objs: > > $(obj)/curl.o: QEMU_CFLAGS += $(CURL_CFLAGS) > > Because $(obj) here is './block

Re: [Qemu-devel] [PATCH v4 00/12] xics: reworks and in-kernel support

2013-09-09 Thread Alexey Kardashevskiy
On 09/04/2013 12:56 PM, Alexey Kardashevskiy wrote: > On 08/30/2013 03:28 PM, Alexey Kardashevskiy wrote: >> Yet another try with XICS and XICS-KVM. >> >> v3->v4: >> Addressed multiple comments from Alex; >> Split out many tiny patches to make them easier to review; >> Fixed xics_cpu_setup not to c

Re: [Qemu-devel] [PATCH v3 0/3] vfio: fixes for better support for 128 bit memory section sizes

2013-09-09 Thread Alexey Kardashevskiy
On 08/29/2013 12:29 AM, Paolo Bonzini wrote: > Il 28/08/2013 16:10, Alex Williamson ha scritto: >> On Wed, 2013-08-28 at 13:09 +0200, Paolo Bonzini wrote: >>> Il 28/08/2013 11:46, Alexey Kardashevskiy ha scritto: On 08/22/2013 09:29 PM, Alexey Kardashevskiy wrote: > I made a couple of smal

Re: [Qemu-devel] [PATCH] memory: fix 128 arithmetic in info mtree

2013-09-09 Thread Alexey Kardashevskiy
On 08/30/2013 06:10 PM, Alexey Kardashevskiy wrote: > mtree_print_mr() calls int128_get64() in 3 places but only 2 places > handle 2^64 correctly. > > This fixes the third call of int128_get64(). > > Signed-off-by: Alexey Kardashevskiy > --- > memory.c | 4 +++- > 1 file changed, 3 insertions(+

Re: [Qemu-devel] [PATCH v2 1/4] target-ppc: Fill in OpenFirmware names for some PowerPCCPU families

2013-09-09 Thread Alexey Kardashevskiy
On 08/16/2013 08:35 AM, Andreas Färber wrote: > Set the expected values for POWER7, POWER7+, POWER8 and POWER5+. > Note that POWER5+ and POWER7+ are intentionally lacking the '+', so the > lack of a POWER7P family constitutes no problem. > > Signed-off-by: Andreas Färber Out of curiosity - is a

Re: [Qemu-devel] [PATCH v2 3/6] block/qapi: Human-readable ImageInfoSpecific dump

2013-09-09 Thread Fam Zheng
On Fri, 09/06 15:12, Max Reitz wrote: > Add a function for generically dumping the ImageInfoSpecific information > in a human-readable format to block/qapi.c. > > Use this function in bdrv_image_info_dump and qemu-io-cmds.c:info_f to > allow qemu-img info resp. qemu-io -c info to print that format

Re: [Qemu-devel] [PATCH v2 2/6] block: Add ImageInfoSpecific to BlockDriverInfo

2013-09-09 Thread Fam Zheng
On Fri, 09/06 15:12, Max Reitz wrote: > Add the new ImageInfoSpecific type also to BlockDriverInfo. > > To prevent memory leaks, this field has to be initialized to NULL every > time before calling bdrv_get_info and qapi_free_ImageInfoSpecific has to > be called on it when the BlockDriverInfo obje

[Qemu-devel] [PATCH vgabios] Make windows8 work with high resolution when using -vga std in qmeu

2013-09-09 Thread Bo Yang
This patch has been sent to upstream vgabios maillist, but there is no response. Since it is useful for windows8 resolution, I resend it to qemu maillist for review. Signed-off-by: Bo Yang --- vbe.c | 42 ++ 1 files changed, 38 insertions(+), 4 deletions

[Qemu-devel] [RFC PATCH v3 2/5] rule.mak: allow per object cflags and libs

2013-09-09 Thread Fam Zheng
Adds extract-libs in LINK to expand any "per object libs", the syntax to define such a libs options is like: foo.o-libs := $(CURL_LIBS) in block/Makefile.objs. Similarly, foo.o-cflags := $(FOO_CFLAGS) is also supported. "foo.o" must be listed a nested var (e.g. common-obj-y) t

[Qemu-devel] [RFC PATCH v3 4/5] module: implement module loading function

2013-09-09 Thread Fam Zheng
Added three types of modules: typedef enum { MODULE_LOAD_BLOCK = 0, MODULE_LOAD_UI, MODULE_LOAD_NET, MODULE_LOAD_MAX, } module_load_type; and their loading function: void module_load(module_load_type). which loads all ".so" files in a subdir under "${

[Qemu-devel] [RFC PATCH v3 1/5] make.rule: fix $(obj) to a real relative path

2013-09-09 Thread Fam Zheng
Makefile.target includes rule.mak and unnested common-obj-y, then prefix them with '../', this will ignore object specific QEMU_CFLAGS in subdir Makefile.objs: $(obj)/curl.o: QEMU_CFLAGS += $(CURL_CFLAGS) Because $(obj) here is './block', instead of '../block'. This doesn't hurt compiling bec

[Qemu-devel] [RFC PATCH v3 3/5] Makefile: introduce common-obj-m and block-obj-m for DSO

2013-09-09 Thread Fam Zheng
Add necessary rules and flags for shared object generation. $(common-obj-m) will include $(block-obj-m), like $(common-obj-y) does for $(block-obj-y). The new rules introduced here are: 0) For all %.so compiling: QEMU_CFLAGS += -fPIC 1) %.o in $(common-obj-m) is compiled to %.o, then linked

[Qemu-devel] [RFC PATCH v3 5/5] block: build qed and curl as shared library

2013-09-09 Thread Fam Zheng
Curl and qed block drivers are built as shared object module. We have per object cflags and libs support now, move CURL_CFLAGS and CURL_LIBS from global option variables to a per object basis. "make install" is not installing them yet, manually copy it to ${prefix}/qemu/block/ to make it loaded.

[Qemu-devel] [RFC PATCH v3 0/5] Shared Library Module Support

2013-09-09 Thread Fam Zheng
This series implements feature of shared object building as described in: http://wiki.qemu.org/Features/Modules It's achieved in three steps, with extra bonus to change curl and qed to shared library modules in the end (only to demonstrate the usage, no "make install" support of .so files yet).

[Qemu-devel] [PATCH v4 7/7] tcg-ppc: Fix and cleanup tcg_out_tlb_check

2013-09-09 Thread Richard Henderson
The fix is that sparc has so many mmu modes that the last one overflowed the 16-bit signed offset we assumed would fit. Handle this, and check the new assumption at compile time. Load the tlb addend earlier for the fast path. Remove the explicit address + addend and make use of index addressing.

[Qemu-devel] [PATCH v3 7/7] tcg-ppc: Fix and cleanup tcg_out_tlb_check

2013-09-09 Thread Richard Henderson
The fix is that sparc has so many mmu modes that the last one overflowed the 16-bit signed offset we assumed would fit. Handle this, and check the new assumption at compile time. Load the tlb addend earlier for the fast path. Remove the explicit address + addend and make use of index addressing.

[Qemu-devel] [PATCH] linux-user: Check type of microMIPS break instruction

2013-09-09 Thread Kwok Cheung Yeung
microMIPS instructions that cause breakpoint exceptions come in 16-bit and 32-bit variants. When handling exceptions caused by such instructions, the instruction type needs to be taken into account when extracting the break code. The code has also been restructured for better clarity. Signed-off

Re: [Qemu-devel] [PATCH v2 7/7] tcg-ppc: Fix and cleanup tcg_out_tlb_check

2013-09-09 Thread Richard Henderson
On 09/09/2013 05:28 PM, Richard Henderson wrote: > +if (add_off >= 0x8000) { > +/* Most target env are smaller than 32k; none are larger than 64k. > + Simplify the logic here merely to offset by 0x8000, giving us a > + range just shy of 64k. Check this assumption.

[Qemu-devel] [PATCH v2 7/7] tcg-ppc: Fix and cleanup tcg_out_tlb_check

2013-09-09 Thread Richard Henderson
The fix is that sparc has so many mmu modes that the last one overflowed the 16-bit signed offset we assumed would fit. Handle this, and check the new assumption at compile time. Load the tlb addend earlier for the fast path. Remove the explicit address + addend and make use of index addressing.

[Qemu-devel] [PATCH v2 1/7] tcg-ppc: fix qemu_ld/qemu_st for AIX ABI

2013-09-09 Thread Richard Henderson
From: Paolo Bonzini For the AIX ABI, the function pointer and small area pointer need to be loaded in the trampoline. The trampoline instead is called with a normal BL instruction. Signed-off-by: Paolo Bonzini --- tcg/ppc/tcg-target.c | 17 + 1 file changed, 9 insertions(+), 8

[Qemu-devel] [PATCH v2 5/7] tcg-ppc: Cleanup tcg_out_qemu_ld/st_slow_path

2013-09-09 Thread Richard Henderson
Coding style fixes. Use TCGReg enumeration values instead of raw numbers. Don't needlessly pull the whole TCGLabelQemuLdst struct into local variables. Less conditional compilation. No functional changes. Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.c | 147 ---

[Qemu-devel] [PATCH v2 6/7] tcg-ppc: Use conditional branch and link to slow path

2013-09-09 Thread Richard Henderson
Saves one insn per slow path. Note that we can no longer use a tail call into the store helper. Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c index a5f1f9

[Qemu-devel] [PATCH v2 2/7] tcg-ppc: use new return-argument ld/st helpers

2013-09-09 Thread Richard Henderson
From: Paolo Bonzini These use a 32-bit load-of-immediate to save a mflr+addi+mtlr sequence. Tested with a Windows 98 guest (pretty much the most recent thing I could run on my PPC machine) and kvm-unit-tests's sieve.flat. The speed up for sieve.flat is as high as 10% for qemu-system-i386, 25% (n

[Qemu-devel] [PATCH v2 4/7] tcg-ppc: Avoid code for nop move

2013-09-09 Thread Richard Henderson
While these are rare from code that's been through the optimizer, it's not uncommon within the tcg backend. Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c index 24a8621..

[Qemu-devel] [PATCH v2 0/7] tcg-ppc qemu_ldst improvements

2013-09-09 Thread Richard Henderson
I'm not 100% sure what was wrong with v1 -- possibly some silly typo fixed during rebasing on top of Paolo's patches. I did that since at minimum his patches are necessary for AIX fixes. I tested my usual alpha/arm/sparc/x86 test images, and also Paulo's sieve32.flat, and they all work now. Spea

[Qemu-devel] [PATCH v2 3/7] configure: Allow command-line configure for ppc32

2013-09-09 Thread Richard Henderson
Similar to manually selecting i386 for an x86_64 host. Signed-off-by: Richard Henderson --- configure | 8 1 file changed, 8 insertions(+) diff --git a/configure b/configure index e989609..24f54f3 100755 --- a/configure +++ b/configure @@ -955,6 +955,14 @@ for opt do done case "$cp

Re: [Qemu-devel] [RFC 1/2] include/: import sizes.h from barebox

2013-09-09 Thread Richard Henderson
On 09/09/2013 10:32 AM, Aurelien Jarno wrote: >> +#define SZ_2G 0x8000 At minimum this must have a U or LL suffix. And if this one has the suffix, then for consistency the rest ought as well. r~

[Qemu-devel] [Bug 685096] Re: USB Passthrough not working for Windows 7 guest

2013-09-09 Thread Serge Hallyn
Upstream git head still gives me this problem, as does back to 0.14.0. Note however that the same qemu builds, with the same usb stick, work fine using a linux guest. The same stick, inserted to the same windows version on native hardware also works. So it's not bad hardware, it's not hardware u

Re: [Qemu-devel] [PATCH v2 05/10] raven: set a correct PCI I/O memory region

2013-09-09 Thread Peter Maydell
On 9 September 2013 21:57, Hervé Poussineau wrote: > Paolo, Peter, so, did we raise some consensus? Should I reuse > get_system_io(), or having a separate MemoryRegion is acceptable? > I think that creating a independant MemoryRegion is better, as I see no > reason why QEMU should provide a global

[Qemu-devel] [PATCH 04/10] Add a script to extract VSS SDK headers on POSIX system

2013-09-09 Thread Michael Roth
From: Tomoki Sekiyama VSS SDK(*) setup.exe is only runnable on Windows. This adds a script to extract VSS SDK headers on POSIX-systems using msitools. * http://www.microsoft.com/en-us/download/details.aspx?id=23490 From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Tomoki Sekiy

[Qemu-devel] [PATCH 01/10] configure: Support configuring C++ compiler

2013-09-09 Thread Michael Roth
From: Tomoki Sekiyama Add configuration for C++ compiler in configure and Makefiles. The C++ compiler is choosed as following: - ${CXX}, if it is specified. - ${cross_prefix}g++, if ${cross_prefix} is specified. - Otherwise, c++ is used. Currently, usage of C++ language is only for access to

[Qemu-devel] [PATCH 02/10] Add c++ keywords to QAPI helper script

2013-09-09 Thread Michael Roth
From: Tomoki Sekiyama Add c++ keywords to avoid errors in compiling with c++ compiler. This also renames class member of PciDeviceInfo to q_class. Signed-off-by: Tomoki Sekiyama Reviewed-by: Laszlo Ersek Reviewed-by: Michael Roth Signed-off-by: Michael Roth --- hmp.c |2 +- hw

[Qemu-devel] [PATCH 10/10] QMP/qemu-ga-client: Make timeout longer for guest-fsfreeze-freeze command

2013-09-09 Thread Michael Roth
From: Tomoki Sekiyama guest-fsfreeze-freeze command can take longer than 3 seconds when heavy disk I/O is running. To avoid unexpected timeout, this changes the timeout to 60 seconds (timeout of pre-commit phase of VSS). Signed-off-by: Tomoki Sekiyama Reviewed-by: Paolo Bonzini Reviewed-by: La

Re: [Qemu-devel] [PATCH 4/4] hmp: add console support for ringbuf backend

2013-09-09 Thread Luiz Capitulino
On Mon, 2 Sep 2013 17:01:48 +0800 Lei Li wrote: > This patch add console command which would suspend the monitor, > output the data that backed in the ringbuf backend to console > first, and install a new readline handler to get input back to > the ringbuf backend. Take back to the monitor once

Re: [Qemu-devel] [PATCH] configure: detect endian via compile test

2013-09-09 Thread Stefan Weil
Am 28.08.2013 10:21, schrieb James Hogan: > On 1 July 2013 04:30, Mike Frysinger wrote: >> This avoids needing to execute a program and keeping an (incomplete) >> list when cross-compiling. Signed-off-by: Mike Frysinger >> > This fixes mipsel cross compiling. I also checked it detected a mips >

Re: [Qemu-devel] [PATCH v2 05/10] raven: set a correct PCI I/O memory region

2013-09-09 Thread Hervé Poussineau
Peter Maydell a écrit : On 4 September 2013 09:11, Paolo Bonzini wrote: Il 04/09/2013 09:22, Peter Maydell ha scritto: should not be using address_space_io; but the easiest way to get there is to convert the PCI bridges one at a time as we have maintenance effort to do so. I'm not against the

[Qemu-devel] [PATCH 05/10] qemu-ga: Add configure options to specify path to Windows/VSS SDK

2013-09-09 Thread Michael Roth
From: Tomoki Sekiyama To enable VSS support in qemu-ga for Windows, header files included in VSS SDK are required. The VSS support is enabled by the configure option like below: ./configure --with-vss-sdk="/path/to/VSS SDK" If the path is omitted, it tries to search the headers from default pa

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add myself to MAINTAINERS file

2013-09-09 Thread Paul Moore
On Monday, September 09, 2013 02:04:15 PM Eduardo Otubo wrote: > Add myself to the MAINTAINERS file. I'll be looking at qemu-seccomp.c > and include/sysemu/seccomp.h. > > Signed-off-by: Eduardo Otubo > --- > As discussed in previous threads, I'm including myself to the MAINTAINERS > file so I can

[Qemu-devel] [PATCH 03/10] checkpatch.pl: Check .cpp files

2013-09-09 Thread Michael Roth
From: Tomoki Sekiyama Enable checkpatch.pl to apply the same checks as C source files for C++ files with .cpp extensions. It also adds some exceptions for C++ sources to suppress errors for: - <> used in C++ template arguments (e.g. template ) - :: used to represent namespaces (e.g. SomeCla

Re: [Qemu-devel] [PATCH RFC v2 2/2] hw/pci: handle unassigned pci addresses

2013-09-09 Thread Michael S. Tsirkin
On Mon, Sep 09, 2013 at 08:49:53PM +0200, Jan Kiszka wrote: > On 2013-09-09 20:03, Paolo Bonzini wrote: > > Il 09/09/2013 19:27, Jan Kiszka ha scritto: > >> On 2013-09-09 19:14, Peter Maydell wrote: > >>> On 9 September 2013 18:09, Jan Kiszka wrote: > On 2013-09-09 18:58, Peter Maydell wrote:

Re: [Qemu-devel] [PATCH 0/2] Try to fix problem with emulated smartcards where invalid PIN succeeds

2013-09-09 Thread Robert Relyea
On 09/08/2013 01:18 AM, Alon Levy wrote: >> I started writing a blog post yesterday about virtualized smartcards here: >> >> https://blogs.gnome.org/halfline/2013/09/08/another-smartcard-post/ >> >> and while testing what I was writing I noticed an invalid PIN worked when >> it shouldn't have. It t

[Qemu-devel] [PATCH 06/10] error: Add error_set_win32 and error_setg_win32

2013-09-09 Thread Michael Roth
From: Tomoki Sekiyama These functions help maintaining homogeneous formatting of error messages with Windows error code and description (generated by g_win32_error_message()). Signed-off-by: Tomoki Sekiyama Reviewed-by: Michael Roth Signed-off-by: Michael Roth --- include/qapi/error.h | 13

[Qemu-devel] [PATCH 08/10] qemu-ga: Call Windows VSS requester in fsfreeze command handler

2013-09-09 Thread Michael Roth
From: Tomoki Sekiyama Support guest-fsfreeze-freeze and guest-fsfreeze-thaw commands for Windows guests. When fsfreeze command is issued, it calls the VSS requester to freeze filesystems and applications. On thaw command, it again tells the VSS requester to thaw them. This also adds calling of i

Re: [Qemu-devel] [PATCH RFC v2 2/2] hw/pci: handle unassigned pci addresses

2013-09-09 Thread Michael S. Tsirkin
On Mon, Sep 09, 2013 at 08:11:25PM +0200, Paolo Bonzini wrote: > Il 09/09/2013 20:06, Jan Kiszka ha scritto: > > archive, was in the context of lock-less MMIO dispatching), and the > > consensus back then was that device-to-device DMA is generally a bug > > that is not worth supporting in all its b

Re: [Qemu-devel] [PATCH v10 00/10] qemu-ga: fsfreeze on Windows using VSS

2013-09-09 Thread Michael Roth
Quoting Peter Maydell (2013-09-09 11:22:11) > On 8 August 2013 23:35, Michael Roth wrote: > > Quoting Tomoki Sekiyama (2013-08-07 10:39:25) > >> Hi, > >> > >> I rebased the patch series to add fsfreeze for Windows qemu-ga. > >> > >> changes from v9: > >> - Fix conflict with commit e8ef31a3518c "

[Qemu-devel] [PATCH 09/10] qemu-ga: Install Windows VSS provider on `qemu-ga -s install'

2013-09-09 Thread Michael Roth
From: Tomoki Sekiyama Register QGA VSS provider library into Windows when qemu-ga is installed as Windows service ('-s install' option). It is deregistered when the service is uninstalled ('-s uninstall' option). Signed-off-by: Tomoki Sekiyama Reviewed-by: Michael Roth Signed-off-by: Michael R

[Qemu-devel] [PULL] qemu-ga: VSS/fsfreeze support for Win32

2013-09-09 Thread Michael Roth
Hi Anthony, These patches implement guest-fsfreeze-* verbs for qemu-ga on Windows by making use of Windows' VSS service. Please pull. The following changes since commit 94c2b6aff43cdfcfdfb552773a6b6b973a72ef0b: mips_malta: support up to 2GiB RAM (2013-09-09 18:42:22 +0200) are available in th

Re: [Qemu-devel] [PATCH 2/4] hmp: factor out ringbuf_print_help()

2013-09-09 Thread Luiz Capitulino
On Mon, 2 Sep 2013 17:01:46 +0800 Lei Li wrote: > Factor out ringbuf_print_help(), which will be called in > hmp_read_ringbuf_cb() reading data that can be written with > monitor_printf() to the console from ringbuf backend. > > Signed-off-by: Lei Li > --- > hmp.c | 31 +++--

Re: [Qemu-devel] [PATCH 1/4] monitor: introduce monitor_read_console

2013-09-09 Thread Luiz Capitulino
On Mon, 2 Sep 2013 17:01:45 +0800 Lei Li wrote: > This patch introduces monitor_read_console(), which will drop > into interactive mode with chardev ringbuf backend, and install > a readline handler. When the handler is invoked, the given data > will be written to ringbuf backend. > > Signed-of

Re: [Qemu-devel] [PATCH RFC v2 2/2] hw/pci: handle unassigned pci addresses

2013-09-09 Thread Michael S. Tsirkin
On Mon, Sep 09, 2013 at 07:59:06PM +0100, Peter Maydell wrote: > On 9 September 2013 19:49, Jan Kiszka wrote: > > Well, even if you resolve the locking issues in all the interesting > > devices (not impossible, just pretty costly in several regards), you > > cannot reasonably allow device A talkin

Re: [Qemu-devel] [PATCH 0/4] Define default CPU at configure time

2013-09-09 Thread Richard Henderson
On 09/07/2013 02:19 AM, Peter Maydell wrote: > On 7 September 2013 10:13, Laurent Vivier wrote: >> Le 07/09/2013 10:43, Peter Maydell a écrit : >> In fact, I don't understand why a given CPU id has been chosen to be the >> default value. I think there is a default value not because this is the >>

Re: [Qemu-devel] [RFC 1/2] include/: import sizes.h from barebox

2013-09-09 Thread Stefan Weil
Am 09.09.2013 19:32, schrieb Aurelien Jarno: > On Wed, Sep 04, 2013 at 11:35:27AM +0400, Antony Pavlov wrote: >> @@ -0,0 +1,48 @@ >> +/* >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License as published by >> + * the

Re: [Qemu-devel] [PATCH RFC v2 2/2] hw/pci: handle unassigned pci addresses

2013-09-09 Thread Jan Kiszka
On 2013-09-09 20:03, Paolo Bonzini wrote: > Il 09/09/2013 19:27, Jan Kiszka ha scritto: >> On 2013-09-09 19:14, Peter Maydell wrote: >>> On 9 September 2013 18:09, Jan Kiszka wrote: On 2013-09-09 18:58, Peter Maydell wrote: > Why is a DMA request any different from any other communication

Re: [Qemu-devel] [PATCH RFC v2 2/2] hw/pci: handle unassigned pci addresses

2013-09-09 Thread Peter Maydell
On 9 September 2013 19:49, Jan Kiszka wrote: > Well, even if you resolve the locking issues in all the interesting > devices (not impossible, just pretty costly in several regards), you > cannot reasonably allow device A talking to device B triggering a > request on A issuing a command to B... in

Re: [Qemu-devel] [PATCH RFC v2 2/2] hw/pci: handle unassigned pci addresses

2013-09-09 Thread Jan Kiszka
On 2013-09-09 20:59, Peter Maydell wrote: > On 9 September 2013 19:49, Jan Kiszka wrote: >> Well, even if you resolve the locking issues in all the interesting >> devices (not impossible, just pretty costly in several regards), you >> cannot reasonably allow device A talking to device B triggering

Re: [Qemu-devel] [PATCH 3/4] tcg-ppc: Convert to helper_ret_ld/st_mmu

2013-09-09 Thread Richard Henderson
On 09/09/2013 10:49 AM, Paolo Bonzini wrote: > I sent you my binaries offlist. And apparently there was something wrong with the binaries I built myself, as yours work. I'll now look at my ppc32 changes and see what's what. r~

[Qemu-devel] [PATCH v2 3/4] tcg/optimize: improve known-zero bits for 32-bit ops

2013-09-09 Thread Aurelien Jarno
The shl_i32 op might set some bits of the unused 32 high bits of the mask. Fix that by clearing the unused 32 high bits for all 32-bit ops except load/store which operate on tl values. Cc: Richard Henderson Cc: Paolo Bonzini Signed-off-by: Aurelien Jarno --- tcg/optimize.c |6 ++ 1 fil

Re: [Qemu-devel] [RFC 1/2] include/: import sizes.h from barebox

2013-09-09 Thread Aurelien Jarno
On Wed, Sep 04, 2013 at 11:35:27AM +0400, Antony Pavlov wrote: > The header file sizes.h is used in linux kernel, > barebox bootloader and u-boot bootloader. It provides > the short and easy-to-read names for power-of-two > numbers. The numbers like this are othen used > for memory range sizes. >

[Qemu-devel] [PULL 2/2] pc_q35: Initialize Xen.

2013-09-09 Thread Stefano Stabellini
From: Anthony PERARD Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini Acked-by: Michael S. Tsirkin --- hw/i386/pc_q35.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index d7b7c3b..464a892 100644 --- a/hw/i386/p

[Qemu-devel] [PATCH v2 1/4] tcg/optimize: fix known-zero bits for right shift ops

2013-09-09 Thread Aurelien Jarno
32-bit versions of sar and shr ops should not propagate known-zero bits from the unused 32 high bits. For sar it could even lead to wrong code being generated. Cc: Richard Henderson Cc: Paolo Bonzini Cc: qemu-sta...@nongnu.org Signed-off-by: Aurelien Jarno --- tcg/optimize.c | 21 +++

Re: [Qemu-devel] [PATCH RFC v2 2/2] hw/pci: handle unassigned pci addresses

2013-09-09 Thread Peter Maydell
On 9 September 2013 18:27, Jan Kiszka wrote: > On 2013-09-09 19:14, Peter Maydell wrote: >> On 9 September 2013 18:09, Jan Kiszka wrote: >>> Other communication between devices requiring to take the target >>> device's lock while holding the one of the initiator will be a no-go as >>> well. But u

Re: [Qemu-devel] [PATCH RFC v2 2/2] hw/pci: handle unassigned pci addresses

2013-09-09 Thread Jan Kiszka
On 2013-09-09 19:14, Peter Maydell wrote: > On 9 September 2013 18:09, Jan Kiszka wrote: >> On 2013-09-09 18:58, Peter Maydell wrote: >>> Why is a DMA request any different from any other communication >>> between two devices? >> >> Other communication between devices requiring to take the target

[Qemu-devel] [PATCH v2 0/4] tcg/optimize: fixes and improvements

2013-09-09 Thread Aurelien Jarno
This patchset first fixes known-zero bits optimization so that it works in more than a few cases, and does some further optimizations for 32-bit ops and unsigned loads. v1 -> v2: - swapped patches 1 & 2 - Cc:ed qemu-stable for patch 1 - improved description of patch 2 Aurelien Jarno (4): tcg/op

Re: [Qemu-devel] [PATCH RFC v2 2/2] hw/pci: handle unassigned pci addresses

2013-09-09 Thread Michael S. Tsirkin
On Mon, Sep 09, 2013 at 05:02:15PM +0100, Peter Maydell wrote: > On 9 September 2013 17:00, Michael S. Tsirkin wrote: > > On Mon, Sep 09, 2013 at 03:58:36PM +0100, Peter Maydell wrote: > >> On 9 September 2013 15:51, Marcel Apfelbaum wrote: > >> > On Mon, 2013-09-09 at 15:21 +0100, Peter Maydell

Re: [Qemu-devel] [PATCH RFC v2 2/2] hw/pci: handle unassigned pci addresses

2013-09-09 Thread Jan Kiszka
On 2013-09-09 19:41, Peter Maydell wrote: > On 9 September 2013 18:27, Jan Kiszka wrote: >> On 2013-09-09 19:14, Peter Maydell wrote: >>> On 9 September 2013 18:09, Jan Kiszka wrote: Other communication between devices requiring to take the target device's lock while holding the one of

Re: [Qemu-devel] [PATCH RFC v2 2/2] hw/pci: handle unassigned pci addresses

2013-09-09 Thread Peter Maydell
On 9 September 2013 17:54, Jan Kiszka wrote: > DMA requests from one device to another targeting anything else but > RAM-backed regions will have to be rejected by QEMU in the future. We > cannot map this sanely on a per-device locking model. The filtering will > take place early in the memory cor

[Qemu-devel] [PATCH v2 4/4] tcg/optimize: add known-zero bits compute for load ops

2013-09-09 Thread Aurelien Jarno
Cc: Richard Henderson Cc: Paolo Bonzini Signed-off-by: Aurelien Jarno --- tcg/optimize.c | 13 + 1 file changed, 13 insertions(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index b1f736b..044f456 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -787,6 +787,19 @@ static TCGAr

Re: [Qemu-devel] [PATCH RFC v2 2/2] hw/pci: handle unassigned pci addresses

2013-09-09 Thread Michael S. Tsirkin
On Mon, Sep 09, 2013 at 07:27:48PM +0200, Jan Kiszka wrote: > On 2013-09-09 19:14, Peter Maydell wrote: > > On 9 September 2013 18:09, Jan Kiszka wrote: > >> On 2013-09-09 18:58, Peter Maydell wrote: > >>> Why is a DMA request any different from any other communication > >>> between two devices? >

[Qemu-devel] [PATCH v2 2/4] tcg/optimize: fix known-zero bits optimization

2013-09-09 Thread Aurelien Jarno
Known-zero bits optimization is a great idea that helps to generate more optimized code. However the current implementation only works in very few cases as the computed mask is not saved. Fix this to make it really working. Cc: Richard Henderson Cc: Paolo Bonzini Signed-off-by: Aurelien Jarno

Re: [Qemu-devel] [RFC 2/2] hw/mips: use sizes.h macros

2013-09-09 Thread Aurelien Jarno
On Wed, Sep 04, 2013 at 11:35:28AM +0400, Antony Pavlov wrote: > Signed-off-by: Antony Pavlov > --- > hw/mips/mips_malta.c | 3 ++- > include/hw/mips/bios.h | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/hw/mips/mips_malta.c b/hw/mips/mips_malta.c > index ae0921c.

Re: [Qemu-devel] [RFC qom-cpu 00/41] QOM CPUState, part 13: Emptying CPU_COMMON

2013-09-09 Thread Peter Maydell
On 9 September 2013 17:39, Michael Walle wrote: > Am 2013-09-04 11:04, schrieb Andreas Färber: >> On part 11, rth said for alpha that using CPUAlphaState in >> DisasContext was bad >> and that the relevant fields should be copied into DisasContext >> instead; a few >> targets still have an env fie

Re: [Qemu-devel] [PATCH 3/4] tcg-ppc: Convert to helper_ret_ld/st_mmu

2013-09-09 Thread Paolo Bonzini
Il 09/09/2013 19:42, Richard Henderson ha scritto: > On 08/19/2013 12:42 PM, Paolo Bonzini wrote: >> Bad news... with this patch, either with or without patch 2, trying to >> execute >> sieve.flat from kvm-unit-tests (it doesn't matter if it is compiled as 32-bit >> or 64-bit, and with both i386-s

Re: [Qemu-devel] [PATCH 3/4] tcg-ppc: Convert to helper_ret_ld/st_mmu

2013-09-09 Thread Richard Henderson
On 08/19/2013 12:42 PM, Paolo Bonzini wrote: > Bad news... with this patch, either with or without patch 2, trying to execute > sieve.flat from kvm-unit-tests (it doesn't matter if it is compiled as 32-bit > or 64-bit, and with both i386-softmmu and x86_64-softmmu targets) fails as > follows on my

Re: [Qemu-devel] [PATCH] Convert ram_list to RCU DQ V4,2

2013-09-09 Thread Mike Day
On Mon, Sep 9, 2013 at 12:21 PM, Paolo Bonzini wrote: > > > @@ -601,12 +608,22 @@ static void reset_ram_globals(void) > > last_seen_block = NULL; > > last_sent_block = NULL; > > last_offset = 0; > > -last_version = ram_list.version; > > ram_bulk_stage = true; > > +smp_w

Re: [Qemu-devel] [RFC 1/2] include/: import sizes.h from barebox

2013-09-09 Thread Paolo Bonzini
Il 09/09/2013 19:32, Aurelien Jarno ha scritto: > On Wed, Sep 04, 2013 at 11:35:27AM +0400, Antony Pavlov wrote: >> The header file sizes.h is used in linux kernel, >> barebox bootloader and u-boot bootloader. It provides >> the short and easy-to-read names for power-of-two >> numbers. The numbers

Re: [Qemu-devel] [PATCH RFC v2 2/2] hw/pci: handle unassigned pci addresses

2013-09-09 Thread Paolo Bonzini
Il 09/09/2013 20:06, Jan Kiszka ha scritto: > archive, was in the context of lock-less MMIO dispatching), and the > consensus back then was that device-to-device DMA is generally a bug > that is not worth supporting in all its beauty. But if you know a > concrete scenario / guest where it matters,

[Qemu-devel] [PULL 0/2] Xen 2013-09-09

2013-09-09 Thread Stefano Stabellini
The following changes since commit df7131623daf4823e087eb1128f6c1c351519774: Merge remote-tracking branch 'bonzini/iommu-for-anthony' into staging (2013-09-05 13:38:53 -0500) are available in the git repository at: git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-2013-09-09 Anthony

Re: [Qemu-devel] [RFC] Policy for supported hosts/platforms

2013-09-09 Thread Ed Maste
On 17 July 2013 20:07, Ed Maste wrote: > On 8 July 2013 11:15, Ed Maste wrote: > > > > Ok, as soon as I can get a password (after the buildbot disk space > > issues are sorted out) I'll contribute a FreeBSD 9 amd64 builder. > > It seems the disk space / inode issue is resolved; is there anything

Re: [Qemu-devel] [PATCH] qapi-types.py: Fix enum struct sizes on i686

2013-09-09 Thread Luiz Capitulino
On Sat, 31 Aug 2013 18:36:17 -0400 Cole Robinson wrote: > Unlike other list types, enum wasn't adding any padding, which caused > a mismatch between the generated struct size and GenericList struct > size. More details in a678e26cbe89f7a27cbce794c2c2784571ee9d21 > > This crashed qemu if calling

Re: [Qemu-devel] [PATCH RFC v2 2/2] hw/pci: handle unassigned pci addresses

2013-09-09 Thread Paolo Bonzini
Il 09/09/2013 19:27, Jan Kiszka ha scritto: > On 2013-09-09 19:14, Peter Maydell wrote: >> On 9 September 2013 18:09, Jan Kiszka wrote: >>> On 2013-09-09 18:58, Peter Maydell wrote: Why is a DMA request any different from any other communication between two devices? >>> >>> Other communi

Re: [Qemu-devel] [PATCH] tci: Add implementation of rotl_i64, rotr_i64

2013-09-09 Thread Aurelien Jarno
On Mon, Sep 09, 2013 at 06:14:34PM +0200, Stefan Weil wrote: > Am 09.09.2013 16:53, schrieb Aurelien Jarno: > > On Wed, Sep 04, 2013 at 10:51:54PM +0200, Stefan Weil wrote: > >> Am 04.09.2013 22:49, schrieb Stefan Weil: > >>> It is used by qemu-ppc64 when running Debian's busybox-static. > >>> > >>

Re: [Qemu-devel] [RFC qom-cpu 00/41] QOM CPUState, part 13: Emptying CPU_COMMON

2013-09-09 Thread Michael Walle
Hi, Am 2013-09-04 11:04, schrieb Andreas Färber: On part 11, rth said for alpha that using CPUAlphaState in DisasContext was bad and that the relevant fields should be copied into DisasContext instead; a few targets still have an env field though and use it for register access and cpu_abort()

Re: [Qemu-devel] seccomp submaintainer? (was Re: [PATCH] seccomp: adding times() to the whitelist)

2013-09-09 Thread Anthony Liguori
On Mon, Sep 9, 2013 at 8:48 AM, Paolo Bonzini wrote: > Il 09/09/2013 15:20, Eduardo Otubo ha scritto: >>> Out of respect for the work that Eduardo has done, and is >>> continuing to do, with the QEMU seccomp filtering, I think Eduardo >>> should be the one to take on this role. If Eduardo declines

Re: [Qemu-devel] [PATCH RFC v2 2/2] hw/pci: handle unassigned pci addresses

2013-09-09 Thread Jan Kiszka
On 2013-09-09 18:34, Michael S. Tsirkin wrote: > On Mon, Sep 09, 2013 at 05:02:15PM +0100, Peter Maydell wrote: >> On 9 September 2013 17:00, Michael S. Tsirkin wrote: >>> On Mon, Sep 09, 2013 at 03:58:36PM +0100, Peter Maydell wrote: On 9 September 2013 15:51, Marcel Apfelbaum wrote: >

Re: [Qemu-devel] [PATCH 0/4] tcg/optimize: fixes and improvements

2013-09-09 Thread Paolo Bonzini
Il 09/09/2013 19:04, Aurelien Jarno ha scritto: > I have just checked, and it does indeed work for a few cases involving > constants. That said, it doesn't change the resulting TCG code, as these > cases were already handled by some other optimizations. > > That let me ask a question, about why th

Re: [Qemu-devel] [PATCH RFC v2 2/2] hw/pci: handle unassigned pci addresses

2013-09-09 Thread Peter Maydell
On 9 September 2013 18:09, Jan Kiszka wrote: > On 2013-09-09 18:58, Peter Maydell wrote: >> Why is a DMA request any different from any other communication >> between two devices? > > Other communication between devices requiring to take the target > device's lock while holding the one of the init

Re: [Qemu-devel] [PATCH RFC v2 2/2] hw/pci: handle unassigned pci addresses

2013-09-09 Thread Jan Kiszka
On 2013-09-09 18:58, Peter Maydell wrote: > On 9 September 2013 17:54, Jan Kiszka wrote: >> DMA requests from one device to another targeting anything else but >> RAM-backed regions will have to be rejected by QEMU in the future. We >> cannot map this sanely on a per-device locking model. The filt

[Qemu-devel] [PULL 1/2] pc: Initializing ram_memory under Xen.

2013-09-09 Thread Stefano Stabellini
From: Anthony PERARD Signed-off-by: Anthony PERARD Signed-off-by: Stefano Stabellini Acked-by: Michael S. Tsirkin CC: qemu-sta...@nongnu.org --- hw/i386/pc_piix.c|2 +- include/hw/xen/xen.h |4 +--- xen-all.c|7 --- xen-stub.c |2 +- 4 files chang

Re: [Qemu-devel] [PATCH v2] mips_malta: support up to 2GiB RAM

2013-09-09 Thread Aurelien Jarno
On Fri, Sep 06, 2013 at 01:57:44PM +0100, Paul Burton wrote: > A Malta board can support up to 2GiB of RAM. Since the unmapped kseg0/1 > regions are only 512MiB large & the latter 256MiB of those are taken up > by the IO region, access to RAM beyond 256MiB must be done through a > mapped region. In

Re: [Qemu-devel] [PATCH 0/4] tcg/optimize: fixes and improvements

2013-09-09 Thread Aurelien Jarno
On Tue, Sep 03, 2013 at 09:21:06AM +0200, Paolo Bonzini wrote: > Il 03/09/2013 08:27, Aurelien Jarno ha scritto: > > This patchset first fixes known-zero bits optimization so that it is > > actually used, and does some further optimizations for 32-bit ops and > > unsigned loads. > > > > Aurelien J

[Qemu-devel] [PATCH] MAINTAINERS: Add myself to MAINTAINERS file

2013-09-09 Thread Eduardo Otubo
Add myself to the MAINTAINERS file. I'll be looking at qemu-seccomp.c and include/sysemu/seccomp.h. Signed-off-by: Eduardo Otubo --- As discussed in previous threads, I'm including myself to the MAINTAINERS file so I can take care of the sandbox feature in Qemu. MAINTAINERS |6 ++ 1 fil

Re: [Qemu-devel] [PATCH v10 00/10] qemu-ga: fsfreeze on Windows using VSS

2013-09-09 Thread Peter Maydell
On 8 August 2013 23:35, Michael Roth wrote: > Quoting Tomoki Sekiyama (2013-08-07 10:39:25) >> Hi, >> >> I rebased the patch series to add fsfreeze for Windows qemu-ga. >> >> changes from v9: >> - Fix conflict with commit e8ef31a3518c "qemu-ga: build it even if !system" >> >> changes from v8: >>

Re: [Qemu-devel] [PATCH] Convert ram_list to RCU DQ V4,2

2013-09-09 Thread Paolo Bonzini
Il 09/09/2013 17:13, Mike Day ha scritto: > Changes from V4.1: > > * Correct memory barriers for ram_list globals. > > Changes from V4: > > * rebased on https://github.com/bonzini/qemu/tree/rcu > commit 965f3b2aac93bca6df50c86fb17a06b3c856fa30 > > Changes from V3: > > * now passes virt-test

Re: [Qemu-devel] [PATCH] tci: Add implementation of rotl_i64, rotr_i64

2013-09-09 Thread Stefan Weil
Am 09.09.2013 16:53, schrieb Aurelien Jarno: > On Wed, Sep 04, 2013 at 10:51:54PM +0200, Stefan Weil wrote: >> Am 04.09.2013 22:49, schrieb Stefan Weil: >>> It is used by qemu-ppc64 when running Debian's busybox-static. >>> >>> Signed-off-by: Stefan Weil >>> --- >>> >>> This patch is also useful f

Re: [Qemu-devel] [PATCH RFC v2 2/2] hw/pci: handle unassigned pci addresses

2013-09-09 Thread Peter Maydell
On 9 September 2013 17:00, Michael S. Tsirkin wrote: > On Mon, Sep 09, 2013 at 03:58:36PM +0100, Peter Maydell wrote: >> On 9 September 2013 15:51, Marcel Apfelbaum wrote: >> > On Mon, 2013-09-09 at 15:21 +0100, Peter Maydell wrote: >> >> No, it's perfectly possible for a bus master transaction >

Re: [Qemu-devel] [PATCH RFC v2 2/2] hw/pci: handle unassigned pci addresses

2013-09-09 Thread Michael S. Tsirkin
On Mon, Sep 09, 2013 at 03:21:44PM +0100, Peter Maydell wrote: > On 9 September 2013 15:04, Marcel Apfelbaum wrote: > > By the way, I am not sure that the upstream transactions (DMA) > > can actually end with a master abort. Master abort would happen > > if a transaction will not be claimed by any

  1   2   3   >