[Qemu-devel] [Bug 1221966] [NEW] SIGSEGV in static_code_gen_buffer

2013-09-06 Thread William D Colburn
Public bug reported: Trying to run 'ls' (or, anything else as far as I can tell) from a SunOS 5.8 box under RHEL 6.4 linux, I get a segfault. I've tried qemu-1.5.3, qemu-1.6.0, and I fetched git://git.qemu-project.org/qemu.git. I've also tried a statically linked sh from /sbin/ and it also segfa

Re: [Qemu-devel] [RFC v4 4/5] hw/arm/digic: add UART support

2013-09-06 Thread Antony Pavlov
On Fri, 6 Sep 2013 14:40:14 +0100 Peter Maydell wrote: > On 6 September 2013 14:00, Antony Pavlov wrote: > > On Fri, 6 Sep 2013 08:25:20 +0100 > > Peter Maydell wrote: > >> You can deduce its existence though -- does the > >> UART let you feed two or three characters to it > >> at faster than w

[Qemu-devel] [PATCH v3 3/3] audio: remove CONFIG_MIXEMU configure option

2013-09-06 Thread Bandan Das
Signed-off-by: Bandan Das --- audio/mixeng.c | 6 -- configure| 8 hw/audio/hda-codec.c | 30 -- 3 files changed, 44 deletions(-) diff --git a/audio/mixeng.c b/audio/mixeng.c index 02a9d9f..0e4976f 100644 --- a/audio/mixeng.c +++ b/aud

[Qemu-devel] [PATCH v3 2/3] hda-codec: make mixemu selectable at runtime

2013-09-06 Thread Bandan Das
Define PARAM so that we have two versions of the "desc_codec and family" structs. Add a property called "mixer" whose default value depends on whether CONFIG_MIXEMU is defined or not which will help us call the appropriate instance init functions. Signed-off-by: Bandan Das --- hw/audio/hda-codec

[Qemu-devel] [PATCH v3 1/3] hda-codec: refactor common definitions into a header file

2013-09-06 Thread Bandan Das
Move common defines and structs to a header file. The next commit will include it twice, once for a device with a mixer, and once for device without a mixer. Signed-off-by: Bandan Das --- hw/audio/hda-codec-common.h | 449 hw/audio/hda-codec.c

[Qemu-devel] [PATCH v3 0/3] Make mixer emulation configurable at runtime

2013-09-06 Thread Bandan Das
Currently, hda-codec mixer emulation can only be enabled by using the "--enable-mixemu" option to configure at compile time with the default value being off. These patches enable making mixer emulation selectable at runtime which is more convenient. Consequently, the last patch in this series remo

Re: [Qemu-devel] [PATCH v2 3/3] audio: remove CONFIG_MIXEMU configure option and enable mixemu by default

2013-09-06 Thread Bandan Das
Gerd Hoffmann writes: > On Do, 2013-09-05 at 18:24 -0400, Bandan Das wrote: >> Set mixer property to on by default. > > The "by default" in the commit message is a bit misleading. There is no > default any more once CONFIG_MIXEMU is gone ... I was actually referring to the mixemu property which

Re: [Qemu-devel] ARM virtio-serial not showing up (was: Re: ARM virtio-scsi - disks never show up)

2013-09-06 Thread Doug Goldstein
On Fri, Sep 6, 2013 at 1:01 PM, Richard W.M. Jones wrote: > > Have you tried virtio-serial on ARM at all? The port never shows up. > I believe it does not work. Cole Robinson's patchset for libvirt to support ARM mentions that -device virtio-serial-device for serial does not work and you have to

Re: [Qemu-devel] [RFC] TCG unit testing

2013-09-06 Thread Rob Landley
On 09/02/2013 11:07:03 AM, Aurelien Jarno wrote: On Fri, Aug 23, 2013 at 12:47:43PM -0700, Richard Henderson wrote: > I've been thinking for a while about how to reliably test TCG backends, and > maybe how to do regression testing on them. Having to begin the test from a > guest binary, espe

Re: [Qemu-devel] [PATCH v2 2/3] hda-codec: make mixemu selectable at runtime

2013-09-06 Thread Bandan Das
Gerd Hoffmann writes: >> --- a/hw/audio/hda-codec.c >> +++ b/hw/audio/hda-codec.c >> @@ -118,7 +118,20 @@ static void hda_codec_parse_fmt(uint32_t format, struct >> audsettings *as) >> #define QEMU_HDA_AMP_NONE(0) >> #define QEMU_HDA_AMP_STEPS 0x4a >> >> +#ifdef CONFIG_MIXEMU >> +#defi

Re: [Qemu-devel] ARM virtio-serial not showing up (was: Re: ARM virtio-scsi - disks never show up)

2013-09-06 Thread Tom Sutcliffe
I can't check this until Monday, but from memory: > Do all virtio-* devices need to be ported specially to virtio-mmio or > should they (in theory at least) just work? They're intended to just work, although some command line shenanigans are required at the moment. I've had other virtio devices

[Qemu-devel] [PATCH 0/4] Define default CPU at configure time

2013-09-06 Thread Laurent Vivier
This series of patch allows to set the default CPU used by linux-user qemu. When qemu is used in a container as a binfmt interpreter we can't use the environment variable QEMU_CPU to set the CPU id. The two last patches allows to display the default CPU id when "-cpu ?" is used. Only two archs ar

[Qemu-devel] [PATCH 3/4] linux-user,m68k: display default cpu

2013-09-06 Thread Laurent Vivier
From: Laurent Vivier Signed-off-by: Laurent Vivier --- target-m68k/helper.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target-m68k/helper.c b/target-m68k/helper.c index 00a7a08..123329a 100644 --- a/target-m68k/helper.c +++ b/target-m68k/helper.c @@ -52,6 +52,11 @@ static void m68

[Qemu-devel] [PATCH 1/4] linux-user: define default cpu model in configure instead of linux-user/main.c

2013-09-06 Thread Laurent Vivier
From: Laurent Vivier Signed-off-by: Laurent Vivier --- configure | 14 ++ linux-user/main.c | 36 +--- 2 files changed, 15 insertions(+), 35 deletions(-) diff --git a/configure b/configure index e989609..ef84abe 100755 --- a/configure +++ b/c

[Qemu-devel] [Bug 1221797] [NEW] virt-install gets stuck during downloading install.img

2013-09-06 Thread Patrick-gramsl
Public bug reported: I have tried to install CentOS 6.4 using the latest version of all kvm related tools. My problem is that I get stuck at arround 20% during the download of the file install.img. Everything before that works just fine. My Server is based on CentOS 6.4 I am using the following

[Qemu-devel] [PATCH 4/4] linux-user,arm: display default cpu

2013-09-06 Thread Laurent Vivier
From: Laurent Vivier Signed-off-by: Laurent Vivier --- target-arm/helper.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index e51ef20..26863d4 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -1809,6 +1809,11 @@ static void arm_

[Qemu-devel] [PATCH 2/4] linux-user: specify the cpu model during configure

2013-09-06 Thread Laurent Vivier
From: Laurent Vivier This patch allows to set the default cpu model for a given architecture, for instance: configure --target-list=m68k-linux-user --m68k-default-cpu=m68040 Signed-off-by: Laurent Vivier --- configure | 9 + 1 file changed, 9 insertions(+) diff --git a/configure b/c

Re: [Qemu-devel] qemu-user-x86_64 segfaults on armv5 (WAS: qemu-user + networking issues / segfaults)

2013-09-06 Thread Christof Schulze
Hello Richard, using your vdso patch from today that takes into account vtime as well, running linux-x86_64 code on arm via qemu-user works! Thank you very much for your support and energy! As promised on IRC the software is dead-slow but I do not mind since it is a batch application anyways. I

[Qemu-devel] [PULL 32/42] block: use bdrv_has_zero_init to return BDRV_BLOCK_ZERO

2013-09-06 Thread Stefan Hajnoczi
From: Paolo Bonzini Alternatively, this could use a "discard zeroes data" flag returned by bdrv_get_info. Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- block.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/block.c b/

Re: [Qemu-devel] [PATCH 2/2] osdep: warn if open(O_DIRECT) on fails with EINVAL

2013-09-06 Thread Jeff Cody
On Thu, Aug 22, 2013 at 11:29:03AM +0200, Stefan Hajnoczi wrote: > Print a warning when opening a file O_DIRECT fails with EINVAL. This > saves users a lot of time trying to figure out the EINVAL error, which > is typical when attempting to open a file O_DIRECT on Linux tmpfs. > > Reported-by: De

Re: [Qemu-devel] [PATCH 5/6] linux-user: add support of binfmt_misc 'O' flag

2013-09-06 Thread Laurent Vivier
Le 06/09/2013 18:17, Peter Maydell a écrit : On 30 August 2013 00:46, Laurent Vivier wrote: The binfmt_misc module can calculate the credentials and security token according to the binary instead of to the interpreter if the 'C' flag is enabled. To be able to execute non-readable binaries, thi

[Qemu-devel] [PATCHv2 1/3] seccomp: adding blacklist support

2013-09-06 Thread Eduardo Otubo
Adding a system call blacklist right before the vcpus starts. This filter is composed by the system calls that can't be executed after the guests are up. This list should be refined as the whitelist is, with as much testing as we can do using virt-test. Signed-off-by: Eduardo Otubo --- include/s

[Qemu-devel] [PATCHv3 3/3] seccomp: general fixes

2013-09-06 Thread Eduardo Otubo
1) On qemu-seccomp.c:255, the variable ctx was being used uninitialized; now it's initialized with NULL and it's being checked at the end of the function. 2) Changed the name of the command line option from "enable" to "sandbox" for a better understanding from user side. Signed-off-by: Eduardo

[Qemu-devel] [PATCH] linux-user: Fix wrong use of stat instead of stat64 for sparc64

2013-09-06 Thread Stefan Weil
This test case is fixed now: sparc64-linux-user/qemu-sparc64 /usr/gnemul/qemu-sparc64/busybox ls -l block.c Signed-off-by: Stefan Weil --- linux-user/syscall.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index ecead51..e498a9

[Qemu-devel] ARM virtio-serial not showing up (was: Re: ARM virtio-scsi - disks never show up)

2013-09-06 Thread Richard W.M. Jones
Have you tried virtio-serial on ARM at all? The port never shows up. Do all virtio-* devices need to be ported specially to virtio-mmio or should they (in theory at least) just work? Is there a command one can use in the guest to list virtio-mmio devices, similar to lspci? Are virtio-mmio devi

[Qemu-devel] [PULL 01/42] throttle: Add a new throttling API implementing continuous leaky bucket.

2013-09-06 Thread Stefan Hajnoczi
From: Benoît Canet Implement the continuous leaky bucket algorithm devised on IRC as a separate module. Signed-off-by: Benoit Canet Signed-off-by: Stefan Hajnoczi --- include/qemu/throttle.h | 110 ++ util/Makefile.objs | 1 + util/throttle.c | 396 +

[Qemu-devel] [PULL 12/42] block: implement reference count for BlockDriverState

2013-09-06 Thread Stefan Hajnoczi
From: Fam Zheng Introduce bdrv_ref/bdrv_unref to manage the lifecycle of BlockDriverState. They are unused for now but will used to replace bdrv_delete() later. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- block.c | 21 + include/block/bloc

[Qemu-devel] [PULL 40/42] dataplane: Fix startup race.

2013-09-06 Thread Stefan Hajnoczi
From: Cornelia Huck Avoid trying to setup dataplane again if dataplane setup is already in progress. This may happen if an eventfd is triggered during setup. I saw this occasionally with an experimental s390 irqfd implementation: virtio_blk_handle_output -> virtio_blk_data_plane_start -> virtio

[Qemu-devel] [PATCH] tcg-sparc: Fix parenthesis warning

2013-09-06 Thread Richard Henderson
error: suggest parentheses around comparison in operand of ‘&’ [-Werror=parentheses] Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/sparc/tcg-target.h b/tcg/sparc/tcg-target.h index 2edf858..1ff2922 100644 ---

[Qemu-devel] [PULL 34/42] qemu-img: add a "map" subcommand

2013-09-06 Thread Stefan Hajnoczi
From: Paolo Bonzini This command dumps the metadata of an entire chain, in either tabular or JSON format. Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- qemu-img-cmds.hx | 6 ++ qemu-img.c | 191 +++ 2 files changed,

[Qemu-devel] [PULL 00/42] Block patches

2013-09-06 Thread Stefan Hajnoczi
A couple of patch series make this pull request large: * Benoit Canet's new I/O throttling implementation * Fam Zheng's BlockDriverState refcount * Paolo Bonzini's get_block_status() and qemu-img map command The following changes since commit df7131623daf4823e087eb1128f6c1c351519774: Merge

[Qemu-devel] [PATCHv2 0/3] seccomp: adding blacklist support with command line

2013-09-06 Thread Eduardo Otubo
v2: The blacklist works exactly the opposite as the whitelist. I set the default behaiour to SCMP_ACT_ALLOW and the exceptions to SCMP_ACT_KILL; remembering it inherits the behavior from the previous installed whitelist. This patch series also contain the command line support for this feature and

[Qemu-devel] [RFC v3 5/6] qemu-img create: Emit filename on error

2013-09-06 Thread Max Reitz
bdrv_img_create generally does not emit the target filename, although this is pretty important information. Therefore, prepend its error message with the output filename (if an error occurs). Signed-off-by: Max Reitz --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[Qemu-devel] [PULL 28/42] block: make bdrv_has_zero_init return false for copy-on-write-images

2013-09-06 Thread Stefan Hajnoczi
From: Paolo Bonzini This helps implementing is_allocated on top of get_block_status. Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- block.c| 5 + qemu-img.c | 9 + 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/block.c

[Qemu-devel] [RFC v3 6/6] qcow2: Use Error parameter

2013-09-06 Thread Max Reitz
Employ usage of the new Error ** parameter in qcow2_open, qcow2_create and associated functions. Signed-off-by: Max Reitz --- block/qcow2.c | 134 ++ 1 file changed, 88 insertions(+), 46 deletions(-) diff --git a/block/qcow2.c b/block/qcow

[Qemu-devel] [PATCHv2 2/3] seccomp: adding command line support for blacklist

2013-09-06 Thread Eduardo Otubo
New command line options for the seccomp blacklist feature: $ qemu -sandbox on[,strict=] The strict parameter will turn on or off the new system call blacklist Signed-off-by: Eduardo Otubo --- qemu-options.hx | 8 +--- vl.c| 11 ++- 2 files changed, 15 insertions(+),

[Qemu-devel] [PULL 26/42] block: expect errors from bdrv_co_is_allocated

2013-09-06 Thread Stefan Hajnoczi
From: Paolo Bonzini Some bdrv_is_allocated callers do not expect errors, but the fallback in qcow2.c might make other callers trip on assertion failures or infinite loops. Fix the callers to always look for errors. Cc: qemu-sta...@nongnu.org Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH] linux-user: Fix wrong use of stat instead of stat64 for sparc64

2013-09-06 Thread Peter Maydell
On 6 September 2013 17:46, Stefan Weil wrote: > This test case is fixed now: > sparc64-linux-user/qemu-sparc64 /usr/gnemul/qemu-sparc64/busybox ls -l block.c > > Signed-off-by: Stefan Weil > --- > linux-user/syscall.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/li

[Qemu-devel] [PULL 31/42] block: return get_block_status data and flags for formats

2013-09-06 Thread Stefan Hajnoczi
From: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- block/cow.c | 8 +++- block/qcow.c | 9 - block/qcow2.c| 16 ++-- block/qed.c | 35 --- block/sheepdog.c | 2

[Qemu-devel] [PULL 06/42] qemu-iotests: Adjust test result 039

2013-09-06 Thread Stefan Hajnoczi
From: Max Reitz The moved OFLAG_COPIED check in qcow2_check_refcounts results in a different output from test 039 (mismatches are now found after the general refcount check (as far as any remain)). This patch adjusts the expected test result accordingly. Signed-off-by: Max Reitz Signed-off-by:

[Qemu-devel] [PULL 16/42] nbd: use BlockDriverState refcnt

2013-09-06 Thread Stefan Hajnoczi
From: Fam Zheng Previously, nbd calls drive_get_ref() on the drive of bs. A BDS doesn't always have associated dinfo, which nbd doesn't care either. We already have BDS ref count, so use it to make it safe for a BDS w/o blockdev. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- blo

[Qemu-devel] [PULL 36/42] raw-posix: return get_block_status data and flags

2013-09-06 Thread Stefan Hajnoczi
From: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- block/raw-posix.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index dbc65b0..d011cfd 100644 --- a/block/

Re: [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist

2013-09-06 Thread Eduardo Otubo
Hello, Any chance to get this patch applied? Thanks! On 09/04/2013 11:11 AM, Paul Moore wrote: On Wednesday, September 04, 2013 09:25:08 AM Eduardo Otubo wrote: This was causing Qemu process to hang when using -sandbox on. Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=100

Re: [Qemu-devel] [RFC PATCH v2 1/6] make.rule: fix $(obj) to a real relative path

2013-09-06 Thread Lluís Vilanova
Fam Zheng writes: [...] > Because $(obj) here is './block', instead of '../block'. This doesn't > hurt compiling because we basically build all .o from top Makefile, > before entering Makefile.target, but it will affact arriving per-object > libs support. I'm curious. What's the reason to not use

[Qemu-devel] [PULL 22/42] block: keep bs->total_sectors up to date even for growable block devices

2013-09-06 Thread Stefan Hajnoczi
From: Paolo Bonzini If a BlockDriverState is growable, after every write we need to check if bs->total_sectors might have changed. With this change, bdrv_getlength does not need anymore a system call. Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- block.c | 5 - 1 file c

Re: [Qemu-devel] [PATCH 5/6] linux-user: add support of binfmt_misc 'O' flag

2013-09-06 Thread Peter Maydell
On 30 August 2013 00:46, Laurent Vivier wrote: > The binfmt_misc module can calculate the credentials and security > token according to the binary instead of to the interpreter if the > 'C' flag is enabled. > > To be able to execute non-readable binaries, this flag implies 'O' > flag. When 'O' fla

[Qemu-devel] [PULL 11/42] iscsi: use bdrv_new() instead of stack structure

2013-09-06 Thread Stefan Hajnoczi
From: Fam Zheng BlockDriverState structure needs bdrv_new() to initialize refcnt, don't allocate a local structure variable and memset to 0, becasue with coming refcnt implementation, bdrv_unref will crash if bs->refcnt not initialized to 1. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoc

[Qemu-devel] [PULL 24/42] block: do not use ->total_sectors in bdrv_co_is_allocated

2013-09-06 Thread Stefan Hajnoczi
From: Paolo Bonzini This is more robust when the device has removable media. Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- block.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index f27bab6..4a10fb1 100644 --- a/block.c +++ b/b

Re: [Qemu-devel] [RFC] Introducing CoroCheck and proposal for a blocking_fn annotation

2013-09-06 Thread Gabriel Kerneis
On Fri, Sep 06, 2013 at 04:36:47PM +0100, Charlie Shepherd wrote: > However, I'm not sure it makes sense to use blocking_fn until the > convert-block series (which currently needs a respin after Stefan's > review) is fully upstreamed. Maybe this patch makes most sense at > the start of that series?

[Qemu-devel] [PULL 18/42] qmp: Documentation for BLOCK_IMAGE_CORRUPTED

2013-09-06 Thread Stefan Hajnoczi
From: Max Reitz Add an appropriate entry describing this event and its parameters into qmp-events.txt. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- QMP/qmp-events.txt | 22 ++ 1 file changed, 22 insertions(+)

[Qemu-devel] [PULL 30/42] block: define get_block_status return value

2013-09-06 Thread Stefan Hajnoczi
From: Paolo Bonzini Define the return value of get_block_status. Bits 0, 1, 2 and 9-62 are valid; bit 63 (the sign bit) is reserved for errors. Bits 3-8 are left for future extensions. The return code is compatible with the old is_allocated API: if a driver only returns 0 or 1 (aka BDRV_BLOCK_

[Qemu-devel] [PULL 39/42] block: look for zero blocks in bs->file

2013-09-06 Thread Stefan Hajnoczi
From: Paolo Bonzini Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- block.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index 3c39769..a325efc 100644 --- a/block.c +++ b/block.c @@ -3075,7 +3075

Re: [Qemu-devel] [PATCH] linux-user: Fix wrong use of stat instead of stat64 for sparc64

2013-09-06 Thread Stefan Weil
Am 06.09.2013 19:16, schrieb Peter Maydell: > On 6 September 2013 17:46, Stefan Weil wrote: >> This test case is fixed now: >> sparc64-linux-user/qemu-sparc64 /usr/gnemul/qemu-sparc64/busybox ls -l >> block.c >> >> Signed-off-by: Stefan Weil >> --- >> linux-user/syscall.c |2 +- >> 1 file c

[Qemu-devel] [PULL 41/42] qemu-iotests: Whitespace cleanup

2013-09-06 Thread Stefan Hajnoczi
From: Kevin Wolf These scripts used to have a four characters indentation, with eight consecutive spaces converted into a tab. Convert everything into spaces. Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/check | 234 ++--- tests/qemu

[Qemu-devel] [PULL 42/42] qemu-iotests: Fixed test case 026

2013-09-06 Thread Stefan Hajnoczi
From: Kevin Wolf The reference output for test case 026 hasn't been updated in a long time and it's one of the "known failing" cases. This patch updates the reference output so that unintentional changes can be reliably detected again. The problem with this test case is that it produces differen

[Qemu-devel] [RFC v3 4/6] block: Error parameter for create functions

2013-09-06 Thread Max Reitz
Add an Error ** parameter to bdrv_create and its associated functions to allow more specific error messages. Signed-off-by: Max Reitz --- block.c | 80 +++ block/cow.c | 4 ++- block/qcow.c | 4 ++- block/qcow2.c

Re: [Qemu-devel] vfio for platform devices - 9/5/2012 - minutes

2013-09-06 Thread Yoder Stuart-B08248
Adding Will... > -Original Message- > From: Sethi Varun-B16395 > Sent: Friday, September 06, 2013 11:56 AM > To: Yoder Stuart-B08248; Wood Scott-B07421; Bhushan Bharat-R65777; 'Peter > Maydell'; 'Santosh Shukla'; 'Alex Williamson'; 'Alexander Graf'; > 'Antonios Motakis'; 'Christoffer Dall'

Re: [Qemu-devel] vfio for platform devices - 9/5/2012 - minutes

2013-09-06 Thread Sethi Varun-B16395
I have a query about the ARM SMMU driver. In the ARM smmu driver I see, that bus notifiers are registered for both amba and platform bus. Amba is the I/O interconnect, right? Why is bus notifier required for the amba bus? -Varun > -Original Message- > From: Yoder Stuart-B08248 > Sent:

[Qemu-devel] [PULL 25/42] block: remove bdrv_is_allocated_above/bdrv_co_is_allocated_above distinction

2013-09-06 Thread Stefan Hajnoczi
From: Paolo Bonzini Now that bdrv_is_allocated detects coroutine context, the two can use the same code. Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- block.c | 46 -- block/commit.c|

[Qemu-devel] [PULL 15/42] xen_disk: simplify blk_disconnect with refcnt

2013-09-06 Thread Stefan Hajnoczi
From: Fam Zheng We call bdrv_attach_dev when initializing whether or not bs is created locally, so call bdrv_detach_dev and let the refcnt handle the lifecycle. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- hw/block/xen_disk.c | 11 +-- 1 file changed, 5 insertions(+), 6

[Qemu-devel] [RFC v3 3/6] block: Error parameter for open functions

2013-09-06 Thread Max Reitz
Add an Error ** parameter to bdrv_open, bdrv_file_open and associated functions to allow more specific error messages. Signed-off-by: Max Reitz --- block.c | 100 -- block/blkdebug.c | 4 +- block/blkverify.c | 8 +++- bl

Re: [Qemu-devel] [PATCH 6/6] scripts: create a template to use with lxc-create

2013-09-06 Thread Peter Maydell
On 30 August 2013 00:46, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier > --- > scripts/lxc-cross-debian | 353 > +++ > 1 file changed, 353 insertions(+) > create mode 100755 scripts/lxc-cross-debian > > diff --git a/scripts/lxc-cross-debian b

[Qemu-devel] [RFC v3 2/6] bdrv: Use "Error" for creating images

2013-09-06 Thread Max Reitz
Add an Error ** parameter to BlockDriver.bdrv_create to allow more specific error messages. Signed-off-by: Max Reitz --- block.c | 2 +- block/cow.c | 3 ++- block/gluster.c | 2 +- block/iscsi.c | 3 ++- block/qcow.c | 3 ++- bl

Re: [Qemu-devel] [PATCH 6/6] scripts: create a template to use with lxc-create

2013-09-06 Thread Laurent Vivier
Le 06/09/2013 18:33, Peter Maydell a écrit : On 30 August 2013 00:46, Laurent Vivier wrote: Signed-off-by: Laurent Vivier --- scripts/lxc-cross-debian | 353 +++ 1 file changed, 353 insertions(+) create mode 100755 scripts/lxc-cross-debian diff

[Qemu-devel] [PULL 35/42] docs, qapi: document qemu-img map

2013-09-06 Thread Stefan Hajnoczi
From: Paolo Bonzini Eric Blake also requested including the output in qapi-schema.json, so that it is published through the introspection mechanism. Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- qapi-schema.json | 29 + qemu-img.texi| 55 +

[Qemu-devel] [RFC v3 0/6] block: Error parameter for opening/creating images

2013-09-06 Thread Max Reitz
This RFC adds an Error ** parameter to bdrv_open, bdrv_file_open, bdrv_create and the respective functions provided by a block driver. This results in more specific error information than just -errno provided to the user when opening or creating images (disregarding the fact that block drivers oft

[Qemu-devel] [PULL 21/42] cow: do not call bdrv_co_is_allocated

2013-09-06 Thread Stefan Hajnoczi
From: Paolo Bonzini As we change bdrv_is_allocated to gather more information from bs and bs->file, it will become a bit slower. It is still appropriate for online jobs, but not for reads/writes. Call the internal function instead. Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-

[Qemu-devel] [PULL 02/42] throttle: Add units tests

2013-09-06 Thread Stefan Hajnoczi
From: Benoît Canet Signed-off-by: Benoit Canet Signed-off-by: Stefan Hajnoczi --- tests/Makefile| 2 + tests/test-throttle.c | 481 ++ 2 files changed, 483 insertions(+) create mode 100644 tests/test-throttle.c diff --git a/tests/Make

[Qemu-devel] [PULL 09/42] aio / timers: fix build of test/test-aio.c on non-linux platforms

2013-09-06 Thread Stefan Hajnoczi
From: Alex Bligh tests/test-aio.c used pipe2 which is Linux only. Use qemu_pipe and qemu_set_nonblock for portabillity. Addition of O_CLOEXEC is a harmless bonus. Signed-off-by: Alex Bligh Signed-off-by: Stefan Hajnoczi --- tests/test-aio.c | 11 +-- 1 file changed, 9 insertions(+), 2

[Qemu-devel] [PULL 27/42] qemu-img: always probe the input image for allocated sectors

2013-09-06 Thread Stefan Hajnoczi
From: Paolo Bonzini qemu-img convert can assume "that sectors which are unallocated in the input image are present in both the output's and input's base images". However it is only doing this if the output image returns true for bdrv_has_zero_init(). Testing bdrv_has_zero_init() does not make m

[Qemu-devel] [PULL 37/42] raw-posix: report unwritten extents as zero

2013-09-06 Thread Stefan Hajnoczi
From: Paolo Bonzini These are created for example with XFS_IOC_ZERO_RANGE. Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- block/raw-posix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index d011cfd..1b4

[Qemu-devel] [PULL 33/42] block: return BDRV_BLOCK_ZERO past end of backing file

2013-09-06 Thread Stefan Hajnoczi
From: Paolo Bonzini If the sectors are unallocated and we are past the end of the backing file, they will read as zero. Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- block.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c i

[Qemu-devel] [PULL 10/42] vvfat: use bdrv_new() to allocate BlockDriverState

2013-09-06 Thread Stefan Hajnoczi
From: Fam Zheng we need bdrv_new() to properly initialize BDS, don't allocate memory manually. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- block/vvfat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vvfat.c b/block/vvfat.c index cd3b8ed..a827d91 100

[Qemu-devel] [PULL 19/42] cow: make reads go at a decent speed

2013-09-06 Thread Stefan Hajnoczi
From: Paolo Bonzini Do not do two reads for each sector; load each sector of the bitmap and use bitmap operations to process it. Writes are still dog slow! Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- block/cow.c | 54 ++

[Qemu-devel] [PULL 20/42] cow: make writes go at a less indecent speed

2013-09-06 Thread Stefan Hajnoczi
From: Paolo Bonzini Only sync once per write, rather than once per sector. Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- block/cow.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/block/cow.c b/block/cow.c in

[Qemu-devel] [PULL 08/42] w32: Fix access to host devices (regression)

2013-09-06 Thread Stefan Hajnoczi
From: Stefan Weil QEMU failed to open host devices like \\.\PhysicalDrive0 (first hard disk) since some time (commit 8a79380b8ef1b02d2abd705dd026a18863b09020?). Those devices use hdev_open which did not use the latest API for options. This resulted in a fatal runtime error: Block protocol 'ho

[Qemu-devel] [RFC v3 1/6] bdrv: Use "Error" for opening images

2013-09-06 Thread Max Reitz
Add an Error ** parameter to BlockDriver.bdrv_open and BlockDriver.bdrv_file_open to allow more specific error messages. Signed-off-by: Max Reitz --- block.c | 4 ++-- block/blkdebug.c | 3 ++- block/blkverify.c | 3 ++- block/bochs.c | 3 ++- b

[Qemu-devel] [PULL 23/42] block: make bdrv_co_is_allocated static

2013-09-06 Thread Stefan Hajnoczi
From: Paolo Bonzini bdrv_is_allocated can detect coroutine context and go through a fast path, similar to other block layer functions. Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- block.c | 24 +++- block/backup.c

[Qemu-devel] [PULL 17/42] block: use BDS ref for block jobs

2013-09-06 Thread Stefan Hajnoczi
From: Fam Zheng Block jobs used drive_get_ref(drive_get_by_blockdev(bs)) to avoid BDS being deleted. Now we have BDS reference count, and block jobs don't care about dinfo, so replace them to get cleaner code. It is also the safe way when BDS has no drive info. Signed-off-by: Fam Zheng Signed-o

[Qemu-devel] [PULL 38/42] block: add default get_block_status implementation for protocols

2013-09-06 Thread Stefan Hajnoczi
From: Paolo Bonzini Protocols return raw data, so you can assume the offsets to pass through unchanged. Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- block.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c i

Re: [Qemu-devel] [PATCH 3/6] linux-user: allow use of TIOCGSID

2013-09-06 Thread Peter Maydell
On 30 August 2013 00:46, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell -- PMM

[Qemu-devel] [PULL 29/42] block: introduce bdrv_get_block_status API

2013-09-06 Thread Stefan Hajnoczi
From: Paolo Bonzini For now, bdrv_get_block_status is just another name for bdrv_is_allocated. The next patches will add more flags. This also touches all block drivers with a mostly mechanical rename. The sole exception is cow; because it calls cow_co_is_allocated from the read code, we keep t

Re: [Qemu-devel] [PATCH 4/6] linux-user: add some IPV6 commands in setsockop()

2013-09-06 Thread Peter Maydell
On 30 August 2013 00:46, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH 2/6] linux-user: Add setsockopt(SO_ATTACH_FILTER)

2013-09-06 Thread Peter Maydell
On 30 August 2013 00:46, Laurent Vivier wrote: > This is needed to be able to run dhclient. > > Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH 1/6] linux-user: convert /proc/net/route when endianess differs

2013-09-06 Thread Peter Maydell
On 30 August 2013 00:46, Laurent Vivier wrote: > This patch allows to have IP addresses in correct order > in the case of "netstat -nr" when the endianess of the > guest differs from one of the host. > > Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [RFC] Introducing CoroCheck and proposal for a blocking_fn annotation

2013-09-06 Thread Kevin Wolf
Am 06.09.2013 um 18:05 hat Gabriel Kerneis geschrieben: > On Fri, Sep 06, 2013 at 04:36:47PM +0100, Charlie Shepherd wrote: > > However, I'm not sure it makes sense to use blocking_fn until the > > convert-block series (which currently needs a respin after Stefan's > > review) is fully upstreamed.

[Qemu-devel] [PULL 03/42] block: Enable the new throttling code in the block layer.

2013-09-06 Thread Stefan Hajnoczi
From: Benoît Canet Signed-off-by: Benoit Canet Signed-off-by: Stefan Hajnoczi --- block.c | 338 +- block/qapi.c | 21 ++- blockdev.c| 102 +++--- include/block/block.h | 1 - include/bloc

[Qemu-devel] [PULL 14/42] migration: omit drive ref as we have bdrv_ref now

2013-09-06 Thread Stefan Hajnoczi
From: Fam Zheng block-migration.c does not actually use DriveInfo anywhere. Hence it's safe to drive ref code, we really only care about referencing BDS. Signed-off-by: Fam Zheng Signed-off-by: Stefan Hajnoczi --- block-migration.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) d

[Qemu-devel] [PULL 13/42] block: make bdrv_delete() static

2013-09-06 Thread Stefan Hajnoczi
From: Fam Zheng Manage BlockDriverState lifecycle with refcnt, so bdrv_delete() is no longer public and should be called by bdrv_unref() if refcnt is decreased to 0. This is an identical change because effectively, there's no multiple reference of BDS now: no caller of bdrv_ref() yet, only bdrv_

[Qemu-devel] [PULL 07/42] add qemu-img convert -n option (skip target volume creation)

2013-09-06 Thread Stefan Hajnoczi
From: Alexandre Derumier Add a -n option to skip volume creation on qemu-img convert. This is useful for targets such as rbd / ceph, where the target volume may already exist; we cannot always rely on qemu-img convert to create the image, as dependent on the output format, there may be parameters

[Qemu-devel] [PULL 05/42] block: Add iops_size to do the iops accounting for a given io size.

2013-09-06 Thread Stefan Hajnoczi
From: Benoît Canet This feature can be used in case where users are avoiding the iops limit by doing jumbo I/Os hammering the storage backend. Signed-off-by: Benoit Canet Signed-off-by: Stefan Hajnoczi --- block/qapi.c | 3 +++ blockdev.c | 17 ++--- hmp.c|

[Qemu-devel] [PULL v2 3/5] e1000: add interrupt mitigation support

2013-09-06 Thread Stefan Hajnoczi
From: Vincenzo Maffione This patch partially implements the e1000 interrupt mitigation mechanisms. Using a single QEMUTimer, it emulates the ITR register (which is the newer mitigation register, recommended by Intel) and approximately emulates RADV and TADV registers. TIDV and RDTR register funct

Re: [Qemu-devel] [PULL 0/4] Net patches

2013-09-06 Thread Stefan Hajnoczi
On Thu, Sep 05, 2013 at 01:38:23PM -0500, Anthony Liguori wrote: > Stefan Hajnoczi writes: > > > The following changes since commit 4ff78e0dbcd5c795962567fdc1b31e9e03c55b07: > > > > Merge remote-tracking branch 'luiz/queue/qmp' into staging (2013-08-30 > > 12:26:04 -0500) > > > > are available

[Qemu-devel] [PULL v2 1/5] tap: Use numbered tap/tun devices on all *BSD OS's

2013-09-06 Thread Stefan Hajnoczi
From: Brad Smith The following patch simplifies the *BSD tap/tun code and makes use of numbered tap/tun interfaces on all *BSD OS's. NetBSD has a patch in their pkgsrc tree to make use of this feature and DragonFly also supports this as well. Signed-off-by: Brad Smith Signed-off-by: Stefan Hajn

[Qemu-devel] [PULL v2 5/5] ne2000: mark I/O as LITTLE_ENDIAN

2013-09-06 Thread Stefan Hajnoczi
From: Aurelien Jarno Now that the memory subsystem is propagating the endianness correctly, the ne2000 device should have its I/O ports marked as LITTLE_ENDIAN, as PCI devices are little endian. This makes the ne2000 NIC to work again on PowerPC. Cc: qemu-sta...@nongnu.org Cc: Stefan Hajnoczi

Re: [Qemu-devel] [PULL 0/4] Net patches

2013-09-06 Thread Stefan Hajnoczi
On Fri, Sep 06, 2013 at 08:03:27AM +0200, Paolo Bonzini wrote: > Il 05/09/2013 23:02, Aurelien Jarno ha scritto: > > It would be nice if you can get the pcnet fix in your tree. For the ne2k > > patch, as reported it might break the non-PCI version. I have to look at > > that more in details, probab

[Qemu-devel] [PULL v2 2/5] net: Rename send_queue to incoming_queue

2013-09-06 Thread Stefan Hajnoczi
From: Jan Kiszka Each networking client has a queue for packets that could not yet be delivered to that client. Calling this queue "send_queue" is highly confusing as it has nothing to to with packets send from this client but to it. Avoid this confusing by renaming it to "incoming_queue". Signe

[Qemu-devel] [PULL 04/42] block: Add support for throttling burst max in QMP and the command line.

2013-09-06 Thread Stefan Hajnoczi
From: Benoît Canet The max parameter of the leaky bucket throttling algorithm can be used to allow the guest to do bursts. The max value is a pool of I/O that the guest can use without being throttled at all. Throttling is triggered once this pool is empty. Signed-off-by: Benoit Canet Signed-of

Re: [Qemu-devel] [RFC] Introducing CoroCheck and proposal for a blocking_fn annotation

2013-09-06 Thread Charlie Shepherd
On 06/09/2013 15:30, Gabriel Kerneis wrote: Note that CoroCheck has been written as a plugin to CIL [5]. Contrary to CPC, which is still somewhat of a prototype (although a pretty good one!), CIL is a solid piece of software, packaged in both Fedora and (very soon) Debian. CoroCheck makes use of

[Qemu-devel] [PULL v2 4/5] vmxnet3: Eliminate __packed redefined warning

2013-09-06 Thread Stefan Hajnoczi
From: Brad Smith This eliminates a warning about __packed being redefined as exposed by the vmxnet3 code. __packed is not used anywhere in the vmxnet3 code. CChw/net/vmxnet3.o In file included from hw/net/vmxnet3.c:29: hw/net/vmxnet3.h:37:1: warning: "__packed" redefined In file included f

  1   2   >