Re: [Qemu-devel] [PATCH 08/18] migration-local: introduce qemu_fopen_local()

2013-08-27 Thread Paolo Bonzini
Il 28/08/2013 05:26, Lei Li ha scritto: >>> >>> RAMBlock structs are not visible outside of exec.c and arch_init.c, >>> how did you do this? >> >> Hi Michael, >> >> Good catch! >> Actually this is the 'Known issue' that I listed in the cover >> letter, and I planed to ask suggestions on this. >> >>

Re: [Qemu-devel] [PATCH v2 7/7] smbios: Set system manufacturer, product & version by default

2013-08-27 Thread Michael S. Tsirkin
On Tue, Aug 27, 2013 at 05:22:19PM -0600, Eric Blake wrote: > On 08/27/2013 11:04 AM, Michael S. Tsirkin wrote: > > On Fri, Aug 16, 2013 at 03:18:34PM +0200, arm...@redhat.com wrote: > >> From: Markus Armbruster > >> > >> Currently, we get SeaBIOS defaults: manufacturer Bochs, product Bochs, > >>

[Qemu-devel] [PATCH 9/9] char: use the new tcp_chr_detach to dedup code

2013-08-27 Thread Amit Shah
Signed-off-by: Amit Shah --- qemu-char.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 2caab95..db256f8 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2514,10 +2514,7 @@ static gboolean tcp_chr_read(GIOChannel *chan, GIOCondition c

[Qemu-devel] [PATCH 7/9] char: use the new pty_chr_detach to dedup code

2013-08-27 Thread Amit Shah
Signed-off-by: Amit Shah --- qemu-char.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 88ed131..d667e8c 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -1141,10 +1141,7 @@ static void pty_chr_state(CharDriverState *chr, int connected

[Qemu-devel] [PATCH 5/9] char: introduce udp_chr_detach()

2013-08-27 Thread Amit Shah
Remove any registered callbacks if a frontend is detached. CC: Signed-off-by: Amit Shah --- qemu-char.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/qemu-char.c b/qemu-char.c index befecf2..4b26ff9 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2198,6 +2198,16 @@ typedef str

[Qemu-devel] [PATCH 6/9] char: use the new fd_chr_detach to dedup code

2013-08-27 Thread Amit Shah
Signed-off-by: Amit Shah --- qemu-char.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 4b26ff9..88ed131 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -844,10 +844,7 @@ static gboolean fd_chr_read(GIOChannel *chan, GIOConditi

[Qemu-devel] [PATCH 4/9] char: introduce pty_chr_detach()

2013-08-27 Thread Amit Shah
Remove any registered callbacks if a frontend is detached. CC: Signed-off-by: Amit Shah --- qemu-char.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/qemu-char.c b/qemu-char.c index 91ae1da..befecf2 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -1036,6 +1036,16 @@ typedef str

[Qemu-devel] Problems with QEMU sdcard while using glib 2.33.8

2013-08-27 Thread Taimoor Mirza
Hi Guys, I am building QEMU on Windows using MinGW + Msys. If I build QEMU with Glib 2.28, qemu binary works fine for sdcard. I noticed that QEMU binary has dependency on libgthread-2.0-0.dll in this case. But when I build QEMU with Glib 2.33.8 version, its sdcard option throw error at run time. A

[Qemu-devel] [PATCH 0/9] char: fix segfault on chardev detach

2013-08-27 Thread Amit Shah
This series fixes a segfault when a frontend is detached from a chardev, and the chardev had a pending callback registered. Further details in patch 1. Please review, Amit Shah (9): char: remove watch callback on chardev detach from frontend char: introduce tcp_chr_detach() char: introduce

[Qemu-devel] [PATCH 3/9] char: introduce fd_chr_detach()

2013-08-27 Thread Amit Shah
Remove any registered callbacks if a frontend is detached. CC: Signed-off-by: Amit Shah --- qemu-char.c | 12 1 file changed, 12 insertions(+) diff --git a/qemu-char.c b/qemu-char.c index e235334..91ae1da 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -806,6 +806,17 @@ typedef stru

[Qemu-devel] [PATCH 8/9] char: use the new udp_chr_detach to dedup code

2013-08-27 Thread Amit Shah
Signed-off-by: Amit Shah --- qemu-char.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index d667e8c..2caab95 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2240,10 +2240,7 @@ static gboolean udp_chr_read(GIOChannel *chan, GIOCon

[Qemu-devel] [PATCH 2/9] char: introduce tcp_chr_detach()

2013-08-27 Thread Amit Shah
Remove any registered callbacks if a frontend is detached. CC: Signed-off-by: Amit Shah --- qemu-char.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/qemu-char.c b/qemu-char.c index f27fdb6..e235334 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2321,6 +2321,16 @@ typedef str

[Qemu-devel] [PATCH 1/9] char: remove watch callback on chardev detach from frontend

2013-08-27 Thread Amit Shah
If a frontend device releases the chardev (via unplug), the chr handlers are set to NULL via qdev's exit callbacks invoking qemu_chr_add_handlers(). If the chardev had a pending operation, a callback will be invoked, which will try to access data in the just-released frontend, causing a NULL point

[Qemu-devel] [PATCH] target-arm: Report unimplemented opcodes (LOG_UNIMP)

2013-08-27 Thread Stefan Weil
These unimplemented opcodes are handled like illegal opcodes, but they are used in existing code. We should at least report when they are executed. Signed-off-by: Stefan Weil --- When running a QEMU system emulation of an ARM system (Raspberry PI), Linux booted, but when I tried to run a user se

Re: [Qemu-devel] [PATCH 11/18] migration: introduce capability localhost

2013-08-27 Thread Lei Li
On 08/21/2013 11:08 PM, Eric Blake wrote: On 08/21/2013 01:18 AM, Lei Li wrote: Introduce migration capability localhost. Signed-off-by: Lei Li --- include/migration/migration.h |3 +++ migration.c | 12 qapi-schema.json |8 +++- 3

Re: [Qemu-devel] [PATCH v2 1/2] tcg/mips: detect available host instructions at runtime

2013-08-27 Thread li guang
Hi, Aurelien, to nitpick, use_mips32r2_instructions may already indicate use_mips32_instructions,right? so during ISA detection, we may first do mips32r2, then mips32 detection is unnecessary, I think. 在 2013-08-28三的 00:11 +0200,Aurelien Jarno写道: > Now that TCG supports enabling and disabling o

Re: [Qemu-devel] [PATCH 08/18] migration-local: introduce qemu_fopen_local()

2013-08-27 Thread Lei Li
On 08/23/2013 03:44 PM, Lei Li wrote: On 08/23/2013 04:42 AM, Michael R. Hines wrote: On 08/21/2013 03:18 AM, Lei Li wrote: Introduce read/write backend of QEMUFileLocal used by localhost migration. The unix domain socket will be replaced by PIPE with vmsplice mechanism. Signed-off-by: Lei Li

Re: [Qemu-devel] [RFC] aio: add aio_context_acquire() and aio_context_release()

2013-08-27 Thread Wenchao Xia
The APIs look nice to me, have some minor comments. > It can be useful to run an AioContext from a thread which normally does > not "own" the AioContext. For example, request draining can be > implemented by acquiring the AioContext and looping aio_poll() until all > requests have been complet

[Qemu-devel] Would virtio support 64 bit address for vring virtqueue?

2013-08-27 Thread Xie, Huawei
I am developing virtio user space poll mode network driver. We allocate vring physical memory from huge page. On VMs with less than 4GB memory, it works well. But on VMs with like 8GB memory, huge page are all allocated from high end memory. So would virtio support 64bit address for vring virt

Re: [Qemu-devel] [RFC] aio: add aio_context_acquire() and aio_context_release()

2013-08-27 Thread Wenchao Xia
于 2013-8-27 23:12, Paolo Bonzini 写道: Il 27/08/2013 16:39, Stefan Hajnoczi ha scritto: It can be useful to run an AioContext from a thread which normally does not "own" the AioContext. For example, request draining can be implemented by acquiring the AioContext and looping aio_poll() until all r

Re: [Qemu-devel] [PATCH V8 00/13] monitor: support sub command group in auto completion and help

2013-08-27 Thread Wenchao Xia
于 2013-8-22 21:12, Luiz Capitulino 写道: On Thu, 22 Aug 2013 17:16:23 +0800 Wenchao Xia wrote: 于 2013-8-20 22:04, Luiz Capitulino 写道: On Tue, 30 Jul 2013 12:03:11 -0400 Luiz Capitulino wrote: On Fri, 26 Jul 2013 11:20:29 +0800 Wenchao Xia wrote: This series make auto completion and help f

Re: [Qemu-devel] [PATCH V9 00/15] monitor: support sub command group in auto completion and help

2013-08-27 Thread Wenchao Xia
于 2013-8-27 21:19, Luiz Capitulino 写道: On Tue, 27 Aug 2013 20:39:37 +0800 Wenchao Xia wrote: 于 2013-8-27 9:43, Wenchao Xia 写道: 于 2013-8-26 23:55, Luiz Capitulino 写道: On Fri, 23 Aug 2013 16:17:52 +0800 Wenchao Xia wrote: This series make auto completion and help functions works normal for

Re: [Qemu-devel] [PATCH V2 1/3] qemu-iotests: add unix socket help program

2013-08-27 Thread Wenchao Xia
于 2013-8-28 9:11, Eric Blake 写道: On 08/26/2013 08:52 PM, Wenchao Xia wrote: This program can do a sendmsg call to transfer fd with unix socket, which is not supported in python2. The built binary will not be deleted in clean, but it is a existing issue in ./tests, which should be solved in anot

Re: [Qemu-devel] [libvirt] [PATCH v2] kvm: warn if num cpus is greater than num recommended

2013-08-27 Thread Eric Blake
On 08/23/2013 07:24 AM, Andrew Jones wrote: > The comment in kvm_max_vcpus() states that it's using the recommended > procedure from the kernel API documentation to get the max number > of vcpus that kvm supports. It is, but by always returning the > maximum number supported. The maximum number sho

Re: [Qemu-devel] [PATCH v2] qcow2: Change default for new images to compat=1.1

2013-08-27 Thread Eric Blake
On 08/27/2013 02:08 AM, Kevin Wolf wrote: > By the time that qemu 1.7 will be released, enough time will have passed > since qemu 1.1, which is the first version to understand version 3 > images, that changing the default shouldn't hurt many people any more > and the benefits of using the new forma

Re: [Qemu-devel] [PATCH V2 1/3] qemu-iotests: add unix socket help program

2013-08-27 Thread Eric Blake
On 08/26/2013 08:52 PM, Wenchao Xia wrote: > This program can do a sendmsg call to transfer fd with unix > socket, which is not supported in python2. > > The built binary will not be deleted in clean, but it is a > existing issue in ./tests, which should be solved in another > patch. > > Signed-o

Re: [Qemu-devel] [PATCH 1/2] kvm irqfd: support msimessage to irq translation in PHB

2013-08-27 Thread Alexey Kardashevskiy
On 08/27/2013 08:32 PM, Benjamin Herrenschmidt wrote: > On Tue, 2013-08-27 at 13:26 +0300, Michael S. Tsirkin wrote: >> e would end up with something like >>> >>> diff --git a/kvm-all.c b/kvm-all.c >>> index 716860f..ca3251e 100644 >>> --- a/kvm-all.c >>> +++ b/kvm-all.c >>> @@ -1190,6 +1190,10 @@

Re: [Qemu-devel] [PATCH v3 2/4] timer: protect timers_state's clock with seqlock

2013-08-27 Thread liu ping fan
On Tue, Aug 27, 2013 at 11:18 PM, Alex Bligh wrote: > > On 27 Aug 2013, at 04:21, Liu Ping Fan wrote: > >> Note in tcg mode, vm_clock still read inside BQL, so icount is > > Should refer to QEMU_CLOCK_VIRTUAL if after my patches > Will change the log. >> left without private lock's protection. As

Re: [Qemu-devel] [PATCH v3 4/4] timer: make qemu_clock_enable sync between disable and timer's cb

2013-08-27 Thread liu ping fan
On Tue, Aug 27, 2013 at 11:32 PM, Alex Bligh wrote: > > On 27 Aug 2013, at 04:21, Liu Ping Fan wrote: > >> After disabling the QemuClock, we should make sure that no QemuTimers >> are still in flight. To implement that with light overhead, we resort >> to QemuEvent. The caller of disabling will wa

Re: [Qemu-devel] [PATCH v2 7/7] smbios: Set system manufacturer, product & version by default

2013-08-27 Thread Eric Blake
On 08/27/2013 11:04 AM, Michael S. Tsirkin wrote: > On Fri, Aug 16, 2013 at 03:18:34PM +0200, arm...@redhat.com wrote: >> From: Markus Armbruster >> >> Currently, we get SeaBIOS defaults: manufacturer Bochs, product Bochs, >> no version. Best SeaBIOS can do, but we can provide better defaults: >>

Re: [Qemu-devel] [PATCH V18 24/25] qapi: query-command-line-options outputs def_value_str

2013-08-27 Thread Eric Blake
On 08/27/2013 08:12 AM, Kevin Wolf wrote: > Am 13.08.2013 um 06:32 hat Dong Xu Wang geschrieben: >> QMP command query-command-line-options shows details information of >> parameters, since added def_value_str, also output it in the QMP >> command. >> >> v16->v17: >> 1) add "Since 1.6" tag. >> 2) re

Re: [Qemu-devel] questions about the bdrv_co_do_readv()

2013-08-27 Thread Yaodong Yang
I checked the argument, it looks like the same. I guess my confusion is the follows: code version: qemu-1.5.1 step 1: file: block-migration.c, function: static int mig_save_device_bulk(QEMUFile *f, BlkMigDevState *bmds) Inside this function, qemu calls the following function to read a

[Qemu-devel] [PATCH v2 2/2] tcg/mips: only enable ext8s/ext16s ops on MIPS32R2

2013-08-27 Thread Aurelien Jarno
On MIPS ext8s and ext16s ops are implemented with a dedicated instruction only on MIPS32R2, otherwise the same kind of implementation than at TCG level (shift left followed by shift right) is used. Change that by only implementing the ext8s and ext16s ops on MIPS32R2 so that optimizations can be d

[Qemu-devel] [PATCH v2 0/2] tcg/mips: host detection

2013-08-27 Thread Aurelien Jarno
This patch series improve the MIPS TCG backend by detecting the available instructions at runtime, and by enabling the corresponding ops. v1 -> v2: - Detect MIPS32 detection by using MUL instead of MULT Aurelien Jarno (2): tcg/mips: detect available host instructions at runtime tcg/mips: onl

[Qemu-devel] [PATCH v2 1/2] tcg/mips: detect available host instructions at runtime

2013-08-27 Thread Aurelien Jarno
Now that TCG supports enabling and disabling ops at runtime, it's possible to detect the available host instructions at runtime, and enable the corresponding ops accordingly. Unfortunately it's not easy to probe for available instructions on MIPS, the information is partially available in /proc/cp

Re: [Qemu-devel] [PATCH 0/4] tcg: Add muluh and mulsh opcodes

2013-08-27 Thread Richard Henderson
Ping. r~ On 08/17/2013 04:26 PM, Richard Henderson wrote: > We have -- or will have -- several targets which have a native > multiply-highpart instruction: ppc*, ia64, aarch64, alpha. > > If we leave only the mul[us]2 opcode with which to expose this, > we have to handle the register allocation

[Qemu-devel] [PATCH 7/7] tcg-i386: Perform tail call to qemu_ret_ld*_mmu

2013-08-27 Thread Richard Henderson
This does require the fast path always load to the function return value register, but apparently the loaded value usually needs to be spilled back to its memory slot anyway so the change in register does not really change much. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 107 ++

[Qemu-devel] [PATCH 2/7] tcg-i386: Don't perform GETPC adjustment in TCG code

2013-08-27 Thread Richard Henderson
Since we now perform it inside the helper, no need to do it here. This also lets us perform a tail-call from the store slow path to the helper. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 34 ++ 1 file changed, 14 insertions(+), 20 deletions(-) d

[Qemu-devel] [PATCH 4/7] target: Include softmmu_exec.h where forgotten

2013-08-27 Thread Richard Henderson
Several targets forgot to include softmmu_exec.h, which would break them with a header cleanup to follow. Signed-off-by: Richard Henderson --- target-lm32/op_helper.c | 2 ++ target-moxie/helper.c| 1 + target-ppc/mmu_helper.c | 2 ++ target-unicore32/op_helper.c | 2 ++ target

[Qemu-devel] [PATCH 6/7] tcg: Introduce zero and sign-extended versions of load helpers

2013-08-27 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/exec/softmmu_template.h | 58 - tcg/i386/tcg-target.c | 6 ++--- tcg/tcg.h | 21 ++- 3 files changed, 64 insertions(+), 21 deletions(-) diff --git a/include/exec/soft

[Qemu-devel] [PATCH 0/7] Further tcg ldst improvements

2013-08-27 Thread Richard Henderson
This is the follow-on that Aurelien and I discussed in thread for the PULL of the previous patch set. The bulk of the patch set is rearranging things so that we can elide the move+extend instruction following the call to the load helper function. With the value properly extended for the register,

[Qemu-devel] [PATCH 1/7] exec: Reorganize the GETRA/GETPC macros

2013-08-27 Thread Richard Henderson
Always define GETRA; use __builtin_extract_return_addr, rather than having a special case for s390. Split GETPC_ADJ out of GETPC; use 2 universally, rather than having a special case for arm. Rename GETPC_LDST to GETRA_LDST to indicate that it does not contain the GETPC_ADJ value. Likewise with

[Qemu-devel] [PATCH 5/7] exec: Split softmmu_defs.h

2013-08-27 Thread Richard Henderson
The _cmmu helpers can be moved to exec-all.h. The helpers that are used from TCG will shortly need access to tcg_target_long so move their declarations into tcg.h. This requires minor include adjustments to all TCG backends. Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 5

[Qemu-devel] [PATCH 3/7] exec: Rename USUFFIX to LSUFFIX

2013-08-27 Thread Richard Henderson
In a following patch, there will be confusion between multiple "unsigned" suffixes; rename this one so as to imply "load". Signed-off-by: Richard Henderson --- include/exec/softmmu_template.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/exec/softmmu_te

Re: [Qemu-devel] [PATCH] pc: reduce duplication, fix PIIX descriptions

2013-08-27 Thread Michael S. Tsirkin
On Tue, Aug 27, 2013 at 04:19:39PM -0300, Eduardo Habkost wrote: > On Tue, Aug 27, 2013 at 07:13:49PM +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 27, 2013 at 01:09:23PM -0300, Eduardo Habkost wrote: > > > On Tue, Aug 27, 2013 at 09:51:22AM +0200, Markus Armbruster wrote: > > > > "Michael S. Ts

Re: [Qemu-devel] Boot Problems Windows XP guest

2013-08-27 Thread Anthony Liguori
On Aug 27, 2013 4:32 PM, "Paolo Bonzini" wrote: > > Il 27/08/2013 22:26, Erik Rull ha scritto: > > Hi Stefan, > > > > which BIOS is selected by default? > > QEMU only ships with SeaBIOS. > > > It's more a guess, there must be a > > change between 1.2.0 and 1.6.0 that prevents a simple Windows XP f

Re: [Qemu-devel] Boot Problems Windows XP guest

2013-08-27 Thread Paolo Bonzini
Il 27/08/2013 22:26, Erik Rull ha scritto: > Hi Stefan, > > which BIOS is selected by default? QEMU only ships with SeaBIOS. > It's more a guess, there must be a > change between 1.2.0 and 1.6.0 that prevents a simple Windows XP from > booting completely, if the guest HDD image is placed on a SS

Re: [Qemu-devel] [PULL 0/7] Improve tcg ldst optimization

2013-08-27 Thread Aurelien Jarno
On Mon, Aug 26, 2013 at 02:00:05PM -0700, Richard Henderson wrote: > > The following is a rebase of the i386 portion of the v2 patch set. > That incorporated the minor comments from Aurelien from v1. This > pull request omits the ARM portion of the patch set, as that has > yet to receive any revi

[Qemu-devel] [PATCH V2] i386: forward CPUID cache leaves when -cpu host is used

2013-08-27 Thread Benoît Canet
Some users running cpu intensive tasks checking the cache CPUID leaves at startup and making decisions based on the result reported that the guest was not reflecting the host CPUID leaves when -cpu host is used. This patch fix this. Signed-off-by: Benoit Canet --- target-i386/cpu.c | 19 +

[Qemu-devel] [PATCH V2] forward cpuid leaves when using -cpu host

2013-08-27 Thread Benoît Canet
This patch uses directly cpuid_host to forward the informations instead of storing a variable number of leaves in the cpu states. since v1: use index as argument to cpuid_host Benoît Canet (1): i386: forward CPUID cache leaves when -cpu host is used target-i386/cpu.c | 19 +++

[Qemu-devel] [PATCH] i386: forward CPUID cache leaves when -cpu host is used

2013-08-27 Thread Benoît Canet
Some users running cpu intensive tasks checking the cache CPUID leaves at startup and making decisions based on the result reported that the guest was not reflecting the host CPUID leaves when -cpu host is used. This patch fix this. Signed-off-by: Benoit Canet --- target-i386/cpu.c | 19 +

[Qemu-devel] [PATCH] forward cpuid leaves when using -cpu host

2013-08-27 Thread Benoît Canet
This patch uses directly cpuid_host to forward the informations instead of storing a variable number of leaves in the cpu states. Benoît Canet (1): i386: forward CPUID cache leaves when -cpu host is used target-i386/cpu.c | 19 +++ target-i386/cpu.h |1 + 2 files changed,

Re: [Qemu-devel] Boot Problems Windows XP guest

2013-08-27 Thread Erik Rull
Stefan Hajnoczi wrote: On Mon, Aug 26, 2013 at 11:52:26AM +0200, Erik Rull wrote: is it possible to get back to the "legacy" BIOS instead of the (u)efi based BIOS? I have problems booting the guest on a SSD HDD, there it reboots infinitely, when running the guest on a rotating HDD, it works. On

Re: [Qemu-devel] [PATCH] target-mips: fix get_physical_address() #if 0 build error

2013-08-27 Thread Richard Henderson
On 08/27/2013 09:48 AM, Yongbok Kim wrote: > #if 0 > -qemu_log(TARGET_FMT_lx " %d %d => " TARGET_FMT_lx " %d (%d)\n", > +qemu_log(TARGET_FMT_lx " %d %d => %" HWADDR_PRIx " %d (%d)\n", > address, rw, access_type, *physical, *prot, ret); > #endif While by itself correct, consi

[Qemu-devel] [PATCH 0/2] Make mixer emulation configurable at runtime

2013-08-27 Thread Bandan Das
Currently, hda-codec mixer emulation can only be enabled by using the "--enable-mixemu" option to configure at compile time. These patches add the option to make it configurable at runtime as well. An example usage could be a qemu cmdline : "-device hda-duplex,mixer=(on/off)" although this is

Re: [Qemu-devel] [PATCH] pc: reduce duplication, fix PIIX descriptions

2013-08-27 Thread Eduardo Habkost
On Tue, Aug 27, 2013 at 07:13:49PM +0300, Michael S. Tsirkin wrote: > On Tue, Aug 27, 2013 at 01:09:23PM -0300, Eduardo Habkost wrote: > > On Tue, Aug 27, 2013 at 09:51:22AM +0200, Markus Armbruster wrote: > > > "Michael S. Tsirkin" writes: > > > > > > > We have a lot of code duplication between

[Qemu-devel] [PATCH 2/2] hda-codec: make mixemu selectable at runtime

2013-08-27 Thread Bandan Das
Define PARAM so that we have two versions of the "desc_codec and family" structs. Add a property called "mixer" whose default value depends on whether CONFIG_MIXEMU is defined or not which will help us call the appropriate instance init functions. Signed-off-by: Bandan Das --- hw/audio/hda-code

[Qemu-devel] [PATCH 1/2] hda-codec: refactor common definitions into a header file

2013-08-27 Thread Bandan Das
Move common defines and structs to a header file. We will then include these twice in hda-codec.c - a version with mixer enabled and another with not enabled. Signed-off-by: Bandan Das --- hw/audio/hda-codec-common.h | 427 hw/audio/hda-codec.c

[Qemu-devel] [Bug 1212402] Re: Enabling KVM with recent QEMU builds from GIT hang at boot on Ubuntu Precise AMD64 kernel 3.8.0

2013-08-27 Thread Julius Schwartzenberg
It seems reverting this exact commit also works around the problem. I have attached a patch against current head. ** Patch added: "Patch to revert problematic commit" https://bugs.launchpad.net/qemu/+bug/1212402/+attachment/3790513/+files/0001-Revert-235e8982ad393e5611cb892df54881c872eea9e1.pa

[Qemu-devel] [PATCH 2/2] configure: Remove unneeded redirections of stderr (pkg-config --exists)

2013-08-27 Thread Stefan Weil
Predicate options (--exists, --atleast-version, ...) of pkg-config dont't print error messages to stderr, so redirecting stderr is not necessary. Combining a predicate option with --modversion is not necessary for tests. Instead of testing with --modversion, --exists can be used. Signed-off-by: S

[Qemu-devel] [PATCH 1/2] configure: Remove unneeded redirections of stderr (pkg-config --cflags, --libs)

2013-08-27 Thread Stefan Weil
For existing libraries, pkg-config --cflags and pkg-config --libs won't print error messages to stderr, so redirecting stderr is not necessary. Signed-off-by: Stefan Weil --- configure | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/co

Re: [Qemu-devel] [PATCH] qemu: Fix cross compilation for mipsel

2013-08-27 Thread Richard Henderson
On 08/27/2013 09:02 AM, James Hogan wrote: > The configure script was setting HOST_WORDS_BIGENDIAN for all $cpu = > mips|mips64 when cross compiling, since endianness cannot be detected by > running a test program. This includes little endian MIPS though. It > didn't cause any build errors but does

Re: [Qemu-devel] [RFC] aio: add aio_context_acquire() and aio_context_release()

2013-08-27 Thread Alex Bligh
--On 27 August 2013 16:39:45 +0200 Stefan Hajnoczi wrote: This patch implements aio_context_acquire() and aio_context_release(). Note that existing aio_poll() callers do not need to worry about acquiring and releasing - it is only needed when multiple threads will call aio_poll() on the sam

Re: [Qemu-devel] [PATCH v2 7/7] smbios: Set system manufacturer, product & version by default

2013-08-27 Thread Michael S. Tsirkin
On Fri, Aug 16, 2013 at 03:18:34PM +0200, arm...@redhat.com wrote: > From: Markus Armbruster > > Currently, we get SeaBIOS defaults: manufacturer Bochs, product Bochs, > no version. Best SeaBIOS can do, but we can provide better defaults: > manufacturer QEMU, product & version taken from QEMUMac

[Qemu-devel] [PATCH] target-mips: fix get_physical_address() #if 0 build error

2013-08-27 Thread Yongbok Kim
From: James Hogan In get_physical_address() is a qemu_log() call inside an #if 0 block. When enabled the following build error is hit: target-mips/helper.c In function ‘get_physical_address’: target-mips/helper.c:220:13: error: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5

Re: [Qemu-devel] [PATCH] pc: reduce duplication, fix PIIX descriptions

2013-08-27 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, Aug 27, 2013 at 09:51:22AM +0200, Markus Armbruster wrote: >> "Michael S. Tsirkin" writes: >> >> > We have a lot of code duplication between machine types, >> > this increases with each new machine type >> > and each new field. >> > >> > This has already introd

Re: [Qemu-devel] [PATCH] pc: reduce duplication, fix PIIX descriptions

2013-08-27 Thread Michael S. Tsirkin
On Tue, Aug 27, 2013 at 01:09:23PM -0300, Eduardo Habkost wrote: > On Tue, Aug 27, 2013 at 09:51:22AM +0200, Markus Armbruster wrote: > > "Michael S. Tsirkin" writes: > > > > > We have a lot of code duplication between machine types, > > > this increases with each new machine type > > > and each

Re: [Qemu-devel] [PATCH] pc: reduce duplication, fix PIIX descriptions

2013-08-27 Thread Eduardo Habkost
On Tue, Aug 27, 2013 at 09:51:22AM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > We have a lot of code duplication between machine types, > > this increases with each new machine type > > and each new field. > > > > This has already introduced a minor bug: description > > f

Re: [Qemu-devel] [PATCH] block: Remove redundant assertion

2013-08-27 Thread Stefan Weil
Am 27.08.2013 17:56, schrieb Kevin Wolf: > The failing condition is checked immediately before the assertion, so > keeping the assertion is kind of redundant. Are you sure that it is not the check which is redundant? Is file == NULL allowed in this 'else' branch? Regards, Stefan > > Signed-off-b

[Qemu-devel] [PATCH] qemu: Fix cross compilation for mipsel

2013-08-27 Thread James Hogan
The configure script was setting HOST_WORDS_BIGENDIAN for all $cpu = mips|mips64 when cross compiling, since endianness cannot be detected by running a test program. This includes little endian MIPS though. It didn't cause any build errors but does prevent QEMU from working correctly. Instead, dete

Re: [Qemu-devel] [PATCH 02/18] qapi-types.py: Implement 'base' for unions

2013-08-27 Thread Kevin Wolf
Am 21.08.2013 um 05:38 hat Amos Kong geschrieben: > On Tue, Jul 23, 2013 at 03:03:10PM +0200, Kevin Wolf wrote: > > The new 'base' key in a union definition refers to a struct type, which > > is inlined into the union definition and can represent fields common to > > all kinds. > > > > For example

[Qemu-devel] [PATCH v2] qcow2: Change default for new images to compat=1.1

2013-08-27 Thread Kevin Wolf
By the time that qemu 1.7 will be released, enough time will have passed since qemu 1.1, which is the first version to understand version 3 images, that changing the default shouldn't hurt many people any more and the benefits of using the new format outweigh the pain. qemu-iotests already runs wi

[Qemu-devel] [PATCH] block: Remove redundant assertion

2013-08-27 Thread Kevin Wolf
The failing condition is checked immediately before the assertion, so keeping the assertion is kind of redundant. Signed-off-by: Kevin Wolf --- block.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block.c b/block.c index a387c1a..26639e8 100644 --- a/block.c +++ b/block.c @@ -743,7 +743,6

Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument

2013-08-27 Thread Richard Henderson
On 08/27/2013 08:43 AM, Aurelien Jarno wrote: > I think this can also be done in a second time. Do you want to create a > version 3, or should I just process the current pull request and you > will provide additional patches later? I think it might be better to provide follow-up patches. r~

Re: [Qemu-devel] [PATCH] hw: fix to display correct memory size

2013-08-27 Thread Yongbok Kim
Because this patch is not the critical, probably I can re-send this and the additional patches (Andreas' suggestion) as trivial patches when the 2GiB patch applied. Regards, Yongbok -Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: 25 August 2013 17:12 To: Andreas Fä

Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument

2013-08-27 Thread Aurelien Jarno
On Tue, Aug 27, 2013 at 07:53:56AM -0700, Richard Henderson wrote: > On 08/27/2013 03:46 AM, Aurelien Jarno wrote: > > On the other hand calling the helper is the exception more than the > > rule (that's why they have been moved at the end of the TB), so we > > should not look to much at generatin

[Qemu-devel] [RFC PATCH V3 ] Introduce RCU-enabled DQs

2013-08-27 Thread Mike Day
Add RCU-enabled variants on the existing bsd DQ facility. Each Q operation has the same interface as the existing (non-RCU) version. Also, each operation is implemented as macro for now. Using the RCU-enabled DQ, existing DQ users will be able to convert to RCU without using a different list inter

Re: [Qemu-devel] [PATCH v3 4/4] timer: make qemu_clock_enable sync between disable and timer's cb

2013-08-27 Thread Alex Bligh
On 27 Aug 2013, at 04:21, Liu Ping Fan wrote: > After disabling the QemuClock, we should make sure that no QemuTimers > are still in flight. To implement that with light overhead, we resort > to QemuEvent. The caller of disabling will wait on QemuEvent of each > timerlist. > > Note, qemu_clock_e

[Qemu-devel] [PATCH v2] i386: Use #defines instead of magic numbers for CPUID cache information

2013-08-27 Thread Eduardo Habkost
This is an attempt to make the CPUID cache topology code clearer, by replacing the magic numbers in the code with #defines, and moving all the cache information to the same place in the file. I took care of comparing the assembly output of compiling target-i386/cpu.c before and after applying this

Re: [Qemu-devel] [PATCH v3 3/4] qemu-thread: add QemuEvent

2013-08-27 Thread Alex Bligh
On 27 Aug 2013, at 04:21, Liu Ping Fan wrote: > +void qemu_event_set(QemuEvent *ev) > +{ It would be useful if these functions had inline documentation. -- Alex Bligh

Re: [Qemu-devel] [PATCH v3 2/4] timer: protect timers_state's clock with seqlock

2013-08-27 Thread Alex Bligh
On 27 Aug 2013, at 04:21, Liu Ping Fan wrote: > Note in tcg mode, vm_clock still read inside BQL, so icount is Should refer to QEMU_CLOCK_VIRTUAL if after my patches > left without private lock's protection. As for cpu_ticks_* in > timers_state, it is still protected by BQL. I *think* what you

[Qemu-devel] [PATCH 1/3] qemu-char: add Czech characters to VNC keysyms

2013-08-27 Thread Jan Krupa
This patch adds missing Czech characters to VNC keysym table. Signed-off-by: Jan Krupa --- ui/vnc_keysym.h |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/ui/vnc_keysym.h b/ui/vnc_keysym.h index 6250bec..72c01d1 100644 --- a/ui/vnc_keysym.h +++ b/ui/vnc_keysym.h @

[Qemu-devel] [PATCH 0/3] qemu-char: keymap changes for Czech and Unicode support

2013-08-27 Thread Jan Krupa
I tried to create keymap for Czech keyboard for QEMU. I found out that some of the keysyms are missing. I added those specific symbols to QEMU VNC header files plus wrote the whole keyboard layout. Another issue I hit during keyboard layout creation process is that keysym to keycode converter insi

[Qemu-devel] [PATCH 3/3] qemu-char: add support for U-prefixed symbols

2013-08-27 Thread Jan Krupa
This patch adds support for Unicode symbols in keymap files. This feature was already used in some keyboard layouts in QEMU generated from XKB (e.g. Arabic) but it wasn't implemented in QEMU source code. Signed-off-by: Jan Krupa --- ui/keymaps.c |3 +++ 1 files changed, 3 insertions(+), 0 de

[Qemu-devel] [PATCH 2/3] qemu-char: add Czech keymap file

2013-08-27 Thread Jan Krupa
This patch adds Czech keyboard layout to available keymap files. Signed-off-by: Jan Krupa --- pc-bios/keymaps/cz | 94 1 files changed, 94 insertions(+), 0 deletions(-) create mode 100644 pc-bios/keymaps/cz diff --git a/pc-bios/keymaps/cz

[Qemu-devel] [PATCH uq/master] kvm-stub: fix compilation

2013-08-27 Thread Paolo Bonzini
Non-KVM targets fail compilation on the uq/master branch. Fix the prototype of kvm_irqchip_add_irqfd_notifier to match the one in kvm-all.c. Signed-off-by: Paolo Bonzini --- Gleb, can you add it on top, or squash it, and resend the pull request to Anthony? Bisectability is not a

Re: [Qemu-devel] [RFC] aio: add aio_context_acquire() and aio_context_release()

2013-08-27 Thread Paolo Bonzini
Il 27/08/2013 16:39, Stefan Hajnoczi ha scritto: > It can be useful to run an AioContext from a thread which normally does > not "own" the AioContext. For example, request draining can be > implemented by acquiring the AioContext and looping aio_poll() until all > requests have been completed. >

Re: [Qemu-devel] [PATCH] mips_malta: support up to 2GiB RAM

2013-08-27 Thread Paul Burton
Great, thanks for looking it over & for amusing me with your original clear as mud answer :) Paul On Tue 27 Aug 2013 15:55:50 BST, Richard Henderson wrote: On 08/27/2013 01:45 AM, Paul Burton wrote: Thanks Richard. To be clear, is that a "this would be a nice future improvement" or a "NAK unt

Re: [Qemu-devel] [PULL 5/7] tcg: Add mmu helpers that take a return address argument

2013-08-27 Thread Richard Henderson
On 08/27/2013 03:46 AM, Aurelien Jarno wrote: > On the other hand calling the helper is the exception more than the > rule (that's why they have been moved at the end of the TB), so we > should not look to much at generating fast code, but rather small code > in order to use the caches (both TB an

Re: [Qemu-devel] [PATCH] mips_malta: support up to 2GiB RAM

2013-08-27 Thread Richard Henderson
On 08/27/2013 01:45 AM, Paul Burton wrote: > Thanks Richard. To be clear, is that a "this would be a nice future > improvement" or a "NAK until this is done"? Sorry, mis-read your "or" there. I meant the former. r~

Re: [Qemu-devel] [PATCH] mips_malta: support up to 2GiB RAM

2013-08-27 Thread Richard Henderson
On 08/27/2013 01:45 AM, Paul Burton wrote: > Thanks Richard. To be clear, is that a "this would be a nice future > improvement" or a "NAK until this is done"? Correct. r~

[Qemu-devel] [RFC] aio: add aio_context_acquire() and aio_context_release()

2013-08-27 Thread Stefan Hajnoczi
It can be useful to run an AioContext from a thread which normally does not "own" the AioContext. For example, request draining can be implemented by acquiring the AioContext and looping aio_poll() until all requests have been completed. The following pattern should work: /* Event loop thread

Re: [Qemu-devel] [Bug 1217339] [NEW] SIGQUIT to send ACPI-shutdown to Guest

2013-08-27 Thread Laszlo Ersek
On 08/27/13 14:29, Lasse wrote: > Public bug reported: > > When qemu receives SIGQUIT, it should first try to run system_powerdown > (giving the guest an ACPI signal to begin the shutdown process), before > ending the whole qemu process. I strongly disagree. SIGQUIT is an interactive debugging si

Re: [Qemu-devel] [PATCH V18 06/25] add interface to block

2013-08-27 Thread Kevin Wolf
Am 13.08.2013 um 06:31 hat Dong Xu Wang geschrieben: > Subject: Re: [PATCH V18 06/25] add interface to block This is _not_ a good subject line. > To make patches easy for reviewing, each block format is > a single patch. Add a new interface to block layer to make > sure origin code can compile an

Re: [Qemu-devel] [PATCH V18 24/25] qapi: query-command-line-options outputs def_value_str

2013-08-27 Thread Kevin Wolf
Am 13.08.2013 um 06:32 hat Dong Xu Wang geschrieben: > QMP command query-command-line-options shows details information of > parameters, since added def_value_str, also output it in the QMP > command. > > v16->v17: > 1) add "Since 1.6" tag. > 2) rename def_str_value to "default". > > Signed-off-b

[Qemu-devel] [Bug 1217339] [NEW] SIGQUIT to send ACPI-shutdown to Guest

2013-08-27 Thread Lasse
Public bug reported: When qemu receives SIGQUIT, it should first try to run system_powerdown (giving the guest an ACPI signal to begin the shutdown process), before ending the whole qemu process. At this point there is no way to do a graceful shutdown if you do not have access to the monitor and

Re: [Qemu-devel] [PATCH] mips_malta: support up to 2GiB RAM

2013-08-27 Thread Paul Burton
Thanks Richard. To be clear, is that a "this would be a nice future improvement" or a "NAK until this is done"? Paul On Mon 26 Aug 2013 19:01:51 BST, Richard Henderson wrote: On 08/23/2013 08:09 AM, Yongbok Kim wrote: +/* alias for pre IO hole access */ +memory_region_init_alias(ram_l

Re: [Qemu-devel] [PATCH V18 05/25] qemu-option: opt->str store digit, without suffixes

2013-08-27 Thread Kevin Wolf
Am 13.08.2013 um 06:31 hat Dong Xu Wang geschrieben: > To produce same output while using "qemu-img create", opt->str > should store pure digit, without suffixes. > > Signed-off-by: Dong Xu Wang > --- > util/qemu-option.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/util/qemu-opti

Re: [Qemu-devel] [PATCH V18 04/25] qemu-option: create some QemuOpts functons

2013-08-27 Thread Kevin Wolf
Am 13.08.2013 um 06:31 hat Dong Xu Wang geschrieben: > These functions will be used in next commit. > > qemu_opt_get_(*)_del functions are used to make sure we > have the same behaviors as before: in block layer, after > parsing a parameter value, parameter list will delete it > to avoid parsing i

Re: [Qemu-devel] pvpanic plans?

2013-08-27 Thread Richard W.M. Jones
On Tue, Aug 27, 2013 at 08:26:53AM -0500, Anthony Liguori wrote: > That's why I think having a virtio-ilo makes sense. This is not a > solved problem today. What's the scope of virtio-ilo? If it's anything like a real ILO it's going to do a lot of not-very-related things, such as: - pvpanic-ty

  1   2   3   >