Re: [Qemu-devel] [Xen-devel] Cirrus VGA slow screen update, show blank screen last 13s or so for windows XP guest

2013-08-20 Thread Ben Guthro
On Aug 20, 2013, at 3:45 PM, Konrad Rzeszutek Wilk wrote: > On Sat, Aug 17, 2013 at 09:04:29AM +, Gonglei (Arei) wrote: >> Hi, >> The fundamental reason is traditional qemu-dm and upstream qemu using a >> different vgabios-cirrus.bin, >> qemu-dm is using xen-4.1.2/tools/firmware/vgabios/

[Qemu-devel] [PATCH v4] spapr-pci: fix config space access to support bridges

2013-08-20 Thread Alexey Kardashevskiy
spapr-pci config space accessors use find_dev() to find a PCI device. However find_dev() only searched on a primary bus and did not do recursive search through secondary buses so config space access was not possible for devices other that on a primary bus. This fixed find_dev() by using the PCI AP

[Qemu-devel] [PATCH] configure: Enable extra compiler warnings

2013-08-20 Thread Stefan Weil
Compiler option -Wextra enables an additional set of compiler warnings. Some of these warnings were already enabled explicitly in QEMU: -Wold-style-declaration, -Wtype-limits, -Wignored-qualifiers and -Wempty-body are now redundant and can be removed. Others don't work with the current code and m

Re: [Qemu-devel] [PATCH 5/8] vfio: Add guest side IOMMU support

2013-08-20 Thread Alexey Kardashevskiy
On 08/19/2013 11:12 PM, Paolo Bonzini wrote: > Il 15/08/2013 08:02, Alexey Kardashevskiy ha scritto: >> On 08/13/2013 08:07 AM, Alex Williamson wrote: +static void vfio_listener_region_add(MemoryListener *listener, + MemoryRegionSection *section) +

[Qemu-devel] [PATCH v2] pci: add config space access traces

2013-08-20 Thread Alexey Kardashevskiy
This adds pci_cfg_read and pci_cfg_write traces for config spaces accesses. Signed-off-by: Alexey Kardashevskiy --- Changes: v2: * added slot and function numbers into traces * added arrows in trace strings --- hw/pci/pci_host.c | 11 ++- trace-events | 4 2 files changed, 14

Re: [Qemu-devel] [PATCH 02/18] qapi-types.py: Implement 'base' for unions

2013-08-20 Thread Amos Kong
On Tue, Jul 23, 2013 at 03:03:10PM +0200, Kevin Wolf wrote: > The new 'base' key in a union definition refers to a struct type, which > is inlined into the union definition and can represent fields common to > all kinds. > > For example the following schema definition... > > { 'type': 'BlockO

[Qemu-devel] Emulation of ICH PIRQ#16~23

2013-08-20 Thread liu ping fan
When I debug the hpet with linux v3.10. I found it can not work with linux-2.6/Documentation/timers/hpet_example.c. But on bare metal, hpet_example can work! After tracing, I found the trouble is caused by drivers/char/hpet.c hpet_timer_set_irq() gsi = acpi_register_gsi(NULL, irq,

Re: [Qemu-devel] [PATCH V8 07/11] NUMA: set guest numa nodes memory policy

2013-08-20 Thread Wanlong Gao
On 08/20/2013 09:41 PM, Andrew Jones wrote: > > > - Original Message - >> Set the guest numa nodes memory policies using the mbind(2) >> system call node by node. >> After this patch, we are able to set guest nodes memory policies >> through the QEMU options, this arms to solve the guest

[Qemu-devel] [PATCH v3 3/3] slirp: set mainloop timeout with more precise value

2013-08-20 Thread Liu Ping Fan
If slirp needs to emulate tcp timeout, then the timeout value for mainloop should be more precise, which is determined by slirp's fasttimo or slowtimo. Achieve this by swap the logic sequence of slirp_pollfds_fill and slirp_update_timeout. Signed-off-by: Liu Ping Fan --- main-loop.c | 3 +-

[Qemu-devel] [PATCH v3 2/3] slirp: define timeout as macro

2013-08-20 Thread Liu Ping Fan
Signed-off-by: Liu Ping Fan --- slirp/slirp.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/slirp/slirp.c b/slirp/slirp.c index b71c617..1e8983e 100644 --- a/slirp/slirp.c +++ b/slirp/slirp.c @@ -47,6 +47,9 @@ static QTAILQ_HEAD(slirp_instances, Slirp) slirp_instanc

[Qemu-devel] [PATCH v3 1/3] slirp: make timeout local

2013-08-20 Thread Liu Ping Fan
Each slirp has its own time to caculate timeout. Signed-off-by: Liu Ping Fan --- slirp/slirp.c | 22 ++ slirp/slirp.h | 3 +++ 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/slirp/slirp.c b/slirp/slirp.c index 80b28ea..b71c617 100644 --- a/slirp/slirp.c +++

[Qemu-devel] [PATCH v3 0/3] slirp: fill mainloop with more precise timeout value

2013-08-20 Thread Liu Ping Fan
With this series, we can set the mainloop timeout more precisely when slirp has to emulate tcp timeout problem. v3: fix comment: document timeout unit "milliseconds" fix logic: no slirps, no timeout modifications in slirp_pollfds_fill() v2: fold slirp_update_timeout logic into slirp_pollfds_

[Qemu-devel] [PULL 2/3] hw/openrisc: Fix masking in openrisc_pic_cpu_handler()

2013-08-20 Thread Jia Liu
Consider the masking of PICSR and PICMR: ((cpu->env.picsr && (1 << i)) && (cpu->env.picmr && (1 << i))) To correctly mask bits, we should use the bitwise AND "&" rather than the logical AND "&&". Also, the loop is not necessary for masking. Simply use (cpu->env.picsr & cpu->env.picmr). Sign

[Qemu-devel] [PULL 0/3] OpenRISC patch queue for 1.7

2013-08-20 Thread Jia Liu
d shift in openrisc_pic_cpu_handler() The following changes since commit ecfe10c9a6f9bc77d0e4b7eb5d0f5d61e8fbaed8: Merge remote-tracking branch 'pmaydell/tags/pull-target-arm-20130820' into staging (2013-08-20 11:23:52 -0500) are available in the git repository at: git://github.com/J-Liu/qemu.

[Qemu-devel] [PULL 3/3] hw/openrisc: Avoid undefined shift in openrisc_pic_cpu_handler()

2013-08-20 Thread Jia Liu
In C99 signed shift (1 << 31) is undefined behavior, since the result exceeds INT_MAX. Use 1U instead and move the shift after the check. Signed-off-by: Xi Wang Acked-by: Jia Liu --- hw/openrisc/pic_cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/openrisc/pic_cp

[Qemu-devel] [PULL 1/3] hw/openrisc: Avoid using uninitialised variable 'entry'

2013-08-20 Thread Jia Liu
clang warns that cpu_openrisc_load_kernel() can use 'entry' uninitialized: hw/openrisc/openrisc_sim.c:69:9: error: variable 'entry' is used uninitialized whenever '&&' condition is false [-Werror,-Wsometimes-uninitialized] if (kernel_filename && !qtest_enabled()) { ^~~ hw/

[Qemu-devel] [PATCH] block: Fix race in gluster_finish_aiocb

2013-08-20 Thread Asias He
In block/gluster.c, we have gluster_finish_aiocb { if (retval != sizeof(acb)) { qemu_mutex_lock_iothread(); /* We are in gluster thread context */ ... qemu_mutex_unlock_iothread(); } } qemu tools, e.g. qemu-img, might race here because qemu_mutex_{lock,unlock}_iothread are

[Qemu-devel] [Bug 1213797] Re: Guest hang after live migration

2013-08-20 Thread chao zhou
Jinsong Liu (@Intel) 's patch "qemu-kvm bugfix for IA32_FEATURE_CONTROL" will fix this bug. That patch will also fix the following bug. 10. 64bit RHEL6.4 guest crashes and reboots continuously https://bugs.launchpad.net/qemu-kvm/+bug/1207623 So you suggent we should use qemu instead of qemu-kv

Re: [Qemu-devel] [PATCH V8 00/11] Add support for binding guest numa nodes to host numa nodes

2013-08-20 Thread Wanlong Gao
On 08/20/2013 09:43 PM, Paolo Bonzini wrote: > Il 20/08/2013 03:07, Wanlong Gao ha scritto: >> -numa node,nodeid=0,cpus=0, \ >> -numa mem,size=1024M,policy=membind,host-nodes=0-1 \ >> -numa node,nodeid=1,cpus=1 \ >> -numa mem,size=1024M,policy=interleave,host-nodes=1 > > What nodes would the m

Re: [Qemu-devel] [Patch] ARM: Simplify and fix imx_epit implementation.

2013-08-20 Thread peter
> "Andreas" == Andreas Färber writes: >> Thanks; applied to target-arm.next. Andreas> Also if there is a reset bug, then fixing that in its own Andreas> patch would better allow backporting that to 1.6.1. The way Andreas> it is right now with no Cc: line for qemu-stable, the Andreas> release

Re: [Qemu-devel] [PATCH 1/2] Make cow_co_is_allocated and cow_update_bitmap more efficient

2013-08-20 Thread Charlie Shepherd
On 20/08/2013 21:48, Paolo Bonzini wrote: Il 20/08/2013 20:34, Charlie Shepherd ha scritto: /* Return true if first block has been changed (ie. current version is @@ -146,40 +114,82 @@ static inline int is_bit_set(BlockDriverState *bs, int64_t bitnum) static int coroutine_fn cow_co_is_alloc

Re: [Qemu-devel] [PATCH] sun4m: Add FCode ROM for TCX framebuffer

2013-08-20 Thread Peter Maydell
On 20 August 2013 23:25, Mark Cave-Ayland wrote: > Upstream OpenBIOS now implements SBus probing in order to determine the > contents of a physical bus slot, which is required to allow OpenBIOS to > identify the framebuffer without help from the fw_cfg interface. > > SBus probing works by detectin

[Qemu-devel] [PATCH] sun4m: Add FCode ROM for TCX framebuffer

2013-08-20 Thread Mark Cave-Ayland
Upstream OpenBIOS now implements SBus probing in order to determine the contents of a physical bus slot, which is required to allow OpenBIOS to identify the framebuffer without help from the fw_cfg interface. SBus probing works by detecting the presence of an FCode program (effectively tokenised F

Re: [Qemu-devel] [PATCH 0/6] pc init & compat function cleanup

2013-08-20 Thread Michael S. Tsirkin
On Tue, Aug 20, 2013 at 05:48:59PM -0300, Eduardo Habkost wrote: > This is a follow-up to the patch submitted by Michael (patch 1/6 in this > series), to make the pc compat initialization code simpler and easier to > eventually remove code duplication between pc_piix.c and pc_q35.c. Eduardo this d

Re: [Qemu-devel] [PATCH 0/6] pc init & compat function cleanup

2013-08-20 Thread Michael S. Tsirkin
On Tue, Aug 20, 2013 at 05:48:59PM -0300, Eduardo Habkost wrote: > This is a follow-up to the patch submitted by Michael (patch 1/6 in this > series), to make the pc compat initialization code simpler and easier to > eventually remove code duplication between pc_piix.c and pc_q35.c. OK, patch 1/6

Re: [Qemu-devel] [PATCH 1/2] Make cow_co_is_allocated and cow_update_bitmap more efficient

2013-08-20 Thread Paolo Bonzini
Il 20/08/2013 20:34, Charlie Shepherd ha scritto: > cow_co_is_allocated and cow_update_bitmap set bits by reading the relevant > word, setting the specific bit in it and writing it back. These functions set > a number of contiguous bits however, so this is an extremely inefficient way > of doing th

[Qemu-devel] [PATCH 6/6] pc_piix: Pass QEMUMachineInitArgs to pc_init1()

2013-08-20 Thread Eduardo Habkost
This makes the code much simpler. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c | 47 --- 1 file changed, 12 insertions(+), 35 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 3e77dfd..decbd61 100644 --- a/hw/i386/pc_piix.c

[Qemu-devel] [PATCH 4/6] pc: pc_compat_1_4() now can call pc_compat_1_5()

2013-08-20 Thread Eduardo Habkost
It just needs to set has_pvpanic=false after calling it. This way, it won't be a special case anymore. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c | 4 ++-- hw/i386/pc_q35.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c i

[Qemu-devel] [PATCH 0/6] pc init & compat function cleanup

2013-08-20 Thread Eduardo Habkost
This is a follow-up to the patch submitted by Michael (patch 1/6 in this series), to make the pc compat initialization code simpler and easier to eventually remove code duplication between pc_piix.c and pc_q35.c. Eduardo Habkost (5): pc: Kill pc_init_pci_1_0() pc: Create pc_compat_*() function

[Qemu-devel] [PATCH 1/6] pc: cleanup 1.4 compat support

2013-08-20 Thread Eduardo Habkost
From: "Michael S. Tsirkin" Make 1.4 compat code call the 1.6 one, reducing code duplication. Add comment explaining why we can't make 1.4 call 1.5 as usual. Signed-off-by: Michael S. Tsirkin Reviewed-by: Andreas Färber Reviewed-by: Eduardo Habkost Signed-off-by: Eduardo Habkost --- hw/i386/

[Qemu-devel] [PATCH 2/6] pc: Kill pc_init_pci_1_0()

2013-08-20 Thread Eduardo Habkost
The pc_init_pci_1_2()/pc_init_pci_1_0() split was made on commit 6fd028f64f662c801fd5a54d0e3a1d2baeee93ea, in preparation for commit 9953f8822cc316eec9962f0a2858c3439a80adec. The latter was reverted, so there's no reason to keep two separate functions that do exactly the same, anymore. Signed-off-

[Qemu-devel] [PATCH 3/6] pc: Create pc_compat_*() functions

2013-08-20 Thread Eduardo Habkost
Making the older compat functions call the newer compat functions at the beginning allows the older functions undo what's done by newer compat functions. e.g.: pc_compat_1_4() will be able to call pc_compat_1_5() and then set has_pvpanic=false. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.

[Qemu-devel] [PATCH 5/6] pc_piix: Kill pc_init1() memory region args

2013-08-20 Thread Eduardo Habkost
All callers always use the same values (get_system_memory(), get_system_io()), so the parameters are pointless. If one day we decide to eliminate get_system_memory() and get_system_io(), we will be able to do that more easily by adding the values to struct QEMUMachineInitArgs. Signed-off-by: Edua

Re: [Qemu-devel] [Xen-devel] Cirrus VGA slow screen update, show blank screen last 13s or so for windows XP guest

2013-08-20 Thread Konrad Rzeszutek Wilk
On Sat, Aug 17, 2013 at 09:04:29AM +, Gonglei (Arei) wrote: > Hi, > The fundamental reason is traditional qemu-dm and upstream qemu using a > different vgabios-cirrus.bin, > qemu-dm is using xen-4.1.2/tools/firmware/vgabios/ > VGABIOS-lgpl-latest.cirrus.bin, > but upstream qemu is using qemu

Re: [Qemu-devel] [PULL 08/11] add "test-int128" and "test-bitops" to .gitignore

2013-08-20 Thread Andreas Färber
Am 20.08.2013 20:39, schrieb Luiz Capitulino: > On Tue, 20 Aug 2013 18:23:00 +0200 > Andreas Färber wrote: >> Am 20.08.2013 18:10, schrieb Luiz Capitulino: >>> diff --git a/.gitignore b/.gitignore >>> index 0fe114d..a8e0f17 100644 >>> --- a/.gitignore >>> +++ b/.gitignore >>> @@ -45,7 +45,9 @@ qem

Re: [Qemu-devel] [PULL 08/11] add "test-int128" and "test-bitops" to .gitignore

2013-08-20 Thread Luiz Capitulino
On Tue, 20 Aug 2013 18:23:00 +0200 Andreas Färber wrote: > Am 20.08.2013 18:10, schrieb Luiz Capitulino: > > From: Laszlo Ersek > > > > "test-int128" was probably missed in commit 6046c620 > > ("int128: optimize and add test cases"). > > > > "test-bitops" was probably missed in commit 3464700f

Re: [Qemu-devel] [PATCH 1/2] Make cow_co_is_allocated and cow_update_bitmap more efficient

2013-08-20 Thread Charlie Shepherd
Sorry, this is not only NOT 1/2, but it should say v2, as this is also based on merging in Paolo's similar patch in his get_block_status series. On 20/08/2013 19:34, Charlie Shepherd wrote: cow_co_is_allocated and cow_update_bitmap set bits by reading the relevant word, setting the specific bit

[Qemu-devel] [PATCH 1/2] Make cow_co_is_allocated and cow_update_bitmap more efficient

2013-08-20 Thread Charlie Shepherd
cow_co_is_allocated and cow_update_bitmap set bits by reading the relevant word, setting the specific bit in it and writing it back. These functions set a number of contiguous bits however, so this is an extremely inefficient way of doing this. This patch converts them to read the whole bitmap they

[Qemu-devel] [PATCH] q35: Add PCIe switch to example q35 configuration

2013-08-20 Thread Alex Williamson
Signed-off-by: Alex Williamson --- docs/q35-chipset.cfg | 23 +++ 1 file changed, 23 insertions(+) diff --git a/docs/q35-chipset.cfg b/docs/q35-chipset.cfg index 1b6efc0..e4ddb7d 100644 --- a/docs/q35-chipset.cfg +++ b/docs/q35-chipset.cfg @@ -91,6 +91,29 @@ port = "4"

Re: [Qemu-devel] [RFC] Convert AioContext to Gsource sub classes

2013-08-20 Thread Alex Bligh
On 20 Aug 2013, at 10:59, Wenchao Xia wrote: > The main issue here is that components are tightly bind together and > no clear layer represent the thread and event loop API. Block and hw > code are inter acting with AioContext, so both GMainContext and > AioContext are playing the role. I hope t

Re: [Qemu-devel] [PATCH] qemu-kvm bugfix for IA32_FEATURE_CONTROL

2013-08-20 Thread Paolo Bonzini
Il 20/08/2013 05:33, Liu, Jinsong ha scritto: > Thanks Andreas! > > This patch is for qemu-kvm. Even though the repository is still called qemu-kvm, the uq/master branch is the only active one and patches there will end up in upstream QEMU. There are no qemu-kvm releases anymore. I applied the

[Qemu-devel] [PULL 04/11] OptsVisitor: opts_type_int(): recognize intervals when LM_IN_PROGRESS

2013-08-20 Thread Luiz Capitulino
From: Laszlo Ersek When a well-formed range value, bounded by signed integers, is encountered while processing a repeated option, enter LM_SIGNED_INTERVAL and return the low bound. Signed-off-by: Laszlo Ersek Tested-by: Wanlong Gao Signed-off-by: Luiz Capitulino --- qapi/opts-visitor.c | 34

Re: [Qemu-devel] [PATCH uq/master] kvm: Simplify kvm_handle_io

2013-08-20 Thread Paolo Bonzini
Il 13/08/2013 14:43, Jan Kiszka ha scritto: > Now that cpu_in/out is just a wrapper around address_space_rw, we can > also call the latter directly. As host endianness == guest endianness, > there is no need for the memory access helpers st*_p/ld*_p as well. > > Signed-off-by: Jan Kiszka > --- >

Re: [Qemu-devel] [PULL 08/11] add "test-int128" and "test-bitops" to .gitignore

2013-08-20 Thread Andreas Färber
Am 20.08.2013 18:10, schrieb Luiz Capitulino: > From: Laszlo Ersek > > "test-int128" was probably missed in commit 6046c620 > ("int128: optimize and add test cases"). > > "test-bitops" was probably missed in commit 3464700f > ("tests: Add test-bitops.c with some sextract tests"). > > Signed-off

[Qemu-devel] [PULL 11/11] scripts/qapi.py: Avoid syntax not supported by Python 2.4

2013-08-20 Thread Luiz Capitulino
From: Peter Maydell The Python "except Foo as x" syntax was only introduced in Python 2.6, but we aim to support Python 2.4 and later. Use the old-style "except Foo, x" syntax instead, thus fixing configure/compile on systems with older Python. Signed-off-by: Peter Maydell Signed-off-by: Luiz C

[Qemu-devel] [PULL 08/11] add "test-int128" and "test-bitops" to .gitignore

2013-08-20 Thread Luiz Capitulino
From: Laszlo Ersek "test-int128" was probably missed in commit 6046c620 ("int128: optimize and add test cases"). "test-bitops" was probably missed in commit 3464700f ("tests: Add test-bitops.c with some sextract tests"). Signed-off-by: Laszlo Ersek Tested-by: Wanlong Gao Signed-off-by: Luiz C

[Qemu-devel] [PULL 10/11] monitor: print the invalid char in error message

2013-08-20 Thread Luiz Capitulino
From: Fam Zheng It's more friendly to print which char is invalid to user, especially when user tries to input a float value and expect the monitor to round it to int. Since we don't round float number when we look for a integer, telling which char is invalid is less confusing. Signed-off-by: Fa

[Qemu-devel] [PULL 01/11] Convert stderr message calling error_get_pretty() to error_report()

2013-08-20 Thread Luiz Capitulino
From: Seiji Aguchi Convert stderr messages calling error_get_pretty() to error_report(). Timestamp is prepended by -msg timstamp option with it. Per Markus's comment below, A conversion from fprintf() to error_report() is always an improvement, regardless of error_get_pretty(). http://marc.inf

[Qemu-devel] [PULL 06/11] OptsVisitor: opts_type_uint64(): recognize intervals when LM_IN_PROGRESS

2013-08-20 Thread Luiz Capitulino
From: Laszlo Ersek When a well-formed range value, bounded by unsigned integers, is encountered while processing a repeated option, enter LM_UNSIGNED_INTERVAL and return the low bound. Signed-off-by: Laszlo Ersek Tested-by: Wanlong Gao Signed-off-by: Luiz Capitulino --- qapi/opts-visitor.c |

[Qemu-devel] [PULL 05/11] OptsVisitor: rebase opts_type_uint64() to parse_uint_full()

2013-08-20 Thread Luiz Capitulino
From: Laszlo Ersek Simplify the code in preparation for the next patch. Signed-off-by: Laszlo Ersek Tested-by: Wanlong Gao Signed-off-by: Luiz Capitulino --- qapi/opts-visitor.c | 23 +-- 1 file changed, 5 insertions(+), 18 deletions(-) diff --git a/qapi/opts-visitor.c b

[Qemu-devel] [PULL 02/11] OptsVisitor: introduce basic list modes

2013-08-20 Thread Luiz Capitulino
From: Laszlo Ersek We're going to need more state while processing a list of repeated options. This change eliminates "repeated_opts_first" and adds a new state variable: list_mode repeated_opts repeated_opts_first -- - --- LM_NONE N

[Qemu-devel] [PULL 09/11] OptsVisitor: introduce unit tests, with test cases for range flattening

2013-08-20 Thread Luiz Capitulino
From: Laszlo Ersek According to commit 4f193e34 ("tests: Use qapi-schema-test.json as schema parser test") the "tests/qapi-schema/qapi-schema-test.out" file must be updated as well. Signed-off-by: Laszlo Ersek Tested-by: Wanlong Gao Signed-off-by: Luiz Capitulino --- .gitignore

[Qemu-devel] [PULL 03/11] OptsVisitor: introduce list modes for interval flattening

2013-08-20 Thread Luiz Capitulino
From: Laszlo Ersek The new modes are equal-rank, exclusive alternatives of LM_IN_PROGRESS. Teach opts_next_list(), opts_type_int() and opts_type_uint64() to handle them. Also enumerate explicitly what functions are valid to call in what modes: - opts_next_list() is valid to call while flattening

[Qemu-devel] [PULL 07/11] OptsVisitor: don't try to flatten overlong integer ranges

2013-08-20 Thread Luiz Capitulino
From: Laszlo Ersek Prevent mistyped command line options from incurring high memory and CPU usage at startup. 64K elements in a range should be enough for everyone (TM). The OPTS_VISITOR_RANGE_MAX macro is public so that unit tests can construct corner cases with it. Signed-off-by: Laszlo Ersek

Re: [Qemu-devel] [PATCH v2 0/8] OptsVisitor: support / flatten integer ranges for repeating options

2013-08-20 Thread Luiz Capitulino
On Tue, 20 Aug 2013 00:35:32 +0200 Laszlo Ersek wrote: > v1->v2: > - rebased to current master (patch #8 only applied with "git am -3"), > - now patch #7 adds "test-bitops" too to .gitignore, > - patch #8 updates "qapi-schema-test.out" to keep it in synch with the > test schema changes warrante

[Qemu-devel] [PULL 00/11] QMP queue

2013-08-20 Thread Luiz Capitulino
The following changes since commit 9176e8fb8f78206bd4039f001aca0d931a47d663: Merge remote-tracking branch 'stefanha/block-next' into staging (2013-08-20 09:52:18 -0500) are available in the git repository at: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp for you to fetch changes up to

Re: [Qemu-devel] [PATCH] scripts/qapi.py: Avoid syntax not supported by Python 2.4

2013-08-20 Thread Luiz Capitulino
On Tue, 20 Aug 2013 15:50:15 +0100 Peter Maydell wrote: > The Python "except Foo as x" syntax was only introduced in > Python 2.6, but we aim to support Python 2.4 and later. > Use the old-style "except Foo, x" syntax instead, thus > fixing configure/compile on systems with older Python. > > Sig

[Qemu-devel] [PATCH v3 18/24] arm11mpcore: Split off SCU device

2013-08-20 Thread Andreas Färber
Inspired by a9scu. Signed-off-by: Andreas Färber --- default-configs/arm-softmmu.mak | 1 + hw/cpu/arm11mpcore.c| 65 ++ hw/misc/Makefile.objs | 1 + hw/misc/arm11scu.c | 100 include/hw/misc

[Qemu-devel] [PATCH v3 19/24] arm11mpcore: Convert ARM11MPCorePriveState to QOM realize

2013-08-20 Thread Andreas Färber
Embed child devices and replace SysBus initfn with realizefn. Signed-off-by: Andreas Färber --- hw/cpu/arm11mpcore.c | 84 ++-- 1 file changed, 56 insertions(+), 28 deletions(-) diff --git a/hw/cpu/arm11mpcore.c b/hw/cpu/arm11mpcore.c index 9ab2bf

[Qemu-devel] [PATCH v3 24/24] arm11mpcore: Split off RealView MPCore

2013-08-20 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/cpu/Makefile.objs | 1 + hw/cpu/arm11mpcore.c | 121 - hw/cpu/realview_mpcore.c | 139 +++ 3 files changed, 140 insertions(+), 121 deletions(-) create mode 100644 hw

[Qemu-devel] [PATCH v3 22/24] arm11mpcore: Convert mpcore_rirq_state to QOM realize

2013-08-20 Thread Andreas Färber
Embed ARM11MPCorePriveState and RealViewGICState and replace SysBus initfn with realizefn. Signed-off-by: Andreas Färber --- hw/cpu/arm11mpcore.c | 58 +++- 1 file changed, 44 insertions(+), 14 deletions(-) diff --git a/hw/cpu/arm11mpcore.c b/hw/c

[Qemu-devel] [PATCH v3 16/24] arm11mpcore: Drop unused fields

2013-08-20 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/cpu/arm11mpcore.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/cpu/arm11mpcore.c b/hw/cpu/arm11mpcore.c index 27cd32b..8719634 100644 --- a/hw/cpu/arm11mpcore.c +++ b/hw/cpu/arm11mpcore.c @@ -20,8 +20,6 @@ typedef struct ARM11MPCorePriveState {

Re: [Qemu-devel] [PATCH] pci: add config space access traces

2013-08-20 Thread Michael S. Tsirkin
On Fri, Aug 16, 2013 at 09:10:48PM +1000, Alexey Kardashevskiy wrote: > This adds pci_cfg_read and pci_cfg_write traces for config spaces accesses. > > Signed-off-by: Alexey Kardashevskiy Looks good to me. I think it would be useful to add device and function numbers in trace. Could you incorpor

[Qemu-devel] [PATCH v3 17/24] arm11mpcore: Create container MemoryRegion in instance_init

2013-08-20 Thread Andreas Färber
This allows to map the region directly after object initialization. Signed-off-by: Andreas Färber --- hw/cpu/arm11mpcore.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/hw/cpu/arm11mpcore.c b/hw/cpu/arm11mpcore.c index 8719634..5f80e7b 100644 --- a/hw/cpu/ar

[Qemu-devel] [PATCH v3 05/24] cpu/a9mpcore: Embed A9SCUState

2013-08-20 Thread Andreas Färber
From: Andreas Färber Prepares for QOM realize. Signed-off-by: Andreas Färber --- hw/cpu/a9mpcore.c | 16 ++-- hw/misc/a9scu.c | 18 +- include/hw/misc/a9scu.h | 31 +++ 3 files changed, 42 insertions(+), 23 deletions(-) cre

[Qemu-devel] [PATCH v3 21/24] realview_gic: Prepare for QOM embedding

2013-08-20 Thread Andreas Färber
Move state struct, type constant and cast macro to a new header. Signed-off-by: Andreas Färber --- hw/intc/realview_gic.c | 15 +-- include/hw/intc/realview_gic.h | 28 2 files changed, 29 insertions(+), 14 deletions(-) create mode 100644 include

[Qemu-devel] [PATCH v3 13/24] cpu/a15mpcore: Prepare for QOM embedding

2013-08-20 Thread Andreas Färber
From: Andreas Färber Signed-off-by: Andreas Färber --- hw/cpu/a15mpcore.c | 21 + include/hw/cpu/a15mpcore.h | 44 2 files changed, 45 insertions(+), 20 deletions(-) create mode 100644 include/hw/cpu/a15mpcore.h diff --g

[Qemu-devel] [PATCH v3 12/24] cpu/a15mpcore: Convert to QOM realize

2013-08-20 Thread Andreas Färber
From: Andreas Färber Turn SysBusDevice initfn into a QOM realizefn. Signed-off-by: Andreas Färber --- hw/cpu/a15mpcore.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/hw/cpu/a15mpcore.c b/hw/cpu/a15mpcore.c index 3f8b07b..ea6568c 100644 --- a/hw/cpu/

[Qemu-devel] [PATCH v3 20/24] realview_gic: Convert to QOM realize

2013-08-20 Thread Andreas Färber
Embed GICState and replace SysBus initfn with realizefn. Signed-off-by: Andreas Färber --- hw/intc/realview_gic.c | 51 ++ 1 file changed, 35 insertions(+), 16 deletions(-) diff --git a/hw/intc/realview_gic.c b/hw/intc/realview_gic.c index ce80447

[Qemu-devel] [PATCH v3 15/24] arm11mpcore: Fix typo in MemoryRegion name

2013-08-20 Thread Andreas Färber
"mpcode" -> "mpcore" Signed-off-by: Andreas Färber --- hw/cpu/arm11mpcore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/cpu/arm11mpcore.c b/hw/cpu/arm11mpcore.c index a786c62..27cd32b 100644 --- a/hw/cpu/arm11mpcore.c +++ b/hw/cpu/arm11mpcore.c @@ -93,7 +93,7 @@ static

[Qemu-devel] [PATCH v3 06/24] timer/arm_mptimer: Convert to QOM realize

2013-08-20 Thread Andreas Färber
From: Andreas Färber Split the SysBusDevice initfn into instance_init and realizefn. Signed-off-by: Andreas Färber --- hw/timer/arm_mptimer.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/hw/timer/arm_mptimer.c b/hw/timer/arm_mptimer.c index 92

[Qemu-devel] [PATCH v3 11/24] cpu/a15mpcore: Embed GICState

2013-08-20 Thread Andreas Färber
From: Andreas Färber This covers both emulated and KVM GIC. Prepares for QOM realize. Signed-off-by: Andreas Färber --- hw/cpu/a15mpcore.c | 35 ++- 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/hw/cpu/a15mpcore.c b/hw/cpu/a15mpcore.c index c2

[Qemu-devel] [PATCH v3 23/24] arm11mpcore: Prepare for QOM embedding

2013-08-20 Thread Andreas Färber
Move state struct, type constant and cast macro to a new header. Signed-off-by: Andreas Färber --- hw/cpu/arm11mpcore.c | 27 +-- include/hw/cpu/arm11mpcore.h | 35 +++ 2 files changed, 36 insertions(+), 26 deletions(-) create mode

[Qemu-devel] [PATCH v3 03/24] cpu/a9mpcore: Embed GICState

2013-08-20 Thread Andreas Färber
From: Andreas Färber Prepares for conversion to QOM realize. Signed-off-by: Andreas Färber --- hw/cpu/a9mpcore.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/hw/cpu/a9mpcore.c b/hw/cpu/a9mpcore.c index acbdab5..d157387 100644 --- a/hw/cpu/a9mpc

[Qemu-devel] [PATCH v3 07/24] cpu/a9mpcore: Embed ARMMPTimerState

2013-08-20 Thread Andreas Färber
From: Andreas Färber Prepares for QOM realize. Signed-off-by: Andreas Färber --- hw/cpu/a9mpcore.c | 29 ++- hw/timer/arm_mptimer.c | 35 --- include/hw/timer/arm_mptimer.h | 54 ++ 3 files

[Qemu-devel] [PATCH v3 09/24] cpu/a9mpcore: Prepare for QOM embedding

2013-08-20 Thread Andreas Färber
From: Andreas Färber Signed-off-by: Andreas Färber --- hw/cpu/a9mpcore.c | 24 +--- include/hw/cpu/a9mpcore.h | 37 + 2 files changed, 38 insertions(+), 23 deletions(-) create mode 100644 include/hw/cpu/a9mpcore.h diff --git a/hw

[Qemu-devel] [PATCH v3 04/24] misc/a9scu: QOM cleanups

2013-08-20 Thread Andreas Färber
From: Andreas Färber Rename A9SCUState::busdev field to parent_obj and turn realizefn into an instance_init function to allow early MMIO mapping. Reviewed-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- hw/misc/a9scu.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions

[Qemu-devel] [PATCH v3 08/24] cpu/a9mpcore: Convert to QOM realize

2013-08-20 Thread Andreas Färber
From: Andreas Färber Signed-off-by: Andreas Färber --- hw/cpu/a9mpcore.c | 36 ++-- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/hw/cpu/a9mpcore.c b/hw/cpu/a9mpcore.c index 1dc1e92..5eb1a2f 100644 --- a/hw/cpu/a9mpcore.c +++ b/hw/cpu/a9mpcore.c

[Qemu-devel] [PATCH v3 01/24] cpu/a9mpcore: Split off instance_init

2013-08-20 Thread Andreas Färber
From: Andreas Färber Prepares for QOM realize. Signed-off-by: Andreas Färber --- hw/cpu/a9mpcore.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/cpu/a9mpcore.c b/hw/cpu/a9mpcore.c index 3e675e3..acbdab5 100644 --- a/hw/cpu/a9mpcore.c +++ b/hw/cpu/a9mpcore.

[Qemu-devel] [PATCH v3 10/24] cpu/a15mpcore: Split off instance_init

2013-08-20 Thread Andreas Färber
From: Andreas Färber Prepares for QOM realize. Signed-off-by: Andreas Färber --- hw/cpu/a15mpcore.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/hw/cpu/a15mpcore.c b/hw/cpu/a15mpcore.c index 4f37964..c261cea 100644 --- a/hw/cpu/a15mpcore.c +++ b/hw/cpu/a15

[Qemu-devel] [PATCH v3 14/24] a9scu: Build only once

2013-08-20 Thread Andreas Färber
It does not have a target or ARMCPU dependency. Signed-off-by: Andreas Färber --- hw/misc/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/Makefile.objs b/hw/misc/Makefile.objs index 2578e29..5636299 100644 --- a/hw/misc/Makefile.objs +++ b/hw/misc/Makefi

[Qemu-devel] [PATCH v3 02/24] intc/arm_gic: Extract headers hw/intc/arm_gic{, _common}.h

2013-08-20 Thread Andreas Färber
Rename NCPU to GIC_NCPU and move GICState away from gic_internal.h. Signed-off-by: Andreas Färber --- hw/intc/arm_gic_common.c | 18 hw/intc/gic_internal.h | 80 +- include/hw/intc/arm_gic.h| 42 ++ include/hw/int

[Qemu-devel] [PATCH v3 00/24] arm: ARM11MPCore+A9MPCore+A15MPCore QOM'ification

2013-08-20 Thread Andreas Färber
From: Andreas Färber Hello Peter, This series fully QOM'ifies A9MPCore so that it can be embedded for Tegra2. It goes on to do the same for A15MPCore, which had previously been taken as template for Cortex-A57 by John Rigby, and in v3 ARM11MPCore. Separate headers are introduced to only expose

Re: [Qemu-devel] [PATCH] target-i386: Only provide CMOV and friends if feature bit set

2013-08-20 Thread Richard Henderson
On 08/20/2013 05:59 AM, Peter Maydell wrote: > Ping^2! This has been reviewed and I've checked that the > patch still applies to master. Reviewed-by: Richard Henderson > > thanks > -- PMM > > On 25 July 2013 17:54, Peter Maydell wrote: >> Ping! >> >> (patchwork url: http://patchwork.ozlabs.or

[Qemu-devel] [PULL 12/21] hw/arm/versatilepb: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell Message-id: 1375977856-25046-12-git-send-email-peter.mayd...@linaro.org --- hw/arm/versatilepb.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions

Re: [Qemu-devel] Fwd: [libvirt] virDomainAttachDevice error during disk hotplug

2013-08-20 Thread Daniel P. Berrange
On Tue, Aug 20, 2013 at 04:43:48PM +0200, Stefan Hajnoczi wrote: > On Fri, Aug 16, 2013 at 06:52:32PM +0530, Deepak C Shetty wrote: > > 2) qemu-img info /var/run/vdsm/017d-1278-4bfb-8129-62bded257399 > > image: /var/run/vdsm/017d-1278-4bfb-8129-62bded257399 > > file format: qcow2 > > virtua

Re: [Qemu-devel] [RFC] Hardware acceleration for Windows and OS X?

2013-08-20 Thread Stefan Hajnoczi
On Mon, Aug 19, 2013 at 10:17:15PM +0200, Stefan Weil wrote: > Would it be a good plan to merge HAXM support in latest QEMU > (the Android QEMU is based on a rather old version)? It only > supports Intel based hosts, is restricted to 32 bit guests (?) > and free, but not open source. I think the a

Re: [Qemu-devel] vmdk stream-optimised format

2013-08-20 Thread Stefan Hajnoczi
On Tue, Aug 20, 2013 at 07:51:40AM +0100, Alex Bligh wrote: > What I'm not sure of is whether the streaming format has to be written > sequentially from as opposed to random writes. I believe the way > qemu-img convert works, one can't guarantee the writes are > sequential. It should be possible t

[Qemu-devel] [PATCH] scripts/qapi.py: Avoid syntax not supported by Python 2.4

2013-08-20 Thread Peter Maydell
The Python "except Foo as x" syntax was only introduced in Python 2.6, but we aim to support Python 2.4 and later. Use the old-style "except Foo, x" syntax instead, thus fixing configure/compile on systems with older Python. Signed-off-by: Peter Maydell --- I don't have an old python to test this

Re: [Qemu-devel] Fwd: [libvirt] virDomainAttachDevice error during disk hotplug

2013-08-20 Thread Stefan Hajnoczi
On Fri, Aug 16, 2013 at 06:52:32PM +0530, Deepak C Shetty wrote: > 2) qemu-img info /var/run/vdsm/017d-1278-4bfb-8129-62bded257399 > image: /var/run/vdsm/017d-1278-4bfb-8129-62bded257399 > file format: qcow2 > virtual size: 3.8G (409600 bytes) > disk size: 196K > cluster_size: 65536 > b

Re: [Qemu-devel] [Bug?] qemu-1.6.0 python traceback in GEN qmp-commands.h

2013-08-20 Thread Stefan Hajnoczi
On Mon, Aug 19, 2013 at 03:50:45PM +0200, Andreas Färber wrote: > Am 16.08.2013 15:21, schrieb Peter Maydell: > > On 16 August 2013 08:59, Erik Rull wrote: > >> Hi all, > >> > >> when using the released qemu-1.6.0.tar.bz2, I get the following error > >> message: > >> File "/home/erik/qemu-1.6.0

Re: [Qemu-devel] [PATCH v4 00/13] VHDX log replay and write support, .bdrv_create()

2013-08-20 Thread Kevin Wolf
Am 20.08.2013 um 08:01 hat Jeff Cody geschrieben: > This patch series contains the initial VHDX log parsing, replay, > and write support. (New with v4: VHDX image file creation) Not sure if it helps a lot, but patches 1 to 4 are: Reviewed-by: Kevin Wolf I'll continue next week (unless someone

[Qemu-devel] [PULL 00/21] target-arm queue

2013-08-20 Thread Peter Maydell
l/qemu-arm.git tags/pull-target-arm-20130820 for you to fetch changes up to 230058106ab26de9b876158dbe27d60719f01f51: hw/timer/imx_epit: Simplify and fix imx_epit implementation (2013-08-20 14:54:32 +0100)

Re: [Qemu-devel] [PATCH v2] monitor: print the invalid char in error message

2013-08-20 Thread Luiz Capitulino
On Tue, 20 Aug 2013 10:58:21 +0800 Fam Zheng wrote: > It's more friendly to print which char is invalid to user, especially > when user tries to input a float value and expect the monitor to round > it to int. Since we don't round float number when we look for a integer, > telling which char is i

[Qemu-devel] [PULL 06/21] hw/arm/integratorcp: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell Message-id: 1375977856-25046-6-git-send-email-peter.mayd...@linaro.org --- hw/arm/integratorcp.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions

[Qemu-devel] [PULL 04/21] hw/arm/exynos4210: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell Message-id: 1375977856-25046-4-git-send-email-peter.mayd...@linaro.org --- hw/arm/exynos4210.c | 16 +++- 1 file changed, 3 insertions(+), 13 d

[Qemu-devel] [PULL 10/21] hw/arm/realview: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell Message-id: 1375977856-25046-10-git-send-email-peter.mayd...@linaro.org --- hw/arm/realview.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) di

[Qemu-devel] [PULL 02/21] target-arm: Make IRQ and FIQ gpio lines on the CPU object

2013-08-20 Thread Peter Maydell
Now that ARMCPU is a subclass of DeviceState, we can make the CPU's inbound IRQ and FIQ lines be simply gpio lines, which means we can remove the odd arm_pic shim. We retain the arm_pic_init_cpu() function as a backwards compatibility shim layer so we can convert the board models to get the IRQ an

[Qemu-devel] [PULL 03/21] hw/arm/armv7m: Don't use arm_pic_init_cpu()

2013-08-20 Thread Peter Maydell
Drop the now-deprecated arm_pic_init_cpu() in favour of directly getting the IRQ line from the ARMCPU object. Signed-off-by: Peter Maydell Message-id: 1375977856-25046-3-git-send-email-peter.mayd...@linaro.org --- hw/arm/armv7m.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) dif

[Qemu-devel] [PULL 18/21] target-arm: Implement the generic timer

2013-08-20 Thread Peter Maydell
The ARMv7 architecture specifies a 'generic timer' which is implemented via cp15 registers. Newer kernels will prefer to use this rather than a devboard-level timer. Implement the generic timer for TCG; for KVM we will already use the hardware's virtualized timer for this. Signed-off-by: Peter May

  1   2   >