Re: [Qemu-devel] [PATCH for-next v2 01/22] object: Add OBJECT_GET_PARENT_CLASS() macro

2013-08-06 Thread Alexey Kardashevskiy
On 08/07/2013 04:10 PM, Peter Crosthwaite wrote: > On Wed, Aug 7, 2013 at 3:53 PM, Alexey Kardashevskiy wrote: >> On 08/07/2013 03:45 PM, Andreas Färber wrote: >>> Am 07.08.2013 07:38, schrieb Alexey Kardashevskiy: On 08/07/2013 02:20 PM, Peter Crosthwaite wrote: > Hi, > > On Wed,

Re: [Qemu-devel] [PATCH] Moving alarm_timer assignment before atexit()

2013-08-06 Thread Laszlo Ersek
On 08/07/13 01:29, Amos Kong wrote: > We register exit clean function by atexit(), > but alarm_timer is NULL here. If exit is caused > between atexit() and alarm_timer assignment, > real timer can't be cleaned. That's correct in general, but I don't see how it could happen in the code being patche

Re: [Qemu-devel] [PATCH for-next v2 01/22] object: Add OBJECT_GET_PARENT_CLASS() macro

2013-08-06 Thread Andreas Färber
Am 07.08.2013 07:53, schrieb Alexey Kardashevskiy: > On 08/07/2013 03:45 PM, Andreas Färber wrote: >> Am 07.08.2013 07:38, schrieb Alexey Kardashevskiy: >>> On 08/07/2013 02:20 PM, Peter Crosthwaite wrote: Hi, On Wed, Aug 7, 2013 at 1:36 PM, Alexey Kardashevskiy wrote: > O

Re: [Qemu-devel] [PATCH for-next v2 01/22] object: Add OBJECT_GET_PARENT_CLASS() macro

2013-08-06 Thread Peter Crosthwaite
On Wed, Aug 7, 2013 at 3:53 PM, Alexey Kardashevskiy wrote: > On 08/07/2013 03:45 PM, Andreas Färber wrote: >> Am 07.08.2013 07:38, schrieb Alexey Kardashevskiy: >>> On 08/07/2013 02:20 PM, Peter Crosthwaite wrote: Hi, On Wed, Aug 7, 2013 at 1:36 PM, Alexey Kardashevskiy wrot

Re: [Qemu-devel] [PATCH 5/6] xics: split to xics and xics-common

2013-08-06 Thread Alexey Kardashevskiy
On 08/06/2013 07:53 PM, Andreas Färber wrote: > Am 06.08.2013 10:27, schrieb Alexey Kardashevskiy: >> The upcoming XICS-KVM support will use bits of emulated XICS code. >> So this introduces new level of hierarchy - "xics-common" class. Both >> emulated XICS and XICS-KVM will inherit from it and ov

Re: [Qemu-devel] [PATCH for-next v2 01/22] object: Add OBJECT_GET_PARENT_CLASS() macro

2013-08-06 Thread Andreas Färber
Am 07.08.2013 05:36, schrieb Alexey Kardashevskiy: > This what I would suggest: > > #define OBJECT_GET_PARENT_CLASS(obj, name) \ > object_class_get_parent(OBJECT_GET_CLASS(ObjectClass, (obj), (name))) > > @name here is just to make sure we are at the right level of the class > hierarchy. > >

Re: [Qemu-devel] [PATCH for-next v2 01/22] object: Add OBJECT_GET_PARENT_CLASS() macro

2013-08-06 Thread Alexey Kardashevskiy
On 08/07/2013 03:45 PM, Andreas Färber wrote: > Am 07.08.2013 07:38, schrieb Alexey Kardashevskiy: >> On 08/07/2013 02:20 PM, Peter Crosthwaite wrote: >>> Hi, >>> >>> On Wed, Aug 7, 2013 at 1:36 PM, Alexey Kardashevskiy wrote: On 08/06/2013 06:33 PM, Andreas Färber wrote: > Am 06.08.2013

Re: [Qemu-devel] vm performance degradation after kvm live migration or save-restore with EPT enabled

2013-08-06 Thread Gleb Natapov
On Wed, Aug 07, 2013 at 01:34:41AM +, Zhanghaoyu (A) wrote: > >>> The QEMU command line (/var/log/libvirt/qemu/[domain name].log), > >>> LC_ALL=C PATH=/bin:/sbin:/usr/bin:/usr/sbin HOME=/ > >>> QEMU_AUDIO_DRV=none > >>> /usr/local/bin/qemu-system-x86_64 -name ATS1 -S -M pc-0.12 -cpu > >>> qe

Re: [Qemu-devel] [Patch] Fix typo in qom/object.h

2013-08-06 Thread Andreas Färber
Am 07.08.2013 04:31, schrieb Peter Chubb: > > There's been a cut-and-paste error, it looks like, in the documentation > in qom/object.h. > > Signed-off-by: Peter Chubb > > --- > include/qom/object.h |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to qom-next: http

Re: [Qemu-devel] [PATCH 2/4] timer: protect timers_state's clock with seqlock

2013-08-06 Thread liu ping fan
On Tue, Aug 6, 2013 at 5:30 PM, Stefan Hajnoczi wrote: > On Mon, Aug 05, 2013 at 03:33:24PM +0800, Liu Ping Fan wrote: >> diff --git a/cpus.c b/cpus.c >> index 85e743d..ab92db9 100644 >> --- a/cpus.c >> +++ b/cpus.c >> @@ -107,12 +107,17 @@ static int64_t qemu_icount; >> typedef struct TimersStat

Re: [Qemu-devel] [PATCH for-next v2 01/22] object: Add OBJECT_GET_PARENT_CLASS() macro

2013-08-06 Thread Andreas Färber
Am 07.08.2013 07:38, schrieb Alexey Kardashevskiy: > On 08/07/2013 02:20 PM, Peter Crosthwaite wrote: >> Hi, >> >> On Wed, Aug 7, 2013 at 1:36 PM, Alexey Kardashevskiy wrote: >>> On 08/06/2013 06:33 PM, Andreas Färber wrote: Am 06.08.2013 07:54, schrieb Alexey Kardashevskiy: > On 08/01/20

Re: [Qemu-devel] [PATCH for-next v2 01/22] object: Add OBJECT_GET_PARENT_CLASS() macro

2013-08-06 Thread Alexey Kardashevskiy
On 08/07/2013 02:20 PM, Peter Crosthwaite wrote: > Hi, > > On Wed, Aug 7, 2013 at 1:36 PM, Alexey Kardashevskiy wrote: >> On 08/06/2013 06:33 PM, Andreas Färber wrote: >>> Am 06.08.2013 07:54, schrieb Alexey Kardashevskiy: On 08/01/2013 12:17 PM, Andreas Färber wrote: > The object argume

Re: [Qemu-devel] [PATCH 2/5] target-ppc: USE LPCR_ILE to control exception endian on POWER7

2013-08-06 Thread Andreas Färber
Am 07.08.2013 02:47, schrieb Anton Blanchard: > On POWER7, LPCR_ILE is used to control what endian guests take > their exceptions in so use it instead of MSR_ILE. > > Signed-off-by: Anton Blanchard > --- > target-ppc/cpu.h | 2 ++ > target-ppc/excp_helper.c | 10 ++ > 2 files ch

Re: [Qemu-devel] [PATCH for-1.6? v2 14/21] milkymist: Suppress -kernel/-bios/-drive error for qtest

2013-08-06 Thread Michael Walle
Am 2013-08-05 15:27, schrieb Andreas Färber: Signed-off-by: Andreas Färber Acked-by: Michael Walle --- hw/lm32/milkymist.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c index 7ceedb8..a8e7230 100644 --- a/hw/lm32/milkymist.c

[Qemu-devel] [Bug 1204697] Re: guest disk accesses lead to ATA errors + host vcpu0 unhandled wrmsr/rdmsr

2013-08-06 Thread Bug Watch Updater
** Changed in: qemu (Debian) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1204697 Title: guest disk accesses lead to ATA errors + host vcpu0 unhandled wr

Re: [Qemu-devel] [PATCH for-next v2 01/22] object: Add OBJECT_GET_PARENT_CLASS() macro

2013-08-06 Thread Peter Crosthwaite
Hi, On Wed, Aug 7, 2013 at 1:36 PM, Alexey Kardashevskiy wrote: > On 08/06/2013 06:33 PM, Andreas Färber wrote: >> Am 06.08.2013 07:54, schrieb Alexey Kardashevskiy: >>> On 08/01/2013 12:17 PM, Andreas Färber wrote: The object argument is currently unused and may be used to optimize the

[Qemu-devel] [Bug 1208944] Re: -kernel option broken for some multiboot kernels

2013-08-06 Thread Martijn van den Broek
Patch sent to qemu-devel. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1208944 Title: -kernel option broken for some multiboot kernels Status in QEMU: New Bug description: When using the -ke

[Qemu-devel] [Bug 1208944] [NEW] -kernel option broken for some multiboot kernels

2013-08-06 Thread Martijn van den Broek
Public bug reported: When using the -kernel option QEMU fails with "Error while fetching elf kernel from rom" when the ELF file contains a segment with a file size of 0. This is typical for segments containing only a .bss section. rom_copy (hw/core/loader.c) fails to load roms (elf segments in th

[Qemu-devel] [PATCH] Bugfix for loading multiboot kernels

2013-08-06 Thread Martijn van den Broek
This patch fixes a bug in rom_copy introduced by commit d60fa42e8bae39440f997ebfe8fe328269a57d16. rom_copy failed to load roms with a "datasize" of 0. As a result, multiboot kernels were not loaded correctly when they contain a segment with a "file size" of 0. https://bugs.launchpad.net/qemu/+bug

Re: [Qemu-devel] KVM call agenda for 2013-08-06

2013-08-06 Thread Mauro Sanna
I want to subscribe from this list, where are istructions? On 6 August 2013 12:07, Michael S. Tsirkin wrote: > On Tue, Jul 23, 2013 at 06:31:45PM +0200, Juan Quintela wrote: > > > > Hi > > > > Please, send any topic that you are interested in covering. > > > > Thanks, Juan. > > > > PD. If you

Re: [Qemu-devel] [PATCH for-next v2 01/22] object: Add OBJECT_GET_PARENT_CLASS() macro

2013-08-06 Thread Alexey Kardashevskiy
On 08/06/2013 06:33 PM, Andreas Färber wrote: > Am 06.08.2013 07:54, schrieb Alexey Kardashevskiy: >> On 08/01/2013 12:17 PM, Andreas Färber wrote: >>> The object argument is currently unused and may be used to optimize the >>> class lookup when needed. >>> >>> Inspired-by: Peter Crosthwaite >>> S

[Qemu-devel] [PATCH V7 1/8] snapshot: new function bdrv_snapshot_find_by_id_and_name()

2013-08-06 Thread Wenchao Xia
To make it clear about id and name in searching, add this API to distinguish them. Caller can choose to search by id or name, *errp will be set only for exception. Some code are modified based on Pavel's patch. Signed-off-by: Wenchao Xia Signed-off-by: Pavel Hrdina Reviewed-by: Eric Blake ---

[Qemu-devel] [PATCH V7 0/8] add internal snapshot support at block device level

2013-08-06 Thread Wenchao Xia
This series brings internal snapshot support at block devices level, now we have two three methods to do block snapshot lively: 1) backing chain, 2) internal one and 3) drive-back up approach. Comparation: Advantages:Disadvantages: 1)delta data, taken

[Qemu-devel] [PATCH V7 7/8] hmp: add interface hmp_snapshot_delete_blkdev_internal

2013-08-06 Thread Wenchao Xia
It is hard to make both id and name optional in hmp console as qmp interface, so this interface require user to specify name. Signed-off-by: Wenchao Xia --- hmp-commands.hx | 18 ++ hmp.c | 12 hmp.h |1 + 3 files changed, 31 insertions(+)

[Qemu-devel] [PATCH V7 4/8] qmp: add interface blockdev-snapshot-internal-sync

2013-08-06 Thread Wenchao Xia
Snapshot ID can't be specified in this interface. Signed-off-by: Wenchao Xia --- blockdev.c | 13 + qapi-schema.json | 20 qmp-commands.hx | 29 + 3 files changed, 62 insertions(+), 0 deletions(-) diff --git a/blockdev.c

[Qemu-devel] [PATCH V7 6/8] hmp: add interface hmp_snapshot_blkdev_internal

2013-08-06 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- hmp-commands.hx | 19 +-- hmp.c | 10 ++ hmp.h |1 + 3 files changed, 28 insertions(+), 2 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 8c6b91a..039c401 100644 --- a/hmp-commands.hx +++ b/hmp-c

[Qemu-devel] [PATCH V7 3/8] qmp: add internal snapshot support in qmp_transaction

2013-08-06 Thread Wenchao Xia
Unlike savevm, the qmp_transaction interface will not generate snapshot name automatically, saving trouble to return information of the new created snapshot. Although qcow2 support storing multiple snapshots with same name but different ID, here it will fail when an snapshot with that name already

[Qemu-devel] [PATCH V7 5/8] qmp: add interface blockdev-snapshot-delete-internal-sync

2013-08-06 Thread Wenchao Xia
This interface use id and name as optional parameters, to handle the case that one image contain multiple snapshots with same name which may be '', but with different id. Adding parameter id is for historical compatiability reason, and that case is not possible in qemu's new interface for internal

Re: [Qemu-devel] [PATCH V6 0/8] add internal snapshot support at block device level

2013-08-06 Thread Wenchao Xia
于 2013-7-30 10:59, Wenchao Xia 写道: >> This series brings internal snapshot support at block devices > level, now we >> have two three methods to do block snapshot lively: 1) backing chain, >> 2) internal one and 3) drive-back up approach. >> >> Comparation: >>Advantages:

[Qemu-devel] [PATCH V7 8/8] qemu-iotests: add 057 internal snapshot for block device test case

2013-08-06 Thread Wenchao Xia
Create in transaction and deletion in single command will be tested. Signed-off-by: Wenchao Xia --- tests/qemu-iotests/057 | 259 tests/qemu-iotests/057.out |5 + tests/qemu-iotests/group |1 + 3 files changed, 265 insertions(+), 0 dele

[Qemu-devel] [PATCH V7 2/8] snapshot: distinguish id and name in snapshot delete

2013-08-06 Thread Wenchao Xia
Snapshot creation actually already distinguish id and name since it take a structured parameter *sn, but delete can't. Later an accurate delete is needed in qmp_transaction abort and blockdev-snapshot-delete-sync, so change its prototype. Also *errp is added to tip error, but return value is kepted

Re: [Qemu-devel] [PATCH v6 01/18] block: ensure bdrv_drain_all() works during bdrv_delete()

2013-08-06 Thread Wenchao Xia
On Fri, Jul 26, 2013 at 02:43:44PM +0800, Wenchao Xia wrote: Reviewed-by: Wenchao Xia One question: old code missed itself in bdrv_drain_all(), is that a bug? Sorry, I don't understand the question. Can you rephrase it? Before this patch, in the code path: bdrv_close()->bdrv_drain_all(),

[Qemu-devel] [Patch] Fix typo in qom/object.h

2013-08-06 Thread peter . chubb
There's been a cut-and-paste error, it looks like, in the documentation in qom/object.h. Signed-off-by: Peter Chubb --- include/qom/object.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: qemu/include/qom/object.h

[Qemu-devel] [PATCH 0/3] rdma: validate remote provided RDMAControlHeader::len

2013-08-06 Thread Isaku Yamahata
RDMAControlHeader::len is remote-provided. So validate the value before use. Isaku Yamahata (3): rdma: use resp.len after validation in qemu_rdma_registration_stop rdma: validate RDMAControlHeader::len rdma: check if RDMAControlHeader::len match transferred byte migration-rdma.c | 44 +++

[Qemu-devel] [PATCH 1/3] rdma: use resp.len after validation in qemu_rdma_registration_stop

2013-08-06 Thread Isaku Yamahata
resp.len is given from remote host. So should be validated before use. Otherwise memcpy can access beyond the buffer. Cc: Michael R. Hines Signed-off-by: Isaku Yamahata --- migration-rdma.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/migration-rdma.c b/migratio

[Qemu-devel] [PATCH 2/3] rdma: validate RDMAControlHeader::len

2013-08-06 Thread Isaku Yamahata
RMDAControlHeader::len is provided from remote, so validate it. Cc: Michael R. Hines Signed-off-by: Isaku Yamahata --- migration-rdma.c |5 + 1 file changed, 5 insertions(+) diff --git a/migration-rdma.c b/migration-rdma.c index 6721266..ebe1f55 100644 --- a/migration-rdma.c +++ b/migr

[Qemu-devel] [PATCH 3/3] rdma: check if RDMAControlHeader::len match transferred byte

2013-08-06 Thread Isaku Yamahata
RDMAControlHeader::len is provided from remote, so check if the value match the actual transferred byte_len. Cc: Michael R. Hines Signed-off-by: Isaku Yamahata --- migration-rdma.c | 32 ++-- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/migration

Re: [Qemu-devel] [Patch] ARM: Add an L2 cache controller to KZM

2013-08-06 Thread Peter Chubb
OK, this is what I've come up with. Dunno whether it's right or not -- the object model is decoupled from the memory model, so there's no straightforward way to override just a few of the registers. At this stage this is just for comment, as I don't really have that much of a clue about how the

Re: [Qemu-devel] [PATCH for-next v2 01/22] object: Add OBJECT_GET_PARENT_CLASS() macro

2013-08-06 Thread Peter Crosthwaite
On Thu, Aug 1, 2013 at 12:17 PM, Andreas Färber wrote: > The object argument is currently unused and may be used to optimize the > class lookup when needed. > > Inspired-by: Peter Crosthwaite > Signed-off-by: Andreas Färber Reviewed-by: Peter Crosthwaite One minor nit about comments below but

Re: [Qemu-devel] vm performance degradation after kvm live migration or save-restore with EPT enabled

2013-08-06 Thread Zhanghaoyu (A)
>>> The QEMU command line (/var/log/libvirt/qemu/[domain name].log), >>> LC_ALL=C PATH=/bin:/sbin:/usr/bin:/usr/sbin HOME=/ >>> QEMU_AUDIO_DRV=none >>> /usr/local/bin/qemu-system-x86_64 -name ATS1 -S -M pc-0.12 -cpu >>> qemu32 -enable-kvm -m 12288 -smp 4,sockets=4,cores=1,threads=1 -uuid >>> 050

Re: [Qemu-devel] [PATCH 0/5] 64bit PowerPC little endian support

2013-08-06 Thread Anthony Liguori
On Tue, Aug 6, 2013 at 7:46 PM, Anton Blanchard wrote: > This patchset adds support for 64bit PowerPC little endian on POWER7. > > Linux kernel patches to support this were sent out earlier today: > > https://lists.ozlabs.org/pipermail/linuxppc-dev/2013-August/109849.html Nice :-) This will need

Re: [Qemu-devel] [PATCH 5/5] pseries: Fix loading of little endian kernels

2013-08-06 Thread Anthony Liguori
On Tue, Aug 6, 2013 at 7:47 PM, Anton Blanchard wrote: > From: Benjamin Herrenschmidt > > Try loading the kernel as little endian if it fails big endian. > > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: Anton Blanchard Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- >

Re: [Qemu-devel] [PATCH 4/5] disas/ppc.c: Fix little endian disassembly

2013-08-06 Thread Anthony Liguori
On Tue, Aug 6, 2013 at 7:47 PM, Anton Blanchard wrote: > Use info->endian to select the endian of the instruction to > be disassembled. > > Signed-off-by: Anton Blanchard Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > disas/ppc.c | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [Qemu-devel] [PATCH 3/5] pseries: Add H_SET_MODE hcall to change guest exception endianness

2013-08-06 Thread Anthony Liguori
On Tue, Aug 6, 2013 at 7:47 PM, Anton Blanchard wrote: > H_SET_MODE is used for controlling various partition settings. One > of these settings is the endianness a guest takes its exceptions in. > > Signed-off-by: Anton Blanchard > --- > hw/ppc/spapr.c | 2 +- > hw/ppc/spapr_hcall.c |

Re: [Qemu-devel] [PATCH 2/5] target-ppc: USE LPCR_ILE to control exception endian on POWER7

2013-08-06 Thread Anthony Liguori
On Tue, Aug 6, 2013 at 7:47 PM, Anton Blanchard wrote: > On POWER7, LPCR_ILE is used to control what endian guests take > their exceptions in so use it instead of MSR_ILE. > > Signed-off-by: Anton Blanchard Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > target-ppc/cpu.h

Re: [Qemu-devel] [PATCH 1/5] target-ppc: POWER7 supports the MSR_LE bit

2013-08-06 Thread Anthony Liguori
On Tue, Aug 6, 2013 at 7:47 PM, Anton Blanchard wrote: > Add MSR_LE to the msr_mask for POWER7. > > Signed-off-by: Anton Blanchard Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > target-ppc/translate_init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[Qemu-devel] [PATCH 4/5] disas/ppc.c: Fix little endian disassembly

2013-08-06 Thread Anton Blanchard
Use info->endian to select the endian of the instruction to be disassembled. Signed-off-by: Anton Blanchard --- disas/ppc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/disas/ppc.c b/disas/ppc.c index c149506..99c4cbc 100644 --- a/disas/ppc.c +++ b/disas/ppc.c @@ -5157,7

[Qemu-devel] [PATCH 3/5] pseries: Add H_SET_MODE hcall to change guest exception endianness

2013-08-06 Thread Anton Blanchard
H_SET_MODE is used for controlling various partition settings. One of these settings is the endianness a guest takes its exceptions in. Signed-off-by: Anton Blanchard --- hw/ppc/spapr.c | 2 +- hw/ppc/spapr_hcall.c | 44 include/hw/ppc/spap

[Qemu-devel] [PATCH 2/5] target-ppc: USE LPCR_ILE to control exception endian on POWER7

2013-08-06 Thread Anton Blanchard
On POWER7, LPCR_ILE is used to control what endian guests take their exceptions in so use it instead of MSR_ILE. Signed-off-by: Anton Blanchard --- target-ppc/cpu.h | 2 ++ target-ppc/excp_helper.c | 10 ++ 2 files changed, 12 insertions(+) diff --git a/target-ppc/cpu.h b/targe

[Qemu-devel] [PATCH 1/5] target-ppc: POWER7 supports the MSR_LE bit

2013-08-06 Thread Anton Blanchard
Add MSR_LE to the msr_mask for POWER7. Signed-off-by: Anton Blanchard --- target-ppc/translate_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index b14aec8..33914bc 100644 --- a/target-ppc/translate_init.c +++

[Qemu-devel] [PATCH 5/5] pseries: Fix loading of little endian kernels

2013-08-06 Thread Anton Blanchard
From: Benjamin Herrenschmidt Try loading the kernel as little endian if it fails big endian. Signed-off-by: Benjamin Herrenschmidt Signed-off-by: Anton Blanchard --- hw/ppc/spapr.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.

[Qemu-devel] [PATCH 0/5] 64bit PowerPC little endian support

2013-08-06 Thread Anton Blanchard
This patchset adds support for 64bit PowerPC little endian on POWER7. Linux kernel patches to support this were sent out earlier today: https://lists.ozlabs.org/pipermail/linuxppc-dev/2013-August/109849.html Anton -- Anton Blanchard (4): target-ppc: POWER7 supports the MSR_LE bit target-ppc

[Qemu-devel] [RFC] [PATCHv7 08/22] aio / timers: Untangle include files

2013-08-06 Thread Alex Bligh
include/qemu/timer.h has no need to include main-loop.h and doing so causes an issue for the next patch. Unfortunately various files assume including timers.h will pull in main-loop.h. Untangle this mess. Signed-off-by: Alex Bligh --- dma-helpers.c |1 + hw/dma/xilinx_axidma.c

Re: [Qemu-devel] [PATCH for-1.6] qemu-timer: fix get_clock() gettimeofday() fallback #ifdef

2013-08-06 Thread Brad Smith
On 06/08/13 7:48 AM, Stefan Hajnoczi wrote: If CLOCK_MONOTONIC is not defined by system headers we use gettimeofday(2). Apparently this is not used very often since no one noticed the #ifdef was actually broken and left the function definition unterminated. Can you show what this supposedly fi

[Qemu-devel] [RFC] [PATCHv7 05/22] aio / timers: Add prctl(PR_SET_TIMERSLACK, 1, ...) to reduce timer slack

2013-08-06 Thread Alex Bligh
Where supported, called prctl(PR_SET_TIMERSLACK, 1, ...) to set one nanosecond timer slack to increase precision of timer calls. Signed-off-by: Alex Bligh --- qemu-timer.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 3109b

[Qemu-devel] [RFC] [PATCHv7 18/22] aio / timers: Use all timerlists in icount warp calculations

2013-08-06 Thread Alex Bligh
Notify all timerlists derived from vm_clock in icount warp calculations. When calculating timer delay based on vm_clock deadline, use all timerlists. For compatibility, maintain an apparent bug where when using icount, if no vm_clock timer was set, qemu_clock_deadline would return INT32_MAX and a

Re: [Qemu-devel] [RFC] [PATCHv5 06/16] aio / timers: Untangle include files

2013-08-06 Thread Alex Bligh
Stefan, --On 6 August 2013 12:10:17 +0200 Stefan Hajnoczi wrote: Fails to build ui/vnc-auth-sasl.c Please make sure that your ./configure output shows most optional dependencies are available (you need to install development packages for these libraries). Otherwise you will not see build b

Re: [Qemu-devel] [RFC] [PATCHv6 05/16] aio / timers: Split QEMUClock into QEMUClock and QEMUTimerList

2013-08-06 Thread Alex Bligh
Stefan, --On 6 August 2013 16:29:40 +0200 Stefan Hajnoczi wrote: At the very least we should put the conversion to use the new API into a separate patch (possibly a separate patch set). It's fantastically intrusive. Yes, it should be a separate patch. OK - this separate patch is not in t

[Qemu-devel] [RFC] [PATCHv7 17/22] aio / timers: Introduce new API qemu_timer_new and friends

2013-08-06 Thread Alex Bligh
Introduce new API for creating timers - qemu_timer_new and _ns, _ms, _us derivatives. Signed-off-by: Alex Bligh --- include/qemu/timer.h | 69 ++ 1 file changed, 69 insertions(+) diff --git a/include/qemu/timer.h b/include/qemu/timer.h index ddc

[Qemu-devel] [RFC] [PATCHv7 20/22] aio / timers: Remove alarm timers

2013-08-06 Thread Alex Bligh
Remove alarm timers from qemu-timers.c now we use g_poll / ppoll instead. Signed-off-by: Alex Bligh --- include/qemu/timer.h |3 - main-loop.c |4 - qemu-timer.c | 500 +- vl.c |4 +- 4 files changed, 4

[Qemu-devel] [RFC] [PATCHv7 21/22] aio / timers: Add test harness for AioContext timers

2013-08-06 Thread Alex Bligh
Add a test harness for AioContext timers. The g_source equivalent is unsatisfactory as it suffers from false wakeups. Signed-off-by: Alex Bligh --- tests/test-aio.c | 137 ++ 1 file changed, 137 insertions(+) diff --git a/tests/test-aio.c b/t

[Qemu-devel] [RFC] [PATCHv7 15/22] aio / timers: Convert mainloop to use timeout

2013-08-06 Thread Alex Bligh
Convert mainloop to use timeout from default timerlist group (i.e. the current 3 static timers) Signed-off-by: Alex Bligh --- main-loop.c | 45 ++--- 1 file changed, 34 insertions(+), 11 deletions(-) diff --git a/main-loop.c b/main-loop.c index a44fff6.

[Qemu-devel] [RFC] [PATCHv7 07/22] aio / timers: Split QEMUClock into QEMUClock and QEMUTimerList

2013-08-06 Thread Alex Bligh
Split QEMUClock into QEMUClock and QEMUTimerList so that we can have more than one QEMUTimerList associated with the same clock. Introduce a default_timerlist concept and make existing qemu_clock_* calls that actually should operate on a QEMUTimerList call the relevant QEMUTimerList implementation

[Qemu-devel] [RFC] [PATCHv7 22/22] aio / timers: Remove legacy qemu_clock_deadline & qemu_timerlist_deadline

2013-08-06 Thread Alex Bligh
Remove qemu_clock_deadline and qemu_timerlist_deadline now we are using the ns functions throughout. Signed-off-by: Alex Bligh --- include/qemu/timer.h | 16 qemu-timer.c | 20 2 files changed, 36 deletions(-) diff --git a/include/qemu/timer.h b

[Qemu-devel] [RFC] [PATCHv7 06/22] aio / timers: Make qemu_run_timers and qemu_run_all_timers return progress

2013-08-06 Thread Alex Bligh
Make qemu_run_timers and qemu_run_all_timers return progress so that aio_poll etc. can determine whether a timer has been run. Signed-off-by: Alex Bligh --- include/qemu/timer.h | 21 +++-- qemu-timer.c | 18 -- 2 files changed, 31 insertions(+), 8 del

[Qemu-devel] [RFC] [PATCHv7 16/22] aio / timers: On timer modification, qemu_notify or aio_notify

2013-08-06 Thread Alex Bligh
On qemu_mod_timer_ns, ensure qemu_notify or aio_notify is called to end the appropriate poll(), irrespective of use_icount value. On qemu_clock_enable, ensure qemu_notify or aio_notify is called for all QEMUTimerLists attached to the QEMUClock. Signed-off-by: Alex Bligh --- include/qemu/timer.h

[Qemu-devel] [RFC] [PATCHv7 12/22] aio / timers: aio_ctx_prepare sets timeout from AioContext timers

2013-08-06 Thread Alex Bligh
Calculate the timeout in aio_ctx_prepare taking into account the timers attached to the AioContext. Alter aio_ctx_check similarly. Signed-off-by: Alex Bligh --- async.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/async.c b/async.c index 2051921..dd27459

[Qemu-devel] [RFC] [PATCHv7 13/22] aio / timers: Add aio_timer_new wrapper

2013-08-06 Thread Alex Bligh
Add aio_timer_new wrapper function. Signed-off-by: Alex Bligh --- include/block/aio.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/block/aio.h b/include/block/aio.h index a13f6e8..bd6f17c 100644 --- a/include/block/aio.h +++ b/include/block/aio.h @@ -255,4 +

[Qemu-devel] [RFC] [PATCHv7 14/22] aio / timers: Convert aio_poll to use AioContext timers' deadline

2013-08-06 Thread Alex Bligh
Convert aio_poll to use deadline based on AioContext's timers. aio_poll has been changed to return accurately whether progress has occurred. Prior to this commit, aio_poll always returned true if g_poll was entered, whether or not any progress was made. This required a change to tests/test-aio.c w

[Qemu-devel] [RFC] [PATCHv7 10/22] aio / timers: Add QEMUTimerListGroup to AioContext

2013-08-06 Thread Alex Bligh
Add a QEMUTimerListGroup each AioContext (meaning a QEMUTimerList associated with each clock is added) and delete it when the AioContext is freed. Signed-off-by: Alex Bligh --- async.c |2 ++ include/block/aio.h |4 tests/test-aio.c |3 +++ tests/te

[Qemu-devel] [RFC] [PATCHv7 19/22] aio / timers: Add documentation and new format calls

2013-08-06 Thread Alex Bligh
Add documentation for existing qemu timer calls. Add new format calls of the format qemu_timer_XXX rather than qemu_XXX_timer for consistency. Signed-off-by: Alex Bligh --- configure| 18 + include/qemu/timer.h | 215 +- 2 files

[Qemu-devel] [RFC] [PATCHv7 11/22] aio / timers: Add a notify callback to QEMUTimerList

2013-08-06 Thread Alex Bligh
Add a notify pointer to QEMUTimerList so it knows what to notify on a timer change. Signed-off-by: Alex Bligh --- async.c |7 ++- include/qemu/timer.h | 35 --- qemu-timer.c | 24 ++-- 3 files changed, 60 insert

[Qemu-devel] [RFC] [PATCHv7 09/22] aio / timers: Add QEMUTimerListGroup and helper functions

2013-08-06 Thread Alex Bligh
Add QEMUTimerListGroup and helper functions, to represent a QEMUTimerList associated with each clock. Add a default QEMUTimerListGroup representing the default timer lists which are not associated with any other object (e.g. an AioContext as added by future patches). Signed-off-by: Alex Bligh ---

[Qemu-devel] [RFC] [PATCHv7 04/22] aio / timers: add ppoll support with qemu_poll_ns

2013-08-06 Thread Alex Bligh
Add qemu_poll_ns which works like g_poll but takes a nanosecond timeout. Signed-off-by: Alex Bligh --- configure| 19 +++ include/qemu/timer.h | 12 qemu-timer.c | 24 3 files changed, 55 insertions(+) diff --git a/

[Qemu-devel] [RFC] [PATCHv7 02/22] aio / timers: add qemu-timer.c utility functions

2013-08-06 Thread Alex Bligh
Add utility functions to qemu-timer.c for nanosecond timing. Add qemu_clock_deadline_ns to calculate deadlines to nanosecond accuracy. Add utility function qemu_soonest_timeout to calculate soonest deadline. Add qemu_timeout_ns_to_ms to convert a timeout in nanoseconds back to milliseconds for w

[Qemu-devel] [RFC] [PATCHv7 00/22] aio / timers: Add AioContext timers and use ppoll

2013-08-06 Thread Alex Bligh
This patch series adds support for timers attached to an AioContext clock which get called within aio_poll. In doing so it removes alarm timers and moves to use ppoll where possible. This patch set 'sort of' passes make check (see below for caveat) including a new test harness for the aio timers,

[Qemu-devel] [RFC] [PATCHv7 03/22] aio / timers: Consistent treatment of disabled clocks for deadlines

2013-08-06 Thread Alex Bligh
Make treatment of disabled clocks consistent in deadline calculation Signed-off-by: Alex Bligh --- qemu-timer.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-timer.c b/qemu-timer.c index 2a862bc..0617e3e 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -269,7 +269,7

[Qemu-devel] [RFC] [PATCHv7 01/22] aio / timers: Add qemu_clock_free and expose qemu_clock_new and clock types

2013-08-06 Thread Alex Bligh
Add qemu_clock_free and expose qemu_new_clock as qemu_clock_new. Expose clock types. Signed-off-by: Alex Bligh --- include/qemu/timer.h | 22 ++ qemu-timer.c | 11 ++- 2 files changed, 28 insertions(+), 5 deletions(-) diff --git a/include/qemu/timer.h b/

[Qemu-devel] [PATCH] Moving alarm_timer assignment before atexit()

2013-08-06 Thread Amos Kong
We register exit clean function by atexit(), but alarm_timer is NULL here. If exit is caused between atexit() and alarm_timer assignment, real timer can't be cleaned. So move alarm_timer assignment before atexit(). Signed-off-by: Amos Kong --- qemu-timer.c | 2 +- 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [PATCH v3 for-qmp-1.6 0/4] dump-guest-memory: correct the vmcores

2013-08-06 Thread Laszlo Ersek
On 08/06/13 22:13, Luiz Capitulino wrote: > On Tue, 6 Aug 2013 12:37:07 +0200 > Laszlo Ersek wrote: > >> v2->v3 [Paolo]: >> - The memory API guarantees an increasing traversal. Drop the hash >> tables and build the final list directly in the region_add callback, >> merging any adjacent regio

Re: [Qemu-devel] [PATCH v3 for-qmp-1.6 0/4] dump-guest-memory: correct the vmcores

2013-08-06 Thread Luiz Capitulino
On Tue, 6 Aug 2013 12:37:07 +0200 Laszlo Ersek wrote: > v2->v3 [Paolo]: > - The memory API guarantees an increasing traversal. Drop the hash > tables and build the final list directly in the region_add callback, > merging any adjacent region only with the last element on the list. > (Patch

[Qemu-devel] [Bug 1204697] Re: guest disk accesses lead to ATA errors + host vcpu0 unhandled wrmsr/rdmsr

2013-08-06 Thread Christoph Anton Mitterer
>From a first test of the Debian package in experimental, I'd say that the >issue has been fixed :) Thanks a lot for all your help! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1204697 Title: gue

[Qemu-devel] [PULL for-1.6 0/1] QOM CPUState patch queue 2013-08-06

2013-08-06 Thread Andreas Färber
Hello Anthony, This is my current QOM CPU patch queue for 1.6. Please pull. Thanks, Andreas Cc: Anthony Liguori The following changes since commit a1fc6246b3964e74ddb3a7e0b8bba03af1c6ac38: target-mips: fix decoding of microMIPS POOL32Axf instructions (2013-08-06 13:09:14 +0200) are availa

[Qemu-devel] [PULL 1/1] target-i386: Fix X86CPU error handling

2013-08-06 Thread Andreas Färber
Error **errp argument is not for emitting warnings, it means an error has occurred and the caller should not make any assumptions about the state of other return values (unless otherwise documented). Therefore cpu_x86_create() must unref the new X86CPU itself, and pc_new_cpu() must check for an Er

[Qemu-devel] [PATCH] audio/mixeng_template.h: fix inline declaration

2013-08-06 Thread Alex Bligh
Fix error: ‘inline’ is not at beginning of declaration [-Werror=old-style-declaration] Signed-off-by: Alex Bligh --- audio/mixeng_template.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/audio/mixeng_template.h b/audio/mixeng_template.h index 30849a6..77cc89b 100644

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Andreas Färber
Am 06.08.2013 11:20, schrieb Gleb Natapov: > On Tue, Aug 06, 2013 at 10:45:01AM +0200, Andreas Färber wrote: >> Am 06.08.2013 10:36, schrieb Gleb Natapov: >>> On Tue, Aug 06, 2013 at 11:33:10AM +0300, Michael S. Tsirkin wrote: On Tue, Aug 06, 2013 at 10:21:52AM +0300, Gleb Natapov wrote: >

Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI

2013-08-06 Thread Andreas Färber
Am 06.08.2013 14:00, schrieb Gleb Natapov: > On Tue, Aug 06, 2013 at 01:23:49PM +0200, Andreas Färber wrote: >> Am 06.08.2013 13:00, schrieb Gleb Natapov: >>> On Tue, Aug 06, 2013 at 12:35:10PM +0200, Andreas Färber wrote: I wonder if IPMI might be such an alternative in the future, in which >

Re: [Qemu-devel] [PATCH] KVM: always use MADV_DONTFORK

2013-08-06 Thread Benoît Canet
Le Thursday 25 Jul 2013 à 12:11:15 (+0200), Andrea Arcangeli a écrit : > MADV_DONTFORK prevents fork to fail with -ENOMEM if the default > overcommit heuristics decides there's too much anonymous virtual > memory allocated. If the KVM secondary MMU is synchronized with MMU > notifiers or not, doesn

Re: [Qemu-devel] [PATCH v3] target-mips: fix decoding of microMIPS POOL32Axf instructions

2013-08-06 Thread Aurelien Jarno
On Tue, Aug 06, 2013 at 11:59:25AM +0100, Leon Alrae wrote: > Fix incorrect assumption that DSP and non-DSP versions of the following > instructions have the same encoding: > MULT, MULTU, MADD, MADDU, MSUB, MSUBU, MFHI, MFLO, MTHI, MTLO. > Correct the existing (non-DSP) instructions and add DSP equ

Re: [Qemu-devel] KVM call minutes for 2013-08-06

2013-08-06 Thread Gleb Natapov
On Tue, Aug 06, 2013 at 05:47:36PM +0200, Paolo Bonzini wrote: > On 08/06/2013 05:15 PM, Juan Quintela wrote: > >* pvpanic > >- was added by default in 1.5, this might have been too rash: > > - might change guest behaviour if guest is set to reboot on panic > > Interesting, but it looks like e

Re: [Qemu-devel] [PATCH] KVM: always use MADV_DONTFORK

2013-08-06 Thread Andreas Färber
Am 25.07.2013 12:32, schrieb Andrea Arcangeli: > On Thu, Jul 25, 2013 at 11:16:44AM +0100, Peter Maydell wrote: >> On 25 July 2013 11:11, Andrea Arcangeli wrote: >>> diff --git a/exec.c b/exec.c >>> index c99a883..d3bb58d 100644 >>> --- a/exec.c >>> +++ b/exec.c >>> @@ -1162,6 +1162,7 @@ ram_addr_

Re: [Qemu-devel] [PATCH v3 for-qmp-1.6 0/4] dump-guest-memory: correct the vmcores

2013-08-06 Thread Paolo Bonzini
> v2->v3 [Paolo]: > - The memory API guarantees an increasing traversal. Drop the hash > tables and build the final list directly in the region_add callback, > merging any adjacent region only with the last element on the list. > (Patch #3.) I only looked at this change, it looks good. Than

[Qemu-devel] PING for-1.6 Re: [PATCH] KVM: always use MADV_DONTFORK

2013-08-06 Thread Paolo Bonzini
On 07/25/2013 12:11 PM, Andrea Arcangeli wrote: MADV_DONTFORK prevents fork to fail with -ENOMEM if the default overcommit heuristics decides there's too much anonymous virtual memory allocated. If the KVM secondary MMU is synchronized with MMU notifiers or not, doesn't make a difference in that

Re: [Qemu-devel] KVM call minutes for 2013-08-06

2013-08-06 Thread Paolo Bonzini
On 08/06/2013 05:15 PM, Juan Quintela wrote: * pvpanic - was added by default in 1.5, this might have been too rash: - might change guest behaviour if guest is set to reboot on panic Interesting, but it looks like either a feature or a driver bug. - might cause slightly annoyi

Re: [Qemu-devel] [RFC] [PATCHv6 00/16] aio / timers: Add AioContext timers and use ppoll

2013-08-06 Thread Stefan Hajnoczi
On Tue, Aug 06, 2013 at 10:16:16AM +0100, Alex Bligh wrote: > This patch series adds support for timers attached to an AioContext clock > which get called within aio_poll. > > In doing so it removes alarm timers and moves to use ppoll where possible. > > This patch set 'sort of' passes make check

[Qemu-devel] Call for agenda for 2013-08-20

2013-08-06 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. Thanks, Juan. Agenda so far: - Talk about qemu reverse executing (1st description was done this week) How to handle IO when we want to do reverse execution. How this relate to Kemari needs? And to icount changes? Call details

[Qemu-devel] [PULL 02/14] ignore SIGPIPE in qemu-img and qemu-io

2013-08-06 Thread Kevin Wolf
From: MORITA Kazutaka This prevents the tools from being stopped when they write data to a closed connection in the other side. Signed-off-by: MORITA Kazutaka Reviewed-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- qemu-img.c | 4 qemu-io.c | 4 2 files changed, 8 insertions(+)

[Qemu-devel] KVM call minutes for 2013-08-06

2013-08-06 Thread Juan Quintela
Hi if you find that Today minutes are better than usual, I am learning to delegate and ask people for help. Thanks to: - mst - eduardo - stephan 2013-08-06 -- What libvirt needs/miss Today? - how to handle machine types? creating them inside qemu? - qemu --cpu help only shows cpus,

[Qemu-devel] [PULL 03/14] iov: handle EOF in iov_send_recv

2013-08-06 Thread Kevin Wolf
From: MORITA Kazutaka Without this patch, iov_send_recv() never returns when do_send_recv() returns zero. Signed-off-by: MORITA Kazutaka Reviewed-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- util/iov.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/util/iov.c b/util/iov.c index

Re: [Qemu-devel] [PATCH 6/6] xics-kvm: Support for in-kernel XICS interrupt controller

2013-08-06 Thread Andreas Färber
Am 06.08.2013 14:06, schrieb Alexey Kardashevskiy: > On 08/06/2013 08:12 PM, Andreas Färber wrote: >>> diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h >>> index 1066f69..e5889e9 100644 >>> --- a/include/hw/ppc/xics.h >>> +++ b/include/hw/ppc/xics.h >>> @@ -35,6 +35,9 @@ >>> #define TYPE

  1   2   3   >