[Qemu-devel] [PATCH V7 05/11] NUMA: Add Linux libnuma detection

Add detection of libnuma (mostly contained in the numactl package) to the configure script. Can be enabled or disabled on the command line, default is use if available. Signed-off-by: Andre Przywara Signed-off-by: Wanlong Gao --- configure | 32 1 file changed,

[Qemu-devel] [PATCH V7 11/11] NUMA: convert hmp command info_numa to use qmp command query_numa

Signed-off-by: Wanlong Gao --- hmp.c | 54 ++ hmp.h | 1 + monitor.c | 21 + 3 files changed, 56 insertions(+), 20 deletions(-) diff --git a/hmp.c b/hmp.c index 98d2a76..3b2f04d 100644 --- a/hmp.c +++ b/hmp.c @@ -27

[Qemu-devel] [PATCH V7 01/11] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions

Signed-off-by: Wanlong Gao --- qapi-schema.json | 47 +++ 1 file changed, 47 insertions(+) diff --git a/qapi-schema.json b/qapi-schema.json index a51f7d2..b9b18e4 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -3773,3 +3773,50 @@ ## { 'comma

Re: [Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided

Michal Novotny writes: > Output error message to stderr when user provides the invalid machine > type on the command line. This also saves time to find what issue is > when you downgrade from one version of qemu to another that doesn't > support required machine type yet (the version user downgra

[Qemu-devel] [PATCH V7 09/11] NUMA: add hmp command set-mem-policy

Add hmp command set-mem-policy to set host memory policy for a guest NUMA node. Then we can also set node's memory policy using the monitor command like: (qemu) set-mem-policy 0 policy=membind,relative=false,host-nodes=0-1 Signed-off-by: Wanlong Gao --- hmp-commands.hx | 16 ++ h

[Qemu-devel] [PATCH V7 08/11] NUMA: add qmp command set-mem-policy to set memory policy for NUMA node

This QMP command allows user set guest node's memory policy through the QMP protocol. The qmp-shell command is like: set-mem-policy nodeid=0 policy=membind relative=true host-nodes=0-1 Signed-off-by: Wanlong Gao --- numa.c | 62 ++

[Qemu-devel] [PATCH V7 03/11] NUMA: move numa related code to numa.c

Signed-off-by: Wanlong Gao --- cpus.c | 14 --- include/sysemu/cpus.h | 1 - include/sysemu/sysemu.h | 2 ++ numa.c | 65 + vl.c| 47 +-- 5 files chang

[Qemu-devel] [PATCH V7 06/11] NUMA: parse guest numa nodes memory policy

The memory policy setting format is like: policy={default|membind|interleave|preferred}[,relative=true],host-nodes=N-N And we are adding this setting as a suboption of "-numa mem,", the memory policy then can be set like following: -numa node,nodeid=0,cpus=0 \ -numa node,nodeid=1,cpus=1

[Qemu-devel] [PATCH V7 00/11] Add support for binding guest numa nodes to host numa nodes

As you know, QEMU can't direct it's memory allocation now, this may cause guest cross node access performance regression. And, the worse thing is that if PCI-passthrough is used, direct-attached-device uses DMA transfer between device and qemu process. All pages of the guest will be pinned by get_u

[Qemu-devel] [PATCH V7 07/11] NUMA: set guest numa nodes memory policy

Set the guest numa nodes memory policies using the mbind(2) system call node by node. After this patch, we are able to set guest nodes memory policies through the QEMU options, this arms to solve the guest cross nodes memory access performance issue. And as you all know, if PCI-passthrough is used,

[Qemu-devel] [PATCH V7 02/11] NUMA: split -numa option

Change -numa option like following as Paolo suggested: -numa node,nodeid=0,cpus=0-1 \ -numa mem,nodeid=0,size=1G This new option will make later coming memory hotplug better. And this new option is implemented using OptsVisitor. And just remain "-numa node,mem=xx" as legacy. Reviewed-by:

Re: [Qemu-devel] [PATCH v3] vl.c: Output error on invalid machine type provided

On 07/30/2013 09:29 PM, Eric Blake wrote: > On 07/30/2013 01:10 PM, Michal Novotny wrote: >> Output error message when user provides the invalid machine type >> on the command line. This also saves time to find what issue is >> when you upgrade from one version of qemu to another version that >> d

[Qemu-devel] [PATCH v4] vl.c: Output error on invalid machine type provided

Output error message to stderr when user provides the invalid machine type on the command line. This also saves time to find what issue is when you downgrade from one version of qemu to another that doesn't support required machine type yet (the version user downgraded to have to have this patch ap

[Qemu-devel] [PATCH 2/2] LICENSE: clarify

1) The GPL says that "if the Program does not specify a version number of this License, you may choose any version ever published by the Free Software Foundation". This is not true, QEMU includes parts that are v2-only. 2) Provide a default for files with no licensing information. 3) It is not j

Re: [Qemu-devel] Licensing question

Il 31/07/2013 07:45, Erik de Castro Lopo ha scritto: > Stefan Weil wrote: > >> No, there is no such statement. >> >> There is an agreement that files with GPL should be GPLv2+ >> (not only GPLv2), but files may also use other free licenses. >> >> In file LICENSE, it is said that QEMU as a whole is

[Qemu-devel] [PATCH 1/2] raw: add license header

Most of the block layer is under the BSD license, thus it is reasonable to license block/raw.c the same way. CCed people should ACK by replying with a Signed-off-by line. Cc: Christoph Hellwig Cc: Kevin Wolf Cc: Anthony Liguori Cc: Markus Armbruster Cc: Stefan Hajnoczi Cc: Luiz Capitulino C

[Qemu-devel] [PATCH 0/2] Clarify licensing terms

Here is a list of license-less files: audio/audio_pt_int.c audio/audio_win_int.c audio/paaudio.c audio/wavcapture.c audio/winwaveaudio.c block/raw.c bsd-user/bsdload.c bsd-user/elfload.c bsd-user/strace.c bsd-user/uaccess.c

Re: [Qemu-devel] Licensing question

Stefan Weil wrote: > No, there is no such statement. > > There is an agreement that files with GPL should be GPLv2+ > (not only GPLv2), but files may also use other free licenses. > > In file LICENSE, it is said that QEMU as a whole is released > under the GNU General Public License. > > Some f

Re: [Qemu-devel] Licensing question

Am 31.07.2013 03:50, schrieb Erik de Castro Lopo: > Hi all, > > I have a patch I would like to submit and I am currently running it past > my employer's legal department. The legal department has identified 10 > different licenses in the Qemu codebase and has asked about the two files > I am modify

[Qemu-devel] Licensing question

Hi all, I have a patch I would like to submit and I am currently running it past my employer's legal department. The legal department has identified 10 different licenses in the Qemu codebase and has asked about the two files I am modifying: linux-user/syscall.c linux-user/syscall_defs.h

[Qemu-devel] [PATCH for 1.6] hw/core: Fix wrong left shift (build regression)

Shifting a long int (32 bit) by 40 bit positions won't work. Compiler message: hw/core/qdev-properties.c: In function ‘print_size’: hw/core/qdev-properties.c:1180:5: warning: left shift count >= width of type Signed-off-by: Stefan Weil --- hw/core/qdev-properties.c |2 +- 1 file changed, 1

Re: [Qemu-devel] [PATCH V8 09/13] monitor: support sub command in help

于 2013-7-30 22:51, Luiz Capitulino 写道: On Fri, 26 Jul 2013 11:20:38 +0800 Wenchao Xia wrote: The old code in help_cmd() uses global 'info_cmds' and treats it as a special case. Actually 'info_cmds' is a sub command group of 'mon_cmds', in order to avoid direct use of it, help_cmd() needs to ch

Re: [Qemu-devel] [PATCH V8 00/13] monitor: support sub command group in auto completion and help

于 2013-7-31 0:03, Luiz Capitulino 写道: On Fri, 26 Jul 2013 11:20:29 +0800 Wenchao Xia wrote: This series make auto completion and help functions works normal for sub command, by using reentrant functions. In order to do that, global variables are not directly used in those functions any more. W

Re: [Qemu-devel] [PATCH V6 02/11] NUMA: split -numa option

On 07/30/2013 07:14 PM, Laszlo Ersek wrote: > On 07/30/13 09:32, Wanlong Gao wrote: > >> +static int numa_node_parse(NumaNodeOptions *opts) >> +{ >> +uint16_t nodenr; >> +UInt16List *cpus = NULL; >> + >> +if (opts->has_nodeid) { >> +nodenr = opts->nodeid; >> +if (nodenr

[Qemu-devel] [PULL for-1.6] Update OpenBIOS images to r1198

Hi Anthony, The following changes since commit beb3faaa0027c114e37317fdba38a8a7facf3f9b: target-mips: correct the values in the DSP tests (2013-07-30 17:48:24 +0200) are available in the git repository at: https://github.com/mcayland/qemu.git qemu-openbios for you to fetch changes up to

Re: [Qemu-devel] [PATCH v8 07/10] qemu-ga: Add Windows VSS provider and requester as DLL

On 7/30/13 18:24 , "Michael Roth" wrote: >Quoting Tomoki Sekiyama (2013-07-30 15:54:05) >>On 7/30/13 15:35 , "Michael Roth" wrote: >One small issue I noticed was that this error will get overwritten >with the VSS writer timeout error if we wait longer than 60s before >calling guest-f

Re: [Qemu-devel] [PATCH v8 07/10] qemu-ga: Add Windows VSS provider and requester as DLL

Quoting Tomoki Sekiyama (2013-07-30 15:54:05) > On 7/30/13 15:35 , "Michael Roth" wrote: > > >>>One small issue I noticed was that this error will get overwritten > >>>with the VSS writer timeout error if we wait longer than 60s before > >>>calling guest-fsfreeze-thaw. It might give some users fa

Re: [Qemu-devel] [PATCH 6/6] pc: limit 64 bit hole to 2G by default

Quoting Andreas Färber (2013-07-28 05:17:47) > Am 28.07.2013 11:11, schrieb Michael S. Tsirkin: > > On Sun, Jul 28, 2013 at 10:21:56AM +0200, Igor Mammedov wrote: > >> On Sun, 28 Jul 2013 10:57:12 +0300 > >> "Michael S. Tsirkin" wrote: > >> > >>> On Sun, Jul 28, 2013 at 09:29:13AM +0200, Igor Mamm

Re: [Qemu-devel] [PATCH v8 07/10] qemu-ga: Add Windows VSS provider and requester as DLL

On 7/30/13 15:35 , "Michael Roth" wrote: >>>One small issue I noticed was that this error will get overwritten >>>with the VSS writer timeout error if we wait longer than 60s before >>>calling guest-fsfreeze-thaw. It might give some users false assurances >>>about what aspects of their snapshot m

Re: [Qemu-devel] [PATCH v8 10/10] QMP/qemu-ga-client: Make timeout longer for guest-fsfreeze-freeze command

Quoting Tomoki Sekiyama (2013-07-23 17:46:06) > guest-fsfreeze-freeze command can take longer than 3 seconds when heavy > disk I/O is running. To avoid unexpected timeout, this changes the timeout > to 60 seconds (timeout of pre-commit phase of VSS). > > Signed-off-by: Tomoki Sekiyama > Reviewed-

[Qemu-devel] [PATCH for 1.6] tci: Fix broken build (compiler warning caused by redefined macro BIT)

The definition of macro BIT in tci/tcg-target.c now conflicts with the definition of the same macro in includes qemu/bitops.h. This conflict was triggered by a recent change in the include chain of tcg.c (probably commit 949fc82314cc84162e64a5323764527a542421ce). Signed-off-by: Stefan Weil ---

Re: [Qemu-devel] [PATCH v8 09/10] qemu-ga: Install Windows VSS provider on `qemu-ga -s install'

Quoting Tomoki Sekiyama (2013-07-23 17:46:03) > Register QGA VSS provider library into Windows when qemu-ga is installed as > Windows service ('-s install' option). It is deregistered when the service > is uninstalled ('-s uninstall' option). > > Signed-off-by: Tomoki Sekiyama Reviewed-by: Micha

Re: [Qemu-devel] [PATCH v8 08/10] qemu-ga: Call Windows VSS requester in fsfreeze command handler

Quoting Tomoki Sekiyama (2013-07-23 17:45:58) > Support guest-fsfreeze-freeze and guest-fsfreeze-thaw commands for Windows > guests. When fsfreeze command is issued, it calls the VSS requester to > freeze filesystems and applications. On thaw command, it again tells the VSS > requester to thaw them

Re: [Qemu-devel] [PATCH 0/4] dump-guest-memory: correct the vmcores

On Mon, 29 Jul 2013 16:37:12 +0200 Laszlo Ersek wrote: > (Apologies for the long To: list, I'm including everyone who > participated in > ). > > Conceptually, the dump-guest-memory command works as follows: > (a) pause the gues

Re: [Qemu-devel] [PATCH 2/2] i82378: cleanup implementation

Andreas Färber a écrit : Hi, Am 23.07.2013 23:16, schrieb Hervé Poussineau: - i82378 only exists on PCI bus ; do not split implementation in 2 structures - remove BARs, which are not specified in datasheet - replace custom isa_mmio implementation by PCI bus IO region usage - use QOM casts when

Re: [Qemu-devel] [PATCH v8 07/10] qemu-ga: Add Windows VSS provider and requester as DLL

Quoting Tomoki Sekiyama (2013-07-29 13:32:20) > Hi Michael, > Thank you for the review. > > >>- if [ "$linux" = "yes" -o "$bsd" = "yes" -o "$solaris" = "yes" ] ; then > >>+ if [ "$linux" = "yes" -o "$bsd" = "yes" -o "$solaris" = "yes" -o > >>"$mingw32" = "yes" ] ; then > >> if [ "$guest_age

Re: [Qemu-devel] [PATCH v3] vl.c: Output error on invalid machine type provided

On 07/30/2013 01:10 PM, Michal Novotny wrote: > Output error message when user provides the invalid machine type > on the command line. This also saves time to find what issue is > when you upgrade from one version of qemu to another version that > doesn't support required machine type any longer.

Re: [Qemu-devel] [PATCH v2] vl.c: Output error on invalid machine type provided

Hi Markus, thanks, v3 sent. Michal On 07/30/2013 09:05 PM, Markus Armbruster wrote: > Michal Novotny writes: > >> Hi Markus, >> should I rebase it or no need and can maintainer do it before push? > Depends on the maintainer :) > > I'd respin. > -- Michal Novotny , RHCE, Red Hat Virtualization

[Qemu-devel] [PATCH v3] vl.c: Output error on invalid machine type provided

Output error message when user provides the invalid machine type on the command line. This also saves time to find what issue is when you upgrade from one version of qemu to another version that doesn't support required machine type any longer. Signed-off-by: Michal Novotny --- The patch is chec

[Qemu-devel] [PATCH v2 1/2] qdev: Fix 32-bit compilation in print_size

Signed-off-by: Richard Henderson --- hw/core/qdev-properties.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index 8d43a8d..d6d10c9 100644 --- a/hw/core/qdev-properties.c +++ b/hw/core/qdev-properties.c @@ -1177,7 +1177,7

Re: [Qemu-devel] [PATCH v2] vl.c: Output error on invalid machine type provided

Michal Novotny writes: > Hi Markus, > should I rebase it or no need and can maintainer do it before push? Depends on the maintainer :) I'd respin.

[Qemu-devel] [PATCH v2 0/2] Fix qdev 32-bit compilation

The patch e8cd45c78f53501e75bd455140da63d1b7ed3685 broke compilation on 32-bit with a 40-bit shift of "long int". The first patch is the trivial fix for that bug. The second patch is an optional improvement that avoids the division loop entirely. r~ -- V2: Fixing erroneous email from mis-confi

[Qemu-devel] [PATCH v2 2/2] qdev: Use clz in print_size

We can compute a floor log2 value with clz rather than a division loop. Signed-off-by: Richard Henderson --- hw/core/qdev-properties.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index d6d10c9..dc

Re: [Qemu-devel] [RFC qom-cpu for-next 2/2] cpu: Replace qemu_for_each_cpu()

On Tue, Jul 30, 2013 at 06:55:59PM +0200, Andreas Färber wrote: > It was introduced to loop over CPUs from target-independent code, but > since commit 182735efaf956ccab50b6d74a4fed163e0f35660 target-independent > CPUState is used. > > A loop can be considered more efficient than function calls in

[Qemu-devel] [PATCH 4/4] hw/cpu/a15mpcore: Wire generic timer outputs to GIC inputs

Now our A15 CPU implements the generic timers, we can wire them up to the appropriate inputs on the GIC. Signed-off-by: Peter Maydell --- hw/cpu/a15mpcore.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/hw/cpu/a15mpcore.c b/hw/cpu/a15mpcore.c index c736257..8c23020 10

[Qemu-devel] [PATCH 1/2] qdev: Fix 32-bit compilation in print_size

From: Richard Henderson Signed-off-by: Richard Henderson --- hw/core/qdev-properties.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index 8d43a8d..d6d10c9 100644 --- a/hw/core/qdev-properties.c +++ b/hw/core/qdev-prope

[Qemu-devel] [PATCH 2/2] qdev: Use clz in print_size

From: Richard Henderson We can compute a floor log2 value with clz rather than a division loop. Signed-off-by: Richard Henderson --- hw/core/qdev-properties.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-prop

[Qemu-devel] [PATCH 0/2] Fix qdev 32-bit compilation

From: Richard Henderson The patch e8cd45c78f53501e75bd455140da63d1b7ed3685 broke compilation on 32-bit with a 40-bit shift of "long int". The first patch is the trivial fix for that bug. The second patch is an optional improvement that avoids the division loop entirely. r~ Richard Henderson

[Qemu-devel] [PATCH 3/4] target-arm: Implement the generic timer

The ARMv7 architecture specifies a 'generic timer' which is implemented via cp15 registers. Newer kernels will prefer to use this rather than a devboard-level timer. Implement the generic timer for TCG; for KVM we will already use the hardware's virtualized timer for this. Signed-off-by: Peter May

[Qemu-devel] [PATCH 0/4] target-arm: Implement support for generic timers

This patch series implements support for the 'generic timers', which are a set of timers defined in the ARM Architecture Reference Manual and implemented by the Cortex-A15. We've got away without these up til now because Linux will generally fall back on whatever random timer is present on the devb

[Qemu-devel] [PATCH 1/4] target-arm: Allow raw_read() and raw_write() to handle 64 bit regs

Extend the raw_read() and raw_write() helper accessors so that they can be used for 64 bit registers as well as 32 bit registers. Signed-off-by: Peter Maydell --- target-arm/helper.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/target-arm/helper.c b/target-

[Qemu-devel] [PATCH 2/4] target-arm: Support coprocessor registers which do I/O

Add an ARM_CP_IO flag which an ARMCPRegInfo definition can use to indicate that the register's implementation does I/O and thus its accesses need to be surrounded by gen_io_start()/gen_io_end() in order for icount to work. Most notably, cp registers which implement clocks or timers need this. Sign

[Qemu-devel] [PATCH v2 for-1.6] chardev: fix CHR_EVENT_OPENED events for mux chardevs

As of bd5c51ee6c4f1c79cae5ad2516d711a27b4ea8ec, chardevs no longer use bottom-halves to issue CHR_EVENT_OPENED events. To maintain past semantics, we instead defer the CHR_EVENT_OPENED events toward the end of chardev initialization. For muxes, this isn't good enough, since a range of FEs must be

Re: [Qemu-devel] [PATCH 18/18] blockdev: 'blockdev-add' QMP command

On Fri, 26 Jul 2013 20:14:06 +0200 Kevin Wolf wrote: > Am 26.07.2013 um 19:45 hat Eric Blake geschrieben: > > Overall, I like where this is headed, but I'm not quite sure it is ready > > for commit as-is; looking forward to v2. Given my positive review on > > the rest of the series, I think you

Re: [Qemu-devel] usb: a problem of using libusb for usb pass through

Hi, On 07/30/2013 07:13 PM, Hans de Goede wrote: Hi, On 07/22/2013 02:58 PM, Gerd Hoffmann wrote: On 07/16/13 10:45, Gonglei (Arei) wrote: Hi, Gerd My Qemu version is 1.5.1, and use libusb for usb pass through. I pass through a host usb device to the guest by bus number and physical

Re: [Qemu-devel] usb: a problem of using libusb for usb pass through

Hi, On 07/22/2013 02:58 PM, Gerd Hoffmann wrote: On 07/16/13 10:45, Gonglei (Arei) wrote: Hi, Gerd My Qemu version is 1.5.1, and use libusb for usb pass through. I pass through a host usb device to the guest by bus number and physical port, when I unplug the usb device from the

[Qemu-devel] [PATCH qom-cpu for-next 1/2] cpu: Use QTAILQ for CPU list

Introduce CPU_FOREACH(), CPU_FOREACH_SAFE() and CPU_NEXT() shorthand macros. Signed-off-by: Andreas Färber --- cpus.c| 47 --- cputlb.c | 2 +- dump.c| 10 +- exec.c|

[Qemu-devel] [RFC qom-cpu for-next 2/2] cpu: Replace qemu_for_each_cpu()

It was introduced to loop over CPUs from target-independent code, but since commit 182735efaf956ccab50b6d74a4fed163e0f35660 target-independent CPUState is used. A loop can be considered more efficient than function calls in a loop, and CPU_FOREACH() hides implementation details just as well, so us

[Qemu-devel] [PATCH qom-cpu for-next 0/2] QOM CPUState, part 12: CPU loops, revisited

Hello everyone, A short CPUState series for a change: This mini-series replaces our home-grown CPU list (first_cpu global and CPUState::next_cpu) with a QTAILQ. To avoid repeated QTAILQ_FOREACH(foo, cpus, node) I am proposing a wrapper CPU_FOREACH(foo) to hide the implementation details, as reque

Re: [Qemu-devel] [PATCH V9 0/2] Implement sync modes for drive-backup.

On Mon, Jul 29, 2013 at 11:54:38AM +0100, Richard W.M. Jones wrote: > On Mon, Jul 29, 2013 at 06:16:48PM +0800, Fam Zheng wrote: > > Ian's patches are in master, on which I already rebased the first. I can > > rebase the other one for you if you feel like to test it too. > > No that's fine, thanks

Re: [Qemu-devel] [PATCH V8 00/13] monitor: support sub command group in auto completion and help

On Fri, 26 Jul 2013 11:20:29 +0800 Wenchao Xia wrote: > This series make auto completion and help functions works normal for sub > command, by using reentrant functions. In order to do that, global variables > are not directly used in those functions any more. With this series, cmd_table > is a m

Re: [Qemu-devel] [PATCH v3 14/19] docs, qapi: document qemu-img map

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 30/07/2013 17:48, Eric Blake ha scritto: > In case of a hybrid file (part raw, part encrypted), does this > command exit on first error, or only after printing as much raw > information was available? On first error. The reason is that usually eve

Re: [Qemu-devel] [PATCH] target-mips: correct the values in the DSP tests

On Mon, Jul 29, 2013 at 12:49:05PM +0200, Petar Jovanovic wrote: > From: Petar Jovanovic > > Five tests files for DSP instructions had wrong expected values in the tests. > This change fixes this, and this has been cross-checked by running the same > test binaries on Malta 74K board. > > Signed-

Re: [Qemu-devel] [PATCH v3 14/19] docs, qapi: document qemu-img map

On 07/25/2013 08:23 AM, Paolo Bonzini wrote: > Eric Blake also requested including the output in qapi-schema.json, > so that it is published through the introspection mechanism. > > Signed-off-by: Paolo Bonzini > --- > qapi-schema.json | 29 + > qemu-img.texi| 46

Re: [Qemu-devel] [PATCH v3 13/19] qemu-img: add a "map" subcommand

Am 30.07.2013 um 17:22 hat Paolo Bonzini geschrieben: > Il 30/07/2013 17:13, Kevin Wolf ha scritto: > > Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben: > >> This command dumps the metadata of an entire chain, in either tabular or > >> JSON > >> format. > >> > >> Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [PATCH v2] vl.c: Output error on invalid machine type provided

Hi Markus, should I rebase it or no need and can maintainer do it before push? Michal On 07/30/2013 05:17 PM, Markus Armbruster wrote: > Michal Novotny writes: > >> Output error message when user provides the invalid machine type >> on the command line. This also saves time to find what issue is

Re: [Qemu-devel] [PATCH] rdma: bugfix: make IPv6 support work

On 07/30/2013 05:57 PM, Michael R. Hines wrote: > On 07/30/2013 04:14 AM, Orit Wasserman wrote: >> On 07/27/2013 05:23 AM, mrhi...@linux.vnet.ibm.com wrote: >>> From: "Michael R. Hines" >>> >>> When testing with libvirt, a simple IPv6 migration test failed >>> because we were not using getaddrinfo

Re: [Qemu-devel] [PATCH v3 0/6] Clean up bogus default boot order

Any chance for this to make 1.6? It first hit the list mid-June...

Re: [Qemu-devel] [PATCH v3 12/19] block: return get_block_status data and flags for formats

Am 30.07.2013 um 17:15 hat Paolo Bonzini geschrieben: > Il 30/07/2013 16:40, Kevin Wolf ha scritto: > > Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben: > >> Reviewed-by: Eric Blake > >> Signed-off-by: Paolo Bonzini > >> --- > >> block/cow.c | 8 +++- > >> block/qcow.c | 9 ++

Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables

Anthony Liguori writes: > On Tue, Jul 30, 2013 at 1:39 AM, Markus Armbruster wrote: >> Anthony Liguori writes: >> >>> This was part of the discussion way back when this all was first >>> introduced. Since everything was open coded and we had to preserve >>> the semantics, that was the only cho

[Qemu-devel] [PATCH v2 2/3] rdma: forgot to turn off the debugging flag

From: "Michael R. Hines" Ooops. We forgot to turn off the flag. Signed-off-by: Michael R. Hines --- migration-rdma.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration-rdma.c b/migration-rdma.c index 9cf73e3..fe6118d 100644 --- a/migration-rdma.c +++ b/migration-r

Re: [Qemu-devel] [PATCH v3 13/19] qemu-img: add a "map" subcommand

Il 30/07/2013 17:13, Kevin Wolf ha scritto: > Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben: >> This command dumps the metadata of an entire chain, in either tabular or JSON >> format. >> >> Signed-off-by: Paolo Bonzini > > Hm, we have a 'map' command in qemu-io, which isn't exactly the sa

[Qemu-devel] [PATCH v2 1/3] rdma: bugfix: make IPv6 support work

From: "Michael R. Hines" RDMA does not use sockets, so we cannot use many of the socket helper functions, but we *do* use inet_parse() which gives RDMA all the necessary details of the connection parameters. However, when testing with libvirt, a simple IPv6 migration test failed because we were

[Qemu-devel] [PATCH v2 3/3] rdma: correct newlines in error statements

From: "Michael R. Hines" Don't print newlines on the error_setg() function, but still allow newlines on fprintf(). Signed-off-by: Michael R. Hines --- migration-rdma.c | 68 +++--- 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a

[Qemu-devel] [PATCH v2 0/3] rdma: IPv6 bugfixes and cleanups

From: "Michael R. Hines" Changes: 1. IPv6 support was broken under libvirt. 2. incorrect use of error_setg() 3. DPRINTF flag was not disabled Michael R. Hines (3): rdma: bugfix: make IPv6 support work rdma: forgot to turn off the debugging flag rdma: correct newlines in error statements

Re: [Qemu-devel] [PATCH v2] vl.c: Output error on invalid machine type provided

Michal Novotny writes: > Output error message when user provides the invalid machine type > on the command line. This also saves time to find what issue is > when you upgrade from one version of qemu to another version that > doesn't support required machine type any longer. Text from here > >

Re: [Qemu-devel] [PATCH v3 12/19] block: return get_block_status data and flags for formats

Il 30/07/2013 16:40, Kevin Wolf ha scritto: > Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben: >> Reviewed-by: Eric Blake >> Signed-off-by: Paolo Bonzini >> --- >> block/cow.c | 8 +++- >> block/qcow.c | 9 - >> block/qcow2.c| 16 ++-- >> block/qed.c

Re: [Qemu-devel] [PATCH v3 13/19] qemu-img: add a "map" subcommand

Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben: > This command dumps the metadata of an entire chain, in either tabular or JSON > format. > > Signed-off-by: Paolo Bonzini Hm, we have a 'map' command in qemu-io, which isn't exactly the same, but then not much different either. Depending on

Re: [Qemu-devel] [PATCH v2 3/7] block: implement reference count for BlockDriverState

On Tue, Jul 30, 2013 at 03:52:53PM +0800, Fam Zheng wrote: > @@ -1518,6 +1519,9 @@ static void bdrv_move_feature_fields(BlockDriverState > *bs_dest, > /* dirty bitmap */ > bs_dest->dirty_bitmap = bs_src->dirty_bitmap; > > +/* reference count */ > +bs_dest->refcnt

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices

Am 30.07.2013 16:50, schrieb Igor Mammedov: > On Tue, 30 Jul 2013 10:27:26 -0400 > "Jason J. Herne" wrote: >> On 07/30/2013 03:24 AM, Igor Mammedov wrote: >> Is there an easier way of getting the count besides this? >> >> int cpu_count = 0; >> for (cpu = first_cpu; cpu != NULL; cpu = cpu->next_cpu

Re: [Qemu-devel] [PATCH] rdma: bugfix: make IPv6 support work

On 07/30/2013 04:14 AM, Orit Wasserman wrote: On 07/27/2013 05:23 AM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" When testing with libvirt, a simple IPv6 migration test failed because we were not using getaddrinfo() properly. This makes IPv6 migration over RDMA work. Also, we

Re: [Qemu-devel] [PATCH] vl.c: Output error on invalid machine type provided

On 07/30/2013 04:46 PM, Peter Maydell wrote: > On 30 July 2013 15:28, Michal Novotny wrote: >> Output error message when user provides the invalid machine type >> on the command line. This also saves time to find what issue is >> when you upgrade from one version of qemu to another version that >

[Qemu-devel] [PATCH v2] vl.c: Output error on invalid machine type provided

Output error message when user provides the invalid machine type on the command line. This also saves time to find what issue is when you upgrade from one version of qemu to another version that doesn't support required machine type any longer. The patch is checked using ./scripts/checkpatch.pl sc

Re: [Qemu-devel] [PATCH V8 09/13] monitor: support sub command in help

On Fri, 26 Jul 2013 11:20:38 +0800 Wenchao Xia wrote: > The old code in help_cmd() uses global 'info_cmds' and treats it as a > special case. Actually 'info_cmds' is a sub command group of 'mon_cmds', > in order to avoid direct use of it, help_cmd() needs to change its work > mechanism to support

Re: [Qemu-devel] [PATCH v2 3/7] block: implement reference count for BlockDriverState

On Tue, Jul 30, 2013 at 03:52:53PM +0800, Fam Zheng wrote: > Introduce bdrv_ref/bdrv_unref to manage the lifecycle of > BlockDriverState. They are unused for now but will used to replace > bdrv_delete() later. > > Signed-off-by: Fam Zheng > --- > block.c | 22 ++

Re: [Qemu-devel] [PATCH v2 3/7] block: implement reference count for BlockDriverState

On Tue, Jul 30, 2013 at 02:16:08PM +0200, Andreas Färber wrote: > Am 30.07.2013 09:52, schrieb Fam Zheng: > > Introduce bdrv_ref/bdrv_unref to manage the lifecycle of > > BlockDriverState. They are unused for now but will used to replace > > bdrv_delete() later. > > > > Signed-off-by: Fam Zheng >

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices

On Tue, 30 Jul 2013 10:27:26 -0400 "Jason J. Herne" wrote: > On 07/30/2013 03:24 AM, Igor Mammedov wrote: > > On Mon, 29 Jul 2013 15:41:57 -0400 > > "Jason J. Herne" wrote: > > > >> On 06/08/2013 09:11 PM, Andreas Färber wrote: > if (tcg_enabled() && !inited) { > > inited =

Re: [Qemu-devel] [PATCH] vl.c: Output error on invalid machine type provided

On 30 July 2013 15:28, Michal Novotny wrote: > Output error message when user provides the invalid machine type > on the command line. This also saves time to find what issue is > when you upgrade from one version of qemu to another version that > doesn't support required machine type any longer.

Re: [Qemu-devel] [PATCH for-1.6] block: Disable driver-specific options for 1.6

On Tue, Jul 30, 2013 at 02:58:27PM +0200, Kevin Wolf wrote: > We don't want to commit to the API yet before everything is worked out. > Like already for 1.5, disable it again for the 1.6 release. This commit > is meant to be reverted after the 1.6 release. > > The disabling of the driver-specific

Re: [Qemu-devel] [PATCH v3 12/19] block: return get_block_status data and flags for formats

Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben: > Reviewed-by: Eric Blake > Signed-off-by: Paolo Bonzini > --- > block/cow.c | 8 +++- > block/qcow.c | 9 - > block/qcow2.c| 16 ++-- > block/qed.c | 35 --- > block

Re: [Qemu-devel] [PATCH v3 11/19] block: define get_block_status return value

Am 30.07.2013 um 16:19 hat Paolo Bonzini geschrieben: > Il 30/07/2013 16:14, Kevin Wolf ha scritto: > > Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben: > >> Define the return value of get_block_status. Bits 0, 1, 2 and 9-62 > >> are valid; bit 63 (the sign bit) is reserved for errors. Bits

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices

On 07/30/2013 03:24 AM, Igor Mammedov wrote: On Mon, 29 Jul 2013 15:41:57 -0400 "Jason J. Herne" wrote: On 06/08/2013 09:11 PM, Andreas Färber wrote: if (tcg_enabled() && !inited) { inited = true; s390x_translate_init(); } + +smp_cpus += 1; Won't we need som

[Qemu-devel] [PATCH 5/8] s390x/ioinst: Fixed priority of operand exceptions

From: Thomas Huth Operand exceptions have a lower priority than specification and address exceptions. Thus the checks for operand exceptions must be done later. Signed-off-by: Thomas Huth Acked-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- target-s390x/ioinst.c | 30

[Qemu-devel] [PATCH] vl.c: Output error on invalid machine type provided

Output error message when user provides the invalid machine type on the command line. This also saves time to find what issue is when you upgrade from one version of qemu to another version that doesn't support required machine type any longer. Michal Signed-off-by: Michal Novotny --- vl.c | 4

[Qemu-devel] [PATCH 2/8] s390x/ioinst: Add missing alignment checks for IO instructions

From: Thomas Huth The IO instructions MSCH, SSCH, STSCH, TSCH, STCRW and TPI require that the second operand address must be aligned on a word boundary. Signed-off-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- target-s390x/ioinst.c | 25 +

[Qemu-devel] [PATCH 4/8] s390x/ioinst: Fixed alignment check in SCHM instruction

From: Thomas Huth Register 2 only has to be aligned to a 32-byte boundary, not a full page boundary. Signed-off-by: Thomas Huth Acked-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- target-s390x/ioinst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-s3

[Qemu-devel] [PATCH 8/8] s390: Implement dump-guest-memory support for target s390x

From: Ekaterina Tumanova With this patch dump-guest-memory on s390 produces an ELF formatted, crash-readable dump. In order to implement this, the arch-specific part of dump-guest-memory was added: target-s390x/arch_dump.c contains the whole set of function for writing Elf note sections of all ty

[Qemu-devel] [PULLv2 0/8] s390 patch queue

Anthony, V2 of the s390 patch queue, now on top of master with the following changes since commit dbe49aea76a7805f05b33d548b2e543b51fa8bb1: Update version for 1.6.0-rc0 (2013-07-29 20:30:29 -0500) are available in the git repository at: git://github.com/borntraeger/qemu.git s390-for-1.6

[Qemu-devel] [PATCH 7/8] s390x/kvm: Remove redundant return code

From: Thomas Huth Removed the redundant return code statement from handle_instruction() - it always returned 0 and never reports any errors to its caller, since errors from the sub-functions are already reported via program exceptions instead. Signed-off-by: Thomas Huth Signed-off-by: Christian

[Qemu-devel] [PATCH 3/8] s390x/ioinst: Throw addressing exception when memory_map failed

From: Thomas Huth So far, the IO instructions were throwing specification exceptions when there was a problem with accessing the memory. However, the better way is to throw an addressing exception instead. Signed-off-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Christian Borntraeg

  1   2   >