Re: [Qemu-devel] [PATCH] rdma: bugfix: make IPv6 support work

2013-07-26 Thread Michael R. Hines
On 07/26/2013 10:30 PM, Andreas Färber wrote: Am 27.07.2013 04:23, schrieb mrhi...@linux.vnet.ibm.com: From: "Michael R. Hines" When testing with libvirt, a simple IPv6 migration test failed because we were not using getaddrinfo() properly. This makes IPv6 migration over RDMA work. Also, we f

Re: [Qemu-devel] [PATCH] rdma: bugfix: make IPv6 support work

2013-07-26 Thread Andreas Färber
Am 27.07.2013 04:23, schrieb mrhi...@linux.vnet.ibm.com: > From: "Michael R. Hines" > > When testing with libvirt, a simple IPv6 migration test failed > because we were not using getaddrinfo() properly. > This makes IPv6 migration over RDMA work. > > Also, we forgot to turn the DPRINTF flag off

[Qemu-devel] [PATCH] rdma: bugfix: make IPv6 support work

2013-07-26 Thread mrhines
From: "Michael R. Hines" When testing with libvirt, a simple IPv6 migration test failed because we were not using getaddrinfo() properly. This makes IPv6 migration over RDMA work. Also, we forgot to turn the DPRINTF flag off =). Signed-off-by: Michael R. Hines --- migration-rdma.c | 35

Re: [Qemu-devel] [PATCH qom-next for-1.6 v2] fdc: Fix inheritence for SUNW, fdtwo

2013-07-26 Thread Andreas Färber
Am 27.07.2013 03:50, schrieb Andreas Färber: > Since commit dd3be7420774f7dc8f37a96ca24d07f0b6f31b3b SUNW,fdtwo's > initfn (realizefn since 940194c2369e50d91d1abf6f36d43853eea5e539) > was using SYSBUS_FDC() cast. This uses type sysbus-fdc rather than > SUNW,fdtwo. > > Fix this by letting SUNW,fdtw

[Qemu-devel] [PATCH qom-cpu for-1.6] cpu: Partially revert "cpu: Change qemu_init_vcpu() argument to CPUState"

2013-07-26 Thread Andreas Färber
Commit c643bed99 moved qemu_init_vcpu() calls to common CPUState code. This causes x86 cpu-add to fail with "KVM: setting VAPIC address failed". The reason for the failure is that CPUClass::kvm_fd is not yet initialized in the following call graph: ->x86_cpu_realizefn ->x86_cpu_apic_realize ->q

[Qemu-devel] [PATCH qom-next for-1.6 v2] fdc: Fix inheritence for SUNW, fdtwo

2013-07-26 Thread Andreas Färber
Since commit dd3be7420774f7dc8f37a96ca24d07f0b6f31b3b SUNW,fdtwo's initfn (realizefn since 940194c2369e50d91d1abf6f36d43853eea5e539) was using SYSBUS_FDC() cast. This uses type sysbus-fdc rather than SUNW,fdtwo. Fix this by letting SUNW,fdtwo and sysbus-fdc both inherit from an abstract type base-

Re: [Qemu-devel] [PATCH v8 07/10] qemu-ga: Add Windows VSS provider and requester as DLL

2013-07-26 Thread Michael Roth
Quoting Tomoki Sekiyama (2013-07-23 17:45:54) > Adds VSS provider and requester as a qga-vss.dll, which is loaded by > Windows VSS service as well as by qemu-ga. > > "provider.cpp" implements a basic stub of a software VSS provider. > Currently, this module only relays a frozen event from VSS serv

Re: [Qemu-devel] [PATCH qom-next v2 1/4] pci-bridge: Turn PCIBridge into abstract QOM type

2013-07-26 Thread Andreas Färber
Am 23.07.2013 00:36, schrieb Andreas Färber: > Introduce TYPE_PCI_BRIDGE as base type and use PCI_BRIDGE() casts. > > Signed-off-by: Andreas Färber > --- > hw/pci-bridge/dec.c| 4 ++-- > hw/pci-bridge/i82801b11.c | 6 +++--- > hw/pci-bridge/ioh3420.c| 18 ++

[Qemu-devel] [PULL 16/25] target-microblaze: Move cpu_gdb_{read, write}_register()

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c | 29 +-- target-microblaze/gdbstub.c | 49 + 2 files changed, 50 insertions(+), 28 deletions(-) create mode 100644 target-microblaze/gdbstub.c diff --git a/gdbstub.

[Qemu-devel] [PULL 15/25] target-sh4: Move cpu_gdb_{read, write}_register()

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c| 117 +-- target-sh4/gdbstub.c | 137 +++ 2 files changed, 138 insertions(+), 116 deletions(-) create mode 100644 target-sh4/gdbstub.c diff --git a/gdb

[Qemu-devel] [PULL 06/25] gdbstub: Drop dead code in cpu_gdb_{read, write}_register()

2013-07-26 Thread Andreas Färber
GET_REG*() macros include a return statement, thus no need for break. Acked-by: Michael Walle (for lm32) Signed-off-by: Andreas Färber --- gdbstub.c | 25 - 1 file changed, 25 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index cd25c06..9ede3de 100644 --- a/gdbstub.c

Re: [Qemu-devel] [PATCH] target-or32: fix masking in openrisc_pic_cpu_handler()

2013-07-26 Thread Paolo Bonzini
Il 22/01/2013 16:57, Xi Wang ha scritto: > A correct mask should be `x & (1 << i)', rather than `x && (1 << i)'. > > Also, in C99 signed shift (1 << 31) is undefined behavior, since the > result exceeds INT_MAX; use 1U instead. > > Signed-off-by: Xi Wang > --- > hw/openrisc_pic.c |8 +--

Re: [Qemu-devel] [PATCH qom-next for-1.6 0/4] audio: QOM cast cleanups

2013-07-26 Thread Andreas Färber
Am 24.07.2013 10:35, schrieb Andreas Färber: > Andreas Färber (4): > cs4231: QOM'ify > audio/marvell_88w8618: QOM'ify > milkymist-ac97: QOM'ify > pl041: QOM'ify Thanks, applied to qom-next: https://github.com/afaerber/qemu-cpu/commits/qom-next Andreas -- SUSE LINUX Products GmbH, Maxfel

Re: [Qemu-devel] [PATCH qom-next for-1.6] onenand: QOM'ify

2013-07-26 Thread Andreas Färber
Am 26.07.2013 10:54, schrieb Hu Tao: > On Wed, Jul 24, 2013 at 10:46:31AM +0200, Andreas Färber wrote: >> Signed-off-by: Andreas Färber >> --- >> hw/block/onenand.c | 30 -- >> 1 file changed, 20 insertions(+), 10 deletions(-) > > Reviewed-by: Hu Tao Thanks, applied

[Qemu-devel] [PULL 00/25] QOM CPUState patch queue 2013-07-26

2013-07-26 Thread Andreas Färber
Hello Anthony, This is my current QOM CPU patch queue for 1.6. Please pull. CPUArchState: 289 -> 279 Thanks, Andreas Cc: Anthony Liguori Cc: Richard Henderson Cc: Jia Liu Cc: Max Filippov Cc: Eduardo Habkost Cc: Igor Mammedov Cc: Mike Frysinger The following changes since commit f0ef1

[Qemu-devel] [PULL 07/25] cpu: Introduce CPUState::gdb_num_regs and CPUClass::gdb_num_core_regs

2013-07-26 Thread Andreas Färber
CPUState::gdb_num_regs replaces num_g_regs. CPUClass::gdb_num_core_regs replaces NUM_CORE_REGS. Allows building gdb_register_coprocessor() for xtensa, too. As a side effect this should fix coprocessor register numbering for SMP. Acked-by: Michael Walle (for lm32) Acked-by: Max Filippov (for xt

[Qemu-devel] [PULL 17/25] target-cris: Move cpu_gdb_{read, write}_register()

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c | 105 +- target-cris/gdbstub.c | 125 ++ 2 files changed, 126 insertions(+), 104 deletions(-) create mode 100644 target-cris/gdbstub.c diff --git a/gd

[Qemu-devel] [PULL 03/25] target-s390x: Fix CPUState rework fallout

2013-07-26 Thread Andreas Färber
From: Christian Borntraeger Commit f17ec444c3d39f76bcd8b71c2c05d5754bfe333e exec: Change cpu_memory_rw_debug() argument to CPUState missed to update s390x KVM code, breaking the build. Let's fix it up. Signed-off-by: Christian Borntraeger Signed-off-by: Andreas Färber --- target-s390x/kvm.c

[Qemu-devel] [PULL 11/25] target-arm: Move cpu_gdb_{read, write}_register()

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c| 74 + target-arm/gdbstub.c | 94 2 files changed, 95 insertions(+), 73 deletions(-) create mode 100644 target-arm/gdbstub.c diff --git a/gdbstub.

[Qemu-devel] [PULL 02/25] kvm: Change prototype of kvm_update_guest_debug()

2013-07-26 Thread Andreas Färber
From: Stefan Weil Passing a CPUState pointer instead of a CPUArchState pointer eliminates the last target dependent data type in sysemu/kvm.h. It also simplifies the code. Signed-off-by: Stefan Weil Acked-by: Paolo Bonzini Signed-off-by: Andreas Färber --- exec.c | 5 ++--- i

[Qemu-devel] [PULL 13/25] target-mips: Move cpu_gdb_{read, write}_register()

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c | 124 +-- target-mips/gdbstub.c | 144 ++ 2 files changed, 145 insertions(+), 123 deletions(-) create mode 100644 target-mips/gdbstub.c diff --git a/g

[Qemu-devel] [PULL 05/25] gdbstub: Fix cpu_gdb_{read, write}_register() Coding Style

2013-07-26 Thread Andreas Färber
Add braces, replace tabs, remove trailing whitespace, drop space before parenthesis and place break etc. below case statements. Signed-off-by: Andreas Färber --- gdbstub.c | 446 -- 1 file changed, 292 insertions(+), 154 deletions(-) d

Re: [Qemu-devel] [PATCH qom-next for-1.6 00/14] char: QOM cast cleanups

2013-07-26 Thread Andreas Färber
Am 24.07.2013 23:42, schrieb Andreas Färber: > Andreas Färber (14): [...] > etraxfs_ser: QOM'ify [...] > xilinx_uartlite: Rename xlx_uartlite to XilinxUARTLite > xilinx_uartlite: QOM'ify Thanks, applied to qom-next (with improved commit messages): https://github.com/afaerber/qemu-cpu/commits

[Qemu-devel] ioport: qemu-system-sparc64 currently broken

2013-07-26 Thread Mark Cave-Ayland
Hi Jan/Paolo, I've just updated my local QEMU repository to git master for OpenBIOS testing and it seems that the ioport changes break SPARC64. git bisect points to this commit: commit b40acf99bef69fa8ab0f9092ff162fde945eec12 Author: Jan Kiszka Date: Mon Jun 24 10:45:09 2013 +0200 io

Re: [Qemu-devel] [PATCH qom-next for-1.6 0/2] cpu: QOM cast cleanups

2013-07-26 Thread Andreas Färber
Am 25.07.2013 00:16, schrieb Andreas Färber: > Andreas Färber (2): > arm11mpcore: QOM cast cleanups for ARM11MPCorePriveState > arm11mpcore: QOM cast cleanups for mpcore_rirq_state > > hw/cpu/arm11mpcore.c | 42 +++--- > 1 file changed, 27 insertions(+), 15

Re: [Qemu-devel] [PATCH qom-cpu v3 00/41] QOM CPUState, part 11: GDB stub

2013-07-26 Thread Edgar E. Iglesias
On Fri, Jul 26, 2013 at 11:32:29PM +0200, Andreas Färber wrote: > Am 23.07.2013 12:32, schrieb Max Filippov: > > On Wed, Jul 10, 2013 at 2:23 AM, Andreas Färber wrote: > >> Hello, > >> > >> This series cleans up gdbstub by changing all its internal CPU state to > >> CPUState > >> and by moving mo

[Qemu-devel] [PULL 08/25] target-i386: Move cpu_gdb_{read, write}_register()

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c | 203 + target-i386/gdbstub.c | 222 ++ 2 files changed, 223 insertions(+), 202 deletions(-) create mode 100644 target-i386/gdbstub.c diff --git a

[Qemu-devel] [PULL 22/25] gdbstub: Replace GET_REG*() macros with gdb_get_reg*() functions

2013-07-26 Thread Andreas Färber
This avoids polluting the global namespace with a non-prefixed macro and makes it obvious in the call sites that we return. Semi-automatic conversion using, e.g., sed -i 's/GET_REGL(/return gdb_get_regl(mem_buf, /g' target-*/gdbstub.c followed by manual tweaking for sparc's GET_REGA() and Coding

[Qemu-devel] [PULL 25/25] cpu: Introduce CPUClass::gdb_core_xml_file for GDB_CORE_XML

2013-07-26 Thread Andreas Färber
Replace the GDB_CORE_XML define in gdbstub.c with a CPUClass field. Use first_cpu for qSupported and qXfer:features:read: for now. Add a stub for xml_builtin. Signed-off-by: Andreas Färber --- gdbstub.c | 42 ++ include/qom/cpu.h

[Qemu-devel] [PULL 21/25] target-xtensa: Move cpu_gdb_{read, write}_register()

2013-07-26 Thread Andreas Färber
Acked-by: Max Filippov Signed-off-by: Andreas Färber --- gdbstub.c | 80 +- target-xtensa/gdbstub.c | 100 2 files changed, 101 insertions(+), 79 deletions(-) create mode 100644 target-xtensa/gdb

[Qemu-devel] [PULL 19/25] target-s390x: Move cpu_gdb_{read, write}_register()

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c | 60 + target-s390x/gdbstub.c | 80 ++ 2 files changed, 81 insertions(+), 59 deletions(-) create mode 100644 target-s390x/gdbstub.c diff --git a/gdbstub.

[Qemu-devel] [PULL 20/25] target-lm32: Move cpu_gdb_{read, write}_register()

2013-07-26 Thread Andreas Färber
Acked-by: Michael Walle Signed-off-by: Andreas Färber --- gdbstub.c | 66 +-- target-lm32/gdbstub.c | 85 +++ 2 files changed, 86 insertions(+), 65 deletions(-) create mode 100644 target-lm32/gdbstub

[Qemu-devel] [PULL 23/25] cpu: Introduce CPUClass::gdb_{read, write}_register()

2013-07-26 Thread Andreas Färber
Completes migration of target-specific code to new target-*/gdbstub.c. Acked-by: Michael Walle (for lm32) Acked-by: Max Filippov (for xtensa) Signed-off-by: Andreas Färber --- gdbstub.c | 80 - include/exec/gdbstub.h | 8 +

[Qemu-devel] [PULL 12/25] target-m68k: Move cpu_gdb_{read, write}_register()

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c | 47 +--- target-m68k/gdbstub.c | 67 +++ 2 files changed, 68 insertions(+), 46 deletions(-) create mode 100644 target-m68k/gdbstub.c diff --git a/gdbstub.c b

[Qemu-devel] [PULL 14/25] target-openrisc: Move cpu_gdb_{read, write}_register()

2013-07-26 Thread Andreas Färber
Reviewed-by: Jia Liu Signed-off-by: Andreas Färber --- gdbstub.c | 57 +-- target-openrisc/gdbstub.c | 77 +++ 2 files changed, 78 insertions(+), 56 deletions(-) create mode 100644 target-openrisc/gdbstu

[Qemu-devel] [PULL 24/25] target-cris: Factor out CPUClass::gdb_read_register() hook for v10

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-cris/cpu-qom.h | 1 + target-cris/cpu.c | 4 target-cris/gdbstub.c | 10 -- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/target-cris/cpu-qom.h b/target-cris/cpu-qom.h index 3e92ea0..7559366 100644 --- a/target-cris/cpu-

[Qemu-devel] [PULL 09/25] target-ppc: Move cpu_gdb_{read, write}_register()

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c| 101 +- target-ppc/gdbstub.c | 122 +++ 2 files changed, 123 insertions(+), 100 deletions(-) create mode 100644 target-ppc/gdbstub.c diff --git a/gdbs

[Qemu-devel] [PULL 18/25] target-alpha: Move cpu_gdb_{read, write}_register()

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c | 66 +- target-alpha/gdbstub.c | 86 ++ 2 files changed, 87 insertions(+), 65 deletions(-) create mode 100644 target-alpha/gdbstub.c diff --git a/gdbstub

[Qemu-devel] [PULL 10/25] target-sparc: Move cpu_gdb_{read, write}_register()

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c | 180 +--- target-sparc/gdbstub.c | 200 + 2 files changed, 201 insertions(+), 179 deletions(-) create mode 100644 target-sparc/gdbstub.c diff --git

[Qemu-devel] [PULL 01/25] linux-user: Avoid redundant ENV_GET_CPU()

2013-07-26 Thread Andreas Färber
This fixes a mismerge in 874ec3c5b3821bb964f9f37b2f930f2a9ce51652. Acked-by: Riku Voipio Signed-off-by: Andreas Färber --- linux-user/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/main.c b/linux-user/main.c index 5dc0947..5309117 100644 --- a/linux-user/m

[Qemu-devel] [PULL 04/25] target-xtensa: Introduce XtensaCPU subclasses

2013-07-26 Thread Andreas Färber
Register a CPU type per core registered. Save the XtensaConfig in XtensaCPUClass and copy it from there to CPUXtensaState, to avoid touching every env->config access for now. Prepares for storing per-class GDB register count. Acked-by: Max Filippov Signed-off-by: Andreas Färber --- target-xten

[Qemu-devel] [PATCH qom-next for-1.6 04/14] eccmemctl: QOM cast cleanup

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/misc/eccmemctl.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/misc/eccmemctl.c b/hw/misc/eccmemctl.c index 3de9675..96a69d4 100644 --- a/hw/misc/eccmemctl.c +++ b/hw/misc/eccmemctl.c @@ -120,8 +120,12 @@ #define EC

Re: [Qemu-devel] [RESEND][PATCH v2] cpu: Correct cpu-hotplug failure

2013-07-26 Thread Andreas Färber
Am 26.07.2013 05:08, schrieb Chen Fan: > This regression is caused by commit c643bed99. > > When using x86_64-softmmu --enable-kvm boot qemu, cpu-add command fails to > add a vcpu, > there show (KVM: setting VAPIC address failed), but at boot, there is no > problem. > > The reason for this is:

[Qemu-devel] [PATCH qom-next for-1.6 02/14] arm_l2x0: QOM cast cleanup

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/misc/arm_l2x0.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/misc/arm_l2x0.c b/hw/misc/arm_l2x0.c index f3ce477..8e192cd 100644 --- a/hw/misc/arm_l2x0.c +++ b/hw/misc/arm_l2x0.c @@ -23,8 +23,12 @@ /* L2C-310 r3p2 */ #de

[Qemu-devel] [PATCH qom-next for-1.6 13/14] slavio_misc: QOM cast cleanup for APCState

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/misc/slavio_misc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/hw/misc/slavio_misc.c b/hw/misc/slavio_misc.c index 1b93a01..767544e 100644 --- a/hw/misc/slavio_misc.c +++ b/hw/misc/slavio_misc.c @@ -57,8 +57,12 @@ typedef str

[Qemu-devel] [PATCH qom-next for-1.6 10/14] mst_fpga: QOM cast cleanup

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/misc/mst_fpga.c | 68 +- 1 file changed, 36 insertions(+), 32 deletions(-) diff --git a/hw/misc/mst_fpga.c b/hw/misc/mst_fpga.c index 604be5e..c96810f 100644 --- a/hw/misc/mst_fpga.c +++ b/hw/misc/mst_fpga.c

[Qemu-devel] [PATCH qom-next for-1.6 11/14] puv3_pm: QOM cast cleanup

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/misc/puv3_pm.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/misc/puv3_pm.c b/hw/misc/puv3_pm.c index 5592560..37f2369 100644 --- a/hw/misc/puv3_pm.c +++ b/hw/misc/puv3_pm.c @@ -14,8 +14,12 @@ #undef DEBUG_PUV3 #include

[Qemu-devel] [PATCH qom-next for-1.6 12/14] slavio_misc: QOM cast cleanup for MiscState

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/misc/slavio_misc.c | 35 --- 1 file changed, 20 insertions(+), 15 deletions(-) diff --git a/hw/misc/slavio_misc.c b/hw/misc/slavio_misc.c index 00d9542..1b93a01 100644 --- a/hw/misc/slavio_misc.c +++ b/hw/misc/slavio_misc.c @@

[Qemu-devel] [PATCH qom-next for-1.6 08/14] milkymist-hpdmc: QOM cast cleanup

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/misc/milkymist-hpdmc.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/misc/milkymist-hpdmc.c b/hw/misc/milkymist-hpdmc.c index a498881..aef135e 100644 --- a/hw/misc/milkymist-hpdmc.c +++ b/hw/misc/milkymist-hpdmc.c @@ -40,

[Qemu-devel] [PATCH qom-next for-1.6 05/14] exynos4210_pmu: QOM cast cleanup

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/misc/exynos4210_pmu.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/hw/misc/exynos4210_pmu.c b/hw/misc/exynos4210_pmu.c index 28395ba..cbf0795 100644 --- a/hw/misc/exynos4210_pmu.c +++ b/hw/misc/exynos4210_pmu.c @@ -386,8 +

[Qemu-devel] [PATCH qom-next for-1.6 03/14] arm_sysctl: QOM cast cleanup

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/misc/arm_sysctl.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/hw/misc/arm_sysctl.c b/hw/misc/arm_sysctl.c index 5906ae5..4a911d4 100644 --- a/hw/misc/arm_sysctl.c +++ b/hw/misc/arm_sysctl.c @@ -16,8 +16,13 @@ #d

[Qemu-devel] [PATCH qom-next for-1.6 00/14] misc: QOM cast cleanups

2013-07-26 Thread Andreas Färber
Hello, This series eliminates FROM_SYSBUS() in hw/misc/. Regards, Andreas Cc: Hu Tao Andreas Färber (14): arm_l2x0: Rename l2x0_state to L2x0State arm_l2x0: QOM cast cleanup arm_sysctl: QOM cast cleanup eccmemctl: QOM cast cleanup exynos4210_pmu: QOM cast cleanup imx_ccm: QOM cast

[Qemu-devel] [PATCH qom-next for-1.6 07/14] lm32_sys: QOM cast cleanup

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/misc/lm32_sys.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/hw/misc/lm32_sys.c b/hw/misc/lm32_sys.c index 060a5bf..9bdb781 100644 --- a/hw/misc/lm32_sys.c +++ b/hw/misc/lm32_sys.c @@ -44,8 +44,12 @@ enum { #define MAX_TE

[Qemu-devel] [PATCH qom-next for-1.6 09/14] milkymist-pfpu: QOM cast cleanup

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/misc/milkymist-pfpu.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/misc/milkymist-pfpu.c b/hw/misc/milkymist-pfpu.c index 2b64ee7..b3b2143 100644 --- a/hw/misc/milkymist-pfpu.c +++ b/hw/misc/milkymist-pfpu.c @@ -116,8 +1

[Qemu-devel] [PATCH qom-next for-1.6 14/14] zynq_slcr: QOM cast cleanup

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/misc/zynq_slcr.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/misc/zynq_slcr.c b/hw/misc/zynq_slcr.c index fc7a85f..e42a5b0 100644 --- a/hw/misc/zynq_slcr.c +++ b/hw/misc/zynq_slcr.c @@ -114,8 +114,12 @@ typedef enum {

[Qemu-devel] [PATCH qom-next for-1.6 01/14] arm_l2x0: Rename l2x0_state to L2x0State

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/misc/arm_l2x0.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/hw/misc/arm_l2x0.c b/hw/misc/arm_l2x0.c index 3d6acee..f3ce477 100644 --- a/hw/misc/arm_l2x0.c +++ b/hw/misc/arm_l2x0.c @@ -23,7 +23,7 @@ /* L2C

[Qemu-devel] [PATCH qom-next for-1.6 06/14] imx_ccm: QOM cast cleanup

2013-07-26 Thread Andreas Färber
Signed-off-by: Andreas Färber --- hw/misc/imx_ccm.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/misc/imx_ccm.c b/hw/misc/imx_ccm.c index 816d5e8..63e33a4 100644 --- a/hw/misc/imx_ccm.c +++ b/hw/misc/imx_ccm.c @@ -29,8 +29,12 @@ do { printf("imx_ccm: "

Re: [Qemu-devel] [PATCH qom-cpu v3 00/41] QOM CPUState, part 11: GDB stub

2013-07-26 Thread Andreas Färber
Am 23.07.2013 12:32, schrieb Max Filippov: > On Wed, Jul 10, 2013 at 2:23 AM, Andreas Färber wrote: >> Hello, >> >> This series cleans up gdbstub by changing all its internal CPU state to >> CPUState >> and by moving most target-specific code into the target directories. >> >> Support for m68k, m

[Qemu-devel] [Bug 1180777] Re: Windows 7 VM freeze on Ubuntu 12.04 KVM

2013-07-26 Thread Serge Hallyn
** Also affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1180777 Title: Windows 7 VM freeze on Ubuntu 12.04 KVM Status in QEMU: New Status

Re: [Qemu-devel] [PATCH] s390: fix cpustate rework fallout

2013-07-26 Thread Andreas Färber
Am 26.07.2013 17:56, schrieb Christian Borntraeger: > On 26/07/13 17:55, Andreas Färber wrote: >> Am 26.07.2013 17:48, schrieb Christian Borntraeger: >>> commit f17ec444c3d39f76bcd8b71c2c05d5754bfe333e >>> exec: Change cpu_memory_rw_debug() argument to CPUState >>> >>> broke s390: >>> >>> CCs

Re: [Qemu-devel] [PATCH V3 for-1.6 3/5] block: Add support for throttling burst threshold in QMP and the command line.

2013-07-26 Thread Benoît Canet
> Kevin's series renamed these to have a dash in the name, and also moved > all the throttling parameters into a sub-struct. Does it make more > sense to have just '*throttling' with that sub-struct containing 12 > parameters, 6 for limits and 6 for thresholds, or would it be better to > have '*th

[Qemu-devel] [PATCH RFC qom-next for-1.6] fdc: Fix inheritence for SUNW, fdtwo

2013-07-26 Thread Andreas Färber
Since commit dd3be7420774f7dc8f37a96ca24d07f0b6f31b3b SUNW,fdtwo's initfn (realizefn since 940194c2369e50d91d1abf6f36d43853eea5e539) was using SYSBUS_FDC() cast. This uses type sysbus-fdc rather than SUNW,fdtwo. Fix this by letting SUNW,fdtwo inherit from sysbus-fdc. This has the side-effect of e

Re: [Qemu-devel] [PATCHv3 0/2] seccomp: remove unused syscalls - for 1.6

2013-07-26 Thread Eduardo Otubo
Any chance to get it pushed for 1.6? Thanks. On 07/23/2013 04:43 AM, Paolo Bonzini wrote: Il 22/07/2013 20:33, Eduardo Otubo ha scritto: In this small patch series I basically: v3 update: - reincluded getrlimit(), it's used by Xen. v2 update: - set libseccomp 2.1.0 as requirement

[Qemu-devel] [PATCHv2] sun4m: add display width and height to the firmware configuration

2013-07-26 Thread Mark Cave-Ayland
Currently the graphics resolution for TCX is fixed at 1024x768, however other framebuffers are capable of supporting additional resolutions. Signed-off-by: Mark Cave-Ayland CC: Anthony Liguori CC: Blue Swirl --- hw/sparc/sun4m.c |4 1 file changed, 4 insertions(+) diff --git a/hw/spa

[Qemu-devel] [PATCH V4/FIX FOR 1.6] block: Repair the throttling code.

2013-07-26 Thread Benoît Canet
The throttling code was segfaulting since commit 02ffb504485f0920cfc75a0982a602f824a9a4f4 because some qemu_co_queue_next caller does not run in a coroutine. qemu_co_queue_do_restart assume that the caller is a coroutinne. As suggested by Stefan fix this by entering the coroutine directly. Also mak

[Qemu-devel] [PULL 17/18] Implement sync modes for drive-backup.

2013-07-26 Thread Kevin Wolf
From: Ian Main This patch adds sync-modes to the drive-backup interface and implements the FULL, NONE and TOP modes of synchronization. FULL performs as before copying the entire contents of the drive while preserving the point-in-time using CoW. NONE only copies new writes to the target drive.

[Qemu-devel] [PATCH V4/FIX FOR 1.6] repair throttling code

2013-07-26 Thread Benoît Canet
since v3: silence bogus checkpatch warning [abligh] Benoît Canet (1): block: Repair the throttling code. block.c |7 +++ include/block/coroutine.h |9 +++-- qemu-coroutine-lock.c | 20 ++-- 3 files changed, 28 insertions(+), 8 deletions(

[Qemu-devel] [PULL 08/18] qapi.py: Maintain a list of union types

2013-07-26 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- scripts/qapi.py | 13 + 1 file changed, 13 insertions(+) diff --git a/scripts/qapi.py b/scripts/qapi.py index baf1321..3a54c7f 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -105,6 +105,7 @@ def parse_schema(fp):

[Qemu-devel] [PULL 18/18] Add tests for sync modes 'TOP' and 'NONE'

2013-07-26 Thread Kevin Wolf
From: Ian Main This patch adds tests for sync modes top and none. Test for 'TOP' is separated out as it requires a backing file. Also added a test for invalid format. Signed-off-by: Ian Main Signed-off-by: Kevin Wolf --- tests/qemu-iotests/055| 6 +++ tests/qemu-iotests/055.out

[Qemu-devel] [PULL 06/18] qapi: Flat unions with arbitrary discriminator

2013-07-26 Thread Kevin Wolf
Instead of the rather verbose syntax that distinguishes base and subclass fields... { "type": "file", "read-only": true, "data": { "filename": "test" } } ...we can now have both in the same namespace, allowing a more direct mapping of the command line, and moving fields betw

[Qemu-devel] [PULL 13/18] qcow2: Use dashes instead of underscores in options

2013-07-26 Thread Kevin Wolf
This is what QMP wants to use. The options haven't been enabled in any release yet, so we're still free to change them. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- block/qcow2.c | 2 +- block/qcow2.h | 8 tests/qemu-iotests/051 | 14 +++

[Qemu-devel] [PULL 12/18] blockdev: Rename I/O throttling options for QMP

2013-07-26 Thread Kevin Wolf
In QMP, we want to use dashes instead of underscores in QMP argument names, and use nested options for throttling. The new option names affect the command line as well, but for compatibility drive_init() will convert the old option names before calling into the code that will be shared between -dr

[Qemu-devel] [PULL 11/18] QemuOpts: Add qemu_opt_unset()

2013-07-26 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- include/qemu/option.h | 1 + util/qemu-option.c| 14 ++ 2 files changed, 15 insertions(+) diff --git a/include/qemu/option.h b/include/qemu/option.h index a83c700..13f5e72 100644 --- a/include/qemu/option.h +++ b/include/qem

[Qemu-devel] [PULL 16/18] Implement qdict_flatten()

2013-07-26 Thread Kevin Wolf
qdict_flatten(): For each nested QDict with key x, all fields with key y are moved to this QDict and their key is renamed to "x.y". This operation is applied recursively for nested QDicts. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- include/qapi/qmp/qdict.h | 1 + qobject/qdict.c

[Qemu-devel] [PULL 10/18] block: Allow "driver" option on the top level

2013-07-26 Thread Kevin Wolf
This is traditionally -drive format=..., which is now translated into the new driver option. This gives us a more consistent way to select the driver of BlockDriverStates that can be used in QMP context, too. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- block.c| 7 +++ blockde

[Qemu-devel] [PULL 05/18] qapi: Add visitor for implicit structs

2013-07-26 Thread Kevin Wolf
These can be used when an embedded struct is parsed and members not belonging to the struct may be present in the input (e.g. parsing a flat namespace QMP union, where fields from both the base and one of the alternative types are mixed in the JSON object) Signed-off-by: Kevin Wolf Reviewed-by: E

[Qemu-devel] [PULL 15/18] blockdev: Split up 'cache' option

2013-07-26 Thread Kevin Wolf
The old 'cache' option really encodes three different boolean flags into a cache mode name, without providing all combinations. Make them three separate options instead and translate the old option to the new ones for drive_init(). The specific boolean options take precedence if the old cache opti

[Qemu-devel] [PULL 04/18] docs: Document QAPI union types

2013-07-26 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- docs/qapi-code-gen.txt | 62 -- 1 file changed, 55 insertions(+), 7 deletions(-) diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt index cccb11e..f6f8d33 100644 --- a/docs/qapi-code-

[Qemu-devel] [PULL 14/18] blockdev: Rename 'readonly' option to 'read-only'

2013-07-26 Thread Kevin Wolf
Option name cleanup before it becomes a QMP API. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- blockdev.c | 10 ++ tests/qemu-iotests/051.out | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/blockdev.c b/blockdev.c index 5403188..3b05e29 10

[Qemu-devel] [PULL 09/18] qapi: Anonymous unions

2013-07-26 Thread Kevin Wolf
The discriminator for anonymous unions is the data type. This allows to have a union type that allows both of these: { 'file': 'my_existing_block_device_id' } { 'file': { 'filename': '/tmp/mydisk.qcow2', 'read-only': true } } Unions like this are specified in the schema with an empty dict

[Qemu-devel] [PULL 03/18] qapi-visit.py: Implement 'base' for unions

2013-07-26 Thread Kevin Wolf
This implements the visitor part of base types for unions. Parsed into QMP, this example schema definition... { 'type': 'BlockOptionsBase', 'data': { 'read-only': 'bool' } } { 'type': 'BlockOptionsQcow2, 'data': { 'lazy-refcounts': 'bool' } } { 'union': 'BlockOptions', 'base': '

[Qemu-devel] [PULL 02/18] qapi-visit.py: Split off generate_visit_struct_fields()

2013-07-26 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- scripts/qapi-visit.py | 62 --- 1 file changed, 34 insertions(+), 28 deletions(-) diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py index 6cac05a..a337d80 100644 --- a/scripts/qapi-vis

[Qemu-devel] [PULL 07/18] qapi: Add consume argument to qmp_input_get_object()

2013-07-26 Thread Kevin Wolf
This allows to just look at the next element without actually consuming it. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- qapi/qmp-input-visitor.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/qapi/qmp-input-visitor.c b/qapi/qmp-input-visitor.c

[Qemu-devel] [PULL 01/18] qapi-types.py: Implement 'base' for unions

2013-07-26 Thread Kevin Wolf
The new 'base' key in a union definition refers to a struct type, which is inlined into the union definition and can represent fields common to all kinds. For example the following schema definition... { 'type': 'BlockOptionsBase', 'data': { 'read-only': 'bool' } } { 'union': 'BlockOptio

[Qemu-devel] [PULL 00/18] Block patches

2013-07-26 Thread Kevin Wolf
The following changes since commit 003e26bc9f7c4f5cd90e046ae112c1d09363b8d1: Merge remote-tracking branch 'mdroth/qga-pull-2013-7-25' into staging (2013-07-25 15:58:29 -0500) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony for you to fetch changes up to

Re: [Qemu-devel] [qom-cpu PATCH 0/2] i386: disable PMU CPUID leaf by default

2013-07-26 Thread Andreas Färber
Am 26.07.2013 22:09, schrieb Eduardo Habkost: > Changes v1 -> v2: > * compat property is now named "pmu" instead of "pmu-passthrough" > > Eduardo Habkost (2): > i386: pass X86CPU object to cpu_x86_find_by_name() > i386: disable PMU CPUID leaves by default > > include/hw/i386/pc.h | 4

[Qemu-devel] [qom-cpu PATCH v2 1/2] i386: pass X86CPU object to cpu_x86_find_by_name()

2013-07-26 Thread Eduardo Habkost
This will help us change the initialization code to not require carrying some intermediate values in a x86_def_t struct (and eventually kill the x86_def_t struct entirely). Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [qom-cpu PATCH 0/2] i386: disable PMU CPUID leaf by default

2013-07-26 Thread Eduardo Habkost
Changes v1 -> v2: * compat property is now named "pmu" instead of "pmu-passthrough" Eduardo Habkost (2): i386: pass X86CPU object to cpu_x86_find_by_name() i386: disable PMU CPUID leaves by default include/hw/i386/pc.h | 4 target-i386/cpu-qom.h | 7 +++ target-i386/cpu.c |

[Qemu-devel] [qom-cpu PATCH v2 2/2] i386: disable PMU CPUID leaf by default

2013-07-26 Thread Eduardo Habkost
Bug description: QEMU currently gets all bits from GET_SUPPORTED_CPUID for CPUID leaf 0xA and passes them directly to the guest. This makes the guest ABI depend on host kernel and host CPU capabilities, and breaks live migration if we migrate between host with different capabilities (e.g. different

[Qemu-devel] [PULL v2 for-1.6 3/3] tcg: Remove temp_buf

2013-07-26 Thread Richard Henderson
All targets have been converted to allocating space for temporaries on the stack. No need to allocate space within the CPU_COMMON block. Signed-off-by: Richard Henderson --- include/exec/cpu-defs.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/exec/cpu-defs.h b/include/exec/cpu-d

Re: [Qemu-devel] [PATCH v2 03/16] intc/arm_gic: Extract public header hw/intc/arm_gic.h

2013-07-26 Thread Andreas Färber
Am 23.07.2013 04:43, schrieb Andreas Färber: > diff --git a/include/hw/intc/arm_gic.h b/include/hw/intc/arm_gic.h > new file mode 100644 > index 000..be945ec > --- /dev/null > +++ b/include/hw/intc/arm_gic.h [...] > +typedef struct GICState { > +/*< private >*/ > +SysBusDevice busdev;

Re: [Qemu-devel] [PATCH 4/9] qapi.py: Decent syntax error reporting

2013-07-26 Thread Eric Blake
On 07/26/2013 01:48 PM, Paolo Bonzini wrote: > Il 26/07/2013 21:33, Markus Armbruster ha scritto: >>> Do we even want to allow TABs in the schema files? Right now, they are >>> tab-free; if you error out here instead of futzing with tab width, we >>> could forcefully maintain that property. >> >>

[Qemu-devel] [RFC] [PATCHv4 01/13] aio / timers: add qemu-timer.c utility functions

2013-07-26 Thread Alex Bligh
Add qemu_free_clock and expose qemu_new_clock and clock types. Add utility functions to qemu-timer.c for nanosecond timing. Add qemu_clock_deadline_ns to calculate deadlines to nanosecond accuracy. Add utility function qemu_soonest_timeout to calculate soonest deadline. Add qemu_timeout_ns_to_m

Re: [Qemu-devel] [PATCH 13/18] blockdev: Rename I/O throttling options for QMP

2013-07-26 Thread Eric Blake
On 07/26/2013 01:35 PM, Benoît Canet wrote: >> This patch will probably conflict with Benoît's work on leaky bucket >> throttling; can the two of you decide which one should go in first? Are >> we trying to target both this series and leaky bucket throttling for 1.6? > > I will to rebase my serie

[Qemu-devel] [PATCH/FIX FOR 1.6] block: Repair the throttling code.

2013-07-26 Thread Benoît Canet
The throttling code was segfaulting since commit 02ffb504485f0920cfc75a0982a602f824a9a4f4 because some qemu_co_queue_next caller does not run in a coroutine. qemu_co_queue_do_restart assume that the caller is a coroutinne. As suggested by Stefan fix this by entering the coroutine directly. Also mak

[Qemu-devel] [PATCH/FIX FOR 1.6] Repair the throttling code

2013-07-26 Thread Benoît Canet
The throttling code was segfaulting repair it for 1.6. Benoît Canet (1): block: Repair the throttling code. block.c |8 include/block/coroutine.h |9 +++-- qemu-coroutine-lock.c | 20 ++-- 3 files changed, 29 insertions(+), 8 deletio

Re: [Qemu-devel] [PATCH 4/9] qapi.py: Decent syntax error reporting

2013-07-26 Thread Paolo Bonzini
Il 26/07/2013 21:33, Markus Armbruster ha scritto: > > Do we even want to allow TABs in the schema files? Right now, they are > > tab-free; if you error out here instead of futzing with tab width, we > > could forcefully maintain that property. > > I'm not volunteering for the TAB police, but if

Re: [Qemu-devel] [PATCH 0/9] Our QAPI parser is a hack, replace it

2013-07-26 Thread Markus Armbruster
Anthony Liguori writes: > Markus Armbruster writes: > >> Anthony Liguori writes: >> >>> Markus Armbruster writes: >>> If you think I'm exaggerating, check out the list of issues in PATCH 3/9. >>> >>> You are not. >>> >>> However, I think we can drop the whole thing and just use the J

[Qemu-devel] [RFC] [PATCHv4 07/13] aio / timers: Add an AioContext pointer to QEMUTimerList

2013-07-26 Thread Alex Bligh
Add an AioContext pointer to QEMUTimerList so it knows what to notify on a timer change. Signed-off-by: Alex Bligh --- async.c |1 + include/qemu/timer.h |3 +++ qemu-timer.c | 12 3 files changed, 16 insertions(+) diff --git a/async.c b/async.c index

Re: [Qemu-devel] [PATCH V3 for-1.6 1/5] block: Repair the throttling code.

2013-07-26 Thread Alex Bligh
--On 26 July 2013 13:16:04 -0600 Eric Blake wrote: -while (qemu_co_queue_next(&bs->throttled_reqs)); +while (qemu_co_enter_next(&bs->throttled_reqs)) { +} On first read, I missed the s/queue/enter/ change and thought all you were doing was the s/;/{}/ change. Is the style chang

  1   2   3   4   >