Re: [Qemu-devel] [PATCH v2 1/2] qapi: change qapi to convert schema json

2013-07-25 Thread Amos Kong
On Fri, Jul 19, 2013 at 06:27:12AM -0600, Eric Blake wrote: > On 07/16/2013 04:37 AM, Amos Kong wrote: > > QMP schema is defined in a json file, it will be parsed by > > qapi scripts and generate C files. > > > > We want to return the schema information to management, > > this patch converts the j

Re: [Qemu-devel] [PATCH 2/9] block: vhdx - add header update capability.

2013-07-25 Thread Fam Zheng
On Wed, 07/24 13:54, Jeff Cody wrote: > This adds the ability to update the headers in a VHDX image, including > generating a new MS-compatible GUID. > > As VHDX depends on uuid.h, VHDX is now a configurable build option. If > VHDX support is enabled, that will also enable uuid as well. The > de

Re: [Qemu-devel] [PATCH v6 01/18] block: ensure bdrv_drain_all() works during bdrv_delete()

2013-07-25 Thread Wenchao Xia
Reviewed-by: Wenchao Xia One question: old code missed itself in bdrv_drain_all(), is that a bug? > In bdrv_delete() make sure to call bdrv_make_anon() *after* bdrv_close() > so that the device is still seen by bdrv_drain_all() when iterating > bdrv_states. > > Cc: qemu-sta...@nongnu.org > Sign

Re: [Qemu-devel] Cirrus VGA slow screen update, show blank screen last 13s or so for windows XP guest

2013-07-25 Thread Gonglei (Arei)
> -Original Message- > From: Anthony Liguori [mailto:anth...@codemonkey.ws] > Sent: Friday, July 26, 2013 11:21 AM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; Hanweidong; > Luonengjun; Huangweidong (Hardware) > Subject: Re: [Qemu-devel] Cirrus VGA slow scree

[Qemu-devel] [PATCH v4 07/10] sheepdog: try to reconnect to sheepdog after network error

2013-07-25 Thread MORITA Kazutaka
This introduces a failed request queue and links all the inflight requests to the list after network error happens. After QEMU reconnects to the sheepdog server successfully, the sheepdog block driver will retry all the requests in the failed queue. Tested-and-reviewed-by: Liu Yuan Signed-off-by

[Qemu-devel] [PATCH v4 00/10] sheepdog: reconnect server after connection failure

2013-07-25 Thread MORITA Kazutaka
Currently, if a sheepdog server exits, all the connecting VMs need to be restarted. This series implements a feature to reconnect the server, and enables us to do online sheepdog upgrade and avoid restarting VMs when sheepdog servers crash unexpectedly. v4: - Added comment to explain why we need

[Qemu-devel] [PATCH v4 04/10] sheepdog: handle vdi objects in resend_aio_req

2013-07-25 Thread MORITA Kazutaka
The current resend_aio_req() doesn't work when the request is against vdi objects. This fixes the problem. Tested-and-reviewed-by: Liu Yuan Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/block/sheep

[Qemu-devel] [PATCH v4 03/10] sheepdog: check return values of qemu_co_recv/send correctly

2013-07-25 Thread MORITA Kazutaka
If qemu_co_recv/send doesn't return the specified length, it means that an error happened. Tested-and-reviewed-by: Liu Yuan Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.

[Qemu-devel] [PATCH v4 08/10] sheepdog: make add_aio_request and send_aioreq void functions

2013-07-25 Thread MORITA Kazutaka
These functions no longer return errors. We can make them void functions and simplify the codes. Tested-and-reviewed-by: Liu Yuan Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 66 +++- 1 file changed, 17 insertions(+), 49 deletions(-)

[Qemu-devel] [PATCH v4 10/10] sheepdog: check simultaneous create in resend_aioreq

2013-07-25 Thread MORITA Kazutaka
After reconnection happens, all the inflight requests are moved to the failed request list. As a result, sd_co_rw_vector() can send another create request before resend_aioreq() resends a create request from the failed list. This patch adds a helper function check_simultaneous_create() and checks

[Qemu-devel] [PATCH v4 09/10] sheepdog: cancel aio requests if possible

2013-07-25 Thread MORITA Kazutaka
This patch tries to cancel aio requests in pending queue and failed queue. When the sheepdog driver cannot cancel the requests, it waits for them to be completed. Tested-and-reviewed-by: Liu Yuan Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 70 +

[Qemu-devel] [PATCH v4 02/10] iov: handle EOF in iov_send_recv

2013-07-25 Thread MORITA Kazutaka
Without this patch, iov_send_recv() never returns when do_send_recv() returns zero. Reviewed-by: Paolo Bonzini Signed-off-by: MORITA Kazutaka --- util/iov.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/util/iov.c b/util/iov.c index cc6e837..f705586 100644 --- a/util/iov.c +++ b/uti

[Qemu-devel] [PATCH v4 05/10] sheepdog: reload inode outside of resend_aioreq

2013-07-25 Thread MORITA Kazutaka
This prepares for using resend_aioreq() after reconnecting to the sheepdog server. Tested-and-reviewed-by: Liu Yuan Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/block/sheepdog.c b/bloc

[Qemu-devel] [PATCH v4 06/10] coroutine: add co_aio_sleep_ns() to allow sleep in block drivers

2013-07-25 Thread MORITA Kazutaka
This helper function behaves similarly to co_sleep_ns(), but the sleeping coroutine will be resumed when using qemu_aio_wait(). Signed-off-by: MORITA Kazutaka --- include/block/coroutine.h | 8 qemu-coroutine-sleep.c| 47 +++ 2 files chan

[Qemu-devel] [PATCH v4 01/10] ignore SIGPIPE in qemu-img and qemu-io

2013-07-25 Thread MORITA Kazutaka
This prevents the tools from being stopped when they write data to a closed connection in the other side. Reviewed-by: Paolo Bonzini Signed-off-by: MORITA Kazutaka --- qemu-img.c | 4 qemu-io.c | 4 2 files changed, 8 insertions(+) diff --git a/qemu-img.c b/qemu-img.c index c55ca5c.

[Qemu-devel] [Bug 1205156] Re: Errors while compiling version 1.5.2

2013-07-25 Thread jean-christophe manciot
I was able to compile and link latest 1.5.2 release with the tar.bz2 source files. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1205156 Title: Errors while compiling version 1.5.2 Status in QEMU:

Re: [Qemu-devel] [sheepdog] [PATCH v3 07/10] sheepdog: try to reconnect to sheepdog after network error

2013-07-25 Thread MORITA Kazutaka
At Thu, 25 Jul 2013 21:20:43 +0800, Liu Yuan wrote: > > On Thu, Jul 25, 2013 at 09:53:14PM +0900, MORITA Kazutaka wrote: > > At Thu, 25 Jul 2013 17:13:46 +0800, > > Liu Yuan wrote: > > > > > > > + > > > > +/* Try to reconnect the sheepdog server every one second. */ > > > > +while (s->fd

Re: [Qemu-devel] [PATCH v6 13/18] block/sheepdog: drop have_co_req() and aio_flush_request()

2013-07-25 Thread MORITA Kazutaka
At Thu, 25 Jul 2013 17:18:20 +0200, Stefan Hajnoczi wrote: > > .io_flush() is no longer called so drop have_co_req() and > aio_flush_request(). > > Signed-off-by: Stefan Hajnoczi > --- > block/sheepdog.c | 25 + > 1 file changed, 5 insertions(+), 20 deletions(-) Reviewe

Re: [Qemu-devel] [Bug 1205156] [NEW] Errors while compiling version 1.5.2

2013-07-25 Thread Stefan Weil
Am 26.07.2013 04:03, schrieb jean-christophe manciot: > Public bug reported: > > Environment: Ubuntu 13.04 > > "hw/ide/macio.c: In function ‘pmac_ide_atapi_transfer_cb’: > hw/ide/macio.c:134:9: error: format ‘%lx’ expects argument of type ‘long > unsigned int’, but argument 3 has type ‘hwaddr’ [-W

[Qemu-devel] [Bug 1192780] Re: qemu-kvm with snapshot option always fails with Permission denied Could not open disk image

2013-07-25 Thread Deepak C Shetty
Eric, Thanks for the quick reply. I saw the desc. in formatdomain.html and thought its supported. So does that mean its supported for other hypervisors but not QEMU/KVM ? If not supported at all, why does it show up in the doc... its misleading. I had a recent need to start exploiting this

Re: [Qemu-devel] [RFC 1/2] Provide infrastructure for marking private QOM struct fields

2013-07-25 Thread Edgar E. Iglesias
On Thu, Jul 25, 2013 at 05:42:02PM +0100, Peter Maydell wrote: > Provide infrastructure for marking private QOM struct fields, > so that a compiler warning is generated when a user of the QOM > object attempts to access them directly. > > This is implemented using GCC's 'deprecated' attribute; pre

Re: [Qemu-devel] [PATCH V3 for-1.6 2/5] block: Modify the throttling code to implement the leaky bucket algorithm.

2013-07-25 Thread Fam Zheng
On Tue, 07/23 18:29, Benoît Canet wrote: > This patch replace the previous algorithm by the well described leaky bucket > algorithm: A bucket is filled by the incoming IOs and a periodic timer > decrement > the counter to make the bucket leak. When a given threshold is reached the > bucket is full

Re: [Qemu-devel] [PATCH v2 1/2] qapi: change qapi to convert schema json

2013-07-25 Thread Amos Kong
On Wed, Jul 17, 2013 at 04:09:32PM -0400, Luiz Capitulino wrote: > On Tue, 16 Jul 2013 18:37:41 +0800 > Amos Kong wrote: > > > QMP schema is defined in a json file, it will be parsed by > > qapi scripts and generate C files. > > > > We want to return the schema information to management, > > thi

Re: [Qemu-devel] [PATCH V7 00/13] monitor: support sub command group in auto completion and help

2013-07-25 Thread Wenchao Xia
>> >Luiz, do you like a respin for this version? There are some typo in > commit message Eric have pointed out. > I have respinned v8 to fix the typo issues, sorry for interrupt. -- Best Regards Wenchao Xia

[Qemu-devel] [PATCH V8 13/13] monitor: improve auto complete of "help" for single command in sub group

2013-07-25 Thread Wenchao Xia
Now special case "help *" in auto completion can work with sub commands, such as "help info u*". Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake --- monitor.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 99b9f2e..754cf4c 100644 ---

[Qemu-devel] [PATCH V8 12/13] monitor: allow "help" show message for single command in sub group

2013-07-25 Thread Wenchao Xia
A new parameter type 'S' is introduced to allow user input any string. "help info block" works normal now. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake --- hmp-commands.hx |2 +- monitor.c | 27 +++ 2 files changed, 28 insertions(+), 1 deletions(-) dif

[Qemu-devel] [PATCH V8 09/13] monitor: support sub command in help

2013-07-25 Thread Wenchao Xia
The old code in help_cmd() uses global 'info_cmds' and treats it as a special case. Actually 'info_cmds' is a sub command group of 'mon_cmds', in order to avoid direct use of it, help_cmd() needs to change its work mechanism to support sub command and not treat it as a special case any more. To su

[Qemu-devel] [PATCH V8 03/13] monitor: avoid use of global *cur_mon in block_completion_it()

2013-07-25 Thread Wenchao Xia
Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake --- monitor.c | 18 ++ 1 files changed, 14 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index dc66dca..0ecb70a 100644 --- a/monitor.c +++ b/monitor.c @@ -4086,14 +4086,21 @@ static void file_completion(Moni

[Qemu-devel] [PATCH V8 06/13] monitor: avoid direct use of global variable *mon_cmds

2013-07-25 Thread Wenchao Xia
New member *cmd_table is added in structure Monitor to avoid direct usage of *mon_cmds. Now monitor have an associated command table, when global variable *info_cmds is also discarded, structure Monitor would gain full control about how to deal with user input. Signed-off-by: Wenchao Xia Reviewed

[Qemu-devel] [PATCH V8 11/13] monitor: support sub command in auto completion

2013-07-25 Thread Wenchao Xia
This patch allows auto completion work normal for sub command case, "info block [DEVICE]" can auto complete now, by re-enter the completion function. In original code "info" is treated as a special case, now it is treated as a sub command group, global variable info_cmds is not used any more. "hel

[Qemu-devel] [PATCH V8 04/13] monitor: avoid use of global *cur_mon in monitor_find_completion()

2013-07-25 Thread Wenchao Xia
Parameter *mon is added, and local variable *mon added in previous patch is removed. The caller readline_completion(), pass rs->mon as value, which should be initialized in readline_init() called by monitor_init(). Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake --- include/monitor/readline.

[Qemu-devel] [PATCH V8 10/13] monitor: refine monitor_find_completion()

2013-07-25 Thread Wenchao Xia
In order to support sub command in auto completion, a reentrant function is needed, so monitor_find_completion() is split into two parts. The first part does parsing of user input which need to be done only once, the second part does the auto completion job according to the parsing result, which co

[Qemu-devel] [PATCH V8 08/13] monitor: refine parse_cmdline()

2013-07-25 Thread Wenchao Xia
Since this function will be used by help_cmd() later, so improve it to make it more generic and easier to use. free_cmdline_args() is added too as paired function to free the result. One change of this function is that, when the valid args in input exceed the limit of MAX_ARGS, it fails now, inste

[Qemu-devel] [PATCH V8 05/13] monitor: avoid use of global *cur_mon in readline_completion()

2013-07-25 Thread Wenchao Xia
Now all completion functions do not use *cur_mon any more, instead they use rs->mon. In short, structure ReadLineState decide where the complete action would be taken now. Tested with the case that qemu have two telnet monitors, auto completion function works normal. Signed-off-by: Wenchao Xia R

[Qemu-devel] [PATCH V8 00/13] monitor: support sub command group in auto completion and help

2013-07-25 Thread Wenchao Xia
This series make auto completion and help functions works normal for sub command, by using reentrant functions. In order to do that, global variables are not directly used in those functions any more. With this series, cmd_table is a member of structure Monitor so it is possible to create a monitor

[Qemu-devel] [PATCH V8 07/13] monitor: code move for parse_cmdline()

2013-07-25 Thread Wenchao Xia
help_cmd() need this function later, so move it. get_str() is called by parse_cmdline() so it is moved also. Some code style error reported by check script, is also fixed. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake --- monitor.c | 191 +++

[Qemu-devel] [PATCH V8 01/13] monitor: avoid use of global *cur_mon in cmd_completion()

2013-07-25 Thread Wenchao Xia
A new local variable *mon is added in monitor_find_completion() to make compile pass, which will be removed later in conversion patch for monitor_find_completion(). Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake --- monitor.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletio

[Qemu-devel] [PATCH V8 02/13] monitor: avoid use of global *cur_mon in file_completion()

2013-07-25 Thread Wenchao Xia
Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake --- monitor.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index c2babba..dc66dca 100644 --- a/monitor.c +++ b/monitor.c @@ -4030,7 +4030,7 @@ static void cmd_completion(Monitor *mon, cons

Re: [Qemu-devel] Cirrus VGA slow screen update, show blank screen last 13s or so for windows XP guest

2013-07-25 Thread Anthony Liguori
On Thu, Jul 25, 2013 at 10:08 PM, Gonglei (Arei) wrote: >> -Original Message- >> From: Anthony Liguori [mailto:anth...@codemonkey.ws] >> Sent: Friday, July 26, 2013 10:09 AM >> To: Gonglei (Arei) >> Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; Hanweidong; >> Luonengjun; Huangweidon

Re: [Qemu-devel] [PATCH qom-next for-1.6 03/14] etraxfs_ser: QOM'ify

2013-07-25 Thread Edgar E. Iglesias
On Wed, Jul 24, 2013 at 11:42:08PM +0200, Andreas Färber wrote: > Rename etrax_serial to ETRAXSerial, introduce type constant and use QOM > casts. Acked-by: Edgar E. Iglesias > > Signed-off-by: Andreas Färber > --- > hw/char/etraxfs_ser.c | 37 + > 1 fi

[Qemu-devel] [RESEND][PATCH v2] cpu: Correct cpu-hotplug failure

2013-07-25 Thread Chen Fan
This regression is caused by commit c643bed99. When using x86_64-softmmu --enable-kvm boot qemu, cpu-add command fails to add a vcpu, there show (KVM: setting VAPIC address failed), but at boot, there is no problem. The reason for this is: in hotplug case it uses an uninitialized vcpu to set ap

Re: [Qemu-devel] Cirrus VGA slow screen update, show blank screen last 13s or so for windows XP guest

2013-07-25 Thread Gonglei (Arei)
> -Original Message- > From: Anthony Liguori [mailto:anth...@codemonkey.ws] > Sent: Friday, July 26, 2013 10:09 AM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; Hanweidong; > Luonengjun; Huangweidong (Hardware) > Subject: Re: [Qemu-devel] Cirrus VGA slow screen

Re: [Qemu-devel] [PATCH V3 for-1.6 3/5] block: Add support for throttling burst threshold in QMP and the command line.

2013-07-25 Thread Fam Zheng
On Tue, 07/23 18:29, Benoît Canet wrote: > The thresholds of the leaky bucket algorithm can be used to allow some > burstiness. > > Signed-off-by: Benoit Canet > --- > block/qapi.c | 24 + > blockdev.c | 105 > +++--- > hm

Re: [Qemu-devel] [PATCH qom-next for-1.6 14/14] xilinx_uartlite: QOM'ify

2013-07-25 Thread Edgar E. Iglesias
On Wed, Jul 24, 2013 at 11:42:19PM +0200, Andreas Färber wrote: > Signed-off-by: Andreas Färber Acked-by: Edgar E. Iglesias > --- > hw/char/xilinx_uartlite.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/hw/char/xilinx_uartlite.c b/hw/char/xilinx_uartli

Re: [Qemu-devel] [PATCH qom-next for-1.6 0/8] display: QOM cast cleanups

2013-07-25 Thread Hu Tao
On Thu, Jul 25, 2013 at 01:16:44AM +0200, Andreas Färber wrote: > Hello, > > This series eliminates FROM_SYSBUS() in hw/display/. > > Regards, > Andreas > > Cc: Hu Tao > > Andreas Färber (8): > exynos4210_fimd: QOM cast cleanup > g364fb: QOM cast cleanup > jazz_led: QOM cast cleanups >

Re: [Qemu-devel] [PATCH qom-next for-1.6 13/14] xilinx_uartlite: Rename xlx_uartlite to XilinxUARTLite

2013-07-25 Thread Edgar E. Iglesias
On Wed, Jul 24, 2013 at 11:42:18PM +0200, Andreas Färber wrote: > Signed-off-by: Andreas Färber Acked-by: Edgar E. Iglesias > --- > hw/char/xilinx_uartlite.c | 21 ++--- > 1 file changed, 10 insertions(+), 11 deletions(-) > > diff --git a/hw/char/xilinx_uartlite.c b/hw/char/x

Re: [Qemu-devel] [PATCH v2] cpu: Correct cpu-hotplug failure

2013-07-25 Thread chenfan
On Thu, 2013-07-25 at 12:08 +0200, Igor Mammedov wrote: > On Thu, 25 Jul 2013 17:49:11 +0800 > Chen Fan wrote: > > > v1-v2: Change cpu_apic_realize to post_vcpu_init. > > > > When useing x86_64-softmmu --enable-kvm boot qemu, cpu-add command fails to > > add a vcpu, >^^^ using > > there

Re: [Qemu-devel] [PATCH qom-next for-1.6 7/8] pl110: QOM'ify pl110, pl110_versatile and pl111

2013-07-25 Thread Hu Tao
On Thu, Jul 25, 2013 at 01:16:51AM +0200, Andreas Färber wrote: > Let pl110_versatile and pl111 inherit from pl110 and use PL110() cast; > set their version index in an instance_init. > > Signed-off-by: Andreas Färber > --- > hw/display/pl110.c | 71 > ++-

Re: [Qemu-devel] [PATCH V3 for-1.6 5/5] block: Add throttling percentage metrics.

2013-07-25 Thread Fam Zheng
On Tue, 07/23 18:29, Benoît Canet wrote: > This metrics show how many percent of the time I/Os are put on hold by the > throttling algorithm. > This metric could be used by system administrators or cloud stack developpers > to decide when the throttling settings must be changed. > > Signed-off-by:

Re: [Qemu-devel] [PATCH 0/4] export internal snapshot by qemu-nbd

2013-07-25 Thread Wenchao Xia
于 2013-7-25 16:06, Stefan Hajnoczi 写道: On Thu, Jul 25, 2013 at 10:30:49AM +0800, Wenchao Xia wrote: Besides the argument, I think it helps to probe snapshot without qemu-img convert, hope to get comments for the code. Hi Wenchao, Which patch are you referring to? Stefan This series, wh

Re: [Qemu-devel] [PATCH qom-next for-1.6 2/2] arm11mpcore: QOM cast cleanups for mpcore_rirq_state

2013-07-25 Thread Hu Tao
On Thu, Jul 25, 2013 at 12:17:00AM +0200, Andreas Färber wrote: > Signed-off-by: Andreas Färber > --- > hw/cpu/arm11mpcore.c | 20 +--- > 1 file changed, 13 insertions(+), 7 deletions(-) Reviewed-by: Hu Tao

Re: [Qemu-devel] [PATCH qom-next for-1.6 1/2] arm11mpcore: QOM cast cleanups for ARM11MPCorePriveState

2013-07-25 Thread Hu Tao
On Thu, Jul 25, 2013 at 12:16:59AM +0200, Andreas Färber wrote: > Signed-off-by: Andreas Färber > --- > hw/cpu/arm11mpcore.c | 22 ++ > 1 file changed, 14 insertions(+), 8 deletions(-) Reviewed-by: Hu Tao

[Qemu-devel] [Bug 1205156] [NEW] Errors while compiling version 1.5.2

2013-07-25 Thread jean-christophe manciot
Public bug reported: Environment: Ubuntu 13.04 "hw/ide/macio.c: In function ‘pmac_ide_atapi_transfer_cb’: hw/ide/macio.c:134:9: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘hwaddr’ [-Werror=format] hw/ide/macio.c: In function ‘pmac_ide_transfer_cb’:

Re: [Qemu-devel] Cirrus VGA slow screen update, show blank screen last 13s or so for windows XP guest

2013-07-25 Thread Anthony Liguori
Windows XP uses VGA planar mode during boot up. This means that to set a pixel requires 3 MMIO operations (one for the red pixel, one for the green pixel, one for the blue pixel). KVM has an optimization called MMIO coalescing which avoids a heavy weight exit for planar mode exits. I guess Xen

Re: [Qemu-devel] [Xen-devel] Cirrus VGA slow screen update, show blank screen last 13s or so for windows XP guest

2013-07-25 Thread Gonglei (Arei)
> >> Il 25/07/2013 15:13, Gonglei (Arei) ha scritto: > >>> Hi, > >>> I found a problem: For windows XP guest booting by qemu upstream, > >>> using the RDP(Remote Desktop Protocol) and VNC protocol to connect the > >> windows XP guest > >>> which booting by Qemu upstream respectively. the VNC

Re: [Qemu-devel] [PATCH 3/8] block: implement reference count for BlockDriverState

2013-07-25 Thread Fam Zheng
On Thu, 07/25 21:50, Jeff Cody wrote: > On Fri, Jul 26, 2013 at 09:13:32AM +0800, Fam Zheng wrote: > > On Thu, 07/25 09:15, Jeff Cody wrote: > > > On Thu, Jul 25, 2013 at 05:01:41PM +0800, Fam Zheng wrote: > > > > Introduce bdrv_ref/bdrv_unref to manage the lifecycle of > > > > BlockDriverState. Th

Re: [Qemu-devel] [PATCH 3/8] block: implement reference count for BlockDriverState

2013-07-25 Thread Jeff Cody
On Fri, Jul 26, 2013 at 09:13:32AM +0800, Fam Zheng wrote: > On Thu, 07/25 09:15, Jeff Cody wrote: > > On Thu, Jul 25, 2013 at 05:01:41PM +0800, Fam Zheng wrote: > > > Introduce bdrv_ref/bdrv_unref to manage the lifecycle of > > > BlockDriverState. They are unused for now but will used to replace >

Re: [Qemu-devel] [PATCH 7/8] xen_disk: simplify blk_disconnect with refcnt

2013-07-25 Thread Jeff Cody
On Thu, Jul 25, 2013 at 08:56:41AM -0400, Jeff Cody wrote: > On Thu, Jul 25, 2013 at 05:01:45PM +0800, Fam Zheng wrote: > > We call bdrv_attach_dev when initializing whether or not bs is created > > locally, so call bdrv_detach_dev and let the refcnt handle the > > lifecycle. > > > > Signed-off-by

Re: [Qemu-devel] [PATCH 8/8] nbd: use BlockDriverState refcnt

2013-07-25 Thread Jeff Cody
On Thu, Jul 25, 2013 at 09:01:41AM -0400, Jeff Cody wrote: > On Thu, Jul 25, 2013 at 05:01:46PM +0800, Fam Zheng wrote: > > Previously, nbd calls drive_get_ref() on the drive of bs. A BDS doesn't > > always have associated dinfo, which nbd doesn't care either. We already > > have BDS ref count, so

Re: [Qemu-devel] [PATCH 3/8] block: implement reference count for BlockDriverState

2013-07-25 Thread Fam Zheng
On Thu, 07/25 09:15, Jeff Cody wrote: > On Thu, Jul 25, 2013 at 05:01:41PM +0800, Fam Zheng wrote: > > Introduce bdrv_ref/bdrv_unref to manage the lifecycle of > > BlockDriverState. They are unused for now but will used to replace > > bdrv_delete() later. > > > > Signed-off-by: Fam Zheng > > ---

[Qemu-devel] [PATCH V7 0/2] Implement sync modes for drive-backup.

2013-07-25 Thread Ian Main
This patch adds sync modes on top of the work that Stefan Hajnoczi has done. These patches apply on kevin/block. Hopefully all is in order as this is my first QEMU patch. Many thanks to Stephan and Fam Zheng for their help. V2: - No longer poll, instead use qemu_coroutine_yield(). - Use bdrv_c

[Qemu-devel] [PATCH V7 1/2] Implement sync modes for drive-backup.

2013-07-25 Thread Ian Main
This patch adds sync-modes to the drive-backup interface and implements the FULL, NONE and TOP modes of synchronization. FULL performs as before copying the entire contents of the drive while preserving the point-in-time using CoW. NONE only copies new writes to the target drive. TOP copies change

[Qemu-devel] [PATCH V7 2/2] Add tests for sync modes 'TOP' and 'NONE'

2013-07-25 Thread Ian Main
This patch adds tests for sync modes top and none. Test for 'TOP' is separated out as it requires a backing file. Also added a test for invalid format. Signed-off-by: Ian Main --- tests/qemu-iotests/055| 26 +-- tests/qemu-iotests/055.out| 4 +-- tests/qemu-iotests/056

[Qemu-devel] [Bug 1204697] Re: guest disk accesses lead to ATA errors + host vcpu0 unhandled wrmsr/rdmsr

2013-07-25 Thread Bug Watch Updater
** Changed in: qemu (Debian) Status: Incomplete => Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1204697 Title: guest disk accesses lead to ATA errors + host vcpu0 unhandled wrms

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 1/5] linker: utility to patch in-memory ROM files

2013-07-25 Thread Kevin O'Connor
On Thu, Jul 25, 2013 at 03:55:56PM +0300, Michael S. Tsirkin wrote: > On Mon, Jul 15, 2013 at 11:01:02AM +0300, Michael S. Tsirkin wrote: > > On Sun, Jul 14, 2013 at 02:24:52PM -0400, Kevin O'Connor wrote: > > > I'd prefer to see this tracked within the "linker" code and not in the > > > generic ro

Re: [Qemu-devel] [PATCH 1/2] hw/virtio/virtio: Don't allow guests to add/remove queues

2013-07-25 Thread Michael S. Tsirkin
On Thu, Jul 25, 2013 at 11:37:22PM +0100, Peter Maydell wrote: > On 25 July 2013 23:33, Michael S. Tsirkin wrote: > > On Thu, Jul 25, 2013 at 02:37:42PM +0100, Peter Maydell wrote: > >> A queue size of 0 is used to indicate a nonexistent queue, so > >> don't allow the guest to flip a queue between

Re: [Qemu-devel] [PATCH 04/18] qapi-visit.py: Implement 'base' for unions

2013-07-25 Thread Eric Blake
On 07/23/2013 07:03 AM, Kevin Wolf wrote: > This implements the visitor part of base types for unions. Parsed into > QMP, this example schema definiton... s/definiton/definition/ > > { 'type': 'BlockOptionsBase', 'data': { 'read-only': 'bool' } } > { 'type': 'BlockOptionsQcow2, 'data': {

Re: [Qemu-devel] [PATCH v8 03/10] checkpatch.pl: Check .cpp files

2013-07-25 Thread Michael Roth
Quoting Tomoki Sekiyama (2013-07-23 17:45:39) > Enable checkpatch.pl to apply the same checks as C source files for > C++ files with .cpp extensions. It also adds some exceptions for C++ > sources to suppress errors for: > - <> used in C++ template arguments (e.g. template ) > - :: used to repr

Re: [Qemu-devel] [PATCH 03/18] qapi-visit.py: Split off generate_visit_struct_fields()

2013-07-25 Thread Eric Blake
On 07/23/2013 07:03 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > scripts/qapi-visit.py | 62 > --- > 1 file changed, 34 insertions(+), 28 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266

Re: [Qemu-devel] [PATCH 02/18] qapi-types.py: Implement 'base' for unions

2013-07-25 Thread Eric Blake
On 07/23/2013 07:03 AM, Kevin Wolf wrote: > The new 'base' key in a union definition refers to a struct type, which > is inlined into the union definition and can represent fields common to > all kinds. > > For example the following schema definition... > > { 'type': 'BlockOptionsBase', 'data

Re: [Qemu-devel] [PATCH 01/18] qapi-types.py: Split off generate_struct_fields()

2013-07-25 Thread Eric Blake
On 07/23/2013 07:03 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > scripts/qapi-types.py | 19 +-- > 1 file changed, 13 insertions(+), 6 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://l

Re: [Qemu-devel] [PATCH v8 01/10] configure: Support configuring C++ compiler

2013-07-25 Thread Michael Roth
Quoting Tomoki Sekiyama (2013-07-23 17:45:31) > Add configuration for C++ compiler in configure and Makefiles. > The C++ compiler is choosed as following: > - ${CXX}, if it is specified. > - ${cross_prefix}g++, if ${cross_prefix} is specified. > - Otherwise, c++ is used. > > Currently, usage of

[Qemu-devel] [RFC] [PATCHv3 10/12] aio / timers: on timer modification, qemu_notify or aio_notify

2013-07-25 Thread Alex Bligh
On qemu_clock_enable or qemu_mod_timer_ns, ensure qemu_notify or aio_notify is called to end the appropriate poll(). Signed-off-by: Alex Bligh --- qemu-timer.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 6efd1b4..a0cbeaa

[Qemu-devel] [RFC] [PATCHv3 09/12] aio / timers: convert mainloop to use timeout

2013-07-25 Thread Alex Bligh
Convert mainloop to use timeout from 3 static timers. Signed-off-by: Alex Bligh --- main-loop.c | 48 +--- 1 file changed, 37 insertions(+), 11 deletions(-) diff --git a/main-loop.c b/main-loop.c index a44fff6..c30978b 100644 --- a/main-loop.c +++ b

Re: [Qemu-devel] [PATCH 1/2] hw/virtio/virtio: Don't allow guests to add/remove queues

2013-07-25 Thread Peter Maydell
On 25 July 2013 23:33, Michael S. Tsirkin wrote: > On Thu, Jul 25, 2013 at 02:37:42PM +0100, Peter Maydell wrote: >> A queue size of 0 is used to indicate a nonexistent queue, so >> don't allow the guest to flip a queue between zero-size and >> non-zero-size. Don't permit setting of negative queue

Re: [Qemu-devel] [PATCH 2/2] hw/virtio/virtio-mmio: Make QueueNumMax read 0 for unavailable queues

2013-07-25 Thread Peter Maydell
On 25 July 2013 23:34, Michael S. Tsirkin wrote: > On Thu, Jul 25, 2013 at 02:37:43PM +0100, Peter Maydell wrote: >> case VIRTIO_MMIO_QUEUENUMMAX: >> +if (virtio_queue_get_num(vdev, vdev->queue_sel) == 0) { >> +return 0; >> +} > > All other callers do: >if

Re: [Qemu-devel] [RFC] [PATCHv3 00/12] aio / timers: Add AioContext timers and use ppoll

2013-07-25 Thread Alex Bligh
--On 25 July 2013 23:16:36 +0100 Alex Bligh wrote: * change comment in deprecation of clock options This got missed due to my own inadequacy. Delta is below. It will be in the next series. -- Alex Bligh commit 699c55b421822ad2d14b5520b04db8fa9f77c4e0 Author: Alex Bligh Date: Thu Jul 25

[Qemu-devel] [RFC] [PATCHv3 00/12] aio / timers: Add AioContext timers and use ppoll

2013-07-25 Thread Alex Bligh
This patch series adds support for timers attached to an AioContext clock which get called within aio_poll. In doing so it removes alarm timers and moves to use ppoll where possible. This patch set 'sort of' passes make check (see below for caveat) including a new test harness for the aio timers,

Re: [Qemu-devel] [PATCH 2/2] hw/virtio/virtio-mmio: Make QueueNumMax read 0 for unavailable queues

2013-07-25 Thread Michael S. Tsirkin
On Thu, Jul 25, 2013 at 02:37:43PM +0100, Peter Maydell wrote: > The virtio-mmio spec says that QueueNumMax must read zero for queues > which are unavailable; implement this, rather than always returning > VIRTQUEUE_MAX_SIZE. > > Signed-off-by: Peter Maydell > --- > hw/virtio/virtio-mmio.c |

Re: [Qemu-devel] [PATCH 1/2] hw/virtio/virtio: Don't allow guests to add/remove queues

2013-07-25 Thread Michael S. Tsirkin
On Thu, Jul 25, 2013 at 02:37:42PM +0100, Peter Maydell wrote: > A queue size of 0 is used to indicate a nonexistent queue, so > don't allow the guest to flip a queue between zero-size and > non-zero-size. Don't permit setting of negative queue sizes > either. > > Signed-off-by: Peter Maydell > -

[Qemu-devel] [RFC] [PATCHv3 03/12] aio / timers: Add prctl(PR_SET_TIMERSLACK, 1, ...) to reduce timer slack

2013-07-25 Thread Alex Bligh
Where supported, called prctl(PR_SET_TIMERSLACK, 1, ...) to set one nanosecond timer slack to increase precision of timer calls. Signed-off-by: Alex Bligh --- configure| 18 ++ qemu-timer.c |7 +++ 2 files changed, 25 insertions(+) diff --git a/configure b/configur

[Qemu-devel] [RFC] [PATCHv3 08/12] aio / timers: Convert aio_poll to use AioContext timers' deadline

2013-07-25 Thread Alex Bligh
Convert aio_poll to use deadline based on AioContext's timers. Signed-off-by: Alex Bligh --- aio-posix.c | 20 +--- aio-win32.c | 22 +++--- 2 files changed, 32 insertions(+), 10 deletions(-) diff --git a/aio-posix.c b/aio-posix.c index b68eccd..fe12022 10064

[Qemu-devel] [RFC] [PATCHv3 04/12] aio / timers: Make qemu_run_timers and qemu_run_all_timers return progress

2013-07-25 Thread Alex Bligh
Make qemu_run_timers and qemu_run_all_timers return progress so that aio_poll etc. can determine whether a timer has been run. Signed-off-by: Alex Bligh --- include/qemu/timer.h |4 ++-- qemu-timer.c | 18 -- 2 files changed, 14 insertions(+), 8 deletions(-) diff -

[Qemu-devel] [RFC] [PATCHv3 11/12] aio / timers: Remove alarm timers

2013-07-25 Thread Alex Bligh
Remove alarm timers from qemu-timers.c now we use g_poll / ppoll instead. Signed-off-by: Alex Bligh --- include/qemu/timer.h |2 - main-loop.c |4 - qemu-timer.c | 501 +- vl.c |5 +- 4 files changed, 8

[Qemu-devel] [RFC] [PATCHv3 07/12] aio / timers: aio_ctx_prepare sets timeout from AioContext timers

2013-07-25 Thread Alex Bligh
Calculate the timeout in aio_ctx_prepare taking into account the timers attached to the AioContext. Alter aio_ctx_check similarly. Signed-off-by: Alex Bligh --- async.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/async.c b/async.c index 2968c68..a62c463

[Qemu-devel] [RFC] [PATCHv3 12/12] aio / timers: Add test harness for AioContext timers

2013-07-25 Thread Alex Bligh
Add a test harness for AioContext timers. The g_source equivalent is unsatisfactory as it suffers from false wakeups. Signed-off-by: Alex Bligh --- tests/test-aio.c | 122 ++ 1 file changed, 122 insertions(+) diff --git a/tests/test-aio.c b/t

[Qemu-devel] [RFC] [PATCHv3 02/12] aio / timers: add ppoll support with qemu_poll_ns

2013-07-25 Thread Alex Bligh
Add qemu_poll_ns which works like g_poll but takes a nanosecond timeout. Signed-off-by: Alex Bligh --- configure| 19 +++ include/qemu/timer.h |1 + qemu-timer.c | 24 3 files changed, 44 insertions(+) diff --git a/configure b

[Qemu-devel] [RFC] [PATCHv3 06/12] aio / timers: Add an AioContext pointer to QEMUClock

2013-07-25 Thread Alex Bligh
Add an AioContext pointer to QEMUClock so it knows what to notify on a timer change. Signed-off-by: Alex Bligh --- async.c |1 + include/qemu/timer.h |3 +++ qemu-timer.c | 12 3 files changed, 16 insertions(+) diff --git a/async.c b/async.c index 0d4

[Qemu-devel] [RFC] [PATCHv3 01/12] aio / timers: add qemu-timer.c utility functions

2013-07-25 Thread Alex Bligh
Add qemu_free_clock and expose qemu_new_clock and clock types. Add utility functions to qemu-timer.c for nanosecond timing. Add qemu_clock_deadline_ns to calculate deadlines to nanosecond accuracy. Add utility function qemu_soonest_timeout to calculate soonest deadline. Add qemu_timeout_ns_to_m

[Qemu-devel] [RFC] [PATCHv3 05/12] aio / timers: Add a clock to AioContext

2013-07-25 Thread Alex Bligh
Add a clock to each AioContext and delete it when freed. Signed-off-by: Alex Bligh --- async.c |2 ++ include/block/aio.h |5 + 2 files changed, 7 insertions(+) diff --git a/async.c b/async.c index 90fe906..0d41431 100644 --- a/async.c +++ b/async.c @@ -177,6 +177,7 @@ a

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.5.2 Stable released

2013-07-25 Thread Laszlo Ersek
On 07/25/13 23:44, Michael Roth wrote: > The QEMU v1.5.2 stable release is now available at: > > http://wiki.qemu.org/download/qemu-1.5.2.tar.bz2 > > This is release is solely to address a security issue (CVE-2013-2231) found > in the QEMU Guest Agent on Windows. More details on the nature of t

[Qemu-devel] [ANNOUNCE] QEMU 1.5.2 Stable released

2013-07-25 Thread Michael Roth
The QEMU v1.5.2 stable release is now available at: http://wiki.qemu.org/download/qemu-1.5.2.tar.bz2 This is release is solely to address a security issue (CVE-2013-2231) found in the QEMU Guest Agent on Windows. More details on the nature of the CVE can be found here: http://seclists.org/oss-

Re: [Qemu-devel] [PATCH qom-next v2 4/4] pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types

2013-07-25 Thread Michael S. Tsirkin
On Tue, Jul 23, 2013 at 12:36:08AM +0200, Andreas Färber wrote: > Move PCIEPort's "port" property to the new type, same for "aer_log_max". > Move PCIESlot's "chassis" and "slot" properties to the new type. > > Signed-off-by: Andreas Färber > --- > hw/pci-bridge/ioh3420.c| 31 ++--

[Qemu-devel] [PATCH 11/12] migration-local: add option to commandline for incoming-local

2013-07-25 Thread Lei Li
Signed-off-by: Lei Li --- qemu-options.hx |9 + vl.c| 14 ++ 2 files changed, 23 insertions(+), 0 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 8355f9b..a975e83 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2912,6 +2912,15 @@ STE

Re: [Qemu-devel] [PATCH qom-next v2 1/4] pci-bridge: Turn PCIBridge into abstract QOM type

2013-07-25 Thread Michael S. Tsirkin
On Tue, Jul 23, 2013 at 12:36:05AM +0200, Andreas Färber wrote: > Introduce TYPE_PCI_BRIDGE as base type and use PCI_BRIDGE() casts. > > Signed-off-by: Andreas Färber > --- > hw/pci-bridge/dec.c| 4 ++-- > hw/pci-bridge/i82801b11.c | 6 +++--- > hw/pci-bridge/ioh3420.c

[Qemu-devel] [PATCH 06/12] arch_init: add save_local_setup to savevm_ram_handlers

2013-07-25 Thread Lei Li
Signed-off-by: Lei Li --- arch_init.c |1 + include/migration/vmstate.h |2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/arch_init.c b/arch_init.c index 7eeb52f..5c25005 100644 --- a/arch_init.c +++ b/arch_init.c @@ -973,6 +973,7 @@ SaveVMHandlers save

[Qemu-devel] [PATCH 01/12] migration: export MIG_STATE_xxx flags

2013-07-25 Thread Lei Li
Signed-off-by: Lei Li --- include/migration/migration.h |9 + migration.c |8 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/include/migration/migration.h b/include/migration/migration.h index e2acec6..a821c80 100644 --- a/include/migrati

Re: [Qemu-devel] [PATCH qom-next v2 4/4] pcie_port: Turn PCIEPort and PCIESlot into abstract QOM types

2013-07-25 Thread Don Koch
On 07/22/2013 06:36 PM, Andreas Färber wrote: > Move PCIEPort's "port" property to the new type, same for "aer_log_max". > Move PCIESlot's "chassis" and "slot" properties to the new type. > > Signed-off-by: Andreas Färber > --- > hw/pci-bridge/ioh3420.c| 31 ++- >

[Qemu-devel] [PATCH 09/12] migration-local: implementation of outgoing part

2013-07-25 Thread Lei Li
Signed-off-by: Lei Li --- Makefile.objs |1 + include/migration/migration.h | 15 migration-local.c | 158 + migration-unix.c | 13 qapi-schema.json | 14 qmp-commands.hx

[Qemu-devel] [PATCH 1/3] qga/service-win32.c: diagnostic output should go to stderr

2013-07-25 Thread Michael Roth
From: Laszlo Ersek Acked-by: Michael Roth Reviewed-by: Eric Blake Signed-off-by: Laszlo Ersek Signed-off-by: Michael Roth --- qga/service-win32.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/qga/service-win32.c b/qga/service-win32.c index 02926ab..6de8be4 1006

  1   2   3   4   >