Re: [Qemu-devel] [PATCH v2 3/4] ide: Set BSY bit during FLUSH

2013-07-09 Thread Michael S. Tsirkin
On Thu, Jul 04, 2013 at 09:55:42AM +0200, Kevin Wolf wrote: > Am 03.07.2013 um 22:02 hat Alex Williamson geschrieben: > > On Wed, 2013-06-05 at 15:17 +0200, Kevin Wolf wrote: > > > From: Andreas Färber > > > > > > The implementation of the ATA FLUSH command invokes a flush at the block > > > laye

Re: [Qemu-devel] [PATCH V5 7/7] monitor: improve "help" to allow show details of single command in sub group

2013-07-09 Thread Wenchao Xia
于 2013-7-9 0:17, Luiz Capitulino 写道: On Sat, 29 Jun 2013 11:53:01 +0800 Wenchao Xia wrote: A new parameter type 'S' is introduced to allow user input any string. "help info block" do not tip extra parameter error now. Signed-off-by: Wenchao Xia --- hmp-commands.hx |2 +- monitor.c

Re: [Qemu-devel] [PATCH V5 6/7] monitor: improve "help" in auto completion for sub command

2013-07-09 Thread Wenchao Xia
于 2013-7-9 0:09, Luiz Capitulino 写道: On Sat, 29 Jun 2013 11:53:00 +0800 Wenchao Xia wrote: Now special case "help *" in auto completion can work with sub commands, such as "help info a*". The auto-completion works, but the command is still refused: (qemu) help info u usb usbhost use

Re: [Qemu-devel] [PATCH V5 4/7] monitor: avoid direct use of global *info_cmds in help functions

2013-07-09 Thread Wenchao Xia
于 2013-7-8 23:45, Luiz Capitulino 写道: On Sat, 29 Jun 2013 11:52:58 +0800 Wenchao Xia wrote: In help functions info_cmds is treated as sub command group now, not as a special case any more. Still help can't show message for single command under "info", since command parser reject additional par

Re: [Qemu-devel] [PATCH 18/19] target-ppc: Enhance the CPU node labels for the guest device tree for pseries.

2013-07-09 Thread Prerna Saxena
Hi Andreas, Thanks for the response. On 07/08/2013 10:15 PM, Andreas Färber wrote: > Hi, > > Am 08.07.2013 17:49, schrieb Prerna Saxena: >> On 07/08/2013 02:32 PM, Andreas Färber wrote: >>> -BEGIN PGP SIGNED MESSAGE- >>> Hash: SHA1 >>> >>> Am 08.07.2013 03:09, schrieb David Gibson: O

Re: [Qemu-devel] [PATCH V5 1/7] monitor: avoid direct use of global *cur_mon in completion functions

2013-07-09 Thread Wenchao Xia
于 2013-7-9 22:14, Luiz Capitulino 写道: On Tue, 09 Jul 2013 22:03:42 +0800 Wenchao Xia wrote: You could pass cur_mon to readline_completion() in readline_handle_byte() to avoid all this, but it would be preferable to clarify the matter. This is also another benefit of having readline_completi

Re: [Qemu-devel] [PATCH v1 1/1] qom: Fix class cast of NULL classes

2013-07-09 Thread Peter Crosthwaite
Ping! On Tue, Jun 18, 2013 at 7:18 PM, wrote: > From: Peter Crosthwaite > > Its clear from the implementation that class casting is supposed to work > with a NULL class argument. Guard all dereferences of the class argument > against NULL accordingly. > > Signed-off-by: Peter Crosthwaite > ---

[Qemu-devel] [PATCH arm-devs v1 2/2] cpu/a9mpcore: Add Global Timer

2013-07-09 Thread peter . crosthwaite
From: Peter Crosthwaite Add the global timer to A9 MPCore. Signed-off-by: Peter Crosthwaite --- This is From Francois LEGALs original patch (never had it as git patch so has my authorship). Whats the protocol here? Francois can you ack this? This will likely conflict with Andreas' MPCore work

[Qemu-devel] [PATCH arm-devs v1 1/2] hw/timer: Introduce ARM A9 Global Timer.

2013-07-09 Thread peter . crosthwaite
From: Peter Crosthwaite The ARM A9 MPCore has a timer that is global to all CPUs in the mpcore. The timer is shared but each CPU has a private independent comparator and interrupt. Original version contributed by Francois LEGAL. Signed-off-by: Peter Crosthwaite --- Francois, do you want to re-

Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE

2013-07-09 Thread Michael Tokarev
10.07.2013 08:45, Michael Tokarev wrote: [] > Besides, -- I just noticed -- we're discussing a V1 of this patch, > while I already sent a v3, -- it has a much more appropriate logic > for the Ctrl+C handling. The only issue I see with it is the make > check breakage which is easy to fix by s/==0/=

Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE

2013-07-09 Thread Michael Tokarev
10.07.2013 01:24, Anthony Liguori wrote: > Peter Maydell writes: > >> On 9 July 2013 21:45, Anthony Liguori wrote: >>> Michael Tokarev writes: 09.07.2013 22:37, Anthony Liguori wrote: > ERROR:/home/aliguori/git/qemu/tests/fw_cfg-test.c:63:test_fw_cfg_nographic: > assertion failed

[Qemu-devel] [PATCH v1 4/4] target-arm: Add CP15 VBAR support

2013-07-09 Thread peter . crosthwaite
From: Nathan Rossi Added Vector Base Address remapping on ARM v7. Signed-off-by: Nathan Rossi Signed-off-by: Peter Crosthwaite --- changed since v1: Removed obsolete VMSD logic (rebase) Forced lower 5 bits of VBAR ro 0 (PMM review) Simplified if-else logic to not worry about pre-v7 (PMM review

[Qemu-devel] [PATCH v1 2/4] target-arm/helper.c: Implement MIDR aliases

2013-07-09 Thread peter . crosthwaite
From: Peter Crosthwaite Unimplemented registers in the cp15, CRn=0, opc1=0, CRm=0 space default to aliasing the MIDR register. Set all registers in the space to access MIDR by default. Signed-off-by: Peter Crosthwaite --- target-arm/helper.c | 16 +++- 1 file changed, 11 insertion

[Qemu-devel] [PATCH v1 3/4] target-arm/helper.c: Allow const opaques in arm CP

2013-07-09 Thread peter . crosthwaite
From: Peter Crosthwaite Allow for defining const opaque data in ARM CP register definitions by setting .opaque = foo. If non null opaque is passes into define_one_arm_cp_reg_with_opaque then that opaque will take precedence, otherwise if null opaque is passed, the original opaque data will be use

[Qemu-devel] [PATCH v1 1/4] target-arm/helper.c: OMAP/StrongARM cp15 crn=0 cleanup

2013-07-09 Thread peter . crosthwaite
From: Peter Crosthwaite The if block detecting OMAP/StrongARM modifies the id_cp_reginfo .access fields in place. So there is no need to replicate the call to define_arm_cp_reg(). Dropped, and let the OMAP case fall through to the normal behaviour after the in-place modification. Signed-off-by:

[Qemu-devel] [PATCH v1 0/4] Petercs target-arm queue

2013-07-09 Thread peter . crosthwaite
From: Peter Crosthwaite Hi Peter, Heres is a mixed bag of target-arm patches from my tree. They are independent of each other and only threaded together for review convenience. Regards, Peter Nathan Rossi (1): target-arm: Add CP15 VBAR support Peter Crosthwaite (3): target-arm/helper.c:

Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE

2013-07-09 Thread Michael Tokarev
10.07.2013 00:45, Anthony Liguori wrote: > Michael Tokarev writes: > >> 09.07.2013 22:37, Anthony Liguori wrote: >>> Michael Tokarev writes: >>> It looks like initially there was -nographic option to turn off display, now there's another option of the same sort, -display none. Bu

Re: [Qemu-devel] [Qemu-ppc] Mac OS X on QEMU

2013-07-09 Thread Programmingkid
On Jul 9, 2013, at 1:32 PM, Scott Wood wrote: > On 07/04/2013 09:58:04 AM, Programmingkid wrote: >> On Jul 4, 2013, at 10:51 AM, Stefan Hajnoczi wrote: >> > On Thu, Jul 4, 2013 at 4:45 PM, Alexander Graf wrote: >> >> >> >> On 04.07.2013, at 16:40, Programmingkid wrote: >> >> >> >>> We have made

Re: [Qemu-devel] [PATCH 04/17] target-ppc: Convert ppc cpu savevm to VMStateDescription

2013-07-09 Thread Benjamin Herrenschmidt
On Wed, 2013-07-10 at 01:11 +1000, David Gibson wrote: > More precisely, DCRs are only needed on the BookE CPUs which have > them. They can be added later without breaking compatibility, and > would be best added by someone working on the BookE stuff who can test > it properly. DCRs are also not

Re: [Qemu-devel] [PATCH 02/17] pseries: rework XICS

2013-07-09 Thread Benjamin Herrenschmidt
On Tue, 2013-07-09 at 08:58 -0500, Anthony Liguori wrote: > There's nothing gross about making the things that are devices > devices. But there is no such thing as the XICS ... The "XICS" is just the combination of ICP's and ICS... so XICS *is* the device... Cheers, Ben.

Re: [Qemu-devel] [PATCH 14/17] pseries: Support for in-kernel XICS interrupt controller

2013-07-09 Thread Benjamin Herrenschmidt
On Tue, 2013-07-09 at 17:21 +1000, David Gibson wrote: > > Did you mean missing typedef? > > I think he means the kernel_style_struct_name instead of the > QemuStyleStudlyCapsStructName. Looks like we missed the mandatory MakeCodeFugly rule of qemu :-) Cheers, Ben.

Re: [Qemu-devel] [PATCH 02/17] pseries: rework XICS

2013-07-09 Thread Alexey Kardashevskiy
On 07/09/2013 11:58 PM, Anthony Liguori wrote: > Benjamin Herrenschmidt writes: > >> On Tue, 2013-07-09 at 13:40 +1000, Alexey Kardashevskiy wrote: >>> No, why? It is a per CPU state of XICS controller, never exists apart >>> from XICS. >> >> ICP is. ICS is ... different but can mostly be consid

Re: [Qemu-devel] [PATCH 5/7] microblaze: Fix latent bug with default DTB lookup

2013-07-09 Thread Peter Crosthwaite
On Thu, Jul 4, 2013 at 11:09 PM, Markus Armbruster wrote: > microblaze_load_kernel() fails to call > qemu_find_file(QEMU_FILE_TYPE_BIOS, dtb_filename) when no -machine > options are given. This can't normally happen, because -machine > option kernel is mandatory for this target. Fix it anyway, b

Re: [Qemu-devel] virtio indirect with lots of descriptors

2013-07-09 Thread Rusty Russell
Dave Airlie writes: > Hi Rusty, > > playing with my virtio gpu, I started hitting the qemu > error_report("Too many read descriptors in indirect table"); > > Now I'm not sure but this doesn't seem to be a virtio limit that the > guest catches from what I can see, since my host dies quite quickly,

Re: [Qemu-devel] [PATCH qom-cpu v3 30/41] target-openrisc: Move cpu_gdb_{read, write}_register()

2013-07-09 Thread Jia Liu
Hi Andreas, On Wed, Jul 10, 2013 at 6:23 AM, Andreas Färber wrote: > > Signed-off-by: Andreas Färber > --- > gdbstub.c | 57 +-- > target-openrisc/gdbstub.c | 77 > +++ > 2 files changed, 78 insertions

Re: [Qemu-devel] [PATCH 6/9] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-07-09 Thread Asias He
On Fri, Jul 05, 2013 at 07:17:59AM -0400, Vadim Rozenfeld wrote: > Hi Asias, > > Windows driver should be able to support as many logical units and targets > as reported by QEMU. In case of VIRTIO_SCSI_S_BAD_TARGET it will just > propagate > the relevant SRB error code to the port driver. > In an

[Qemu-devel] virtio indirect with lots of descriptors

2013-07-09 Thread Dave Airlie
Hi Rusty, playing with my virtio gpu, I started hitting the qemu error_report("Too many read descriptors in indirect table"); Now I'm not sure but this doesn't seem to be a virtio limit that the guest catches from what I can see, since my host dies quite quickly, when I'm doing transfers in/out o

Re: [Qemu-devel] [PATCH 0/4] alpha-softmmu fixes

2013-07-09 Thread Rob Landley
On 07/08/2013 08:01:08 PM, Richard Henderson wrote: The recent changes for ioport memory regions is a blessing and a curse for the simplified alpha machine model we have. On the one hand, we can eliminate two hacks present in the tsunami system chip emulation. We also now get machine checks whe

Re: [Qemu-devel] [PATCH] Enable async page faults

2013-07-09 Thread Andreas Färber
Am 09.07.2013 17:47, schrieb Dominik Dingel: > S390 can also use async page faults, to enhance guest scheduling. > But in the case of live migration we want to disable the feature and know > if there are still notifications in flight. > > Signed-off-by: Dominik Dingel > --- > target-s390x/kvm.c

[Qemu-devel] [PATCH qom-cpu v3 03/41] target-m68k: Implement CPUClass::set_pc()

2013-07-09 Thread Andreas Färber
This adds support for GDB's c addr (Continue) and s addr (Single Step). Prepares for dropping cpu_pc_from_tb(). Signed-off-by: Andreas Färber --- target-m68k/cpu.c | 8 1 file changed, 8 insertions(+) diff --git a/target-m68k/cpu.c b/target-m68k/cpu.c index 1b6ef66..43011e7 100644 ---

[Qemu-devel] [PATCH qom-cpu v3 30/41] target-openrisc: Move cpu_gdb_{read, write}_register()

2013-07-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c | 57 +-- target-openrisc/gdbstub.c | 77 +++ 2 files changed, 78 insertions(+), 56 deletions(-) create mode 100644 target-openrisc/gdbstub.c diff --git a/gdbs

[Qemu-devel] [PATCH qom-cpu v3 27/41] target-arm: Move cpu_gdb_{read, write}_register()

2013-07-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c| 74 + target-arm/gdbstub.c | 94 2 files changed, 95 insertions(+), 73 deletions(-) create mode 100644 target-arm/gdbstub.c diff --git a/gdbstub.

[Qemu-devel] [PATCH qom-cpu v3 34/41] target-alpha: Move cpu_gdb_{read, write}_register()

2013-07-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c | 66 +- target-alpha/gdbstub.c | 86 ++ 2 files changed, 87 insertions(+), 65 deletions(-) create mode 100644 target-alpha/gdbstub.c diff --git a/gdbstub

[Qemu-devel] [PATCH qom-cpu v3 17/41] gdbstub: Change GDBState::{c, g}_cpu and find_cpu() to CPUState

2013-07-09 Thread Andreas Färber
Use CPUState::env_ptr where still needed. Signed-off-by: Andreas Färber --- gdbstub.c | 104 +++--- 1 file changed, 52 insertions(+), 52 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index 9e017ed..ee31603 100644 --- a/gdbstub.c +++ b/gd

[Qemu-devel] [PATCH qom-cpu v3 13/41] gdbstub: Change gdb_{read, write}_register() argument to CPUState

2013-07-09 Thread Andreas Färber
Use CPUState::env_ptr for now. Prepares for changing GDBState::g_cpu to CPUState. Signed-off-by: Andreas Färber --- gdbstub.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index b65682f..848754d 100644 --- a/gdbstub.c +++ b/gdbstub.c

[Qemu-devel] [PATCH qom-cpu v3 28/41] target-m68k: Move cpu_gdb_{read, write}_register()

2013-07-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c | 47 +--- target-m68k/gdbstub.c | 67 +++ 2 files changed, 68 insertions(+), 46 deletions(-) create mode 100644 target-m68k/gdbstub.c diff --git a/gdbstub.c b

[Qemu-devel] [PATCH qom-cpu v3 07/41] cpu: Move singlestep_enabled field from CPU_COMMON to CPUState

2013-07-09 Thread Andreas Färber
Prepares for changing cpu_single_step() argument to CPUState. Acked-by: Michael Walle (for lm32) Signed-off-by: Andreas Färber --- cpu-exec.c| 2 +- cpus.c| 2 +- exec.c| 10 ++ include/exec/cpu-defs.h | 1 - i

[Qemu-devel] [PATCH qom-cpu v3 15/41] exec: Change cpu_memory_rw_debug() argument to CPUState

2013-07-09 Thread Andreas Färber
Propagate X86CPU in kvmvapic for simplicity. Signed-off-by: Andreas Färber --- cpus.c | 4 +-- disas.c | 4 +-- exec.c | 6 ++-- gdbstub.c | 2 +- hw/i386/kvmvapic.c | 72 +++-

[Qemu-devel] [PATCH qom-cpu v3 20/41] target-xtensa: Introduce XtensaCPU subclasses

2013-07-09 Thread Andreas Färber
Register a CPU type per core registered. Save the XtensaConfig in XtensaCPUClass and copy it from there to CPUXtensaState, to avoid touching every env->config access for now. Prepares for storing per-class GDB register count. Signed-off-by: Andreas Färber --- target-xtensa/cpu-qom.h | 3 +++ t

[Qemu-devel] [PATCH qom-cpu v3 09/41] cpu: Change cpu_single_step() argument to CPUState

2013-07-09 Thread Andreas Färber
Use CPUState::env_ptr for now. Needed for GdbState::c_cpu. Signed-off-by: Andreas Färber --- exec.c | 4 ++-- gdbstub.c | 9 + include/exec/cpu-all.h | 6 -- include/qom/cpu.h | 13 + 4 files changed, 20 insertions(+), 12 deletions(-)

[Qemu-devel] [PATCH qom-cpu v3 16/41] cpu: Introduce CPUClass::memory_rw_debug() for target_memory_rw_debug()

2013-07-09 Thread Andreas Färber
Make inline target_memory_rw_debug() always available and change its argument to CPUState. Let it check if CPUClass::memory_rw_debug provides a specialized callback and fall back to cpu_memory_rw_debug() otherwise. The only overriding implementation is for 32-bit sparc. This prepares for changing

[Qemu-devel] [PATCH qom-cpu v3 39/41] cpu: Introduce CPUClass::gdb_{read, write}_register()

2013-07-09 Thread Andreas Färber
Completes migration of target-specific code to new target-*/gdbstub.c. Acked-by: Michael Walle (for lm32) Signed-off-by: Andreas Färber --- gdbstub.c | 80 - include/exec/gdbstub.h | 8 + include/qom/cpu.h

[Qemu-devel] [PATCH qom-cpu v3 40/41] target-cris: Factor out CPUClass::gdb_read_register() hook for v10

2013-07-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- target-cris/cpu-qom.h | 1 + target-cris/cpu.c | 4 target-cris/gdbstub.c | 10 -- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/target-cris/cpu-qom.h b/target-cris/cpu-qom.h index 3e92ea0..7559366 100644 --- a/target-cris/cpu-

[Qemu-devel] [PATCH qom-cpu v3 37/41] target-xtensa: Move cpu_gdb_{read, write}_register()

2013-07-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c | 80 +- target-xtensa/gdbstub.c | 100 2 files changed, 101 insertions(+), 79 deletions(-) create mode 100644 target-xtensa/gdbstub.c diff --git a/gdb

[Qemu-devel] [PATCH qom-cpu v3 33/41] target-cris: Move cpu_gdb_{read, write}_register()

2013-07-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c | 105 +- target-cris/gdbstub.c | 125 ++ 2 files changed, 126 insertions(+), 104 deletions(-) create mode 100644 target-cris/gdbstub.c diff --git a/gd

[Qemu-devel] [PATCH qom-cpu v3 31/41] target-sh4: Move cpu_gdb_{read, write}_register()

2013-07-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c| 117 +-- target-sh4/gdbstub.c | 137 +++ 2 files changed, 138 insertions(+), 116 deletions(-) create mode 100644 target-sh4/gdbstub.c diff --git a/gdb

[Qemu-devel] [PATCH qom-cpu v3 29/41] target-mips: Move cpu_gdb_{read, write}_register()

2013-07-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c | 124 +-- target-mips/gdbstub.c | 144 ++ 2 files changed, 145 insertions(+), 123 deletions(-) create mode 100644 target-mips/gdbstub.c diff --git a/g

[Qemu-devel] [PATCH qom-cpu v3 14/41] cpu: Turn cpu_get_phys_page_debug() into a CPUClass hook

2013-07-09 Thread Andreas Färber
Change breakpoint_invalidate() argument to CPUState alongside. Since all targets now assign a softmmu-only field, we can drop helpers cpu_class_set_{do_unassigned_access,vmsd}() and device_class_set_vmsd(). Prepares for changing cpu_memory_rw_debug() argument to CPUState. Signed-off-by: Andreas

[Qemu-devel] [PATCH qom-cpu v3 26/41] target-sparc: Move cpu_gdb_{read, write}_register()

2013-07-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c | 180 +--- target-sparc/gdbstub.c | 200 + 2 files changed, 201 insertions(+), 179 deletions(-) create mode 100644 target-sparc/gdbstub.c diff --git

[Qemu-devel] [PATCH qom-cpu v3 36/41] target-lm32: Move cpu_gdb_{read, write}_register()

2013-07-09 Thread Andreas Färber
Acked-by: Michael Walle Signed-off-by: Andreas Färber --- gdbstub.c | 66 +-- target-lm32/gdbstub.c | 85 +++ 2 files changed, 86 insertions(+), 65 deletions(-) create mode 100644 target-lm32/gdbstub

[Qemu-devel] [PATCH qom-cpu v3 35/41] target-s390x: Move cpu_gdb_{read, write}_register()

2013-07-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c | 60 + target-s390x/gdbstub.c | 80 ++ 2 files changed, 81 insertions(+), 59 deletions(-) create mode 100644 target-s390x/gdbstub.c diff --git a/gdbstub.

[Qemu-devel] [PATCH qom-cpu v3 22/41] gdbstub: Drop dead code in cpu_gdb_{read, write}_register()

2013-07-09 Thread Andreas Färber
GET_REG*() macros include a return statement, thus no need for break. Acked-by: Michael Walle (for lm32) Signed-off-by: Andreas Färber --- gdbstub.c | 25 - 1 file changed, 25 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index cd25c06..9ede3de 100644 --- a/gdbstub.c

[Qemu-devel] [PATCH qom-cpu v3 19/41] gdbstub: Change gdb_register_coprocessor() argument to CPUState

2013-07-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c | 7 +++ include/exec/gdbstub.h | 2 +- target-arm/helper.c | 7 --- target-m68k/helper.c| 3 ++- target-ppc/translate_init.c | 15 --- 5 files changed, 18 insertions(+), 16 deletions(-) di

[Qemu-devel] [PATCH qom-cpu v3 24/41] target-i386: Move cpu_gdb_{read, write}_register()

2013-07-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c | 203 + target-i386/gdbstub.c | 222 ++ 2 files changed, 223 insertions(+), 202 deletions(-) create mode 100644 target-i386/gdbstub.c diff --git a

[Qemu-devel] [PATCH qom-cpu v3 38/41] gdbstub: Replace GET_REG*() macros with gdb_get_reg*() functions

2013-07-09 Thread Andreas Färber
This avoids polluting the global namespace with a non-prefixed macro and makes it obvious in the call sites that we return. Semi-automatic conversion using, e.g., sed -i 's/GET_REGL(/return gdb_get_regl(mem_buf, /g' target-*/gdbstub.c followed by manual tweaking for sparc's GET_REGA() and Coding

[Qemu-devel] [PATCH qom-cpu v3 32/41] target-microblaze: Move cpu_gdb_{read, write}_register()

2013-07-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c | 29 +-- target-microblaze/gdbstub.c | 49 + 2 files changed, 50 insertions(+), 28 deletions(-) create mode 100644 target-microblaze/gdbstub.c diff --git a/gdbstub.

[Qemu-devel] [PATCH qom-cpu v3 21/41] gdbstub: Fix cpu_gdb_{read, write}_register() Coding Style

2013-07-09 Thread Andreas Färber
Add braces, replace tabs, remove trailing whitespace, drop space before parenthesis and place break etc. below case statements. Signed-off-by: Andreas Färber --- gdbstub.c | 446 -- 1 file changed, 292 insertions(+), 154 deletions(-) d

[Qemu-devel] [PATCH qom-cpu v3 41/41] cpu: Introduce CPUClass::gdb_core_xml_file for GDB_CORE_XML

2013-07-09 Thread Andreas Färber
Replace the GDB_CORE_XML define in gdbstub.c with a CPUClass field. Use first_cpu for qSupported and qXfer:features:read: for now. Add a stub for xml_builtin. Signed-off-by: Andreas Färber --- gdbstub.c | 42 ++ include/qom/cpu.h

[Qemu-devel] [PATCH qom-cpu v3 01/41] cpu: Introduce vaddr type

2013-07-09 Thread Andreas Färber
vaddr is to target_ulong what uintmax_t is to unsigned int. Its purpose is to allow turning per-target functions with target_ulong arguments into CPUClass hooks. Suggested-by: Peter Maydell Signed-off-by: Andreas Färber --- include/qom/cpu.h | 8 1 file changed, 8 insertions(+) diff

[Qemu-devel] [PATCH qom-cpu v3 04/41] target-moxie: Implement CPUClass::set_pc()

2013-07-09 Thread Andreas Färber
This adds support for GDB's c addr (Continue) and s addr (Single Step). Prepares for dropping cpu_pc_from_tb(). Signed-off-by: Andreas Färber --- target-moxie/cpu.c | 8 1 file changed, 8 insertions(+) diff --git a/target-moxie/cpu.c b/target-moxie/cpu.c index 92ca594..91f6197 100644

[Qemu-devel] [PATCH qom-cpu v3 11/41] gdbstub: Change syscall callback argument to CPUState

2013-07-09 Thread Andreas Färber
Callback implementations were specific to arm and m68k, so can easily cast to ARMCPU and M68kCPU respectively. Prepares for changing GDBState::c_cpu to CPUState. Signed-off-by: Andreas Färber --- gdbstub.c | 2 +- include/exec/gdbstub.h | 2 +- target-arm/arm-semi.c | 8 ++-

[Qemu-devel] [PATCH qom-cpu v3 25/41] target-ppc: Move cpu_gdb_{read, write}_register()

2013-07-09 Thread Andreas Färber
Signed-off-by: Andreas Färber --- gdbstub.c| 101 +- target-ppc/gdbstub.c | 122 +++ 2 files changed, 123 insertions(+), 100 deletions(-) create mode 100644 target-ppc/gdbstub.c diff --git a/gdbs

[Qemu-devel] [PATCH qom-cpu v3 23/41] cpu: Introduce CPUState::gdb_num_regs and CPUClass::gdb_num_core_regs

2013-07-09 Thread Andreas Färber
CPUState::gdb_num_regs replaces num_g_regs. CPUClass::gdb_num_core_regs replaces NUM_CORE_REGS. Allows building gdb_register_coprocessor() for xtensa, too. As a side effect this should fix coprocessor register numbering for SMP. Acked-by: Michael Walle (for lm32) Signed-off-by: Andreas Färber

[Qemu-devel] [PATCH qom-cpu v3 18/41] cpu: Move gdb_regs field from CPU_COMMON to CPUState

2013-07-09 Thread Andreas Färber
Prepares for changing gdb_register_coprocessor() argument to CPUState. Signed-off-by: Andreas Färber --- gdbstub.c | 11 ++- include/exec/cpu-defs.h | 2 -- include/qom/cpu.h | 2 ++ 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/gdbstub.c b/gdbstub.

[Qemu-devel] [PATCH qom-cpu v3 00/41] QOM CPUState, part 11: GDB stub

2013-07-09 Thread Andreas Färber
Hello, This series cleans up gdbstub by changing all its internal CPU state to CPUState and by moving most target-specific code into the target directories. Support for m68k, moxie and unicore32 to set the PC via gdbstub is added. Lightweight subclasses for XtensaCPU are introduced, keeping the

[Qemu-devel] [PATCH qom-cpu v3 10/41] kvm: Change kvm_{insert, remove}_breakpoint() argument to CPUState

2013-07-09 Thread Andreas Färber
CPUArchState is no longer directly used since converting CPU loops to CPUState. Prepares for changing GDBState::c_cpu to CPUState. Signed-off-by: Andreas Färber --- gdbstub.c| 12 include/sysemu/kvm.h | 4 ++-- kvm-all.c| 10 -- kvm-stub.c

[Qemu-devel] [PATCH qom-cpu v3 02/41] cpu: Introduce CPUClass::set_pc() for gdb_set_cpu_pc()

2013-07-09 Thread Andreas Färber
This moves setting the Program Counter from gdbstub into target code. Use vaddr type as upper-bound replacement for target_ulong. Signed-off-by: Andreas Färber --- gdbstub.c | 39 ++- include/qom/cpu.h | 2 ++ target-alpha/cpu.c

[Qemu-devel] [PATCH qom-cpu v3 08/41] gdbstub: Update gdb_handlesig() and gdb_signalled() Coding Style

2013-07-09 Thread Andreas Färber
In particular reindent to 4 instead of 2 spaces. Prepares for changing cpu_single_step() argument in gdb_handlesig(). Signed-off-by: Andreas Färber --- gdbstub.c | 94 +++ 1 file changed, 47 insertions(+), 47 deletions(-) diff --git a

[Qemu-devel] [PATCH qom-cpu v3 12/41] gdbstub: Change gdb_handlesig() argument to CPUState

2013-07-09 Thread Andreas Färber
Prepares for changing GDBState::c_cpu to CPUState. Signed-off-by: Andreas Färber --- bsd-user/main.c| 10 ++ gdbstub.c | 6 +++--- include/exec/gdbstub.h | 2 +- linux-user/main.c | 35 +++ linux-user/signal.c| 3 ++- 5 fil

[Qemu-devel] [PATCH qom-cpu v3 05/41] target-unicore32: Implement CPUClass::set_pc()

2013-07-09 Thread Andreas Färber
This adds support for GDB's c addr (Continue) and s addr (Single Step). Prepares for dropping cpu_pc_from_tb(). Signed-off-by: Andreas Färber --- target-unicore32/cpu.c | 8 1 file changed, 8 insertions(+) diff --git a/target-unicore32/cpu.c b/target-unicore32/cpu.c index 6572f01..79f

[Qemu-devel] [PATCH qom-cpu v3 06/41] cpu: Introduce CPUClass::synchronize_from_tb() for cpu_pc_from_tb()

2013-07-09 Thread Andreas Färber
Where no extra implementation is needed, fall back to CPUClass::set_pc(). Acked-by: Michael Walle (for lm32) Signed-off-by: Andreas Färber --- cpu-exec.c | 8 +++- include/qom/cpu.h | 5 + target-alpha/cpu.h | 5 - target-arm/cpu.h| 5 - targe

Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE

2013-07-09 Thread Anthony Liguori
Peter Maydell writes: > On 9 July 2013 22:24, Anthony Liguori wrote: >> Peter Maydell writes: >>> Why the heck are we telling the guest that the user >>> specified -nographic anyhow? It's a dumb guest ABI... >> >> I believe OpenBIOS uses this to determine if it should display messages >> on ser

Re: [Qemu-devel] [PATCH V16 0/7] replace QEMUOptionParameter with QemuOpts parser

2013-07-09 Thread Andreas Färber
Am 04.07.2013 14:52, schrieb Stefan Hajnoczi: > On Tue, Jun 18, 2013 at 05:31:52PM +0800, Dong Xu Wang wrote: >> These patches will replace QEMUOptionParameter with QemuOpts. Change logs >> please go to each patch's commit message. >> >> Dong Xu Wang (7): >> add def_value_str in QemuOptDesc struc

Re: [Qemu-devel] [PATCH] RTC: enable lost_tick_policy=slew as default (v2)

2013-07-09 Thread Anthony Liguori
Marcelo Tosatti writes: > On Sat, Mar 09, 2013 at 06:44:36AM +0100, Paolo Bonzini wrote: >> Il 08/03/2013 18:53, Anthony Liguori ha scritto: >> >> Anthony mentioned that this >> >> >> >> http://article.gmane.org/gmane.comp.emulators.qemu/160699 >> >> >> >> Is the proper way to do it. >> > >> > T

Re: [Qemu-devel] gdbstub broken in master

2013-07-09 Thread Andreas Färber
Hi Max, Am 09.07.2013 01:37, schrieb Max Filippov: > commit c52a6b67c1d7c6fc9fb2e3ba988d7b978e1487d3 > Author: Andreas Färber > Date: Fri May 17 17:49:10 2013 +0200 > > gdbstub: Simplify find_cpu() > > Use qemu_get_cpu() and CPUState::env_ptr. > > Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE

2013-07-09 Thread Peter Maydell
On 9 July 2013 22:24, Anthony Liguori wrote: > Peter Maydell writes: >> Why the heck are we telling the guest that the user >> specified -nographic anyhow? It's a dumb guest ABI... > > I believe OpenBIOS uses this to determine if it should display messages > on serial or on the graphic display. >

Re: [Qemu-devel] [PATCH] RTC: enable lost_tick_policy=slew as default (v2)

2013-07-09 Thread Marcelo Tosatti
On Sat, Mar 09, 2013 at 06:44:36AM +0100, Paolo Bonzini wrote: > Il 08/03/2013 18:53, Anthony Liguori ha scritto: > >> Anthony mentioned that this > >> > >> http://article.gmane.org/gmane.comp.emulators.qemu/160699 > >> > >> Is the proper way to do it. > > > > That breaks too. I don't have a solu

Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE

2013-07-09 Thread Anthony Liguori
Peter Maydell writes: > On 9 July 2013 21:45, Anthony Liguori wrote: >> Michael Tokarev writes: >>> 09.07.2013 22:37, Anthony Liguori wrote: ERROR:/home/aliguori/git/qemu/tests/fw_cfg-test.c:63:test_fw_cfg_nographic: assertion failed (qfw_cfg_get_u16(fw_cfg, FW_CFG_NOGRAPHIC) == 0):

Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE

2013-07-09 Thread Peter Maydell
On 9 July 2013 21:45, Anthony Liguori wrote: > Michael Tokarev writes: >> 09.07.2013 22:37, Anthony Liguori wrote: >>> ERROR:/home/aliguori/git/qemu/tests/fw_cfg-test.c:63:test_fw_cfg_nographic: >>> assertion failed (qfw_cfg_get_u16(fw_cfg, FW_CFG_NOGRAPHIC) == 0): (1 == 0) >>> GTester: last ran

Re: [Qemu-devel] [PATCH qom-cpu v2 00/42] QOM CPUState, part 11: GDB stub

2013-07-09 Thread Andreas Färber
Am 07.07.2013 20:25, schrieb Andreas Färber: > Hello, > > This series cleans up gdbstub by changing all its internal CPU state to > CPUState > and by moving most target-specific code into the target directories. > > Support for m68k, moxie and unicore32 to set the PC via gdbstub is added. > > L

Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE

2013-07-09 Thread Anthony Liguori
Michael Tokarev writes: > 09.07.2013 22:37, Anthony Liguori wrote: >> Michael Tokarev writes: >> >>> It looks like initially there was -nographic option to turn >>> off display, now there's another option of the same sort, >>> -display none. But code in other places of qemu checks for >>> DT_N

Re: [Qemu-devel] [PATCH V16 0/7] replace QEMUOptionParameter with QemuOpts parser

2013-07-09 Thread Eric Blake
On 07/04/2013 06:52 AM, Stefan Hajnoczi wrote: > On Tue, Jun 18, 2013 at 05:31:52PM +0800, Dong Xu Wang wrote: >> These patches will replace QEMUOptionParameter with QemuOpts. Change logs >> please go to each patch's commit message. >> >> Dong Xu Wang (7): >> add def_value_str in QemuOptDesc stru

Re: [Qemu-devel] win7 boot failure with commit f68ec83 - ide: Set BSY bit during FLUSH

2013-07-09 Thread Andreas Färber
Hi, Am 09.07.2013 22:27, schrieb Michael S. Tsirkin: > I am using this command line: > qemu-system-x86_64 -m 512 -enable-kvm -drive > id=disk,file=./images/win7-x86.qcow2,if=none -device ahci,id=ahci > -device ide-drive,drive=disk,bus=ahci.0 -cdrom > ./images/en_windows_7_ultimate_x86_dvd_x15-6592

[Qemu-devel] win7 boot failure with commit f68ec83 - ide: Set BSY bit during FLUSH

2013-07-09 Thread Michael S. Tsirkin
Hi! I am using this command line: qemu-system-x86_64 -m 512 -enable-kvm -drive id=disk,file=./images/win7-x86.qcow2,if=none -device ahci,id=ahci -device ide-drive,drive=disk,bus=ahci.0 -cdrom ./images/en_windows_7_ultimate_x86_dvd_x15-65921.iso -monitor stdio -cpu kvm64 -snapshot and windows 7 do

Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE

2013-07-09 Thread Michael Tokarev
09.07.2013 22:37, Anthony Liguori wrote: > Michael Tokarev writes: > >> It looks like initially there was -nographic option to turn >> off display, now there's another option of the same sort, >> -display none. But code in other places of qemu checks for >> DT_NOGRAPHIC and does not work well wi

Re: [Qemu-devel] [PATCH] display: stop using DT_NOGRAPHIC, use DT_NONE

2013-07-09 Thread Anthony Liguori
Michael Tokarev writes: > It looks like initially there was -nographic option to turn > off display, now there's another option of the same sort, > -display none. But code in other places of qemu checks for > DT_NOGRAPHIC and does not work well with -display none. > Make DT_NOGRAPHIC an internal

Re: [Qemu-devel] IO : Disk Sector Reads not aligned

2013-07-09 Thread Alex Bligh
--On 10 July 2013 01:04:35 +0800 Saptarshi Sen wrote:    the sector reads are not 512 bytes aligned.    I am gathering the stats from hw/ide/core.c in the function    ide_dma_cb. variable :sector_num    Should not these disk reads be 512 bytes aligned. As illustrated by the code below,

Re: [Qemu-devel] [PATCHv2] block: add the optional file entry to query-block

2013-07-09 Thread Eric Blake
On 07/05/2013 08:28 AM, Federico Simoncelli wrote: > This patch adds the optional file entry to the query-block output. > The value is a json-object representing the information about the > underlying file or device (when present). > > Signed-off-by: Federico Simoncelli > --- > block/qapi.c

[Qemu-devel] IO : Disk Sector Reads not aligned

2013-07-09 Thread Saptarshi Sen
Hi, I am trying to monitor the disk access pattern from the guest. and i am using an IDE as my virtual hard drive. My observation is that the sector reads are not 512 bytes aligned. I am gathering the stats from hw/ide/core.c in the function ide_dma_cb. variable :sector_num

[Qemu-devel] [PATCH] Fix BRDIGE typo.

2013-07-09 Thread Don Koch
From: Don Koch Fix typo in PCI_CLASS_BRDIGE_PCI_INF_SUB. Signed-off-by: Don Koch --- hw/pci-bridge/i82801b11.c | 2 +- include/hw/pci/pci_ids.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci-bridge/i82801b11.c b/hw/pci-bridge/i82801b11.c index 5807a92..b98bfb0 1

Re: [Qemu-devel] [Qemu-ppc] Mac OS X on QEMU

2013-07-09 Thread Scott Wood
On 07/04/2013 09:58:04 AM, Programmingkid wrote: On Jul 4, 2013, at 10:51 AM, Stefan Hajnoczi wrote: > On Thu, Jul 4, 2013 at 4:45 PM, Alexander Graf wrote: >> >> On 04.07.2013, at 16:40, Programmingkid wrote: >> >>> We have made a lot of progress in the last month with making Mac OS X ru

Re: [Qemu-devel] [PATCH v5 05/14] vl: handle "-device dimm"

2013-07-09 Thread Igor Mammedov
On Thu, 27 Jun 2013 08:55:25 +0200 Paolo Bonzini wrote: > Il 27/06/2013 07:08, Wanlong Gao ha scritto: > > Do we really need to specify the memory range? I suspect that we can > > follow current design of normal memory in hot-plug memory. > > I think we can do both. I'm afraid that the configur

Re: [Qemu-devel] [PATCH 03/17] savevm: Implement VMS_DIVIDE flag

2013-07-09 Thread Anthony Liguori
David Gibson writes: > On Mon, Jul 08, 2013 at 01:27:05PM -0500, Anthony Liguori wrote: >> Alexey Kardashevskiy writes: >> >> > From: David Gibson >> > >> > The vmstate infrastructure includes a VMS_MULTIPY flag, and associated >> > VMSTATE_VBUFFER_MULTIPLY helper macro. These can be used to

Re: [Qemu-devel] [PATCH 08/17] pseries: savevm support for PAPR TCE tables

2013-07-09 Thread Anthony Liguori
David Gibson writes: > On Mon, Jul 08, 2013 at 01:39:26PM -0500, Anthony Liguori wrote: >> Alexey Kardashevskiy writes: >> >> > From: David Gibson >> > >> > This patch adds the necessary VMStateDescription information to save the >> > state of PAPR TCE tables (that is, the PAPR specified IOMMU

[Qemu-devel] [PATCH] s390: Async page fault control

2013-07-09 Thread Dominik Dingel
Following the current discussion on the kvm ML, here are the qemu bits regarding async page faults. They are responsible for enabling, disabling the feature and adding a savevm handler for live migration. Dominik Dingel (1): Enable async page faults with live migration target-s390x/kvm.c | 42

[Qemu-devel] [PATCH] Enable async page faults

2013-07-09 Thread Dominik Dingel
S390 can also use async page faults, to enhance guest scheduling. But in the case of live migration we want to disable the feature and know if there are still notifications in flight. Signed-off-by: Dominik Dingel --- target-s390x/kvm.c | 42 ++ 1 file cha

[Qemu-devel] KVM Forum 2013 Call for Participation

2013-07-09 Thread KVM-Forum-2013-PC
= KVM Forum 2013: Call For Participation October 21-23, 2013 - Edinburgh International Conference Centre - Edinburgh, UK (All submissions must be received before midnight July 21, 2013)

Re: [Qemu-devel] [PATCH v3] configure: Simplify alternate .text segment

2013-07-09 Thread Richard Henderson
Ping 2. On 07/02/2013 08:12 AM, Richard Henderson wrote: > Ping. > > On 06/21/2013 07:10 PM, Richard Henderson wrote: >> For bsd-user and linux-user emulation modes QEMU needs to be linked at an >> alternate .text segment address, so that it's out of the way of the guest >> executable. Instead o

[Qemu-devel] [PATCH v2] [Bug 1187529] Update bridge mappings for migration/restore

2013-07-09 Thread dkoch
From: Don Koch Fix for LP#1187529: Devices on PCI bridge stop working when live-migrated. Update bridge mappings for all PCI bridge devices in get_pci_config_device(). Signed-off-by: Don Koch --- Still using old cast method for PCIBridge since there currently is no macro for it; this way it wil

[Qemu-devel] KVM call minutes for 2013-06-26 and 2013-07-08

2013-07-09 Thread Juan Quintela
Hi I forgto to sent the minutes for previous call. So two in one: 2013-07-08 -- - How to handle compatibility in propierties - Static qdev vs dynamic QOM Array of properties defined as an array of types Global: we can enumerate the propierties without instatiating the device/cl

  1   2   3   >