Re: [Qemu-devel] [PATCH 00/17 v3] spapr: migration, pci, msi, power8

2013-07-08 Thread Alexey Kardashevskiy
On 07/09/2013 04:01 AM, Anthony Liguori wrote: > Alexey Kardashevskiy writes: > >> This series spent quite a lot of time waiting when David's PCI series >> reaches the upstream but it does not seem to happen soon so I rebased >> those on top of agraf/ppc-next rebased on top qemu.org/master. >> >>

[Qemu-devel] sending SEGV to qemu crashes host kernel in Fedora 19

2013-07-08 Thread Dave Airlie
Hi, F19 kernel-3.9.8-300.fc19.x86_64 qemu-kvm-1.4.2-4.fc19.x86_64 If I start a complete F19 install in the guest and send the qemu process a SEGV signal, the host kernel starts giving me random kmalloc errors soon after, if I send a normal kill signal things seem fine. CPU is Intel(R) Core(TM) i

Re: [Qemu-devel] sending SEGV to qemu crashes host kernel in Fedora 19

2013-07-08 Thread Dave Airlie
On Tue, Jul 9, 2013 at 10:35 AM, Dave Airlie wrote: > Hi, > > F19 > kernel-3.9.8-300.fc19.x86_64 > qemu-kvm-1.4.2-4.fc19.x86_64 > > If I start a complete F19 install in the guest and send the qemu > process a SEGV signal, the host kernel starts giving me random kmalloc > errors soon after, if I se

Re: [Qemu-devel] [PATCH 04/17] target-ppc: Convert ppc cpu savevm to VMStateDescription

2013-07-08 Thread Alexey Kardashevskiy
On 07/09/2013 04:29 AM, Anthony Liguori wrote: > Alexey Kardashevskiy writes: > >> From: David Gibson >> >> The savevm code for the powerpc cpu emulation is currently based around >> the old register_savevm() rather than register_vmstate() method. It's also >> rather broken, missing some import

Re: [Qemu-devel] [PATCH 02/17] pseries: rework XICS

2013-07-08 Thread Benjamin Herrenschmidt
On Tue, 2013-07-09 at 13:40 +1000, Alexey Kardashevskiy wrote: > No, why? It is a per CPU state of XICS controller, never exists apart > from XICS. ICP is. ICS is ... different but can mostly be considered to be the XICS itself. Anthony, we could be completely anal about it and create a gigantic

[Qemu-devel] Questions about Block subsystem in QEMU.

2013-07-08 Thread Yaodong Yang
hello everyone, I have a question about the qemu block-subsytem. When a user in guest os perform an io operation, how this io request performed in the qemu. Where is the start point in qemu code to serve this request. Thanks! -- Yaodong Yang Computer Science and Engineering Department Universit

Re: [Qemu-devel] [PATCH] target-arm: Avoid g_hash_table_get_keys()

2013-07-08 Thread Peter Crosthwaite
On Mon, Jul 1, 2013 at 9:40 PM, Peter Maydell wrote: > g_hash_table_get_keys() was only introduced in glib 2.14, and we're > still targeting a minimum version of 2.12. Rewrite the offending > code (introduced in commit 721fae1) to use g_hash_table_foreach() > to build the list of keys. > > Signed

Re: [Qemu-devel] [PATCH 02/17] pseries: rework XICS

2013-07-08 Thread Alexey Kardashevskiy
On 07/09/2013 04:22 AM, Anthony Liguori wrote: > Alexey Kardashevskiy writes: > >> Currently XICS interrupt controller is not a QEMU device. As we are going >> to support in-kernel emulated XICS which is a part of KVM, it make >> sense not to extend the existing XICS and have multiple KVM stub fu

Re: [Qemu-devel] [PATCH 05/17] pseries: savevm support for XICS interrupt controller

2013-07-08 Thread Alexey Kardashevskiy
On 07/09/2013 10:49 AM, Anthony Liguori wrote: > On Mon, Jul 8, 2013 at 7:06 PM, Alexey Kardashevskiy wrote: >>> You should tie the vmstate section to DeviceState::vmsd. You only need >>> to do this because you haven't converted everything to QOM yet. >>> >>> Please do that to avoid these hacks.

Re: [Qemu-devel] [PATCH V4 01/10] NUMA: Support multiple CPU ranges on -numa option

2013-07-08 Thread Eric Blake
On 07/08/2013 09:28 PM, Wanlong Gao wrote: > > Note that after this patch, the defalut suffix of "-numa node,mem=N" > will no longer be "M". So we must add the suffix "M" like "-numa > node,mem=NM" > when assigning "N MB" of node memory size. > > But if we follow Paolo'

Re: [Qemu-devel] [PATCH V4 01/10] NUMA: Support multiple CPU ranges on -numa option

2013-07-08 Thread Wanlong Gao
On 07/09/2013 03:25 AM, Anthony Liguori wrote: > Eric Blake writes: > >> On 07/05/2013 12:41 PM, Eduardo Habkost wrote: >>> On Thu, Jul 04, 2013 at 05:53:08PM +0800, Wanlong Gao wrote: From: Bandan Das This allows us to use the "cpus" property multiple times to specify multip

Re: [Qemu-devel] [PATCH 14/17] pseries: Support for in-kernel XICS interrupt controller

2013-07-08 Thread Alexey Kardashevskiy
On 07/09/2013 04:50 AM, Anthony Liguori wrote: >> +#include "hw/hw.h" >> +#include "trace.h" >> +#include "hw/ppc/spapr.h" >> +#include "hw/ppc/xics.h" >> +#include "kvm_ppc.h" >> +#include "qemu/config-file.h" >> + >> +#include >> + >> +struct icp_state_kvm { > > CodingStyle ./scripts/checkpat

Re: [Qemu-devel] [PATCH 03/17] savevm: Implement VMS_DIVIDE flag

2013-07-08 Thread David Gibson
On Mon, Jul 08, 2013 at 01:27:05PM -0500, Anthony Liguori wrote: > Alexey Kardashevskiy writes: > > > From: David Gibson > > > > The vmstate infrastructure includes a VMS_MULTIPY flag, and associated > > VMSTATE_VBUFFER_MULTIPLY helper macro. These can be used to save a > > variably sized buffe

Re: [Qemu-devel] [PATCH V5 1/7] monitor: avoid direct use of global *cur_mon in completion functions

2013-07-08 Thread Wenchao Xia
于 2013-7-8 23:17, Luiz Capitulino 写道: On Sat, 29 Jun 2013 11:52:55 +0800 Wenchao Xia wrote: Parameter *mon is added to replace *cur_mon, and readline_completion() pass rs->mon as value, which should be initialized in readline_init() called by monitor_init(). In short, structure ReadLineState c

Re: [Qemu-devel] [PATCH 05/17] pseries: savevm support for XICS interrupt controller

2013-07-08 Thread Anthony Liguori
Alexey Kardashevskiy writes: > On 07/09/2013 10:49 AM, Anthony Liguori wrote: >> On Mon, Jul 8, 2013 at 7:06 PM, Alexey Kardashevskiy wrote: You should tie the vmstate section to DeviceState::vmsd. You only need to do this because you haven't converted everything to QOM yet.

[Qemu-devel] [PATCH 4/4] hw/alpha: Drop latch_tmp hack

2013-07-08 Thread Richard Henderson
The memory and i/o core now support passing 64-bit accesses along from the guest, so we no longer need to emulate them. Signed-off-by: Richard Henderson --- hw/alpha/typhoon.c | 53 - 1 file changed, 12 insertions(+), 41 deletions(-) diff --gi

[Qemu-devel] [PATCH 2/4] hw/alpha: Don't machine check on missing pci i/o

2013-07-08 Thread Richard Henderson
Not really correct, but we don't implement all of the random devices that the kernel looks for. This is good enough to keep us booting. Signed-off-by: Richard Henderson --- hw/alpha/alpha_sys.h | 1 + hw/alpha/pci.c | 26 ++ hw/alpha/typhoon.c | 3 ++- 3 files

[Qemu-devel] [PATCH 3/4] exec: Support 64-bit operations in address_space_rw

2013-07-08 Thread Richard Henderson
Honor the implementation maximum access size, and at least check the minimum access size. Signed-off-by: Richard Henderson --- exec.c | 68 ++ 1 file changed, 56 insertions(+), 12 deletions(-) diff --git a/exec.c b/exec.c index 03f

[Qemu-devel] [PATCH 0/4] alpha-softmmu fixes

2013-07-08 Thread Richard Henderson
The recent changes for ioport memory regions is a blessing and a curse for the simplified alpha machine model we have. On the one hand, we can eliminate two hacks present in the tsunami system chip emulation. We also now get machine checks when we access ioports that aren't connected to a device.

[Qemu-devel] [PATCH 1/4] hw/alpha: Don't use get_system_io

2013-07-08 Thread Richard Henderson
Advancements in the ioport subsystem mean that we need no longer thunk memory-mapped i/o through the system-io address space. Signed-off-by: Richard Henderson --- hw/alpha/alpha_sys.h | 1 - hw/alpha/pci.c | 44 hw/alpha/typhoon.c | 20 ++

Re: [Qemu-devel] [PATCH 05/17] pseries: savevm support for XICS interrupt controller

2013-07-08 Thread Alexey Kardashevskiy
On 07/09/2013 10:49 AM, Anthony Liguori wrote: > On Mon, Jul 8, 2013 at 7:06 PM, Alexey Kardashevskiy wrote: >>> You should tie the vmstate section to DeviceState::vmsd. You only need >>> to do this because you haven't converted everything to QOM yet. >>> >>> Please do that to avoid these hacks.

Re: [Qemu-devel] [PATCH 05/17] pseries: savevm support for XICS interrupt controller

2013-07-08 Thread Anthony Liguori
On Mon, Jul 8, 2013 at 7:06 PM, Alexey Kardashevskiy wrote: >> You should tie the vmstate section to DeviceState::vmsd. You only need >> to do this because you haven't converted everything to QOM yet. >> >> Please do that to avoid these hacks. > > > How? I want to support migration from xics to x

Re: [Qemu-devel] seabios 1.7.3 breaks booting windows 7?

2013-07-08 Thread Kevin O'Connor
On Mon, Jul 08, 2013 at 08:18:42PM -0400, Cole Robinson wrote: > On 07/08/2013 07:18 PM, Kevin O'Connor wrote: > > On Mon, Jul 08, 2013 at 05:23:40PM -0400, Cole Robinson wrote: > >> On 07/07/2013 11:41 PM, Kevin O'Connor wrote: > >>> The 1.7.3 version of SeaBIOS has now been released. For more >

Re: [Qemu-devel] seabios 1.7.3 breaks booting windows 7?

2013-07-08 Thread Cole Robinson
On 07/08/2013 07:18 PM, Kevin O'Connor wrote: > On Mon, Jul 08, 2013 at 05:23:40PM -0400, Cole Robinson wrote: >> On 07/07/2013 11:41 PM, Kevin O'Connor wrote: >>> The 1.7.3 version of SeaBIOS has now been released. For more >>> information on the release, please see: >> >> Just gave it a spin, br

Re: [Qemu-devel] [PATCH 05/17] pseries: savevm support for XICS interrupt controller

2013-07-08 Thread Alexey Kardashevskiy
On 07/09/2013 04:31 AM, Anthony Liguori wrote: > Alexey Kardashevskiy writes: > >> From: David Gibson >> >> This patch adds the necessary VMStateDescription information to support >> savevm/loadvm for the XICS interrupt controller used on the pseries >> machine. >> >> Signed-off-by: David Gibson

[Qemu-devel] gdbstub broken in master

2013-07-08 Thread Max Filippov
Hi Andreas, commit c52a6b67c1d7c6fc9fb2e3ba988d7b978e1487d3 Author: Andreas Färber Date: Fri May 17 17:49:10 2013 +0200 gdbstub: Simplify find_cpu() Use qemu_get_cpu() and CPUState::env_ptr. Reviewed-by: Richard Henderson Signed-off-by: Andreas Färber breaks single-steppin

Re: [Qemu-devel] seabios 1.7.3 breaks booting windows 7? (was: [ANNOUNCE] SeaBIOS 1.7.3)

2013-07-08 Thread Kevin O'Connor
On Mon, Jul 08, 2013 at 05:23:40PM -0400, Cole Robinson wrote: > On 07/07/2013 11:41 PM, Kevin O'Connor wrote: > > The 1.7.3 version of SeaBIOS has now been released. For more > > information on the release, please see: > > Just gave it a spin, breaks booting a Windows 7 VM for me. Using qemu-1.4

[Qemu-devel] [PATCH v3 1/2] hw/loader: Support ramdisk with u-boot header

2013-07-08 Thread Soren Brinkmann
Introduce 'load_ramdisk()' which can load "normal" ramdisks and ramdisks with a u-boot header. To enable this and leverage synergies 'load_uimage()' is refactored to accomodate this additional use case. Signed-off-by: Soren Brinkmann --- v3: - remove fallback code from load_ramdisk(). This way t

[Qemu-devel] [PATCH v3 2/2] hw/arm: Use 'load_ramdisk()' for loading ramdisks w/ U-Boot header

2013-07-08 Thread Soren Brinkmann
The load_ramdisk function is used to load ramdisk featuring a U-Boot header. Signed-off-by: Soren Brinkmann --- v2: - try to load a u-boot ramdisk using the new load_ramdisk() function first. And then, in case of an error, fall back to the traditional way for loading a ramdisk. In order to

Re: [Qemu-devel] [PATCH 08/17] pseries: savevm support for PAPR TCE tables

2013-07-08 Thread Benjamin Herrenschmidt
On Mon, 2013-07-08 at 17:15 -0500, Anthony Liguori wrote: > Hypercall arguments are passed in CPU endianness so what's being stored > in the tce table is CPU endianness. > > Since VBUFFER just does a blind write() of the full array of uint64s, > what goes on the wire will be CPU endianness. > >

[Qemu-devel] [PATCH v3 0/2] Support ramdisks with U-Boot header

2013-07-08 Thread Soren Brinkmann
Sorry, for the delay, but I finally found some time for a follow up. I assume the asymmety between loading kernels and loading the ramdisk is the blocker for this series and fixed it up. Detailed changelog in the following emails. Sören Soren Brinkmann (2): hw/loader: Support ramdisk wi

Re: [Qemu-devel] [PATCH 11/17] pseries: savevm support for pseries machine

2013-07-08 Thread Anthony Liguori
Benjamin Herrenschmidt writes: > On Mon, 2013-07-08 at 13:45 -0500, Anthony Liguori wrote: >> I vaguely recall making the suggestion to use a live section like >> this. How large is the HTAB typically? > > Depends on how much RAM you put in your VM. The default is around 16M > but it can get bigg

Re: [Qemu-devel] [PATCH 08/17] pseries: savevm support for PAPR TCE tables

2013-07-08 Thread Anthony Liguori
Benjamin Herrenschmidt writes: > On Mon, 2013-07-08 at 13:39 -0500, Anthony Liguori wrote: >> > +.fields = (VMStateField []) { >> > +/* Sanity check */ >> > +VMSTATE_UINT32_EQUAL(liobn, sPAPRTCETable), >> > +VMSTATE_UINT32_EQUAL(window_size, sPAPRTCETable), >> > +

Re: [Qemu-devel] [PATCH 11/17] pseries: savevm support for pseries machine

2013-07-08 Thread Benjamin Herrenschmidt
On Mon, 2013-07-08 at 13:45 -0500, Anthony Liguori wrote: > I vaguely recall making the suggestion to use a live section like > this. How large is the HTAB typically? Depends on how much RAM you put in your VM. The default is around 16M but it can get bigger. Cheers, Ben.

Re: [Qemu-devel] [PATCH 08/17] pseries: savevm support for PAPR TCE tables

2013-07-08 Thread Benjamin Herrenschmidt
On Mon, 2013-07-08 at 13:39 -0500, Anthony Liguori wrote: > > +.fields = (VMStateField []) { > > +/* Sanity check */ > > +VMSTATE_UINT32_EQUAL(liobn, sPAPRTCETable), > > +VMSTATE_UINT32_EQUAL(window_size, sPAPRTCETable), > > + > > +/* IOMMU state */ > > +

[Qemu-devel] [Bug 1100843] Re: Live Migration Causes Performance Issues

2013-07-08 Thread Fletcher Kubota
My HyperDex cluster nodes performance dropped significantly after migrating them (virsh migrate --live ...).they are hosted on precise KVM (12.04.2 Precise Pangolin). first Google search result landed me on this page. it seems i'm not the only one who's encountering this problem. I hope this

[Qemu-devel] seabios 1.7.3 breaks booting windows 7? (was: [ANNOUNCE] SeaBIOS 1.7.3)

2013-07-08 Thread Cole Robinson
On 07/07/2013 11:41 PM, Kevin O'Connor wrote: > The 1.7.3 version of SeaBIOS has now been released. For more > information on the release, please see: > > http://seabios.org/Releases > > > New in this release: > > * Initial support for using SeaBIOS as a UEFI Compatibility Support > Module (

Re: [Qemu-devel] [PATCH 0/8] Add virtio-mmio and use it in vexpress

2013-07-08 Thread Anthony Liguori
Alexander Graf writes: > On 08.07.2013, at 22:08, Anthony Liguori wrote: > >> I think we're trying to fit a square peg into a round hole. >> >> virtio-mmio is a virtio transport where each device has a dedicated set >> of system resources. >> >> Alex, it sounds like you want virtio-mmio-bus whi

Re: [Qemu-devel] [PATCH 0/8] Add virtio-mmio and use it in vexpress

2013-07-08 Thread Alexander Graf
On 08.07.2013, at 22:08, Anthony Liguori wrote: > Peter Maydell writes: > >> On 8 July 2013 14:45, Alexander Graf wrote: >>> On 08.07.2013, at 15:23, Peter Maydell wrote: Now I'm completely confused. Why would assigned devices have anything to do with this? Can you explain in more >>

Re: [Qemu-devel] [PATCH 0/8] Add virtio-mmio and use it in vexpress

2013-07-08 Thread Anthony Liguori
Peter Maydell writes: > On 8 July 2013 14:45, Alexander Graf wrote: >> On 08.07.2013, at 15:23, Peter Maydell wrote: >>> Now I'm completely confused. Why would assigned devices >>> have anything to do with this? Can you explain in more >>> detail, because I don't really see what you're suggestin

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 4/4] i386: ACPI table generation code from seabios

2013-07-08 Thread Michael S. Tsirkin
On Mon, Jul 08, 2013 at 02:16:13PM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > This adds C code for generating ACPI tables at runtime, > > imported from seabios git tree > > commit 51684b7ced75fb76776e8ee84833fcfb6ecf12dd > > > > Although ACPI tables come from a system

Re: [Qemu-devel] [PATCH 5/8] virtio: Implement MMIO based virtio transport

2013-07-08 Thread Anthony Liguori
Peter Maydell writes: > Add support for the generic MMIO based virtio transport. > > This patch includes some fixes for bugs spotted by > Ying-Shiuan Pan . > > Signed-off-by: Peter Maydell > [Fred changes: updated to new virtio-bus mechanisms] > Signed-off-by: KONRAD Frederic > [PMM changes: >

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info

2013-07-08 Thread Michael S. Tsirkin
On Mon, Jul 08, 2013 at 02:10:03PM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > This fills in guest info table with misc > > information of interest to the guest. > > Will be used by ACPI table generation code. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > hw/acpi/

Re: [Qemu-devel] [PATCH 3/8] virtio: Add support for guest setting of queue size

2013-07-08 Thread Anthony Liguori
Peter Maydell writes: > The MMIO virtio transport spec allows the guest to tell the host how > large the queue size is. Add virtio_queue_set_num() function which > implements this in the QEMU common virtio support code. > > Signed-off-by: Peter Maydell > --- > hw/virtio/virtio.c |6

Re: [Qemu-devel] [PATCH V4 01/10] NUMA: Support multiple CPU ranges on -numa option

2013-07-08 Thread Anthony Liguori
Eric Blake writes: > On 07/05/2013 12:41 PM, Eduardo Habkost wrote: >> On Thu, Jul 04, 2013 at 05:53:08PM +0800, Wanlong Gao wrote: >>> From: Bandan Das >>> >>> This allows us to use the "cpus" property multiple times >>> to specify multiple cpu (ranges) to the -numa option : >>> >>> -numa node,

Re: [Qemu-devel] [PATCH 12/17] pseries: savevm support for PCI host bridge

2013-07-08 Thread Anthony Liguori
Alexey Kardashevskiy writes: > From: David Gibson > > This adds the necessary support for saving the state of the PAPR virtual > PCI host bridge (or host bridges). > > Signed-off-by: David Gibson > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Anthony Liguori Regards, Anthony Liguori >

Re: [Qemu-devel] [PATCH V4 01/10] NUMA: Support multiple CPU ranges on -numa option

2013-07-08 Thread Eduardo Habkost
On Mon, Jul 08, 2013 at 01:02:41PM -0600, Eric Blake wrote: > On 07/05/2013 12:41 PM, Eduardo Habkost wrote: > > On Thu, Jul 04, 2013 at 05:53:08PM +0800, Wanlong Gao wrote: > >> From: Bandan Das > >> > >> This allows us to use the "cpus" property multiple times > >> to specify multiple cpu (range

Re: [Qemu-devel] [PATCH V4 08/10] NUMA: add qmp command set-mpol to set memory policy for NUMA node

2013-07-08 Thread Luiz Capitulino
On Mon, 08 Jul 2013 20:50:46 +0200 Andreas Färber wrote: > Am 08.07.2013 20:34, schrieb Luiz Capitulino: > > I forgot to bike-shed on the naming. I'd suggest the following: > > > > - s/set-mpol/set-numa-policy > > - s/mem-policy/policy > > - s/mem-hostnode/host-nodes > > I had suggested s/se

Re: [Qemu-devel] [PATCH 11/17] pseries: savevm support for pseries machine

2013-07-08 Thread Anthony Liguori
Alexey Kardashevskiy writes: > From: David Gibson > > This adds the necessary pieces to implement savevm / migration for the > pseries machine. The most complex part here is migrating the hash > table - for the paravirtualized pseries machine the guest's hash page > table is not stored within g

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 4/4] i386: ACPI table generation code from seabios

2013-07-08 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > This adds C code for generating ACPI tables at runtime, > imported from seabios git tree > commit 51684b7ced75fb76776e8ee84833fcfb6ecf12dd > > Although ACPI tables come from a system BIOS on real hw, > it makes sense that the ACPI tables are coupled with the > v

Re: [Qemu-devel] [PATCH V4 01/10] NUMA: Support multiple CPU ranges on -numa option

2013-07-08 Thread Eric Blake
On 07/05/2013 12:41 PM, Eduardo Habkost wrote: > On Thu, Jul 04, 2013 at 05:53:08PM +0800, Wanlong Gao wrote: >> From: Bandan Das >> >> This allows us to use the "cpus" property multiple times >> to specify multiple cpu (ranges) to the -numa option : >> >> -numa node,cpus=1,cpus=2,cpus=4 >> or >>

Re: [Qemu-devel] [PATCH V4 08/10] NUMA: add qmp command set-mpol to set memory policy for NUMA node

2013-07-08 Thread Eric Blake
On 07/04/2013 03:53 AM, Wanlong Gao wrote: > The QMP command let it be able to set node's memory policy s/let it be able/allows users/ > through the QMP protocol. The qmp-shell command is like: > set-mpol nodeid=0 mem-policy=membind mem-hostnode=0-1 > > Signed-off-by: Wanlong Gao > --- Jus

Re: [Qemu-devel] [SeaBIOS] [PATCH v2 3/4] i386: generate pc guest info

2013-07-08 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > This fills in guest info table with misc > information of interest to the guest. > Will be used by ACPI table generation code. > > Signed-off-by: Michael S. Tsirkin > --- > hw/acpi/ich9.c | 7 ++- > hw/acpi/piix4.c| 44

Re: [Qemu-devel] [PATCH 02/17] pseries: rework XICS

2013-07-08 Thread Anthony Liguori
Alexey Kardashevskiy writes: > Currently XICS interrupt controller is not a QEMU device. As we are going > to support in-kernel emulated XICS which is a part of KVM, it make > sense not to extend the existing XICS and have multiple KVM stub functions > but to create yet another device and share p

Re: [Qemu-devel] [PATCH V4 09/10] NUMA: add hmp command set-mpol

2013-07-08 Thread Luiz Capitulino
On Thu, 4 Jul 2013 17:53:16 +0800 Wanlong Gao wrote: > Add hmp command set-mpol to set host memory policy for a guest > NUMA node. Then we can also set node's memory policy using > the monitor command like: > (qemu) set-mpol 0 mem-policy=membind,mem-hostnode=0-1 > > Signed-off-by: Wanlong Ga

Re: [Qemu-devel] [PATCH 06/17] pseries: savevm support for VIO devices

2013-07-08 Thread Anthony Liguori
Alexey Kardashevskiy writes: > From: David Gibson > > This patch adds helpers to allow PAPR VIO devices to save state common > to all VIO devices during savevm. > > Signed-off-by: David Gibson > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --

Re: [Qemu-devel] [PATCH 11/17] pseries: savevm support for pseries machine

2013-07-08 Thread Anthony Liguori
Alexander Graf writes: > On 08.07.2013, at 20:45, Anthony Liguori wrote: > >> Alexey Kardashevskiy writes: >> >>> From: David Gibson >>> >>> This adds the necessary pieces to implement savevm / migration for the >>> pseries machine. The most complex part here is migrating the hash >>> table

Re: [Qemu-devel] [PATCH v6] add timestamp to error_report()

2013-07-08 Thread Luiz Capitulino
On Mon, 8 Jul 2013 18:47:24 + Seiji Aguchi wrote: > > > +DEF("msg", HAS_ARG, QEMU_OPTION_msg, > > > +"-msg timestamp[=on|off]\n" > > > +"change the format of messages\n" > > > +"on|off controls leading timestamps (default:on)\n", > > > > Did you re

Re: [Qemu-devel] [PATCH 09/17] pseries: rework PAPR virtual SCSI

2013-07-08 Thread Anthony Liguori
Alexey Kardashevskiy writes: > The patch reimplements handling of indirect requests in order to > simplify upcoming live migration support. > - all pointers (except SCSIRequest*) were replaces with integer > indexes and offsets; > - DMA'ed srp_direct_buf kept untouched (ie. BE format); > - vscsi_

Re: [Qemu-devel] [PATCH 04/17] target-ppc: Convert ppc cpu savevm to VMStateDescription

2013-07-08 Thread Anthony Liguori
Alexey Kardashevskiy writes: > From: David Gibson > > The savevm code for the powerpc cpu emulation is currently based around > the old register_savevm() rather than register_vmstate() method. It's also > rather broken, missing some important state on some CPU models. > > This patch completely

Re: [Qemu-devel] [PATCH 14/17] pseries: Support for in-kernel XICS interrupt controller

2013-07-08 Thread Anthony Liguori
Alexey Kardashevskiy writes: > From: David Gibson > > Recent (host) kernels support emulating the PAPR defined "XICS" interrupt > controller system within KVM. This patch allows qemu to initialize and > configure the in-kernel XICS, and keep its state in sync with qemu's XICS > state as necessa

Re: [Qemu-devel] [PATCH V4 08/10] NUMA: add qmp command set-mpol to set memory policy for NUMA node

2013-07-08 Thread Andreas Färber
Am 08.07.2013 20:34, schrieb Luiz Capitulino: > I forgot to bike-shed on the naming. I'd suggest the following: > > - s/set-mpol/set-numa-policy > - s/mem-policy/policy > - s/mem-hostnode/host-nodes I had suggested s/set-mpol/set-memory-policy/g on the previous round (but didn't get any kind o

Re: [Qemu-devel] [PATCH 11/17] pseries: savevm support for pseries machine

2013-07-08 Thread Alexander Graf
On 08.07.2013, at 20:45, Anthony Liguori wrote: > Alexey Kardashevskiy writes: > >> From: David Gibson >> >> This adds the necessary pieces to implement savevm / migration for the >> pseries machine. The most complex part here is migrating the hash >> table - for the paravirtualized pseries

Re: [Qemu-devel] [PATCH 07/17] pseries: savevm support for PAPR VIO logical lan

2013-07-08 Thread Anthony Liguori
Alexey Kardashevskiy writes: > From: David Gibson > > This patch adds the necessary VMStateDescription information to support > savevm/loadvm for the spapr_llan (PAPR logical lan) device. > > Signed-off-by: David Gibson > Signed-off-by: Alexey Kardashevskiy > --- > hw/char/spapr_vty.c | 16

[Qemu-devel] [PATCH v2 3/4] i386: generate pc guest info

2013-07-08 Thread Michael S. Tsirkin
This fills in guest info table with misc information of interest to the guest. Will be used by ACPI table generation code. Signed-off-by: Michael S. Tsirkin --- hw/acpi/ich9.c | 7 ++- hw/acpi/piix4.c| 44 +++- hw/i386/Makefile.objs |

Re: [Qemu-devel] [PATCH v6] add timestamp to error_report()

2013-07-08 Thread Seiji Aguchi
> > +DEF("msg", HAS_ARG, QEMU_OPTION_msg, > > +"-msg timestamp[=on|off]\n" > > +"change the format of messages\n" > > +"on|off controls leading timestamps (default:on)\n", > > Did you really intend to say it's on by default? Because it's actually > disab

Re: [Qemu-devel] [PATCH 08/17] pseries: savevm support for PAPR TCE tables

2013-07-08 Thread Anthony Liguori
Alexey Kardashevskiy writes: > From: David Gibson > > This patch adds the necessary VMStateDescription information to save the > state of PAPR TCE tables (that is, the PAPR specified IOMMU). > > Signed-off-by: David Gibson > Signed-off-by: Alexey Kardashevskiy > --- > hw/ppc/spapr_iommu.c |

Re: [Qemu-devel] [PATCH V4 10/10] NUMA: show host memory policy info in info numa command

2013-07-08 Thread Luiz Capitulino
On Thu, 4 Jul 2013 17:53:17 +0800 Wanlong Gao wrote: > Show host memory policy of nodes in the info numa monitor command. > After this patch, the monitor command "info numa" will show the > information like following if the host numa support is enabled: As you're adding a QMP command to set the

Re: [Qemu-devel] [PATCH V4 08/10] NUMA: add qmp command set-mpol to set memory policy for NUMA node

2013-07-08 Thread Luiz Capitulino
On Mon, 8 Jul 2013 14:25:14 -0400 Luiz Capitulino wrote: > On Thu, 4 Jul 2013 17:53:15 +0800 > Wanlong Gao wrote: > > > The QMP command let it be able to set node's memory policy > > through the QMP protocol. The qmp-shell command is like: > > set-mpol nodeid=0 mem-policy=membind mem-hostno

Re: [Qemu-devel] [PATCH 01/17] pseries: move interrupt controllers to hw/intc/

2013-07-08 Thread Alexander Graf
On 08.07.2013, at 20:15, Anthony Liguori wrote: > Alexey Kardashevskiy writes: > >> Signed-off-by: Alexey Kardashevskiy > > Reviewed-by: Anthony Liguori Thanks, applied to ppc-next. Alex

Re: [Qemu-devel] [PATCH 05/17] pseries: savevm support for XICS interrupt controller

2013-07-08 Thread Anthony Liguori
Alexey Kardashevskiy writes: > From: David Gibson > > This patch adds the necessary VMStateDescription information to support > savevm/loadvm for the XICS interrupt controller used on the pseries > machine. > > Signed-off-by: David Gibson > [aik: added ics_resend() on post_load] > Signed-off-by

Re: [Qemu-devel] [PATCH 03/17] savevm: Implement VMS_DIVIDE flag

2013-07-08 Thread Anthony Liguori
Alexey Kardashevskiy writes: > From: David Gibson > > The vmstate infrastructure includes a VMS_MULTIPY flag, and associated > VMSTATE_VBUFFER_MULTIPLY helper macro. These can be used to save a > variably sized buffer where the size in bytes of the buffer isn't directly > accessible as a struct

[Qemu-devel] [PATCH v2 4/4] i386: ACPI table generation code from seabios

2013-07-08 Thread Michael S. Tsirkin
This adds C code for generating ACPI tables at runtime, imported from seabios git tree commit 51684b7ced75fb76776e8ee84833fcfb6ecf12dd Although ACPI tables come from a system BIOS on real hw, it makes sense that the ACPI tables are coupled with the virtual machine, since they have to abstract

[Qemu-devel] [PATCH v2 1/4] loader: support for unmapped ROM blobs

2013-07-08 Thread Michael S. Tsirkin
Support ROM blobs not mapped into guest memory: let user pass in MR for memory serving as the backing store. Signed-off-by: Michael S. Tsirkin --- hw/core/loader.c | 32 +--- hw/lm32/lm32_hwsetup.h | 2 +- include/hw/loader.h| 4 ++-- 3 files changed, 32 i

[Qemu-devel] [PATCH v2 0/4] qemu: generate acpi tables for the guest

2013-07-08 Thread Michael S. Tsirkin
This patchset moves all generation of ACPI tables from guest BIOS to the hypervisor. Please review, and consider for 1.6. Changes from v1 RFC: - added code to address cross version compatibility - rebased to latest bits - updated acpi tables to latest seabios bits (added pvpanic device) Comments

[Qemu-devel] [PATCH v2 2/4] loader: allow adding ROMs in done callbacks

2013-07-08 Thread Michael S. Tsirkin
Don't abort if machine done callbacks add ROMs. Signed-off-by: Michael S. Tsirkin --- hw/core/loader.c| 6 +- include/hw/loader.h | 1 + vl.c| 3 +++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index 1ead722..3f1d89b 1

Re: [Qemu-devel] [PATCH 02/17] pseries: rework XICS

2013-07-08 Thread Anthony Liguori
Alexey Kardashevskiy writes: > On 06/27/2013 09:47 PM, David Gibson wrote: >> On Thu, Jun 27, 2013 at 04:45:45PM +1000, Alexey Kardashevskiy wrote: >>> Currently XICS interrupt controller is not a QEMU device. As we are going >>> to support in-kernel emulated XICS which is a part of KVM, it make

Re: [Qemu-devel] [PATCH V4 08/10] NUMA: add qmp command set-mpol to set memory policy for NUMA node

2013-07-08 Thread Luiz Capitulino
On Thu, 4 Jul 2013 17:53:15 +0800 Wanlong Gao wrote: > The QMP command let it be able to set node's memory policy > through the QMP protocol. The qmp-shell command is like: > set-mpol nodeid=0 mem-policy=membind mem-hostnode=0-1 > > Signed-off-by: Wanlong Gao > --- > cpus.c | 54

Re: [Qemu-devel] [PATCH 01/17] pseries: move interrupt controllers to hw/intc/

2013-07-08 Thread Anthony Liguori
Alexey Kardashevskiy writes: > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > default-configs/ppc64-softmmu.mak |1 + > hw/intc/Makefile.objs |1 + > hw/{ppc => intc}/xics.c |0 > hw/ppc/Makefile.objs

Re: [Qemu-devel] [PATCH v6] add timestamp to error_report()

2013-07-08 Thread Luiz Capitulino
On Wed, 03 Jul 2013 23:02:46 -0400 Seiji Aguchi wrote: > [Issue] > When we offer a customer support service and a problem happens > in a customer's system, we try to understand the problem by > comparing what the customer reports with message logs of the > customer's system. > > In this case, we

Re: [Qemu-devel] [PATCH 00/17 v3] spapr: migration, pci, msi, power8

2013-07-08 Thread Anthony Liguori
Alexey Kardashevskiy writes: > This series spent quite a lot of time waiting when David's PCI series > reaches the upstream but it does not seem to happen soon so I rebased > those on top of agraf/ppc-next rebased on top qemu.org/master. > > > While this series applies and compiles, the migration

Re: [Qemu-devel] QEMU live block-migration

2013-07-08 Thread Yaodong Yang
Yes, I found it in the qemu-1.5.1 and it's much clear for me now. I think I need to work on this version, other than the out-of-date version qemu-kvm-1.2.0. Thanks a lot. On Mon, Jul 8, 2013 at 12:29 PM, Yaodong Yang wrote: > I used the qemu-kvm 1.2.0, so I did not find it in the code. I will m

Re: [Qemu-devel] [Bug 1187529] [PATCH] Update mappings after PCI bridge live migration or save-restore.

2013-07-08 Thread Don Koch
On 07/04/2013 04:57 AM, Michael S. Tsirkin wrote: > On Wed, Jul 03, 2013 at 11:04:16AM -0400, Don Koch wrote: >> From: Don Koch >> >> Update mappings for PCI bridge after live migration. >> >> Signed-off-by: Don Koch >> --- >> This fixes bug 1187529: devices on a PCI bridge stop working after mig

[Qemu-devel] [RFC] Undeterministic behaviour with icount.

2013-07-08 Thread Frederic Konrad
Hi everybody, We get some issues with reverse execution caused by indeterminism. Something catched our attention: static void icount_warp_rt(void *opaque), cpus.c:276 We have the feeling that icount is synchronized with rt_clock, is that possible? According to this Paolo's series

Re: [Qemu-devel] [PATCH v3 0/3] qapi: Top-level type reference for command definitions

2013-07-08 Thread Luiz Capitulino
On Mon, 1 Jul 2013 16:31:49 +0200 Kevin Wolf wrote: > v2: > - Updated documentation in patch 3 > > v3: > - Refactored differently (introduced get_expr()) as suggested by Michael > > Kevin Wolf (3): > qapi.py: Avoid code duplication > qapi.py: Allow top-level type reference for command defi

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Anthony Liguori
Stefano Stabellini writes: > On Mon, 8 Jul 2013, Anthony Liguori wrote: >> Andreas Färber writes: >> >> Right, it goes: >> >> 1) Acked-by: >> >> I haven't reviewed the code in detail but the general idea seems sane. >> >> 2) Reviewed-by: >> >> The general idea seems sane, and I have done a

Re: [Qemu-devel] QEMU live block-migration

2013-07-08 Thread Yaodong Yang
I used the qemu-kvm 1.2.0, so I did not find it in the code. I will move to the current qemu version. Thanks! On Mon, Jul 8, 2013 at 12:18 PM, Michael Roth wrote: > Quoting Yaodong Yang (2013-07-08 10:57:25) > > Hello Michael, > >Thanks for your help! > >I read the function of tcp_wait_

Re: [Qemu-devel] QEMU live block-migration

2013-07-08 Thread Michael Roth
Quoting Yaodong Yang (2013-07-08 10:57:25) > Hello Michael, >Thanks for your help! >I read the function of tcp_wait_for_connect(), there is a statement; " >qemu_set_fd_handler2(s->fd, NULL, NULL, NULL, NULL); " I guess this will >disable this file-descriptor from the main loop and

Re: [Qemu-devel] [Bug 1187529] [PATCH] Update mappings after PCI bridge live migration or save-restore.

2013-07-08 Thread Don Koch
On 07/03/2013 12:15 PM, Andreas Färber wrote: > Am 03.07.2013 17:04, schrieb Don Koch: >> From: Don Koch >> >> Update mappings for PCI bridge after live migration. >> >> Signed-off-by: Don Koch >> --- >> This fixes bug 1187529: devices on a PCI bridge stop working after migration. > > Feel free

Re: [Qemu-devel] [PATCH 18/19] target-ppc: Enhance the CPU node labels for the guest device tree for pseries.

2013-07-08 Thread Andreas Färber
Hi, Am 08.07.2013 17:49, schrieb Prerna Saxena: > On 07/08/2013 02:32 PM, Andreas Färber wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> Am 08.07.2013 03:09, schrieb David Gibson: >>> On Sat, Jul 06, 2013 at 11:54:15PM +1000, Alexey Kardashevskiy >>> wrote: @@ -1342,6 +1346,1

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Stefano Stabellini
On Mon, 8 Jul 2013, Stefano Stabellini wrote: > On Mon, 8 Jul 2013, Anthony Liguori wrote: > > Andreas Färber writes: > > > > > Am 08.07.2013 16:10, schrieb Peter Maydell: > > >> On 8 July 2013 15:04, Anthony Liguori wrote: > > >>> (Just a nit and responding because this happens commonly). > > >

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Stefano Stabellini
On Mon, 8 Jul 2013, Anthony Liguori wrote: > Andreas Färber writes: > > > Am 08.07.2013 16:10, schrieb Peter Maydell: > >> On 8 July 2013 15:04, Anthony Liguori wrote: > >>> (Just a nit and responding because this happens commonly). > >>> > >>> You probably mean Reviewed-by. Acked-by really mea

Re: [Qemu-devel] [PATCH V5 7/7] monitor: improve "help" to allow show details of single command in sub group

2013-07-08 Thread Luiz Capitulino
On Sat, 29 Jun 2013 11:53:01 +0800 Wenchao Xia wrote: > A new parameter type 'S' is introduced to allow user input any string. > "help info block" do not tip extra parameter error now. > > Signed-off-by: Wenchao Xia > --- > hmp-commands.hx |2 +- > monitor.c | 30 ++

Re: [Qemu-devel] [PATCH V5 6/7] monitor: improve "help" in auto completion for sub command

2013-07-08 Thread Luiz Capitulino
On Sat, 29 Jun 2013 11:53:00 +0800 Wenchao Xia wrote: > Now special case "help *" in auto completion can work with sub commands, > such as "help info a*". The auto-completion works, but the command is still refused: (qemu) help info u usb usbhost usernet uuid (qemu) help info uuid hel

Re: [Qemu-devel] [PATCH v5] Xen PV Device

2013-07-08 Thread Andreas Färber
Am 08.07.2013 17:34, schrieb Peter Maydell: > On 8 July 2013 16:20, Anthony Liguori wrote: >> Right, it goes: >> >> 1) Acked-by: >> >> I haven't reviewed the code in detail but the general idea seems sane. >> >> 2) Reviewed-by: >> >> The general idea seems sane, and I have done a thorough review o

Re: [Qemu-devel] QEMU live block-migration

2013-07-08 Thread Yaodong Yang
Hello Michael, Thanks for your help! I read the function of tcp_wait_for_connect(), there is a statement; " qemu_set_fd_handler2(s->fd, NULL, NULL, NULL, NULL); " I guess this will disable this file-descriptor from the main loop and make the current execution parallel with the main loop. Is it co

Re: [Qemu-devel] [PATCH 18/19] target-ppc: Enhance the CPU node labels for the guest device tree for pseries.

2013-07-08 Thread Prerna Saxena
On 07/08/2013 02:32 PM, Andreas Färber wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Am 08.07.2013 03:09, schrieb David Gibson: >> On Sat, Jul 06, 2013 at 11:54:15PM +1000, Alexey Kardashevskiy >> wrote: >>> @@ -1342,6 +1346,13 @@ static void >>> ppc_spapr_init(QEMUMachineInitArgs *

[Qemu-devel] [PATCH v2 18/19] target-ppc: Enhance the CPU node labels for the guest device tree for pseries.

2013-07-08 Thread Prerna Saxena
Hi David, Thanks for the review feedback. I have incorporated your changes in v2 of the patch, which follows herewith. Regards, Prerna Subject: [PATCH v2] Target-ppc : Enhance the CPU node labels for the guest device tree for pseries. In absence of a -CPU parameter in the qemu command line, the

Re: [Qemu-devel] [PATCH V5 2/7] monitor: avoid direct use of global variable *mon_cmds

2013-07-08 Thread Luiz Capitulino
On Sat, 29 Jun 2013 11:52:56 +0800 Wenchao Xia wrote: > New member *cmd_table is added in structure Monitor to avoid direct usage of > *mon_cmds. Now monitor have an associated command table, when global variable > *info_cmds is also discarded, structure Monitor would gain full control about > ho

Re: [Qemu-devel] [PATCH V5 4/7] monitor: avoid direct use of global *info_cmds in help functions

2013-07-08 Thread Luiz Capitulino
On Sat, 29 Jun 2013 11:52:58 +0800 Wenchao Xia wrote: > In help functions info_cmds is treated as sub command group now, not as > a special case any more. Still help can't show message for single command > under "info", since command parser reject additional parameter, which What you meant by "h

  1   2   >