Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer.

2013-06-25 Thread Paolo Bonzini
Il 25/06/2013 22:53, Peter Maydell ha scritto: > On 25 June 2013 19:42, Paolo Bonzini wrote: >> Il 25/06/2013 20:21, Peter Maydell ha scritto: >>> @@ -416,7 +513,7 @@ static int imx_timerg_init(SysBusDevice *dev) >>> >>> sysbus_init_irq(dev, &s->irq); >>> memory_region_init_io(&s->iomem,

Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event

2013-06-25 Thread Markus Armbruster
Eric Blake writes: > On 05/23/2013 03:07 AM, Amos Kong wrote: >> Introduce this new QMP event to notify management after guest changes >> rx-filter configuration. >> >> Signed-off-by: Amos Kong >> --- >> QMP/qmp-events.txt| 14 ++ >> include/monitor/monitor.h | 1 + >> mon

Re: [Qemu-devel] block: Review of .has_zero_init use

2013-06-25 Thread Bharata B Rao
On Wed, Jun 26, 2013 at 07:59:27AM +0200, Peter Lieven wrote: > > Am 26.06.2013 um 05:14 schrieb Bharata B Rao : > > > On Tue, Jun 25, 2013 at 01:39:11PM +0200, Kevin Wolf wrote: > >> > >> Can you please review for the gluster, rbd, sheepdog and ssh driver > >> whether it's safe to assume that t

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-06-25 Thread Paolo Bonzini
Il 26/06/2013 02:31, Michael R. Hines ha scritto: > On 06/25/2013 05:06 PM, Paolo Bonzini wrote: >> Il 25/06/2013 22:56, Michael R. Hines ha scritto: >>> I was wrong - this does require a protocol extension. >>> >>> This is because the RDMA transfers are asynchronous, and thus >>> we cannot know in

Re: [Qemu-devel] [PATCH 0/3] make bh safe with hot-unplug

2013-06-25 Thread Paolo Bonzini
Il 26/06/2013 04:59, liu ping fan ha scritto: >> The latter part could be the hard one in a multi-threaded context, but I >> think it's up to the device to ensure it. It doesn't _have_ to be hard. >> For example, joining the data-plane thread would do that as well. >> > It seems not easy, take co

Re: [Qemu-devel] [PATCH v4 06/10] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-06-25 Thread Paolo Bonzini
Il 26/06/2013 00:31, Tomoki Sekiyama ha scritto: > From: Paolo Bonzini [paolo.bonz...@gmail.com] on behalf of Paolo Bonzini > [pbonz...@redhat.com] >> Il 06/06/2013 17:06, Tomoki Sekiyama ha scritto: >>> +STDAPI VSSCheckOSVersion(void); >>> + >>> +STDAPI COMRegister(void); >>> +STDAPI COMUnregiste

Re: [Qemu-devel] block: Review of .has_zero_init use

2013-06-25 Thread Peter Lieven
Am 26.06.2013 um 05:14 schrieb Bharata B Rao : > On Tue, Jun 25, 2013 at 01:39:11PM +0200, Kevin Wolf wrote: >> >> Can you please review for the gluster, rbd, sheepdog and ssh driver >> whether it's safe to assume that the image reads back as zeros after >> bdrv_create? > > Gluster supports bot

[Qemu-devel] meaningless to compare irqfd's msi message with new msi message in virtio_pci_vq_vector_unmask

2013-06-25 Thread Zhanghaoyu (A)
I searched "vector_irqfd" globally, no place found to set/change irqfd's msi message, only irqfd's virq or users member may be changed in kvm_virtio_pci_vq_vector_use, kvm_virtio_pci_vq_vector_release, etc. So I think it's meaningless to do below check in virtio_pci_vq_vector_unmask, if (irqfd-

[Qemu-devel] [RFC PATCH 3/3] nbd: don't get ref if bs has no drive

2013-06-25 Thread Fam Zheng
Signed-off-by: Fam Zheng --- blockdev-nbd.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/blockdev-nbd.c b/blockdev-nbd.c index 95f10c8..2657a90 100644 --- a/blockdev-nbd.c +++ b/blockdev-nbd.c @@ -81,6 +81,7 @@ void qmp_nbd_server_add(const char *device, bool has_writ

[Qemu-devel] [RFC PATCH 0/3] Point-in-time snapshot exporting with drive-backup

2013-06-25 Thread Fam Zheng
This series adds partial support for point-in-time snapshot NBD exporting based on drive-backup. The ideas is described below and patches followed (the missing part is item 3, which work is in progress by Ian Main and will have another patch on it). As the work does not overlap, these series should

[Qemu-devel] [RFC PATCH 2/3] block: assign backing relationship in drive-backup

2013-06-25 Thread Fam Zheng
Assign source image as the backing hd of target bs, so reading target bs gets the point-in-time copy of data from source image. Signed-off-by: Fam Zheng --- blockdev.c | 4 1 file changed, 4 insertions(+) diff --git a/blockdev.c b/blockdev.c index 5e694f3..a1d816e 100644 --- a/blockdev.c +

[Qemu-devel] [RFC PATCH 1/3] block: add target-id option to drive-backup QMP command

2013-06-25 Thread Fam Zheng
Add target-id (optional) to drive-backup command, to make the target bs a named drive so that we can operate on it (e.g. export with NBD). Signed-off-by: Fam Zheng --- blockdev.c | 4 +++- qapi-schema.json | 7 +-- qmp-commands.hx | 3 ++- 3 files changed, 10 insertions(+), 4 deletion

Re: [Qemu-devel] [PATCH V2 5/7] monitor: support sub commands in auto completion

2013-06-25 Thread Wenchao Xia
于 2013-6-24 20:48, Wenchao Xia 写道: > This patch allow auot completion work normal in sub command case, > "info block [DEVICE]" can auto complete now, by re-enter the completion > function. Also, original "info" is treated as a special case, now it is > treated as a sub command group, global variabl

[Qemu-devel] [PATCH V3 8/9] hmp: add interface hmp_snapshot_delete_blkdev_internal

2013-06-25 Thread Wenchao Xia
It is hard to make both id and name optional in hmp console as qmp interface, so this interface require user to specify name. Signed-off-by: Wenchao Xia --- hmp-commands.hx | 18 ++ hmp.c | 12 hmp.h |1 + 3 files changed, 31 insertions(+)

[Qemu-devel] [PATCH V3 6/9] qmp: add interface blockdev-snapshot-delete-internal-sync

2013-06-25 Thread Wenchao Xia
This interface use id and name as optional parameters, to handle the case that one image contain multiple snapshots with same name which may be '', but with different id. Adding parameter id is for historical compatiability reason, and that case is not possible in qemu's new interface for internal

[Qemu-devel] [PATCH V3 9/9] qemu-iotests: add 056 internal snapshot for block device test case

2013-06-25 Thread Wenchao Xia
Create in transaction and deletion in single command will be tested. Signed-off-by: Wenchao Xia --- tests/qemu-iotests/056 | 267 tests/qemu-iotests/056.out |5 + tests/qemu-iotests/group |1 + 3 files changed, 273 insertions(+), 0 dele

[Qemu-devel] [PATCH V3 5/9] qmp: add interface blockdev-snapshot-internal-sync

2013-06-25 Thread Wenchao Xia
Snapshot ID can't be specified in this interface. Signed-off-by: Wenchao Xia --- blockdev.c | 13 + qapi-schema.json | 22 ++ qmp-commands.hx | 30 ++ 3 files changed, 65 insertions(+), 0 deletions(-) diff --git a/blockdev

[Qemu-devel] [PATCH V3 7/9] hmp: add interface hmp_snapshot_blkdev_internal

2013-06-25 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- hmp-commands.hx | 19 +-- hmp.c | 10 ++ hmp.h |1 + 3 files changed, 28 insertions(+), 2 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 915b0d1..53e3ef3 100644 --- a/hmp-commands.hx +++ b/hmp-c

[Qemu-devel] [PATCH V3 1/9] snapshot: new function bdrv_snapshot_find_by_id_and_name()

2013-06-25 Thread Wenchao Xia
To make it clear about id and name in searching, add this API to distinguish them. Caller can choose to search by id or name, *errp will be set only for exception. Some code are modified based on Pavel's patch. Signed-off-by: Wenchao Xia Signed-off-by: Pavel Hrdina --- block/snapshot.c

[Qemu-devel] [PATCH V3 3/9] snapshot: distinguish id and name in snapshot delete

2013-06-25 Thread Wenchao Xia
Snapshot creation actually already distinguish id and name since it take a structured parameter *sn, but delete can't. Later an accurate delete is needed in qmp_transaction abort and blockdev-snapshot-delete-sync, so change its prototype. Also *errp is added to tip error, but return value is kepted

[Qemu-devel] [PATCH V3 4/9] qmp: add internal snapshot support in qmp_transaction

2013-06-25 Thread Wenchao Xia
Unlike savevm, the qmp_transaction interface will not generate snapshot name automatically, saving trouble to return information of the new created snapshot. The snapshot name should not mess up with snapshot ID, there is a check for it. Although qcow2 support storing multiple snapshots with same

[Qemu-devel] [PATCH V3 0/9] add internal snapshot support at block device level

2013-06-25 Thread Wenchao Xia
This series brings internal snapshot support at block devices level, now we have two three methods to do block snapshot lively: 1) backing chain, 2) internal one and 3) drive-back up approach. Comparation: Advantages:Disadvantages: 1)delta data, taken

[Qemu-devel] [PATCH V3 2/9] snapshot: add paired functions for internal snapshot id and name

2013-06-25 Thread Wenchao Xia
Internal snapshot's ID and name concept are both visible in general block level, they are observed by user in "info snapshots", so it is possible to mess them up. Although we can separate the two concept in programming, but if they can be distinguished in string itself, things will be simple and cl

Re: [Qemu-devel] [PATCH for mst/pci] output nc->name in NIC_RX_FILTER_CHANGED event

2013-06-25 Thread Amos Kong
On Mon, Jun 24, 2013 at 02:34:59PM +0800, Amos Kong wrote: > netclient 'name' entry in event is useful for management to know > which device is changed. n->netclient_name is not always set. > This patch changes to use nc->name. If we don't assign 'id', > qemu will set a generated name to nc->name.

Re: [Qemu-devel] block: Review of .has_zero_init use

2013-06-25 Thread Bharata B Rao
On Tue, Jun 25, 2013 at 01:39:11PM +0200, Kevin Wolf wrote: > > Can you please review for the gluster, rbd, sheepdog and ssh driver > whether it's safe to assume that the image reads back as zeros after > bdrv_create? Gluster supports both file and block backends. While the above is true for file

Re: [Qemu-devel] [PATCH 0/3] make bh safe with hot-unplug

2013-06-25 Thread liu ping fan
On Tue, Jun 25, 2013 at 3:53 PM, Paolo Bonzini wrote: > Il 25/06/2013 08:32, liu ping fan ha scritto: >> On Tue, Jun 25, 2013 at 2:24 PM, Paolo Bonzini wrote: >>> Il 25/06/2013 19:38, Liu Ping Fan ha scritto: This series relies on refcnt of object used by bh callback to run against unp

[Qemu-devel] Monitoring Screen Activity in QEMU/KVM

2013-06-25 Thread Shehbaz Jaffer
I want to determine the amount of screen activity taking place on VGA monitor/ Screen for different applications (eg. playing vlc video, normal typing.) When I do not start the X server, I can easily determine the screen activity by counting the number of pages accessed in the region 0xA - 0xB

Re: [Qemu-devel] [PATCH] target-arm: Added CP15 VBAR support

2013-06-25 Thread Peter Crosthwaite
Hi Peter, (Sorry about the delay), On Wed, Feb 27, 2013 at 8:10 PM, Peter Maydell wrote: > On 27 February 2013 07:16, Peter Crosthwaite > wrote: >> From: Nathan Rossi >> >> Added Vector Base Address remapping on ARM v7. > > This one's tricky because the VBAR only exists in CPUs with > TrustZon

[Qemu-devel] [PATCH v12 00/15] rdma: migration support

2013-06-25 Thread Michael R. Hines
Changes since v11: - Minor state transition fix - Fixed localhost migration - Fixed 0.0.0.0 migration - Drop invalid hunk - Updated tags Michael R. Hines (15): rdma: add documentation rdma: introduce qemu_update_position() rdma: export yield_until_fd_readable() rdma: export throughput w/

[Qemu-devel] [PATCH v12 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-06-25 Thread mrhines
From: "Michael R. Hines" As described in the previous patch, until now, the MIG_STATE_SETUP state was not really a 'formal' state. It has been used as a 'zero' state (what we're calling 'NONE' here) and QEMU has been unconditionally transitioning into this state when the QMP migration command was

[Qemu-devel] [PATCH v12 01/15] rdma: add documentation

2013-06-25 Thread mrhines
From: "Michael R. Hines" docs/rdma.txt contains full documentation, wiki links, github url and contact information. Reviewed-by: Juan Quintela Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vinod Tested-by: Chegu Vinod Tested-by: Michael R. Hines Signed-off-by: Michael R. Hines --- docs/rd

[Qemu-devel] [PATCH v12 06/15] rdma: export qemu_fflush()

2013-06-25 Thread mrhines
From: "Michael R. Hines" RDMA uses this to flush the control channel before sending its own message to handle page registrations. Reviewed-by: Juan Quintela Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vinod Tested-by: Chegu Vinod Tested-by: Michael R. Hines Signed-off-by: Michael R. Hines

[Qemu-devel] [PATCH v12 00/15] rdma: migration support

2013-06-25 Thread mrhines
From: "Michael R. Hines" Changes since v11: - Minor state transition fix - Fixed localhost migration - Fixed 0.0.0.0 migration - Drop invalid hunk - Updated tags Michael R. Hines (15): rdma: add documentation rdma: introduce qemu_update_position() rdma: export yield_until_fd_readable()

[Qemu-devel] [PATCH v12 13/15] rdma: allow state transitions between other states besides ACTIVE

2013-06-25 Thread mrhines
From: "Michael R. Hines" This patch is in preparation for the next ones: Until now the MIG_STATE_SETUP state was not really a 'formal' state. It has been used as a 'zero' state and QEMU has been unconditionally transitioning into this state when the QMP migrate command was called. In preparation

[Qemu-devel] [PATCH v12 08/15] rdma: introduce qemu_ram_foreach_block()

2013-06-25 Thread mrhines
From: "Michael R. Hines" This is used during RDMA initialization in order to transmit a description of all the RAM blocks to the peer for later dynamic chunk registration purposes. Reviewed-by: Juan Quintela Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vinod Tested-by: Chegu Vinod Tested-by

[Qemu-devel] [PATCH v12 02/15] rdma: introduce qemu_update_position()

2013-06-25 Thread mrhines
From: "Michael R. Hines" RDMA writes happen asynchronously, and thus the performance accounting also needs to be able to occur asynchronously. This allows anybody to call into savevm.c to update both f->pos as well as into arch_init.c to update the acct_info structure with up-to-date values when

[Qemu-devel] [PATCH v12 15/15] rdma: account for the time spent in MIG_STATE_SETUP through QMP

2013-06-25 Thread mrhines
From: "Michael R. Hines" Using the previous patches, we're now able to timestamp the SETUP state. Once we have this time, let the user know about it in the schema. Reviewed-by: Juan Quintela Signed-off-by: Michael R. Hines --- hmp.c |4 include/migration/migra

[Qemu-devel] [PATCH v12 04/15] rdma: export throughput w/ MigrationStats QMP

2013-06-25 Thread mrhines
From: "Michael R. Hines" This exposes throughput (in megabits/sec) through QMP. Reviewed-by: Juan Quintela Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vinod Tested-by: Chegu Vinod Tested-by: Michael R. Hines Signed-off-by: Michael R. Hines --- hmp.c |2 ++ in

[Qemu-devel] [PATCH v12 09/15] rdma: new QEMUFileOps hooks

2013-06-25 Thread mrhines
From: "Michael R. Hines" These are the prototypes and implementation of new hooks that RDMA takes advantage of to perform dynamic page registration. An optional hook is also introduced for a custom function to be able to override the default save_page function. Also included are the prototypes

[Qemu-devel] [PATCH v12 03/15] rdma: export yield_until_fd_readable()

2013-06-25 Thread mrhines
From: "Michael R. Hines" The RDMA event channel can be made non-blocking just like a TCP socket. Exporting this function allows us to yield so that the QEMU monitor remains available. Reviewed-by: Juan Quintela Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vinod Tested-by: Chegu Vinod Tested

[Qemu-devel] [PATCH v12 10/15] rdma: introduce capability x-rdma-pin-all

2013-06-25 Thread mrhines
From: "Michael R. Hines" This capability allows you to disable dynamic chunk registration for better throughput on high-performance links. For example, using an 8GB RAM virtual machine with all 8GB of memory in active use and the VM itself is completely idle using a 40 gbps infiniband link: 1.

[Qemu-devel] [PATCH v12 05/15] rdma: introduce qemu_file_mode_is_not_valid()

2013-06-25 Thread mrhines
From: "Michael R. Hines" QEMUFileRDMA also has read and write modes. This function is now shared to reduce code duplication. Reviewed-by: Juan Quintela Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vinod Tested-by: Chegu Vinod Tested-by: Michael R. Hines Signed-off-by: Michael R. Hines ---

[Qemu-devel] [PATCH v12 12/15] rdma: send pc.ram

2013-06-25 Thread mrhines
From: "Michael R. Hines" This takes advantages of the previous patches: 1. use the new QEMUFileOps hook 'save_page' 2. call out to the right accessor methods to invoke the iteration hooks defined in QEMUFileOps Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vinod Tested-by: Chegu Vinod Te

[Qemu-devel] RFC: Busifiying NAND

2013-06-25 Thread Peter Crosthwaite
Hi All, NAND emulation is a little strange, in that is doesnt have an appropriate bus type (NAND was formerly SYS_BUS_DEVICE which was completely wrong - so changed to DEVICE). Do want TYPE_NAND_BUS so centrally support multiple NAND chips connected to the one NAND interface? Currently controllers

Re: [Qemu-devel] [PATCH arm-devs v1 1/1] char/cadence_uart: Fix reset for unattached instances

2013-06-25 Thread Peter Crosthwaite
Hi Peter, On Wed, Jun 26, 2013 at 3:16 AM, Peter Maydell wrote: > On 7 June 2013 05:02, wrote: >> From: Peter Crosthwaite >> >> commit 1db8b5efe0c2b5000e50691eea61264a615f43de introduced an issue >> where QEMU would segfault if you have an unattached Cadence UART. >> >> Fix by guarding the flu

Re: [Qemu-devel] [PATCH v1 0/5] Nand Cleanup

2013-06-25 Thread Peter Crosthwaite
On Wed, Jun 26, 2013 at 4:16 AM, Peter Maydell wrote: > On 18 June 2013 12:07, wrote: >> From: Peter Crosthwaite >> >> >> Misc refactorings and cleanup of NAND. >> >> >> Peter Crosthwaite (5): >> block/nand: Factor out common code >> block/nand: Formatting sweep >> block/nand: QOM casting

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-06-25 Thread Michael R. Hines
On 06/25/2013 05:06 PM, Paolo Bonzini wrote: Il 25/06/2013 22:56, Michael R. Hines ha scritto: I was wrong - this does require a protocol extension. This is because the RDMA transfers are asynchronous, and thus we cannot know in advance that it is safe to unregister the memory associated with e

Re: [Qemu-devel] [PATCH 1/2] device_tree: Add qemu_devtree_setprop_sized_cells() utility function

2013-06-25 Thread David Gibson
On Mon, Jun 24, 2013 at 12:02:39PM +0100, Peter Maydell wrote: > On 24 June 2013 11:56, Alexander Graf wrote: > > On 24.06.2013, at 12:22, Peter Maydell wrote: > >> We already have a qemu_devtree_setprop_cells() which sets a dtb > >> property to an array of cells whose values are specified by vara

Re: [Qemu-devel] [PATCH 2/5] Blackfin: initial port

2013-06-25 Thread Mike Frysinger
On Tuesday 25 June 2013 17:23:57 Richard Henderson wrote: whee, got a review! :) i've snipped items that were obvious in the "i'll go do this" category rather than just copying & pasting "OK" many times. got a long flight coming up soon, so hopefully i can tackle the majority of this work the

Re: [Qemu-devel] [PATCH v4 06/10] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-06-25 Thread Tomoki Sekiyama
From: Paolo Bonzini [paolo.bonz...@gmail.com] on behalf of Paolo Bonzini [pbonz...@redhat.com] > Il 06/06/2013 17:06, Tomoki Sekiyama ha scritto: >> +STDAPI VSSCheckOSVersion(void); >> + >> +STDAPI COMRegister(void); >> +STDAPI COMUnregister(void); >> + >> +STDAPI DllRegisterServer(void); >> +STDA

Re: [Qemu-devel] [PULL 0/8] arm-devs queue

2013-06-25 Thread Peter Maydell
On 25 June 2013 22:45, Anthony Liguori wrote: > Peter Maydell writes: >> and (more generically) do you care if the tag message >> actually has any useful content? I notice mst does both. > > Note the tags don't show up in qemu.git git history. The tags don't, but the message does, at least accor

Re: [Qemu-devel] [PULL v2 00/21] pci,kvm,misc enhancements

2013-06-25 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > From: Michael S. Tsirkin > > The following changes since commit 90a2541b763b31d2b551b07e24aae3de5266d31b: > > target-i386: fix over 80 chars warnings (2013-06-15 17:50:38 +) Just as an aside, you should rebase and test before sending pull requests. This con

Re: [Qemu-devel] [PULL 0/8] arm-devs queue

2013-06-25 Thread Anthony Liguori
et me know if I've messed it up. >>> The signed tag itself is 'pull-arm-devs-20130625'; arm-devs.for-upstream >>> is the branch name, as usual. >>> >>> >>> The following changes since commit baf8673ca802cb3ea2cdbe94813441d23bde223b: >&g

Re: [Qemu-devel] [PATCH 2/5] Blackfin: initial port

2013-06-25 Thread Richard Henderson
> diff --git a/target-bfin/bfin-sim.c b/target-bfin/bfin-sim.c Why this separate file from translate.c? > +#include > +#include > +#include > +#include > +#include > +#include Certainly you shouldn't need these, since this isn't a separately compiled object -- you're included from translat

Re: [Qemu-devel] [PATCH v4 06/10] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-06-25 Thread Paolo Bonzini
Il 06/06/2013 17:06, Tomoki Sekiyama ha scritto: > +STDAPI VSSCheckOSVersion(void); > + > +STDAPI COMRegister(void); > +STDAPI COMUnregister(void); > + > +STDAPI DllRegisterServer(void); > +STDAPI DllUnregisterServer(void); Can you explain the difference between COMRegister/COMUnregister and DllRe

[Qemu-devel] [Bug 1101210] Re: qemu 1.3.0: usb keyboard not fully working

2013-06-25 Thread CrystalGamma
** Also affects: archlinux Importance: Undecided Status: New ** No longer affects: archlinux -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1101210 Title: qemu 1.3.0: usb keyboard not ful

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-06-25 Thread Paolo Bonzini
Il 25/06/2013 22:56, Michael R. Hines ha scritto: >> > I was wrong - this does require a protocol extension. > > This is because the RDMA transfers are asynchronous, and thus > we cannot know in advance that it is safe to unregister the memory > associated with each individual transfer before the

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-06-25 Thread Michael R. Hines
On 06/25/2013 10:55 AM, Paolo Bonzini wrote: Il 25/06/2013 16:54, Michael R. Hines ha scritto: Do those few lines of code change the protocol? If yes, I'll go against all my previous recommendations and suggest a #define. If no, it is fine to leave it for later, but I would still suggest posti

Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer.

2013-06-25 Thread Peter Maydell
On 25 June 2013 19:42, Paolo Bonzini wrote: > Il 25/06/2013 20:21, Peter Maydell ha scritto: >> @@ -416,7 +513,7 @@ static int imx_timerg_init(SysBusDevice *dev) >> >> sysbus_init_irq(dev, &s->irq); >> memory_region_init_io(&s->iomem, &imx_timerg_ops, >> - s, "im

Re: [Qemu-devel] [PULL 0/8] arm-devs queue

2013-06-25 Thread Peter Maydell
The signed tag itself is 'pull-arm-devs-20130625'; arm-devs.for-upstream >> is the branch name, as usual. >> >> >> The following changes since commit baf8673ca802cb3ea2cdbe94813441d23bde223b: >> >> Merge remote-tracking branch 'stefanha/block

Re: [Qemu-devel] [PATCH 10/15] target-i386: convert 'hv_spinlocks' to static property

2013-06-25 Thread Eduardo Habkost
On Tue, Jun 25, 2013 at 05:30:50PM -0300, Eduardo Habkost wrote: > On Wed, Jun 05, 2013 at 03:18:41PM +0200, Igor Mammedov wrote: > > Signed-off-by: Igor Mammedov > > --- > [...] > > @@ -1632,6 +1677,7 @@ static void cpu_x86_parse_featurestr(X86CPU *cpu, > > char *features, Error **errp) > >

Re: [Qemu-devel] [PATCH 10/15] target-i386: convert 'hv_spinlocks' to static property

2013-06-25 Thread Eduardo Habkost
On Wed, Jun 05, 2013 at 03:18:41PM +0200, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- [...] > @@ -1632,6 +1677,7 @@ static void cpu_x86_parse_featurestr(X86CPU *cpu, char > *features, Error **errp) > } else if (!strcmp(featurestr, "hv-spinlocks")) { > c

Re: [Qemu-devel] [PATCH v4 06/10] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-06-25 Thread Laszlo Ersek
On 06/25/13 20:23, Tomoki Sekiyama wrote: > On 6/25/13 12:03 , "Laszlo Ersek" wrote: >>> +ifeq ($(CONFIG_QGA_VSS),y) >>> +QEMU_CFLAGS += -DHAS_VSS_SDK >> >> Isn't this superfluous? First, I can find no other reference to >> HAS_VSS_SDK in the series, second, CONFIG_QGA_VSS would be available >> d

Re: [Qemu-devel] [PATCH 09/15] target-i386: move hyperv_* static globals to CPUState

2013-06-25 Thread Eduardo Habkost
On Wed, Jun 05, 2013 at 03:18:40PM +0200, Igor Mammedov wrote: > - since hyperv_* helper functions are used only in target-i386/kvm.c > move them there as static helpers > > Signed-off-by: Igor Mammedov > Requestd-By: Eduardo Habkost Reviewed-by: Eduardo Habkost -- Eduardo

[Qemu-devel] [Bug 1101210] Re: qemu 1.4.2: usb keyboard not fully working

2013-06-25 Thread Sven
Any comment? The <>| key is still not working in qemu 1.4.2. ** Summary changed: - qemu 1.3.0: usb keyboard not fully working + qemu 1.4.2: usb keyboard not fully working -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.

Re: [Qemu-devel] [PATCH v4 06/10] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-06-25 Thread Tomoki Sekiyama
>Il 25/06/2013 20:23, Tomoki Sekiyama ha scritto: >>> >(b) shouldn't "qga-obj-y" be independent of "qga-provider.dll" >> The DLL is linked to qemu-ga.exe because qemu-ga.exe kicks the >> registration of the DLL (COMRegister(), which depends on the DLL's >> Internal variable) at the installation of

Re: [Qemu-devel] [PULL 0/8] arm-devs queue

2013-06-25 Thread Anthony Liguori
Peter Maydell writes: > arm-devs pullreq; nothing particularly earthshattering. > As with the target-arm pullreq, I'm trying to create a signed > pullreq here, so let me know if I've messed it up. > The signed tag itself is 'pull-arm-devs-20130625'; arm-devs.for-u

Re: [Qemu-devel] [PATCH v4 06/10] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-06-25 Thread Paolo Bonzini
Il 25/06/2013 20:23, Tomoki Sekiyama ha scritto: >> >(b) shouldn't "qga-obj-y" be independent of "qga-provider.dll" > The DLL is linked to qemu-ga.exe because qemu-ga.exe kicks the > registration of the DLL (COMRegister(), which depends on the DLL's > Internal variable) at the installation of the q

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-06-25 Thread Michael R. Hines
On 06/25/2013 10:17 AM, Juan Quintela wrote: "Michael R. Hines" wrote: On 06/25/2013 06:13 AM, Paolo Bonzini wrote: Il 25/06/2013 11:49, Juan Quintela ha scritto: mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" As described in the previous patch, until now, the MIG_STATE_SETUP s

[Qemu-devel] [PULL 6/8] block/nand: QOM casting sweep

2013-06-25 Thread Peter Maydell
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style casting. Cc: afaer...@suse.de Signed-off-by: Peter Crosthwaite Reviewed-by: Andreas Färber Signed-off-by: Peter Maydell --- hw/block/nand.c | 25 - 1 file

[Qemu-devel] [PULL 5/8] i.MX31: Fix PRCS bit test

2013-06-25 Thread Peter Maydell
From: Stefan Weil cppcheck detected a condition which was always false. According to the MCIMX31 Reference Manual, the PRCS bits have to be 01 to select the Frequency Pre-Multiplier (FPM). PRCS uses bits 1 and 2, so we have to test for 2. Signed-off-by: Stefan Weil Signed-off-by: Peter Chubb

[Qemu-devel] [PULL 3/8] i.MX: Rework functions/types name and use new style initialization

2013-06-25 Thread Peter Maydell
From: Jean-Christophe DUBOIS * use dynamic cast whenever possible * Change function names to some more meaningful prefix * Change type names to a more meaningful one * use new style device initialization Signed-off-by: Jean-Christophe DUBOIS Message-id: 1369898943-1993-3-git-send-email-...@trib

[Qemu-devel] [PULL 0/8] arm-devs queue

2013-06-25 Thread Peter Maydell
arm-devs pullreq; nothing particularly earthshattering. As with the target-arm pullreq, I'm trying to create a signed pullreq here, so let me know if I've messed it up. The signed tag itself is 'pull-arm-devs-20130625'; arm-devs.for-upstream is the branch name, as usual. T

Re: [Qemu-devel] [PATCH v11 11/15] rdma: core logic

2013-06-25 Thread Michael R. Hines
On 06/25/2013 12:31 PM, Vasilis Liaskovitis wrote: Hi, On Mon, Jun 24, 2013 at 09:58:01PM -0400, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" [...] +/* + * Put in the log file which RDMA device was opened and the details + * associated with that device. + */ +static void qemu_

Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer.

2013-06-25 Thread Paolo Bonzini
Il 25/06/2013 20:21, Peter Maydell ha scritto: > @@ -416,7 +513,7 @@ static int imx_timerg_init(SysBusDevice *dev) > > sysbus_init_irq(dev, &s->irq); > memory_region_init_io(&s->iomem, &imx_timerg_ops, > - s, "imxg-timer", > + s, TYPE_IM

[Qemu-devel] [PULL 8/8] nand: Don't inherit from Sysbus

2013-06-25 Thread Peter Maydell
From: Peter Crosthwaite Nand chips are not sysbus devices - they do not have any sense of MMIO, nor interrupts. Re-parent to TYPE_DEVICE accordingly. Cc: afaer...@suse.de Signed-off-by: Peter Crosthwaite Reviewed-by: Andreas Färber Signed-off-by: Peter Maydell --- hw/block/nand.c |7 +++

Re: [Qemu-devel] [PATCH v4 06/10] qemu-ga: Add Windows VSS provider to quiesce applications on fsfreeze

2013-06-25 Thread Tomoki Sekiyama
Thanks for your review. On 6/25/13 12:03 , "Laszlo Ersek" wrote: >I'm trying to wrap my head around the build changes first. >> diff --git a/configure b/configure >> index cafe830..8e45fad 100755 >> --- a/configure >> +++ b/configure >> @@ -3490,9 +3490,12 @@ if test "$softmmu" = yes ; then >>

[Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer.

2013-06-25 Thread Peter Maydell
From: Jean-Christophe DUBOIS * implement compare 1 2 and 3 registers * simplify Debug printf Signed-off-by: Jean-Christophe DUBOIS Message-id: 1369898943-1993-2-git-send-email-...@tribudubois.net Reviewed-by: Peter Chubb Signed-off-by: Peter Maydell --- hw/timer/imx_gpt.c | 443

[Qemu-devel] [PULL 4/8] arm/boot: Free dtb blob memory after use

2013-06-25 Thread Peter Maydell
The dtb blob returned by load_device_tree() is in memory allocated with g_malloc(). Free it accordingly once we have copied its contents into the guest memory. To make this easy, we need also to clean up the error handling in load_dtb() so that we consistently handle errors in the same way (by prin

[Qemu-devel] [PULL 7/8] block/nand: Convert Sysbus::init to Device::realize

2013-06-25 Thread Peter Maydell
From: Peter Crosthwaite The prescribed transition from Sysbus::init function to a Device::realize. Cc: afaer...@suse.de Signed-off-by: Peter Crosthwaite Reviewed-by: Andreas Färber Signed-off-by: Peter Maydell --- hw/block/nand.c | 16 +++- 1 file changed, 7 insertions(+), 9 d

[Qemu-devel] [PULL 1/8] ARM: Allow dumping of device tree

2013-06-25 Thread Peter Maydell
From: John Rigby By calling qemu_devtree_dumpdtb near the end of load_dtb. Signed-off-by: John Rigby Signed-off-by: Peter Maydell --- hw/arm/boot.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index defcf15..797c691 100644 --- a/hw/arm/boot.c +++ b/hw/a

Re: [Qemu-devel] [PATCH v1 0/5] Nand Cleanup

2013-06-25 Thread Peter Maydell
On 18 June 2013 12:07, wrote: > From: Peter Crosthwaite > > > Misc refactorings and cleanup of NAND. > > > Peter Crosthwaite (5): > block/nand: Factor out common code > block/nand: Formatting sweep > block/nand: QOM casting sweep > block/nand: Convert Sysbus::init to Device::realize >

Re: [Qemu-devel] [PATCH] block: add drive_backup HMP command

2013-06-25 Thread Ian Main
On Tue, Jun 25, 2013 at 04:36:53PM +0200, Paolo Bonzini wrote: > Il 25/06/2013 16:06, Kevin Wolf ha scritto: > > Am 25.06.2013 um 15:49 hat Paolo Bonzini geschrieben: > >> Il 25/06/2013 15:26, Kevin Wolf ha scritto: > > +if (!full) { > > +error_setg(&errp, "-f is not yet impleme

[Qemu-devel] [PULL 5/8] target-arm: Initialize cpreg list from KVM when using KVM

2013-06-25 Thread Peter Maydell
When using KVM, use the kernel's initial state to set up the cpreg list, and sync to and from the kernel when doing migration. Signed-off-by: Peter Maydell --- target-arm/Makefile.objs |1 + target-arm/kvm-stub.c| 23 +++ target-arm/kvm.c | 164

[Qemu-devel] [PULL 1/8] target-arm: Allow special cpregs to have flags set

2013-06-25 Thread Peter Maydell
Relax the "is this a valid ARMCPRegInfo type value?" check to permit "special" cpregs to have flags other than ARM_CP_SPECIAL set. At the moment none of the other flags are relevant for special regs, but the migration related flag we're about to introduce can apply here too. Signed-off-by: Peter M

[Qemu-devel] [PULL 0/8] target-arm queue

2013-06-25 Thread Peter Maydell
m is still a branch name as usual; the signed tag is "pull-target-arm-20130625"; I'm not sure whether the tag should be the thing named in the 'available at' line below rather than the branch. The following changes since commit baf8673ca802cb3ea2cdbe94813441d23bde22

[Qemu-devel] [PULL 6/8] target-arm: Reinitialize all KVM VCPU registers on reset

2013-06-25 Thread Peter Maydell
Since the ARM KVM API doesn't include a "reset this VCPU" ioctl, we have to capture the initial values of every register it knows about so that we can reset the VCPU by feeding those values back again. Signed-off-by: Peter Maydell --- target-arm/cpu-qom.h |6 +- target-arm/kvm.c |

Re: [Qemu-devel] [PATCH 21/26] kvmclock: use realize for kvmclock

2013-06-25 Thread Eduardo Habkost
On Tue, Jun 25, 2013 at 10:20:08AM +0800, Hu Tao wrote: [...] > > Is TYPE_SYS_BUS_DEVICE guaranteed to never override ->realize() itself? > > > > From DeviceClass documentation: > > > > * If a type derived directly from TYPE_DEVICE implements @realize, it does > > * not need to implement @init

[Qemu-devel] [PULL 3/8] target-arm: mark up cpregs for no-migrate or raw access

2013-06-25 Thread Peter Maydell
Mark up coprocessor register definitions to add raw access functions or mark the register as non-migratable where necessary. Signed-off-by: Peter Maydell --- target-arm/helper.c | 140 ++- 1 file changed, 94 insertions(+), 46 deletions(-) diff --

[Qemu-devel] [PULL 8/8] target-arm: Make LPAE feature imply V7MP

2013-06-25 Thread Peter Maydell
The v7 ARM ARM specifies that the Large Physical Address Extension requires implementation of the Multiprocessing Extensions, so make our LPAE feature imply V7MP rather than specifying both in the A15 CPU initfn. Signed-off-by: Peter Maydell Reviewed-by: Andreas Färber Message-id: 1371127899-103

Re: [Qemu-devel] [PATCH] i.MX31: Fix PRCS bit test

2013-06-25 Thread Peter Maydell
On 9 June 2013 21:44, Stefan Weil wrote: > cppcheck detected a condition which was always false. > > According to the MCIMX31 Reference Manual, the PRCS bits have to be 01 > to select the Frequency Pre-Multiplier (FPM). PRCS uses bits 1 and 2, > so we have to test for 2. > > Signed-off-by: Stefan

[Qemu-devel] [PULL 4/8] target-arm: Convert TCG to using (index, value) list for cp migration

2013-06-25 Thread Peter Maydell
Convert the TCG ARM target to using an (index,value) list for migrating coprocessors. The primary benefit of the (index,value) list is for passing state between KVM and QEMU, but it works for TCG-to-TCG migration as well and is a useful self-contained first step. Signed-off-by: Peter Maydell ---

[Qemu-devel] [PULL 7/8] target-arm: Use tuple list to sync cp regs with KVM

2013-06-25 Thread Peter Maydell
Use the tuple list of cp registers for syncing KVM state to QEMU, rather than only syncing a very minimal set by hand. Signed-off-by: Peter Maydell --- target-arm/kvm.c | 103 +- 1 file changed, 33 insertions(+), 70 deletions(-) diff --git a/

[Qemu-devel] [PULL 2/8] target-arm: Add raw_readfn and raw_writefn to ARMCPRegInfo

2013-06-25 Thread Peter Maydell
For reading and writing register values from the kernel for KVM, we need to provide accessor functions which are guaranteed to succeed and don't impose access checks, mask out unwritable bits, etc. Define new fields raw_readfn and raw_writefn for this purpose; these only need to be provided if ther

Re: [Qemu-devel] [PATCH arm-devs v1 1/1] char/cadence_uart: Fix reset for unattached instances

2013-06-25 Thread Peter Maydell
On 7 June 2013 05:02, wrote: > From: Peter Crosthwaite > > commit 1db8b5efe0c2b5000e50691eea61264a615f43de introduced an issue > where QEMU would segfault if you have an unattached Cadence UART. > > Fix by guarding the flush-on-reset logic on there being a qemu_chr > attachment. > > Reported-by:

[Qemu-devel] [PATCH] block/ssh: Set bdrv_has_zero_init according to the file type.

2013-06-25 Thread Richard W.M. Jones
From: "Richard W.M. Jones" If the remote is a regular file, set it to true (ie. reads of uninitialized areas in a newly created file will return zeroes). If we can't prove that, return false (a safe default). Tested by adding a debugging print statement [not part of this commit] and creating a r

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-06-25 Thread Michael R. Hines
On 06/25/2013 10:55 AM, Paolo Bonzini wrote: Il 25/06/2013 16:54, Michael R. Hines ha scritto: Do those few lines of code change the protocol? If yes, I'll go against all my previous recommendations and suggest a #define. If no, it is fine to leave it for later, but I would still suggest posti

Re: [Qemu-devel] [PATCH v11 14/15] rdma: introduce MIG_STATE_NONE and change MIG_STATE_SETUP state transition

2013-06-25 Thread Michael R. Hines
On 06/25/2013 10:17 AM, Juan Quintela wrote: "Michael R. Hines" wrote: On 06/25/2013 06:13 AM, Paolo Bonzini wrote: Il 25/06/2013 11:49, Juan Quintela ha scritto: mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" As described in the previous patch, until now, the MIG_STATE_SETUP s

Re: [Qemu-devel] [PATCH v11 11/15] rdma: core logic

2013-06-25 Thread Paolo Bonzini
Il 25/06/2013 18:31, Vasilis Liaskovitis ha scritto: > Then I think qemu_rdma_dump_id can segfault trying to dereference a null verbs > structure. The dump_id function should check for non-NULL verbs argument, > or the dump should be made only in the (verbs != NULL) if clause. > > Disabling the du

[Qemu-devel] [PULL v2 18/21] pci: Simpler implementation of primary PCI bus

2013-06-25 Thread Michael S. Tsirkin
From: David Gibson Currently pci_find_primary_bus() searches the list of root buses for one with domain 0. But since host buses are always registered with domain 0, this just amounts to finding the only PCI host bus. The only remaining users of pci_find_primary_bus() are in pci-hotplug-old.c, w

  1   2   3   >