Re: [Qemu-devel] [PATCH v3 15/16] boot-order-test: Support fw_cfg in I/O space

2013-06-18 Thread Markus Armbruster
Anthony Liguori writes: > Markus Armbruster writes: > >> Next commit needs it. >> >> Cc: Blue Swirl >> Signed-off-by: Markus Armbruster >> --- >> tests/boot-order-test.c | 24 >> 1 file changed, 16 insertions(+), 8 deletions(-) >> >> diff --git a/tests/boot-order-test

Re: [Qemu-devel] [PATCH] block: add 'backing' option to drive_add

2013-06-18 Thread Markus Armbruster
Fam Zheng writes: > On Tue, 06/18 16:18, Markus Armbruster wrote: >> Fam Zheng writes: >> >> > On Tue, 06/18 08:32, Kevin Wolf wrote: >> >> Am 18.06.2013 um 05:58 hat Fam Zheng geschrieben: >> >> > On Mon, 06/17 17:12, Kevin Wolf wrote: >> >> > > Am 17.06.2013 um 16:46 hat Paolo Bonzini geschri

Re: [Qemu-devel] [PATCH V2] build: remove compile warning

2013-06-18 Thread Wenchao Xia
于 2013-6-18 18:13, Paolo Bonzini 写道: Il 07/06/2013 14:17, Markus Armbruster ha scritto: diff --git a/util/iov.c b/util/iov.c index cc6e837..b91cfb9 100644 --- a/util/iov.c +++ b/util/iov.c @@ -146,7 +146,7 @@ ssize_t iov_send_recv(int sockfd, struct iovec *iov, unsigned iov_cnt, { ssize

Re: [Qemu-devel] [PATCH V2 12/12] qemu-iotests: add 055 internal snapshot for block device test case

2013-06-18 Thread Wenchao Xia
于 2013-6-18 22:32, Stefan Hajnoczi 写道: On Fri, Jun 14, 2013 at 07:39:59PM +0800, Wenchao Xia wrote: Signed-off-by: Wenchao Xia --- tests/qemu-iotests/055 | 157 tests/qemu-iotests/055.out |5 ++ drive-backup already uses 055, please name

Re: [Qemu-devel] [PATCH V2 09/12] qmp: add interface blockdev-snapshot-delete-internal-sync

2013-06-18 Thread Wenchao Xia
于 2013-6-18 22:20, Stefan Hajnoczi 写道: On Mon, Jun 17, 2013 at 11:25:26AM +0800, Wenchao Xia wrote: 于 2013-6-15 17:55, Eric Blake 写道: Should this command be made available via 'transaction'? That is, if I have a two-disk VM, and use 'transaction' to take a snapshot of both disks at once, shoul

Re: [Qemu-devel] [Bug 1191606] Re: qemu crashes with iscsi initiator (libiscsi) when using virtio

2013-06-18 Thread ronnie sahlberg
I can reproduce with current QEMU. Ubuntu 13 crashes with if=virtio but if=ide is fine. But it seems dependent on the guest/kernel. For example Fedora-18-x86_64-Live-Desktop.iso installs and runs just fine, even with virtio But both ubuntu-12.04-desktop-amd64.iso or ubuntu-13.04-desktop-amd64.

[Qemu-devel] [PATCH resend] pci-assign: remove the duplicate function name in debug message

2013-06-18 Thread Wanlong Gao
While DEBUG() already includes the function name. Signed-off-by: Wanlong Gao Acked-by: Alex Williamson --- hw/i386/kvm/pci-assign.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c index ff85590..9896c28 100644

[Qemu-devel] [PATCH] eepro100: fix compile warning

2013-06-18 Thread Wanlong Gao
hw/net/eepro100.c:108:0: error: "BIT" redefined [-Werror] In file included from /work/git/qemu/include/qemu/bitmap.h:16:0, from /work/git/qemu/include/sysemu/sysemu.h:12, from hw/net/eepro100.c:48: /work/git/qemu/include/qemu/bitops.h:21:0: note: this is the locati

[Qemu-devel] [Bug 1192344] [NEW] qemu crashes on unaligned extended disk reads

2013-06-18 Thread Andrew McGowen
Public bug reported: When performing a BIOS extended disk read (INT 13H, AH=0x42), if the offset of the buffer destination in the DAP (disk address packet) is not dword-aligned (i.e. a multiple of 4), SeaBIOS attempts to execute code at non-mapped address 0xb4f53, causing QEMU to crash. I imagine

Re: [Qemu-devel] Java volatile vs. C11 seq_cst (was Re: [PATCH v2 1/2] add a header file for atomic operations)

2013-06-18 Thread Paul E. McKenney
On Tue, Jun 18, 2013 at 06:38:38PM +0200, Torvald Riegel wrote: > On Tue, 2013-06-18 at 18:08 +0200, Paolo Bonzini wrote: > > Il 18/06/2013 16:50, Paul E. McKenney ha scritto: > > > PS: Nevertheless, I personally prefer the C++ formulation, but that is > > > only because I stand with one foot

Re: [Qemu-devel] Java volatile vs. C11 seq_cst (was Re: [PATCH v2 1/2] add a header file for atomic operations)

2013-06-18 Thread Paul E. McKenney
On Tue, Jun 18, 2013 at 05:37:42PM +0200, Torvald Riegel wrote: > On Tue, 2013-06-18 at 07:50 -0700, Paul E. McKenney wrote: > > First, I am not a fan of SC, mostly because there don't seem to be many > > (any?) production-quality algorithms that need SC. But if you really > > want to take a paral

Re: [Qemu-devel] [RFC PATCH v1 0/7] QOM Super class access

2013-06-18 Thread Hu Tao
On Tue, Jun 18, 2013 at 12:41:29PM +0200, Andreas Färber wrote: > Am 18.06.2013 12:23, schrieb Michael S. Tsirkin: > > On Tue, Jun 18, 2013 at 07:43:11PM +1000, peter.crosthwa...@xilinx.com > > wrote: > >> From: Peter Crosthwaite > >> > >> > >> This series enables QOM super class access and demos

Re: [Qemu-devel] [PATCH] block: add 'backing' option to drive_add

2013-06-18 Thread Fam Zheng
On Tue, 06/18 16:18, Markus Armbruster wrote: > Fam Zheng writes: > > > On Tue, 06/18 08:32, Kevin Wolf wrote: > >> Am 18.06.2013 um 05:58 hat Fam Zheng geschrieben: > >> > On Mon, 06/17 17:12, Kevin Wolf wrote: > >> > > Am 17.06.2013 um 16:46 hat Paolo Bonzini geschrieben: > >> > > > Il 17/06/20

Re: [Qemu-devel] [PATCH RFC v2 0/7] coordinate cpu hotplug/unplug bewteen QEMU and kernel by EC

2013-06-18 Thread li guang
在 2013-06-18二的 11:14 +0200,Igor Mammedov写道: > On Tue, 18 Jun 2013 10:47:15 +0800 > li guang wrote: > > > Hi, Igor and Micheal > > > > 在 2013-06-06四的 16:33 +0800,li guang写道: > > > 在 2013-06-06四的 11:13 +0300,Michael S. Tsirkin写道: > > > > On Thu, Jun 06, 2013 at 11:16:53AM +0800, liguang wrote: > >

Re: [Qemu-devel] [RFC PATCH 0/4] per-object libraries

2013-06-18 Thread Michael Tokarev
18.06.2013 21:34, Michael Tokarev wrote: > The following working patchset demonstrates a one step to plugins system: > it moves various dependent libraries and stuff out from libs_softmmu or > libs_tools to object-specific variables. When that object is linked > into final executable, correspondin

Re: [Qemu-devel] [PATCH] kvmclock: clock should count only if vm is running

2013-06-18 Thread Marcelo Tosatti
On Tue, Jun 18, 2013 at 11:02:27AM +0200, Paolo Bonzini wrote: > Hi Marcelo, sorry for the late review. > > Il 08/06/2013 04:00, Marcelo Tosatti ha scritto: > > kvmclock should not count while vm is paused, because: > > > > 1) if the vm is paused for long periods, timekeeping > > math can overfl

[Qemu-devel] [PATCH] kvmclock: clock should count only if vm is running (v2)

2013-06-18 Thread Marcelo Tosatti
v2: remove unnecessary runstate_is_running() usage (Paolo) -- kvmclock should not count while vm is paused, because: 1) if the vm is paused for long periods, timekeeping math can overflow while converting the (large) clocksource delta to nanoseconds. 2) Users rely on CLOCK_MONOTONIC to count r

Re: [Qemu-devel] [PATCH 1/2] hw/loader: Support ramdisk with u-boot header

2013-06-18 Thread Peter Crosthwaite
Hi Soren, On Sat, Jun 15, 2013 at 3:14 AM, Sören Brinkmann wrote: > Hi Peter, > > On Fri, Jun 14, 2013 at 05:56:31PM +0100, Peter Maydell wrote: >> On 14 June 2013 17:36, Soren Brinkmann wrote: >> > Introduce 'load_ramdisk()' which can load "normal" ramdisks and ramdisks >> > with a u-boot heade

Re: [Qemu-devel] [0/3] Accumulated ppc patches

2013-06-18 Thread Alexey Kardashevskiy
On 06/19/2013 01:49 AM, Alexander Graf wrote: > > On 15.06.2013, at 03:51, David Gibson wrote: > >> Hi Alex, >> >> I see that you're now back from your holiday. Here, rather >> belatedly, is my series of ppc related patches collected while acting >> ppc maintainer. As you can see there aren't

Re: [Qemu-devel] [PATCH 2/2] intc/openpic: Convert to QOM realize

2013-06-18 Thread Peter Crosthwaite
Hi Andreas, On Wed, Jun 19, 2013 at 1:49 AM, Andreas Färber wrote: > Hi, > > Am 18.06.2013 05:28, schrieb Peter Crosthwaite: >> On Tue, Jun 18, 2013 at 11:58 AM, Andreas Färber wrote: >>> Split qdev initfn into instance_init and realize functions. >>> Change one occurrence of "klass" while at it

Re: [Qemu-devel] [PATCH v2 2/2] QEMUBH: make AioContext's bh re-entrant

2013-06-18 Thread mdroth
On Tue, Jun 18, 2013 at 09:20:26PM +0200, Paolo Bonzini wrote: > Il 18/06/2013 17:14, mdroth ha scritto: > > Could we possibly simplify this by introducing a recursive mutex that we > > could use to protect the whole list loop and hold even during the cb? > > If it is possible, we should avoid rec

Re: [Qemu-devel] RFC: DSO (dynamic shared objects) support

2013-06-18 Thread Richard Henderson
On 06/18/2013 01:15 PM, Daniel P. Berrange wrote: > By having all the private symbols change their version tag on every > release, we make it a total PITA for anyone to provide closed source, > out of tree, third party modules. Which is nice a feature :-) Using a symbol version file also means tha

Re: [Qemu-devel] [Xen-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-18 Thread Andreas Färber
Am 18.06.2013 21:35, schrieb Stefano Stabellini: > On Tue, 18 Jun 2013, Paolo Bonzini wrote: >> Il 18/06/2013 20:56, Stefano Stabellini ha scritto: >>> xenfv-2.0 is a bad idea, like Paolo wrote, it should be possible to just >>> use -M pc for HVM guests and retain -M xenpv for pv guests. >>> >>> Ho

Re: [Qemu-devel] RFC: DSO (dynamic shared objects) support

2013-06-18 Thread Peter Maydell
On 18 June 2013 21:19, Daniel P. Berrange wrote: > For example, use ELF symbol versioning > and make the version tags change on every single minor release Change on every git commit hash, please. Otherwise I bet there are going to be a lot of random weird failures in development due to things get

[Qemu-devel] [PATCH v10 07/14] rdma: introduce ram_handle_compressed()

2013-06-18 Thread mrhines
From: "Michael R. Hines" This gives RDMA shared access to madvise() on the destination side when an entire chunk is found to be zero. Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vinod Reviewed-by: Eric Blake Tested-by: Chegu Vinod Tested-by: Michael R. Hines Signed-off-by: Michael R. Hine

Re: [Qemu-devel] Java volatile vs. C11 seq_cst (was Re: [PATCH v2 1/2] add a header file for atomic operations)

2013-06-18 Thread Torvald Riegel
On Tue, 2013-06-18 at 07:50 -0700, Paul E. McKenney wrote: > First, I am not a fan of SC, mostly because there don't seem to be many > (any?) production-quality algorithms that need SC. But if you really > want to take a parallel-programming trip back to the 1980s, let's go! ;-) Dekker-style mut

Re: [Qemu-devel] Java volatile vs. C11 seq_cst (was Re: [PATCH v2 1/2] add a header file for atomic operations)

2013-06-18 Thread Andrew Haley
On 06/18/2013 02:24 PM, Paolo Bonzini wrote: > Or is Java volatile somewhere between acq_rel and seq_cst, as the last > paragraph of > http://www.cs.umd.edu/~pugh/java/memoryModel/jsr-133-faq.html#volatile > seems to suggest? As far as I know, the Java semantics are acq/rel. I can't see anything

Re: [Qemu-devel] Java volatile vs. C11 seq_cst (was Re: [PATCH v2 1/2] add a header file for atomic operations)

2013-06-18 Thread Torvald Riegel
On Tue, 2013-06-18 at 18:08 +0200, Paolo Bonzini wrote: > Il 18/06/2013 16:50, Paul E. McKenney ha scritto: > > PS: Nevertheless, I personally prefer the C++ formulation, but that is > > only because I stand with one foot in theory and the other in > > practice. If I were a pure practit

Re: [Qemu-devel] Java volatile vs. C11 seq_cst (was Re: [PATCH v2 1/2] add a header file for atomic operations)

2013-06-18 Thread Torvald Riegel
On Tue, 2013-06-18 at 15:24 +0200, Paolo Bonzini wrote: > Il 17/06/2013 20:57, Richard Henderson ha scritto: > >> + * And for the few ia64 lovers that exist, an atomic_mb_read is a ld.acq, > >> + * while an atomic_mb_set is a st.rel followed by a memory barrier. > > ... > >> + */ > >> +#ifndef atom

Re: [Qemu-devel] Java volatile vs. C11 seq_cst (was Re: [PATCH v2 1/2] add a header file for atomic operations)

2013-06-18 Thread Peter Sewell
On 18 June 2013 15:50, Paul E. McKenney wrote: > On Tue, Jun 18, 2013 at 03:24:24PM +0200, Paolo Bonzini wrote: >> Il 17/06/2013 20:57, Richard Henderson ha scritto: >> >> + * And for the few ia64 lovers that exist, an atomic_mb_read is a ld.acq, >> >> + * while an atomic_mb_set is a st.rel follow

Re: [Qemu-devel] Java volatile vs. C11 seq_cst (was Re: [PATCH v2 1/2] add a header file for atomic operations)

2013-06-18 Thread Paul E. McKenney
On Tue, Jun 18, 2013 at 03:24:24PM +0200, Paolo Bonzini wrote: > Il 17/06/2013 20:57, Richard Henderson ha scritto: > >> + * And for the few ia64 lovers that exist, an atomic_mb_read is a ld.acq, > >> + * while an atomic_mb_set is a st.rel followed by a memory barrier. > > ... > >> + */ > >> +#ifnd

[Qemu-devel] [PATCH v10 08/14] rdma: introduce qemu_ram_foreach_block()

2013-06-18 Thread mrhines
From: "Michael R. Hines" This is used during RDMA initialization in order to transmit a description of all the RAM blocks to the peer for later dynamic chunk registration purposes. Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vinod Reviewed-by: Eric Blake Tested-by: Chegu Vinod Tested-by: M

[Qemu-devel] [PATCH v10 12/14] rdma: send pc.ram

2013-06-18 Thread mrhines
From: "Michael R. Hines" This takes advantages of the previous patches: 1. use the new QEMUFileOps hook 'save_page' 2. call out to the right accessor methods to invoke the iteration hooks defined in QEMUFileOps Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vinod Reviewed-by: Eric Blake T

[Qemu-devel] [PATCH v10 04/14] rdma: export throughput w/ MigrationStats QMP

2013-06-18 Thread mrhines
From: "Michael R. Hines" This exposes throughput (in megabits/sec) through QMP. Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vinod Reviewed-by: Eric Blake Tested-by: Chegu Vinod Tested-by: Michael R. Hines Signed-off-by: Michael R. Hines --- hmp.c |2 ++ inclu

[Qemu-devel] [PATCH v10 02/14] rdma: introduce qemu_update_position()

2013-06-18 Thread mrhines
From: "Michael R. Hines" RDMA writes happen asynchronously, and thus the performance accounting also needs to be able to occur asynchronously. This allows anybody to call into savevm.c to update both f->pos as well as into arch_init.c to update the acct_info structure with up-to-date values when

[Qemu-devel] [PATCH v10 05/14] rdma: introduce qemu_file_mode_is_not_valid()

2013-06-18 Thread mrhines
From: "Michael R. Hines" QEMUFileRDMA also has read and write modes. This function is now shared to reduce code duplication. Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vinod Reviewed-by: Eric Blake Tested-by: Chegu Vinod Tested-by: Michael R. Hines Signed-off-by: Michael R. Hines --- i

[Qemu-devel] [PATCH trivial] Makefile.objs: do not link block/ twice

2013-06-18 Thread Michael Tokarev
$(block-obj-y) already includes block/, so there's no need to add it explicitly to $(common-obj-y). Signed-off-by: Michael Tokarev --- Makefile.objs |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.objs b/Makefile.objs index 5b288ba..24c74a8 100644 --- a/Makefile.o

Re: [Qemu-devel] [PATCH v9 14/14] rdma: add pin-all accounting timestamp to QMP statistics

2013-06-18 Thread Michael R. Hines
On 06/16/2013 02:37 PM, Chegu Vinod wrote: On 6/14/2013 1:35 PM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" For very large virtual machines, pinning can take a long time. While this does not affect the migration's *actual* time itself, it is still important for the user to know

Re: [Qemu-devel] [PATCH 3/7] NUMA: parse guest numa nodes memory policy

2013-06-18 Thread Bandan Das
Eduardo Habkost writes: > On Tue, Jun 18, 2013 at 11:20:37AM +0200, Paolo Bonzini wrote: > [...] >> Also, please use QemuOpts instead of yet another homegrown parser. >> Eduardo, I think you had the most recent attempt to convert -numa to >> QemuOpts? > > I had one, but I believe it is more compl

[Qemu-devel] [PATCH v10 01/14] rdma: add documentation

2013-06-18 Thread mrhines
From: "Michael R. Hines" docs/rdma.txt contains full documentation, wiki links, github url and contact information. Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vinod Reviewed-by: Eric Blake Tested-by: Chegu Vinod Tested-by: Michael R. Hines Signed-off-by: Michael R. Hines --- docs/rdma.

[Qemu-devel] [PATCH v10 13/14] rdma: fix mlock() freezes and accounting

2013-06-18 Thread mrhines
From: "Michael R. Hines" This patch is contained to migration-rdma.c and fixes the problems experienced by others when the x-rdma-pin-all feature appeared to freeze the VM. By moving this operation out of the connection setup time and instead moving it to ram_save_setup() code, we no longer execu

[Qemu-devel] [PATCH v10 00/14] rdma: migration support

2013-06-18 Thread mrhines
From: "Michael R. Hines" Please pull. Changes since v9: patch #14, #4, and #10 : Insted of timing just the pinning, we now time the entire setup phase of migration. This requires postponing MIG_STATE_ACTIVE initialization to the migration_thread instead of the QMP command. Also

[Qemu-devel] [PATCH v10 10/14] rdma: introduce capability x-rdma-pin-all

2013-06-18 Thread mrhines
From: "Michael R. Hines" This capability allows you to disable dynamic chunk registration for better throughput on high-performance links. For example, using an 8GB RAM virtual machine with all 8GB of memory in active use and the VM itself is completely idle using a 40 gbps infiniband link: 1.

Re: [Qemu-devel] RFC: DSO (dynamic shared objects) support

2013-06-18 Thread Daniel P. Berrange
On Tue, Jun 18, 2013 at 07:42:11AM -0500, Anthony Liguori wrote: > Hi, > > On Tue, Jun 18, 2013 at 6:37 AM, Michael Tokarev wrote: > > Hello. > > > > I looked at what's needed to support DSO (dynamic shared objects) > > in qemu, in order to be able to split functionality into loadable > > "plugin

[Qemu-devel] [PATCH v10 03/14] rdma: export yield_until_fd_readable()

2013-06-18 Thread mrhines
From: "Michael R. Hines" The RDMA event channel can be made non-blocking just like a TCP socket. Exporting this function allows us to yield so that the QEMU monitor remains available. Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vinod Reviewed-by: Eric Blake Tested-by: Chegu Vinod Tested-by

[Qemu-devel] [PATCH v10 09/14] rdma: new QEMUFileOps hooks

2013-06-18 Thread mrhines
From: "Michael R. Hines" These are the prototypes and implementation of new hooks that RDMA takes advantage of to perform dynamic page registration. An optional hook is also introduced for a custom function to be able to override the default save_page function. Also included are the prototypes

[Qemu-devel] [PATCH v10 14/14] rdma: add setup time accounting to QMP statistics

2013-06-18 Thread mrhines
From: "Michael R. Hines" For very large virtual machines, pinning can take a long time. While this does not affect the migration's *actual* time itself, it is still important for the user to know what's going on and to know what component of the total time is actual taken up by pinning. For exam

[Qemu-devel] [PATCH v10 06/14] rdma: export qemu_fflush()

2013-06-18 Thread mrhines
From: "Michael R. Hines" RDMA uses this to flush the control channel before sending its own message to handle page registrations. Reviewed-by: Paolo Bonzini Reviewed-by: Chegu Vinod Reviewed-by: Eric Blake Tested-by: Chegu Vinod Tested-by: Michael R. Hines Signed-off-by: Michael R. Hines -

Re: [Qemu-devel] RFC: DSO (dynamic shared objects) support

2013-06-18 Thread Daniel P. Berrange
On Tue, Jun 18, 2013 at 02:17:08PM +0200, Laszlo Ersek wrote: > On 06/18/13 13:37, Michael Tokarev wrote: > > > Next, and this is the most complex part. The build system for > > modules, and configuring it. I heard there were plans to use > > something like kbuild system for that, has anything

Re: [Qemu-devel] [Xen-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-18 Thread Stefano Stabellini
On Tue, 18 Jun 2013, Paolo Bonzini wrote: > Il 18/06/2013 20:56, Stefano Stabellini ha scritto: > >> > > >> > Ok. I guess we can have the ability to override the machine type in the > >> > VM config, so you could still kick off an older qemu with a newer libxl > >> > - but it sounds like the aut

Re: [Qemu-devel] RFC: DSO (dynamic shared objects) support

2013-06-18 Thread Richard Henderson
On 06/18/2013 04:37 AM, Michael Tokarev wrote: > First of all, we need a global config switch/check for this kind of > service. On a POSIX system this should make the executable to be > linked with -rdynamic option, in order to make all symbols in the > executable to be available to plugins. The

[Qemu-devel] [PATCH v3] vl.c: Support multiple CPU ranges on -numa option

2013-06-18 Thread Bandan Das
This allows us to use the cpu property multiple times to specify multiple cpu (ranges) to the -numa option : -numa node,cpu=1,cpu=2,cpu=4 or -numa node,cpu=1-3,cpu=5 Signed-off-by: Bandan Das --- v3: Convert to using QemuOpts Use -cpu rather than -cpus which probably probably makes it more m

Re: [Qemu-devel] [Bug 1191606] Re: qemu crashes with iscsi initiator (libiscsi) when using virtio

2013-06-18 Thread Laszlo Ersek
On 06/18/13 20:01, Klaus Hochlehnert wrote: > I'll see what I can do to recompile qemu with debugging information. > Maybe tomorrow. > > But one other question. I thought this is the "normal" qemu bug > reporting or is it Ubuntu only? I tried with the latest release and > followed the "Report a b

Re: [Qemu-devel] [PATCH v2 2/2] QEMUBH: make AioContext's bh re-entrant

2013-06-18 Thread Paolo Bonzini
Il 18/06/2013 17:14, mdroth ha scritto: > Could we possibly simplify this by introducing a recursive mutex that we > could use to protect the whole list loop and hold even during the cb? If it is possible, we should avoid recursive locks. It makes impossible to establish a lock hierarchy. For ex

Re: [Qemu-devel] [Xen-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-18 Thread Paolo Bonzini
Il 18/06/2013 20:56, Stefano Stabellini ha scritto: >> > >> > Ok. I guess we can have the ability to override the machine type in the VM >> > config, so you could still kick off an older qemu with a newer libxl - but >> > it sounds like the auto-discovery idea is a no-go then. > xenfv-2.0 is a b

Re: [Qemu-devel] [PATCH 3/7] NUMA: parse guest numa nodes memory policy

2013-06-18 Thread Eduardo Habkost
On Tue, Jun 18, 2013 at 11:20:37AM +0200, Paolo Bonzini wrote: [...] > Also, please use QemuOpts instead of yet another homegrown parser. > Eduardo, I think you had the most recent attempt to convert -numa to > QemuOpts? I had one, but I believe it is more complex than it should have been. I was c

Re: [Qemu-devel] [Xen-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-18 Thread Stefano Stabellini
On Fri, 14 Jun 2013, Paul Durrant wrote: > > -Original Message- > > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > > Bonzini > > Sent: 14 June 2013 15:58 > > To: Paul Durrant > > Cc: Ian Campbell; Stefano Stabellini; qemu-devel@nongnu.org; xen- > > de...@lists.xen

Re: [Qemu-devel] [PATCH v2] wdt_i6300esb: fix vmstate versioning

2013-06-18 Thread Juan Quintela
mdroth wrote: > On Tue, Jun 11, 2013 at 04:53:51PM -0500, mdroth wrote: >> On Wed, May 22, 2013 at 11:32:51AM -0500, Michael Roth wrote: >> > When this VMSD was introduced it's version fields were set to >> > sizeof(I6300State), making them essentially random from build to build, >> > version to v

Re: [Qemu-devel] [PATCH v2] wdt_i6300esb: fix vmstate versioning

2013-06-18 Thread Anthony Liguori
mdroth writes: > On Tue, Jun 11, 2013 at 04:53:51PM -0500, mdroth wrote: >> On Wed, May 22, 2013 at 11:32:51AM -0500, Michael Roth wrote: >> > When this VMSD was introduced it's version fields were set to >> > sizeof(I6300State), making them essentially random from build to build, >> > version to

Re: [Qemu-devel] [Qemu-stable] [PATCH] acl: acl_add can't insert before last list element, fix

2013-06-18 Thread mdroth
On Tue, Jun 18, 2013 at 10:05:23AM +0200, Markus Armbruster wrote: > Watch this: > > $ upstream-qemu -nodefaults -S -vnc :0,acl,sasl -monitor stdio > QEMU 1.5.50 monitor - type 'help' for more information > (qemu) acl_add vnc.username drei allow > acl: added rule at position 1 >

[Qemu-devel] [Bug 1191606] Re: qemu crashes with iscsi initiator (libiscsi) when using virtio

2013-06-18 Thread Klaus Hochlehnert
I'll see what I can do to recompile qemu with debugging information. Maybe tomorrow. But one other question. I thought this is the "normal" qemu bug reporting or is it Ubuntu only? I tried with the latest release and followed the "Report a bug"-link from the qemu web site. -- You received this

Re: [Qemu-devel] [PATCH v2 0/8] memory: remove old_portio usage

2013-06-18 Thread Hervé Poussineau
Jan Kiszka a écrit : On 2013-06-17 22:39, Hervé Poussineau wrote: Jan Kiszka a écrit : On 2013-06-17 09:32, Paolo Bonzini wrote: Il 16/06/2013 20:20, Hervé Poussineau ha scritto: Hervé Poussineau a écrit : These proposed patches aim at removing the .old_portio member of MemoryRegionOps struc

Re: [Qemu-devel] [PATCH v2] wdt_i6300esb: fix vmstate versioning

2013-06-18 Thread mdroth
On Tue, Jun 11, 2013 at 04:53:51PM -0500, mdroth wrote: > On Wed, May 22, 2013 at 11:32:51AM -0500, Michael Roth wrote: > > When this VMSD was introduced it's version fields were set to > > sizeof(I6300State), making them essentially random from build to build, > > version to version. > > > > To f

[Qemu-devel] [RFC PATCH 4/4] build-sys: move -lcurl out of libs and specify it for curl.o

2013-06-18 Thread Michael Tokarev
We only need to link -lcurl into executables which actually use/link curl.o, so make -lcurl object-specific library, using curl.libs variable. While at it, also use new curl.cflags variable to specify curl-specific cflags, for symmetry with .libs, and move whole declaration into the if..endif bloc

[Qemu-devel] [RFC PATCH 0/4] per-object libraries

2013-06-18 Thread Michael Tokarev
The following working patchset demonstrates a one step to plugins system: it moves various dependent libraries and stuff out from libs_softmmu or libs_tools to object-specific variables. When that object is linked into final executable, corresponding libs are expanded and appended to the linking c

[Qemu-devel] [RFC PATCH 3/4] build-sys: allow per-object foo.cflags variables

2013-06-18 Thread Michael Tokarev
In addition to allowing specifying foo.libs for additional libraries, recognize also foo.cflags variable when compiling foo.c into foo.o. This is more for completness/symmetry with foo.libs. Signed-off-by: Michael Tokarev --- rules.mak |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

[Qemu-devel] [RFC PATCH 2/4] build-sys: allow object-specific libraries to be used to link executables

2013-06-18 Thread Michael Tokarev
When linking final executables consiting of various object files foo.o, one may define foo.libs variable to hold libraries needed to be linked with foo.o. This way, we may specify dependencies inside the makefile fragments where corresponding objects are defined. Signed-off-by: Michael Tokarev -

[Qemu-devel] [RFC PATCH 1/4] build-sys: strip leading ./ from $(obj)

2013-06-18 Thread Michael Tokarev
This change modifies the way how subdir objects are handled. Previously, $(obj) make variable were starting with `.' (current directory), and were appended `/subdir' when recursing into subdirs, so that actual objects in top level dir were named ./obj and in subdirs - ./subdir/obj. Remove the `./'

Re: [Qemu-devel] [PATCH] arm/boot: Free dtb blob memory after use

2013-06-18 Thread Peter Maydell
On 14 June 2013 12:27, Peter Maydell wrote: > The dtb blob returned by load_device_tree() is in memory allocated > with g_malloc(). Free it accordingly once we have copied its > contents into the guest memory. To make this easy, we need also to > clean up the error handling in load_dtb() so that w

Re: [Qemu-devel] [PATCH qom-cpu v2 19/29] cpu: Replace cpu_single_env with CPUState cpu_single_cpu

2013-06-18 Thread Andreas Färber
Am 16.06.2013 22:49, schrieb Blue Swirl: > On Sun, Jun 16, 2013 at 3:57 PM, Andreas Färber wrote: >> Move it to qom/cpu.h. > > While renaming, perhaps a more descriptive name could be used instead > of 'cpu_single_cpu', something like cpu_loop_current_cpu? There were some local variables named c

Re: [Qemu-devel] [PATCH qom-cpu v2 01/29] kvm: Change kvm_cpu_synchronize_state() argument to CPUState

2013-06-18 Thread Andreas Färber
Am 17.06.2013 18:15, schrieb Paolo Bonzini: > Il 16/06/2013 17:57, Andreas Färber ha scritto: >> It no longer relies on CPUArchState since 20d695a. >> >> Reviewed-by: liguang >> Signed-off-by: Andreas Färber >> --- >> hw/ppc/spapr_rtas.c | 2 +- >> include/sysemu/kvm.h | 4 ++-- >> kvm-all.c

Re: [Qemu-devel] [PATCH v2 2/2] QEMUBH: make AioContext's bh re-entrant

2013-06-18 Thread mdroth
On Tue, Jun 18, 2013 at 10:14:38AM -0500, mdroth wrote: > On Sun, Jun 16, 2013 at 07:21:21PM +0800, Liu Ping Fan wrote: > > BH will be used outside big lock, so introduce lock to protect > > between the writers, ie, bh's adders and deleter. > > Note that the lock only affects the writers and bh's c

Re: [Qemu-devel] Java volatile vs. C11 seq_cst (was Re: [PATCH v2 1/2] add a header file for atomic operations)

2013-06-18 Thread Paolo Bonzini
Il 18/06/2013 16:50, Paul E. McKenney ha scritto: > PS: Nevertheless, I personally prefer the C++ formulation, but that is > only because I stand with one foot in theory and the other in > practice. If I were a pure practitioner, I would probably strongly > prefer the Java formulat

Re: [Qemu-devel] [PATCH 1/2] PPC: Add dump_mmu() for 6xx

2013-06-18 Thread Fabien Chouteau
On 06/18/2013 05:31 PM, Alexander Graf wrote: >> +for (type = 0; type < 2; type++) > > You need braces on these. Please run your patch through checkpatch.pl :). I did ;) -> ./scripts/checkpatch.pl 0001-PPC-Add-dump_mmu-for-6xx.patch total: 0 errors, 0 warnings, 51 lines checked 0001-PPC-Add

Re: [Qemu-devel] [PATCH 2/2] intc/openpic: Convert to QOM realize

2013-06-18 Thread Andreas Färber
Hi, Am 18.06.2013 05:28, schrieb Peter Crosthwaite: > On Tue, Jun 18, 2013 at 11:58 AM, Andreas Färber wrote: >> Split qdev initfn into instance_init and realize functions. >> Change one occurrence of "klass" while at it. >> >> Signed-off-by: Andreas Färber > > Reviewed-by: Peter Crosthwaite >

Re: [Qemu-devel] [PATCH 2/2] PPC: Fix GDB read on code area for PPC6xx

2013-06-18 Thread Alexander Graf
On 18.06.2013, at 16:53, Fabien Chouteau wrote: > On PPC 6xx, data and code have separated TLBs. Until now QEMU was only > looking at data TLBs, which is not good when GDB wants to read code. > > This patch adds a second call to get_physical_address() with an > ACCESS_CODE type of access when th

Re: [Qemu-devel] [0/3] Accumulated ppc patches

2013-06-18 Thread Alexander Graf
On 15.06.2013, at 03:51, David Gibson wrote: > Hi Alex, > > I see that you're now back from your holiday. Here, rather belatedly, > is my series of ppc related patches collected while acting ppc > maintainer. As you can see there aren't many at all. I'm not sure if > that's because I wasn't lo

Re: [Qemu-devel] [PATCH for-1.5] ppc: do not register IABR SPR twice for 603e

2013-06-18 Thread Alexander Graf
On 11.05.2013, at 21:03, Hervé Poussineau wrote: > IABR SPR is already registered in gen_spr_603(), called from init_proc_603E(). > > Signed-off-by: Hervé Poussineau Thanks, applied to ppc-next. Sorry for the long delay - I was on vacation :) Alex > --- > target-ppc/translate_init.c |5

Re: [Qemu-devel] [RESEND PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-18 Thread Michael S. Tsirkin
On Fri, Jun 14, 2013 at 08:13:29AM +0200, Frederic Konrad wrote: > On 13/06/2013 09:59, Michael S. Tsirkin wrote: > >On Thu, Jun 13, 2013 at 09:34:30AM +0200, Frederic Konrad wrote: > >>On 13/06/2013 09:23, Michael S. Tsirkin wrote: > >>>On Thu, Jun 13, 2013 at 04:46:09PM +1000, Alexey Kardashevski

Re: [Qemu-devel] [PATCH 1/2] PPC: Add dump_mmu() for 6xx

2013-06-18 Thread Alexander Graf
On 18.06.2013, at 16:53, Fabien Chouteau wrote: > "(qemu) info tlb" is a very useful tool for debugging, so I implemented > the missing 6xx version. > > Signed-off-by: Fabien Chouteau > --- > target-ppc/mmu_helper.c | 39 +++ > 1 file changed, 39 insertions(

Re: [Qemu-devel] [PATCH qom-cpu v3 0/6] QOM CPUState migration, next generation

2013-06-18 Thread Andreas Färber
Am 18.06.2013 02:29, schrieb Andreas Färber: > Andreas Färber (6): > cpu: Fix cpu_class_set_vmsd() documentation > cpu: Introduce device_class_set_vmsd() helper > cpu: Introduce VMSTATE_CPU() macro for CPUState > target-alpha: Register VMStateDescription for AlphaCPU > target-openrisc: Re

Re: [Qemu-devel] [PATCH ppc-next] target-ppc: Drop redundant flags assignments from CPU families

2013-06-18 Thread Alexander Graf
On 22.02.2013, at 18:35, Andreas Färber wrote: > Previous code has #define POWERPC_INSNS2_ PPC_NONE in some > places for macrofied assignment to insns_flags2 field. > > PPC_NONE is defined as zero though and QOM classes are zero-initialized, > so drop any pcc->insns_flags2 = PPC_NONE; assignment

Re: [Qemu-devel] [PATCH v2 2/2] QEMUBH: make AioContext's bh re-entrant

2013-06-18 Thread mdroth
On Sun, Jun 16, 2013 at 07:21:21PM +0800, Liu Ping Fan wrote: > BH will be used outside big lock, so introduce lock to protect > between the writers, ie, bh's adders and deleter. > Note that the lock only affects the writers and bh's callback does > not take this extra lock. > > Signed-off-by: Liu

Re: [Qemu-devel] [PATCH v3 08/16] boot-order-test: New; covering just PC for now

2013-06-18 Thread Anthony Liguori
Markus Armbruster writes: > Anthony Liguori writes: > >> Markus Armbruster writes: >> >>> Signed-off-by: Markus Armbruster >>> --- >>> tests/Makefile | 2 ++ >>> tests/boot-order-test.c | 68 >>> + >>> 2 files changed, 70 insertions(+)

[Qemu-devel] [PULL 0/2] NBD changes for 2013-06-18 (including 1.5.1 patches)

2013-06-18 Thread Paolo Bonzini
The following changes since commit afd59989db90683fa127fec501d2633bcfbd6379: intc/xilinx_intc: Dont lower IRQ when HIE cleared (2013-06-18 09:45:00 +0200) are available in the git repository at: git://github.com/bonzini/qemu.git nbd-next for you to fetch changes up to 23307908790cd8fad91220

[Qemu-devel] [PATCH v3 4/4] pc_piix: cleanup init compat handling

2013-06-18 Thread Michael S. Tsirkin
Make sure 1.4 calls 1.5, 1.3 calls 1.4 etc. This way it's enough to add enough new compat hook in a single place in piix. Signed-off-by: Michael S. Tsirkin --- hw/i386/pc_piix.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc

Re: [Qemu-devel] [PATCH v2 1/2] add a header file for atomic operations

2013-06-18 Thread Paolo Bonzini
Il 18/06/2013 16:38, Richard Henderson ha scritto: +#ifndef atomic_read +#define atomic_read(ptr) (*(__typeof__(*ptr) *volatile) (ptr)) #endif +#ifndef atomic_set +#define atomic_set(ptr, i) ((*(__typeof__(*ptr) *volatile) (ptr)) = (i)) +#endif

[Qemu-devel] [PATCH 7/7] iscsi: reorganize iscsi_readcapacity_sync

2013-06-18 Thread Paolo Bonzini
Avoid the goto, and use the same retry logic for the 10- and 16- byte versions. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini --- block/iscsi.c | 94 +-- 1 file changed, 46 insertions(+), 48 deletions(-) diff --git a/block/iscsi.

Re: [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver

2013-06-18 Thread Kevin Wolf
Am 30.05.2013 um 14:34 hat Stefan Hajnoczi geschrieben: > From: Dietmar Maurer > > backup_start() creates a block job that copies a point-in-time snapshot > of a block device to a target block device. > > We call backup_do_cow() for each write during backup. That function > reads the original da

[Qemu-devel] [PATCH 6/7] iscsi: simplify freeing of tasks

2013-06-18 Thread Paolo Bonzini
Always free them in the iscsi_aio_*_acb functions and remove the checks in their callers. Remove ifs when the task struct was previously dereferenced (spotted by Coverity). Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini --- block/iscsi.c | 35 ++- 1 file

[Qemu-devel] [PATCH] target-arm: implement ARMv8 VSEL instruction

2013-06-18 Thread Mans Rullgard
This adds support for the VSEL instruction introduced in ARMv8. It resides along with other new VFP instructions under the CDP2 encoding which was previously unused. Signed-off-by: Mans Rullgard --- Basic testing performed but not every combination. --- target-arm/translate.c | 51 ++

[Qemu-devel] [PATCH 1/2] PPC: Add dump_mmu() for 6xx

2013-06-18 Thread Fabien Chouteau
"(qemu) info tlb" is a very useful tool for debugging, so I implemented the missing 6xx version. Signed-off-by: Fabien Chouteau --- target-ppc/mmu_helper.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/target-ppc/mmu_helper.c b/target-ppc/mmu_help

[Qemu-devel] [PATCH 2/2] PPC: Fix GDB read on code area for PPC6xx

2013-06-18 Thread Fabien Chouteau
On PPC 6xx, data and code have separated TLBs. Until now QEMU was only looking at data TLBs, which is not good when GDB wants to read code. This patch adds a second call to get_physical_address() with an ACCESS_CODE type of access when the first call with ACCESS_INT fails. Signed-off-by: Fabien C

Re: [Qemu-devel] [PATCH v2 1/2] add a header file for atomic operations

2013-06-18 Thread Richard Henderson
On 06/18/2013 01:36 AM, Paolo Bonzini wrote: >> Why all the ifdefs? If __atomic support is present, then __ATOMIC defines >> will >> exist. > > Then I can just use "#ifdef __ATOMIC_RELAXED" instead of > "#if QEMU_GNUC_PREREQ(4, 8)"? I'd say so. > I have no idea, but I can say which semantics I

Re: [Qemu-devel] [PATCH v2 0/8] memory: remove old_portio usage

2013-06-18 Thread Jan Kiszka
On 2013-06-17 22:39, Hervé Poussineau wrote: > Jan Kiszka a écrit : >> On 2013-06-17 09:32, Paolo Bonzini wrote: >>> Il 16/06/2013 20:20, Hervé Poussineau ha scritto: Hervé Poussineau a écrit : > These proposed patches aim at removing the .old_portio member of > MemoryRegionOps structu

Re: [Qemu-devel] [RfC PATCH 2/2] console: add screendump-device qmp cmd

2013-06-18 Thread Stefan Hajnoczi
On Tue, Jun 18, 2013 at 03:24:33PM +0200, Gerd Hoffmann wrote: > Hi, > > >> Something like the attached patch? Which is just the bare minimum I'll > >> need for screendump. Basically a one-off bottom half with some monitor > >> infrastructure (job id, error handling). So it isn't for big jobs

Re: [Qemu-devel] [Bug 1191606] Re: qemu crashes with iscsi initiator (libiscsi) when using virtio

2013-06-18 Thread Stefan Hajnoczi
On Tue, Jun 18, 2013 at 02:26:19PM +0200, Laszlo Ersek wrote: > On 06/18/13 11:38, Stefan Hajnoczi wrote: > > On Mon, Jun 17, 2013 at 05:37:57PM -, Klaus Hochlehnert wrote: > >> Without debug information I just can provide this (on that server I > >> can't recompile qemu with debugging informat

Re: [Qemu-devel] [PATCH qom-cpu v3 4/6] target-alpha: Register VMStateDescription for AlphaCPU

2013-06-18 Thread Richard Henderson
On 06/17/2013 05:29 PM, Andreas Färber wrote: > Commit b758aca1f6cdb175634812b79f5560c36c902d00 (target-alpha: Enable > the alpha-softmmu target.) introduced cpu_{save,load}() functions but > didn't define CPU_SAVE_VERSION, so they were never registered. > > Drop cpu_{save,load}() and register the

[Qemu-devel] [PATCH 1/2] qemu-socket: allow hostnames starting with a digit

2013-06-18 Thread Paolo Bonzini
From: Ján Tomko According to RFC 1123 [1], hostnames can start with a digit too. [1] http://tools.ietf.org/html/rfc1123#page-13 Signed-off-by: Ján Tomko Cc: qemu-sta...@nongnu.org [Use strspn, not strcspn. - Paolo] Signed-off-by: Paolo Bonzini --- util/qemu-sockets.c | 13 - 1 fi

Re: [Qemu-devel] [PATCH V2 12/12] qemu-iotests: add 055 internal snapshot for block device test case

2013-06-18 Thread Stefan Hajnoczi
On Fri, Jun 14, 2013 at 07:39:59PM +0800, Wenchao Xia wrote: > Signed-off-by: Wenchao Xia > --- > tests/qemu-iotests/055 | 157 > > tests/qemu-iotests/055.out |5 ++ drive-backup already uses 055, please name it 056 to avoid conflicts. > te

  1   2   3   >