Re: [Qemu-devel] [PATCH V15 0/5] enhancement for qmp/hmp interfaces of block info

2013-06-05 Thread Fam Zheng
On Thu, 06/06 12:27, Wenchao Xia wrote: > This series lets qmp interface show delaied info, including internal > snapshot Typo? s/delaied/detailed/ > /backing chain on all block device at runtime, which helps management stack > and > human user, by retrieving exactly the same info of what qemu

[Qemu-devel] [PATCH v7 11/13] block/curl.c: Refuse to open the handle for writes.

2013-06-05 Thread Fam Zheng
From: "Richard W.M. Jones" Signed-off-by: Richard W.M. Jones Signed-off-by: Fam Zheng --- block/curl.c | 4 1 file changed, 4 insertions(+) diff --git a/block/curl.c b/block/curl.c index e067417..bce2e8a 100644 --- a/block/curl.c +++ b/block/curl.c @@ -454,6 +454,10 @@ static int curl_op

[Qemu-devel] [PATCH v7 10/13] curl: introduce ssl_no_cert runtime option.

2013-06-05 Thread Fam Zheng
Added an option to let curl disable ssl certificate check. Signed-off-by: Fam Zheng --- block/curl.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/block/curl.c b/block/curl.c index 6e893d0..e067417 100644 --- a/block/curl.c +++ b/block/curl.c @@ -95,6 +95,8 @@

[Qemu-devel] [PATCH v7 07/13] curl: make use of CURLDataCache.

2013-06-05 Thread Fam Zheng
Make subsequecial changes to make use of introduced CURLDataCache. Moved acb struct from CURLState to BDRVCURLState, and changed to list. Signed-off-by: Fam Zheng --- block/curl.c | 170 --- 1 file changed, 92 insertions(+), 78 deletions(-)

[Qemu-devel] [PATCH v7 12/13] curl: set s->url to NULL after free.

2013-06-05 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/curl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/curl.c b/block/curl.c index bce2e8a..50c7188 100644 --- a/block/curl.c +++ b/block/curl.c @@ -741,6 +741,7 @@ static void curl_close(BlockDriverState *bs) } g_free(s->url); +s->url

[Qemu-devel] [PATCH v7 13/13] curl: change timeout to 30 seconds

2013-06-05 Thread Fam Zheng
On curl request timeout, guest gets -EIO. This happens too frequently accessing a slow network resource, with 5 seconds timeout. Change it to 30 seconds to give more time before aborting the request. Reported-by: Richard W.M. Jones Signed-off-by: Fam Zheng --- block/curl.c | 2 +- 1 file change

[Qemu-devel] [PATCH v7 06/13] curl: introduce CURLDataCache

2013-06-05 Thread Fam Zheng
Data buffer was contained by CURLState, they are allocated and freed together. This patch try to isolate them, by introducing a dedicated cache list to BDRVCURLState. The benifit is we can now release the CURLState (and associated sockets) while keep the fetched data for later use, and simplies the

[Qemu-devel] [PATCH v7 08/13] curl: use list to store CURLState

2013-06-05 Thread Fam Zheng
Make it consistent to other structures to use QLIST to store CURLState. It also simplifies initialization and releasing of data. Signed-off-by: Fam Zheng --- block/curl.c | 82 +++- 1 file changed, 37 insertions(+), 45 deletions(-) diff --

[Qemu-devel] [PATCH v7 09/13] curl: add cache quota.

2013-06-05 Thread Fam Zheng
Introduce a cache quota: BDRVCURLState.cache_quota. When adding new CURLDataCache to BDRVCURLState, if number of existing CURLDataCache is larger than CURL_CACHE_QUOTA, try to release some first to limit the in memory cache size. A least used entry is selected for releasing. Signed-off-by: Fam Zh

[Qemu-devel] [PATCH v7 03/13] curl: change curl_multi_do to curl_fd_handler

2013-06-05 Thread Fam Zheng
The driver calls curl_multi_do to take action at several points, while it's also registered as socket fd handler. This patch removes internal call of curl_multi_do because they are not necessary when handler can be called by socket data update. Since curl_multi_do becomes a pure fd handler, the fu

[Qemu-devel] [PATCH v7 05/13] curl: add timer to BDRVCURLState

2013-06-05 Thread Fam Zheng
libcurl uses timer to manage ongoing sockets, it needs us to supply timer. This patch introduce QEMUTimer to BDRVCURLState and handles timeouts as libcurl expects (curl_multi_timer_cb sets given timeout value on the timer and curl_timer_cb calls curl_multi_socket_action on triggered). Signed-off-b

[Qemu-devel] [PATCH v7 00/13] curl: fix curl read

2013-06-05 Thread Fam Zheng
CURL library API has changed, the current curl driver is not working with current libcurl. It may or may not have worked with old libcurl, but currently, when testing with apache http URL, it just hangs before fetching any data. The problem is because the mismatch of our code and how libcurl wants

[Qemu-devel] [PATCH v7 04/13] curl: fix curl_open

2013-06-05 Thread Fam Zheng
Change curl_size_cb to curl_header_cb, as what the function is really doing. Fix the registering, CURLOPT_WRITEFUNCTION is apparently wrong, should be CURLOPT_HEADERFUNCTION. Parsing size from header is not necessary as we're using curl_easy_getinfo(state->curl, CURLINFO_CONTENT_LENGTH_DOWNLOAD

[Qemu-devel] [PATCH v7 01/13] curl: introduce CURLSockInfo to BDRVCURLState.

2013-06-05 Thread Fam Zheng
We use socket provided by curl in the driver. Libcurl multi interface has option CURLMOPT_SOCKETFUNCTION for socket. Per man 3 curl_multi_setopt: ... CURLMOPT_SOCKETFUNCTION Pass a pointer to a function matching the curl_socket_callback prototype. The curl_multi_socket_action(3)

[Qemu-devel] [PATCH v7 02/13] curl: change magic number to sizeof

2013-06-05 Thread Fam Zheng
String field length is duplicated in two places. Make it a sizeof. Signed-off-by: Fam Zheng --- block/curl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/curl.c b/block/curl.c index a829fe7..a11002b 100644 --- a/block/curl.c +++ b/block/curl.c @@ -569,7 +569,7 @@ sta

Re: [Qemu-devel] [PATCH v2] e600 core for MPC86xx processors

2013-06-05 Thread Julio Guerra
ping 2013/5/26 Julio Guerra : > MPC86xx processors are based on the e600 core, which is not the case > in qemu where it is based on the 7400 processor. > > This patch creates the e600 core and instantiates the MPC86xx > processors based on it. Therefore, adding the high BATs and the SPRG > 4..7 re

[Qemu-devel] Intel HDA issue with TCG x86_64

2013-06-05 Thread Peter Crosthwaite
Hi All, Im running: qemu-system-x86_64 -drive file=./qemu-pc/debian,if=scsi,bus=0 -m 2048 -soundhw hda Drive is Aureliens debian squeeze desktop image: http://people.debian.org/~aurel32/qemu/amd64/ QEMU configured as: ../qemu/configure --target-list=x86_64-softmmu --enable-kvm --audio-drv-lis

[Qemu-devel] [PATCH v2 2/2] audio/intel-hda: QOM casting sweep

2013-06-05 Thread peter . crosthwaite
From: Peter Crosthwaite Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct -> style casting. Signed-off-by: Peter Crosthwaite --- hw/audio/intel-hda.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/hw/audio/intel-hda.c b/hw/

[Qemu-devel] [PATCH v2 1/2] audio/intel-hda: Fix Inheritance hierachy

2013-06-05 Thread peter . crosthwaite
From: Peter Crosthwaite The ich6 and ich9 variants either need to inherit one from the other, or both from a common base class, otherwise its not possible to create a QOM cast macro for use by the shared implementation functions. Went for option B, with a common base class. Signed-off-by: Peter

Re: [Qemu-devel] [RFC/RFT PATCH v1 1/2] audio/intel-hda: Fix Inheritance hierachy

2013-06-05 Thread Peter Crosthwaite
This is missing a hunk @@ -1329,6 +1329,7 @@ static int intel_hda_and_codec_init(PCIBus *bus) static void intel_hda_register_types(void) { type_register_static(&hda_codec_bus_info); +type_register_static(&intel_hda_info); type_register_static(&intel_hda_info_ich6); type_regist

Re: [Qemu-devel] [PATCH v5 00/11] block: drive-backup live backup command

2013-06-05 Thread Wenchao Xia
于 2013-5-30 20:34, Stefan Hajnoczi 写道: > Note: These patches apply to kevin/block. You can also grab the code from git > here: > git://github.com/stefanha/qemu.git block-backup-core > > This series adds a new QMP command, drive-backup, which takes a point-in-time > snapshot of a block device. Th

Re: [Qemu-devel] [PATCH v5 04/11] blockdev: drop redundant proto_drv check

2013-06-05 Thread Wenchao Xia
于 2013-5-30 20:34, Stefan Hajnoczi 写道: > It is not necessary to check that we can find a protocol block driver > since we create or open the image file. This produces the error that we > need anyway. > > Besides, the QERR_INVALID_BLOCK_FORMAT is inappropriate since the > protocol is incorrect rat

[Qemu-devel] [PATCH V15 5/5] hmp: add parameters device and -v for info block

2013-06-05 Thread Wenchao Xia
With these parameters, user can choose the information to be showed, to avoid message flood in the monitor. Signed-off-by: Wenchao Xia --- hmp.c | 25 - monitor.c |7 --- 2 files changed, 20 insertions(+), 12 deletions(-) diff --git a/hmp.c b/hmp.c index 2a

[Qemu-devel] [PATCH V15 3/5] qmp: add ImageInfo in BlockDeviceInfo used by query-block

2013-06-05 Thread Wenchao Xia
Now image info will be retrieved as an embbed json object inside BlockDeviceInfo, backing chain info and all related internal snapshot info can be got in the enhanced recursive structure of ImageInfo. New recursive member *backing-image is added to reflect the backing chain status. Signed-off-by:

[Qemu-devel] [PATCH V15 1/5] block: add snapshot info query function bdrv_query_snapshot_info_list()

2013-06-05 Thread Wenchao Xia
This patch adds function bdrv_query_snapshot_info_list(), which will retrieve snapshot info of an image in qmp object format. The implementation is based on the code moved from qemu-img.c with modification to fit more for qmp based block layer API. Signed-off-by: Wenchao Xia Reviewed-by: Eric Bla

[Qemu-devel] [PATCH V15 2/5] block: add image info query function bdrv_query_image_info()

2013-06-05 Thread Wenchao Xia
This patch adds function bdrv_query_image_info(), which will retrieve image info in qmp object format. The implementation is based on the code moved from qemu-img.c, but uses block layer function to get snapshot info. Signed-off-by: Wenchao Xia --- block/qapi.c | 43 +++

[Qemu-devel] [PATCH V15 0/5] enhancement for qmp/hmp interfaces of block info

2013-06-05 Thread Wenchao Xia
This series lets qmp interface show delaied info, including internal snapshot /backing chain on all block device at runtime, which helps management stack and human user, by retrieving exactly the same info of what qemu sees. Example: -> { "execute": "query-block" } <- { "return":[

[Qemu-devel] [PATCH V15 4/5] hmp: show ImageInfo in 'info block'

2013-06-05 Thread Wenchao Xia
Now human monitor can show image details, include internal snapshot and backing chain info for every block device. Signed-off-by: Wenchao Xia --- hmp.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/hmp.c b/hmp.c index 4fb76ec..2aa832c 100644 --- a/hmp.c +

[Qemu-devel] [PATCH 1/2] linux-headers: Update to v3.10-rc4

2013-06-05 Thread Alexey Kardashevskiy
This adds symbols required for sPAPR live migration and in-kernel XICS interrupt controller. Signed-off-by: Alexey Kardashevskiy --- linux-headers/asm-arm/kvm.h | 12 ++--- linux-headers/asm-mips/kvm.h | 55 +++ linux-headers/asm-mips/kvm_para.h |1 + linux

[Qemu-devel] [PATCH 0/2] header update request

2013-06-05 Thread Alexey Kardashevskiy
We need new headers for live migration and in-kernel interrupt controller support. However just copying new headers breaks PPC so dummy kvm_arch_init_irq_routing() is required as well. Alexey Kardashevskiy (1): linux-headers: Update to v3.10-rc4 Scott Wood (1): KVM: PPC: Add dummy kvm_arch

[Qemu-devel] [PATCH 2/2] KVM: PPC: Add dummy kvm_arch_init_irq_routing()

2013-06-05 Thread Alexey Kardashevskiy
From: Scott Wood The common KVM code insists on calling kvm_arch_init_irq_routing() as soon as it sees kernel header support for it (regardless of whether QEMU supports it). Provide a dummy function to satisfy this. Unlike x86, PPC does not have one default irqchip, so there's no common code th

[Qemu-devel] [PATCH] build: remove compile warning

2013-06-05 Thread Wenchao Xia
This patch simply remove "variable may be used uninitialized" warning. Signed-off-by: Wenchao Xia --- libcacard/vscclient.c |2 +- util/iov.c|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index ac23647..815f

Re: [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver

2013-06-05 Thread Fam Zheng
On Thu, 05/30 14:34, Stefan Hajnoczi wrote: > + > +static int coroutine_fn backup_before_write_notify( > +NotifierWithReturn *notifier, > +void *opaque) > +{ > +BdrvTrackedRequest *req = opaque; > + > +return backup_do_cow(req->bs, req->sector_num, req->nb_sectors, NULL); >

[Qemu-devel] [PATCH RFC v2 1/2] ec: add ASL for ACPI Embedded Controller

2013-06-05 Thread liguang
Signed-off-by: liguang --- src/acpi-dsdt-isa.dsl | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/src/acpi-dsdt-isa.dsl b/src/acpi-dsdt-isa.dsl index 23761db..2b9c3a0 100644 --- a/src/acpi-dsdt-isa.dsl +++ b/src/acpi-dsdt-isa.dsl @@ -99,4 +99,30 @

[Qemu-devel] [PATCH RFC v2 6/8] qmp: add 'cpu-del' command

2013-06-05 Thread liguang
add 'cpu-del' as complementary of 'cpu-add', cpu-del doesn't really delete a previous created cpu for it depends on CPU-QOM which it's un-finished yet to unrealize it. cpu-del just records the cpu-id that guest want to remove to keep status of ACPI cpu hot-remove process. Signed-off-by: liguang -

[Qemu-devel] [PATCH RFC v2 2/2] use EC space instead of specific systemio for cpu hotplug

2013-06-05 Thread liguang
Signed-off-by: liguang --- src/acpi-dsdt-cpu-hotplug.dsl |9 + src/acpi-dsdt-isa.dsl |8 +--- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/src/acpi-dsdt-cpu-hotplug.dsl b/src/acpi-dsdt-cpu-hotplug.dsl index 0f3e83b..869373b 100644 --- a/src/acpi-dsdt

[Qemu-devel] [PATCH RFC v2 1/8] acpi: add ACPI Embedded Controller support

2013-06-05 Thread liguang
this work implemented Embedded Controller chip emulation which was defined at ACPI SEPC v5 chapter 12: "ACPI Embedded Controller Interface Specification" commonly Embedded Controller will emulate keyboard, mouse, handle ACPI defined operations and some low-speed devices like SMbus. Signed-off-by:

[Qemu-devel] [PATCH RFC v2 7/8] pc: add EC qdev init for piix & q35

2013-06-05 Thread liguang
Signed-off-by: liguang --- hw/i386/pc_piix.c |6 ++ hw/i386/pc_q35.c |5 + 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 71ce2ff..378c980 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -46,6 +46,8 @@ #inclu

[Qemu-devel] [PATCH RFC v2 4/8] piix4: add notifer for ec to generate sci

2013-06-05 Thread liguang
Signed-off-by: liguang --- hw/acpi/piix4.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index e6525ac..aae1c88 100644 --- a/hw/acpi/piix4.c +++ b/hw/acpi/piix4.c @@ -29,6 +29,7 @@ #include "exec/ioport.h" #include "hw/n

[Qemu-devel] [PATCH RFC v2 3/8] ec: add operations for _Qxx events

2013-06-05 Thread liguang
Signed-off-by: liguang --- hw/acpi/ec.c | 32 include/hw/acpi/ec.h | 10 ++ 2 files changed, 38 insertions(+), 4 deletions(-) diff --git a/hw/acpi/ec.c b/hw/acpi/ec.c index da8525f..fe82e9c 100644 --- a/hw/acpi/ec.c +++ b/hw/acpi/ec.c @@ -22,6

[Qemu-devel] [PATCH RFC v2 2/8] ich9: add notifer for ec to generate sci

2013-06-05 Thread liguang
Signed-off-by: liguang --- hw/acpi/ich9.c | 15 +++ include/hw/acpi/ich9.h |1 + 2 files changed, 16 insertions(+), 0 deletions(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index 4a17f32..f1583ef 100644 --- a/hw/acpi/ich9.c +++ b/hw/acpi/ich9.c @@ -33,6 +33,7 @@ #in

[Qemu-devel] [PATCH RFC v2 8/8] cpu-hotplug: remove memory regison for cpu hotplug

2013-06-05 Thread liguang
operations of memory regison(PIIX4_PROC_BASE) for cpu hostplug can be transfered to EC space naturally by adding EC support. Signed-off-by: liguang --- hw/acpi/piix4.c | 46 ++ hw/i386/pc.c | 16 include/hw/acpi/ec.h |

[Qemu-devel] [PATCH RFC v2 5/8] piix4: add events for cpu hotplug

2013-06-05 Thread liguang
Signed-off-by: liguang --- hw/acpi/piix4.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index aae1c88..8c5b39a 100644 --- a/hw/acpi/piix4.c +++ b/hw/acpi/piix4.c @@ -657,6 +657,14 @@ static void piix4_cpu_hotplug_req(PIIX4PMStat

[Qemu-devel] [PATCH RFC v2 0/7] coordinate cpu hotplug/unplug bewteen QEMU and kernel by EC

2013-06-05 Thread liguang
v2: 1.remove PIIX4_PROC_BASE operations for cpu hotplug 2.fix wrong description fo cpu-del patch 1 adds ACPI Embedded Controller (EC), refer-to: ACPI SPEC v5 chapter 12 "ACPI Embedded Controller Interface Specification" EC is a standard ACPI device, it plays flexible roles, especially be event c

Re: [Qemu-devel] [PATCH V14 0/6] enhancement for qmp/hmp interfaces of block info

2013-06-05 Thread Wenchao Xia
于 2013-6-3 11:14, Wenchao Xia 写道: >This series lets qmp interface show delaied info, including internal > snapshot > /backing chain on all block device at runtime, which helps management stack > and > human user, by retrieving exactly the same info of what qemu sees. > > Example: > -> { "exe

Re: [Qemu-devel] [PATCH 1/2] tcg-arm: Implement tcg_register_jit

2013-06-05 Thread li guang
在 2013-06-05三的 05:49 -0700,Richard Henderson写道: > On 06/04/2013 06:56 PM, li guang wrote: > >> > +typedef struct { > >> > +uint32_t len __attribute__((aligned((sizeof(void *); > >> > +uint32_t cie_offset; > >> > +tcg_target_long func_start __attribute__((packed)); > >> > +tcg_ta

Re: [Qemu-devel] [PATCH trivial] gitignore: unignore *.patch

2013-06-05 Thread li guang
在 2013-06-06四的 01:16 +0400,Michael Tokarev写道: > This partially reverts: > > commit 082369e62c5bbaba89f173c2b803bc24115bb111 > Author: liguang > Date: Fri Mar 22 16:44:13 2013 +0800 > > gitignore: ignore more files > > I'm not sure how this went in. The thing is that > ignoring *.patch

Re: [Qemu-devel] [PATCH 11/13] pseries: savevm support for PCI host bridge

2013-06-05 Thread David Gibson
On Wed, Jun 05, 2013 at 08:57:29PM +1000, Alexey Kardashevskiy wrote: > On 05.06.2013 20:00, David Gibson wrote: > > On Tue, Jun 04, 2013 at 10:21:03PM +1000, Alexey Kardashevskiy wrote: > >> Author: David Gibson > >> > >> This adds the necessary support for saving the state of the PAPR virtual >

Re: [Qemu-devel] [PATCH trivial] gitignore: unignore *.patch

2013-06-05 Thread Peter Maydell
On 5 June 2013 22:16, Michael Tokarev wrote: > This partially reverts: > > commit 082369e62c5bbaba89f173c2b803bc24115bb111 > Author: liguang > Date: Fri Mar 22 16:44:13 2013 +0800 > > gitignore: ignore more files > > I'm not sure how this went in. The thing is that > ignoring *.patch, i

[Qemu-devel] [PATCH trivial] gitignore: unignore *.patch

2013-06-05 Thread Michael Tokarev
This partially reverts: commit 082369e62c5bbaba89f173c2b803bc24115bb111 Author: liguang Date: Fri Mar 22 16:44:13 2013 +0800 gitignore: ignore more files I'm not sure how this went in. The thing is that ignoring *.patch, in my opinion, is just wrong. Especially for downstreams who app

Re: [Qemu-devel] kFreeBSD and USB support

2013-06-05 Thread Brad Smith
On 05/06/13 4:34 PM, Ed Maste wrote: On 5 June 2013 16:17, Michael Tokarev wrote: Hello. On debian we, for a long time, used the following hack in a build script of qemu: # Hack alert. qemu-1.3 still needs this. # On recent kFreebsd, old USB host API has been removed, # but qemu did not lear

[Qemu-devel] [PATCH v2 1/3] nvram: Add TPM NVRAM implementation

2013-06-05 Thread Corey Bryant
Provides TPM NVRAM implementation that enables storing of TPM NVRAM data in a persistent image file. The block driver is used to read/write the drive image. This will enable, for example, an encrypted QCOW2 image to be used to store sensitive keys. This patch provides APIs that a TPM backend can

[Qemu-devel] [PATCH v2 0/3] TPM NVRAM persistent storage

2013-06-05 Thread Corey Bryant
This patch series provides persistent storage support that a TPM can use to store NVRAM data. It uses QEMU's block driver to store data on a drive image. The libtpms TPM 1.2 backend will be the initial user of this functionality to store data that must persist through a reboot or migration. A sa

[Qemu-devel] [PATCH v2 2/3] nvram: Add tpm-tis drive support

2013-06-05 Thread Corey Bryant
Add a drive property to the tpm-tis device and initialize the TPM NVRAM if a drive is specified. Signed-off-by: Corey Bryant --- v2 -No changes --- hw/tpm/tpm_int.h |2 ++ hw/tpm/tpm_tis.c |8 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/hw/tpm/tpm_int.h b/h

Re: [Qemu-devel] kFreeBSD and USB support

2013-06-05 Thread Andreas Färber
Am 05.06.2013 22:17, schrieb Michael Tokarev: > Hello. > > On debian we, for a long time, used the following hack > in a build script of qemu: > > # Hack alert. qemu-1.3 still needs this. > # On recent kFreebsd, old USB host API has been removed, > # but qemu did not learn to use new USB API. >

Re: [Qemu-devel] kFreeBSD and USB support

2013-06-05 Thread Ed Maste
On 5 June 2013 16:17, Michael Tokarev wrote: > Hello. > > On debian we, for a long time, used the following hack > in a build script of qemu: > > # Hack alert. qemu-1.3 still needs this. > # On recent kFreebsd, old USB host API has been removed, > # but qemu did not learn to use new USB API. > #

[Qemu-devel] kFreeBSD and USB support

2013-06-05 Thread Michael Tokarev
Hello. On debian we, for a long time, used the following hack in a build script of qemu: # Hack alert. qemu-1.3 still needs this. # On recent kFreebsd, old USB host API has been removed, # but qemu did not learn to use new USB API. # Just do not build USB host support. sed -i 's/^HOST_US

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Use ${config_host_ld} variable

2013-06-05 Thread Ed Maste
On 5 June 2013 16:03, Michael Tokarev wrote: > 05.06.2013 19:02, Ed Maste wrote: >> - linker_script="-Wl,-T../config-host.ld >> -Wl,-T,\$(SRC_PATH)/ldscripts/\$(ARCH).ld" >> + linker_script="-Wl,-T../${config_host_ld} >> -Wl,-T,\$(SRC_PATH)/ldscripts/\$(ARCH).ld" > > Do we really care? To me

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Use ${config_host_ld} variable

2013-06-05 Thread Michael Tokarev
05.06.2013 19:02, Ed Maste wrote: > - linker_script="-Wl,-T../config-host.ld > -Wl,-T,\$(SRC_PATH)/ldscripts/\$(ARCH).ld" > + linker_script="-Wl,-T../${config_host_ld} > -Wl,-T,\$(SRC_PATH)/ldscripts/\$(ARCH).ld" Do we really care? To me it looks like it is better to just remove the variable

Re: [Qemu-devel] [Qemu-trivial] [PATCH] cputlb: fix debug logs

2013-06-05 Thread Michael Tokarev
05.06.2013 16:16, Hervé Poussineau wrote: > 'pd' variable has been removed in 06ef3525e1f271b6a842781a05eace5cf63b95c2. It's been removed indeed, but the value has been replaced by using a MemoryRegionSection instead. I understand current code is wrong when DEBUG_TLB is #defined, but I think it i

Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/5] oslib-posix: add qemu_pipe_non_block

2013-06-05 Thread Michael Tokarev
05.06.2013 00:23, Alon Levy wrote: > Used by the followin patch. > > +int qemu_pipe_non_block(int pipefd[2]); A nitpick. I'd name it qemu_pipe_nonblock(), like O_NONBLOCK is named, but that may be just me. Thanks, /mjt

Re: [Qemu-devel] [PATCH qom-cpu 00/15 v8] target-i386: convert CPU features into properties, part 1

2013-06-05 Thread Peter Maydell
On 5 June 2013 19:31, Eduardo Habkost wrote: > On Wed, Jun 05, 2013 at 07:29:46PM +0200, Andreas Färber wrote: >> Am 05.06.2013 19:17, schrieb Eduardo Habkost: >> > We have had this discussion before, and I remember Anthony saying that >> > anything set using global properties _must_ be static pro

Re: [Qemu-devel] [PATCH qom-cpu 00/15 v8] target-i386: convert CPU features into properties, part 1

2013-06-05 Thread Eduardo Habkost
On Wed, Jun 05, 2013 at 07:29:46PM +0200, Andreas Färber wrote: > Am 05.06.2013 19:17, schrieb Eduardo Habkost: > > On Wed, Jun 05, 2013 at 07:04:59PM +0200, Andreas Färber wrote: > >> Am 05.06.2013 16:39, schrieb Igor Mammedov: > >>> On Wed, 05 Jun 2013 15:29:08 +0200 > >>> Andreas Färber wrote:

Re: [Qemu-devel] [Qemu-stable] [PATCH for 1.5] ui/gtk.c: Fix *BSD build of Gtk+ UI

2013-06-05 Thread Brad Smith
On 25/05/13 5:14 AM, Michael Tokarev wrote: 24.05.2013 22:47, Brad Smith wrote: +++ b/include/qemu-common.h #elif defined CONFIG_BSD +# include Kinda late nit picking about it now. It's not. And it's not nitpicking really, we're carrying a ton of unnecessary #includes which slows down

Re: [Qemu-devel] [RFC] Policy for supported hosts/platforms

2013-06-05 Thread Brad Smith
On 05/06/13 10:04 AM, Anthony Liguori wrote: Hi, Below is the coverage we currently have in buildbot. It's not terribly complete but I suspect it does reflect what people are actually testing and care about. In terms of policy, we should consider buildbot coverage as a requirement for a platf

Re: [Qemu-devel] [PATCH 1/2] user-exec.c: aarch64 initial implementation of cpu_signal_handler

2013-06-05 Thread Peter Maydell
On 5 June 2013 14:42, Claudio Fontana wrote: > > Signed-off-by: Claudio Fontana > > --- > user-exec.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/user-exec.c b/user-exec.c > index 71bd6c5..fa7f1f1 100644 > --- a/user-exec.c > +++ b/user-exec.c > @@ -448,6 +448,21 @@

[Qemu-devel] [PATCH v2 4/4] tcg-arm: Implement tcg_register_jit

2013-06-05 Thread Richard Henderson
Allows unwinding past the code_gen_buffer. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 76 +--- 1 file changed, 67 insertions(+), 9 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 3d43412..a20c96d 100644

[Qemu-devel] [PATCH v2 0/4] tcg-arm: Implement tcg_register_jit

2013-06-05 Thread Richard Henderson
Changes v1-v2: The suggestions for improvement I got from round 1 apply to all of the hosts, not just arm. r~ Richard Henderson (4): tcg: Fix high_pc fields in .debug_info tcg: Move the CIE and FDE header definitions to common code tcg-i386: Use QEMU_BUILD_BUG_ON instead of assert for fra

[Qemu-devel] [PATCH v2 3/4] tcg-i386: Use QEMU_BUILD_BUG_ON instead of assert for frame size

2013-06-05 Thread Richard Henderson
We can check the condition at compile time, rather than run time. Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index 7d946eb..991f484 100644 --- a/tcg/i386/tcg-ta

[Qemu-devel] [PATCH v2 1/4] tcg: Fix high_pc fields in .debug_info

2013-06-05 Thread Richard Henderson
I don't think the debugger actually looks at this for anything, using the correct .debug_frame contents, but might as well get it all correct. Signed-off-by: Richard Henderson --- tcg/tcg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index 1d8099

[Qemu-devel] [PATCH v2 2/4] tcg: Move the CIE and FDE header definitions to common code

2013-06-05 Thread Richard Henderson
These will necessarily be the same layout for all hosts. This limits the amount of boilerplate required to implement jit debug for a host. Signed-off-by: Richard Henderson --- tcg/hppa/tcg-target.c | 35 ++- tcg/i386/tcg-target.c | 39 +-

Re: [Qemu-devel] [PATCH qom-cpu 00/15 v8] target-i386: convert CPU features into properties, part 1

2013-06-05 Thread Andreas Färber
Am 05.06.2013 19:17, schrieb Eduardo Habkost: > On Wed, Jun 05, 2013 at 07:04:59PM +0200, Andreas Färber wrote: >> Am 05.06.2013 16:39, schrieb Igor Mammedov: >>> On Wed, 05 Jun 2013 15:29:08 +0200 >>> Andreas Färber wrote: Why is conversion of dynamic properties to static properties still >>

Re: [Qemu-devel] [PATCH qom-cpu 00/15 v8] target-i386: convert CPU features into properties, part 1

2013-06-05 Thread Eduardo Habkost
On Wed, Jun 05, 2013 at 07:04:59PM +0200, Andreas Färber wrote: > Am 05.06.2013 16:39, schrieb Igor Mammedov: > > On Wed, 05 Jun 2013 15:29:08 +0200 > > Andreas Färber wrote: > > > >> Am 05.06.2013 15:18, schrieb Igor Mammedov: > >>> It's a rebase of v7 on current qom-cpu tree, since then some pa

Re: [Qemu-devel] [PATCH qom-cpu 00/15 v8] target-i386: convert CPU features into properties, part 1

2013-06-05 Thread Andreas Färber
Am 05.06.2013 16:39, schrieb Igor Mammedov: > On Wed, 05 Jun 2013 15:29:08 +0200 > Andreas Färber wrote: > >> Am 05.06.2013 15:18, schrieb Igor Mammedov: >>> It's a rebase of v7 on current qom-cpu tree, since then some patches from it >>> were applied to master. Convertion of feature bits is left

[Qemu-devel] [PATCH RFC] virtio-pci: support config layout in BAR1

2013-06-05 Thread Michael S. Tsirkin
Some setups don't support enabling BAR0 (IO BAR). Reasons range from CPU limitations (e.g. on some powerpc setups) to architecture limmitations (e.g. a setup with >15 PCI bridges, with one virtio device behind each, on x86). PCI Express spec made IO optional, so future guests will disable IO for a

Re: [Qemu-devel] [PATCH 2/2] Add monitor command mem-nodes

2013-06-05 Thread Eduardo Habkost
On Wed, Jun 05, 2013 at 07:57:42AM -0500, Anthony Liguori wrote: > Wanlong Gao writes: > > > Add monitor command mem-nodes to show the huge mapped > > memory nodes locations. > > > > (qemu) info mem-nodes > > /proc/14132/fd/13: 2ac0-2aaaeac0: node0 > > /proc/14132/fd/13: 2

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-05 Thread Peter Maydell
On 5 June 2013 16:44, Michael S. Tsirkin wrote: > On Wed, Jun 05, 2013 at 10:33:05AM -0500, Anthony Liguori wrote: >> "finalize" is the standard name of the hook that gets called before >> garbage collection as Andreas previously pointed out. > > I am simply asking for function names to tell us >

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-05 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Wed, Jun 05, 2013 at 07:53:05AM -0500, Anthony Liguori wrote: >> "Michael S. Tsirkin" writes: >> >> > On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas Färber wrote: >> >> Am 04.06.2013 20:51, schrieb Paolo Bonzini: >> >> > This series changes all PCI devices (

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-05 Thread Michael S. Tsirkin
On Wed, Jun 05, 2013 at 10:33:05AM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Wed, Jun 05, 2013 at 07:53:05AM -0500, Anthony Liguori wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas Färber wrote: > >> >> Am 04.06.2

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-05 Thread Anthony Liguori
Paolo Bonzini writes: > QOM splits the destruction of a device in two phases: > > - unrealize, also known as "exit" from qdev times, should isolate > the device from the guest. After unrealize returns, the guest > should not be able to issue new requests. > > - instance_finalize will reclaim

[Qemu-devel] [PATCH v2] create qemu_openpty_raw() helper function and move it to a separate file

2013-06-05 Thread Michael Tokarev
In two places qemu uses openpty() which is very system-dependent, and in both places the pty is switched to raw mode as well. Make a wrapper function which does both steps, and move all the system-dependent complexity into a separate file, together with static/local implementations of openpty() and

Re: [Qemu-devel] [RFC] Policy for supported hosts/platforms

2013-06-05 Thread Ed Maste
On 5 June 2013 10:04, Anthony Liguori wrote: > > In terms of policy, we should consider buildbot coverage as a > requirement for a platform/architecture to be fully supported. Fully > supported means (1) that code will be rejected/reverted if it breaks one > of these platforms (2) breaking these

Re: [Qemu-devel] [PATCH] create qemu_openpty_raw() helper function and move it to a separate file

2013-06-05 Thread Ed Maste
On 5 June 2013 10:51, Michael Tokarev wrote: > This change removes #including of , > and other rather specific system headers out of qemu-common.h, > which isn't a place for such specific headers really. I needed to add the #include of in qemu-openpty.h in order for this to build on FreeBSD.

Re: [Qemu-devel] [PATCH 1/3] virtio: add bus_plugged() callback to VirtioDeviceClass

2013-06-05 Thread Frederic Konrad
On 04/06/2013 22:02, Jesse Larrew wrote: On 06/04/2013 12:35 PM, Andreas Färber wrote: Hi, Hi Andreas! Thanks for the review. :) Am 04.06.2013 18:22, schrieb Jesse Larrew: Virtio devices are initialized prior to plugging them into a bus. However, other initializations (such as host_feature

[Qemu-devel] [PATCH trivial] qemu-char: remove a few needless #includes

2013-06-05 Thread Michael Tokarev
This removes since we don't use syslogging, and removes second, solaris-specific, include of (which is included in a common part of the file) Signed-off-by: Michael Tokarev --- qemu-char.c |2 -- 1 file changed, 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index d04b429..f1df400

Re: [Qemu-devel] [PATCH 1/3] virtio: add bus_plugged() callback to VirtioDeviceClass

2013-06-05 Thread Frederic Konrad
On 04/06/2013 19:35, Andreas Färber wrote: Hi, Am 04.06.2013 18:22, schrieb Jesse Larrew: Virtio devices are initialized prior to plugging them into a bus. However, other initializations (such as host_features) don't occur until after the device is plugged into the bus. If a device needs to mod

[Qemu-devel] [PATCH] configure: Use ${config_host_ld} variable

2013-06-05 Thread Ed Maste
Signed-off-by: Ed Maste --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 1654413..ec833df 100755 --- a/configure +++ b/configure @@ -4445,7 +4445,7 @@ fi if test "$ARCH" = "tci"; then linker_script="" else - linker_script="-Wl,-T

[Qemu-devel] [PATCH] create qemu_openpty_raw() helper function and move it to a separate file

2013-06-05 Thread Michael Tokarev
In two places qemu uses openpty() which is very system-dependent, and in both places the pty is switched to raw mode as well. Make a wrapper function which does both steps, and move all the system-dependent complexity into a separate file, together with static/local implementations of openpty() and

Re: [Qemu-devel] [PATCH 1/2] kvm: zero-initialize KVM_SET_GSI_ROUTING input

2013-06-05 Thread Gleb Natapov
On Tue, Jun 04, 2013 at 02:52:32PM +0300, Michael S. Tsirkin wrote: > kvm_add_routing_entry makes an attempt to > zero-initialize any new routing entry. > However, it fails to initialize padding > within the u field of the structure > kvm_irq_routing_entry. > > Other functions like kvm_irqchip_upd

Re: [Qemu-devel] [PATCH v2] blockdev: reset werror/rerror on drive_del

2013-06-05 Thread Stefan Hajnoczi
On Wed, Jun 05, 2013 at 10:33:14AM +0200, Stefan Hajnoczi wrote: > Paolo Bonzini suggested the following test case: > > 1. Launch a guest and wait at the GRUB boot menu: > > qemu-system-x86_64 -enable-kvm -m 1024 \ >-drive if=none,cache=none,file=test.img,id=foo,werror=stop,rerror=stop >

Re: [Qemu-devel] [PATCH qom-cpu 00/15 v8] target-i386: convert CPU features into properties, part 1

2013-06-05 Thread Igor Mammedov
On Wed, 05 Jun 2013 15:29:08 +0200 Andreas Färber wrote: > Am 05.06.2013 15:18, schrieb Igor Mammedov: > > It's a rebase of v7 on current qom-cpu tree, since then some patches from it > > were applied to master. Convertion of feature bits is left for part 2 > > since it's not ready yet. > > > >

Re: [Qemu-devel] qemu & openpty

2013-06-05 Thread Michael Tokarev
05.06.2013 15:23, Andreas Färber wrote: > Am 05.06.2013 12:28, schrieb Michael Tokarev: [qemu_openpty() wrapper] > I haven't tried yet, but this sounds like something for osdep.c, no need > for a special qemu-openpty.c. This is a bit more tricky. At least on glibc, openpty() is in -lutil, but -l

Re: [Qemu-devel] [PATCH v5] NVMe: Initial commit for new storage interface

2013-06-05 Thread Stefan Hajnoczi
On Tue, Jun 04, 2013 at 09:17:10AM -0600, Keith Busch wrote: > Initial commit for emulated Non-Volatile-Memory Express (NVMe) pci > storage device. > > NVMe is an open, industry driven storage specification defining > an optimized register and command set designed to deliver the full > capabilitie

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-05 Thread Michael S. Tsirkin
On Wed, Jun 05, 2013 at 07:53:05AM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas Färber wrote: > >> Am 04.06.2013 20:51, schrieb Paolo Bonzini: > >> > This series changes all PCI devices (the sole to support hotplug > >> > _an

[Qemu-devel] [PATCH 06/15] target-i386: cpu: convert 'vendor' to static property

2013-06-05 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 31 --- 1 files changed, 24 insertions(+), 7 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index f42282e..21e7334 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1290,7 +1290,8 @@ stat

Re: [Qemu-devel] [PATCH V19 7/8] add-cow file format core code.

2013-06-05 Thread Stefan Hajnoczi
On Thu, May 30, 2013 at 06:00:24PM +0800, Dongxu Wang wrote: > +static coroutine_fn int add_cow_co_writev(BlockDriverState *bs, > + int64_t sector_num, > + int remaining_sectors, > +

Re: [Qemu-devel] [PATCH 1/2] kvm: zero-initialize KVM_SET_GSI_ROUTING input

2013-06-05 Thread Michael S. Tsirkin
On Wed, Jun 05, 2013 at 05:12:32PM +0300, Gleb Natapov wrote: > On Wed, Jun 05, 2013 at 05:11:44PM +0300, Michael S. Tsirkin wrote: > > On Wed, Jun 05, 2013 at 05:04:55PM +0300, Gleb Natapov wrote: > > > On Wed, Jun 05, 2013 at 05:02:07PM +0300, Michael S. Tsirkin wrote: > > > > On Wed, Jun 05, 201

Re: [Qemu-devel] [PATCH 1/2] kvm: zero-initialize KVM_SET_GSI_ROUTING input

2013-06-05 Thread Gleb Natapov
On Wed, Jun 05, 2013 at 05:11:44PM +0300, Michael S. Tsirkin wrote: > On Wed, Jun 05, 2013 at 05:04:55PM +0300, Gleb Natapov wrote: > > On Wed, Jun 05, 2013 at 05:02:07PM +0300, Michael S. Tsirkin wrote: > > > On Wed, Jun 05, 2013 at 04:00:20PM +0300, Gleb Natapov wrote: > > > > On Tue, Jun 04, 201

[Qemu-devel] [PATCH v2 1/4] blkdebug: Add BLKDBG_FLUSH_TO_OS/DISK events

2013-06-05 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block.c | 8 block/blkdebug.c | 3 +++ include/block/block.h | 3 +++ 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/block.c b/block.c index 3f616de..79ad33d 100644 --- a/block.c +++ b/block.c @@ -3186,13 +3186,11 @@ int b

Re: [Qemu-devel] [PATCH 1/2] kvm: zero-initialize KVM_SET_GSI_ROUTING input

2013-06-05 Thread Michael S. Tsirkin
On Wed, Jun 05, 2013 at 05:04:55PM +0300, Gleb Natapov wrote: > On Wed, Jun 05, 2013 at 05:02:07PM +0300, Michael S. Tsirkin wrote: > > On Wed, Jun 05, 2013 at 04:00:20PM +0300, Gleb Natapov wrote: > > > On Tue, Jun 04, 2013 at 02:52:32PM +0300, Michael S. Tsirkin wrote: > > > > kvm_add_routing_ent

  1   2   3   >