Re: [Qemu-devel] [PATCH 07/21] Revert "memory: limit sections in the radix tree to the actual address space size"

2013-05-31 Thread Paolo Bonzini
Il 01/06/2013 00:04, Richard Henderson ha scritto: > On 05/30/2013 02:16 PM, Paolo Bonzini wrote: >> This reverts commit 86a8623692b1b559a419a92eb8b6897c221bca74. >> >> Signed-off-by: Paolo Bonzini >> --- >> exec.c| 13 + >> include/exec/memory.h | 3 --- >> 2 files c

Re: [Qemu-devel] [PATCH v2 1/1] configure: dtc: Probe for libfdt_env.h

2013-05-31 Thread David Gibson
On Fri, May 31, 2013 at 10:44:33AM +0100, Peter Maydell wrote: > On 31 May 2013 09:25, Paolo Bonzini wrote: > > Please don't. Fedora is not going to use the bundled dtc because of a > > policy against bundling, and Fedora's dtc package doesn't include > > libfdt_env.h. > > It sounds like Fedora'

Re: [Qemu-devel] [PATCH v2 1/1] configure: dtc: Probe for libfdt_env.h

2013-05-31 Thread David Gibson
On Fri, May 31, 2013 at 10:25:55AM +0200, Paolo Bonzini wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Il 31/05/2013 05:32, David Gibson ha scritto: > >>> Then again, although we certainly want to keep changes which > >>> require updates to libfdt_env.h rare, I'm not going to rule >

Re: [Qemu-devel] [PATCH v7 1/4] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS)

2013-05-31 Thread Kevin O'Connor
On Fri, May 31, 2013 at 02:48:17PM +0200, Paolo Bonzini wrote: > Il 31/05/2013 04:06, Kevin O'Connor ha scritto: > > On Wed, May 29, 2013 at 01:27:24AM -0700, Jordan Justen wrote: > >> > The isapc machine with seabios currently requires the BIOS region > >> > to be read/write memory rather than rea

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-31 Thread Kevin O'Connor
On Fri, May 31, 2013 at 10:13:34AM +0200, Peter Stuge wrote: > Kevin O'Connor wrote: > > one possible way forward would be to split the current SeaBIOS rom > > into two roms: "qvmloader" and "seabios". The "qvmloader" would do > > the qemu specific platform init (pci init, smm init, mtrr init, bio

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Jordan Justen
On Fri, May 31, 2013 at 5:01 PM, Laszlo Ersek wrote: > On 05/31/13 23:03, Jordan Justen wrote: > >> Of course, the fact that the current FAT driver is exclusionary for >> free software projects is a point that is not lost on me. I just don't >> agree that the best response to this is a GPL'd FAT d

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Kevin O'Connor
On Fri, May 31, 2013 at 07:58:36AM -0500, Anthony Liguori wrote: > Kevin O'Connor writes: > > Given the objections to implementing ACPI directly in QEMU, one > > possible way forward would be to split the current SeaBIOS rom into > > two roms: "qvmloader" and "seabios". The "qvmloader" would do t

Re: [Qemu-devel] [PATCH] target-i386: Fix aflag logic for CODE64 and the 0x67 prefix

2013-05-31 Thread Laszlo Ersek
On 05/29/13 21:30, Richard Henderson wrote: > The code reorganization in commit 4a6fd938 broke handling of PREFIX_ADR. > While fixing this, tidy and comment the code so that it's more obvious > what's going on in setting both aflag and dflag. > > The TARGET_X86_64 ifdef can be eliminated because C

Re: [Qemu-devel] [PATCH 7/8] pseries: savevm support for PAPR virtual SCSI

2013-05-31 Thread Benjamin Herrenschmidt
On Fri, 2013-05-31 at 12:41 +0200, Paolo Bonzini wrote: > It may be halfway through, but it is always restarted on the destination. "restarted" as in the whole transfer is restarted if any right ? So we can essentially consider as a new request for which we just did scsi_req_enqueue() ? IE. We d

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Laszlo Ersek
On 05/31/13 23:03, Jordan Justen wrote: > Of course, the fact that the current FAT driver is exclusionary for > free software projects is a point that is not lost on me. I just don't > agree that the best response to this is a GPL'd FAT driver. What would you suggest? Thank you, Laszlo

Re: [Qemu-devel] [PATCH v3 4/5] xilinx_devcfg: Zynq devcfg device model

2013-05-31 Thread Peter Crosthwaite
Hi Anthony, On Fri, May 31, 2013 at 5:41 AM, Anthony Liguori wrote: > Peter Crosthwaite writes: [snip] >>> } >>> >> >> That's still possible using just the register API (Patch 2 content >> only) and throwing away the memory API glue. I think its actually >> quite similar to V1 of the patch serie

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-31 Thread Jordan Justen
On Fri, May 31, 2013 at 2:32 AM, Gerd Hoffmann wrote: > Hi, > >> I guess -bios would load coreboot. Coreboot would siphon the data >> necessary for ACPI table building through the current (same) fw_cfg >> bottleneck, build the tables, > > Yes. So, this is really about making coreboot+seabios th

Re: [Qemu-devel] [PATCH 12/21] memory: Add iommu map/unmap notifiers

2013-05-31 Thread Richard Henderson
On 05/30/2013 02:17 PM, Paolo Bonzini wrote: > From: David Gibson > > This patch adds a NotifierList to MemoryRegions which represent IOMMUs > allowing other parts of the code to register interest in mappings or > unmappings from the IOMMU. All IOMMU implementations will need to call > memory_re

Re: [Qemu-devel] [PATCH 13/21] vfio: abort if an emulated iommu is used

2013-05-31 Thread Richard Henderson
On 05/30/2013 02:17 PM, Paolo Bonzini wrote: > From: Avi Kivity > > vfio doesn't support guest iommus yet, indicate it to the user > by gently depositing a core on their disk. > > Reviewed-by: Peter Maydell > Signed-off-by: Avi Kivity > Signed-off-by: Paolo Bonzini > --- > hw/misc/vfio.c | 2

Re: [Qemu-devel] [PATCH 11/21] memory: iommu support

2013-05-31 Thread Richard Henderson
On 05/30/2013 02:16 PM, Paolo Bonzini wrote: > struct MemoryRegion { > /* All fields are private - violators will be prosecuted */ > const MemoryRegionOps *ops; > +const MemoryRegionIOMMUOps *iommu_ops; > void *opaque; > MemoryRegion *parent; ... > +void memory_region_init_

Re: [Qemu-devel] [PATCH 09/21] exec: reorganize mem_add to match Int128 version

2013-05-31 Thread Richard Henderson
On 05/30/2013 02:16 PM, Paolo Bonzini wrote: > When adding support for 2^64-byte sections, we will have to change > the structure of mem_add to avoid failures in int128_get64. > Reorganize the code now before introducing Int128. > > Signed-off-by: Paolo Bonzini > --- > exec.c | 39 ++

Re: [Qemu-devel] [PATCH 10/21] memory: make section size a 128-bit integer

2013-05-31 Thread Richard Henderson
On 05/30/2013 02:16 PM, Paolo Bonzini wrote: > +static inline Int128 int128_rshift(Int128 a, int n) > +{ > +return (Int128) { (a.lo >> n) | (a.hi << (64 - n)), (a.hi >> n) }; > +} Produces wrong results for n == 0, since (a.hi << 64) is undefined. r~

Re: [Qemu-devel] [PATCH 06/21] exec: return MemoryRegion from address_space_translate

2013-05-31 Thread Richard Henderson
On 05/30/2013 02:16 PM, Paolo Bonzini wrote: > Only address_space_translate_for_iotlb needs to return the section. > Every caller of address_space_translate now uses only section->mr, > return it directly. > > Signed-off-by: Paolo Bonzini > --- > exec.c| 150 > ++

Re: [Qemu-devel] [PATCH 07/21] Revert "memory: limit sections in the radix tree to the actual address space size"

2013-05-31 Thread Richard Henderson
On 05/30/2013 02:16 PM, Paolo Bonzini wrote: > This reverts commit 86a8623692b1b559a419a92eb8b6897c221bca74. > > Signed-off-by: Paolo Bonzini > --- > exec.c| 13 + > include/exec/memory.h | 3 --- > 2 files changed, 1 insertion(+), 15 deletions(-) I would think that

Re: [Qemu-devel] [PATCH 05/21] exec: Implement subpage_read/write via address_space_rw

2013-05-31 Thread Richard Henderson
On 05/30/2013 02:16 PM, Paolo Bonzini wrote: > From: Jan Kiszka > > This will allow to add support for unaligned memory regions: the subpage > container region can activate unaligned support unconditionally because > the read/write handler will now ensure that accesses are split as > required by

Re: [Qemu-devel] [PATCH 04/21] exec: Resolve subpages in one step except for IOTLB fills

2013-05-31 Thread Richard Henderson
On 05/30/2013 02:16 PM, Paolo Bonzini wrote: > static MemoryRegionSection *address_space_lookup_region(AddressSpace *as, > -hwaddr addr) > +hwaddr addr, > +

Re: [Qemu-devel] [PATCH 03/21] exec: Allow unaligned address_space_rw

2013-05-31 Thread Richard Henderson
On 05/30/2013 02:16 PM, Paolo Bonzini wrote: > From: Jan Kiszka > > This will be needed for some corner cases with para-virtual I/O ports. > > Signed-off-by: Jan Kiszka > Signed-off-by: Paolo Bonzini > --- > exec.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) Reviewed

Re: [Qemu-devel] [PATCH 02/21] memory: move private types to exec.c

2013-05-31 Thread Richard Henderson
On 05/30/2013 02:16 PM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > exec.c | 16 > include/exec/memory-internal.h | 15 --- > 2 files changed, 16 insertions(+), 15 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH 01/21] memory: Introduce address_space_lookup_region

2013-05-31 Thread Richard Henderson
On 05/30/2013 02:16 PM, Paolo Bonzini wrote: > From: Jan Kiszka > > This introduces a wrapper for phys_page_find (before we complicate > address_space_translate with IOMMU translation). > > The function will also include subpage handling. > > Signed-off-by: Jan Kiszka > Signed-off-by: Paolo Bo

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Jordan Justen
On Fri, May 31, 2013 at 1:27 PM, Anthony Liguori wrote: > Jordan Justen writes: > >> On Fri, May 31, 2013 at 7:38 AM, Anthony Liguori >> wrote: >>> In terms of creating a FAT module, the most likely source would seem to >>> be the kernel code and since that's GPL, I don't think it's terribly >>

[Qemu-devel] [PATCH 4/4] tcg/aarch64: implement tlb lookup fast path

2013-05-31 Thread Jani Kokkonen
From: Jani Kokkonen implement the fast path for tcg_out_qemu_ld/st. Signed-off-by: Jani Kokkonen --- tcg/aarch64/tcg-target.c | 161 +-- 1 file changed, 157 insertions(+), 4 deletions(-) diff --git a/tcg/aarch64/tcg-target.c b/tcg/aarch64/tcg-target

[Qemu-devel] [PATCH 2/4] tcg/aarch64: implement byte swap operations

2013-05-31 Thread Jani Kokkonen
From: Claudio Fontana implement the optional byte swap operations with the dedicated aarch64 instructions. These instructions are also needed for the tlb lookup. Signed-off-by: Claudio Fontana --- tcg/aarch64/tcg-target.c | 42 ++ tcg/aarch64/tcg-target.

[Qemu-devel] [PATCH 0/4] ARM aarch64 TCG tlb fast lookup

2013-05-31 Thread Jani Kokkonen
From: Jani Kokkonen This series implements the TCG tlb fast lookup in tcg_out_qemu_ld/st for the aarch64 TCG target. It requires the reviewed but not committed yet series "[PATCH v4 0/3] ARM aarch64 TCG target" at: http://lists.nongnu.org/archive/html/qemu-devel/2013-05/msg04200.html https://gi

[Qemu-devel] [PATCH 1/4] tcg/aarch64: more low level ops in preparation of tlb, lookup

2013-05-31 Thread Jani Kokkonen
From: Claudio Fontana for arith operations, add SUBS and add a shift parameter so that all arith instructions can make use of shifted registers. Also add functions to TEST/AND registers with immediate patterns. Signed-off-by: Claudio Fontana --- tcg/aarch64/tcg-target.c | 72 ++

[Qemu-devel] [PATCH 3/4] tcg/aarch64: implement sign/zero extend operations

2013-05-31 Thread Jani Kokkonen
From: Claudio Fontana implement the optional sign/zero extend operations with the dedicated aarch64 instructions. These instructions are also needed for the tlb lookup. Signed-off-by: Claudio Fontana --- tcg/aarch64/tcg-target.c | 58 ++-- tcg/aarch6

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Anthony Liguori
Jordan Justen writes: > On Fri, May 31, 2013 at 11:35 AM, Anthony Liguori > wrote: >> As I think more about it, I think forking edk2 is inevitable. We need a >> clean repo that doesn't include the proprietary binaries. I doubt >> upstream edk2 is willing to remove the binaries. > > No, probab

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Anthony Liguori
Jordan Justen writes: > On Fri, May 31, 2013 at 7:38 AM, Anthony Liguori > wrote: >> In terms of creating a FAT module, the most likely source would seem to >> be the kernel code and since that's GPL, I don't think it's terribly >> avoidable to end up with a GPL'd uefi implementation. > > Why w

Re: [Qemu-devel] [PATCH 4/4] tcg/aarch64: implement tlb lookup fast path

2013-05-31 Thread Richard Henderson
On 05/31/2013 11:07 AM, Jani Kokkonen wrote: > +/* Load and compare a TLB entry, leaving the flags set. Leaves X2 pointing > + to the tlb entry. Clobbers X0,X1,X2,X3 and TMP. */ > + > +static void tcg_out_tlb_read(TCGContext *s, TCGReg addr_reg, > + int s_bits, uint

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-31 Thread Patrick Georgi
Am 31.05.2013 14:09, schrieb David Woodhouse: > On Thu, 2013-05-30 at 09:20 -0700, Jordan Justen wrote: >> On Thu, May 30, 2013 at 5:19 AM, David Woodhouse >> wrote: >>> https://github.com/pgeorgi/edk2/tree/coreboot-pkg >> Is the license on this actually BSD as the License.txt indicates? Yes. All

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Jordan Justen
On Fri, May 31, 2013 at 11:35 AM, Anthony Liguori wrote: > As I think more about it, I think forking edk2 is inevitable. We need a > clean repo that doesn't include the proprietary binaries. I doubt > upstream edk2 is willing to remove the binaries. No, probably not unless a BSD licensed altern

Re: [Qemu-devel] [PATCH 3/4] tcg/aarch64: implement sign/zero extend operations

2013-05-31 Thread Richard Henderson
On 05/31/2013 11:05 AM, Jani Kokkonen wrote: > +static inline void tcg_out_uxt(TCGContext *s, int s_bits, > + TCGReg rd, TCGReg rn) > +{ > +/* using ALIASes UXTB 0x53001c00, UXTH 0x53003c00 > + of UBFM Wd, Wn, #0, #7|15 and mov */ > +int bits = 8 * (1 <<

Re: [Qemu-devel] [PATCH 2/4] tcg/aarch64: implement byte swap operations

2013-05-31 Thread Richard Henderson
On 05/31/2013 11:01 AM, Jani Kokkonen wrote: > +static inline void tcg_out_rev(TCGContext *s, int ext, TCGReg rd, TCGReg rm) > +{ > +/* using REV 0x5ac00800 */ > +unsigned int base = ext ? 0xdac00c00 : 0x5ac00800; > +tcg_out32(s, base | rm << 5 | rd); > +} > + > +static inline void tcg_

Re: [Qemu-devel] [PATCH 1/4] tcg/aarch64: more low level ops in preparation of tlb, lookup

2013-05-31 Thread Richard Henderson
On 05/31/2013 10:57 AM, Jani Kokkonen wrote: > +ARITH_SUBS = 0x6b, Any reason you're adding SUBS here, but not ANDS? > +/* encode a logical immediate, mapping user parameter > + M=set bits pattern length to S=M-1 */ > +static inline unsigned int > +aarch64_limm(unsigned int m, unsigned int

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Jordan Justen
On Fri, May 31, 2013 at 7:38 AM, Anthony Liguori wrote: > In terms of creating a FAT module, the most likely source would seem to > be the kernel code and since that's GPL, I don't think it's terribly > avoidable to end up with a GPL'd uefi implementation. Why would OpenBSD not be a potential sou

Re: [Qemu-devel] [PATCH v2] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS)

2013-05-31 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] virtio-pci: drop unused wmb macro

2013-05-31 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [QEMU PATCH v3] qdev: fix get_fw_dev_path to support to add nothing to fw_dev_path

2013-05-31 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH stable-1.1] qga: set umask 0077 when daemonizing (CVE-2013-2007)

2013-05-31 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] virtio-pci: drop unused wmb macro

2013-05-31 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] seccomp: add the asynchronous I/O syscalls to the whitelist

2013-05-31 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v4] tests: set MALLOC_PERTURB_ to expose memory bugs

2013-05-31 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PULL] VirtFS update

2013-05-31 Thread Anthony Liguori
Pulled. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] gdbstub: do not restart crashed guest

2013-05-31 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v7 0/4] KVM flash memory support

2013-05-31 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Anthony Liguori
Paolo Bonzini writes: > Il 31/05/2013 19:06, Anthony Liguori ha scritto: >> David Woodhouse writes: >> >>> On Fri, 2013-05-31 at 10:43 -0500, Anthony Liguori wrote: It's even more fundamental. OVMF as a whole (at least in it's usable form) is not Open Source. >>> >>> The FAT module

[Qemu-devel] [PATCH] correct RTC_CHANGE_EVENT description

2013-05-31 Thread Marcelo Tosatti
Fix RTC_CHANGE event description to match implementation. Signed-off-by: Marcelo Tosatti diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt index 92fe5fb..00b4087 100644 --- a/QMP/qmp-events.txt +++ b/QMP/qmp-events.txt @@ -203,7 +203,8 @@ Emitted when the guest changes the RTC time. Data:

[Qemu-devel] [PATCH v2] virtio-rng: Fix crash with non-default backend

2013-05-31 Thread Cole Robinson
'default_backend' isn't always set, but 'rng' is, so use that. $ ./x86_64-softmmu/qemu-system-x86_64 -object rng-random,id=rng0,filename=/dev/random -device virtio-rng-pci,rng=rng0 Segmentation fault (core dumped) Regressed with virtio refactoring in 59ccd20a9ac719cff82180429458728f03ec612f CC:

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 19:06, Anthony Liguori ha scritto: > David Woodhouse writes: > >> On Fri, 2013-05-31 at 10:43 -0500, Anthony Liguori wrote: >>> It's even more fundamental. OVMF as a whole (at least in it's usable >>> form) is not Open Source. >> >> The FAT module is required to make EDK2 usable,

Re: [Qemu-devel] [PATCH] libcacard/vscclient: fix leakage of socket on error paths

2013-05-31 Thread Alon Levy
> Spotted by Coverity. > Self NACK. I'll send a more complete patch, and use closesocket. > Signed-off-by: Alon Levy > --- > libcacard/vscclient.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c > index ac23647..9

[Qemu-devel] [PATCH] libcacard/vscclient: fix leakage of socket on error paths

2013-05-31 Thread Alon Levy
Spotted by Coverity. Signed-off-by: Alon Levy --- libcacard/vscclient.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index ac23647..9fcc548 100644 --- a/libcacard/vscclient.c +++ b/libcacard/vscclient.c @@ -618,18 +618,

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Anthony Liguori
Laszlo Ersek writes: > On 05/31/13 16:38, Anthony Liguori wrote: > >> It's either Open Source or it's not. It's currently not. > > I disagree with this binary representation of Open Source or Not. If it > weren't (mostly) Open Source, how could we fork (most of) it as you're > suggesting (from t

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Anthony Liguori
David Woodhouse writes: > On Fri, 2013-05-31 at 10:43 -0500, Anthony Liguori wrote: >> It's even more fundamental. OVMF as a whole (at least in it's usable >> form) is not Open Source. > > The FAT module is required to make EDK2 usable, and yes, that's not Open > Source. So in a sense you're ri

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Laszlo Ersek
On 05/31/13 18:33, David Woodhouse wrote: > On Fri, 2013-05-31 at 10:43 -0500, Anthony Liguori wrote: >> It's even more fundamental. OVMF as a whole (at least in it's usable >> form) is not Open Source. > > The FAT module is required to make EDK2 usable, and yes, that's not Open > Source. So in

[Qemu-devel] [PATCH] script: git script to compile every commit in a range of commits

2013-05-31 Thread Jeff Cody
This is a git script that will iterate through every commit in a specified range, and perform a configure and make. The intention of this script is not to act as a check of code correctness, but to see if any commit breaks compilation of the tree. The idea is that prior to submitting a patch or p

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Laszlo Ersek
On 05/31/13 16:38, Anthony Liguori wrote: > It's either Open Source or it's not. It's currently not. I disagree with this binary representation of Open Source or Not. If it weren't (mostly) Open Source, how could we fork (most of) it as you're suggesting (from the soapbox :))? > I have a hard >

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Laszlo Ersek
On 05/31/13 17:43, Anthony Liguori wrote: > David Woodhouse writes: > >> On Fri, 2013-05-31 at 08:04 -0500, Anthony Liguori wrote: >>> >>> >>> >>> Fork OVMF, drop the fat module, and just add GPL code. It's an easily >>> solvable problem. >> >> Heh. Actually it doesn't need to be a fork. It's m

Re: [Qemu-devel] [PATCH] s390/ipl: Fix spurious errors in virtio

2013-05-31 Thread Andreas Färber
Am 23.05.2013 13:51, schrieb Christian Borntraeger: > With the ccw ipl code sometimes an error message like > "virtio: trying to map MMIO memory" or > "Guest moved used index from %u to %u" appeared. Turns out > that the ccw bios did not zero out the vring, which might > cause stale values in avail

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread David Woodhouse
On Fri, 2013-05-31 at 10:43 -0500, Anthony Liguori wrote: > It's even more fundamental. OVMF as a whole (at least in it's usable > form) is not Open Source. The FAT module is required to make EDK2 usable, and yes, that's not Open Source. So in a sense you're right. But we're talking here about

[Qemu-devel] [PATCH] fpu: Simplify floatx80ToCommonNaN function.

2013-05-31 Thread Thomas Schwinge
Signed-off-by: Thomas Schwinge --- fpu/softfloat-specialize.h | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git fpu/softfloat-specialize.h fpu/softfloat-specialize.h index 518f694..83add1a 100644 --- fpu/softfloat-specialize.h +++ fpu/softfloat-specialize.h @@ -9

Re: [Qemu-devel] [Qemu-trivial] [PATCH] fpu: Simplify floatx80ToCommonNaN function.

2013-05-31 Thread Thomas Schwinge
Hi! On Fri, 31 May 2013 13:34:12 +0100, Peter Maydell wrote: > On 31 May 2013 13:07, Michael Tokarev wrote: > > Hmm. And where's the simplification? Here's context diff for the same: > > > > *** fpu/softfloat-specialize.h.orig 2013-05-31 16:02:51.614710351 +0400 > > --- fpu/softfloat-speci

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Anthony Liguori
David Woodhouse writes: > On Fri, 2013-05-31 at 08:04 -0500, Anthony Liguori wrote: >> >> >> >> Fork OVMF, drop the fat module, and just add GPL code. It's an easily >> solvable problem. > > Heh. Actually it doesn't need to be a fork. It's modular, and the FAT > driver is just a single module

Re: [Qemu-devel] [Qemu-trivial] [PATCH] do not check pointers after dereferencing them

2013-05-31 Thread Michael Tokarev
31.05.2013 16:00, Paolo Bonzini wrote: > Two instances, both spotted by Coverity. In one, two blocks were > swapped. In the other, the check is not needed anymore. Thanks, applied to the trivial patches queue. /mjt

[Qemu-devel] [Bug 1186303] [NEW] virtual fat do not working in qemu 1.5.0

2013-05-31 Thread prochazka nicolas
Public bug reported: Guest : windows Seven / XP Qemu version : 1.5.0 cmd line : -drive file=fat:floppy:/mnt/vdisk/diskconf/TEST004/,if=none,id=drive-fdc0-0-0,readonly=on generated by libvirt : works with qemu <= 1.4.1 with qemu 1.5.0 , gues

Re: [Qemu-devel] [PATCH] target-i386: Fix aflag logic for CODE64 and the 0x67 prefix

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 17:03, Richard Henderson ha scritto: > Ping. > > On 05/29/2013 12:30 PM, Richard Henderson wrote: >> The code reorganization in commit 4a6fd938 broke handling of PREFIX_ADR. >> While fixing this, tidy and comment the code so that it's more obvious >> what's going on in setting both a

Re: [Qemu-devel] [PATCH] target-i386: Fix aflag logic for CODE64 and the 0x67 prefix

2013-05-31 Thread Richard Henderson
Ping. On 05/29/2013 12:30 PM, Richard Henderson wrote: > The code reorganization in commit 4a6fd938 broke handling of PREFIX_ADR. > While fixing this, tidy and comment the code so that it's more obvious > what's going on in setting both aflag and dflag. > > The TARGET_X86_64 ifdef can be eliminat

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Anthony Liguori
Laszlo Ersek writes: > On 05/31/13 15:04, Anthony Liguori wrote: >> Laszlo Ersek writes: >> >>> On 05/31/13 09:09, Jordan Justen wrote: >>> >>> Due to licensing differences I can't just port code from SeaBIOS to >>> OVMF >> >> > > :) > >> Fork OVMF, drop the fat module, and just add GPL code.

Re: [Qemu-devel] [Qemu-trivial] [PATCH] fpu: Simplify floatx80ToCommonNaN function.

2013-05-31 Thread Peter Maydell
On 31 May 2013 14:01, Thomas Schwinge wrote: > On Fri, 31 May 2013 13:34:12 +0100, Peter Maydell > wrote: >> That said, I think any new patches to fpu/ need to >> come with an explicit statement that they can be >> licensed under the softfloat-2a license or GPLv2 >> or BSD (etc etc) so they aren

[Qemu-devel] [PULL 3/3] target-i386: Fix mask of pte index in memory mapping

2013-05-31 Thread Luiz Capitulino
From: Qiao Nuohan Function walk_pte() needs pte index to calculate virtual address. However, pte index of PAE paging or IA-32e paging is 9 bit, so the mask should be 0x1ff. Signed-off-by: Qiao Nuohan Reviewed-by: Jesse Larrew Signed-off-by: Andreas Färber Signed-off-by: Luiz Capitulino ---

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Laszlo Ersek
On 05/31/13 16:08, David Woodhouse wrote: > On Fri, 2013-05-31 at 08:04 -0500, Anthony Liguori wrote: >> >> >> >> Fork OVMF, drop the fat module, and just add GPL code. It's an easily >> solvable problem. > > Heh. Actually it doesn't need to be a fork. It's modular, and the FAT > driver is just

[Qemu-devel] [PULL 2/3] target-i386: fix abort on bad PML4E/PDPTE/PDE/PTE addresses

2013-05-31 Thread Luiz Capitulino
The code used to walk IA-32e page-tables, and possibly PAE page-tables, uses the bit mask ~0xfff to get the next PML4E/PDPTE/PDE/PTE address. However, as we use a uint64_t to store the resulting address, that mask gets expanded to 0xf000 which not only ends up selecting reserved bits b

[Qemu-devel] [PULL 1/3] qapi: pad GenericList value fields to 64 bits

2013-05-31 Thread Luiz Capitulino
From: Michael Roth With the introduction of native list types, we now have types such as int64List where the 'value' field is not a pointer, but the actual 64-bit value. On 32-bit architectures, this can lead to situations where 'next' field offset in GenericList does not correspond to the 'next

[Qemu-devel] [PULL 0/3] QMP queue

2013-05-31 Thread Luiz Capitulino
One qapi fix and two fixes that affect the dump-guest-memory QMP command. The changes (since 87d23f78aa79b72da022afda358bbc8a8509ca70) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Luiz Capitulino (1): target-i386: fix abort on bad PML4E/PDPTE/

Re: [Qemu-devel] fixing qemu busy wait

2013-05-31 Thread Paolo Bonzini
Il 18/04/2013 20:47, Orr Dvory ha scritto: > is this better? Yes -- but I don't remember if this was fixed elsewhere. Can you reproduce the problem in 1.5.0? If so, please send the patch according to the guidelines at http://wiki.qemu.org/Contribute/SubmitAPatch. Paolo > diff -uprN qemu-1.4.1/

Re: [Qemu-devel] [PATCH qom-cpu v3 0/9] dump: Build cleanups redone

2013-05-31 Thread Luiz Capitulino
On Thu, 30 May 2013 17:07:52 +0200 Andreas Färber wrote: > Hello, > > This series is an alternative to patches previously queued or posted, > based on virgin master. > > As requested by Paolo, this replaces Kate's previous memory_mapping split > and my follow-ups and instead goes directly for m

Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer

2013-05-31 Thread Luiz Capitulino
On Fri, 31 May 2013 21:04:10 +0800 Wenchao Xia wrote: > 于 2013-5-30 10:41, Wenchao Xia 写道: > > 于 2013-5-27 23:41, Kevin Wolf 写道: > >> Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: > >>> These patches are the common part of my hmp/qmp block query series > >>> and Pavel's > >>> qmp snapshot c

Re: [Qemu-devel] [PATCH qom-cpu v3 9/9] memory_mapping: Change qemu_get_guest_memory_mapping() semantics

2013-05-31 Thread Luiz Capitulino
On Thu, 30 May 2013 17:08:01 +0200 Andreas Färber wrote: > Previously it would search for the first CPU with paging enabled and > retrieve memory mappings from this and any following CPUs or return an > error if that fails. > > Instead walk all CPUs and if paging is enabled retrieve the memory >

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread David Woodhouse
On Fri, 2013-05-31 at 08:04 -0500, Anthony Liguori wrote: > > > > Fork OVMF, drop the fat module, and just add GPL code. It's an easily > solvable problem. Heh. Actually it doesn't need to be a fork. It's modular, and the FAT driver is just a single module. Which is actually included in *binar

Re: [Qemu-devel] [PATCH qom-cpu v3 6/9] cpu: Turn cpu_get_memory_mapping() into a CPUState hook

2013-05-31 Thread Luiz Capitulino
On Thu, 30 May 2013 17:07:58 +0200 Andreas Färber wrote: > Signed-off-by: Andreas Färber > --- > include/qom/cpu.h | 11 +++ > include/sysemu/memory_mapping.h | 2 -- > memory_mapping-stub.c | 6 -- > memory_mapping.c | 2 +- > qom/c

Re: [Qemu-devel] [PATCH qom-cpu v3 4/9] cpu: Turn cpu_paging_enabled() into a CPUState hook

2013-05-31 Thread Luiz Capitulino
On Thu, 30 May 2013 17:07:56 +0200 Andreas Färber wrote: > Signed-off-by: Andreas Färber Nitpick alarm on. > --- > include/qom/cpu.h | 10 ++ > include/sysemu/memory_mapping.h | 1 - > memory_mapping-stub.c | 6 -- > memory_mapping.c

Re: [Qemu-devel] [PATCH 2/2] chardev: fix "info chardev" output

2013-05-31 Thread Peter Krempa
On 05/31/13 15:21, Gerd Hoffmann wrote: Hi, Hi, Please double-check. Current master (87d23f78aa79b72da022afda358bbc8a8509ca70 to be exact) works just fine for me. libvirt works, including a serial line redirected to pty, and 'info chardev' looks sane too. sorry for the fuzz. :/ Upstr

Re: [Qemu-devel] [PATCH 2/2] chardev: fix "info chardev" output

2013-05-31 Thread Gerd Hoffmann
Hi, > Without this patch the returned message for "query-chardev" is: > > { > "return": [ > { > "filename": "pty:/dev/pts/8", > "label": "charserial0" > }, > { > "filename": "unix:/var/lib/libvirt/qemu/qemu-git.monitor,server", >

Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer

2013-05-31 Thread Wenchao Xia
于 2013-5-30 10:41, Wenchao Xia 写道: 于 2013-5-27 23:41, Kevin Wolf 写道: Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: These patches are the common part of my hmp/qmp block query series and Pavel's qmp snapshot command converion series. It mainly does following things: 1 move snapshot related

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Anthony Liguori
Laszlo Ersek writes: > On 05/31/13 09:09, Jordan Justen wrote: > > Due to licensing differences I can't just port code from SeaBIOS to > OVMF Fork OVMF, drop the fat module, and just add GPL code. It's an easily solvable problem. Rewriting BSD implementations of everything is silly. Every o

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread David Woodhouse
On Fri, 2013-05-31 at 07:58 -0500, Anthony Liguori wrote: > What about a small change to the SeaBIOS build system to allow ACPI > table generation to be done via a "plugin". SeaBIOS already accepts ACPI tables from Coreboot or UEFI, and queries them to find things that it needs. > This could be a

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-31 Thread Laszlo Ersek
On 05/31/13 10:13, Peter Stuge wrote: > ACPI bytes are obviously a function of QEMU configuration. Precisely! When we evaluate that (mathematical-sense) function in boot firmware, we need to retrieve the function's arguments. Those arguments are bits of QEMU configuration, as you say, and fw_cfg

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-31 Thread Anthony Liguori
Kevin O'Connor writes: > On Tue, May 28, 2013 at 07:53:09PM -0400, Kevin O'Connor wrote: >> There were discussions on potentially introducing a middle component >> to generate the tables. Coreboot was raised as a possibility, and >> David thought it would be okay to use coreboot for both OVMF an

Re: [Qemu-devel] [PATCH v7 1/4] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS)

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 14:40, Laszlo Ersek ha scritto: > I think we've been here before... > > - always resetting the PAM registers broke S3 resume: > http://thread.gmane.org/gmane.comp.emulators.qemu/195931/focus=195932 > http://thread.gmane.org/gmane.comp.emulators.qemu/195931/focus=196081 > > - there w

Re: [Qemu-devel] [PATCH v7 1/4] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS)

2013-05-31 Thread Paolo Bonzini
Il 31/05/2013 04:06, Kevin O'Connor ha scritto: > On Wed, May 29, 2013 at 01:27:24AM -0700, Jordan Justen wrote: >> > The isapc machine with seabios currently requires the BIOS region >> > to be read/write memory rather than read-only memory. >> > >> > KVM currently cannot support the BIOS as a RO

Re: [Qemu-devel] [PATCH] do not check pointers after dereferencing them

2013-05-31 Thread Eric Blake
On 05/31/2013 06:00 AM, Paolo Bonzini wrote: > Two instances, both spotted by Coverity. In one, two blocks were > swapped. In the other, the check is not needed anymore. > > Cc: qemu-sta...@nongnu.org > Cc: qemu-triv...@nongnu.org > Signed-off-by: Paolo Bonzini > --- > monitor.c | 2 +- > sav

Re: [Qemu-devel] [PATCH 2/2] chardev: fix "info chardev" output

2013-05-31 Thread Peter Krempa
On 05/31/13 14:36, Eric Blake wrote: > On 05/28/2013 12:34 AM, Gerd Hoffmann wrote: >> Fill unset CharDriverState->filename with the backend name, so >> 'info chardev' will return at least the chardev type. Don't >> touch it in case the chardev init function filled it already, >> like the socket+p

Re: [Qemu-devel] [PATCH uq/master] fix double free the memslot in kvm_set_phys_mem

2013-05-31 Thread Luiz Capitulino
On Fri, 31 May 2013 16:52:18 +0800 Xiao Guangrong wrote: > Luiz Capitulino reported that guest refused to boot and qemu > complained with: > kvm_set_phys_mem: error unregistering overlapping slot: Invalid argument > > It is caused by commit 235e8982ad that did double free for the memslot > so th

Re: [Qemu-devel] [PATCH v7 1/4] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS)

2013-05-31 Thread Laszlo Ersek
On 05/31/13 06:41, Jordan Justen wrote: > On Thu, May 30, 2013 at 7:06 PM, Kevin O'Connor wrote: >> On Wed, May 29, 2013 at 01:27:24AM -0700, Jordan Justen wrote: >>> The isapc machine with seabios currently requires the BIOS region >>> to be read/write memory rather than read-only memory. >>> >>>

Re: [Qemu-devel] [PATCH v2 1/1] configure: dtc: Probe for libfdt_env.h

2013-05-31 Thread Peter Crosthwaite
Hi, On Fri, May 31, 2013 at 7:54 PM, Paolo Bonzini wrote: > Il 31/05/2013 11:44, Peter Maydell ha scritto: >> On 31 May 2013 09:25, Paolo Bonzini wrote: >>> Please don't. Fedora is not going to use the bundled dtc because of a >>> policy against bundling, and Fedora's dtc package doesn't includ

Re: [Qemu-devel] [PATCH 2/2] chardev: fix "info chardev" output

2013-05-31 Thread Eric Blake
On 05/28/2013 12:34 AM, Gerd Hoffmann wrote: > Fill unset CharDriverState->filename with the backend name, so > 'info chardev' will return at least the chardev type. Don't > touch it in case the chardev init function filled it already, > like the socket+pty chardevs do for example. > > Signed-off

Re: [Qemu-devel] [Qemu-trivial] [PATCH] fpu: Simplify floatx80ToCommonNaN function.

2013-05-31 Thread Peter Maydell
On 31 May 2013 13:07, Michael Tokarev wrote: > Hmm. And where's the simplification? Here's context diff for the same: > > *** fpu/softfloat-specialize.h.orig 2013-05-31 16:02:51.614710351 +0400 > --- fpu/softfloat-specialize.h 2013-05-31 16:02:59.838820308 +0400 > *** > *** 936,9

  1   2   >