Re: [Qemu-devel] snabbswitch integration with QEMU for userspace ethernet I/O

2013-05-29 Thread Michael S. Tsirkin
On Thu, May 30, 2013 at 08:46:42AM +0200, Stefan Hajnoczi wrote: > On Wed, May 29, 2013 at 6:02 PM, Julian Stecklina > wrote: > > On 05/29/2013 04:21 PM, Stefan Hajnoczi wrote: > >> The fact that a single switch process has shared memory access to all > >> guests' RAM is critical. If the switch p

Re: [Qemu-devel] snabbswitch integration with QEMU for userspace ethernet I/O

2013-05-29 Thread Stefan Hajnoczi
On Wed, May 29, 2013 at 6:02 PM, Julian Stecklina wrote: > On 05/29/2013 04:21 PM, Stefan Hajnoczi wrote: >> The fact that a single switch process has shared memory access to all >> guests' RAM is critical. If the switch process is exploited, then that >> exposes other guests' data! (Think of a

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-29 Thread Gerd Hoffmann
Hi, > Why should this be true? Shouldn't we be allowed to increase the amount > of memory the guest has across reboots? That's equivalent to adding > another DIMM after power off. poweroff is equivalent to exiting qemu, not to guest reset. > Not generating tables on reset does limit what we

Re: [Qemu-devel] updated: kvm networking todo wiki

2013-05-29 Thread Stefan Hajnoczi
On Thu, May 30, 2013 at 7:23 AM, Rusty Russell wrote: > Anthony Liguori writes: >> Rusty Russell writes: >>> On Fri, May 24, 2013 at 08:47:58AM -0500, Anthony Liguori wrote: FWIW, I think what's more interesting is using vhost-net as a networking backend with virtio-net in QEMU being w

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-29 Thread Gerd Hoffmann
Hi, >>> Raised >>> that QOM interface should be sufficient. >> >> Agree on this one. Ideally the acpi table generation code should be >> able to gather all information it needs from the qom tree, so it can be >> a standalone C file instead of being scattered over all qemu. > > Ack. So my basi

Re: [Qemu-devel] [PATCH] pci: change typename of q35 to pci-q35

2013-05-29 Thread Michael S. Tsirkin
On Thu, May 30, 2013 at 10:47:48AM +0800, Amos Kong wrote: > In QEMU, we set the firmware name of pc-i440fx is 'pci', and set the > firmware name of q35 is 'q35-pcihost'. > > The seabios pattern matching code isn't sophisticated, and we want to > match those two devices with exact pattern. > > Th

Re: [Qemu-devel] updated: kvm networking todo wiki

2013-05-29 Thread Rusty Russell
Anthony Liguori writes: > Rusty Russell writes: >> On Fri, May 24, 2013 at 08:47:58AM -0500, Anthony Liguori wrote: >>> FWIW, I think what's more interesting is using vhost-net as a networking >>> backend with virtio-net in QEMU being what's guest facing. >>> >>> In theory, this gives you the be

Re: [Qemu-devel] [PATCH 6/9] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-05-29 Thread Nicholas A. Bellinger
On Wed, 2013-05-29 at 21:29 -0700, Nicholas A. Bellinger wrote: > On Thu, 2013-05-30 at 06:17 +0800, Asias He wrote: > > On Wed, May 29, 2013 at 08:10:44AM -0700, Badari Pulavarty wrote: > > > On 05/29/2013 02:05 AM, Wenchao Xia wrote: > > > >于 2013-5-28 17:00, Wenchao Xia 写道: > > > > > > > I h

Re: [Qemu-devel] [PATCH 6/8] pci: Simpler implementation of primary PCI bus

2013-05-29 Thread Michael S. Tsirkin
On Thu, May 30, 2013 at 01:34:41PM +1000, David Gibson wrote: > On Wed, May 29, 2013 at 03:22:29PM +0300, Michael S. Tsirkin wrote: > > On Wed, May 29, 2013 at 09:04:00PM +1000, David Gibson wrote: > > > On Wed, May 29, 2013 at 01:17:13PM +0300, Michael S. Tsirkin wrote: > > > > On Wed, May 29, 201

Re: [Qemu-devel] [PATCH 6/9] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-05-29 Thread Nicholas A. Bellinger
On Thu, 2013-05-30 at 06:17 +0800, Asias He wrote: > On Wed, May 29, 2013 at 08:10:44AM -0700, Badari Pulavarty wrote: > > On 05/29/2013 02:05 AM, Wenchao Xia wrote: > > >于 2013-5-28 17:00, Wenchao Xia 写道: > > > I have done a basic test of vhost-scsi, following is the result I'd > > >like to po

Re: [Qemu-devel] [PATCH v2 1/3] block: add basic backup support to block driver

2013-05-29 Thread Fam Zheng
On Mon, 04/29 09:42, Stefan Hajnoczi wrote: > + > +static void coroutine_fn backup_run(void *opaque) > +{ > +BackupBlockJob *job = opaque; > +BlockDriverState *bs = job->common.bs; > +assert(bs); > + > +int64_t start, end; > + > +start = 0; > +end = DIV_ROUND_UP(bdrv_getleng

Re: [Qemu-devel] [PATCH 6/8] pci: Simpler implementation of primary PCI bus

2013-05-29 Thread David Gibson
On Wed, May 29, 2013 at 03:22:29PM +0300, Michael S. Tsirkin wrote: > On Wed, May 29, 2013 at 09:04:00PM +1000, David Gibson wrote: > > On Wed, May 29, 2013 at 01:17:13PM +0300, Michael S. Tsirkin wrote: > > > On Wed, May 29, 2013 at 08:06:42PM +1000, David Gibson wrote: > > > > On Wed, May 29, 201

Re: [Qemu-devel] [PATCH v2 2/2] i.MX: unify all function and variale name convention in GPT

2013-05-29 Thread Peter Chubb
> > -static char const *imx_timerg_reg_name(uint32_t reg) > +static char const *imx_timer_gpt_reg_name(uint32_t reg) You could just use imc_gpt_xxx in line with the imx_epit_xxx naming from your other patch series. Otherwise this looks good. -- Dr Peter Chubb

[Qemu-devel] EC space vs SystemIO for cpu hotplug

2013-05-29 Thread li guang
Hi, Igor and all based on the patches "pass cpu online/offline event bewteen QEMU", http://lists.nongnu.org/archive/html/qemu-devel/2013-05/msg04135.html I'd like to go further, IMHO, too many specific operation regions of SystemIO have been created for specific usage, like pci-hotplug, cpu-hotpl

[Qemu-devel] [SeaBIOS PATCH v2] boot: fix fw_dev_path pattern to match q35

2013-05-29 Thread Amos Kong
We match pci domain by "/pci@i0cf8" in SeaBIOS, but fw_dev_path prefix of q35 is "/q35-pcihost@i0cf8". It causes boot priority of q35 devices could not be changed by bootindex parameter in QEMU. I have a patch to change typename of q35 to 'pci-q35', this patch fixes the pattern to match both pc-i4

[Qemu-devel] [PATCH] pci: change typename of q35 to pci-q35

2013-05-29 Thread Amos Kong
In QEMU, we set the firmware name of pc-i440fx is 'pci', and set the firmware name of q35 is 'q35-pcihost'. The seabios pattern matching code isn't sophisticated, and we want to match those two devices with exact pattern. This patch changes the typename of q35 to 'pci-q35', all pci devices use sa

Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer

2013-05-29 Thread Wenchao Xia
于 2013-5-27 23:41, Kevin Wolf 写道: Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: These patches are the common part of my hmp/qmp block query series and Pavel's qmp snapshot command converion series. It mainly does following things: 1 move snapshot related code to block/snapshot.c, qmp and i

Re: [Qemu-devel] snabbswitch integration with QEMU for userspace ethernet I/O

2013-05-29 Thread ronnie sahlberg
Julian, Stefan's concerns are valid. (Hopefully, kernel is harder to exploit and more carefully audited.) On Wed, May 29, 2013 at 9:02 AM, Julian Stecklina wrote: > On 05/29/2013 04:21 PM, Stefan Hajnoczi wrote: >> The fact that a single switch process has shared memory access to all >> gues

Re: [Qemu-devel] [PATCH 11/16] qemu-io: Move functions for registering and running commands

2013-05-29 Thread Eric Blake
On 05/28/2013 09:27 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > cmd.c | 113 - > cmd.h | 11 +--- > qemu-io-cmds.c | 192 > ++--- > qemu-io.c | 10 +-- > 4 files changed, 14

Re: [Qemu-devel] [PATCH 6/9] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-05-29 Thread Wenchao Xia
于 2013-5-29 23:10, Badari Pulavarty 写道: > On 05/29/2013 02:05 AM, Wenchao Xia wrote: >> 于 2013-5-28 17:00, Wenchao Xia 写道: >>> 于 2013-5-28 16:33, Asias He 写道: On Tue, May 28, 2013 at 10:01:14AM +0200, Paolo Bonzini wrote: > Il 28/05/2013 09:13, Wenchao Xia ha scritto: From: Nichol

Re: [Qemu-devel] [PATCH v3 4/5] xilinx_devcfg: Zynq devcfg device model

2013-05-29 Thread Peter Crosthwaite
Hi Anthony, On Thu, May 30, 2013 at 3:57 AM, Anthony Liguori wrote: > peter.crosthwa...@xilinx.com writes: > >> From: "Peter A. G. Crosthwaite" >> >> Minimal device model for devcfg module of Zynq. DMA capabilities and >> interrupt generation supported. >> >> Signed-off-by: Peter A. G. Crosthwai

Re: [Qemu-devel] [coreboot] [SeaBIOS] SeaBIOS v1.7.2.2 stable release

2013-05-29 Thread Kevin O'Connor
On Wed, May 29, 2013 at 09:27:16AM +0200, Gerd Hoffmann wrote: > While talking about releases: There are quite some changes accumulated > in master, time to cut a new release I think. Given that sorting the > acpi table issue seems to take more time than expected, how about freeze > + call for pa

Re: [Qemu-devel] [SeaBIOS PATCH] boot: fix fw_dev_path pattern for q35-pcihost

2013-05-29 Thread Kevin O'Connor
On Wed, May 29, 2013 at 10:33:54AM +0800, Amos Kong wrote: > On Tue, May 28, 2013 at 06:59:02PM -0400, Kevin O'Connor wrote: > > On Tue, May 28, 2013 at 08:28:14PM +0800, Amos Kong wrote: > > > -#define FW_PCI_DOMAIN "/pci@i0cf8" > > > +#define FW_PCI_DOMAIN "/*pci*@i0cf8" > > > > The seabios patt

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-29 Thread Kevin O'Connor
On Wed, May 29, 2013 at 11:18:03AM -0500, Anthony Liguori wrote: > Gerd Hoffmann writes: > > On 05/29/13 01:53, Kevin O'Connor wrote: > >> Raised > >> that QOM interface should be sufficient. > > > > Agree on this one. Ideally the acpi table generation code should be > > able to gather all inform

Re: [Qemu-devel] [PATCH v2] i.MX: Improve EPIT timer code.

2013-05-29 Thread peter
Jean-Christophe wrote: This is fine by me ... > * Unify function and type naming > * use dynamic cast whenever possible > * simplify Debug printf. > * use new style device intialization. > > Signed-off-by: Jean-Christophe DUBOIS Reviewed-by: Peter Chubb Peter C

Re: [Qemu-devel] [PATCH v2] monitor: work around delayed CHR_EVENT_OPENED events

2013-05-29 Thread mdroth
On Wed, May 29, 2013 at 01:27:33PM -0400, Luiz Capitulino wrote: > On Mon, 27 May 2013 12:59:25 -0500 > mdroth wrote: > > > On Mon, May 27, 2013 at 11:16:01AM -0500, Anthony Liguori wrote: > > > Luiz Capitulino writes: > > > > > > > On Sun, 26 May 2013 10:33:39 -0500 > > > > Michael Roth wrote

[Qemu-devel] [PATCH] qemu-char: don't issue CHR_EVENT_OPEN in a BH

2013-05-29 Thread Michael Roth
When CHR_EVENT_OPEN was initially added, it was CHR_EVENT_RESET, and it was issued as a bottom-half: 86e94dea5b740dad65446c857f6959eae43e0ba6 AFAICT the only reason this was ever done in a BH was because it was initially used to to issue a CHR_EVENT_RESET when we initialized the monitor, and we w

[Qemu-devel] [PATCH 10/20] ipmi: Add a local BMC simulation

2013-05-29 Thread minyard
From: Corey Minyard This provides a minimal local BMC, basically enough to comply with the spec and provide a complete watchdog timer (including a sensor, SDR, and event). Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak |1 + default-configs/x86_64-softmmu.mak |1 +

[Qemu-devel] [PATCH 12/20] ipmi: Add tests

2013-05-29 Thread minyard
From: Corey Minyard Test the KCS interface with a local BMC and a BT interface with an external BMC. Signed-off-by: Corey Minyard --- tests/Makefile|4 + tests/ipmi-bt-test.c | 444 + tests/ipmi-kcs-test.c | 294 +++

Re: [Qemu-devel] [PATCH 6/9] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-05-29 Thread Asias He
On Wed, May 29, 2013 at 08:10:44AM -0700, Badari Pulavarty wrote: > On 05/29/2013 02:05 AM, Wenchao Xia wrote: > >于 2013-5-28 17:00, Wenchao Xia 写道: > >>于 2013-5-28 16:33, Asias He 写道: > >>>On Tue, May 28, 2013 at 10:01:14AM +0200, Paolo Bonzini wrote: > Il 28/05/2013 09:13, Wenchao Xia ha scri

[Qemu-devel] [PATCH 11/20] ipmi: Add an external connection simulation interface

2013-05-29 Thread minyard
From: Corey Minyard This adds an interface for IPMI that connects to a remote BMC over a chardev (generally a TCP socket). The OpenIPMI lanserv simulator describes this interface, see that for interface details. Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak |1 + def

[Qemu-devel] [PATCH 14/20] ipmi: Add migration capability to the IPMI device.

2013-05-29 Thread minyard
From: Corey Minyard Signed-off-by: Corey Minyard io_length = 3; memory_region_init_io(&s->io, &ipmi_bt_io_ops, bt, "ipmi-bt", 3); +vmstate_register(NULL, 0, &vmstate_ipmi_bt, bt); return 0; } diff --git a/hw/ipmi/ipmi_extern.c b/hw/ipmi/ipmi_extern.c index 0c5fcfb..39d3ebf 1006

[Qemu-devel] [PATCH 16/20] acpi: Add table construction tools

2013-05-29 Thread minyard
From: Corey Minyard Add a set of functions to allow construction of ACPI elements dynamically. Signed-off-by: Corey Minyard --- hw/acpi/Makefile.objs |2 +- hw/acpi/acpi-elements.c | 351 +++ include/hw/acpi/acpi-elements.h | 77

[Qemu-devel] [PATCH 17/20] pc: Postpone adding ACPI and SMBIOS to fw_cfg

2013-05-29 Thread minyard
From: Corey Minyard Postpone the addition of the ACPI and SMBIOS tables until after device initialization. This allows devices to add entries to these tables. Signed-off-by: Corey Minyard --- hw/i386/pc.c | 38 ++ 1 file changed, 30 insertions(+), 8 delet

Re: [Qemu-devel] [PATCH 10/16] qemu-io: Move qemu_strsep() to cutils.c

2013-05-29 Thread Eric Blake
On 05/28/2013 09:27 AM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > cmd.c | 21 - > include/qemu-common.h | 1 + > util/cutils.c | 21 + > 3 files changed, 22 insertions(+), 21 deletions(-) Reviewed-by: Eric Blake -- E

[Qemu-devel] [PATCH 01/20] qemu-char: Allocate CharDriverState in qemu_chr_new_from_opts

2013-05-29 Thread minyard
From: Corey Minyard This allocates the CharDriverState structure and passes it in to the open routine. This allows a coming option to automatically attempt to reconnect a chardev if the connection fails. The chardev has to be kept around so a reconnect can be done on it. Signed-off-by: Corey M

[Qemu-devel] [PATCH 08/20] ipmi: Add a KCS low-level interface

2013-05-29 Thread minyard
From: Corey Minyard This provides the simulation of the KCS hardware interface. Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak |1 + default-configs/x86_64-softmmu.mak |1 + hw/ipmi/Makefile.objs |1 + hw/ipmi/ipmi_kcs.c | 342

[Qemu-devel] [PATCH 09/20] ipmi: Add a BT low-level interface

2013-05-29 Thread minyard
From: Corey Minyard This provides the simulation of the BT hardware interface for IPMI. Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak |1 + default-configs/x86_64-softmmu.mak |1 + hw/ipmi/Makefile.objs |1 + hw/ipmi/ipmi_bt.c |

[Qemu-devel] [PATCH 07/20] ipmi: Add a PC ISA type structure

2013-05-29 Thread minyard
From: Corey Minyard This provides the base infrastructure to tie IPMI low-level interfaces into a PC ISA bus. Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak |1 + default-configs/x86_64-softmmu.mak |1 + hw/ipmi/Makefile.objs |1 + hw/ipmi/isa_ipmi

[Qemu-devel] [PATCH 18/20] ipmi: Add ACPI table entries for BMCs

2013-05-29 Thread minyard
From: Corey Minyard Use the new ACPI table construction tools to create an ACPI entry for IPMI. Signed-off-by: Corey Minyard --- hw/ipmi/isa_ipmi.c | 127 1 file changed, 127 insertions(+) diff --git a/hw/ipmi/isa_ipmi.c b/hw/ipmi/isa_ipmi

Re: [Qemu-devel] [PATCH 09/16] qemu-io: Move 'quit' function

2013-05-29 Thread Eric Blake
On 05/28/2013 09:27 AM, Kevin Wolf wrote: > This one only makes sense in the context of the qemu-io tool, so move it > to qemu-io.c. Adapt coding style and register it like other commands. > > Signed-off-by: Kevin Wolf > --- > cmd.c | 29 - > cmd.h | 2 -- >

[Qemu-devel] [PATCH 02/20] qemu-char: Allow a chardev to reconnect if disconnected

2013-05-29 Thread minyard
From: Corey Minyard Allow a socket that connects to reconnect on a periodic basis if it fails to connect at startup or if the connection drops while in use. Signed-off-by: Corey Minyard --- include/sysemu/char.h |3 ++ qemu-char.c | 84 ++

[Qemu-devel] [PATCH 19/20] smbios: Add a function to directly add an entry

2013-05-29 Thread minyard
From: Corey Minyard There was no way to directly add a table entry to the SMBIOS table, even though the BIOS supports this. So add a function to do this. This is in preparation for the IPMI handler adding it's SMBIOS table entry. Signed-off-by: Corey Minyard --- hw/i386/smbios.c | 2

[Qemu-devel] [PATCH 20/20] ipmi: Add SMBIOS table entry

2013-05-29 Thread minyard
From: Corey Minyard Add an IPMI table entry to the SMBIOS. Signed-off-by: Corey Minyard --- hw/ipmi/isa_ipmi.c | 23 +++ include/hw/i386/smbios.h | 12 2 files changed, 35 insertions(+) diff --git a/hw/ipmi/isa_ipmi.c b/hw/ipmi/isa_ipmi.c index 92afb

[Qemu-devel] [PATCH 15/20] acpi: Add a way to extend tables

2013-05-29 Thread minyard
From: Corey Minyard Add a function that can extend the contents of a given ACPI table to add on new entries. This way devices that have ACPI entries can add them. Signed-off-by: Corey Minyard --- hw/acpi/core.c | 47 +++ include/hw/acpi/ac

[Qemu-devel] [PATCH 06/20] Add a base IPMI interface

2013-05-29 Thread minyard
From: Corey Minyard Add the basic IPMI types and infrastructure to QEMU. Low-level interfaces and simulation interfaces will register with this; it's kind of the go-between to tie them together. Signed-off-by: Corey Minyard --- default-configs/i386-softmmu.mak |1 + default-configs/x86_

[Qemu-devel] [PATCH 03/20] qemu-char: Fix a race reporting opens and closes

2013-05-29 Thread minyard
From: Corey Minyard When an open event is reported, it is done through a bh. But close events are reported immediately. So if an open event is in the bh and a close occurs, an extraneous open happens, which can confuse a user. To fix this, this patch sets the "opened" flag immediately instead

[Qemu-devel] [PATCH 00/20] Add an IPMI device to QEMU

2013-05-29 Thread minyard
I have finally gotten some time to work on this, this series of patches adds an IPMI interface to qemu. The changes are roughly: patches 01-05 - Add the capability to have a chardev reconnect if the connections fails. This way, if using an external BMC, qemu will detect the failure and periodica

[Qemu-devel] [PATCH 05/20] qemu-char: Close fd at end of file

2013-05-29 Thread minyard
From: Corey Minyard The chardev backends that used qemu_chr_open_fd did not get their file descriptors closed at end of file or when the chardev was closed. This could result in a file descriptor leak. Signed-off-by: Corey Minyard --- qemu-char.c | 35 +-- 1 f

[Qemu-devel] [PATCH 04/20] qemu-char: remove free of chr from win_stdio_close

2013-05-29 Thread minyard
From: Corey Minyard This will result in a double free on close, because it's freed in qemu_chr_delete() right after calling the close function. Signed-off-by: Corey Minyard --- qemu-char.c |1 - 1 file changed, 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index 76cddd9..1270a65 10

[Qemu-devel] [PATCH 13/20] ipmi: Add documentation

2013-05-29 Thread minyard
From: Corey Minyard Add some basic documentation for the IPMI device. Signed-off-by: Corey Minyard --- qemu-options.hx | 35 +++ 1 file changed, 35 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index df5488f..538572d 100644 --- a/qemu-options.h

Re: [Qemu-devel] [PATCH 08/16] qemu-io: Move 'help' function

2013-05-29 Thread Eric Blake
On 05/28/2013 09:27 AM, Kevin Wolf wrote: > No reason to treat it different from other commands. Move it to > qemu-io-cmds.c, adapt the coding style and register it like any other > command. > > Signed-off-by: Kevin Wolf > --- > cmd.c | 79 >

Re: [Qemu-devel] [PATCH] seccomp: add the asynchronous I/O syscalls to the whitelist

2013-05-29 Thread Corey Bryant
On 05/29/2013 04:30 PM, Paul Moore wrote: In order to enable the asynchronous I/O functionality when using the seccomp sandbox we need to add the associated syscalls to the whitelist. Signed-off-by: Paul Moore --- qemu-seccomp.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH 07/16] qemu-io: Factor out qemuio_command

2013-05-29 Thread Eric Blake
On 05/28/2013 09:27 AM, Kevin Wolf wrote: > It's duplicated code. Move it to qemu-io-cmds.c because it's not > dependent on any static data of the qemu-io tool. > > Signed-off-by: Kevin Wolf > --- > cmd.c | 43 +-- > cmd.h | 3 ++- > qem

Re: [Qemu-devel] [PATCH v2] monitor: work around delayed CHR_EVENT_OPENED events

2013-05-29 Thread mdroth
On Wed, May 29, 2013 at 01:27:33PM -0400, Luiz Capitulino wrote: > On Mon, 27 May 2013 12:59:25 -0500 > mdroth wrote: > > > On Mon, May 27, 2013 at 11:16:01AM -0500, Anthony Liguori wrote: > > > Luiz Capitulino writes: > > > > > > > On Sun, 26 May 2013 10:33:39 -0500 > > > > Michael Roth wrote

[Qemu-devel] [PATCH] seccomp: add the asynchronous I/O syscalls to the whitelist

2013-05-29 Thread Paul Moore
In order to enable the asynchronous I/O functionality when using the seccomp sandbox we need to add the associated syscalls to the whitelist. Signed-off-by: Paul Moore --- qemu-seccomp.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qemu-seccomp.c b/qemu-seccomp.c in

Re: [Qemu-devel] [PATCH 06/16] qemu-io: Split off commands to qemu-io-cmds.c

2013-05-29 Thread Eric Blake
On 05/28/2013 09:27 AM, Kevin Wolf wrote: > This is the implementation of all qemu-io commands that make sense to be > called from the qemu monitor, i.e. everything except open, close and > quit. > > Signed-off-by: Kevin Wolf > --- > Makefile |2 +- > qemu-io-cmds.c | 1835 > +

[Qemu-devel] [PATCH 1/4] util/envlist: Properly forward a callback's error in envlist_parse.

2013-05-29 Thread Thomas Schwinge
Signed-off-by: Thomas Schwinge --- util/envlist.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git util/envlist.c util/envlist.c index ebc06cf..cbbf7e5 100644 --- util/envlist.c +++ util/envlist.c @@ -109,9 +109,10 @@ envlist_parse(envlist_t *envlist, const char *env,

[Qemu-devel] [Bug 1180970] Re: qemu: fatal: Trying to execute code outside RAM or ROM; worked in 1.4.0, fails in 1.4.92

2013-05-29 Thread Duane Voth
I just tried Richard's fix against HEAD (6a4e17711) and it works for me. I also like that his fix clearly constrains aflag to the values 1 and 2 for 64bit mode - a concept which matches the intent of the 0x67 prefix. $ git diff target-i386/translate.c diff --git a/target-i386/translate.c b/target

Re: [Qemu-devel] [PATCH] qapi: pad GenericList value fields to 64 bits

2013-05-29 Thread Luiz Capitulino
On Wed, 29 May 2013 13:12:18 -0500 mdroth wrote: > On Wed, May 29, 2013 at 01:32:52PM -0400, Luiz Capitulino wrote: > > On Sun, 26 May 2013 22:20:58 -0500 > > Michael Roth wrote: > > > > > With the introduction of native list types, we now have types such as > > > int64List where the 'value' fi

[Qemu-devel] [PATCH 4/4] linux-user: Restore original behavior of the -E and -U command-line options.

2013-05-29 Thread Thomas Schwinge
Revert the change in behavior that had been introducecd in commit fc9c54124d134dbd76338a92a91804dab2df8166 for the -E and -U command-line options, but keep the comma-splitting for the QEMU_SET_ENV and QEMU_UNSET_ENV environment variables. Signed-off-by: Thomas Schwinge --- linux-user/main.c |

[Qemu-devel] [PATCH, resend] linux-user: environment variables

2013-05-29 Thread Thomas Schwinge
Hi! I'm resending here the patches previously posted and described in the thread starting at . In short, fix a bug in util/envlist, code simplification, and then restore the original behavior of the -E and -U comm

[Qemu-devel] [PATCH 2/4] linux-user: Use existing envlist_parse_set/envlist_parse_unset interface.

2013-05-29 Thread Thomas Schwinge
Signed-off-by: Thomas Schwinge --- linux-user/main.c | 18 -- util/envlist.c|4 ++-- 2 files changed, 6 insertions(+), 16 deletions(-) diff --git linux-user/main.c linux-user/main.c index b97b8cf..a0ea161 100644 --- linux-user/main.c +++ linux-user/main.c @@ -3204,26 +3

[Qemu-devel] [PATCH 3/4] linux-user: Tell handler_arg_* which context they're invoked from.

2013-05-29 Thread Thomas Schwinge
Signed-off-by: Thomas Schwinge --- linux-user/main.c | 47 ++- 1 file changed, 26 insertions(+), 21 deletions(-) diff --git linux-user/main.c linux-user/main.c index a0ea161..b7d49f4 100644 --- linux-user/main.c +++ linux-user/main.c @@ -3180,12 +318

[Qemu-devel] [PATCH] target-i386: Fix aflag logic for CODE64 and the 0x67 prefix

2013-05-29 Thread Richard Henderson
The code reorganization in commit 4a6fd938 broke handling of PREFIX_ADR. While fixing this, tidy and comment the code so that it's more obvious what's going on in setting both aflag and dflag. The TARGET_X86_64 ifdef can be eliminated because CODE64 expands to the constant zero when TARGET_X86_64

Re: [Qemu-devel] [PATCH v3 4/5] xilinx_devcfg: Zynq devcfg device model

2013-05-29 Thread Anthony Liguori
Anthony Liguori writes: > peter.crosthwa...@xilinx.com writes: > >> From: "Peter A. G. Crosthwaite" >> >> Minimal device model for devcfg module of Zynq. DMA capabilities and >> interrupt generation supported. >> >> Signed-off-by: Peter A. G. Crosthwaite >> --- >> Changed since v2: >> Some QOM

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-29 Thread Michael S. Tsirkin
On Wed, May 29, 2013 at 07:28:05PM +0300, Michael S. Tsirkin wrote: > Because that's just insanely rick interface s/rick/rich/. Sorry about the typo.

Re: [Qemu-devel] [PATCH] qapi: pad GenericList value fields to 64 bits

2013-05-29 Thread mdroth
On Wed, May 29, 2013 at 01:32:52PM -0400, Luiz Capitulino wrote: > On Sun, 26 May 2013 22:20:58 -0500 > Michael Roth wrote: > > > With the introduction of native list types, we now have types such as > > int64List where the 'value' field is not a pointer, but the actual > > 64-bit value. > > > >

Re: [Qemu-devel] [PATCH 16/16] Make qemu-io commands available in the monitor

2013-05-29 Thread Luiz Capitulino
On Wed, 29 May 2013 10:13:42 +0200 Kevin Wolf wrote: > Am 28.05.2013 um 18:07 hat Eric Blake geschrieben: > > On 05/28/2013 09:27 AM, Kevin Wolf wrote: > > > The QMP version is flagged with a __org.qemu.debug- prefix in order to > > > reinforce the statement that qemu-io is for testing and debugg

Re: [Qemu-devel] [PATCH v3 4/5] xilinx_devcfg: Zynq devcfg device model

2013-05-29 Thread Anthony Liguori
peter.crosthwa...@xilinx.com writes: > From: "Peter A. G. Crosthwaite" > > Minimal device model for devcfg module of Zynq. DMA capabilities and > interrupt generation supported. > > Signed-off-by: Peter A. G. Crosthwaite > --- > Changed since v2: > Some QOM styling updates. > Re-implemented nw0

Re: [Qemu-devel] [PATCH v3 2/5] register: Add Register API

2013-05-29 Thread Edgar E. Iglesias
On Fri, May 24, 2013 at 03:47:33PM +1000, peter.crosthwa...@xilinx.com wrote: > From: Peter Crosthwaite > > This API provides some encapsulation of registers and factors our some > common functionality to common code. Bits of device state (usually MMIO > registers), often have all sorts of access

Re: [Qemu-devel] [PATCH 7/7] monitor: QMP/HMP support for retrieving VNVRAM details

2013-05-29 Thread Corey Bryant
On 05/29/2013 01:15 PM, Luiz Capitulino wrote: On Thu, 23 May 2013 13:44:47 -0400 Corey Bryant wrote: Signed-off-by: Corey Bryant Looks good to me, only one small nit below. It looks like this series is going to get dropped, but thanks for the review! -- Regards, Corey Bryant ---

Re: [Qemu-devel] [PATCH] qapi: pad GenericList value fields to 64 bits

2013-05-29 Thread Luiz Capitulino
On Sun, 26 May 2013 22:20:58 -0500 Michael Roth wrote: > With the introduction of native list types, we now have types such as > int64List where the 'value' field is not a pointer, but the actual > 64-bit value. > > On 32-bit architectures, this can lead to situations where 'next' field > offset

Re: [Qemu-devel] [PATCH v2] monitor: work around delayed CHR_EVENT_OPENED events

2013-05-29 Thread Luiz Capitulino
On Mon, 27 May 2013 12:59:25 -0500 mdroth wrote: > On Mon, May 27, 2013 at 11:16:01AM -0500, Anthony Liguori wrote: > > Luiz Capitulino writes: > > > > > On Sun, 26 May 2013 10:33:39 -0500 > > > Michael Roth wrote: > > > > > >> In the past, CHR_EVENT_OPENED events were emitted via a pre-expire

Re: [Qemu-devel] [PATCH 7/7] monitor: QMP/HMP support for retrieving VNVRAM details

2013-05-29 Thread Luiz Capitulino
On Thu, 23 May 2013 13:44:47 -0400 Corey Bryant wrote: > Signed-off-by: Corey Bryant Looks good to me, only one small nit below. > --- > hmp.c| 32 > hmp.h|1 + > monitor.c|7 + > qapi-schema.json | 47 ++

Re: [Qemu-devel] [PATCH v3 4/5] xilinx_devcfg: Zynq devcfg device model

2013-05-29 Thread Paolo Bonzini
Il 29/05/2013 19:04, Edgar E. Iglesias ha scritto: >> > +for (i = 0; i < R_MAX; ++i) { >> > +RegisterInfo *r = &s->regs_info[i]; >> > + >> > +*r = (RegisterInfo) { >> > +.data = &s->regs[i], >> > +.data_size = sizeof(uint32_t), >> > +.access =

Re: [Qemu-devel] VFIO VGA test branches

2013-05-29 Thread Alex Williamson
On Wed, 2013-05-29 at 18:16 +0200, Maik Broemme wrote: > Hi, > > Maik Broemme wrote: > > > > > > > > Here is the DEBUG_VFIO output: > > > > > > > > vfio: vfio_initfn(:04:00.0) group 14 > > > > vfio: region_add 0 - afff [0x7f869800] > > > > vfio: SKIPPING region_add fec0 - fec00f

Re: [Qemu-devel] [PATCH v3 4/5] xilinx_devcfg: Zynq devcfg device model

2013-05-29 Thread Edgar E. Iglesias
On Fri, May 24, 2013 at 03:49:00PM +1000, peter.crosthwa...@xilinx.com wrote: > From: "Peter A. G. Crosthwaite" > > Minimal device model for devcfg module of Zynq. DMA capabilities and > interrupt generation supported. > > Signed-off-by: Peter A. G. Crosthwaite > --- > Changed since v2: > Some

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-29 Thread Markus Armbruster
Anthony Liguori writes: > Gerd Hoffmann writes: > >> On 05/29/13 01:53, Kevin O'Connor wrote: >>> On Thu, May 23, 2013 at 03:41:32PM +0300, Michael S. Tsirkin wrote: Juan is not available now, and Anthony asked for agenda to be sent early. So here comes: Agenda for the m

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-29 Thread Michael S. Tsirkin
On Wed, May 29, 2013 at 11:18:03AM -0500, Anthony Liguori wrote: > Gerd Hoffmann writes: > > > On 05/29/13 01:53, Kevin O'Connor wrote: > >> On Thu, May 23, 2013 at 03:41:32PM +0300, Michael S. Tsirkin wrote: > >>> Juan is not available now, and Anthony asked for > >>> agenda to be sent early. >

[Qemu-devel] [PATCH v2 2/2] block: move the bdrv_dev_change_media_cb()

2013-05-29 Thread Pavel Hrdina
The bdrv_dev_change_media_cb() should be called only for eject and change commands. We should call that function only if that command is successful. What this function does is that it calls the change_media_cb() and also emit the QEVENT_DEVICE_TRAY_MOVED event. Signed-off-by: Pavel Hrdina --- b

[Qemu-devel] [PATCH v2 1/2] block: make bdrv_dev_change_media_cb() public

2013-05-29 Thread Pavel Hrdina
From: Luiz Capitulino Next commit wants to use it. Signed-off-by: Luiz Capitulino Signed-off-by: Pavel Hrdina --- block.c | 3 +-- include/block/block.h | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/block.c b/block.c index 3f87489..99bc357 100644 --- a/bl

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-29 Thread Michael S. Tsirkin
On Wed, May 29, 2013 at 11:12:06AM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Tue, May 28, 2013 at 07:53:09PM -0400, Kevin O'Connor wrote: > >> On Thu, May 23, 2013 at 03:41:32PM +0300, Michael S. Tsirkin wrote: > >> > Juan is not available now, and Anthony asked for >

Re: [Qemu-devel] [SeaBIOS] KVM call agenda for 2013-05-28

2013-05-29 Thread Anthony Liguori
Gerd Hoffmann writes: > On 05/29/13 01:53, Kevin O'Connor wrote: >> On Thu, May 23, 2013 at 03:41:32PM +0300, Michael S. Tsirkin wrote: >>> Juan is not available now, and Anthony asked for >>> agenda to be sent early. >>> So here comes: >>> >>> Agenda for the meeting Tue, May 28: >>> >>> - Genera

[Qemu-devel] [PATCH v2 0/2] block: fix spurious DEVICE_TRAY_MOVED events on shutdown

2013-05-29 Thread Pavel Hrdina
This fixes a regression introduced by commit 9ca111544. The first commit is done by Luiz and I've just use it as it is. The second commit moves the bdrv_dev_change_media_cb() into eject_device(), called by QMP and HMP eject command, and into qmp_bdrv_open_encrypted(), called by QMP and HMP change

Re: [Qemu-devel] VFIO VGA test branches

2013-05-29 Thread Maik Broemme
Hi, Maik Broemme wrote: > > > > > > Here is the DEBUG_VFIO output: > > > > > > vfio: vfio_initfn(:04:00.0) group 14 > > > vfio: region_add 0 - afff [0x7f869800] > > > vfio: SKIPPING region_add fec0 - fec00fff > > > vfio: SKIPPING region_add fed0 - fed003ff > > > vfio: SKIPPI

Re: [Qemu-devel] KVM call agenda for 2013-05-28

2013-05-29 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Tue, May 28, 2013 at 07:53:09PM -0400, Kevin O'Connor wrote: >> On Thu, May 23, 2013 at 03:41:32PM +0300, Michael S. Tsirkin wrote: >> > Juan is not available now, and Anthony asked for >> > agenda to be sent early. >> > So here comes: >> > >> > Agenda for the m

Re: [Qemu-devel] snabbswitch integration with QEMU for userspace ethernet I/O

2013-05-29 Thread Julian Stecklina
On 05/29/2013 04:21 PM, Stefan Hajnoczi wrote: > The fact that a single switch process has shared memory access to all > guests' RAM is critical. If the switch process is exploited, then that > exposes other guests' data! (Think of a multi-tenant host with guests > belonging to different users.)

Re: [Qemu-devel] snabbswitch integration with QEMU for userspace ethernet I/O

2013-05-29 Thread Julian Stecklina
On 05/29/2013 04:31 PM, Stefan Hajnoczi wrote: > On Wed, May 29, 2013 at 02:32:50PM +0200, Julian Stecklina wrote: >> On 05/28/2013 07:00 PM, Anthony Liguori wrote: >>> We aren't going to support any interface that enables out of tree >>> devices. This is just plugins in a different form with even

Re: [Qemu-devel] VFIO VGA test branches

2013-05-29 Thread Maik Broemme
Hi, Alex Williamson wrote: > On Tue, 2013-05-28 at 20:45 +0200, Maik Broemme wrote: > > Hi, > > > > Maik Broemme wrote: > > > Hi Alex, > > > > > > Maik Broemme wrote: > > > > Hi Alex, > > > > > > > > Alex Williamson wrote: > > > > > > > > > > Good to hear. It looks like you have the same

Re: [Qemu-devel] [PATCH 6/9] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-05-29 Thread Badari Pulavarty
On 05/29/2013 02:05 AM, Wenchao Xia wrote: 于 2013-5-28 17:00, Wenchao Xia 写道: 于 2013-5-28 16:33, Asias He 写道: On Tue, May 28, 2013 at 10:01:14AM +0200, Paolo Bonzini wrote: Il 28/05/2013 09:13, Wenchao Xia ha scritto: From: Nicholas Bellinger The WWPN specified in configfs is passed to "-de

Re: [Qemu-devel] [PATCH v4 0/3] ARM aarch64 TCG target

2013-05-29 Thread Richard Henderson
On 05/29/2013 02:04 AM, Claudio Fontana wrote: > This series implements preliminary support for the ARM aarch64 TCG target. > > Limitations of this initial implementation (TODOs) include: > > * missing TLB lookup in qemu_ld/st [C helpers always called]. >An incremental patch, which requires

[Qemu-devel] [PATCH v2] i.MX: Improve EPIT timer code.

2013-05-29 Thread Jean-Christophe DUBOIS
* Unify function and type naming * use dynamic cast whenever possible * simplify Debug printf. * use new style device intialization. Signed-off-by: Jean-Christophe DUBOIS --- Change since v1: * use shorter unified name * fix a debug print bug in imx_epit_set_freq() hw/timer/imx_epit.c | 236 ++

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-29 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Wed, May 29, 2013 at 08:05:29AM -0500, Anthony Liguori wrote: >> Rusty Russell writes: >> >> > Anthony Liguori writes: >> >> The headers say they are BSD licensed... but they include a GPLv2+ >> >> header. Doesn't make a lot of sense, does it? >> > >> > It ma

Re: [Qemu-devel] QEMU ARM Cortex-A9 emulation boards

2013-05-29 Thread Peter Maydell
On 29 May 2013 15:24, Erlon Cruz wrote: > So, this hardware we intend to emulate doesn't need to use > any specific SoC. This doesn't make sense. If it's hardware it must be using *some* SoC or system board or PCI interface or similar. It doesn't just float around in a vacuum. > The only > requi

Re: [Qemu-devel] snabbswitch integration with QEMU for userspace ethernet I/O

2013-05-29 Thread Michael S. Tsirkin
On Wed, May 29, 2013 at 04:21:43PM +0200, Stefan Hajnoczi wrote: > On Wed, May 29, 2013 at 12:08:59PM +0300, Michael S. Tsirkin wrote: > > On Wed, May 29, 2013 at 09:49:29AM +0200, Stefan Hajnoczi wrote: > > > On Tue, May 28, 2013 at 08:17:42PM +0300, Michael S. Tsirkin wrote: > > > > On Tue, May 2

Re: [Qemu-devel] [PATCH v2 3/3] xen_machine_pv: do not create a dummy CPU in machine->init

2013-05-29 Thread Igor Mammedov
On Wed, 29 May 2013 14:29:51 +0200 Paolo Bonzini wrote: > Il 29/05/2013 14:11, Andreas Färber ha scritto: > >> xen_machine_pv uses cpu_x86_init, therefore it has been broken. > >> > >> This patch fixes the problem by removing the dummy CPU creation > >> altogether from xen_init_pv, relying on the

Re: [Qemu-devel] snabbswitch integration with QEMU for userspace ethernet I/O

2013-05-29 Thread Stefan Hajnoczi
On Wed, May 29, 2013 at 02:32:50PM +0200, Julian Stecklina wrote: > On 05/28/2013 07:00 PM, Anthony Liguori wrote: > > We aren't going to support any interface that enables out of tree > > devices. This is just plugins in a different form with even more > > downsides. You cannot easily keep track

Re: [Qemu-devel] [PATCH] target-i386: Disable CPUID_EXT_MONITOR when KVM is enabled

2013-05-29 Thread Eduardo Habkost
(CCing libvirt people) On Tue, May 28, 2013 at 06:48:52PM +0200, Andreas Färber wrote: > Am 28.05.2013 18:46, schrieb Paolo Bonzini: > > Il 28/05/2013 18:34, Bandan Das ha scritto: > >> Eduardo Habkost writes: > >> > >>> On Mon, May 27, 2013 at 02:21:36PM +0200, Paolo Bonzini wrote: > Il 27/

Re: [Qemu-devel] snabbswitch integration with QEMU for userspace ethernet I/O

2013-05-29 Thread Stefan Hajnoczi
On Wed, May 29, 2013 at 12:08:59PM +0300, Michael S. Tsirkin wrote: > On Wed, May 29, 2013 at 09:49:29AM +0200, Stefan Hajnoczi wrote: > > On Tue, May 28, 2013 at 08:17:42PM +0300, Michael S. Tsirkin wrote: > > > On Tue, May 28, 2013 at 12:00:38PM -0500, Anthony Liguori wrote: > > > > Julian Steckl

  1   2   3   >