Re: [Qemu-devel] [PATCH 0/4] add ACPI Embedded Controller

2013-05-27 Thread Michael S. Tsirkin
On Tue, May 28, 2013 at 02:40:30PM +0800, li guang wrote: > Hi, Michael > > 在 2013-05-28二的 09:31 +0300,Michael S. Tsirkin写道: > > On Tue, May 28, 2013 at 08:21:24AM +0800, li guang wrote: > > > 在 2013-05-27一的 23:23 +0300,Michael S. Tsirkin写道: > > > > On Mon, May 27, 2013 at 09:22:59AM +0800, li gua

Re: [Qemu-devel] [PATCH 3/4] ich9: add notifer for ec to generate sci

2013-05-27 Thread li guang
在 2013-05-28二的 09:40 +0300,Michael S. Tsirkin写道: > On Wed, May 22, 2013 at 11:46:36AM +0800, liguang wrote: > > Signed-off-by: liguang > > --- > > hw/acpi/ich9.c | 15 +++ > > include/hw/acpi/ich9.h |1 + > > 2 files changed, 16 insertions(+), 0 deletions(-) > > > > dif

[Qemu-devel] [PATCH] block: add read only to whitelist

2013-05-27 Thread Fam Zheng
We may want to include a driver in the whitelist for read only tasks such as diagnosing or exporting guest data (with libguestfs as a good example). This patch introduces the magic prefix ^ to include a driver to the whitelist, but only enables qemu to open specific image format readonly, and retur

Re: [Qemu-devel] [PATCH 0/4] add ACPI Embedded Controller

2013-05-27 Thread li guang
Hi, Michael 在 2013-05-28二的 09:31 +0300,Michael S. Tsirkin写道: > On Tue, May 28, 2013 at 08:21:24AM +0800, li guang wrote: > > 在 2013-05-27一的 23:23 +0300,Michael S. Tsirkin写道: > > > On Mon, May 27, 2013 at 09:22:59AM +0800, li guang wrote: > > > > 在 2013-05-26日的 19:51 -0500,Anthony Liguori写道: > > >

Re: [Qemu-devel] [PATCH 3/4] ich9: add notifer for ec to generate sci

2013-05-27 Thread Michael S. Tsirkin
On Wed, May 22, 2013 at 11:46:36AM +0800, liguang wrote: > Signed-off-by: liguang > --- > hw/acpi/ich9.c | 15 +++ > include/hw/acpi/ich9.h |1 + > 2 files changed, 16 insertions(+), 0 deletions(-) > > diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c > index 582dbec..2ecde3

Re: [Qemu-devel] [PATCH 1/3] qemu_chr_new_from_opts: do not overwrite existing chr->filename

2013-05-27 Thread Gerd Hoffmann
On 05/27/13 20:13, Stefano Stabellini wrote: > Set the new filename only if it hasn't been already set (for example by > qemu_chr_open_pty). > > This fixes a regression that prevents Xen HVM domains from booting. > It was introduced by: > > commit 2b220025993e76d4116781ca91a4fabc5ad9c722 > Author

[Qemu-devel] [PATCH 1/2] Revert "chardev: Get filename for new qapi backend"

2013-05-27 Thread Gerd Hoffmann
Does not handle chardevs created via chardev-add monitor command. This reverts commit 2b220025993e76d4116781ca91a4fabc5ad9c722. Signed-off-by: Gerd Hoffmann --- qemu-char.c |2 -- 1 file changed, 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index 4f8382e..f825294 100644 --- a/qemu

[Qemu-devel] [PULL 0/2] chardev: fix "info chardev" output

2013-05-27 Thread Gerd Hoffmann
Hi, Tiny series, first reverting the broken patch from Lei Li, then fixing it for real. please pull, Gerd The following changes since commit 6a4e17711442849bf2cc731ccddef5a2a2d92d29: Remove Sun4c, Sun4d and a few CPUs (2013-05-26 11:37:58 +) are available in the git repository at:

[Qemu-devel] [PATCH 2/2] chardev: fix "info chardev" output

2013-05-27 Thread Gerd Hoffmann
Fill unset CharDriverState->filename with the backend name, so 'info chardev' will return at least the chardev type. Don't touch it in case the chardev init function filled it already, like the socket+pty chardevs do for example. Signed-off-by: Gerd Hoffmann --- qemu-char.c |3 +++ 1 file c

Re: [Qemu-devel] [PATCH 0/4] add ACPI Embedded Controller

2013-05-27 Thread Michael S. Tsirkin
On Tue, May 28, 2013 at 08:21:24AM +0800, li guang wrote: > 在 2013-05-27一的 23:23 +0300,Michael S. Tsirkin写道: > > On Mon, May 27, 2013 at 09:22:59AM +0800, li guang wrote: > > > 在 2013-05-26日的 19:51 -0500,Anthony Liguori写道: > > > > li guang writes: > > > > > > > > > 在 2013-05-24五的 14:45 +0300,Mich

Re: [Qemu-devel] [PATCH] rtl8139: flush queued packets when RxBufPtr is written

2013-05-27 Thread Peter Lieven
On 27.05.2013 17:29, Stefan Hajnoczi wrote: On Mon, May 27, 2013 at 04:24:59PM +0200, Peter Lieven wrote: On 27.05.2013 16:07, Oliver Francke wrote: Well, Am 27.05.2013 um 08:15 schrieb Peter Lieven : Hi all, I ocassionally have seen a probably related problem in the past. It mainly happen

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-27 Thread Michael S. Tsirkin
On Mon, May 27, 2013 at 11:14:47AM -0500, Anthony Liguori wrote: > > Well specifically if_ether.h says GPLv2+ so it's OK for QEMU. > > Do you mean for some other non GPL app? > > Ignore QEMU for the moment. > > The headers say they are BSD licensed... but they include a GPLv2+ > header. Above is

Re: [Qemu-devel] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON

2013-05-27 Thread Gerd Hoffmann
On 05/28/13 02:31, li guang wrote: > 在 2013-05-27一的 11:13 +0200,Gerd Hoffmann写道: >> On 05/24/13 04:47, liguang wrote: >>> when enable DEBUG_DEBUGCON, there are some message >>> printing bugs, so fix them. >> >> I'd suggest to either simply remove the debug printfs or turn them into >> tracepoints.

Re: [Qemu-devel] VFIO VGA test branches

2013-05-27 Thread Knut Omang
On Mon, 2013-05-20 at 23:11 +0200, Knut Omang wrote: > On Sun, 2013-05-19 at 22:15 -0600, Alex Williamson wrote: > > On Sun, 2013-05-19 at 17:35 +0200, Knut Omang wrote: > > > On Mon, 2013-05-13 at 16:23 -0600, Alex Williamson wrote: > > > > On Mon, 2013-05-13 at 22:55 +0200, Knut Omang wrote: > >

Re: [Qemu-devel] [PATCH 3/4] microblaze: Remove CONFIG_FDT conditionals

2013-05-27 Thread Peter Crosthwaite
On Sat, May 25, 2013 at 1:26 AM, Peter Maydell wrote: > Now that we know we're compiling with libfdt we can remove the > CONFIG_FDT conditionals. > > Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite > --- > hw/microblaze/boot.c | 12 > 1 file changed, 12 deletions(-)

Re: [Qemu-devel] [PATCH 2/4] arm: Remove CONFIG_FDT conditionals

2013-05-27 Thread Peter Crosthwaite
On Sat, May 25, 2013 at 1:26 AM, Peter Maydell wrote: > Now that we know we're compiling with libfdt, we can remove the > CONFIG_FDT conditionals. > > Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite > --- > hw/arm/boot.c |7 --- > 1 file changed, 7 deletions(-) > > diff --

Re: [Qemu-devel] [PATCH 1/4] configure: Require libfdt for arm, ppc, microblaze softmmu targets

2013-05-27 Thread Peter Crosthwaite
On Sat, May 25, 2013 at 1:26 AM, Peter Maydell wrote: > A number of our softmmu targets (PPC, ARM, Microblaze) now more or > less require flattened device tree support for various board models > to work correctly. Make libfdt mandatory if the target list includes > these, rather than building unh

Re: [Qemu-devel] VFIO VGA test branches

2013-05-27 Thread Alex Williamson
On Tue, 2013-05-28 at 03:40 +0200, Maik Broemme wrote: > Hi Alex, > > Maik Broemme wrote: > > Hi Alex, > > > > Alex Williamson wrote: > > > > > > Good to hear. It looks like you have the same motherboard as my AMD > > > test system. An HD7850 in that system runs quite reliably with the > > >

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-27 Thread Anthony Liguori
Rusty Russell writes: > Anthony Liguori writes: >> Paolo Bonzini writes: >> >>> Il 26/05/2013 22:02, Michael S. Tsirkin ha scritto: > My fault. I should have looked at linux/types.h (actually asm-generic/). Not really, __uX appear in the headers that were posted. >> >> Which is

[Qemu-devel] [PATCH v4 6/9] dump: Add API to create page

2013-05-27 Thread qiaonuohan
From: Qiao Nuohan Functions in this patch are used to gather data of page desc and page data in kdump-compressed format. The following patch will use these functions to gather data of page, then cache them into tmp files Signed-off-by: Qiao Nuohan Reviewed-by: Zhang Xiaohe --- dump.c

[Qemu-devel] [PATCH v4 9/9] dump: Make kdump-compressed format available for 'dump-guest-memory'

2013-05-27 Thread qiaonuohan
From: Qiao Nuohan Make monitor command 'dump-guest-memory' be able to dump in kdump-compressed format. The command's usage: dump [-p] protocol [begin] [length] [format] 'format' is used to specified the format of vmcore and can be: 1. 'elf': ELF format, without compression 2. 'zlib': kdump-co

[Qemu-devel] [PATCH v4 4/9] dump: Add API to create header of vmcore

2013-05-27 Thread qiaonuohan
From: Qiao Nuohan Functions in this patch are used to gather data of header and sub header in kdump-compressed format. The following patch will use these functions to gather data of header, then cache them into struct DumpState. Signed-off-by: Qiao Nuohan Reviewed-by: Zhang Xiaohe --- dump.c

[Qemu-devel] [PATCH v4 2/9] dump: Add API to manipulate cache_data

2013-05-27 Thread qiaonuohan
From: Qiao Nuohan Struct cache_data is associated with a tmp file which is used to store page desc and page data in kdump-compressed format temporarily. The following patch will use these function to gather data of page and cache them in tmp files. Signed-off-by: Qiao Nuohan Reviewed-by: Zhang

[Qemu-devel] [PATCH v4 7/9] dump: Add API to free memory used by creating header, bitmap and page

2013-05-27 Thread qiaonuohan
From: Qiao Nuohan When calling create_header, create_dump_bitmap and create_pages, some memory spaces are allocated. The following patch will use this function to free these memory. Signed-off-by: Qiao Nuohan Reviewed-by: Zhang Xiaohe --- dump.c | 19 +++ 1 files changed, 19

[Qemu-devel] [PATCH v4 8/9] dump: Add API to write header, bitmap and page into vmcore

2013-05-27 Thread qiaonuohan
From: Qiao Nuohan The following patch will use these functions to write cached data into vmcore. Header is cached in DumpState, and bitmap and page are cached in tmp files. Signed-off-by: Qiao Nuohan Reviewed-by: Zhang Xiaohe --- dump.c | 259 +++

[Qemu-devel] [PATCH v4 5/9] dump: Add API to create data of dump bitmap

2013-05-27 Thread qiaonuohan
From: Qiao Nuohan Functions in this patch are used to gather data of 1st and 2nd dump bitmap in kdump-compressed format. The following patch will use these functions to gather data of dump bitmap, then cache them into tmp files. Signed-off-by: Qiao Nuohan Reviewed-by: Zhang Xiaohe --- dump.c

[Qemu-devel] [PATCH v4 3/9] dump: Move struct definition into dump_memroy.h

2013-05-27 Thread qiaonuohan
From: Qiao Nuohan Move definition of struct DumpState into include/sysemu/dump_memory.h. Signed-off-by: Qiao Nuohan Reviewed-by: Zhang Xiaohe --- dump.c | 22 +- include/sysemu/dump_memory.h | 40 2 files c

[Qemu-devel] [PATCH v4 1/9] dump: Add API to manipulate dump_bitmap

2013-05-27 Thread qiaonuohan
From: Qiao Nuohan Struct dump_bitmap is associated with a tmp file which is used to store bitmap in kdump-compressed format temporarily. The following patch will use these functions to gather data of bitmap and cache them into tmp files. Signed-off-by: Qiao Nuohan Reviewed-by: Zhang Xiaohe ---

[Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-05-27 Thread qiaonuohan
From: Qiao Nuohan Hi, all The last version is here: http://lists.gnu.org/archive/html/qemu-devel/2013-05/msg02280.html Command 'dump-guest-memory' was introduced to dump guest's memory. But the vmcore's format is only elf32 or elf64. The message is here: http://lists.gnu.org/archive/html/qemu-d

Re: [Qemu-devel] [PATCH] pci-assign: remove the duplicate function name in debug message

2013-05-27 Thread Wanlong Gao
Ping... > On Fri, 2013-04-12 at 14:46 +0800, Wanlong Gao wrote: >> While DEBUG() already includes the function name. >> >> Signed-off-by: Wanlong Gao >> --- >> hw/i386/kvm/pci-assign.c | 12 ++-- >> 1 file changed, 6 insertions(+), 6 deletions(-) > > Acked-by: Alex Williamson > >> >>

Re: [Qemu-devel] [PATCH 5/5] memory: able to pin guest node memory to host node manually

2013-05-27 Thread Wanlong Gao
Any comments? > Use mbind to pin guest numa node memory to host nodes manually. > > If we are not able to pin memory to host node, we may meet the > cross node memory access performance regression. > > With this patch, we can add manual pinning host node like this: > -m 1024 -numa node,cpus=0,n

Re: [Qemu-devel] [PATCH V3 1/4] block: drop bs_snapshots global variable

2013-05-27 Thread Wenchao Xia
于 2013-5-27 23:25, Kevin Wolf 写道: Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: From: Stefan Hajnoczi The bs_snapshots global variable points to the BlockDriverState which will be used to save vmstate. This is really a savevm.c concept but was moved into block.c:bdrv_snapshots() when it

Re: [Qemu-devel] [PATCH V3 1/4] block: drop bs_snapshots global variable

2013-05-27 Thread Wenchao Xia
于 2013-5-27 23:18, Kevin Wolf 写道: Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: From: Stefan Hajnoczi The bs_snapshots global variable points to the BlockDriverState which will be used to save vmstate. This is really a savevm.c concept but was moved into block.c:bdrv_snapshots() when it

Re: [Qemu-devel] [update][PATCH 00/12] target-i386: remove some macros

2013-05-27 Thread li guang
在 2013-05-26日的 17:55 +0200,Andreas Färber写道: > Am 24.05.2013 13:37, schrieb Andreas Färber: > > Am 23.04.2013 10:16, schrieb liguang: > >> remove macros EAX, EBX, ECX, EDX, EBP, ESP, ESI, EDI, EIP, DF > >> as suggested by Richard Henderson > >> > >> Li Guang (12) > >> target-i386/helper: remov

Re: [Qemu-devel] [PATCH V3 4/4] block: dump snapshot and image info to specified output

2013-05-27 Thread Wenchao Xia
于 2013-5-27 23:40, Kevin Wolf 写道: Am 27.05.2013 um 17:02 hat Luiz Capitulino geschrieben: On Sat, 25 May 2013 11:09:45 +0800 Wenchao Xia wrote: bdrv_snapshot_dump() and bdrv_image_info_dump() do not dump to a buffer now, some internal buffers are still used for format control, which have no c

Re: [Qemu-devel] VFIO VGA test branches

2013-05-27 Thread Maik Broemme
Hi Alex, Maik Broemme wrote: > Hi Alex, > > Alex Williamson wrote: > > > > Good to hear. It looks like you have the same motherboard as my AMD > > test system. An HD7850 in that system runs quite reliably with the > > branches above although I do occasionally get VGA palette corruption. > >

Re: [Qemu-devel] [PATCH 2/4] acpi/gpe: expand bits of gpe register

2013-05-27 Thread li guang
在 2013-05-27一的 11:00 +0200,Gerd Hoffmann写道: > On 05/24/13 04:02, li guang wrote: > > 在 2013-05-24五的 10:24 +0900,Isaku Yamahata写道: > >> On Wed, May 22, 2013 at 01:37:41PM +0800, li guang wrote: > >>> 在 2013-05-22三的 14:28 +0900,Isaku Yamahata写道: > Why? > And it breaks pointer operation like

Re: [Qemu-devel] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON

2013-05-27 Thread li guang
在 2013-05-27一的 11:13 +0200,Gerd Hoffmann写道: > On 05/24/13 04:47, liguang wrote: > > when enable DEBUG_DEBUGCON, there are some message > > printing bugs, so fix them. > > I'd suggest to either simply remove the debug printfs or turn them into > tracepoints. > sorry, why we simply remove debug me

Re: [Qemu-devel] [PATCH 0/4] add ACPI Embedded Controller

2013-05-27 Thread li guang
在 2013-05-27一的 13:45 +0200,Igor Mammedov写道: > On Mon, 27 May 2013 09:22:59 +0800 > li guang wrote: > > > 在 2013-05-26日的 19:51 -0500,Anthony Liguori写道: > > > li guang writes: > > > > > > > 在 2013-05-24五的 14:45 +0300,Michael S. Tsirkin写道: > > > >> On Wed, May 22, 2013 at 11:46:33AM +0800, liguang

Re: [Qemu-devel] [PATCH 3/4] ich9: add notifer for ec to generate sci

2013-05-27 Thread li guang
在 2013-05-27一的 23:21 +0300,Michael S. Tsirkin写道: > On Wed, May 22, 2013 at 11:46:36AM +0800, liguang wrote: > > Signed-off-by: liguang > > --- > > hw/acpi/ich9.c | 15 +++ > > include/hw/acpi/ich9.h |1 + > > 2 files changed, 16 insertions(+), 0 deletions(-) > > > > dif

Re: [Qemu-devel] [PATCH 0/4] add ACPI Embedded Controller

2013-05-27 Thread li guang
在 2013-05-27一的 23:23 +0300,Michael S. Tsirkin写道: > On Mon, May 27, 2013 at 09:22:59AM +0800, li guang wrote: > > 在 2013-05-26日的 19:51 -0500,Anthony Liguori写道: > > > li guang writes: > > > > > > > 在 2013-05-24五的 14:45 +0300,Michael S. Tsirkin写道: > > > >> On Wed, May 22, 2013 at 11:46:33AM +0800, l

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON

2013-05-27 Thread li guang
在 2013-05-28二的 00:42 +0400,Michael Tokarev写道: > 27.05.2013 05:40, li guang wrote: > [] > >>> NACK. If you want to apply 1-3, okay. But please unqueue 4/4, it makes > >>> no sense as-is (just look at the stderr output to see what I mean) and > >>> it pretends that I suggested that! > >> > >> Actuall

[Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile

2013-05-27 Thread Alexey Kardashevskiy
The symlink to "asm" platform linux headers is made in the build tree by the configure script but gcc is not told to look for them there. The patch fixes this. Signed-off-by: Alexey Kardashevskiy --- The previous patch did not remove the old line adding includes. Early morning, lack of focus :)

[Qemu-devel] [PATCH v2] qemu: fix out of tree cross compile

2013-05-27 Thread Alexey Kardashevskiy
The symlink to "asm" platform linux headers is made in the build tree by the configure script but gcc is not told to look for them there. The patch fixes this. Signed-off-by: Alexey Kardashevskiy --- configure |1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 5a

Re: [Qemu-devel] [PATCH] i.MX: implement a more complete version of the GPT timer.

2013-05-27 Thread Peter Chubb
> "Jean-Christophe" == Jean-Christophe DUBOIS writes: Jean-Christophe> * implement compare 1 2 and 3 registers * Unify Jean-Christophe> function and type naming * use dynamic cast whenever Jean-Christophe> possible * simplify Debug printf. * use new style Jean-Christophe> device intializatio

Re: [Qemu-devel] [PATCH] i.MX: Improve EPIT timer code.

2013-05-27 Thread Peter Chubb
Hi Jean, Thanks for this. Most of it appears cosmetic and an improvement. Comments in-line below. > > /* > * Update interrupt status > */ > -static void imx_timerp_update(IMXTimerPState *s) > +static void imx_timer_epit_update(IMXTimerEPITState *s) > { > -if (s->sr && (s->cr & C

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-27 Thread Rusty Russell
Anthony Liguori writes: > Paolo Bonzini writes: > >> Il 26/05/2013 22:02, Michael S. Tsirkin ha scritto: >>> > My fault. I should have looked at linux/types.h (actually asm-generic/). >>> >>> Not really, __uX appear in the headers that were posted. > > Which is a problem because this is a reser

Re: [Qemu-devel] [PATCH] qemu: fix out of tree cross compile

2013-05-27 Thread Alexey Kardashevskiy
On 05/28/2013 01:02 AM, Paolo Bonzini wrote: > Il 27/05/2013 16:12, Alexey Kardashevskiy ha scritto: >> The symlink to platform linux headers is made in the build tree by >> the configure script but gcc is not told to look for them there. >> The patch fixes this. >> >> Signed-off-by: Alexey Kardash

[Qemu-devel] [Bug 1184089] Re: [Feature request] loadvm snapshot as read-only

2013-05-27 Thread Michael Coppola
Awesome, looking forward to it. I may be misunderstanding what's happening under the hood, but at least for me, calling 'loadvm' on a single snapshot over and over seems to work the first few times and then immediately blue screens the WinXP guest with PFN_LIST_CORRUPT. I was under the assumption

Re: [Qemu-devel] Selecting device variant types based on bdrv size

2013-05-27 Thread Peter Crosthwaite
Hi Andreas, Jan, On Mon, May 27, 2013 at 11:40 PM, Andreas Färber wrote: > Hi, > > Am 27.05.2013 09:50, schrieb Peter Crosthwaite: >> I have a bit of a chicken and egg problem trying to refactor Jans AT24 >> I2C EEPROM model. I'm trying to migrate static class properties up to >> the class level

Re: [Qemu-devel] [PATCH v2 1/2] net: introduce MAC_TABLE_CHANGED event

2013-05-27 Thread Amos Kong
On Mon, May 27, 2013 at 09:24:28AM -0400, Luiz Capitulino wrote: > On Mon, 27 May 2013 09:10:11 -0400 > Luiz Capitulino wrote: > > > > We use the QMP event to notify management about the mac changing. > > > > > > In this thread, we _wrongly_ considered to use qmp approach to delay > > > the even

[Qemu-devel] [PATCH] i.MX: implement a more complete version of the GPT timer.

2013-05-27 Thread Jean-Christophe DUBOIS
* implement compare 1 2 and 3 registers * Unify function and type naming * use dynamic cast whenever possible * simplify Debug printf. * use new style device intialization. Note: This implementation is still missing the support of the 2 input registers that allow to timestamp a level change on a G

[Qemu-devel] [PATCH] i.MX: Improve EPIT timer code.

2013-05-27 Thread Jean-Christophe DUBOIS
* Unify function and type naming * use dynamic cast whenever possible * simplify Debug printf. * use new style device intialization. Signed-off-by: Jean-Christophe DUBOIS --- hw/timer/imx_epit.c | 227 +--- 1 file changed, 129 insertions(+), 98 del

Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

2013-05-27 Thread Laurent Desnogues
On Monday, May 27, 2013, Richard Henderson wrote: > On 2013-05-27 04:43, Claudio Fontana wrote: >>> >>> Hmm, true. Although I'd been thinking more along the lines of >>> arranging the code such that we'd use movz to set the zero. >> >> I think we need to keep treating zero specially if we want to

Re: [Qemu-devel] [Bug 1184616] [NEW] undefined reference to`trace_qemu_anon_ram_alloc'

2013-05-27 Thread Nigel Horne
> On Mon, May 27, 2013 at 4:02 PM, Nigel Horne <1184...@bugs.launchpad.net> > wrote: >> The latest git version (commit 6a4e17711442849bf2cc731ccddef5a2a2d92d29) >> fails to compile: >> >> ... >> LINK qemu-ga >> libqemuutil.a(oslib-posix.o): In function `qemu_anon_ram_alloc': >> oslib-posix.c:(.

Re: [Qemu-devel] kvm process disappears

2013-05-27 Thread Stefan Priebe
Am 10.05.2013 13:09, schrieb Stefan Hajnoczi: On Fri, May 10, 2013 at 11:07 AM, Stefan Priebe - Profihost AG wrote: Am 10.05.2013 09:42, schrieb Stefan Hajnoczi: On Fri, May 10, 2013 at 08:12:39AM +0200, Stefan Priebe - Profihost AG wrote: 3. Either use gdb or an LD_PRELOAD library that catche

Re: [Qemu-devel] IDE disk FLUSH take more than 30 secs, the SUSE guest reports "lost interrupt and the file system becomes read-only"

2013-05-27 Thread Paolo Bonzini
Il 26/05/2013 19:08, Andreas Färber ha scritto: > Have you actually tried that out with a patch such as the following? > > diff --git a/hw/ide/core.c b/hw/ide/core.c > index c7a8041..bf1ff18 100644 > --- a/hw/ide/core.c > +++ b/hw/ide/core.c > @@ -795,6 +795,8 @@ static void ide_flush_cb(void *opa

[Qemu-devel] [PATCH trivial] slirp: cleanup leftovers from misc.h

2013-05-27 Thread Michael Tokarev
There are quite a few leftover declarations in slirp/misc.h. Remove them. Signed-off-by: Michael Tokarev --- slirp/misc.h | 14 -- 1 file changed, 14 deletions(-) I'm not entirely sure we should do this, since this kind of changes just moves us more and more away from the upstream

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4] debugcon: fix some bugs when DEBUG_DEBUGCON

2013-05-27 Thread Michael Tokarev
27.05.2013 05:40, li guang wrote: [] >>> NACK. If you want to apply 1-3, okay. But please unqueue 4/4, it makes >>> no sense as-is (just look at the stderr output to see what I mean) and >>> it pretends that I suggested that! >> >> Actually I did just that, rebuild with DEBUG_DEBUGCON and looked >>

Re: [Qemu-devel] [PATCH qom-cpu 0/3] Conroe/Penryn/Nehalem CPUID family/level fixes

2013-05-27 Thread Andreas Färber
Am 27.05.2013 22:23, schrieb Eduardo Habkost: > This series changes the CPUID family and level fields of the Conroe, Penryn, > and > Nehalem CPU models. > > Testing: those model/level values have been in use on Red Hat > Enterprise Linux since version 6.0 (released in 2010). The fix wasn't > subm

[Qemu-devel] [PATCH qom-cpu 1/3] pc: create pc-*-1.6 machine-types

2013-05-27 Thread Eduardo Habkost
Some CPU model fixes are going to be included and they will require compatibility properties in the pc-*-1.5 machine-types. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c | 14 -- hw/i386/pc_q35.c | 12 +++- 2 files changed, 23 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH qom-cpu 2/3] target-i386: update model values on Conroe/Penryn/Nehalem CPU models

2013-05-27 Thread Eduardo Habkost
The CPUID model values on Conroe, Penryn, and Nehalem are too conservative and don't reflect the values found on real Conroe, Penryn, and Nehalem CPUs. This causes at least one known problems: Windows XP disables sysenter when (family == 6 && model <= 2), but Skype tries to use the sysenter instru

[Qemu-devel] [PATCH qom-cpu 3/3] target-i386: set level=4 on Conroe/Penryn/Nehalem

2013-05-27 Thread Eduardo Habkost
The CPUID level value on Conroe, Penryn, and Nehalem are too low. This causes at least one known problem: the -smp "threads" option doesn't work as expect if level is < 4, because thread count information is provided to the guest on CPUID[EAX=4,ECX=2].EAX Signed-off-by: Eduardo Habkost --- Testin

[Qemu-devel] [PATCH qom-cpu 0/3] Conroe/Penryn/Nehalem CPUID family/level fixes

2013-05-27 Thread Eduardo Habkost
This series changes the CPUID family and level fields of the Conroe, Penryn, and Nehalem CPU models. Testing: those model/level values have been in use on Red Hat Enterprise Linux since version 6.0 (released in 2010). The fix wasn't submitted to QEMU earlier because we didn't have a good mechanism

Re: [Qemu-devel] [PATCH 0/4] add ACPI Embedded Controller

2013-05-27 Thread Michael S. Tsirkin
On Mon, May 27, 2013 at 09:22:59AM +0800, li guang wrote: > 在 2013-05-26日的 19:51 -0500,Anthony Liguori写道: > > li guang writes: > > > > > 在 2013-05-24五的 14:45 +0300,Michael S. Tsirkin写道: > > >> On Wed, May 22, 2013 at 11:46:33AM +0800, liguang wrote: > > >> > These patches try to add ACPI Embedded

Re: [Qemu-devel] [PATCH 3/4] ich9: add notifer for ec to generate sci

2013-05-27 Thread Michael S. Tsirkin
On Wed, May 22, 2013 at 11:46:36AM +0800, liguang wrote: > Signed-off-by: liguang > --- > hw/acpi/ich9.c | 15 +++ > include/hw/acpi/ich9.h |1 + > 2 files changed, 16 insertions(+), 0 deletions(-) > > diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c > index 582dbec..2ecde3

Re: [Qemu-devel] [PATCH 0/2] Trivial fixes for migration

2013-05-27 Thread Michael Tokarev
27.05.2013 14:33, Lei Li wrote: > This small series improves the document migration.txt > and remove a duplicated setting of bandwidth_limit. Thanks, both applied to the trivial patch queue. /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: try pkg-config ncurses first

2013-05-27 Thread Michael Tokarev
25.05.2013 00:07, Ed Maste wrote: > When probing for ncurses, try pkg-config first rather than after > explicit -lncurses and -lcurses. This fixes static linking in the case > that ncurses has additional dependencies, such as -ltinfo (as on FreeBSD). Thanks, applied to the trivial patches queue,

Re: [Qemu-devel] [Qemu-trivial] [RFC PATCH v1 08/20] rtc: remove rtc_set_date

2013-05-27 Thread Michael Tokarev
22.05.2013 09:33, Hu Tao wrote: > Since it's not defined and used anywhere. Thanks, applied to the trivial-patches queue. If the need arises to bring it back, it can be done together with the implementation and some users :) /mjt

Re: [Qemu-devel] [Qemu-trivial] [PATCH] linux-user: Fix typo in comment

2013-05-27 Thread Michael Tokarev
20.05.2013 13:20, Lei Li wrote: > Signed-off-by: Lei Li > --- > linux-user/syscall.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the trivial patch queue. /mjt

Re: [Qemu-devel] [Bug 1184616] [NEW] undefined reference to `trace_qemu_anon_ram_alloc'

2013-05-27 Thread Stefan Hajnoczi
On Mon, May 27, 2013 at 4:02 PM, Nigel Horne <1184...@bugs.launchpad.net> wrote: > The latest git version (commit 6a4e17711442849bf2cc731ccddef5a2a2d92d29) > fails to compile: > > ... > LINK qemu-ga > libqemuutil.a(oslib-posix.o): In function `qemu_anon_ram_alloc': > oslib-posix.c:(.text+0x154):

[Qemu-devel] [PATCH] linux-user: add SIOCADDRT/SIOCDELRT support

2013-05-27 Thread Laurent Vivier
This allows to pass the device name. You can test this with the "route" command. WITHOUT this patch: $ sudo route add -net default gw 10.0.3.1 eth0 SIOCADDRT: Bad address $ netstat -nr Kernel IP routing table Destination Gateway Genmask Flags MSS Window irtt Ifa 10.0.3.0

Re: [Qemu-devel] [PATCH 2/4] tcg/aarch64: implement new TCG target for aarch64

2013-05-27 Thread Richard Henderson
On 2013-05-27 04:43, Claudio Fontana wrote: Hmm, true. Although I'd been thinking more along the lines of arranging the code such that we'd use movz to set the zero. I think we need to keep treating zero specially if we want to keep the optimization where we don't emit needless MOVK instructi

Re: [Qemu-devel] snabbswitch integration with QEMU for userspace ethernet I/O

2013-05-27 Thread Anthony Liguori
On Mon, May 27, 2013 at 12:13 PM, Michael S. Tsirkin wrote: > > On Mon, May 27, 2013 at 12:01:07PM -0500, Anthony Liguori wrote: > > Paolo Bonzini writes: > > > > Finally, the destination QEMU process can vmsplice() from the pipe which > > will copy the data (this is the only copy). > > AFAIK spl

Re: [Qemu-devel] [PATCH stable-1.1] qga: set umask 0077 when daemonizing (CVE-2013-2007)

2013-05-27 Thread Laszlo Ersek
On 05/27/13 02:19, Andreas Färber wrote: > Am 27.05.2013 02:11, schrieb Laszlo Ersek: >> Also, a side-note: existing world-writable log files etc. are not >> recreated nor have their modes changed, so maybe a release note or some >> such would be useful for admins ("delete your previous logfile &

Re: [Qemu-devel] [PATCH arm-devs v3 1/1] sd/sd.c: Fix "inquiry" ACMD41

2013-05-27 Thread Igor Mitsyanko
On 05/27/2013 06:41 AM, peter.crosthwa...@xilinx.com wrote: > From: Peter Crosthwaite > > QEMU models two (of the three) ACMD41 has two modes, "inquiry" and > "first". The selection logic for which of the two is incorrect - it > compares != 0 for the entire argument value rather than only bits 23:

[Qemu-devel] [PATCH 2/2] xen: use pc_init_pci instead of pc_init_pci_no_kvmclock

2013-05-27 Thread Stefano Stabellini
Call kvmclock_create only if kvmclock_enabled. Use pc_init_pci on Xen rather than pc_init_pci_no_kvmclock. Signed-off-by: Stefano Stabellini --- hw/i386/pc_piix.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 1ef4cbf..4308

[Qemu-devel] [PATCH 1/2] xen: remove xen_vcpu_init

2013-05-27 Thread Stefano Stabellini
No need for xen_vcpu_init anymore: - the RTC emulator doesn't have any periodic timers continuously running even in absence of guest interactions anymore; - qemu_dummy_start_vcpu takes care of disabling TCG for us, so we don't need to do it manually here. Signed-off-by: Stefano Stabellini ---

[Qemu-devel] [PATCH 0/2] Xen cleanups

2013-05-27 Thread Stefano Stabellini
Hi all, just a couple of simple cleanups suggested by Paolo Bonzini: Stefano Stabellini (2): xen: remove xen_vcpu_init xen: use pc_init_pci instead of pc_init_pci_no_kvmclock hw/i386/pc_piix.c |5 ++--- xen-all.c | 23 --- 2 files changed, 2 insertio

[Qemu-devel] [PATCH 2/3] xen: simplify xen_enabled

2013-05-27 Thread Stefano Stabellini
No need for preprocessor conditionals in xen_enabled: xen_allowed is always defined. Please backport this patch to stable branches (it is needed by the following patch to remove the dependency on a preprocessor identifier defined by config-target.h). Signed-off-by: Stefano Stabellini CC: qemu-st

[Qemu-devel] [PATCH 3/3] main_loop: do not set nonblocking if xen_enabled()

2013-05-27 Thread Stefano Stabellini
Please backport this patch to stable branches. Signed-off-by: Stefano Stabellini CC: qemu-sta...@nongnu.org --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 510d2c2..47ab45d 100644 --- a/vl.c +++ b/vl.c @@ -2022,7 +2022,7 @@ static void main_lo

[Qemu-devel] [PATCH 1/3] qemu_chr_new_from_opts: do not overwrite existing chr->filename

2013-05-27 Thread Stefano Stabellini
Set the new filename only if it hasn't been already set (for example by qemu_chr_open_pty). This fixes a regression that prevents Xen HVM domains from booting. It was introduced by: commit 2b220025993e76d4116781ca91a4fabc5ad9c722 Author: Lei Li Date: Tue May 21 18:27:59 2013 +0800 Signed-off-

[Qemu-devel] [PATCH 0/3] Xen related fixes

2013-05-27 Thread Stefano Stabellini
Hi all, I have few simple fixes for Xen for the next release: - the first one fixes a regression in qemu-char; - the second one is just a cleanup (that is needed to simplify preprocessor dependencies); - the last one avoids setting nonblocking on Xen (as is already done for KVM). The last two

Re: [Qemu-devel] [PATCH v2] monitor: work around delayed CHR_EVENT_OPENED events

2013-05-27 Thread mdroth
On Mon, May 27, 2013 at 11:16:01AM -0500, Anthony Liguori wrote: > Luiz Capitulino writes: > > > On Sun, 26 May 2013 10:33:39 -0500 > > Michael Roth wrote: > > > >> In the past, CHR_EVENT_OPENED events were emitted via a pre-expired > >> QEMUTimer. Due to timers being processing at the tail end

Re: [Qemu-devel] snabbswitch integration with QEMU for userspace ethernet I/O

2013-05-27 Thread Michael S. Tsirkin
On Mon, May 27, 2013 at 12:01:07PM -0500, Anthony Liguori wrote: > Paolo Bonzini writes: > > > Il 27/05/2013 18:18, Anthony Liguori ha scritto: > >> Paolo Bonzini writes: > >> > >>> Il 27/05/2013 11:34, Stefan Hajnoczi ha scritto: > On Sun, May 26, 2013 at 11:32:49AM +0200, Luke Gorrie wro

Re: [Qemu-devel] [PATCH 2/4] tcg/aarch64: implement new TCG target for aarch64

2013-05-27 Thread Richard Henderson
On 2013-05-27 02:10, Claudio Fontana wrote: +case INDEX_op_mov_i64: ext = 1; Please don't put code on the same line as a case statement. Also fall-through cases should have an explicit /* fall through */ comment (except in the case where there is no code at all between one case statement an

Re: [Qemu-devel] [Bug 1180970] *** affects all x86_64 soft emulation

2013-05-27 Thread Luiz Capitulino
On Fri, 24 May 2013 23:23:02 +0200 Laszlo Ersek wrote: > --[ proposed fix ]-- > diff --git a/target-i386/translate.c b/target-i386/translate.c > index 0e0356f..4fbd6c0 100644 > --- a/target-i386/translate.c > +++ b/target-i386/translate.c > @@ -

[Qemu-devel] [Bug 1184616] [NEW] undefined reference to `trace_qemu_anon_ram_alloc'

2013-05-27 Thread Nigel Horne
Public bug reported: The latest git version (commit 6a4e17711442849bf2cc731ccddef5a2a2d92d29) fails to compile: ... LINK qemu-ga libqemuutil.a(oslib-posix.o): In function `qemu_anon_ram_alloc': oslib-posix.c:(.text+0x154): undefined reference to `trace_qemu_anon_ram_alloc' libqemuutil.a(oslib-

Re: [Qemu-devel] snabbswitch integration with QEMU for userspace ethernet I/O

2013-05-27 Thread Anthony Liguori
Paolo Bonzini writes: > Il 27/05/2013 18:18, Anthony Liguori ha scritto: >> Paolo Bonzini writes: >> >>> Il 27/05/2013 11:34, Stefan Hajnoczi ha scritto: On Sun, May 26, 2013 at 11:32:49AM +0200, Luke Gorrie wrote: > Stefan put us onto the highly promising track of vhost/virtio. We hav

Re: [Qemu-devel] snabbswitch integration with QEMU for userspace ethernet I/O

2013-05-27 Thread Paolo Bonzini
Il 27/05/2013 18:18, Anthony Liguori ha scritto: > Paolo Bonzini writes: > >> Il 27/05/2013 11:34, Stefan Hajnoczi ha scritto: >>> On Sun, May 26, 2013 at 11:32:49AM +0200, Luke Gorrie wrote: Stefan put us onto the highly promising track of vhost/virtio. We have implemented this between

Re: [Qemu-devel] snabbswitch integration with QEMU for userspace ethernet I/O

2013-05-27 Thread Anthony Liguori
Paolo Bonzini writes: > Il 27/05/2013 11:34, Stefan Hajnoczi ha scritto: >> On Sun, May 26, 2013 at 11:32:49AM +0200, Luke Gorrie wrote: >>> Stefan put us onto the highly promising track of vhost/virtio. We have >>> implemented this between Snabb Switch and the Linux kernel, but not >>> directly

Re: [Qemu-devel] [PATCH v2] monitor: work around delayed CHR_EVENT_OPENED events

2013-05-27 Thread Anthony Liguori
Luiz Capitulino writes: > On Sun, 26 May 2013 10:33:39 -0500 > Michael Roth wrote: > >> In the past, CHR_EVENT_OPENED events were emitted via a pre-expired >> QEMUTimer. Due to timers being processing at the tail end of each main >> loop iteration, this generally meant that such events would be

Re: [Qemu-devel] [PATCH v2 00/11] qemu: use virtio linux headers in portable code

2013-05-27 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Sun, May 26, 2013 at 07:55:25PM -0500, Anthony Liguori wrote: >> "Michael S. Tsirkin" writes: >> >> > On Sun, May 26, 2013 at 03:49:53PM -0500, Anthony Liguori wrote: >> >> Paolo Bonzini writes: >> >> >> >> > Il 26/05/2013 22:02, Michael S. Tsirkin ha scritto

Re: [Qemu-devel] [PATCH V3 4/4] block: dump snapshot and image info to specified output

2013-05-27 Thread Luiz Capitulino
On Mon, 27 May 2013 17:40:59 +0200 Kevin Wolf wrote: > Am 27.05.2013 um 17:02 hat Luiz Capitulino geschrieben: > > On Sat, 25 May 2013 11:09:45 +0800 > > Wenchao Xia wrote: > > > > > bdrv_snapshot_dump() and bdrv_image_info_dump() do not dump to a buffer > > > now, > > > some internal buffers

Re: [Qemu-devel] snabbswitch integration with QEMU for userspace ethernet I/O

2013-05-27 Thread Paolo Bonzini
Il 27/05/2013 11:34, Stefan Hajnoczi ha scritto: > On Sun, May 26, 2013 at 11:32:49AM +0200, Luke Gorrie wrote: >> Stefan put us onto the highly promising track of vhost/virtio. We have >> implemented this between Snabb Switch and the Linux kernel, but not >> directly between Snabb Switch and QEMU

Re: [Qemu-devel] [PATCH V3 4/4] block: dump snapshot and image info to specified output

2013-05-27 Thread Kevin Wolf
Am 27.05.2013 um 17:02 hat Luiz Capitulino geschrieben: > On Sat, 25 May 2013 11:09:45 +0800 > Wenchao Xia wrote: > > > bdrv_snapshot_dump() and bdrv_image_info_dump() do not dump to a buffer now, > > some internal buffers are still used for format control, which have no > > chance to be truncate

Re: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer

2013-05-27 Thread Kevin Wolf
Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: > These patches are the common part of my hmp/qmp block query series and Pavel's > qmp snapshot command converion series. It mainly does following things: > 1 move snapshot related code to block/snapshot.c, qmp and info dumping code to > block/qap

Re: [Qemu-devel] [PATCH] rtl8139: flush queued packets when RxBufPtr is written

2013-05-27 Thread Stefan Hajnoczi
On Mon, May 27, 2013 at 04:24:59PM +0200, Peter Lieven wrote: > On 27.05.2013 16:07, Oliver Francke wrote: > >Well, > > > >Am 27.05.2013 um 08:15 schrieb Peter Lieven : > > > >>Hi all, > >> > >>I ocassionally have seen a probably related problem in the past. It mainly > >>happend with rtl8139 unde

Re: [Qemu-devel] [PATCH V3 1/4] block: drop bs_snapshots global variable

2013-05-27 Thread Kevin Wolf
Am 25.05.2013 um 05:09 hat Wenchao Xia geschrieben: > From: Stefan Hajnoczi > > The bs_snapshots global variable points to the BlockDriverState which > will be used to save vmstate. This is really a savevm.c concept but was > moved into block.c:bdrv_snapshots() when it became clear that hotplug

Re: [Qemu-devel] [PATCH v2] monitor: work around delayed CHR_EVENT_OPENED events

2013-05-27 Thread Luiz Capitulino
On Sun, 26 May 2013 10:33:39 -0500 Michael Roth wrote: > In the past, CHR_EVENT_OPENED events were emitted via a pre-expired > QEMUTimer. Due to timers being processing at the tail end of each main > loop iteration, this generally meant that such events would be emitted > within the same main loo

  1   2   >