Re: [Qemu-devel] [PATCH V5 0/5] block: make qmp_transaction extendable

2013-05-13 Thread Wenchao Xia
于 2013-5-8 19:21, Kevin Wolf 写道: Am 08.05.2013 um 12:25 hat Wenchao Xia geschrieben: This serial will package backing chain snapshot code as one case, to make it possible adding more operations later. v2: Address Kevin's comments: Use the same prototype prepare, commit, rollback model

Re: [Qemu-devel] [PATCH] Remove twice include of qemu-common.h

2013-05-13 Thread Michael Tokarev
08.05.2013 08:39, qiaonuo...@cn.fujitsu.com wrote: > From: Qiao Nuohan > > This patch is used to remove twice include of "qemu-common.h" in > block/win32-aio.c Thanks, applied to the trivial patches queue. /mjt

Re: [Qemu-devel] [Patch] v2 fix /proc/self/maps output

2013-05-13 Thread Michael Tokarev
02.04.2013 16:03, Christophe Lyon wrote: > Add a space at end of line when there is no filename to print, to > conform to linux kernel format (see show_map_vma() in > fs/proc/task_mmu.c). > > Signed-off-by: Christophe Lyon Thanks, applied to the trivial patches queue. /mjt > Changes v1-v2: > A

Re: [Qemu-devel] [RFC PATCH 2/2] mem: prepare address_space listener rcu style

2013-05-13 Thread liu ping fan
On Mon, May 13, 2013 at 5:31 PM, Paolo Bonzini wrote: > Il 13/05/2013 05:21, Liu Ping Fan ha scritto: >> From: Liu Ping Fan >> >> Each address space listener has PhysPageMap *cur_map, *next_map, >> the switch from cur_map to next_map complete the RCU style. The >> mem_commit() do the switch, and

[Qemu-devel] [PATCH v4 07/12] linux-user: Add syscall handling for AArch64

2013-05-13 Thread John Rigby
From: Alexander Graf The AArch64 syscall definitions are all publicly available in the Linux kernel. Let's add them to our linux-user emulation target, so that we can easily handle AArch64 syscalls. Signed-off-by: Alexander Graf Signed-off-by: John Rigby --- Changes in v3: - Put aarch64 sysca

[Qemu-devel] [PATCH v4 12/12] linux-user: AArch64 requires at least 3.8.0

2013-05-13 Thread John Rigby
From: Alexander Graf Glibc 1.17 checks for the host kernel version on startup. Unfortunately, it also checks whether the host kernel version is recent enough for the target to run at all. Since AArch64 support only got introduced in 3.8.0, that means that glibc refuses to run on any older kernel

[Qemu-devel] [PATCH v4 08/12] linux-user: Fix up AArch64 syscall handlers

2013-05-13 Thread John Rigby
From: Alexander Graf Some syscall handlers have special code for ARM enabled that we don't need on AArch64. Exclude AArch64 in those cases. In other places we can share struct definitions with other targets or have to provide our own. With this patch applied, most syscall definitions in linux-us

[Qemu-devel] [PATCH v4 10/12] linux-user: Add AArch64 support

2013-05-13 Thread John Rigby
From: Alexander Graf This patch adds support for AArch64 in all the small corners of linux-user and beyond. Signed-off-by: Alexander Graf Signed-off-by: John Rigby --- changes in v3: - Aarch64 files go in linux-user/aarch64 instead of ifdefs in linux-user/arm changes in v4: - fix more

[Qemu-devel] [PATCH v4 06/12] linux-user: Don't treat aarch64 cpu names specially

2013-05-13 Thread John Rigby
From: Alexander Graf 32-bit ARM has a lot of different names for different types of CPUs it supports. On AArch64, we don't have this, so we really don't want to execute the 32-bit logic. Stub it out for AArch64 linux-user guests. Signed-off-by: Alexander Graf Signed-off-by: John Rigby --- lin

[Qemu-devel] [PATCH v4 09/12] linux-user: Add signal handling for AArch64

2013-05-13 Thread John Rigby
From: Andreas Schwab This patch adds signal handling for AArch64. The code is based on the respective source in the Linux kernel. Signed-off-by: Andreas Schwab Signed-off-by: Alexander Graf Signed-off-by: John Rigby --- Changes in v3: - Remove unneeded __{put,get}__user error checking - Fix

[Qemu-devel] [PATCH v4 11/12] ARM: Add aarch64 target to configure

2013-05-13 Thread John Rigby
From: Alexander Graf If we want to compile a target machine type that is AArch64 capable, we need to add a new 64-bit capable ARM target. Use AArch64 since that is the official ARM LTD name. Signed-off-by: Alexander Graf Signed-off-by: John Rigby --- Changes in v3: - Arch aarch64 gets its own

[Qemu-devel] [PATCH v4 05/12] AArch64: Add gdb stub

2013-05-13 Thread John Rigby
From: Alexander Graf We want to be able to debug AArch64 guests. So let's add the respective gdb stub functions and xml descriptions that allow us to do so. Signed-off-by: Alexander Graf Signed-off-by: John Rigby --- Changes in v3: - fix checkpatch.pl issues Changes in v4: - env->sp --> env-

[Qemu-devel] [PATCH v4 02/12] ARM: Export cpu_env

2013-05-13 Thread John Rigby
From: Alexander Graf The cpu_env tcg variable will be used by both the AArch32 and AArch64 handling code. Unstaticify it, so that both sides can make use of it. Signed-off-by: Alexander Graf Signed-off-by: John Rigby --- Changes in v3: - None because consensus alternative to non static arm cp

[Qemu-devel] [PATCH v4 04/12] ARM: Add AArch64 translation stub

2013-05-13 Thread John Rigby
From: Alexander Graf We should translate AArch64 mode separately from AArch32 mode. In AArch64 mode, registers look vastly different, instruction encoding is completely different, basically the system turns into a different machine. So let's do a simple if() in translate.c to decide whether we c

[Qemu-devel] [PATCH v4 03/12] ARM: Prepare translation for AArch64 code

2013-05-13 Thread John Rigby
From: Alexander Graf This patch adds all the prerequisites for AArch64 support that didn't fit into split up patches. It extends important bits in the core cpu headers to also take AArch64 mode into account. Add new ARM_TBFLAG_AARCH64_STATE translation buffer flag indicate an ARMv8 cpu running i

[Qemu-devel] [PATCH v4 01/12] ARM: Extract the disas struct to a header file

2013-05-13 Thread John Rigby
From: Alexander Graf We will need to share the disassembly status struct between AArch32 and AArch64 modes. So put it into a header file that both sides can use. Signed-off-by: Alexander Graf Signed-off-by: John Rigby --- target-arm/translate.c | 24 +--- target-arm/transl

[Qemu-devel] [PATCH v4 00/12] AArch64 preparation patch set

2013-05-13 Thread John Rigby
More clean up. Cross compile tested for aarch64 linux-user target and armhf softmmu. Alexander Graf (11): ARM: Extract the disas struct to a header file ARM: Export cpu_env ARM: Prepare translation for AArch64 code ARM: Add AArch64 translation stub AArch64: Add gdb stub linux-user: Don

Re: [Qemu-devel] [RFC PATCH 1/2] mem: make phys_section and phys_map_nodes prepared for RCU

2013-05-13 Thread liu ping fan
On Mon, May 13, 2013 at 5:20 PM, Paolo Bonzini wrote: > Il 13/05/2013 05:21, Liu Ping Fan ha scritto: >> From: Liu Ping Fan >> >> Now, each AddressSpaceDispatch has its own radix-tree, and all of them >> lie on phys_section[] and phys_map_nodes[]. When we want lockless >> mmio dispatch, we need s

[Qemu-devel] [Bug 1179731] [NEW] is networking broken on windows hosts?

2013-05-13 Thread therock247uk
Public bug reported: just wondering as i just compiled the latest git and qemu goes into none responding mode when i try to do any networking stuff on guests (both linux and windows) ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because y

[Qemu-devel] [Bug 1179664] [NEW] migration.c:293: undefined reference to `__sync_val_compare_and_swap_4'

2013-05-13 Thread therock247uk
Public bug reported: latest git qemu error i get on compiling with mingw LINK i386-softmmu/qemu-system-i386w.exe ../migration.o: In function `migrate_finish_set_state': C:\MinGW\msys\1.0\home\therock247uk\qemu/migration.c:293: undefined reference to `__sync_val_compare_and_swap_4' C:\MinGW\ms

Re: [Qemu-devel] [0/8] RFC: VFIO and guest side IOMMUs, revisited

2013-05-13 Thread David Gibson
On Mon, May 13, 2013 at 03:30:26PM +0200, Paolo Bonzini wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Il 13/05/2013 15:13, David Gibson ha scritto: > > On Mon, May 13, 2013 at 02:23:30PM +0200, Paolo Bonzini wrote: > >> Il 13/05/2013 12:54, David Gibson ha scritto: > >>> Specificall

[Qemu-devel] [PATCH v2 09/11] curl: release everything on curl_close

2013-05-13 Thread Fam Zheng
Release everything properly on curl_close. Signed-off-by: Fam Zheng --- block/curl.c | 37 - 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/block/curl.c b/block/curl.c index f20d81c..bde2a55 100644 --- a/block/curl.c +++ b/block/curl.c @@ -644,6

[Qemu-devel] [PATCH v2 04/11] curl: fix curl_open

2013-05-13 Thread Fam Zheng
Change curl_size_cb to curl_header_cb, as what the function is really doing. Fix the registering, CURLOPT_WRITEFUNCTION is apparently wrong, should be CURLOPT_HEADERFUNCTION. Parsing size from header is not necessary as we're using curl_easy_getinfo(state->curl, CURLINFO_CONTENT_LENGTH_DOWNLOAD

[Qemu-devel] [PATCH v2 11/11] curl: introduce ssl_no_cert runtime option.

2013-05-13 Thread Fam Zheng
Added an option to let curl disable ssl certificate check. Signed-off-by: Fam Zheng --- block/curl.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/block/curl.c b/block/curl.c index fa9960d..21a357b 100644 --- a/block/curl.c +++ b/block/curl.c @@ -96,6 +96,8 @@

[Qemu-devel] [PATCH v2 03/11] curl: change curl_multi_do to curl_fd_handler

2013-05-13 Thread Fam Zheng
The driver calls curl_multi_do to take action at several points, while it's also registered as socket fd handler. This patch removes internal call of curl_multi_do because they are not necessary when handler can be called by socket data update. Since curl_multi_do becomes a pure fd handler, the fu

[Qemu-devel] [PATCH v2 10/11] curl: add cache quota.

2013-05-13 Thread Fam Zheng
Introduce a cache quota: BDRVCURLState.cache_quota. When adding new CURLDataCache to BDRVCURLState, if number of existing CURLDataCache is larger than CURL_CACHE_QUOTA, try to release some first to limit the in memory cache size. A least used entry is selected for releasing. Signed-off-by: Fam Zh

[Qemu-devel] [PATCH v2 02/11] curl: change magic number to macro

2013-05-13 Thread Fam Zheng
String field length is duplicated in two places. Make it a macro. Signed-off-by: Fam Zheng --- block/curl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/block/curl.c b/block/curl.c index 14f4552..aa78086 100644 --- a/block/curl.c +++ b/block/curl.c @@ -70,7 +70,8 @@ t

[Qemu-devel] [PATCH v2 08/11] curl: use list to store CURLState

2013-05-13 Thread Fam Zheng
Make it consistent to other structures to use QLIST to store CURLState. It also simplifies initialization and releasing of data. Signed-off-by: Fam Zheng --- block/curl.c | 79 +++- 1 file changed, 35 insertions(+), 44 deletions(-) diff --

[Qemu-devel] [PATCH v2 06/11] curl: introduce CURLDataCache

2013-05-13 Thread Fam Zheng
Data buffer was contained by CURLState, they are allocated and freed together. This patch try to isolate them, by introducing a dedicated cache list to BDRVCURLState. The benifit is we can now release the CURLState (and associated sockets) while keep the fetched data for later use, and simplies the

[Qemu-devel] [PATCH v2 01/11] curl: introduce CURLSockInfo to BDRVCURLState.

2013-05-13 Thread Fam Zheng
We use socket provided by curl in the driver. Libcurl multi interface has option CURLMOPT_SOCKETFUNCTION for socket. Per man 3 curl_multi_setopt: ... CURLMOPT_SOCKETFUNCTION Pass a pointer to a function matching the curl_socket_callback prototype. The curl_multi_socket_action(3)

[Qemu-devel] [PATCH v2 07/11] curl: make use of CURLDataCache.

2013-05-13 Thread Fam Zheng
Make subsequecial changes to make use of introduced CURLDataCache. Moved acb struct from CURLState to BDRVCURLState, and changed to list. Signed-off-by: Fam Zheng --- block/curl.c | 156 +-- 1 file changed, 78 insertions(+), 78 deletions(-)

[Qemu-devel] [PATCH v2 05/11] curl: add timer to BDRVCURLState

2013-05-13 Thread Fam Zheng
libcurl uses timer to manage ongoing sockets, it needs us to supply timer. This patch introduce QEMUTimer to BDRVCURLState and handles timeouts as libcurl expects (curl_multi_timer_cb sets given timeout value on the timer and curl_timer_cb calls curl_multi_socket_action on triggered). Signed-off-b

[Qemu-devel] [PATCH v2 00/11] curl: fix curl read

2013-05-13 Thread Fam Zheng
CURL library API has changed, the current curl driver is not working. This patch rewrites the use of API as well as the structure of internal states. (It is hard to split this to multiple patches as basically all these changes need to work together.) BDRVCURLState holds the pointer to curl multi i

Re: [Qemu-devel] [PATCH 8/8] vfio: Create VFIOAddressSpace objects as needed

2013-05-13 Thread David Gibson
On Mon, May 13, 2013 at 03:33:06PM -0600, Alex Williamson wrote: > On Mon, 2013-05-13 at 20:54 +1000, David Gibson wrote: > > So far, VFIO has a notion of different logical DMA address spaces, but > > only ever uses one (system memory). This patch extends this, creating > > new VFIOAddressSpace ob

Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command

2013-05-13 Thread Wenchao Xia
于 2013-5-13 22:50, Eric Blake 写道: On 05/13/2013 08:27 AM, Kevin Wolf wrote: I think long term we'll need a dynamic schema anyway. As we go forward with modularisation and putting things into shared libraries, we'll have modules that add support for commands, enum values, etc. In other words, q

Re: [Qemu-devel] [PATCH V18 5/6] add-cow file format core code.

2013-05-13 Thread Dong Xu Wang
On 2013/5/13 23:07, Jeff Cody wrote: On Wed, Apr 10, 2013 at 04:11:52PM +0800, Dong Xu Wang wrote: add-cow file format core code. It use block-cache.c as cache code. It lacks of snapshot_blkdev support. Signed-off-by: Dong Xu Wang --- v17-v18: 1) use error_report, not fprintf. 2) remove versio

Re: [Qemu-devel] [PATCH for-1.5 0/2] Fix hot-unplug of devices with ROM or RAM

2013-05-13 Thread Amos Kong
On Mon, May 13, 2013 at 04:19:54PM +0200, Paolo Bonzini wrote: > Reported by Amos. > > Paolo Bonzini (2): > osdep: rename qemu_vmalloc to qemu_anon_ram_alloc > osdep: introduce qemu_anon_ram_free to free qemu_anon_ram_alloc-ed memory Looks good to me, hotplug works now. Reviewed-by: Amos Ko

Re: [Qemu-devel] [SeaBIOS] [PATCH RFC 00/13] qemu: generate acpi tables for the guest

2013-05-13 Thread Kevin O'Connor
On Mon, May 13, 2013 at 03:38:51PM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > git trees, for those interested in testing this: > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/seabios.git acpi > > > > bios patch

Re: [Qemu-devel] [PATCH 7/8] vfio: Introduce VFIO address spaces

2013-05-13 Thread David Gibson
On Mon, May 13, 2013 at 03:32:59PM -0600, Alex Williamson wrote: > On Mon, 2013-05-13 at 20:54 +1000, David Gibson wrote: > > The only model so far supported for VFIO passthrough devices is the model > > usually used on x86, where all of the guest's RAM is mapped into the > > (host) IOMMU and there

Re: [Qemu-devel] [PATCH for-1.5 1/2] qom: aggressively optimize qom casting

2013-05-13 Thread Anthony Liguori
Peter Maydell writes: > On 13 May 2013 21:31, Anthony Liguori wrote: >> This patch adds a small typename cache to ObjectClass. This allows >> caching positive casts within each ObjectClass. Benchmarking a >> PPC workload provided by Aurelien, this patch eliminates every >> single g_hash_table_

[Qemu-devel] [Bug 1094564] Re: images used as scsi disks not readable (qemu-system-arm, macos 10.8)

2013-05-13 Thread Joss Reeves
I just compiled 1.5.0-rc1 on my Linux host with the same configure/compiler flags and duplicated the error (see screenshot). The configure flags are: ./configure --disable-guest-agent --disable-bsd-user --enable-sdl --target-list="arm-linux-user armeb-linux-user arm-softmmu" As before, it goes i

Re: [Qemu-devel] [PATCH] arm/zynq: Add software reset

2013-05-13 Thread Peter Crosthwaite
Hi Sebastian, Thanks for your contribution, On Wed, May 8, 2013 at 10:55 PM, Sebastian Huber wrote: > --- > hw/misc/zynq_slcr.c |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/hw/misc/zynq_slcr.c b/hw/misc/zynq_slcr.c > index 8418327..e88702e 100644 > --- a/hw/mi

Re: [Qemu-devel] VFIO VGA test branches

2013-05-13 Thread Alex Williamson
On Mon, 2013-05-13 at 22:55 +0200, Knut Omang wrote: > Hi all, > > Perfect timing from my perspective, thanks Alex! > > I spent the better part of the weekend testing your branches on a new system > I just put together for this purpose, results below.. > > On Fri, 2013-05-03 at 16:56 -0600, Ale

Re: [Qemu-devel] drive-mirror sync points

2013-05-13 Thread Wolfgang Richter
On May 13, 2013, at 5:46 PM, "Richard W.M. Jones" wrote: > On Mon, May 13, 2013 at 01:50:00PM -0400, Wolfgang Richter wrote: >> Paolo/anyone who knows - >> >> Are drive-mirror sync points (NBD flush commands) reflecting guest write >> barriers? Are guest write barriers respected by drive-mirror

Re: [Qemu-devel] [PATCH for-1.5 1/2] qom: aggressively optimize qom casting

2013-05-13 Thread Peter Maydell
On 13 May 2013 21:31, Anthony Liguori wrote: > This patch adds a small typename cache to ObjectClass. This allows > caching positive casts within each ObjectClass. Benchmarking a > PPC workload provided by Aurelien, this patch eliminates every > single g_hash_table_lookup() happening during the

Re: [Qemu-devel] drive-mirror sync points

2013-05-13 Thread Richard W.M. Jones
On Mon, May 13, 2013 at 10:46:55PM +0100, Richard W.M. Jones wrote: > On Mon, May 13, 2013 at 01:50:00PM -0400, Wolfgang Richter wrote: > > Paolo/anyone who knows - > > > > Are drive-mirror sync points (NBD flush commands) reflecting guest write > > barriers? Are guest write barriers respected by

Re: [Qemu-devel] drive-mirror sync points

2013-05-13 Thread Richard W.M. Jones
On Mon, May 13, 2013 at 01:50:00PM -0400, Wolfgang Richter wrote: > Paolo/anyone who knows - > > Are drive-mirror sync points (NBD flush commands) reflecting guest write > barriers? Are guest write barriers respected by drive-mirror? If so, that > would make drive-mirror much more palatable for

Re: [Qemu-devel] [PATCH 8/8] vfio: Create VFIOAddressSpace objects as needed

2013-05-13 Thread Alex Williamson
On Mon, 2013-05-13 at 20:54 +1000, David Gibson wrote: > So far, VFIO has a notion of different logical DMA address spaces, but > only ever uses one (system memory). This patch extends this, creating > new VFIOAddressSpace objects as necessary, according to the AddressSpace > reported by the PCI s

Re: [Qemu-devel] [PATCH 7/8] vfio: Introduce VFIO address spaces

2013-05-13 Thread Alex Williamson
On Mon, 2013-05-13 at 20:54 +1000, David Gibson wrote: > The only model so far supported for VFIO passthrough devices is the model > usually used on x86, where all of the guest's RAM is mapped into the > (host) IOMMU and there is no IOMMU visible in the guest. > > This patch begins to relax this m

Re: [Qemu-devel] [PATCHv3 for-1.5] virtio-pci: fix level interrupts

2013-05-13 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > mask notifiers are never called without msix, > so devices with backend masking like vhost don't work. > Call mask notifiers explicitly at > startup/cleanup to make it work. > > Signed-off-by: Michael S. Tsirkin > Tested-by: Alexander Graf Applied, thanks. There

[Qemu-devel] [RFC] block-trace Low Level Command Supporting Disk Introspection

2013-05-13 Thread Wolfgang Richter
I'm working on a new patch series which will add a new QMP command, block-trace, which turns on tracing of writes for a specified block device and sends the stream unmodified to another block device. The 'trace' is meant to be precise meaning that writes are not lost, which differentiates this com

Re: [Qemu-devel] [PATCH for-1.5 1/2] qom: aggressively optimize qom casting

2013-05-13 Thread Paolo Bonzini
Il 13/05/2013 23:04, Anthony Liguori ha scritto: > We should leave the --disable-qom-casts present for 1.5 but I'd like > to discuss reverting it for 1.6. I'll send patches once 1.6 opens up. I disagree, the cost is small but still provably nonzero. We should only remove it once interfaces start

Re: [Qemu-devel] [PATCH for-1.5 1/2] qom: aggressively optimize qom casting

2013-05-13 Thread Anthony Liguori
Paolo Bonzini writes: > Il 13/05/2013 22:31, Anthony Liguori ha scritto: >> This patch adds a small typename cache to ObjectClass. This allows >> caching positive casts within each ObjectClass. Benchmarking a >> PPC workload provided by Aurelien, this patch eliminates every >> single g_hash_tab

Re: [Qemu-devel] VFIO VGA test branches

2013-05-13 Thread Knut Omang
Hi all, Perfect timing from my perspective, thanks Alex! I spent the better part of the weekend testing your branches on a new system I just put together for this purpose, results below.. On Fri, 2013-05-03 at 16:56 -0600, Alex Williamson wrote: ... > git://github.com/awilliam/linux-vfio.git vf

Re: [Qemu-devel] [PATCH for-1.5 1/2] qom: aggressively optimize qom casting

2013-05-13 Thread Paolo Bonzini
Il 13/05/2013 22:31, Anthony Liguori ha scritto: > This patch adds a small typename cache to ObjectClass. This allows > caching positive casts within each ObjectClass. Benchmarking a > PPC workload provided by Aurelien, this patch eliminates every > single g_hash_table_lookup() happening during t

Re: [Qemu-devel] [PATCH RFC 00/13] qemu: generate acpi tables for the guest

2013-05-13 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > This patchset moves all generation of ACPI tables > from guest BIOS to the hypervisor. > > Although ACPI tables come from a system BIOS on real hw, > it makes sense that the ACPI tables are coupled with the > virtual machine, since they have to abstract the x86 mach

Re: [Qemu-devel] [PATCH moxie] Fix bug in tlb_fill.

2013-05-13 Thread Max Filippov
On Tue, May 14, 2013 at 12:04 AM, Anthony Green wrote: > Fix a simple bug in tlb_fill for moxie. The port was mostly working > before, which is why I only really noticed it recently. Thanks to > @jcmvbkbc for tracking it down. > > Signed-off-by: Anthony Green > --- > target-moxie/helper.c | 2

[Qemu-devel] [PATCH for-1.5 2/2] qom: add casting statistics

2013-05-13 Thread Anthony Liguori
This is not meant to be applied but included as a reference. Signed-off-by: Anthony Liguori --- qom/object.c | 88 1 file changed, 88 insertions(+) diff --git a/qom/object.c b/qom/object.c index ec88231..2bfdcda 100644 --- a/qom/objec

[Qemu-devel] [PATCH for-1.5 1/2] qom: aggressively optimize qom casting

2013-05-13 Thread Anthony Liguori
This patch adds a small typename cache to ObjectClass. This allows caching positive casts within each ObjectClass. Benchmarking a PPC workload provided by Aurelien, this patch eliminates every single g_hash_table_lookup() happening during the benchmark (which was about 2 million per-second). Wit

Re: [Qemu-devel] [PATCH RFC 01/13] apic: rename apic specific bitopts

2013-05-13 Thread Michael S. Tsirkin
On Mon, May 13, 2013 at 09:22:20PM +0100, Peter Maydell wrote: > On 13 May 2013 21:00, Michael S. Tsirkin wrote: > > apic has its own version of bitops, with the > > difference that it works on u32 and not long. > > Add apic_ prefix to avoid namespace clashes. > > Wouldn't it be better to consoli

Re: [Qemu-devel] [PATCH RFC 12/13] i386: ACPI table generation code from seabios

2013-05-13 Thread Peter Maydell
On 13 May 2013 21:01, Michael S. Tsirkin wrote: > hw/i386/acpi-build.c | 685 > +++ I'm sitting here hoping nobody ever asks me to add ACPI support for ARM QEMU :-) [not totally impossible one day in the future...] -- PMM

[Qemu-devel] [PATCH RFC 00/13] qemu: generate acpi tables for the guest

2013-05-13 Thread Michael S. Tsirkin
This patchset moves all generation of ACPI tables from guest BIOS to the hypervisor. Although ACPI tables come from a system BIOS on real hw, it makes sense that the ACPI tables are coupled with the virtual machine, since they have to abstract the x86 machine to the OS's. Several future developme

Re: [Qemu-devel] [PATCH RFC 10/13] i386: generate pc guest info

2013-05-13 Thread Peter Maydell
On 13 May 2013 21:01, Michael S. Tsirkin wrote: > This fills in guest info table with misc > information of interest to the guest. > Will be used by ACPI table generation code. Bunch of coding style violations in this patch which will need fixing at some point in the RFC->patch process. thanks -

Re: [Qemu-devel] [PATCH RFC 01/13] apic: rename apic specific bitopts

2013-05-13 Thread Peter Maydell
On 13 May 2013 21:00, Michael S. Tsirkin wrote: > apic has its own version of bitops, with the > difference that it works on u32 and not long. > Add apic_ prefix to avoid namespace clashes. Wouldn't it be better to consolidate so we only have one set of bitops rather than a local set in this file

[Qemu-devel] [PATCH moxie] Fix bug in tlb_fill.

2013-05-13 Thread Anthony Green
Fix a simple bug in tlb_fill for moxie. The port was mostly working before, which is why I only really noticed it recently. Thanks to @jcmvbkbc for tracking it down. Signed-off-by: Anthony Green --- target-moxie/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/targe

Re: [Qemu-devel] [PATCH RFC 08/13] range: add Range structure

2013-05-13 Thread Peter Maydell
On 13 May 2013 21:01, Michael S. Tsirkin wrote: > Sometimes we need to pass ranges around, add a > handy structure for this purpose. > > Signed-off-by: Michael S. Tsirkin > --- > include/qemu/range.h | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/include/qemu/ra

[Qemu-devel] [PATCH v2] pci-assign: Add MSI affinity support

2013-05-13 Thread Alex Williamson
To support guest MSI affinity changes update the MSI message any time the guest writes to the address or data fields. Signed-off-by: Alex Williamson --- v2: Don't cache MSIMessage hw/i386/kvm/pci-assign.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/hw/i386/kvm/pci

[Qemu-devel] [PATCH v2] vfio-pci: Add support for MSI affinity

2013-05-13 Thread Alex Williamson
When MSI is accelerated through KVM the vectors are only programmed when the guest first enables MSI support.  Subsequent writes to the vector address or data fields are ignored.  Unfortunately that means wee ignore updates done to adjust SMP affinity of the vectors. MSI SMP affinity already works

Re: [Qemu-devel] [PATCH RFC 02/13] hw/i386/pc.c: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/apic.h

2013-05-13 Thread Eric Blake
On 05/13/2013 02:00 PM, Michael S. Tsirkin wrote: > Signed-off-by: Michael S. Tsirkin > Signed-off-by: Laszlo Ersek > Signed-off-by: Michael S. Tsirkin Looks odd to see your sign-off twice :) -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.or

[Qemu-devel] [PATCH RFC 12/13] i386: ACPI table generation code from seabios

2013-05-13 Thread Michael S. Tsirkin
This adds C code for generating ACPI tables at runtime, imported from seabios git tree commit 51684b7ced75fb76776e8ee84833fcfb6ecf12dd Although ACPI tables come from a system BIOS on real hw, it makes sense that the ACPI tables are coupled with the virtual machine, since they have to abstract

[Qemu-devel] [PATCH RFC 10/13] i386: generate pc guest info

2013-05-13 Thread Michael S. Tsirkin
This fills in guest info table with misc information of interest to the guest. Will be used by ACPI table generation code. Signed-off-by: Michael S. Tsirkin --- hw/acpi/ich9.c| 7 - hw/acpi/piix4.c | 44 +- hw/i386/Makefile.objs | 2 ++ hw/

[Qemu-devel] [PATCH RFC 11/13] pc: pass PCI hole ranges to Guests

2013-05-13 Thread Michael S. Tsirkin
Guest currently has to jump through lots of hoops to guess the PCI hole ranges. It's fragile, and makes us change BIOS each time we add a new chipset. Let's report the window in a ROM file, to make BIOS do exactly what QEMU intends. Signed-off-by: Michael S. Tsirkin --- hw/i386/pc.c | 21 +

[Qemu-devel] [PATCH RFC 09/13] i386: add bios linker/loader

2013-05-13 Thread Michael S. Tsirkin
This add a dynamic bios linker/loader. This will be used by acpi table generation code to: - load each table in the appropriate memory egment - link tables to each other - fix up checksums after said linking Signed-off-by: Michael S. Tsirkin --- hw/i386/Makefile.objs|

[Qemu-devel] [PATCH RFC 01/13] apic: rename apic specific bitopts

2013-05-13 Thread Michael S. Tsirkin
apic has its own version of bitops, with the difference that it works on u32 and not long. Add apic_ prefix to avoid namespace clashes. Signed-off-by: Michael S. Tsirkin --- hw/intc/apic.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --

[Qemu-devel] [PATCH RFC 13/13] pc: reuse guest info for legacy fw cfg

2013-05-13 Thread Michael S. Tsirkin
Reduce code duplication by getting legacy fw cfg data from guest info structure. Signed-off-by: Michael S. Tsirkin --- hw/i386/pc.c | 34 ++ 1 file changed, 14 insertions(+), 20 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index af414a4..41bfb5b 100644 -

[Qemu-devel] [PATCH RFC 02/13] hw/i386/pc.c: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/apic.h

2013-05-13 Thread Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin Signed-off-by: Laszlo Ersek Signed-off-by: Michael S. Tsirkin --- hw/i386/pc.c | 2 -- include/hw/i386/apic.h | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 197d218..f13dde5 100644 --- a/hw/i38

[Qemu-devel] [PATCH RFC 08/13] range: add Range structure

2013-05-13 Thread Michael S. Tsirkin
Sometimes we need to pass ranges around, add a handy structure for this purpose. Signed-off-by: Michael S. Tsirkin --- include/qemu/range.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/include/qemu/range.h b/include/qemu/range.h index 3502372..4bcd346 100644 --- a/

[Qemu-devel] [PATCH RFC 06/13] acpi: add rules to compile ASL source

2013-05-13 Thread Michael S. Tsirkin
Detect presence of IASL compiler and use it to process ASL source. If not there, use pre-compiled files in-tree. Add script to update the in-tree files. Signed-off-by: Michael S. Tsirkin --- configure | 9 - hw/i386/Makefile.objs | 22 ++ scripts/update

[Qemu-devel] [PATCH RFC 04/13] fw_cfg: move typedef to qemu/typedefs.h

2013-05-13 Thread Michael S. Tsirkin
Less header dependencies this way. Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 1 - include/hw/nvram/fw_cfg.h | 2 +- include/qemu/typedefs.h | 1 + 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index def52aa..1

[Qemu-devel] [PATCH RFC 03/13] refer to FWCfgState explicitly

2013-05-13 Thread Michael S. Tsirkin
From: Laszlo Ersek Subject: refer to FWCfgState explicitly Currently some places use pointer-to-void even though they mean pointer-to-FWCfgState. Clean them up. Signed-off-by: Laszlo Ersek Signed-off-by: Michael S. Tsirkin --- hw/acpi/piix4.c | 2 +- hw/core/loader.c | 2 +- hw/i38

Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

2013-05-13 Thread Richard Henderson
On 05/13/2013 06:33 AM, Claudio Fontana wrote: > +enum aarch64_cond_code { > +COND_EQ = 0x0, > +COND_NE = 0x1, > +COND_CS = 0x2, /* Unsigned greater or equal */ > +COND_HS = 0x2, /* ALIAS greater or equal */ Clearer to define aliases as COND_HS = COND_CS. > +static inline v

Re: [Qemu-devel] drive-mirror sync points

2013-05-13 Thread Paolo Bonzini
Il 13/05/2013 19:50, Wolfgang Richter ha scritto: > Paolo/anyone who knows - > > Are drive-mirror sync points (NBD flush commands) reflecting guest write > barriers? Are guest write barriers respected by drive-mirror? If so, > that would make drive-mirror much more palatable for disk introspecti

Re: [Qemu-devel] [PATCH v2] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS)

2013-05-13 Thread Paolo Bonzini
Il 13/05/2013 19:04, Jordan Justen ha scritto: > The isapc machine with seabios currently requires the BIOS region > to be read/write memory rather than read-only memory. > > KVM currently cannot support the BIOS as a ROM region, but qemu > in non-KVM mode can. Based on this, isapc machine current

Re: [Qemu-devel] [PATCH 2/3] include/elf.h: add aarch64 ELF machine and relocs

2013-05-13 Thread Peter Maydell
On 13 May 2013 14:31, Claudio Fontana wrote: > > we will use the 26bit relative relocations in the aarch64 tcg target. This patch looks OK, but can I ask you to just neaten up the #defines by making the column of values line up? (use spaces, not hardcoded tabs). > @@ -616,6 +618,132 @@ typedef s

Re: [Qemu-devel] [PATCH 1/3] configure: permit compilation on arm aarch64

2013-05-13 Thread Peter Maydell
On 13 May 2013 14:28, Claudio Fontana wrote: > > support compiling on aarch64. > > Signed-off-by: Claudio Fontana This looks good, but it should be the last patch in the series, so we don't allow the support to be enabled until the code that implements it is present. thanks -- PMM

Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

2013-05-13 Thread Peter Maydell
On 13 May 2013 14:33, Claudio Fontana wrote: > > add preliminary support for TCG target aarch64. Thanks for this patch. Some comments below. > Signed-off-by: Claudio Fontana > --- > include/exec/exec-all.h |5 +- > tcg/aarch64/tcg-target.c | 1084 > +++

[Qemu-devel] drive-mirror sync points

2013-05-13 Thread Wolfgang Richter
Paolo/anyone who knows - Are drive-mirror sync points (NBD flush commands) reflecting guest write barriers? Are guest write barriers respected by drive-mirror? If so, that would make drive-mirror much more palatable for disk introspection work (a drop-in usable feature of QEMU!). -- Wolf

[Qemu-devel] [PATCH v2] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS)

2013-05-13 Thread Jordan Justen
The isapc machine with seabios currently requires the BIOS region to be read/write memory rather than read-only memory. KVM currently cannot support the BIOS as a ROM region, but qemu in non-KVM mode can. Based on this, isapc machine currently only works with KVM. To work-around this isapc issue,

Re: [Qemu-devel] [PATCH V2] virtio: properly validate address before accessing config

2013-05-13 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.5 0/9] Disable expensive QOM cast debugging for official releases

2013-05-13 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for-1.5] Revert "pc: Kill the "use flash device for BIOS unless KVM" misfeature"

2013-05-13 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] ui/gtk.c: do not use gdk_display_warp_pointer when GTK ver >3.0

2013-05-13 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [GIT PULL for-1.5] Trivial patches for 2013-05-12

2013-05-13 Thread Anthony Liguori
Pulled. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PULL for-1.5] spice: bugfix queue

2013-05-13 Thread Anthony Liguori
Pulled. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] softfloat: rebase to version 2a

2013-05-13 Thread Peter Maydell
On 29 April 2013 19:05, Anthony Liguori wrote: > N.B. If you are on CC, see after the '---' for a requested action! > > The license of SoftFloat-2b is claimed to be GPLv2 incompatible by > the FSF due to an indemnification clause. The previous release, > SoftFloat-2a, did not contain this clause.

Re: [Qemu-devel] [PATCH] Fix usage of USB_DEV_FLAG_IS_HOST flag.

2013-05-13 Thread Gerd Hoffmann
On 05/13/13 01:19, Michael Marineau wrote: > USB_DEV_FLAG_IS_HOST is the bit number, not value. Booting with a > "Fitbit Base Station" USB dongle was triggering this assert. > > Signed-off-by: Michael Marineau > --- > hw/usb/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > dif

Re: [Qemu-devel] [PATCH v3 07/28] build-sys: must link with -fstack-protector

2013-05-13 Thread Laurent Desnogues
Hi, Another issue on my old distro. On Mon, Apr 22, 2013 at 5:04 PM, Alon Levy wrote: > From: Marc-André Lureau > > It is needed to give that flag to the linker as well, but latest > libtool 2.4.2 still swallows that argument, so let's pass it with > libtool -Wc argument. > > qemu-1.4.0/stubs/a

[Qemu-devel] [PATCH] target-mips: set carry bit correctly in DSPControl register

2013-05-13 Thread Petar Jovanovic
From: Petar Jovanovic First we need to clear the bit and then we set the given value. Instruction ADDSC sets the bit and instruction ADDWC uses this bit. Signed-off-by: Petar Jovanovic --- target-mips/dsp_helper.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ta

[Qemu-devel] [PATCH 2/2] qga: unlink just created guest-file if fchmod() or fdopen() fails on it

2013-05-13 Thread Michael Roth
From: Laszlo Ersek We shouldn't allow guest filesystem pollution on error paths. Suggested-by: Eric Blake Signed-off-by: Laszlo Ersek Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino Signed-off-by: Michael Roth --- qga/commands-posix.c |3 +++ 1 file changed, 3 insertions(+) diff

[Qemu-devel] [PATCH 1/2] qga: distinguish binary modes in "guest_file_open_modes" map

2013-05-13 Thread Michael Roth
From: Laszlo Ersek In Windows guests this may make a difference. Since the original patch (commit c689b4f1) sought to be pedantic and to consider theoretical corner cases of portability, we should fix it up where it failed to come through in that pursuit. Suggested-by: Eric Blake Reviewed-by:

  1   2   >