Re: [Qemu-devel] [RFC PATCH v4 01/15] util: introduce gsource event abstration

2013-04-18 Thread liu ping fan
On Thu, Apr 18, 2013 at 10:01 PM, Stefan Hajnoczi wrote: > On Wed, Apr 17, 2013 at 04:39:10PM +0800, Liu Ping Fan wrote: >> +static gboolean prepare(GSource *src, gint *time) >> +{ >> +EventGSource *nsrc = (EventGSource *)src; >> +int events = 0; >> + >> +if (!nsrc->readable && !nsrc->

Re: [Qemu-devel] [RFC PATCH v4 15/15] slirp: use lock to protect the slirp_instances

2013-04-18 Thread liu ping fan
On Thu, Apr 18, 2013 at 10:16 PM, Paolo Bonzini wrote: > >> grep'ing for slirp_instances points to more spots that work with that >> list (QTAILQ_FOREACH, QTAILQ_EMPTY, ...). So the same question here: >> What are the usage rules? When do I _not_ need it when touching the list >> of instances, and

Re: [Qemu-devel] [RFC PATCH v4 06/15] net: port socket to GSource

2013-04-18 Thread liu ping fan
On Thu, Apr 18, 2013 at 10:34 PM, Stefan Hajnoczi wrote: > On Wed, Apr 17, 2013 at 04:39:15PM +0800, Liu Ping Fan wrote: >> @@ -160,7 +154,13 @@ static void net_socket_send(void *opaque) >> net_socket_read_poll(s, false); >> net_socket_write_poll(s, false); >> if (s->lis

Re: [Qemu-devel] [RFC PATCH v4 04/15] net: resolve race of tap backend and its peer

2013-04-18 Thread liu ping fan
On Thu, Apr 18, 2013 at 10:11 PM, Stefan Hajnoczi wrote: > On Wed, Apr 17, 2013 at 04:39:13PM +0800, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> When vhost net enabled, we should be sure that the user space >> fd handler is not in flight >> >> Signed-off-by: Liu Ping Fan >> --- >> net/tap.c

Re: [Qemu-devel] qemu exit because of signal 11

2013-04-18 Thread Michael Tokarev
19.04.2013 06:38, yue-kvm wrote: > hi,all > every time i remote connect my guest , ehich will be kill by signal 11. > > my environment centos6.3. Please ask redhat support for this. Their qemu and kernel are based on outdated versions but heavily patched, so it isn't realistically possible to s

[Qemu-devel] [RFC PATCH] qapi: introduce strList and visit_type_strList() (was Re: [qapi] Cannot use list of strings)

2013-04-18 Thread Amos Kong
On Wed, Apr 17, 2013 at 04:33:03PM +0800, Amos Kong wrote: > On Tue, Apr 16, 2013 at 09:50:17AM -0500, mdroth wrote: > > On Tue, Apr 16, 2013 at 10:49:19AM +0200, Stefan Hajnoczi wrote: > > > On Mon, Apr 15, 2013 at 10:04:24PM +0200, Lluís Vilanova wrote: > > > > Tried using a list of strings as an

[Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time

2013-04-18 Thread Amos Kong
(qemu) sendkey a 1000 Current design is that qemu only send one down event to guest, and delay sometime, then send one up event. In this case, only key can be identified by guest. This patch changed qemu to intervally send down events to guest in the hold time, the interval is 100ms. (qemu) send

Re: [Qemu-devel] block/ssh: Compilation fails on Debian squeeze

2013-04-18 Thread Stefan Weil
Am 18.04.2013 23:08, schrieb Richard W.M. Jones: > On Thu, Apr 18, 2013 at 10:42:09PM +0200, Stefan Weil wrote: >> The test fails on current Debian (squeeze), not because of wrong >> format specifiers, but because of an "old" libssh2-1-dev. >> >> ssh.c calls libssh2_session_handshake which was adde

Re: [Qemu-devel] [PATCH] ssh: Remove unnecessary use of strlen function.

2013-04-18 Thread Stefan Weil
Am 18.04.2013 23:09, schrieb Richard W.M. Jones: > From: "Richard W.M. Jones" > > --- > block/ssh.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/block/ssh.c b/block/ssh.c > index 8f78e2e..7bc008d 100644 > --- a/block/ssh.c > +++ b/block/ssh.c > @@ -387,15 +387,13

[Qemu-devel] [PATCH 5/5] vmdk: add bdrv_co_write_zeroes

2013-04-18 Thread Fam Zheng
From: Feiran Zheng Use special offset to write zeroes efficiently, when zeroed-grain GTE is available. If zero-write an allocated cluster, cluster is leaked because its offset pointer is overwritten by "0x1". Signed-off-by: Fam Zheng --- block/vmdk.c | 63 ++

[Qemu-devel] [PATCH 2/5] vmdk: add support for “zeroed‐grain” GTE

2013-04-18 Thread Fam Zheng
From: Feiran Zheng Introduced support for zeroed-grain GTE, as specified in Virtual Disk Format 5.0[1]. Recent VMware hosted platform products support a new “zeroed‐grain” grain table entry (GTE). The zeroed‐grain GTE returns all zeros on read. In other words, the zeroed‐grain GTE i

[Qemu-devel] [PATCH 4/5] vmdk: change magic number to macro

2013-04-18 Thread Fam Zheng
From: Feiran Zheng Two hard coded flag bits are changed to macros. Signed-off-by: Fam Zheng --- block/vmdk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/vmdk.c b/block/vmdk.c index 827b35b..5daa9f2 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -32,6 +32,7 @@

[Qemu-devel] [PATCH 1/5] vmdk: named return code.

2013-04-18 Thread Fam Zheng
From: Feiran Zheng Internal routines in vmdk.c previously return -1 on error and 0 on success. More return values are useful for future changes such as zeroed-grain GTE. Change all the magic `return 0` and `return -1` to macro names: * VMDK_OK 0 * VMDK_ERROR (-1) * VMDK_UNALLOC (-2) *

[Qemu-devel] [PATCH 3/5] vmdk: Add option to create zeroed-grain image

2013-04-18 Thread Fam Zheng
From: Feiran Zheng Add image create option "zeroed-grain" to enable zeroed-grain GTE feature of vmdk sparse extents. When this option is on, header version of newly created extent will be 2 and VMDK4_FLAG_ZG flag bit will be set. Signed-off-by: Fam Zheng --- block/vmdk.c | 20

[Qemu-devel] [PATCH 0/5] vmdk: zeroed-grain GTE support

2013-04-18 Thread Fam Zheng
Added support for zeroed-grain GTE to VMDK according to VMDK Spec 5.0[1]. [1] Virtual Disk Format 5.0 - VMware, http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf?src=vmdk Feiran Zheng (5): vmdk: named return code. vmdk: add support for “zeroed‐grain” GTE vmdk: Add optio

[Qemu-devel] [PATCH 0/5] vmdk: zeroed-grain GTE support

2013-04-18 Thread Fam Zheng
Added support for zeroed-grain GTE to VMDK according to VMDK Spec 5.0[1]. [1] Virtual Disk Format 5.0 - VMware, http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf?src=vmdk Feiran Zheng (5): vmdk: named return code. vmdk: add support for “zeroed‐grain” GTE vmdk: Add option

Re: [Qemu-devel] [PATCH v2 17/23] instrument: Add commandline options to start with an instrumentation library

2013-04-18 Thread Eric Blake
On 04/16/2013 07:51 AM, Lluís Vilanova wrote: > Add commandline options to control initial loading of dynamic instrumentation > library. > > Signed-off-by: Lluís Vilanova > --- > @@ -688,6 +690,15 @@ static void usage(void) > #endif > "-bsd type select emulated BSD type > F

Re: [Qemu-devel] [PATCH v2 15/23] instrument: [qmp, qapi] Add control interface

2013-04-18 Thread Eric Blake
On 04/16/2013 07:51 AM, Lluís Vilanova wrote: > Add QMP commands to control (un)loading of dynamic instrumentation library. > > Signed-off-by: Lluís Vilanova > --- > include/qapi/qmp/qerror.h |9 + > instrument/Makefile.objs|1 + > instrument/qapi-schema.json | 33 +++

[Qemu-devel] [PATCH 6/6] target-i386/seg_helper: define names for code/data segment types

2013-04-18 Thread liguang
Signed-off-by: liguang --- target-i386/seg_helper.c | 71 + 1 files changed, 52 insertions(+), 19 deletions(-) diff --git a/target-i386/seg_helper.c b/target-i386/seg_helper.c index 635c5ab..aed5499 100644 --- a/target-i386/seg_helper.c +++ b/target-

[Qemu-devel] [PATCH 5/6] target-i386/seg_helper: refactor 4 helper functions

2013-04-18 Thread liguang
for helper_{lsl, lar, verr, verw}, there are common parts, so move them outside, and then call this new helper-helper function. Signed-off-by: liguang --- target-i386/seg_helper.c | 179 ++--- 1 files changed, 56 insertions(+), 123 deletions(-) diff --gi

[Qemu-devel] [PATCH 4/6] target-i386/svm_helper: remove redundant assignment

2013-04-18 Thread liguang
Signed-off-by: liguang --- target-i386/svm_helper.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/target-i386/svm_helper.c b/target-i386/svm_helper.c index f9ffd18..393b126 100644 --- a/target-i386/svm_helper.c +++ b/target-i386/svm_helper.c @@ -249,7 +249,6 @@ void hel

[Qemu-devel] [PATCH 1/6] target-i386/seg_helper: replace env->eip with EIP

2013-04-18 Thread liguang
Signed-off-by: liguang --- target-i386/seg_helper.c | 46 +++--- 1 files changed, 23 insertions(+), 23 deletions(-) diff --git a/target-i386/seg_helper.c b/target-i386/seg_helper.c index 906e4f3..5f7f99d 100644 --- a/target-i386/seg_helper.c +++ b/target

[Qemu-devel] [PATCH 2/6] target-i386/smm_helper: replace env->eip with EIP

2013-04-18 Thread liguang
Signed-off-by: liguang --- target-i386/smm_helper.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target-i386/smm_helper.c b/target-i386/smm_helper.c index eea2fe9..ba79075 100644 --- a/target-i386/smm_helper.c +++ b/target-i386/smm_helper.c @@ -93,7 +93,7 @@ v

[Qemu-devel] [PATCH 3/6] target-i386/svm_helper: replace env->eip with EIP

2013-04-18 Thread liguang
Signed-off-by: liguang --- target-i386/svm_helper.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target-i386/svm_helper.c b/target-i386/svm_helper.c index c46a213..f9ffd18 100644 --- a/target-i386/svm_helper.c +++ b/target-i386/svm_helper.c @@ -249,7 +249,7 @@ voi

[Qemu-devel] [PATCH 0/6] target-i386:do some cleanups

2013-04-18 Thread liguang
here are some cleanups Li Guang (6) target-i386/seg_helper: replace env->eip with EIP target-i386/smm_helper: replace env->eip with EIP target-i386/svm_helper: replace env->eip with EIP target-i386/svm_helper: remove redundant assignment target-i386/seg

Re: [Qemu-devel] [PATCH v2 13/23] qapi: Add a primitive to include other files from a QAPI schema file

2013-04-18 Thread Eric Blake
On 04/16/2013 07:51 AM, Lluís Vilanova wrote: > Adds the "input(...)" primitive to the syntax of QAPI schema files. Interesting idea, but isn't "include(...)" a more common name than "input(...)"? -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.

[Qemu-devel] qemu exit because of signal 11

2013-04-18 Thread yue-kvm
hi,all every time i remote connect my guest , ehich will be kill by signal 11. my environment centos6.3. audit.log type=ANOM_ABEND msg=audit(1366249929.447:14213): auid=0 uid=107 gid=107 ses=533 subj=system_u:system_r:svirt_t:s0:c898,c1007 pid=49526 comm="qemu-kvm" sig=11 thanks

[Qemu-devel] [PATCH] m25p80: Remove bogus include of devices.h

2013-04-18 Thread peter . crosthwaite
From: Peter Crosthwaite I think in the early revisions of this we had an instantiation helper for the device in devices.h. This was later removed and this header was left over. Removed Signed-off-by: Peter Crosthwaite --- hw/block/m25p80.c |1 - 1 files changed, 0 insertions(+), 1 deletion

[Qemu-devel] [PATCH for-1.5 v2 15/15] xilinx_spips: lqspi: Fix byte/misaligned access

2013-04-18 Thread peter . crosthwaite
From: Peter Crosthwaite The LQSPI bus attachment supports byte/halfword and misaligned accesses. Fixed. Refactored the LQSPI cache to be byte-wise instead of word wise accordingly. Signed-off-by: Peter Crosthwaite --- hw/ssi/xilinx_spips.c | 31 +-- 1 files chang

[Qemu-devel] [PATCH for-1.5 v2 14/15] xilinx_spips: lqspi: Push more data to tx-fifo

2013-04-18 Thread peter . crosthwaite
From: Peter Crosthwaite Do 16 words per fifo flush. Increases performance and decreases debug verbosity. This data depth has no real hardware analogue, so just go with something that has reasonable performance. Signed-off-by: Peter Crosthwaite --- hw/ssi/xilinx_spips.c | 11 +++ 1 f

[Qemu-devel] [PATCH for-1.5 v2 13/15] xilinx_spips: Multiple debug verbosity levels

2013-04-18 Thread peter . crosthwaite
From: Peter Crosthwaite The debug printfs on every SPI operation is extremely verbose. Add a second level of debug for this. Signed-off-by: Peter Crosthwaite --- hw/ssi/xilinx_spips.c | 68 +--- 1 files changed, 41 insertions(+), 27 deletions(-)

[Qemu-devel] [PATCH for-1.5 v2 12/15] xilinx_spips: Debug msgs for Snoop state

2013-04-18 Thread peter . crosthwaite
From: Peter Crosthwaite This is worth keeping track of when debugging the device model. Signed-off-by: Peter Crosthwaite --- hw/ssi/xilinx_spips.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index 43e4df1..fec22ef 10

[Qemu-devel] [PATCH for-1.5 v2 11/15] xilinx_spips: Fix striping behaviour

2013-04-18 Thread peter . crosthwaite
From: Peter Crosthwaite The QSPI controller was using byte-wide stripes when striping across the two flashes in dual parallel mode. The real hardware however uses individual bit striping. QEMU misbehaves in the (corner) case where data is written/read in dual-parallel mode and read/written back i

[Qemu-devel] [PATCH for-1.5 v2 10/15] xilinx_spips: Fix CTRL register RW bits

2013-04-18 Thread peter . crosthwaite
From: Peter Crosthwaite The CTRL register was RAZ/WI on some of the RW bits. Even though the function behind these bits is invalid in QEMU, they should still be guest accessible. Fix. Signed-off-by: Peter Crosthwaite --- changed from v1 Macroified magic number (PMM review) hw/ssi/xilinx_spips

[Qemu-devel] [PATCH for-1.5 v2 09/15] xilinx_spips: lqspi: Dont touch config register

2013-04-18 Thread peter . crosthwaite
From: Peter Crosthwaite The LQSPI mode is supposed to work via the automatic CS mode feature rather than manipulate CS lines itself. Now that auto CS is implemented remove LQSPIs CS mode override logic. There is still a need to manipulate the U_PAGE bit in LQSPI config register to implement dual-

[Qemu-devel] [PATCH for-1.5 v2 08/15] xilinx_spips: Implement automatic CS

2013-04-18 Thread peter . crosthwaite
From: Peter Crosthwaite Implement the automatic CS control feature. If the MANUAL_CS bit is cleared then the chip select stay de-asserted as long as the tx FIFO is empty. Signed-off-by: Peter Crosthwaite --- changed from v1: Refresh CS on entry and exit from flush routine as needed. hw/ssi/xi

[Qemu-devel] [PATCH for-1.5 v2 07/15] xilinx_spips: Add automatic start support

2013-04-18 Thread peter . crosthwaite
From: Peter Crosthwaite SPI has a mode where it automatically starts based on tx fifo occupancy. Implemented. Signed-off-by: Peter Crosthwaite --- hw/ssi/xilinx_spips.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c ind

[Qemu-devel] [PATCH for-1.5 v2 06/15] xilinx_spips: Trash LQ page cache on mode change

2013-04-18 Thread peter . crosthwaite
From: Peter Crosthwaite Invalidate the LQSPI cached page when transitioning into LQSPI mode. Otherwise there is a possibility that the controller will return stale data to the guest when transitioning back to LQ_MODE after a page program. Signed-off-by: Peter Crosthwaite --- changed from v1: Re

[Qemu-devel] [PATCH for-1.5 v2 05/15] xilinx_spips: Fix QSPI FIFO size

2013-04-18 Thread peter . crosthwaite
From: Peter Crosthwaite QSPI has a bigger FIFO than the regular SPI controller. Differentiate between the two with correct FIFO sizes for each. This is the first piece of class data for SPIPS, so this patch sees the creation of the XilinxSPIPSClass definition and assoicated QOM constructs. Sign

[Qemu-devel] [PATCH for-1.5 v2 04/15] xilinx_spips: Add verbose LQSPI debug output

2013-04-18 Thread peter . crosthwaite
From: Peter Crosthwaite You really need this is you want to track a guest banging on LQSPI. Signed-off-by: Peter Crosthwaite --- hw/ssi/xilinx_spips.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index a8691d5..2963

[Qemu-devel] [PATCH for-1.5 v2 03/15] xilinx_spips: Inhibit interrupts in LQSPI mode

2013-04-18 Thread peter . crosthwaite
From: Peter Crosthwaite The real hardware does not produce interrupts in LQSPI mode. Inhibit generation of interrupts when the LQ_MODE bit is set. Signed-off-by: Peter Crosthwaite --- hw/ssi/xilinx_spips.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/hw/ssi/x

[Qemu-devel] [PATCH for-1.5 v2 02/15] xilinx_spips: Make interrupts clear on read

2013-04-18 Thread peter . crosthwaite
From: Peter Crosthwaite By default these interrupts are clear on read. Signed-off-by: Peter Crosthwaite --- hw/ssi/xilinx_spips.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index 734adf0..261d948 100644 --- a/hw/ss

[Qemu-devel] [PATCH for-1.5 v2 01/15] xilinx_spips: seperate SPI and QSPI as two classes

2013-04-18 Thread peter . crosthwaite
From: Peter Crosthwaite Make SPI and QSPI different classes. QSPIPS is setup as a child of SPIPS. Only QSPI has the LQSPI functionality, so move all that to the child class. Signed-off-by: Peter Crosthwaite --- Changed from v2: User parent_obj as appropriate for QOM parents (PMM review) Changed

[Qemu-devel] [PATCH for-1.5 v2 00/15] Xilinx SPIPS fixes round 2

2013-04-18 Thread peter . crosthwaite
From: Peter Crosthwaite Updates to the Zynq SPI controller. Some QOMifying cleanup, followed by a number of bugs/incompletnesses found by some (very) rigourous test vectors. Peter Crosthwaite (15): xilinx_spips: seperate SPI and QSPI as two classes xilinx_spips: Make interrupts clear on rea

Re: [Qemu-devel] KVM VM(windows xp) reseted when running geekbench for about 2 days

2013-04-18 Thread Zhanghaoyu (A)
>> On Thu, Apr 18, 2013 at 12:00:49PM +, Zhanghaoyu (A) wrote: >>> I start 10 VMs(windows xp), then running geekbench tool on them, >>> about 2 days, one of them was reset, I found the reset operation is >>> done by int kvm_cpu_exec(CPUArchState *env) { >>>... >>> switch (run->exit_

[Qemu-devel] [PATCH V3 4/5] block: package rollback code in qmp_transaction()

2013-04-18 Thread Wenchao Xia
Signed-off-by: Wenchao Xia --- blockdev.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 275c6f9..051be98 100644 --- a/blockdev.c +++ b/blockdev.c @@ -882,6 +882,13 @@ static void external_snapshot_commit(BlkTransactionStates *sta

[Qemu-devel] [PATCH V3 5/5] block: make all steps in qmp_transaction() as callback

2013-04-18 Thread Wenchao Xia
Make it easier to add other operations to qmp_transaction() by using callbacks, with external snapshots serving as an example implementation of the callbacks. Signed-off-by: Wenchao Xia --- blockdev.c | 84 +++ 1 files changed, 67 inserti

[Qemu-devel] [PATCH V3 3/5] block: package committing code in qmp_transaction()

2013-04-18 Thread Wenchao Xia
The code is simply moved into a separate function. Signed-off-by: Wenchao Xia --- blockdev.c | 19 --- 1 files changed, 12 insertions(+), 7 deletions(-) diff --git a/blockdev.c b/blockdev.c index 89521bb..275c6f9 100644 --- a/blockdev.c +++ b/blockdev.c @@ -871,6 +871,17 @@ st

[Qemu-devel] [PATCH V3 1/5] block: package preparation code in qmp_transaction()

2013-04-18 Thread Wenchao Xia
The code before really committing is moved into a function. Most code are simply moved from qmp_transaction(), except that on fail it just return now. Other code such as input parsing is not touched, to make it easier in review. Signed-off-by: Wenchao Xia --- blockdev.c | 139 ++

[Qemu-devel] [PATCH V3 2/5] block: move input parsing code in qmp_transaction()

2013-04-18 Thread Wenchao Xia
The code is moved into preparation function, and changed a bit to tip more clearly what it is doing. Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake --- blockdev.c | 38 +++--- 1 files changed, 19 insertions(+), 19 deletions(-) diff --git a/blockdev.c b/blo

[Qemu-devel] [PATCH V3 0/5] block: make qmp_transaction extendable

2013-04-18 Thread Wenchao Xia
This serial will package backing chain snapshot code as one case, to make it possible adding more operations later. v2: Address Kevin's comments: Use the same prototype prepare, commit, rollback model in original code, commit should never fail. v3: Address Stefan's comments: 3/5, 4/5: re

Re: [Qemu-devel] [PULL v4 11/11] rdma: add documentation

2013-04-18 Thread Michael R. Hines
I'm very sorry. I totally missed this email. My apologies. On 04/18/2013 02:55 AM, Michael S. Tsirkin wrote: On Wed, Apr 17, 2013 at 07:07:20PM -0400, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" docs/rdma.txt contains full documentation, wiki links, github url and contact info

[Qemu-devel] [PATCH] PPC: Fix compile with profiling enabled

2013-04-18 Thread Alexander Graf
When using profiling, we rely on profile_getclock() being available at our disposal. Somehow that function got moved from an indirect include we used to have in translate-init.c, so that we were now left not properly compiling anymore. Add an explicit include to timer.h which defines profile_getcl

Re: [Qemu-devel] licensing of IBM contributions to QEMU (was Re: [PULL v4 08/11] rdma: core logic)

2013-04-18 Thread Anthony Liguori
Paolo Bonzini writes: >> > >>>I'm guessing you need approval from Jiuxing Liu for this, >> > >>>pls make him ack license change. >> > >>He approves. He doesn't work for IBM anymore. >> > >Does he approve version 2 or version 2 or later? >> > > >> > >> > It doesn't matter - his contributions were

Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

2013-04-18 Thread Michael R. Hines
On 04/18/2013 06:12 PM, Eric Blake wrote: On 04/17/2013 05:07 PM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" Code that does need to be visible is kept well contained inside this file and this is the only new additional file to the entire patch - good progress. This file includ

Re: [Qemu-devel] [PULL v4 07/11] rdma: introduce capability for chunk registration

2013-04-18 Thread Michael R. Hines
On 04/18/2013 06:07 PM, Eric Blake wrote: On 04/17/2013 05:07 PM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" This capability allows you to disable dynamic chunk registration for better throughput on high-performance links. It is enabled by default. Signed-off-by: Michael R. H

Re: [Qemu-devel] [PATCH 11/11] savevm: remove backward compatibility from bdrv_snapshot_find()

2013-04-18 Thread Wenchao Xia
于 2013-4-18 18:22, Pavel Hrdina 写道: On 18.4.2013 06:31, Wenchao Xia wrote: 于 2013-4-18 2:14, Eric Blake 写道: On 04/17/2013 04:51 AM, Pavel Hrdina wrote: On 17.4.2013 12:19, Wenchao Xia wrote: 于 2013-4-17 15:52, Pavel Hrdina 写道: Hi Wenchao, unfortunately no. According to new design of savevm,

Re: [Qemu-devel] [PATCH 07/16] cpu: introduce get_arch_id() method and override it for target-i386

2013-04-18 Thread li guang
在 2013-04-16二的 00:12 +0200,Igor Mammedov写道: > get_arch_id() adds possibility for generic code to get guest visible > CPU ID without accessing CPUArchState. If target doesn't override it, > it will return cpu_index. > > Override it on target-i386 to return APIC ID. > > Signed-off-by: Igor Mammedov

Re: [Qemu-devel] [RFC PATCH v4 14/15] slirp: handle race condition

2013-04-18 Thread liu ping fan
On Thu, Apr 18, 2013 at 3:13 PM, Jan Kiszka wrote: > On 2013-04-17 10:39, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> Slirp and its peer can run on different context at the same time. >> Using lock to protect > > What are the usage rules for this lock, what precisely is it protecting? > Is it

Re: [Qemu-devel] xen-unstable qemu-upstream: libxl: error: libxl_qmp.c:440:qmp_next: timeout, libxl_qmp.c:705:libxl__qmp_initialize: Failed to connect to QMP

2013-04-18 Thread Sander Eikelenboom
Thursday, April 18, 2013, 3:32:37 PM, you wrote: > Il 18/04/2013 15:27, Stefano Stabellini ha scritto: >>> > >>> > Any thing that springs to mind ? >> Nope, sorry. >> Given the commit that your bisection identified and the error message, >> it's clear that it's a QMP connection issue from libxl

Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

2013-04-18 Thread Eric Blake
On 04/17/2013 05:07 PM, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > Code that does need to be visible is kept > well contained inside this file and this is the only > new additional file to the entire patch - good > progress. > > This file includes the entire protocol and in

[Qemu-devel] [PATCH] Add i.MX25 3DS evaluation board support

2013-04-18 Thread Jean-Christophe DUBOIS
This is an initial port of the Freescale i.MX25 processor. This allow a minimally configured linux kernel to boot on Qemu. Signed-off-by: Jean-Christophe DUBOIS --- hw/arm/Makefile.objs |1 + hw/arm/imx25_3ds.c | 199 ++ 2 files changed, 20

Re: [Qemu-devel] [PULL v4 07/11] rdma: introduce capability for chunk registration

2013-04-18 Thread Eric Blake
On 04/17/2013 05:07 PM, mrhi...@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" > > This capability allows you to disable dynamic chunk registration > for better throughput on high-performance links. > > It is enabled by default. > > Signed-off-by: Michael R. Hines > --- > migration.c

Re: [Qemu-devel] [PULL v4 00/11] rdma: migration support

2013-04-18 Thread Michael S. Tsirkin
On Thu, Apr 18, 2013 at 05:28:14PM -0400, Michael R. Hines wrote: > On 04/18/2013 04:12 PM, Michael S. Tsirkin wrote: > >On Thu, Apr 18, 2013 at 03:17:39PM -0400, Michael R. Hines wrote: > >>On 04/18/2013 09:50 AM, Michael S. Tsirkin wrote: > >>>On Thu, Apr 18, 2013 at 09:49:37AM -0400, Michael R.

Re: [Qemu-devel] [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients

2013-04-18 Thread Michael S. Tsirkin
On Thu, Apr 18, 2013 at 10:22:24PM +0200, Laszlo Ersek wrote: > This patch reuses some code from SeaBIOS, which was originally under > LGPLv2 and then relicensed to GPLv3 or LGPLv3, in QEMU under GPLv2+. This > relicensing has been acked by all contributors that had contributed to the > code since

Re: [Qemu-devel] [PULL v4 00/11] rdma: migration support

2013-04-18 Thread Michael R. Hines
On 04/18/2013 04:12 PM, Michael S. Tsirkin wrote: On Thu, Apr 18, 2013 at 03:17:39PM -0400, Michael R. Hines wrote: On 04/18/2013 09:50 AM, Michael S. Tsirkin wrote: On Thu, Apr 18, 2013 at 09:49:37AM -0400, Michael R. Hines wrote: On 04/18/2013 03:00 AM, Michael S. Tsirkin wrote: On Wed, Apr

Re: [Qemu-devel] [PATCH] ssh: Remove unnecessary use of strlen function.

2013-04-18 Thread Eric Blake
On 04/18/2013 03:09 PM, Richard W.M. Jones wrote: > From: "Richard W.M. Jones" > > --- > block/ssh.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvirt virtualization library http://libvirt.org

Re: [Qemu-devel] [PULL v4 00/11] rdma: migration support

2013-04-18 Thread Michael S. Tsirkin
On Thu, Apr 18, 2013 at 03:17:39PM -0400, Michael R. Hines wrote: > On 04/18/2013 09:50 AM, Michael S. Tsirkin wrote: > >On Thu, Apr 18, 2013 at 09:49:37AM -0400, Michael R. Hines wrote: > >>On 04/18/2013 03:00 AM, Michael S. Tsirkin wrote: > >>>On Wed, Apr 17, 2013 at 07:07:09PM -0400, mrhi...@lin

[Qemu-devel] [PATCH] ssh: Remove unnecessary use of strlen function.

2013-04-18 Thread Richard W.M. Jones
From: "Richard W.M. Jones" --- block/ssh.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index 8f78e2e..7bc008d 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -387,15 +387,13 @@ static int check_host_key(BDRVSSHState *s, const char *host, int

Re: [Qemu-devel] block/ssh: Compilation fails on Debian squeeze

2013-04-18 Thread Richard W.M. Jones
On Thu, Apr 18, 2013 at 10:42:09PM +0200, Stefan Weil wrote: > Am 18.04.2013 22:21, schrieb Stefan Weil: > > Now gcc will check whether format string and variable arguments match. > > > > Signed-off-by: Stefan Weil > > --- > > > > Please note: I could only run limited tests with the new code > > b

Re: [Qemu-devel] [PATCH] block/ssh: Add missing gcc format attributes

2013-04-18 Thread Richard W.M. Jones
On Thu, Apr 18, 2013 at 10:21:05PM +0200, Stefan Weil wrote: > Now gcc will check whether format string and variable arguments match. > > Signed-off-by: Stefan Weil ACK, this looks fine to me. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is '

[Qemu-devel] block/ssh: Compilation fails on Debian squeeze

2013-04-18 Thread Stefan Weil
Am 18.04.2013 22:21, schrieb Stefan Weil: > Now gcc will check whether format string and variable arguments match. > > Signed-off-by: Stefan Weil > --- > > Please note: I could only run limited tests with the new code > because ssh.c is currently not compiled in my w32/w64 environment. > > Regards

[Qemu-devel] [PATCH] block/ssh: Add missing gcc format attributes

2013-04-18 Thread Stefan Weil
Now gcc will check whether format string and variable arguments match. Signed-off-by: Stefan Weil --- Please note: I could only run limited tests with the new code because ssh.c is currently not compiled in my w32/w64 environment. Regards, Stefan W. block/ssh.c |4 ++-- 1 file changed, 2

[Qemu-devel] [PATCH v4 6/7] hw/i386/pc.c: move IO_APIC_DEFAULT_ADDRESS to include/hw/i386/apic.h

2013-04-18 Thread Laszlo Ersek
From: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin Signed-off-by: Laszlo Ersek Acked-by: Michael S. Tsirkin --- include/hw/i386/apic.h |2 ++ hw/i386/pc.c |2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/hw/i386/apic.h b/include/hw/i386/

[Qemu-devel] [PATCH v4 7/7] hw/i386: build ACPI MADT (APIC) for fw_cfg clients

2013-04-18 Thread Laszlo Ersek
This patch reuses some code from SeaBIOS, which was originally under LGPLv2 and then relicensed to GPLv3 or LGPLv3, in QEMU under GPLv2+. This relicensing has been acked by all contributors that had contributed to the code since the v2->v3 relicense. ACKs approving the v2+ relicensing are listed be

[Qemu-devel] [PATCH v4 5/7] hw/acpi: export acpi_checksum()

2013-04-18 Thread Laszlo Ersek
Again, this enables reuse when preparing per-table fw_cfg blobs later. Signed-off-by: Laszlo Ersek Acked-by: Michael S. Tsirkin --- include/hw/acpi/acpi.h |2 ++ hw/acpi/core.c |2 +- 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/include/hw/acpi/acpi.h b/include

[Qemu-devel] [PATCH v4 1/7] refer to FWCfgState explicitly

2013-04-18 Thread Laszlo Ersek
Currently some places use pointer-to-void even though they mean pointer-to-FWCfgState. Clean them up. Signed-off-by: Laszlo Ersek Acked-by: Michael S. Tsirkin --- hw/i386/multiboot.h |4 +++- include/hw/i386/pc.h | 19 ++- include/hw/loader.h |3 ++- hw/acpi/piix4.c

[Qemu-devel] [PATCH v4 4/7] hw/acpi: export default ACPI headers using the type just introduced

2013-04-18 Thread Laszlo Ersek
This enables reuse when preparing per-table fw_cfg blobs later. Signed-off-by: Laszlo Ersek Acked-by: Michael S. Tsirkin --- include/hw/acpi/acpi.h |2 ++ hw/acpi/core.c | 39 --- 2 files changed, 26 insertions(+), 15 deletions(-) diff --git a/

[Qemu-devel] [PATCH v4 3/7] hw/acpi: extract standard table headers as a standalone structure

2013-04-18 Thread Laszlo Ersek
This enables reuse when preparing per-table fw_cfg blobs later. Signed-off-by: Laszlo Ersek Acked-by: Michael S. Tsirkin --- include/hw/acpi/acpi.h | 11 +++ hw/acpi/core.c | 48 +--- 2 files changed, 32 insertions(+), 27 deletions

[Qemu-devel] [PATCH v4 2/7] acpi_table_install(): fix funcparam formatting in leading comment

2013-04-18 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek Acked-by: Michael S. Tsirkin --- hw/acpi/core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index 64b8718..69cadb0 100644 --- a/hw/acpi/core.c +++ b/hw/acpi/core.c @@ -86,7 +86,7 @@ static int acpi_checksum

[Qemu-devel] [PATCH v4 0/7] publish etc/acpi/APIC in fw_cfg

2013-04-18 Thread Laszlo Ersek
v4: - patches 1-6 are unchanged and carry Michael's ACK, - patch 7 is rendered dependent on a new configure switch (default off) [Michael Tsirkin]. v3: - rebased to current master 24a6e7f4, - added Michael's S-o-b to 6/7 [Eric Blake], - added Dave Frodin's relicensing ACK to 7/7, originally sent

Re: [Qemu-devel] [PATCH v3 00/13] TARGET_*_ALIGNMENT cleanup, and config-target.mak trimming

2013-04-18 Thread Paolo Bonzini
Il 18/04/2013 16:58, Riku Voipio ha scritto: >> > target_short/int/llong and the corresponding unsigned types are renamed >> > to abi_short/int/llong, and TARGET_*_ALIGNMENT is similarly renamed to >> > ABI_*_ALIGNMENT. target_long/ulong, which identify the register width >> > in the CPU, do not h

Re: [Qemu-devel] [PULL v4 08/11] rdma: core logic

2013-04-18 Thread Michael R. Hines
On 04/18/2013 11:51 AM, Orit Wasserman wrote: On 04/18/2013 04:54 PM, Michael R. Hines wrote: On 04/18/2013 04:44 AM, Orit Wasserman wrote: Hi Michael, I don't see you addressed any of the comment I had in v3 (especially the error handling) please, fix those I did fix them, but not all of yo

Re: [Qemu-devel] [PULL v4 00/11] rdma: migration support

2013-04-18 Thread Michael R. Hines
On 04/18/2013 09:50 AM, Michael S. Tsirkin wrote: On Thu, Apr 18, 2013 at 09:49:37AM -0400, Michael R. Hines wrote: On 04/18/2013 03:00 AM, Michael S. Tsirkin wrote: On Wed, Apr 17, 2013 at 07:07:09PM -0400, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" The following changes sin

Re: [Qemu-devel] licensing of IBM contributions to QEMU (was Re: [PULL v4 08/11] rdma: core logic)

2013-04-18 Thread Michael R. Hines
On 04/18/2013 10:53 AM, Paolo Bonzini wrote: I'm guessing you need approval from Jiuxing Liu for this, pls make him ack license change. He approves. He doesn't work for IBM anymore. Does he approve version 2 or version 2 or later? It doesn't matter - his contributions were made at IBM and he

Re: [Qemu-devel] [PATCH] virtio-balloon: fix integer overflow in BALLOON_CHANGE QMP event

2013-04-18 Thread Eric Blake
On 04/18/2013 11:05 AM, Luiz Capitulino wrote: > Because dev->actual is uint32_t, the expression 'dev->actual << > VIRTIO_BALLOON_PFN_SHIFT' is truncated to 32 bits. This overflows when > dev->actual >= 1048576. > > To reproduce: > > 1. Start a VM with a QMP socket and 5G of RAM > 2. Connect to

Re: [Qemu-devel] fixing qemu busy wait

2013-04-18 Thread Orr Dvory
is this better? diff -uprN qemu-1.4.1/gdbstub.c qemu-1.4.1-fix/gdbstub.c --- qemu-1.4.1/gdbstub.c2013-04-15 23:25:18.0 +0300 +++ qemu-1.4.1-fix/gdbstub.c2013-04-18 21:35:00.0 +0300 @@ -379,17 +379,22 @@ static void put_buffer(GDBState *s, cons { #ifdef CONFIG_USER_ONLY

Re: [Qemu-devel] [PATCH] tpm: Simplify creation of cancel path

2013-04-18 Thread Stefan Berger
On 04/16/2013 02:16 PM, Anthony Liguori wrote: Stefan Berger writes: Simplify the creation of the cancel path given the TPM's device path. Given the path /dev/tpm0 build the path /sys/class/misc/tpm0/device/cancel. Signed-off-by: Stefan Berger No longer applies. Had you sent with git-send-

Re: [Qemu-devel] [PATCH RFC] vhost: fix vhost force with msix=off

2013-04-18 Thread Alexander Graf
On 15.04.2013, at 16:40, Michael S. Tsirkin wrote: > In response to a bug report on IRC: this should fix it I think? > Need to test properly but out of time for today, > compiled only. Hope this helps. > > Signed-off-by: Michael S. Tsirkin This does indeed make level interrupts work with vhost

Re: [Qemu-devel] [PATCH 03/16] introduce resume_vcpu(), for single CPU

2013-04-18 Thread Eduardo Habkost
On Tue, Apr 16, 2013 at 12:12:43AM +0200, Igor Mammedov wrote: > ... also add stub for it, to make possible to use it in qom/cpu.c, > which is shared with user emulators. > > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost > --- > Note: > it will be re-used from qom/cpu.c by hotpl

Re: [Qemu-devel] [PATCH 07/16] cpu: introduce get_arch_id() method and override it for target-i386

2013-04-18 Thread Eduardo Habkost
On Tue, Apr 16, 2013 at 12:12:47AM +0200, Igor Mammedov wrote: > get_arch_id() adds possibility for generic code to get guest visible > CPU ID without accessing CPUArchState. If target doesn't override it, > it will return cpu_index. > > Override it on target-i386 to return APIC ID. > > Signed-of

Re: [Qemu-devel] [PATCH 06/16] target-i386: pc: update rtc_cmos on CPU hot-plug

2013-04-18 Thread Eduardo Habkost
On Tue, Apr 16, 2013 at 12:12:46AM +0200, Igor Mammedov wrote: > ... so that on reboot BIOS could read current available CPU count > > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost > --- > hw/i386/pc.c | 20 > hw/timer/mc146818rtc.c |

[Qemu-devel] [PATCH] virtio-balloon: fix integer overflow in BALLOON_CHANGE QMP event

2013-04-18 Thread Luiz Capitulino
Because dev->actual is uint32_t, the expression 'dev->actual << VIRTIO_BALLOON_PFN_SHIFT' is truncated to 32 bits. This overflows when dev->actual >= 1048576. To reproduce: 1. Start a VM with a QMP socket and 5G of RAM 2. Connect to the QMP socket, negotiate capabilities and issue: { "execu

Re: [Qemu-devel] [PATCH 04/16] cpu: resume CPU from CPUClass.cpu_common_realizefn() when it is hot-plugged

2013-04-18 Thread Eduardo Habkost
On Tue, Apr 16, 2013 at 12:12:44AM +0200, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost > --- > v2: > * remove unnecessary now sysemu/cpus.h header > * move out introducing resume_vcpu() into a separate patch > --- > qom/cpu.c | 1 + > 1 file changed, 1 in

Re: [Qemu-devel] [PATCH 02/16] cpu: call cpu_synchronize_post_init() from CPUClass.realize() if hotplugged

2013-04-18 Thread Eduardo Habkost
On Tue, Apr 16, 2013 at 12:12:42AM +0200, Igor Mammedov wrote: > ... to synchronize CPU state to KVM > > Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost > --- > v2: > * linking kvm-stub.o to *-user target moved in separate patch > --- > include/sysemu/kvm.h | 18 ++

Re: [Qemu-devel] Virtualbox svga card in KVM

2013-04-18 Thread Sriram Murthy
Some updates on this -  I changed the PCI Device ID and Vendor ID in hw/vga.c, and was able to get the VirtualBox SVGA card driver installed in WinXP running on KVM. However, when I try to change the resolution, KVM crashes with a SIGFPE in vbe_ioport_write_data(), and this is due to line_offset

[Qemu-devel] [PATCH 6/8] qom: do not return root for empty path

2013-04-18 Thread Paolo Bonzini
An empty path will return the sole object of that type in the QOM tree. This is different from "/", which returns the root. Signed-off-by: Paolo Bonzini --- qom/object.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/qom/object.c b/qom/object.c index 093502e..

[Qemu-devel] [PATCH 2/8] audio: remove the need for audio card CONFIG_* symbols

2013-04-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- RFC->v1: do not touch audio_available() here arch_init.c | 130 --- configure| 8 +-- hw/audio/ac97.c | 3 +- hw/audio/adlib.c | 3 +- hw/audio/cs4231a.c

[Qemu-devel] [PATCH 5/8] audio: replace audio card configuration with default-configs

2013-04-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- configure| 7 --- default-configs/i386-softmmu.mak | 2 +- default-configs/mips-softmmu.mak | 2 +- default-configs/mips64-softmmu.mak | 2 +- default-configs/mips64el-softmmu.mak | 2 +- default-configs/mipsel-softmm

[Qemu-devel] [PATCH 8/8] audio: enable PCI audio cards for all PCI-enabled targets

2013-04-18 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- RFC->v1: move audio_init() to vl.c default-configs/pci.mak | 3 +++ default-configs/sound.mak | 3 --- hw/i386/pc_piix.c | 2 -- hw/i386/pc_q35.c | 1 - hw/mips/mips_jazz.c | 2 -- hw/mips/mips_malta.c | 3 --- hw/ppc/prep.c

  1   2   3   >