Re: [Qemu-devel] [PATCH v4 0/7] virtio-serial refactoring.

2013-04-02 Thread Cornelia Huck
On Fri, 29 Mar 2013 10:02:37 +0100 fred.kon...@greensocs.com wrote: > From: KONRAD Frederic > > This is the next part of virtio-refactoring. > > Basically it creates virtio-serial device which extends virtio-device. > Then a virtio-serial can be connected on a virtio-bus. > virtio-serial-pci, v

Re: [Qemu-devel] [PATCH v1 1/4] m25p80: Fix debug messages.

2013-04-02 Thread Edgar E. Iglesias
On Wed, Apr 03, 2013 at 02:09:16PM +1000, Peter Crosthwaite wrote: > Some dodgy casts were making a mess of these msgs. Hi Peter > > Signed-off-by: Peter Crosthwaite > --- > > hw/m25p80.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/m25p80.c b/hw/m25

Re: [Qemu-devel] [PATCH v4 1/7] virtio-serial: add the virtio-serial device.

2013-04-02 Thread Cornelia Huck
On Fri, 29 Mar 2013 10:02:38 +0100 fred.kon...@greensocs.com wrote: > From: KONRAD Frederic > > Create virtio-serial which extends virtio-device, so it can be connected > on virtio-bus. > > Signed-off-by: KONRAD Frederic > --- > hw/virtio-pci.c| 2 +- > hw/virtio-serial-bus.c | 95 >

Re: [Qemu-devel] [PATCH 1/2 V3] virtio-spec: dynamic network offloads configuration

2013-04-02 Thread Rusty Russell
Dmitry Fleytman writes: > From: Dmitry Fleytman > > Virtio-net driver currently negotiates network offloads > on startup via features mechanism and have no ability to > change offloads state later. > This patch introduced a new control command that allows > to configure device network offloads st

Re: [Qemu-devel] [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-04-02 Thread Paolo Bonzini
> > Considering the following when the same seabios code snippet: > > > >pci_config_writeb(0x31): bdf: 0x pam: 0x005b > > > > is executed to mark an pc.ram area 0xc as readonly: > > > > Entering vhost_begin > > Entering vhost_region_del section: 0

[Qemu-devel] [RFC/PATCH 1/1] s390: implement CPU hotplug

2013-04-02 Thread Jens Freimann
From: Thang Pham This patch allows CPUs to be hotplugged to a running guest. The QEMU option (maxcpus) can be used to define the total number of standby and configured CPUs available at boot time, although it is not necessary because you can hotplug standby CPUs after boot time. For example, the

[Qemu-devel] [RFC/PATCH 0/1] cpu hotplug for s390

2013-04-02 Thread Jens Freimann
Hi all, this is what our approach to CPU hotplug looks like. With respect to Igor's CPU hotplug series, how should we proceed? Should we change the interface to qemu_system_cpu_add_notifier/qemu_system_cpu_hotplug_request/cpu-add etc? Feedback regarding the non-API part is also highly welcome!

[Qemu-devel] qemu-kvm precopy based cloning

2013-04-02 Thread shashaankar reddy
Hi All, I'm very new to qemu code base and keenly interested in understanding how live VM migration works (pre-copy mechanism). So that I can work on contributing pre-copy based live VM cloning. Any inputs from current developers regarding pre-copy migration and specific hook points to implement

Re: [Qemu-devel] [RFC PATCH] main-loop: Unconditionally unlock iothread

2013-04-02 Thread Paolo Bonzini
> --- > Is it expected that this non-blocking condition implies lockup of the > iothread? No. The idea was to make the loop cheaper when you had a qemu_notify_event() or bottom half, basically something that causes main_loop_wait() to wake up immediately multiple times. When that happens, it is

Re: [Qemu-devel] Virtio 9p live migration patches

2013-04-02 Thread Aneesh Kumar K.V
Benoît Canet writes: > Thanks a lot, > > Do you have an idea of what is left to be done on it ? > It has to rewritten with the new model with respect to migration. Also these is problem of how much time does it take to migrate the fid information ?. We also need to ensure new 9p request are bloc

[Qemu-devel] [PATCH 2/2] trace: document frace backend

2013-04-02 Thread Eiichi Tsukata
Add documentation of ftrace backend. Signed-off-by: Eiichi Tsukata --- docs/tracing.txt | 16 1 file changed, 16 insertions(+) diff --git a/docs/tracing.txt b/docs/tracing.txt index cf53c17..60ff9c5 100644 --- a/docs/tracing.txt +++ b/docs/tracing.txt @@ -175,6 +175,22 @@ unles

[Qemu-devel] [PATCH 1/2] trace: Add ftrace tracing backend

2013-04-02 Thread Eiichi Tsukata
This patch adds a ftrace tracing backend which sends trace event to ftrace marker file. You can effectively compare qemu trace data and kernel(especially, kvm.ko when using KVM) trace data. The ftrace backend is restricted to Linux only. To try out the ftrace backend: $ ./configure --trace-backe

[Qemu-devel] [PATCH 0/2] New trace backend: ftrace

2013-04-02 Thread Eiichi Tsukata
This patchset introduces a new tracing backend "ftrace". Currently, QEMU tracing backends do not support userspace tracing with ftrace. Collecting QEMU trace data and kernel trace data simultaniouly is useful for latency analysis and debugging especially when using KVM. With ftrace backend, you c

Re: [Qemu-devel] [PATCH 1/1] rng backend: open backend in blocking mode

2013-04-02 Thread Amit Shah
On (Tue) 02 Apr 2013 [07:52:19], Anthony Liguori wrote: > Amit Shah writes: > > > On (Mon) 01 Apr 2013 [09:02:46], Anthony Liguori wrote: > >> Amit Shah writes: > >> > >> > Opening backends in non-blocking mode isn't necessary, we don't do > >> > anything while waiting for data. > >> > > >> > T

Re: [Qemu-devel] [PATCH 2/3] block: adjust qmp_transaction to be extendable

2013-04-02 Thread Wenchao Xia
于 2013-4-2 21:55, Kevin Wolf 写道: Am 01.04.2013 um 12:01 hat Wenchao Xia geschrieben: Now code for external snapshot are packaged as one case in qmp_transaction, so later other operation could be added. The logic in qmp_transaction is changed a bit: Original code tries to create all images

Re: [Qemu-devel] [PATCH 3/3] block: change rollback sequence in qmp_transaction

2013-04-02 Thread Wenchao Xia
于 2013-4-2 21:59, Kevin Wolf 写道: Am 01.04.2013 um 12:01 hat Wenchao Xia geschrieben: Last operaton should be cancelled first. Signed-off-by: Wenchao Xia Should it? This commit message does little to convince me. Kevin I think so, if two request are "snapshot_blkdev ide0 newimage.qcow

[Qemu-devel] [PATCH] hw/nand.c: Fix nand erase operation

2013-04-02 Thread Peter Crosthwaite
From: Wendy Liang Usually, nand erase operation has only 2 or 3 address cycles. We need to mask s->addr to zero unset stale high-order bytes in the nand address before using it as the erase address. This fixes the NAND erase operation in Linux. [PC: Generalised to work for any number of address

[Qemu-devel] [PATCH v5 16/16] stream: Remove app argument hack

2013-04-02 Thread Peter Crosthwaite
The uint32_t *app argument doesn't exist in real hardware. It was a hack in xilinx_axidma/enet to fake the (secondary) control stream connection. Removed the argument and added the second stream to axienet/dma. Signed-off-by: Peter Crosthwaite --- changed since v3: Rebased against now synchronous

[Qemu-devel] [PATCH v5 15/16] xilinx_axienet/dma: Implement rx path flow control

2013-04-02 Thread Peter Crosthwaite
Implement flow control for the RX data path from xilinx_axienet->xilinx_axidma. On short return from axidma, then ethernet sets up the notify callback to resume transfer from where it left off. This also allows the ethernet to track whether there is an in progress transaction and return false fro

[Qemu-devel] [PATCH v5 13/16] xilinx_axidma: Fix rx/tx halted bit.

2013-04-02 Thread Peter Crosthwaite
If there is no DMA buffer descriptor, the DMA halts, not idles. Signed-off-by: Peter Crosthwaite Acked-by: Edgar E. Iglesias --- changed from v3: Fixed for TX path as well as RX hw/xilinx_axidma.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/xilinx_axidma.c b/

[Qemu-devel] [PATCH v5 14/16] stream: Add flow control API

2013-04-02 Thread Peter Crosthwaite
Add basic flow control to stream. A stream slave may return short, indicating that it is not capable of accepting any more data at the present time. Polling or a callback can be used via the can_push() function to determine when the slave can receive again. Signed-off-by: Peter Crosthwaite ---

[Qemu-devel] [PATCH v5 12/16] xilinx_axidma: Create Proxy object for stream

2013-04-02 Thread Peter Crosthwaite
Create a separate child object to proxy the stream slave connection. This is setup for future work where a second stream slave connection is needed. The new child object is created at qdev init time and is linked back to the parent (the ethernet device itself) automatically. Stream slave masters d

Re: [Qemu-devel] [PATCH V11 05/17] block: add snapshot info query function bdrv_query_snapshot_info_list()

2013-04-02 Thread Wenchao Xia
于 2013-4-3 9:17, Eric Blake 写道: On 04/02/2013 05:47 AM, Wenchao Xia wrote: This patch adds function bdrv_query_snapshot_info_list(), which will retrieve snapshot info of an image in qmp object format. The implementation is based on the code moved from qemu-img.c with modification to fit more

[Qemu-devel] [PATCH v5 11/16] xilinx_axienet: Create Proxy object for stream

2013-04-02 Thread Peter Crosthwaite
Create a separate child object to proxy the stream slave connection. This is setup for future work where a second stream slave connection is needed. The new child object is created at qdev init time and is linked back to the parent (the ethernet device itself) automatically. Stream slave masters d

[Qemu-devel] [PATCH v5 10/16] petalogix_ml605_mmu: Attach ethernet to machine

2013-04-02 Thread Peter Crosthwaite
Explicitly make the ethernet a child of the machine. This is needed to set and use links pre-realize. Also makes the ethernet initialization consistent with its peer DMA. Signed-off-by: Peter Crosthwaite Reviewed-by: Andreas Färber Acked-by: Edgar E. Iglesias --- hw/microblaze/petalogix_ml605

[Qemu-devel] [PATCH v5 09/16] petalogix_ml605_mmu: Fix machine node attachment

2013-04-02 Thread Peter Crosthwaite
Just attach devices straight to the root machine node, rather than the "unattached node" Signed-off-by: Peter Crosthwaite Reviewed-by: Andreas Färber Acked-by: Edgar E. Iglesias --- Suggested (indirectly) by Andreas if he wants to put his Suggested-by to it. hw/microblaze/petalogix_ml605_mmu.

[Qemu-devel] [PATCH v5 08/16] xilinx_axidma: converted init->realize

2013-04-02 Thread Peter Crosthwaite
The prescribed transition from SysBusDevice::init to Device::realize. I'm going with Andreas suggestion to move the sysbus foo to Object::init for early IRQ visibility. Signed-off-by: Peter Crosthwaite Acked-by: Edgar E. Iglesias --- hw/xilinx_axidma.c | 25 - 1 files

[Qemu-devel] [PATCH v5 07/16] xilinx_axidma: Register reset properly

2013-04-02 Thread Peter Crosthwaite
Register the reset function as the Device::reset function rather than explicitly call it from the sysbus::init. Signed-off-by: Peter Crosthwaite Acked-by: Edgar E. Iglesias --- hw/xilinx_axidma.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/hw/xilinx_axi

[Qemu-devel] [PATCH v5 06/16] xilinx_axidma: Defined and use type cast macro

2013-04-02 Thread Peter Crosthwaite
Standard QOM cast macro. Replaces usages of FROM_SYSBUS Signed-off-by: Peter Crosthwaite Acked-by: Edgar E. Iglesias --- hw/xilinx_axidma.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/xilinx_axidma.c b/hw/xilinx_axidma.c index d57538e..7cb40bd 100644

[Qemu-devel] [PATCH v5 05/16] xilinx_axidma: typedef XilinxAXIDMA struct

2013-04-02 Thread Peter Crosthwaite
Typedef xilinx_axidma's object state struct to shorten the repeated usages of struct XilinxAXIDMA. Signed-off-by: Peter Crosthwaite Acked-by: Edgar E. Iglesias --- hw/xilinx_axidma.c | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/hw/xilinx_axidma.c b/hw

[Qemu-devel] [PATCH v5 04/16] xilinx_axienet: converted init->realize

2013-04-02 Thread Peter Crosthwaite
The prescribed transition from SysBusDevice::init to Device::realize. Im going with Andreas suggestion to move the sysbus foo to Object::init for early IRQ visibility. Signed-off-by: Peter Crosthwaite Reviewed-by: Andreas Färber Acked-by: Edgar E. Iglesias --- Changed from v3: Added missing inc

[Qemu-devel] [PATCH v5 03/16] xilinx_axienet: Register reset properly

2013-04-02 Thread Peter Crosthwaite
Register the reset function and the Device::reset function rather than explicitly call it from the sysbus::init. Signed-off-by: Peter Crosthwaite Reviewed-by: Andreas Färber Acked-by: Edgar E. Iglesias --- hw/xilinx_axienet.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) di

[Qemu-devel] [PATCH v5 02/16] xilinx_axienet: Defined and use type cast macro

2013-04-02 Thread Peter Crosthwaite
Standard QOM cast macro. Replaces usages of FROM_SYSBUS Signed-off-by: Peter Crosthwaite Reviewed-by: Andreas Färber Acked-by: Edgar E. Iglesias --- hw/xilinx_axienet.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/xilinx_axienet.c b/hw/xilinx_axienet.c

[Qemu-devel] [PATCH v5 01/16] xilinx_axienet: typedef XilinxAXIEnet struct

2013-04-02 Thread Peter Crosthwaite
Typedef xilinx_axienets object state struct to shorten the repeated usages of struct XilinxAXIEnet. Signed-off-by: Peter Crosthwaite Reviewed-by: Andreas Färber Acked-by: Edgar E. Iglesias --- hw/xilinx_axienet.c | 44 +++- 1 files changed, 23 inserti

[Qemu-devel] [PATCH v5 00/16] Stream Patches

2013-04-02 Thread Peter Crosthwaite
Hi all. The Xilinx AXIEnet and DMA devices have two AXI stream connections (control and data), only one of which is currently modelled (data). AXI stream is modelled using the stream QOM interface described in stream.h. Unfortunately, interfaces have no nice way of modelling multiple connections of

Re: [Qemu-devel] Regarding migration

2013-04-02 Thread Shehbaz Jaffer
All of migration code can be found in migrate.c file. To understand migration, you can run qemu in gdb and place breakpoints in do_savevm() function on server side and do_loadvm() function on client side. Migration consists of the following parts: 1. save device driver state (11 in number. this c

Re: [Qemu-devel] [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-04-02 Thread Nicholas A. Bellinger
On Tue, 2013-04-02 at 21:04 -0700, Nicholas A. Bellinger wrote: > On Tue, 2013-04-02 at 16:27 +0300, Michael S. Tsirkin wrote: > > On Mon, Apr 01, 2013 at 06:05:47PM -0700, Nicholas A. Bellinger wrote: > > > On Fri, 2013-03-29 at 09:14 +0100, Paolo Bonzini wrote: > > > > Il 29/03/2013 03:53, Nicho

[Qemu-devel] [PATCH arm-devs v1 1/1] cadence_uart: Flush queued characters on reset

2013-04-02 Thread Peter Crosthwaite
Reset can be used to empty the rx-fifo. As the fifo full condition is used to return false from can_receive, queued rx data should be flushed on reset accordingly. Cc: Wendy Liang Cc: Jason Wu Signed-off-by: Peter Crosthwaite Reported-by: Jason Wu --- hw/cadence_uart.c |1 + 1 files cha

[Qemu-devel] [PATCH arm-devs v1 0/1] cadence_uart: U-boot driver

2013-04-02 Thread Peter Crosthwaite
Hi Peter, This is a corner case bug discovered by U-boot driver for cadence GEM. Regards, Peter Peter Crosthwaite (1): cadence_uart: Flush queued characters on reset hw/cadence_uart.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH arm-devs v1 15/15] xilinx_spips: lqspi: Fix byte/misaligned access

2013-04-02 Thread Peter Crosthwaite
The LQSPI bus attachment supports byte/halfword and misaligned accesses. Fixed. Refactored the LQSPI cache to be byte-wise instead of word wise accordingly. Signed-off-by: Peter Crosthwaite --- hw/xilinx_spips.c | 31 +-- 1 files changed, 17 insertions(+), 14 delet

[Qemu-devel] [PATCH arm-devs v1 14/15] xilinx_spips: lqspi: Push more data to tx-fifo

2013-04-02 Thread Peter Crosthwaite
Do 16 words per fifo flush. Increases performance and decreases debug verbosity. This data depth has no real hardware analogue, so just go with something that has reasonable performance. Signed-off-by: Peter Crosthwaite --- hw/xilinx_spips.c | 11 +++ 1 files changed, 7 insertions(+),

[Qemu-devel] [PATCH arm-devs v1 13/15] xilinx_spips: Multiple debug verbosity levels

2013-04-02 Thread Peter Crosthwaite
The debug printfs on every SPI operation is extremely verbose. Add a second level of debug for this. Signed-off-by: Peter Crosthwaite --- hw/xilinx_spips.c | 68 - 1 files changed, 41 insertions(+), 27 deletions(-) diff --git a/hw/xilinx_sp

[Qemu-devel] [PATCH arm-devs v1 12/15] xilinx_spips: Debug msgs for Snoop state

2013-04-02 Thread Peter Crosthwaite
This is worth keeping track of when debugging the device model. Signed-off-by: Peter Crosthwaite --- hw/xilinx_spips.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/xilinx_spips.c b/hw/xilinx_spips.c index 43ce2d8..0d01103 100644 --- a/hw/xilinx_spips.c +++ b/hw/

[Qemu-devel] [PATCH arm-devs v1 11/15] xilinx_spips: Fix striping behaviour

2013-04-02 Thread Peter Crosthwaite
The QSPI controller was using byte-wide stripes when striping across the two flashes in dual parallel mode. The real hardware however uses individual bit striping. QEMU misbehaves in the (corner) case where data is written/read in dual-parallel mode and read/written back in single mode. Signed-off

[Qemu-devel] [PATCH arm-devs v1 10/15] xilinx_spips: Fix CTRL register RW bits

2013-04-02 Thread Peter Crosthwaite
The CTRL register was RAZ/WI on some of the RW bits. Even though the function behind these bits is invalid in QEMU, they should still be guest accessible. Fix. Signed-off-by: Peter Crosthwaite --- hw/xilinx_spips.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/x

[Qemu-devel] [PATCH arm-devs v1 09/15] xilinx_spips: Implement automatic CS

2013-04-02 Thread Peter Crosthwaite
Implement the automatic CS control feature. If the MANUAL_CS bit is cleared then the chip select stay de-asserted as long as the tx FIFO is empty. Signed-off-by: Peter Crosthwaite --- hw/xilinx_spips.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/xilinx

[Qemu-devel] [PATCH arm-devs v1 08/15] xilinx_spips: Add automatic start support

2013-04-02 Thread Peter Crosthwaite
SPI has a mode where it automatically starts based on tx fifo occupancy. Implemented. Signed-off-by: Peter Crosthwaite --- hw/xilinx_spips.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/xilinx_spips.c b/hw/xilinx_spips.c index 4f921f8..f7d942e 100644 --- a/hw/xi

[Qemu-devel] [PATCH arm-devs v1 07/15] xilinx_spips: Trash LQ page cache on mode change

2013-04-02 Thread Peter Crosthwaite
Invalidate the LQSPI cached page when transitioning into LQSPI mode. Otherwise there is a possibility that the controller will return stale data to the guest when transitioning back to LQ_MODE after a page program. Signed-off-by: Peter Crosthwaite --- hw/xilinx_spips.c |8 1 files

[Qemu-devel] [PATCH arm-devs v1 06/15] xilinx_spips: Fix QSPI FIFO size

2013-04-02 Thread Peter Crosthwaite
QSPI has a bigger FIFO than the regular SPI controller. Differentiate between the two with correct FIFO sizes for each. Signed-off-by: Peter Crosthwaite --- hw/xilinx_spips.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/hw/xilinx_spips.c b/hw/xilinx_spips.c ind

[Qemu-devel] [PATCH arm-devs v1 05/15] xilinx_spips: lqspi: Dont trash config register

2013-04-02 Thread Peter Crosthwaite
The LQSPI code currently manipulates the config register to achieve its ends. Some (agressively designed) drivers assume that the config register preserves state across a transition into and out of LQSPI mode. Fixed by just restoring R_CONFIG to its original value after LQSPI does its thing. Signe

[Qemu-devel] [PATCH arm-devs v1 04/15] xilinx_spips: Add verbose LQSPI debug output

2013-04-02 Thread Peter Crosthwaite
You really need this is you want to track a guest banging on LQSPI. Signed-off-by: Peter Crosthwaite --- hw/xilinx_spips.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/hw/xilinx_spips.c b/hw/xilinx_spips.c index a8691d5..29636ce 100644 --- a/hw/xilinx_spips.c +++

[Qemu-devel] [PATCH arm-devs v1 03/15] xilinx_spips: Inhibit interrupts in LQSPI mode

2013-04-02 Thread Peter Crosthwaite
The real hardware does not produce interrupts in LQSPI mode. Inhibit generation of interrupts when the LQ_MODE bit is set. Signed-off-by: Peter Crosthwaite --- hw/xilinx_spips.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/hw/xilinx_spips.c b/hw/xilinx_spips.c

[Qemu-devel] [PATCH arm-devs v1 02/15] xilinx_spips: Make interrupts clear on read

2013-04-02 Thread Peter Crosthwaite
By default these interrupts are clear on read. Signed-off-by: Peter Crosthwaite --- hw/xilinx_spips.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/hw/xilinx_spips.c b/hw/xilinx_spips.c index 734adf0..261d948 100644 --- a/hw/xilinx_spips.c +++ b/hw/xilinx_spips.c @

[Qemu-devel] [PATCH arm-devs v1 01/15] xilinx_spips: seperate SPI and QSPI as two classes

2013-04-02 Thread Peter Crosthwaite
Make SPI and QSPI different classes. QSPIPS is setup as a child of SPIPS. Only QSPI has the LQSPI functionality, so move all that to the child class. Signed-off-by: Peter Crosthwaite --- Changed from v2: User parent_obj as appropriate for QOM parents (PMM review) Changed from v1: Fixed compile bu

[Qemu-devel] [PATCH arm-devs v1 00/15] Xilinx SPIPS fixes round 2

2013-04-02 Thread Peter Crosthwaite
Updates to the Zynq SPI controller. Some QOMifying cleanup, followed by a number of bugs/incompletnesses found by some (very) rigourous test vectors. Peter Crosthwaite (15): xilinx_spips: seperate SPI and QSPI as two classes xilinx_spips: Make interrupts clear on read xilinx_spips: Inhibit

[Qemu-devel] [PATCH v1 4/4] m25p80: Add debug message for no bdrv

2013-04-02 Thread Peter Crosthwaite
If there is no backing bdrv, let the debugging developer know about it. Signed-off-by: Peter Crosthwaite --- hw/m25p80.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/m25p80.c b/hw/m25p80.c index f8aa0e9..812cae0 100644 --- a/hw/m25p80.c +++ b/hw/m25p80.c @@ -605,6

[Qemu-devel] [PATCH v1 3/4] m25p80.c: Multiple debug verbosity levels

2013-04-02 Thread Peter Crosthwaite
The debug printfs on every page program/read is extremely verbose. Add add second level of debug for this. Signed-off-by: Peter Crosthwaite --- hw/m25p80.c | 36 +++- 1 files changed, 19 insertions(+), 17 deletions(-) diff --git a/hw/m25p80.c b/hw/m25p80.c ind

[Qemu-devel] [PATCH v1 2/4] m25p80: Convert guest errors to LOG_GUEST_ERROR

2013-04-02 Thread Peter Crosthwaite
Some of the debug printfs in m25p80 are really guest errors. Changed over to qemu_log_mask(LOG_GUEST_ERROR accordingly. Signed-off-by: Peter Crosthwaite --- hw/m25p80.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/m25p80.c b/hw/m25p80.c index 34b476b.

[Qemu-devel] [PATCH v1 1/4] m25p80: Fix debug messages.

2013-04-02 Thread Peter Crosthwaite
Some dodgy casts were making a mess of these msgs. Signed-off-by: Peter Crosthwaite --- hw/m25p80.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/m25p80.c b/hw/m25p80.c index 55e9d0d..34b476b 100644 --- a/hw/m25p80.c +++ b/hw/m25p80.c @@ -538,15 +538,15 @@ sta

[Qemu-devel] [PATCH v1 0/4] m25p80: Fix debug printfery

2013-04-02 Thread Peter Crosthwaite
Fix up the debug printfery m25p80 in various ways. 0 functional diff. Peter Crosthwaite (4): m25p80: Fix debug messages. m25p80: Convert guest errors to LOG_GUEST_ERROR m25p80.c: Multiple debug verbosity levels m25p80: Add debug message for no bdrv hw/m25p80.c | 53 +++

[Qemu-devel] [PATCH] xilinx_axienet: pump events as appropriate

2013-04-02 Thread Peter Crosthwaite
When the conditions blocking receiving are cleared, check for buffered rx packets. Signed-off-by: Peter Crosthwaite --- hw/xilinx_axienet.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/xilinx_axienet.c b/hw/xilinx_axienet.c index 5785290..07c4bad 100644 --- a/hw/x

Re: [Qemu-devel] [PATCH V3 WIP 3/3] disable vhost_verify_ring_mappings check

2013-04-02 Thread Nicholas A. Bellinger
On Tue, 2013-04-02 at 16:27 +0300, Michael S. Tsirkin wrote: > On Mon, Apr 01, 2013 at 06:05:47PM -0700, Nicholas A. Bellinger wrote: > > On Fri, 2013-03-29 at 09:14 +0100, Paolo Bonzini wrote: > > > Il 29/03/2013 03:53, Nicholas A. Bellinger ha scritto: > > > > On Thu, 2013-03-28 at 06:13 -0400,

[Qemu-devel] [PATCH arm-devs v1] pl330: Dont inhibit ES bits on INTEN

2013-04-02 Thread Peter Crosthwaite
This if-else logic inhibits setting of the event status (ES) bits when interrupts are enabled. This is incorrect. ES should be set regardless on INTEN state. INTEN only inhibits the signalling of events to PL330 threads, not setting of the ES register. Signed-off-by: Peter Crosthwaite --- hw/pl

[Qemu-devel] [PATCH arm-devs v1] pl330: Interrupt logic fix

2013-04-02 Thread Peter Crosthwaite
Hi Peter I recently did a bringup of the common Linux kernel pl330 driver as instantiated in Zynq. Just the one QEMU bug discovered in the process, with the interrupt logic. Regards, Peter Peter Crosthwaite (1): pl330: Dont inhibit ES bits on INTEN hw/pl330.c |3 +-- 1 files changed, 1

Re: [Qemu-devel] RFC: vfio API changes needed for powerpc

2013-04-02 Thread Alex Williamson
On Tue, 2013-04-02 at 17:50 -0500, Scott Wood wrote: > On 04/02/2013 04:38:45 PM, Alex Williamson wrote: > > On Tue, 2013-04-02 at 16:08 -0500, Stuart Yoder wrote: > > > On Tue, Apr 2, 2013 at 3:57 PM, Scott Wood > > wrote: > > > >> >C. Explicit mapping using normal DMA map. The last idea

Re: [Qemu-devel] RFC: vfio API changes needed for powerpc

2013-04-02 Thread Alex Williamson
On Tue, 2013-04-02 at 17:44 -0500, Scott Wood wrote: > On 04/02/2013 04:32:04 PM, Alex Williamson wrote: > > On Tue, 2013-04-02 at 15:57 -0500, Scott Wood wrote: > > > On 04/02/2013 03:32:17 PM, Alex Williamson wrote: > > > > On x86 the interrupt remapper handles this transparently when MSI > > > >

Re: [Qemu-devel] RFC: vfio API changes needed for powerpc

2013-04-02 Thread Alex Williamson
On Tue, 2013-04-02 at 17:13 -0500, Scott Wood wrote: > On 04/02/2013 04:16:11 PM, Alex Williamson wrote: > > On Tue, 2013-04-02 at 15:54 -0500, Stuart Yoder wrote: > > > The number of windows is always power of 2 (and max is 256). And > > to reduce > > > PAMU cache pressure you want to use the f

Re: [Qemu-devel] Virtualbox svga card in KVM

2013-04-02 Thread Sriram Murthy
Hi,     I am looking into hw/vga.c and hw/vga-pci.c as a starting point in my effort to get vbox svga card into kvm.     However, given my very basic understanding of VGA/SVGA standards, can somebody throw some light on the inner workings of the std vga card in kvm?     Also, are there any g

Re: [Qemu-devel] [RFC PATCH] main-loop: Unconditionally unlock iothread

2013-04-02 Thread Peter Crosthwaite
Hi Paolo, Thanks for the clues. On Tue, Apr 2, 2013 at 9:11 PM, Paolo Bonzini wrote: > Il 02/04/2013 11:04, Peter Crosthwaite ha scritto: >> Public bug: 1154328 >> Broken Commit: a29753f8aa79a34a324afebe340182a51a5aef11 >> >> ATM, the timeout from g_pollfds_fill is inhibiting unlocking of the >>

Re: [Qemu-devel] [PATCH V11 05/17] block: add snapshot info query function bdrv_query_snapshot_info_list()

2013-04-02 Thread Eric Blake
On 04/02/2013 05:47 AM, Wenchao Xia wrote: > This patch adds function bdrv_query_snapshot_info_list(), which will > retrieve snapshot info of an image in qmp object format. The implementation > is based on the code moved from qemu-img.c with modification to fit more > for qmp based block layer AP

Re: [Qemu-devel] [PATCH-v2 0/3] virtio/vhost: Add checks for uninitialized VQs

2013-04-02 Thread Nicholas A. Bellinger
On Tue, 2013-04-02 at 15:01 +0300, Michael S. Tsirkin wrote: > On Mon, Apr 01, 2013 at 11:58:21PM +, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > Hi folks, > > > > This series adds a virtio_queue_valid() for use by virtio-pci code in > > order to prevent opreations upon

Re: [Qemu-devel] [PATCH] Add configure clock_gettime() monotonic time test

2013-04-02 Thread Peter Maydell
On 2 April 2013 17:45, Paolo Bonzini wrote: > Il 02/04/2013 17:42, Brad Smith ha scritto: >> Replace the hardcoded list of OS's utilizing clock_gettime() for monotonic >> time with a configure test. This is to fix the use of monotonic time on >> OpenBSD but allows for other POSIX compliant OS's su

Re: [Qemu-devel] RFC: vfio API changes needed for powerpc

2013-04-02 Thread Scott Wood
On 04/02/2013 04:38:45 PM, Alex Williamson wrote: On Tue, 2013-04-02 at 16:08 -0500, Stuart Yoder wrote: > On Tue, Apr 2, 2013 at 3:57 PM, Scott Wood wrote: > >> >C. Explicit mapping using normal DMA map. The last idea is that > >> >we would introduce a new ioctl to give user-s

[Qemu-devel] [PATCH 07/37] help: add docs for multiqueue tap options

2013-04-02 Thread Michael Roth
From: Jason Wang Cc: Markus Armbruster Cc: Jason Wang Signed-off-by: Jason Wang Message-id: 1361354641-51969-1-git-send-email-jasow...@redhat.com Signed-off-by: Anthony Liguori (cherry picked from commit 2ca81baa0b3363d57de94f8b80c02a003b361161) Signed-off-by: Michael Roth --- qapi-schema.

[Qemu-devel] [PATCH 33/37] linux-user/syscall.c: handle FUTEX_WAIT_BITSET in do_futex

2013-04-02 Thread Michael Roth
From: John Rigby Upstream libc has recently changed to start using FUTEX_WAIT_BITSET instead of FUTEX_WAIT and this is causing do_futex to return -TARGET_ENOSYS. Pass bitset in val3 to sys_futex which will be ignored by kernel for the FUTEX_WAIT case. Signed-off-by: John Rigby Signed-off-by: R

Re: [Qemu-devel] RFC: vfio API changes needed for powerpc

2013-04-02 Thread Scott Wood
On 04/02/2013 04:32:04 PM, Alex Williamson wrote: On Tue, 2013-04-02 at 15:57 -0500, Scott Wood wrote: > On 04/02/2013 03:32:17 PM, Alex Williamson wrote: > > On x86 the interrupt remapper handles this transparently when MSI > > is enabled and userspace never gets direct access to the device MS

[Qemu-devel] [PATCH 29/37] Fix page_cache leak in cache_resize

2013-04-02 Thread Michael Roth
From: Orit Wasserman Signed-off-by: Orit Wasserman Reviewed-by: Peter Maydell Signed-off-by: Juan Quintela (cherry picked from commit 0db65d624e0211a43c011579d6607a50d8f06082) Signed-off-by: Michael Roth --- page_cache.c |1 + 1 file changed, 1 insertion(+) diff --git a/page_cache.c b

[Qemu-devel] [PATCH 32/37] qcow2: flush refcount cache correctly in qcow2_write_snapshots()

2013-04-02 Thread Michael Roth
From: Stefan Hajnoczi Since qcow2 metadata is cached we need to flush the caches, not just the underlying file. Use bdrv_flush(bs) instead of bdrv_flush(bs->file). Also add the error return path when bdrv_flush() fails and move the flush after checking for qcow2_alloc_clusters() failure so that

Re: [Qemu-devel] [PATCH] Add configure clock_gettime() monotonic time test

2013-04-02 Thread Brad Smith
On Tue, Apr 02, 2013 at 06:45:17PM +0200, Paolo Bonzini wrote: > Il 02/04/2013 17:42, Brad Smith ha scritto: > > Replace the hardcoded list of OS's utilizing clock_gettime() for monotonic > > time with a configure test. This is to fix the use of monotonic time on > > OpenBSD but allows for other PO

[Qemu-devel] [PATCH 30/37] page_cache: fix memory leak

2013-04-02 Thread Michael Roth
From: Peter Lieven XBZRLE encoded migration introduced a MRU page cache meachnism. Unfortunately, cached items where never freed in case of a collision in the page cache on cache_insert(). This lead to out of memory conditions during XBZRLE migration if the page cache was small and there where a

[Qemu-devel] [PATCH 05/37] qemu-char.c: fix waiting for telnet connection message

2013-04-02 Thread Michael Roth
From: Igor Mitsyanko Current colon position in "waiting for telnet connection" message template produces messages like: QEMU waiting for connection on: telnet::127.0.0.1,server After moving a colon to the right, we will get a correct messages like: QEMU waiting for connection on: telnet:127.

[Qemu-devel] [PATCH 04/37] tap: forbid creating multiqueue tap when hub is used

2013-04-02 Thread Michael Roth
From: Jason Wang Obviously, hub does not support multiqueue tap. So this patch forbids creating multiple queue tap when hub is used to prevent the crash when command line such as "-net tap,queues=2" is used. Cc: qemu-sta...@nongnu.org Signed-off-by: Jason Wang Signed-off-by: Stefan Hajnoczi (c

Re: [Qemu-devel] [PATCHv2] rdma: add a new IB_ACCESS_GIFT flag

2013-04-02 Thread Michael R. Hines
I'm getting around to it, Michael, I promise =). Just came back from vacation. I have to re-build the ib_ucm kernel module from the original SUSE kernel that I'm using along before I can test it.. The machines I'm using are slightly tied up with other things, so its taking me a little ti

Re: [Qemu-devel] RFC: vfio API changes needed for powerpc

2013-04-02 Thread Scott Wood
On 04/02/2013 04:16:11 PM, Alex Williamson wrote: On Tue, 2013-04-02 at 15:54 -0500, Stuart Yoder wrote: > The number of windows is always power of 2 (and max is 256). And to reduce > PAMU cache pressure you want to use the fewest number of windows > you can.So, I don't see practically ho

Re: [Qemu-devel] RFC: vfio API changes needed for powerpc

2013-04-02 Thread Scott Wood
On 04/02/2013 04:08:27 PM, Stuart Yoder wrote: On Tue, Apr 2, 2013 at 3:57 PM, Scott Wood wrote: >> This could also be done as another "type2" ioctl extension. > > > Again, what is "type2", specifically? If someone else is adding their own > IOMMU that is kind of, sort of like PAMU, how wou

[Qemu-devel] [PATCH 31/37] qcow2: flush refcount cache correctly in alloc_refcount_block()

2013-04-02 Thread Michael Roth
From: Stefan Hajnoczi update_refcount() affects the refcount cache, it does not write to disk. Therefore bdrv_flush(bs->file) does nothing. We need to flush the refcount cache in order to write out the refcount updates! While we're here also add error returns when qcow2_cache_flush() fails. Si

Re: [Qemu-devel] Patch Round-up for stable 1.4.1, freeze next Tuesday

2013-04-02 Thread Eric Blake
On 04/02/2013 03:45 PM, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v1.4.1: > > https://github.com/mdroth/qemu/commits/stable-1.4-staging > > The release is planned for 04-15-2013: > > http://wiki.qemu.org/Planning/1.4 > > Please CC qemu-sta...@n

[Qemu-devel] [PATCH 37/37] update seabios to 1.7.2.1

2013-04-02 Thread Michael Roth
From: Gerd Hoffmann Alex Williamson (3): seabios q35: Enable all PIRQn IRQs at startup seabios q35: Add new PCI slot to irq routing function seabios: Add a dummy PCI slot to irq mapping function Avik Sil (1): USB-EHCI: Fix null pointer assignment Kevin O'Connor (4):

[Qemu-devel] [PATCH 36/37] linux-user/syscall.c: Don't warn about unimplemented get_robust_list

2013-04-02 Thread Michael Roth
From: Peter Maydell The nature of the kernel ABI for the get_robust_list and set_robust_list syscalls means we cannot implement them in QEMU. Make get_robust_list silently return ENOSYS rather than using the default "print message and then fail ENOSYS" code path, in the same way we already do for

[Qemu-devel] [PATCH 34/37] linux-user: fix futex strace of FUTEX_CLOCK_REALTIME

2013-04-02 Thread Michael Roth
From: John Rigby Handle same as existing FUTEX_PRIVATE_FLAG. Signed-off-by: John Rigby Signed-off-by: Riku Voipio (cherry picked from commit bfb669f39f2ecd854992924ced20b00163509043) Signed-off-by: Michael Roth --- linux-user/strace.c |6 ++ 1 file changed, 6 insertions(+) diff --g

[Qemu-devel] [PATCH 35/37] linux-user: make bogus negative iovec lengths fail EINVAL

2013-04-02 Thread Michael Roth
From: Peter Maydell If the guest passes us a bogus negative length for an iovec, fail EINVAL rather than proceeding blindly forward. This fixes some of the error cases tests for readv and writev in the LTP. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Signed-off-by: Riku Voipio

[Qemu-devel] [PATCH 28/37] virtio-blk: fix unplug + virsh reboot

2013-04-02 Thread Michael Roth
From: Christian Borntraeger virtio-blk registers a vmstate change handler. Unfortunately this handler is not unregistered on unplug, leading to some random crashes if the system is restarted, e.g. via virsh reboot. Lets unregister the vmstate change handler if the device is removed. Signed-off-b

[Qemu-devel] [PATCH 27/37] ide/macio: Fix macio DMA initialisation.

2013-04-02 Thread Michael Roth
From: Mark Cave-Ayland Commit 07a7484e5d713f1eb7c1c37b18a8ab0d56d88875 accidentally introduced a bug in the initialisation of the second macio DMA device which could cause some DMA operations to segfault QEMU. CC: Andreas Färber Signed-off-by: Mark Cave-Ayland Acked-by: Andreas Färber Signed-

[Qemu-devel] [PATCH 25/37] pseries: Add cleanup hook for PAPR virtual LAN device

2013-04-02 Thread Michael Roth
From: David Gibson Currently the spapr-vlan device does not supply a cleanup call for its NetClientInfo structure. With current qemu versions, that leads to a SEGV on exit, when net_cleanup() attempts to call the cleanup handlers on all net clients. Signed-off-by: David Gibson Signed-off-by: A

[Qemu-devel] [PATCH 22/37] virtio-ccw: Queue sanity check for notify hypercall.

2013-04-02 Thread Michael Roth
From: Cornelia Huck Verify that the virtio-ccw notify hypercall passed a reasonable value for queue. Cc: qemu-sta...@nongnu.org Reported-by: Alexander Graf Signed-off-by: Cornelia Huck (cherry picked from commit b57ed9bf075e33cdd2f9eb545ff555301dd57221) Signed-off-by: Michael Roth --- hw/s3

[Qemu-devel] [PATCH 21/37] tcg: Fix occasional TCG broken problem when ldst optimization enabled

2013-04-02 Thread Michael Roth
From: Yeongkyoon Lee is_tcg_gen_code() checks the upper limit of TCG generated code range wrong, so that TCG could get broken occasionally only when CONFIG_QEMU_LDST_OPTIMIZATION enabled. The reason is code_gen_buffer_max_size does not cover the upper range up to (TCG_MAX_OP_SIZE * OPC_BUF_SIZE),

[Qemu-devel] [PATCH 18/37] qcow2: make is_allocated return true for zero clusters

2013-04-02 Thread Michael Roth
From: Paolo Bonzini Otherwise, live migration of the top layer will miss zero clusters and let the backing file show through. This also matches what is done in qed. QCOW2_CLUSTER_ZERO clusters are invalid in v2 image files. Check this directly in qcow2_get_cluster_offset instead of replicating

[Qemu-devel] [PATCH 19/37] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-04-02 Thread Michael Roth
Hosts hold on to handles provided by guest-file-open for periods that can span beyond the life of the qemu-ga process that issued them. Since these are issued starting from 0 on every restart, we run the risk of issuing duplicate handles after restarts/reboots. As a result, users with a stale copy

[Qemu-devel] [PATCH 17/37] pseries: Add compatible property to root of device tree

2013-04-02 Thread Michael Roth
From: David Gibson Currently, for the pseries machine the device tree supplied by qemu to SLOF and from there to the guest does not include a 'compatible property' at the root level. Usually that works fine, since in this case the compatible property doesn't really give any information not alrea

[Qemu-devel] [PATCH 16/37] Allow virtio-net features for legacy s390 virtio bus

2013-04-02 Thread Michael Roth
From: Christian Borntraeger Enable all virtio-net features for the legacy s390 virtio bus. This also fixes kernel BUG at /usr/src/packages/BUILD/kernel-default-3.0.58/linux-3.0/drivers/s390/kvm/kvm_virtio.c:121! Signed-off-by: Christian Borntraeger Cc: qemu-sta...@nongnu.org Signed-off-by: Ale

  1   2   3   4   >