Re: [Qemu-devel] [PATCH] scsi-bus: fix endianness bug in store_lun()

2013-03-16 Thread Benjamin Herrenschmidt
On Sat, 2013-03-16 at 14:09 +0100, Paolo Bonzini wrote: > > The confusion comes from the old SCSI protocol LUN as a 2 bytes number > > identifying a unit for a given bus/device and the "new style" LUN as a > > more generic concept such as used in SRP (ie vscsi is SRP) which > > encompass the bus,

Re: [Qemu-devel] [PATCH] hw/vexpress: set default block type to SD

2013-03-16 Thread Peter Maydell
On 17 March 2013 00:04, Aurelien Jarno wrote: > On Fri, Mar 15, 2013 at 03:45:11PM +, Peter Maydell wrote: >> On 15 March 2013 15:42, Aurelien Jarno wrote: >> > On Fri, Mar 15, 2013 at 03:35:48PM +, Peter Maydell wrote: >> >> I'm not convinced this is a good thing -- I think you should ha

Re: [Qemu-devel] [PATCH] hw/vexpress: set default block type to SD

2013-03-16 Thread Aurelien Jarno
On Fri, Mar 15, 2013 at 03:45:11PM +, Peter Maydell wrote: > On 15 March 2013 15:42, Aurelien Jarno wrote: > > On Fri, Mar 15, 2013 at 03:35:48PM +, Peter Maydell wrote: > >> I'm not convinced this is a good thing -- I think you should have > >> to know that you're attaching an SD card and

Re: [Qemu-devel] Qemu Irq No. 7

2013-03-16 Thread Aurelien Jarno
On Fri, Mar 15, 2013 at 05:40:09PM +0500, Muhammad Nouman wrote: > Hi ! i am emulating mips on Qemu and while the kernel is booting ,i am > getting irq no. 7 from Qemu.Can any one tell what is the source for irq > no. 7 and how can i disable that?? There are different mips machines available in Q

[Qemu-devel] [PATCH v6 0/2] qdev: Detect duplicate device properties

2013-03-16 Thread Peter Maydell
Detect and abort on duplicate properties in a qdev Property array. This patchset actually dates back to October last year (and got reviewed then, hence Anthony's r-b tags) but it didn't get applied (maybe we were in codefreeze) and I forgot about it. Anyway, I've rebased it so here we are again.

[Qemu-devel] [PATCH v6 1/2] qom: Detect attempts to add a property that already exists

2013-03-16 Thread Peter Maydell
Detect attempts to add a property to an object if one of that name already exists, and report them as errors. Signed-off-by: Peter Maydell Reviewed-by: Anthony Liguori --- qom/object.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/qom/object.c b/qom/object.

[Qemu-devel] [PATCH v6 2/2] hw/qdev: Abort rather than ignoring errors adding device properties

2013-03-16 Thread Peter Maydell
Instead of ignoring any errors that occur when adding properties to a new device in device_initfn(), check for them and abort if any occur. The most likely cause is accidentally adding a duplicate property, which is a programming error by the device author. Signed-off-by: Peter Maydell Reviewed-b

[Qemu-devel] [Bug 1015978] Re: USB serial port regression after qemu-kvm_1.0+dfsg-8

2013-03-16 Thread Attila Lendvai
using 1.1.2+dfsg-5 it seems to be fixed/gone. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1015978 Title: USB serial port regression after q

Re: [Qemu-devel] [PATCH] scsi-bus: fix endianness bug in store_lun()

2013-03-16 Thread Alexey Kardashevskiy
On 17/03/13 00:01, Benjamin Herrenschmidt wrote: On Sat, 2013-03-16 at 23:11 +1100, Alexey Kardashevskiy wrote: No, LUNs are composed of four 2-byte big-endian values. I cannot find it in "SCSI Commands References Manual" (for example here - http://www.seagate.com/staticfiles/support/disc/manu

[Qemu-devel] [PATCH] HLFS driver for QEMU

2013-03-16 Thread harryxiyou
From: Harry Wei HLFS is HDFS-based(Hadoop Distributed File System) Log-Structured File System. Actually, HLFS, currently, is not a FS but a block-storage system, which we simplify LFS to fit block-level storage. So you could also call HLFS as HLBS (HDFS-based Log-Structured Block-storage System).

Re: [Qemu-devel] [PATCH] scsi-bus: fix endianness bug in store_lun()

2013-03-16 Thread Paolo Bonzini
Il 16/03/2013 14:01, Benjamin Herrenschmidt ha scritto: > On Sat, 2013-03-16 at 23:11 +1100, Alexey Kardashevskiy wrote: >>> No, LUNs are composed of four 2-byte big-endian values. >> >> I cannot find it in "SCSI Commands References Manual" >> (for example here - >> http://www.seagate.com/staticfi

Re: [Qemu-devel] [PATCH] scsi-bus: fix endianness bug in store_lun()

2013-03-16 Thread Benjamin Herrenschmidt
On Sat, 2013-03-16 at 23:11 +1100, Alexey Kardashevskiy wrote: > > No, LUNs are composed of four 2-byte big-endian values. > > I cannot find it in "SCSI Commands References Manual" > (for example here - > http://www.seagate.com/staticfiles/support/disc/manuals/Interface% > 20manuals/100293068c.pd

Re: [Qemu-devel] Trouble with adding TCG branch instructions

2013-03-16 Thread Soumyadeep Ghosh
Thanks a lot! The problem was with using dead temporaries. The ts->val_type assertion failed because the value of val_type for these instructions was TEMP_VAL_DEAD. Deep On Mar 16, 2013, at 5:44 AM, Peter Maydell wrote: > On 15 March 2013 18:59, Soumyadeep Ghosh > wrote: >>int label

Re: [Qemu-devel] [PATCH] scsi-bus: fix endianness bug in store_lun()

2013-03-16 Thread Alexey Kardashevskiy
On 16/03/13 19:13, Paolo Bonzini wrote: Il 16/03/2013 08:16, Alexey Kardashevskiy ha scritto: SCSI protocol is defined as big endian. The SCSI command REPORT_LUNS returns the list of LUNs, 8 bytes each. The store_lun() function is called from scsi_target_emulate_report_luns() to fill the LUNs l

Re: [Qemu-devel] [Qemu-ppc] [PATCH] pseries: Fix breakage in CPU QOM conversion

2013-03-16 Thread David Gibson
On Fri, Mar 15, 2013 at 06:29:50PM +0100, Andreas Färber wrote: > Am 15.03.2013 04:59, schrieb David Gibson: > > Commit 259186a7d2f7184efc96ae99bc5658e6159f53ad "cpu: Move halted and > > interrupt_request fields to CPUState" broke the pseries machine. That's > > because it uses CPU() instead of EN

Re: [Qemu-devel] Trouble with adding TCG branch instructions

2013-03-16 Thread Peter Maydell
On 15 March 2013 18:59, Soumyadeep Ghosh wrote: > int label_rn = gen_new_label(); > int label_done = gen_new_label(); > tcg_gen_brcond_tl (TCG_cond_LT, tmp2, tmp, label_rn); // If tmp2 > < tmp, branch to label_rn > store_reg (s, 20, tmp2);

[Qemu-devel] [Bug 1155403] Re: virtio cdrom detected as hard disk

2013-03-16 Thread Paolo Bonzini
There's no such thing as a virtio-blk CD-ROM, only hard-disks. For installation it shouldn't matter, since .iso images usually can work also as hard-disk images (for putting them on a USB stick). If you want to test installation from a "real" virtio CD-ROM, use virtio-scsi: -drive file=/path/to/f

Re: [Qemu-devel] large memory requirements for translate.c a barrier

2013-03-16 Thread Paolo Bonzini
Il 15/03/2013 20:21, Todd T. Fries ha scritto: > PID USERNAME PRI NICE SIZE RES STATE WAIT TIMECPU COMMAND > 28818 todd 640 1142M 53M onproc/0 - 2:01 17.24% cc1 > > For systems with lower limits on user process memory, this prevents things > from building. >

Re: [Qemu-devel] [PATCH] scsi-bus: fix endianness bug in store_lun()

2013-03-16 Thread Paolo Bonzini
Il 16/03/2013 08:16, Alexey Kardashevskiy ha scritto: > SCSI protocol is defined as big endian. The SCSI command REPORT_LUNS > returns the list of LUNs, 8 bytes each. > > The store_lun() function is called from scsi_target_emulate_report_luns() > to fill the LUNs list which is sent later to a gues

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] pseries: Fixes and enhancements to L1 cache properties

2013-03-16 Thread David Gibson
On Fri, Mar 15, 2013 at 01:27:09PM +0100, Alexander Graf wrote: > On 14.03.2013, at 02:53, David Gibson wrote: > > > PAPR requires that the device tree's CPU nodes have several properties > > with information about the L1 cache. We already create two of these > > properties, but with incorrect na

[Qemu-devel] [PATCH] scsi-bus: fix endianness bug in store_lun()

2013-03-16 Thread Alexey Kardashevskiy
SCSI protocol is defined as big endian. The SCSI command REPORT_LUNS returns the list of LUNs, 8 bytes each. The store_lun() function is called from scsi_target_emulate_report_luns() to fill the LUNs list which is sent later to a guest a response. However it puts the 2 bytes long big-endian value