Re: [Qemu-devel] [PATCH V7 09/14] block: move bdrv_snapshot_find() to block.c

2013-03-04 Thread Wenchao Xia
于 2013-3-4 21:02, Stefan Hajnoczi 写道: On Fri, Mar 01, 2013 at 09:51:53AM +0800, Wenchao Xia wrote: > 于 2013-2-28 0:22, Kevin Wolf 写道: Am 27.02.2013 um 17:04 hat Markus Armbruster geschrieben: Wenchao Xia writes: Signed-off-by: Wenchao Xia Reviewed-by: Eric Blake --- block.c

Re: [Qemu-devel] [PATCH v12 rebased] kvm: notify host when the guest is panicked

2013-03-04 Thread Gleb Natapov
On Mon, Mar 04, 2013 at 05:43:48PM -0300, Marcelo Tosatti wrote: > On Mon, Mar 04, 2013 at 07:49:13PM +0200, Gleb Natapov wrote: > > On Sun, Mar 03, 2013 at 07:29:53PM -0300, Marcelo Tosatti wrote: > > > On Sun, Mar 03, 2013 at 03:00:22PM +0200, Gleb Natapov wrote: > > > > On Fri, Mar 01, 2013 at 0

[Qemu-devel] QEMU -netdev vhost=on + -device virtio-net-pci bug

2013-03-04 Thread Alexey Kardashevskiy
Hi! The patch f56a12475ff1b8aa61210d08522c3c8aaf0e2648 "vhost: backend masking support" breaks virtio-net + vhost=on on PPC64 platform. The problem command line is: 1) -netdev tap,id=tapnet,ifname=tap0,script=qemu-ifup.sh,vhost=on \ -device virtio-net-pci,netdev=tapnet,addr=0.0 \ Without the

Re: [Qemu-devel] default guest RAM size?

2013-03-04 Thread Peter Maydell
On 5 March 2013 14:07, 陳韋任 (Wei-Ren Chen) wrote: > On Tue, Mar 05, 2013 at 01:40:38PM +0800, Peter Maydell wrote: >> On 5 March 2013 13:26, Michael Tokarev wrote: >> > For many years, qemu defaults to 128Mb of guest RAM size. >> > Today, this is just too small, and many OSes fails to boot >> > wi

Re: [Qemu-devel] default guest RAM size?

2013-03-04 Thread Wei-Ren Chen
On Tue, Mar 05, 2013 at 01:40:38PM +0800, Peter Maydell wrote: > On 5 March 2013 13:26, Michael Tokarev wrote: > > For many years, qemu defaults to 128Mb of guest RAM size. > > Today, this is just too small, and many OSes fails to boot > > with this size, more, they fail to produce any reasonable

Re: [Qemu-devel] default guest RAM size?

2013-03-04 Thread Peter Maydell
On 5 March 2013 13:26, Michael Tokarev wrote: > For many years, qemu defaults to 128Mb of guest RAM size. > Today, this is just too small, and many OSes fails to boot > with this size, more, they fail to produce any reasonable > messages either (eg, windows7 just crashes at startup). If you make

[Qemu-devel] default guest RAM size?

2013-03-04 Thread Michael Tokarev
For many years, qemu defaults to 128Mb of guest RAM size. Today, this is just too small, and many OSes fails to boot with this size, more, they fail to produce any reasonable messages either (eg, windows7 just crashes at startup). Some distributions (eg ubuntu) had a local patch to increase this v

Re: [Qemu-devel] virtio-rng and fd passing

2013-03-04 Thread H. Peter Anvin
On 03/02/2013 04:23 AM, Paolo Bonzini wrote: > Il 02/03/2013 04:13, Anthony Liguori ha scritto: >> There is no valid use-case of rng-random other than using /dev/random. >> In fact, it was probably a mistake to even allow a filename to be >> specified because it lets people do silly things (like /d

Re: [Qemu-devel] [PATCH v13 2/8] start vm after resetting it

2013-03-04 Thread Hu Tao
On Mon, Mar 04, 2013 at 10:32:17AM +0100, Paolo Bonzini wrote: > Il 28/02/2013 13:13, Hu Tao ha scritto: > > From: Wen Congyang > > > > The guest should run after resetting it, but it does not run if its > > old state is RUN_STATE_INTERNAL_ERROR or RUN_STATE_PAUSED. > > > > We don't set runstate

Re: [Qemu-devel] [PATCH v13 2/8] start vm after resetting it

2013-03-04 Thread Hu Tao
On Thu, Feb 28, 2013 at 02:23:42PM +0100, Jan Kiszka wrote: > On 2013-02-28 13:13, Hu Tao wrote: > > From: Wen Congyang > > > > The guest should run after resetting it, but it does not run if its > > old state is RUN_STATE_INTERNAL_ERROR or RUN_STATE_PAUSED. > > > > We don't set runstate to RUN_

Re: [Qemu-devel] [PATCH v13 5/8] add a new qevent: QEVENT_GUEST_PANICKED

2013-03-04 Thread Hu Tao
On Fri, Mar 01, 2013 at 09:31:47AM -0700, Eric Blake wrote: > On 02/28/2013 05:13 AM, Hu Tao wrote: > > This event will be emited when the guest is panicked. > > > > Signed-off-by: Wen Congyang > > --- > > include/monitor/monitor.h | 1 + > > monitor.c | 1 + > > 2 files changed,

Re: [Qemu-devel] [PATCH v13 4/8] add a new runstate: RUN_STATE_GUEST_PANICKED

2013-03-04 Thread Hu Tao
On Mon, Mar 04, 2013 at 10:40:15AM +0100, Paolo Bonzini wrote: > Il 28/02/2013 13:13, Hu Tao ha scritto: > > The guest will be in this state when it is panicked. > > > > Signed-off-by: Wen Congyang > > Signed-off-by: Hu Tao > > --- > > migration.c | 1 + > > qapi-schema.json | 6 +- >

Re: [Qemu-devel] [PATCH 2/3] net: introduce lock to protect NetClientState's send_queue

2013-03-04 Thread liu ping fan
On Tue, Mar 5, 2013 at 10:45 AM, liu ping fan wrote: > On Mon, Mar 4, 2013 at 10:49 PM, Stefan Hajnoczi wrote: >> On Sun, Mar 03, 2013 at 09:21:21PM +0800, Liu Ping Fan wrote: >>> From: Liu Ping Fan >>> >>> Use nc->transfer_lock to protect the nc->peer->send_queue. All of the >> >> Please use co

Re: [Qemu-devel] [PATCH 3/3] net: make netclient re-entrant with refcnt

2013-03-04 Thread liu ping fan
On Mon, Mar 4, 2013 at 11:19 PM, Stefan Hajnoczi wrote: > On Sun, Mar 03, 2013 at 09:21:22PM +0800, Liu Ping Fan wrote: >> diff --git a/net/hub.c b/net/hub.c >> index 97c3ac3..ab4448e 100644 >> --- a/net/hub.c >> +++ b/net/hub.c >> @@ -36,6 +36,7 @@ typedef struct NetHubPort { >> } NetHubPort; >>

Re: [Qemu-devel] [PATCH 1/3] net: spread hub on AioContexts

2013-03-04 Thread liu ping fan
On Mon, Mar 4, 2013 at 10:35 PM, Stefan Hajnoczi wrote: > On Sun, Mar 03, 2013 at 09:21:20PM +0800, Liu Ping Fan wrote: >> @@ -44,6 +47,7 @@ typedef ssize_t (NetReceiveIOV)(NetClientState *, const >> struct iovec *, int); >> typedef void (NetCleanup) (NetClientState *); >> typedef void (LinkSta

Re: [Qemu-devel] [PATCH 2/3] net: introduce lock to protect NetClientState's send_queue

2013-03-04 Thread liu ping fan
On Mon, Mar 4, 2013 at 10:49 PM, Stefan Hajnoczi wrote: > On Sun, Mar 03, 2013 at 09:21:21PM +0800, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> Use nc->transfer_lock to protect the nc->peer->send_queue. All of the > > Please use consistent names: the lock protects ->send_queue so it's best >

Re: [Qemu-devel] [PATCH 2/3] net: introduce lock to protect NetClientState's send_queue

2013-03-04 Thread liu ping fan
On Mon, Mar 4, 2013 at 11:04 PM, Paolo Bonzini wrote: > Il 04/03/2013 15:49, Stefan Hajnoczi ha scritto: >> > Use nc->transfer_lock to protect the nc->peer->send_queue. All of the >> >> Please use consistent names: the lock protects ->send_queue so it's best >> called send_queue_lock or send_lock.

Re: [Qemu-devel] [PATCH v13 1/8] save/load cpu runstate

2013-03-04 Thread Hu Tao
On Mon, Mar 04, 2013 at 10:30:48AM +0100, Paolo Bonzini wrote: > Il 28/02/2013 13:13, Hu Tao ha scritto: > > This patch enables preservation of cpu runstate during save/load vm. > > So when a vm is restored from snapshot, the cpu runstate is restored, > > too. > > I don't think this feature is wor

[Qemu-devel] [Seabios PATCH] make reboot-timeout to static for using it after POST phase

2013-03-04 Thread Amos Kong
From: Kevin O'Connor Memory allocated with malloc_tmp() can't be used after the POST phase. The reboot-timeout inside romfile could not be loaded in boot_fail(). The patch saved reboot-timeout to a static variable, it fixed the regression bug introduced by commit 59d6ca52 I already tested this p

[Qemu-devel] [PATCH 07/13] ARM KVM: save and load VFP registers from kernel

2013-03-04 Thread Peter Maydell
Add support for saving and restoring VFP register state from the kernel. This includes a check that the KVM-created CPU has full VFP support (as the TCG Cortex-A15 model always does), since for the moment ARM QEMU doesn't have any way to tweak optional features on created CPUs. Signed-off-by: Pete

[Qemu-devel] [PATCH 13/13] MAINTAINERS: add entry for ARM KVM guest cores

2013-03-04 Thread Peter Maydell
Add an entry indicating maintainer status for the ARM KVM code. Signed-off-by: Peter Maydell --- MAINTAINERS |5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 21043e4..2439614 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -140,6 +140,11 @@ S: Supported

[Qemu-devel] [PATCH 01/13] target-arm: Factor out handling of SRS instruction

2013-03-04 Thread Peter Maydell
Factor out the handling of the SRS instruction rather than duplicating it between the Thumb and ARM decoders. This in passing fixes two bugs in the Thumb decoder's SRS handling which didn't exist in the ARM decoder: * (LP:1079080) storing CPSR rather than SPSR (fixed in the ARM decoder in commi

[Qemu-devel] [PATCH 04/13] linux-headers: resync from mainline to add ARM KVM headers

2013-03-04 Thread Peter Maydell
Resync QEMU's copy of the Linux kernel headers from git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master commit 2ef14f4. This adds the ARM KVM headers, since ARM KVM support has just hit mainline via Russell's ARM tree. This is not a pure sync -- I have removed by hand some chan

[Qemu-devel] [PATCH 08/13] hw/arm_gic: Add presave/postload hooks

2013-03-04 Thread Peter Maydell
Add presave/postload hooks to the ARM GIC common base class. These will be used by the KVM in-kernel GIC subclass to sync state between kernel and userspace when migrating. Signed-off-by: Peter Maydell Reviewed-by: Andreas Färber Reviewed-by: Paolo Bonzini --- hw/arm_gic_common.c | 10

[Qemu-devel] [PATCH 11/13] hw/kvm/arm_gic: Implement support for KVM in-kernel ARM GIC

2013-03-04 Thread Peter Maydell
Implement support for using the KVM in-kernel GIC for ARM. Signed-off-by: Peter Maydell Reviewed-by: Andreas Färber --- hw/a15mpcore.c |8 ++- hw/arm/Makefile.objs |1 + hw/kvm/arm_gic.c | 167 ++ 3 files changed, 175 insertions

[Qemu-devel] [PATCH 05/13] target-arm: Drop CPUARMState* argument from bank_number()

2013-03-04 Thread Peter Maydell
Drop the CPUARMState* argument from bank_number(), since we only use it for passing to cpu_abort(). Use hw_error() instead. This avoids propagating further interfaces using env pointers. In the long term this function's callers need auditing to fix problems where badly behaved guests can pass inva

[Qemu-devel] [PATCH 02/13] target-arm: Don't decode RFE or SRS on M profile cores

2013-03-04 Thread Peter Maydell
M profile cores do not have the RFE or SRS instructions, so correctly UNDEF these insn patterns on those cores. Signed-off-by: Peter Maydell --- target-arm/translate.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c inde

[Qemu-devel] [PATCH 03/13] oslib-posix: Align to permit transparent hugepages on ARM Linux

2013-03-04 Thread Peter Maydell
ARM Linux (like x86-64 Linux) can use transparent hugepages for KVM if memory blocks are 2MiB aligned; set QEMU_VMALLOC_ALIGN accordingly. Signed-off-by: Peter Maydell Reviewed-by: Paolo Bonzini --- util/oslib-posix.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/o

[Qemu-devel] [PULL 00/13] target-arm queue (feat.ARM KVM support)

2013-03-04 Thread Peter Maydell
Hi; here's a target-arm pullre. Major business here is the KVM support patchset, though there are a couple of SRS bugfixes too. Please pull. thanks -- PMM The following changes since commit 26135ead80fa1fd13e95c162dacfd06f2ba82981: target-mips: Fix accumulator selection for MIPS16 and microMIP

[Qemu-devel] [PATCH 09/13] hw/arm_gic: Convert ARM GIC classes to use init/realize

2013-03-04 Thread Peter Maydell
Convert the ARM GIC classes to use init/realize rather than SysBusDevice::init. (We have to do them all in one patch to avoid unconverted subclasses calling a nonexistent SysBusDevice init function in the base class and crashing.) Signed-off-by: Peter Maydell Reviewed-by: Andreas Färber --- hw/

[Qemu-devel] [PATCH 10/13] target-arm: Use MemoryListener to identify GIC base address for KVM

2013-03-04 Thread Peter Maydell
When using an in-kernel GIC with KVM, we need to tell the kernel where the GIC's memory mapped registers live. Do this by registering a MemoryListener which tracks where the board model maps the A15's private peripherals, so we can finish the GIC initialisation when the GIC is actually mapped. Sig

[Qemu-devel] [PATCH 06/13] ARM: KVM: Add support for KVM on ARM architecture

2013-03-04 Thread Peter Maydell
From: Christoffer Dall Add basic support for KVM on ARM architecture. Signed-off-by: Christoffer Dall [PMM: Minor tweaks and code cleanup, switch to ONE_REG] Signed-off-by: Peter Maydell Reviewed-by: Paolo Bonzini --- hw/arm_pic.c | 26 target-arm/Makefile.objs |1 + t

[Qemu-devel] [PATCH 12/13] configure: Enable KVM on ARM

2013-03-04 Thread Peter Maydell
Enable KVM on ARM hosts, now that all the necessary components for it exist. Signed-off-by: Peter Maydell Reviewed-by: Paolo Bonzini --- configure |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 19738ac..b4deb9b 100755 --- a/configure +++ b/con

Re: [Qemu-devel] [PATCH] rng: restrict passthrough names to known-good files

2013-03-04 Thread Eric Blake
On 03/04/2013 04:31 PM, Anthony Liguori wrote: > Eric Blake writes: > >> There is some controversy[1] on the qemu list on whether qemu should >> have ever allowed arbitrary file name passthrough, or whether it >> should be restricted to JUST /dev/random and /dev/hwrng. It is >> always easier to

[Qemu-devel] [PATCH v2 25/27] tcg-ppc64: Use getauxval for ISA detection

2013-03-04 Thread Richard Henderson
Glibc 2.16 includes an easy way to get feature bits previously buried in /proc or the program startup auxiliary vector. Use it. Signed-off-by: Richard Henderson --- configure | 18 ++ tcg/ppc64/tcg-target.c | 20 +++- 2 files changed, 37 insertions(+

Re: [Qemu-devel] [PATCH V7 00/14] add qmp/hmp interfaces for internal snapshot info

2013-03-04 Thread Eric Blake
On 03/04/2013 06:10 AM, Stefan Hajnoczi wrote: >>> It is also useful to include QMP examples or the QMP docs in the cover >>> letter so reviewers know what you are trying to achieve. >>> >> OK, a better explaination would be added in the cover-letter. > > Thanks. When reviewers don't know your

[Qemu-devel] [PATCH v2 21/27] tcg-ppc64: Use I constraint for mul

2013-03-04 Thread Richard Henderson
The mul_i32 pattern was loading non-16-bit constants into a register, when we can get the middle-end to do that for us. The mul_i64 pattern was not considering that MULLI takes 64-bit inputs. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 24 1 file chang

Re: [Qemu-devel] [PATCH] hw/vexpress: set default block type to SD

2013-03-04 Thread Aurelien Jarno
On Tue, Mar 05, 2013 at 08:22:57AM +0800, Peter Maydell wrote: > On 5 March 2013 08:19, Aurelien Jarno wrote: > > The versatile express has no SCSI card, but instead boot on an SD card. > > Change block_default_type accordingly. > > I notice that no other board has SD as the block_default_type...

[Qemu-devel] [PATCH v2 17/27] tcg-ppc64: Implement bswap64

2013-03-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 35 +++ tcg/ppc64/tcg-target.h | 2 +- 2 files changed, 36 insertions(+), 1 deletion(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 723cc77..576effc 100644 --- a/tcg/ppc64/tcg-ta

[Qemu-devel] [PATCH v2 24/27] tcg-ppc64: Implement movcond

2013-03-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 59 ++ tcg/ppc64/tcg-target.h | 4 ++-- 2 files changed, 61 insertions(+), 2 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index bc29738..2acccf6 100644 ---

[Qemu-devel] [PATCH v2 16/27] tcg-ppc64: Implement bswap16 and bswap32

2013-03-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 43 +++ tcg/ppc64/tcg-target.h | 18 ++ 2 files changed, 53 insertions(+), 8 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index a08ad90..723cc77 1006

[Qemu-devel] [PATCH v2 22/27] tcg-ppc64: Use TCGType throughout compares

2013-03-04 Thread Richard Henderson
The optimization/bug being fixed is that tcg_out_cmp was not applying the right type to loading a constant, in the case it can't be implemented directly. Rather than recomputing the TCGType enum from the arch64 bool, pass around the original TCGType throughout. Signed-off-by: Richard Henderson -

[Qemu-devel] [PATCH v2 14/27] tcg-ppc64: Streamline qemu_ld/st insn selection

2013-03-04 Thread Richard Henderson
Using a table to look up insns of the right width and sign. Include support for the Power 2.05 LDBRX and STDBRX insns included in e.g. Power6. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 166 + 1 file changed, 56 insertions(+), 11

[Qemu-devel] [PATCH v2 20/27] tcg-ppc64: Implement deposit

2013-03-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 12 tcg/ppc64/tcg-target.h | 4 ++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index c1d974b..8114334 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg/ppc

[Qemu-devel] [PATCH v2 13/27] tcg-ppc64: Improve and_i64 with constant

2013-03-04 Thread Richard Henderson
Use RLDICL and RLDICR. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 64 +++--- 1 file changed, 50 insertions(+), 14 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index ad6db6c..51a5545 100644 --- a/tcg/ppc6

[Qemu-devel] [PATCH v2 27/27] tcg-ppc64: Implement mulu2/muls2_i64

2013-03-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 27 +++ tcg/ppc64/tcg-target.h | 4 ++-- 2 files changed, 29 insertions(+), 2 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 7f3e76d..334b030 100644 --- a/tcg/ppc64/tcg-target.

[Qemu-devel] [PATCH v2 19/27] tcg-ppc64: Handle constant inputs for some compound logicals

2013-03-04 Thread Richard Henderson
Since we have special code to handle and/or/xor with a constant, apply the same to andc/orc/eqv with a constant. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 44 ++-- 1 file changed, 34 insertions(+), 10 deletions(-) diff --git a/tcg/ppc6

[Qemu-devel] [PATCH v2 10/27] tcg-ppc64: Improve constant add and sub ops.

2013-03-04 Thread Richard Henderson
Use SUBFIC to implement subtraction with constant op1. Improve constant addition -- previously we'd emit useless addis with 0. Use new constraints to force the driver to pull full 64-bit constants into a register. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 117 ++

[Qemu-devel] [PATCH v2 26/27] tcg-ppc64: Implement add2/sub2_i64

2013-03-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 56 ++ tcg/ppc64/tcg-target.h | 4 ++-- 2 files changed, 58 insertions(+), 2 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 826726d..7f3e76d 100644 ---

[Qemu-devel] [PATCH v2 11/27] tcg-ppc64: Tidy or and xor patterns.

2013-03-04 Thread Richard Henderson
Handle constants in common code; we'll want to reuse that later. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 55 -- 1 file changed, 31 insertions(+), 24 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c in

[Qemu-devel] [PATCH v2 18/27] tcg-ppc64: Implement compound logicals

2013-03-04 Thread Richard Henderson
Mostly copied from the ppc32 port. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 34 ++ tcg/ppc64/tcg-target.h | 20 ++-- 2 files changed, 44 insertions(+), 10 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target

[Qemu-devel] [PATCH v2 09/27] tcg-ppc64: Rearrange integer constant constraints

2013-03-04 Thread Richard Henderson
We'll need a zero, and Z makes more sense for that. Make sure we have a full compliment of signed and unsigned 16 and 32-bit tests. Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 43 +-- 1 file changed, 33 insertions(+), 10 deletions(-) di

[Qemu-devel] [PATCH v2 23/27] tcg-ppc64: Rewrite setcond

2013-03-04 Thread Richard Henderson
Never use MFCR, as the latency is really high. Even MFOCRF, at half the latency of MFCR, isn't as fast as we can do with carry tricks. The ADDIC+SUBFE trick only works for word-sized operands, as we need carry-out from bit 63. So for ppc64 we must extend 32-bit inputs. Use ISEL if available. S

[Qemu-devel] [PATCH v2 15/27] tcg-ppc64: Implement rotates

2013-03-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 39 +++ tcg/ppc64/tcg-target.h | 4 ++-- 2 files changed, 41 insertions(+), 2 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 4a55ae7..a08ad90 100644 --- a/tcg/ppc64

[Qemu-devel] [PATCH v2 06/27] tcg-ppc64: Introduce and use tcg_out_shri64

2013-03-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 9199ac4..82e1da7 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg/ppc64/tcg-target.c @@ -461,6 +461,11 @@ sta

[Qemu-devel] [PATCH v2 12/27] tcg-ppc64: Improve and_i32 with constant

2013-03-04 Thread Richard Henderson
Use RLWINM Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 50 +- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 9718ef6..ad6db6c 100644 --- a/tcg/ppc64/tcg-target.c

[Qemu-devel] [PATCH v2 05/27] tcg-ppc64: Introduce and use tcg_out_shli64

2013-03-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 84e30ad..9199ac4 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg/ppc64/tcg-target.c @@ -456,6 +456,11 @

[Qemu-devel] [PATCH v2 08/27] tcg-ppc64: Introduce and use TAI and SAI

2013-03-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 138 +++-- 1 file changed, 66 insertions(+), 72 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index a4951c5..31b0cb7 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg

[Qemu-devel] [PATCH v2 07/27] tcg-ppc64: Cleanup tcg_out_movi

2013-03-04 Thread Richard Henderson
The test for using movi32 was sub-optimal for TCG_TYPE_I32, comparing a signed 32-bit quantity against an unsigned 32-bit quantity. When possible, use addi+oris for 32-bit unsigned constants. Otherwise, standardize on addi+oris+ori instead of addis+ori+rldicl. Signed-off-by: Richard Henderson -

[Qemu-devel] [PATCH v2 04/27] tcg-ppc64: Introduce and use tcg_out_ext32u

2013-03-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 3587d0e..84e30ad 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg/ppc64/tcg-target.c @@ -451,6 +451,1

[Qemu-devel] [PATCH v2 02/27] tcg-ppc64: Use TCGReg everywhere

2013-03-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 833fe0c..762ca1b 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg/ppc64/tcg-tar

[Qemu-devel] [PATCH v2 03/27] tcg-ppc64: Introduce and use tcg_out_rlw

2013-03-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 72 ++ 1 file changed, 20 insertions(+), 52 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 762ca1b..3587d0e 100644 --- a/tcg/ppc64/tcg-target.c +++ b/tcg

[Qemu-devel] [PATCH v2 01/27] disas: Disassemble all ppc insns for the host

2013-03-04 Thread Richard Henderson
Signed-off-by: Richard Henderson --- disas.c | 1 + 1 file changed, 1 insertion(+) diff --git a/disas.c b/disas.c index a46faee..c0ac7ec 100644 --- a/disas.c +++ b/disas.c @@ -322,6 +322,7 @@ void disas(FILE *out, void *code, unsigned long size) s.info.mach = bfd_mach_x86_64; print_ins

[Qemu-devel] [PATCH v2 00/27] Modernize tcg/ppc64

2013-03-04 Thread Richard Henderson
Additional patches since V1: * Handle constant inputs for some compound logicals * Implement add2/sub2_i64 * Implement mulu2/muls2_i64 Otherwise unchanged, but rebased vs 26135ead80fa1fd13e95c162dacfd06f2ba82981. Tree available at: git://github.com/rth7680/qemu tcg-ppc64 Please review or

Re: [Qemu-devel] [PATCH][RFC] vl: move unrelated functions out of vl.c

2013-03-04 Thread li guang
Hi, Anthony is it reasonable split? 在 2013-02-28四的 12:45 +0800,liguang写道: > now, lots of other functions which were not related with > mainloop exist in vl.c, e.g. > > numa related functions (numa_add() ...) > bt related functions (bt_parse() ...) > usb related functions (usb_parse() ...) > gui

Re: [Qemu-devel] [PATCH] hw/vexpress: set default block type to SD

2013-03-04 Thread Peter Maydell
On 5 March 2013 08:19, Aurelien Jarno wrote: > The versatile express has no SCSI card, but instead boot on an SD card. > Change block_default_type accordingly. I notice that no other board has SD as the block_default_type... What effect does this actually have on the user experience? Also, won't

[Qemu-devel] [PATCH] hw/vexpress: set default block type to SD

2013-03-04 Thread Aurelien Jarno
The versatile express has no SCSI card, but instead boot on an SD card. Change block_default_type accordingly. Signed-off-by: Aurelien Jarno --- hw/vexpress.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/vexpress.c b/hw/vexpress.c index 741b044..969aae6 100644 --

Re: [Qemu-devel] [PATCH] target-mips: fix mips16 MULT/DIV (broken by ASE_DSP)

2013-03-04 Thread Aurelien Jarno
On Wed, Feb 20, 2013 at 12:57:35PM +0800, Leon Yu wrote: > using bit[11-12] of opcode as acc is not correct for ASE_MIPS16 instructions. > doing so generates RI/DSPDIS exception when decoding MIPS16 MULT/DIV. > > Signed-off-by: Leon Yu > --- > target-mips/translate.c | 14 +++--- > 1 f

Re: [Qemu-devel] [PATCH v5 6/6] KVM: s390: Wire up ioeventfd.

2013-03-04 Thread Marcelo Tosatti
On Thu, Feb 28, 2013 at 12:33:21PM +0100, Cornelia Huck wrote: > Enable ioeventfd support on s390 and hook up diagnose 500 virtio-ccw > notifications. > > Signed-off-by: Cornelia Huck > --- > arch/s390/kvm/Kconfig| 1 + > arch/s390/kvm/Makefile | 2 +- > arch/s390/kvm/diag.c | 26 +++

Re: [Qemu-devel] [PATCH v2] target-mips: Fix accumulator selection for MIPS16 and microMIPS

2013-03-04 Thread Aurelien Jarno
On Mon, Jan 21, 2013 at 08:43:31PM +, Richard Sandiford wrote: > Add accumulator arguments to gen_HILO and gen_muldiv, rather than > extracting the accumulator directly from ctx->opcode. The extraction > was only right for the standard encoding: MIPS16 doesn't have access > to the DSP register

Re: [Qemu-devel] PCI device assign problems!

2013-03-04 Thread Alex Williamson
On Tue, 2013-03-05 at 06:46 +0800, GaoYi wrote: > Hi Alex, > >Thanks for your prompt response. The driver is as following: > > >virt = (u64)kzalloc(size, GFP_KERNEL); > >phy_addr = virt_to_bus((void*)virt_addr); > >iowrite32( phy_addr, (void*

Re: [Qemu-devel] [PATCH] rng: restrict passthrough names to known-good files

2013-03-04 Thread Anthony Liguori
Eric Blake writes: > There is some controversy[1] on the qemu list on whether qemu should > have ever allowed arbitrary file name passthrough, or whether it > should be restricted to JUST /dev/random and /dev/hwrng. It is > always easier to add support for additional filenames than it is > to re

Re: [Qemu-devel] [PATCH] sysbus: add no_user for devices using mmio or IRQ or GPIO

2013-03-04 Thread Peter Maydell
On 5 March 2013 04:16, Paolo Bonzini wrote: > Il 04/03/2013 18:58, Peter Maydell ha scritto: >>> > Mass-mark these devices as no_user. >> "There is no such thing as a 'no-user' device" -- Anthony >> (http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg00896.html) >> >> We should figure out wha

[Qemu-devel] [PATCH 0/3] qga/Linux: online/offline/query VCPUs via guest sysfs

2013-03-04 Thread Laszlo Ersek
Until the uncomparably harder task of real VCPU hotplug / hot-unplug is completed, here's a small guest agent series that imitates the same thing through the sysfs of the Linux guest. We've heard that people migrating from another VMM might be transitorily interested in this. Laszlo Ersek (3): q

[Qemu-devel] [PATCH] rng: restrict passthrough names to known-good files

2013-03-04 Thread Eric Blake
There is some controversy[1] on the qemu list on whether qemu should have ever allowed arbitrary file name passthrough, or whether it should be restricted to JUST /dev/random and /dev/hwrng. It is always easier to add support for additional filenames than it is to remove support for something once

Re: [Qemu-devel] virtio-rng and fd passing

2013-03-04 Thread Eric Blake
On 03/04/2013 03:24 PM, Anthony Liguori wrote: >> Then libvirt should also make sure that the XML we allow for non-egd >> virtio-rng is restricted to the two filenames that won't cause a qemu >> warning, or even modify the XML to not expose a filename in the first >> place. We haven't released lib

Re: [Qemu-devel] virtio-rng and fd passing

2013-03-04 Thread Anthony Liguori
Eric Blake writes: > [adding libvirt] > > On 03/03/2013 02:05 PM, Anthony Liguori wrote: >> Paolo Bonzini writes: >> >>> Il 02/03/2013 04:13, Anthony Liguori ha scritto: There is no valid use-case of rng-random other than using /dev/random. In fact, it was probably a mistake to even a

Re: [Qemu-devel] [PATCH] build: compile gtk.c with special CFLAGS

2013-03-04 Thread Anthony Liguori
Blue Swirl writes: > On Mon, Mar 4, 2013 at 8:29 PM, Anthony Liguori wrote: >> Blue Swirl writes: >> >>> On Sun, Mar 3, 2013 at 9:03 PM, Anthony Liguori wrote: Blue Swirl writes: > Compile gtk.c with special CFLAGS instead of disabling -Werror globally. > > Signed-off-by

[Qemu-devel] [PATCH 1/3] qga: introduce guest-get-vcpus / guest-set-vcpus with stubs

2013-03-04 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek --- qga/qapi-schema.json | 50 ++ qga/commands-posix.c | 11 +++ qga/commands-win32.c | 11 +++ 3 files changed, 72 insertions(+), 0 deletions(-) diff --git a/qga/qapi-schema.json b/qga/qapi-schema

[Qemu-devel] [PATCH 2/3] qga: implement qmp_guest_get_vcpus() for Linux with sysfs

2013-03-04 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek --- qga/commands-posix.c | 87 ++ 1 files changed, 87 insertions(+), 0 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 1ad231a..d4b6bdc 100644 --- a/qga/commands-posix.c +++ b/qga/commands-

[Qemu-devel] [PATCH 3/3] qga: implement qmp_guest_set_vcpus() for Linux with sysfs

2013-03-04 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek --- qga/commands-posix.c | 51 ++ 1 files changed, 51 insertions(+), 0 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index d4b6bdc..1848df8 100644 --- a/qga/commands-posix.c +++ b/qga/commands-

Re: [Qemu-devel] virtio-rng and fd passing

2013-03-04 Thread Eric Blake
[adding libvirt] On 03/03/2013 02:05 PM, Anthony Liguori wrote: > Paolo Bonzini writes: > >> Il 02/03/2013 04:13, Anthony Liguori ha scritto: >>> There is no valid use-case of rng-random other than using /dev/random. >>> In fact, it was probably a mistake to even allow a filename to be >>> speci

Re: [Qemu-devel] virtio-rng and fd passing

2013-03-04 Thread Eric Blake
On 03/01/2013 08:13 PM, Anthony Liguori wrote: > Eric Blake writes: > >> On 03/01/2013 04:59 PM, Anthony Liguori wrote: >>> I said this when seccomp was first introduced and I'll say it again. >>> blacklisting open() is a bad idea. DAC and MAC already exist and solve >>> this problem. We've got

Re: [Qemu-devel] [PATCH v11 0/7] trace: Generic event state description

2013-03-04 Thread Lluís Vilanova
Stefan Hajnoczi writes: > On Fri, Mar 01, 2013 at 04:29:35PM +0100, Lluís Vilanova wrote: >> Provides a generic event state description structure (TraceEvent) and a more >> detailed event control and query interface. >> >> This is achieved by creating a new "non-public" tracing backend (i.e., not

Re: [Qemu-devel] [PATCH] lm32: remove unused function

2013-03-04 Thread Michael Walle
On Mon, March 4, 2013 18:11, Paolo Bonzini wrote: > The milkymist-minimac device in fact does not exist at all. > > Signed-off-by: Paolo Bonzini Acked-by: Michael Walle > --- > hw/milkymist-hw.h | 16 > 1 file changed, 16 deletions(-) > > diff --git a/hw/milkymist-hw.h b/hw/m

Re: [Qemu-devel] [PATCH] build: compile gtk.c with special CFLAGS

2013-03-04 Thread Blue Swirl
On Mon, Mar 4, 2013 at 8:29 PM, Anthony Liguori wrote: > Blue Swirl writes: > >> On Sun, Mar 3, 2013 at 9:03 PM, Anthony Liguori wrote: >>> Blue Swirl writes: >>> Compile gtk.c with special CFLAGS instead of disabling -Werror globally. Signed-off-by: Blue Swirl >>> >>> I thought

Re: [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions

2013-03-04 Thread Blue Swirl
On Mon, Mar 4, 2013 at 9:44 AM, Michael S. Tsirkin wrote: > On Sun, Mar 03, 2013 at 09:01:11AM +, Blue Swirl wrote: >> On Sun, Mar 3, 2013 at 6:13 AM, Peter Crosthwaite >> wrote: >> > This struct and functions provide some encapsulation of the uint32_t type >> > to >> > make it more friendly

Re: [Qemu-devel] [RFC PATCH v1 2/4] bitops: Add UInt32StateInfo and helper functions

2013-03-04 Thread Blue Swirl
On Mon, Mar 4, 2013 at 1:37 AM, Peter Crosthwaite wrote: > Hi Blue, > > Thanks for the review. Comments in-line below. Are you on the IRC much > and what timezone? I'd like to ask a few questions about how you see > this fitting with the memory API, that would probably go much faster > in live dis

Re: [Qemu-devel] [PATCH] build: compile gtk.c with special CFLAGS

2013-03-04 Thread Anthony Liguori
Blue Swirl writes: > On Sun, Mar 3, 2013 at 9:03 PM, Anthony Liguori wrote: >> Blue Swirl writes: >> >>> Compile gtk.c with special CFLAGS instead of disabling -Werror globally. >>> >>> Signed-off-by: Blue Swirl >> >> I thought Kevin's pragma trick solved this problem? > > Not in all cases it

Re: [Qemu-devel] TCG assertion with qemu-system-mipsel

2013-03-04 Thread Stefan Weil
Am 04.03.2013 17:37, schrieb Aurélien Jarno: > Hi, > > On Sat, Feb 23, 2013 at 11:10:18PM +0100, Stefan Weil wrote: >> This assertion occured with latest git master: >> >> qemu-system-mipsel: /src/qemu/tcg/tcg-op.h:2589: >> tcg_gen_goto_tb: Assertion `(tcg_ctx.goto_tb_issue_mask & (1 << idx)) >> =

Re: [Qemu-devel] [PATCH v6 2/3] VFIO-AER: Vfio-pci driver changes for supporting AER

2013-03-04 Thread Alex Williamson
On Sat, 2013-03-02 at 01:16 -0600, Vijay Mohan Pandarathil wrote: > - New VFIO_SET_IRQ ioctl option to pass the eventfd that is signaled > when > an error occurs in the vfio_pci_device > > - Register pci_error_handler for the vfio_pci driver > > - When the device enco

Re: [Qemu-devel] [PATCH v6 1/3] VFIO: Wrapper for getting reference to vfio_device from device

2013-03-04 Thread Alex Williamson
On Sat, 2013-03-02 at 01:16 -0600, Vijay Mohan Pandarathil wrote: > - Added vfio_device_get_from_dev() as wrapper to get > reference to vfio_device from struct device. > > - Added vfio_device_data() as a wrapper to get device_data from > vfio_device. > > Signed-off

Re: [Qemu-devel] [PATCH] build: compile gtk.c with special CFLAGS

2013-03-04 Thread Blue Swirl
On Sun, Mar 3, 2013 at 9:03 PM, Anthony Liguori wrote: > Blue Swirl writes: > >> Compile gtk.c with special CFLAGS instead of disabling -Werror globally. >> >> Signed-off-by: Blue Swirl > > I thought Kevin's pragma trick solved this problem? Not in all cases it seems. > > Are you attempting to

Re: [Qemu-devel] [PATCH] sysbus: add no_user for devices using mmio or IRQ or GPIO

2013-03-04 Thread Paolo Bonzini
Il 04/03/2013 18:58, Peter Maydell ha scritto: >> > Mass-mark these devices as no_user. > "There is no such thing as a 'no-user' device" -- Anthony > (http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg00896.html) > > We should figure out what we might be trying to use 'no-user' > for, and co

Re: [Qemu-devel] [PATCH] qemu-ga: make guest-sync-delimited available during fsfreeze

2013-03-04 Thread mdroth
On Fri, Mar 01, 2013 at 11:53:40AM -0600, Michael Roth wrote: > We currently maintain a whitelist of commands that are safe during > fsfreeze. During fsfreeze, we disable all commands that aren't part of > that whitelist. > > guest-sync-delimited meets the criteria for being whitelisted, and is >

Re: [Qemu-devel] The state of testing

2013-03-04 Thread Anthony Liguori
Stefan Hajnoczi writes: > People are working on testing for various parts of QEMU. I started > this thread to gather an update on the state of testing and see where > we still need help. > > I'm not sure yet if we should propose Google Summer of Code projects > to help with the testing infrastru

[Qemu-devel] [PATCH v3] exec: make -mem-path filenames deterministic

2013-03-04 Thread peter
From: Peter Feiner Adds ramblocks' names to their backing files when using -mem-path. Eases introspection and debugging. Signed-off-by: Peter Feiner --- The commit should probably be called "exec: add ramblocks' names to -mem-path files" since the paths aren't deterministic. v1 -> v2: Just

Re: [Qemu-devel] [PATCH 1/2] qga: add guest-get-time command

2013-03-04 Thread Eric Blake
On 03/04/2013 02:16 AM, Lei Li wrote: > Signed-off-by: Lei Li > --- > qga/commands-posix.c | 16 > qga/qapi-schema.json | 13 + > 2 files changed, 29 insertions(+) > > ## > +# @guest-get-time: > +# > +# Get the information about guest time relative to the Epoch > +

Re: [Qemu-devel] [PATCHv2 1/2] bridge helper: unified error cleanup for parse_acl_file

2013-03-04 Thread Doug Goldstein
On Mon, Mar 4, 2013 at 10:27 AM, Corey Bryant wrote: > > > On 03/02/2013 01:58 AM, Doug Goldstein wrote: >> >> Handle errors and cleanup from the error in a unified place for >> parse_acl_file(). >> >> Signed-off-by: Doug Goldstein >> CC: Anthony Liguori >> CC: Richa Marwaha >> CC: Corey Bryant

Re: [Qemu-devel] [PATCH 2/2] qga: add guest-set-time command

2013-03-04 Thread Eric Blake
On 03/04/2013 11:16 AM, mdroth wrote: > On Mon, Mar 04, 2013 at 05:16:30PM +0800, Lei Li wrote: >> Signed-off-by: Lei Li >> --- >> qga/commands-posix.c | 54 >> >> qga/qapi-schema.json | 27 ++ >> 2 files changed, 81 in

  1   2   3   >