Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing

2013-02-24 Thread Paolo Bonzini
> Another thing is, that qdev_free looks now different, some days ago > it also did an unref. As far as I can see the object_unparent in > virtio-ccw was always the wrong thing to do. object_unparent is "almost" idempotent, i.e. idempotent as long as it does not cause the last reference to go aw

Re: [Qemu-devel] [PATCH v4 0/6] Efficient VM backup for qemu

2013-02-24 Thread Paolo Bonzini
> > > Sure. nbd+unix:///exportname?socket=path is the new URI syntax, I > > > honestly forgot the old one. SCM_CREDENTIALS checks (qemu-nbd --pid > > > or something like that) is not supported, but patches would be > > > very welcome. > > > > Yes, this is better than my tcp suggestion. > > So i

Re: [Qemu-devel] [PATCH v2 2/2] Add AT24Cxx I2C EEPROM device model

2013-02-24 Thread Paolo Bonzini
> > +#include "hw.h" > > +#include "i2c.h" > > Please use "hw/hw.h" and "hw/i2c.h" since Paolo is planning to move > I2C devices into hw/i2c/. No, I2C _masters_ move into hw/i2c. This would probably move into hw/nvram. Paolo > > +#include "sysemu/blockdev.h" > > +#include "hw/block-common.h"

Re: [Qemu-devel] [PATCH 21/38] target-arm: Implement sbc_cc inline

2013-02-24 Thread Peter Crosthwaite
Hi All, Same problem as commented on patch 20. On Wed, Feb 20, 2013 at 5:52 PM, Richard Henderson wrote: > Use sub2 if available, otherwise use 64-bit arithmetic. > > Cc: Peter Maydell > Signed-off-by: Richard Henderson > --- > target-arm/helper.h| 2 -- > target-arm/op_helper.c | 15 ---

Re: [Qemu-devel] [PATCH v4 0/6] Efficient VM backup for qemu

2013-02-24 Thread Dietmar Maurer
> -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Freitag, 22. Februar 2013 19:07 > To: Dietmar Maurer > Cc: Stefan Hajnoczi; Kevin Wolf; qemu-devel@nongnu.org; Wenchao Xia > Subject: Re: [PATCH v4 0/6] Efficient VM backup for qemu > > Il 22/02/2013 18:57, D

Re: [Qemu-devel] [PATCH 20/38] target-arm: Implement adc_cc inline

2013-02-24 Thread Peter Crosthwaite
Hi All, This patch breaks ARM TCG. Fix comming shortly. On Wed, Feb 20, 2013 at 5:52 PM, Richard Henderson wrote: > Use add2 if available, otherwise use 64-bit arithmetic. > > Cc: Peter Maydell > Signed-off-by: Richard Henderson > --- > target-arm/helper.h| 1 - > target-arm/op_helper.c

Re: [Qemu-devel] [PATCH v4 2/6] add basic backup support to block driver

2013-02-24 Thread Dietmar Maurer
> > > > +for (; start < end; start++) { > > > > +if (block_job_is_cancelled(&job->common)) { > > > > +ret = -1; > > > > +break; > > > > +} > > > > + > > > > +/* we need to yield so that qemu_aio_flush() returns. > > > > + * (without, VM do

[Qemu-devel] [PATCH v2] piix: define a TOM register to report the base of PCI

2013-02-24 Thread Xudong Hao
v2: * Use "piix: " in the subject rather than "qemu: " * Define TOM register as one byte * Define default TOM value instead of hardcode 0xe000 in more that one place * Use API pci_set_byte for pci config access * Use dev->config instead of the indirect d->dev.config Define a TOM(top of memory)

Re: [Qemu-devel] [PATCH v5 4/6] introduce new vma archive format

2013-02-24 Thread Dietmar Maurer
> > +return -1; > > +} > > + > > +VmaHeader *h = (VmaHeader *)vmar->head_data; > > + > > +if (h->magic != VMA_MAGIC) { > > +error_setg(errp, "not a vma file - wrong magic number"); > > +return -1; > > +} > > Doesn't seem like this is endian-safe. h->magic i

Re: [Qemu-devel] [PATCH v5 4/6] introduce new vma archive format

2013-02-24 Thread Dietmar Maurer
> > +if (full_read(vmar->fd, vmar->head_data, sizeof(VmaHeader)) != > > +sizeof(VmaHeader)) { > > +error_setg(errp, "can't read vma header - %s", > > + errno ? strerror(errno) : "got EOF"); > > You're not the first user, but strerror() isn't thread-safe. stre

Re: [Qemu-devel] scp during migration with vhost fails

2013-02-24 Thread Jason Wang
On 02/25/2013 01:57 PM, Jason Wang wrote: > On 02/24/2013 05:54 AM, Michael S. Tsirkin wrote: >> On Sat, Feb 23, 2013 at 10:49:29PM +0200, Michael S. Tsirkin wrote: >>> On Fri, Feb 22, 2013 at 11:33:53PM +0800, Jason Wang wrote: On 02/21/2013 07:23 PM, Michael S. Tsirkin wrote: > On Thu, F

Re: [Qemu-devel] scp during migration with vhost fails

2013-02-24 Thread Jason Wang
On 02/24/2013 05:54 AM, Michael S. Tsirkin wrote: > On Sat, Feb 23, 2013 at 10:49:29PM +0200, Michael S. Tsirkin wrote: >> On Fri, Feb 22, 2013 at 11:33:53PM +0800, Jason Wang wrote: >>> On 02/21/2013 07:23 PM, Michael S. Tsirkin wrote: On Thu, Feb 21, 2013 at 05:57:04PM +0800, Jason Wang wrot

[Qemu-devel] [PATCH v5] Enable kvm emulated watchdog

2013-02-24 Thread Bharat Bhushan
Enable the KVM emulated watchdog if KVM supports (use the capability enablement in watchdog handler). Also watchdog exit (KVM_EXIT_WATCHDOG) handling is added. Watchdog state machine is cleared whenever VM state changes to running. This is to handle the cases like return from debug halt etc. Signe

[Qemu-devel] [PATCH v5] Enable and Handle in-kernel watchdog emulation

2013-02-24 Thread Bharat Bhushan
This Patch enables and handle the in-kernel watchdog emulation if KVM supports. Initially there were 3 patches, 2 of them are already applied so sending the 3rd patch now. v5: - using store_booke_tcr/tsr in reset handler rather than using SREGS interface. - removed unused SREGS get/set timer re

Re: [Qemu-devel] 'info help'

2013-02-24 Thread Serge E. Hallyn
Quoting mdroth (mdr...@linux.vnet.ibm.com): > On Fri, Feb 22, 2013 at 05:10:29PM +, Serge E. Hallyn wrote: > > Hi, > > > > up to and including 1.3.0, monitor.c:do_info(), if it got no arg or an > > unknown arg, would do help_cmd(mon, "info"); That behavior is gone in > > 1.4.0, so that 'info'

[Qemu-devel] [PATCH] show --disable-gtk and --enable-gtk in the help message

2013-02-24 Thread Hu Tao
Signed-off-by: Hu Tao --- configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure b/configure index dcaa67c..46b29dc 100755 --- a/configure +++ b/configure @@ -1052,6 +1052,8 @@ echo " --disable-strip disable stripping binaries" echo " --disable-werror disa

[Qemu-devel] [PATCH 05/10] target-i386: convert 'hv_relaxed' to static property

2013-02-24 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 443c15e..e38c369 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1349,6 +1349,7 @@ static Property cpu_x86_propertie

[Qemu-devel] [PATCH 2/2] bridge helper: unified error cleanup for parse_acl_file

2013-02-24 Thread Doug Goldstein
Handle errors and cleanup from the error in a unified place for parse_acl_file(). Signed-off-by: Doug Goldstein CC: Anthony Liguori CC: Richa Marwaha CC: Corey Bryant TO: qemu-devel@nongnu.org --- qemu-bridge-helper.c | 32 +--- 1 file changed, 21 insertions(+), 11

[Qemu-devel] [PATCH 1/2] bridge helper: support conf dirs

2013-02-24 Thread Doug Goldstein
Allow the bridge helper to take a config directory rather than having to specify every file in the directory manually via an include statement. Signed-off-by: Doug Goldstein CC: Anthony Liguori CC: Richa Marwaha CC: Corey Bryant TO: qemu-devel@nongnu.org --- qemu-bridge-helper.c | 55

[Qemu-devel] [PATCH 0/2] bridge helper: includedir conf arg

2013-02-24 Thread Doug Goldstein
The goal is to support an 'includedir' to include all files within a directory specified in the bridge.conf file. The rationale is to allow libvirt to be able to configure interfaces to for use by unprivileged users by just simply generating a new configuration file to the directory. CC: Anthony L

[Qemu-devel] [PATCH 09/10] target-i386: cleanup 'foo=val' feature handling

2013-02-24 Thread Igor Mammedov
features family, model, stepping, level, hv_spinlocks are treated similarly when passed from command line, so it's not necessary to handle each of them individually. Collapse them to one catch-all branch which will treat any not explicitly handled feature in format 'foo=val'. PS: Any unknown featu

[Qemu-devel] [PATCH qom-cpu-next 00/10 v7] target-i386: convert CPU features into properties

2013-02-24 Thread Igor Mammedov
It's a simplified rewrite of previous series, since then cleanups from it were applied to master and I left out kvm_check_features_against_host() and listflags() patches as not directly related to make series simpler. They could follow as separate cleanups later. Also setting defaults with static p

[Qemu-devel] [PATCH 02/10] target-i386: cpu: convert existing dynamic properties into static properties

2013-02-24 Thread Igor Mammedov
Following properties are converted: * vendor * xlevel * custom setter/getter replaced by qdev's DEFINE_PROP_UINT32 * level * custom setter/getter replaced by qdev's DEFINE_PROP_UINT32 * tsc-frequency * stepping * model * family * model-id * ch

[Qemu-devel] [PATCH 04/10] target-i386: convert 'hv_spinlocks' to static property

2013-02-24 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 50 -- 1 files changed, 48 insertions(+), 2 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 35fc303..443c15e 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -129

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/3] powerpc iommu: multiple TCE requests enabled

2013-02-24 Thread David Gibson
On Fri, Feb 22, 2013 at 12:03:49PM +1100, Alexey Kardashevskiy wrote: > On 22/02/13 09:52, David Gibson wrote: > >On Tue, Feb 19, 2013 at 06:43:35PM +1100, Alexey Kardashevskiy wrote: [snip] > >You've implemented the multitce hypercalls in qemu, but because of the > >kvm capability check, you'll ne

[Qemu-devel] [PATCH 08/10] target-i386: cleanup 'foo' feature handling'

2013-02-24 Thread Igor Mammedov
features check, enforce, hv_relaxed and hv_vapic are treated as boolean set to 'on' when passed from command line, so it's not neccessary to handle each of them separetly. Collapse them to one catch-all branch which will treat any feature in format 'foo' as boolean set to 'on'. PS: Any unknown fe

[Qemu-devel] [PATCH 10/10] target-i386: set [+-]feature using static properties

2013-02-24 Thread Igor Mammedov
* Define static properties for cpuid feature bits * property names of CPUID features are changed to have "f-" prefix, so that it would be easy to distinguish them from other properties. * Convert [+-]cpuid_features to a set(QDict) of key, value pairs, where +feat => (f-feat, on)

[Qemu-devel] [PATCH 01/10] qdev: add qdev property for bool type

2013-02-24 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/qdev-properties.c | 33 + hw/qdev-properties.h | 10 ++ 2 files changed, 43 insertions(+), 0 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index a8a31f5..16ac814 100644 --- a/hw/qdev-propertie

[Qemu-devel] [PATCH 06/10] target-i386: convert 'hv_vapic' to static property

2013-02-24 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index e38c369..8f7132a 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1350,6 +1350,7 @@ static Property cpu_x86_propertie

[Qemu-devel] [PATCH 03/10] target-i386: move hyperv_* static globals to CPUState

2013-02-24 Thread Igor Mammedov
- since hyperv_* helper functions are used only in target-i386/kvm.c move them there as static helpers Signed-off-by: Igor Mammedov Requestd-By: Eduardo Habkost --- target-i386/Makefile.objs |2 +- target-i386/cpu.c | 16 +++--- target-i386/cpu.h |7 + target

[Qemu-devel] [PATCH 07/10] target-i386: convert 'check' and 'enforce' to static properties

2013-02-24 Thread Igor Mammedov
* additionally convert check_cpuid & enforce_cpuid to bool and make them members of CPUX86State * make 'enforce' feature independent from 'check' Signed-off-by: Igor Mammedov --- v2: - make check_cpuid & enforce_cpuid members of CPUX86State and use DEFINE_PROP_BOOL instead of custom prope

Re: [Qemu-devel] [PATCH v2] Fix guest OS hang when 64bit PCI bar present

2013-02-24 Thread Alexey Korolev
>> This patch addresses the issue fully described here: >> http://lists.nongnu.org/archive/html/qemu-devel/2013-02/msg01804.html >> >> Linux kernels prior to 2.6.36 do not disable the PCI device during >> enumeration process. Since lower and higher parts of a 64bit BAR >> are programmed separately

Re: [Qemu-devel] [PATCH] ide/macio: Fix macio DMA initialisation.

2013-02-24 Thread Andreas Färber
Am 24.02.2013 21:46, schrieb Mark Cave-Ayland: > Commit 07a7484e5d713f1eb7c1c37b18a8ab0d56d88875 accidentally introduced a bug > in the initialisation of the second macio DMA device which could cause some > DMA operations to segfault QEMU. > > CC: Andreas Färber > Signed-off-by: Mark Cave-Ayland

Re: [Qemu-devel] [Qemu-ppc] Segfault in block driver with qemu-system-ppc and -M mac99

2013-02-24 Thread Andreas Färber
Am 24.02.2013 21:40, schrieb Mark Cave-Ayland: > On 24/02/13 19:29, Mark Cave-Ayland wrote: > >> If you try booting the openSUSE ISO mentioned in my previous email then >> the crash occurs at some point during the "Starting udev..." prompt. > > With a manual review of that particular commit, I ma

[Qemu-devel] [PATCH] ide/macio: Fix macio DMA initialisation.

2013-02-24 Thread Mark Cave-Ayland
Commit 07a7484e5d713f1eb7c1c37b18a8ab0d56d88875 accidentally introduced a bug in the initialisation of the second macio DMA device which could cause some DMA operations to segfault QEMU. CC: Andreas Färber Signed-off-by: Mark Cave-Ayland --- hw/macio.c |2 +- 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [Qemu-ppc] Segfault in block driver with qemu-system-ppc and -M mac99

2013-02-24 Thread Mark Cave-Ayland
On 24/02/13 19:29, Mark Cave-Ayland wrote: If you try booting the openSUSE ISO mentioned in my previous email then the crash occurs at some point during the "Starting udev..." prompt. With a manual review of that particular commit, I managed to spot that it was just a typing error. Patch to f

[Qemu-devel] [Fwd: qemu tx stop in cloonix]

2013-02-24 Thread clownix
Hello, I use qemu inside a gplv3 software called cloonix, I have patched qemu to have unix sockets instead of inet ones but the bug I have with unix sockets may also happen with inet ones. The bug can be reproduced in cloonix context by using iperf, it occurs randomly in a virtual cloonix network

Re: [Qemu-devel] Segfault in block driver with qemu-system-ppc and -M mac99

2013-02-24 Thread Mark Cave-Ayland
On 24/02/13 12:44, Andreas Färber wrote: The commit you reference does nothing with block or IDE but with mips, so is very unlikely to be the cause. I was asking if you have narrowed down whether this is a regression or not. If so then a git-bisect would hopefully give us some more insight. (

[Qemu-devel] 'commit' error for 'all': No medium found

2013-02-24 Thread Jan Kiszka
Hi, I'm seeing this with git head and 1.4. Apparently, commit on a non-populated medium now generates this error instead of ignoring it like in the past. As we stop iterating over the block devices while doing "all", this may leaving uncommitted data behind. Didn't test, but I suspect 58513bde83

[Qemu-devel] Moving BIOS tables from SeaBIOS to QEMU

2013-02-24 Thread Kevin O'Connor
On Sat, Feb 23, 2013 at 04:47:26PM +, David Woodhouse wrote: > On Sat, 2013-02-23 at 11:38 -0500, Kevin O'Connor wrote: > > IMO, we need to move the ACPI table creation (and PIR/MPTABLE/SMBIOS) > > to QEMU and just have QEMU pass the tables to SeaBIOS for it to copy > > into memory like it does

Re: [Qemu-devel] [PATCH v6 7/9] hw/kvm/arm_gic: Implement support for KVM in-kernel ARM GIC

2013-02-24 Thread Peter Maydell
On 23 February 2013 15:29, Andreas Färber wrote: >> +static int kvm_arm_gic_init(SysBusDevice *dev) > > Please make this a realize function ... Will do. As you've probably guessed, this was written some time ago and I never updated it to match our current recommendations. >> +KVMARMGICClass

Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing

2013-02-24 Thread Christian Borntraeger
On 24/02/13 12:30, Andreas Färber wrote: > Am 22.02.2013 20:01, schrieb Jens Freimann: >> From: Christian Borntraeger >> >> This patch fixes a crash when unplugging a virtio-ccw device. We no >> longer need to do that in virtio-ccw since common code does now >> proper handling. >> >> Signed-off-by

Re: [Qemu-devel] [PATCH 2/6] cpu: Introduce ENV_OFFSET macros

2013-02-24 Thread Andreas Färber
Am 24.02.2013 15:07, schrieb Peter Maydell: > On 24 February 2013 11:42, Andreas Färber wrote: >> Am 24.02.2013 12:31, schrieb Peter Maydell: >>> In this case I actually kind of 50% thought they were the >>> result of conflicts/merge process rather than intentional, >>> which is why I cleaned them

Re: [Qemu-devel] [PATCH 2/6] cpu: Introduce ENV_OFFSET macros

2013-02-24 Thread Peter Maydell
On 24 February 2013 11:42, Andreas Färber wrote: > Am 24.02.2013 12:31, schrieb Peter Maydell: >> In this case I actually kind of 50% thought they were the >> result of conflicts/merge process rather than intentional, >> which is why I cleaned them up. I don't actually care one >> way or the other

[Qemu-devel] [PATCH v2 0/4] Moxie CPU target port

2013-02-24 Thread Anthony Green
This is my resubmission of the moxie port. Thank you for all of the feedback on my first attempt. I believe that these patches address all of the reviewer comments, with the exception of some of rth's code refactoring suggestions around cmp and branch instructions. I'll work on that after approv

[Qemu-devel] [PATCH v2 4/4] Add top level changes for moxie

2013-02-24 Thread Anthony Green
Signed-off-by: Anthony Green --- MAINTAINERS | 5 + arch_init.c | 2 ++ configure | 12 +++- cpu-exec.c| 2 ++ default-configs/moxie-softmmu.mak | 2 ++ qapi-schema.json |

[Qemu-devel] [PATCH v2 2/4] Add moxie disassembler

2013-02-24 Thread Anthony Green
Signed-off-by: Anthony Green --- disas.c | 6 + disas/Makefile.objs | 1 + disas/moxie.c | 360 3 files changed, 367 insertions(+) create mode 100644 disas/moxie.c diff --git a/disas.c b/disas.c index a46faee..74d3ba0 1

[Qemu-devel] [PATCH v2 3/4] Add sample moxie system

2013-02-24 Thread Anthony Green
Signed-off-by: Anthony Green --- hw/moxie/Makefile.objs | 6 ++ hw/moxie/moxiesim.c| 175 + include/sysemu/arch_init.h | 1 + 3 files changed, 182 insertions(+) create mode 100644 hw/moxie/Makefile.objs create mode 100644 hw/moxie/mox

[Qemu-devel] QEMU no longer debugable with recent gdb

2013-02-24 Thread Jan Kiszka
Hi, running qemu-system-xxx under recent gdb gives me this instead of starting QEMU: GNU gdb (GDB) 7.5.1 Copyright (C) 2012 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later This is free software: you are free to change and redistribute i

Re: [Qemu-devel] Segfault in block driver with qemu-system-ppc and -M mac99

2013-02-24 Thread Andreas Färber
Am 24.02.2013 13:40, schrieb Mark Cave-Ayland: > On 24/02/13 12:14, Andreas Färber wrote: > >> Have you tried a revision before my macio refactoring? It changed which >> IDE code paths are taken. > > Hi Andreas, > > It's a git pull as of a few hours ago (commit > a345481baa2b2fb3d54f8c9ddb58dfca

Re: [Qemu-devel] Segfault in block driver with qemu-system-ppc and -M mac99

2013-02-24 Thread Mark Cave-Ayland
On 24/02/13 12:14, Andreas Färber wrote: Have you tried a revision before my macio refactoring? It changed which IDE code paths are taken. Hi Andreas, It's a git pull as of a few hours ago (commit a345481baa2b2fb3d54f8c9ddb58dfcaf75786df) if that helps? Many thanks, Mark.

Re: [Qemu-devel] Segfault in block driver with qemu-system-ppc and -M mac99

2013-02-24 Thread Andreas Färber
Hi Mark, Am 24.02.2013 13:08, schrieb Mark Cave-Ayland: > Whilst running through some OpenBIOS tests, I came across the following > segfault in qemu-system-ppc with -M mac99 on git master. It is > consistently reproducible here with my test openSUSE image although > strangely all my other images s

[Qemu-devel] Segfault in block driver with qemu-system-ppc and -M mac99

2013-02-24 Thread Mark Cave-Ayland
Hi all, Whilst running through some OpenBIOS tests, I came across the following segfault in qemu-system-ppc with -M mac99 on git master. It is consistently reproducible here with my test openSUSE image although strangely all my other images seem to run fine. The host is running amd64 Debian W

Re: [Qemu-devel] [PATCH 2/3] s390/css: Fix subchannel detection

2013-02-24 Thread Christian Borntraeger
On 24/02/13 12:32, Andreas Färber wrote: > Am 22.02.2013 20:01, schrieb Jens Freimann: >> From: Christian Borntraeger >> >> We have to consider the m bit to find the real channel subsystem when >> determining the last subchannel. >> >> If we fail to take this into account, removal of a subchannel

Re: [Qemu-devel] [PATCH 2/6] cpu: Introduce ENV_OFFSET macros

2013-02-24 Thread Andreas Färber
Am 24.02.2013 12:31, schrieb Peter Maydell: > On 24 February 2013 11:27, Andreas Färber wrote: >> Am 22.02.2013 19:22, schrieb Peter Maydell: >>> Yeah, I deliberately dropped a bunch of what I felt were >>> extraneous blank lines :-) >> >> I've applied it to qom-cpu since it conflicts with my addi

Re: [Qemu-devel] [PATCH 2/3] s390/css: Fix subchannel detection

2013-02-24 Thread Andreas Färber
Am 22.02.2013 20:01, schrieb Jens Freimann: > From: Christian Borntraeger > > We have to consider the m bit to find the real channel subsystem when > determining the last subchannel. > > If we fail to take this into account, removal of a subchannel in > the middle of a big list of devices will s

Re: [Qemu-devel] [PATCH 2/6] cpu: Introduce ENV_OFFSET macros

2013-02-24 Thread Peter Maydell
On 24 February 2013 11:27, Andreas Färber wrote: > Am 22.02.2013 19:22, schrieb Peter Maydell: >> Yeah, I deliberately dropped a bunch of what I felt were >> extraneous blank lines :-) > > I've applied it to qom-cpu since it conflicts with my additions of > vmstate_..._cpu fields and ..._do_interr

Re: [Qemu-devel] [PATCH 1/3] virtio-ccw: remove qdev_unparent in unplug routing

2013-02-24 Thread Andreas Färber
Am 22.02.2013 20:01, schrieb Jens Freimann: > From: Christian Borntraeger > > This patch fixes a crash when unplugging a virtio-ccw device. We no > longer need to do that in virtio-ccw since common code does now > proper handling. > > Signed-off-by: Christian Borntraeger > Signed-off-by: Jens F

Re: [Qemu-devel] [PATCH 2/6] cpu: Introduce ENV_OFFSET macros

2013-02-24 Thread Andreas Färber
Am 22.02.2013 19:22, schrieb Peter Maydell: > On 22 February 2013 18:20, Andreas Färber wrote: >> Am 22.02.2013 19:10, schrieb Peter Maydell: >>> From: Andreas Färber >>> index c0f6c6d..252bd14 100644 >>> --- a/target-alpha/cpu-qom.h >>> +++ b/target-alpha/cpu-qom.h >>> @@ -72,5 +72,6 @@ static i

[Qemu-devel] [PATCH] gtk: Release modifier when graphic console loses keyboard focus

2013-02-24 Thread Jan Kiszka
From: Jan Kiszka This solves, e.g., sticky ALT when selecting a GTK menu, switching to a different window or selecting a different virtual console. Signed-off-by: Jan Kiszka --- ui/gtk.c | 52 ++-- 1 files changed, 50 insertions(+), 2 deletions

Re: [Qemu-devel] [RFC PATCH v2 2/4] KVM: Introduce KVM_CSS_BUS.

2013-02-24 Thread Michael S. Tsirkin
On Fri, Feb 22, 2013 at 01:09:47PM +0100, Cornelia Huck wrote: > Add a new bus type for s390 css kvm io devices. > > Signed-off-by: Cornelia Huck > --- > include/linux/kvm_host.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index

Re: [Qemu-devel] [RFC PATCH v2 0/4] kvm: Make ioeventfd usable on s390.

2013-02-24 Thread Michael S. Tsirkin
On Fri, Feb 22, 2013 at 01:09:45PM +0100, Cornelia Huck wrote: > Here's the second attempt at implementing ioeventfd for s390. The patchset looks fine overall. Minor comments and questions below. > > Rather than the architecture-specific functions used in v1, we > now try to integrate with the k

Re: [Qemu-devel] [RFC PATCH v2 3/4] KVM: ioeventfd for s390 css devices.

2013-02-24 Thread Michael S. Tsirkin
On Fri, Feb 22, 2013 at 01:09:48PM +0100, Cornelia Huck wrote: > Enhance KVM_IOEVENTFD with a new flag that allows to attach to s390 css > devices. > > Signed-off-by: Cornelia Huck > --- > Documentation/virtual/kvm/api.txt | 7 +++ > include/uapi/linux/kvm.h | 2 ++ > virt/kvm/event

Re: [Qemu-devel] [RFC PATCH v2 4/4] KVM: s390: Wire up ioeventfd.

2013-02-24 Thread Michael S. Tsirkin
On Fri, Feb 22, 2013 at 01:09:49PM +0100, Cornelia Huck wrote: > Enable ioeventfd support on s390 and hook up diagnose 500 virtio-ccw > notifications. > > Signed-off-by: Cornelia Huck > --- > arch/s390/kvm/Kconfig| 1 + > arch/s390/kvm/Makefile | 2 +- > arch/s390/kvm/diag.c | 25 +++

Re: [Qemu-devel] [RFC PATCH v2 0/4] kvm: Make ioeventfd usable on s390.

2013-02-24 Thread Michael S. Tsirkin
On Fri, Feb 22, 2013 at 01:09:45PM +0100, Cornelia Huck wrote: > Here's the second attempt at implementing ioeventfd for s390. > > Rather than the architecture-specific functions used in v1, we > now try to integrate with the kvm_io_device infrastructure. > Calls to diagnose 500 subcode 3 are now

Re: [Qemu-devel] [RFC PATCH 3/3] KVM: s390: Hook up ioeventfds.

2013-02-24 Thread Michael S. Tsirkin
On Fri, Feb 22, 2013 at 08:22:08AM +0100, Cornelia Huck wrote: > On Thu, 21 Feb 2013 22:42:41 +0200 > "Michael S. Tsirkin" wrote: > > > On Thu, Feb 21, 2013 at 07:14:31PM +0100, Cornelia Huck wrote: > > > On Thu, 21 Feb 2013 18:34:59 +0200 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Thu,

Re: [Qemu-devel] [PATCH v2 8/8] qtest: Add boot order test

2013-02-24 Thread Andreas Färber
Am 22.02.2013 18:20, schrieb Markus Armbruster: > diff --git a/tests/boot-order-test.c b/tests/boot-order-test.c > new file mode 100644 > index 000..60412ad > --- /dev/null > +++ b/tests/boot-order-test.c [...] > +static void test_pc_with_args(const char *args, uint8_t boot1, uint8_t boot2, > +

[Qemu-devel] [PATCH] boot-order-test: Add tests for PowerMacs

2013-02-24 Thread Andreas Färber
They set the boot device via fw_cfg, which is then translated to a boot path of "hd" or "cd" in OpenBIOS. Signed-off-by: Andreas Färber Cc: Markus Armbruster Cc: Alexander Graf Cc: qemu-...@nongnu.org --- tests/Makefile |2 ++ tests/boot-order-test.c | 66 +++