[Qemu-devel] [Bug 1129571] Re: libreoffice armhf FTBFS

2013-02-22 Thread Ubuntu Foundations Team Bug Bot
** Tags added: patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1129571 Title: libreoffice armhf FTBFS Status in QEMU: New Status in “qemu” package in Ubuntu: Confirmed Bug description:

Re: [Qemu-devel] [PATCH 0/3] piix_pci cleanups

2013-02-22 Thread David Woodhouse
On Sat, 2013-02-23 at 00:40 +, David Woodhouse wrote: > Some cleanups for piix_pci, *not* including the final patch which actually > adds hard-reset support for the i440FX PAM configuration. We'll want Kevin's Er, Anthony's. Sorry. S'late... -- dwmw2 smime.p7s Description: S/MIME cryptogr

[Qemu-devel] [PATCH 1/3] piix_pci: Clean up i440FX object handling

2013-02-22 Thread David Woodhouse
From: David Woodhouse Define and use I440FX_PCI_DEVICE() instead of using DO_UPCAST(). Signed-off-by: David Woodhouse Reviewed-by: Andreas Färber Tested-by: Laszlo Ersek Reviewed-by: Laszlo Ersek --- hw/piix_pci.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff

[Qemu-devel] [PATCH 2/3] piix_pci: Use DEVICE() and ISA_BUS()

2013-02-22 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse Reviewed-by: Andreas Färber Tested-by: Laszlo Ersek Reviewed-by: Laszlo Ersek --- hw/piix_pci.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 6b69e26..19fc045 100644 --- a/hw/p

[Qemu-devel] [PATCH 3/3] piix_pci: Fix C99 comments

2013-02-22 Thread David Woodhouse
From: David Woodhouse Signed-off-by: David Woodhouse Reviewed-by: Andreas Färber Tested-by: Laszlo Ersek Reviewed-by: Laszlo Ersek --- hw/piix_pci.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 19fc045..030e454 100644 ---

[Qemu-devel] [PATCH 0/3] piix_pci cleanups

2013-02-22 Thread David Woodhouse
Some cleanups for piix_pci, *not* including the final patch which actually adds hard-reset support for the i440FX PAM configuration. We'll want Kevin's work to fix reset handling before we merge that final one; suspend/resume shouldn't trigger a full power-on type reset.    git://git.infradead.org/

[Qemu-devel] [Bug 1131757] Re: QEMU 1.4.0 fails to boot sparc64 linux image

2013-02-22 Thread Kirill Tkhai
During testing of test image on sparc32 I found out that it is uncompressed. I tried to make the same for sparc64 and the kernel works. Everything is ok. Thank you for the answer, Michael! Regards, Kirill -- You received this bug notification because you are a member of qemu- devel-ml, which i

Re: [Qemu-devel] [RFC V8 00/13] Quorum block filter.

2013-02-22 Thread Benoît Canet
Hi Kevin, I just saw you reviewed Quorum. Thanks a lot for doing this. I will iterate on it. Regards Benoît > Le Monday 28 Jan 2013 à 18:07:12 (+0100), Benoît Canet a écrit : > This patchset is rebased on top of "cutils: unsigned int parsing functions" > by "Eduardo Habkost". > > It must be a

[Qemu-devel] [PATCH 02/22] qemu-img: add json output option to the check command

2013-02-22 Thread Kevin Wolf
From: Federico Simoncelli This option --output=[human|json] makes qemu-img check output a human or JSON representation at the choice of the user. Signed-off-by: Federico Simoncelli Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf --- qapi-schema.json | 46 +++ qemu-img-cmds.hx |

[Qemu-devel] [PATCH 22/22] pc: add compatibility machine types for 1.4

2013-02-22 Thread Kevin Wolf
From: Paolo Bonzini Adds both pc-i440fx-1.4 and pc-q35-1.4. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- hw/pc.h | 31 +++ hw/pc_piix.c | 18 -- hw/pc_q35.c | 19 --- 3 files changed, 63 insertions(+), 5 deletions

[Qemu-devel] [PATCH 03/22] qcow2: introduce check_refcounts_l1/l2() flags

2013-02-22 Thread Kevin Wolf
From: Stefan Hajnoczi The check_refcounts_l1/l2() functions have a check_copied argument to check that the QCOW_O_COPIED flag is consistent with refcount == 1. This should be a bool, not an int. However, the next patch introduces qcow2 fragmentation statistics and also needs to pass an option to

[Qemu-devel] [PATCH 01/22] qemu-img: find the image end offset during check

2013-02-22 Thread Kevin Wolf
From: Federico Simoncelli This patch adds the support for reporting the image end offset (in bytes). This is particularly useful after a conversion (or a rebase) where the destination is a block device in order to find the first unused byte at the end of the image. Signed-off-by: Federico Simonc

[Qemu-devel] [PATCH 15/22] coroutine: move pooling to common code

2013-02-22 Thread Kevin Wolf
From: Paolo Bonzini The coroutine pool code is duplicated between the ucontext and sigaltstack backends, and absent from the win32 backend. But the code can be shared easily by moving it to qemu-coroutine.c. Signed-off-by: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH 11/22] qemu-img: Add "Quiet mode" option

2013-02-22 Thread Kevin Wolf
From: Miroslav Rezanina There can be a need to turn output to stdout off. This patch adds a -q option that enable "Quiet mode". In Quiet mode, only errors are printed out. Signed-off-by: Miroslav Rezanina Reviewed-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- block.c | 12

[Qemu-devel] [PATCH 12/22] qemu-img: Add compare subcommand

2013-02-22 Thread Kevin Wolf
From: Miroslav Rezanina This patch adds new qemu-img subcommand that compares content of two disk images. Signed-off-by: Miroslav Rezanina Reviewed-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- qemu-img-cmds.hx | 6 ++ qemu-img.c | 290

[Qemu-devel] [PATCH 04/22] qcow2: record fragmentation statistics during check

2013-02-22 Thread Kevin Wolf
From: Stefan Hajnoczi The qemu-img check command can display fragmentation statistics: * Total number of clusters in virtual disk * Number of allocated clusters * Number of fragmented clusters This patch adds fragmentation statistics support to qcow2. Compressed and normal clusters count as

[Qemu-devel] [PATCH 34/42] qemu-file: simplify and export qemu_ftell

2013-02-22 Thread Paolo Bonzini
Force a flush when qemu_ftell is called. This simplifies the buffer magic (it also breaks qemu_ftell for input QEMUFiles, but we never use it). Reviewed-by: Orit Wasserman Reviewed-by: Juan Quintela Signed-off-by: Paolo Bonzini --- savevm.c | 20 1 file changed, 8 inserti

[Qemu-devel] [PATCH 26/42] migration: eliminate last_round

2013-02-22 Thread Paolo Bonzini
We will go around the loop exactly once after setting last_round. Eliminate the variable altogether. Reviewed-by: Orit Wasserman Reviewed-by: Juan Quintela Signed-off-by: Paolo Bonzini --- migration.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/migration.c b

[Qemu-devel] [PATCH 17/22] block: complete all IOs before .bdrv_truncate

2013-02-22 Thread Kevin Wolf
From: Peter Lieven bdrv_truncate() invalidates the bdrv_check_request() result for in-flight requests, so there should better be none. Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven Reported-by: Kevin Wolf Reviewed-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block.c | 4 1

[Qemu-devel] [PATCH 20/22] qemu-nbd: add --discard option

2013-02-22 Thread Kevin Wolf
From: Paolo Bonzini Similar to --cache and --aio, this option mimics the discard suboption of "-drive". Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- qemu-nbd.c| 18 +++--- qemu-nbd.texi | 4 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/qe

[Qemu-devel] [PATCH v6 1/9] oslib-posix: Align to permit transparent hugepages on ARM Linux

2013-02-22 Thread Peter Maydell
ARM Linux (like x86-64 Linux) can use transparent hugepages for KVM if memory blocks are 2MiB aligned; set QEMU_VMALLOC_ALIGN accordingly. Signed-off-by: Peter Maydell Reviewed-by: Paolo Bonzini --- util/oslib-posix.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/o

[Qemu-devel] [PATCH 16/22] coroutine: trim down nesting level in perf_nesting test

2013-02-22 Thread Kevin Wolf
From: Paolo Bonzini 2 nested coroutines require 20 GB of virtual address space. Only nest 1000 of them so that the test (only enabled with "-m perf" on the command line) runs on 32-bit machines too. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini Reviewed-by: Stefan Hajnoczi Signed

[Qemu-devel] [PATCH 08/22] block: use Error in do_check_io_limits()

2013-02-22 Thread Kevin Wolf
From: Stefan Hajnoczi The do_check_io_limits() function returns false when I/O limits are invalid but it doesn't set an Error to indicate why. The two do_check_io_limits() callers duplicate error reporting. Solve this by passing an Error pointer into do_check_io_limits(). Note that the two cal

[Qemu-devel] [PATCH 07/22] qcow2: support compressed clusters in BlockFragInfo

2013-02-22 Thread Kevin Wolf
From: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi --- block/qcow2-refcount.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c index 771b7b2..55543ed 100644 --- a/block/qcow2-refcount.c +++ b/block/qcow2-refcount.c @@ -968,6 +968,7 @@ static

[Qemu-devel] [PATCH 19/22] blockdev: add discard suboption to -drive

2013-02-22 Thread Kevin Wolf
From: Paolo Bonzini Add support for BDRV_O_UNMAP from the QEMU command-line. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- blockdev.c | 11 +++ qemu-options.hx | 2 ++ 2 files changed, 13 insertions(+) diff --git a/blockdev.c b/blockdev.c index b307ed9..0e67d06 100

[Qemu-devel] [PATCH v2 00/42] Migration cleanups and latency improvements

2013-02-22 Thread Paolo Bonzini
This series does many of the improvements that the migration thread promised. First, it simplifies substantially the logic of the migration thread, which makes it easier to do more changes later (patches 1-14). Second, It makes a large amount of code run outside the big QEMU lock, so that blockin

Re: [Qemu-devel] [PATCH] qmp: netdev_add is like -netdev, not -net, fix documentation

2013-02-22 Thread Laszlo Ersek
On 02/22/13 18:31, Markus Armbruster wrote: > Cc: qemu-sta...@nongnu.org > Signed-off-by: Markus Armbruster > --- > qmp-commands.hx | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qmp-commands.hx b/qmp-commands.hx > index 799adea..95022e2 100644 > --- a/qmp-commands.hx >

[Qemu-devel] [PATCH 14/22] qemu-iotests: Test qcow2 image creation options

2013-02-22 Thread Kevin Wolf
Just create lots of images and try out each of the creation options that qcow2 provides (except backing_file/fmt for now) I'm not totally happy with the behaviour of qemu-img in each of the cases, but let's be explicit and update the test when we do change things later. Signed-off-by: Kevin Wolf

[Qemu-devel] [PATCH 18/22] block: implement BDRV_O_UNMAP

2013-02-22 Thread Kevin Wolf
From: Paolo Bonzini It is better to present homogeneous hardware independent of the storage technology that is chosen on the host, hence we make discard a host parameter; the user can choose whether to pass it down to the image format and protocol, or to ignore it. Using DISCARD with filesystems

[Qemu-devel] [PATCH 13/22] qemu-iotests: Add qemu-img compare test

2013-02-22 Thread Kevin Wolf
From: Miroslav Rezanina Simple test for qemu-img compare to check it's working correctly. Signed-off-by: Miroslav Rezanina Reviewed-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/048 | 78 ++ tests/qemu-iotests/048.out | 3

[Qemu-devel] [PATCH 21/22] blockdev: enable discard by default

2013-02-22 Thread Kevin Wolf
From: Paolo Bonzini Because discard is now a host parameter, we can always fake it as enabled in the guest. This is an extension of the current choice to ignore "not supported" errors from the host when discard_granularity is set to nonzero. The default granularity is set to the logical block s

[Qemu-devel] [PATCH 09/22] block: refuse negative iops and bps values

2013-02-22 Thread Kevin Wolf
From: Stefan Hajnoczi Negative I/O throttling iops and bps values do not make sense so reject them with an error message. Reviewed-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- blockdev.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/blockdev.c b/blockdev.c index 9b03513

[Qemu-devel] [PATCH 06/22] qemu-img: add compressed clusters to BlockFragInfo

2013-02-22 Thread Kevin Wolf
From: Stefan Hajnoczi Show how many clusters are compressed. This can be used to monitor how many compressed clusters remain and whether to recompress the image. Suggested-by: Cole Robinson Signed-off-by: Stefan Hajnoczi --- include/block/block.h| 1 + qapi-schema.json |

[Qemu-devel] [PATCH 10/22] block: Add synchronous wrapper for bdrv_co_is_allocated_above

2013-02-22 Thread Kevin Wolf
From: Miroslav Rezanina There's no synchronous wrapper for bdrv_co_is_allocated_above function so it's not possible to check for sector allocation in an image with a backing file. Signed-off-by: Miroslav Rezanina Reviewed-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- block.c

[Qemu-devel] [PATCH 05/22] qemu-img: fix missing space in qemu-img check output

2013-02-22 Thread Kevin Wolf
From: Stefan Hajnoczi The qemu-img check fragmentation printf() is missing a space before the '=' sign. The human output is not guaranteed to be stable and we are not aware of screen scrapers, so add the missing space. Also fix the missing indentation of the printf() arguments. Signed-off-by:

[Qemu-devel] [PULL 00/22] Block patches

2013-02-22 Thread Kevin Wolf
The following changes since commit 5cbb08283789caf7dbfd0890dcff47124ad766c2: ui/gtk: require at least GTK 2.18 and VTE 0.26 (2013-02-22 09:53:56 -0600) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony for you to fetch changes up to bf3caa3dc17552b323cec683

[Qemu-devel] [PATCH v6 4/9] ARM KVM: save and load VFP registers from kernel

2013-02-22 Thread Peter Maydell
Add support for saving and restoring VFP register state from the kernel. This includes a check that the KVM-created CPU has full VFP support (as the TCG Cortex-A15 model always does), since for the moment ARM QEMU doesn't have any way to tweak optional features on created CPUs. Signed-off-by: Pete

Re: [Qemu-devel] [PATCH 4/6] Handle CPU interrupts by inline checking of a flag

2013-02-22 Thread Paul Brook
> @@ -100,6 +102,7 @@ struct CPUState { > bool stop; > bool stopped; > volatile sig_atomic_t exit_request; > +volatile sig_atomic_t tcg_exit_req; Do we really need annother variable/check? It seems like this should be at least partially redundant with the existing icount code.

Re: [Qemu-devel] [PATCH v2] gtk: Replace bogus term "VGA" with "Screen"

2013-02-22 Thread Stefan Weil
Am 22.02.2013 18:02, schrieb Peter Maydell: > On 22 February 2013 16:59, Anthony Liguori wrote: >> They way I plan on doing it is simply making a NULL end up with 'video0' >> or something like that. > Mmm. (Might be nice to avoid having to touch every device to > add a NULL argument to the functio

[Qemu-devel] [PATCH 38/42] migration: small changes around rate-limiting

2013-02-22 Thread Paolo Bonzini
This patch extracts a few small changes from the next patch, which are unrelated to adding generic rate-limiting functionality to QEMUFile. Make migration_set_rate_limit a simple accessor, and use qemu_file_set_rate_limit consistently. Also fix a typo where INT_MAX should have been SIZE_MAX. Rev

Re: [Qemu-devel] [PATCH v2 00/15] Debug output revamp

2013-02-22 Thread Andreas Färber
Am 22.02.2013 17:54, schrieb Richard Henderson: > On 02/22/2013 08:16 AM, Andreas Färber wrote: >> I would be willing to do a macro-based v3 using do { ... } while (0) if >> maintainers can reach agreement on that and on how to do the if (0). > > FWIW, I'm in favor of the > > #ifndef DEBUG > # de

Re: [Qemu-devel] [PATCH v2] gtk: Replace bogus term "VGA" with "Screen"

2013-02-22 Thread Anthony Liguori
Peter Maydell writes: > On 22 February 2013 15:37, Anthony Liguori wrote: >> I think what I'd prefer to do is add a parameter to >> graphics_console_init() for the name of the DisplayState. >> >> This will better support having multiple graphics tabs in the future. I >> can spin this patch later

Re: [Qemu-devel] [PATCH] Reenable -Wstrict-prototypes

2013-02-22 Thread Kevin Wolf
Am 22.02.2013 um 21:33 hat Stefan Weil geschrieben: > Am 22.02.2013 21:08, schrieb Kevin Wolf: > > One part of this patch reverts commit 22bc9a46, which disabled the > > warning. The rest of it deals with the warning by adding a #pragma for > > newer gcc and by disabling -Werror for compilers that

Re: [Qemu-devel] [PATCH v2] vga: fix byteswapping.

2013-02-22 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

[Qemu-devel] [Bug 1131757] [NEW] QEMU 1.4.0 fails to boot sparc64 linux image

2013-02-22 Thread Kirill Tkhai
Public bug reported: Hi! I tried to boot sparc64 linux image (http://packages.debian.org/sid/sparc64/linux- image-2.6-sparc64-smp/download) with qemu and received the error. host:~$qemu-system-sparc64 -nographic -kernel vmlinuz-3.2.0-4-sparc64-smp OpenBIOS for Sparc64 Configuration device id QE

[Qemu-devel] [PATCH 14/42] migration: prepare to access s->state outside critical sections

2013-02-22 Thread Paolo Bonzini
Accessing s->state outside the big QEMU lock will simplify a bit the locking/unlocking of the iothread lock. We need to keep the lock in migrate_fd_error and migrate_fd_completed, however, because they call migrate_fd_cleanup. Reviewed-by: Orit Wasserman Reviewed-by: Juan Quintela Signed-off-by

[Qemu-devel] [PATCH 25/42] qemu-file: make qemu_fflush and qemu_file_set_error private again

2013-02-22 Thread Paolo Bonzini
Reviewed-by: Orit Wasserman Reviewed-by: Juan Quintela Signed-off-by: Paolo Bonzini --- include/migration/qemu-file.h | 2 -- savevm.c | 4 ++-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/include/migration/qemu-file.h b/include/migration/qemu-file.h inde

Re: [Qemu-devel] Online resize of virtio-blk device does not emit udev event

2013-02-22 Thread Milos Vyletel
- Original Message - > On Wed, Feb 20, 2013 at 09:34:45PM +0100, Milos Vyletel wrote: > > It looks like none of the block drivers handle this. > > drivers/md/dm*.c is a block driver and you showed that LVM > (device-mapper) does raise a uevent when the device is resized. That > would be t

[Qemu-devel] [PATCH v2 1/8] vl: Clean up parsing of -boot option argument

2013-02-22 Thread Markus Armbruster
Commit 3d3b8303 threw in some QemuOpts parsing without replacing the existing ad hoc parser, resulting in a confusing mess. Clean it up. Two user-visible changes: 1. Invalid options are reported more nicely. Before: qemu: unknown boot parameter 'x' in 'x=y' After: qemu-sys

[Qemu-devel] [PATCH 10/42] migration: use qemu_file_set_error

2013-02-22 Thread Paolo Bonzini
Remove the return value of buffered_flush, pass it via the error code of s->file. Once this is done, the error can be retrieved simply via migrate_fd_close's call to qemu_fclose. Reviewed-by: Orit Wasserman Reviewed-by: Juan Quintela Signed-off-by: Paolo Bonzini --- migration.c | 22 ++---

Re: [Qemu-devel] 'info help'

2013-02-22 Thread Markus Armbruster
"Serge E. Hallyn" writes: > Hi, > > up to and including 1.3.0, monitor.c:do_info(), if it got no arg or an > unknown arg, would do help_cmd(mon, "info"); That behavior is gone in > 1.4.0, so that 'info', 'info help', and 'info whatever' just say unknown > argument. Was that intended, or would r

[Qemu-devel] [PATCH v6 7/9] hw/kvm/arm_gic: Implement support for KVM in-kernel ARM GIC

2013-02-22 Thread Peter Maydell
Implement support for using the KVM in-kernel GIC for ARM. Signed-off-by: Peter Maydell Reviewed-by: Paolo Bonzini --- hw/a15mpcore.c |8 ++- hw/arm/Makefile.objs |1 + hw/kvm/arm_gic.c | 169 ++ 3 files changed, 177 insertions(

[Qemu-devel] [PATCH v6 6/9] target-arm: Use MemoryListener to identify GIC base address for KVM

2013-02-22 Thread Peter Maydell
When using an in-kernel GIC with KVM, we need to tell the kernel where the GIC's memory mapped registers live. Do this by registering a MemoryListener which tracks where the board model maps the A15's private peripherals, so we can finish the GIC initialisation when the GIC is actually mapped. Sig

[Qemu-devel] [PATCH 32/42] qemu-file: check exit status when closing a pipe QEMUFile

2013-02-22 Thread Paolo Bonzini
This is what exec_close does. Move this to the underlying QEMUFile. Reviewed-by: Orit Wasserman Reviewed-by: Juan Quintela Signed-off-by: Paolo Bonzini --- include/qemu/osdep.h | 7 +++ migration-exec.c | 4 savevm.c | 3 +++ 3 files changed, 10 insertions(+), 4 delet

[Qemu-devel] [PATCH v2 1/2] i2c: Introduce device address mask

2013-02-22 Thread Jan Kiszka
Some devices react on multiple addresses. To emulate this, we could register them multiple times, but that is cumbersome. The AT24C16, e.g. listens on 8 different addresses. Instead, introduce a device address mask that is applied on the transmitted address before matching it against the stored on

[Qemu-devel] [PATCH v2 2/2] Add AT24Cxx I2C EEPROM device model

2013-02-22 Thread Jan Kiszka
This implements I2C EEPROMs of the AT24Cxx series. Sizes from 1Kbit to 1024Kbit are supported. Each EEPROM is backed by a block device. Its size can be explicitly specified by the "size" property (required for sizes < 512, the blockdev sector size) or is derived from the size of the backing block d

[Qemu-devel] [PATCH v2 0/2] i2c: Add AT24Cxx EEPROM model

2013-02-22 Thread Jan Kiszka
Rebased over current master, resolved new reports of checkpatch. See patches for details. Jan Kiszka (2): i2c: Introduce device address mask Add AT24Cxx I2C EEPROM device model hw/Makefile.objs |2 +- hw/at24.c| 363 ++ hw/ds1

Re: [Qemu-devel] [PATCH ppc-next v2 44/52] target-ppc: Set instruction flags on CPU family classes

2013-02-22 Thread Alexander Graf
On 22.02.2013, at 17:33, Andreas Färber wrote: > Am 22.02.2013 15:34, schrieb Alexander Graf: >> >> On 18.02.2013, at 10:16, Andreas Färber wrote: >> >>> Signed-off-by: Andreas Färber >>> --- >>> target-ppc/translate_init.c | 994 >>> ++- >>> 1 Datei ge

[Qemu-devel] [PATCH 36/42] migration: use QEMUFile for writing outgoing migration data

2013-02-22 Thread Paolo Bonzini
Second, drop the file descriptor indirection, and write directly to the QEMUFile. Reviewed-by: Orit Wasserman Reviewed-by: Juan Quintela Signed-off-by: Paolo Bonzini --- include/migration/migration.h | 4 migration-exec.c | 12 --- migration-fd.c| 12

Re: [Qemu-devel] [PATCH 0/9] Add GTK UI to enable basic accessibility (v5)

2013-02-22 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] Reenable -Wstrict-prototypes

2013-02-22 Thread Stefan Weil
Am 22.02.2013 21:08, schrieb Kevin Wolf: > One part of this patch reverts commit 22bc9a46, which disabled the > warning. The rest of it deals with the warning by adding a #pragma for > newer gcc and by disabling -Werror for compilers that can't deal with > the #pragma. > > Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [PATCH 1/2] ui/gtk: Support versions of gtk+-2.0 before 2.90.7

2013-02-22 Thread Stefan Weil
Am 22.02.2013 20:28, schrieb Anthony Liguori: > Stefan Weil writes: > >> This is needed for current Debian stable (Squeeze). >> >> Extract from NEWS in gtk+-2.0: >> >> Overview of Changes from GTK+ 2.90.6 to 2.90.7 >> == >> >> * All GDK keysym name

[Qemu-devel] [PATCH v6 5/9] hw/arm_gic: Add presave/postload hooks

2013-02-22 Thread Peter Maydell
Add presave/postload hooks to the ARM GIC common base class. These will be used by the KVM in-kernel GIC subclass to sync state between kernel and userspace when migrating. Signed-off-by: Peter Maydell Reviewed-by: Andreas Färber Reviewed-by: Paolo Bonzini --- hw/arm_gic_common.c | 10

Re: [Qemu-devel] [PATCH] Remove elderly top level TODO file

2013-02-22 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

[Qemu-devel] [PATCH v6 8/9] configure: Enable KVM on ARM

2013-02-22 Thread Peter Maydell
Enable KVM on ARM hosts, now that all the necessary components for it exist. Signed-off-by: Peter Maydell Reviewed-by: Paolo Bonzini --- configure |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 0dadd31..a97b968 100755 --- a/configure +++ b/con

Re: [Qemu-devel] [Bug 1131757] [NEW] QEMU 1.4.0 fails to boot sparc64 linux image

2013-02-22 Thread mdroth
On Fri, Feb 22, 2013 at 02:33:43PM -, Kirill Tkhai wrote: > Public bug reported: > > Hi! > > I tried to boot sparc64 linux image > (http://packages.debian.org/sid/sparc64/linux- > image-2.6-sparc64-smp/download) with qemu and received the error. > > host:~$qemu-system-sparc64 -nographic -ke

Re: [Qemu-devel] [PATCH][RESENT] configure: Create link to icon bitmap for out-of-tree builds

2013-02-22 Thread Stefan Weil
Am 22.02.2013 21:05, schrieb Jan Kiszka: > This allows to pick up the icon when starting QEMU directly from an > out-of-tree build directory. > > Signed-off-by: Jan Kiszka > --- > configure |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/configure b/configure > index

[Qemu-devel] [PATCH 19/42] block-migration: add lock

2013-02-22 Thread Paolo Bonzini
Some state is shared between the block migration code and its AIO callbacks. Once block migration will run outside the iothread, the block migration code and the AIO callbacks will be able to run concurrently. Protect the critical sections with a separate lock. Do the same for completed_sectors,

[Qemu-devel] [PATCH v2 5/8] pc: Make -no-fd-bootchk stick across boot order changes

2013-02-22 Thread Markus Armbruster
Option -no-fd-bootchk asks the BIOS to attempt booting from a floppy even when the boot sector signature isn't there, by setting a bit in RTC CMOS. It was added back in 2006 (commit 52ca8d6a). Two years later, commit 0ecdffbb added monitor command boot_set. Implemented by new function pc_boot_set

Re: [Qemu-devel] [PATCH] slirp: Properly initialize pollfds_idx of new sockets

2013-02-22 Thread Laszlo Ersek
On 02/22/13 20:51, Jan Kiszka wrote: > Otherwise we may start processing sockets in slirp_pollfds_poll that > were created past slirp_pollfds_fill. > > Signed-off-by: Jan Kiszka > --- > > Not sure if this pattern also applies to other users besides slirp. > Worth checking I suppose. > > slirp/

Re: [Qemu-devel] [PATCH 1/2] ui/gtk: Support versions of gtk+-2.0 before 2.90.7

2013-02-22 Thread Stefan Weil
Am 22.02.2013 21:00, schrieb Anthony Liguori: > Stefan Weil writes: > >> This is needed for current Debian stable (Squeeze). >> >> Extract from NEWS in gtk+-2.0: >> >> Overview of Changes from GTK+ 2.90.6 to 2.90.7 >> == >> >> * All GDK keysym name

Re: [Qemu-devel] [PATCH 0/6] Drop the irredeemably racy cpu_unlink_tb()

2013-02-22 Thread Richard Henderson
On 02/22/2013 10:09 AM, Peter Maydell wrote: > Andreas Färber (1): > cpu: Introduce ENV_OFFSET macros > > Peter Maydell (5): > tcg: Document tcg_qemu_tb_exec() and provide constants for low bit uses > cpu-exec: wrap tcg_qemu_tb_exec() in a fn to restore the PC > Handle CPU interrupts by in

Re: [Qemu-devel] [PATCH 6/6] gen-icount.h: Rename gen_icount_start/end to gen_tb_start/end

2013-02-22 Thread Richard Henderson
On 02/22/2013 10:10 AM, Peter Maydell wrote: > -gen_icount_end(tb, insn_count); > +gen_tb_end(tb, insn_count); > *tcg_ctx.gen_opc_ptr = INDEX_op_end; Looks like 7/6 should move that INDEX_op_end into gen_tb_end. ;-) r~

[Qemu-devel] [PATCH 18/42] block-migration: document usage of state across threads

2013-02-22 Thread Paolo Bonzini
Reviewed-by: Orit Wasserman Reviewed-by: Juan Quintela Signed-off-by: Paolo Bonzini --- block-migration.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/block-migration.c b/block-migration.c index 9a40edd..d62a8b8 100644 --- a/block-migration.c +++

[Qemu-devel] [PATCH] Reenable -Wstrict-prototypes

2013-02-22 Thread Kevin Wolf
One part of this patch reverts commit 22bc9a46, which disabled the warning. The rest of it deals with the warning by adding a #pragma for newer gcc and by disabling -Werror for compilers that can't deal with the #pragma. Signed-off-by: Kevin Wolf --- configure | 19 +-- ui/gtk.c

[Qemu-devel] [PATCH v6 9/9] MAINTAINERS: add entry for ARM KVM guest cores

2013-02-22 Thread Peter Maydell
Add an entry indicating maintainer status for the ARM KVM code. Signed-off-by: Peter Maydell --- MAINTAINERS |5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 21043e4..2439614 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -140,6 +140,11 @@ S: Supported

[Qemu-devel] [PATCH][RESENT] configure: Create link to icon bitmap for out-of-tree builds

2013-02-22 Thread Jan Kiszka
This allows to pick up the icon when starting QEMU directly from an out-of-tree build directory. Signed-off-by: Jan Kiszka --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 0eb25dd..265d8f7 100755 --- a/configure +++ b/configure @@

[Qemu-devel] [PATCH] ui/gtk: prepare for GTK3 support

2013-02-22 Thread Anthony Liguori
I need to build a VteTerminal for GTK3 before I can do the configure bits. These changes are enough though to make ui/gtk.c build with gtk3 though so we might as well do them now. Signed-off-by: Anthony Liguori --- ui/gtk.c | 62 +++--- 1 f

Re: [Qemu-devel] [PATCH 1/2] ui/gtk: Support versions of gtk+-2.0 before 2.90.7

2013-02-22 Thread Anthony Liguori
Stefan Weil writes: > This is needed for current Debian stable (Squeeze). > > Extract from NEWS in gtk+-2.0: > > Overview of Changes from GTK+ 2.90.6 to 2.90.7 > == > > * All GDK keysym names have been changed from GDK_keysym to GDK_KEY_keysym; >

[Qemu-devel] [PATCH v2 2/8] qemu-option: check_params() is now unused, drop it

2013-02-22 Thread Markus Armbruster
Cc: qemu-sta...@nongnu.org Signed-off-by: Markus Armbruster --- include/qemu/option.h | 2 -- util/qemu-option.c| 30 -- 2 files changed, 32 deletions(-) diff --git a/include/qemu/option.h b/include/qemu/option.h index ba197cd..4dea7ac 100644 --- a/include/qemu/o

Re: [Qemu-devel] [PATCH v2 8/8] qtest: Add boot order test

2013-02-22 Thread Andreas Färber
Am 22.02.2013 18:20, schrieb Markus Armbruster: > Covers only PC so far. > > Signed-off-by: Markus Armbruster Reviewed-by: Andreas Färber > +static void test_cmos_byte(int reg, int expected) > +{ > +int actual; > + > +outb(0x70 + 0, reg); > +actual = inb(0x71); Did you intend to u

[Qemu-devel] [PATCH 06/42] qemu-file: pass errno from qemu_fflush via f->last_error

2013-02-22 Thread Paolo Bonzini
This is done by almost all callers of qemu_fflush, move the code directly to qemu_fflush. Reviewed-by: Orit Wasserman Reviewed-by: Juan Quintela Signed-off-by: Paolo Bonzini --- savevm.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/savevm.c b/

[Qemu-devel] [PATCH 37/42] migration: use qemu_ftell to compute bandwidth

2013-02-22 Thread Paolo Bonzini
Prepare for when s->bytes_xfer will be removed. Reviewed-by: Orit Wasserman Reviewed-by: Juan Quintela Signed-off-by: Paolo Bonzini --- migration.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/migration.c b/migration.c index 681a459..6da1746 100644 --- a/migration.c +

Re: [Qemu-devel] [PATCH v3] doc: document -netdev hubport

2013-02-22 Thread Laszlo Ersek
On 02/22/13 09:49, Stefan Hajnoczi wrote: > Signed-off-by: Stefan Hajnoczi > --- > hmp-commands.hx | 2 +- > qemu-options.hx | 11 ++- > 2 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/hmp-commands.hx b/hmp-commands.hx > index 64008a9..c204d31 100644 > --- a/hmp-comma

[Qemu-devel] [PATCH v4] gtk: Rename File to Machine menu and add pause, reset and power down items

2013-02-22 Thread Jan Kiszka
This adds basic guest control commands to the "Machine" menu - a nice added-value for the GTK UI. We use "pause" as the term for stopping the machine here. So reword also the related caption tag. Signed-off-by: Jan Kiszka --- Changes in v3: - stop -> pause renaming ui/gtk.c | 80 ++

[Qemu-devel] [PATCH 16/42] block-migration: remove variables that are never read

2013-02-22 Thread Paolo Bonzini
Reviewed-by: Orit Wasserman Reviewed-by: Juan Quintela Signed-off-by: Paolo Bonzini --- block-migration.c | 13 - 1 file changed, 13 deletions(-) diff --git a/block-migration.c b/block-migration.c index e6c917d..e72f322 100644 --- a/block-migration.c +++ b/block-migration.c @@ -50,

[Qemu-devel] [PATCH] slirp: Properly initialize pollfds_idx of new sockets

2013-02-22 Thread Jan Kiszka
Otherwise we may start processing sockets in slirp_pollfds_poll that were created past slirp_pollfds_fill. Signed-off-by: Jan Kiszka --- Not sure if this pattern also applies to other users besides slirp. Worth checking I suppose. slirp/socket.c |1 + 1 files changed, 1 insertions(+), 0 de

[Qemu-devel] [PATCH 30/42] migration: merge qemu_popen_cmd with qemu_popen

2013-02-22 Thread Paolo Bonzini
There is no reason for outgoing exec migration to do popen manually anymore (the reason used to be that we needed the FILE* to make it non-blocking). Use qemu_popen_cmd. Reviewed-by: Orit Wasserman Reviewed-by: Juan Quintela Signed-off-by: Paolo Bonzini --- include/migration/qemu-file.h | 1

[Qemu-devel] [PATCH v2] ui/gtk: Use menu item from stock for full screen

2013-02-22 Thread Stefan Weil
This reduces the required translations and gives a nicer menu with an icon. The full screen menu item is no longer a check menu item. A checked item is not visible in full screen mode, so it is not needed for this special menu item. Signed-off-by: Stefan Weil --- v2: Full screen menu item is no

Re: [Qemu-devel] [PATCH 2/2] ui/gtk: Support versions of VTE before 2.26

2013-02-22 Thread Anthony Liguori
Stefan Weil writes: > This is needed for current Debian stable (Squeeze). > > VTE versions before 2.26 did not support VtePty. > > Lower the version requirement and use alternate code which works for Debian. > > Signed-off-by: Stefan Weil Reviewed-by: Anthony Liguori Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 1/2] ui/gtk: Support versions of gtk+-2.0 before 2.90.7

2013-02-22 Thread Anthony Liguori
Stefan Weil writes: > This is needed for current Debian stable (Squeeze). > > Extract from NEWS in gtk+-2.0: > > Overview of Changes from GTK+ 2.90.6 to 2.90.7 > == > > * All GDK keysym names have been changed from GDK_keysym to GDK_KEY_keysym; >

[Qemu-devel] [PATCH 03/42] migration: move more error handling to migrate_fd_cleanup

2013-02-22 Thread Paolo Bonzini
The next patch will add more cases where qemu_savevm_state_cancel needs to be called; prepare for that already, the function can be called twice with no ill effect. Reviewed-by: Orit Wasserman Reviewed-by: Juan Quintela Signed-off-by: Paolo Bonzini --- migration.c | 16 ++-- 1 file

[Qemu-devel] [PATCH v6 2/9] linux-headers: resync from mainline to add ARM KVM headers

2013-02-22 Thread Peter Maydell
Resync QEMU's copy of the Linux kernel headers from git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master commit 2ef14f4. This adds the ARM KVM headers, since ARM KVM support has just hit mainline via Russell's ARM tree. This is not a pure sync -- I have removed by hand some chan

[Qemu-devel] [PATCH v6 3/9] ARM: KVM: Add support for KVM on ARM architecture

2013-02-22 Thread Peter Maydell
From: Christoffer Dall Add basic support for KVM on ARM architecture. Signed-off-by: Christoffer Dall [PMM: Minor tweaks and code cleanup, switch to ONE_REG] Signed-off-by: Peter Maydell Reviewed-by: Paolo Bonzini --- hw/arm_pic.c | 26 target-arm/Makefile.objs |1 + t

[Qemu-devel] [PATCH 3/6] cpu-exec: wrap tcg_qemu_tb_exec() in a fn to restore the PC

2013-02-22 Thread Peter Maydell
If tcg_qemu_tb_exec() returns a value whose low bits don't indicate a link to an indexed next TB, this means that the TB execution never started (eg because the instruction counter hit zero). In this case the guest PC has to be reset to the address of the start of the TB. Refactor the cpu-exec cod

Re: [Qemu-devel] [PATCH] ui/gtk: Use menu item from stock for full screen

2013-02-22 Thread Anthony Liguori
Stefan Weil writes: > This reduces the required translations and gives a nicer menu > with an icon. > > Signed-off-by: Stefan Weil > --- > po/de_DE.po|4 > po/it.po |4 > po/messages.po |4 > ui/gtk.c |3 ++- > 4 files changed, 2 insertions(+), 13

[Qemu-devel] [PATCH 2/6] cpu: Introduce ENV_OFFSET macros

2013-02-22 Thread Peter Maydell
From: Andreas Färber Introduce ENV_OFFSET macros which can be used in non-target-specific code that needs to generate TCG instructions which reference CPUState fields given the cpu_env register that TCG targets set up with a pointer to the CPUArchState struct. Signed-off-by: Andreas Färber Sign

[Qemu-devel] [PATCH 35/42] migration: use QEMUFile for migration channel lifetime

2013-02-22 Thread Paolo Bonzini
As a start, use QEMUFile to store the destination and close it. qemu_get_fd gets a file descriptor that will be used by the write callbacks. Reviewed-by: Orit Wasserman Reviewed-by: Juan Quintela Signed-off-by: Paolo Bonzini --- include/migration/migration.h | 7 --- migration-exec.c

[Qemu-devel] [PATCH v2] ui/gtk: Support versions of VTE before 0.26

2013-02-22 Thread Stefan Weil
This is needed for current Debian stable (Squeeze). VTE versions before 0.26 did not support VtePty. Lower the version requirement and use alternate code which works for Debian. Signed-off-by: Stefan Weil --- v2: Fixed version in subject and preprocessor code. configure |2 +- ui/gtk.c

Re: [Qemu-devel] [PATCH v2] gtk: Rename File to Machine menu and add stop, reset and power-down items

2013-02-22 Thread Anthony Liguori
Jan Kiszka writes: > On 2013-02-22 18:53, Anthony Liguori wrote: >> Jan Kiszka writes: >> >>> On 2013-02-22 18:16, Anthony Liguori wrote: Jan Kiszka writes: > This adds basic guest control commands to the "Machine" menu - a nice > added-value for the GTK UI. We pick up the st

  1   2   3   4   5   >