Re: [Qemu-devel] [PATCH for-1.4 0/2] fix migration failure from 1.3 due to SeaBIOS size change

2013-02-11 Thread Paolo Bonzini
Il 11/02/2013 17:13, Philipp Hahn ha scritto: > We currenty are carrying the attached patch with our Debian based > distribution, which fixes a very similar issue with the PXE-BIOSs, because > Debian provides it's own compilation of etherboot and iPXE. > > As each upgrade threatens to break all

Re: [Qemu-devel] [PATCH for-1.4 0/2] fix migration failure from 1.3 due to SeaBIOS size change

2013-02-11 Thread Philipp Hahn
Hello, On Wednesday 06 February 2013 01:48:24 Michael Roth wrote: > Migration from 1.3 currently fails due to a mismatch between the expected > size of 256KB and the received size of 128KB for seabios. ... > 2) We can begin checking in past versions of SeaBIOS and other roms and > loading those ac

[Qemu-devel] [PATCH v10 2/4] qemu-img: Add "Quiet mode" option

2013-02-11 Thread Miroslav Rezanina
There can be a need to turn output to stdout off. This patch adds a -q option that enable "Quiet mode". In Quiet mode, only errors are printed out. Signed-off-by: Miroslav Rezanina --- block.c | 12 ++-- blockdev.c|6 +- include/block/block.h |3 +- qemu-img-c

Re: [Qemu-devel] tap devices not receiving packets from a bridge

2013-02-11 Thread Peter Lieven
On 23.01.2013 11:03, Michael S. Tsirkin wrote: On Tue, Jan 22, 2013 at 10:04:07AM +0100, Peter Lieven wrote: On 23.11.2012 12:01, Michael S. Tsirkin wrote: On Fri, Nov 23, 2012 at 10:41:21AM +0100, Peter Lieven wrote: Am 23.11.2012 um 08:02 schrieb Stefan Hajnoczi: On Thu, Nov 22, 2012 at 0

[Qemu-devel] [PATCH v10 3/4] This patch adds new qemu-img subcommand that compares content of two disk images.

2013-02-11 Thread Miroslav Rezanina
Signed-off-by: Miroslav Rezanina --- qemu-img-cmds.hx |6 + qemu-img.c | 290 +- qemu-img.texi| 53 ++ 3 files changed, 348 insertions(+), 1 deletions(-) diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index 9283776..4

[Qemu-devel] [PATCH v10 4/4] qemu-iotests: Add qemu-img compare test

2013-02-11 Thread Miroslav Rezanina
Simple test for qemu-img compare to check it's working correctly. Signed-off-by: Miroslav Rezanina --- tests/qemu-iotests/048 | 77 tests/qemu-iotests/048.out | 25 ++ tests/qemu-iotests/group |1 + 3 files changed, 103 inser

[Qemu-devel] [PATCH v10 0/4] Add subcommand compare for qemu-img

2013-02-11 Thread Miroslav Rezanina
This is 10th version of patch adding compare subcommand that compares two images. Compare has following criteria: - only data part is compared - unallocated sectors are not read to be zeroed/unallocated to compare rest - qemu-img returns: - 0 if images are identical - 1 if images differ

[Qemu-devel] [PATCH v10 1/4] block: Add synchronous wrapper for bdrv_co_is_allocated_above

2013-02-11 Thread Miroslav Rezanina
There's no synchronous wrapper for bdrv_co_is_allocated_above function so it's not possible to check for sector allocation in an image with a backing file. Signed-off-by: Miroslav Rezanina --- block.c | 39 +++ include/block/block.h |2 ++

[Qemu-devel] [Bug 921208] Re: win7/x64 installer hangs on startup with 0x0000005d.

2013-02-11 Thread Cole Robinson
Just for reference, the qemu-devel thread mentioned in comment #11 is: https://lists.gnu.org/archive/html/qemu-devel/2012-09/msg00972.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/921208 Title:

[Qemu-devel] [Bug 1122492] [NEW] qemu and grub2 rescue floppy don't get along

2013-02-11 Thread Cole Robinson
Public bug reported: With qemu.git as of Feb 11 2013: # grub2-mkrescue -o test.img # ./x86_64-softmmu/qemu-system-x86_64 -fda test.img -curses SeaBIOS (version ?-20130206_051134-ccnode4) iPXE v1.0.0-591-g7aee315 iPXE (http://ipxe.org) 00:03.0 C900 PCI2.10 PnP PMM+07FC7EC0+07F87EC0 C900 Bootin

Re: [Qemu-devel] Char flow control patches

2013-02-11 Thread Amit Shah
On (Mon) 11 Feb 2013 [12:37:34], Amit Shah wrote: > On (Wed) 30 Jan 2013 [08:38:50], Anthony Liguori wrote: > > Amit Shah writes: > > > > > Hi Anthony, > > > > > > I did some basic testing of the char flow control patches from your > > > char-flow.2 branch. With the following patch applied, thin

Re: [Qemu-devel] [PATCH 4/6] qemu-log: Rename the public-facing cpu_set_log function to qemu_set_log

2013-02-11 Thread Peter Maydell
On 11 February 2013 19:28, Andreas Färber wrote: > Am 11.02.2013 17:41, schrieb Peter Maydell: >> diff --git a/hw/ppc.c b/hw/ppc.c >> index c52e22f..6053bd5 100644 >> --- a/hw/ppc.c >> +++ b/hw/ppc.c >> @@ -1189,7 +1189,7 @@ void PPC_debug_write (void *opaque, uint32_t addr, >> uint32_t val) >>

Re: [Qemu-devel] [PATCH] (RFC) target-ppc: Remove vestigial PowerPC 620 support

2013-02-11 Thread Alexander Graf
On 11.02.2013, at 16:13, Andreas Färber wrote: > Am 11.02.2013 05:50, schrieb David Gibson: >> The PowerPC 620 was the very first 64-bit PowerPC implementation, but >> hardly anyone ever actually used the chips. qemu notionally supports the >> 620, but since we don't actually have code to implem

Re: [Qemu-devel] [RFC PATCH RDMA support v2: 3/6] install new monitor commands and setup RDMA capabilities

2013-02-11 Thread Michael R. Hines
None of the other migration QMP commands use dashes. Shouldn't I stay consistent with the other commands? If someone wants to re-work the migration command structure as a whole, I'll certainly adapt to the new structure. On 02/11/2013 05:58 PM, Eric Blake wrote: +++ b/qapi-schema.json #

[Qemu-devel] [PATCH 6/8] target-ppc: Rework get_physical_address()

2013-02-11 Thread David Gibson
Currently get_physical_address() first checks to see if translation is enabled in the MSR, then in the translation on case switches on the mmu type. Except that for BookE MMUs, translation is always on, and so it has to switch in the "translation off" case as well and do the same thing as the tran

[Qemu-devel] [PATCH 3/8] target-ppc64: Disentangle 64-bit version of pte_check()

2013-02-11 Thread David Gibson
Currently support for both 32-bit and 64-bit hash MMUs share an implementation of pte_check. But there are enough differences that this means the shared function has several very ugly conditionals on "is_64b". This patch cleans things up by separating out the 64-bit version (putting it into mmu-h

[Qemu-devel] [PATCH 4/8] target-ppc: Disentangle 64-bit version of find_pte()

2013-02-11 Thread David Gibson
32-bit and 64-bit hash MMU implementations currently share a find_pte function. This results in a whole bunch of ugly conditionals in the shared function, and not all that much actually shared code. This patch separates out the 64-bit version, putting it in mmu-hash64.c, and removes the condition

[Qemu-devel] [PATCH 8/8] target-ppc Disentangle ppc64 hash mmu path for cpu_ppc_handle_mmu_fault

2013-02-11 Thread David Gibson
cpu_ppc_handle_mmu_fault() calls get_physical_address() (whose behaviour depends on MMU type) then, if that fails, issues an appropriate exception - which again has a number of dependencies on MMU type. This patch starts converting cpu_ppc_handle_mmu_fault() to have a single switch on MMU type, ca

[Qemu-devel] [0/8] RFC: target-ppc: Start disentangling different MMU types

2013-02-11 Thread David Gibson
The target-ppc code supports CPUs with a number of different MMU types: there's both the 32-bit and 64-bit versions of the "classic" hash page table based powerpc mmu and there's also the BookE and 40x MMUs. Currently handling of all these has a roughly shared path in mmu_helper.c. Although code

[Qemu-devel] [PATCH 7/8] target-ppc: Disentangle 64-bit hash MMU get_physical_address() paths

2013-02-11 Thread David Gibson
Depending on the MSR state, for 64-bit hash MMUs, get_physical_address can either call check_physical (which has further tests for mmu type) or get_segment64. This patch splits off the whole get_physical_addresss() path for 64-bit hash MMUs into its own function, which handles real mode correctly

[Qemu-devel] [RFC PATCH v1 2/4] xilinx.h: s/xilinx_axiethernetdma()/xilinx_axidma()

2013-02-11 Thread Peter Crosthwaite
This function has nothing to do with ethernet. Its reusable for all DMA clients. Dropped the "ethernet" in the name accordingly. Signed-off-by: Peter Crosthwaite --- hw/petalogix_ml605_mmu.c |4 ++-- hw/xilinx.h |5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) di

[Qemu-devel] [PATCH] target-ppc: Remove vestigial PowerPC 620 support (v2)

2013-02-11 Thread David Gibson
The PowerPC 620 was the very first 64-bit PowerPC implementation, but hardly anyone ever actually used the chips. qemu notionally supports the 620, but since we don't actually have code to implement the segment table, the support is broken (quite likely in other ways too). This partch, therefore,

[Qemu-devel] [PATCH 5/8] target-ppc: Disentangle 64-bit version of get_segment()

2013-02-11 Thread David Gibson
The poorly named get_segment() function handles most of the address translation logic for hash-based MMUs. It has many ugly conditionals on whether the MMU is 32-bit or 64-bit. This patch splits the function into 32 and 64-bit versions, using the switch on mmu_type that's already in the caller (g

[Qemu-devel] [PATCH 2/8] target-ppc: Move SLB handling into a mmu-hash64.c

2013-02-11 Thread David Gibson
As a first step to disentangling the handling for 64-bit hash MMUs from the rest, we move the code handling the Segment Lookaside Buffer (SLB) (which only exists on 64-bit hash MMUs) into a new mmu-hash64.c file. Signed-off-by: David Gibson --- target-ppc/Makefile.objs |5 +- target-ppc/cpu.

[Qemu-devel] [PATCH 1/8] target-ppc: Trivial cleanups in mmu_helper.c

2013-02-11 Thread David Gibson
This removes the never-used pte64_invalidate() function, and makes ppcmas_tlb_check() static, since it's only used within that file. Signed-off-by: David Gibson --- target-ppc/cpu.h|3 --- target-ppc/mmu_helper.c | 11 +++ 2 files changed, 3 insertions(+), 11 deletions(-)

[Qemu-devel] [RFC PATCH v1 3/4] xilinx_axienet: Create Proxy object for stream

2013-02-11 Thread Peter Crosthwaite
Create a separate child object to proxy the stream slave connection. This is setup for future work where a second stream slave connection is needed. The new child object is created at qdev init time and is linked back to the parent (the ethernet device itself) automatically. Stream slave masters d

[Qemu-devel] [PATCH for-1.4] cadance_uart: Accept input after rx FIFO pop

2013-02-11 Thread Peter Crosthwaite
The device returns false from the can receive function when the FIFO is full. This means the device should check for buffered input whenever a byte is popped from the FIFO. Reported-by: Jason Wu Signed-off-by: Peter Crosthwaite --- hw/cadence_uart.c |1 + 1 files changed, 1 insertions(+), 0

[Qemu-devel] [RFC PATCH v1 4/4] xilinx_axienet: stub out second stream connection

2013-02-11 Thread Peter Crosthwaite
Example patch adding a second proxy object for the second stream connection of axienet. This is a non-functional RFC, please see the cover letter for discussion. Signed-off-by: Peter Crosthwaite --- hw/xilinx_axienet.c | 35 +++ 1 files changed, 35 insertions(

[Qemu-devel] [RFC PATCH v1 1/4] xilinx.h: Dont qdev_create from ethernet_create()

2013-02-11 Thread Peter Crosthwaite
Pulled the qdev_create functionality out of xilinx_axiethernet_create() and pushed it up to the petalogix_ml605_mmu machine model. This makes the ethernet create+init process consistent with the AXI DMA. Renamed function to xilinx_axiethernet_init accordingly. Signed-off-by: Peter Crosthwaite ---

[Qemu-devel] [RFC PATCH v1 0/4] Stream - Multiple connections for the one device

2013-02-11 Thread Peter Crosthwaite
Hi all. The Xilinx AXIEnet and DMA devices have two AXI stream connections (control and data), only one of which is currently modelled (data). AXI stream is modelled using the stream QOM interface described in stream.h. Unfortunately, interfaces have no nice way of modelling multiple connections

Re: [Qemu-devel] [Qemu-ppc] [PATCH] (RFC) target-ppc: Remove vestigial PowerPC 620 support

2013-02-11 Thread David Gibson
On Mon, Feb 11, 2013 at 04:13:58PM +0100, Andreas Färber wrote: > Am 11.02.2013 05:50, schrieb David Gibson: > > The PowerPC 620 was the very first 64-bit PowerPC implementation, but > > hardly anyone ever actually used the chips. qemu notionally supports the > > 620, but since we don't actually h

Re: [Qemu-devel] [PATCH 4/7 v2] KVM regsync: Add register bitmap parameter to do_kvm_cpu_synchronize_state

2013-02-11 Thread Marcelo Tosatti
On Fri, Feb 01, 2013 at 10:47:37AM -0500, Jason J. Herne wrote: > On 01/24/2013 07:40 AM, Alexander Graf wrote: > >I think for now the best choice for get_regs() would be to ignore the > >FULL/RESET bits and always keep the syncing as it happens today under the > >RUNTIME umbrella only. So all of

[Qemu-devel] [RFC PATCH RDMA support v2: 1/6] add openfabrics RDMA libraries, configure options to build

2013-02-11 Thread Michael R. Hines
From: "Michael R. Hines" This patchest introduces RDMA-based live-migration to QEMU. A copy of this documentation is located online: http://wiki.qemu.org/Features/RDMALiveMigration DESIGN: == 1. In order to provide maximum cross-device compatibility, we use the librdmacm library, wh

Re: [Qemu-devel] [RFC PATCH RDMA support v2: 3/6] install new monitor commands and setup RDMA capabilities

2013-02-11 Thread Eric Blake
On 02/11/2013 03:49 PM, Michael R. Hines wrote: > From: "Michael R. Hines" > > > Signed-off-by: Michael R. Hines > --- > +++ b/include/qapi/qmp/qerror.h > @@ -165,6 +165,12 @@ void assert_no_error(Error *err); > #define QERR_MIGRATION_ACTIVE \ > ERROR_CLASS_GENERIC_ERROR, "There's a migr

[Qemu-devel] [RFC PATCH RDMA support v2: 6/6] send memory over RDMA as blocks are iterated

2013-02-11 Thread Michael R. Hines
From: "Michael R. Hines" Signed-off-by: Michael R. Hines --- arch_init.c | 84 --- savevm.c| 59 - 2 files changed, 139 insertions(+), 4 deletions(-) diff --git a/arch_init.c b/arch_init.c

[Qemu-devel] [RFC PATCH RDMA support v2: 1/6] add openfabrics RDMA libraries, configure options to build

2013-02-11 Thread Michael R. Hines
From: "Michael R. Hines" This patchest introduces RDMA-based live-migration to QEMU. A copy of this documentation is located online: http://wiki.qemu.org/Features/RDMALiveMigration DESIGN: == 1. In order to provide maximum cross-device compatibility, we use the librdmacm library, wh

[Qemu-devel] [RFC PATCH RDMA support v2: 2/6] create migration-rdma.c for core RDMA migration code

2013-02-11 Thread Michael R. Hines
From: "Michael R. Hines" Signed-off-by: Michael R. Hines --- include/qemu/rdma.h | 281 ++ migration-rdma.c| 1444 +++ 2 files changed, 1725 insertions(+) create mode 100644 include/qemu/rdma.h create mode 100644 migration-rdma.c

[Qemu-devel] [RFC PATCH RDMA support v2: 5/6] connection-setup code between client/server

2013-02-11 Thread Michael R. Hines
From: "Michael R. Hines" Signed-off-by: Michael R. Hines --- migration-tcp.c | 19 +++ migration.c | 53 - 2 files changed, 71 insertions(+), 1 deletion(-) diff --git a/migration-tcp.c b/migration-tcp.c index e78a296.

[Qemu-devel] [RFC PATCH RDMA support v2: 3/6] install new monitor commands and setup RDMA capabilities

2013-02-11 Thread Michael R. Hines
From: "Michael R. Hines" Signed-off-by: Michael R. Hines --- hmp-commands.hx | 28 hmp.c | 12 hmp.h |2 ++ include/migration/qemu-file.h |1 + include/qapi/qmp/qerror.h |

[Qemu-devel] [RFC PATCH RDMA support v2: 4/6] initialize RDMA options when QEMU first runs on command-line

2013-02-11 Thread Michael R. Hines
From: "Michael R. Hines" Signed-off-by: Michael R. Hines --- exec.c | 27 +++ vl.c | 13 + 2 files changed, 40 insertions(+) diff --git a/exec.c b/exec.c index b85508b..b7ac6fa 100644 --- a/exec.c +++ b/exec.c @@ -25,6 +25,8 @@ #endif #include "qe

Re: [Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

2013-02-11 Thread Jeff Cody
On Mon, Feb 11, 2013 at 10:33:53PM +0100, Stefan Weil wrote: > Am 11.02.2013 20:38, schrieb Jeff Cody: > > I've done some testing back and forth between VPC, Win Server 2012 > > Hyper-V, and qemu/kvm with and without this patch applied. > > > > The short: this patch will break Virtual PC VHD compat

Re: [Qemu-devel] [PATCH V21 6/7] Add support for cancelling of a TPM command

2013-02-11 Thread Corey Bryant
On 02/11/2013 04:38 PM, Stefan Berger wrote: On 02/11/2013 01:46 PM, Corey Bryant wrote: @@ -79,25 +88,36 @@ static uint32_t tpm_passthrough_get_size_from_buffer(const uint8_t *buf) return be32_to_cpu(resp->len); } -static int tpm_passthrough_unix_tx_bufs(int tpm_fd, +static int tpm_

Re: [Qemu-devel] [PATCH V21 6/7] Add support for cancelling of a TPM command

2013-02-11 Thread Stefan Berger
On 02/11/2013 01:46 PM, Corey Bryant wrote: @@ -79,25 +88,36 @@ static uint32_t tpm_passthrough_get_size_from_buffer(const uint8_t *buf) return be32_to_cpu(resp->len); } -static int tpm_passthrough_unix_tx_bufs(int tpm_fd, +static int tpm_passthrough_unix_tx_bufs(TPMPassthruState *tpm_

Re: [Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

2013-02-11 Thread Stefan Weil
Am 11.02.2013 20:38, schrieb Jeff Cody: > I've done some testing back and forth between VPC, Win Server 2012 > Hyper-V, and qemu/kvm with and without this patch applied. > > The short: this patch will break Virtual PC VHD compatibility (as it > exists under Win7), but allow compatibility for VHD fi

Re: [Qemu-devel] [PATCH 2/6] qemu-log: Abstract out "print usage message about valid log categories"

2013-02-11 Thread Peter Maydell
On 11 February 2013 19:23, Andreas Färber wrote: > Am 11.02.2013 17:41, schrieb Peter Maydell: >> +void qemu_print_log_usage(FILE *f) >> +{ >> +const CPULogItem *item; > > If this gets resubmitted or included in a PULL, a while line here would > match our usual separate-variables-from-statemen

Re: [Qemu-devel] Google Summer of Code 2013 ideas wiki open

2013-02-11 Thread Stefan Hajnoczi
On Thu, Feb 7, 2013 at 4:19 PM, Stefan Hajnoczi wrote: > I believe Google will announce GSoC again this year (there is > no guarantee though) and I have created the wiki page so we can begin > organizing project ideas that students can choose from. Google Summer of Code 2013 has just been announc

Re: [Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

2013-02-11 Thread Jeff Cody
On Mon, Feb 11, 2013 at 03:14:36PM -0600, Anthony Liguori wrote: > Paolo Bonzini writes: > > > Il 11/02/2013 21:13, Anthony Liguori ha scritto: > >> Applied. Thanks. > >> > >> Regards, > >> > >> Anthony Liguori > > > > I guess this was a mistake, please revert. > > No, it wasn't. The patch w

Re: [Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

2013-02-11 Thread Anthony Liguori
Paolo Bonzini writes: > Il 11/02/2013 21:13, Anthony Liguori ha scritto: >> Applied. Thanks. >> >> Regards, >> >> Anthony Liguori > > I guess this was a mistake, please revert. No, it wasn't. The patch was reviewed and tested. What's the problem. It's proposed for 1.4 so it's now or never.

Re: [Qemu-devel] [PATCH] ide: log error when trying to use ATAPI overlapping features

2013-02-11 Thread Hervé Poussineau
Peter Maydell a écrit : On 10 February 2013 22:12, Hervé Poussineau wrote: --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -1394,8 +1394,10 @@ void ide_exec_cmd(IDEBus *bus, uint32_t val) break; case WIN_PACKETCMD: /* overlapping commands not supported */ -if (s->featu

Re: [Qemu-devel] [PATCH] (RFC) target-ppc: Remove vestigial PowerPC 620 support

2013-02-11 Thread Hervé Poussineau
Andreas Färber a écrit : Am 11.02.2013 05:50, schrieb David Gibson: The PowerPC 620 was the very first 64-bit PowerPC implementation, but hardly anyone ever actually used the chips. qemu notionally supports the 620, but since we don't actually have code to implement the segment table, the suppo

[Qemu-devel] [PATCH for-1.4] target-ppc: Fix "G2leGP3" PVR

2013-02-11 Thread Andreas Färber
Unlike derived PVR constants mapped to CPU_POWERPC_G2LEgp3, the "G2leGP3" model definition itself used the CPU_POWERPC_G2LEgp1 PVR. Fixing this will allow to alias CPU_POWERPC_G2LEgp3-using types to "G2leGP3". Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber --- target-ppc/translate_ini

[Qemu-devel] [PATCH for-1.4?] target-ppc: Fix CPU_POWERPC_MPC8547E

2013-02-11 Thread Andreas Färber
It was defined to ..._MPC8545E_v21 rather than ..._MPC8547E_v21. Due to both resolving to CPU_POWERPC_e500v2_v21 this did not show. Fixing this nontheless helps with QOM'ifying CPU aliases. Signed-off-by: Andreas Färber --- target-ppc/translate_init.c |2 +- 1 Datei geändert, 1 Zeile hinzug

Re: [Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

2013-02-11 Thread Paolo Bonzini
Il 11/02/2013 21:13, Anthony Liguori ha scritto: > Applied. Thanks. > > Regards, > > Anthony Liguori I guess this was a mistake, please revert. Paolo

Re: [Qemu-devel] [PATCH for-1.4 stable v2 0/3] block-migration: fix "Unknown flags" error

2013-02-11 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

2013-02-11 Thread Jeff Cody
On Mon, Feb 11, 2013 at 09:09:48PM +0100, Kevin Wolf wrote: > Am 11.02.2013 20:38, schrieb Jeff Cody: > > I've done some testing back and forth between VPC, Win Server 2012 > > Hyper-V, and qemu/kvm with and without this patch applied. > > First of all, thanks a lot for doing all the testing! > >

Re: [Qemu-devel] [PATCH for-1.4 v3 0/6] Error reporting fixes

2013-02-11 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

2013-02-11 Thread Anthony Liguori
Applied. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PULL for-1.4] QMP queue

2013-02-11 Thread Anthony Liguori
Pulled. Thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

2013-02-11 Thread Kevin Wolf
Am 11.02.2013 20:38, schrieb Jeff Cody: > I've done some testing back and forth between VPC, Win Server 2012 > Hyper-V, and qemu/kvm with and without this patch applied. First of all, thanks a lot for doing all the testing! > The short: this patch will break Virtual PC VHD compatibility (as it >

Re: [Qemu-devel] [PATCH] pc-bios: build OpenBIOS if possible

2013-02-11 Thread Anthony Liguori
Blue Swirl writes: > On Sun, Feb 10, 2013 at 6:42 AM, Michael Tokarev wrote: >> 09.02.2013 23:01, Blue Swirl wrote: >>> >>> Check if xsltproc and Sparc32, Sparc64 and PPC compilers >>> are available. If found, rebuild OpenBIOS ROMs from submodule. >>> >>> Signed-off-by: Blue Swirl >>> --- >>> A

Re: [Qemu-devel] [PATCH for 1.4] block/vpc: Fix size calculation

2013-02-11 Thread Jeff Cody
On Mon, Feb 11, 2013 at 09:54:56AM +0100, Kevin Wolf wrote: > Am 08.02.2013 18:43, schrieb Stefan Weil: > > Am 08.02.2013 13:14, schrieb Jeff Cody: > >> On Fri, Feb 08, 2013 at 09:38:47AM +0100, Kevin Wolf wrote: > >>> Am 07.02.2013 20:26, schrieb Stefan Weil: > From: Stefan Weil > > >>>

Re: [Qemu-devel] [PATCH 6/6] qemu-log: Rename CPULogItem, cpu_log_items to QEMULogItem, qemu_log_items

2013-02-11 Thread Andreas Färber
Am 11.02.2013 17:41, schrieb Peter Maydell: > Rename the typedef CPULogItem and the public array cpu_log_items > to names that better reflect the fact that the qemu_log functionality > isn't restricted to TCG CPU debug logs any more. > > Signed-off-by: Peter Maydell > --- > include/qemu/log.h |

Re: [Qemu-devel] [PATCH 5/6] cpus.c: Drop unnecessary set_cpu_log()

2013-02-11 Thread Andreas Färber
Am 11.02.2013 17:41, schrieb Peter Maydell: > The set_cpu_log() function in cpus.c is a fairly simple wrapper > which is only called from one location. Just inline the code > into vl.c, since there is no need to indirect it via cpus.c > and the handling of the error case is more appropriate to vl.c

Re: [Qemu-devel] [PATCH 4/6] qemu-log: Rename the public-facing cpu_set_log function to qemu_set_log

2013-02-11 Thread Andreas Färber
Am 11.02.2013 17:41, schrieb Peter Maydell: > Rename the public-facing function cpu_set_log to qemu_set_log. This > requires us to rename the internal-only qemu_set_log() to > do_qemu_set_log(). > > Signed-off-by: Peter Maydell > --- > bsd-user/main.c |2 +- > cpus.c

Re: [Qemu-devel] [PATCH 3/6] qemu-log: Rename cpu_str_to_log_mask to qemu_str_to_log_mask

2013-02-11 Thread Andreas Färber
Am 11.02.2013 17:41, schrieb Peter Maydell: > Rename cpu_str_to_log_mask() to qemu_str_to_log_mask(), since > the qemu_log functionality is no longer restricted to TCG CPU > debug logging. > > Signed-off-by: Peter Maydell > --- > bsd-user/main.c|2 +- > cpus.c |2 +- > in

Re: [Qemu-devel] [PATCH 2/6] qemu-log: Abstract out "print usage message about valid log categories"

2013-02-11 Thread Andreas Färber
Am 11.02.2013 17:41, schrieb Peter Maydell: > Abstract out the "print a human readable list of all the > valid log categories" functionality which is currently duplicated > in three separate places. (We leave the monitor.c help_cmd() > implementation as-is since it wants to send the message to > th

Re: [Qemu-devel] [PATCH 1/6] qemu-log: Unify {cpu_set, set_cpu}_log_filename as qemu_set_log_filename

2013-02-11 Thread Andreas Färber
Am 11.02.2013 17:41, schrieb Peter Maydell: > The qemu_log() functionality is no longer specific to TCG CPU debug logs. > Rename cpu_set_log_filename() to qemu_set_log_filename() and drop the > pointless wrapper set_cpu_log_filename(). > > Signed-off-by: Peter Maydell > --- > bsd-user/main.c

[Qemu-devel] [PATCH for-next v3 0/5] qtest: tmp105 cleanups and MMIO support

2013-02-11 Thread Andreas Färber
Hello, These are the follow-ups for 1.5 to permanently fix qtest endianness issues. Based on my for-1.4 series plus for-1.4 @value patch. v3 implements the endian fixes the new functions were supposed to address and cleans up existing macros to align with the new inline functions. Regards, Andre

Re: [Qemu-devel] [PATCH V21 6/7] Add support for cancelling of a TPM command

2013-02-11 Thread Corey Bryant
On 02/08/2013 04:42 PM, Stefan Berger wrote: This patch adds support for cancelling an executing TPM command. In Linux for example a user can cancel a command through the TPM's sysfs 'cancel' entry using echo "1" > /sysfs/class/misc/tpm0/device/cancel This patch propagates the cancellation of

Re: [Qemu-devel] [PATCH 0/6] qemu_log: remove 'cpu' from qemu log function names

2013-02-11 Thread Richard Henderson
On 2013-02-11 08:41, Peter Maydell wrote: Peter Maydell (6): qemu-log: Unify {cpu_set,set_cpu}_log_filename as qemu_set_log_filename qemu-log: Abstract out "print usage message about valid log categories" qemu-log: Rename cpu_str_to_log_mask to qemu_str_to_log_mask qemu-log:

Re: [Qemu-devel] [PATCH V21 2/7] Add TPM (frontend) hardware interface (TPM TIS) to QEMU

2013-02-11 Thread Corey Bryant
On 02/11/2013 01:35 PM, Stefan Berger wrote: On 02/11/2013 12:53 PM, Corey Bryant wrote: On 02/08/2013 04:42 PM, Stefan Berger wrote: The TPM TIS driver's backend was previously chosen in the code added to arch_init. The frontend holds a pointer to the chosen backend (interface). Communi

[Qemu-devel] [PATCH for-next v3 5/5] qtest: Add MMIO support

2013-02-11 Thread Andreas Färber
Introduce [qtest_]{read,write}[bwlq]() libqtest functions and corresponding QTest protocol commands to replace local versions in libi2c-omap.c. Also convert m48t59-test's cmos_{read,write}_mmio() to {read,write}b(). Signed-off-by: Andreas Färber --- Makefile.objs |1 - Makefile.target

[Qemu-devel] [PATCH for-next v3 3/5] libqtest: Convert macros to functions and clean up documentation

2013-02-11 Thread Andreas Färber
libqtest.h provides a number of shortcut macros to avoid tests feeding it the QTestState they operate on. Most of these can easily be turned into static inline functions, so let's do that for clarity. This avoids getting off-by-one error messages when passing wrong args. Some macros had a val argu

[Qemu-devel] [PATCH for-next v3 1/5] tmp105-test: Combine assertions of 16-bit responses

2013-02-11 Thread Andreas Färber
From: Andreas Färber Instead of comparing bytes individually, compare the full values. This aids spotting endianness issues. Signed-off-by: Andreas Färber --- tests/tmp105-test.c |8 1 Datei geändert, 4 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) diff --git a/tests/tmp105-test.c

[Qemu-devel] [PATCH for-next v3 4/5] libqtest: Introduce qtest_qmpv() and convert remaining macro

2013-02-11 Thread Andreas Färber
In order to convert qmp() macro to an inline function, expose a qtest_qmpv() function, reused by qtest_qmp(). We can't apply GCC_FMT_ATTR() since fdc-test is using zero-length format strings, which would result in warnings treated as errors. Signed-off-by: Andreas Färber --- tests/libqtest.c |

[Qemu-devel] [PATCH for-next v3 2/5] tmp105: Add debug output

2013-02-11 Thread Andreas Färber
From: Andreas Färber Signed-off-by: Andreas Färber --- hw/tmp105.c | 27 +-- 1 Datei geändert, 25 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/hw/tmp105.c b/hw/tmp105.c index 3ad2d2f..5dafa37 100644 --- a/hw/tmp105.c +++ b/hw/tmp105.c @@ -23,6 +23,18 @@ #

Re: [Qemu-devel] [PATCH V21 2/7] Add TPM (frontend) hardware interface (TPM TIS) to QEMU

2013-02-11 Thread Stefan Berger
On 02/11/2013 12:53 PM, Corey Bryant wrote: On 02/08/2013 04:42 PM, Stefan Berger wrote: The TPM TIS driver's backend was previously chosen in the code added to arch_init. The frontend holds a pointer to the chosen backend (interface). Communication with the backend is based on thread poo

Re: [Qemu-devel] [PATCH 10/10] mipsn32-linux-user: Configure the architecture properly

2013-02-11 Thread Richard Henderson
On 2013-02-11 10:15, Peter Maydell wrote: This is a pretty huge patch. Is it literally just moving code from the mipsn32/ headers into suitably ifdeffed blocks in the mips64 headers? (I ask to save me the effort of reviewing all 600 lines :-)) Yep, code movement only, modulo ifdefs. I did have

[Qemu-devel] [Bug 1054558] Re: 1366x768 resolution missing

2013-02-11 Thread Bug Watch Updater
** Changed in: debian Status: Unknown => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1054558 Title: 1366x768 resolution missing Status in QEMU: New Status in Debian GNU/Linux: New

Re: [Qemu-devel] [PATCH 00/10] Support mips64/mipsn32-linux-user

2013-02-11 Thread Peter Maydell
On 11 February 2013 16:10, Richard Henderson wrote: > On 2013-02-11 07:57, Peter Maydell wrote: >> Well, just to start with, I looked at patch 1 and thought >> "why is it ok to delete these without it making something >> fail to compile?". > > Fair enough. Assume the replies I just sent will be i

Re: [Qemu-devel] [PATCH 10/10] mipsn32-linux-user: Configure the architecture properly

2013-02-11 Thread Peter Maydell
On 10 February 2013 18:30, Richard Henderson wrote: > N32 is a 64-bit cpu with a 32-bit address space. We have > existing cpp defines for this situation, but weren't using them. > > This does mean that the linux-user/mipsn32 directory must be > merged with the linux-user/mips64 directory, and dif

Re: [Qemu-devel] [PATCH 05/10] mips-linux-user: Fix n32 and n64 syscalls

2013-02-11 Thread Richard Henderson
On 2013-02-11 09:33, Peter Maydell wrote: You're only changing the cast here, so this isn't something you should feel the need to fix in this patch, but do you know what's special about -1133 ? It does correspond to the kernel code. C.f. EMAXERRNO. r~

Re: [Qemu-devel] [PATCH 09/10] mipsn32-linux-user: Restrict address space to 31-bits.

2013-02-11 Thread Peter Maydell
On 11 February 2013 17:56, Richard Henderson wrote: > On 2013-02-11 09:44, Peter Maydell wrote: >> Maybe clearer to pull out the "#if HOST_LONG_BITS == 64" into >> its own #if rather than having it as an && term in both the #if >> and the #elif? > > > In which case you get two "base" (unsigned lon

Re: [Qemu-devel] [PATCH 04/10] mips-linux-user: Save and restore fpu and dsp from sigcontext

2013-02-11 Thread Richard Henderson
On 2013-02-11 09:55, Peter Maydell wrote: Whereas allowing the guest to write garbage into our CPU state struct means we have to be sure that there's nothing in target-mips/ which ever assumes "dsp state fields are zero in a non-dsp config because nothing will have written to them" or similar.

Re: [Qemu-devel] [PATCH for-1.4] qapi: Improve chardev-add documentation

2013-02-11 Thread Eric Blake
On 02/11/2013 10:16 AM, Markus Armbruster wrote: > Apropos chardev-add schema. I know I gave up whatever bikeshedding > privileges I might have by not reviewing the series before it went in, > but here goes anyway: I don't like the name ChardevPort. 'Port' tells > me nothing. It's really host ch

Re: [Qemu-devel] [PATCH 05/10] mips-linux-user: Fix n32 and n64 syscalls

2013-02-11 Thread Peter Maydell
On 11 February 2013 17:51, Richard Henderson wrote: > On 2013-02-11 09:33, Peter Maydell wrote: >> You're only changing the cast here, so this isn't something you >> should feel the need to fix in this patch, but do you know what's >> special about -1133 ? > > It does correspond to the kernel code

Re: [Qemu-devel] [PATCH V21 2/7] Add TPM (frontend) hardware interface (TPM TIS) to QEMU

2013-02-11 Thread Corey Bryant
On 02/08/2013 04:42 PM, Stefan Berger wrote: This patch adds the main code of the TPM frontend driver, the TPM TIS interface, to QEMU. The code is largely based on the previous implementation for Xen but has been significantly extended to meet the standard's requirements, such as the support fo

[Qemu-devel] [PATCH qom-cpu-next 0/9 v6] target-i386: convert CPU features into properties

2013-02-11 Thread Igor Mammedov
It's a simplified rewrite of previous series, since then cleanups from it were applied to master and I left out kvm_check_features_against_host() and listflags() patches as not directly related to make series simpler. They could follow as separate cleanups later. Also setting defaults with static p

Re: [Qemu-devel] [PATCH 09/10] mipsn32-linux-user: Restrict address space to 31-bits.

2013-02-11 Thread Richard Henderson
On 2013-02-11 09:44, Peter Maydell wrote: >-# ifdef TARGET_MIPS >+# if HOST_LONG_BITS == 64 \ >+ && (defined(TARGET_ABI_MIPSO32) || defined(TARGET_ABI_MIPSN32)) > /* MIPS only supports 31 bits of virtual address space for user space */ >-unsigned long reserved_va = 0x7700; >-# else >+uns

Re: [Qemu-devel] [PATCH 04/10] mips-linux-user: Save and restore fpu and dsp from sigcontext

2013-02-11 Thread Peter Maydell
On 11 February 2013 17:43, Richard Henderson wrote: >> On 2013-02-11 09:28, Peter Maydell wrote: >>> -/* flush_cache_sigtramp((unsigned long) tramp); */ >> >> >> So, what does cause any stale TB we might have happened to >> have lying around for this address to be flushed from the >> TB cache?

[Qemu-devel] [PATCH 7/9] target-i386: cleanup 'foo' feature handling'

2013-02-11 Thread Igor Mammedov
features check, enforce, hv_relaxed and hv_vapic are treated as boolean set to 'on' when passed from command line, so it's not neccessary to handle each of them separetly. Collapse them to one catch-all branch which will treat any feature in format 'foo' as boolean set to 'on'. PS: Any unknown fe

[Qemu-devel] [PATCH 2/9] target-i386: add stubs for hyperv_(vapic_recommended|relaxed_timing_enabled|get_spinlock_retries)()

2013-02-11 Thread Igor Mammedov
It's needed for converting hv_* features into properties and to avoid build breakage when qemu is built with --disable-kvm option. Signed-off-by: Igor Mammedov Reported-by: Eduardo Habkost --- target-i386/hyperv.h |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/

[Qemu-devel] [PATCH 4/6] qemu-log: Rename the public-facing cpu_set_log function to qemu_set_log

2013-02-11 Thread Peter Maydell
Rename the public-facing function cpu_set_log to qemu_set_log. This requires us to rename the internal-only qemu_set_log() to do_qemu_set_log(). Signed-off-by: Peter Maydell --- bsd-user/main.c |2 +- cpus.c |2 +- hw/ppc.c|2 +- include/qemu/

Re: [Qemu-devel] [PATCH 09/10] mipsn32-linux-user: Restrict address space to 31-bits.

2013-02-11 Thread Peter Maydell
On 10 February 2013 18:30, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > linux-user/main.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/linux-user/main.c b/linux-user/main.c > index 8c4dffd..25491ca 100644 > --- a/linux-user/main.c >

Re: [Qemu-devel] [PATCH V21 1/7] Support for TPM command line options

2013-02-11 Thread Stefan Berger
On 02/11/2013 12:19 PM, Corey Bryant wrote: On 02/08/2013 04:42 PM, Stefan Berger wrote: + * Implementation of the TIS interface according to specs found at + *http://www.trustedcomputiggroup.org Were you going to make a comment somewhere that this front end is based on the v1.21 rev 1.0 TI

Re: [Qemu-devel] [PATCH V21 1/7] Support for TPM command line options

2013-02-11 Thread Corey Bryant
On 02/11/2013 12:28 PM, Stefan Berger wrote: On 02/11/2013 12:19 PM, Corey Bryant wrote: On 02/08/2013 04:42 PM, Stefan Berger wrote: + * Implementation of the TIS interface according to specs found at + *http://www.trustedcomputiggroup.org Were you going to make a comment somewhere that

[Qemu-devel] [PATCH 4/9] target-i386: convert 'hv_relaxed' to static property

2013-02-11 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 35 ++- 1 files changed, 34 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 1f14b65..b804031 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -528,6 +528,38 @@ P

Re: [Qemu-devel] [PATCH 04/10] mips-linux-user: Save and restore fpu and dsp from sigcontext

2013-02-11 Thread Richard Henderson
On 2013-02-11 09:28, Peter Maydell wrote: Since this code is writing to a region of memory which it has obtained via lock_user_struct(), __put_user() is guaranteed not to fail. So you might as well not worry about its return code. MIPS setup_rt_frame() is already written in this style, for instan

Re: [Qemu-devel] [PATCH 07/10] mips64-linux-user: Use MIPS64R2-generic as default cpu.

2013-02-11 Thread Peter Maydell
On 10 February 2013 18:30, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > linux-user/main.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > I don't actually recall why this patch was in my old tree. It might > just have been that I wanted a mips64r2 part for

[Qemu-devel] [PATCH 5/9] target-i386: convert 'hv_vapic' to static property

2013-02-11 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- target-i386/cpu.c | 35 ++- 1 files changed, 34 insertions(+), 1 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index b804031..0233985 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -560,6 +560,38 @@ P

  1   2   3   >