Signed-off-by: Orit Wasserman
Reviewed-by: Paolo Bonzini
---
Makefile.objs | 2 +-
savevm.c | 159 -
xbzrle.c | 173 ++
3 files changed, 174 insertions(+), 160 deletions(-)
cr
Signed-off-by: Orit Wasserman
Reviewed-by: Paolo Bonzini
---
tests/Makefile | 3 +
tests/test-xbzrle.c | 196
2 files changed, 199 insertions(+)
create mode 100644 tests/test-xbzrle.c
diff --git a/tests/Makefile b/tests/Makefile
index
Il 30/01/2013 21:02, Michael S. Tsirkin ha scritto:
> On Wed, Jan 30, 2013 at 05:41:22PM +0100, Paolo Bonzini wrote:
>> Ok, so here is my attempt at a vhost-scsi device. I'm creating an
>> entirely separate device, with the common parts of virtio-scsi and
>> vhost-scsi (actually little more than t
On 01/31/2013 08:57 AM, Peter Lieven wrote:
> Hi,
>
> I just came across an idea and would like to have feedback if it makes sence
> or not.
>
> If a VM is started without preallocated memory all memory that has not been
> written to
> reads as zeros, right?
Hi,
No the memory will be unmapped (
Signed-off-by: Orit Wasserman
Reviewed-by: Paolo Bonzini
Reviewed-by: Eric Blake
---
qmp-commands.hx | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/qmp-commands.hx b/qmp-commands.hx
index f90efe5..bbb21f3 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -2601,10
On 01/31/2013 02:29 AM, Eric Blake wrote:
> On 01/30/2013 04:12 AM, Jason Wang wrote:
>
>> With this changes, user could start a multiqueue virtio-net device through
>>
>> ./qemu -netdev tap,id=hn0,queues=2,vhost=on -device virtio-net-pci,netdev=hn0
>>
>> Management tools such as libvirt can pass m
Signed-off-by: Orit Wasserman
Reviewed-by: Paolo Bonzini
Reviewed-by: Eric Blake
---
hmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hmp.c b/hmp.c
index 249b89b..1689e6f 100644
--- a/hmp.c
+++ b/hmp.c
@@ -892,7 +892,7 @@ void hmp_migrate_set_capability(Monitor *mon, co
Before this fix we couldn't load a guest from
XBZRLE compressed file.
For example:
The user activated the XBZRLE capability
The user run migrate -d "exec:gzip -c > vm.gz"
The user won't be able to load vm.gz and get an error.
Signed-off-by: Orit Wasserman
Reviewed-by: Paolo Bonzini
Reviewed-by:
Changes for V3:
Fix year in xbzrle.c copyright notice
Add copyright notice to test-xbzrle.c, use stack variable
for 2 byte array and fix spacing.
This series add some testing to the XBZRLE compression
and fixes the error in loading a guest from a compressed file with
XBZRLE by allowing encoding of
Hi,
I just came across an idea and would like to have feedback if it makes sence or
not.
If a VM is started without preallocated memory all memory that has not been
written to
reads as zeros, right?
If a VM with a lot of unwritten memory is migrated or if the memory contains a
lot
of zeroed o
Am 30.01.2013 23:00, schrieb Richard Henderson:
> On 01/30/2013 01:56 PM, Stefan Weil wrote:
>> Could you please try whether this patch fixes the build problems:
>>
>>
>> From 4dd39af7a3e493669977ec6f50e91bf649b5727f Mon Sep 17 00:00:00 2001
>> From: Stefan Weil
>> Date: Wed, 30 Jan 2013 22:52:12
> -Original Message-
> From: Pasi Kärkkäinen [mailto:pa...@iki.fi]
> Sent: Thursday, January 24, 2013 9:45 PM
> To: Ian Jackson
> Cc: xen-de...@lists.xensource.com; Ian Campbell; Stefano Stabellini;
> qemu-devel@nongnu.org; Xu, Dongxiao
> Subject: Re: [Xen-devel] [PATCH 0/2] QEMU/xen: simpl
Prepares for changing cpu_interrupt() argument to CPUState.
Signed-off-by: Andreas Färber
---
Extracted from my qom-cpu-8 queue - could accompany my debug output fixes. :)
hw/ppc.c | 12 ++--
hw/ppc.h |6 +++---
hw/ppc405_uc.c | 16 ++--
3 Dateien geände
On Thu, 2013-01-31 at 10:02 +1100, Benjamin Herrenschmidt wrote:
> On Thu, 2013-01-31 at 00:49 +0200, Michael S. Tsirkin wrote:
> > > In practice they do (VGA at least)
> > >
> > > >From a SW modelling standpoint, I don't think it's worth
> > differentiating
> > > PCI and PCIE.
> > >
> > > Cheers
On Thu, 2013-01-31 at 00:49 +0200, Michael S. Tsirkin wrote:
> > In practice they do (VGA at least)
> >
> > >From a SW modelling standpoint, I don't think it's worth
> differentiating
> > PCI and PCIE.
> >
> > Cheers,
> > Ben.
>
> Interesting.
> Do you have such hardware? Could you please dump
>
On Thu, Jan 31, 2013 at 09:32:05AM +1100, Benjamin Herrenschmidt wrote:
> On Thu, 2013-01-31 at 00:20 +0200, Michael S. Tsirkin wrote:
> >
> > Well you can have a PCI bridge and a legacy device behind that.
> > I think real PCI express devices can not be mapped onto legacy address
> > ranges.
>
>
This prepares for moving the halted field to CPUState.
Most call sites can already supply S390CPU, for some env becomes unused.
Signed-off-by: Andreas Färber
---
hw/s390x/ipl.c |6 --
hw/s390x/s390-virtio.c |8 ++--
target-s390x/cpu.c |2 +-
target-s390x/cpu.h
Despite cautioning that S390CPU is needed for upcoming CPUState
refactorings, commit 5d69c547d947798cba92d836d06f6e017ba2b19d (s390:
I/O interrupt and machine check injection.) added functions
cpu_inject_io() and cpu_inject_crw_mchk() with CPUS390XState argument,
claiming consistency with cpu_injec
Hi Alex,
Here's a cleanup of all of cpu_inject_*(), as requested by Cornelia, plus
another API preparation for my CPUState part 8 series, to go along with my
debug output bug fixes.
As a reminder here's a link to one of my original discussions of the new types:
https://lists.nongnu.org/archive/ht
On Thu, 2013-01-31 at 00:20 +0200, Michael S. Tsirkin wrote:
>
> Well you can have a PCI bridge and a legacy device behind that.
> I think real PCI express devices can not be mapped onto legacy address
> ranges.
In practice they do (VGA at least)
>From a SW modelling standpoint, I don't think it
On Wed, Jan 30, 2013 at 03:39:34PM -0600, Anthony Liguori wrote:
> Benjamin Herrenschmidt writes:
>
> > On Wed, 2013-01-30 at 07:59 -0600, Anthony Liguori wrote:
> >> An x86 CPU has a MMIO capability that's essentially 65 bits. Whether
> >> the top bit is set determines whether it's a "PIO" tran
Am 30.01.2013 23:03, schrieb Andreas Färber:
> Am 30.01.2013 22:59, schrieb Richard Henderson:
>> On 01/30/2013 01:04 PM, Stefan Weil wrote:
static inline unsigned long leul_to_cpu(unsigned long v)
{
-return le_bswap(v, HOST_LONG_BITS);
+/* In order to break an inclu
Am 30.01.2013 22:59, schrieb Richard Henderson:
> On 01/30/2013 01:04 PM, Stefan Weil wrote:
>>> static inline unsigned long leul_to_cpu(unsigned long v)
>>> {
>>> -return le_bswap(v, HOST_LONG_BITS);
>>> +/* In order to break an include loop between here and
>>> + qemu-common.h,
On 01/30/2013 01:56 PM, Stefan Weil wrote:
Could you please try whether this patch fixes the build problems:
From 4dd39af7a3e493669977ec6f50e91bf649b5727f Mon Sep 17 00:00:00 2001
From: Stefan Weil
Date: Wed, 30 Jan 2013 22:52:12 +0100
Subject: [PATCH] Fix build problems for big endian hosts
On 01/30/2013 01:04 PM, Stefan Weil wrote:
static inline unsigned long leul_to_cpu(unsigned long v)
{
-return le_bswap(v, HOST_LONG_BITS);
+/* In order to break an include loop between here and
+ qemu-common.h, don't rely on HOST_LONG_BITS. */
+#if ULONG_MAX == UINT32_MAX
+
On 30 January 2013 21:51, Eric Blake wrote:
> On 01/30/2013 01:41 PM, Peter Maydell wrote:
>> This reimplementation appears to have an off by one error.
>> For example, on an input of 4, the old algorithm returns 2
>> and this one returns 3.
>
> Ouch - you are right that the old implementation is
Am 30.01.2013 22:04, schrieb Stefan Weil:
Am 30.01.2013 21:55, schrieb Richard Henderson:
This is not always defined in all places qemu/bswap.h is used.
If we include qemu-common.h to get it, we create an include loop.
This resolves a build problem on any big-endian host like ppc64.
Signed-off-
On Wed, 2013-01-30 at 15:39 -0600, Anthony Liguori wrote:
> Benjamin Herrenschmidt writes:
> > There also exists P2P bridges doing such substractive
> > decoding, this used to be fairly common with transparent bridges used for
> > laptop docking.
>
> I'm not sure I understand how this would work
On 01/30/2013 01:41 PM, Peter Maydell wrote:
>> -#if LONG_MAX > 0x7FFF
>> - if ((word & 0x) == 0) {
>> - num += 32;
>> - word >>= 32;
>> - }
>> - if ((word & 0x) == 0) {
>> - num += 16;
>> - word >>= 16;
>>
Benjamin Herrenschmidt writes:
> On Wed, 2013-01-30 at 17:54 +0100, Andreas Färber wrote:
>>
>> That would require polymorphism since we already need to derive from
>> PCIDevice or ISADevice respectively for interfacing with the bus...
>> Modern object-oriented languages have tried to avoid mult
Benjamin Herrenschmidt writes:
> On Wed, 2013-01-30 at 07:59 -0600, Anthony Liguori wrote:
>> An x86 CPU has a MMIO capability that's essentially 65 bits. Whether
>> the top bit is set determines whether it's a "PIO" transaction or an
>> "MMIO" transaction. A large chunk of that address space i
On Wed, 2013-01-30 at 18:08 +0100, Paolo Bonzini wrote:
> > Make VGACommonState a proper QOM object and use it as the base class
> for
> > QXL, CirrusVGA, QEMUVGA (std-vga), and VMwareVGA.
>
> I think QXL should have-a VGA rather than being one. It completely
> bypasses the VGA infrastructure if
On Wed, 2013-01-30 at 17:54 +0100, Andreas Färber wrote:
>
> That would require polymorphism since we already need to derive from
> PCIDevice or ISADevice respectively for interfacing with the bus...
> Modern object-oriented languages have tried to avoid multi-inheritence
> due to arising complica
On Wed, 2013-01-30 at 07:59 -0600, Anthony Liguori wrote:
> An x86 CPU has a MMIO capability that's essentially 65 bits. Whether
> the top bit is set determines whether it's a "PIO" transaction or an
> "MMIO" transaction. A large chunk of that address space is invalid of
> course.
>
> PCI has a
Am 30.01.2013 21:55, schrieb Richard Henderson:
This is not always defined in all places qemu/bswap.h is used.
If we include qemu-common.h to get it, we create an include loop.
This resolves a build problem on any big-endian host like ppc64.
Signed-off-by: Richard Henderson
---
include/qemu/bs
This is not always defined in all places qemu/bswap.h is used.
If we include qemu-common.h to get it, we create an include loop.
This resolves a build problem on any big-endian host like ppc64.
Signed-off-by: Richard Henderson
---
include/qemu/bswap.h | 12 ++--
1 file changed, 10 insert
On Wed, Jan 30, 2013 at 09:33:05PM +0100, Andreas Färber wrote:
> Am 30.01.2013 21:20, schrieb Michael S. Tsirkin:
> > On Wed, Jan 30, 2013 at 06:55:47PM +0100, Andreas Färber wrote:
> >> Am 30.01.2013 12:48, schrieb Peter Maydell:
> >>> On 30 January 2013 11:39, Andreas Färber wrote:
> Propo
On 30 January 2013 16:53, Paolo Bonzini wrote:
> +if (!word) {
> +return 0;
> +}
If we're specifically defining the behaviour for zero input we
need to fix the API documentation comment which currently says
this case is undefined and the caller should be checking.
> -#if LONG_MAX
Am 30.01.2013 21:20, schrieb Michael S. Tsirkin:
> On Wed, Jan 30, 2013 at 06:55:47PM +0100, Andreas Färber wrote:
>> Am 30.01.2013 12:48, schrieb Peter Maydell:
>>> On 30 January 2013 11:39, Andreas Färber wrote:
Proposal by hpoussin was to move _list_add() code to ISADevice:
http://lis
Am 30.01.2013 18:29, schrieb Anthony Liguori:
> Andreas Färber writes:
>
>> Am 30.01.2013 17:33, schrieb Anthony Liguori:
>>> Gerd Hoffmann writes:
>>>
> hw/qxl.c:portio_list_add(qxl_vga_port_list,
> pci_address_space_io(dev), 0x3b0);
> hw/vga.c:portio_list_add(vga_port_l
On 30 January 2013 20:08, Michael S. Tsirkin wrote:
> Anthony wrote:
>> Nope. You can use composition:
>>
>> QXLDevice is-a VGACommonState
>>
>> QXLPCI is-a PCIDevice
>>has-a QXLDevice
>
> But why like this?
> The distinction is artificial, isn't it?
I think it's the wrong way round. QXL
On Wed, Jan 30, 2013 at 06:55:47PM +0100, Andreas Färber wrote:
> Am 30.01.2013 12:48, schrieb Peter Maydell:
> > On 30 January 2013 11:39, Andreas Färber wrote:
> >> Proposal by hpoussin was to move _list_add() code to ISADevice:
> >> http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg00508.
On Wed, Jan 30, 2013 at 11:29:58AM -0600, Anthony Liguori wrote:
> Andreas Färber writes:
>
> > Am 30.01.2013 17:33, schrieb Anthony Liguori:
> >> Gerd Hoffmann writes:
> >>
> hw/qxl.c:portio_list_add(qxl_vga_port_list,
> pci_address_space_io(dev), 0x3b0);
> hw/vga.c:
On Wed, Jan 30, 2013 at 05:41:22PM +0100, Paolo Bonzini wrote:
> Ok, so here is my attempt at a vhost-scsi device. I'm creating an
> entirely separate device, with the common parts of virtio-scsi and
> vhost-scsi (actually little more than the initialization) grouped into
> a VirtIOSCSICommon type
Hi,
> hw/qxl.c:portio_list_add(qxl_vga_port_list,
> pci_address_space_io(dev), 0x3b0);
> hw/vga.c:portio_list_add(vga_port_list, address_space_io, 0x3b0);
That reminds me I should solve this in a more elegant way.
qxl takes over the vga io ports. The reason it does this is because
Disable multiqueue support for pre 1.4.
Signed-off-by: Jason Wang
---
hw/pc_piix.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/hw/pc_piix.c b/hw/pc_piix.c
index b9a9b2e..84069b1 100644
--- a/hw/pc_piix.c
+++ b/hw/pc_piix.c
@@ -309,6 +309,10 @@ static QEMUMachine p
To support multiqueue virtio-net, the first step is to separate the virtqueue
related fields from VirtIONet to a new structure VirtIONetQueue. The following
patches will add an array of VirtIONetQueue to VirtIONet based on this patch.
Signed-off-by: Jason Wang
---
hw/virtio-net.c | 195
This patch lets vhost support multiqueue. The idea is simple, just launching
multiple threads of vhost and let each of vhost thread processing a subset of
the virtqueues of the device. After this change each emulated device can have
multiple vhost threads as its backend.
To do this, a virtqueue in
Am 17.01.2013 21:45, schrieb Blue Swirl:
On Wed, Jan 16, 2013 at 6:04 PM, Stefan Weil wrote:
MinGW has no strtok_r, so we need a declaration in sysemu/os-win32.h.
We must also fix the include statements in util/envlist.c to include
that file.
We currently don't need an implementation of st
On 30 January 2013 16:53, Paolo Bonzini wrote:
> Fixes the build on Mac OS X, which has ffsl.
>
> Signed-off-by: Paolo Bonzini
Confirmed that this fixes the MacOSX build (though there seems
to be some other problem causing us to hang on startup which I need
to track down).
NB: the comment in ho
On 01/30/2013 08:17 PM, Eric Blake wrote:
> On 01/30/2013 04:41 AM, Orit Wasserman wrote:
>> Signed-off-by: Orit Wasserman
>> ---
>> Makefile.objs | 2 +-
>> savevm.c | 159 -
>> xbzrle.c | 173
>> +++
On 01/30/2013 07:59 PM, Eric Blake wrote:
> On 01/30/2013 03:35 AM, Orit Wasserman wrote:
>> XBZRLE is not effective when migrating to file.
>
> Why not? When doing a live migration to file, the same sector of memory
> can be visited more than once in the migration stream, and thus
> compressing
QEMU monitor command 'info registers' only displays information for the first
CPU. This fix that by show registers information for each CPU in the system
Signed-off-by: erlon.c...@fit-tecnologia.org.br
---
monitor.c | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
dif
On 01/30/2013 04:41 AM, Orit Wasserman wrote:
> Signed-off-by: Orit Wasserman
> ---
> hmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
D
On 01/30/2013 04:41 AM, Orit Wasserman wrote:
> Before this fix we couldn't load a guest from
> XBZRLE compressed file.
s/encoding/decoding/ in the subject line.
>
> For example:
> The user activated the XBZRLE capability
> The user run migrate -d "exec:gzip -c > vm.gz"
> The user won't be able
On 01/30/2013 04:41 AM, Orit Wasserman wrote:
> Signed-off-by: Orit Wasserman
> ---
> qmp-commands.hx | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
On 01/30/2013 04:41 AM, Orit Wasserman wrote:
> Signed-off-by: Orit Wasserman
> ---
> tests/Makefile | 3 +
> tests/test-xbzrle.c | 186
>
> 2 files changed, 189 insertions(+)
> create mode 100644 tests/test-xbzrle.c
> +++ b/tests/tes
On 01/30/2013 04:41 AM, Orit Wasserman wrote:
> Signed-off-by: Orit Wasserman
> ---
> Makefile.objs | 2 +-
> savevm.c | 159 -
> xbzrle.c | 173
> ++
> 3 files changed, 174 in
Public bug reported:
Somewhere between qemu 1.1.2 and 1.2.0 OpenBSD zaurus kernels and
ramdisk images stopped booting properly and instead end up in the kernel
debugger. This behaviour is still present in the latest git and appears
to have been introduced in:
commit e2f8a44d0d425a22cca5855702f53
Am 30.01.2013 18:57, schrieb Paolo Bonzini:
> Fixes the build on Mac OS X, which has ffsl.
>
> Signed-off-by: Paolo Bonzini
> ---
> include/qemu/bitops.h | 40 ++--
> include/qemu/hbitmap.h| 2 +-
> include/qemu/host-utils.h | 25 --
On 01/30/2013 10:57 AM, Paolo Bonzini wrote:
> Fixes the build on Mac OS X, which has ffsl.
>
> Signed-off-by: Paolo Bonzini
> ---
> include/qemu/bitops.h | 40 ++--
> include/qemu/hbitmap.h| 2 +-
> include/qemu/host-utils.h | 25
Il 30/01/2013 18:57, Paolo Bonzini ha scritto:
> @@ -30,34 +31,21 @@
> */
> static unsigned long bitops_ffsl(unsigned long word)
> {
> - int num = 0;
> +#if QEMU_GNUC_PREREQ(3, 4)
> +return __builtin_ffsl(word) + 1;
Obviously wrong, sent before "git commit --amend".
But it also remind
On 01/30/2013 03:35 AM, Orit Wasserman wrote:
> XBZRLE is not effective when migrating to file.
Why not? When doing a live migration to file, the same sector of memory
can be visited more than once in the migration stream, and thus
compressing the later pages should make the saved file smaller.
Fixes the build on Mac OS X, which has ffsl.
Signed-off-by: Paolo Bonzini
---
include/qemu/bitops.h | 40 ++--
include/qemu/hbitmap.h| 2 +-
include/qemu/host-utils.h | 25 -
util/hbitmap.c| 2 +-
4 files changed,
Am 30.01.2013 12:48, schrieb Peter Maydell:
> On 30 January 2013 11:39, Andreas Färber wrote:
>> Proposal by hpoussin was to move _list_add() code to ISADevice:
>> http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg00508.html
>>
>> Concerns:
>> * PCI devices (VGA, QXL) register I/O ports as w
Am 30.01.2013 18:46, schrieb Paolo Bonzini:
>
> - Messaggio originale -
>> Da: "Stefan Weil"
>> A: "Paolo Bonzini"
>> Cc: qemu-devel@nongnu.org, blauwir...@gmail.com, "peter maydell"
>>
>> Inviato: Mercoledì, 30 gennaio 2013 18:36:52
>> Oggetto: Re: [Qemu-devel] [PATCH] bitops: unify bi
On 01/30/2013 09:46 AM, Paolo Bonzini wrote:
>Nevertheless I wonder why you don't use gcc's __builtin_ffsl.
Because I had no idea it existed until now. :)
Do you know what version of GCC introduced it?
gcc 3.4.
2003-02-01 Falk Hueffner
* optabs.h (optab_index): Add OTI_clz, OTI_c
- Messaggio originale -
> Da: "Stefan Weil"
> A: "Paolo Bonzini"
> Cc: qemu-devel@nongnu.org, blauwir...@gmail.com, "peter maydell"
>
> Inviato: Mercoledì, 30 gennaio 2013 18:36:52
> Oggetto: Re: [Qemu-devel] [PATCH] bitops: unify bitops_ffsl with the one in
> host-utils.h
>
> Am 30
Needed for vhost-scsi, see previous commit.
Signed-off-by: Paolo Bonzini
---
hw/vhost.c | 9 +
hw/virtio.h | 2 ++
2 files changed, 11 insertions(+)
diff --git a/hw/vhost.c b/hw/vhost.c
index edb6b08..09fa4e1 100644
--- a/hw/vhost.c
+++ b/hw/vhost.c
@@ -985,6 +985,12 @@ int vhost_dev_s
On 01/30/2013 09:53 AM, Paolo Bonzini wrote:
> Fixes the build on Mac OS X, which has ffsl.
>
> Signed-off-by: Paolo Bonzini
> ---
> include/qemu/bitops.h | 40 ++--
> include/qemu/hbitmap.h| 2 +-
> include/qemu/host-utils.h | 25
Am 30.01.2013 17:53, schrieb Paolo Bonzini:
> Fixes the build on Mac OS X, which has ffsl.
>
> Signed-off-by: Paolo Bonzini
> ---
> include/qemu/bitops.h | 40 ++--
> include/qemu/hbitmap.h| 2 +-
> include/qemu/host-utils.h | 25 --
Andreas Färber writes:
> Am 30.01.2013 17:33, schrieb Anthony Liguori:
>> Gerd Hoffmann writes:
>>
hw/qxl.c:portio_list_add(qxl_vga_port_list,
pci_address_space_io(dev), 0x3b0);
hw/vga.c:portio_list_add(vga_port_list, address_space_io, 0x3b0);
>>>
>>> That reminds me
Am 30.01.2013 17:58, schrieb Paolo Bonzini:
> Il 30/01/2013 14:44, Andreas Färber ha scritto:
>> I disagree on the "or else" part. I have been qdev'ifying and QOM'ifying
>> devices in my maintenance area, and progress is slow. It gets even
>> slower if one leaves clearly maintained areas. I see no
Il 30/01/2013 17:33, Anthony Liguori ha scritto:
> Gerd Hoffmann writes:
>
>> Hi,
>>
>>> hw/qxl.c:portio_list_add(qxl_vga_port_list,
>>> pci_address_space_io(dev), 0x3b0);
>>> hw/vga.c:portio_list_add(vga_port_list, address_space_io, 0x3b0);
>>
>> That reminds me I should solve this
Il 30/01/2013 14:44, Andreas Färber ha scritto:
> I disagree on the "or else" part. I have been qdev'ifying and QOM'ifying
> devices in my maintenance area, and progress is slow. It gets even
> slower if one leaves clearly maintained areas. I see no good reason to
> force a pistol on someone's brea
Am 30.01.2013 17:33, schrieb Anthony Liguori:
> Gerd Hoffmann writes:
>
>>> hw/qxl.c:portio_list_add(qxl_vga_port_list,
>>> pci_address_space_io(dev), 0x3b0);
>>> hw/vga.c:portio_list_add(vga_port_list, address_space_io, 0x3b0);
>>
>> That reminds me I should solve this in a more eleg
Fixes the build on Mac OS X, which has ffsl.
Signed-off-by: Paolo Bonzini
---
include/qemu/bitops.h | 40 ++--
include/qemu/hbitmap.h| 2 +-
include/qemu/host-utils.h | 25 -
util/hbitmap.c| 2 +-
4 files changed,
Fix a leak of a TCG temporary in code paths for VFP system register
writes for cases which UNDEF or are write-ignored.
Signed-off-by: Peter Maydell
---
target-arm/translate.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/target-arm/translate.c b/target-arm/translate.
Last few target-arm patches to go in before hardfreeze. Please
pull.
-- PMM
The following changes since commit 0893d46014b0300fb8aec92df94effea34d04b61:
Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2013-01-29
16:57:41 -0600)
are available in the git repository at:
git:
Signed-off-by: Paolo Bonzini
---
hw/virtio-scsi.c | 199 +--
hw/virtio-scsi.h | 127
include/qemu/osdep.h | 4 ++
3 files changed, 180 insertions(+), 150 deletions(-)
diff --git a/hw/virtio-scsi.c b/hw/vir
From: Stefan Hajnoczi
The WWPN specified in configfs is passed to "-device vhost-scsi-pci".
The tgpt field of the SET_ENDPOINT ioctl is going to be obsolete soon,
so it is not available from the QEMU command-line. Instead, I hardcode
it to zero.
Signed-off-by: Stefan Hajnoczi
Signed-off-by: Ni
tcm_vhost requires setting the backend endpoint before starting
the virtqueue, and setting up the vring before setting the backend
endpoint. Otherwise, you have a race and its handle_kick function
can run before the endpoint is set, and this breaks vhost-scsi.
To fix this, first of all move the V
Ok, so here is my attempt at a vhost-scsi device. I'm creating an
entirely separate device, with the common parts of virtio-scsi and
vhost-scsi (actually little more than the initialization) grouped into
a VirtIOSCSICommon type. The device is used simply like "-device
vhost-scsi-pci,wwpn=WWPN", w
Am 19.01.2013 17:01, schrieb Blue Swirl:
> Perform input tests on random data.
>
> Improvement to code coverage for qapi/string-input-visitor.c
> is about 3 percentage points.
>
> Signed-off-by: Blue Swirl
Does this test pass for you? It consistently segfaults for me.
/string-visitor/input/fuz
Gerd Hoffmann writes:
> Hi,
>
>> hw/qxl.c:portio_list_add(qxl_vga_port_list,
>> pci_address_space_io(dev), 0x3b0);
>> hw/vga.c:portio_list_add(vga_port_list, address_space_io, 0x3b0);
>
> That reminds me I should solve this in a more elegant way.
>
> qxl takes over the vga io ports.
The vexpress-a15 QEMU model is supposed to be a V2P-CA15; the HBI
(a kind of board model number) for this coretile is 237, not 217.
Signed-off-by: Peter Maydell
---
hw/vexpress.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/vexpress.c b/hw/vexpress.c
index 7f0897c..7
From: Christoffer Dall
The start bit should only be set to indicate that a function call is
underway, right now. When done with function, clear it.
Signed-off-by: Christoffer Dall
Signed-off-by: Peter Maydell
---
hw/arm_sysctl.c |1 +
1 file changed, 1 insertion(+)
diff --git a/hw/arm_s
Two minor patches to go in before hardfreeze; please pull.
thanks
-- PMM
The following changes since commit 0893d46014b0300fb8aec92df94effea34d04b61:
Merge remote-tracking branch 'qemu-kvm/uq/master' into staging (2013-01-29
16:57:41 -0600)
are available in the git repository at:
git://g
On 28 January 2013 13:51, Peter Maydell wrote:
> Blue -- I forgot to put this patch in a target-arm pullreq,
> and it's my only outstanding target-arm patch for 1.4.
> Do you want to just apply it directly or would you prefer
> me to put together a single-patch pullreq?
I got another target-arm p
On 29 January 2013 12:00, Andreas Färber wrote:
> Am 29.01.2013 12:03, schrieb Peter Maydell:
>> I assume you're going to submit this via the qom subtree.
>
> It applies to master now and is an arm-internal leaf patch. Since you
> have another target-arm.next patch that Blue didn't pick up so far,
From: Andreas Färber
In the initial conversion of CPU models to QOM types, model names were
mapped 1:1 to type names. As a side effect this gained us a type "any",
which is now a device.
To avoid "-device any" silliness and to pave the way for compiling
multiple targets into one executable, adop
From: Andreas Färber
In the initial conversion of CPU models to QOM types, model names were
mapped 1:1 to type names. As a side effect this gained us a type "any",
which is now a device.
To avoid "-device any" silliness and to pave the way for compiling
multiple targets into one executable, adop
Markus Armbruster writes:
> Peter Maydell writes:
>
>> On 30 January 2013 11:39, Andreas Färber wrote:
>>> Proposal by hpoussin was to move _list_add() code to ISADevice:
>>> http://lists.gnu.org/archive/html/qemu-devel/2013-01/msg00508.html
>>>
>>> Concerns:
>>> * PCI devices (VGA, QXL) regist
On Fri, Jan 25, 2013 at 8:08 AM, Andreas Färber wrote:
> We just need to be aware that inspecting register values is one thing,
> but that letting QMP qom-set arbitrary registers during runtime could
> cause unpredictable issues. Checks on dev->realized could be added as
> precaution (cf. qdev sta
On 30 January 2013 14:05, Peter Maydell wrote:
> On 16 January 2013 17:31, Paolo Bonzini wrote:
>> We can provide fast versions based on the other functions defined
>> by host-utils.h. Some care is required on glibc, which provides
>> ffsl already.
>>
>> Signed-off-by: Paolo Bonzini
>
> Hi. Thi
Amit Shah writes:
> Hi Anthony,
>
> I did some basic testing of the char flow control patches from your
> char-flow.2 branch. With the following patch applied, things seem to
> be working fine. I tested the isa-serial and virtio-serial devices.
>
> I haven't yet tested with virtio-serial flow c
Gerd Hoffmann writes:
> Hi,
>
>> Gerd: Are you willing to co-maintain the QEMU buildmaster with Daniel
>> and Christian? It would be awesome if you could do this given your
>> experience running and customizing buildbot.
>
> I'll try to set aside some time for that. Christians idea to host th
Markus Armbruster writes:
> Peter Maydell writes:
>
>> On 30 January 2013 07:02, Markus Armbruster wrote:
>>> Anthony Liguori writes:
>>>
>>> [...]
The problems I ran into were (1) this is a lot of work (2) it basically
requires that all bus children have been qdev/QOM-ified. Even w
On Wed, Jan 30, 2013 at 07:24:57AM -0600, Anthony Liguori wrote:
> "Michael S. Tsirkin" writes:
>
> > On Wed, Jan 30, 2013 at 11:48:14AM +, Peter Maydell wrote:
> >> On 30 January 2013 11:39, Andreas Färber wrote:
> >> > Proposal by hpoussin was to move _list_add() code to ISADevice:
> >> >
On 16 January 2013 17:31, Paolo Bonzini wrote:
> We can provide fast versions based on the other functions defined
> by host-utils.h. Some care is required on glibc, which provides
> ffsl already.
>
> Signed-off-by: Paolo Bonzini
Hi. This patch breaks compile on MacOS (and likely other BSDs):
1 - 100 of 224 matches
Mail list logo
