[Qemu-devel] [ANNOUNCE] SeaBIOS 1.7.2

2013-01-18 Thread Kevin O'Connor
The 1.7.2 version of SeaBIOS has now been released. For more information on the release, please see: http://seabios.org/Releases New in this release: * Support for ICH9 host chipset ("q35") on emulators * Support for booting from LSI MegaRAID SAS controllers * Support for using the ACPI PM tim

Re: [Qemu-devel] [QEMU PATCH v4 1/3] virtio-net: remove layout assumptions for ctrl vq

2013-01-18 Thread Amos Kong
On Sat, Jan 19, 2013 at 09:54:26AM +0800, ak...@redhat.com wrote: > From: "Michael S. Tsirkin" > > Virtio-net code makes assumption about virtqueue descriptor layout > (e.g. sg[0] is the header, sg[1] is the data buffer). > > This patch makes code not rely on the layout of descriptors. > > Sign

Re: [Qemu-devel] [Qemu-stable] Patch Round-up for stable 1.3.1, freeze Monday

2013-01-18 Thread Doug Goldstein
On Wed, Jan 16, 2013 at 10:49 AM, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v1.3.1: > > https://github.com/mdroth/qemu/commits/stable-1.3-staging > > The release is planned for 01-25-2013: > > http://wiki.qemu.org/Planning/1.3 > > Please CC qemu-st

[Qemu-devel] [QEMU PATCH v4 3/3] virtio-net: rename ctrl rx commands

2013-01-18 Thread akong
From: Amos Kong This patch makes rx commands consistent with specification. Signed-off-by: Amos Kong --- hw/virtio-net.c | 14 +++--- hw/virtio-net.h | 14 +++--- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index cf40ff2..5

[Qemu-devel] [QEMU PATCH v4 2/3] virtio-net: introduce a new macaddr control

2013-01-18 Thread akong
From: Amos Kong In virtio-net guest driver, currently we write MAC address to pci config space byte by byte, this means that we have an intermediate step where mac is wrong. This patch introduced a new control command to set MAC address, it's atomic. VIRTIO_NET_F_CTRL_MAC_ADDR is a new feature b

[Qemu-devel] [QEMU PATCH v4 1/3] virtio-net: remove layout assumptions for ctrl vq

2013-01-18 Thread akong
From: "Michael S. Tsirkin" Virtio-net code makes assumption about virtqueue descriptor layout (e.g. sg[0] is the header, sg[1] is the data buffer). This patch makes code not rely on the layout of descriptors. Signed-off-by: Michael S. Tsirkin Signed-off-by: Amos Kong --- hw/virtio-net.c | 12

[Qemu-devel] [QEMU PATCH v4 0/3] virtio-net: fix of ctrl commands

2013-01-18 Thread akong
From: Amos Kong Currently virtio-net code relys on the layout of descriptor, this patchset removed the assumptions and introduced a control command to set mac address. Last patch is a trivial renaming. V2: check guest's iov_len V3: fix of migration compatibility make mac field in config spac

Re: [Qemu-devel] qemu-kvm command-line compat

2013-01-18 Thread Doug Goldstein
On Thu, Jan 17, 2013 at 11:28 PM, Michael Tokarev wrote: > Hello. > > I was thinking about switching users from (old) qemu-kvm to (new) qemu, > and am trying to understand the difference and how to compensate for > them. > > So far we had several discussions about this topic, first of all > touchi

Re: [Qemu-devel] [PATCH V20 8/8] Add fd parameter for TPM passthrough driver

2013-01-18 Thread Stefan Berger
On 01/18/2013 07:14 PM, Stefan Berger wrote: On 01/18/2013 01:18 PM, Eric Blake wrote: On 01/18/2013 09:02 AM, Stefan Berger wrote: When libvirt forks, the child process inherits the file descriptors, among them those of the taps and /dev/tpm0. The subsequent execve keeps the file descriptor o

Re: [Qemu-devel] bypassing pci_dma_read() and pci_dma_write() ?

2013-01-18 Thread Luigi Rizzo
On Fri, Jan 18, 2013 at 05:14:02PM +0100, Paolo Bonzini wrote: > Il 18/01/2013 17:04, Luigi Rizzo ha scritto: > > Hi, > > with a bunch of e1000 improvements we are at a point where we are > > doing over 1Mpps (short frames) and 7-8Gbit/s (1500 byte frames) > > between two guests, and two things tha

Re: [Qemu-devel] [PATCH V20 8/8] Add fd parameter for TPM passthrough driver

2013-01-18 Thread Stefan Berger
On 01/18/2013 01:18 PM, Eric Blake wrote: On 01/18/2013 09:02 AM, Stefan Berger wrote: Enable the passing of a file descriptor via fd=<..> to access the host's TPM device using the TPM passthrough driver. Do we still need this, or is it sufficient to use path=/dev/fdset/nnn, so that we are reus

[Qemu-devel] [PATCH] usb: Fix compilation for MinGW (regression)

2013-01-18 Thread Stefan Weil
84f2d0ea added an argument to function usb_host_info. The stub function must match the declaration in usb.h. Signed-off-by: Stefan Weil --- hw/usb/host-stub.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/host-stub.c b/hw/usb/host-stub.c index 58423a0..8affba7 100

[Qemu-devel] buildbot failure in qemu on default_mingw32

2013-01-18 Thread qemu
The Buildbot has detected a new failure on builder default_mingw32 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/501 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 Build Reason:

Re: [Qemu-devel] [PATCH 1/3] balloon: drop old stats code & API

2013-01-18 Thread Eric Blake
On 01/18/2013 12:29 PM, Luiz Capitulino wrote: > Next commit will re-enable balloon stats with a different interface, but > this old code conflicts with it. Let's drop it. > > It's important to note that the QMP and HMP interfaces are also dropped > by this commit. That shouldn't be a problem thou

Re: [Qemu-devel] gen_icount_start

2013-01-18 Thread biswaranjan panda
> What I understand is that in gen_icount_start 'icount_arg' keeps a pointer > to gen_opparam_ptr which is used in gen_icount_end to patch up the value . I > however didnt understand what the 'horrid hack' is about. Can any one give > me some idea on this ? >My guess is that it's a hack because it

Re: [Qemu-devel] [PATCH 1/8 v6] cutils: unsigned int parsing functions

2013-01-18 Thread Eric Blake
On 01/18/2013 12:41 PM, Eduardo Habkost wrote: > There are lots of duplicate parsing code using strto*() in QEMU, and > most of that code is broken in one way or another. Even the visitors > code have duplicate integer parsing code[1]. This introduces functions > to help parsing unsigned int values

Re: [Qemu-devel] [PATCH 3/3] docs: document virtio-balloon stats

2013-01-18 Thread Eric Blake
On 01/18/2013 12:29 PM, Luiz Capitulino wrote: > Signed-off-by: Luiz Capitulino > --- > docs/virtio-balloon-stats.txt | 102 > ++ > 1 file changed, 102 insertions(+) > create mode 100644 docs/virtio-balloon-stats.txt > > + > + o A key named 'stats', co

Re: [Qemu-devel] [PATCH] define qemukvm-1.2 machine type

2013-01-18 Thread Marcelo Tosatti
On Fri, Jan 18, 2013 at 12:34:57PM -0500, Paolo Bonzini wrote: > > > version_id and minimum_version_id should be changed to 2, as the > > > comment indicates. > > > > But won't that mean we have to carry that patch forever, and while we carry > > that patch we can never migrate from Fedora qemu to

Re: [Qemu-devel] [PATCH 2/3] balloon: re-enable balloon stats

2013-01-18 Thread Eric Blake
On 01/18/2013 12:29 PM, Luiz Capitulino wrote: > The statistics are now available through device properties via a > polling mechanism. First a client has to enable polling, then it > can query available stats. > Reviewed-by: Eric Blake -- Eric Blake eblake redhat com+1-919-301-3266 Libvi

Re: [Qemu-devel] [PATCH] define qemukvm-1.2 machine type

2013-01-18 Thread Marcelo Tosatti
On Fri, Jan 18, 2013 at 11:04:04AM -0600, Cole Robinson wrote: > >> Thanks for the analysis Paolo, here's the final patch I used: > >> > >> http://pkgs.fedoraproject.org/cgit/qemu.git/tree/0004-Fix-migration-compat-with-qemu-kvm.patch > >> > >> Thanks, > >> Cole > > > > Cole, > > > > version_id a

[Qemu-devel] [PATCH 1/8 v6] cutils: unsigned int parsing functions

2013-01-18 Thread Eduardo Habkost
There are lots of duplicate parsing code using strto*() in QEMU, and most of that code is broken in one way or another. Even the visitors code have duplicate integer parsing code[1]. This introduces functions to help parsing unsigned int values: parse_uint() and parse_uint_full(). Parsing function

Re: [Qemu-devel] [PATCH v3] block: Monitor command commit neglects to report some errors

2013-01-18 Thread Luiz Capitulino
On Fri, 18 Jan 2013 12:45:35 -0500 Jeff Cody wrote: > The non-live bdrv_commit() function may return one of the following > errors: -ENOTSUP, -EBUSY, -EACCES, -EIO. The only error that is > checked in the HMP handler is -EBUSY, so the monitor command 'commit' > silently fails for all error cases

[Qemu-devel] [PATCH 2/3] balloon: re-enable balloon stats

2013-01-18 Thread Luiz Capitulino
The statistics are now available through device properties via a polling mechanism. First a client has to enable polling, then it can query available stats. Polling is enabled by setting an update interval (in seconds) to a property named guest-stats-polling-interval, like this: { "execute": "qom

[Qemu-devel] [PATCH 1/3] balloon: drop old stats code & API

2013-01-18 Thread Luiz Capitulino
Next commit will re-enable balloon stats with a different interface, but this old code conflicts with it. Let's drop it. It's important to note that the QMP and HMP interfaces are also dropped by this commit. That shouldn't be a problem though, because: 1. All QMP fields are optional 2. This fe

[Qemu-devel] [PATCH 3/3] docs: document virtio-balloon stats

2013-01-18 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- docs/virtio-balloon-stats.txt | 102 ++ 1 file changed, 102 insertions(+) create mode 100644 docs/virtio-balloon-stats.txt diff --git a/docs/virtio-balloon-stats.txt b/docs/virtio-balloon-stats.txt new file mode 100644 i

[Qemu-devel] [PATCH v3 0/3] re-enable balloon stats

2013-01-18 Thread Luiz Capitulino
This series re-enables the virtio-balloon device stats feature. It now uses QOM properties via a polling mechanism as suggested by Anthony here: http://lists.gnu.org/archive/html/qemu-devel/2012-02/msg02390.html o v3 - return all stats at once via the guest-stats property (ie. kill individu

Re: [Qemu-devel] [PATCH 8/8] s390: Add a hypercall registration interface.

2013-01-18 Thread Andreas Färber
Am 18.01.2013 19:12, schrieb Alexander Graf: > diff --git a/hw/s390-virtio.h b/hw/s390-virtio.h > new file mode 100644 > index 000..25bb610 > --- /dev/null > +++ b/hw/s390-virtio.h > @@ -0,0 +1,22 @@ > +/* > + * Virtio interfaces for s390 > + * > + * Copyright 2012 IBM Corp. > + * Author(s): Co

[Qemu-devel] [PATCH 2/9] openpic: unify gcr mode mask updates

2013-01-18 Thread Alexander Graf
The mode mask already masks out bits we don't care about, so the actual handling code can stay intact regardless. Signed-off-by: Alexander Graf --- hw/openpic.c | 25 + 1 files changed, 13 insertions(+), 12 deletions(-) diff --git a/hw/openpic.c b/hw/openpic.c index 08

[Qemu-devel] [PATCH 4/8] s390x: Remove inline function ebcdic_put and related data from cpu.h

2013-01-18 Thread Alexander Graf
From: Stefan Weil The function is only used in misc_helper.c, so move it to that file. This reduces the size of debug executables (compiled without optimization) because they get unused code and data for each compilation which includes cpu.h. Executables with optimization don't change their siz

[Qemu-devel] [PATCH qom-cpu for-1.4] cpu-defs.h: Drop qemu_work_item prototype

2013-01-18 Thread Andreas Färber
Commit c64ca8140e9c21cd0d44c10fbe1247cb4ade8e6e (cpu: Move queued_work_{first,last} to CPUState) moved the qemu_work_item fields away. Clean up the now unused prototype. Signed-off-by: Andreas Färber --- include/exec/cpu-defs.h |2 -- 1 Datei geändert, 2 Zeilen entfernt(-) diff --git a/incl

[Qemu-devel] [PATCH 9/9] PPC: KVM: Add support for EPR with KVM

2013-01-18 Thread Alexander Graf
This patch links KVM EPR support to the existing TCG support we have now. Signed-off-by: Alexander Graf --- hw/ppc.c |6 ++ target-ppc/kvm.c | 21 + target-ppc/kvm_ppc.h |5 + 3 files changed, 32 insertions(+), 0 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH 4/9] PPC: E500: Calculate loading blob offsets properly

2013-01-18 Thread Alexander Graf
We have 3 blobs we need to load when booting the system: - kernel - initrd - dtb We place them in physical memory in that order. At least we should. This patch fixes the location calculation up to take any module into account, fixing the dtb offset along the way. Reported-by: Stuart Yoder

Re: [Qemu-devel] [PATCH 2/8] s390: Move IPL code into a separate device

2013-01-18 Thread Andreas Färber
Am 18.01.2013 19:12, schrieb Alexander Graf: > diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c > new file mode 100644 > index 000..7cbbf99 > --- /dev/null > +++ b/hw/s390x/ipl.c [...] > +static TypeInfo s390_ipl_info = { This should probably be static const - my tree-wide cleanup didn't catch s39

[Qemu-devel] [PATCH for-1.4] block/raw-posix: Make hdev_aio_discard() available outside Linux

2013-01-18 Thread Andreas Färber
Fixes the build on OpenBSD among others. Suggested-by: Kevin Wolf Signed-off-by: Andreas Färber Cc: Paolo Bonzini --- block/raw-posix.c | 26 +- 1 Datei geändert, 13 Zeilen hinzugefügt(+), 13 Zeilen entfernt(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index

[Qemu-devel] [PATCH 7/9] Update Linux kernel headers

2013-01-18 Thread Alexander Graf
Based on kvm.git a843fac (next) plus dfdebc24 (master). Signed-off-by: Alexander Graf --- linux-headers/asm-powerpc/kvm.h |6 +- linux-headers/linux/kvm.h | 27 +++ 2 files changed, 32 insertions(+), 1 deletions(-) diff --git a/linux-headers/asm-powerpc/k

[Qemu-devel] [PATCH 6/9] PPC: e500: Change in-memory order of load blobs

2013-01-18 Thread Alexander Graf
Today, we load into memory in that order. However, Linux has a bug where it can only handle the dtb if it's within the first 64MB of where starts. So instead, let's change the order to making Linux happy. Signed-off-by: Alexander Graf --- hw/ppc/e500.c |7 ++- 1 files cha

[Qemu-devel] [PATCH 8/8] s390: Add a hypercall registration interface.

2013-01-18 Thread Alexander Graf
From: Cornelia Huck Allow virtio machines to register for different diag500 function codes and convert s390-virtio to use it. Signed-off-by: Cornelia Huck Signed-off-by: Alexander Graf --- hw/s390-virtio.c | 90 ++--- hw/s390-virtio.h

[Qemu-devel] [PULL 0/8] s390 patch queue 2013-01-18

2013-01-18 Thread Alexander Graf
Hi Blue / Aurelien, This is my current patch queue for s390. Please pull. Alex The following changes since commit ddc01bf16e9f04b3e72c1b946b0b8efeb7a545d2: Anthony Liguori (1): Merge remote-tracking branch 'luiz/queue/qmp' into staging are available in the git repository at: git:

[Qemu-devel] [PULL 0/9] ppc patch queue 2013-01-18

2013-01-18 Thread Alexander Graf
Hi Blue / Aurelien, This is my current patch queue for ppc. Please pull. Alex The following changes since commit ddc01bf16e9f04b3e72c1b946b0b8efeb7a545d2: Anthony Liguori (1): Merge remote-tracking branch 'luiz/queue/qmp' into staging are available in the git repository at: git:/

[Qemu-devel] [RFC V7 04/11] quorum: Add quorum_aio_writev and its dependencies.

2013-01-18 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 113 1 file changed, 113 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index e157eb1..71ae9ce 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -204,6 +204,117 @@ static void

[Qemu-devel] [PATCH 6/8] win32-aio: use iov utility functions instead of open-coding them

2013-01-18 Thread Stefan Hajnoczi
From: Michael Tokarev We have iov_from_buf() and iov_to_buf(), use them instead of open-coding these in block/win32-aio.c Signed-off-by: Stefan Hajnoczi --- block/win32-aio.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/block/win32-aio.c b/block/win32-

[Qemu-devel] [PATCH 5/8] s390: Add CPU reset handler

2013-01-18 Thread Alexander Graf
From: Jens Freimann Add a CPU reset handler to have all CPUs in a PoP compliant state. Signed-off-by: Jens Freimann [agraf: move hw/hw.h into existing ifdef] Signed-off-by: Alexander Graf --- target-s390x/cpu.c | 35 +-- target-s390x/kvm.c |9 - 2

[Qemu-devel] [PATCH 5/9] PPC: Provide zero SVR for -cpu e500mc and e5500

2013-01-18 Thread Alexander Graf
Even though our -cpu types for e500mc and e5500 are no real CPUs that actually have version registers, a guest might still want to access said version register and that has to succeed for a guest to be happy. So let's expose a zero SVR value on E500_SVR SPR reads. Signed-off-by: Alexander Graf -

[Qemu-devel] [PATCH 1/9] openpic: move gcr write into a function

2013-01-18 Thread Alexander Graf
The GCR register contains too much functionality to be covered inside of the register switch statement. Move it out into a separate function. Signed-off-by: Alexander Graf --- hw/openpic.c | 39 ++- 1 files changed, 22 insertions(+), 17 deletions(-) diff --

[Qemu-devel] [PATCH 0/3] Purge the silly GLib Basic Types

2013-01-18 Thread Markus Armbruster
See PATCH 1/3 for rationale. Markus Armbruster (3): Purge the silly GLib "Basic Types", except for gboolean Purge GLib's gboolean, it's a trap for the unwary checkpatch: Keep out the GLib silliness we just purged async.c| 12 +--- coroutine-gthread.c

[Qemu-devel] [PATCH 8/9] openpic: export e500 epr enable into a ppc.c function

2013-01-18 Thread Alexander Graf
Enabling and disabling the EPR capability (mpic_proxy) is a system wide operation. As such, it belongs into the ppc.c file, since that's where PPC specific machine wide logic happens. Signed-off-by: Alexander Graf --- hw/openpic.c | 11 +-- hw/ppc.c | 11 +++ hw/ppc.h

[Qemu-devel] [PATCH 7/8] target-s390x: Unregister reset callback on finalization

2013-01-18 Thread Alexander Graf
From: Andreas Färber Since commit "s390: Add CPU reset handler" the CPU's instance_init registers a reset callback. Unregister that on instance_finalize. Signed-off-by: Andreas Färber Signed-off-by: Alexander Graf --- target-s390x/cpu.c | 10 ++ 1 files changed, 10 insertions(+), 0

[Qemu-devel] [PATCH 3/9] openpic: set mixed mode as supported

2013-01-18 Thread Alexander Graf
The Raven MPIC implementation supports the "Mixed" mode to work with an i8259. While we don't implement mixed mode, we should mark it as a supported mode in the mode bitmap. Signed-off-by: Alexander Graf --- hw/openpic.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw

[Qemu-devel] [PATCH 3/8] S390: Enable -cpu help and QMP query-cpu-definitions

2013-01-18 Thread Alexander Graf
From: Viktor Mihajlovski This enables qemu -cpu help to return a list of supported CPU models on s390 and also to query for cpu definitions in the monitor. Initially only cpu model = host is returned. This needs to be reworked into a full-fledged CPU model handling later on. This change is needed

[Qemu-devel] [PATCH 1/8] block: fix null-pointer bug on error case in block commit

2013-01-18 Thread Stefan Hajnoczi
From: Jeff Cody This is a bug that was caught by a coverity run by Markus. In the error case when we errored out to exit_restore_open early in the function, 'overlay_bs' was still NULL at that point, although it is used to look up flags and perform a bdrv_reopen(). Move the overlay_bs lookup to

[Qemu-devel] [PATCH 6/8] s390x: fix indentation

2013-01-18 Thread Alexander Graf
In one of the last commits we accidently got 3-space indentation into the tree. Fix it up so it's 4 spaces wide. Reported-by: Andreas Faerber Signed-off-by: Alexander Graf --- target-s390x/kvm.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target-s390x/kvm.c

[Qemu-devel] [PATCH 1/8] s390: new contributions GPLv2 or later

2013-01-18 Thread Alexander Graf
From: Christian Borntraeger IBMs s390 contributions were meant to to be gplv2 or later (since we were contributing to qemu). Several of the s390 specific files link to gpl code anyway, so lets clarify the licence statement for new contributions for those files that we have touched multiple times

[Qemu-devel] [PATCH 2/8] s390: Move IPL code into a separate device

2013-01-18 Thread Alexander Graf
From: Christian Borntraeger Lets move the code to setup IPL for external kernel or via the zipl rom into a separate file. This allows to - define a reboot handler, setting up the PSW appropriately - enhance the boot code to IPL disks that contain a bootmap that was created with zipl under LPAR

[Qemu-devel] [PATCH 3/3] checkpatch: Keep out the GLib silliness we just purged

2013-01-18 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- scripts/checkpatch.pl | 29 + 1 file changed, 29 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index ec0aa4c..3490946 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2876,6 +2876,35 @@

Re: [Qemu-devel] [PATCH 1/8 v5] cutils: unsigned int parsing functions

2013-01-18 Thread Eric Blake
On 01/18/2013 10:57 AM, Eduardo Habkost wrote: > There are lots of duplicate parsing code using strto*() in QEMU, and > most of that code is broken in one way or another. Even the visitors > code have duplicate integer parsing code[1]. This introduces functions > to help parsing unsigned int values

Re: [Qemu-devel] [PATCH v2 2/5] block: Use error code EMEDIUMTYPE for wrong format in some block drivers

2013-01-18 Thread Stefan Weil
Am 18.01.2013 09:53, schrieb Markus Armbruster: > Stefan Weil writes: >> This improves error reports for bochs, cow, qcow, qcow2, qed and vmdk >> when a file with the wrong format is selected. >> >> Signed-off-by: Stefan Weil >> --- >> block/bochs.c |2 +- >> block/cow.c |2 +- >> bloc

Re: [Qemu-devel] [PATCH v3] block: Monitor command commit neglects to report some errors

2013-01-18 Thread Markus Armbruster
Jeff Cody writes: > The non-live bdrv_commit() function may return one of the following > errors: -ENOTSUP, -EBUSY, -EACCES, -EIO. The only error that is > checked in the HMP handler is -EBUSY, so the monitor command 'commit' > silently fails for all error cases other than 'Device is in use'. >

Re: [Qemu-devel] [PATCH 1/8] cutils: unsigned int parsing functions

2013-01-18 Thread Markus Armbruster
Eduardo Habkost writes: > On Fri, Jan 18, 2013 at 11:01:14AM +0100, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > There are lots of duplicate parsing code using strto*() in QEMU, and >> > most of that code is broken in one way or another. Even the visitors >> > code have duplicate

Re: [Qemu-devel] bdrv_co_flush_to_disk() don't flush as expected

2013-01-18 Thread Liu Yuan
On 01/18/2013 11:43 PM, Liu Yuan wrote: > # start up the guest > $ qemu-system-x86_64 --enable-kvm -drive > file=~/images/test1,if=virtio,cache=writeback -smp 2 -cpu host -m 1024 > -drive file=sheepdog:test,if=virtio,cache=writeback > # write to the /dev/vdb of the guest > # sudo dd if=/dev/ura

[Qemu-devel] [RFC V7 07/11] quorum: Add quorum mechanism.

2013-01-18 Thread Benoît Canet
Use gnutls's SHA-256 to compare versions. Signed-off-by: Benoit Canet --- block/quorum.c | 303 +++- configure | 22 2 files changed, 324 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index 7194809..e2b

Re: [Qemu-devel] [PULL 00/27] More source reorganization and build system TLC

2013-01-18 Thread Andreas Färber
Am 12.01.2013 18:35, schrieb Paolo Bonzini: > Alon Levy (1): > libcacard: fix missing symbol in libcacard.so > > Paolo Bonzini (26): > qemu-option: move standard option definitions out of qemu-config.c > stubs: fully replace qemu-tool.c and qemu-user.c > build: make libtool

[Qemu-devel] [RFC V7 01/11] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB.

2013-01-18 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/Makefile.objs |1 + block/quorum.c | 45 + 2 files changed, 46 insertions(+) create mode 100644 block/quorum.c diff --git a/block/Makefile.objs b/block/Makefile.objs index c067f38..4143e34 100644 --- a/

Re: [Qemu-devel] [PATCH V3 42/44] virtio-9p-pci: switch to the new API.

2013-01-18 Thread Deepak C Shetty
On 01/15/2013 07:39 PM, fred.kon...@greensocs.com wrote: From: KONRAD Frederic Here the virtio-9p-pci is modified for the new API. The device virtio-9p-pci extends virtio-pci. It creates and connects a virtio-9p during the init. The properties are not changed. Signed-off-by: KONRAD Frederic

Re: [Qemu-devel] [PATCH V3 43/44] virtio-9p: cleanup: init function.

2013-01-18 Thread Deepak C Shetty
On 01/15/2013 07:39 PM, fred.kon...@greensocs.com wrote: From: KONRAD Frederic This remove old init function as it is no longer needed. Signed-off-by: KONRAD Frederic Tested-by: Deepak C Shetty

[Qemu-devel] [PATCH 1/8 v5] cutils: unsigned int parsing functions

2013-01-18 Thread Eduardo Habkost
There are lots of duplicate parsing code using strto*() in QEMU, and most of that code is broken in one way or another. Even the visitors code have duplicate integer parsing code[1]. This introduces functions to help parsing unsigned int values: parse_uint() and parse_uint_full(). Parsing function

[Qemu-devel] [RFC V7 10/11] quorum: Add quorum_co_is_allocated.

2013-01-18 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 53 + 1 file changed, 53 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 5cafb40..8cbf66f 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -287,6 +287,22 @@ static int quoru

[Qemu-devel] [PATCH 1/3] Purge the silly GLib "Basic Types", except for gboolean

2013-01-18 Thread Markus Armbruster
GLib chooses to define aliases for a whole bunch of bog-standard C names. GLib's documentation justifies them by "ease-of-use and portability". Baloney. Aliases for standar types are no more portable than the standard types themselves. And if you const void * so hard to use that you need to mud

Re: [Qemu-devel] [PATCH] define qemukvm-1.2 machine type

2013-01-18 Thread Paolo Bonzini
> > version_id and minimum_version_id should be changed to 2, as the > > comment indicates. > > But won't that mean we have to carry that patch forever, and while we carry > that patch we can never migrate from Fedora qemu to an upstream qemu instance? > I'd like to avoid carrying any incompatibil

[Qemu-devel] bypassing pci_dma_read() and pci_dma_write() ?

2013-01-18 Thread Luigi Rizzo
Hi, with a bunch of e1000 improvements we are at a point where we are doing over 1Mpps (short frames) and 7-8Gbit/s (1500 byte frames) between two guests, and two things that are high in the "perf top" stats are phys_page_find() and related memory copies. Both are triggered by the pci_dma_read() a

[Qemu-devel] [RFC V7 05/11] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify.

2013-01-18 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/blkverify.c | 108 + include/qemu-common.h |2 + util/iov.c| 103 ++ 3 files changed, 107 insertions(+), 106 deletions(-) diff --git a/block/blk

Re: [Qemu-devel] [PATCH v2] block: do_commit() does not pass along error messages for all errors

2013-01-18 Thread Jeff Cody
On Fri, Jan 18, 2013 at 06:11:25PM +0100, Markus Armbruster wrote: > Jeff Cody writes: > > > The non-live bdrv_commit() function may return one of the following > > errors: -ENOTSUP, -EBUSY, -EACCES, -EIO. The only error that is > > checked in the HMP handler is -EBUSY, so the monitor command 'c

Re: [Qemu-devel] [PATCH for-1.4 04/12] kvm: Create kvm_arch_vcpu_id() function

2013-01-18 Thread Eric Blake
On 01/18/2013 09:40 AM, Eduardo Habkost wrote: > On Fri, Jan 18, 2013 at 09:11:42AM -0700, Eric Blake wrote: >> On 01/18/2013 07:20 AM, Eduardo Habkost wrote: Could you suggest a text for me to add please? >>> >>> "The argument passed to KVM_CREATE_VCPU now has 'unsigned long' type >>> instead

[Qemu-devel] [PATCH v3] block: Monitor command commit neglects to report some errors

2013-01-18 Thread Jeff Cody
The non-live bdrv_commit() function may return one of the following errors: -ENOTSUP, -EBUSY, -EACCES, -EIO. The only error that is checked in the HMP handler is -EBUSY, so the monitor command 'commit' silently fails for all error cases other than 'Device is in use'. Report error using monitor_pr

[Qemu-devel] [RFC V7 03/11] quorum: Add quorum_open() and quorum_close().

2013-01-18 Thread Benoît Canet
Valid quorum resources look like quorum:threshold/total:path/to/image_1: ... :path/to/image_total ':' is used as a separator '\' is the escaping character for filename containing ':' '\' escape itself ',' must be escaped with ',' On the command line for quorum files "img:test.raw", "img2,raw" and

[Qemu-devel] [Bug 1101210] Re: qemu 1.3.0: usb keyboard not fully working

2013-01-18 Thread Sven
Actually, the whole < > | key doesn't work. It's just dead. I can't type any of those characters. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1101210 Title: qemu 1.3.0: usb keyboard not fully wor

[Qemu-devel] [PATCH V20 3/8] Add a debug register

2013-01-18 Thread Stefan Berger
This patch uses the possibility to add a vendor-specific register and adds a debug register useful for dumping the TIS's internal state. This register is only active in a debug build (#define DEBUG_TIS). Signed-off-by: Stefan Berger --- hw/tpm_tis.c | 70 +

[Qemu-devel] [Bug 1101210] [NEW] qemu 1.3.0: usb keyboard not fully working

2013-01-18 Thread Sven
Public bug reported: When using the usb keyboard, I can't type the | character. I'm using german keyboard layout (de) on the host and inside the guest. As a guest OS, I use Linux (e.g. a recent KNOPPIX cd). To obtain the | character on a german keyboard, I need to press AltGr + the < or > key, i.e

[Qemu-devel] [PATCH V20 8/8] Add fd parameter for TPM passthrough driver

2013-01-18 Thread Stefan Berger
Enable the passing of a file descriptor via fd=<..> to access the host's TPM device using the TPM passthrough driver. Signed-off-by: Stefan Berger --- hmp.c| 7 ++- hw/tpm_passthrough.c | 53 qapi-schema.json | 4 +++-

[Qemu-devel] [RFC V7 06/11] quorum: Add quorum_aio_readv.

2013-01-18 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 38 +- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index 71ae9ce..7194809 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -225,15 +225,24 @@ static void quo

Re: [Qemu-devel] [PATCH v2 05/12] mirror: perform COW if the cluster size is bigger than the granularity

2013-01-18 Thread Paolo Bonzini
> Am 18.01.2013 17:22, schrieb Paolo Bonzini: > > I haven't written a testcase for it, it's tricky but should be > > doable. > > Do you want me to respin, or can it be done as a followup? > > I think I would prefer a respin, but if you think otherwise, I won't > insist. Okay, I'll respin. I'll

[Qemu-devel] [RFC V7 08/11] quorum: Add quorum_getlength().

2013-01-18 Thread Benoît Canet
Check that every bs file return the same length. If not return -EIO to disable the quorum and avoid length discrepancy. Signed-off-by: Benoit Canet --- block/quorum.c | 20 1 file changed, 20 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index e2b5208..a63a84

[Qemu-devel] [RFC V7 09/11] quorum: Add quorum_invalidate_cache().

2013-01-18 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index a63a84f..5cafb40 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -669,6 +669,16 @@ static int64_t quorum_getlength(BlockDriverState *bs)

[Qemu-devel] [RFC V7 11/11] quorum: Add quorum_co_flush().

2013-01-18 Thread Benoît Canet
Makes a vote to select error if any. Signed-off-by: Benoit Canet --- block/quorum.c | 33 + 1 file changed, 33 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 8cbf66f..0f4f634 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -731,6 +731,38 @

[Qemu-devel] [RFC V7 02/11] quorum: Create BDRVQuorumState and BlkDriver and do init.

2013-01-18 Thread Benoît Canet
Signed-off-by: Benoit Canet --- block/quorum.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index ce094a1..0524b63 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -15,6 +15,13 @@ #include "block/block_int.h" +typedef struct

[Qemu-devel] [RFC V7 00/11] Quorum block filter

2013-01-18 Thread Benoît Canet
This patchset is rebased on top of "cutils: unsigned int parsing functions" by "Eduardo Habkost". This patchset create a block driver implementing a quorum using total qemu disk images. Writes are mirrored on the $total files. For the reading part the $total files are read at the same time and a v

[Qemu-devel] [PATCH 7/8] dataplane: avoid reentrancy during virtio_blk_data_plane_stop()

2013-01-18 Thread Stefan Hajnoczi
When dataplane is stopping, the s->vdev->binding->set_host_notifier(..., false) call can invoke the virtqueue handler if an ioeventfd notification is pending. This causes hw/virtio-blk.c to invoke virtio_blk_data_plane_start() before virtio_blk_data_plane_stop() returns! The result is that we try

Re: [Qemu-devel] [PATCH 12/12] s390: Add s390-ccw-virtio machine.

2013-01-18 Thread Alexander Graf
On 17.01.2013, at 15:23, Cornelia Huck wrote: > Add a new machine type, s390-ccw-virtio, making use of the > virtio-ccw transport to present virtio devices as channel > devices and make it the default on s390. > > Signed-off-by: Cornelia Huck > --- > hw/s390-virtio.c | 1 - > hw/s390

Re: [Qemu-devel] [PATCH V3 44/44] virtio-9p: cleanup: QOM casts.

2013-01-18 Thread Deepak C Shetty
On 01/15/2013 07:39 PM, fred.kon...@greensocs.com wrote: From: KONRAD Frederic As the virtio-9p-pci is switched to the new API, we can use QOM casts. Signed-off-by: KONRAD Frederic Tested-by: Deepak C Shetty

[Qemu-devel] [PATCH 2/8] ide: Remove wrong assertion

2013-01-18 Thread Stefan Hajnoczi
From: Kevin Wolf The Bus Master IDE Active bit (BM_STATUS_DMAING) is not only set when the request is still in flight, but also when it has completed and the size of the physical memory regions in the PRDT was larger than the transfer size. Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoc

Re: [Qemu-devel] [PATCH v2] block: do_commit() does not pass along error messages for all errors

2013-01-18 Thread Markus Armbruster
Jeff Cody writes: > The non-live bdrv_commit() function may return one of the following > errors: -ENOTSUP, -EBUSY, -EACCES, -EIO. The only error that is > checked in the HMP handler is -EBUSY, so the monitor command 'commit' > silently fails for all error cases other than 'Device is in use'. >

Re: [Qemu-devel] [PATCH 03/12] s390: Add mapping helper functions.

2013-01-18 Thread Alexander Graf
On 17.01.2013, at 15:23, Cornelia Huck wrote: > Add s390_cpu_physical_memory_{map,unmap} with special handling > for the lowcore. > > Signed-off-by: Cornelia Huck > --- > target-s390x/cpu.h| 4 > target-s390x/helper.c | 26 ++ > 2 files changed, 30 insertions(+)

[Qemu-devel] [PATCH 2/3] Purge GLib's gboolean, it's a trap for the unwary

2013-01-18 Thread Markus Armbruster
Despite its name, gboolean is an alias for int, *not* for _Bool. If you forget that, and compare gboolean values to TRUE, you're in trouble. Instead of blindly replacing gboolean by int, replace it by int exactly where that's needed for type-correctness, and by bool everywhere else. Signed-off-b

Re: [Qemu-devel] [PATCH v2 05/12] mirror: perform COW if the cluster size is bigger than the granularity

2013-01-18 Thread Kevin Wolf
Am 18.01.2013 17:22, schrieb Paolo Bonzini: > I haven't written a testcase for it, it's tricky but should be doable. > Do you want me to respin, or can it be done as a followup? I think I would prefer a respin, but if you think otherwise, I won't insist. > I would prefer a followup also because i

Re: [Qemu-devel] [PATCH] define qemukvm-1.2 machine type

2013-01-18 Thread Cole Robinson
On 01/18/2013 06:12 AM, Marcelo Tosatti wrote: > On Wed, Jan 16, 2013 at 06:17:03PM -0500, Cole Robinson wrote: >> On 01/15/2013 11:29 AM, Paolo Bonzini wrote: >>> Il 15/01/2013 04:45, Cole Robinson ha scritto: Libvirt always specifies an explicit machine type and carries it for the life

Re: [Qemu-devel] [PATCH] bswap: improve gluing

2013-01-18 Thread Markus Armbruster
Alexander Graf writes: > On 17.01.2013, at 08:50, Markus Armbruster wrote: > >> David Gibson writes: >> >>> On Sun, Jan 13, 2013 at 04:35:41PM +, Blue Swirl wrote: OpenBSD system compiler (gcc 4.2.1) has problems with concatenation of macro arguments in macro functions: CC

[Qemu-devel] [PATCH 3/8] aio: Fix return value of aio_poll()

2013-01-18 Thread Stefan Hajnoczi
From: Kevin Wolf aio_poll() must return true if any work is still pending, even if it didn't make progress, so that bdrv_drain_all() doesn't stop waiting too early. The possibility of stopping early occasionally lead to a failed assertion in bdrv_drain_all(), when some in-flight request was misse

Re: [Qemu-devel] [PATCH 02/12] s390: Lowcore mapping helper.

2013-01-18 Thread Alexander Graf
On 17.01.2013, at 15:23, Cornelia Huck wrote: > Create a lowcore mapping helper that includes a check for sufficient > length. > > Signed-off-by: Cornelia Huck > --- > target-s390x/helper.c | 31 +-- > 1 file changed, 25 insertions(+), 6 deletions(-) > > diff --git a

Re: [Qemu-devel] [PATCH 01/12] s390: Add a hypercall registration interface.

2013-01-18 Thread Alexander Graf
On 17.01.2013, at 15:23, Cornelia Huck wrote: > Allow virtio machines to register for different diag500 function > codes and convert s390-virtio to use it. > > Signed-off-by: Cornelia Huck Thanks, applied to s390-next. Alex

Re: [Qemu-devel] [PATCH v5 00/12] s390: channel I/O support in qemu.

2013-01-18 Thread Alexander Graf
On 17.01.2013, at 15:23, Cornelia Huck wrote: > Hi, > > here's the latest incarnation of my channel I/O and virtio-ccw > patchset for qemu, containing various changes over the last one. Which tree are you working against? This set doesn't apply on s390-next. Alex > > (Note that "s390: Add a

Re: [Qemu-devel] bypassing pci_dma_read() and pci_dma_write() ?

2013-01-18 Thread Paolo Bonzini
Il 18/01/2013 17:33, Luigi Rizzo ha scritto: >> > First, host memory mappings could change (though they rarely do on PC). >> > The result of address_space_map is not guaranteed to be stable. To >> > avoid problems with this, however, you could use something like >> > hw/dataplane/hostmem.c and ev

  1   2   >