Re: [Qemu-devel] [RFC] Add serial number to usbdevice when passthrough to VM

On 01/16/13 08:18, Lei Li wrote: > Hi guys, > > Currently we can passthrough the host USB device to the virtual > machine. This is done like: > > –usbdevice host:1234:5678, where 1234 is vendor id, 5678 is product > id. > > But there is a problem. If there are two identical USB devices, > where

Re: [Qemu-devel] [PATCH qom-cpu 1/2] target-i386/cpu.c: Coding style fixes

On Fri, 11 Jan 2013 00:18:09 -0200 Eduardo Habkost wrote: > * Add braces to 'if' statements; > * Remove last TAB character from the source. > > Signed-off-by: Eduardo Habkost Reviewed-By: Igor Mammedov > --- > target-i386/cpu.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-)

Re: [Qemu-devel] [PATCH] target-i386: make x86_def_t.vendor[1, 2, 3] a string and use cpuid_vendor union in CPUX86State

On Wed, 16 Jan 2013 15:07:05 +0800 li guang wrote: > 在 2013-01-15二的 13:06 +0100，Igor Mammedov写道： > > Tested on x86 host yet, I don't have bigendian host avilable right now. > > > > Vendor property setter takes string as vendor value but cpudefs > > use uint32_t vendor[123] fields to define vendo

Re: [Qemu-devel] [RFC PATCH v4 13/30] piix_pci and pc_piix: refactor

Hi Vasilis, On Tue, Dec 18, 2012 at 01:41:41PM +0100, Vasilis Liaskovitis wrote: > Refactor code so that chipset initialization is similar to q35. This will > allow memory map initialization at chipset qdev init time for both > machines, as well as more similar code structure overall. > > Signed-

[Qemu-devel] [RFC] Add serial number to usbdevice when passthrough to VM

Hi guys, Currently we can passthrough the host USB device to the virtual machine. This is done like: –usbdevice host:1234:5678, where 1234 is vendor id, 5678 is product id. But there is a problem. If there are two identical USB devices, where the vendor id and the product id is the same. It's

Re: [Qemu-devel] [PATCH] target-i386: make x86_def_t.vendor[1, 2, 3] a string and use cpuid_vendor union in CPUX86State

在 2013-01-15二的 13:06 +0100，Igor Mammedov写道： > Tested on x86 host yet, I don't have bigendian host avilable right now. > > Vendor property setter takes string as vendor value but cpudefs > use uint32_t vendor[123] fields to define vendor value. It makes it > difficult to unify and use property sett

[Qemu-devel] [RFC qom-cpu 08/15] target-m68k: Introduce QOM realizefn for M68kCPU

Introduce realizefn and set realized = true in cpu_m68k_init(). Signed-off-by: Andreas Färber --- target-m68k/cpu.c| 11 +++ target-m68k/helper.c |3 +-- 2 Dateien geändert, 12 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/target-m68k/cpu.c b/target-m68k/cpu.c index

[Qemu-devel] [RFC qom-cpu 03/15] target-i386: Update CPU to QOM realizefn

Adapt the signature of x86_cpu_realize(), hook up to DeviceClass::realize and set realized = true in cpu_x86_init(). Signed-off-by: Andreas Färber Cc: Eduardo Habkost Cc: Igor Mammedov --- target-i386/cpu-qom.h |3 --- target-i386/cpu.c |7 +-- target-i386/helper.c |2 +-

[Qemu-devel] [RFC qom-cpu 11/15] target-s390x: Introduce QOM realizefn for S390CPU

Introduce realizefn and set realized = true in cpu_s390x_init(). Signed-off-by: Andreas Färber --- target-s390x/cpu.c| 10 ++ target-s390x/helper.c |4 +++- 2 Dateien geändert, 13 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/target-s390x/cpu.c b/target-s390x/cpu.c i

[Qemu-devel] [RFC qom-cpu 12/15] target-sh4: Introduce QOM realizefn for SuperHCPU

Introduce a realizefn and set realized = true in cpu_sh4_init(). Signed-off-by: Andreas Färber --- target-sh4/cpu.c | 11 +++ target-sh4/translate.c |5 +++-- 2 Dateien geändert, 14 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/target-sh4/cpu.c b/target-sh4/cpu.c

Re: [Qemu-devel] 100% CPU when sockfd is half-closed and unexpected behavior for qemu_co_send()

On 01/14/2013 06:07 PM, Paolo Bonzini wrote: > Ok. I guess the problem is that we use select(), not poll(), so we have > no way to get POLLHUP notifications. But the write fd_set receives the > file descriptor because indeed writes will not block. Hi Paolo, is there any movement switch select(

[Qemu-devel] [RFC qom-cpu 02/15] target-arm: Update CPU to QOM realizefn

Turn arm_cpu_realize() into a QOM realize function, no longer called via cpu.h prototype. To maintain the semantics of cpu_init(), set realized = true explicitly in cpu_arm_init(). Move CPU reset and vCPU initialization into the realizefn. Signed-off-by: Andreas Färber --- target-arm/cpu-qom.h

Re: [Qemu-devel] [QEMU PATCH v2] virtio-net: introduce a new macaddr control

On Wednesday, January 16, 2013 02:16:47 PM ak...@redhat.com wrote: > From: Amos Kong > > In virtio-net guest driver, currently we write MAC address to > pci config space byte by byte, this means that we have an > intermediate step where mac is wrong. This patch introduced > a new control command

[Qemu-devel] [RFC qom-cpu 00/15] CPUState QOM realizefn support

Hello, This series is one of the missing puzzle pieces to allow using device_add for CPU hotplug mentioned on yesterdays's KVM call. Historically, CPUs are created through cpu_init() macro aliased to cpu__init() functions. Since v1.1 these all create a QOM object and then somehow "fiddle" with it

[Qemu-devel] [RFC qom-cpu 10/15] target-mips: Introduce QOM realizefn for MIPSCPU

Introduce a realizefn and set realized = true from cpu_mips_init(). Signed-off-by: Andreas Färber --- target-mips/cpu.c | 11 +++ target-mips/translate.c |5 +++-- 2 Dateien geändert, 14 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/target-mips/cpu.c b/target-mips

[Qemu-devel] [RFC qom-cpu 01/15] target-alpha: Update CPU to QOM realizefn

Update the alpha_cpu_realize() signature and hook up to DeviceClass::realize. Set realized = true in cpu_alpha_init(). qapi/error.h is included through qdev now and no longer needed. Signed-off-by: Andreas Färber --- target-alpha/cpu.c | 15 +++ 1 Datei geändert, 11 Zeilen hinzuge

[Qemu-devel] [RFC qom-cpu 04/15] target-openrisc: Update CPU to QOM realizefn

Update the openrisc_cpu_realize() signature, hook it up to DeviceClass::realize and set realized = true in cpu_openrisc_init(). qapi/error.h is now included through qdev and no longer needed. Signed-off-by: Andreas Färber --- target-openrisc/cpu.c |9 ++--- target-openrisc/cpu.h |2

Re: [Qemu-devel] [PATCH v2 2/2] virtio-net: introduce a new control to set macaddr

On Wednesday, January 16, 2013 01:57:01 PM ak...@redhat.com wrote: > From: Amos Kong > > Currently we write MAC address to pci config space byte by byte, > this means that we have an intermediate step where mac is wrong. > This patch introduced a new control command to set MAC address > in one ti

[Qemu-devel] [RFC qom-cpu 07/15] target-lm32: Introduce QOM realizefn for LM32CPU

Introduce a realizefn and set realized = true in cpu_lm32_init(). Also move cpu_reset() call from initfn to realizefn. Signed-off-by: Andreas Färber --- target-lm32/cpu.c| 14 -- target-lm32/helper.c |4 ++-- 2 Dateien geändert, 14 Zeilen hinzugefügt(+), 4 Zeilen entfernt(

[Qemu-devel] [QEMU PATCH v2] virtio-net: introduce a new macaddr control

From: Amos Kong In virtio-net guest driver, currently we write MAC address to pci config space byte by byte, this means that we have an intermediate step where mac is wrong. This patch introduced a new control command to set MAC address in one time. VIRTIO_NET_F_CTRL_MAC_ADDR is a new feature bi

[Qemu-devel] [RFC qom-cpu 09/15] target-microblaze: Introduce QOM realizefn for MicroBlazeCPU

Introduce realizefn and set realized = true from cpu_mb_init(). Signed-off-by: Andreas Färber --- target-microblaze/cpu.c | 11 +++ target-microblaze/translate.c |3 +-- 2 Dateien geändert, 12 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/target-microblaze/cpu.c b

[Qemu-devel] [PATCH v2 1/2] move virtnet_send_command() above virtnet_set_mac_address()

From: Amos Kong We will send vq command to set mac address in virtnet_set_mac_address() a little fix of coding style Signed-off-by: Amos Kong --- drivers/net/virtio_net.c | 89 1 file changed, 44 insertions(+), 45 deletions(-) diff --git a/driv

[Qemu-devel] [PATCH v2 2/2] virtio-net: introduce a new control to set macaddr

From: Amos Kong Currently we write MAC address to pci config space byte by byte, this means that we have an intermediate step where mac is wrong. This patch introduced a new control command to set MAC address in one time. VIRTIO_NET_F_CTRL_MAC_ADDR is a new feature bit for compatibility. Signed

[Qemu-devel] [PATCH v2 0/2] make mac programming for virtio net more robust

From: Amos Kong Currenly mac is programmed byte by byte. This means that we have an intermediate step where mac is wrong. Second patch introduced a new vq control command to set mac address in one time. V2: check return of sending command, delay eth_mac_addr() Amos Kong (2): move virtnet_se

[Qemu-devel] [RFC qom-cpu 15/15] target-xtensa: Introduce QOM realizefn for XtensaCPU

Introduce realizefn and set realized = true in cpu_xtensa_init(). Signed-off-by: Andreas Färber --- target-xtensa/cpu.c| 10 ++ target-xtensa/helper.c |4 +++- 2 Dateien geändert, 13 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/target-xtensa/cpu.c b/target-xtensa/cp

[Qemu-devel] [RFC qom-cpu 06/15] target-cris: Introduce QOM realizefn for CRISCPU

Introduce realizefn and set realized = true from cpu_cris_init(). Signed-off-by: Andreas Färber --- target-cris/cpu.c | 11 +++ target-cris/translate.c |3 +-- 2 Dateien geändert, 12 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/target-cris/cpu.c b/target-cris/cpu

[Qemu-devel] [RFC qom-cpu 14/15] target-unicore32: Introduce QOM realizefn for UniCore32CPU

Introduce a realizefn and set realized = true in uc32_cpu_init(). Signed-off-by: Andreas Färber --- target-unicore32/cpu.c| 15 +++ target-unicore32/helper.c |2 +- 2 Dateien geändert, 16 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/target-unicore32/cpu.c b/targ

[Qemu-devel] [RFC qom-cpu 13/15] target-sparc: Introduce QOM realizefn for SPARCCPU

Introduce realizefn and set realized = true in cpu_sparc_init(). Signed-off-by: Andreas Färber --- target-sparc/cpu.c | 13 - 1 Datei geändert, 12 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/target-sparc/cpu.c b/target-sparc/cpu.c index f404aa8..b38fe0d 100644 --- a/ta

[Qemu-devel] [RFC qom-cpu 05/15] target-ppc: Update CPU to QOM realizefn

Signed-off-by: Andreas Färber --- target-ppc/translate_init.c |9 ++--- 1 Datei geändert, 6 Zeilen hinzugefügt(+), 3 Zeilen entfernt(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index 3f199c4..45ed0a1 100644 --- a/target-ppc/translate_init.c +++ b/target-ppc/

Re: [Qemu-devel] [PATCH] virtio-s390: add a reset function to virtio-s390 devices

Am 10.01.2013 15:40, schrieb Paolo Bonzini: > virtio-s390 devices are not being reset when their bus is. To fix > this, add a reset method that forwards to virtio_reset. This is > only needed because of the "strange" modeling of virtio devices; > the ->vdev link is being handled manually rather t

Re: [Qemu-devel] [RFC PATCH 2/2] virtio-net: introduce a new control to set macaddr

On Thu, Jan 10, 2013 at 10:57:05PM +0800, Jason Wang wrote: > On 01/10/2013 10:45 PM, ak...@redhat.com wrote: > > From: Amos Kong > > > > Currently we write MAC address to pci config space byte by byte, > > this means that we have an intermediate step where mac is wrong. > > This patch introduced

Re: [Qemu-devel] [PATCH] virtio-s390: add a reset function to virtio-s390 devices

On Thu, Jan 10, 2013 at 03:40:25PM +0100, Paolo Bonzini wrote: > virtio-s390 devices are not being reset when their bus is. To fix > this, add a reset method that forwards to virtio_reset. This is > only needed because of the "strange" modeling of virtio devices; > the ->vdev link is being handle

Re: [Qemu-devel] [PATCH V3 07/11] block: export function bdrv_find_snapshot()

于 2013-1-16 1:57, Eric Blake 写道: On 01/15/2013 03:24 AM, Wenchao Xia wrote: +int bdrv_snapshot_find(BlockDriverState *bs, QEMUSnapshotInfo *sn_info, + const char *name) +if (!strcmp(sn->id_str, name) || !strcmp(sn->name, name)) { This code comparison favo

Re: [Qemu-devel] [PATCH qom-cpu for-1.4] target-openrisc: Drop OpenRISCCPUList

Am 16.01.2013 04:57, schrieb Andreas Färber: > It was missed in the previous cleanup because its naming did not match > the *CPUListState pattern. Use the generalized CPUListState instead. > > Signed-off-by: Andreas Färber Jia, please add a MAINTAINERS entry for target-openrisc/ so that you auto

[Qemu-devel] [PATCH qom-cpu for-1.4] target-openrisc: Drop OpenRISCCPUList

It was missed in the previous cleanup because its naming did not match the *CPUListState pattern. Use the generalized CPUListState instead. Signed-off-by: Andreas Färber --- target-openrisc/cpu.c |9 ++--- 1 Datei geändert, 2 Zeilen hinzugefügt(+), 7 Zeilen entfernt(-) diff --git a/targ

Re: [Qemu-devel] [PATCH 04/17 v3] target-i386: add x86_cpu_vendor_words2str()

Reviewed-by: Li Guang 在 2013-01-14一的 19:33 +0100，Igor Mammedov写道： > Make for() cycle reusable for the next patch > > Signed-off-by: Igor Mammedov > Reviewed-by: Eduardo Habkost > --- > v5: >- style fix: added extra space to align arguments > Spotted-By: Eduardo Habkost >

Re: [Qemu-devel] [PATCH V3 01/11] qemu-img: remove unused parameter in collect_image_info()

于 2013-1-15 19:11, Luiz Capitulino 写道: On Tue, 15 Jan 2013 15:58:34 +0800 Wenchao Xia wrote: 于 2013-1-15 15:27, Wenchao Xia 写道: 于 2013-1-15 1:08, Luiz Capitulino 写道: On Mon, 14 Jan 2013 15:09:37 +0800 Wenchao Xia wrote: Parameter *fmt was not used, so remove it. Reviewed-by: Eric Bla

Re: [Qemu-devel] [PATCH V3 11/11] hmp: show snapshot on single block device

于 2013-1-15 19:05, Luiz Capitulino 写道: On Tue, 15 Jan 2013 10:36:22 +0800 Wenchao Xia wrote: > On Mon, 2013-01-14 at 15:09 +0800, Wenchao Xia wrote: This patch use block layer API to qmp snapshot info on a block device, then use the same code dumping vm snapshot info, to print in monito

[Qemu-devel] [PATCH for-1.4 v4 0/6] I2C libqos and tmp105 qtest support

Hello Anthony, Here's another rebased version of $subject. Please review changed bits and apply. Regards, Andreas v3 -> v4: * Rebased tmp105 onto already-const TypeInfo. * Rebased qtest Makefile additions onto second build reorganization. v2 -> v3: * Alex' tmp105.h patch was applied. * Rebased

Re: [Qemu-devel] [PATCH v3 0/2] Qemu boot order patch series

Thanks, applied. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH v3 0/2] QOM realize, device-only

Thanks, applied. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH 0/2] ACL fixes

Thanks, applied. Regards, Anthony Liguori

Re: [Qemu-devel] [PATCH] kvm: add stub for kvm_irqchip_update_msi_route

Thanks, applied. Regards, Anthony Liguori

[Qemu-devel] [PATCH for-1.4 v4 6/6] tmp105: Add temperature QOM property

This obsoletes tmp105_set() and allows for better error handling. Signed-off-by: Andreas Färber --- hw/tmp105.c | 34 +- hw/tmp105.h | 15 --- 2 Dateien geändert, 29 Zeilen hinzugefügt(+), 20 Zeilen entfernt(-) diff --git a/hw/tmp105.c b/hw/tmp105

[Qemu-devel] [PATCH for-1.4 v4 3/6] tmp105: Fix I2C protocol bug

An early length postincrement in the TMP105's I2C TX path led to transfers of more than one byte to place the second byte in the third byte's place within the buffer and the third byte to get discarded. Fix this by explictly incrementing the length after the checks but before the callback is calle

[Qemu-devel] [PATCH for-1.4 v4 4/6] tests: Add tmp105 qtest test case

Exercise all four commands of the TMP105, testing for an issue in the I2C TX path. The test case uses the N800's OMAP I2C and is the first for ARM. Signed-off-by: Andreas Färber --- tests/Makefile |3 ++ tests/tmp105-test.c | 76 +++ 2

Re: [Qemu-devel] [PULL 0/8] qemu-ga: cleanups and minor fixes

Pulled, thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PULL 0/1] qemu-ga: documentation/schema fix

Pulled, thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PULL 00/15] Block patches for QEMU 1.4

Pulled, thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PULL] PReP patch queue 2013-01-15

Pulled, thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PULL] QOM CPUState patch queue 2013-01-15

Pulled, thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PULL 0/3] Trivial patches for 12 to 15 January 2013

Pulled, thanks. Regards, Anthony Liguori

Re: [Qemu-devel] [PULL for-1.4 v2] Memory API ioport cleanups

Pulled, thanks. Regards, Anthony Liguori

[Qemu-devel] [PATCH for-1.4 v4 5/6] tmp105: QOM'ify

Introduce TYPE_ constant and cast macro. Move the state struct to the new header to allow for future embedding. Signed-off-by: Andreas Färber Reviewed-by: Anthony Liguori --- hw/tmp105.c | 36 hw/tmp105.h | 27 +++ 2 Dateien geänd

[Qemu-devel] [PATCH for-1.4 v4 2/6] tmp105: Split out I2C message constants from header

Allows value sharing with qtest. Signed-off-by: Andreas Färber Reviewed-by: Anthony Liguori --- hw/tmp105.h | 34 +- hw/tmp105_regs.h | 50 ++ 2 Dateien geändert, 51 Zeilen hinzugefügt(+), 33 Zeilen entfern

[Qemu-devel] [PATCH for-1.4 v4 1/6] libqtest: Prepare I2C libqos

This adds a simple I2C API and a driver implementation for omap_i2c. Signed-off-by: Andreas Färber Reviewed-by: Anthony Liguori --- tests/Makefile |1 + tests/libi2c-omap.c | 166 +++ tests/libi2c.c | 22 +++ tests/libi2c.h

Re: [Qemu-devel] [PULL for-1.4 v2] Memory API ioport cleanups

Andreas Färber writes: > Hi Anthony, > > Am 16.01.2013 00:02, schrieb Anthony Liguori: >> >> Please adjust your pull request script to include a 0/M marker if you're >> also including patches in the reply. > > In the past it was you who specifically requested us to always include > the queue of

[Qemu-devel] buildbot failure in qemu on block_mingw32

The Buildbot has detected a new failure on builder block_mingw32 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_mingw32/builds/447 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 Build Reason: The

Re: [Qemu-devel] [PULL for-1.4 v2] Memory API ioport cleanups

Hi Anthony, Am 16.01.2013 00:02, schrieb Anthony Liguori: > > Please adjust your pull request script to include a 0/M marker if you're > also including patches in the reply. In the past it was you who specifically requested us to always include the queue of patches part of that pull as reply! Is

[Qemu-devel] [Qemu-trivial] [PATCH] configure: silencing pkg-config's check for curses

>From d10856f3b1d893b5d3c6ab213eb921d0a24e7766 Mon Sep 17 00:00:00 2001 From: Vadim Evard Date: Wed, 16 Jan 2013 03:45:44 +0400 Subject: [PATCH] configure: silencing pkg-config's check for curses --- configure |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/con

Re: [Qemu-devel] [PATCH] hw/tpci200: Fix compiler warning (redefined symbol with MinGW)

On Tue, Jan 15, 2013 at 11:23:23PM +0100, Stefan Weil wrote: > STATUS_TIMEOUT is defined in winnt.h: > Fix the compiler warning by adding a prefix. Hey, thanks. If it doesn't conflict with anything else in Windows we could also replace it with STATUS_TIME, which is the actual name of the status

Re: [Qemu-devel] [PATCH 3/3 v2] configure: try pkg-config for curses

Vadim Evard writes: > Static linkikng against ncurses may require explicit -ltinfo. > In case -lcurses and -lncurses both didn't work give pkg-config a > chance. > > Fixes #1094786 for me. > > Signed-off-by: Vadim Evard > Signed-off-by: Stefan Hajnoczi The original patch is already in master so

Re: [Qemu-devel] [PATCH 3/3 v2] configure: try pkg-config for curses

Static linkikng against ncurses may require explicit -ltinfo. In case -lcurses and -lncurses both didn't work give pkg-config a chance. Fixes #1094786 for me. Signed-off-by: Vadim Evard Signed-off-by: Stefan Hajnoczi --- configure |5 - 1 file changed, 4 insertions(+), 1 deletion(-) di

Re: [Qemu-devel] [PULL for-1.4 v2] Memory API ioport cleanups

Hi, Please adjust your pull request script to include a 0/M marker if you're also including patches in the reply. No worries about this request, but my new version tracker gets confused because it marks this whole series as "broken" because it's impossible for a non-human to tell if this is the

Re: [Qemu-devel] [PATCH 3/3] configure: try pkg-config for curses

Stefan Hajnoczi writes: > From: Vadim Evard > > Static linkikng against ncurses may require explicit -ltinfo. > In case -lcurses and -lncurses both didn't work give pkg-config a > chance. > > Fixes #1094786 for me. > > Signed-off-by: Vadim Evard > Signed-off-by: Stefan Hajnoczi > --- > config

[Qemu-devel] [PATCH] hw/tpci200: Fix compiler warning (redefined symbol with MinGW)

STATUS_TIMEOUT is defined in winnt.h: CChw/tpci200.o hw/tpci200.c:34:0: warning: "STATUS_TIMEOUT" redefined [enabled by default] /usr/lib/gcc/x86_64-w64-mingw32/4.6/../../../../x86_64-w64-mingw32/include/winnt.h:1036:0: note: this is the location of the previous definition Fix the compile

[Qemu-devel] v1->v2 diff (PIIX3: reset the VM when the Reset Control Register's RCPU bit gets set)

diff --git a/hw/piix_pci.c b/hw/piix_pci.c index 75dc9c4..38a1027 100644 --- a/hw/piix_pci.c +++ b/hw/piix_pci.c @@ -477,9 +477,26 @@ static void piix3_pre_save(void *opaque) } } +static bool piix3_rcr_needed(void *opaque) +{ +PIIX3State *piix3 = opaque; + +return (piix3->rcr != 0);

[Qemu-devel] [PATCH v2] PIIX3: reset the VM when the Reset Control Register's RCPU bit gets set

>From : Traditional PCI config space access is achieved by writing a 32 bit value to io port 0xcf8 to identify the bus, device, function and config register. Port 0xcfc then contains the register in question. But if you write the appropriate pair of m

Re: [Qemu-devel] [PATCH] target-i386: make x86_def_t.vendor[1, 2, 3] a string and use cpuid_vendor union in CPUX86State

On Tue, 15 Jan 2013 15:51:18 -0200 Eduardo Habkost wrote: > On Tue, Jan 15, 2013 at 01:06:28PM +0100, Igor Mammedov wrote: [..] > > - replace cpuid_vendor[1.2.3] words in CPUX86State with union > > to simplify vendor property setter and pack/unpack procedures > > - add x86_cpu_vendor_word

Re: [Qemu-devel] [PATCH 00/14] migration queue

On 01/15/2013 04:18 AM, Juan Quintela wrote: > Hi > > This is the intersect of the paolo & me patches for migration thread, > please consided for inclusion. > > > arch_init.c | 6 +- > include/migration/migration.h | 3 - > include/sysemu/sysemu.h | 2 +- > migrat

Re: [Qemu-devel] [PATCH 08/14] migration: move begining stage to the migration thread

On 01/15/2013 04:18 AM, Juan Quintela wrote: In the subject line: s/begining/beginning/ > Signed-off-by: Juan Quintela > --- > include/migration/migration.h | 1 - > migration.c | 28 +++- > 2 files changed, 15 insertions(+), 14 deletions(-) > -- Er

Re: [Qemu-devel] [PATCH 03/14] use XFER_LIMIT_RATIO consistently

On 01/15/2013 04:18 AM, Juan Quintela wrote: > From: Paolo Bonzini > > Previous patch missed this case Might be worth mentioning _which_ previous patch, now that there is quite a gap in the git history. > > Signed-off-by: Paolo Bonzini > Signed-off-by: Juan Quintela > --- > migration.c | 2

Re: [Qemu-devel] [PATCH] virtio-pci: fix irqfd cleanup argument order

On 01/15/13 18:42, Michael S. Tsirkin wrote: > Order of arguments of kvm_virtio_pci_irqfd_release > got mixed up in all calls. > As a result users see assertions during cleanup. > > Reported-by: Laszlo Ersek > Signed-off-by: Michael S. Tsirkin > --- > > hw/virtio-pci.c | 6 +++--- > 1 file cha

Re: [Qemu-devel] [PATCH] PIIX3: reset the VM when the Reset Control Register's RCPU bit gets set

On 01/15/13 17:53, Paolo Bonzini wrote: > Il 15/01/2013 00:47, Laszlo Ersek ha scritto: >> @@ -442,12 +455,14 @@ static void piix3_reset(void *opaque) >> pci_conf[0xae] = 0x00; >> >> d->pic_levels = 0; >> +d->rcr = 0; >> } >> >> static int piix3_post_load(void *opaque, int versi

[Qemu-devel] [PATCH 3/3] acpi_piix4: Do not use old_portio-style callbacks

From: Hervé Poussineau Signed-off-by: Hervé Poussineau [AF: Used HWADDR_PRIx for hwaddr PIIX4_DPRINTF()] Signed-off-by: Andreas Färber --- hw/acpi_piix4.c | 92 +-- 1 Datei geändert, 41 Zeilen hinzugefügt(+), 51 Zeilen entfernt(-) diff --g

[Qemu-devel] [PATCH 2/3] xen_platform: Do not use old_portio-style callbacks

From: Hervé Poussineau Signed-off-by: Hervé Poussineau Signed-off-by: Andreas Färber --- hw/xen_platform.c | 21 ++--- 1 Datei geändert, 10 Zeilen hinzugefügt(+), 11 Zeilen entfernt(-) diff --git a/hw/xen_platform.c b/hw/xen_platform.c index ca66047..8866468 100644 --- a/hw/

[Qemu-devel] [PATCH 1/3] hw/dma.c: Fix conversion of ioport_register* to MemoryRegion

From: Julien Grall The commit 582299336879504353e60c7937fbc70fea93f3da introduced a 1-shift for some offset in DMA emulation. Before the previous commit, which converted ioport_register_* to MemoryRegion, the DMA controller registered 8 ioports with the following formula: base + ((8 + i) << d->s

[Qemu-devel] [PULL for-1.4 v2] Memory API ioport cleanups

Hello, Here's a bugfix and a few more I/O port conversions to Memory API. Please pull. Cc: Julien Grall Cc: Hervé Poussineau The following changes since commit cf7c3f0cb5a7129f57fa9e69d410d6a05031988c: virtio-9p: fix compilation error. (2013-01-14 18:52:39 -0600) are available in the git

Re: [Qemu-devel] [PULL for-1.4] Memory API ioport cleanups

Am 15.01.2013 19:31, schrieb Andreas Färber: > Hello, > > Here's a bugfix and a few more I/O port conversions to Memory API. Please > pull. Nah, please ignore, v2 coming up... > Cc: Julien Grall > Cc: Hervé Poussineau > > > The following changes since commit cf7c3f0cb5a7129f57fa9e69d410d6a0

[Qemu-devel] [PATCH 1/3] hw/dma.c: Fix conversion of ioport_register* to MemoryRegion

From: Julien Grall The commit 582299336879504353e60c7937fbc70fea93f3da introduced a 1-shift for some offset in DMA emulation. Before the previous commit, which converted ioport_register_* to MemoryRegion, the DMA controller registered 8 ioports with the following formula: base + ((8 + i) << d->s

[Qemu-devel] [PATCH 2/3] xen_platform: Do not use old_portio-style callbacks

From: Hervé Poussineau Signed-off-by: Hervé Poussineau Signed-off-by: Andreas Färber --- hw/xen_platform.c | 21 ++--- 1 Datei geändert, 10 Zeilen hinzugefügt(+), 11 Zeilen entfernt(-) diff --git a/hw/xen_platform.c b/hw/xen_platform.c index ca66047..8866468 100644 --- a/hw/

[Qemu-devel] [PATCH 3/3] acpi_piix4: Do not use old_portio-style callbacks

From: Hervé Poussineau Signed-off-by: Hervé Poussineau [AF: Used HWADDR_PRIx for hwaddr PIIX4_DPRINTF()] Signed-off-by: Andreas Färber --- hw/acpi_piix4.c | 92 +-- 1 Datei geändert, 41 Zeilen hinzugefügt(+), 51 Zeilen entfernt(-) diff --g

[Qemu-devel] [PULL for-1.4] Memory API ioport cleanups

Hello, Here's a bugfix and a few more I/O port conversions to Memory API. Please pull. Cc: Julien Grall Cc: Hervé Poussineau The following changes since commit cf7c3f0cb5a7129f57fa9e69d410d6a05031988c: virtio-9p: fix compilation error. (2013-01-14 18:52:39 -0600) are available in the git

[Qemu-devel] [PATCH 04/15] raw-posix: remember whether discard failed

From: Paolo Bonzini Avoid sending system calls repeatedly if they shall fail. This does not apply to XFS: if the filesystem-specific ioctl fails, something weird is happening. Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- block/raw-posix.c | 9 ++--- 1 file changed, 6 i

[Qemu-devel] [PATCH 3/3] configure: try pkg-config for curses

From: Vadim Evard Static linkikng against ncurses may require explicit -ltinfo. In case -lcurses and -lncurses both didn't work give pkg-config a chance. Fixes #1094786 for me. Signed-off-by: Vadim Evard Signed-off-by: Stefan Hajnoczi --- configure | 5 - 1 file changed, 4 insertions(+),

[Qemu-devel] [PATCH 2/3] qom: Make object_resolve_path_component() path argument const

From: Andreas Färber A usage with a hardcoded partial path such as object_resolve_path_component(obj, "foo") is totally valid but currently leads to a compilation error. Fix this. Signed-off-by: Andreas Färber Signed-off-by: Stefan Hajnoczi --- include/qom/object.h | 2 +- qom/object.c

Re: [Qemu-devel] 3 new x86 instructions

Richard Henderson writes: On 01/14/2013 10:14 AM, Torbjorn Granlund wrote: > Is it in such a state that grabbing that repo and building a > qemu-system-x86_64 would give me MULX support? Yes, and "-cpu Haswell" will enable the BMI extensions. A review of the code and docs reveals

[Qemu-devel] [PATCH 08/15] ide: issue discard asynchronously but serialize the pieces

From: Paolo Bonzini Now that discard can take a long time, make it asynchronous. Each LBA range entry is processed separately because discard can be an expensive operation. Signed-off-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- hw/ide/core.c | 79 +

Re: [Qemu-devel] [PATCH V3 07/11] block: export function bdrv_find_snapshot()

On 01/15/2013 03:24 AM, Wenchao Xia wrote: >>> >>> +int bdrv_snapshot_find(BlockDriverState *bs, QEMUSnapshotInfo *sn_info, >>> + const char *name) >>> +if (!strcmp(sn->id_str, name) || !strcmp(sn->name, name)) { >> >> >> This code comparison favors ids over names;

[Qemu-devel] [PATCH 3/4] rules/mak: make clean should blow away timestamp files

Using a global pattern makes it easier to clean out old generated files. Signed-off-by: Michael S. Tsirkin --- rules.mak | 5 + 1 file changed, 5 insertions(+) diff --git a/rules.mak b/rules.mak index d11a5b4..edc2552 100644 --- a/rules.mak +++ b/rules.mak @@ -88,6 +88,11 @@ config-%.h: con

Re: [Qemu-devel] [PATCH] target-i386: make x86_def_t.vendor[1, 2, 3] a string and use cpuid_vendor union in CPUX86State

On Tue, Jan 15, 2013 at 01:06:28PM +0100, Igor Mammedov wrote: > Tested on x86 host yet, I don't have bigendian host avilable right now. > > Vendor property setter takes string as vendor value but cpudefs > use uint32_t vendor[123] fields to define vendor value. It makes it > difficult to unify an

[Qemu-devel] [PATCH 14/15] win32-aio: Fix how win32_aio_process_completion() frees buffer

From: Markus Armbruster win32_aio_submit() allocates it with qemu_blockalign(), therefore it must be freed with qemu_vfree(), not g_free(). Signed-off-by: Markus Armbruster Reviewed-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- block/win32-aio.c | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PATCH] kvm: add stub for kvm_irqchip_update_msi_route

ppc64 build needs this stub to build with virtio enabled. Signed-off-by: Michael S. Tsirkin Tested-by: Andreas Färber --- kvm-all.c | 5 + 1 file changed, 5 insertions(+) diff --git a/kvm-all.c b/kvm-all.c index fc0c6e7..bac67da 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -1182,6 +1182,11 @@

[Qemu-devel] [PATCH 06/15] block: make discard asynchronous

From: Paolo Bonzini This is easy with the thread pool, because we can use s->is_xfs and s->has_discard from the worker function. QEMU has a widespread assumption that each I/O operation writes less than 2^32 bytes. This patch doesn't fix it throughout of course, but it starts correcting struct

Re: [Qemu-devel] [PATCH 05/10] xen_platform: do not use old_portio-style callbacks

On Tue, 15 Jan 2013, Andreas Färber wrote: > Stefano, > > Am 12.01.2013 17:06, schrieb Andreas Färber: > > Am 04.01.2013 22:29, schrieb Hervé Poussineau: > >> Signed-off-by: Hervé Poussineau > >> --- > >> hw/xen_platform.c | 21 ++--- > >> 1 file changed, 10 insertions(+), 11 d

[Qemu-devel] [PATCH 09/15] block: clear dirty bitmap when discarding

From: Paolo Bonzini Note that resetting bits in the dirty bitmap is done _before_ actually processing the request. Writes, instead, set bits after the request is completed. This way, when there are concurrent write and discard requests, the outcome will always be that the blocks are marked dirt

Re: [Qemu-devel] [PULL] pci,virtio

Am 15.01.2013 17:32, schrieb Michael S. Tsirkin: > On Tue, Jan 15, 2013 at 11:09:22AM +0100, Andreas Färber wrote: >> Am 13.01.2013 11:47, schrieb Michael S. Tsirkin: >>> virtio-pci: cache msix messages >> >> This broke the build with PowerKVM: >> >> LINK ppc64-softmmu/qemu-system-ppc64 >>

[Qemu-devel] [PATCH 11/15] sheepdog: clean up sd_aio_setup()

From: Liu Yuan The last two parameters of sd_aio_setup() are never used, so remove them. Cc: MORITA Kazutaka Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan Signed-off-by: Stefan Hajnoczi --- block/sheepdog.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) dif

[Qemu-devel] [PATCH 4/4] Makefile: fix make clean on libcacard

libcacard lacks a clean target. Need to fix it, meanwhile mark this target phony so it does not stop parallel make clean. Signed-off-by: Michael S. Tsirkin --- libcacard/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libcacard/Makefile b/libcacard/Makefile index 478

[Qemu-devel] [PATCH] virtio-pci: fix irqfd cleanup argument order

Order of arguments of kvm_virtio_pci_irqfd_release got mixed up in all calls. As a result users see assertions during cleanup. Reported-by: Laszlo Ersek Signed-off-by: Michael S. Tsirkin --- hw/virtio-pci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio-pci

  1   2   3   4   >