[Qemu-devel] [PATCH] pc: rename machine types

2013-01-07 Thread Gerd Hoffmann
Starting with release 1.4 we have a fully functional q35 machine type, i.e. "qemu -M q35" JustWorks[tm]. Update machine type names to reflect that: * pc-1.4 becomes piix-1.4 * q35-next becomes q35-1.4 The pc-1.3 (+older) names are maintained for compatibility reason. For the same reason the

Re: [Qemu-devel] [PATCH KVM v2 2/4] KVM: additional i8254 output fixes

2013-01-07 Thread Gleb Natapov
On Mon, Jan 07, 2013 at 06:35:47PM -0600, mmogi...@miniinfo.net wrote: > On Mon, 7 Jan 2013 14:04:03 +0200, Gleb Natapov wrote: > > On Wed, Dec 26, 2012 at 10:39:54PM -0700, Matthew Ogilvie wrote: > >> Make git_get_out() consistent with spec. Currently pit_get_out() > >> doesn't affect IRQ0, but

Re: [Qemu-devel] [PATCH KVM v2 1/4] KVM: fix i8254 IRQ0 to be normally high

2013-01-07 Thread Gleb Natapov
On Mon, Jan 07, 2013 at 06:17:22PM -0600, mmogi...@miniinfo.net wrote: > On Mon, 7 Jan 2013 11:39:18 +0200, Gleb Natapov wrote: > > On Wed, Dec 26, 2012 at 10:39:53PM -0700, Matthew Ogilvie wrote: > >> Reading the spec, it is clear that most modes normally leave the IRQ > >> output line high, and

Re: [Qemu-devel] [PATCH v3 REBASE 2/2] pseries: set no default boot order

2013-01-07 Thread Alexander Graf
On 08.01.2013, at 08:06, Avik Sil wrote: > This patch removes the default boot order for pseries machine. This allows > the machine to handle a NULL boot order in case no -boot option is provided. > Thus it helps SLOF firmware to verify if boot order is specified in command > line or not. If no b

Re: [Qemu-devel] [PATCH 07/12] virtio: introduce virtio_queue_del()

2013-01-07 Thread Michael S. Tsirkin
On Fri, Dec 28, 2012 at 06:31:59PM +0800, Jason Wang wrote: > Some device (such as virtio-net) needs the ability to destroy or re-order the > virtqueues, this patch adds a helper to do this. > > Signed-off-by: Jason Wang Actually del_queue unlike what the subject says :) > --- > hw/virtio.c |

Re: [Qemu-devel] [PATCH 11/12] virtio-net: migration support for multiqueue

2013-01-07 Thread Michael S. Tsirkin
On Fri, Dec 28, 2012 at 06:32:03PM +0800, Jason Wang wrote: > This patch add migration support for multiqueue virtio-net. The version were > bumped to 12. > > Signed-off-by: Jason Wang > --- > hw/virtio-net.c | 45 +++-- > 1 files changed, 35 insertions(

[Qemu-devel] [PATCH v3 REBASE 1/2] Make default boot order machine specific

2013-01-07 Thread Avik Sil
This patch makes default boot order machine specific instead of set globally. The default boot order can be set per machine in QEMUMachine boot_order. This also allows a machine to receive a NULL boot order when -boot isn't used and take an appropriate action accordingly. This helps machine boots f

[Qemu-devel] [PATCH v3 REBASE 0/2] Qemu boot order patch series

2013-01-07 Thread Avik Sil
Hi, This patch series allows a machine to specify if it wants a default boot order or not. Regards, Avik Changes v2 -> v3: - Implement boot_order as per Anthony's suggestion in http://lists.nongnu.org/archive/html/qemu-ppc/2012-10/msg00274.html Changes v1 -> v2: - Set default boot order for e

[Qemu-devel] [PATCH v3 REBASE 2/2] pseries: set no default boot order

2013-01-07 Thread Avik Sil
This patch removes the default boot order for pseries machine. This allows the machine to handle a NULL boot order in case no -boot option is provided. Thus it helps SLOF firmware to verify if boot order is specified in command line or not. If no boot order is provided SLOF tries to boot from the d

Re: [Qemu-devel] [PATCH KVM v2 1/4] KVM: fix i8254 IRQ0 to be normally high

2013-01-07 Thread mmogilvi
On Mon, 7 Jan 2013 11:39:18 +0200, Gleb Natapov wrote: > On Wed, Dec 26, 2012 at 10:39:53PM -0700, Matthew Ogilvie wrote: >> Reading the spec, it is clear that most modes normally leave the IRQ >> output line high, and only pulse it low to generate a leading edge. >> Especially the most commonly u

Re: [Qemu-devel] [PATCH KVM v2 2/4] KVM: additional i8254 output fixes

2013-01-07 Thread mmogilvi
On Mon, 7 Jan 2013 14:04:03 +0200, Gleb Natapov wrote: > On Wed, Dec 26, 2012 at 10:39:54PM -0700, Matthew Ogilvie wrote: >> Make git_get_out() consistent with spec. Currently pit_get_out() >> doesn't affect IRQ0, but it can be read by the guest in other ways. >> This makes it consistent with pro

Re: [Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring.

2013-01-07 Thread Michael S. Tsirkin
On Mon, Jan 07, 2013 at 04:50:44PM -0600, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Mon, Jan 07, 2013 at 03:51:04PM -0600, Anthony Liguori wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > I guess you are saying we want to add bus= option to -net nic? > >> > >> I absolu

[Qemu-devel] [PATCH] target-mips: Allow DSP access to be disabled once enabled.

2013-01-07 Thread Eric Johnson
Clear the DSP hflags at the start of compute_hflags. Otherwise access is not properly disabled once enabled. Signed-off-by: Eric Johnson --- target-mips/cpu.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-mips/cpu.h b/target-mips/cpu.h index 31602ac..5963d62 1

Re: [Qemu-devel] [PATCH] target-mips: Fix helper and tests for dot/cross-dot product instructions

2013-01-07 Thread Eric Johnson
On 01/01/2013 08:08 PM, Petar Jovanovic wrote: From: Petar Jovanovic Helper function for dpa_w_ph, dpax_w_ph, dps_w_ph and dpsx_w_ph incorrectly defines halfword vector elements as unsigned values. This results in wrong output which is not triggered in the tests as they also follow this logic.

Re: [Qemu-devel] [PATCH qom-cpu 2/7] target-mips: Clean up mips_cpu_map_tc() documentation

2013-01-07 Thread Eric Johnson
On 12/19/2012 07:31 AM, Andreas Färber wrote: This function will be touched again soon, so a good understanding of env vs. other helps. Adopt gtk-doc style. Signed-off-by: Andreas Färber --- target-mips/op_helper.c | 14 +- 1 Datei geändert, 9 Zeilen hinzugefügt(+), 5 Zeilen ent

Re: [Qemu-devel] [PATCH] target-mips: Replace macros by inline functions

2013-01-07 Thread Eric Johnson
On 01/01/2013 10:44 AM, Stefan Weil wrote: The macros RESTORE_ROUNDING_MODE and RESTORE_FLUSH_MODE silently used variable env from their callers. Using inline functions with env passed as a function argument is more transparent. This modification was proposed by Peter Maydell. Cc: Peter Maydell

Re: [Qemu-devel] [PATCH] sheepdog: implement direct write semantics

2013-01-07 Thread Liu Yuan
On 01/07/2013 09:23 PM, Kevin Wolf wrote: > No, and in theory they shouldn't have to care. > > Why do you want to handle writethrough semantics in the block driver > rather than letting qemu care for sending the right flushes? Because Sheepdog itself provide the client side cache implementation a

Re: [Qemu-devel] [PATCH] sheepdog: implement direct write semantics

2013-01-07 Thread Liu Yuan
On 01/07/2013 08:31 PM, Stefan Hajnoczi wrote: > On Sat, Jan 05, 2013 at 03:56:11PM +0800, Liu Yuan wrote: >> On 01/05/2013 01:29 PM, Liu Yuan wrote: >>> On 01/05/2013 12:40 PM, Liu Yuan wrote: On 01/05/2013 12:38 AM, Stefan Hajnoczi wrote: > Hi Yuan, > BDRV_O_NOCACHE means bypass host

Re: [Qemu-devel] [libvirt][PATCH v2 1/2] add pci-bridge controller type

2013-01-07 Thread li guang
在 2013-01-07一的 22:38 -0600,Doug Goldstein写道: > On Mon, Jan 7, 2013 at 7:58 PM, liguang wrote: > > Signed-off-by: liguang > > --- > > src/conf/device_conf.c | 12 +++- > > src/conf/device_conf.h |1 + > > src/conf/domain_conf.c |5 - > > src/conf/domain_conf.h |1 + > >

Re: [Qemu-devel] [PATCH] qga/channel-posix.c: Explicitly include string.h

2013-01-07 Thread Stefan Weil
> On Mon, Jan 07, 2013 at 05:50:14PM +, Peter Maydell wrote: >> On 7 January 2013 17:38, Stefan Weil wrote: >> > Am 07.01.2013 18:29, schrieb Peter Maydell: >> > >> >> Explicitly include string.h to avoid warnings under MacOS X/clang >> >> about implicit declarations of strerror() and strlen()

Re: [Qemu-devel] [libvirt][PATCH v2 1/2] add pci-bridge controller type

2013-01-07 Thread Doug Goldstein
On Mon, Jan 7, 2013 at 7:58 PM, liguang wrote: > Signed-off-by: liguang > --- > src/conf/device_conf.c | 12 +++- > src/conf/device_conf.h |1 + > src/conf/domain_conf.c |5 - > src/conf/domain_conf.h |1 + > 4 files changed, 17 insertions(+), 2 deletions(-) > > diff --

Re: [Qemu-devel] [PATCH 08/11] qmp: add interface query-snapshot

2013-01-07 Thread Wenchao Xia
Sorry for bad spelling, will fix them in next version. On 12/29/2012 01:45 AM, Wenchao Xia wrote: This interface now return valid internal snapshots. Signed-off-by: Wenchao Xia --- block.c | 32 qapi-schema.json | 12 2 files c

Re: [Qemu-devel] [PATCH V2 04/10] oslib-win32: add lock for time functions

2013-01-07 Thread Wenchao Xia
> Am 07.01.2013 08:28, schrieb Wenchao Xia: This patch adding lock for calling gmtime() and localtime() on windows. If no other lib linked into qemu would call those two function itself, then they are thread safe now on windows. Signed-off-by: Wenchao Xia --- oslib-win32.c | 12 ++

Re: [Qemu-devel] [PATCH 1/6] snapshot: export function in block.c

2013-01-07 Thread Wenchao Xia
于 2013-1-8 0:43, Kevin Wolf 写道: Am 17.12.2012 07:25, schrieb Wenchao Xia: This patch moves bdrv_snapshotfind from savevm.c to block.c and export it, also added bdrv_deappend in block.c. Signed-off-by: Wenchao Xia Should be two separate patches. OK, it have been split into two patches

[Qemu-devel] [libvirt][PATCH v2 1/2] add pci-bridge controller type

2013-01-07 Thread liguang
Signed-off-by: liguang --- src/conf/device_conf.c | 12 +++- src/conf/device_conf.h |1 + src/conf/domain_conf.c |5 - src/conf/domain_conf.h |1 + 4 files changed, 17 insertions(+), 2 deletions(-) diff --git a/src/conf/device_conf.c b/src/conf/device_conf.c index 7b97f

[Qemu-devel] [libvirt][PATCH v2 2/2] build command line for pci-bridge device of qemu

2013-01-07 Thread liguang
Signed-off-by: liguang --- src/qemu/qemu_command.c | 25 - 1 files changed, 20 insertions(+), 5 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 04a9512..0da32e0 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -966,

[Qemu-devel] [libvirt][PATCH v2 0/2] add pci-bridge support

2013-01-07 Thread liguang
Now, it's impossible to arrange devices into multi-pci-bus, for example: libvirt will complain about "bus != 0", fortunately, qemu supports pci-to-pci bridge, if we want to use multi-pci-bus, we can define 2 pci bridge controllers, then attach 1 to the other as

Re: [Qemu-devel] [Xen-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and cpu_ioreq_move

2013-01-07 Thread Xu, Dongxiao
> -Original Message- > From: Xu, Dongxiao > Sent: Tuesday, December 11, 2012 1:50 PM > To: Ian Jackson; Ian Campbell > Cc: Stefano Stabellini; xen-de...@lists.xensource.com; > qemu-devel@nongnu.org > Subject: RE: [Xen-devel] [PATCH 0/2] QEMU/xen: simplify cpu_ioreq_pio and > cpu_ioreq_move

[Qemu-devel] [PATCH v4 2/2] Add GE IP-Octal 232 IndustryPack emulation

2013-01-07 Thread Alberto Garcia
The GE IP-Octal 232 is an IndustryPack module that implements eight RS-232 serial ports, each one of which can be redirected to a character device in the host. Signed-off-by: Alberto Garcia --- hw/Makefile.objs |2 +- hw/ipoctal.c | 614 ++

[Qemu-devel] [PATCH v4 1/2] Add TEWS TPCI200 IndustryPack emulation

2013-01-07 Thread Alberto Garcia
The TPCI200 is a PCI board that supports up to 4 IndustryPack modules. A new bus type called 'IndustryPack' has been created so any compatible module can be attached to this board. Signed-off-by: Alberto Garcia --- default-configs/pci.mak |1 + hw/Makefile.objs|3 + hw/ipack.c

[Qemu-devel] [PATCH v4 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2013-01-07 Thread Alberto Garcia
Rebased (and tested) against the current master as requested. On Mon, Jan 07, 2013 at 02:32:41PM -0600, Anthony Liguori wrote: > Alberto Garcia writes: > > > Ping, > > > > Here's a QEMU image (124 MB) of a Debian system with the tpci200 and > > ipoctal drivers, in case you want to try them out:

Re: [Qemu-devel] [PATCH 2/3] vnc: added initial websocket protocol support

2013-01-07 Thread Anthony Liguori
Tim Hardeck writes: > Hi Anthony, > > thanks for your feedback. > > On Mon, 2013-01-07 at 13:52 -0600, Anthony Liguori wrote: >> Tim Hardeck writes: > > +void vncws_handshake_read(void *opaque) >> > +{ >> > +VncState *vs = opaque; >> > +long ret; >> > +buffer_reserve(&vs->ws_input, 4

Re: [Qemu-devel] [SeaBIOS] SeaBIOS release for QEMU 1.3 (was Re: [PATCH] esp: enable busmaster)

2013-01-07 Thread Brad Smith
On Mon, Jan 07, 2013 at 06:56:00PM -0500, Kevin O'Connor wrote: > On Mon, Jan 07, 2013 at 06:51:03PM -0500, Brad Smith wrote: > > On Mon, Jan 07, 2013 at 06:34:01PM -0500, Kevin O'Connor wrote: > > > On Mon, Jan 07, 2013 at 03:29:33PM +0100, Gerd Hoffmann wrote: > > > > Hi, > > > > > > > > >> Ke

[Qemu-devel] buildbot failure in qemu on block_mingw32

2013-01-07 Thread qemu
The Buildbot has detected a new failure on builder block_mingw32 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/block_mingw32/builds/439 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 Build Reason: The

Re: [Qemu-devel] [PATCH 2/3] vnc: added initial websocket protocol support

2013-01-07 Thread Tim Hardeck
Hi Anthony, thanks for your feedback. On Mon, 2013-01-07 at 13:52 -0600, Anthony Liguori wrote: > Tim Hardeck writes: > > +void vncws_handshake_read(void *opaque) > > +{ > > +VncState *vs = opaque; > > +long ret; > > +buffer_reserve(&vs->ws_input, 4096); > > +ret = vnc_client_rea

Re: [Qemu-devel] [SeaBIOS] SeaBIOS release for QEMU 1.3 (was Re: [PATCH] esp: enable busmaster)

2013-01-07 Thread Kevin O'Connor
On Mon, Jan 07, 2013 at 06:51:03PM -0500, Brad Smith wrote: > On Mon, Jan 07, 2013 at 06:34:01PM -0500, Kevin O'Connor wrote: > > On Mon, Jan 07, 2013 at 03:29:33PM +0100, Gerd Hoffmann wrote: > > > Hi, > > > > > > >> Kevin, are you okay with tagging SeaBIOS master as 1.7.2 one of these > > > >>

Re: [Qemu-devel] [SeaBIOS] SeaBIOS release for QEMU 1.3 (was Re: [PATCH] esp: enable busmaster)

2013-01-07 Thread Brad Smith
On Mon, Jan 07, 2013 at 06:34:01PM -0500, Kevin O'Connor wrote: > On Mon, Jan 07, 2013 at 03:29:33PM +0100, Gerd Hoffmann wrote: > > Hi, > > > > >> Kevin, are you okay with tagging SeaBIOS master as 1.7.2 one of these > > >> days? Other opinions? > > > > > > A new release can be produced if de

Re: [Qemu-devel] [SeaBIOS] SeaBIOS release for QEMU 1.3 (was Re: [PATCH] esp: enable busmaster)

2013-01-07 Thread Kevin O'Connor
On Mon, Jan 07, 2013 at 03:29:33PM +0100, Gerd Hoffmann wrote: > Hi, > > >> Kevin, are you okay with tagging SeaBIOS master as 1.7.2 one of these > >> days? Other opinions? > > > > A new release can be produced if desired. Given that there isn't much > > new since 1.7.1 I too would prefer to

[Qemu-devel] [PATCH] gdbstub: Implement "Xfer:spaces" requests. This is a part of Codebench IDE integration.

2013-01-07 Thread Alex Rozenman
Signed-off-by: Alex Rozenman --- gdbstub.c | 113 + 1 file changed, 113 insertions(+) diff --git a/gdbstub.c b/gdbstub.c index a8dd437..564bde1 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -1839,6 +1839,90 @@ static const char *get_featur

[Qemu-devel] [PATCH] Add libcacard/trace/generated-tracers.c to .gitignore

2013-01-07 Thread Alex Rozenman
Signed-off-by: Alex Rozenman --- .gitignore |1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 0e38169..9085f6d 100644 --- a/.gitignore +++ b/.gitignore @@ -7,6 +7,7 @@ trace/generated-tracers.h trace/generated-tracers.c trace/generated-tracers-dtrace.h trace/

Re: [Qemu-devel] [PATCH] linux-user,alpha: correct select()

2013-01-07 Thread Richard Henderson
On 01/07/2013 02:38 PM, Laurent Vivier wrote: > -#if defined(TARGET_NR_select) && !defined(TARGET_S390X) && > !defined(TARGET_S390) > +#if defined(TARGET_NR_select) && !defined(TARGET_S390X) && \ > + !defined(TARGET_S390) && \ > + !de

Re: [Qemu-devel] [PATCH] linux-user, alpha: l_type of fcntl() flock differs

2013-01-07 Thread Richard Henderson
On 01/07/2013 02:24 PM, Laurent Vivier wrote: > +static short target_to_host_flock_type(short type) > +{ > +switch (type) { > +case TARGET_F_RDLCK: > +return F_RDLCK; > +case TARGET_F_WRLCK: > +return F_WRLCK; > +case TARGET_F_UNLCK: > +return F_UNLCK; > +

Re: [Qemu-devel] [RESEND PATCH] pci-assign: Enable MSIX on device to match guest

2013-01-07 Thread Marcelo Tosatti
On Mon, Jan 07, 2013 at 06:01:19PM +0200, Michael S. Tsirkin wrote: > On Sun, Jan 06, 2013 at 09:30:31PM -0700, Alex Williamson wrote: > > When a guest enables MSIX on a device we evaluate the MSIX vector > > table, typically find no unmasked vectors and don't switch the device > > to MSIX mode. T

Re: [Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring.

2013-01-07 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Mon, Jan 07, 2013 at 03:51:04PM -0600, Anthony Liguori wrote: >> "Michael S. Tsirkin" writes: >> >> > I guess you are saying we want to add bus= option to -net nic? >> >> I absolutely wouldn't object to that. >> >> But I can think of better solutions too. Li

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Anthony Liguori
Andreas Färber writes: > Am 07.01.2013 23:20, schrieb Peter Maydell: >> On 7 January 2013 22:10, Andreas Färber wrote: >>> Am 07.01.2013 21:16, schrieb Peter Maydell: On 7 January 2013 20:12, Anthony Liguori wrote: > Peter Maydell writes: >> It seems to me like arbitrarily allowin

[Qemu-devel] [PATCH v3 4/6] tests: Add tmp105 qtest test case

2013-01-07 Thread Andreas Färber
Exercise all four commands of the TMP105, testing for an issue in the I2C TX path. The test case uses the N800's OMAP I2C and is the first for ARM. Signed-off-by: Andreas Färber --- tests/Makefile |3 ++ tests/tmp105-test.c | 76 +++ 2

[Qemu-devel] [PATCH v3 5/6] tmp105: QOM'ify

2013-01-07 Thread Andreas Färber
Introduce TYPE_ constant and cast macro. Move the state struct to the new header to allow for future embedding. Signed-off-by: Andreas Färber Reviewed-by: Anthony Liguori --- hw/tmp105.c | 38 +- hw/tmp105.h | 27 +++ 2 Dateien geä

[Qemu-devel] [PATCH v3 1/6] libqtest: Prepare I2C libqos

2013-01-07 Thread Andreas Färber
This adds a simple I2C API and a driver implementation for omap_i2c. Signed-off-by: Andreas Färber Reviewed-by: Anthony Liguori --- tests/Makefile |1 + tests/libi2c-omap.c | 166 +++ tests/libi2c.c | 22 +++ tests/libi2c.h

[Qemu-devel] [PATCH v3 2/6] tmp105: Split out I2C message constants from header

2013-01-07 Thread Andreas Färber
Allows value sharing with qtest. Signed-off-by: Andreas Färber Reviewed-by: Anthony Liguori --- hw/tmp105.h | 34 +- hw/tmp105_regs.h | 50 ++ 2 Dateien geändert, 51 Zeilen hinzugefügt(+), 33 Zeilen entfern

[Qemu-devel] [PATCH v3 3/6] tmp105: Fix I2C protocol bug

2013-01-07 Thread Andreas Färber
An early length postincrement in the TMP105's I2C TX path led to transfers of more than one byte to place the second byte in the third byte's place within the buffer and the third byte to get discarded. Fix this by explictly incrementing the length after the checks but before the callback is calle

[Qemu-devel] [PATCH v3 6/6] tmp105: Add temperature QOM property

2013-01-07 Thread Andreas Färber
This obsoletes tmp105_set() and allows for better error handling. Signed-off-by: Andreas Färber --- hw/tmp105.c | 34 +- hw/tmp105.h | 15 --- 2 Dateien geändert, 29 Zeilen hinzugefügt(+), 20 Zeilen entfernt(-) diff --git a/hw/tmp105.c b/hw/tmp105

[Qemu-devel] [PATCH v3 0/6] I2C libqos and tmp105 qtest support

2013-01-07 Thread Andreas Färber
Hello Anthony, Here's a rebased version of plus a minor patch cleanup. Please review and apply. Regards, Andreas v2 -> v3: * Alex' tmp105.h patch was applied. * Rebased onto header reorganization. * Rebased onto introduction of gcov support. * Switched order of test case and bugfix to keep make

[Qemu-devel] [PATCH] linux-user,alpha: correct select()

2013-01-07 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- linux-user/syscall.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 2232bb8..76bafff 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -6249,7 +6249,9 @@ abi_long do_

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Andreas Färber
Am 07.01.2013 23:20, schrieb Peter Maydell: > On 7 January 2013 22:10, Andreas Färber wrote: >> Am 07.01.2013 21:16, schrieb Peter Maydell: >>> On 7 January 2013 20:12, Anthony Liguori wrote: Peter Maydell writes: > It seems to me like arbitrarily allowing the monitor to construct >

Re: [Qemu-devel] [PATCH 3/3] qga: add guest-set-time command

2013-01-07 Thread Eric Blake
On 01/06/2013 03:07 AM, Lei Li wrote: > Signed-off-by: Lei Li > --- > qga/commands-posix.c | 57 > ++ > qga/qapi-schema.json | 32 > 2 files changed, 89 insertions(+), 0 deletions(-) > > diff --git a/qga/commands-p

[Qemu-devel] [PATCH] linux-user, alpha: l_type of fcntl() flock differs

2013-01-07 Thread Laurent Vivier
on alpha, F_RDLCK, F_WRLCK, F_UNLCK, F_EXLCK, F_SHLCK are not the standard ones. This patch allows to run "dpkg" (database lock). Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 50 +++-- linux-user/syscall_defs.h | 18

[Qemu-devel] [PATCH 3/3] vfio-pci: [NOT FOR COMMIT] Hack around HD5450 I/O port backdoor

2013-01-07 Thread Alex Williamson
This is a hack specific to my system which I haven't even attempted to generalize yet. The ATI/AMD Radeon HD5450 VGA BIOS appears to have a backdoor to determine the physical address of the device. It reads a value matching the top byte of the I/O Port BAR from a register in VGA I/O port space th

[Qemu-devel] [PATCH 2/3] vfio-pci: [NOT FOR COMMIT] Add support for VGA MMIO and I/O port access

2013-01-07 Thread Alex Williamson
With this, some VGA cards can make it through VGA BIOS init, but I have yet to see one sync the monitor in VGA text mode. Only tested with -vga none. This adds a new option to vfio-pci, vga=on, which enables legacy VGA ranges. Signed-off-by: Alex Williamson --- hw/vfio_pci.c | 173 +++

[Qemu-devel] [PATCH 1/3] qemu: [NOT FOR COMMIT] Update linux headers for vfio VGA

2013-01-07 Thread Alex Williamson
Signed-off-by: Alex Williamson --- linux-headers/asm-powerpc/kvm.h | 86 ++ linux-headers/asm-powerpc/kvm_para.h | 13 +++-- linux-headers/linux/kvm.h| 21 ++-- linux-headers/linux/kvm_para.h |6 +- linux-headers/linux/vfio.h

[Qemu-devel] [PATCH 0/3] Towards vfio-base VGA device assignment

2013-01-07 Thread Alex Williamson
This is the companion series to the vfio-pci kernel series for VGA support. Combined, these don't do as much as you'd hope. Patch 1 is simpy a header update for the matching vfio kernel changes. Patch 2 is the meat of the changes, enabling vfio-pci to claim access to VGA ranges and pass them thro

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Peter Maydell
On 7 January 2013 22:10, Andreas Färber wrote: > Am 07.01.2013 21:16, schrieb Peter Maydell: >> On 7 January 2013 20:12, Anthony Liguori wrote: >>> Peter Maydell writes: It seems to me like arbitrarily allowing the monitor to construct no-user devices isn't really the right way to atta

Re: [Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring.

2013-01-07 Thread Michael S. Tsirkin
On Mon, Jan 07, 2013 at 03:24:14PM -0600, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Mon, Jan 07, 2013 at 02:12:23PM -0600, Anthony Liguori wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > On Tue, Dec 18, 2012 at 12:30:20PM +0100, KONRAD Frédéric wrote: > >> >> On 18/12/

Re: [Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring.

2013-01-07 Thread Michael S. Tsirkin
On Mon, Jan 07, 2013 at 03:51:04PM -0600, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > I guess you are saying we want to add bus= option to -net nic? > > I absolutely wouldn't object to that. > > But I can think of better solutions too. Like: > > -virtio-net ... > > Regard

Re: [Qemu-devel] [PATCH] qga/channel-posix.c: Explicitly include string.h

2013-01-07 Thread Eduardo Habkost
On Mon, Jan 07, 2013 at 05:50:14PM +, Peter Maydell wrote: > On 7 January 2013 17:38, Stefan Weil wrote: > > Am 07.01.2013 18:29, schrieb Peter Maydell: > > > >> Explicitly include string.h to avoid warnings under MacOS X/clang > >> about implicit declarations of strerror() and strlen(). > >

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Andreas Färber
Am 07.01.2013 21:16, schrieb Peter Maydell: > On 7 January 2013 20:12, Anthony Liguori wrote: >> Peter Maydell writes: >>> It seems to me like arbitrarily allowing the monitor to construct >>> no-user devices isn't really the right way to attack the problem >>> of "allow complete machine construc

[Qemu-devel] [PATCH] Replace remaining gmtime, localtime by gmtime_r, localtime_r

2013-01-07 Thread Stefan Weil
This allows removing of MinGW specific code and improves reentrancy for POSIX hosts. Signed-off-by: Stefan Weil --- block.c | 10 -- block/vvfat.c |4 hw/omap1.c|2 +- vl.c |8 +++- 4 files changed, 4 insertions(+), 20 deletions(-) diff --git a/

Re: [Qemu-devel] [PATCH 2/3] qga: add guest-get-time command

2013-01-07 Thread Eric Blake
On 01/06/2013 03:06 AM, Lei Li wrote: > Signed-off-by: Lei Li > --- > qga/commands-posix.c | 12 > qga/qapi-schema.json | 17 + > 2 files changed, 29 insertions(+), 0 deletions(-) > > +++ b/qga/qapi-schema.json > @@ -100,6 +100,23 @@ > 'utc-offset'

Re: [Qemu-devel] [PATCH 19/61] virtio-net : cleanup : use QOM cast.

2013-01-07 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Mon, Jan 07, 2013 at 03:17:18PM -0600, Anthony Liguori wrote: >> "Michael S. Tsirkin" writes: >> >> > On Mon, Jan 07, 2013 at 07:40:32PM +0100, fred.kon...@greensocs.com wrote: >> >> @@ -130,7 +124,9 @@ static void virtio_net_set_status(struct VirtIODevice >>

Re: [Qemu-devel] [PATCH 1/3] qga: add support to get host time

2013-01-07 Thread Eric Blake
On 01/06/2013 03:06 AM, Lei Li wrote: > Signed-off-by: Lei Li > --- > qga/commands-posix.c | 18 ++ > qga/qapi-schema.json | 17 + > 2 files changed, 35 insertions(+), 0 deletions(-) > > diff --git a/qga/commands-posix.c b/qga/commands-posix.c > index a657201.

Re: [Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring.

2013-01-07 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > I guess you are saying we want to add bus= option to -net nic? I absolutely wouldn't object to that. But I can think of better solutions too. Like: -virtio-net ... Regards, Anthony Liguori > >> > >> >> > >> >> > -- >> >> > MST

Re: [Qemu-devel] [PATCH][v2] linux-user: correct reboot()

2013-01-07 Thread Peter Maydell
On 7 January 2013 21:40, Laurent Vivier wrote: > According to man reboot(2), the 4th argument is only used with > LINUX_REBOOT_CMD_RESTART2. In other cases, trying to convert > the value can generate EFAULT. > > Signed-off-by: Laurent Vivier Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Anthony Liguori
Christian Borntraeger writes: > On 07/01/13 20:32, Anthony Liguori wrote: >> Christian Borntraeger writes: >> >>> since >>> >>> commit 18b6dade8c0799c48f5c5e124b8c407cd5e22e96 >>> qdev: refactor device creation to allow bus_info to be set only in class >>> >>> A user can specify a device that i

[Qemu-devel] [PATCH][v2] linux-user: correct reboot()

2013-01-07 Thread Laurent Vivier
According to man reboot(2), the 4th argument is only used with LINUX_REBOOT_CMD_RESTART2. In other cases, trying to convert the value can generate EFAULT. Signed-off-by: Laurent Vivier --- v2: Set arg4 to NULL when arg3 != LINUX_REBOOT_CMD_RESTART2 use get_errno() check patch checkpatch.p

Re: [Qemu-devel] [PATCH] readline: avoid memcpy() of overlapping regions

2013-01-07 Thread Richard Henderson
On 01/07/2013 12:38 PM, Nickolai Zeldovich wrote: > memcpy() for overlapping regions is undefined behavior; use memmove() > instead in readline_hist_add(). > > Signed-off-by: Nickolai Zeldovich > --- > readline.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) This probably shoul

Re: [Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring.

2013-01-07 Thread Michael S. Tsirkin
On Mon, Jan 07, 2013 at 03:24:14PM -0600, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Mon, Jan 07, 2013 at 02:12:23PM -0600, Anthony Liguori wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > On Tue, Dec 18, 2012 at 12:30:20PM +0100, KONRAD Frédéric wrote: > >> >> On 18/12/

Re: [Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring.

2013-01-07 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Mon, Jan 07, 2013 at 08:02:32PM +, Peter Maydell wrote: >> On 7 January 2013 19:58, Michael S. Tsirkin wrote: >> > On Tue, Dec 18, 2012 at 12:30:20PM +0100, KONRAD Frédéric wrote: >> >> The modifications will be transparent to the user, as we will keep >> >>

Re: [Qemu-devel] [PATCH 19/61] virtio-net : cleanup : use QOM cast.

2013-01-07 Thread Michael S. Tsirkin
On Mon, Jan 07, 2013 at 03:17:18PM -0600, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Mon, Jan 07, 2013 at 07:40:32PM +0100, fred.kon...@greensocs.com wrote: > >> @@ -130,7 +124,9 @@ static void virtio_net_set_status(struct VirtIODevice > >> *vdev, uint8_t status) > >> > >>

Re: [Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring.

2013-01-07 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Mon, Jan 07, 2013 at 02:12:23PM -0600, Anthony Liguori wrote: >> "Michael S. Tsirkin" writes: >> >> > On Tue, Dec 18, 2012 at 12:30:20PM +0100, KONRAD Frédéric wrote: >> >> On 18/12/2012 12:01, Michael S. Tsirkin wrote: >> >> >On Tue, Dec 18, 2012 at 10:33:37AM

Re: [Qemu-devel] [RFC PATCH 0/4] MSI affinity for assigned devices

2013-01-07 Thread Krishna J
> > 45: 1 0 3377 11194 PCI-MSI-edge > > FPGA_DEV> > RES: 14 20 21 3398 Rescheduling > > interrupts---> Many RES Interrtups!! > > I don't know, but I'll fix the line wrap for anyone else that wants to > have a look. The

Re: [Qemu-devel] [PATCH 08/11] qmp: add interface query-snapshot

2013-01-07 Thread Eric Blake
On 12/29/2012 01:45 AM, Wenchao Xia wrote: > This interface now return valid internal snapshots. > > Signed-off-by: Wenchao Xia > --- > block.c | 32 > qapi-schema.json | 12 > 2 files changed, 44 insertions(+), 0 deletions(-) > > ++

[Qemu-devel] [PATCH] savevm: Remove MinGW specific code which is no longer needed

2013-01-07 Thread Stefan Weil
QEMU provides a portable function qemu_gettimeofday instead of gettimeofday and also an implementation of localtime_r for MinGW. Signed-off-by: Stefan Weil --- savevm.c | 30 ++ 1 file changed, 2 insertions(+), 28 deletions(-) diff --git a/savevm.c b/savevm.c index

Re: [Qemu-devel] [PATCH v3 0/2] Qemu boot order patch series

2013-01-07 Thread Anthony Liguori
Alexander Graf writes: > On 07.01.2013, at 21:22, Anthony Liguori wrote: > >> Alexander Graf writes: >> >>> On 19.12.2012, at 19:16, Avik Sil wrote: >>> Hi, This patch series allows a machine to specify if it wants a default boot order or not. >>> >>> I like the patch se

Re: [Qemu-devel] [PATCH 19/61] virtio-net : cleanup : use QOM cast.

2013-01-07 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Mon, Jan 07, 2013 at 07:40:32PM +0100, fred.kon...@greensocs.com wrote: >> @@ -130,7 +124,9 @@ static void virtio_net_set_status(struct VirtIODevice >> *vdev, uint8_t status) >> >> static void virtio_net_set_link_status(NetClientState *nc) >> { >> -VirtI

Re: [Qemu-devel] [PATCH 19/61] virtio-net : cleanup : use QOM cast.

2013-01-07 Thread Michael S. Tsirkin
On Mon, Jan 07, 2013 at 07:40:32PM +0100, fred.kon...@greensocs.com wrote: > @@ -130,7 +124,9 @@ static void virtio_net_set_status(struct VirtIODevice > *vdev, uint8_t status) > > static void virtio_net_set_link_status(NetClientState *nc) > { > -VirtIONet *n = DO_UPCAST(NICState, nc, nc)->

Re: [Qemu-devel] [PATCH v3 0/2] Qemu boot order patch series

2013-01-07 Thread Alexander Graf
On 07.01.2013, at 21:22, Anthony Liguori wrote: > Alexander Graf writes: > >> On 19.12.2012, at 19:16, Avik Sil wrote: >> >>> Hi, >>> >>> This patch series allows a machine to specify if it wants a default boot >>> order or not. >> >> I like the patch set. Anthony, please (n)ack :). > > Re

Re: [Qemu-devel] [PATCH] linux-user: correct reboot()

2013-01-07 Thread Peter Maydell
On 7 January 2013 20:51, Laurent Vivier wrote: > Le lundi 07 janvier 2013 à 20:42 +, Peter Maydell a écrit : >> On 7 January 2013 20:30, Laurent Vivier wrote: >> > + ret = reboot(arg1, arg2, arg3, (void*)(unsigned long)arg4); >> >> I don't think we should pass arg4 in this case. It'

Re: [Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring.

2013-01-07 Thread Michael S. Tsirkin
On Mon, Jan 07, 2013 at 02:12:23PM -0600, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > On Tue, Dec 18, 2012 at 12:30:20PM +0100, KONRAD Frédéric wrote: > >> On 18/12/2012 12:01, Michael S. Tsirkin wrote: > >> >On Tue, Dec 18, 2012 at 10:33:37AM +, Peter Maydell wrote: > >> >>On

Re: [Qemu-devel] [RFC PATCH 0/4] MSI affinity for assigned devices

2013-01-07 Thread Alex Williamson
On Mon, 2013-01-07 at 20:14 +, Krishna J wrote: > Hi Alex, > > MSI routing updates aren't currently handled by pci-assign or > > vfio-pci (when using KVM acceleration), which means that trying to > > set interrupt SMP affinity in the guest has no effect unless MSI is > > completely disabled and

Re: [Qemu-devel] [PATCH] linux-user: correct reboot()

2013-01-07 Thread Laurent Vivier
Le lundi 07 janvier 2013 à 20:42 +, Peter Maydell a écrit : > On 7 January 2013 20:30, Laurent Vivier wrote: > > According to man reboot(2), the 4th argument is only used with > > LINUX_REBOOT_CMD_RESTART2. In other cases, trying to convert > > the value can generate EFAULT. > > > > Signed-off

Re: [Qemu-devel] [PATCH 00/15] qdev: make reset semantics more clear and consistent, reset qbuses under virtio devices

2013-01-07 Thread Anthony Liguori
Peter Maydell writes: > On 7 January 2013 20:20, Anthony Liguori wrote: >> Peter Maydell writes: >>> On 7 January 2013 19:10, Anthony Liguori wrote: I think reset really ought to just be a bus level concept with individual implementations for each bus. >>> >>> I'm not sure I really a

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Anthony Liguori
Peter Maydell writes: > On 7 January 2013 20:12, Anthony Liguori wrote: >> Peter Maydell writes: >>> It seems to me like arbitrarily allowing the monitor to construct >>> no-user devices isn't really the right way to attack the problem >>> of "allow complete machine construction by management t

Re: [Qemu-devel] [RFC PATCH v6 0/6] Virtio refactoring.

2013-01-07 Thread Michael S. Tsirkin
On Mon, Jan 07, 2013 at 08:02:32PM +, Peter Maydell wrote: > On 7 January 2013 19:58, Michael S. Tsirkin wrote: > > On Tue, Dec 18, 2012 at 12:30:20PM +0100, KONRAD Frédéric wrote: > >> The modifications will be transparent to the user, as we will keep > >> virtio-x-pci devices. > > > > Then w

Re: [Qemu-devel] [PATCH] linux-user: correct reboot()

2013-01-07 Thread Peter Maydell
On 7 January 2013 20:30, Laurent Vivier wrote: > According to man reboot(2), the 4th argument is only used with > LINUX_REBOOT_CMD_RESTART2. In other cases, trying to convert > the value can generate EFAULT. > > Signed-off-by: Laurent Vivier > --- > linux-user/syscall.c | 14 ++ >

Re: [Qemu-devel] [PATCH] qdev: obey no_user

2013-01-07 Thread Christian Borntraeger
On 07/01/13 20:32, Anthony Liguori wrote: > Christian Borntraeger writes: > >> since >> >> commit 18b6dade8c0799c48f5c5e124b8c407cd5e22e96 >> qdev: refactor device creation to allow bus_info to be set only in class >> >> A user can specify a device that is no_user. >> For example on my i386 box,

Re: [Qemu-devel] [PATCH 07/11] qdev: add reference for the bus while it is referred to by the DeviceState

2013-01-07 Thread Anthony Liguori
Paolo Bonzini writes: > Now that the unparent callbacks are complete, we can correctly account > more missing references. > > Signed-off-by: Paolo Bonzini > --- > hw/qdev.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/qdev.c b/hw/qdev.c > index d7f1545..62b6c14 100644 > --- a/

[Qemu-devel] [PATCH] readline: avoid memcpy() of overlapping regions

2013-01-07 Thread Nickolai Zeldovich
memcpy() for overlapping regions is undefined behavior; use memmove() instead in readline_hist_add(). Signed-off-by: Nickolai Zeldovich --- readline.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/readline.c b/readline.c index 5fc9643..aeccc7b 100644 --- a/readline.c

[Qemu-devel] [PATCH 29/61] virtio-scsi : cleanup : use QOM casts.

2013-01-07 Thread fred . konrad
From: KONRAD Frederic As the virtio-scsi-pci and virtio-scsi-s390 are switched to the new API, we can use QOM casts. This shouldn't been applyied before virtio-scsi-pci and virtio-scsi-s390 refactoring as their VirtIODevice were not a QOM object. Signed-off-by: KONRAD Frederic --- hw/virtio-sc

[Qemu-devel] [PATCH 20/61] virtio-net : cleanup : init and exit function.

2013-01-07 Thread fred . konrad
From: KONRAD Frederic This remove old init and exit function as they are no longer needed. This shouldn't been applyied before virtio-net-pci and virtio-net-s390 refactoring. Signed-off-by: KONRAD Frederic --- hw/virtio-net.c | 95 - 1 fi

Re: [Qemu-devel] Ping [PATCH v3 0/2] Add TPCI200 and IP-Octal 232 IndustryPack emulation

2013-01-07 Thread Anthony Liguori
Alberto Garcia writes: > Ping, > > Here's a QEMU image (124 MB) of a Debian system with the tpci200 and > ipoctal drivers, in case you want to try them out: Please rebase and top-post. Don't send the new series as a response to a previous thread. Regards, Anthony Liguori > > http://dl.dropbo

Re: [Qemu-devel] [PATCH 00/11] qdev: correct reference counting

2013-01-07 Thread Anthony Liguori
Paolo Bonzini writes: > This series makes the ref_count field of device and bus objects actually > match the number of references that the objects have. Once this is done, > qdev_free and qbus_free are equivalent to simply object_unparent, and > object_delete can go. > > Patches 1-3 fix some war

  1   2   3   4   >