Re: [Qemu-devel] [Resend][Seabios PATCH] don't boot from un-selected devices

2012-12-18 Thread Gerd Hoffmann
On 12/19/12 08:24, Amos Kong wrote: > Current seabios will try to boot from selected devices first, > if they are all failed, seabios will also try to boot from > un-selected devices. > > For example: > @ qemu-kvm -boot order=n,menu=on ... > > Guest will boot from network first, if it's failed, g

Re: [Qemu-devel] [RFC PATCH v4 00/30] ACPI memory hotplug

2012-12-18 Thread Gerd Hoffmann
Hi, > - multiple memory buses can be registered. Memory buses of the real hw/chipset > or a paravirtual memory bus can be added. IIRC q35 supports memory hotplug natively (picked up in some discussion). Is that correct? What does the code emulate? It doesn't look like it emulates q35 memor

[Qemu-devel] [Resend][Seabios PATCH] don't boot from un-selected devices

2012-12-18 Thread Amos Kong
Current seabios will try to boot from selected devices first, if they are all failed, seabios will also try to boot from un-selected devices. For example: @ qemu-kvm -boot order=n,menu=on ... Guest will boot from network first, if it's failed, guest will try to boot from other un-selected devices

[Qemu-devel] [PATCH] don't boot from un-selected devices

2012-12-18 Thread Amos Kong
Current seabios will try to boot from selected devices first, if they are all failed, seabios will also try to boot from un-selected devices. For example: @ qemu-kvm -boot order=n,menu=on ... Guest will boot from network first, if it's failed, guest will try to boot from other un-selected devices

Re: [Qemu-devel] (bisected): Is mips-user broken on 64bit host since v1.1?

2012-12-18 Thread Michael Tokarev
On 19.12.2012 01:33, Alexander Graf wrote: > On 18.12.2012, at 20:05, Michael Tokarev wrote: >>> # chroot mipsroot /bin/bash >>> qemu: uncaught target signal 11 (Segmentation fault) - core dumped >> commit 288e65b9eea0c9b3cbe21be46f3e24e4e8b2a090 >> Author: Alexander Graf >> Date: Wed Dec 14 0

Re: [Qemu-devel] [PULL 00/45] Include reorganization + PCI patch queue

2012-12-18 Thread Michael S. Tsirkin
On Tue, Dec 18, 2012 at 06:13:11PM -0600, Anthony Liguori wrote: > Paolo Bonzini writes: > > > And how does it conflicts with Alex's ppc pull request? It is a fast > > forward from origin/master as of now (commit a8a826a, exec: refactor > > cpu_restore_state, 2012-12-04), and that includes Alex's

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-18 Thread Wenchao Xia
于 2012-12-19 12:55, Dietmar Maurer 写道: OK, I think underlying storage is another level of issue, just wondering what this patch miss to stop you use external tool, did you called a LVM/nexenta C API in previous patch? The trick is to do thing step by step 1.) save state 2.) create internal

Re: [Qemu-devel] [PATCH 1/3] balloon: drop old stats code & API

2012-12-18 Thread Dietmar Maurer
> Libvirt has been using it when available (although reluctantly, as it risks > hanging on an uncooperative guest); and while libvirt can be patched to call 6 > QOM commands in a row to query six different QOM stats, I still think it > would be nicer to add a command that provides all the stats at

Re: [Qemu-devel] [RFC 3/3] virtio-balloon: add auto-ballooning support

2012-12-18 Thread Anton Vorontsov
Hello Luiz, On Tue, Dec 18, 2012 at 06:16:55PM -0200, Luiz Capitulino wrote: > The auto-ballooning feature automatically performs balloon inflate > or deflate based on host and guest memory pressure. This can help to > avoid swapping or worse in both, host and guest. > > Auto-ballooning has a hos

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-18 Thread Dietmar Maurer
> OK, I think underlying storage is another level of issue, just wondering > what > this patch miss to stop you use external tool, did you called a LVM/nexenta C > API in previous patch? The trick is to do thing step by step 1.) save state 2.) create internal snapshots 3.) call external tools

Re: [Qemu-devel] [Qemu-ppc] [PATCH 11/13] pseries: Fixes and enhancements to L1 cache properties

2012-12-18 Thread David Gibson
On Tue, Dec 18, 2012 at 12:49:02AM +0100, Alexander Graf wrote: > > On 18.12.2012, at 00:00, David Gibson wrote: > > > On Mon, Dec 17, 2012 at 11:10:12AM +0100, Alexander Graf wrote: > >> > >> > >> On 17.12.2012, at 03:32, David Gibson wrote: > >> > >>> On Thu, Dec 13, 2012 at 01:50:25PM +010

[Qemu-devel] [Bug 1091766] Re: Physical host crash with Mellanox IB PCI passthrough

2012-12-18 Thread Alex Williamson
If the above pci-assign patch works, please also try this vfio-pci version as it requires a slightly different implementation. Also against qemu 1.3. Thanks. ** Attachment added: "vfio-pci: Make host MSI-X enable track guest" https://bugs.launchpad.net/qemu/+bug/1091766/+attachment/3463505/+f

Re: [Qemu-devel] [PATCH qom-cpu 3/4] target-ppc: Slim conversion of model definitions to QOM subclasses

2012-12-18 Thread Andreas Färber
Am 18.12.2012 08:53, schrieb Andreas Färber: > +static gint ppc_cpu_compare_class_name(gconstpointer a, gconstpointer b) > +{ > +ObjectClass *oc = (ObjectClass *)a; > +const char *name = b; > > -return NULL; > +if (strncasecmp(name, object_class_get_name(oc), strlen(name)) == 0 &&

Re: [Qemu-devel] [PATCH 4/6] snapshot: implemention of common API to take snapshots

2012-12-18 Thread Wenchao Xia
于 2012-12-18 18:36, Dietmar Maurer 写道: I am not familar with those tools >>> >>> You do not know LVM? >>> >> Honest speaking I use LVM tools little. I wonder why lvcreate can't be >> used, >> for block internal snapshot I think this patch have same function as your >> previous patch,

Re: [Qemu-devel] [PULL 00/45] Include reorganization + PCI patch queue

2012-12-18 Thread David Gibson
On Wed, Dec 19, 2012 at 03:13:10AM +0100, Alexander Graf wrote: > > On 19.12.2012, at 03:00, Anthony Liguori wrote: > > > Anthony Liguori writes: > > > >> Paolo Bonzini writes: > >> > >>> And how does it conflicts with Alex's ppc pull request? It is a fast > >>> forward from origin/master as

Re: [Qemu-devel] [PULL 00/45] Include reorganization + PCI patch queue

2012-12-18 Thread Alexander Graf
On 19.12.2012, at 03:00, Anthony Liguori wrote: > Anthony Liguori writes: > >> Paolo Bonzini writes: >> >>> And how does it conflicts with Alex's ppc pull request? It is a fast >>> forward from origin/master as of now (commit a8a826a, exec: refactor >>> cpu_restore_state, 2012-12-04), and tha

Re: [Qemu-devel] [PULL 00/45] Include reorganization + PCI patch queue

2012-12-18 Thread Anthony Liguori
Anthony Liguori writes: > Paolo Bonzini writes: > >> And how does it conflicts with Alex's ppc pull request? It is a fast >> forward from origin/master as of now (commit a8a826a, exec: refactor >> cpu_restore_state, 2012-12-04), and that includes Alex's commits... > > It's not a conflict. You b

Re: [Qemu-devel] [PATCH 1/2] hw: add isa-debug-exit device v3

2012-12-18 Thread Lucas Meneghel
On 12/13/2012 12:48 PM, Lucas Meneghel Rodrigues wrote: From: Gerd Hoffmann When present it makes qemu exit on any write. Mapped to port 0x501 by default. Without this patch Anthony doesn't allow me to remove the bochs bios debug ports because his test suite uses this. Hello Anthony, So, th

[Qemu-devel] [PATCH qom-cpu v2] cpu: Introduce CPUListState struct

2012-12-18 Thread Andreas Färber
This generalizes {ARM,M68k,Alpha}CPUListState to avoid declaring it for each target. Place it in cpu-common.h to avoid circular dependencies. Signed-off-by: Andreas Färber Cc: Eduardo Habkost Cc: Igor Mammedov --- cpu-common.h | 12 target-alpha/cpu.c |9 ++---

Re: [Qemu-devel] [PULL 00/45] Include reorganization + PCI patch queue

2012-12-18 Thread Anthony Liguori
Paolo Bonzini writes: > And how does it conflicts with Alex's ppc pull request? It is a fast > forward from origin/master as of now (commit a8a826a, exec: refactor > cpu_restore_state, 2012-12-04), and that includes Alex's commits... It's not a conflict. You both have problems with your pull re

Re: [Qemu-devel] [RFC 00/20] generic_cpu_init() and generic_cpu_create() functions

2012-12-18 Thread Eduardo Habkost
On Tue, Dec 18, 2012 at 11:57:58PM +0100, Andreas Färber wrote: > Am 18.12.2012 21:03, schrieb Eduardo Habkost: > > This is just a proof of concept, of how I think we could gradually move to > > make the architectures share CPU creation/initialization code. > > > > I have implemented a quick cpu_r

Re: [Qemu-devel] [PATCH v2 00/11] QOM CPUState, part 6: CPU_COMMON for KVM

2012-12-18 Thread Andreas Färber
Am 16.12.2012 01:13, schrieb Andreas Färber: > Here's a rebased version of the series moving KVM-specific fields from > CPU*State struct (CPU_COMMON macro) to QOM CPUState and avoiding use of > CPU*State in KVM's API. > > There was no review feedback on v1, which I'm interpreting as a don't-care.

Re: [Qemu-devel] [PULL] Xen fixes and multiple consoles

2012-12-18 Thread Anthony Liguori
Stefano Stabellini writes: > Hi Anthony, > please pull the following branch based on > a8a826a3c3b8c8a1c4def0e9e22b46e78e6163a0: > > > git://xenbits.xen.org/people/sstabellini/qemu-dm.git xen-20121217 > > > It contains several fixes and multiple consoles support in the Xen PV > console backend.

[Qemu-devel] [PATCH] qemu-jeos: Update .gitmodules

2012-12-18 Thread Andreas Färber
sources.redhat.com is timing out, use sourceware.org URL instead. Signed-off-by: Andreas Färber --- .gitmodules |2 +- 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/.gitmodules b/.gitmodules index d975cd0..a64bf93 100644 --- a/.gitmodules +++ b/.gitmodules @@ -9

Re: [Qemu-devel] [PULL 0/8] spice patch queue

2012-12-18 Thread Anthony Liguori
Gerd Hoffmann writes: > Hi, > > This is the spice patch queue, bringing two bugfixes > and chardev redirection over spice. Pulled. Thanks. Regards, Anthony Liguori > > please pull, > Gerd > > The following changes since commit a8a826a3c3b8c8a1c4def0e9e22b46e78e6163a0: > > exec: refactor

Re: [Qemu-devel] [PULL] virtio-serial: fixes, cleanups

2012-12-18 Thread Anthony Liguori
Amit Shah writes: > Hi Anthony, > > Please pull to get fixes and cleanups to virtio-serial code. > Pulled. Thanks. Regards, Anthony Liguori > Thanks, > > The following changes since commit 1c97e303d4ea80a2691334b0febe87a50660f99d: > > Merge remote-tracking branch 'afaerber/qom-cpu' into sta

Re: [Qemu-devel] [PULL 00/10] Trivial patches for December 8 to 18 2012

2012-12-18 Thread Anthony Liguori
Stefan Hajnoczi writes: > The following changes since commit a8a826a3c3b8c8a1c4def0e9e22b46e78e6163a0: > > exec: refactor cpu_restore_state (2012-12-16 08:35:24 +) > > are available in the git repository at: > > git://github.com/stefanha/qemu.git trivial-patches > > for you to fetch chang

Re: [Qemu-devel] [PULL 00/45] Include reorganization + PCI patch queue

2012-12-18 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > On Tue, Dec 18, 2012 at 04:35:53PM -0600, Anthony Liguori wrote: >> Paolo Bonzini writes: >> >> > Ok... I had really merged the wrong branch with mst's. I fixed it up and >> > pushed again to the same place; it's now commit 6cdf60e, "make check" >> > builds and p

Re: [Qemu-devel] [RFC 09/20] cpu: introduce cpu_realize()

2012-12-18 Thread Andreas Färber
Am 18.12.2012 21:04, schrieb Eduardo Habkost: > This is just for testing/demonstration purposes. Probably this will be > replaced by the more generic DeviceState realize() method, later. > > Signed-off-by: Eduardo Habkost Such a function was nack'ed for Object, the reason being that the goal was

Re: [Qemu-devel] [PATCH qom-cpu v2 4/5] target-alpha: Turn CPU definitions into subclasses

2012-12-18 Thread Andreas Färber
Am 09.12.2012 02:40, schrieb Andreas Färber: > Make TYPE_ALPHA_CPU abstract and add types -alpha-cpu. > Use type inheritence, and turn "2*" models into aliases. > > Move cpu_alpha_init() to cpu.c and split out CPU realization. > Default to creating type "ev67-alpha-cpu" as before. > > Signed-off-

[Qemu-devel] [Bug 1091766] Re: Physical host crash with Mellanox IB PCI passthrough

2012-12-18 Thread Alex Williamson
Does the attached patch against qemu 1.3 fix it for pci-assign? ** Attachment added: "pci-assign: Enable MSIX on device to match guest" https://bugs.launchpad.net/qemu/+bug/1091766/+attachment/3463375/+files/foo -- You received this bug notification because you are a member of qemu- devel-ml,

[Qemu-devel] [PATCH] pcie: Fix bug in pcie_ext_cap_set_next

2012-12-18 Thread Knut Omang
Upper 16 bits of the PCIe Extended Capability Header was truncated during update, also breaking pcie_add_capability. Signed-off-by: Knut Omang --- hw/pcie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pcie.c b/hw/pcie.c index 7c92f19..fa260af 100644 --- a/hw/pcie.c ++

Re: [Qemu-devel] [RFC 00/20] generic_cpu_init() and generic_cpu_create() functions

2012-12-18 Thread Andreas Färber
Am 18.12.2012 21:03, schrieb Eduardo Habkost: > This is just a proof of concept, of how I think we could gradually move to > make the architectures share CPU creation/initialization code. > > I have implemented a quick cpu_realize() function, just for testing, while we > don't have qdev realizefn

Re: [Qemu-devel] [Bug 1089006] Re: Qemu scrambles order of eth devices in vm

2012-12-18 Thread john fisher
For the benefit of 1) others and 2) me when I forget how this works- I did find a solution in formatting the xml file. If you leave the vnets out completely, see file below, the generic xml file will cooperate with libvirt and qemu and order the VM's eth devices as they are ordered on the hyper

Re: [Qemu-devel] [PULL 00/45] Include reorganization + PCI patch queue

2012-12-18 Thread Michael S. Tsirkin
On Tue, Dec 18, 2012 at 04:35:53PM -0600, Anthony Liguori wrote: > Paolo Bonzini writes: > > > Ok... I had really merged the wrong branch with mst's. I fixed it up and > > pushed again to the same place; it's now commit 6cdf60e, "make check" > > builds and passes. > > > > Here is the diff, sorry

Re: [Qemu-devel] [PULL 00/45] Include reorganization + PCI patch queue

2012-12-18 Thread Anthony Liguori
Paolo Bonzini writes: > And how does it conflicts with Alex's ppc pull request? It is a fast > forward from origin/master as of now (commit a8a826a, exec: refactor > cpu_restore_state, 2012-12-04), and that includes Alex's commits... Something from the e500 changes because hw/ppc/e500.c and hw/p

Re: [Qemu-devel] [PULL 00/45] Include reorganization + PCI patch queue

2012-12-18 Thread Anthony Liguori
Paolo Bonzini writes: > Ok... I had really merged the wrong branch with mst's. I fixed it up and > pushed again to the same place; it's now commit 6cdf60e, "make check" > builds and passes. > > Here is the diff, sorry for the mistake. No problem. I'm processing other pull requests now but will

Re: [Qemu-devel] [PATCH 6/8] qdev-properties.c: Separate core from the code used only by qemu-system-*

2012-12-18 Thread Andreas Färber
Am 05.12.2012 17:49, schrieb Eduardo Habkost: > This separates the qdev properties code in two parts: > - qdev-properties.c, that contains most of the qdev properties code; > - qdev-properties-system.c for code specific for qemu-system-*, >containing: >- Property types: drive, chr, netdev

Re: [Qemu-devel] [PULL 00/45] Include reorganization + PCI patch queue

2012-12-18 Thread Paolo Bonzini
And how does it conflicts with Alex's ppc pull request? It is a fast forward from origin/master as of now (commit a8a826a, exec: refactor cpu_restore_state, 2012-12-04), and that includes Alex's commits... Paolo On Tue, Dec 18, 2012 at 10:11 PM, Paolo Bonzini wrote: > Il 18/12/2012 21:59, Ant

Re: [Qemu-devel] [PATCH 5/8] qdev: Coding style fixes

2012-12-18 Thread Andreas Färber
Am 05.12.2012 17:49, schrieb Eduardo Habkost: > Add missing braces and break lines larger than 80 chars. > > Signed-off-by: Eduardo Habkost Thanks, applied to qom-cpu queue: https://github.com/afaerber/qemu-cpu/commits/qom-cpu Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg

Re: [Qemu-devel] [PULL 00/45] Include reorganization + PCI patch queue

2012-12-18 Thread Paolo Bonzini
Ok... I had really merged the wrong branch with mst's. I fixed it up and pushed again to the same place; it's now commit 6cdf60e, "make check" builds and passes. Here is the diff, sorry for the mistake. Paolo On Tue, Dec 18, 2012 at 10:11 PM, Paolo Bonzini wrote: > Il 18/12/2012 21:59, Antho

Re: [Qemu-devel] [PULLv2] pci,net,misc infrastructure

2012-12-18 Thread Michael S. Tsirkin
On Mon, Dec 17, 2012 at 01:12:10PM +0200, Michael S. Tsirkin wrote: > On Sun, Dec 16, 2012 at 11:11:37PM +0200, Michael S. Tsirkin wrote: > > The following changes since commit 1c97e303d4ea80a2691334b0febe87a50660f99d: > > > > Merge remote-tracking branch 'afaerber/qom-cpu' into staging (2012-12

Re: [Qemu-devel] [PATCH 1/3] balloon: drop old stats code & API

2012-12-18 Thread Eric Blake
On 12/17/2012 03:13 AM, Dietmar Maurer wrote: >> Next commit will re-enable balloon stats with a different interface, but this >> old code conflicts with it. Let's drop it. > > I don't really see any conflicts here? > >> It's important to note that the QMP and HMP interfaces are also dropped by >

Re: [Qemu-devel] (bisected): Is mips-user broken on 64bit host since v1.1?

2012-12-18 Thread Alexander Graf
On 18.12.2012, at 20:05, Michael Tokarev wrote: > On 18.12.2012 20:10, Michael Tokarev wrote: >> Since at least 1.1 version of qemu, I can't run any >> mips binary using statically linked qemu-mips on x86_64 >> host. It immediately fails with SIGSEGV: >> >> # chroot mipsroot /bin/bash >> qemu:

Re: [Qemu-devel] (bisected): Is mips-user broken on 64bit host since v1.1?

2012-12-18 Thread Stefan Weil
Am 18.12.2012 20:05, schrieb Michael Tokarev: On 18.12.2012 20:10, Michael Tokarev wrote: Since at least 1.1 version of qemu, I can't run any mips binary using statically linked qemu-mips on x86_64 host. It immediately fails with SIGSEGV: # chroot mipsroot /bin/bash qemu: uncaught target signa

[Qemu-devel] [RFC 09/20] cpu: introduce cpu_realize()

2012-12-18 Thread Eduardo Habkost
This is just for testing/demonstration purposes. Probably this will be replaced by the more generic DeviceState realize() method, later. Signed-off-by: Eduardo Habkost --- include/qemu/cpu.h | 13 + qom/cpu.c | 10 ++ 2 files changed, 23 insertions(+) diff --git a/i

Re: [Qemu-devel] [PATCH 10/11] cpu: do not use object_delete

2012-12-18 Thread Paolo Bonzini
Il 18/12/2012 22:07, Andreas Färber ha scritto: >> > CPUs are never added to the composition tree, so delete is achieved >> > simply by removing the last references to them. >> > >> > Signed-off-by: Paolo Bonzini > Reviewed-by: Andreas Färber > > Note however that x86 is undergoing major change

Re: [Qemu-devel] [PATCH 01/11] qdev: export and use qbus_init

2012-12-18 Thread Andreas Färber
Am 05.12.2012 21:44, schrieb Paolo Bonzini: > BusState subclasses need to do their own allocation because > qbus_create_inplace calls object_initialize (which wipes out the > "free" callback). This patch separates the initialization of the object > (object_initialize) from its insertion in the qde

[Qemu-devel] [RFC 03/20] cpu: make cpu_init return CPUState QOM object

2012-12-18 Thread Eduardo Habkost
This will allow us to gradually change the existing cpu_init()/cpu_copy() code to use QOM, and to gradually move CPU_COMMON fields to CPUState. The existing implementations were mechanically changed to be called 'old_cpu_init', and a wrapper was added to all architectures. Later the wrappers and

[Qemu-devel] [RFC 3/3] virtio-balloon: add auto-ballooning support

2012-12-18 Thread Luiz Capitulino
The auto-ballooning feature automatically performs balloon inflate or deflate based on host and guest memory pressure. This can help to avoid swapping or worse in both, host and guest. Auto-ballooning has a host and a guest part. The host performs automatic inflate by requesting the guest to infla

Re: [Qemu-devel] [PULL 00/45] Include reorganization + PCI patch queue

2012-12-18 Thread Paolo Bonzini
Il 18/12/2012 21:59, Anthony Liguori ha scritto: > But this series breaks the build of make check. It's not just one test > case but almost every single one. I think you must have eliminated an > implicit include of qemu-common.h which makes PRId64 et al all > undeclared. > > I started fixing th

[Qemu-devel] [RFC 1/3] virtio-balloon: add guest_get_actual_ram()

2012-12-18 Thread Luiz Capitulino
A future commit will also want to use this. Signed-off-by: Luiz Capitulino --- hw/virtio-balloon.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c index dd1a650..03248df 100644 --- a/hw/virtio-balloon.c +++ b/hw/virtio-balloon

[Qemu-devel] [RFC 17/20] target-m68k: replace cpu_m68k_init() with generic_cpu_init()

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- target-m68k/cpu.h| 3 +-- target-m68k/helper.c | 14 -- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/target-m68k/cpu.h b/target-m68k/cpu.h index 9823267..3573c05 100644 --- a/target-m68k/cpu.h +++ b/target-m68k/cpu.h @@ -116,7

Re: [Qemu-devel] [PATCH 10/11] cpu: do not use object_delete

2012-12-18 Thread Andreas Färber
Am 05.12.2012 21:44, schrieb Paolo Bonzini: > CPUs are never added to the composition tree, so delete is achieved > simply by removing the last references to them. > > Signed-off-by: Paolo Bonzini Reviewed-by: Andreas Färber Note however that x86 is undergoing major changes and other targets a

[Qemu-devel] [RFC 14/20] target-arm: move final steps of cpu_arm_init() to realize function

2012-12-18 Thread Eduardo Habkost
This way we will be able to replace cpu_arm_init() with generic_cpu_init(). Signed-off-by: Eduardo Habkost --- target-arm/cpu-qom.h | 1 - target-arm/cpu.c | 76 +++- target-arm/helper.c | 76 +-

[Qemu-devel] [RFC 16/20] target-m68k: move final steps of cpu_m68k_init() to realize function

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- target-m68k/cpu.c| 52 +++- target-m68k/helper.c | 47 +-- 2 files changed, 52 insertions(+), 47 deletions(-) diff --git a/target-m68k/cpu.c b/target-m68k/cpu.c inde

[Qemu-devel] [RFC 18/20] target-unicore32: move final steps of uc32_cpu_init() to realize function

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- target-unicore32/cpu.c| 21 + target-unicore32/helper.c | 11 +-- 2 files changed, 22 insertions(+), 10 deletions(-) diff --git a/target-unicore32/cpu.c b/target-unicore32/cpu.c index 76750da..5467127 100644 --- a/target-unicore3

[Qemu-devel] [RFC 10/20] cpu: introduce generic_cpu_init() & generic_cpu_create() functions

2012-12-18 Thread Eduardo Habkost
Useful for architectures where cpu_init() is just creation of a CPU object and a call to cpu_realize(). All the functions should need is the base CPU class name and cpu_model string. Any target-specific behavior/information can later be provided by the target-specific CPU class, if necessary. Sig

[Qemu-devel] [RFC 02/20] cpu: introduce CPU_GET_ENV macros

2012-12-18 Thread Eduardo Habkost
This will help us gradually convert code based on CPUArchState to QOM-based code. The macro checks for NULL cpu value, so a NULL cpu safely becomes a NULL env pointer. Signed-off-by: Eduardo Habkost --- target-alpha/cpu-qom.h | 7 +++ target-arm/cpu-qom.h| 7 +++ target-cri

[Qemu-devel] [RFC 06/20] m68k: convert cpu_init to QOM

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- target-m68k/cpu.h| 5 ++--- target-m68k/helper.c | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/target-m68k/cpu.h b/target-m68k/cpu.h index fbb35dc..9823267 100644 --- a/target-m68k/cpu.h +++ b/target-m68k/cpu.h @@ -116,7 +116,7 @@

[Qemu-devel] [RFC 08/20] cpu: move cpu_model_str to CPUState

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- cpu-defs.h | 1 - exec.c | 3 ++- include/qemu/cpu.h | 1 + target-alpha/translate.c | 2 +- target-arm/helper.c | 2 +- target-i386/helper.c | 4 +--- target-m68k/helper.c | 2 +- target-mips/translate.c | 2 +

Re: [Qemu-devel] [PATCH 03/11] qom: preserve object while unparenting it

2012-12-18 Thread Andreas Färber
Am 05.12.2012 21:44, schrieb Paolo Bonzini: > Avoid that the object disappears after it's deleted from the QOM > composition tree, in case that was the only reference to it. > > Signed-off-by: Paolo Bonzini Reviewed-by: Andreas Färber Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409

[Qemu-devel] [RFC 07/20] target-unicore32: convert cpu_init to QOM

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- target-unicore32/cpu.h| 6 +++--- target-unicore32/helper.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/target-unicore32/cpu.h b/target-unicore32/cpu.h index 86a6959..43bdd84 100644 --- a/target-unicore32/cpu.h +++ b/target-unico

[Qemu-devel] [RFC 2/3] virtio-balloon: add virtio_balloon_conf skeleton

2012-12-18 Thread Luiz Capitulino
Next commit wants it. Signed-off-by: Luiz Capitulino --- hw/virtio-balloon.c | 2 +- hw/virtio-balloon.h | 4 hw/virtio-pci.c | 2 +- hw/virtio-pci.h | 2 ++ hw/virtio.h | 3 ++- 5 files changed, 10 insertions(+), 3 deletions(-) diff --git a/hw/virtio-balloon.c b/hw/virtio-

[Qemu-devel] [RFC 0/3] auto-ballooning prototype (host part)

2012-12-18 Thread Luiz Capitulino
Hi, This series implements an early protoype of a new feature called automatic ballooning. This is based on ideas by Rik van Riel and I also got some help from Rafael Aquini (misconceptions and bugs are all mine, though). The auto-ballooning feature automatically performs balloon inflate and defl

[Qemu-devel] [RFC 20/20] cpu: convert cpu_copy() to QOM

2012-12-18 Thread Eduardo Habkost
Instead of using CPUArchState for parameters and return value, get/return CPUState objects. It is still an ugly hack that should die, but at least it's an ugly hack that can use the QOM CPU object if necessary, and allows the calling code to be converted to QOM as well. This also keeps the cpu_co

[Qemu-devel] [RFC 19/20] target-unicore32: replace uc32_cpu_init() with generic_cpu_init()

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- target-unicore32/cpu.h| 2 +- target-unicore32/helper.c | 12 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/target-unicore32/cpu.h b/target-unicore32/cpu.h index 43bdd84..ad6fee4 100644 --- a/target-unicore32/cpu.h +++ b/target

[Qemu-devel] [RFC 13/20] target-openrisc: replace cpu_openrisc_init() with generic_cpu_init()

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- hw/openrisc_sim.c | 2 +- target-openrisc/cpu.c | 22 -- target-openrisc/cpu.h | 4 +--- 3 files changed, 2 insertions(+), 26 deletions(-) diff --git a/hw/openrisc_sim.c b/hw/openrisc_sim.c index 440dc9e..1955854 100644 --- a/hw/openri

[Qemu-devel] [RFC 00/20] generic_cpu_init() and generic_cpu_create() functions

2012-12-18 Thread Eduardo Habkost
This is just a proof of concept, of how I think we could gradually move to make the architectures share CPU creation/initialization code. I have implemented a quick cpu_realize() function, just for testing, while we don't have qdev realizefn support implemented. I have converted the following tar

[Qemu-devel] [RFC 04/20] cpu: replace trivial old_cpu_init functions

2012-12-18 Thread Eduardo Habkost
Most of the existing old_cpu_init functions were just wrappers around QOM-ready cpu_*_init() functions, so just define cpu_init as a call to those functions (wrapped inside CPU macro). Signed-off-by: Eduardo Habkost --- target-arm/cpu.h| 10 +- target-cris/cpu.h | 10 +-

[Qemu-devel] [RFC 12/20] hw/openrisc_sim.c: coding style/indentation fix

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- hw/openrisc_sim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/openrisc_sim.c b/hw/openrisc_sim.c index 23c66df..440dc9e 100644 --- a/hw/openrisc_sim.c +++ b/hw/openrisc_sim.c @@ -96,7 +96,7 @@ static void openrisc_sim_init(QEMUMachineI

[Qemu-devel] [RFC 15/20] target-arm: replace cpu_arm_init() with generic_cpu_init()

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- target-arm/cpu.h| 6 -- target-arm/helper.c | 13 - 2 files changed, 4 insertions(+), 15 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 718f1d9..bf50ea1 100644 --- a/target-arm/cpu.h +++ b/target-arm/cpu.h @@ -232,7 +23

[Qemu-devel] [RFC 11/20] target-openrisc: implement CPU realize() method

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- target-openrisc/cpu.c | 19 ++- target-openrisc/cpu.h | 1 - 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c index e152a3a..0a8253e 100644 --- a/target-openrisc/cpu.c +++ b/target-ope

[Qemu-devel] [RFC 05/20] alpha: convert cpu_init to QOM

2012-12-18 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- target-alpha/cpu.h | 5 ++--- target-alpha/translate.c | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/target-alpha/cpu.h b/target-alpha/cpu.h index c04d436..a34cf0e 100644 --- a/target-alpha/cpu.h +++ b/target-alpha/cpu.h @@ -290,

[Qemu-devel] [RFC 01/20] qemu-common.h: "use" env parameter in no-op version of qemu_init_vcpu()

2012-12-18 Thread Eduardo Habkost
This will avoid warnings about unused variables when compiling code that calls qemu_init_vcpu(). Signed-off-by: Eduardo Habkost --- qemu-common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-common.h b/qemu-common.h index e674786..bfd4c1a 100644 --- a/qemu-common.h ++

Re: [Qemu-devel] [PATCH qom-cpu 1/4] cpu: Introduce CPUListState struct

2012-12-18 Thread Andreas Färber
Am 18.12.2012 18:42, schrieb Eduardo Habkost: > On Tue, Dec 18, 2012 at 08:53:40AM +0100, Andreas Färber wrote: >> diff --git a/include/qemu/cpu.h b/include/qemu/cpu.h >> index 61b7698..5fbb3f9 100644 >> --- a/include/qemu/cpu.h >> +++ b/include/qemu/cpu.h >> @@ -21,6 +21,7 @@ >> #define QEMU_CPU_

[Qemu-devel] (bisected): Is mips-user broken on 64bit host since v1.1?

2012-12-18 Thread Michael Tokarev
On 18.12.2012 20:10, Michael Tokarev wrote: > Since at least 1.1 version of qemu, I can't run any > mips binary using statically linked qemu-mips on x86_64 > host. It immediately fails with SIGSEGV: > > # chroot mipsroot /bin/bash > qemu: uncaught target signal 11 (Segmentation fault) - core dump

[Qemu-devel] [Bug 1091766] [NEW] Physical host crash with Mellanox IB PCI passthrough

2012-12-18 Thread Vlastimil Holer
Public bug reported: (from http://permalink.gmane.org/gmane.comp.emulators.kvm.devel/100736) We have been using PCI passthrough with the Mellanox IB interface (MT27500 Family [ConnectX-3]) on Debian 6.0.6, kernel 3.2.23 and qemu-kvm-1.0 (both from backports). It worked fine until latest update in

Re: [Qemu-devel] [PATCH v2] Added uapi directory into linux-header

2012-12-18 Thread David Howells
Alexander Graf wrote: > Could you please try and see if this kernel side patch makes things work for > you too? > > > Alex > > > diff --git a/arch/powerpc/include/uapi/asm/kvm_para.h > b/arch/powerpc/include/uapi/asm/kvm_para.h > index ed0e025..e3af328 100644 > --- a/arch/powerpc/include/ua

Re: [Qemu-devel] [PATCH v2] Added uapi directory into linux-header

2012-12-18 Thread David Howells
Alexander Graf wrote: > But looking through this whole thing, it seems like the root cause is > actually different. We don't want any uapi directories exposed to user > space. So let's go back a step: > > Why do we need the uapi include dir? Because some header is using it. > > linux-headers/as

Re: [Qemu-devel] [PATCH qom-cpu 1/4] cpu: Introduce CPUListState struct

2012-12-18 Thread Andreas Färber
Am 18.12.2012 16:59, schrieb Igor Mammedov: > On Tue, 18 Dec 2012 08:53:40 +0100 > Andreas Färber wrote: > >> This generalizes {ARM,M68k,Alpha}CPUListState to avoid declaring it for >> each target. >> >> Signed-off-by: Andreas Färber >> --- >> include/qemu/cpu.h | 12 >> target

Re: [Qemu-devel] [PATCH 1/3] target-i386/cpu.c: coding style fix

2012-12-18 Thread Eduardo Habkost
On Tue, Dec 18, 2012 at 07:33:13PM +0100, Andreas Färber wrote: > Am 18.12.2012 18:03, schrieb Eduardo Habkost: > > On Tue, Dec 18, 2012 at 05:44:12PM +0100, Igor Mammedov wrote: > >> On Tue, 18 Dec 2012 14:29:21 -0200 > >> Eduardo Habkost wrote: > >> > >>> Signed-off-by: Eduardo Habkost > >>> --

Re: [Qemu-devel] [PATCH 1/3] target-i386/cpu.c: coding style fix

2012-12-18 Thread Andreas Färber
Am 18.12.2012 18:03, schrieb Eduardo Habkost: > On Tue, Dec 18, 2012 at 05:44:12PM +0100, Igor Mammedov wrote: >> On Tue, 18 Dec 2012 14:29:21 -0200 >> Eduardo Habkost wrote: >> >>> Signed-off-by: Eduardo Habkost >>> --- >>> target-i386/cpu.c | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 del

[Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2012-12-18 Thread Jens Freimann
Add a CPU reset handler to have all CPUs in a PoP compliant state. Signed-off-by: Jens Freimann --- v2 -> v3: * remove FIXME * separate parent reset from local reset by adding a while line * use defines for register reset values v1 -> v2: * move setting of control registers and psa to s390_cpu_

Re: [Qemu-devel] [PATCH qom-cpu 3/4] target-ppc: Slim conversion of model definitions to QOM subclasses

2012-12-18 Thread Eduardo Habkost
On Tue, Dec 18, 2012 at 08:53:42AM +0100, Andreas Färber wrote: > Since the model list is highly macrofied, keep ppc_def_t for now and > save a pointer to it in PowerPCCPUClass. This results in a flat list of > subclasses including aliases, to be refined later. > > Move cpu_ppc_init() to translate

[Qemu-devel] [PATCH 1/3] s390: Move IPL code into a separate device

2012-12-18 Thread Jens Freimann
From: Christian Borntraeger Lets move the code to setup IPL for external kernel or via the zipl rom into a separate file. This allows to - define a reboot handler, setting up the PSW appropriately - enhance the boot code to IPL disks that contain a bootmap that was created with zipl under LPAR

[Qemu-devel] [PATCH 10/10] configure: Earlier pkg-config probe

2012-12-18 Thread Stefan Hajnoczi
From: Stefan Weil Probe pkg-config before it is used for the first time (libseccomp check). Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- configure | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/configure b/configure index ecdb33a..728caca

[Qemu-devel] [PATCH 08/10] linux-user/syscall.c: remove wrong forward decl of setgroups()

2012-12-18 Thread Stefan Hajnoczi
From: John Spencer this declaration is wrong: the correct prototype on linux is: int setgroups(size_t size, const gid_t *list); since by default musl libc exposes this symbol in unistd.h additionally to grp.h, the wrong declaration causes a build error. the proper fix is to simply include the c

[Qemu-devel] [PATCH 03/10] pflash_cfi0x: Send debug messages to stderr

2012-12-18 Thread Stefan Hajnoczi
From: Peter Crosthwaite These debug info messages should go to stderr rather than stdout. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- hw/pflash_cfi01.c | 8 hw/pflash_cfi02.c | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions

[Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions

2012-12-18 Thread Jens Freimann
From: Viktor Mihajlovski This enables qemu -cpu help to return a list of supported CPU models on s390 and also to query for cpu definitions in the monitor. Initially only cpu model = host is returned. This needs to be reworked into a full-fledged CPU model handling later on. This change is needed

[Qemu-devel] [PATCH 0/3] s390: ipl device, cpu reset handler and cpu model support

2012-12-18 Thread Jens Freimann
Hi Alex, here's a reworked version of the ipl-device patch, the cpu reset handler and the patch to query cpu definitions via QMP. Patch 1: Creates a new ipl device and moves ipl code from s390_virtio.c Patch 2: Adds a cpu reset handler to Patch 3 Allow to query cpu types via commandline -? argu

[Qemu-devel] [PATCH 07/10] fix build error on ARM due to wrong glibc check

2012-12-18 Thread Stefan Hajnoczi
From: John Spencer the test for glibc < 2 "succeeds" wrongly for any non-glibc C library, and breaks the build on musl libc. we must first test if __GLIBC__ is defined at all, before using it unconditionally. Signed-off-by: John Spencer Reviewed-by: Stefan Weil Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH qom-cpu 1/4] cpu: Introduce CPUListState struct

2012-12-18 Thread Eduardo Habkost
On Tue, Dec 18, 2012 at 08:53:40AM +0100, Andreas Färber wrote: > This generalizes {ARM,M68k,Alpha}CPUListState to avoid declaring it for > each target. > > Signed-off-by: Andreas Färber > --- > include/qemu/cpu.h | 12 > target-alpha/cpu.c |9 ++--- > target-arm/helpe

Re: [Qemu-devel] [PATCH] e1000: Discard oversized packets based on SBP|LPE

2012-12-18 Thread Michael Contreras
On Tue, Dec 18, 2012 at 05:49:16PM +0100, Stefan Hajnoczi wrote: > On Tue, Dec 18, 2012 at 5:20 PM, Michael Tokarev wrote: > > On 18.12.2012 17:44, Stefan Hajnoczi wrote: > >> On Wed, Dec 05, 2012 at 01:31:30PM -0500, Michael Contreras wrote: > >>> Discard packets longer than 16384 when !SBP to ma

[Qemu-devel] [PATCH 09/10] vmmouse_reset(): remove minimal code duplication

2012-12-18 Thread Stefan Hajnoczi
From: Laszlo Ersek Commit 069ab0eb added a vmmouse_disable() call to vmmouse_reset(). vmmouse_disable() resets the status already. Signed-off-by: Laszlo Ersek Signed-off-by: Stefan Hajnoczi --- hw/vmmouse.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/vmmouse.c b/hw/vmmouse.c index 6

Re: [Qemu-devel] [PATCH RFC qom-cpu 2/4] qemu-common.h: Move fprintf_function to qemu-types.h

2012-12-18 Thread Eduardo Habkost
On Tue, Dec 18, 2012 at 08:53:41AM +0100, Andreas Färber wrote: > This avoids a dependency on qemu-common.h from qemu/cpu.h. > > Signed-off-by: Andreas Färber When I introduced qemu-types.h, I just planned to use it for the trivial "typedef struct Foobar Foobar" typedefs that can't be anywhere e

[Qemu-devel] [PATCH 06/10] gitignore: Add virtfs-proxy-helper

2012-12-18 Thread Stefan Hajnoczi
From: Cole Robinson Signed-off-by: Cole Robinson Signed-off-by: Stefan Hajnoczi --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index bd6ba1c..3ce57cc 100644 --- a/.gitignore +++ b/.gitignore @@ -47,6 +47,7 @@ test-qmp-output-visitor test-string-inpu

Re: [Qemu-devel] target-i386: Allow tsc-frequency to be larger then 2.147G

2012-12-18 Thread Don Slutz
On 12/16/12 12:06, Michael Tokarev wrote: This is a follow-up to a more-or-less trivial commit, 2e84849aa2cc7f220d3b3668f5f7e3c57bb1b590 . I'm adding some more context - the whole function in question. commit 2e84849aa2cc7f220d3b3668f5f7e3c57bb1b590 Author: Don Slutz Date: Fri Sep 21 20:13:

[Qemu-devel] [PATCH 02/10] pflash_cfi01: qemu_log_mask "unimplemented" msg

2012-12-18 Thread Stefan Hajnoczi
From: Peter Crosthwaite This printf is informing the user of unimplemented functionality. It should be re-directed to qemu_log(LOG_UNIMP, ...) accordingly. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- hw/pflash_cfi01.c | 6 +++--- 1 file chan

Re: [Qemu-devel] [PATCH 1/3] target-i386/cpu.c: coding style fix

2012-12-18 Thread Eduardo Habkost
On Tue, Dec 18, 2012 at 05:44:12PM +0100, Igor Mammedov wrote: > On Tue, 18 Dec 2012 14:29:21 -0200 > Eduardo Habkost wrote: > > > Signed-off-by: Eduardo Habkost > > --- > > target-i386/cpu.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/target-i386/cpu.c

  1   2   3   >