[Qemu-devel] [Bug 1090837] [NEW] Error in building Qemu-1.3.0 on Solaris 10

2012-12-15 Thread Dipanjan Das
Public bug reported: While trying to build Qemu on Oracle Solaris 10 (SPARC processor), I encountered the following error in the configure step: ./configure --prefix=/usr/local/ --install=/usr/ucb/install ./configure: bad substitution ./configure: !: not found ./configure: !: not found ./configur

[Qemu-devel] [PATCH v2 3/4] usb/ehci: Add SysBus EHCI device for Exynos4210

2012-12-15 Thread Andreas Färber
It uses a different capsbase and opregbase than the Xilinx device. Signed-off-by: Liming Wang Signed-off-by: Andreas Färber Cc: Igor Mitsyanko --- hw/usb/hcd-ehci-sysbus.c | 15 +++ hw/usb/hcd-ehci.h|2 ++ 2 Dateien geändert, 17 Zeilen hinzugefügt(+) diff --git a/hw/

[Qemu-devel] [PATCH v2 1/4] usb/ehci: Clean up SysBus and PCI EHCI split

2012-12-15 Thread Andreas Färber
SysBus EHCI was introduced in a hurry before 1.3 Soft Freeze. To use QOM casts in place of DO_UPCAST() / FROM_SYSBUS(), we need an identifying type. Introduce generic abstract base types for PCI and SysBus EHCI to allow multiple types to access the shared fields. While at it, move the state struct

[Qemu-devel] [PATCH v2 0/4] usb: Clean up and extend SysBus EHCI

2012-12-15 Thread Andreas Färber
Hello Gerd, Here's an updated patchset for SysBus EHCI models, fixing exynos4210 values. As indicated, I've moved the state structs to the hcd-ehci.h header to allow my experimental Tegra model to embed EHCISysBusState into the SoC object's struct. When you and reviewers are happy, please apply t

[Qemu-devel] [PATCH v2 4/4] exynos4210: Add EHCI support

2012-12-15 Thread Andreas Färber
From: Liming Wang Add EHCI USB host controller to exynos4210. Signed-off-by: Liming Wang Signed-off-by: Andreas Färber Reviewed-by: Igor Mitsyanko --- hw/exynos4210.c |7 +++ hw/exynos4210_gic.c |2 +- 2 Dateien geändert, 8 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --g

[Qemu-devel] [PATCH v2 2/4] usb/ehci: Move capsbase and opregbase into SysBus EHCI class

2012-12-15 Thread Andreas Färber
This allows specific derived models to use different values. Signed-off-by: Andreas Färber --- hw/usb/hcd-ehci-sysbus.c | 15 +-- hw/usb/hcd-ehci.h| 13 + 2 Dateien geändert, 26 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/hw/usb/hcd-ehci-sysbus.c

[Qemu-devel] [PATCH v2 05/11] ppc: Pass PowerPCCPU to [h]decr callbacks

2012-12-15 Thread Andreas Färber
Cleans up after passing PowerPCCPU to ppc_set_irq(). Signed-off-by: Andreas Färber --- hw/ppc.c | 60 +--- 1 Datei geändert, 33 Zeilen hinzugefügt(+), 27 Zeilen entfernt(-) diff --git a/hw/ppc.c b/hw/ppc.c index 6db595f..b1b93a1 100644 -

[Qemu-devel] [PATCH v2 01/11] cpu: Move kvm_fd into CPUState

2012-12-15 Thread Andreas Färber
Signed-off-by: Andreas Färber --- cpu-defs.h |1 - include/qemu/cpu.h |5 + kvm-all.c |8 +--- 3 Dateien geändert, 10 Zeilen hinzugefügt(+), 4 Zeilen entfernt(-) diff --git a/cpu-defs.h b/cpu-defs.h index 3669241..6373a80 100644 --- a/cpu-defs.h +++ b/cpu-def

[Qemu-devel] [PATCH v2 08/11] ppc4xx_devs: Return PowerPCCPU from ppc4xx_init()

2012-12-15 Thread Andreas Färber
Prepares for passing PowerPCCPU to ppc_booke_timers_init(). Signed-off-by: Andreas Färber --- hw/ppc405_uc.c |8 ++-- hw/ppc4xx.h |6 +++--- hw/ppc4xx_devs.c |8 3 Dateien geändert, 13 Zeilen hinzugefügt(+), 9 Zeilen entfernt(-) diff --git a/hw/ppc405_uc.c b/hw/p

[Qemu-devel] [PATCH v2 04/11] ppc: Pass PowerPCCPU to ppc_set_irq()

2012-12-15 Thread Andreas Färber
Adapt static caller functions. This cleans up after passing PowerPCCPU to kvmppc_set_interrupt(). Signed-off-by: Andreas Färber --- hw/ppc.c | 66 ++-- hw/ppc.h |2 +- hw/ppc_booke.c | 28 3 Dateien

[Qemu-devel] [PATCH v2 10/11] cpu: Move kvm_state field into CPUState

2012-12-15 Thread Andreas Färber
Adapt some functions to take CPUState / {PowerPC,S390}CPU argument. Signed-off-by: Andreas Färber --- cpu-defs.h |2 -- include/qemu/cpu.h |3 +++ kvm-all.c | 28 ++-- kvm.h |4 ++-- target-i386/cpu.c |7 +-- target-i38

[Qemu-devel] [PATCH v2 09/11] ppc_booke: Pass PowerPCCPU to ppc_booke_timers_init()

2012-12-15 Thread Andreas Färber
Cleans up after passing PowerPCCPU to timer callbacks. Signed-off-by: Andreas Färber --- hw/ppc.h |2 +- hw/ppc/e500.c |2 +- hw/ppc405_uc.c |2 +- hw/ppc440_bamboo.c |2 +- hw/ppc_booke.c |5 ++--- hw/virtex_ml507.c |2 +- 6 Dateien geändert, 7 Ze

[Qemu-devel] [PATCH v2 00/11] QOM CPUState, part 6: CPU_COMMON for KVM

2012-12-15 Thread Andreas Färber
Hello, Here's a rebased version of the series moving KVM-specific fields from CPU*State struct (CPU_COMMON macro) to QOM CPUState and avoiding use of CPU*State in KVM's API. There was no review feedback on v1, which I'm interpreting as a don't-care. If no one objects, I will thus include it in my

[Qemu-devel] [PATCH v2 02/11] kvm: Pass CPUState to kvm_arch_*

2012-12-15 Thread Andreas Färber
Move kvm_vcpu_dirty field into CPUState to simplify things and change its type to bool while at it. Signed-off-by: Andreas Färber --- cpu-defs.h |3 +-- include/qemu/cpu.h |1 + kvm-all.c | 75 ++-- kvm.h |

[Qemu-devel] [PATCH v2 06/11] ppc: Pass PowerPCCPU to [h]decr timer callbacks

2012-12-15 Thread Andreas Färber
Cleans up after passing PowerPCCPU to [h]decr exception callbacks. Signed-off-by: Andreas Färber --- hw/ppc.c | 18 ++ 1 Datei geändert, 10 Zeilen hinzugefügt(+), 8 Zeilen entfernt(-) diff --git a/hw/ppc.c b/hw/ppc.c index b1b93a1..8c05eb3 100644 --- a/hw/ppc.c +++ b/hw/ppc.c

[Qemu-devel] [PATCH v2 11/11] cpu: Move kvm_run into CPUState

2012-12-15 Thread Andreas Färber
Pass CPUState / {X86,S390}CPU to helper functions. Signed-off-by: Andreas Färber --- cpu-defs.h |4 +-- include/qemu/cpu.h |2 ++ kvm-all.c |8 +++--- target-i386/kvm.c |9 +++--- target-s390x/kvm.c | 77 5

[Qemu-devel] [PATCH v2 03/11] kvm: Pass CPUState to kvm_vcpu_ioctl()

2012-12-15 Thread Andreas Färber
Adapt helper functions to pass X86CPU / PowerPCCPU / S390CPU. Signed-off-by: Andreas Färber --- hw/kvm/apic.c | 10 +-- hw/kvm/clock.c |2 +- hw/ppc.c |2 +- hw/s390-virtio-bus.c | 12 ++-- hw/spapr.c |2 +- kvm-all

[Qemu-devel] [PATCH v2 07/11] ppc_booke: Pass PowerPCCPU to {decr, fit, wdt} timer callbacks

2012-12-15 Thread Andreas Färber
Cleans up after passing PowerPCCPU to booke_update_irq(). Signed-off-by: Andreas Färber --- hw/ppc_booke.c | 23 ++- 1 Datei geändert, 10 Zeilen hinzugefügt(+), 13 Zeilen entfernt(-) diff --git a/hw/ppc_booke.c b/hw/ppc_booke.c index da6bc4a..5748063 100644 --- a/hw/ppc_bo

Re: [Qemu-devel] [[Bug 108996]] hw/dma.c: Fix conversion ioport_register* to MemoryRegion

2012-12-15 Thread Julien Grall
On Fri, Dec 14, 2012 at 5:30 PM, Andreas Färber wrote: > Am 14.12.2012 10:52, schrieb Julien Grall: >> The commit 582299336879504353e60c7937fbc70fea93f3da introduced a bug in >> dma emulation due to a bad conversion between ioport_register* and >> MemoryRegion. >> >> Cc: 1089...@bugs.launchpad.ne

Re: [Qemu-devel] [PATCH v2 7/7] tmp105: Add temperature QOM property

2012-12-15 Thread Andreas Färber
Am 15.12.2012 17:52, schrieb Alex Horn: >> +static void tmp105_initfn(Object *obj) >> +{ >> +object_property_add(obj, "temperature", "int", >> +tmp105_get_temperature, >> +tmp105_set_temperature, NULL, NULL, NULL); >> +} >> + >> static void tmp10

Re: [Qemu-devel] [PATCH 2/2] tests: Add tmp105 unit test

2012-12-15 Thread Andreas Färber
Am 12.12.2012 15:44, schrieb Alex Horn: > Thanks so much for taking the initiative on creating functional tests > for the TMP105 hardware model. I am exciting to see these changes and > I am wondering if your QTests could be complemented with the following > standalone unit tests: > > > https:/

[Qemu-devel] Panic at shutdown in x86-64 3.7 kernel under qemu 1.3.0?

2012-12-15 Thread Rob Landley
Reasonably vanilla versions of both just did this. No idea why. Just did it the once, haven't gotten it to reproduce... Rob Restarting system. reboot: machine restart general protection fault: fff2 [#1] CPU 0 Pid: 8542, comm: oneit Not tainted 3.7.0 #1 Bochs Bochs RIP: 0010:[] [] lapic_shut

Re: [Qemu-devel] [PATCH] fix dma.c MemoryRegion convertion

2012-12-15 Thread Andreas Färber
Am 15.12.2012 14:45, schrieb Julien Grall: > On Fri, Dec 14, 2012 at 11:39 PM, Marcelo Tosatti wrote: >> >> >> The high byte of the ioport address is necessary to compute >> the register address, see "82371AB PCI ISA IDE Xcelerator (PIIX4)" >> document, eg: >> >> 4.2.1.1. DCOM—DMA Command Register

Re: [Qemu-devel] [PATCH v2 7/7] tmp105: Add temperature QOM property

2012-12-15 Thread Alex Horn
> +static void tmp105_initfn(Object *obj) > +{ > +object_property_add(obj, "temperature", "int", > +tmp105_get_temperature, > +tmp105_set_temperature, NULL, NULL, NULL); > +} > + > static void tmp105_class_init(ObjectClass *klass, void *data) >

[Qemu-devel] [Bug 1090726] [NEW] qemu does not generate guest cpu topology properly

2012-12-15 Thread Ivelin Slavov
Public bug reported: Adding the option -smp 12,sockets=2,cores=6,threads=1 exposes Machine (12GB) Socket #0 L2 L#0 (512KB) + L1 L#0 (64KB) + Core L#0 + PU L#0 (P#0) L2 L#1 (512KB) + L1 L#1 (64KB) + Core L#1 + PU L#1 (P#1) L2 L#2 (512KB) + L1 L#2 (64KB) + Core L#2 + PU

Re: [Qemu-devel] [PATCH 3/4] block: Use new error code for wrong format in selected block drivers

2012-12-15 Thread Don Slutz
On 12/15/12 09:09, Stefan Weil wrote: This improves error reports for bochs, cow, qcow, qcow2, qed and vmdk when a file with the wrong format is selected. Signed-off-by: Stefan Weil --- block/bochs.c |2 +- block/cow.c |2 +- block/qcow.c |2 +- block/qcow2.c |2 +- blo

[Qemu-devel] [PATCH 1/4] block: Add special error code for wrong format

2012-12-15 Thread Stefan Weil
The block drivers normally return -errno for typical errors. There is no appropriate error code for "wrong format", so use a special error code which does not conflict with system error codes. Signed-off-by: Stefan Weil --- block.h |7 +++ 1 file changed, 7 insertions(+) diff --git a/bl

[Qemu-devel] [PATCH 2/4] block: Improve error report for wrong format

2012-12-15 Thread Stefan Weil
There is no good system error for this kind of error, so it needs special handling instead of strerror. Signed-off-by: Stefan Weil --- blockdev.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/blockdev.c b/blockdev.c index 5a4cd56..3da44f6 100644 --- a/blockdev.c

[Qemu-devel] [PATCH 3/4] block: Use new error code for wrong format in selected block drivers

2012-12-15 Thread Stefan Weil
This improves error reports for bochs, cow, qcow, qcow2, qed and vmdk when a file with the wrong format is selected. Signed-off-by: Stefan Weil --- block/bochs.c |2 +- block/cow.c |2 +- block/qcow.c |2 +- block/qcow2.c |2 +- block/qed.c |2 +- block/vmdk.c |4 ++

[Qemu-devel] [PATCH 4/4] block/vdi: Improved return values from vdi_open and other small fixes

2012-12-15 Thread Stefan Weil
vdi_open returned -1 in case of any error, but it should return an error code (negative value of errno or BDRV_WRONG_FORMAT). vdi_open did not check for a bad signature. This check was only in vdi_probe. The signature is a 32 bit value and needs up to 8 hex digits for printing. Signed-off-by: St

[Qemu-devel] [PATCH 0/4] block: Fix error report for wrong file format

2012-12-15 Thread Stefan Weil
These patches improve the error report if the file format was specified explicitly (example: -drive file=myfile,format=qcow2) and the given format does not match the real format. This fixes those bugs: https://bugzilla.redhat.com/show_bug.cgi?id=556482 https://bugs.launchpad.net/qemu/+bug/1090600

Re: [Qemu-devel] [PATCH] fix dma.c MemoryRegion convertion

2012-12-15 Thread Julien Grall
On Fri, Dec 14, 2012 at 11:39 PM, Marcelo Tosatti wrote: > > > The high byte of the ioport address is necessary to compute > the register address, see "82371AB PCI ISA IDE Xcelerator (PIIX4)" > document, eg: > > 4.2.1.1. DCOM—DMA Command Register (IO) > I/O Address: Channels 0–3—08h; Channels 4–7—

Re: [Qemu-devel] [PATCH 09/20] mirror: switch mirror_iteration to AIO

2012-12-15 Thread Eric Blake
On 12/15/2012 02:09 AM, Paolo Bonzini wrote: >>> +/* Allocate a MirrorOp that is used as an AIO callback. */ >>> +op = g_slice_new(MirrorOp); >>> +op->s = s; >>> +op->iov.iov_base = s->buf; >>> +op->iov.iov_len = nb_sectors * 512; >> >> Why two spaces? > > To align the equal

Re: [Qemu-devel] [PATCH] block: Probe file for specified format

2012-12-15 Thread Stefan Weil
Am 15.12.2012 12:35, schrieb Stefan Weil: Probe for the file format if the file format was specified explicitly and a probe function is available. example: -drive file=myfile,format=qcow2 Then myfile is probed and must be in qcow2 format. This fixes those bugs: https://bugzilla.redhat.com/sho

[Qemu-devel] [Bug 1090600] Re: Improve error reporting when -drive format= is incorrect

2012-12-15 Thread Stefan Weil
** Changed in: qemu Assignee: (unassigned) => Stefan Weil (ubuntu-weilnetz) ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1090600 Title:

[Qemu-devel] [PATCH] block: Probe file for specified format

2012-12-15 Thread Stefan Weil
Probe for the file format if the file format was specified explicitly and a probe function is available. example: -drive file=myfile,format=qcow2 Then myfile is probed and must be in qcow2 format. This fixes those bugs: https://bugzilla.redhat.com/show_bug.cgi?id=556482 https://bugs.launchpad.n

Re: [Qemu-devel] big wait check in ram_save_iterate()

2012-12-15 Thread Peter Lieven
Am 15.12.2012 10:02, schrieb Paolo Bonzini: > >> is the check for spending > 50ms in the loop still necessary in qemu >> 1.3.0? > > Yes, it helps finding the available bandwidth and tuning the downtime of > migration. Aha, okay. But then it should also be added to block migration, shoudn't it?

Re: [Qemu-devel] [PULL 00/40] ppc patch queue 2012-12-14

2012-12-15 Thread Blue Swirl
On Fri, Dec 14, 2012 at 12:13 PM, Alexander Graf wrote: > Hi Blue / Aurelien, > > This is my current patch queue for ppc. Please pull. Thanks, pulled. > > Alex > > > The following changes since commit 1c97e303d4ea80a2691334b0febe87a50660f99d: > Anthony Liguori (1): > Merge remote-trac

[Qemu-devel] [PATCH Update] sheepdog: don't update inode when create_and_write fails

2012-12-15 Thread Liu Yuan
From: Liu Yuan For the error case such as SD_RES_NO_SPACE, we shouldn't update the inode bitmap to avoid the scenario that the object is allocated but wasn't created at the server side. This will result in VM's IO error on the failed object. Cc: MORITA Kazutaka Cc: Kevin Wolf Signed-off-by: Li

[Qemu-devel] [PATCH] sheepdog: don't update inode when create_and_write fails

2012-12-15 Thread Liu Yuan
From: Liu Yuan For the error case such as SD_RES_NO_SPACE, we shouldn't update the inode bitmap to avoid the scenario that the object is allocated but wasn't created at the server side. This will result in VM's IO error on the failed object. Cc: MORITA Kazutaka Cc: Kevin Wolf Signed-off-by: Li

[Qemu-devel] [PATCH] sheepdog: don't update inode when create_and_write fails

2012-12-15 Thread Liu Yuan
From: Liu Yuan For the error case such as SD_RES_NO_SPACE, we shouldn't update the inode bitmap to avoid the scenario that the object is allocated but wasn't created at the server side. This will result in VM's IO error on the failed object. Cc: MORITA Kazutaka Cc: Kevin Wolf Signed-off-by: Li

Re: [Qemu-devel] [PATCH 1/3] qtest: Enable creation of multiple qemu instances

2012-12-15 Thread Blue Swirl
On Sat, Dec 15, 2012 at 9:14 AM, Paolo Bonzini wrote: >> > +#define QTEST_FILE_TEMP "/tmp/qtest-%d.sock" >> > +#define QTEST_QMP_FILE_TEMP "/tmp/qtest-%d.qmp" >> > +#define QTEST_PID_FILE_TEMP "/tmp/qtest-%d.pid" >> >> These filenames are too predictable from security point of view, > > This need

Re: [Qemu-devel] big wait check in ram_save_iterate()

2012-12-15 Thread Paolo Bonzini
> is the check for spending > 50ms in the loop still necessary in qemu > 1.3.0? Yes, it helps finding the available bandwidth and tuning the downtime of migration. Paolo

Re: [Qemu-devel] [PATCH 1/3] qtest: Enable creation of multiple qemu instances

2012-12-15 Thread Paolo Bonzini
> > +#define QTEST_FILE_TEMP "/tmp/qtest-%d.sock" > > +#define QTEST_QMP_FILE_TEMP "/tmp/qtest-%d.qmp" > > +#define QTEST_PID_FILE_TEMP "/tmp/qtest-%d.pid" > > These filenames are too predictable from security point of view, This need not be secure as long as the file is created with 0600 permiss

Re: [Qemu-devel] [PATCH 07/20] block: allow customizing the granularity of the dirty bitmap

2012-12-15 Thread Paolo Bonzini
- Messaggio originale - > Da: "Eric Blake" > A: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, kw...@redhat.com, stefa...@redhat.com, > jc...@redhat.com > Inviato: Venerdì, 14 dicembre 2012 22:27:04 > Oggetto: Re: [PATCH 07/20] block: allow customizing the granularity of the > dirty bit

Re: [Qemu-devel] [PATCH 09/20] mirror: switch mirror_iteration to AIO

2012-12-15 Thread Paolo Bonzini
- Messaggio originale - > Da: "Eric Blake" > A: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, kw...@redhat.com, stefa...@redhat.com, > jc...@redhat.com > Inviato: Venerdì, 14 dicembre 2012 23:11:02 > Oggetto: Re: [PATCH 09/20] mirror: switch mirror_iteration to AIO > > On 12/12/2012 06

Re: [Qemu-devel] [PATCH 10/20] mirror: add buf-size argument to drive-mirror

2012-12-15 Thread Paolo Bonzini
> On 12/12/2012 06:46 AM, Paolo Bonzini wrote: > > This makes sense when the next commit starts using the extra buffer > > space > > to perform many I/O operations asynchronously. > > > > Signed-off-by: Paolo Bonzini > > --- > > block/mirror.c | 6 +++--- > > block_int.h| 5

Re: [Qemu-devel] [PATCH 13/20] oslib: add a wrapper for mmap/munmap

2012-12-15 Thread Paolo Bonzini
- Messaggio originale - > Da: "Eric Blake" > A: "Paolo Bonzini" > Cc: qemu-devel@nongnu.org, kw...@redhat.com, stefa...@redhat.com, > jc...@redhat.com > Inviato: Venerdì, 14 dicembre 2012 23:54:31 > Oggetto: Re: [PATCH 13/20] oslib: add a wrapper for mmap/munmap > > On 12/12/2012 06:4

Re: [Qemu-devel] [PATCH] target-xtensa: fix ITLB/DTLB page protection flags

2012-12-15 Thread Blue Swirl
Thanks, applied. On Thu, Dec 13, 2012 at 12:13 AM, Max Filippov wrote: > With MMU option xtensa architecture has two TLBs: ITLB and DTLB. ITLB is > only used for code access, DTLB is only for data. However TLB entries in > both TLBs have attribute field controlling write and exec access. These >

Re: [Qemu-devel] [PATCH 0/5] pixman patch queue

2012-12-15 Thread Blue Swirl
On Fri, Dec 14, 2012 at 7:54 AM, Gerd Hoffmann wrote: > Hi, > > Pixman patch queue, fixing vnc tight/png and tackeling build issues. Thanks, applied all. > > cheers, > Gerd > > Gerd Hoffmann (5): > pixman: fix version check for PIXMAN_TYPE_BGRA > Revert "pixman: require 0.18.4 or newer"

Re: [Qemu-devel] [PATCH] fix dma.c MemoryRegion convertion

2012-12-15 Thread Blue Swirl
On Fri, Dec 14, 2012 at 11:39 PM, Marcelo Tosatti wrote: > > The high byte of the ioport address is necessary to compute > the register address, see "82371AB PCI ISA IDE Xcelerator (PIIX4)" > document, eg: > > 4.2.1.1. DCOM—DMA Command Register (IO) > I/O Address: Channels 0–3—08h; Channels 4–7—0D

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/6] openpic: don't crash on a register access without a CPU context

2012-12-15 Thread Blue Swirl
On Fri, Dec 14, 2012 at 9:58 PM, Alexander Graf wrote: > > On 14.12.2012, at 22:42, Scott Wood wrote: > >> On 12/14/2012 06:35:12 AM, Alexander Graf wrote: >>> On 14.12.2012, at 03:12, Scott Wood wrote: >>> > If we access a register via the QEMU memory inspection commands (e.g. >>> > "xp") rather