Re: [Qemu-devel] [PATCH v2 0/3] re-enable balloon stats

2012-12-14 Thread Dietmar Maurer
> - drop qmp & hmp interface of old stats code I think the old interface is not that bad (the new one is clumsy, because we need 6 qmp call instead of one to get all stats). Can't we try to make it functional and keep it? Seriously, I think 'interval' should be a property we can pass at qemu sta

[Qemu-devel] [Bug 1090615] [NEW] RFE: More info in qemu-img info/check

2012-12-14 Thread Cole Robinson
Public bug reported: Originally filed in Fedora bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=861375 """ qemu-img info currently give me info like this: image: /home/alex/.local/share/gnome-boxes/images/Fedora 16 file format: qcow2 virtual size: 11G (11794287616 bytes) disk size: 4.5G cl

[Qemu-devel] [Bug 1090604] [NEW] RFE: Implement support for SMBIOS Type 41 structures

2012-12-14 Thread Cole Robinson
Public bug reported: This was originally filed in Fedora bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=669955 """ Please extend the existing support for SMBIOS in qemu to add a capability to provide "Onboard Devices Extended Information" (Type 41). Not only is this replacing one of the

[Qemu-devel] [Bug 1090602] [NEW] RFE: Allow specifying usb-host device by serial number

2012-12-14 Thread Cole Robinson
Public bug reported: Currently you can pass through a host USB device to the guest like -device usb-host,vendorid=0x1234,productid=0x5678 Which is all well and good, but has problems if you are trying to assign to identical USB devices to the same guest. It would be useful if there was an add

[Qemu-devel] [Bug 1090600] [NEW] Improve error reporting when -drive format= is incorrect

2012-12-14 Thread Cole Robinson
Public bug reported: With qemu.git as of e376a788ae130454ad5e797f60cb70d0308babb6 $ qemu-img create -f raw test.raw 1M Formatting 'test.raw', fmt=raw size=1048576 $ ./x86_64-softmmu/qemu-system-x86_64 -drive file=./test.raw,format=qcow2 qemu-system-x86_64: -drive file=./test.raw,format=qcow2: c

[Qemu-devel] [PATCH] fix dma.c MemoryRegion convertion

2012-12-14 Thread Marcelo Tosatti
The high byte of the ioport address is necessary to compute the register address, see "82371AB PCI ISA IDE Xcelerator (PIIX4)" document, eg: 4.2.1.1. DCOM—DMA Command Register (IO) I/O Address: Channels 0–3—08h; Channels 4–7—0D0h Also the size of the region is wrong. Fixes WinXP-32 installation

Re: [Qemu-devel] [PATCH 13/20] oslib: add a wrapper for mmap/munmap

2012-12-14 Thread Eric Blake
On 12/12/2012 06:46 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > osdep.h | 10 ++ > oslib-posix.c | 47 +++ > oslib-win32.c | 59 > +++ > 3 files changed, 116 inse

[Qemu-devel] [PATCH] Fix conversion between 12 hours and 24 hours modes.

2012-12-14 Thread Antoine Mathys
The proper mapping between 24 hours and 12 hours modes is: 0 12 AM 1-111-11 AM 12 12 PM 13-23 1-11 PM Fix code accordingly. Signed-off-by: Antoine Mathys --- hw/ds1338.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/ds1338.c b/hw/ds1338.c inde

Re: [Qemu-devel] [PATCH 12/20] mirror: support arbitrarily-sized iterations

2012-12-14 Thread Eric Blake
On 12/12/2012 06:46 AM, Paolo Bonzini wrote: > Yet another optimization is to extend the mirroring iteration to include more > adjacent dirty blocks. This limits the number of I/O operations and makes > mirroring efficient even with a small granularity. Most of the infrastructure > is already in

Re: [Qemu-devel] [PATCH 11/20] mirror: support more than one in-flight AIO operation

2012-12-14 Thread Eric Blake
On 12/12/2012 06:46 AM, Paolo Bonzini wrote: > With AIO support in place, we can start copying more than one chunk > in parallel. This patch introduces the required infrastructure for > this: the buffer is split into multiple granularity-sized chunks, > and there is a free list to access them. >

Re: [Qemu-devel] [PATCH 10/20] mirror: add buf-size argument to drive-mirror

2012-12-14 Thread Eric Blake
On 12/12/2012 06:46 AM, Paolo Bonzini wrote: > This makes sense when the next commit starts using the extra buffer space > to perform many I/O operations asynchronously. > > Signed-off-by: Paolo Bonzini > --- > block/mirror.c | 6 +++--- > block_int.h| 5 +++-- > blockdev.c

Re: [Qemu-devel] [PATCH 09/20] mirror: switch mirror_iteration to AIO

2012-12-14 Thread Eric Blake
On 12/12/2012 06:46 AM, Paolo Bonzini wrote: > There is really no change in the behavior of the job here, since > there is still a maximum of one in-flight I/O operation between > the source and the target. However, this patch already introduces > the AIO callbacks (which are unmodified in the nex

Re: [Qemu-devel] [PATCH 08/20] mirror: allow customizing the granularity

2012-12-14 Thread Eric Blake
On 12/12/2012 06:46 AM, Paolo Bonzini wrote: > The desired granularity may be very different depending on the kind of > operation (e.g. continuous replication vs. collapse-to-raw) and whether > the VM is expected to perform lots of I/O while mirroring is in progress. > > Allow the user to customiz

Re: [Qemu-devel] [PATCH 4/6] openpic: don't crash on a register access without a CPU context

2012-12-14 Thread Alexander Graf
On 14.12.2012, at 22:42, Scott Wood wrote: > On 12/14/2012 06:35:12 AM, Alexander Graf wrote: >> On 14.12.2012, at 03:12, Scott Wood wrote: >> > If we access a register via the QEMU memory inspection commands (e.g. >> > "xp") rather than from guest code, we won't have a CPU context. >> > Graceful

Re: [Qemu-devel] [PATCH 4/6] openpic: don't crash on a register access without a CPU context

2012-12-14 Thread Scott Wood
On 12/14/2012 06:35:12 AM, Alexander Graf wrote: On 14.12.2012, at 03:12, Scott Wood wrote: > If we access a register via the QEMU memory inspection commands (e.g. > "xp") rather than from guest code, we won't have a CPU context. > Gracefully fail to access the register in that case, rather

Re: [Qemu-devel] [PULL] pci,net,misc infrastructure

2012-12-14 Thread Blue Swirl
On Thu, Dec 13, 2012 at 7:26 AM, Michael S. Tsirkin wrote: > The following changes since commit 1c97e303d4ea80a2691334b0febe87a50660f99d: > > Merge remote-tracking branch 'afaerber/qom-cpu' into staging (2012-12-10 > 08:35:15 -0600) > > are available in the git repository at: > > > git://git.

Re: [Qemu-devel] [PATCH 07/20] block: allow customizing the granularity of the dirty bitmap

2012-12-14 Thread Eric Blake
On 12/12/2012 06:46 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > block-migration.c | 5 +++-- > block.c | 17 ++--- > block.h | 5 + > block/mirror.c| 14 -- > qapi-schema.json | 4 +++- > 5 files changed, 21 insertions(+)

[Qemu-devel] [Bug 1090558] [NEW] hw/mc146818: error reading RTC_HOURS_ALARM

2012-12-14 Thread Antoine Mathys
Public bug reported: get_next_alarm() doesn't read the RTC_HOURS_ALARM field correctly. - Bit 7 must be masked before conversion from BCD. - Care must be taken to check the don't care condition before masking. - The PM bit must be read from RTC_HOURS_ALARM, not from RTC_HOURS (as is done in conv

Re: [Qemu-devel] [PATCH v2] build: Use separate makefile for "trace/"

2012-12-14 Thread Lluís Vilanova
I'm really sorry for sending this multiple times. Lluís Vilanova writes: > Signed-off-by: Lluís Vilanova > -- > Changes in v2: > * Do not depend on "qemu-timer-common.o". > * Use "$(obj)" in rules to refer to the build sub-directory. > * Remove dependencies against "$(GENERATED_HEADERS)". > Cc

Re: [Qemu-devel] [PATCH 25/40] openpic: convert to qdev

2012-12-14 Thread Blue Swirl
On Fri, Dec 14, 2012 at 8:42 PM, Alexander Graf wrote: > > On 14.12.2012, at 21:32, Blue Swirl wrote: > >> On Fri, Dec 14, 2012 at 12:13 PM, Alexander Graf wrote: >>> This patch converts the OpenPIC device to qdev. Along the way it >>> renames the "openpic" target to "raven" and the "mpic" target

Re: [Qemu-devel] [PATCH 06/20] block: return count of dirty sectors, not chunks

2012-12-14 Thread Eric Blake
On 12/12/2012 06:46 AM, Paolo Bonzini wrote: > Reviewed-by: Laszlo Ersek > Signed-off-by: Paolo Bonzini > --- > block-migration.c | 2 +- > block.c | 5 ++--- > block/mirror.c| 2 +- > 3 files changed, 4 insertions(+), 5 deletions(-) Reviewed-by: Eric Blake although the commit m

Re: [Qemu-devel] [PATCH 25/40] openpic: convert to qdev

2012-12-14 Thread Alexander Graf
On 14.12.2012, at 21:32, Blue Swirl wrote: > On Fri, Dec 14, 2012 at 12:13 PM, Alexander Graf wrote: >> This patch converts the OpenPIC device to qdev. Along the way it >> renames the "openpic" target to "raven" and the "mpic" target to >> "fsl_mpic_20", to better reflect the actual models they

[Qemu-devel] [PATCH v2] build: Use separate makefile for "trace/"

2012-12-14 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova -- Changes in v2: * Do not depend on "qemu-timer-common.o". * Use "$(obj)" in rules to refer to the build sub-directory. * Remove dependencies against "$(GENERATED_HEADERS)". Cc: Paolo Bonzini --- .gitignore |8 ++-- Makefile

Re: [Qemu-devel] [PATCH v7 03/12] dataplane: add host memory mapping code

2012-12-14 Thread Blue Swirl
On Fri, Dec 14, 2012 at 6:00 PM, Stefan Hajnoczi wrote: > The data plane thread needs to map guest physical addresses to host > pointers. Normally this is done with cpu_physical_memory_map() but the > function assumes the global mutex is held. The data plane thread does > not touch the global mu

Re: [Qemu-devel] [PATCH 25/40] openpic: convert to qdev

2012-12-14 Thread Blue Swirl
On Fri, Dec 14, 2012 at 12:13 PM, Alexander Graf wrote: > This patch converts the OpenPIC device to qdev. Along the way it > renames the "openpic" target to "raven" and the "mpic" target to > "fsl_mpic_20", to better reflect the actual models they implement. > > This way we have a generic OpenPIC

Re: [Qemu-devel] [PATCH 1/3] qtest: Enable creation of multiple qemu instances

2012-12-14 Thread Blue Swirl
On Thu, Dec 13, 2012 at 10:02 PM, Jason Baron wrote: > From: Jason Baron > > Currently, the qtest harness can only spawn 1 qemu instance at a time because > the parent pid is used to create the socket files. Use the child pid instead, > so we can remove that limitation. > > Signed-off-by: Jason B

Re: [Qemu-devel] [PULL] pci,net,misc infrastructure

2012-12-14 Thread Blue Swirl
On Thu, Dec 13, 2012 at 7:26 AM, Michael S. Tsirkin wrote: > The following changes since commit 1c97e303d4ea80a2691334b0febe87a50660f99d: > > Merge remote-tracking branch 'afaerber/qom-cpu' into staging (2012-12-10 > 08:35:15 -0600) > > are available in the git repository at: > > > git://git.

Re: [Qemu-devel] [PATCH 05/20] mirror: perform COW if the cluster size is bigger than the granularity

2012-12-14 Thread Eric Blake
On 12/12/2012 06:46 AM, Paolo Bonzini wrote: > When mirroring runs, the backing files for the target may not yet be > ready. However, this means that a copy-on-write operation on the target > would fill the missing sectors with zeros. Copy-on-write only happens > if the granularity of the dirty b

Re: [Qemu-devel] [PATCH 04/20] block: make round_to_clusters public

2012-12-14 Thread Eric Blake
On 12/12/2012 06:46 AM, Paolo Bonzini wrote: > This is needed in the following patch. > > Reviewed-by: Laszlo Ersek > Signed-off-by: Paolo Bonzini > --- > block.c | 16 > block.h | 4 > 2 files changed, 12 insertions(+), 8 deletions(-) Reviewed-by: Eric Blake -- Eric

[Qemu-devel] [PATCH v2] build: Use separate makefile for "trace/"

2012-12-14 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova -- Changes in v2: * Do not depend on "qemu-timer-common.o". * Use "$(obj)" in rules to refer to the build sub-directory. * Remove dependencies against "$(GENERATED_HEADERS)". Cc: Paolo Bonzini --- .gitignore |8 ++-- Makefile

[Qemu-devel] [PATCH v7 12/12] virtio-blk: add x-data-plane=on|off performance feature

2012-12-14 Thread Stefan Hajnoczi
The virtio-blk-data-plane feature is easy to integrate into hw/virtio-blk.c. The data plane can be started and stopped similar to vhost-net. Users can take advantage of the virtio-blk-data-plane feature using the new -device virtio-blk-pci,x-data-plane=on property. The x-data-plane name was chos

[Qemu-devel] [PATCH v7 06/12] dataplane: add Linux AIO request queue

2012-12-14 Thread Stefan Hajnoczi
The IOQueue has a pool of iocb structs and a function to add new read/write requests. Multiple requests can be added before calling the submit function to actually tell the host kernel to begin I/O. This allows callers to batch requests and submit them in one go. The actual I/O is performed usin

Re: [Qemu-devel] [RFC PATCH] Allow building without graphics support

2012-12-14 Thread Scott Wood
On 12/14/2012 02:13:53 AM, Gerd Hoffmann wrote: Hi, > Yes, I could manually install it, though then I get to deal with telling > the pixman build exactly where to install itself, and repeating the > process for each toolchain and multilib-variant thereof. That part is easy too. You just n

[Qemu-devel] [PATCH v7 01/12] raw-posix: add raw_get_aio_fd() for virtio-blk-data-plane

2012-12-14 Thread Stefan Hajnoczi
The raw_get_aio_fd() function allows virtio-blk-data-plane to get the file descriptor of a raw image file with Linux AIO enabled. This interface is really a layering violation that can be resolved once the block layer is able to run outside the global mutex - at that point virtio-blk-data-plane wi

[Qemu-devel] [PATCH v7 07/12] iov: add iov_discard_front/back() to remove data

2012-12-14 Thread Stefan Hajnoczi
The iov_discard_front/back() functions remove data from the front or back of the vector. This is useful when peeling off header/footer structs. Signed-off-by: Stefan Hajnoczi --- iov.c | 51 +++ iov.h | 13 + 2 files changed, 64 insert

[Qemu-devel] [PATCH v7 03/12] dataplane: add host memory mapping code

2012-12-14 Thread Stefan Hajnoczi
The data plane thread needs to map guest physical addresses to host pointers. Normally this is done with cpu_physical_memory_map() but the function assumes the global mutex is held. The data plane thread does not touch the global mutex and therefore needs a thread-safe memory mapping mechanism.

[Qemu-devel] [PATCH v7 09/12] iov: add qemu_iovec_concat_iov()

2012-12-14 Thread Stefan Hajnoczi
The qemu_iovec_concat() function copies a subset of a QEMUIOVector. The new qemu_iovec_concat_iov() function does the same for a iov/cnt pair. It is easy to define qemu_iovec_concat() in terms of qemu_iovec_concat_iov(). The existing code is mostly unchanged, except for the assertion src->size >

Re: [Qemu-devel] [RFC PATCH] Allow building without graphics support

2012-12-14 Thread Scott Wood
On 12/14/2012 02:07:23 AM, Gerd Hoffmann wrote: Hi, > No, they are with prefix, just not in $PATH. I have more than one > "powerpc-linux-gnu" toolchain and I don't want to mess with my $PATH > constantly to choose between them. # ls -l /usr/bin/*-gcc -rwxr-xr-x. 2 root root 264112 Aug 23 201

[Qemu-devel] [PATCH v7 08/12] test-iov: add iov_discard_front/back() testcases

2012-12-14 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- tests/test-iov.c | 150 +++ 1 file changed, 150 insertions(+) diff --git a/tests/test-iov.c b/tests/test-iov.c index cbe7a89..720d95c 100644 --- a/tests/test-iov.c +++ b/tests/test-iov.c @@ -250,11 +250,161 @@

[Qemu-devel] [PATCH v7 11/12] dataplane: add virtio-blk data plane code

2012-12-14 Thread Stefan Hajnoczi
virtio-blk-data-plane is a subset implementation of virtio-blk. It only handles read, write, and flush requests. It does this using a dedicated thread that executes an epoll(2)-based event loop and processes I/O using Linux AIO. This approach performs very well but can be used for raw image file

[Qemu-devel] [PATCH v7 04/12] dataplane: add virtqueue vring code

2012-12-14 Thread Stefan Hajnoczi
The virtio-blk-data-plane cannot access memory using the usual QEMU functions since it executes outside the global mutex and the memory APIs are this time are not thread-safe. This patch introduces a virtqueue module based on the kernel's vhost vring code. The trick is that we map guest memory ah

[Qemu-devel] [PATCH v7 05/12] dataplane: add event loop

2012-12-14 Thread Stefan Hajnoczi
Outside the safety of the global mutex we need to poll on file descriptors. I found epoll(2) is a convenient way to do that, although other options could replace this module in the future (such as an AioContext-based loop or glib's GMainLoop). One important feature of this small event loop implem

[Qemu-devel] [PATCH] MAINTAINERS: Avi has left

2012-12-14 Thread Andreas Färber
For the kernel, Avi removed himself from their maintainers list. In QEMU such a change was so far not yet applied, and the Red Hat mail server says "Mailbox disabled for this recipient". So avoid his address getting cc'ed on future patches by dropping him from our MAINTAINERS. Signed-off-by: Andre

Re: [Qemu-devel] [PATCH v2 15/17] qapi: Convert delvm

2012-12-14 Thread Eric Blake
On 12/13/2012 08:40 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > hmp-commands.hx | 2 +- > hmp.c| 10 ++ > hmp.h| 1 + > qapi-schema.json | 14 ++ > qmp-commands.hx | 24 > savevm.c | 17 +++-

Re: [Qemu-devel] [PATCH 1/2] add visitor for parsing int[KMGT] input string

2012-12-14 Thread Eduardo Habkost
On Fri, Dec 14, 2012 at 02:20:48PM +0100, Igor Mammedov wrote: > On Wed, 12 Dec 2012 16:16:42 -0200 > Eduardo Habkost wrote: > > > On Mon, Dec 10, 2012 at 10:33:06PM +0100, Igor Mammedov wrote: > > > Caller of visit_type_suffixed_int() have to specify > > > value of 'K' suffix using suffix_factor

Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState

2012-12-14 Thread Eduardo Habkost
On Fri, Dec 14, 2012 at 04:44:24PM +0100, Andreas Färber wrote: > Am 14.12.2012 16:40, schrieb Paolo Bonzini: > > Il 14/12/2012 16:29, Andreas Färber ha scritto: > >> The latest motivation for making the CPU a device was to have the static > >> properties infrastructure for machine/CPU versioning.

Re: [Qemu-devel] [PATCH 3/3] target-i386: replace cpuid_*features fields with a feature word array

2012-12-14 Thread Eduardo Habkost
On Fri, Dec 14, 2012 at 06:47:20PM +0100, Igor Mammedov wrote: > On Fri, 14 Dec 2012 15:36:22 -0200 > Eduardo Habkost wrote: > > > On Fri, Dec 14, 2012 at 06:20:41PM +0100, Andreas Färber wrote: > > > Am 14.12.2012 17:52, schrieb Eduardo Habkost: > > > > On Fri, Dec 14, 2012 at 04:14:32PM +0100,

[Qemu-devel] [PATCH v2] build: Use separate makefile for "trace/"

2012-12-14 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova -- Changes in v2: * Do not depend on "qemu-timer-common.o". * Use "$(obj)" in rules to refer to the build sub-directory. * Remove dependencies against "$(GENERATED_HEADERS)". Cc: Paolo Bonzini --- .gitignore |8 ++-- Makefile

[Qemu-devel] [PATCH] build: Use separate makefile for "trace/"

2012-12-14 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova -- Changes in v2: * Do not depend on "qemu-timer-common.o". * Use "$(obj)" in rules to refer to the build sub-directory. * Remove dependencies against "$(GENERATED_HEADERS)". Cc: Paolo Bonzini --- .gitignore |8 ++-- Makefile

Re: [Qemu-devel] [PATCH v2 14/17] qapi: Convert loadvm

2012-12-14 Thread Eric Blake
On 12/13/2012 08:40 AM, Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > hmp-commands.hx | 4 ++-- > hmp.c| 9 > hmp.h| 1 + > monitor.c| 12 --- > qapi-schema.json | 15 + > qmp-commands.hx | 25 ++ >

Re: [Qemu-devel] [PATCH 4/6] openpic: don't crash on a register access without a CPU context

2012-12-14 Thread Alexander Graf
On 14.12.2012, at 19:18, Scott Wood wrote: > On 12/14/2012 06:35:12 AM, Alexander Graf wrote: >> On 14.12.2012, at 03:12, Scott Wood wrote: >> > If we access a register via the QEMU memory inspection commands (e.g. >> > "xp") rather than from guest code, we won't have a CPU context. >> > Graceful

Re: [Qemu-devel] [PATCH 4/6] openpic: don't crash on a register access without a CPU context

2012-12-14 Thread Scott Wood
On 12/14/2012 06:35:12 AM, Alexander Graf wrote: On 14.12.2012, at 03:12, Scott Wood wrote: > If we access a register via the QEMU memory inspection commands (e.g. > "xp") rather than from guest code, we won't have a CPU context. > Gracefully fail to access the register in that case, rather

[Qemu-devel] big wait check in ram_save_iterate()

2012-12-14 Thread Peter Lieven
Hi, is the check for spending > 50ms in the loop still necessary in qemu 1.3.0? Peter

[Qemu-devel] [PATCH v7 10/12] virtio-blk: restore VirtIOBlkConf->config_wce flag

2012-12-14 Thread Stefan Hajnoczi
Two slightly different versions of a patch to conditionally set VIRTIO_BLK_F_CONFIG_WCE through the "config-wce" qdev property have been applied (ea776abca and eec7f96c2). David Gibson noticed that the "config-wce" property is broken as a result and fixed it recently. The fix sets the host_featu

[Qemu-devel] [PATCH v7 00/12] virtio: virtio-blk data plane

2012-12-14 Thread Stefan Hajnoczi
This series adds the -device virtio-blk-pci,x-data-plane=on property that enables a high performance I/O codepath. A dedicated thread is used to process virtio-blk requests outside the global mutex and without going through the QEMU block layer. Khoa Huynh reported an increase from 140,000 IOPS

[Qemu-devel] [PATCH v7 02/12] configure: add CONFIG_VIRTIO_BLK_DATA_PLANE

2012-12-14 Thread Stefan Hajnoczi
The virtio-blk-data-plane feature only works with Linux AIO. Therefore add a ./configure option and necessary checks to implement this dependency. Signed-off-by: Stefan Hajnoczi --- configure | 21 + 1 file changed, 21 insertions(+) diff --git a/configure b/configure index

Re: [Qemu-devel] [PATCH 3/3] target-i386: replace cpuid_*features fields with a feature word array

2012-12-14 Thread Igor Mammedov
On Fri, 14 Dec 2012 15:36:22 -0200 Eduardo Habkost wrote: > On Fri, Dec 14, 2012 at 06:20:41PM +0100, Andreas Färber wrote: > > Am 14.12.2012 17:52, schrieb Eduardo Habkost: > > > On Fri, Dec 14, 2012 at 04:14:32PM +0100, Andreas Färber wrote: > > >> Am 12.12.2012 23:22, schrieb Eduardo Habkost:

Re: [Qemu-devel] [PATCH 3/3] target-i386: replace cpuid_*features fields with a feature word array

2012-12-14 Thread Eduardo Habkost
On Fri, Dec 14, 2012 at 06:20:41PM +0100, Andreas Färber wrote: > Am 14.12.2012 17:52, schrieb Eduardo Habkost: > > On Fri, Dec 14, 2012 at 04:14:32PM +0100, Andreas Färber wrote: > >> Am 12.12.2012 23:22, schrieb Eduardo Habkost: > >>> This replaces the feature-bit fields on both X86CPU and x86_de

Re: [Qemu-devel] [PATCH 0/5] pixman patch queue

2012-12-14 Thread Stefan Weil
Am 14.12.2012 08:54, schrieb Gerd Hoffmann: Hi, Pixman patch queue, fixing vnc tight/png and tackeling build issues. cheers, Gerd Gerd Hoffmann (5): pixman: fix version check for PIXMAN_TYPE_BGRA Revert "pixman: require 0.18.4 or newer" pixman: update internal copy to pixman-0.2

Re: [Qemu-devel] [[Bug 108996]] hw/dma.c: Fix conversion ioport_register* to MemoryRegion

2012-12-14 Thread Andreas Färber
Am 14.12.2012 10:52, schrieb Julien Grall: > The commit 582299336879504353e60c7937fbc70fea93f3da introduced a bug in > dma emulation due to a bad conversion between ioport_register* and > MemoryRegion. > > Cc: 1089...@bugs.launchpad.net > Reported-by: Andreas Gustafsson > Signed-off-by: Julien G

Re: [Qemu-devel] [PATCH v2 16/17] qapi: Convert info snapshots

2012-12-14 Thread Luiz Capitulino
On Thu, 13 Dec 2012 16:40:50 +0100 Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > hmp.c| 33 + > hmp.h| 1 + > monitor.c| 2 +- > qapi-schema.json | 13 + > qmp-commands.hx | 34 +++

Re: [Qemu-devel] [PATCH 3/3] qtest: add migrate-test

2012-12-14 Thread Paolo Bonzini
> > Do you think this function could be turned into a libqtest call? > > Seems like a good idea. > > > It would take mach_a as an argument, add -incoming > > tcp:localhost: > > to the command line of mach_a, use that to spawn mach_b, and > > why add to mach_a? I thought -incoming is just fo

Re: [Qemu-devel] [PATCH v2 00/17] qapi: Convert savevm, loadvm, delvm and info snapshots

2012-12-14 Thread Luiz Capitulino
On Thu, 13 Dec 2012 16:40:34 +0100 Pavel Hrdina wrote: > This patch series convert these commands into qapi and introduce QMP commands > vm-snapshot-save, vm-snapshot-load, vm-snapshot-delete and query-vm-snapshots. > It also rewrite error report for functions used by these commands. I've review

Re: [Qemu-devel] [PATCH 3/3] target-i386: replace cpuid_*features fields with a feature word array

2012-12-14 Thread Andreas Färber
Am 14.12.2012 17:52, schrieb Eduardo Habkost: > On Fri, Dec 14, 2012 at 04:14:32PM +0100, Andreas Färber wrote: >> Am 12.12.2012 23:22, schrieb Eduardo Habkost: >>> This replaces the feature-bit fields on both X86CPU and x86_def_t >>> structs with an array. >>> >>> With this, we will be able to sim

Re: [Qemu-devel] [PATCH 1/8] Move -I$(SRC_PATH)/include compiler flag to Makefile.objs

2012-12-14 Thread Eduardo Habkost
On Fri, Dec 14, 2012 at 04:34:29PM +0100, Andreas Färber wrote: > Am 05.12.2012 17:49, schrieb Eduardo Habkost: > > The flag is necessary for code that doesn't use the variables from > > Makefile (but use Makefile.objs), like libcacard/ and stubs/. > > > > This also moves the existing CFLAGS lines

Re: [Qemu-devel] [PATCH 3/3] target-i386: replace cpuid_*features fields with a feature word array

2012-12-14 Thread Eduardo Habkost
On Fri, Dec 14, 2012 at 03:53:58PM +0100, Andreas Färber wrote: > Am 14.12.2012 13:27, schrieb Eduardo Habkost: > > On Fri, Dec 14, 2012 at 10:38:50AM +0100, Igor Mammedov wrote: > >> On Wed, 12 Dec 2012 20:22:26 -0200 > >> Eduardo Habkost wrote: > >> > >>> This replaces the feature-bit fields on

Re: [Qemu-devel] [PATCH v2 13/17] qapi: Convert savevm

2012-12-14 Thread Eric Blake
On 12/14/2012 09:57 AM, Luiz Capitulino wrote: >> +## >> +# @vm-snapshot-save: >> +# >> +# Create a snapshot of the whole virtual machine. If tag is provided as >> @name, >> +# it is used as human readable identifier. If there is already a snapshot >> +# with the same tag or ID, it is replaced. >

Re: [Qemu-devel] [PATCH v2 13/17] qapi: Convert savevm

2012-12-14 Thread Luiz Capitulino
On Thu, 13 Dec 2012 16:40:47 +0100 Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > hmp-commands.hx | 4 ++-- > hmp.c| 9 + > hmp.h| 1 + > qapi-schema.json | 19 +++ > qmp-commands.hx | 29 + > savevm.c

[Qemu-devel] [PATCH 1/3] s390: Move IPL code into a separate device

2012-12-14 Thread Jens Freimann
From: Christian Borntraeger Lets move the code to setup IPL for external kernel or via the zipl rom into a separate file. This allows to - define a reboot handler, setting up the PSW appropriately - enhance the boot code to IPL disks that contain a bootmap that was created with zipl under LPAR

Re: [Qemu-devel] [PATCH v2 02/17] block: add error parameter to bdrv_snapshot_create() and related functions

2012-12-14 Thread Luiz Capitulino
[Forgot adding block layer guys, re-sending] On Thu, 13 Dec 2012 16:40:36 +0100 Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > block.c| 26 ++ > block.h| 3 ++- > block/qcow2-snapshot.c | 11 ++- > block/qcow2.h

Re: [Qemu-devel] [PATCH v2 12/17] savevm: add error parameter to qemu_loadvm_state()

2012-12-14 Thread Luiz Capitulino
On Thu, 13 Dec 2012 16:40:46 +0100 Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > migration.c | 8 > savevm.c| 39 +++ > sysemu.h| 3 ++- > 3 files changed, 29 insertions(+), 21 deletions(-) > > diff --git a/migration.c b/migrat

Re: [Qemu-devel] [PATCH 3/3] target-i386: replace cpuid_*features fields with a feature word array

2012-12-14 Thread Eduardo Habkost
On Fri, Dec 14, 2012 at 04:14:32PM +0100, Andreas Färber wrote: > Am 12.12.2012 23:22, schrieb Eduardo Habkost: > > This replaces the feature-bit fields on both X86CPU and x86_def_t > > structs with an array. > > > > With this, we will be able to simplify code that simply does the same > > operati

[Qemu-devel] [PATCH 0/3] s390: ipl device, cpu reset handler and cpu model support

2012-12-14 Thread Jens Freimann
Hi Alex, here's a reworked version of the ipl-device patch, the cpu reset handler and the patch to query cpu definitions via QMP. Viktors cpu query patch now has an #ifdef CONFIG_KVM and the square brackets around "host" in the text output were removed. It provides the basic funtionality we n

[Qemu-devel] [PATCH 2/3] s390: Add CPU reset handler

2012-12-14 Thread Jens Freimann
Add a CPU reset handler to have all CPUs in a PoP compliant state. Signed-off-by: Jens Freimann --- v2 -> v3: * explain in comment which code sets cpu 0 to running during IPL v1 -> v2: * move setting of control registers and psa to s390_cpu_reset and call it from the new s390_machine_cpu_res

[Qemu-devel] [PATCH 3/3] S390: Enable -cpu help and QMP query-cpu-definitions

2012-12-14 Thread Jens Freimann
From: Viktor Mihajlovski This enables qemu -cpu help to return a list of supported CPU models on s390 and also to query for cpu definitions in the monitor. Initially only cpu model = host is returned. This needs to be reworked into a full-fledged CPU model handling later on. This change is needed

Re: [Qemu-devel] [PATCH v2 08/17] savevm: add error parameter to qemu_savevm_state_begin()

2012-12-14 Thread Luiz Capitulino
On Thu, 13 Dec 2012 16:40:42 +0100 Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > migration.c | 2 +- > savevm.c| 7 +-- > sysemu.h| 3 ++- > 3 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/migration.c b/migration.c > index 73ce170..bf51a07 100644 > ---

Re: [Qemu-devel] [PATCH v2 07/17] block: add error parameter to del_existing_snapshots()

2012-12-14 Thread Luiz Capitulino
On Thu, 13 Dec 2012 16:40:41 +0100 Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > savevm.c | 12 > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/savevm.c b/savevm.c > index 7ab7c7c..3ee7da5 100644 > --- a/savevm.c > +++ b/savevm.c > @@ -2094,22 +2094,

Re: [Qemu-devel] [PATCH v2 03/17] block: add error parameter to bdrv_snapshot_goto() and related functions

2012-12-14 Thread Luiz Capitulino
On Thu, 13 Dec 2012 16:40:37 +0100 Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina The same comments I made in the previous patch apply here: you're keeping the error code and converting callers to propagate error in the same patch (which makes this difficult to review). > --- > block.c

Re: [Qemu-devel] [PATCH v2 02/17] block: add error parameter to bdrv_snapshot_create() and related functions

2012-12-14 Thread Luiz Capitulino
On Thu, 13 Dec 2012 16:40:36 +0100 Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > block.c| 26 ++ > block.h| 3 ++- > block/qcow2-snapshot.c | 11 ++- > block/qcow2.h | 4 +++- > block/rbd.c| 17 ++

[Qemu-devel] [[Bug 108996]] hw/dma.c: Fix conversion ioport_register* to MemoryRegion

2012-12-14 Thread Julien Grall
The commit 582299336879504353e60c7937fbc70fea93f3da introduced a bug in dma emulation due to a bad conversion between ioport_register* and MemoryRegion. Cc: 1089...@bugs.launchpad.net Reported-by: Andreas Gustafsson Signed-off-by: Julien Grall --- hw/dma.c | 22 +++--- 1 file

Re: [Qemu-devel] [PATCH 3/3] qtest: add migrate-test

2012-12-14 Thread Jason Baron
On Fri, Dec 14, 2012 at 03:08:21AM -0500, Paolo Bonzini wrote: > > Tests a single 'pc' machine migration on the same host. Currently, > > the test > > fail for q35 since the ahci controller doesn't yet migrate. Will add > > support > > for q35 once the ahci support is accepted. > > > > Would be ni

[Qemu-devel] [PATCH 2/3] balloon: re-enable balloon stats

2012-12-14 Thread Luiz Capitulino
The statistics are now available through device properties via a polling mechanism. First a client has to enable polling, then it can query each stat individually. The following control properties are introduced: o stats-polling-interval: a value greater than zero enables polling in the speci

Re: [Qemu-devel] [PATCH 2/3] qtest: extend qtest_qmp() to fill in the reply

2012-12-14 Thread Jason Baron
On Fri, Dec 14, 2012 at 01:07:24AM +0100, Andreas Färber wrote: > Am 13.12.2012 23:02, schrieb Jason Baron: > > diff --git a/tests/Makefile b/tests/Makefile > > index b60f0fb..30a101d 100644 > > --- a/tests/Makefile > > +++ b/tests/Makefile > > @@ -74,10 +74,10 @@ tests/test-qmp-input-strict$(EXESU

[Qemu-devel] [PATCH 3/3] docs: document virtio-balloon stats

2012-12-14 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- docs/virtio-balloon-stats.txt | 91 +++ 1 file changed, 91 insertions(+) create mode 100644 docs/virtio-balloon-stats.txt diff --git a/docs/virtio-balloon-stats.txt b/docs/virtio-balloon-stats.txt new file mode 100644 in

[Qemu-devel] [PATCH v2 0/3] re-enable balloon stats

2012-12-14 Thread Luiz Capitulino
This new try to re-enable the virtio-balloon driver stats uses QOM properties via a polling mechanism as suggested by Anthony here: http://lists.gnu.org/archive/html/qemu-devel/2012-02/msg02390.html o v2 - drop qmp & hmp interface of old stats code - allow polling callback to run even if the

Re: [Qemu-devel] [PATCH v2 01/17] error: introduce handle_error

2012-12-14 Thread Luiz Capitulino
On Thu, 13 Dec 2012 16:40:35 +0100 Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > error.c | 8 > error.h | 6 ++ > 2 files changed, 14 insertions(+) > > diff --git a/error.c b/error.c > index 128d88c..dd3ab66 100644 > --- a/error.c > +++ b/error.c > @@ -113,3 +113,11 @@

[Qemu-devel] [PATCH 1/3] balloon: drop old stats code & API

2012-12-14 Thread Luiz Capitulino
Next commit will re-enable balloon stats with a different interface, but this old code conflicts with it. Let's drop it. It's important to note that the QMP and HMP interfaces are also dropped by this commit. That shouldn't be a problem though, because: 1. All QMP fields are optional 2. This ha

Re: [Qemu-devel] [PATCH 3/3] target-i386: replace cpuid_*features fields with a feature word array

2012-12-14 Thread Andreas Färber
Am 14.12.2012 13:27, schrieb Eduardo Habkost: > On Fri, Dec 14, 2012 at 10:38:50AM +0100, Igor Mammedov wrote: >> On Wed, 12 Dec 2012 20:22:26 -0200 >> Eduardo Habkost wrote: >> >>> This replaces the feature-bit fields on both X86CPU and x86_def_t >>> structs with an array. >>> >>> With this, we w

Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState

2012-12-14 Thread Andreas Färber
Am 14.12.2012 16:40, schrieb Paolo Bonzini: > Il 14/12/2012 16:29, Andreas Färber ha scritto: >> The latest motivation for making the CPU a device was to have the static >> properties infrastructure for machine/CPU versioning. The global >> property defaults are set in qdev's instance_init, so obje

Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState

2012-12-14 Thread Paolo Bonzini
Il 14/12/2012 16:29, Andreas Färber ha scritto: > The latest motivation for making the CPU a device was to have the static > properties infrastructure for machine/CPU versioning. The global > property defaults are set in qdev's instance_init, so object_new() seems > fine for that. > > qdev_[try_]c

Re: [Qemu-devel] [PATCH 1/8] Move -I$(SRC_PATH)/include compiler flag to Makefile.objs

2012-12-14 Thread Paolo Bonzini
Il 14/12/2012 16:34, Andreas Färber ha scritto: > Am 05.12.2012 17:49, schrieb Eduardo Habkost: >> The flag is necessary for code that doesn't use the variables from >> Makefile (but use Makefile.objs), like libcacard/ and stubs/. >> >> This also moves the existing CFLAGS lines from Makefile.objs a

Re: [Qemu-devel] [PATCH 1/8] Move -I$(SRC_PATH)/include compiler flag to Makefile.objs

2012-12-14 Thread Andreas Färber
Am 05.12.2012 17:49, schrieb Eduardo Habkost: > The flag is necessary for code that doesn't use the variables from > Makefile (but use Makefile.objs), like libcacard/ and stubs/. > > This also moves the existing CFLAGS lines from Makefile.objs at the > beginning of the file, to keep them all in th

Re: [Qemu-devel] [PATCH 8/8] qom: Make CPU a child of DeviceState

2012-12-14 Thread Andreas Färber
Am 12.12.2012 15:27, schrieb Igor Mammedov: > On Wed, 12 Dec 2012 11:59:01 -0200 > Eduardo Habkost wrote: >> On Wed, Dec 12, 2012 at 02:34:08PM +0100, Andreas Färber wrote: >>> This patch makes the CPU a device and looks good so far but does not >>> initialize the devices in cpu_*_init() like Anth

Re: [Qemu-devel] [PATCH 3/3] target-i386: replace cpuid_*features fields with a feature word array

2012-12-14 Thread Andreas Färber
Am 12.12.2012 23:22, schrieb Eduardo Habkost: > This replaces the feature-bit fields on both X86CPU and x86_def_t > structs with an array. > > With this, we will be able to simplify code that simply does the same > operation on all feature words (e.g. kvm_check_features_against_host(), > filter_fe

Re: [Qemu-devel] [PATCH] qxl: save qemu_create_displaysurface_from result

2012-12-14 Thread Markus Armbruster
Gerd Hoffmann writes: > https://bugzilla.redhat.com/show_bug.cgi?id=885644 > > Reported-by: Markus Armbruster > Signed-off-by: Gerd Hoffmann Spotted by Coverity. Impact of the bug unknown; would be nice to have in the commit message. Reviewed-by: Markus Armbruster

Re: [Qemu-devel] [PATCH 3/3] chardev: add hotplug support.

2012-12-14 Thread Paolo Bonzini
Il 14/12/2012 15:19, Gerd Hoffmann ha scritto: > Hi, > >>> ... are you passing a file descriptor for a pipe, a file or a >>> parallel/serial port? >> >> The open function of the file-based backends basically do (1) create >> file handles and (2) call qemu_chr_open_fd(). Right, and there's the u

Re: [Qemu-devel] [PATCH] build: Use separate makefile for "trace/"

2012-12-14 Thread Lluís Vilanova
Paolo Bonzini writes: > Il 14/12/2012 14:46, Lluís Vilanova ha scritto: The thing I like about automake is that it provides a clear set of vars to manage the per-dir builds, thanks to using a per-dir $(MAKE); but I'm not sure how the per-target build would be managed (except by havi

Re: [Qemu-devel] [PATCH 3/3] target-i386: replace cpuid_*features fields with a feature word array

2012-12-14 Thread Eduardo Habkost
On Fri, Dec 14, 2012 at 02:52:50PM +0100, Igor Mammedov wrote: > On Fri, 14 Dec 2012 10:27:34 -0200 > Eduardo Habkost wrote: > > > On Fri, Dec 14, 2012 at 10:38:50AM +0100, Igor Mammedov wrote: > > > On Wed, 12 Dec 2012 20:22:26 -0200 > > > Eduardo Habkost wrote: > > > > > > > This replaces the

[Qemu-devel] [PATCH V8 2/4] Create four opts list related functions

2012-12-14 Thread Dong Xu Wang
This patch will create 4 functions, count_opts_list, append_opts_list, free_opts_list and print_opts_list, they will used in following commits. v6->v7): 1) Fix typo. v5->v6): 1) allocate enough space in append_opts_list function. Signed-off-by: Dong Xu Wang --- qemu-option.c | 90 +++

[Qemu-devel] [PATCH 18/26] usb: Fix usb_ep_find_packet_by_id

2012-12-14 Thread Hans de Goede
usb_ep_find_packet_by_id mistakenly only checks the first packet and if that is not a match, keeps trying the first packet! This patch fixes this. Signed-off-by: Hans de Goede --- hw/usb/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/core.c b/hw/usb/core.c inde

  1   2   3   >