Re: [Qemu-devel] [PULL for-1.3 0/3] seabios: q35 update

2012-12-03 Thread Jan Kiszka
On 2012-12-04 08:40, Gerd Hoffmann wrote: > Hi, > >> 1) legacy ide mode >> >> I can currently create a ide controller on the command-line using >> '-device'. However, on the real h/w there is an IDE compatibility mode >> which essentially advertises an ide controller at the same location that >>

Re: [Qemu-devel] [PULL for-1.3 0/3] seabios: q35 update

2012-12-03 Thread Gerd Hoffmann
Hi, > 1) legacy ide mode > > I can currently create a ide controller on the command-line using > '-device'. However, on the real h/w there is an IDE compatibility mode > which essentially advertises an ide controller at the same location that > the ahci lives at. In fact, it changes the PCI dev

Re: [Qemu-devel] [PATCH][RESEND] iscsi: add support for iSCSI NOPs

2012-12-03 Thread Peter Lieven
On 04.12.2012 06:03, ronnie sahlberg wrote: Acked-By: ronniesahlb...@gmail.com (Ronnie Sahlberg) This verified that the service is actually operational and is much more reliable than TCP-KEEPALIVES. This is the proper way to monitor that the iscsi target is alive. Yes, especially because (at

Re: [Qemu-devel] [PATCH RFT 3/5] usb/ehci: Add SysBus EHCI device for Exynos4210

2012-12-03 Thread walimis
On Mon, Dec 03, 2012 at 10:51:49PM +0400, Igor Mitsyanko wrote: >On 12/02/2012 06:57 AM, Andreas Färber wrote: >>It uses a different capsbase and opregbase than the Xilinx device. >> >>Signed-off-by: Liming Wang >>Signed-off-by: Andreas Färber >>Cc: Igor Mitsyanko >>--- >> hw/usb/hcd-ehci-sysbu

[Qemu-devel] [PATCH] xilinx_zynq: Fix wrong IRQ number of the second EHCI controller

2012-12-03 Thread Liming Wang
The IRQ number of the second EHCI controller should be 76, not 75. Signed-off-by: Liming Wang --- hw/xilinx_zynq.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/xilinx_zynq.c b/hw/xilinx_zynq.c index 1f12a3d..808de68 100644 --- a/hw/xilinx_zynq.c +++ b/hw/xilinx_zynq.

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2012-12-03 Thread Janne Karhunen
So I guess 'raciness' of my proposed patch would only depend on how small I could squeeze the section between 'sigpending' flag comparison and actual syscall entering? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launc

Re: [Qemu-devel] [PATCH 1.3] ehci-sysbus: Attach DMA context.

2012-12-03 Thread walimis
On Tue, Dec 04, 2012 at 03:16:09PM +1000, Peter Crosthwaite wrote: >Hi Liming, Gerd, > >On Tue, Dec 4, 2012 at 12:50 AM, walimis wrote: >> On Mon, Dec 03, 2012 at 01:51:00PM +0100, Gerd Hoffmann wrote: >>> Hi, >>> As said in another mail, I found that the root cause is that xilinx_zynq

Re: [Qemu-devel] vmstate conversion for virtio?

2012-12-03 Thread Michael S. Tsirkin
On Tue, Dec 04, 2012 at 01:39:35PM +1030, Rusty Russell wrote: > Hi all, > > I want to rework the qemu virtio subsystem, but various > structures are currently blatted to disk in save/load. So I looked at > altering that, only to discover that it needs conversion to vmstate, and > 2009 pa

Re: [Qemu-devel] [PATCH 0/5] TCG global gen_opc_ arrays clean-up

2012-12-03 Thread Evgeny Voevodin
On 11/26/2012 08:19 AM, Evgeny Voevodin wrote: On 11/21/2012 11:43 AM, Evgeny Voevodin wrote: This set of patches moves global variables to tcg_ctx: gen_opc_instr gen_opparam_icount gen_opc_pc Build tested for all targets. Execution tested on Exynos4210 target. After this patchset was aplied,

[Qemu-devel] [PATCH v1 4/4] arm_gic: Add cpu nr to Raised IRQ message

2012-12-03 Thread Peter Crosthwaite
Add the relevant CPU nr to this debug message to make IRQ debugging more informative. Signed-off-by: Peter Crosthwaite --- hw/arm_gic.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/arm_gic.c b/hw/arm_gic.c index f9e423f..7a10188 100644 --- a/hw/arm_gic.c +++ b/hw

[Qemu-devel] [PATCH v1 3/4] zynq_slcr: Compile time warning fixes.

2012-12-03 Thread Peter Crosthwaite
Few warnings when compiled with debug printfs enabled. Fixed all. Signed-off-by: Peter Crosthwaite --- hw/zynq_slcr.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/zynq_slcr.c b/hw/zynq_slcr.c index dde4306..f55ab8d 100644 --- a/hw/zynq_slcr.c +++ b/hw/zynq_s

[Qemu-devel] [PATCH v1 2/4] pflash_cfi0x: Send debug messages to stderr

2012-12-03 Thread Peter Crosthwaite
These debug info messages should go to stderr rather than stdout. Signed-off-by: Peter Crosthwaite --- hw/pflash_cfi01.c |8 hw/pflash_cfi02.c |6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/pflash_cfi01.c b/hw/pflash_cfi01.c index f9f8e5d..931264f

[Qemu-devel] [PATCH v1 1/4] pflash_cfi01: qemu_log_mask "unimplemented" msg

2012-12-03 Thread Peter Crosthwaite
This printf is informing the user of unimplemented functionality. It should be re-directed to qemu_log(LOG_UNIMP, ...) accordingly. Signed-off-by: Peter Crosthwaite --- hw/pflash_cfi01.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/pflash_cfi01.c b/hw/pflash_

[Qemu-devel] [PATCH v1 0/4] Trivial patches

2012-12-03 Thread Peter Crosthwaite
My trivial patches from during the freeze. Peter Crosthwaite (4): pflash_cfi01: qemu_log_mask "unimplemented" msg pflash_cfi0x: Send debug messages to stderr zynq_slcr: Compile time warning fixes. arm_gic: Add cpu nr to Raised IRQ message hw/arm_gic.c |2 +- hw/pflash_cfi01.c |

Re: [Qemu-devel] [PATCH 1.3] ehci-sysbus: Attach DMA context.

2012-12-03 Thread Peter Crosthwaite
Hi Liming, Gerd, On Tue, Dec 4, 2012 at 12:50 AM, walimis wrote: > On Mon, Dec 03, 2012 at 01:51:00PM +0100, Gerd Hoffmann wrote: >> Hi, >> >>> As said in another mail, I found that the root cause is that xilinx_zynq has >>> two EHCI controller. If we use usb-storage disk, the disk will be attac

Re: [Qemu-devel] [PATCH][RESEND] iscsi: add support for iSCSI NOPs

2012-12-03 Thread ronnie sahlberg
Acked-By: ronniesahlb...@gmail.com (Ronnie Sahlberg) This verified that the service is actually operational and is much more reliable than TCP-KEEPALIVES. This is the proper way to monitor that the iscsi target is alive. We should as a later patch add the ability to configure this via the qemu c

Re: [Qemu-devel] [PATCH v2] exynos4210/mct: Avoid infinite loop on non incremental timers

2012-12-03 Thread Evgeny Voevodin
On 12/04/2012 02:55 AM, Jean-Christophe DUBOIS wrote: Check for a 0 "distance" value to avoid infinite loop when the expired FCR timer was not programed with auto-increment. With this change the behavior is coherent with the same type of code in the exynos4210_gfrc_restart() function in the same

[Qemu-devel] [PATCH 11/13] pseries: Fixes and enhancements to L1 cache properties

2012-12-03 Thread David Gibson
PAPR requires that the device tree's CPU nodes have several properties with information about the L1 cache. We created two of these properties, but with incorrect names - "[id]cache-block-size" instead of "[id]-cache-block-size" (note the extra hyphen). We were also missing some of the required c

[Qemu-devel] [PATCH 02/13] pseries: Use #define for XICS base irq number

2012-12-03 Thread David Gibson
From: Ben Herrenschmidt Currently the lowest "real" irq number for the XICS irq controller (as opposed to numbers reserved for IPIs and other special purposes) is hard coded as 16 in two places - in xics_system_init() and in spapr.c. As well as being generally bad practice, we're going to need t

[Qemu-devel] [PATCH 05/13] pseries: Add tracepoints to the XICS interrupt controller

2012-12-03 Thread David Gibson
This patch adds tracing / debugging calls to the XICS interrupt controller implementation used on the pseries machine. Signed-off-by: Ben Herrenschmidt Signed-off-by: David Gibson --- hw/xics.c| 23 --- trace-events | 13 + 2 files changed, 33 insertions(

[Qemu-devel] [PATCH 07/13] pseries: Implement PAPR NVRAM

2012-12-03 Thread David Gibson
The PAPR specification requires a certain amount of NVRAM, accessed via RTAS, which we don't currently implement in qemu. This patch addresses this deficiency, implementing the NVRAM as a VIO device, with some glue to instantiate it automatically based on a machine option. The machine option spec

[Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified

2012-12-03 Thread David Gibson
From: Mike Qiu Currently the target-ppc tcg code only supports a single thread. You can specify more, but they're treated identically to multiple cores. On KVM we obviously can't support more threads than the hardware; if more are specified it will cause strange and cryptic errors. This patch

Re: [Qemu-devel] [PATCH] Build system clean generated source files in tests

2012-12-03 Thread Wenchao Xia
Resent for that 1.3 have been released. I think this problem should be fixed otherwise out of tree build fails strangely. >Currently .c files generated in ./tests are not deleted in make > clean. This introduce trouble that, once we made tests in source > root directory, we can't do a succes

[Qemu-devel] [PATCH 09/13] pseries: Don't allow TCE (iommu) tables to be registered with duplicate LIOBNs

2012-12-03 Thread David Gibson
The PAPR specification requires that every bus or device mediated by the IOMMU have a unique Logical IO Bus Number (LIOBN). This patch adds a check to enforce this, which will help catch errors in configuration earlier. Signed-off-by: David Gibson --- hw/spapr_iommu.c |6 ++ 1 file chan

[Qemu-devel] [PATCH 12/13] pseries: Increase default NVRAM size

2012-12-03 Thread David Gibson
If no image file for NVRAM is specified, the pseries machine currently creates a 16K non-persistent NVRAM by default. This basically works, but is not large enough for current firmware and guest kernels to create all the NVRAM partitions they would like to. Increasing the default size to 64K addr

[Qemu-devel] [PATCH 06/13] pseries: Split xics irq configuration from state information

2012-12-03 Thread David Gibson
Currently the XICS irq controller code has a per-irq state structure which amongst other things includes whether the interrupt is level or message triggered - this is configured by the platform code, and is not directly visible to the guest. This leads to a slightly awkward construct at reset time

[Qemu-devel] vmstate conversion for virtio?

2012-12-03 Thread Rusty Russell
Hi all, I want to rework the qemu virtio subsystem, but various structures are currently blatted to disk in save/load. So I looked at altering that, only to discover that it needs conversion to vmstate, and 2009 patches in patchwork which have never been applied. Has there been any progr

Re: [Qemu-devel] [PATCH 13/13] target-ppc: Give a meaningful error if too many threads are specified

2012-12-03 Thread David Gibson
On Tue, Dec 04, 2012 at 01:42:17PM +1100, David Gibson wrote: > From: Mike Qiu Oops, messed this one up, build error for user only builds. Fixed version below. >From d2cc6bcee4737647c4bbbf65d3c0129d4a119dd3 Mon Sep 17 00:00:00 2001 From: Mike Qiu Date: Tue, 4 Dec 2012 10:52:14 +1100 Subject: [

[Qemu-devel] [0/13] Pending pseries/ppc patches as at 1.3 release

2012-12-03 Thread David Gibson
Here's my currently pending set of ready-to-go patches for the pseries machine. A number of these were sent before and may be in the ppc-next tree, but did not make it into 1.3. 10-13 however, are new patches, or at least reworkings of patches that were rejected in their original form. Alex, ple

[Qemu-devel] [PATCH 10/13] target-ppc: Don't use hwaddr to represent hardware state

2012-12-03 Thread David Gibson
The hwaddr type is somewhat vaguely defined as being able to contain bus addresses on the widest possible bus in the system. For that reason it's discouraged for representing specific pieces of persistent hardware state, which should instead use an explicit width type that matches the bits availab

[Qemu-devel] [PATCH 04/13] pseries: Allow RTAS tokens without a qemu handler

2012-12-03 Thread David Gibson
From: Ben Herrenschmidt Kernel-based RTAS calls will not have a qemu handler, but will still be registered in qemu in order to be assigned a token number and appear in the device-tree. Let's test for the name being NULL rather than the handler when deciding to skip an entry while building the de

[Qemu-devel] [PATCH 01/13] pseries: Fix incorrect initialization of interrupt controller

2012-12-03 Thread David Gibson
Currently in the reset code for the XICS interrupt controller, we initialize the pending_priority field to 0 (most favored, by XICS convention). This is incorrect, since there is no pending interrupt, it should be set to least favored - 0xff. At the moment our XICS implementation doesn't get hurt

[Qemu-devel] [PATCH 03/13] pseries: Return the token when we register an RTAS call

2012-12-03 Thread David Gibson
From: Michael Ellerman The kernel will soon be able to service some RTAS calls. However the choice of tokens will still be up to userspace. To support this have spapr_rtas_register() return the token that is allocated for an RTAS call, that allows the calling code to tell the kernel what the toke

Re: [Qemu-devel] [Bug 1075252] Re: qemu-img cannot read VMDK4 file

2012-12-03 Thread Robert Hubbard
Hi Stefan, I have uploaded a patch - I am failing miserably to get any output from git patch!! ... :^( . the code is structured to addres the fact that convert will not work today, needs lots of work to do this. This would be next effort. i have a sub branch ... root@rhubbard qemu]# git statu

[Qemu-devel] [Bug 1075252] Re: qemu-img cannot read VMDK4 file

2012-12-03 Thread Robert Hubbard
Attached Diff to resolve the "open issue" and to also to begin to cater for the fact that an image copy of streamoptimzed format is not supported. This will be added in later fix pending acceptance here. ** Attachment added: "rhubbard-patch-fix-vmdk" https://bugs.launchpad.net/qemu/+bug/107525

Re: [Qemu-devel] [RFC 06/10] qdev: add stubs for vmstate register/unregister functions

2012-12-03 Thread Igor Mammedov
On Fri, 30 Nov 2012 17:27:18 -0200 Eduardo Habkost wrote: > Add vmstate stub functions, so that qdev.o can be used without savevm.o > when vmstate support is not necessary (i.e. by *-user). > > Signed-off-by: Eduardo Habkost > --- > Originally submitted as: > Subject: qdev-core: isolate vmsta

Re: [Qemu-devel] [PATCH] target-i386:slightly refactor dr7 related function

2012-12-03 Thread li guang
在 2012-12-03一的 10:43 +0100,Jan Kiszka写道: > On 2012-12-03 04:07, liguang wrote: > > 1. define names of breakpoints in dr7 > > 2. slightly refactor bits field of breakpoint > >related functions. > > Two topics, (at least) two patches, please. The code is hairy - not your > fault, you actually tr

Re: [Qemu-devel] [PATCH] target-i386:slightly refactor dr7 related function

2012-12-03 Thread li guang
在 2012-12-03一的 12:19 +0100,Andreas Färber写道: > Am 03.12.2012 10:43, schrieb Jan Kiszka: > > On 2012-12-03 04:07, liguang wrote: > >> 1. define names of breakpoints in dr7 > >> 2. slightly refactor bits field of breakpoint > >>related functions. > > > > Two topics, (at least) two patches, pleas

Re: [Qemu-devel] [0/2] Migration bugfixes that were forgotten for 1.3

2012-12-03 Thread Anthony Liguori
David Gibson writes: > I've sent these before, and reminded several times about the first one > at least, but they still slipped through the cracks and didn't make it > into 1.3. The first at least should go into the stable tree - it is a > very simple bugfix for a serious bug (qemu and possibly

[Qemu-devel] [PATCH 2/2] migration: Fix madvise breakage if host and guest have different page sizes

2012-12-03 Thread David Gibson
madvise(DONTNEED) will throw away the contents of the whole page at the given address, even if the given length is less than the page size. One can argue about whether that's the correct behaviour, but that's what it's done for a long time in Linux at least. That means that the madvise() in ram_l

[Qemu-devel] [PATCH 1/2] Fix off-by-1 error in RAM migration code

2012-12-03 Thread David Gibson
The code for migrating (or savevm-ing) memory pages starts off by creating a dirty bitmap and filling it with 1s. Except, actually, because bit addresses are 0-based it fills every bit except bit 0 with 1s and puts an extra 1 beyond the end of the bitmap, potentially corrupting unrelated memory.

[Qemu-devel] [0/2] Migration bugfixes that were forgotten for 1.3

2012-12-03 Thread David Gibson
I've sent these before, and reminded several times about the first one at least, but they still slipped through the cracks and didn't make it into 1.3. The first at least should go into the stable tree - it is a very simple bugfix for a serious bug (qemu and possibly also guest memory corruption).

Re: [Qemu-devel] [PATCH RFT 3/5] usb/ehci: Add SysBus EHCI device for Exynos4210

2012-12-03 Thread walimis
On Mon, Dec 03, 2012 at 10:51:49PM +0400, Igor Mitsyanko wrote: >On 12/02/2012 06:57 AM, Andreas Färber wrote: >>It uses a different capsbase and opregbase than the Xilinx device. >> >>Signed-off-by: Liming Wang >>Signed-off-by: Andreas Färber >>Cc: Igor Mitsyanko >>--- >> hw/usb/hcd-ehci-sysbu

[Qemu-devel] [PATCH 19/43] nbd: fixes to read-only handling

2012-12-03 Thread Michael Roth
From: Paolo Bonzini We do not need BLKROSET if the kernel supports setting flags. Also, always do BLKROSET even for a read-write export, otherwise the read-only state remains "sticky" after the invocation of "qemu-nbd -r". Signed-off-by: Paolo Bonzini (cherry picked from commit c8969eded252058e

[Qemu-devel] [PATCH 25/43] configure: avoid compiler warning in pipe2 detection

2012-12-03 Thread Michael Roth
From: Bruce Rogers When building qemu-kvm for openSUSE:Factory, I am getting a warning in the pipe2 detection performed by configure, which prevents using --enable-werror. Change detection code to use return value of pipe2. Signed-off-by: Bruce Rogers Reviewed-by: Peter Maydell Signed-off-by:

[Qemu-devel] [PATCH 12/43] memory: fix rendering of a region obscured by another

2012-12-03 Thread Michael Roth
From: Avi Kivity The memory core drops regions that are hidden by another region (for example, during BAR sizing), but it doesn't do so correctly if the lower address of the existing range is below the lower address of the new range. Example (qemu-system-mips -M malta -kernel vmlinux-2.6.32-5-4k

[Qemu-devel] [PATCH 24/43] target-openrisc: remove conflicting definitions from cpu.h

2012-12-03 Thread Michael Roth
From: Aurelien Jarno On an ARM host, the registers definitions from cpu.h clash with /usr/include/sys/ucontext.h. As there are unused, just remove them. Cc: Jia Liu Cc: qemu-sta...@nongnu.org Reviewed-by: Peter Maydell Signed-off-by: Aurelien Jarno (cherry picked from commit 44e04d3b945ba6f5c

[Qemu-devel] [PATCH 08/43] rtc: fix overflow in mktimegm

2012-12-03 Thread Michael Roth
From: Paolo Bonzini When setting a date in 1980, Linux is actually disregarding the century byte and setting the year to 2080. This causes a year-2038 overflow in mktimegm. Fix this by doing the days-to-seconds computation in 64-bit math. Reported-by: Lucas Meneghel Rodrigues Signed-off-by: P

[Qemu-devel] [PATCH 09/43] hw: Fix return value check for bdrv_read, bdrv_write

2012-12-03 Thread Michael Roth
From: Stefan Weil Those functions return -errno in case of an error. The old code would typically only detect EPERM (1) errors. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi (cherry picked from commit 7a608f562ebd91e811ed0b725e528c894e4f19c4) Signed-off-by: Michael Roth --- hw/n

[Qemu-devel] [PATCH 07/43] qxl: always update displaysurface on resize

2012-12-03 Thread Michael Roth
From: Gerd Hoffmann Don't try to be clever and skip displaysurface reinitialization in case the size hasn't changed. Other parameters might have changed nevertheless, for example depth or stride, resulting in rendering being broken then. Trigger: boot linux guest with vesafb, start X11, make su

[Qemu-devel] [PATCH 43/43] e1000: Discard packets that are too long if !SBP and !LPE

2012-12-03 Thread Michael Roth
From: Michael Contreras The e1000_receive function for the e1000 needs to discard packets longer than 1522 bytes if the SBP and LPE flags are disabled. The linux driver assumes this behavior and allocates memory based on this assumption. Signed-off-by: Michael Contreras Signed-off-by: Anthony L

[Qemu-devel] [PATCH 23/43] tcg/arm: fix cross-endian qemu_st16

2012-12-03 Thread Michael Roth
From: Aurelien Jarno The bswap16 TCG opcode assumes that the high bytes of the temp equal to 0 before calling it. The ARM backend implementation takes this assumption to slightly optimize the generated code. The same implementation is called for implementing the cross-endian qemu_st16 opcode, wh

Re: [Qemu-devel] [PATCH 1/5] target-i386: cpu: separate feature string parsing from CPU model lookup

2012-12-03 Thread Igor Mammedov
On Mon, 3 Dec 2012 15:27:57 -0200 Eduardo Habkost wrote: > Instead of using parsing the whole cpu_model string inside > cpu_x86_find_by_name(), first split it into the CPU model name and the > full feature string, then parse the feature string into pieces. > > When using CPU model classes, thos

[Qemu-devel] [PATCH 37/43] iscsi: do not assume device is zero initialized

2012-12-03 Thread Michael Roth
From: Peter Lieven Without any complex checks we can't assume that an iscsi target is initialized to zero. Signed-off-by: Peter Lieven Signed-off-by: Paolo Bonzini (cherry picked from commit f807ecd5741325fe0d281199ff22cdda0acb6a7a) Signed-off-by: Michael Roth --- block/iscsi.c |6 +

[Qemu-devel] [PATCH 36/43] iscsi: fix deadlock during login

2012-12-03 Thread Michael Roth
From: Peter Lieven If the connection is interrupted before the first login is successfully completed qemu-kvm is waiting forever in qemu_aio_wait(). This is fixed by performing an sync login to the target. If the connection breaks after the first successful login errors are handled internally by

[Qemu-devel] [PATCH 11/43] e1000: drop check_rxov, always treat RX ring with RDH == RDT as empty

2012-12-03 Thread Michael Roth
From: Dmitry Fleytman Real HW always treats RX ring with RDH == RDT as empty. Emulation is supposed to behave the same. Reported-by: Chris Webb Reported-by: Richard Davies Signed-off-by: Dmitry Fleytman Signed-off-by: Stefan Hajnoczi (cherry picked from commit e5b8b0d4ba29fe1268ba049519a1b0c

Re: [Qemu-devel] Usage of Temperature Sensor (TMP105)

2012-12-03 Thread andrzej zaborowski
Hi Alex, On 1 December 2012 20:39, Alex Horn wrote: > Hello all, > > As I have been browsing through QEMU's source code, I've noticed a > hardware model for a temperature sensor called TMP105. This model > implements the function tmp105_set(I2CSlave *i2c, int temp) declared > in i2c.h [0, 1]. > >

[Qemu-devel] [PATCH 39/43] virtio-scsi: Fix subtle (guest) endian bug

2012-12-03 Thread Michael Roth
From: David Gibson The virtio-scsi config space is, by specification, in guest endian (which is ill-defined, but there you go). In virtio_scsi_get_config() we set up all the fields in there, using stl_raw(). Which is a problem for the max_channel and max_target fields, which are 16-bit, not 32-

[Qemu-devel] [PATCH 40/43] qxl: reload memslots after migration, when qxl is in UNDEFINED mode

2012-12-03 Thread Michael Roth
From: Yonit Halperin The devram memslot stays active when qxl enters UNDEFINED mode (i.e, no primary surface). If migration has occurred while the device is in UNDEFINED stae, the memslots have to be reloaded at the destination. Fixes rhbz#874574 Signed-off-by: Yonit Halperin Signed-off-by: Ge

[Qemu-devel] [PATCH v2] exynos4210/mct: Avoid infinite loop on non incremental timers

2012-12-03 Thread Jean-Christophe DUBOIS
Check for a 0 "distance" value to avoid infinite loop when the expired FCR timer was not programed with auto-increment. With this change the behavior is coherent with the same type of code in the exynos4210_gfrc_restart() function in the same file. Linux seems to mostly use this timer with auto-i

[Qemu-devel] [PATCH 41/43] usb: fail usbdevice_create() when there is no USB bus

2012-12-03 Thread Michael Roth
From: Stefan Hajnoczi Report an error instead of segfaulting when attaching a USB device to a machine with no USB busses: $ qemu-system-arm -machine vexpress-a9 \ -sd Fedora-17-armhfp-vexpress-mmcblk0.img \ -kernel vmlinuz-3.4.2-3.fc17.armv7hl \ -initrd initramfs-3.4.2-3.fc17

[Qemu-devel] [PATCH 42/43] stream: fix ratelimit_set_speed

2012-12-03 Thread Michael Roth
From: Dietmar Maurer The formula to compute slice_quota was wrong since commit 6ef228fc. Signed-off-by: Dietmar Maurer Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf (cherry picked from commit e3980e28bb888bf643054770452998d1b4319609) Signed-off-by: Michael Roth --- include/qemu/ratelim

[Qemu-devel] [PATCH 38/43] virtio-scsi: Fix some endian bugs with virtio-scsi

2012-12-03 Thread Michael Roth
From: David Gibson The virtio-scsi specification does not specify the correct endianness for fields in the request structure. It's therefore best to assume that it is "guest native" endian since that's the (stupid and poorly defined) norm in virtio. However, the qemu device for virtio-scsi has

[Qemu-devel] [PATCH 35/43] iscsi: fix segfault in url parsing

2012-12-03 Thread Michael Roth
From: Peter Lieven If an invalid URL is specified iscsi_get_error(iscsi) is called with iscsi == NULL. Signed-off-by: Peter Lieven Signed-off-by: Paolo Bonzini (cherry picked from commit 8da1e18b0cf46b6c95c88bbad1cc50d6dd1bef4b) Signed-off-by: Michael Roth --- block/iscsi.c |3 +-- 1 fi

Re: [Qemu-devel] [RFC 05/10] qdev: move reset handler list from vl.c to hw/reset.c

2012-12-03 Thread Eduardo Habkost
On Mon, Dec 03, 2012 at 10:20:03PM +0100, Igor Mammedov wrote: > On Fri, 30 Nov 2012 17:27:17 -0200 > Eduardo Habkost wrote: > > > The core qdev code uses the reset handler list from vl.c, and > > currently *-user has some hacks to make CPU reset work. > > > > This moves qemu_register_reset(), q

[Qemu-devel] [PATCH 33/43] qapi: handle visitor->type_size() in QapiDeallocVisitor

2012-12-03 Thread Michael Roth
From: Stefan Hajnoczi visit_type_size() requires either visitor->type_size() or visitor_uint64() to be implemented, otherwise a NULL function pointer is invoked. It is possible to trigger this crash as follows: $ qemu-system-x86_64 -netdev tap,sndbuf=0,id=netdev0 \ -dev

[Qemu-devel] [PATCH 34/43] qapi: fix qapi_dealloc_type_size parameter type

2012-12-03 Thread Michael Roth
From: Bruce Rogers The second parameter to qapi_dealloc_type_size should be a uint64_t *, not a size_t *. This was causing our 32 bit x86 build to fail, since warnings are treated as errors. Signed-off-by: Bruce Rogers Reviewed-by: Michael Roth Reviewed-by: Stefan Weil Signed-off-by: Luiz Cap

[Qemu-devel] [PATCH 06/43] hw/qxl: qxl_dirty_surfaces: use uintptr_t

2012-12-03 Thread Michael Roth
From: Alon Levy As suggested by Paolo Bonzini, to avoid possible integer overflow issues. Signed-off-by: Alon Levy Signed-off-by: Gerd Hoffmann (cherry picked from commit c5825ac6c861bfe1a4adfa27517931b56079e298) Signed-off-by: Michael Roth --- hw/qxl.c |4 ++-- 1 file changed, 2 insert

[Qemu-devel] [PATCH 26/43] qcow2: Fix refcount table size calculation

2012-12-03 Thread Michael Roth
From: Kevin Wolf A missing factor for the refcount table entry size in the calculation could mean that too little memory was allocated for the in-memory representation of the table, resulting in a buffer overflow. Signed-off-by: Kevin Wolf Reviewed-by: Michael Tokarev Tested-by: Michael Tokare

[Qemu-devel] [PATCH 10/43] target-i386: Allow tsc-frequency to be larger then 2.147G

2012-12-03 Thread Michael Roth
From: Don Slutz The check using INT_MAX (2147483647) is wrong in this case. Signed-off-by: Fred Oliveira Signed-off-by: Don Slutz Signed-off-by: Stefan Hajnoczi (cherry picked from commit 2e84849aa2cc7f220d3b3668f5f7e3c57bb1b590) Signed-off-by: Michael Roth --- target-i386/cpu.c |2 +-

[Qemu-devel] [PATCH 27/43] tci: Fix type of tci_read_label

2012-12-03 Thread Michael Roth
From: Richard Henderson Fixes the pointer truncation that was occurring for branches. Cc: Stefan Weil Cc: Blue Swirl Signed-off-by: Richard Henderson Reviewed-by: Stefan Weil Tested-by: Stefan Weil Signed-off-by: Blue Swirl (cherry picked from commit c6c5063c7a5bb1d3fe6b9931a1ec15294e39b8b

[Qemu-devel] [PATCH 31/43] PPC: Fix missing TRACE exception

2012-12-03 Thread Michael Roth
From: Julio Guerra This patch fixes bug 1031698 : https://bugs.launchpad.net/qemu/+bug/1031698 If we look at the (truncated) translation of the conditional branch instruction in the test submitted in the bug post, the call to the exception helper is missing in the "bne-false" chunk of translated

[Qemu-devel] [PATCH 32/43] qom: fix refcount of non-heap-allocated objects

2012-12-03 Thread Michael Roth
From: Paolo Bonzini The reference count for embedded objects is always one too low, because object_initialize_with_type returns with zero references to the object. This causes premature finalization of the object (or an assertion failure) after calling object_ref to add an extra reference and obj

[Qemu-devel] [PATCH 30/43] hmp: do not crash on invalid SCSI hotplug

2012-12-03 Thread Michael Roth
From: Paolo Bonzini Commit 0d93692 (qdev: Convert busses to QEMU Object Model, 2012-05-02) removed a check on the type of the bus where a SCSI disk is hotplugged. However, hot-plugging to the wrong kind of device now causes a crash due to either a NULL pointer dereference (avoided by the previous

[Qemu-devel] [PATCH 29/43] qom: dynamic_cast of NULL is always NULL

2012-12-03 Thread Michael Roth
From: Paolo Bonzini Trying to cast a NULL value will cause a crash. Returning NULL is also sensible, and it is also what the type-unsafe DO_UPCAST macro does. Reported-by: Markus Armbruster Signed-off-by: Paolo Bonzini Signed-off-by: Anthony Liguori (cherry picked from commit b7f43fe46029d8f

[Qemu-devel] [PATCH 28/43] block: Fix regression for MinGW (assertion caused by short string)

2012-12-03 Thread Michael Roth
From: Stefan Weil The local string tmp_filename is passed to function get_tmp_filename which expects a string with minimum size MAX_PATH for w32 hosts. MAX_PATH is 260 and PATH_MAX is 259, so tmp_filename was too short. Commit eba25057b9a5e19d10ace2bc7716667a31297169 introduced this regression.

[Qemu-devel] [PATCH 05/43] uhci: Raise interrupt when requested even for non active tds

2012-12-03 Thread Michael Roth
From: Hans de Goede According to the spec we must raise an interrupt when one is requested even for non active tds. Linux depends on this, for bulk transfers it runs an inactivity timer to work around a bug in early uhci revisions, when we take longer then 200 ms to process a packet, this timer

[Qemu-devel] [PATCH 22/43] tcg/arm: fix TLB access in qemu-ld/st ops

2012-12-03 Thread Michael Roth
From: Aurelien Jarno The TCG arm backend considers likely that the offset to the TLB entries does not exceed 12 bits for mem_index = 0. In practice this is not true for at least the MIPS target. The current patch fixes that by loading the bits 23-12 with a separate instruction, and using loads w

[Qemu-devel] [PATCH 21/43] target-mips: fix wrong microMIPS opcode encoding

2012-12-03 Thread Michael Roth
From: "陳韋任 (Wei-Ren Chen)" While reading microMIPS decoding, I found a possible wrong opcode encoding. According to [1] page 166, the bits 13..12 for MULTU is 0x01 rather than 0x00. Please review, thanks. [1] MIPS Architecture for Programmers VolumeIV-e: The MIPS DSP Application-Specific Ext

[Qemu-devel] [PATCH 18/43] m68k: Return semihosting errno values correctly

2012-12-03 Thread Michael Roth
From: Meador Inge Fixing a simple typo, s/errno/err/, that caused the error status from GDB semihosted system calls to be returned incorrectly. Signed-off-by: Meador Inge Reviewed-by: Andreas Färber Signed-off-by: Peter Maydell Signed-off-by: Blue Swirl (cherry picked from commit aed91c1bff5

[Qemu-devel] [PATCH 17/43] tools: initialize main loop before block layer

2012-12-03 Thread Michael Roth
From: Paolo Bonzini Tools were broken because they initialized the block layer while qemu_aio_context was still NULL. Reported-by: malc Signed-off-by: Paolo Bonzini Signed-off-by: malc (cherry picked from commit 2592c59a66d456fe98fe96cb5787b356c40ee66f) Signed-off-by: Michael Roth --- qemu

[Qemu-devel] [PATCH 14/43] PPC: Bamboo: Fix memory size DT property

2012-12-03 Thread Michael Roth
From: Alexander Graf Device tree properties need to be specified in big endian. Fix the bamboo memory size property accordingly. Signed-off-by: Alexander Graf CC: qemu-sta...@nongnu.org (cherry picked from commit 5232fa59b17b45c04bd24e0d38224964816bf391) Signed-off-by: Michael Roth --- hw/pp

[Qemu-devel] [PATCH 15/43] target-sparc64: disable VGA cirrus

2012-12-03 Thread Michael Roth
From: Aurelien Jarno OpenBIOS on sparc64 only support Standard VGA and not Cirrus VGA. Don't build Cirrus VGA support so that it can't be selected. This fixes the breakage introduced by commit f2898771. Reported-by: Richard Henderson Cc: Blue Swirl Signed-off-by: Aurelien Jarno Tested-by: Ri

[Qemu-devel] [PATCH 13/43] s390x: fix -initrd in virtio machine

2012-12-03 Thread Michael Roth
From: Alexander Graf When using -initrd in the virtio machine, we need to indicate the initrd start and size inside the kernel image. These parameters need to be stored in native endianness. Signed-off-by: Alexander Graf Acked-by: Richard Henderson Acked-by: Christian Borntraeger (cherry pick

[Qemu-devel] [PATCH 20/43] mips/malta: fix CBUS UART interrupt pin

2012-12-03 Thread Michael Roth
From: Aurelien Jarno According to the MIPS Malta Developement Platform User's Manual, the i8259 interrupt controller is supposed to be connected to the hardware IRQ0, and the CBUS UART to the hardware interrupt 2. In QEMU they are both connected to hardware interrupt 0, the CBUS UART interrupt b

[Qemu-devel] [PATCH 16/43] xhci: fix usb name in caps

2012-12-03 Thread Michael Roth
From: Gerd Hoffmann Used to be "UTB" not "USB". Signed-off-by: Gerd Hoffmann (cherry picked from commit 0ebfb144e8ad3f2da436d630fdcc5aa9ab646341) Signed-off-by: Michael Roth --- hw/usb/hcd-xhci.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/h

[Qemu-devel] [PATCH 04/43] vnc: fix "info vnc" with "-vnc ..., reverse=on"

2012-12-03 Thread Michael Roth
From: Paolo Bonzini When reverse connection is in use, there is no active VNC server socket. Because of this, getsockopt(-1, ...) is attempted and the following error is emitted: $ socat TCP-LISTEN:5900,reuseaddr TCP-LISTEN:5901,reuseaddr & $ x86_64-softmmu/qemu-system-x86_64 -vnc local

[Qemu-devel] [PATCH 01/43] configure: Fix CONFIG_QEMU_HELPERDIR generation

2012-12-03 Thread Michael Roth
From: Jan Kiszka We need to evaluate $libexecdir in configure, otherwise we literally end up with "${prefix}/libexec" instead of the absolute path as CONFIG_QEMU_HELPERDIR. Signed-off-by: Jan Kiszka Signed-off-by: Aurelien Jarno (cherry picked from commit 38f419f35225decdbaea9fe1fd00218f8924ce

[Qemu-devel] [PATCH 03/43] ui/vnc: Only report/use TIGHT_PNG encoding if enabled.

2012-12-03 Thread Michael Roth
From: Joel Martin If TIGHT_PNG is not enabled by the --enable-vnc-png configure flag then do not report to the client that it is supported. Also, since TIGHT_PNG is the same as the TIGHT encoding but with the filter/copy replaced with PNG data, adding it to the supported encodings list when it i

[Qemu-devel] [PATCH 02/43] fix CONFIG_QEMU_HELPERDIR generation again

2012-12-03 Thread Michael Roth
From: Michael Tokarev commit 38f419f35225 fixed a breakage with CONFIG_QEMU_HELPERDIR which has been introduced by 8bf188aa18ef7a8. But while techinically that fix has been correct, all other similar variables are handled differently. Make it consistent, and let scripts/create_config expand and

[Qemu-devel] Patch Round-up for stable 1.2.2, freeze Wednesday

2012-12-03 Thread Michael Roth
Hi everyone, The following new patches are queued for QEMU stable v1.2.2: https://github.com/mdroth/qemu/commits/stable-1.2-staging The release is planned for Tuesday, 12-11-2012: http://wiki.qemu.org/Planning/1.2 Please CC qemu-sta...@nongnu.org on any patches you think should be included in

Re: [Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2012-12-03 Thread Peter Maydell
On 3 December 2012 21:20, Alexander Graf wrote: > Could you please try and see if this patch makes a difference? > > http://repo.or.cz/w/qemu/agraf.git/patch/489924aa0115dc6cfcd4e91b0747da4ff8425d1f I think the answer will turn out to be "no" (though it's worth testing anyway), because the syscal

Re: [Qemu-devel] [RFC] 1.4 release schedule

2012-12-03 Thread Anthony Liguori
"Johnson, Eric" writes: > I think you meant to change the 1.3.0 to 1.4.0 for the milestones on > the Wiki. ;-) Indeed, fixed now. Regards, Anthony Liguori > >> -Original Message- >> From: qemu-devel-bounces+ericj=mips@nongnu.org [mailto:qemu-devel- >> bounces+ericj=mips@nongnu

Re: [Qemu-devel] [RFC] 1.4 release schedule

2012-12-03 Thread Johnson, Eric
I think you meant to change the 1.3.0 to 1.4.0 for the milestones on the Wiki. ;-) > -Original Message- > From: qemu-devel-bounces+ericj=mips@nongnu.org [mailto:qemu-devel- > bounces+ericj=mips@nongnu.org] On Behalf Of Anthony Liguori > Sent: Monday, December 03, 2012 1:30 PM > To

[Qemu-devel] [RFC] 1.4 release schedule

2012-12-03 Thread Anthony Liguori
Hi, Based on popular demand, I'd like to continue with a 3-month release cycle for the foreseeable future. One thing I'd like to "fix" though is to avoid major holidays during the -rc cycles. The best cycle I can figure is: Feb 15th May 15th Aug 15th Nov 15th To get us onto this schedule, we'

Re: [Qemu-devel] [RFC 05/10] qdev: move reset handler list from vl.c to hw/reset.c

2012-12-03 Thread Igor Mammedov
On Fri, 30 Nov 2012 17:27:17 -0200 Eduardo Habkost wrote: > The core qdev code uses the reset handler list from vl.c, and > currently *-user has some hacks to make CPU reset work. > > This moves qemu_register_reset(), qemu_unregister_reset() and > qemu_devices_reset() to a new file, hw/reset.c,

Re: [Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2012-12-03 Thread Alexander Graf
On 01.12.2012, at 12:27, Peter Maydell wrote: > On 1 December 2012 10:29, Janne Karhunen <955...@bugs.launchpad.net> wrote: >>> this blocks forever, because the thing that would wake it up is the >> signal handler writing to the pipe we're selecting on, but we will never >> run the signal handler

[Qemu-devel] [ANNOUNCE] 1.4 development tree is now open

2012-12-03 Thread Anthony Liguori
Happy hacking! Regards, Anthony Liguori

[Qemu-devel] [ANNOUNCE] QEMU 1.3.0 release

2012-12-03 Thread Anthony Liguori
Hi, On behalf of the QEMU Team, I'd like to announce the availability of the QEMU 1.3 release! http://wiki.qemu.org/download/qemu-1.3.0.tar.bz2 This release contains over 1700 changesets from 118 unique authors. See the ChangeLog on the wiki for a full changelog: http://wiki.qemu.org/ChangeLog

Re: [Qemu-devel] [RFC 05/10] qdev: move reset handler list from vl.c to hw/reset.c

2012-12-03 Thread Igor Mammedov
On Fri, 30 Nov 2012 17:27:17 -0200 Eduardo Habkost wrote: > The core qdev code uses the reset handler list from vl.c, and > currently *-user has some hacks to make CPU reset work. > > This moves qemu_register_reset(), qemu_unregister_reset() and > qemu_devices_reset() to a new file, hw/reset.c,

  1   2   >