[Qemu-devel] [PATCH V6 09/10] Use QemuOpts support in block layer

2012-11-22 Thread Dong Xu Wang
This patch will use QemuOpts related functions in block layer, add a member bdrv_create_options to BlockDriver struct, it will return a QemuOptsList pointer, which includes the image format's create options. And create options's primary consumer is block creating related functions, so modify them

[Qemu-devel] [PATCH V6 01/10] qemu-option: opt_set(): split it up into more functions

2012-11-22 Thread Dong Xu Wang
The new functions are opts_accepts_any() and find_desc_by_name(), which are also going to be used by qemu_opts_validate() (see next commit). This also makes opt_set() slightly more readable. Signed-off-by: Luiz Capitulino Signed-off-by: Dong Xu Wang --- qemu-option.c | 40 +++

[Qemu-devel] [PATCH V6 03/10] qemu-option: qemu_opt_set_bool(): fix code duplication

2012-11-22 Thread Dong Xu Wang
It will set opt->str in qemu_opt_set_bool, without opt->str, there will be some potential bugs. These are uses of opt->str, and what happens when it isn't set: * qemu_opt_get(): returns NULL, which means "not set". Bug can bite when value isn't the default value. * qemu_opt_parse(): passes NU

[Qemu-devel] [PATCH V6 05/10] use qemu_opts_create_nofail

2012-11-22 Thread Dong Xu Wang
We will use qemu_opts_create_nofail function, it can make code more readable. Signed-off-by: Dong Xu Wang --- blockdev.c |2 +- hw/watchdog.c |2 +- qemu-config.c |4 ++-- qemu-img.c |2 +- qemu-sockets.c | 16 vl.c | 12 +--- 6 fi

[Qemu-devel] [PATCH V6 02/10] qemu-option: qemu_opts_validate(): fix duplicated code

2012-11-22 Thread Dong Xu Wang
Use opts_accepts_any() and find_desc_by_name(). Signed-off-by: Luiz Capitulino Signed-off-by: Dong Xu Wang --- qemu-option.c | 14 +++--- 1 files changed, 3 insertions(+), 11 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 375daaa..74321bb 100644 --- a/qemu-option.c +++

[Qemu-devel] [PATCH V6 00/10] replace QEMUOptionParameter with QemuOpts parser

2012-11-22 Thread Dong Xu Wang
Patch 1-3 are from Luiz, added Markus's comments, discussion could be found here: http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg02716.html Patch 3 was changed according Paolo's comments. Patch 4-5: because qemu_opts_create can not fail while id is null, so create function qemu_opts_c

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Dietmar Maurer
> > Yup, it's already not too bad. I haven't looked into it in much > > detail, but I'd like to reduce it even a bit more. In particular, the > > backup_info field in the BlockDriverState feels wrong to me. In the > > long term the generic block layer shouldn't know at all what a backup > > is, and

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Dietmar Maurer
> In short, the idea is that you can stick filters on top of a > BlockDriverState, so > that any read/writes (and possibly more requests, if necessary) are routed > through the filter before they are passed to the block driver of this BDS. > Filters would be implemented as BlockDrivers, i.e. you c

Re: [Qemu-devel] [PATCH] virtio-scsi Fix some endian bugs with virtio-scsi

2012-11-22 Thread Paolo Bonzini
Il 23/11/2012 06:08, David Gibson ha scritto: > The virtio-scsi specification does not specify the correct endianness for > fields in the request structure. It's therefore best to assume that it is > "guest native" endian since that's the (stupid and poorly defined) norm in > virtio. Indeed. > H

[Qemu-devel] qcow2: slow internal snapshot creation

2012-11-22 Thread Dietmar Maurer
qcow2 snapshot on newly created files are fast: # qemu-img create -f qcow2 test.img 200G # time qemu-img snapshot -c snap1 test.img real 0m0.014s but if metadata is allocated it gets very slow: # qemu-img create -f qcow2 -o "preallocation=metadata" test.img 200G # time qemu-img snapshot -

Re: [Qemu-devel] [PATCH] virtio-scsi Fix some endian bugs with virtio-scsi

2012-11-22 Thread Stefan Hajnoczi
On Fri, Nov 23, 2012 at 04:08:44PM +1100, David Gibson wrote: > The virtio-scsi specification does not specify the correct endianness for > fields in the request structure. It's therefore best to assume that it is > "guest native" endian since that's the (stupid and poorly defined) norm in > virti

Re: [Qemu-devel] [PATCH] event notifier: Fix setup for win32

2012-11-22 Thread Stefan Hajnoczi
On Thu, Nov 22, 2012 at 08:56:11PM +0100, Jan Kiszka wrote: > The event notifier state is only reset by test_and_clear. But we created > the windows event object with auto-reset, which subtly swallowed events. > > Signed-off-by: Jan Kiszka > --- > > Grr, the last place I looked at after hours of

Re: [Qemu-devel] tap devices not receiving packets from a bridge

2012-11-22 Thread Stefan Hajnoczi
On Thu, Nov 22, 2012 at 03:29:52PM +0100, Peter Lieven wrote: > is anyone aware of a problem with the linux network bridge that in very rare > circumstances stops > a bridge from sending pakets to a tap device? > > My problem occurs in conjunction with vanilla qemu-kvm-1.2.0 and Ubuntu > Kernel

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Legacy qemu-kvm options have no argument

2012-11-22 Thread Stefan Hajnoczi
On Thu, Nov 22, 2012 at 10:34:11AM -0200, Luiz Capitulino wrote: > On Wed, 21 Nov 2012 13:12:53 +0100 > Jan Kiszka wrote: > > > On 2012-11-20 16:14, Markus Armbruster wrote: > > > Cc'ing Marcelo & Jan to speed up patch application. > > > > > > Bruce Rogers writes: > > > > > >> The options no-k

Re: [Qemu-devel] [PATCH 1.3] Legacy qemu-kvm options have no argument

2012-11-22 Thread Stefan Hajnoczi
On Tue, Nov 20, 2012 at 07:11:21AM -0700, Bruce Rogers wrote: > The options no-kvm, no-kvm-pit, no-kvm-pit-reinjection, and no-kvm-irqchip > should be marked as having no argument. > > Signed-off-by: Bruce Rogers > --- > qemu-options.hx |8 > 1 files changed, 4 insertions(+), 4 dele

Re: [Qemu-devel] [PATCH for-1.3] usb: tag usb host adapters as not hotpluggable.

2012-11-22 Thread Gerd Hoffmann
On 11/22/12 18:23, Paolo Bonzini wrote: > Il 22/11/2012 14:50, Gerd Hoffmann ha scritto: >> Hotplugging them simply doesn't work, so tag them accordingly to >> avoid users trying and then crashing qemu. >> >> For xhci there is nothing fundamental which prevents hotplug from >> working, we'll "only"

Re: [Qemu-devel] qmp problems with --enable-kvm

2012-11-22 Thread Dietmar Maurer
> We have more timers than the one based on vm_clock. Does this help? Yes, that patch fixes the problem for me. > > diff --git a/qemu-char.c b/qemu-char.c > index 88f4025..242b799 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -134,9 +134,9 @@ static void qemu_chr_fire_open_event(void > *op

[Qemu-devel] [PATCH] Fix spelling in comments and documentation

2012-11-22 Thread Stefan Weil
These spelling bugs were found by codespell: supressing -> suppressing transfered -> transferred Signed-off-by: Stefan Weil --- hw/usb.h |6 +++--- tests/qemu-iotests/iotests.py |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/usb.h b/hw/usb.

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Dietmar Maurer
> To make progress here I'll review the RFC patches. VMDK or not isn't the > main thing, a backup feature like this looks interesting. Yes, a 'review' would be great - thanks. - Dietmar

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Dietmar Maurer
> > The VMDK format has strong disadvantages: > > > > - unclear License (the spec links to patents) > > I've already pointed out that you're taking an inconsistent position on this > point. It's FUD. > > > - they use a very slow compression algorithm (deflate), which makes it > > unusable for ba

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Dietmar Maurer
> But keep in mind that any other company out there could have a patent on > out-of-order data in an image file or other aspects of what you're proposing. Sorry, but the vmware docs explicitly include a pointer to those patents. So this is something completely different to me.

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Stefan Hajnoczi
On Fri, Nov 23, 2012 at 6:23 AM, Stefan Hajnoczi wrote: > On Thu, Nov 22, 2012 at 6:46 PM, Dietmar Maurer wrote: >>> > Did you look at the VMDK "Stream-Optimized Compressed" subformat? >>> >>> We've gone down several sub-threads discussing whether VMDK is suitable. >>> I want to summarize why thi

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Stefan Hajnoczi
On Thu, Nov 22, 2012 at 6:46 PM, Dietmar Maurer wrote: >> > Did you look at the VMDK "Stream-Optimized Compressed" subformat? >> >> We've gone down several sub-threads discussing whether VMDK is suitable. >> I want to summarize why this is a good approach: >> >> The VMDK format already allows for

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Stefan Hajnoczi
On Thu, Nov 22, 2012 at 6:50 PM, Dietmar Maurer wrote: >> The VMDK format has strong disadvantages: >> >> - unclear License (the spec links to patents) >> - they use a very slow compression algorithm (deflate), which makes it >> unusable for backup > > Seems they do not support multiple configurat

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Stefan Hajnoczi
On Thu, Nov 22, 2012 at 7:05 PM, Dietmar Maurer wrote: >> QEMU's implementation has partial support for Stream-Optimized >> Compressed images. If you complete the code for this subformat, not only >> does this benefit the VM Backup feature, but it also makes qemu-img convert >> more powerful for

[Qemu-devel] [PATCH] virtio-scsi Fix some endian bugs with virtio-scsi

2012-11-22 Thread David Gibson
The virtio-scsi specification does not specify the correct endianness for fields in the request structure. It's therefore best to assume that it is "guest native" endian since that's the (stupid and poorly defined) norm in virtio. However, the qemu device for virtio-scsi has no byteswaps at all,

Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges

2012-11-22 Thread David Gibson
On Thu, Nov 22, 2012 at 09:23:03AM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 22, 2012 at 01:27:18PM +1100, David Gibson wrote: > > On Wed, Nov 21, 2012 at 05:27:37PM +0200, Michael S. Tsirkin wrote: > > > On Wed, Nov 21, 2012 at 02:27:08PM +0100, Alexander Graf wrote: > > > > On 11/21/2012 02:

Re: [Qemu-devel] [PATCH v4 00/14] Add Q35 base support

2012-11-22 Thread Jason Baron
On Thu, Nov 22, 2012 at 12:24:43PM +0100, Gerd Hoffmann wrote: > > These patches are intened to give us a base set of patches for Q35 upon > > which > > to build. The major change in this series is to add the memory controller > > hub, > > or 'mch' as proper member of the q35 host structure. This

Re: [Qemu-devel] [PATCH v4 07/14 (re-post)] ich9: Add smbus

2012-11-22 Thread Jason Baron
From: Jason Baron Add support for the ich9 smbus chip. Signed-off-by: Isaku Yamahata Signed-off-by: Jason Baron --- hw/Makefile.objs |2 - hw/smbus_ich9.c | 159 ++ 2 files changed, 160 insertions(+), 1 deletions(-) create mode 10064

Re: [Qemu-devel] [PATCH v4 05/14 (re-post)] ich9: Add acpi support and definitions

2012-11-22 Thread Jason Baron
From: Jason Baron Lay the groundwork for subsequent ich9 support. Signed-off-by: Isaku Yamahata Signed-off-by: Jason Baron --- hw/Makefile.objs |2 hw/acpi_ich9.c | 315 ++ hw/acpi_ich9.h | 47 hw/ich9.h| 207 +

Re: [Qemu-devel] [PATCH] ivshmem: use irqfd to interrupt among VMs

2012-11-22 Thread liu ping fan
On Thu, Nov 22, 2012 at 7:40 PM, Jan Kiszka wrote: > On 2012-11-22 03:48, liu ping fan wrote: >> On Wed, Nov 21, 2012 at 8:43 PM, Jan Kiszka wrote: >>> On 2012-11-21 07:02, Liu Ping Fan wrote: [...] +static int ivshmem_vector_use(PCIDevice *dev, unsigned vector, +

[Qemu-devel] [Bug 873460] Re: Likewise no sound

2012-11-22 Thread Hugo.Batel
I also have the same problem on Ubuntu 12.04.1 64 bits. A fresh install only with likewise open from the repository. Local user have sound but domain user do not! I have tested on 4 diferent machines with diferent hardware and the problem is always the same... -- You received this bug notificat

Re: [Qemu-devel] Interrupt controller updates

2012-11-22 Thread Peter Maydell
On 22 November 2012 21:00, Benjamin Herrenschmidt wrote: > Oh it's simple enough initially, just move the ioctl call from generic > kvm init to machine init. The problem is then to add an argument, since > that essentially means changing the ioctl number, but we need that for > all archs where the

Re: [Qemu-devel] Interrupt controller updates

2012-11-22 Thread Benjamin Herrenschmidt
On Thu, 2012-11-22 at 11:25 +0100, Paolo Bonzini wrote: > > Again, from memory, you were volunteered to do the initial x86 > change so > > we could piggy back on it :-) Or do I remember wrong ? > > Please suggest an API, then we can work out the x86 changes. I can > volunteer myself, but I wasn't

Re: [Qemu-devel] [PATCH] overflow of int ret: use ssize_t for ret

2012-11-22 Thread Stefan Priebe - Profihost AG
Signed-off-by: Stefan Priebe Am 22.11.2012 10:07, schrieb Stefan Priebe: When acb->cmd is WRITE or DISCARD block/rbd stores rcb->size into acb->ret Look here: if (acb->cmd == RBD_AIO_WRITE || acb->cmd == RBD_AIO_DISCARD) { if (r< 0) { acb->ret = r;

[Qemu-devel] [PATCH 0/2] Followup patches regarding block default interface

2012-11-22 Thread Christian Borntraeger
here are two followup patches. Christian Borntraeger (2): block: simply default_drive block: clarify comment about IF_IDE = 0 blockdev.h |6 +- vl.c | 20 ++-- 2 files changed, 11 insertions(+), 15 deletions(-) -- 1.7.9.5

[Qemu-devel] [PATCH 2/2] block: clarify comment about IF_IDE = 0

2012-11-22 Thread Christian Borntraeger
Lets make the comment regarding IF_IDE more precise why it must be 0. Signed-off-by: Christian Borntraeger --- blockdev.h |6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/blockdev.h b/blockdev.h index 1c9ca6a..d73d552 100644 --- a/blockdev.h +++ b/blockdev.h @@ -19,7 +

[Qemu-devel] [PATCH 1/2] block: simply default_drive

2012-11-22 Thread Christian Borntraeger
Markus Armbruster pointed out that there is only one caller to default_drive with IF_DEFAULT as a type. Lets get rid of the block_default_type parameter and adopt the caller to do the right thing (asking the machine struct). Signed-off-by: Christian Borntraeger --- vl.c | 20 ++

[Qemu-devel] [PATCH] event notifier: Fix setup for win32

2012-11-22 Thread Jan Kiszka
The event notifier state is only reset by test_and_clear. But we created the windows event object with auto-reset, which subtly swallowed events. Signed-off-by: Jan Kiszka --- Grr, the last place I looked at after hours of debugging... event_notifier-win32.c |2 +- 1 files changed, 1 inser

Re: [Qemu-devel] [PATCH] overflow of int ret: use ssize_t for ret

2012-11-22 Thread Stefan Weil
Am 22.11.2012 20:09, schrieb Stefan Priebe - Profihost AG: Hi Andreas, thanks for your comment. Do i have to resend this patch? -- Greets, Stefan Hi Stefan, I'm afraid yes, you'll have to resend the patch. Signed-off-by is a must, see http://wiki.qemu.org/Contribute/SubmitAPatch When you

[Qemu-devel] MIPS exception number limits?

2012-11-22 Thread Wei-Ren Chen
Hi all, Wondering why MIPS limits exception number less then 0x100, you can see such example in function do_raise_exception_err (target-mips/op_helper.c). See below, static inline void QEMU_NORETURN do_raise_exception_err(CPUMIPSState *env,

Re: [Qemu-devel] [PATCH] overflow of int ret: use ssize_t for ret

2012-11-22 Thread Stefan Priebe - Profihost AG
Hi Andreas, thanks for your comment. Do i have to resend this patch? -- Greets, Stefan Am 22.11.2012 17:40, schrieb Andreas Färber: Am 22.11.2012 10:07, schrieb Stefan Priebe: When acb->cmd is WRITE or DISCARD block/rbd stores rcb->size into acb->ret Look here: if (acb->cmd == RBD_AIO_WR

Re: [Qemu-devel] [PATCH] target-or32: Improve float exception

2012-11-22 Thread Peter Maydell
On 22 November 2012 18:45, 陳韋任 (Wei-Ren Chen) wrote: >> > +void QEMU_NORETURN do_raise_exception_err(OpenRISCCPU *cpu, >> > + uint32_t exception, >> > + uintptr_t pc) >> > +{ >> > +TranslationBlock *tb; >> > +#if

Re: [Qemu-devel] [PATCH] target-or32: Improve float exception

2012-11-22 Thread Wei-Ren Chen
> > +void QEMU_NORETURN do_raise_exception_err(OpenRISCCPU *cpu, > > + uint32_t exception, > > + uintptr_t pc) > > +{ > > +TranslationBlock *tb; > > +#if 1 > > +if (exception < 0x100) > > +qemu_log("%s

Re: [Qemu-devel] [PATCH] target-or32: Improve float exception

2012-11-22 Thread Wei-Ren Chen
> -void QEMU_NORETURN raise_exception(OpenRISCCPU *cpu, uint32_t excp) > +void QEMU_NORETURN raise_exception(OpenRISCCPU *cpu, uint32_t exception) > { > -cpu->env.exception_index = excp; > +do_raise_exception_err(cpu, exception, 0); > +} > + > +void QEMU_NORETURN do_raise_exception_err(Ope

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Dietmar Maurer
> The VMDK format already allows for out-of-order data and is supported by > existing tools - this is very important for backups where people are > (rightfully) paranoid about putting their backups in an obscure format. They > want to be able to access their data years later, whether your tool is

Re: [Qemu-devel] [PATCH for-1.3] vl.c: Fix broken -usb option

2012-11-22 Thread Li Zhang
On 2012年11月23日 00:48, Peter Maydell wrote: Commit 094b287f0b accidentally broke the "-usb" command line option, so it would have no effect if the user had not specified any machine options at that point. (the return value from 'qemu_opts_find(qemu_find_opts("machine"), 0);' is NULL if there are n

Re: [Qemu-devel] "object_delete: assertion failed: (obj->ref == 0)" deleting usb-storage from monitor

2012-11-22 Thread Paolo Bonzini
Il 22/11/2012 18:05, Peter Maydell ha scritto: > On 4 July 2012 14:51, Peter Maydell wrote: >> On 2 July 2012 18:28, Peter Maydell wrote: >>> If you create a usb-storage device on the qemu command line >>> and then try to delete it via the monitor, QEMU asserts: >>> >>> $ dd if=/dev/zero bs=4096

[Qemu-devel] [PATCH 3/8] ui/vnc-palette.c: Include headers it needs

2012-11-22 Thread Eduardo Habkost
Include: - for g_malloc0() - for memset() Some of those headers were probably being included by accident because some other headers were including qemu-common.h, but those headers should eventually stop including qemu-common.h. Signed-off-by: Eduardo Habkost Signed-off-by: Andreas Färber --

[Qemu-devel] [PATCH 2/8] user: Rename qemu-types.h to qemu-user-types.h

2012-11-22 Thread Eduardo Habkost
The header file is specific for *-user, but I plan to introduce a more generic qemu-types.h file, so I'm renaming it. Signed-off-by: Eduardo Habkost Signed-off-by: Andreas Färber --- bsd-user/qemu.h | 2 +- cpu-all.h | 2 +- linux-user/qemu.h

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Dietmar Maurer
> QEMU's implementation has partial support for Stream-Optimized > Compressed images. If you complete the code for this subformat, not only > does this benefit the VM Backup feature, but it also makes qemu-img convert > more powerful for everyone. I hope we can kill two birds with one stone The

[Qemu-devel] [PATCH 7/8] create qemu-types.h for struct typedefs

2012-11-22 Thread Eduardo Habkost
Instead of keeping all those struct typedefs on qemu-common.h, move it to a header that can be safely included by other headers, containing only the struct typedefs and not pulling other dependencies. Also, move some of the qdev-core.h typedefs to the new file, too, so other headers don't need to

[Qemu-devel] [PATCH 8/8] sysemu.h: include qemu-types.h instead of qemu-common.h

2012-11-22 Thread Eduardo Habkost
It just needs the Monitor and DeviceState typedefs, so it doesn't need all of qemu-common.h. Signed-off-by: Eduardo Habkost --- sysemu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysemu.h b/sysemu.h index f5ac664..ab1ef8b 100644 --- a/sysemu.h +++ b/sysemu.h @@ -2,7 +2,

[Qemu-devel] [PATCH 0/8] qemu-common.h header cleanups

2012-11-22 Thread Eduardo Habkost
Hi, These are the remaining header cleanups that didn't enter the tree yet. They should help breaking some circular header dependencies involving qemu-common.h. Basically they were reordered by Igor to keep the tree bisectable, and some changes were made on the qga/channel-posix.c patch to elimin

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Dietmar Maurer
> The VMDK format has strong disadvantages: > > - unclear License (the spec links to patents) > - they use a very slow compression algorithm (deflate), which makes it > unusable for backup Seems they do not support multiple configuration files. You can only a single text block, and that needs to

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Dietmar Maurer
> > Did you look at the VMDK "Stream-Optimized Compressed" subformat? > > We've gone down several sub-threads discussing whether VMDK is suitable. > I want to summarize why this is a good approach: > > The VMDK format already allows for out-of-order data and is supported by > existing tools - thi

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Dietmar Maurer
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Donnerstag, 22. November 2012 18:02 > To: Dietmar Maurer > Cc: kw...@redhat.com; qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu > (v1) > > On Thu, Nov 22, 201

[Qemu-devel] [PATCH] chardev: Use real-time clock for open timer

2012-11-22 Thread Jan Kiszka
The vm clock may be stopped, and then we won't get open events anymore. Seen with QMP sessions. Reported-by: Dietmar Maurer Tested-by: Luiz Capitulino Signed-off-by: Jan Kiszka --- qemu-char.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-char.c b/qemu-char.c

Re: [Qemu-devel] [PATCH] target-or32: Improve float exception

2012-11-22 Thread Peter Maydell
On 22 November 2012 02:10, Feng Gao wrote: > From: gaofeng This doesn't look like a valid From line... > When float exception raise, can save right pc. > > Signed-off-by: Feng Gao > --- > target-openrisc/exception.c | 35 -- > target-openrisc/exception.h |8

[Qemu-devel] [PATCH 4/8] qapi/qmp-registry.c: Include headers it needs

2012-11-22 Thread Eduardo Habkost
Include: - for g_malloc0() - for strcmp() Some of those headers were probably being included by accident because some other headers were including qemu-common.h, but those headers should eventually stop including qemu-common.h. Signed-off-by: Eduardo Habkost Signed-off-by: Andreas Färber ---

[Qemu-devel] [PATCH 6/8] qlist.h: do not include qemu-common.h

2012-11-22 Thread Eduardo Habkost
I don't know why it was including it, as I don't see any code that depends on anything from qemu-common.h. Signed-off-by: Eduardo Habkost --- qlist.h | 1 - 1 file changed, 1 deletion(-) diff --git a/qlist.h b/qlist.h index ae776f9..7408947 100644 --- a/qlist.h +++ b/qlist.h @@ -15,7 +15,6 @@

[Qemu-devel] [PATCH 5/8] qga/channel-posix.c: Include headers it needs

2012-11-22 Thread Eduardo Habkost
Include: - for errno - & for fcntl() - "osdep.h" for qemu_open() - for exit() Some of those headers were probably being included by accident because some other headers were including qemu-common.h, but those headers should eventually stop including qemu-common.h. Signed-off-by: Eduardo Ha

[Qemu-devel] [PATCH 1/8] user: Move *-user/qemu-types.h to main directory

2012-11-22 Thread Eduardo Habkost
The bsd-user/qemu-types.h and linux-user/qemu-types.h files are almost the same, but linux-user has the additional definitions of tswapal(). This moves the linux-user file to the main directory, so the same file can be used by linux-user and bsd-user. Signed-off-by: Eduardo Habkost Signed-off-by

Re: [Qemu-devel] qmp problems with --enable-kvm

2012-11-22 Thread Luiz Capitulino
On Thu, 22 Nov 2012 18:09:44 +0100 Jan Kiszka wrote: > On 2012-11-22 18:07, Paolo Bonzini wrote: > > Il 22/11/2012 17:58, Luiz Capitulino ha scritto: > > It seems like mon->mc->command_mode is set wrong, looking at > > qmp_cmd_mode and its callers. Luiz may have more ideas. > >

Re: [Qemu-devel] [PATCH for-1.3] usb: tag usb host adapters as not hotpluggable.

2012-11-22 Thread Paolo Bonzini
Il 22/11/2012 14:50, Gerd Hoffmann ha scritto: > Hotplugging them simply doesn't work, so tag them accordingly to > avoid users trying and then crashing qemu. > > For xhci there is nothing fundamental which prevents hotplug from > working, we'll "only" need a exit() function which cleans up > ever

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Stefan Hajnoczi
On Thu, Nov 22, 2012 at 12:12 PM, Stefan Hajnoczi wrote: > On Wed, Nov 21, 2012 at 10:01:00AM +0100, Dietmar Maurer wrote: >> +==Disadvantages== >> + >> +* we need to define a new archive format >> + >> +Note: Most existing archive formats are optimized to store small files >> +including file attr

[Qemu-devel] [PATCH] target-or32: Improve float exception

2012-11-22 Thread Feng Gao
From: gaofeng When float exception raise, can save right pc. Signed-off-by: Feng Gao --- target-openrisc/exception.c | 35 -- target-openrisc/exception.h |8 ++- target-openrisc/fpu_helper.c | 48 +++--- target-openr

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2012-11-22 Thread Ricardo Salveti
I can confirm that this is still an issue even with latest qemu-linaro, from Quantal (1.2.0-2012.09-0ubuntu1). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/955379 Title: cmake hangs with qemu-arm-

Re: [Qemu-devel] qmp problems with --enable-kvm

2012-11-22 Thread Jan Kiszka
On 2012-11-22 18:07, Paolo Bonzini wrote: > Il 22/11/2012 17:58, Luiz Capitulino ha scritto: > It seems like mon->mc->command_mode is set wrong, looking at > qmp_cmd_mode and its callers. Luiz may have more ideas. Checking. What I've just found is that qmp_capabilites will fail i

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2012-11-22 Thread Tim Penhey
I am also having this issue with latest qemu on quantal using an armhf chroot. cmake will occasionally finish, but mostly it just hangs, most often in the pkg_check bits. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.l

[Qemu-devel] [Bug 955379] Re: cmake hangs with qemu-arm-static

2012-11-22 Thread Ricardo Salveti
** Also affects: qemu-linaro Importance: Undecided Status: New ** Also affects: qemu-linaro (Ubuntu) Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bug

Re: [Qemu-devel] qmp problems with --enable-kvm

2012-11-22 Thread Paolo Bonzini
Il 22/11/2012 17:58, Luiz Capitulino ha scritto: It seems like mon->mc->command_mode is set wrong, looking at qmp_cmd_mode and its callers. Luiz may have more ideas. >>> >>> Checking. What I've just found is that qmp_capabilites will fail if the >>> VM is stopped (!?). >> >> It's a regre

Re: [Qemu-devel] "object_delete: assertion failed: (obj->ref == 0)" deleting usb-storage from monitor

2012-11-22 Thread Peter Maydell
On 4 July 2012 14:51, Peter Maydell wrote: > On 2 July 2012 18:28, Peter Maydell wrote: >> If you create a usb-storage device on the qemu command line >> and then try to delete it via the monitor, QEMU asserts: >> >> $ dd if=/dev/zero bs=4096 count=1024 of=usb.img >> $ ./i386-softmmu/qemu-system-

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Stefan Hajnoczi
On Thu, Nov 22, 2012 at 4:58 PM, Dietmar Maurer wrote: >> > The documents says: VMware products are covered by one or more >> patents >> > listed at http://www.vmware.com/go/patents >> > >> > I simply do not have the time to check all those things, which make that >> format unusable for me. >> >>

Re: [Qemu-devel] qmp problems with --enable-kvm

2012-11-22 Thread Luiz Capitulino
On Thu, 22 Nov 2012 14:33:24 -0200 Luiz Capitulino wrote: > On Thu, 22 Nov 2012 14:24:14 -0200 > Luiz Capitulino wrote: > > > > It seems like mon->mc->command_mode is set wrong, looking at > > > qmp_cmd_mode and its callers. Luiz may have more ideas. > > > > Checking. What I've just found is

Re: [Qemu-devel] commit 094b287 "Add USB option in machine options" broke i386 -usb

2012-11-22 Thread Li Zhang
On 2012年11月23日 00:49, Peter Maydell wrote: On 22 November 2012 16:39, Peter Maydell wrote: We use "-usb" to enable USB in this command line. That has to continue to work, for back compatibility. I think your code to try to support -usb is broken: case QEMU_OPTION_usb: machine_opts = qem

Re: [Qemu-devel] commit 094b287 "Add USB option in machine options" broke i386 -usb

2012-11-22 Thread Peter Maydell
On 22 November 2012 16:39, Peter Maydell wrote: > We use "-usb" to enable USB in this command line. That has > to continue to work, for back compatibility. I think your > code to try to support -usb is broken: > case QEMU_OPTION_usb: > machine_opts = qemu_opts_find(qemu_find_opts("machine"),

[Qemu-devel] [PATCH for-1.3] vl.c: Fix broken -usb option

2012-11-22 Thread Peter Maydell
Commit 094b287f0b accidentally broke the "-usb" command line option, so it would have no effect if the user had not specified any machine options at that point. (the return value from 'qemu_opts_find(qemu_find_opts("machine"), 0);' is NULL if there are no user specified options, so it is only to be

Re: [Qemu-devel] commit 094b287 "Add USB option in machine options" broke i386 -usb

2012-11-22 Thread Li Zhang
On 2012年11月23日 00:44, Alexander Graf wrote: On 22.11.2012, at 17:39, Peter Maydell wrote: On 22 November 2012 16:34, Li Zhang wrote: On 2012年11月23日 00:18, Peter Maydell wrote: On 29 October 2012 10:25, Alexander Graf wrote: From: zhlci...@gmail.com When -usb option is used, global varibl

Re: [Qemu-devel] commit 094b287 "Add USB option in machine options" broke i386 -usb

2012-11-22 Thread Alexander Graf
On 22.11.2012, at 17:39, Peter Maydell wrote: > On 22 November 2012 16:34, Li Zhang wrote: >> On 2012年11月23日 00:18, Peter Maydell wrote: >>> >>> On 29 October 2012 10:25, Alexander Graf wrote: From: zhlci...@gmail.com When -usb option is used, global varible usb_enabled

[Qemu-devel] [PATCH] xen: implement support for secondary consoles in the console backend

2012-11-22 Thread Stefano Stabellini
This patch corresponds to commit 840184a106bc24e745beda5c77e392f6cecd2bc9 from git://xenbits.xensource.com/qemu-xen-unstable.git. Signed-off-by: Stefano Stabellini diff --git a/hw/xen_console.c b/hw/xen_console.c index 9426d73..1349881 100644 --- a/hw/xen_console.c +++ b/hw/xen_console.c @@ -184

Re: [Qemu-devel] commit 094b287 "Add USB option in machine options" broke i386 -usb

2012-11-22 Thread Li Zhang
On 2012年11月23日 00:39, Peter Maydell wrote: On 22 November 2012 16:34, Li Zhang wrote: On 2012年11月23日 00:18, Peter Maydell wrote: On 29 October 2012 10:25, Alexander Graf wrote: From: zhlci...@gmail.com When -usb option is used, global varible usb_enabled is set. And all the plaform will cr

Re: [Qemu-devel] [PATCH] overflow of int ret: use ssize_t for ret

2012-11-22 Thread Andreas Färber
Am 22.11.2012 10:07, schrieb Stefan Priebe: > When acb->cmd is WRITE or DISCARD block/rbd stores rcb->size into acb->ret > > Look here: >if (acb->cmd == RBD_AIO_WRITE || > acb->cmd == RBD_AIO_DISCARD) { > if (r < 0) { > acb->ret = r; > acb->error = 1; >

Re: [Qemu-devel] commit 094b287 "Add USB option in machine options" broke i386 -usb

2012-11-22 Thread Peter Maydell
On 22 November 2012 16:34, Li Zhang wrote: > On 2012年11月23日 00:18, Peter Maydell wrote: >> >> On 29 October 2012 10:25, Alexander Graf wrote: >>> >>> From: zhlci...@gmail.com >>> >>> When -usb option is used, global varible usb_enabled is set. >>> And all the plaform will create one USB controll

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Stefan Hajnoczi
On Thu, Nov 22, 2012 at 4:56 PM, Dietmar Maurer wrote: >> It's a naughty thing to do but we could simply pick a new constant and >> support LZO as an incompatible option. The file is then no longer compatible >> with existing vmdk tools but at least we then have a choice of using >> compatible de

Re: [Qemu-devel] commit 094b287 "Add USB option in machine options" broke i386 -usb

2012-11-22 Thread Li Zhang
On 2012年11月23日 00:18, Peter Maydell wrote: On 29 October 2012 10:25, Alexander Graf wrote: From: zhlci...@gmail.com When -usb option is used, global varible usb_enabled is set. And all the plaform will create one USB controller according to this variable. In fact, global varibles make code ha

Re: [Qemu-devel] qmp problems with --enable-kvm

2012-11-22 Thread Luiz Capitulino
On Thu, 22 Nov 2012 14:24:14 -0200 Luiz Capitulino wrote: > > It seems like mon->mc->command_mode is set wrong, looking at > > qmp_cmd_mode and its callers. Luiz may have more ideas. > > Checking. What I've just found is that qmp_capabilites will fail if the > VM is stopped (!?). It's a regres

Re: [Qemu-devel] qmp problems with --enable-kvm

2012-11-22 Thread Luiz Capitulino
On Thu, 22 Nov 2012 17:09:24 +0100 Paolo Bonzini wrote: > Il 22/11/2012 17:04, Dietmar Maurer ha scritto: > >> Ok, in any case Jan's patch was for a QEMU that didn't start at all with -- > >> > enable-kvm -monitor stdio, i.e. really unrelated. Right. When I saw qmp and --enable-kvm in the same s

[Qemu-devel] commit 094b287 "Add USB option in machine options" broke i386 -usb

2012-11-22 Thread Peter Maydell
On 29 October 2012 10:25, Alexander Graf wrote: > From: zhlci...@gmail.com > > When -usb option is used, global varible usb_enabled is set. > And all the plaform will create one USB controller according > to this variable. In fact, global varibles make code hard > to read. > > So this patch is to

Re: [Qemu-devel] qmp problems with --enable-kvm

2012-11-22 Thread Paolo Bonzini
Il 22/11/2012 17:04, Dietmar Maurer ha scritto: >> Ok, in any case Jan's patch was for a QEMU that didn't start at all with -- >> > enable-kvm -monitor stdio, i.e. really unrelated. >> > >> > In any case, I cannot reproduce it here. > Any idea what can cause such behaviour? It seems like mon->mc-

Re: [Qemu-devel] qmp problems with --enable-kvm

2012-11-22 Thread Dietmar Maurer
> Ok, in any case Jan's patch was for a QEMU that didn't start at all with -- > enable-kvm -monitor stdio, i.e. really unrelated. > > In any case, I cannot reproduce it here. Any idea what can cause such behaviour?

Re: [Qemu-devel] [PATCH v4 2/2] qemu-ga: sample fsfreeze hooks

2012-11-22 Thread Luiz Capitulino
On Thu, 22 Nov 2012 11:15:49 +0900 Tomoki Sekiyama wrote: > Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. > - fsfreeze-hook : execute scripts in fsfreeze-hook.d/ > - fsfreeze-hook.d.sample/mysql-flush.sh : quiesce MySQL before snapshot > > Signed-off-by: Tomoki Sekiyama >

Re: [Qemu-devel] qmp problems with --enable-kvm

2012-11-22 Thread Paolo Bonzini
Il 22/11/2012 16:53, Dietmar Maurer ha scritto: > The interesting thing is that it works perfectly without --enable-kvm. >>> > > Can you please try the following patch? >>> > > >>> > > https://lists.gnu.org/archive/html/qemu-devel/2012-11/msg00174.html >> > >> > I don't think that's related.

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Dietmar Maurer
> > The documents says: VMware products are covered by one or more > patents > > listed at http://www.vmware.com/go/patents > > > > I simply do not have the time to check all those things, which make that > format unusable for me. > > In think proxmox ships the QEMU vmdk functionality today? In t

Re: [Qemu-devel] [PATCH 1/5] RFC: Efficient VM backup for qemu (v1)

2012-11-22 Thread Dietmar Maurer
> It's a naughty thing to do but we could simply pick a new constant and > support LZO as an incompatible option. The file is then no longer compatible > with existing vmdk tools but at least we then have a choice of using > compatible deflate or the LZO extension. To be 100% incompatible to exis

Re: [Qemu-devel] [PATCH] Reorder alarm timer setup again

2012-11-22 Thread Jan Kiszka
On 2012-11-22 16:07, Luiz Capitulino wrote: > On Thu, 01 Nov 2012 17:25:24 +0100 > Jan Kiszka wrote: > >> From: Jan Kiszka >> >> ac4119c023 moved the alarm timer initialization to an earlier point but >> failed to consider that it depends on qemu_init_main_loop. Instead of >> moving the wrong th

Re: [Qemu-devel] [PATCH v4 1/2] qemu-ga: execute hook to quiesce the guest on fsfreeze-freeze/thaw

2012-11-22 Thread Luiz Capitulino
On Thu, 22 Nov 2012 11:15:46 +0900 Tomoki Sekiyama wrote: > To use the online disk snapshot for online-backup, application-level > consistency of the snapshot image is required. However, currently the > guest agent can provide only filesystem-level consistency, and the > snapshot may contain dirt

Re: [Qemu-devel] [PATCH v2 39/39] raw-win32: implement native asynchronous I/O

2012-11-22 Thread Jan Kiszka
On 2012-11-22 16:16, Paolo Bonzini wrote: > Il 22/11/2012 14:34, Jan Kiszka ha scritto: >> >> =>0 0xf77c242e __kernel_vsyscall+0xe() in [vdso].so (0x0519df88) >> 1 0xf761f10b __libc_read+0x4a() in libpthread.so.0 (0x0519df88) >> 2 0x7bc78c98 in ntdll (+0x68c97) (0x0519df88) >> 3 0x7bc7b0a3 in

Re: [Qemu-devel] qmp problems with --enable-kvm

2012-11-22 Thread Dietmar Maurer
> >> > The interesting thing is that it works perfectly without --enable-kvm. > > Can you please try the following patch? > > > > https://lists.gnu.org/archive/html/qemu-devel/2012-11/msg00174.html > > I don't think that's related. The only problem I see here, is that > "qmp_capabilities" can on

[Qemu-devel] [PATCH v4 02/11] configure: add CONFIG_VIRTIO_BLK_DATA_PLANE

2012-11-22 Thread Stefan Hajnoczi
The virtio-blk-data-plane feature only works with Linux AIO. Therefore add a ./configure option and necessary checks to implement this dependency. Signed-off-by: Stefan Hajnoczi --- configure | 21 + 1 file changed, 21 insertions(+) diff --git a/configure b/configure index

  1   2   3   >