Re: [Qemu-devel] [PATCH V10 4/7] libqblock build system

2012-11-20 Thread Paolo Bonzini
Il 21/11/2012 04:03, Wenchao Xia ha scritto: >> >>> +libqblock="yes" >> >> Please make the default the empty string, i.e. "build if and only if >> libtool is present". >> > Do you mean adding a probe section later that if libtool is present, > its default is "yes", else set it to "no"? Here, you

[Qemu-devel] [PATCH 0/5] TCG global gen_opc_ arrays clean-up

2012-11-20 Thread Evgeny Voevodin
This set of patches moves global variables to tcg_ctx: gen_opc_instr gen_opparam_icount gen_opc_pc Build tested for all targets. Execution tested on Exynos4210 target. After this patchset was aplied, I noticed no speed-up or slow-down of code generation. Here is the test procedure: 1. Boot Linux

Re: [Qemu-devel] 879e45c72da1569e07fbbc6a1aa2a708ea796044 breakage

2012-11-20 Thread Paolo Bonzini
Il 21/11/2012 08:14, malc ha scritto: > > Commit in the subject broke inet parsing (noticed by a build on a remote > system without X and only internal vnc server that by default uses > localhost:0,to=99), following was probably intended, but you're never > sure: > > diff --git a/qemu-sockets.c b

Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int

2012-11-20 Thread Stefan Priebe - Profihost AG
Am 21.11.2012 07:41, schrieb Stefan Hajnoczi: On Tue, Nov 20, 2012 at 8:16 PM, Stefan Priebe wrote: Hi Stefan, Am 20.11.2012 17:29, schrieb Stefan Hajnoczi: On Tue, Nov 20, 2012 at 01:44:55PM +0100, Stefan Priebe wrote: rbd / rados tends to return pretty often length of writes or discarded

[Qemu-devel] [PATCH 2/5] TCG: Use gen_opc_pc from context instead of global variable.

2012-11-20 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin --- target-alpha/translate.c |4 ++-- target-arm/translate.c|4 ++-- target-cris/translate.c |6 +++--- target-i386/translate.c |9 + target-lm32/translate.c |4 ++-- target-m68k/translate.c |4 ++-

[Qemu-devel] [PATCH 3/5] TCG: Use gen_opc_icount from context instead of global variable.

2012-11-20 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin --- target-alpha/translate.c |2 +- target-arm/translate.c|2 +- target-cris/translate.c |2 +- target-i386/translate.c |2 +- target-lm32/translate.c |2 +- target-m68k/translate.c |2 +- target-microblaz

[Qemu-devel] [PATCH 1/5] tcg/tcg.h: Duplicate global TCG gen_opc_ arrays into TCGContext.

2012-11-20 Thread Evgeny Voevodin
Signed-off-by: Evgeny Voevodin --- tcg/tcg.h |3 +++ 1 file changed, 3 insertions(+) diff --git a/tcg/tcg.h b/tcg/tcg.h index 9481e35..f6e255f 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -455,6 +455,9 @@ struct TCGContext { uint16_t *gen_opc_ptr; TCGArg *gen_opparam_ptr; +targe

[Qemu-devel] 879e45c72da1569e07fbbc6a1aa2a708ea796044 breakage

2012-11-20 Thread malc
Commit in the subject broke inet parsing (noticed by a build on a remote system without X and only internal vnc server that by default uses localhost:0,to=99), following was probably intended, but you're never sure: diff --git a/qemu-sockets.c b/qemu-sockets.c index cfed9c5..e7272c8 100644 --- a/

Re: [Qemu-devel] [PATCH 0/7] virtio: virtio-blk data plane

2012-11-20 Thread Asias He
On 11/21/2012 02:44 PM, Stefan Hajnoczi wrote: > On Wed, Nov 21, 2012 at 7:42 AM, Asias He wrote: >> On 11/21/2012 01:39 PM, Asias He wrote: >>> On 11/20/2012 08:25 PM, Stefan Hajnoczi wrote: On Tue, Nov 20, 2012 at 1:21 PM, Stefan Hajnoczi wrote: > On Tue, Nov 20, 2012 at 10:02 AM

Re: [Qemu-devel] [PATCH 3/7] target-mips: add unions to access DSP elements

2012-11-20 Thread Johnson, Eric
> -Original Message- > From: qemu-devel-bounces+ericj=mips@nongnu.org [mailto:qemu-devel- > bounces+ericj=mips@nongnu.org] On Behalf Of Aurelien Jarno > Sent: Friday, November 16, 2012 3:04 AM > To: qemu-devel@nongnu.org > Cc: Aurelien Jarno > Subject: [Qemu-devel] [PATCH 3/7] targe

Re: [Qemu-devel] [PATCH 2/7] target-mips: generate a reserved instruction exception on CPU without DSP

2012-11-20 Thread Johnson, Eric
> -Original Message- > From: qemu-devel-bounces+ericj=mips@nongnu.org [mailto:qemu-devel- > bounces+ericj=mips@nongnu.org] On Behalf Of Richard Henderson > Sent: Friday, November 16, 2012 2:03 PM > To: Aurelien Jarno > Cc: qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH 2/7

Re: [Qemu-devel] [PATCH 0/7] virtio: virtio-blk data plane

2012-11-20 Thread Stefan Hajnoczi
On Wed, Nov 21, 2012 at 7:42 AM, Asias He wrote: > On 11/21/2012 01:39 PM, Asias He wrote: >> On 11/20/2012 08:25 PM, Stefan Hajnoczi wrote: >>> On Tue, Nov 20, 2012 at 1:21 PM, Stefan Hajnoczi wrote: On Tue, Nov 20, 2012 at 10:02 AM, Asias He wrote: > Hello Stefan, > > On 11/15

Re: [Qemu-devel] SeaBIOS release for QEMU 1.3 (was Re: [PATCH] esp: enable busmaster)

2012-11-20 Thread Gerd Hoffmann
Hi, > A new release can be produced if desired. Given that there isn't much > new since 1.7.1 I too would prefer to just push forward to 1.7.2. Agree. I'll prepare a seabios update pull once the tag is there. cheers, Gerd

Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int

2012-11-20 Thread Stefan Hajnoczi
On Tue, Nov 20, 2012 at 8:16 PM, Stefan Priebe wrote: > Hi Stefan, > > Am 20.11.2012 17:29, schrieb Stefan Hajnoczi: > >> On Tue, Nov 20, 2012 at 01:44:55PM +0100, Stefan Priebe wrote: >>> >>> rbd / rados tends to return pretty often length of writes >>> or discarded blocks. These values might be

Re: [Qemu-devel] [PATCH 0/7] virtio: virtio-blk data plane

2012-11-20 Thread Asias He
On 11/21/2012 01:39 PM, Asias He wrote: > On 11/20/2012 08:25 PM, Stefan Hajnoczi wrote: >> On Tue, Nov 20, 2012 at 1:21 PM, Stefan Hajnoczi wrote: >>> On Tue, Nov 20, 2012 at 10:02 AM, Asias He wrote: Hello Stefan, On 11/15/2012 11:18 PM, Stefan Hajnoczi wrote: > This series a

Re: [Qemu-devel] [PATCH 1/7] target-mips: fix DSP loads with rd = 0

2012-11-20 Thread Johnson, Eric
> -Original Message- > From: qemu-devel-bounces+ericj=mips@nongnu.org [mailto:qemu-devel- > bounces+ericj=mips@nongnu.org] On Behalf Of Aurelien Jarno > Sent: Friday, November 16, 2012 3:04 AM > To: qemu-devel@nongnu.org > Cc: Aurelien Jarno > Subject: [Qemu-devel] [PATCH 1/7] targe

[Qemu-devel] [PATCH v2 4/4] virtio-rng: fix typos, comments

2012-11-20 Thread Amit Shah
Fix typos, whitespace and update comments to match current implementation. Signed-off-by: Amit Shah --- hw/virtio-rng.c| 7 +++ include/qemu/rng.h | 6 +++--- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/hw/virtio-rng.c b/hw/virtio-rng.c index c8a6da7..f4ed9cf 100644 --

[Qemu-devel] [PATCH v2 3/4] virtio-rng: disable timer on device removal

2012-11-20 Thread Amit Shah
Disable the rate-limit timer on device remove (e.g. hot-unplug). Signed-off-by: Amit Shah Reviewed-by: Anthony Liguori --- hw/virtio-rng.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/virtio-rng.c b/hw/virtio-rng.c index cf5a8ff..c8a6da7 100644 --- a/hw/virtio-rng.c +++ b/hw/virtio-

[Qemu-devel] [PATCH v2 2/4] virtio-rng: remove extra request for entropy

2012-11-20 Thread Amit Shah
If we got fewer bytes from the backend than requested, don't poke the backend for more bytes; the guest will ask for more (or if the guest has already asked for more, the backend knows about it via handle_input()). Signed-off-by: Amit Shah Reviewed-by: Anthony Liguori --- hw/virtio-rng.c | 7 --

Re: [Qemu-devel] [PATCH v3] target-mips: Clean up microMIPS32 major opcode

2012-11-20 Thread Johnson, Eric
> -Original Message- > From: 陳韋任 (Wei-Ren Chen) [mailto:che...@iis.sinica.edu.tw] > Sent: Tuesday, November 20, 2012 10:05 PM > To: qemu-devel@nongnu.org > Cc: Johnson, Eric; Aurelien Jarno; Jia Liu > Subject: [PATCH v3] target-mips: Clean up microMIPS32 major opcode > > I check MIPS mic

[Qemu-devel] [PATCH v3] target-mips: Clean up microMIPS32 major opcode

2012-11-20 Thread Wei-Ren Chen
I check MIPS microMIPS manual [1], and found the major opcode might be wrong. I add a comment to explicitly indicate what manual I am refering to, and according that manual I remove microMIPS32 major opcodes 0x1f. As for others, like 0x16, 0x17, 0x36 and 0x37, they are for higher-order MIPS ISA l

Re: [Qemu-devel] [PATCH v2] target-mips: Add comments on POOL32Axf encoding

2012-11-20 Thread Johnson, Eric
> -Original Message- > From: 陳韋任 (Wei-Ren Chen) [mailto:che...@iis.sinica.edu.tw] > Sent: Tuesday, November 20, 2012 9:51 PM > To: qemu-devel@nongnu.org > Cc: Johnson, Eric; Aurelien Jarno; Jia Liu > Subject: [PATCH v2] target-mips: Add comments on POOL32Axf encoding > > Current QEMU MIP

[Qemu-devel] [PATCH] ivshmem: use irqfd to interrupt among VMs

2012-11-20 Thread Liu Ping Fan
From: Liu Ping Fan Using irqfd, so we can avoid switch between kernel and user when VMs interrupts each other. Signed-off-by: Liu Ping Fan --- hw/ivshmem.c | 48 +++- 1 files changed, 47 insertions(+), 1 deletions(-) diff --git a/hw/ivshmem.c b/hw

Re: [Qemu-devel] [PATCH v6 1/8] atomic: introduce atomic operations

2012-11-20 Thread liu ping fan
On Fri, Nov 16, 2012 at 8:03 AM, Richard Henderson wrote: > On 2012-11-14 23:47, liu ping fan wrote: >> Probably I made a mistake here, in vhost, log = >> __sync_fetch_and_and(from, 0) is used to fetch 64bits atomically in >> the case 32bits qemu running on 64bits linux. Right? But how can >

Re: [Qemu-devel] [PATCH v6 1/8] atomic: introduce atomic operations

2012-11-20 Thread liu ping fan
On Sun, Nov 18, 2012 at 6:04 PM, Avi Kivity wrote: > On 11/15/2012 09:47 AM, liu ping fan wrote: >> On Wed, Nov 14, 2012 at 5:47 PM, Paolo Bonzini wrote: >>> Il 14/11/2012 10:38, liu ping fan ha scritto: On Tue, Nov 13, 2012 at 6:11 PM, Paolo Bonzini wrote: >>> Il 05/11/2012 06:38, Liu

Re: [Qemu-devel] [PATCH 1/4] virtio-rng: use virtqueue_get_avail_bytes, fix migration

2012-11-20 Thread Amit Shah
On (Tue) 20 Nov 2012 [19:44:55], Anthony Liguori wrote: > Amit Shah writes: > > > Popping an elem from the vq just to find out its length causes problems > > with save/load later on. Use the new virtqueue_get_avail_bytes() > > function instead, saves us the complexity in the migration code, as w

Re: [Qemu-devel] [PATCH] target-mips: Add comments on POOL32Axf encoding

2012-11-20 Thread Wei-Ren Chen
Hi Johnson, My bad. Will resend pacth later. ;) Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people.cs.nctu.edu.tw/~chenwj

Re: [Qemu-devel] [PATCH 4/4] virtio-rng: fix typos, comments

2012-11-20 Thread Amit Shah
On (Tue) 20 Nov 2012 [19:43:16], Anthony Liguori wrote: > > * The backend does not need to pass the full amount of data to > > @receive_entropy > > - * but will pass at a value greater than 0. > > + * but will pass a a value greater than 0. > > Your typo fix has a typo. Woops, series re-sent.

[Qemu-devel] [PATCH v2 1/4] virtio-rng: use virtqueue_get_avail_bytes, fix migration

2012-11-20 Thread Amit Shah
Popping an elem from the vq just to find out its length causes problems with save/load later on. Use the new virtqueue_get_avail_bytes() function instead, saves us the complexity in the migration code, as well as makes the migration endian-safe. Signed-off-by: Amit Shah Reviewed-by: Anthony Ligu

[Qemu-devel] [PATCH v2 0/4] [For 1.3] virtio-rng: fixes

2012-11-20 Thread Amit Shah
Hello, This series fixes a few things, especially the migration support, making it endian-safe. New in this submission: delete the timer on device remove, else hot-unplug of an rng device could result in a bad access. The backend should be decoupled on hot-unplug of the virtio-rng device as wel

[Qemu-devel] [PATCH v2] target-mips: Add comments on POOL32Axf encoding

2012-11-20 Thread Wei-Ren Chen
Current QEMU MIPS POOL32AXF encoding comes from microMIPS32 and microMIPS32 DSP. Add comment here to help reading. Signed-off-by: Chen Wei-Ren --- v2: Correct commit message formatting target-mips/translate.c | 17 + 1 file changed, 17 insertions(+) diff --git a/target-mips/

Re: [Qemu-devel] [PATCH] migration: Fix madvise breakage if host and guest have different page sizes

2012-11-20 Thread David Gibson
On Wed, Nov 21, 2012 at 03:59:25PM +1100, David Gibson wrote: > madvise(DONTNEED) will throw away the contents of the whole page at the > given address, even if the given length is less than the page size. One > can argue about whether that's the correct behaviour, but that's what it's > done for

Re: [Qemu-devel] [PATCH 0/7] virtio: virtio-blk data plane

2012-11-20 Thread Asias He
On 11/20/2012 08:25 PM, Stefan Hajnoczi wrote: > On Tue, Nov 20, 2012 at 1:21 PM, Stefan Hajnoczi wrote: >> On Tue, Nov 20, 2012 at 10:02 AM, Asias He wrote: >>> Hello Stefan, >>> >>> On 11/15/2012 11:18 PM, Stefan Hajnoczi wrote: This series adds the -device virtio-blk-pci,x-data-plane=on p

Re: [Qemu-devel] [PATCH 0/7] virtio: virtio-blk data plane

2012-11-20 Thread Asias He
On 11/20/2012 08:21 PM, Stefan Hajnoczi wrote: > On Tue, Nov 20, 2012 at 10:02 AM, Asias He wrote: >> Hello Stefan, >> >> On 11/15/2012 11:18 PM, Stefan Hajnoczi wrote: >>> This series adds the -device virtio-blk-pci,x-data-plane=on property that >>> enables a high performance I/O codepath. A ded

Re: [Qemu-devel] [PATCH 0/7] virtio: virtio-blk data plane

2012-11-20 Thread Asias He
On 11/20/2012 11:03 PM, Khoa Huynh wrote: > Asias He wrote on 11/20/2012 03:02:07 AM: > >> From: Asias He >> To: Stefan Hajnoczi , >> Cc: qemu-devel@nongnu.org, Anthony Liguori/Austin/IBM@IBMUS, Paolo >> Bonzini , Kevin Wolf , >> "Michael S. Tsirkin" , Khoa Huynh/Austin/IBM@IBMUS >> Date: 11/20/

Re: [Qemu-devel] [PATCH] migration: Fix madvise breakage if host and guest have different page sizes

2012-11-20 Thread David Gibson
On Wed, Nov 21, 2012 at 03:59:25PM +1100, David Gibson wrote: > madvise(DONTNEED) will throw away the contents of the whole page at the > given address, even if the given length is less than the page size. One > can argue about whether that's the correct behaviour, but that's what it's > done for

Re: [Qemu-devel] [PATCH v2] target-mips: Clean up microMIPS32 major opcode

2012-11-20 Thread Johnson, Eric
Hi Chen, Again the format is incorrect. Please review the "SubmittingPatches 1.12" link on the http://wiki.qemu.org/Contribute/SubmitAPatch page. -Eric > -Original Message- > From: 陳韋任 (Wei-Ren Chen) [mailto:che...@iis.sinica.edu.tw] > Sent: Thursday, November 15, 2012 6:06 PM > To: qe

Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges

2012-11-20 Thread David Gibson
On Tue, Nov 20, 2012 at 10:27:11AM +0100, Alexander Graf wrote: > > On 19.11.2012, at 23:51, David Gibson wrote: > > > On Mon, Nov 19, 2012 at 05:34:12PM +0100, Alexander Graf wrote: > >> > >> On 13.11.2012, at 03:47, David Gibson wrote: > >> > >>> From: Alexey Kardashevskiy > >>> > >>> In fu

[Qemu-devel] [PATCH] migration: Fix madvise breakage if host and guest have different page sizes

2012-11-20 Thread David Gibson
madvise(DONTNEED) will throw away the contents of the whole page at the given address, even if the given length is less than the page size. One can argue about whether that's the correct behaviour, but that's what it's done for a long time in Linux at least. That means that the madvise() in ram_l

Re: [Qemu-devel] [PATCH] target-mips: Add comments on POOL32Axf encoding

2012-11-20 Thread Johnson, Eric
Hi Chen, The contents of the patch are OK. The formatting of the message is incorrect. Anything before the first '---' will be used as the comment for the commit. It should not have "Hi all," "Please review, thanks. Regards, checnwj" If you want to include these additional comments, put the

Re: [Qemu-devel] [PATCH V10 6/7] libqblock API

2012-11-20 Thread Wenchao Xia
于 2012-11-20 18:41, Paolo Bonzini 写道: Il 20/11/2012 10:46, Wenchao Xia ha scritto: diff --git a/libqblock/libqblock.h b/libqblock/libqblock.h index e69de29..8ca7d28 100644 --- a/libqblock/libqblock.h +++ b/libqblock/libqblock.h Please move the creation of this file to the previous patch. I

Re: [Qemu-devel] [PATCH V10 5/7] libqblock type defines

2012-11-20 Thread Wenchao Xia
于 2012-11-20 18:30, Paolo Bonzini 写道: Il 20/11/2012 10:46, Wenchao Xia ha scritto: This patch contains type and macro defines used in APIs, one file for public usage, one for libqblock internal usage. Mostly looks good, just a few questions below. Signed-off-by: Wenchao Xia --- libqblo

Re: [Qemu-devel] [PATCH V10 4/7] libqblock build system

2012-11-20 Thread Wenchao Xia
于 2012-11-20 18:26, Paolo Bonzini 写道: Mostly looks good... Il 20/11/2012 10:46, Wenchao Xia ha scritto: +libqblock="yes" Please make the default the empty string, i.e. "build if and only if libtool is present". Do you mean adding a probe section later that if libtool is present, its defau

Re: [Qemu-devel] [PATCH V5 09/10] Use QemuOpts support in block layer

2012-11-20 Thread Dong Xu Wang
On Tue, Nov 20, 2012 at 1:14 AM, Stefan Hajnoczi wrote: > On Thu, Nov 01, 2012 at 05:12:29PM +0800, Dong Xu Wang wrote: >> diff --git a/block/qcow.c b/block/qcow.c >> index b239c82..9bb736a 100644 >> --- a/block/qcow.c >> +++ b/block/qcow.c >> @@ -651,7 +651,7 @@ static void qcow_close(BlockDriver

Re: [Qemu-devel] [PATCH V5 08/10] Create four opts list related functions

2012-11-20 Thread Dong Xu Wang
On Tue, Nov 20, 2012 at 1:16 AM, Stefan Hajnoczi wrote: > > On Thu, Nov 01, 2012 at 05:12:28PM +0800, Dong Xu Wang wrote: > > +/* Create a new QemuOptsList and make its desc to the merge of first and > > second. > > + * It will allocate space for one new QemuOptsList plus enouth space for > > + *

Re: [Qemu-devel] [GitHub] [Qemu-commits] [qemu/qemu] ecdffb: tcg/ppc: Remove unused s_bits variable

2012-11-20 Thread malc
On Tue, 20 Nov 2012, Anthony Liguori wrote: > malc writes: [..snip..] > Hi malc, > > If you want to put code under the public domain, it needs to be done (1) > with the consent of all contributors to a file (2) using an appropriate > license. > > In QEMU, we've always followed the FSF's guida

Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN

2012-11-20 Thread David Gibson
On Wed, Nov 21, 2012 at 02:48:07AM +0100, Alexander Graf wrote: > > On 21.11.2012, at 02:14, David Gibson wrote: > > > On Tue, Nov 20, 2012 at 10:55:50AM +0100, Alexander Graf wrote: > >> > >> On 20.11.2012, at 10:53, Peter Maydell wrote: > >> > >>> On 20 November 2012 09:29, Alexander Graf wr

Re: [Qemu-devel] [GitHub] [Qemu-commits] [qemu/qemu] ecdffb: tcg/ppc: Remove unused s_bits variable

2012-11-20 Thread Anthony Liguori
malc writes: > On Tue, 20 Nov 2012, Markus Armbruster wrote: > >> malc writes: >> >> > On Tue, 20 Nov 2012, Markus Armbruster wrote: >> > >> >> malc writes: >> >> >> >> > On Mon, 19 Nov 2012, Anthony Liguori wrote: >> >> > >> >> >> >> >> >> "Public domain" is not a valid copyright header/lic

Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN

2012-11-20 Thread Alexander Graf
On 21.11.2012, at 02:14, David Gibson wrote: > On Tue, Nov 20, 2012 at 10:55:50AM +0100, Alexander Graf wrote: >> >> On 20.11.2012, at 10:53, Peter Maydell wrote: >> >>> On 20 November 2012 09:29, Alexander Graf wrote: On 19.11.2012, at 23:48, David Gibson wrote: > On Mon, Nov 19, 201

Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN

2012-11-20 Thread David Gibson
On Tue, Nov 20, 2012 at 10:55:50AM +0100, Alexander Graf wrote: > > On 20.11.2012, at 10:53, Peter Maydell wrote: > > > On 20 November 2012 09:29, Alexander Graf wrote: > >> On 19.11.2012, at 23:48, David Gibson wrote: > >>> On Mon, Nov 19, 2012 at 05:26:45PM +0100, Alexander Graf wrote: >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges

2012-11-20 Thread David Gibson
On Tue, Nov 20, 2012 at 02:26:09PM +0200, Michael S. Tsirkin wrote: > On Tue, Nov 20, 2012 at 10:27:11AM +0100, Alexander Graf wrote: > > > > On 19.11.2012, at 23:51, David Gibson wrote: > > > > > On Mon, Nov 19, 2012 at 05:34:12PM +0100, Alexander Graf wrote: > > >> > > >> On 13.11.2012, at 03:

Re: [Qemu-devel] [Qemu-ppc] [PATCH 03/12] pseries: Move XICS initialization before cpu initialization

2012-11-20 Thread David Gibson
On Tue, Nov 20, 2012 at 10:26:06AM +0100, Alexander Graf wrote: > > On 19.11.2012, at 23:47, David Gibson wrote: > > > On Tue, Nov 20, 2012 at 06:54:20AM +1100, Benjamin Herrenschmidt wrote: > >> On Mon, 2012-11-19 at 17:22 +0100, Alexander Graf wrote: > Currently, the pseries machine initia

Re: [Qemu-devel] [PATCH 1/4] virtio-rng: use virtqueue_get_avail_bytes, fix migration

2012-11-20 Thread Anthony Liguori
Amit Shah writes: > Popping an elem from the vq just to find out its length causes problems > with save/load later on. Use the new virtqueue_get_avail_bytes() > function instead, saves us the complexity in the migration code, as well > as makes the migration endian-safe. > > Signed-off-by: Amit

Re: [Qemu-devel] SeaBIOS release for QEMU 1.3 (was Re: [PATCH] esp: enable busmaster)

2012-11-20 Thread Kevin O'Connor
On Tue, Nov 20, 2012 at 06:42:25PM +0100, Paolo Bonzini wrote: > Il 20/11/2012 18:33, Paolo Bonzini ha scritto: > > The HBA does DMA, thus we must enable the busmaster bit, > > otherwise dma access will fail with recent qemu versions. > > > > Signed-off-by: Paolo Bonzini > > As usual we forget t

Re: [Qemu-devel] [PATCH 4/4] virtio-rng: fix typos, comments

2012-11-20 Thread Anthony Liguori
Amit Shah writes: > Fix typos, whitespace and update comments to match current > implementation. > > Signed-off-by: Amit Shah > --- > hw/virtio-rng.c| 7 +++ > include/qemu/rng.h | 6 +++--- > 2 files changed, 6 insertions(+), 7 deletions(-) > > diff --git a/hw/virtio-rng.c b/hw/virtio-

Re: [Qemu-devel] [PATCH 3/4] virtio-rng: disable timer on device removal

2012-11-20 Thread Anthony Liguori
Amit Shah writes: > Disable the rate-limit timer on device remove (e.g. hot-unplug). > > Signed-off-by: Amit Shah Nice catch. Reviewed-by: Anthony Liguori Regards, Anthony Liguori > --- > hw/virtio-rng.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/virtio-rng.c b/hw/virti

Re: [Qemu-devel] [PATCH 2/4] virtio-rng: remove extra request for entropy

2012-11-20 Thread Anthony Liguori
Amit Shah writes: > If we got fewer bytes from the backend than requested, don't poke the > backend for more bytes; the guest will ask for more (or if the guest has > already asked for more, the backend knows about it via handle_input()). > > Signed-off-by: Amit Shah Reviewed-by: Anthony Liguor

[Qemu-devel] Interrupt controller updates

2012-11-20 Thread Benjamin Herrenschmidt
Hi Jan ! David (CC) want to make some progress with our in-kernel PIC. From memory, one of the outcomes of the BOF was that we need to move the existing "enable in-kernel PIC" from generic KVM init to machine init in order to be able to add an argument indicating the "model" use by the arch/platfo

Re: [Qemu-devel] [Qemu-ppc] [PATCH] kvm: fix incorrect length in a loop over kvm dirty pages map

2012-11-20 Thread David Gibson
On Tue, Nov 20, 2012 at 10:06:02AM +0100, Alexander Graf wrote: > > On 20.11.2012, at 02:40, Alexey Kardashevskiy wrote: > > > QEMU allocates a map enough for 4k pages. However the system page size > > can be 64K (for example on POWER) and the host kernel uses only a small > > part of it as one b

Re: [Qemu-devel] [PATCH] Fix off-by-1 error in RAM migration code

2012-11-20 Thread David Gibson
On Fri, Nov 02, 2012 at 11:58:32AM +0100, Juan Quintela wrote: > David Gibson wrote: > > On Wed, Oct 31, 2012 at 01:08:16PM +0200, Orit Wasserman wrote: > >> On 10/31/2012 05:43 AM, David Gibson wrote: > >> > The code for migrating (or savevm-ing) memory pages starts off by > >> > creating > >> >

Re: [Qemu-devel] [PATCH] esp: enable busmaster

2012-11-20 Thread Kevin O'Connor
On Tue, Nov 20, 2012 at 06:33:41PM +0100, Paolo Bonzini wrote: > The HBA does DMA, thus we must enable the busmaster bit, > otherwise dma access will fail with recent qemu versions. Thanks - I applied this. -Kevin

[Qemu-devel] [PATCH v2] exec.c: Use tb1->phys_hash_next directly in tb_remove

2012-11-20 Thread Wei-Ren Chen
When tb_remove was first commited at fd6ce8f6, there were three different calls pass different names to offsetof. In current codebase, the other two calls are replaced with tb_page_remove. There is no need to have a general tb_remove. Omit passing the third parameter and using tb1->phys_hash_next

Re: [Qemu-devel] [PATCH v11] kvm: notify host when the guest is panicked

2012-11-20 Thread Marcelo Tosatti
On Tue, Nov 20, 2012 at 06:09:48PM +0800, Hu Tao wrote: > Hi Marcelo, > > On Tue, Nov 13, 2012 at 12:19:08AM -0200, Marcelo Tosatti wrote: > > On Fri, Nov 09, 2012 at 03:17:39PM -0500, Sasha Levin wrote: > > > On Mon, Nov 5, 2012 at 8:58 PM, Hu Tao wrote: > > > > But in the case of panic notifica

Re: [Qemu-devel] [PATCH v3 2/2] qemu-ga: sample fsfreeze hooks

2012-11-20 Thread mdroth
On Tue, Nov 13, 2012 at 01:56:59PM +0900, Tomoki Sekiyama wrote: > Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. > - fsfreeze-hook : execute scripts in fsfreeze-hook.d/ > - fsfreeze-hook.d.sample/mysql-flush.sh : quiesce MySQL before snapshot > > Signed-off-by: Tomoki Sekiyam

Re: [Qemu-devel] [PATCH v3 1/2] qemu-ga: execute hook to quiesce the guest on fsfreeze-freeze/thaw

2012-11-20 Thread mdroth
On Tue, Nov 13, 2012 at 01:56:56PM +0900, Tomoki Sekiyama wrote: > To use the online disk snapshot for online-backup, application-level > consistency of the snapshot image is required. However, currently the > guest agent can provide only filesystem-level consistency, and the > snapshot may contain

Re: [Qemu-devel] assertion in temp_save

2012-11-20 Thread Max Filippov
first place? >> > > Indeed, it looks like that discard doesn't work correctly with a temp > local with this new patch. I might have a fix, but I would like to do > some more tests first. Would it be possible to provide a way to reproduce > the issue? Here's the test case (xtensa assembler): .section .init .global _start _start: ssl a2 ssr a2 j _start Sources + compiled version is available at http://jcmvbkbc.spb.ru/~dumb/ws/osll/qemu-xtensa/20121120/ -- Thanks. -- Max

Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int

2012-11-20 Thread Stefan Priebe
Hi Stefan, Am 20.11.2012 17:29, schrieb Stefan Hajnoczi: On Tue, Nov 20, 2012 at 01:44:55PM +0100, Stefan Priebe wrote: rbd / rados tends to return pretty often length of writes or discarded blocks. These values might be bigger than int. Signed-off-by: Stefan Priebe --- block/rbd.c |4 +

Re: [Qemu-devel] [PATCH v2 3/8] dataplane: add host memory mapping code

2012-11-20 Thread Don Koch
On 11/20/2012 07:31 AM, Stefan Hajnoczi wrote: > The data plane thread needs to map guest physical addresses to host > pointers. Normally this is done with cpu_physical_memory_map() but the > function assumes the global mutex is held. The data plane thread does > not touch the global mutex and th

[Qemu-devel] [PATCH for-1.3] hw/ide/macio: Fix segfault caused by NULL DMAContext*

2012-11-20 Thread Peter Maydell
Pass qemu_sglist_init the global dma_context_memory rather than a NULL pointer; this fixes a segfault in dma_memory_map() when the guest starts using DMA. Reported-by: Amadeusz Sławiński Signed-off-by: Peter Maydell --- Test case: download the squeeze standard image from http://people.debian.org

Re: [Qemu-devel] [Qemu-stable] qemu-stable-1.1

2012-11-20 Thread mdroth
On Mon, Nov 19, 2012 at 08:59:33PM +0400, Michael Tokarev wrote: > Hello. > > I'm trying to pick whatever fixes applicable for 1.1.x series of qemu > and qemu-kvm. Since Michael Roth said he will not be releasing more > 1.1.x series, I think I can at least try to do that. Qemu-1.1 will > be incl

Re: [Qemu-devel] assertion in temp_save

2012-11-20 Thread Aurelien Jarno
On Tue, Nov 20, 2012 at 05:09:57AM +0300, Max Filippov wrote: > On Sun, Nov 18, 2012 at 7:34 AM, Max Filippov wrote: > > On Sun, Nov 18, 2012 at 7:19 AM, Max Filippov wrote: > >> Hi Aurelien, > >> > >> starting with commit 2c0366f tcg: don't explicitly save globals and temps > >> I get the follow

[Qemu-devel] SeaBIOS release for QEMU 1.3 (was Re: [PATCH] esp: enable busmaster)

2012-11-20 Thread Paolo Bonzini
Il 20/11/2012 18:33, Paolo Bonzini ha scritto: > The HBA does DMA, thus we must enable the busmaster bit, > otherwise dma access will fail with recent qemu versions. > > Signed-off-by: Paolo Bonzini As usual we forget to update SeaBIOS. We probably want these two from Gerd: 7d05257 (lsi: enabl

[Qemu-devel] [PATCH] esp: enable busmaster

2012-11-20 Thread Paolo Bonzini
The HBA does DMA, thus we must enable the busmaster bit, otherwise dma access will fail with recent qemu versions. Signed-off-by: Paolo Bonzini --- src/esp-scsi.c | 2 ++ 1 file modificato, 2 inserzioni(+) diff --git a/src/esp-scsi.c b/src/esp-scsi.c index b795012..c43e55b 100644 --- a/src/esp-

Re: [Qemu-devel] [RFC PATCH 1/3] virtio-bus : Introduce VirtioBus.

2012-11-20 Thread Cornelia Huck
On Tue, 20 Nov 2012 17:45:15 +0100 KONRAD Frédéric wrote: > eg for virtio-block-pci in virtio-pci.c : > static void virtio_blk_class_init(ObjectClass *klass, void *data) > { > k->device_id = PCI_DEVICE_ID_VIRTIO_BLOCK; > ... > k->class_id = PCI_CLASS_STORAGE_SCSI; > } > > I think

[Qemu-devel] [PATCH 0/1] Exogenous memory management via -mem-path

2012-11-20 Thread Peter Feiner
This patch proposes a framework that empowers QEMU to implement powerful memory management techniques with very low cost. The insight is to leverage existing sub-systems, composing functionality in a traditional UNIX style. The key to enabling this approach is to expand the -mem-path option to prov

[Qemu-devel] [PATCH 1/1] exec: make -mem-path filenames deterministic

2012-11-20 Thread Peter Feiner
This patch makes the -mem-path filenames deterministic and allows some control over how QEMU mmaps the files. Given this control, QEMU can be used to implement exogenous memory management techniques quite simply. Two examples follow: 1. Post-copy migration (mmap=shared for origin, save device

Re: [Qemu-devel] PCI CAS implementation in qemu

2012-11-20 Thread Paolo Bonzini
Il 20/11/2012 17:32, Francois WELLENREITER ha scritto: > > I order to develop a qemu module, I aim to use the PCI CAS (compare > and swap) function to guarantee an atomic access somewhere in the > guest memory (in a multi-core emulation case). > > Nevertheless, I did not find any routine in qemu

[Qemu-devel] [PATCH v2 4/4] buffered_file: do not automatically unfreeze output on buffered_put_buffer

2012-11-20 Thread Paolo Bonzini
Only unfreeze if the call comes from migrate_fd_put_notify. If the output if frozen we can still add to the buffer (which will not grow in an unbounded manner anyway, both with and without the previous patch), but we will not try to flush until the socket becomes writable. Signed-off-by: Paolo Bon

[Qemu-devel] [PATCH v2 2/4] buffered_file: do not send more than s->bytes_xfer bytes per tick

2012-11-20 Thread Paolo Bonzini
Sending more was possible if the buffer was large. Signed-off-by: Paolo Bonzini --- buffered_file.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/buffered_file.c b/buffered_file.c index 49e9089..edead5c 100644 --- a/buffered_file.c +++ b/buffered_file.c @@ -66,9 +66

[Qemu-devel] [PATCH v2 3/4] buffered_file: rate-limit producers based on buffer size

2012-11-20 Thread Paolo Bonzini
buffered_rate_limit is called to prevent the RAM migration callback from putting too much data in the buffer. So it has to check against the amount of data currently in the buffer, not against the amount of data that has been transferred so far. s->bytes_xfer is used to communicate between succes

[Qemu-devel] [PATCH v2 1/4] buffered_file: reset bytes_xfer on every tick

2012-11-20 Thread Paolo Bonzini
Even if the socket cannot send more data right now, whenever a new tick has started we can send xfer_limit more bytes. Signed-off-by: Paolo Bonzini --- buffered_file.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/buffered_file.c b/buffered_file.c index bd0f61d..49e9

[Qemu-devel] [PATCH v2 0/4] migration: fix rate limiting

2012-11-20 Thread Paolo Bonzini
Here is v2 of the rate limiting fix (now fixes). The rate-limiting condition "s->freeze_output || s->bytes_xfer > s->xfer_limit" is changed to "s->buffer_size > s->xfer_limit", separating the limits used by the producer (s->buffer_size) from those used by the consumer (s->freeze_output and s->byte

Re: [Qemu-devel] [RFC PATCH 1/3] virtio-bus : Introduce VirtioBus.

2012-11-20 Thread KONRAD Frédéric
On 20/11/2012 17:15, Cornelia Huck wrote: On Tue, 20 Nov 2012 15:30:35 +0100 KONRAD Frédéric wrote: On 20/11/2012 15:12, Cornelia Huck wrote: On Mon, 19 Nov 2012 17:33:01 + Peter Maydell wrote: On 16 November 2012 15:35, wrote: From: KONRAD Frederic You forgot to CC enough people.

Re: [Qemu-devel] TCP based PCIE request forwarding

2012-11-20 Thread Jason Baron
On Fri, Nov 16, 2012 at 09:39:07AM +0100, lementec fabien wrote: > Hi, > > I am a software engineer who works in an electronic group. Using QEMU > to emulate devices allows me to start writing and testing LINUX software > before the device is actually available. In the group, we are mostly > worki

[Qemu-devel] PCI CAS implementation in qemu

2012-11-20 Thread Francois WELLENREITER
Hi there, I order to develop a qemu module, I aim to use the PCI CAS (compare and swap) function to guarantee an atomic access somewhere in the guest memory (in a multi-core emulation case). Nevertheless, I did not find any routine in qemu implementing this function. Could anyone on this lis

Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int

2012-11-20 Thread Stefan Hajnoczi
On Tue, Nov 20, 2012 at 01:44:55PM +0100, Stefan Priebe wrote: > rbd / rados tends to return pretty often length of writes > or discarded blocks. These values might be bigger than int. > > Signed-off-by: Stefan Priebe > --- > block/rbd.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletion

[Qemu-devel] [PATCH 2/2] ide: Fix status register after short PRDs

2012-11-20 Thread Kevin Wolf
When failing a request because the length of the regions described by the PRDT was too short for the requested number of sectors, the IDE emulation forgot to update the status register, so that the device would keep the BSY flag set indefinitely. Signed-off-by: Kevin Wolf --- hw/ide/core.c |

[Qemu-devel] [PATCH 1/2] ide: Fix crash with too long PRD

2012-11-20 Thread Kevin Wolf
Without this, s->nsector can become negative and badness happens (trying to malloc huge amount of memory and glib calls abort()) Signed-off-by: Kevin Wolf --- hw/ide/core.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 7d

[Qemu-devel] [PATCH 1.3 0/2] ide: PRDT error handling fixes

2012-11-20 Thread Kevin Wolf
qtest cases for this exist, but they rely on prototype infrastructure that isn't mergable. I'll submit them as soon as libqos is there and I've changed the test to use it. Kevin Wolf (2): ide: Fix crash with too long PRD ide: Fix status register after short PRDs hw/ide/core.c | 13

[Qemu-devel] [ANNOUNCE] QEMU 1.2.1 Stable released

2012-11-20 Thread mdroth
Hi everyone, I am pleased to announce that the QEMU v1.2.1 stable release is now available at: http://wiki.qemu.org/download/qemu-1.2.1.tar.bz2 The official stable-1.2 repository has also been updated to v1.2.1: http://git.qemu.org/?p=qemu-stable-1.2.git;a=summary This release includes 242 bui

Re: [Qemu-devel] [PATCH] iscsi: partly avoid iovec linearization in iscsi_aio_writev

2012-11-20 Thread Paolo Bonzini
Il 20/11/2012 16:51, Stefan Hajnoczi ha scritto: > Poalo: Could be > done when merging the patch? > > Reviewed-by: Stefan Hajnoczi Yes. Applying this to scsi-next branch. Paolo

Re: [Qemu-devel] [RFC PATCH 1/3] virtio-bus : Introduce VirtioBus.

2012-11-20 Thread Cornelia Huck
On Tue, 20 Nov 2012 15:30:35 +0100 KONRAD Frédéric wrote: > On 20/11/2012 15:12, Cornelia Huck wrote: > > On Mon, 19 Nov 2012 17:33:01 + > > Peter Maydell wrote: > > > >> On 16 November 2012 15:35, wrote: > >>> From: KONRAD Frederic > >> You forgot to CC enough people... > >> > >>> This p

Re: [Qemu-devel] [PATCH] vdi: don't override libuuid symbols

2012-11-20 Thread Stefan Hajnoczi
On Tue, Nov 20, 2012 at 04:34:17PM +0100, Stefan Hajnoczi wrote: > It's poor symbol hygiene to provide a global symbols that collide with a > common library like libuuid. If QEMU links against a shared library > that depends on uuid_generate() it can end up calling our stub version > of the functi

Re: [Qemu-devel] [PATCH] iscsi: partly avoid iovec linearization in iscsi_aio_writev

2012-11-20 Thread Stefan Hajnoczi
On Mon, Nov 19, 2012 at 03:58:31PM +0100, Peter Lieven wrote: > libiscsi expects all write16 data in a linear buffer. If the > iovec only contains one buffer we can skip the linearization > step as well as the additional malloc/free and pass the > buffer directly. > > Reported-by: Ronnie Sahlberg

Re: [Qemu-devel] [PATCH] vdi: don't override libuuid symbols

2012-11-20 Thread Kevin Wolf
Am 20.11.2012 16:34, schrieb Stefan Hajnoczi: > It's poor symbol hygiene to provide a global symbols that collide with a > common library like libuuid. If QEMU links against a shared library > that depends on uuid_generate() it can end up calling our stub version > of the function. > > This exact

Re: [Qemu-devel] [PATCH v2] block: add bdrv_reopen() support for raw hdev, floppy, and cdrom

2012-11-20 Thread Stefan Hajnoczi
On Tue, Nov 20, 2012 at 10:21:10AM -0500, Jeff Cody wrote: > For hdev, floppy, and cdrom, the reopen() handlers are the same as > for the file reopen handler. For floppy and cdrom types, however, > we keep O_NONBLOCK, as in the _open function. > > Signed-off-by: Jeff Cody > --- > block/raw-posi

[Qemu-devel] [PATCH] vdi: don't override libuuid symbols

2012-11-20 Thread Stefan Hajnoczi
It's poor symbol hygiene to provide a global symbols that collide with a common library like libuuid. If QEMU links against a shared library that depends on uuid_generate() it can end up calling our stub version of the function. This exact scenario happened with GlusterFS libgfapi.so, which depen

Re: [Qemu-devel] VFIO VGA passthrough

2012-11-20 Thread Alex Williamson
On Tue, 2012-11-20 at 19:47 +0800, ching wrote: > My PC is gentoo x64, kernel 3.6.6, intel sandy bridge i7 2600 + asrock Z77 > exterme 4 MB > > I download qemu from git and try to pass through secondary VGA card to > Windows 7 x64 SP1 VM: > > > 01:00.0 VGA compatible controller: Advanced Micro

[Qemu-devel] [PATCH v2] block: add bdrv_reopen() support for raw hdev, floppy, and cdrom

2012-11-20 Thread Jeff Cody
For hdev, floppy, and cdrom, the reopen() handlers are the same as for the file reopen handler. For floppy and cdrom types, however, we keep O_NONBLOCK, as in the _open function. Signed-off-by: Jeff Cody --- block/raw-posix.c | 16 1 file changed, 16 insertions(+) diff --git a

Re: [Qemu-devel] [PATCH] Legacy qemu-kvm options have no argument

2012-11-20 Thread Markus Armbruster
Cc'ing Marcelo & Jan to speed up patch application. Bruce Rogers writes: > The options no-kvm, no-kvm-pit, no-kvm-pit-reinjection, and no-kvm-irqchip > should be marked as having no argument. > > Signed-off-by: Bruce Rogers > --- > qemu-options.hx |8 > 1 files changed, 4 insertio

  1   2   3   >