Re: [Qemu-devel] buildbot failure in qemu on default_mingw32

2012-11-16 Thread Stefan Weil
Am 16.11.2012 23:48, schrieb q...@buildbot.b1-systems.de: The Buildbot has detected a new failure on builder default_mingw32 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/438 Buildbot URL: http://buildbot.b1-systems.de/q

[Qemu-devel] buildbot failure in qemu on default_mingw32

2012-11-16 Thread qemu
The Buildbot has detected a new failure on builder default_mingw32 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/438 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 Build Reason:

Re: [Qemu-devel] [PATCH 4/7] target-mips: use DSP unions for binary DSP operators

2012-11-16 Thread Richard Henderson
On 11/16/2012 03:04 AM, Aurelien Jarno wrote: > +return (int32_t)ds.sw[0]; \ Why the extra cast? You know what type .sw is... r~

Re: [Qemu-devel] [PATCH 2/7] target-mips: generate a reserved instruction exception on CPU without DSP

2012-11-16 Thread Richard Henderson
On 11/16/2012 03:04 AM, Aurelien Jarno wrote: > +static inline void check_dsp(CPUMIPSState *env, DisasContext *ctx) > { > if (unlikely(!(ctx->hflags & MIPS_HFLAG_DSP))) { > -generate_exception(ctx, EXCP_DSPDIS); > +if (env->insn_flags & ASE_DSP) { > +generate_excep

[Qemu-devel] Virtualization DevRoom at FOSDEM 2013

2012-11-16 Thread Chris Wright
Following on the heels of a successful KVM Forum and oVirt Workshop, FOSDEM will be hosting a Virtualization DevRoom in February. If you've been to FOSDEM before, you know this is about developers and code, not products. Presentation proposals are due by December 16th 2012. The full details are

[Qemu-devel] [PATCH] rng-egd: don't use gslist_free_full

2012-11-16 Thread Anthony Liguori
This function was only introduced in glib 2.28.0. Signed-off-by: Anthony Liguori --- backends/rng-egd.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/backends/rng-egd.c b/backends/rng-egd.c index ec58358..ad84737 100644 --- a/backends/rng-egd.c +++ b/ba

Re: [Qemu-devel] [PATCH v2] build: replace weak symbols with a static library

2012-11-16 Thread Peter Maydell
On 16 November 2012 17:35, Paolo Bonzini wrote: > Weak symbols were a nice idea, but they turned out not to be a good one. > Toolchain support is just too sparse, in particular llvm-gcc is totally > broken. > > This patch uses a surprisingly low-tech approach: a static library. > Symbols in a stat

Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login

2012-11-16 Thread Paolo Bonzini
Il 16/11/2012 18:38, Peter Lieven ha scritto: > Am 16.11.2012 11:38, schrieb Kevin Wolf: >> Am 15.11.2012 17:37, schrieb Paolo Bonzini: >>> Il 15/11/2012 17:13, ronnie sahlberg ha scritto: On Thu, Nov 15, 2012 at 7:54 AM, Paolo Bonzini wrote: > Il 15/11/2012 15:57, ronnie sahlberg ha

Re: [Qemu-devel] [PATCH v2 05/39] fdsets: use weak aliases instead of qemu-tool.c/qemu-user.c

2012-11-16 Thread Paolo Bonzini
Il 16/11/2012 18:52, Peter Maydell ha scritto: > clang: error: linker command failed with exit code 1 (use -v to see > invocation) > > (clang builds OK with current git master.) But I have no idea why, or whether the generated code is correct... Looks like the safest bet is to go with the good

Re: [Qemu-devel] [PATCH v2 05/39] fdsets: use weak aliases instead of qemu-tool.c/qemu-user.c

2012-11-16 Thread Peter Maydell
On 16 November 2012 09:35, Paolo Bonzini wrote: > Ok, I reproduced the original binutils bug, and found a typo in the > weakrefs implementation. Does this work for you? > > diff --git a/compiler.h b/compiler.h > index 55d7d74..d552757 100644 > --- a/compiler.h > +++ b/compiler.h > @@ -50,11 +50,1

Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login

2012-11-16 Thread Peter Lieven
Am 16.11.2012 11:38, schrieb Kevin Wolf: Am 15.11.2012 17:37, schrieb Paolo Bonzini: Il 15/11/2012 17:13, ronnie sahlberg ha scritto: On Thu, Nov 15, 2012 at 7:54 AM, Paolo Bonzini wrote: Il 15/11/2012 15:57, ronnie sahlberg ha scritto: I dont know if we should switch to use synchronous code

Re: [Qemu-devel] [PATCH v2 05/39] fdsets: use weak aliases instead of qemu-tool.c/qemu-user.c

2012-11-16 Thread Paolo Bonzini
Il 16/11/2012 18:15, Stefan Weil ha scritto: > > Tested-by: Stefan Weil > > Great, the above patch fixes w32/w64 (native and with Wine). > Is this modification needed / does it work with MacOS X, too? Yes, but I found a way to get rid of weak references completely. The testing is still preciou

[Qemu-devel] [PATCH v2] build: replace weak symbols with a static library

2012-11-16 Thread Paolo Bonzini
Weak symbols were a nice idea, but they turned out not to be a good one. Toolchain support is just too sparse, in particular llvm-gcc is totally broken. This patch uses a surprisingly low-tech approach: a static library. Symbols in a static library are always overridden by symbols in an object fil

Re: [Qemu-devel] [PATCH v2 05/39] fdsets: use weak aliases instead of qemu-tool.c/qemu-user.c

2012-11-16 Thread Stefan Weil
Am 16.11.2012 10:35, schrieb Paolo Bonzini: Il 15/11/2012 23:18, Stefan Weil ha scritto: Am 15.11.2012 21:52, schrieb Paolo Bonzini: Il 15/11/2012 19:01, Stefan Weil ha scritto: Hi Paolo, this patch breaks QEMU on 32 and 64 bit hosts, native and with Wine. It's easy to reproduce the SIGSEGV c

Re: [Qemu-devel] [RFC/RFT PATCH] build: replace weak symbols with a static library

2012-11-16 Thread Peter Maydell
On 16 November 2012 17:06, Peter Maydell wrote: > This turns out to be the same problem as the MacOS failure: > as well as building the libqemustub.a in the root directory > we also try to create an empty libqemustub.a in arm-softmmu/ > (or whatever the target subdir is). On MacOS this fails > bec

Re: [Qemu-devel] [RFC/RFT PATCH] build: replace weak symbols with a static library

2012-11-16 Thread Peter Maydell
On 16 November 2012 16:54, Peter Maydell wrote: > And it doesn't build on Linux: Adding libqemustub.a to the vscclient$(EXESUF) prerequisites fixes that, and then it fails on qemu-system-arm: LINK arm-softmmu/qemu-system-arm ../qmp.o: In function `qmp_query_cpu_definitions': /home/petmay01/li

Re: [Qemu-devel] [RFC/RFT PATCH] build: replace weak symbols with a static library

2012-11-16 Thread Peter Maydell
On 16 November 2012 15:50, Paolo Bonzini wrote: > Weak symbols were a nice idea, but they turned out not to be > a good one. Toolchain support is just too sparse. > > This patch uses a surprisingly low-tech approach, i.e. static > libraries. Symbols in a static library are always overridden > by

[Qemu-devel] [PATCH] configure: Default to 'cc', not 'gcc', on MacOS X

2012-11-16 Thread Peter Maydell
When building for MacOS X, default the C compiler to 'cc' (usually clang) rather than 'gcc'. This avoids the Apple 'gcc', which is generally an elderly llvm-gcc provided mostly for legacy purposes, in favour of the best supported compiler available on the platform. Signed-off-by: Peter Maydell --

[Qemu-devel] [RFC/RFT PATCH] build: replace weak symbols with a static library

2012-11-16 Thread Paolo Bonzini
Weak symbols were a nice idea, but they turned out not to be a good one. Toolchain support is just too sparse. This patch uses a surprisingly low-tech approach, i.e. static libraries. Symbols in a static library are always overridden by symbols in an object file. Furthermore, if you place each

Re: [Qemu-devel] [Spice-devel] QEMU hangs when shutdown windows7 guest with virtio-serial drivers installed

2012-11-16 Thread Marian Krcmarik
- Original Message - > From: "Christophe Fergeau" > To: "Dunrong Huang" > Cc: "Amit Shah" , "spice-devel" > , "qemu-devel" > > Sent: Friday, November 16, 2012 11:49:30 AM > Subject: Re: [Spice-devel] QEMU hangs when shutdown windows7 guest with > virtio-serial drivers installed > >

[Qemu-devel] [RFC PATCH 3/3] virtio-blk : add the virtio-blk device.

2012-11-16 Thread fred . konrad
From: KONRAD Frederic This patch just add the virtio-blk device which can connect on a Virtio-Bus. The initialization fail if no free VirtioBus are present. Signed-off-by: KONRAD Frederic --- hw/virtio-blk.c | 84 + hw/virtio-blk.h | 7 +

[Qemu-devel] [RFC PATCH 2/3] virtio-pci : Add a virtio-bus interface

2012-11-16 Thread fred . konrad
From: KONRAD Frederic This patch add a VirtioBus in the VirtIOPCIProxy structure. It creates a new device : "virtio-pci" which init the VirtioBus. Two callback are written : * void virtio_pci_init_cb(DeviceState *dev) to initialize the PCI interface after the VirtIODevice init, it is a

[Qemu-devel] [RFC PATCH 1/3] virtio-bus : Introduce VirtioBus.

2012-11-16 Thread fred . konrad
From: KONRAD Frederic This patch create a new VirtioBus, which can be added to Virtio transports like virtio-pci, virtio-mmio,... One VirtIODevice can be connected to this device, like virtio-blk in the 3rd patch. The VirtioBus shares through a VirtioBusInfo structure : * two callbacks wit

[Qemu-devel] [RFC PATCH 0/3] Virtio refactoring.

2012-11-16 Thread fred . konrad
Hi, I submit this RFC to be sure I'm doing the right thing about the VirtioBus. I push the patchset here : git://git.greensocs.com/qemu_virtio.git virtio_refact What I proposed to do : * Introduce a new VirtioBus ( same way as scsi-bus.c ), with VirtIODevice interface : ->

[Qemu-devel] [PATCH] vnc: added initial websockets support

2012-11-16 Thread Tim Hardeck
This patch adds basic Websockets version 13 - RFC 6455 - support to QEMU VNC. Binary encoding support on the client side is required. Websockets support in QEMU is enabled by the configure option --enable-vnc-ws. Websockets connections are recognized by waiting 500ms for a Websocket handshake. If

[Qemu-devel] [PATCH] vnc: added initial websockets support

2012-11-16 Thread Tim Hardeck
This patch adds basic Websockets support to the QEMU VNC component. Websockets allow every modern web browser to connect to QEMU VNC without any additional plugins. Because of the GnuTLS requirement the Websockets implementation is optional (--enable-vnc-ws). Websockets connections are recogni

Re: [Qemu-devel] "usb: uhci: Look up queue by address, not token"

2012-11-16 Thread Jan Kiszka
On 2012-11-16 14:29, Hans de Goede wrote: > Hi, > > On 11/15/2012 04:40 PM, Jan Kiszka wrote: >> Hi Hans, >> >> On 2012-11-15 16:19, Hans de Goede wrote: >>> Hi Jan, >>> >>> I just saw your $subject patch in Gerd's usb-next tree, and I've a question >>> about it. The token should be enough to uniq

[Qemu-devel] [PATCH V2 4/4] block export function path_has_protocol

2012-11-16 Thread Wenchao Xia
This function is needed in other module, so export it. There is already some patch on mail-list try export it, If that patch was applied, pls ignore this one. Signed-off-by: Wenchao Xia --- block.c |2 +- block.h |2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/blo

[Qemu-devel] [PATCH 02/14] usb: Fix (another) bug in usb_packet_map() for IOMMU handling

2012-11-16 Thread Gerd Hoffmann
From: David Gibson Elements in qemu SGLists can cross IOMMU page boundaries. So, in commit 39c138c8420f51a7da7b35233a8d7400a0b589ac "usb: Fix usb_packet_map() in the presence of IOMMUs", I changed usb_packet_map() to split up each SGList element on IOMMU page boundaries and each resulting piece

[Qemu-devel] [PATCH V2 2/4] Buildsystem clean tests directory clearly

2012-11-16 Thread Wenchao Xia
Currently root Makefile try clean tests/tcg, hard to extend. This patch added command make check-clean, which clean all generated files used in tests. With this command root Makefile do not care tests clean method any more, it simply calls the command to do it, so any more clean script could be a

[Qemu-devel] [PATCH 08/14] ehci: Don't verify the next pointer for periodic qh-s and qtd-s

2012-11-16 Thread Gerd Hoffmann
From: Hans de Goede While testing the move to async packet handling for interrupt endpoints I noticed that Windows-XP likes to play tricks with the next pointer for periodic qh-s, so we should not fail qh / qtd verification when it changes. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffm

[Qemu-devel] [PATCH 09/14] ehci: keep the frame timer running in case the guest asked for frame list rollover interrupts

2012-11-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 287a066..14269da 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -964,6 +964,9 @@ static void ehci_opreg_write(vo

[Qemu-devel] [PATCH V7 4/6] Adding common code for VMWARE network devices

2012-11-16 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/vmware_utils.h | 24 ++-- hw/vmxnet_debug.h | 121 +++ hw/vmxnet_utils.c | 219 +++ hw/vmxnet_utils.h | 340 ++ 4 files changed

[Qemu-devel] [PATCH V7 2/6] Adding utility function iov_net_csum_add() for iovec checksum calculation Adding utility function iov_rebuild() for smart iovec copy

2012-11-16 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- Makefile.objs | 1 + iov.c | 53 + iov.h | 13 + tests/Makefile | 2 +- 4 files changed, 68 insertions(+), 1 deletion(-) diff --git a/Makefile.ob

Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Remove stray debug output

2012-11-16 Thread Stefan Hajnoczi
On Sat, Oct 20, 2012 at 08:37:04PM +0100, Peter Maydell wrote: > Rather than printing a message saying we're silently falling > back to gthread coroutines when running on MacOS, actually > do it silently. > > Signed-off-by: Peter Maydell > --- > I guess this is a self-falsifying echo :-) > > co

[Qemu-devel] [PATCH 1/4] net: add public qemu_net_poll() function

2012-11-16 Thread Stefan Hajnoczi
The NetClientInfo .poll() callback is being called directly by hw/vhost_net.c. Create a public net.c function so callers do not depend on internals. This change is useful because later patches change net internals. Those changes shouldn't affect .poll() callers. Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PATCH 12/14] usb-redir: Set default debug level to warning

2012-11-16 Thread Gerd Hoffmann
From: Hans de Goede The previous default of 0 means that even errors and warnings would not get printed, which is really not a good default. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH 01/14] fix live migration

2012-11-16 Thread Gerd Hoffmann
Commit 1c380f9460522f32c8dd2577b2a53d518ec91c6d breaks live migration. DMA stops working for ehci (and probably for any pci device) after restoring the guest because the bus master region never gets enabled. Add code doing that after loading the pci config space from vmstate. Cc: Avi Kivity Cc: H

[Qemu-devel] [PATCH 07/14] ehci: Better detection for qtd-s linked in circles

2012-11-16 Thread Gerd Hoffmann
From: Hans de Goede Windows links interrupt qtd-s in circles, which means that when interrupt endpoints return USB_RET_ASYNC, combined with the recent "ehci: Retry to fill the queue while waiting for td completion" patch, we keep adding the tds to the queue over and over again, as we detect the c

[Qemu-devel] [PATCH 13/14] usb-host: update tracing

2012-11-16 Thread Gerd Hoffmann
Now that we have separate status and length fields in USBPacket update the completion tracepoint to log both. Signed-off-by: Gerd Hoffmann --- hw/usb/host-linux.c | 20 trace-events|2 +- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/hw/usb/ho

[Qemu-devel] [PATCH 14/14] usb-host: fix splitted transfers

2012-11-16 Thread Gerd Hoffmann
USBPacket->actual_length wasn't updated correctly for USBPackets splitted into multiple urbs. Fix it. Signed-off-by: Gerd Hoffmann --- hw/usb/host-linux.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/usb/host-linux.c b/hw/usb/host-linux.c index e3d394f..aa77

[Qemu-devel] [PATCH 11/14] usb-redir: Only add actually in flight packets to the in flight queue

2012-11-16 Thread Gerd Hoffmann
From: Hans de Goede Packets which are queued up, but not yet handed over to the device, are *not* in flight. Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/hw/usb/redirect.c b/hw/usb/r

[Qemu-devel] [PULL for-1.3 00/14] usb patch queue

2012-11-16 Thread Gerd Hoffmann
Hi, A bunch of usb bugfixes all over the place piled up in the usb patch queue. Here we go. please pull, Gerd The following changes since commit 6801038bc52d61f81ac8a25fbe392f1bad982887: target-mips: fix wrong microMIPS opcode encoding (2012-11-15 14:48:16 +0100) are available in the gi

[Qemu-devel] [PATCH V7 5/6] Adding packet abstraction for VMWARE network devices

2012-11-16 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/vmxnet_pkt.c | 776 ++ hw/vmxnet_pkt.h | 311 ++ hw/vmxnet_utils.c | 6 +- hw/vmxnet_utils.h | 6 +- 4 files changed, 1093 insertions(+), 6 deletion

[Qemu-devel] [PATCH V7 3/6] Adding common definitions for VMWARE devices

2012-11-16 Thread Dmitry Fleytman
Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- hw/vmware_utils.h | 143 ++ 1 file changed, 143 insertions(+) create mode 100644 hw/vmware_utils.h diff --git a/hw/vmware_utils.h b/hw/vmware_utils.h new file mode 100644 index

[Qemu-devel] [PATCH V7 1/6] Adding utility function net_checksum_add_cont() that allows checksum calculation of scattered data with odd chunk sizes

2012-11-16 Thread Dmitry Fleytman
Adding utility function net_raw_checksum() that calculates checksum of buffer given Signed-off-by: Dmitry Fleytman Signed-off-by: Yan Vugenfirer --- net/checksum.c | 13 +++-- net/checksum.h | 14 +- 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/net/checksu

[Qemu-devel] [PATCH V7 0/6] VMXNET3 paravirtual NIC device implementation

2012-11-16 Thread Dmitry Fleytman
NOTE: This is not a final patches for commit, they are just for the latest fixes review. This set of patches still misses test for the device. We didn't succeed to find any guide or sample for the king of tests required (packets transmission). If someone can provide

[Qemu-devel] [PATCH 2/2] sd: Send debug printfery to stderr not stdout

2012-11-16 Thread Stefan Hajnoczi
From: Peter Crosthwaite Some debug printfs for SD are coming up in stdout. Redirected them to stderr instead. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- hw/sd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/sd.c

[Qemu-devel] [PATCH 04/14] usb: host-linux: Ignore parsing errors of the device descriptors

2012-11-16 Thread Gerd Hoffmann
From: Jan Kiszka The Linux is more tolerant here as well: Just stop parsing the device descriptors when an error is detected but do not reset what was found so far. This allows to run buggy devices with partially invalid descriptors. Signed-off-by: Jan Kiszka Signed-off-by: Gerd Hoffmann ---

[Qemu-devel] [PATCH 1/2] qemu-sockets: Fix parsing of the inet option 'to'.

2012-11-16 Thread Stefan Hajnoczi
From: Anthony PERARD Having a qemu command line argument like "-vnc 127.0.0.1:0,to=99" is broken. This have been break with commit 879e45c72da1569e07fbbc6a1aa2a708ea796044. Signed-off-by: Anthony PERARD Signed-off-by: Stefan Hajnoczi --- qemu-sockets.c | 5 +++-- 1 file changed, 3 insertions(

[Qemu-devel] [PATCH 0/2] Trivial patches for 2 to 16 November 2012

2012-11-16 Thread Stefan Hajnoczi
The following changes since commit 6801038bc52d61f81ac8a25fbe392f1bad982887: target-mips: fix wrong microMIPS opcode encoding (2012-11-15 14:48:16 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch changes up to 5719bd7c5a5ced7

[Qemu-devel] [PATCH 03/14] usb-host: scan for usb devices when the vm starts

2012-11-16 Thread Gerd Hoffmann
Commit a844ed842d9a9d929645c09ae0f52f753d7a02e0 leads to usb-host detecting devices not right after qemu startup because the guest isn't running yet. Instead they are found on the first of the regular usb device poll runs. Which is too late for seabios to see them, so booting from usb sticks fail

Re: [Qemu-devel] [Qemu-trivial] [PATCH] target-mips: Add comments on POOL32Axf encoding

2012-11-16 Thread Stefan Hajnoczi
On Fri, Nov 16, 2012 at 10:29:47AM +0800, 陳韋任 (Wei-Ren Chen) wrote: > Current QEMU MIPS POOL32AXF encoding comes from microMIPS32 > and microMIPS32 DSP. Add comment here to help reading. > > Please review, thanks. > > Regards, > chenwj > > Signed-off-by: Chen Wei-Ren > --- > target-mips/tr

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] target-mips: Clean up microMIPS32 major opcode

2012-11-16 Thread Stefan Hajnoczi
On Fri, Nov 16, 2012 at 10:05:52AM +0800, 陳韋任 (Wei-Ren Chen) wrote: > Hi all, > > I check MIPS microMIPS manual [1], and found the major opcode might be > wrong. I add a comment to explicitly indicate what manual I am refering > to, and according that manual I remove microMIPS32 major opcodes 0x

Re: [Qemu-devel] [PATCH] ehci: fix compile error with EHCI_DEBUG enabled

2012-11-16 Thread Gerd Hoffmann
On 11/16/12 14:50, Stefan Hajnoczi wrote: > On Mon, Nov 12, 2012 at 09:49:19AM -0500, Gabriel L. Somlo wrote: >> Turning EHCI_DEBUG on gave me compile errors. This is my best guess >> as to what the DPRINTF arguments *should* be, hope I guessed right :) > > In that case I'll let Gerd confirm wheth

[Qemu-devel] [PATCH 10/14] ehci: handle dma errors

2012-11-16 Thread Gerd Hoffmann
Starting with commit 1c380f9460522f32c8dd2577b2a53d518ec91c6d dma transfers can actually fail. This patch makes ehci keep track of the busmaster bit in pci config space, by setting/clearing the dma_context pointer. Attempts to dma without context will result in raising HSE (Host System Error) int

[Qemu-devel] [PATCH 06/14] ehci: Fixup q->qtdaddr after cancelling an already completed packet

2012-11-16 Thread Gerd Hoffmann
From: Hans de Goede This avoids the q->qtdaddr == p->qtdaddr asserts we have triggering, when a queue contains multiple completed packages when we cancel the queue. I triggered this with windows7 + async interrupt endpoint handling (*) + not detecting circles in ehci_fill_queue() properly, which

Re: [Qemu-devel] [Qemu-trivial] [PATCH] sd: Send debug printfery to stderr not stdout

2012-11-16 Thread Stefan Hajnoczi
On Thu, Nov 15, 2012 at 04:32:53PM +1000, Peter Crosthwaite wrote: > Some debug printfs for SD are coming up in stdout. Redirected them to stderr > instead. > > Signed-off-by: Peter Crosthwaite > --- > hw/sd.c |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Thanks, applied to th

[Qemu-devel] [PATCH 05/14] ehci: Don't access packet after freeing it

2012-11-16 Thread Gerd Hoffmann
From: Hans de Goede ehci_state_writeback() will free the packet, so we should not access the packet after calling ehci_state_writeback(). Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --

Re: [Qemu-devel] [PATCH] ehci: fix compile error with EHCI_DEBUG enabled

2012-11-16 Thread Stefan Hajnoczi
On Mon, Nov 12, 2012 at 09:49:19AM -0500, Gabriel L. Somlo wrote: > This patch fixes a few debugging print statements whose arguments fell > out of sync over time with changes being made to the active code base. > > Signed-off-by: Gabriel Somlo > --- > > On Mon, Nov 12, 2012 at 11:26:18AM +0100,

[Qemu-devel] [PATCH 2/2] vga: fix mmio vga register mapping

2012-11-16 Thread Gerd Hoffmann
--- hw/vga-pci.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/vga-pci.c b/hw/vga-pci.c index ec29cac..947e35c 100644 --- a/hw/vga-pci.c +++ b/hw/vga-pci.c @@ -84,9 +84,10 @@ static void pci_vga_ioport_write(void *ptr, hwaddr addr,

[Qemu-devel] [PULL for-1.3 0/2] vga bugfixes

2012-11-16 Thread Gerd Hoffmann
Hi, Two little fixes for the standard vga, sent to the list for review earlier this week. please pull, Gerd The following changes since commit 6801038bc52d61f81ac8a25fbe392f1bad982887: target-mips: fix wrong microMIPS opcode encoding (2012-11-15 14:48:16 +0100) are available in the git r

[Qemu-devel] [PATCH 1/2] vga: fix bochs alignment issue

2012-11-16 Thread Gerd Hoffmann
The bochs dispi interface traditionally uses port 0x1ce as 16bit index register and port 0x1cf as 16bit data register. The later is unaligned, and probably for that reason the the data register was moved to 0x1d0 for non-x86 archs. This patch makes the data register available at 0x1d0 on x86 too.

Re: [Qemu-devel] [Qemu-trivial] [PATCH V2] qemu-sockets: Fix parsing of the inet option 'to'.

2012-11-16 Thread Stefan Hajnoczi
On Fri, Nov 09, 2012 at 11:50:54AM +, Anthony PERARD wrote: > Having a qemu command line argument like "-vnc 127.0.0.1:0,to=99" is broken. > This have been break with commit 879e45c72da1569e07fbbc6a1aa2a708ea796044. > > Signed-off-by: Anthony PERARD > > --- > qemu-sockets.c | 5 +++-- > 1 f

Re: [Qemu-devel] "usb: uhci: Look up queue by address, not token"

2012-11-16 Thread Gerd Hoffmann
On 11/16/12 12:24, Jan Kiszka wrote: > On 2012-11-16 11:25, Gerd Hoffmann wrote: >> On 11/15/12 16:40, Jan Kiszka wrote: >>> Hi Hans, >>> >>> On 2012-11-15 16:19, Hans de Goede wrote: Hi Jan, I just saw your $subject patch in Gerd's usb-next tree, and I've a question about it. T

[Qemu-devel] [PATCH 4/4] tap: reset vnet header size on open

2012-11-16 Thread Stefan Hajnoczi
From: "Michael S. Tsirkin" For tap, we currently assume the vnet header size is 10 (the default value) but that might not be the case if tap is persistent and has been used by qemu previously. To fix, set host header size in tap device on open. Signed-off-by: Michael S. Tsirkin Signed-off-by: S

[Qemu-devel] [PATCH 2/4] net: extract notify_link_status_changed() function

2012-11-16 Thread Stefan Hajnoczi
The code to invoke the NetClientInfo .link_status_changed() callback is duplicated in several places. Create a single notify_link_status_changed() function and avoid duplication. This is useful because later patches change net internals. By having a single function it is easier to make changes w

[Qemu-devel] [PULL 0/4] Net patches

2012-11-16 Thread Stefan Hajnoczi
The following changes since commit 6801038bc52d61f81ac8a25fbe392f1bad982887: target-mips: fix wrong microMIPS opcode encoding (2012-11-15 14:48:16 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git net for you to fetch changes up to 315d78d7f9d70c44eecfdad7f0c

Re: [Qemu-devel] [PATCH v3 0/3] net: convert NetClientState to QOM

2012-11-16 Thread Stefan Hajnoczi
On Wed, Oct 24, 2012 at 9:07 AM, Stefan Hajnoczi wrote: > This series converts NetClientState from a plain C struct to QOM. This means > emulated NICs and netdevs now derive from the NetClientState base class. > There > should be no user-visible change. > > Converting the net subsystem to QOM o

[Qemu-devel] [PATCH V2 3/4] Buildsystem move qapi generation to Makefile.objs

2012-11-16 Thread Wenchao Xia
With this patch Makfile.objs control file auto generation, sub Makefiles could use file generation more easily. v2: rebase and better doc. Signed-off-by: Wenchao Xia --- Makefile | 22 -- Makefile.objs | 22 ++ 2 files changed, 22 insertions(

[Qemu-devel] [PATCH V2 1/4] Buildsystem fix distclean error for pixman

2012-11-16 Thread Wenchao Xia
Currently Makefile test if pixman have configure log, but it will return error if that file do not exist. This patch fix it. v2: print out the command. Signed-off-by: Wenchao Xia --- Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index 8

[Qemu-devel] [PATCH V2 0/4] Buildsystem fix and block func export

2012-11-16 Thread Wenchao Xia
Wenchao Xia (4): Buildsystem fix distclean error for pixman Buildsystem clean tests directory clearly Buildsystem move qapi generation to Makefile.objs block export function path_has_protocol Makefile | 30 +++--- Makefile.objs | 22

Re: [Qemu-devel] "usb: uhci: Look up queue by address, not token"

2012-11-16 Thread Hans de Goede
Hi, On 11/15/2012 04:40 PM, Jan Kiszka wrote: Hi Hans, On 2012-11-15 16:19, Hans de Goede wrote: Hi Jan, I just saw your $subject patch in Gerd's usb-next tree, and I've a question about it. The token should be enough to uniquely identify a device + ep, and unless a guest uses multiple qhs fo

[Qemu-devel] [PATCH 3/4] trace: document '-' syntax for disabling events

2012-11-16 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- docs/tracing.txt | 4 1 file changed, 4 insertions(+) diff --git a/docs/tracing.txt b/docs/tracing.txt index c541133..7901409 100644 --- a/docs/tracing.txt +++ b/docs/tracing.txt @@ -139,6 +139,10 @@ having a common prefix in a batch. For example, virtio-b

[Qemu-devel] [PATCH 4/4] trace: Remove "info trace" from documents

2012-11-16 Thread Stefan Hajnoczi
From: Liming Wang commit 88affa1c monitor: remove unused do_info_trace has removed "info trace" function from monitor, so remove it from documents. Signed-off-by: Liming Wang Signed-off-by: Stefan Hajnoczi --- docs/tracing.txt | 9 - hmp-commands.hx | 7 --- 2 files changed, 16

[Qemu-devel] [PATCH 2/4] trace: allow disabling events in events file

2012-11-16 Thread Stefan Hajnoczi
From: Gerd Hoffmann Disable trace events prefixed with a '-'. Useful to enable a group of tracepoints with exceptions, like this: usb_xhci_port_* -usb_xhci_port_read which will enable all xhci port tracepoints except reads. Signed-off-by: Gerd Hoffmann Signed-off-by: Stefan Hajnoczi ---

[Qemu-devel] [PATCH 1/4] Avoid all systemtap reserved words

2012-11-16 Thread Stefan Hajnoczi
From: "Daniel P. Berrange" Over time various systemtap reserved words have been blacklisted in the trace backend generator. The list is not complete though, so there is continued risk of problems in the future. Preempt such problems by specifying the full list of systemtap keywords listed in its

[Qemu-devel] [PULL 0/4] Tracing patches

2012-11-16 Thread Stefan Hajnoczi
The following changes since commit 6801038bc52d61f81ac8a25fbe392f1bad982887: target-mips: fix wrong microMIPS opcode encoding (2012-11-15 14:48:16 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tracing for you to fetch changes up to e94c4c9287392e9c4de5e9c

Re: [Qemu-devel] TCP based PCIE request forwarding

2012-11-16 Thread lementec fabien
Hi, Thanks for your reply. Actually, I wanted to be independant of the QEMU event loop. Plus, some proprietary simulation environment provides a closed socket based interface to 'stimulate' the emulated device, at the PCIE level for instance. These environments are sometimes installed on cluster

Re: [Qemu-devel] [PATCH V9 2/8] Buildsystem clean tests directory clearly

2012-11-16 Thread Paolo Bonzini
Il 16/11/2012 13:40, Wenchao Xia ha scritto: > I guess "make distclean" for second time would fail in this case, > because $(SRC_PATH) is not set. I found a better way to do it without > MAKEFILES: > > -ifneq ($(wildcard config-host.mak),) > - include $(SRC_PATH)/tests/Makefile > + include t

Re: [Qemu-devel] [PATCH V9 2/8] Buildsystem clean tests directory clearly

2012-11-16 Thread Wenchao Xia
于 2012-11-16 19:16, Paolo Bonzini 写道: Il 16/11/2012 12:01, Wenchao Xia ha scritto: ifneq ($(wildcard config-host.mak),) include $(SRC_PATH)/tests/Makefile endif to -include $(SRC_PATH)/tests/Makefile ? yes, but original author seems not include tests/Makefile in this condition on purpo

Re: [Qemu-devel] [PATCH] trace: Remove "info trace" from documents

2012-11-16 Thread Stefan Hajnoczi
On Fri, Nov 16, 2012 at 03:10:49PM +0800, Liming Wang wrote: > commit 88affa1c monitor: remove unused do_info_trace > > has removed "info trace" function from monitor, so remove it from documents. > > Signed-off-by: Liming Wang > --- > docs/tracing.txt |9 - > hmp-commands.hx |

Re: [Qemu-devel] [PATCH v2 2/2] block: Avoid second open for format probing

2012-11-16 Thread Stefan Hajnoczi
On Thu, Nov 15, 2012 at 01:57:37PM +0100, Kevin Wolf wrote: > This fixes problems that are caused by the additional open/close cycle > of the existing format probing, for example related to qemu-nbd without > -t option or file descriptor passing. > > Signed-off-by: Kevin Wolf > --- > block.c |

Re: [Qemu-devel] [PATCH] virtio-blk: Remove duplicate property definition

2012-11-16 Thread Stefan Hajnoczi
On Thu, Nov 15, 2012 at 01:12:14PM +1100, David Gibson wrote: > For the virtio-blk device (via virtio-pci) the property "config-wce" is > defined in two places. First, it's defined from the > DEFINE_VIRTIO_BLK_FEATURES macro, second it's defined directly in > virtio-pci, just two lines above the c

Re: [Qemu-devel] TCP based PCIE request forwarding

2012-11-16 Thread Stefan Hajnoczi
On Fri, Nov 16, 2012 at 9:39 AM, lementec fabien wrote: > I am a software engineer who works in an electronic group. Using QEMU > to emulate devices allows me to start writing and testing LINUX software > before the device is actually available. In the group, we are mostly > working with XILINX FP

[Qemu-devel] [PATCH 0/7] target-mips: DSP ASE fixes and cleanup

2012-11-16 Thread Aurelien Jarno
This patch series contains some fixes and cleanup following the merge of the DSP ASE patches. Aurelien Jarno (7): target-mips: fix DSP loads with rd = 0 target-mips: generate a reserved instruction exception on CPU without DSP target-mips: add unions to access DSP elements target-mips: use

[Qemu-devel] [PATCH 3/7] target-mips: add unions to access DSP elements

2012-11-16 Thread Aurelien Jarno
Instead of playing with bit shifting, add two unions (one for 32-bit values, one for 64-bit ones) to access all the DSP elements with the correct type. This make the code easier to read and less error prone, and allow GCC to vectorize the code in some cases. Signed-off-by: Aurelien Jarno --- ta

[Qemu-devel] [PATCH 6/7] target-mips: use DSP unions for reduction add instructions

2012-11-16 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- target-mips/dsp_helper.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c index 3bd2d35..474c249 100644 --- a/target-mips/dsp_helper.c +++ b/target-mips/ds

[Qemu-devel] [PATCH 4/7] target-mips: use DSP unions for binary DSP operators

2012-11-16 Thread Aurelien Jarno
This allow to reduce the number of macros. Signed-off-by: Aurelien Jarno --- target-mips/dsp_helper.c | 384 ++ 1 file changed, 116 insertions(+), 268 deletions(-) diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c index 8015d8d..931ca7

[Qemu-devel] [PATCH 5/7] target-mips: use DSP unions for unary DSP operators

2012-11-16 Thread Aurelien Jarno
This allow to reduce the number of macros. Signed-off-by: Aurelien Jarno --- target-mips/dsp_helper.c | 124 -- 1 file changed, 42 insertions(+), 82 deletions(-) diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c index 931ca70..3bd2d35

Re: [Qemu-devel] [Spice-devel] QEMU hangs when shutdown windows7 guest with virtio-serial drivers installed

2012-11-16 Thread Christophe Fergeau
Hey, On Fri, Nov 16, 2012 at 07:22:58PM +0800, Dunrong Huang wrote: > 2012/11/16 Christophe Fergeau : > > On Fri, Nov 16, 2012 at 06:02:33PM +0800, Dunrong Huang wrote: > >> I meet a weird problem: > >> If I I boot QEMU with virtio-serial being enabled and assign only one > >> cpu to windows VM, w

[Qemu-devel] [PATCH 1/7] target-mips: fix DSP loads with rd = 0

2012-11-16 Thread Aurelien Jarno
When rd is 0, which still need to do the actually load to possibly generate a TLB exception. Signed-off-by: Aurelien Jarno --- target-mips/translate.c |5 - 1 file changed, 5 deletions(-) diff --git a/target-mips/translate.c b/target-mips/translate.c index 01b48fa..c3e00c5 100644 --- a/

Re: [Qemu-devel] [Spice-devel] QEMU hangs when shutdown windows7 guest with virtio-serial drivers installed

2012-11-16 Thread Dunrong Huang
2012/11/16 Marian Krcmarik : > > > - Original Message - >> From: "Christophe Fergeau" >> To: "Dunrong Huang" >> Cc: "Amit Shah" , "spice-devel" >> , "qemu-devel" >> >> Sent: Friday, November 16, 2012 11:49:30 AM >> Subject: Re: [Spice-devel] QEMU hangs when shutdown windows7 guest with

Re: [Qemu-devel] "usb: uhci: Look up queue by address, not token"

2012-11-16 Thread Jan Kiszka
On 2012-11-16 11:25, Gerd Hoffmann wrote: > On 11/15/12 16:40, Jan Kiszka wrote: >> Hi Hans, >> >> On 2012-11-15 16:19, Hans de Goede wrote: >>> Hi Jan, >>> >>> I just saw your $subject patch in Gerd's usb-next tree, and I've a question >>> about it. The token should be enough to uniquely identify

Re: [Qemu-devel] [Spice-devel] QEMU hangs when shutdown windows7 guest with virtio-serial drivers installed

2012-11-16 Thread Dunrong Huang
Thanks for your quick reply. 2012/11/16 Christophe Fergeau : > On Fri, Nov 16, 2012 at 06:02:33PM +0800, Dunrong Huang wrote: >> I meet a weird problem: >> If I I boot QEMU with virtio-serial being enabled and assign only one >> cpu to windows VM, when I shutdown VM, QEMU hangs with using 100% cpu

[Qemu-devel] [PATCH 7/7] target-mips: implement DSP (d)append sub-class with TCG

2012-11-16 Thread Aurelien Jarno
DSP instruction from the (d)append sub-class can be implemented with TCG. Use a different function for these instructions are they are quite different from compare-pick sub-class. Fix BALIGN instruction for negative value, where the value should be zero-extended before being shift to the right. S

Re: [Qemu-devel] [PATCH V9 2/8] Buildsystem clean tests directory clearly

2012-11-16 Thread Paolo Bonzini
Il 16/11/2012 12:01, Wenchao Xia ha scritto: >> >> >> ifneq ($(wildcard config-host.mak),) >> include $(SRC_PATH)/tests/Makefile >> endif >> >> to >> >> -include $(SRC_PATH)/tests/Makefile >> >> ? >> > yes, but original author seems not include tests/Makefile in > this condition on purpose, so us

Re: [Qemu-devel] [PATCH V9 3/8] Buildsystem move qapi generation to Makefile.objs

2012-11-16 Thread Paolo Bonzini
Il 16/11/2012 11:58, Wenchao Xia ha scritto: >>>Sub Makefile may need qapi generated files, so move them to >>> Makefile.objs, >>> In this way Makfile.objs control file auto generation. >> >> No objection in principle, but why are you doing this? Does it fix >> anything? > > It seems tools

Re: [Qemu-devel] [PATCH V9 5/8] libqblock build system

2012-11-16 Thread Paolo Bonzini
Il 16/11/2012 11:12, Wenchao Xia ha scritto: > Libqblock was placed in new directory ./libqblock, libtool will build > dynamic library there, source files of block layer remains in ./block. > So block related source code will generate 3 sets of binary, first is old > ones used in qemu, second and

Re: [Qemu-devel] [PATCH V9 2/8] Buildsystem clean tests directory clearly

2012-11-16 Thread Wenchao Xia
于 2012-11-16 18:56, Paolo Bonzini 写道: Il 16/11/2012 11:31, Wenchao Xia ha scritto: 于 2012-11-16 18:23, Peter Maydell 写道: On 16 November 2012 10:12, Wenchao Xia wrote: Currently make clean only clean tests/tcg and hard to extend. This patch added command make check-clean, which clean all g

  1   2   >