Re: [Qemu-devel] [RFC-v3 0/5] vhost-scsi: Add support for host virtualized target

2012-09-06 Thread Nicholas A. Bellinger
On Fri, 2012-09-07 at 09:37 +0300, Michael S. Tsirkin wrote: > On Fri, Sep 07, 2012 at 09:32:37AM +0300, Michael S. Tsirkin wrote: > > On Fri, Sep 07, 2012 at 09:23:22AM +0300, Michael S. Tsirkin wrote: > > > On Tue, Aug 21, 2012 at 08:52:06PM +, Nicholas A. Bellinger wrote: > > > > From: Nicho

[Qemu-devel] [PATCH 0/5] vhost-scsi: Add support for host virtualized target

2012-09-06 Thread Nicholas A. Bellinger
From: Nicholas Bellinger Hello Anthony & Co, This is the fourth installment to add host virtualized target support for the mainline tcm_vhost fabric driver using Linux v3.6-rc into QEMU 1.3.0-rc. The series is available directly from the following git branch: git://git.kernel.org/pub/scm/vi

Re: [Qemu-devel] [PATCH] smbios: convert to use QemuOpts

2012-09-06 Thread Markus Armbruster
Hello, this is your friendly remote compile service. Anthony Liguori writes: > Signed-off-by: Anthony Liguori > --- > arch_init.c | 10 +- > arch_init.h |2 +- > hw/smbios.c | 53 +++-- > hw/smbios.h |2 +- > qemu-conf

Re: [Qemu-devel] [RFC-v3 0/5] vhost-scsi: Add support for host virtualized target

2012-09-06 Thread Michael S. Tsirkin
On Fri, Sep 07, 2012 at 09:32:37AM +0300, Michael S. Tsirkin wrote: > On Fri, Sep 07, 2012 at 09:23:22AM +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 21, 2012 at 08:52:06PM +, Nicholas A. Bellinger wrote: > > > From: Nicholas Bellinger > > > > > > Hi folks, > > > > > > This is the third

Re: [Qemu-devel] [RFC-v3 0/5] vhost-scsi: Add support for host virtualized target

2012-09-06 Thread Michael S. Tsirkin
On Fri, Sep 07, 2012 at 09:23:22AM +0300, Michael S. Tsirkin wrote: > On Tue, Aug 21, 2012 at 08:52:06PM +, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger > > > > Hi folks, > > > > This is the third RFC for vhost-scsi patches against mainline QEMU v1.1 > > I rebased on top of 1.2

Re: [Qemu-devel] [RFC-v3 0/5] vhost-scsi: Add support for host virtualized target

2012-09-06 Thread Michael S. Tsirkin
On Tue, Aug 21, 2012 at 08:52:06PM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi folks, > > This is the third RFC for vhost-scsi patches against mainline QEMU v1.1 I rebased on top of 1.2 and put this in my tree: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git pci Pl

[Qemu-devel] [PULL] pci minor tweaks

2012-09-06 Thread Michael S. Tsirkin
The following changes since commit 6e4c0d1f03d6ab407509c32fab7cb4b8230f57ff: hw/pl110: Fix spelling of 'palette' (2012-09-06 17:04:33 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony for you to fetch changes up to 0e180d9c8a7

Re: [Qemu-devel] [RFC-v3 3/5] vhost-scsi: add -vhost-scsi host device for use with tcm-vhost

2012-09-06 Thread Michael S. Tsirkin
On Tue, Aug 21, 2012 at 08:52:09PM +, Nicholas A. Bellinger wrote: > From: Stefan Hajnoczi > > This patch adds a new type of host device that drives the vhost_scsi > device. The syntax to add vhost-scsi is: > > qemu -vhost-scsi id=vhost-scsi0,wwpn=...,tpgt=123 > > The virtio-scsi emulate

Re: [Qemu-devel] [RFC-v3 0/5] vhost-scsi: Add support for host virtualized target

2012-09-06 Thread Michael S. Tsirkin
On Tue, Aug 21, 2012 at 08:52:06PM +, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Hi folks, > > This is the third RFC for vhost-scsi patches against mainline QEMU v1.1 > to support the upstream tcm_vhost host virtualized target driver now > available in v3.6-rc kernel code.

Re: [Qemu-devel] [PATCH 2/2 v2] pcie_aer: clear cmask for Advanced Error Interrupt Message Number

2012-09-06 Thread Michael S. Tsirkin
On Tue, Sep 04, 2012 at 04:22:46PM -0400, Jason Baron wrote: > On Fri, Aug 31, 2012 at 11:43:31AM -0400, Jason Baron wrote: > > On Fri, Aug 31, 2012 at 06:35:13PM +0300, Michael S. Tsirkin wrote: > > > On Fri, Aug 31, 2012 at 10:45:52AM -0400, Jason Baron wrote: > > > > On Fri, Aug 31, 2012 at 11:4

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-06 Thread Bharata B Rao
On Thu, Sep 06, 2012 at 09:35:04AM +0200, Paolo Bonzini wrote: > > +static int qemu_gluster_open(BlockDriverState *bs, const char *filename, > > +int bdrv_flags) > > +{ > > +BDRVGlusterState *s = bs->opaque; > > +int open_flags = 0; > > +int ret = 0; > > +GlusterURI *uri = g_mal

Re: [Qemu-devel] [PATCH 02/21] target-s390x: split FPU ops

2012-09-06 Thread Alexander Graf
Quoting Richard Henderson : On 09/06/2012 11:42 AM, Alexander Graf wrote: Richard, while at it, could you please check the s390x tcg target? Running any target on there seems to break in the TLB code for me. I did successfully run a simple linux-user test directly off blue's patch set. It ex

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-06 Thread Bharata B Rao
On Thu, Sep 06, 2012 at 04:47:17PM +0100, Daniel P. Berrange wrote: > IMHO this is all gross. URIs already have a well defined way to provide > multiple parameters, dealing with escaping of special characters. ie query > parameters. The whole benefit of using URI syntax is to let apps process > the

[Qemu-devel] [PATCH v2] add a boot parameter to set reboot timeout

2012-09-06 Thread Amos Kong
Added an option to let qemu transfer a configuration file to bios, "etc/boot-fail-wait", which could be specified by command -boot reboot-timeout=T T have a max value of 0x, unit is ms. With this option, guest will wait for a given time if not find bootabled device, then reboot. If reboot-

Re: [Qemu-devel] [PATCH] add a boot parameter to set reboot timeout

2012-09-06 Thread Amos Kong
On 06/09/12 20:46, Gleb Natapov wrote: On Thu, Sep 06, 2012 at 08:39:24PM +0800, Amos Kong wrote: Added an option to let qemu transfer a configuration file to bios, "etc/boot-fail-wait", which could be specified by command -boot reboot-timeout=T T have a max value of 0x, unit is ms. Wi

Re: [Qemu-devel] RFC: Add a new boot parameter to set delay time before seabios retry to boot

2012-09-06 Thread Kevin O'Connor
On Thu, Sep 06, 2012 at 08:36:24AM -0500, Anthony Liguori wrote: > Amos Kong writes: > > > Hi all, > > > > Seabios supports automatically reboot after X second delay on failed > > boot [1], > > I want to add a parameter for qemu, it's used put a boot parameter into > > romfile > > for seabios t

Re: [Qemu-devel] [PATCH v2] virtio-spec: Add virtio-ccw spec.

2012-09-06 Thread Rusty Russell
Cornelia Huck writes: > On Thu, 06 Sep 2012 11:56:31 +0930 > Rusty Russell wrote: > >> Cornelia Huck writes: >> >> > Add specifications for the new s390 specific virtio-ccw transport. >> > >> > Signed-off-by: Cornelia Huck >> >> Excellent. I have applied and pushed this revision. > > Cool.

Re: [Qemu-devel] [Qemu-ppc] [PATCH: RFC] Adding BAR0 for e500 PCI controller

2012-09-06 Thread Scott Wood
On 09/03/2012 01:44 AM, Bhushan Bharat-R65777 wrote: > > >> -Original Message- From: Wood Scott-B07421 Sent: Wednesday, >> August 15, 2012 6:59 AM To: Bhushan Bharat-R65777 Cc: >> qemu-devel@nongnu.org; qemu-...@nongnu.org; ag...@suse.de; Bhushan >> Bharat- R65777 Subject: Re: [Qemu-ppc]

[Qemu-devel] [PATCH] musicpal: Fix flash mapping

2012-09-06 Thread Jan Kiszka
The old arithmetic assumed 32 physical address bits which is no longer true for ARM since 3cc0cd61f4. Signed-off-by: Jan Kiszka --- hw/musicpal.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/musicpal.c b/hw/musicpal.c index ad725b5..10c2c16 100644 --- a/hw/music

Re: [Qemu-devel] [SeaBIOS] RFC: Add a new boot parameter to set delay time before seabios retry to boot

2012-09-06 Thread Steve Goodrich
I'm just guessing, but perhaps because a file can be changed without rebuilding SeaBIOS. - Original Message - From: "Anthony Liguori" To: "Amos Kong" Cc: seab...@seabios.org, qemu-devel@nongnu.org Sent: Thursday, September 6, 2012 7:36:24 AM Subject: Re: [SeaBIOS] [Qemu-devel] RFC: Add

Re: [Qemu-devel] [RFC v2 PATCH 2/6] block: add live block commit functionality

2012-09-06 Thread Eric Blake
On 09/06/2012 02:37 PM, Jeff Cody wrote: > On 09/06/2012 10:00 AM, Kevin Wolf wrote: >> Am 30.08.2012 20:47, schrieb Jeff Cody: >>> This adds the live commit coroutine. This iteration focuses on the >>> commit only below the active layer, and not the active layer itself. >>> >>> The behaviour is s

Re: [Qemu-devel] [RFC v2 PATCH 6/6] QAPI: add command for live block commit, 'block-commit'

2012-09-06 Thread Jeff Cody
On 09/06/2012 10:29 AM, Kevin Wolf wrote: > Am 30.08.2012 20:47, schrieb Jeff Cody: >> The command for live block commit is added, which has the following >> arguments: >> >> device: the block device to perform the commit on (mandatory) >> base: the base image to commit into; optional (if not spe

[Qemu-devel] [PATCH] configure: fix seccomp check

2012-09-06 Thread Yann E. MORIN
Currently, if libseccomp is missing but the user explicitly requested seccomp support using --enable-seccomp, configure silently ignores the situation and disables seccomp support. This is unlike all other tests that explicitly fail in such situation. Fix that. Signed-off-by: "Yann E. MORIN" --

[Qemu-devel] [PATCH 2/5] i386: kvm: use a #define for the set of alias feature bits

2012-09-06 Thread Eduardo Habkost
Instea of using a hardcoded hex constant, define CPUID_EXT2_AMD_ALIASES as the set of CPUID[8000_0001].EDX bits that on AMD are the same as the bits of CPUID[1].EDX. Signed-off-by: Eduardo Habkost Reviewed-By: Igor Mammedov --- target-i386/cpu.h | 12 target-i386/kvm.c | 2 +- 2 f

Re: [Qemu-devel] [RFC v2 PATCH 2/6] block: add live block commit functionality

2012-09-06 Thread Jeff Cody
On 09/06/2012 10:00 AM, Kevin Wolf wrote: > Am 30.08.2012 20:47, schrieb Jeff Cody: >> This adds the live commit coroutine. This iteration focuses on the >> commit only below the active layer, and not the active layer itself. >> >> The behaviour is similar to block streaming; the sectors are walke

[Qemu-devel] [PATCH 4/5] i386: cpu: eliminate duplicate feature names

2012-09-06 Thread Eduardo Habkost
Instead of having duplicate feature names on the ext2_feature array for the AMD feature bit aliases, we keep the feature names only on the feature_name[] array, and copy the corresponding bits to cpuid_ext2_features in case the CPU vendor is AMD. This will: - Make sure we don't set the feature bi

[Qemu-devel] [PATCH 3/5] i386: cpu: replace EXT2_FEATURE_MASK with CPUID_EXT2_AMD_ALIASES

2012-09-06 Thread Eduardo Habkost
Both constants have the same value, but CPUID_EXT2_AMD_ALIASES is defined without using magic numbers. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 7c0953

Re: [Qemu-devel] [PATCH 02/21] target-s390x: split FPU ops

2012-09-06 Thread Richard Henderson
On 09/06/2012 11:42 AM, Alexander Graf wrote: > Richard, while at it, could you please check the s390x tcg target? > Running any target on there seems to break in the TLB code for me. I did successfully run a simple linux-user test directly off blue's patch set. It exercised a bit of fp and syste

[Qemu-devel] [PATCH 0/5] i386: cpu: remove duplicate feature names

2012-09-06 Thread Eduardo Habkost
The problem: - Some features are report at the same time on both CPUID[1].EDX and CPUID[8000_0001].EDX on AMD CPUs (e.g. fpu, tsc, msr, pae, mmx). - "-cpu ,+feature" should enable the bit only on CPUID[1] if it's not an AMD CPU, but it should enable the bit on both CPUID[1] and CPUID[80

[Qemu-devel] [PATCH 5/5] i386: -cpu help: remove reference to specific CPUID leaves/registers

2012-09-06 Thread Eduardo Habkost
The -cpu configuration interface is based on a list of feature names or properties, on a single namespace, so there's no need to mention on which CPUID leaf/register each flag is located. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 8 1 file changed, 4 insertions(+), 4 deleti

Re: [Qemu-devel] [PATCH V12 5/6] add-cow file format

2012-09-06 Thread Michael Roth
On Fri, Aug 10, 2012 at 11:39:44PM +0800, Dong Xu Wang wrote: > add-cow file format core code. It use block-cache.c as cache code. > > Signed-off-by: Dong Xu Wang > --- > block/Makefile.objs |1 + > block/add-cow.c | 613 > +++ > block/ad

[Qemu-devel] [PATCH 1/5] i386: kvm: bit 10 of CPUID[8000_0001].EDX is reserved

2012-09-06 Thread Eduardo Habkost
Bit 10 of CPUID[8000_0001].EDX is not defined as an alias of CPUID[1].EDX[10], so do not duplicate it on kvm_arch_get_supported_cpuid(). Signed-off-by: Eduardo Habkost Reviewed-By: Igor Mammedov --- target-i386/kvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i38

[Qemu-devel] [PATCH 7/8] fdc: remove double affectation of FD_MSR_CMDBUSY flag

2012-09-06 Thread Hervé Poussineau
FD_MSR_CMDBUSY flag is already set in fdctrl_write_data(), just before calling the command handler (fdctrl_start_transfer() here). Signed-off-by: Hervé Poussineau --- hw/fdc.c |1 - 1 file changed, 1 deletion(-) diff --git a/hw/fdc.c b/hw/fdc.c index 551160e..9c2bad2 100644 --- a/hw/fdc.c +

[Qemu-devel] [PATCH 3/8] fdc-test: Check READ ID

2012-09-06 Thread Hervé Poussineau
From: Kevin Wolf ST0 shouldn't include 0x20 (FD_SR0_SEEK) after READ ID. Signed-off-by: Kevin Wolf Signed-off-by: Hervé Poussineau --- tests/fdc-test.c | 66 ++ 1 file changed, 66 insertions(+) diff --git a/tests/fdc-test.c b/tests/fdc-te

[Qemu-devel] [PATCH 4/8] fdc: fix false FD_SR0_SEEK

2012-09-06 Thread Hervé Poussineau
fdctrl_start/stop_transfer() used to set FD_SR0_SEEK no matter if there actually was a seek or not. This is obviously wrong. fdctrl_seek_to_next_sect() has this information because it performs the seek itself. Cc: Kevin Wolf Signed-off-by: Hervé Poussineau --- hw/fdc.c | 13 +

[Qemu-devel] [PATCH 8/8] fdc: fix typo in zero constant

2012-09-06 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/fdc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/fdc.c b/hw/fdc.c index 9c2bad2..e087694 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -1248,7 +1248,7 @@ static void fdctrl_start_transfer(FDCtrl *fdctrl, int direction) fdc

[Qemu-devel] [PATCH 1/8] fdc: Remove status0 parameter from fdctrl_set_fifo()

2012-09-06 Thread Hervé Poussineau
From: Kevin Wolf It decided whether an interrupt is triggered. Only one caller made use of this functionality, so move the code there. In this one caller, the interrupt must actually be triggered unconditionally, like it was before commit 2fee0088. For example, a successful read without an impli

[Qemu-devel] [PATCH 2/8] fdc: use status0 field instead of a local variable

2012-09-06 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- hw/fdc.c | 29 - 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/hw/fdc.c b/hw/fdc.c index 78ae064..d8bffb6 100644 --- a/hw/fdc.c +++ b/hw/fdc.c @@ -327,7 +327,7 @@ static void fdctrl_reset(FDCtrl *fdctrl, int do_i

[Qemu-devel] [PATCH 5/8] fdc: implement VERIFY command

2012-09-06 Thread Hervé Poussineau
VERIFY command is like a READ command, except that read data is not transfered by DMA. As DMA engine is not used, so we have to start data transfer ourselves. Signed-off-by: Hervé Poussineau --- hw/fdc.c | 25 ++--- 1 file changed, 18 insertions(+), 7 deletions(-) diff --g

Re: [Qemu-devel] [PATCH] target-i386: Allow changing of Hypervisor CPUIDs.

2012-09-06 Thread Eduardo Habkost
On Thu, Sep 06, 2012 at 03:00:47PM -0400, Don Slutz wrote: > On 09/06/12 14:40, Eduardo Habkost wrote: > >On Thu, Sep 06, 2012 at 12:28:05PM +0200, Andreas Färber wrote: > >>Am 30.08.2012 21:20, schrieb Don Slutz: > >>>This is primarily done so that the guest will think it is running > >>>under vmw

Re: [Qemu-devel] [PATCH 2/3] fdc: Fix false FD_SR0_SEEK

2012-09-06 Thread Hervé Poussineau
Kevin Wolf a écrit : fdctrl_start/stop_transfer() used to set FD_SR0_SEEK no matter if there actually was a seek or not. This is obviously wrong. fdctrl_start_transfer() has this information because it performs the seek itself. fdctrl_stop_transfer() gets status0 passed and callers already take

[Qemu-devel] [PATCH 6/8] fdc-tests: add tests for VERIFY command

2012-09-06 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- tests/fdc-test.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/tests/fdc-test.c b/tests/fdc-test.c index b825959..4783b08 100644 --- a/tests/fdc-test.c +++ b/tests/fdc-test.c @@ -50,6 +50,7 @@ enum { CMD_SENSE_INT

[Qemu-devel] [PATCH 0/8] fdc: fix FD_SR0_SEEK flag + implement VERIFY

2012-09-06 Thread Hervé Poussineau
Attached patches have 3 goals: - patches 1-4 fix the NT 3.1 floppy driver problem. - patches 5-6 implement the VERIFY command - patches 7-8 are some simple cleanup Hervé Poussineau (6): fdc: use status0 field instead of a local variable fdc: fix false FD_SR0_SEEK fdc: implement VERIFY comman

Re: [Qemu-devel] [PATCH] target-i386: Allow changing of Hypervisor CPUIDs.

2012-09-06 Thread Don Slutz
On 09/06/12 14:40, Eduardo Habkost wrote: On Thu, Sep 06, 2012 at 12:28:05PM +0200, Andreas Färber wrote: Am 30.08.2012 21:20, schrieb Don Slutz: This is primarily done so that the guest will think it is running under vmware when hypervisor=vmware is specified as a property of a cpu. Also allo

Re: [Qemu-devel] [PATCH 1/3] target-arm: convert void helpers

2012-09-06 Thread Peter Maydell
On 4 September 2012 21:48, Peter Maydell wrote: > On 4 September 2012 21:37, Blue Swirl wrote: >> Add an explicit CPUState parameter instead of relying on AREG0. >> >> For easier review, convert only op helpers which don't return any value. >> >> Signed-off-by: Blue Swirl > > Reviewed-by: Peter

Re: [Qemu-devel] [PATCH 02/21] target-s390x: split FPU ops

2012-09-06 Thread Alexander Graf
On 05.09.2012, at 11:34, Richard Henderson wrote: > On 09/04/2012 08:46 PM, Alexander Graf wrote: >> So that means your rewrite is based on this series and just fixes it up? >> Does that mean if I apply this patch, you will be all happy? > > It is not (yet) based on this series. But I will be

Re: [Qemu-devel] [PATCH] target-i386: Allow changing of Hypervisor CPUIDs.

2012-09-06 Thread Eduardo Habkost
On Thu, Sep 06, 2012 at 12:28:05PM +0200, Andreas Färber wrote: > Am 30.08.2012 21:20, schrieb Don Slutz: > > This is primarily done so that the guest will think it is running > > under vmware when hypervisor=vmware is specified as a property of a > > cpu. > > > > Also allow this to work in accel=

Re: [Qemu-devel] [PATCH 01/21] target-s390x: fix style

2012-09-06 Thread Alexander Graf
On 02.09.2012, at 13:33, Blue Swirl wrote: > Before splitting op_helper.c and helper.c in the next patches, > fix style issues. No functional changes. > > Replace also GCC specific __FUNCTION__ with > standard __func__. > > Don't init static variable (cpu_s390x_init:inited) with 0. > > Signed-

Re: [Qemu-devel] [PATCH 05/21] target-s390x: split memory access helpers

2012-09-06 Thread Alexander Graf
On 02.09.2012, at 13:33, Blue Swirl wrote: > Move memory access helpers to mem_helper.c. > > Signed-off-by: Blue Swirl > --- > target-s390x/Makefile.objs |3 +- > target-s390x/mem_helper.c | 1190 > target-s390x/op_helper.c | 1158 +-

Re: [Qemu-devel] [RFC 2/6] i386: kill cpudef config section support

2012-09-06 Thread Eduardo Habkost
On Wed, Sep 05, 2012 at 11:39:21AM +0200, Igor Mammedov wrote: > On Wed, 5 Sep 2012 11:09:16 +0200 > Igor Mammedov wrote: > > > On Fri, 17 Aug 2012 14:53:38 -0300 > > Eduardo Habkost wrote: > > > > > It's nice to have a flexible system to maintain CPU models as data, but > > > this is holding u

Re: [Qemu-devel] [PATCH V12 4/6] rename qcow2-cache.c to block-cache.c

2012-09-06 Thread Michael Roth
On Fri, Aug 10, 2012 at 11:39:43PM +0800, Dong Xu Wang wrote: > add-cow and qcow2 file format will share the same cache code, so rename > block-cache.c to block-cache.c. And related structure and qcow2 code also "qcow2-cache.c to block-cache.c" But I've scanned through the rest of your patches an

Re: [Qemu-devel] [PATCH V12 3/6] qed_read_string to bdrv_read_string

2012-09-06 Thread Michael Roth
On Fri, Aug 10, 2012 at 11:39:42PM +0800, Dong Xu Wang wrote: > Make qed_read_string function to a common interface, so move it to block.c. > > Signed-off-by: Dong Xu Wang > --- > block.c | 27 +++ > block.h |2 ++ > block/qed.c | 29 +-

Re: [Qemu-devel] [PATCH V12 2/6] make path_has_protocol non-static

2012-09-06 Thread Michael Roth
On Fri, Aug 10, 2012 at 11:39:41PM +0800, Dong Xu Wang wrote: > We will use path_has_protocol outside block.c, so just make it public. > > Signed-off-by: Dong Xu Wang Reviewed-by: Michael Roth > --- > block.c |2 +- > block.h |1 + > 2 files changed, 2 insertions(+), 1 deletions(-) >

Re: [Qemu-devel] [PATCH V12 1/6] docs: document for add-cow file format

2012-09-06 Thread Michael Roth
On Fri, Aug 10, 2012 at 11:39:40PM +0800, Dong Xu Wang wrote: > Document for add-cow format, the usage and spec of add-cow are introduced. > > Signed-off-by: Dong Xu Wang > --- > docs/specs/add-cow.txt | 123 > > 1 files changed, 123 insertions(

Re: [Qemu-devel] [Bug 929638] Re: qemu 1.0 unable to compile on the pandaboard ES

2012-09-06 Thread Marietto
This is what I did on the pandaboard ES : git clone git://git.linaro.org/qemu/qemu-linaro.git /configure --disable-kvm --enable-tcg-interpreter --enable-curses --enable-sdl --enable-vnc --enable-debug-tcg --enable-vhost-net make you can see the error on the screenshot attached. 2012/8/3 Samuel Br

Re: [Qemu-devel] [PATCH 0/8] Improve TCG optimizer

2012-09-06 Thread Richard Henderson
On 09/06/2012 08:00 AM, Aurelien Jarno wrote: > This patch series improves the TCG optimizer, based on patterns found > while executing various guest. The brcond ad setcond constant folding > are useful especially useful when they are used to avoid some argument > values (e.g. division by 0), and t

Re: [Qemu-devel] [PATCH 7/8] tcg/optimize: add constant folding for setcond

2012-09-06 Thread Richard Henderson
On 09/06/2012 08:00 AM, Aurelien Jarno wrote: > Signed-off-by: Aurelien Jarno > --- > tcg/optimize.c | 79 > > 1 file changed, 79 insertions(+) > > diff --git a/tcg/optimize.c b/tcg/optimize.c > index 7debc8a..c4af1e8 100644 > --- a/tcg

Re: [Qemu-devel] [PATCH] Add MAINTAINERS entry for leon3

2012-09-06 Thread Fabien Chouteau
Ping! I think this patch isn't applied. Is it an oversight? On 05/22/2012 10:14 AM, Fabien Chouteau wrote: > Signed-off-by: Fabien Chouteau > --- > MAINTAINERS |6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index b45f075..3d773d3 100644 > --- a/MA

Re: [Qemu-devel] [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment

2012-09-06 Thread Jan Kiszka
On 2012-09-06 18:06, Andreas Färber wrote: > Am 06.09.2012 10:44, schrieb Jan Kiszka: >> On 2012-08-30 20:30, Jan Kiszka wrote: >>> This adds PCI device assignment for i386 targets using the classic KVM >>> interfaces. This version is 100% identical to what is being maintained >>> in qemu-kvm for s

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-06 Thread Avi Kivity
On 09/06/2012 06:47 PM, Daniel P. Berrange wrote: > > gluster:///volname/image?transport=unix&sockpath=/path/to/unix/sock Like. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment

2012-09-06 Thread Andreas Färber
Am 06.09.2012 10:44, schrieb Jan Kiszka: > On 2012-08-30 20:30, Jan Kiszka wrote: >> This adds PCI device assignment for i386 targets using the classic KVM >> interfaces. This version is 100% identical to what is being maintained >> in qemu-kvm for several years and is supported by libvirt as well.

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-06 Thread ronnie sahlberg
On Fri, Sep 7, 2012 at 1:47 AM, Daniel P. Berrange wrote: > On Thu, Sep 06, 2012 at 09:10:04PM +0530, Bharata B Rao wrote: > > On Thu, Sep 06, 2012 at 11:29:36AM +0300, Avi Kivity wrote: > > > On 08/14/2012 12:58 PM, Kevin Wolf wrote: > > > > > > > >> While we are at this, let me bring out another

[Qemu-devel] [PATCH 4/8] tcg/optimize: simplify and r, a, 0 cases

2012-09-06 Thread Aurelien Jarno
and r, a, 0 is equivalent to a movi r, 0. Signed-off-by: Aurelien Jarno --- tcg/optimize.c |1 + 1 file changed, 1 insertion(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index 0db849e..c12cb2b 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -360,6 +360,7 @@ static TCGArg *tcg_constan

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-06 Thread Daniel P. Berrange
On Thu, Sep 06, 2012 at 09:10:04PM +0530, Bharata B Rao wrote: > On Thu, Sep 06, 2012 at 11:29:36AM +0300, Avi Kivity wrote: > > On 08/14/2012 12:58 PM, Kevin Wolf wrote: > > > > > >> While we are at this, let me bring out another issue. Gluster supports 3 > > >> transport types: > > >> > > >> -

[Qemu-devel] [PATCH 7/8] tcg/optimize: add constant folding for setcond

2012-09-06 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- tcg/optimize.c | 79 1 file changed, 79 insertions(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index 7debc8a..c4af1e8 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -267,6 +267,65 @@ static TCGA

[Qemu-devel] [PATCH 6/8] tcg/optimize: swap brcond/setcond arguments when possible

2012-09-06 Thread Aurelien Jarno
brcond and setcond ops are not commutative, but it's easy to compute the new condition after swapping the arguments. Try to always put the constant argument in second position like for commutative ops, to help backends to generate better code. Signed-off-by: Aurelien Jarno --- tcg/optimize.c |

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-06 Thread Paolo Bonzini
Il 06/09/2012 17:40, Bharata B Rao ha scritto: > > > > I don't think we can fit 'unix' within the standard URI scheme (RFC > > > > 3986) > > > > easily, but I am planning to specify the 'unix' transport as below: > > > > > > > > gluster://[/path/to/unix/domain/socket]/volname/image?transport=unix

Re: [Qemu-devel] [PATCH] qemu-options.hx: Change from recommending '?' to 'help'

2012-09-06 Thread Peter Maydell
On 6 September 2012 15:55, Eric Blake wrote: > On 09/06/2012 07:54 AM, Peter Maydell wrote: >> Update the -help output and documentation so that it recommends >> 'help' rather than '?' for the various "list valid values for this >> option" cases. '?' is deprecated (as it can fail confusingly if >>

[Qemu-devel] [PATCH 8/8] tcg/optimize: add constant folding for brcond

2012-09-06 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- tcg/optimize.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index c4af1e8..1221b8b 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -601,6 +601,32 @@ static TCGArg *tcg_consta

Re: [Qemu-devel] [PATCH v6 2/2] block: Support GlusterFS as a QEMU block backend

2012-09-06 Thread Bharata B Rao
On Thu, Sep 06, 2012 at 11:29:36AM +0300, Avi Kivity wrote: > On 08/14/2012 12:58 PM, Kevin Wolf wrote: > > > >> While we are at this, let me bring out another issue. Gluster supports 3 > >> transport types: > >> > >> - socket in which case the server will be hostname, ipv4 or ipv4 address. > >>

Re: [Qemu-devel] [PATCH 17/21] target-microblaze: switch to AREG0 free mode

2012-09-06 Thread Aurelien Jarno
On Sun, Sep 02, 2012 at 05:33:46PM +, Blue Swirl wrote: > Add an explicit CPUState parameter instead of relying on AREG0 > and switch to AREG0 free mode. > > Signed-off-by: Blue Swirl > --- > configure |2 +- > target-microblaze/Makefile.objs |2 - > target-micr

Re: [Qemu-devel] [PATCH 3/7] block: raw-posix image file reopen

2012-09-06 Thread Corey Bryant
On 09/06/2012 05:23 AM, Kevin Wolf wrote: Am 05.09.2012 18:43, schrieb Jeff Cody: +} + +int fcntl_flags = O_APPEND | O_ASYNC | O_NONBLOCK; +#ifdef O_NOATIME +fcntl_flags |= O_NOATIME; +#endif +if ((raw_s->open_flags & ~fcntl_flags) == (s->open_flags & ~fcntl_flags)) { +

Re: [Qemu-devel] [PATCH] CHECKPATCH

2012-09-06 Thread Avi Kivity
On 09/02/2012 01:51 PM, Blue Swirl wrote: > I've used the following snippet to check what happens with the last 100 > commits: > for i in '' 1 2 3 4 5 6 7 8 9; do for j in 0 1 2 3 4 5 6 7 8 9; do > echo $i$j; git show HEAD~$i$j >/tmp/a; clear;head -20 /tmp/a; > ./scripts/checkpatch.pl --root=. /tm

Re: [Qemu-devel] [PATCH] Upgrade to SeaBIOS v1.7.1

2012-09-06 Thread Aurelien Jarno
On Fri, Aug 31, 2012 at 01:59:28PM -0400, Kevin O'Connor wrote: > Log of SeaBIOS changes since 5a023065: > > Kevin O'Connor (1): > Make iasl option check work with older versions of iasl. > > Paolo Bonzini (1): > scsi: add AMD PCscsi driver > > Signed-off-by: Kevin O'Connor > --- > > This

[Qemu-devel] [PATCH 1/8] tcg: improve profiler

2012-09-06 Thread Aurelien Jarno
Now that there are two passes of optimization (optimize.c, liveness) there is no point of outputing the statistics of the liveness part only. Update the code to take into account both optimizations. Signed-off-by: Aurelien Jarno --- tcg/tcg.c | 18 ++ tcg/tcg.h |2 +- 2 fil

[Qemu-devel] [PATCH 2/8] tcg/optimize: split expression simplification

2012-09-06 Thread Aurelien Jarno
Split expression simplification in multiple parts so that a given op can appear multiple times. This patch should not change anything. Signed-off-by: Aurelien Jarno --- tcg/optimize.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/tcg/optimize.c b/tcg/optimi

[Qemu-devel] [PATCH 5/8] tcg/optimize: simplify shift/rot r, 0, a => movi r, 0 cases

2012-09-06 Thread Aurelien Jarno
shift/rot r, 0, a is equivalent to movi r, 0. Signed-off-by: Aurelien Jarno --- tcg/optimize.c | 20 1 file changed, 20 insertions(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index c12cb2b..1698ba3 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -322,6 +322,26 @@

Re: [Qemu-devel] [PATCH v2] hw/pl110: Fix spelling of 'palette'

2012-09-06 Thread Aurelien Jarno
On Mon, Aug 27, 2012 at 12:32:36PM +0100, Peter Maydell wrote: > Fix the spelling of 'palette' used in various local variables, > structure members and comments. > > Signed-off-by: Peter Maydell > Reviewed-by: Stefan Weil > --- > v1->v2 changes: fix a comment which I'd missed before because > it

[Qemu-devel] [PATCH 3/8] tcg/optimize: simplify or/xor r, a, 0 cases

2012-09-06 Thread Aurelien Jarno
or/xor r, a, 0 is equivalent to a mov r, a. Signed-off-by: Aurelien Jarno --- tcg/optimize.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/tcg/optimize.c b/tcg/optimize.c index 63f970d..0db849e 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -331,6 +331,8 @@ static TCGArg *tcg_con

[Qemu-devel] [PATCH 0/8] Improve TCG optimizer

2012-09-06 Thread Aurelien Jarno
This patch series improves the TCG optimizer, based on patterns found while executing various guest. The brcond ad setcond constant folding are useful especially useful when they are used to avoid some argument values (e.g. division by 0), and thus can be optimized when this argument is a constant.

Re: [Qemu-devel] [RFC v2 PATCH 1/6] block: add support functions for live commit, to find and delete images.

2012-09-06 Thread Eric Blake
On 09/06/2012 07:23 AM, Kevin Wolf wrote: > Am 30.08.2012 20:47, schrieb Jeff Cody: >> Add bdrv_find_child(), and bdrv_delete_intermediate(). >> >> bdrv_find_child(): given 'bs' and the active (topmost) BDS of an image >> chain, >> find the image that is the immediate top of '

Re: [Qemu-devel] [RFC v2 PATCH 1/6] block: add support functions for live commit, to find and delete images.

2012-09-06 Thread Jeff Cody
On 09/06/2012 09:23 AM, Kevin Wolf wrote: > Am 30.08.2012 20:47, schrieb Jeff Cody: >> Add bdrv_find_child(), and bdrv_delete_intermediate(). >> >> bdrv_find_child(): given 'bs' and the active (topmost) BDS of an image >> chain, >> find the image that is the immediate top of '

Re: [Qemu-devel] memtest 4.20+ does not work with -cpu host

2012-09-06 Thread Avi Kivity
On 08/22/2012 06:06 PM, Peter Lieven wrote: > Hi, > > has anyone ever tested to run memtest with -cpu host flag passed to > qemu-kvm? > For me it resets when probing the chipset. With -cpu qemu64 it works > just fine. > > Maybe this is specific to memtest, but it might be sth that can happen > in

Re: [Qemu-devel] [PATCH] qemu-options.hx: Change from recommending '?' to 'help'

2012-09-06 Thread Eric Blake
On 09/06/2012 07:54 AM, Peter Maydell wrote: > Update the -help output and documentation so that it recommends > 'help' rather than '?' for the various "list valid values for this > option" cases. '?' is deprecated (as it can fail confusingly if > not quoted), so it's better to steer users towards

Re: [Qemu-devel] [RFC v2 PATCH 6/6] QAPI: add command for live block commit, 'block-commit'

2012-09-06 Thread Kevin Wolf
Am 30.08.2012 20:47, schrieb Jeff Cody: > The command for live block commit is added, which has the following > arguments: > > device: the block device to perform the commit on (mandatory) > base: the base image to commit into; optional (if not specified, > it is the underlying original

Re: [Qemu-devel] [RFC v2 PATCH 2/6] block: add live block commit functionality

2012-09-06 Thread Kevin Wolf
Am 30.08.2012 20:47, schrieb Jeff Cody: > This adds the live commit coroutine. This iteration focuses on the > commit only below the active layer, and not the active layer itself. > > The behaviour is similar to block streaming; the sectors are walked > through, and anything that exists above 'ba

Re: [Qemu-devel] [PATCH] qemu-options.hx: Change from recommending '?' to 'help'

2012-09-06 Thread Daniel P. Berrange
On Thu, Sep 06, 2012 at 02:54:40PM +0100, Peter Maydell wrote: > Update the -help output and documentation so that it recommends > 'help' rather than '?' for the various "list valid values for this > option" cases. '?' is deprecated (as it can fail confusingly if > not quoted), so it's better to st

[Qemu-devel] [PATCH] qemu-options.hx: Change from recommending '?' to 'help'

2012-09-06 Thread Peter Maydell
Update the -help output and documentation so that it recommends 'help' rather than '?' for the various "list valid values for this option" cases. '?' is deprecated (as it can fail confusingly if not quoted), so it's better to steer users towards 'help'. ('?' still works, for backwards compatibility

Re: [Qemu-devel] [PATCH v2] virtio-spec: Add virtio-ccw spec.

2012-09-06 Thread Cornelia Huck
On Thu, 06 Sep 2012 11:56:31 +0930 Rusty Russell wrote: > Cornelia Huck writes: > > > Add specifications for the new s390 specific virtio-ccw transport. > > > > Signed-off-by: Cornelia Huck > > Excellent. I have applied and pushed this revision. Cool. Unfortunately, we just discovered that

Re: [Qemu-devel] RFC: Add a new boot parameter to set delay time before seabios retry to boot

2012-09-06 Thread Anthony Liguori
Amos Kong writes: > Hi all, > > Seabios supports automatically reboot after X second delay on failed > boot [1], > I want to add a parameter for qemu, it's used put a boot parameter into > romfile > for seabios to set the delay time. > > # qemu ... -boot order=n,menu=on,delay=5 ... > > > Commen

Re: [Qemu-devel] [PATCH v2 0/4] spice: improve vga mode performance

2012-09-06 Thread Alon Levy
On Thu, Sep 06, 2012 at 07:39:23AM +0200, Gerd Hoffmann wrote: > Hi, Series is Reviewed-by: Alon Levy > > This patch series makes spice be more clever on screen updates when in > vga mode (i.e. without qxl guest driver loaded or when using a non-qxl > vga card). qemu keeps a copy of the scr

Re: [Qemu-devel] [RFC v2 PATCH 1/6] block: add support functions for live commit, to find and delete images.

2012-09-06 Thread Kevin Wolf
Am 30.08.2012 20:47, schrieb Jeff Cody: > Add bdrv_find_child(), and bdrv_delete_intermediate(). > > bdrv_find_child(): given 'bs' and the active (topmost) BDS of an image chain, > find the image that is the immediate top of 'bs' > > bdrv_delete_intermediate(): >

Re: [Qemu-devel] [PATCH] smbios: convert to use QemuOpts

2012-09-06 Thread Paolo Bonzini
Il 05/09/2012 21:52, Anthony Liguori ha scritto: > Signed-off-by: Anthony Liguori > --- > arch_init.c | 10 +- > arch_init.h |2 +- > hw/smbios.c | 53 +++-- > hw/smbios.h |2 +- > qemu-config.c | 50 +++

Re: [Qemu-devel] [PATCH 6/7] gtk: add translation support

2012-09-06 Thread Peter Maydell
On 5 September 2012 20:18, Anthony Liguori wrote: > --- a/Makefile > +++ b/Makefile > @@ -315,6 +315,9 @@ ifneq ($(BLOBS),) > $(INSTALL_DATA) $(SRC_PATH)/pc-bios/$$x > "$(DESTDIR)$(qemu_datadir)"; \ > done > endif > +ifeq ($(CONFIG_GTK),y) > + $(MAKE) -C po $@ || ex

Re: [Qemu-devel] [PATCH v2 1/4] spice: switch to queue for vga mode updates

2012-09-06 Thread Gerd Hoffmann
On 09/06/12 14:07, Kevin Wolf wrote: > SoB is missing in this one. Added. thanks, Gerd

Re: [Qemu-devel] [PATCH] target-xtensa: fix missing errno codes for mingw32

2012-09-06 Thread Max Filippov
On Thu, Sep 6, 2012 at 8:45 AM, Stefan Weil wrote: > Am 06.09.2012 02:36, schrieb Max Filippov: > >> Put the following errno value mappings under #ifdef: >> >> xtensa-semi.c: In function 'errno_h2g': >> xtensa-semi.c:113: error: 'ENOTBLK' undeclared (first use in this >> function) >> xtensa-semi.c

Re: [Qemu-devel] [PATCH] add a boot parameter to set reboot timeout

2012-09-06 Thread Gleb Natapov
On Thu, Sep 06, 2012 at 08:39:24PM +0800, Amos Kong wrote: > Added an option to let qemu transfer a configuration file to bios, > "etc/boot-fail-wait", which could be specified by command > -boot reboot-timeout=T > T have a max value of 0x, unit is ms. > > With this option, guest will wait

Re: [Qemu-devel] [PATCH 6/7] gtk: add translation support

2012-09-06 Thread Anthony Liguori
Kevin Wolf writes: > Am 05.09.2012 21:18, schrieb Anthony Liguori: >> This includes a de_DE translation from Kevin Wolf and an it translation from >> Paolo Bonzini. > > Nope, the de_DE one is still your fake translation. Sorry, I'll fix that in v4. Regards, Anthony Liguori > > Kevin

[Qemu-devel] [PATCH] add a boot parameter to set reboot timeout

2012-09-06 Thread Amos Kong
Added an option to let qemu transfer a configuration file to bios, "etc/boot-fail-wait", which could be specified by command -boot reboot-timeout=T T have a max value of 0x, unit is ms. With this option, guest will wait for a given time if not find bootabled device, then reboot. This featu

Re: [Qemu-devel] [PATCH 6/7] gtk: add translation support

2012-09-06 Thread Kevin Wolf
Am 05.09.2012 21:18, schrieb Anthony Liguori: > This includes a de_DE translation from Kevin Wolf and an it translation from > Paolo Bonzini. Nope, the de_DE one is still your fake translation. Kevin

  1   2   3   >