Re: [Qemu-devel] [PATCH 0/5 v3] convert system_powerdown command to notifiers

2012-09-05 Thread Paolo Bonzini
Il 05/09/2012 23:06, Igor Mammedov ha scritto: > global variable qemu_system_powerdown in sysemu.h is the only dep for qemu_irq > and qemu_rise_irq is not a generic way to signal guest that it should > shutdown. > > replace it by notifiers and allow each implementation to have it's own way > to n

Re: [Qemu-devel] RFC: Add a new boot parameter to set delay time before seabios retry to boot

2012-09-05 Thread Gleb Natapov
On Thu, Sep 06, 2012 at 12:15:13PM +0800, Amos Kong wrote: > Hi all, > > Seabios supports automatically reboot after X second delay on failed > boot [1], > I want to add a parameter for qemu, it's used put a boot parameter > into romfile > for seabios to set the delay time. > > # qemu ... -boot o

[Qemu-devel] [PATCH v2 3/4] spice: add screen mirror

2012-09-05 Thread Gerd Hoffmann
Create a screen mirror, keep there a copy of the most recent update passed on to spice-server. Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 32 ++-- ui/spice-display.h |1 + 2 files changed, 23 insertions(+), 10 deletions(-) diff --git a/ui/spice-displ

[Qemu-devel] [PATCH v2 4/4] spice: send updates only for changed screen content

2012-09-05 Thread Gerd Hoffmann
when creating screen updates go compare the current guest screen against the mirror (which holds the most recent update sent), then only create updates for the screen areas which did actually change. [ v2: drop redundant qemu_spice_create_one_update call ] Signed-off-by: Gerd Hoffmann --- ui/sp

[Qemu-devel] [PATCH v2 1/4] spice: switch to queue for vga mode updates

2012-09-05 Thread Gerd Hoffmann
--- hw/qxl.c |6 +++--- ui/spice-display.c | 25 ++--- ui/spice-display.h |3 ++- 3 files changed, 19 insertions(+), 15 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index b726c19..833cd77 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -597,9 +597,9 @@ static int

[Qemu-devel] [PATCH v2 2/4] spice: split qemu_spice_create_update

2012-09-05 Thread Gerd Hoffmann
Creating one function which creates a single update for a given rectangle. And one (for now) pretty simple wrapper around it to queue up screen updates for the dirty region. [ v2: also update bounding box ] Signed-off-by: Gerd Hoffmann --- ui/spice-display.c | 31 ++--

[Qemu-devel] [PATCH v2 0/4] spice: improve vga mode performance

2012-09-05 Thread Gerd Hoffmann
Hi, This patch series makes spice be more clever on screen updates when in vga mode (i.e. without qxl guest driver loaded or when using a non-qxl vga card). qemu keeps a copy of the screen with the content forwarded to spice-server, then on updates it goes compare the guest screen with the copy

Re: [Qemu-devel] [PATCH] target-xtensa: fix missing errno codes for mingw32

2012-09-05 Thread Stefan Weil
Am 06.09.2012 02:36, schrieb Max Filippov: Put the following errno value mappings under #ifdef: xtensa-semi.c: In function 'errno_h2g': xtensa-semi.c:113: error: 'ENOTBLK' undeclared (first use in this function) xtensa-semi.c:113: error: (Each undeclared identifier is reported only once xtensa-s

[Qemu-devel] RFC: Add a new boot parameter to set delay time before seabios retry to boot

2012-09-05 Thread Amos Kong
Hi all, Seabios supports automatically reboot after X second delay on failed boot [1], I want to add a parameter for qemu, it's used put a boot parameter into romfile for seabios to set the delay time. # qemu ... -boot order=n,menu=on,delay=5 ... Comments & suggestions ? Thanks! [1] commi

Re: [Qemu-devel] Virtual Machine Extension Instructions In QEMU

2012-09-05 Thread Alexander Graf
On 05.09.2012, at 22:51, 陳韋任 (Wei-Ren Chen) wrote: > On Wed, Sep 05, 2012 at 10:00:01AM -0700, Xin Tong wrote: >> I would like to know how well is the Intel VMX and AMD SVM supported in QEMU >> ? > > IIRC, AMD SVM has been supported in QEMU (but not complete). You can > check target-i386/trans

Re: [Qemu-devel] [PATCH] block: Don't forget to delete temporary file

2012-09-05 Thread Dunrong Huang
2012/9/6 Eric Blake : > On 09/05/2012 10:23 AM, Paolo Bonzini wrote: >> And finally, the whole get_tmp_filename is unsafe because there is a >> race window between closing and reopening the file, if the directory is >> writable and does not have the sticky bit. >> >> So the patch is an improvement,

Re: [Qemu-devel] Virtual Machine Extension Instructions In QEMU

2012-09-05 Thread Wei-Ren Chen
On Wed, Sep 05, 2012 at 10:00:01AM -0700, Xin Tong wrote: > I would like to know how well is the Intel VMX and AMD SVM supported in QEMU ? IIRC, AMD SVM has been supported in QEMU (but not complete). You can check target-i386/translate.c, and this is mentioned in changelog [1]. Alex, can you co

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-05 Thread Alexander Graf
On 05.09.2012, at 15:38, Blue Swirl wrote: > On Wed, Sep 5, 2012 at 7:22 PM, Anthony Liguori wrote: >> Blue Swirl writes: >> >>> On Wed, Sep 5, 2012 at 3:41 PM, Anthony Liguori >>> wrote: Avi Kivity writes: > On 09/05/2012 12:00 AM, Anthony Liguori wrote: >>> >>> Why

Re: [Qemu-devel] [PATCH 02/21] target-s390x: split FPU ops

2012-09-05 Thread Alexander Graf
On 05.09.2012, at 11:34, Richard Henderson wrote: > On 09/04/2012 08:46 PM, Alexander Graf wrote: >> So that means your rewrite is based on this series and just fixes it up? >> Does that mean if I apply this patch, you will be all happy? > > It is not (yet) based on this series. But I will be

[Qemu-devel] [PATCH RFC] remove QEMUOptionParameter

2012-09-05 Thread Dong Xu Wang
QEMU now has QEMUOptionParameter and QemuOpts to parse parameters, so we can remove one safely. This RFC removed QEMUOptionParameter and use QemuOpts. But the patch is not completed, I think it is better to send a RFC first. In the RFC, I only allow qcow2 and raw file format and did not test it com

Re: [Qemu-devel] [PATCH v2] virtio-spec: Add virtio-ccw spec.

2012-09-05 Thread Benjamin Herrenschmidt
On Thu, 2012-09-06 at 11:56 +0930, Rusty Russell wrote: > Excellent. I have applied and pushed this revision. > > I was tempted to ask for an explicit endian marker, as switching to > explicit little endian was high on the TODO list for virtio2. On the > other hand, we could say virtio2-pci conf

Re: [Qemu-devel] [PATCH v2] virtio-spec: Add virtio-ccw spec.

2012-09-05 Thread Rusty Russell
Cornelia Huck writes: > Add specifications for the new s390 specific virtio-ccw transport. > > Signed-off-by: Cornelia Huck Excellent. I have applied and pushed this revision. I was tempted to ask for an explicit endian marker, as switching to explicit little endian was high on the TODO list

Re: [Qemu-devel] [PATCH 15/21] target-unicore32: switch to AREG0 free mode

2012-09-05 Thread guanxuetao
> Add an explicit CPUState parameter instead of relying on AREG0 > and switch to AREG0 free mode. > > Signed-off-by: Blue Swirl Thanks, Tested-by: Guan Xuetao > --- > configure |2 +- > target-unicore32/Makefile.objs |2 - > target-unicore32/helper.h | 26 +

[Qemu-devel] [PATCH] target-xtensa: fix missing errno codes for mingw32

2012-09-05 Thread Max Filippov
Put the following errno value mappings under #ifdef: xtensa-semi.c: In function 'errno_h2g': xtensa-semi.c:113: error: 'ENOTBLK' undeclared (first use in this function) xtensa-semi.c:113: error: (Each undeclared identifier is reported only once xtensa-semi.c:113: error: for each function it appear

Re: [Qemu-devel] buildbot failure in qemu on default_mingw32

2012-09-05 Thread Max Filippov
On Thu, Sep 6, 2012 at 4:06 AM, wrote: > The Buildbot has detected a new failure on builder default_mingw32 while > building qemu. > Full details are available at: > http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/367 > > Buildbot URL: http://buildbot.b1-systems.de/qemu/ > >

[Qemu-devel] buildbot failure in qemu on default_mingw32

2012-09-05 Thread qemu
The Buildbot has detected a new failure on builder default_mingw32 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_mingw32/builds/367 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 Build Reason:

[Qemu-devel] [ANNOUNCE] QEMU 1.1.2 Stable released

2012-09-05 Thread Michael Roth
Hi everyone, I am pleased to announce that the QEMU v1.1.2 stable release is now available at: http://wiki.qemu.org/download/qemu-1.1.2.tar.bz2 The official stable-1.1 repository has also been updated to v1.1.2: http://git.qemu.org/?p=qemu-stable-1.1.git;a=summary This is the last planned rele

Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2)

2012-09-05 Thread Anthony Liguori
Blue Swirl writes: > On Wed, Sep 5, 2012 at 8:38 PM, Anthony Liguori wrote: >> Blue Swirl writes: >> >>> On Wed, Sep 5, 2012 at 7:18 PM, Anthony Liguori wrote: This is minimalistic and just contains the basic widget infrastructure. The GUI consists of a menu and a GtkNotebook.

Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2)

2012-09-05 Thread Anthony Liguori
Jan Kiszka writes: > On 2012-09-05 22:04, Stefan Weil wrote: >> Am 05.09.2012 21:18, schrieb Anthony Liguori: >>> This is minimalistic and just contains the basic widget >>> infrastructure. The GUI >>> consists of a menu and a GtkNotebook. To start with, the notebook has >>> its tabs >>> hidden

Re: [Qemu-devel] [PATCH 06/15] ARM: Make target_phys_addr_t 64 bits and physaddrs 40 bits

2012-09-05 Thread Jan Kiszka
On 2012-07-12 15:36, Peter Maydell wrote: > Make target_phys_addr_t 64 bits for ARM targets, and set > TARGET_PHYS_ADDR_SPACE_BITS to 40. This should have no effect for ARM > boards where physical addresses really are 32 bits (except perhaps a > slight performance hit on 32 bit hosts for system em

[Qemu-devel] [PATCH 6/7] x86_cpudef_setup: coding style change

2012-09-05 Thread Eduardo Habkost
Make source code lines shorter. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 73302d8..e13e6d5 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -1513,20

[Qemu-devel] [PATCH 4/7] move CPU models from cpus-x86_64.conf to C

2012-09-05 Thread Eduardo Habkost
Those models are maintained by QEMU and may require compatibility code to be added when making some changes. Keeping the data in the C source code should make it simpler to handle those details. Signed-off-by: Eduardo Habkost --- sysconfigs/target/cpus-x86_64.conf | 129 +- t

[Qemu-devel] [PATCH 7/7] i386: kill cpudef config section support

2012-09-05 Thread Eduardo Habkost
It's nice to have a flexible system to maintain CPU models as data, but this is holding us from making improvements in the CPU code because it's not using the common infra-structure, and because the machine-type data is still inside C code. Users who want to configure CPU features directly may sim

[Qemu-devel] [PATCH 2/5] acpi: use notifier for signaling guest system_powerdown command

2012-09-05 Thread Igor Mammedov
In addition, there is no need to allocate an extra irq just for rising SCI in irq handler. Just rise SCI right from notifier handler instead. Signed-off-by: Igor Mammedov --- hw/acpi_piix4.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/acpi_piix4.c b/hw/acpi_pii

[Qemu-devel] [PATCH 0/7] x86 CPU patches that didn't get into 1.2

2012-09-05 Thread Eduardo Habkost
Hi, This is a small queue of patches that I consider "ready to go", that didn't enter QEMU 1.2. Eduardo Habkost (5): i386: add missing CPUID_* constants move CPU models from cpus-x86_64.conf to C eliminate cpus-x86_64.conf file x86_cpudef_setup: coding style change i386: kill cpudef con

[Qemu-devel] [PATCH 4/5] target-sparc: use notifier for signaling guest system_powerdown command

2012-09-05 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/sun4m.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/hw/sun4m.c b/hw/sun4m.c index 0f909b5..c98cd5e 100644 --- a/hw/sun4m.c +++ b/hw/sun4m.c @@ -472,6 +472,17 @@ static void slavio_timer_init_all(target_phys_addr_t addr, q

[Qemu-devel] [PATCH 1/5] Introduce powerdown_notifiers

2012-09-05 Thread Igor Mammedov
Notifier will be used for signaling powerdown request to guest in a more general way and intended to replace very specific qemu_irq_rise(qemu_system_powerdown) and will allow to remove global variable qemu_system_powerdown. Signed-off-by: Igor Mammedov --- sysemu.h | 1 + vl.c | 8

[Qemu-devel] [PATCH 3/5] target-arm: use notifier for signaling guest system_powerdown command

2012-09-05 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/nseries.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/hw/nseries.c b/hw/nseries.c index 4df2670..6df71eb 100644 --- a/hw/nseries.c +++ b/hw/nseries.c @@ -189,6 +189,17 @@ static void n8x0_nand_setup(struct n800_s *s)

Re: [Qemu-devel] [PATCH 4/7] gtk: add support for input grabbing (v2)

2012-09-05 Thread Anthony Liguori
Jan Kiszka writes: > On 2012-09-05 21:18, Anthony Liguori wrote: >> There is a small deviation from SDL's behavior here. Instead of Ctrl+Alt >> triggering grab, we now use Ctrl-Alt-g to trigger grab. >> >> GTK will not accept Ctrl+Alt as an accelerator since it just consists of >> modifiers. H

[Qemu-devel] [PATCH 1/7] target-i386: Fold -cpu ?cpuid, ?model output into -cpu help, drop ?dump

2012-09-05 Thread Eduardo Habkost
From: Peter Maydell Commit c8057f95 (accidentally) disabled the ability to pass option strings starting with '?' to the target-specific cpu_list function, so the target-i386 specific "-cpu ?dump", "-cpu ?cpuid" and "-cpu ?model" stopped working. Since these options are undocumented and not used

[Qemu-devel] [PATCH 3/7] i386: add missing CPUID_* constants

2012-09-05 Thread Eduardo Habkost
Those constants will be used by new CPU model definitions. Signed-off-by: Eduardo Habkost --- target-i386/cpu.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/target-i386/cpu.h b/target-i386/cpu.h index 49e0259..d7ea2f9 100644 --- a/target-i386/cpu.h +++ b/target-i38

[Qemu-devel] [PATCH 5/5] Cleanup unused global var qemu_system_powerdown

2012-09-05 Thread Igor Mammedov
All deps that used global qemu_system_powerdown var are now converted to notifiers, so remove it. Signed-off-by: Igor Mammedov --- v2: - removed hunk with #include "hw/irq.h", for patch not to depend on cpu_as_device series. - reuse name of removed qemu_system_powerdown var as a function

[Qemu-devel] [PATCH 0/5 v3] convert system_powerdown command to notifiers

2012-09-05 Thread Igor Mammedov
global variable qemu_system_powerdown in sysemu.h is the only dep for qemu_irq and qemu_rise_irq is not a generic way to signal guest that it should shutdown. replace it by notifiers and allow each implementation to have it's own way to notify guest. git repo for testing: https://github.com/i

Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2)

2012-09-05 Thread Blue Swirl
On Wed, Sep 5, 2012 at 8:38 PM, Anthony Liguori wrote: > Blue Swirl writes: > >> On Wed, Sep 5, 2012 at 7:18 PM, Anthony Liguori wrote: >>> This is minimalistic and just contains the basic widget infrastructure. >>> The GUI >>> consists of a menu and a GtkNotebook. To start with, the notebook

Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2)

2012-09-05 Thread Jan Kiszka
On 2012-09-05 21:18, Anthony Liguori wrote: > This is minimalistic and just contains the basic widget infrastructure. The > GUI > consists of a menu and a GtkNotebook. To start with, the notebook has its > tabs > hidden which provides a UI that looks very similar to SDL with the exception > of

Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2)

2012-09-05 Thread Anthony Liguori
Stefan Weil writes: > Am 05.09.2012 21:18, schrieb Anthony Liguori: >> This is minimalistic and just contains the basic widget infrastructure. The >> GUI >> consists of a menu and a GtkNotebook. To start with, the notebook has its >> tabs >> hidden which provides a UI that looks very similar

[Qemu-devel] [PATCH 5/7] eliminate cpus-x86_64.conf file

2012-09-05 Thread Eduardo Habkost
This file is not needed anymore, as QEMU won't ship any config-based cpudefs out of the box, relying only on the builtin CPU models. Signed-off-by: Eduardo Habkost --- Makefile | 1 - arch_init.c| 1 - sysconfigs/target/cpus-x86_64.conf | 1 - 3

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-05 Thread Anthony Liguori
Blue Swirl writes: > On Wed, Sep 5, 2012 at 7:22 PM, Anthony Liguori wrote: >> Blue Swirl writes: >> >>> On Wed, Sep 5, 2012 at 3:41 PM, Anthony Liguori >>> wrote: Avi Kivity writes: > On 09/05/2012 12:00 AM, Anthony Liguori wrote: >>> >>> Why? The way this is being sub

Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2)

2012-09-05 Thread Jan Kiszka
On 2012-09-05 22:04, Stefan Weil wrote: > Am 05.09.2012 21:18, schrieb Anthony Liguori: >> This is minimalistic and just contains the basic widget >> infrastructure. The GUI >> consists of a menu and a GtkNotebook. To start with, the notebook has >> its tabs >> hidden which provides a UI that loo

Re: [Qemu-devel] [PATCH 4/7] gtk: add support for input grabbing (v2)

2012-09-05 Thread Jan Kiszka
On 2012-09-05 22:40, Anthony Liguori wrote: > Jan Kiszka writes: > >> On 2012-09-05 21:18, Anthony Liguori wrote: >>> There is a small deviation from SDL's behavior here. Instead of Ctrl+Alt >>> triggering grab, we now use Ctrl-Alt-g to trigger grab. >>> >>> GTK will not accept Ctrl+Alt as an ac

[Qemu-devel] [PATCH 2/7] Drop cpu_list_id macro

2012-09-05 Thread Eduardo Habkost
From: Peter Maydell Since the only user of the extended cpu_list_id() format was the x86 ?model/?dump/?cpuid output, we can drop it completely. Signed-off-by: Peter Maydell Signed-off-by: Eduardo Habkost Reviewed-by: Eduardo Habkost --- cpus.c| 6 ++ linux-user/main.c | 6 ++-

Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2)

2012-09-05 Thread Anthony Liguori
Blue Swirl writes: > On Wed, Sep 5, 2012 at 7:18 PM, Anthony Liguori wrote: >> This is minimalistic and just contains the basic widget infrastructure. The >> GUI >> consists of a menu and a GtkNotebook. To start with, the notebook has its >> tabs >> hidden which provides a UI that looks very

Re: [Qemu-devel] [PATCH v2] hw: Add VMware's GETHZ command.

2012-09-05 Thread Don Slutz
On 08/31/12 13:27, Jan Kiszka wrote: On 2012-08-31 19:20, Don Slutz wrote: This is known is linux as VMWARE_PORT_CMD_GETHZ. Signed-off-by: Don Slutz --- hw/vmport.c | 23 ++- 1 files changed, 22 insertions(+), 1 deletions(-) diff --git a/hw/vmport.c b/hw/vmport.c inde

[Qemu-devel] [PATCH 13/19] qapi: convert screendump

2012-09-05 Thread Luiz Capitulino
Next commits will update devices to propagate errors. Signed-off-by: Luiz Capitulino --- console.c| 7 --- console.h| 1 - hmp-commands.hx | 3 +-- hmp.c| 9 + hmp.h| 1 + monitor.c| 6 -- qapi-schema.json | 13 +

[Qemu-devel] [PATCH 19/19] tcx: tcx_screen_dump(): add error handling

2012-09-05 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- hw/tcx.c | 35 +-- 1 file changed, 29 insertions(+), 6 deletions(-) diff --git a/hw/tcx.c b/hw/tcx.c index 428649e..93994d6 100644 --- a/hw/tcx.c +++ b/hw/tcx.c @@ -582,26 +582,49 @@ static void tcx_screen_dump(void *opaque, cons

[Qemu-devel] [PATCH 4/7] gtk: add support for input grabbing (v2)

2012-09-05 Thread Anthony Liguori
There is a small deviation from SDL's behavior here. Instead of Ctrl+Alt triggering grab, we now use Ctrl-Alt-g to trigger grab. GTK will not accept Ctrl+Alt as an accelerator since it just consists of modifiers. Having grab as a proper accelerator is important as it allows a user to override th

[Qemu-devel] [PATCH 09/19] qapi: Fix potential NULL pointer segfault

2012-09-05 Thread Luiz Capitulino
From: Stefan Weil Report from smatch: qapi-visit.c:1640 visit_type_BlockdevAction(8) error: we previously assumed 'obj' could be null (see line 1639) qapi-visit.c:2432 visit_type_NetClientOptions(8) error: we previously assumed 'obj' could be null (see line 2431) Signed-off-by: Stefan Weil R

[Qemu-devel] [PATCH 18/19] tcx: tcx24_screen_dump(): add error handling

2012-09-05 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- hw/tcx.c | 50 +- 1 file changed, 41 insertions(+), 9 deletions(-) diff --git a/hw/tcx.c b/hw/tcx.c index 74a7085..428649e 100644 --- a/hw/tcx.c +++ b/hw/tcx.c @@ -611,12 +611,18 @@ static void tcx24_screen_dump(v

[Qemu-devel] [PATCH 07/19] monitor: move key_defs[] table and introduce two help functions

2012-09-05 Thread Luiz Capitulino
From: Amos Kong This patch added two help functions to convert key/code to index of mapping table, those functions will return Q_KEY_CODE_MAX if the code/key is invalid. Patch also moved key_defs[] to input.c, and removed useless KeyDef struct. Key's index in QKeyCode enmu is same as keycode's i

[Qemu-devel] [PATCH 02/19] fix doc of using raw values with sendkey

2012-09-05 Thread Luiz Capitulino
From: Amos Kong (qemu) sendkey a (qemu) sendkey 0x1e (qemu) sendkey #0x1e unknown key: '#0x1e' The last command doesn't work, '#' is not requested before raw values, and the raw value in decimal format is not supported. Signed-off-by: Amos Kong Signed-off-by: Luiz Capitulino --- hmp-command

[Qemu-devel] [PATCH 06/19] qapi: add the QKeyCode enum

2012-09-05 Thread Luiz Capitulino
From: Amos Kong key_defs[] in monitor.c is a mapping table of keys and keycodes, this patch added a QKeyCode enum. Key's index in the enmu is same as keycode's index in key_defs[]. Signed-off-by: Amos Kong Signed-off-by: Luiz Capitulino --- qapi-schema.json | 26 ++ 1

Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2)

2012-09-05 Thread Stefan Weil
Am 05.09.2012 21:18, schrieb Anthony Liguori: This is minimalistic and just contains the basic widget infrastructure. The GUI consists of a menu and a GtkNotebook. To start with, the notebook has its tabs hidden which provides a UI that looks very similar to SDL with the exception of the menu b

[Qemu-devel] [PATCH 03/19] monitor: rename keyname '<' to 'less'

2012-09-05 Thread Luiz Capitulino
From: Amos Kong There are many maps of keycode 0x56 in pc-bios/keymaps/* pc-bios/keymaps/common:less 0x56 pc-bios/keymaps/common:greater 0x56 shift pc-bios/keymaps/common:bar 0x56 altgr pc-bios/keymaps/common:brokenbar 0x56 shift altgr This patch just renamed '<' to 'less', QAPI might ad

Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2)

2012-09-05 Thread Eric Blake
On 09/05/2012 01:53 PM, Blue Swirl wrote: > On Wed, Sep 5, 2012 at 7:18 PM, Anthony Liguori wrote: >> This is minimalistic and just contains the basic widget infrastructure. The >> GUI >> consists of a menu and a GtkNotebook. To start with, the notebook has its >> tabs >> hidden which provides

[Qemu-devel] [PATCH 16/19] omap_lcdc: omap_ppm_save(): add error handling

2012-09-05 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- hw/omap_lcdc.c | 59 -- 1 file changed, 45 insertions(+), 14 deletions(-) diff --git a/hw/omap_lcdc.c b/hw/omap_lcdc.c index 3d6328f..e2ba108 100644 --- a/hw/omap_lcdc.c +++ b/hw/omap_lcdc.c @@ -224,18 +22

[Qemu-devel] [PATCH 05/19] qapi: generate list struct and visit_list for enum

2012-09-05 Thread Luiz Capitulino
From: Amos Kong Currently, if we define an 'enum' and use it in one command's data, list struct for enum could not be generated, but it's used in qmp function. For example: KeyCodesList could not be generated. >>> qapi-schema.json: { 'enum': 'KeyCodes', 'data': [ 'shift', 'alt' ... ] } { 'comm

[Qemu-devel] [PATCH 17/19] g364fb: g364fb_screen_dump(): add error handling

2012-09-05 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- hw/g364fb.c | 52 1 file changed, 40 insertions(+), 12 deletions(-) diff --git a/hw/g364fb.c b/hw/g364fb.c index 498154b..059e622 100644 --- a/hw/g364fb.c +++ b/hw/g364fb.c @@ -293,7 +293,7 @@ static void g36

[Qemu-devel] [PATCH 01/19] Add support for pretty-printing response in qmp-shell

2012-09-05 Thread Luiz Capitulino
From: "Daniel P. Berrange" Add a '-p' arg to the QMP/qmp-shell test program, which uses the python pprint module to pretty-print the dictionary returned from a command $ qmp-shell -p /tmp/qemu Welcome to the QMP low-level shell! Connected to QEMU 1.1.50 (QEMU) query-cpus { u'return'

[Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2)

2012-09-05 Thread Anthony Liguori
This is minimalistic and just contains the basic widget infrastructure. The GUI consists of a menu and a GtkNotebook. To start with, the notebook has its tabs hidden which provides a UI that looks very similar to SDL with the exception of the menu bar. The menu bar allows a user to toggle the vi

Re: [Qemu-devel] [PATCH 2/7] ui: add basic GTK gui (v2)

2012-09-05 Thread Blue Swirl
On Wed, Sep 5, 2012 at 7:18 PM, Anthony Liguori wrote: > This is minimalistic and just contains the basic widget infrastructure. The > GUI > consists of a menu and a GtkNotebook. To start with, the notebook has its > tabs > hidden which provides a UI that looks very similar to SDL with the exc

[Qemu-devel] [PATCH] smbios: convert to use QemuOpts

2012-09-05 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- arch_init.c | 10 +- arch_init.h |2 +- hw/smbios.c | 53 +++-- hw/smbios.h |2 +- qemu-config.c | 50 ++ vl.c |4 +++- 6 f

[Qemu-devel] [PATCH 08/19] qapi: convert sendkey

2012-09-05 Thread Luiz Capitulino
From: Amos Kong Convert 'sendkey' to use QAPI. QAPI passes key's index of mapping table to qmp_send_key(), not keycode. So we use help functions to convert key/code to index of key_defs, and 'index' will be converted to 'keycode' inside qmp_send_key(). For qmp, QAPI would check invalid key and

[Qemu-devel] [PATCH v5] add -machine mem-merge=on|off option

2012-09-05 Thread Luiz Capitulino
It allows to disable memory merge support (KSM on Linux), which is enabled by default otherwise. Signed-off-by: Luiz Capitulino --- v5 - rebase on top of current master exec.c | 19 --- qemu-config.c | 4 qemu-options.hx | 7 ++- 3 files changed, 26 inser

Re: [Qemu-devel] [PATCH] target-xtensa: convert host errno values to guest

2012-09-05 Thread Blue Swirl
Thanks, applied. On Wed, Aug 29, 2012 at 7:54 PM, Max Filippov wrote: > Guest errno values are taken from the newlib. Convert only those errno > values that can be returned from used system calls. > > Signed-off-by: Max Filippov > --- > target-xtensa/xtensa-semi.c | 106 +++

Re: [Qemu-devel] [PATCH v2 0/4] CHECKPATCH: Add warning for single else statement.

2012-09-05 Thread Blue Swirl
Thanks, applied all. On Sun, Sep 2, 2012 at 11:22 PM, Don Slutz wrote: > Also add more debug options to find this issue. They were not listed > in the help because the are not simple to understand the output of. > > Using: > > rm zz; > for k in 0 1 2 3; do >for i in 0 1 2 3 4 5 6 7 8 9;

[Qemu-devel] [PATCH 15/19] omap_lcdc: rename ppm_save() to omap_ppm_save()

2012-09-05 Thread Luiz Capitulino
Avoids confusion with the global ppm_save() defined in hw/vga.c. Signed-off-by: Luiz Capitulino Reviewed-by: Peter Maydell --- hw/omap_lcdc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/omap_lcdc.c b/hw/omap_lcdc.c index 39b78cd..3d6328f 100644 --- a/hw/oma

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-05 Thread Blue Swirl
On Wed, Sep 5, 2012 at 7:24 PM, Eric Blake wrote: > On 09/05/2012 01:04 PM, Blue Swirl wrote: >>> I don't mind GPLv2+, if people want to share code from QEMU in GPLv3 >>> projects, GPLv2+ enables that. >> >> The advantage of 100% GPLv2+ (or other GPLv3 compatible) would be that >> QEMU could share

[Qemu-devel] [PATCH 7/7] gtk: make default UI (v3)

2012-09-05 Thread Anthony Liguori
A user can still enable SDL with '-sdl' or '-display sdl' but start making the default display GTK by default. I'd also like to deprecate the SDL display and remove it in a few releases. Signed-off-by: Anthony Liguori --- v1 -> v3: - fix -display gtk - fix -vnc none --- vl.c | 45 ++

[Qemu-devel] [PATCH 1/7] console: allow VCs to be overridden by UI

2012-09-05 Thread Anthony Liguori
We want to expose VCs using a VteTerminal widget. We need access to provide our own CharDriverState in order to do this. Signed-off-by: Anthony Liguori --- console.c | 14 +- console.h |6 +- qemu-char.c |2 +- 3 files changed, 19 insertions(+), 3 deletions(-) dif

[Qemu-devel] [PATCH 04/19] hmp: rename arguments

2012-09-05 Thread Luiz Capitulino
From: Amos Kong Rename 'string' to 'keys', rename 'hold_time' to 'hold-time'. Signed-off-by: Amos Kong Signed-off-by: Luiz Capitulino --- hmp-commands.hx | 2 +- monitor.c | 14 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-05 Thread Blue Swirl
On Wed, Sep 5, 2012 at 7:22 PM, Anthony Liguori wrote: > Blue Swirl writes: > >> On Wed, Sep 5, 2012 at 3:41 PM, Anthony Liguori >> wrote: >>> Avi Kivity writes: >>> On 09/05/2012 12:00 AM, Anthony Liguori wrote: >> >> Why? The way this is being submitted I don't see why we should

Re: [Qemu-devel] [PATCH 4/7] gtk: add support for input grabbing (v2)

2012-09-05 Thread Jan Kiszka
On 2012-09-05 21:18, Anthony Liguori wrote: > There is a small deviation from SDL's behavior here. Instead of Ctrl+Alt > triggering grab, we now use Ctrl-Alt-g to trigger grab. > > GTK will not accept Ctrl+Alt as an accelerator since it just consists of > modifiers. Having grab as a proper accel

[Qemu-devel] [PATCH 12/19] console: vga_hw_screen_dump_ptr: take Error argument

2012-09-05 Thread Luiz Capitulino
All devices that register a screen dump callback via graphic_console_init() are updated. The new argument is not used in this commit. Error handling will be added to each device individually later. This change is a preparation to convert the screendump command to the QAPI. Signed-off-by: Luiz Ca

[Qemu-devel] [PATCH 10/19] json-parser: Fix potential NULL pointer segfault

2012-09-05 Thread Luiz Capitulino
From: Stefan Weil Report from smatch: json-parser.c:474 parse_object(62) error: potential null derefence 'dict'. json-parser.c:553 parse_array(75) error: potential null derefence 'list'. Label 'out' in json-parser.c can be called with list == NULL which is passed to QDECREF. Modify QDECREF to h

[Qemu-devel] [PATCH 6/7] gtk: add translation support

2012-09-05 Thread Anthony Liguori
This includes a de_DE translation from Kevin Wolf and an it translation from Paolo Bonzini. Signed-off-by: Anthony Liguori --- Makefile |3 +++ configure |4 +++- po/Makefile| 43 +++ po/de_DE.po| 37 +

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-05 Thread Eric Blake
On 09/05/2012 01:04 PM, Blue Swirl wrote: >> I don't mind GPLv2+, if people want to share code from QEMU in GPLv3 >> projects, GPLv2+ enables that. > > The advantage of 100% GPLv2+ (or other GPLv3 compatible) would be that > QEMU could share code from GPLv3 projects, specifically latest > binutils

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-05 Thread Anthony Liguori
Blue Swirl writes: > On Wed, Sep 5, 2012 at 3:41 PM, Anthony Liguori wrote: >> Avi Kivity writes: >> >>> On 09/05/2012 12:00 AM, Anthony Liguori wrote: > > Why? The way this is being submitted I don't see why we should treat > Jan's patch any different from a patch by IBM or Samsung

[Qemu-devel] [PATCH 3/7] gtk: add virtual console support (v2)

2012-09-05 Thread Anthony Liguori
This enables VteTerminal to be used to render the text consoles. VteTerminal is the same widget used by gnome-terminal which means it's VT100 emulation is as good as they come. It's also screen reader accessible, supports copy/paste, proper scrolling and most of the other features you would expec

[Qemu-devel] [PATCH 5/7] gtk: add support for screen scaling and full screen (v3)

2012-09-05 Thread Anthony Liguori
Basic menu items to enter full screen mode and zoom in/out. Unlike SDL, we don't allow arbitrary scaling based on window resizing. The current behavior with SDL causes a lot of problems for me. Sometimes I accidentally resize the window a tiny bit while trying to move it (Ubuntu's 1-pixel window

[Qemu-devel] [PATCH 0/7] Add GTK UI to enable basic accessibility (v3)

2012-09-05 Thread Anthony Liguori
I realize UIs are the third rail of QEMU development, but over the years I've gotten a lot of feedback from users about our UI. I think everyone struggles with the SDL interface and its lack of discoverability but it's worse than I think most people realize for users that rely on accessibility too

[Qemu-devel] [PATCH 11/19] error: add error_setg()

2012-09-05 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- error.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/error.h b/error.h index 96fc203..da7fed3 100644 --- a/error.h +++ b/error.h @@ -30,6 +30,12 @@ typedef struct Error Error; void error_set(Error **err, ErrorClass err_class, const char *fmt, ...)

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-05 Thread Blue Swirl
On Tue, Sep 4, 2012 at 9:28 PM, Michael S. Tsirkin wrote: > On Tue, Sep 04, 2012 at 07:27:32PM +, Blue Swirl wrote: >> On Tue, Sep 4, 2012 at 8:32 AM, Avi Kivity wrote: >> > On 09/03/2012 10:32 PM, Blue Swirl wrote: >> >> On Mon, Sep 3, 2012 at 4:14 PM, Avi Kivity wrote: >> >>> On 08/29/2012

[Qemu-devel] [PATCH 14/19] vga: ppm_save(): add error handling

2012-09-05 Thread Luiz Capitulino
Signed-off-by: Luiz Capitulino --- hw/blizzard.c | 2 +- hw/qxl.c| 2 +- hw/vga.c| 32 +--- hw/vga_int.h| 3 ++- hw/vmware_vga.c | 2 +- 5 files changed, 30 insertions(+), 11 deletions(-) diff --git a/hw/blizzard.c b/hw/blizzard.c index a2b90

Re: [Qemu-devel] [PATCH] Versatile Express: add modelling of NOR flash

2012-09-05 Thread Francesco Lavra
Hi, On 09/05/2012 10:47 AM, Peter Maydell wrote: > On 5 September 2012 06:16, Stefan Weil wrote: >> Am 04.09.2012 19:08, schrieb Francesco Lavra: >>> /* VE_NORFLASH0ALIAS: not modelled */ >> >> >> What about that alias? It's not difficult to add it, too. >> Just look for memory_region_init_

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-09-05 Thread Blue Swirl
On Wed, Sep 5, 2012 at 3:41 PM, Anthony Liguori wrote: > Avi Kivity writes: > >> On 09/05/2012 12:00 AM, Anthony Liguori wrote: Why? The way this is being submitted I don't see why we should treat Jan's patch any different from a patch by IBM or Samsung where we've asked folks

[Qemu-devel] [PATCH] socket: don't attempt to reconnect a TCP socket in server mode

2012-09-05 Thread Anthony Liguori
Commit c3767ed0eb5d0bb25fe409ae5dec06e3411ff1b6 introduced a possible SEGV when using a socket chardev with server=on because it assumes that all TCP sockets are in client mode. This patch adds a check to only reconnect when in client mode. Cc: Lei Li Reported-by: Michael Roth Signed-off-by: An

Re: [Qemu-devel] [PATCH] target-i386: Allow changing of Hypervisor CPUIDs.

2012-09-05 Thread Marcelo Tosatti
On Thu, Aug 30, 2012 at 03:20:35PM -0400, Don Slutz wrote: > This is primarily done so that the guest will think it is running > under vmware when hypervisor=vmware is specified as a property of a > cpu. > > Also allow this to work in accel=tcg mode. > > The new cpu properties hyper_level, hyper_

[Qemu-devel] [PULL 00/19]: QMP queue

2012-09-05 Thread Luiz Capitulino
Let's get the ball rolling for QMP in 1.3 :) This pull request contains the send-key command conversion, screendump qapi conversion and a few fixes. The changes (since f45ddd14209a4d1b95a4096d50a561b7f6270118) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git

Re: [Qemu-devel] [PATCH 09/19] sockets: Chardev open error reporting, sockets part

2012-09-05 Thread Luiz Capitulino
On Wed, 5 Sep 2012 10:19:22 +0800 Amos Kong wrote: > On Thu, Aug 30, 2012 at 12:04 AM, Amos Kong wrote: > > > On Wed, Aug 29, 2012 at 11:15 PM, Amos Kong wrote: > > > On Thu, Feb 23, 2012 at 4:15 PM, Markus Armbruster > > wrote: > > >> > > >> Anthony Liguori writes: > > >> > > >> > On 02/15/

Re: [Qemu-devel] Help needed to run Exynos 4210 linux kernel on qemu?

2012-09-05 Thread Jean-Christophe DUBOIS
Hello Igor, Thanks for you reply and your time. JC On 09/05/2012 02:38 PM, Igor Mitsyanko wrote: On 09/04/2012 02:13 AM, Jean-Christophe DUBOIS wrote: Hello, Jean! I've just tried to do the same thing you're trying to do, it works for me if I remove earlyprintk from append. Yes, I found o

Re: [Qemu-devel] [PATCH] sparc-dis: Remove redundant NULL check

2012-09-05 Thread Stefan Weil
Am 05.09.2012 17:51, schrieb Andreas Färber: Am 03.09.2012 22:23, schrieb Stefan Weil: Report from smatch: sparc-dis.c:2664 build_hash_table(14) info: redundant null check on hash_buf calling free() Signed-off-by: Stefan Weil --- Coding style was not fixed. - sw sparc-dis.c |3 +-

Re: [Qemu-devel] [PATCH] sparc-dis: Remove redundant NULL check

2012-09-05 Thread Stefan Weil
Am 05.09.2012 19:15, schrieb Stefan Weil: AFAIK, binutils moved to GPL 3. Therefore I don't expect that QEMU will update to upstream in the next years. We'll have to maintain the code which we have. Try "git log *-dis.c" or "gitk *-dis.c": there are already lots of more trivial changes which g

Re: [Qemu-devel] [PATCH] sparc-dis: Remove redundant NULL check

2012-09-05 Thread Stefan Weil
Am 05.09.2012 18:55, schrieb Stefan Hajnoczi: On Wed, Sep 5, 2012 at 4:51 PM, Andreas Färber wrote: Am 03.09.2012 22:23, schrieb Stefan Weil: Report from smatch: sparc-dis.c:2664 build_hash_table(14) info: redundant null check on hash_buf calling free() Signed-off-by: Stefan Weil --- Codin

[Qemu-devel] Virtual Machine Extension Instructions In QEMU

2012-09-05 Thread Xin Tong
I would like to know how well is the Intel VMX and AMD SVM supported in QEMU ? Xin

Re: [Qemu-devel] [PATCH] sparc-dis: Remove redundant NULL check

2012-09-05 Thread Stefan Hajnoczi
On Wed, Sep 5, 2012 at 4:51 PM, Andreas Färber wrote: > Am 03.09.2012 22:23, schrieb Stefan Weil: >> Report from smatch: >> sparc-dis.c:2664 build_hash_table(14) info: >> redundant null check on hash_buf calling free() >> >> Signed-off-by: Stefan Weil >> --- >> >> Coding style was not fixed. >>

  1   2   >