Re: [Qemu-devel] [PATCH 02/18] block: add error parameter to bdrv_snapshot_create() and related functions

2012-08-30 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 15 Aug 2012 09:41:43 +0200 > Pavel Hrdina wrote: > >> Signed-off-by: Pavel Hrdina >> --- >> block.c| 25 + >> block.h| 3 ++- >> block/qcow2-snapshot.c | 9 - >> block/qcow2.h | 4 +++-

Re: [Qemu-devel] macvlan/macvtap: guest/host cannot communicate when network cable is unplugged

2012-08-30 Thread Stefan Hajnoczi
On Thu, Aug 30, 2012 at 11:32 PM, ching wrote: > >>> I also perform an additional test: the guests (macvtap bridge mode) CAN >>> communicate each other no matter network cable is plugged or not. >> Strange. I thought the original problem was that the macvtap guests >> cannot communicate with eac

Re: [Qemu-devel] [PATCH v2] Fix buffer run out in eepro100.

2012-08-30 Thread Stefan Hajnoczi
On Fri, Aug 31, 2012 at 4:40 AM, Bo Yang wrote: > > Stefan Hajnoczi 08/30/12 7:42 PM >>> > On Thu, Aug 30, 2012 at 9:38 AM, Bo Yang wrote: >> On 08/30/2012 04:04 PM, Stefan Hajnoczi wrote: >>> On Wed, Aug 29, 2012 at 09:17:43PM +0200, Stefan Weil wrote: Am 29.08.2012 13:26, schrieb Bo

[Qemu-devel] [PATCH v8 7/7] qapi: convert sendkey

2012-08-30 Thread Amos Kong
Convert 'sendkey' to use QAPI. QAPI passes key's index of mapping table to qmp_send_key(), not keycode. So we use help functions to convert key/code to index of key_defs, and 'index' will be converted to 'keycode' inside qmp_send_key(). For qmp, QAPI would check invalid key and raise error. For h

[Qemu-devel] [PATCH v8 5/7] qapi: add the QKeyCode enum

2012-08-30 Thread Amos Kong
key_defs[] in monitor.c is a mapping table of keys and keycodes, this patch added a QKeyCode enum. Key's index in the enmu is same as keycode's index in key_defs[]. Signed-off-by: Amos Kong --- qapi-schema.json | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH v8 1/7] fix doc of using raw values with sendkey

2012-08-30 Thread Amos Kong
(qemu) sendkey a (qemu) sendkey 0x1e (qemu) sendkey #0x1e unknown key: '#0x1e' The last command doesn't work, '#' is not requested before raw values, and the raw value in decimal format is not supported. Signed-off-by: Amos Kong --- hmp-commands.hx |6 +++--- 1 files changed, 3 insertions(

[Qemu-devel] [PATCH v8 3/7] hmp: rename arguments

2012-08-30 Thread Amos Kong
Rename 'string' to 'keys', rename 'hold_time' to 'hold-time'. Signed-off-by: Amos Kong --- hmp-commands.hx |2 +- monitor.c | 14 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 6a70a9c..bd0c6c9 100644 --- a/hmp-co

[Qemu-devel] [PATCH v8 2/7] monitor: rename keyname '<' to 'less'

2012-08-30 Thread Amos Kong
There are many maps of keycode 0x56 in pc-bios/keymaps/* pc-bios/keymaps/common:less 0x56 pc-bios/keymaps/common:greater 0x56 shift pc-bios/keymaps/common:bar 0x56 altgr pc-bios/keymaps/common:brokenbar 0x56 shift altgr This patch just renamed '<' to 'less', QAPI might add new variable by

[Qemu-devel] [PATCH v8 4/7] qapi: generate list struct and visit_list for enum

2012-08-30 Thread Amos Kong
Currently, if we define an 'enum' and use it in one command's data, list struct for enum could not be generated, but it's used in qmp function. For example: KeyCodesList could not be generated. >>> qapi-schema.json: { 'enum': 'KeyCodes', 'data': [ 'shift', 'alt' ... ] } { 'command': 'sendkey',

[Qemu-devel] [PATCH v8 6/7] monitor: move key_defs[] table and introduce two help functions

2012-08-30 Thread Amos Kong
This patch added two help functions to convert key/code to index of mapping table, those functions will return Q_KEY_CODE_MAX if the code/key is invalid. Patch also moved key_defs[] to input.c, and removed useless KeyDef struct. Key's index in QKeyCode enmu is same as keycode's index in new key_de

[Qemu-devel] [PATCH v8 0/7] convert sendkey to qapi

2012-08-30 Thread Amos Kong
This series converted 'sendkey' command to qapi. The raw value in hexadecimal format is not supported by 'send-key' of qmp. Amos Kong (7): fix doc of using raw values with sendkey monitor: rename keyname '<' to 'less' hmp: rename arguments qapi: generate list struct and visit_list for enum

Re: [Qemu-devel] [PATCH v7 5/6] add the QKeyCode enum and the key_defs table

2012-08-30 Thread Amos Kong
On 31/08/12 01:46, Luiz Capitulino wrote: On Mon, 20 Aug 2012 12:39:28 +0800 Amos Kong wrote: key_defs[] in monitor.c is a mapping table of keys and keycodes, this patch added a QKeyCode enum and a new key_defs table, key's index in the enmu is same as keycode's index in new key_defs[]. And a

Re: [Qemu-devel] [PATCH v3 2/5] [RFC] libqblock, user example

2012-08-30 Thread Wenchao Xia
于 2012-8-30 15:46, Paolo Bonzini 写道: Il 30/08/2012 03:59, Wenchao Xia ha scritto: Busy waiting is not acceptable, and this is the reason why I had suggested to keep AIO out of the design for now. You need to provide an implementation of AIO for either glib or something else, but this is best

Re: [Qemu-devel] QEMU emulation per CPU

2012-08-30 Thread Wei-Ren Chen
On Fri, Aug 31, 2012 at 01:50:05AM +0700, Mulyadi Santosa wrote: > On Thu, Aug 30, 2012 at 7:27 PM, Naresh Bhat wrote: > > Hi Santosa, > > > > Can you please forward a link of that discussion thread ?? > > try: > http://lists.nongnu.org/archive/html/qemu-devel/2012-08/msg05037.html I also thin

[Qemu-devel] [PATCH] iSCSI: We need to support SG_IO also from iscsi_ioctl()

2012-08-30 Thread Ronnie Sahlberg
We need to support SG_IO from the synchronous iscsi_ioctl() since scsi-block uses this to do an INQ to the device to discover its properties This patch makes scsi-block work with iscsi. Signed-off-by: Ronnie Sahlberg --- block/iscsi.c | 20 +++- 1 files changed, 19 insertions(+

[Qemu-devel] [PATCH] iSCSI: Add support for SG_IO to iscsi_ioctl()

2012-08-30 Thread Ronnie Sahlberg
Paolo, List Please find a small patch that adds support for SG_IO to the synchronous iscsi_ioctl() function. This is needed to make scsi-block work with iscsi. regards ronnie sahlberg

[Qemu-devel] [PATCH] iSCSI: We dont need to explicitely call qemu_notify_event() any more

2012-08-30 Thread Ronnie Sahlberg
We no longer need to explicitely call qemu_notify_event() any more since this is now done automatically any time the filehandles we listen to change. Signed-off-by: Ronnie Sahlberg --- block/iscsi.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/block/iscsi.c b/bl

[Qemu-devel] [PATCH] iSCSI: remove the now obsolete call to qemu_notify_event()

2012-08-30 Thread Ronnie Sahlberg
Paolo, List Please find a trivial patch to iscsi that removes the call to qemu_notify_event() We do not need to call this any more since a recent patch that made qemu_aio_set_fd_handler() and friends invoke this call automatically when required. regards ronnie sahlberg

Re: [Qemu-devel] [RFC v2 PATCH 6/6] QAPI: add command for live block commit, 'block-commit'

2012-08-30 Thread Eric Blake
On 08/30/2012 11:47 AM, Jeff Cody wrote: > The command for live block commit is added, which has the following > arguments: > > device: the block device to perform the commit on (mandatory) > base: the base image to commit into; optional (if not specified, > it is the underlying original

Re: [Qemu-devel] [RFC v2 PATCH 4/6] qerror: new error for live block commit, QERR_TOP_NOT_FOUND

2012-08-30 Thread Eric Blake
On 08/30/2012 11:47 AM, Jeff Cody wrote: > Signed-off-by: Jeff Cody > --- > qerror.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/qerror.h b/qerror.h > index d0a76a4..7396184 100644 > --- a/qerror.h > +++ b/qerror.h > @@ -219,6 +219,9 @@ void assert_no_error(Error *err); > #defin

Re: [Qemu-devel] macvlan/macvtap: guest/host cannot communicate when network cable is unplugged

2012-08-30 Thread ching
>> I also perform an additional test: the guests (macvtap bridge mode) CAN >> communicate each other no matter network cable is plugged or not. > Strange. I thought the original problem was that the macvtap guests > cannot communicate with each other when the network cable is > unplugged? > > Ho

Re: [Qemu-devel] [PATCH 3/7] block: raw-posix image file reopen

2012-08-30 Thread Eric Blake
On 08/30/2012 11:47 AM, Jeff Cody wrote: > This is derived from the Supriya Kannery's reopen patches. > > This contains the raw-posix driver changes for the bdrv_reopen_* > functions. All changes are staged into a temporary scratch buffer > during the prepare() stage, and copied over to the live

Re: [Qemu-devel] Adding support for Stateless Static NAT for TAP devices

2012-08-30 Thread John Basila
I have a setup that requires to run virtual machines using QEMU. All these machines will be executed from the same snapshot thus giving them the save same state when they come to life, this is why they all will have the same source IP, the only difference between them is that each one is connect

Re: [Qemu-devel] [PATCH for 1.2] console: Fix warning from clang (and potential crash)

2012-08-30 Thread Anthony Liguori
Stefan Weil writes: > Am 17.08.2012 16:10, schrieb Jan Kiszka: >> On 2012-08-17 15:50, Stefan Weil wrote: >> >>> ccc-analyzer reports this warning: >>> >>> console.c:1090:29: warning: Dereference of null pointer >>> if (active_console->cursor_timer) { >>>

[Qemu-devel] [Bug 1037606] Re: vmwgfx does not work with kvm vmware vga

2012-08-30 Thread Bug Watch Updater
** Changed in: linux Status: Unknown => Confirmed ** Changed in: linux Importance: Unknown => Medium -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1037606 Title: vmwgfx does not work wit

Re: [Qemu-devel] [PATCH for 1.2] w32: Fix broken build

2012-08-30 Thread Anthony Liguori
Stefan Weil writes: > Commit ef8621b1a3b199c348606c0a11a77d8e8bf135f1 added an include > file which is not available for MinGW compilations. > > Signed-off-by: Stefan Weil Applied. Thanks. Regards, Anthony Liguori > --- > target-i386/cpu.c |2 ++ > 1 file changed, 2 insertions(+) > > d

Re: [Qemu-devel] Adding support for Stateless Static NAT for TAP devices

2012-08-30 Thread Dennis Jacobfeuerborn
On 08/30/2012 12:58 PM, John Basila wrote: > Please allow me to add a few comments: > > The problem here is related to the fact that QEMU is executed with multiple > instances and all instances start from the same snapshot, thus if they all > send a UDP DNS query, they will all create a packet -

Re: [Qemu-devel] [RFC v2 PATCH 0/6] Live block commit

2012-08-30 Thread Jeff Cody
On 08/30/2012 02:47 PM, Jeff Cody wrote: > Live block commit. > > I originally had intended for this RFC series to include the more > complicated case of a live commit of the active layer, but removed > it for this commit in the hopes of making it into the soft feature > freeze for 1.2, so this se

Re: [Qemu-devel] Slow inbound traffic on macvtap interfaces

2012-08-30 Thread Richard Davies
Chris Webb wrote: > I found that on my laptop, the single change of host kernel config > > -CONFIG_INTEL_IDLE=y > +# CONFIG_INTEL_IDLE is not set > > is sufficient to turn transfers into guests from slow to full wire speed I am not deep enough in this code to write a patch, but I wonder if macvtap

Re: [Qemu-devel] Adding support for Stateless Static NAT for TAP devices

2012-08-30 Thread John Basila
I have tried NAT and this is why I came up with this feature. When starting multiple QEMU instances from the same snapshot image, the Guest OS in all instances from the same state and if they start a connection to the DNS server for example, they will all use the same source port. The iptables

Re: [Qemu-devel] Adding support for Stateless Static NAT for TAP devices

2012-08-30 Thread John Basila
Please allow me to add a few comments: The problem here is related to the fact that QEMU is executed with multiple instances and all instances start from the same snapshot, thus if they all send a UDP DNS query, they will all create a packet - for example - 10.0.0.2:2345 -> DNSERVER:53. The sou

[Qemu-devel] [PATCH] target-i386: Allow changing of Hypervisor CPUIDs.

2012-08-30 Thread Don Slutz
This is primarily done so that the guest will think it is running under vmware when hypervisor=vmware is specified as a property of a cpu. Also allow this to work in accel=tcg mode. The new cpu properties hyper_level, hyper_extra, hyper_extra_a, and hyper_extra_b can be used to further adjust wha

[Qemu-devel] [PATCH] target-i386: Allow changing of Hypervisor CPUIDs.

2012-08-30 Thread Don Slutz
This is primarily done so that the guest will think it is running under vmware when hypervisor=vmware is specified as a property of a cpu. Also allow this to work in accel=tcg mode. The new cpu properties hyper_level, hyper_extra, hyper_extra_a, and hyper_extra_b can be used to further adjust wha

[Qemu-devel] Adding support for Stateless Static NAT for TAP devices

2012-08-30 Thread John Basila
When running multiple instances of QEMU from the same image file (using -snapshot) and connecting each instance to a dedicated TAP device, the Guest OS will most likely not be able to communicate with the outside world as all packets leave the Guest OS from the same IP and thus the Host OS will hav

[Qemu-devel] VHDX support

2012-08-30 Thread Alex Bligh
Is anyone currently working on VHDX (as opposed to VHD) support, as used by the most recent version of Hyper-V? If not, would you be interested in patches? File format at: http://www.microsoft.com/en-us/download/details.aspx?id=29681 (Word format, sadly) -- Alex Bligh

Re: [Qemu-devel] [PATCH for 1.2] console: Fix warning from clang (and potential crash)

2012-08-30 Thread Stefan Weil
Am 17.08.2012 16:10, schrieb Jan Kiszka: On 2012-08-17 15:50, Stefan Weil wrote: ccc-analyzer reports this warning: console.c:1090:29: warning: Dereference of null pointer if (active_console->cursor_timer) { ^ Function console_select allows active_cons

Re: [Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset

2012-08-30 Thread Alexander Graf
On 30.08.2012, at 12:59, Jason Baron wrote: > On Fri, Aug 24, 2012 at 06:39:02AM +0200, Alexander Graf wrote: >>> While testing q35, I found that windows 7 (specifically, windows 7 ultimate >>> with sp1 x64), wouldn't install because it can't find the cdrom or disk >>> drive. >>> The failure m

[Qemu-devel] [PATCH for 1.2] w32: Fix broken build

2012-08-30 Thread Stefan Weil
Commit ef8621b1a3b199c348606c0a11a77d8e8bf135f1 added an include file which is not available for MinGW compilations. Signed-off-by: Stefan Weil --- target-i386/cpu.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index f3cac49..423e009 100644 --- a

Re: [Qemu-devel] [PATCH] ahci: properly reset PxCMD on HBA reset

2012-08-30 Thread Jason Baron
On Fri, Aug 24, 2012 at 06:39:02AM +0200, Alexander Graf wrote: > > While testing q35, I found that windows 7 (specifically, windows 7 ultimate > > with sp1 x64), wouldn't install because it can't find the cdrom or disk > > drive. > > The failure message is: 'A required cd/dvd device driver is mis

[Qemu-devel] [PATCH] ahci: add migration support

2012-08-30 Thread Jason Baron
Add support for ahci migration. This patch builds upon the patches posted previously by Andreas Faerber: http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg01538.html (I hope I am giving Andreas proper credit for his work.) I've tested these patches by migrating Windows 7 and Fedora 16 gues

[Qemu-devel] [PATCH 1/7] block: correctly set the keep_read_only flag

2012-08-30 Thread Jeff Cody
I believe the bs->keep_read_only flag is supposed to reflect the initial open state of the device. If the device is initially opened R/O, then commit operations, or reopen operations changing to R/W, are prohibited. Currently, the keep_read_only flag is only accurate for the active layer, and its

[Qemu-devel] [ANNOUNCE] QEMU 1.2.0-rc2 release

2012-08-30 Thread Anthony Liguori
Hi, On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 1.2 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-1.2.0-rc2.tar.bz2 You can help improve

[Qemu-devel] [RFC v2 PATCH 3/6] blockdev: rename block_stream_cb to a generic block_job_cb

2012-08-30 Thread Jeff Cody
Signed-off-by: Jeff Cody --- blockdev.c | 8 +--- trace-events | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/blockdev.c b/blockdev.c index 7c83baa..68d65fb 100644 --- a/blockdev.c +++ b/blockdev.c @@ -53,6 +53,8 @@ static const int if_max_devs[IF_COUNT] = { [I

[Qemu-devel] [RFC v2 PATCH 1/6] block: add support functions for live commit, to find and delete images.

2012-08-30 Thread Jeff Cody
Add bdrv_find_child(), and bdrv_delete_intermediate(). bdrv_find_child(): given 'bs' and the active (topmost) BDS of an image chain, find the image that is the immediate top of 'bs' bdrv_delete_intermediate(): Given 3 BDS (active, top, base), delete images

[Qemu-devel] [RFC v2 PATCH 2/6] block: add live block commit functionality

2012-08-30 Thread Jeff Cody
This adds the live commit coroutine. This iteration focuses on the commit only below the active layer, and not the active layer itself. The behaviour is similar to block streaming; the sectors are walked through, and anything that exists above 'base' is committed back down into base. At the end,

[Qemu-devel] [RFC v2 PATCH 0/6] Live block commit

2012-08-30 Thread Jeff Cody
Live block commit. I originally had intended for this RFC series to include the more complicated case of a live commit of the active layer, but removed it for this commit in the hopes of making it into the soft feature freeze for 1.2, so this series is the simpler case. This series adds the basic

[Qemu-devel] [PATCH 6/7] block: qcow2 image file reopen

2012-08-30 Thread Jeff Cody
These are the stubs for the file reopen drivers for the qcow2 format. There is currently nothing that needs to be done by the qcow2 driver in reopen. Signed-off-by: Jeff Cody --- block/qcow2.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/block/qcow2.c b/block/qcow

[Qemu-devel] [PATCH 7/7] block: qcow image file reopen

2012-08-30 Thread Jeff Cody
These are the stubs for the file reopen drivers for the qcow format. There is currently nothing that needs to be done by the qcow driver in reopen. Signed-off-by: Jeff Cody --- block/qcow.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/block/qcow.c b/block/qcow.c

[Qemu-devel] [RFC v2 PATCH 5/6] block: helper function, to find the base image of a chain

2012-08-30 Thread Jeff Cody
This is a simple helper function, that will return the base image of a given image chain. Signed-off-by: Jeff Cody --- block.c | 16 block.h | 1 + 2 files changed, 17 insertions(+) diff --git a/block.c b/block.c index 11e275c..5f58600 100644 --- a/block.c +++ b/block.c @@ -31

[Qemu-devel] [PATCH 5/7] block: qed image file reopen

2012-08-30 Thread Jeff Cody
These are the stubs for the file reopen drivers for the qed format. There is currently nothing that needs to be done by the qed driver in reopen. Signed-off-by: Jeff Cody --- block/qed.c | 20 1 file changed, 20 insertions(+) diff --git a/block/qed.c b/block/qed.c index a0

Re: [Qemu-devel] [PATCH 5/6] Fix enumeration typo error

2012-08-30 Thread Luiz Capitulino
On Thu, 23 Aug 2012 13:14:25 +0800 Lei Li wrote: > Signed-off-by: Lei Li Reviewed-by: Luiz Capitulino PS: CC'ing qemu-trivial as per Eric's suggestion. > --- > qapi-schema-guest.json |2 +- > qapi-schema.json |4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > dif

Re: [Qemu-devel] [PATCH 3/6] QAPI: Introduce memchar_write QMP command

2012-08-30 Thread Luiz Capitulino
On Thu, 23 Aug 2012 13:14:23 +0800 Lei Li wrote: > Signed-off-by: Lei Li > --- > hmp-commands.hx | 16 > hmp.c| 15 +++ > hmp.h|1 + > qapi-schema.json | 28 > qemu-char.c | 36 ++

Re: [Qemu-devel] Posix timer syscalls ; dealing with the timer_t type

2012-08-30 Thread Erik de Castro Lopo
Andreas Färber wrote: > Hi, > > Am 30.08.2012 14:30, schrieb Erik de Castro Lopo: > > I'm working on implementing Posix timers in linux-user. > > > > I'm having trouble figuring out how to handle the timer_t type. > > Consider the following code with say 32 bit ARM being emulated > > on 64 bit x

[Qemu-devel] [PATCH 2/7] block: Framework for reopening files safely

2012-08-30 Thread Jeff Cody
This is based heavily on Supriya Kannery's bdrv_reopen() patch series. This provides a transactional method to reopen multiple images files safely. Image files are queue for reopen via bdrv_reopen_queue(), and the reopen occurs when bdrv_reopen_multiple() is called. Changes are staged in bdrv_re

[Qemu-devel] [PATCH 3/7] block: raw-posix image file reopen

2012-08-30 Thread Jeff Cody
This is derived from the Supriya Kannery's reopen patches. This contains the raw-posix driver changes for the bdrv_reopen_* functions. All changes are staged into a temporary scratch buffer during the prepare() stage, and copied over to the live structure during commit(). Upon abort(), all chang

[Qemu-devel] [PATCH 4/7] block: raw image file reopen

2012-08-30 Thread Jeff Cody
These are the stubs for the file reopen drivers for the raw format. There is currently nothing that needs to be done by the raw driver in reopen. Signed-off-by: Jeff Cody --- block/raw.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/block/raw.c b/block/raw.c index

Re: [Qemu-devel] CPU hotplug

2012-08-30 Thread Stefan Priebe
Am 30.08.2012 20:56, schrieb Igor Mammedov: On Thu, 30 Aug 2012 20:45:10 +0200 Stefan Priebe wrote: Am 30.08.2012 20:40, schrieb Igor Mammedov: Am 30.08.2012 um 17:41 schrieb Andreas Färber : Am 30.08.2012 11:06, schrieb Stefan Priebe: I tried latest 1.2rc1 kvm-qemu with vanilla kernel v3.

Re: [Qemu-devel] CPU hotplug

2012-08-30 Thread Igor Mammedov
On Thu, 30 Aug 2012 20:45:10 +0200 Stefan Priebe wrote: > Am 30.08.2012 20:40, schrieb Igor Mammedov: > Am 30.08.2012 um 17:41 schrieb Andreas Färber : > > > Am 30.08.2012 11:06, schrieb Stefan Priebe: > >> I tried latest 1.2rc1 kvm-qemu with vanilla kernel v3.5.2 but the VM > >

[Qemu-devel] [RFC v2 PATCH 4/6] qerror: new error for live block commit, QERR_TOP_NOT_FOUND

2012-08-30 Thread Jeff Cody
Signed-off-by: Jeff Cody --- qerror.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qerror.h b/qerror.h index d0a76a4..7396184 100644 --- a/qerror.h +++ b/qerror.h @@ -219,6 +219,9 @@ void assert_no_error(Error *err); #define QERR_TOO_MANY_FILES \ ERROR_CLASS_GENERIC_ERROR, "Too m

Re: [Qemu-devel] [PATCH 2/6] monitor: Adjust qmp_human_monitor_command to new MemCharDriver

2012-08-30 Thread Luiz Capitulino
On Thu, 23 Aug 2012 13:14:22 +0800 Lei Li wrote: > Signed-off-by: Lei Li > --- > monitor.c |8 +++- > 1 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/monitor.c b/monitor.c > index 480f583..ab4650b 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -642,7 +642,13 @@ char

Re: [Qemu-devel] QEMU emulation per CPU

2012-08-30 Thread Mulyadi Santosa
On Thu, Aug 30, 2012 at 7:27 PM, Naresh Bhat wrote: > Hi Santosa, > > Can you please forward a link of that discussion thread ?? try: http://lists.nongnu.org/archive/html/qemu-devel/2012-08/msg05037.html -- regards, Mulyadi Santosa Freelance Linux trainer and consultant blog: the-hydra.blogsp

[Qemu-devel] [RFC v2 PATCH 6/6] QAPI: add command for live block commit, 'block-commit'

2012-08-30 Thread Jeff Cody
The command for live block commit is added, which has the following arguments: device: the block device to perform the commit on (mandatory) base: the base image to commit into; optional (if not specified, it is the underlying original image) top:the top image of the commit - all dat

[Qemu-devel] [PATCH 0/7] block: bdrv_reopen() patches

2012-08-30 Thread Jeff Cody
These patches are strongly based off Supriya Kannery's original bdrv_reopen() patches as part of the hostcache series, including the _prepare(), _commit(), and _abort() structure. Some additions / changes: * Added support for multiple image reopen transactionally * Reopen changes are staged into

Re: [Qemu-devel] CPU hotplug

2012-08-30 Thread Stefan Priebe
Am 30.08.2012 20:40, schrieb Igor Mammedov: Am 30.08.2012 um 17:41 schrieb Andreas Färber : Am 30.08.2012 11:06, schrieb Stefan Priebe: I tried latest 1.2rc1 kvm-qemu with vanilla kernel v3.5.2 but the VM just crashes when sending cpu_set X online through qm monitor. For SLES we're carrying

Re: [Qemu-devel] [PATCH 1/6] qemu-char: Convert MemCharDriver to circular buffer

2012-08-30 Thread Luiz Capitulino
On Thu, 23 Aug 2012 13:14:21 +0800 Lei Li wrote: > Signed-off-by: Lei Li > --- > qemu-char.c | 96 +++--- > qemu-char.h |2 +- > 2 files changed, 78 insertions(+), 20 deletions(-) > > diff --git a/qemu-char.c b/qemu-char.c > index 398ba

Re: [Qemu-devel] CPU hotplug

2012-08-30 Thread Igor Mammedov
On Thu, 30 Aug 2012 19:23:14 +0200 Stefan Priebe wrote: > Am 30.08.2012 18:43, schrieb Andreas Färber: > > Am 30.08.2012 18:35, schrieb Stefan Priebe: > >> Am 30.08.2012 um 17:41 schrieb Andreas Färber : > >> > >>> Am 30.08.2012 11:06, schrieb Stefan Priebe: > I tried latest 1.2rc1 kvm-qemu

[Qemu-devel] [PATCH 1/2] pcie: drop version_id field for live migration

2012-08-30 Thread Jason Baron
While testing q35 live migration, I found that the migration would abort with the following error: "Unknown savevm section type 76". The error is due to this check failing in 'vmstate_load_state()': while(field->name) { if ((field->field_exists && field->field_exists(opaq

[Qemu-devel] [PATCH 2/2] pcie_aer: clear cmask for Advanced Error Interrupt Message Number

2012-08-30 Thread Jason Baron
The Advanced Error Interrupt Message Number (bits 31:27 of the Root Error Status Register) is updated when the number of msi messages assigned to a device changes. Migration of windows 7 on q35 chipset failed because the check in get_pci_config_device() fails due to wmask being set on these bits. I

[Qemu-devel] [PATCH 0/2] pcie migration fixes

2012-08-30 Thread Jason Baron
Hi, A couple of pcie related migration fixes that I found while testing q35 migration. Thanks, -Jason Jason Baron (2): pcie: drop version_id field for live migration pcie_aer: clear cmask for Advanced Error Interrupt Message Number hw/pci.c |2 +- hw/pcie.h |1 - hw/pcie_

Re: [Qemu-devel] [PATCH v7 5/6] add the QKeyCode enum and the key_defs table

2012-08-30 Thread Luiz Capitulino
On Mon, 20 Aug 2012 12:39:28 +0800 Amos Kong wrote: > key_defs[] in monitor.c is a mapping table of keys and keycodes, > this patch added a QKeyCode enum and a new key_defs table, > key's index in the enmu is same as keycode's index in new key_defs[]. > > And added two help functions to convert

Re: [Qemu-devel] CPU hotplug

2012-08-30 Thread Stefan Priebe
Am 30.08.2012 18:43, schrieb Andreas Färber: Am 30.08.2012 18:35, schrieb Stefan Priebe: Am 30.08.2012 um 17:41 schrieb Andreas Färber : Am 30.08.2012 11:06, schrieb Stefan Priebe: I tried latest 1.2rc1 kvm-qemu with vanilla kernel v3.5.2 but the VM just crashes when sending cpu_set X online

Re: [Qemu-devel] [PATCH 00/18] qapi: Convert savevm, loadvm, delvm and info snapshots

2012-08-30 Thread Luiz Capitulino
On Wed, 15 Aug 2012 09:41:41 +0200 Pavel Hrdina wrote: > This patch series convert these commands into qapi and intruduce QMP commands > vm-snapshot-save, vm-snapshot-load, vm-snapshot-delete and query-vm-snapshots. > It also rewrite error report for function used by these commands. Unfortunatel

Re: [Qemu-devel] [PATCH 12/18] savevm: add error parameter to qemu_loadvm_state()

2012-08-30 Thread Luiz Capitulino
On Wed, 15 Aug 2012 09:41:53 +0200 Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > migration.c | 2 +- > savevm.c| 44 > sysemu.h| 3 ++- > 3 files changed, 31 insertions(+), 18 deletions(-) > > diff --git a/migration.c b/migrati

[Qemu-devel] [PATCH] qxl: dont update invalid area

2012-08-30 Thread riegamaths
From: Dunrong Huang This patch fixes the following error: $ ~/usr/bin/qemu-system-x86_64 -enable-kvm -m 1024 -spice port=5900,disable-ticketing -vga qxl -cdrom ~/Images/linuxmint-13-mate-dvd-32bit.iso (/home/mathslinux/usr/bin/qemu-system-x86_64:10068): SpiceWorker-CRITICAL **: red_worker.c:4

Re: [Qemu-devel] Posix timer syscalls ; dealing with the timer_t type

2012-08-30 Thread Andreas Färber
Hi, Am 30.08.2012 14:30, schrieb Erik de Castro Lopo: > I'm working on implementing Posix timers in linux-user. > > I'm having trouble figuring out how to handle the timer_t type. > Consider the following code with say 32 bit ARM being emulated > on 64 bit x86-64: > > timer_t timerid; > >

Re: [Qemu-devel] CPU hotplug

2012-08-30 Thread Andreas Färber
Am 30.08.2012 18:35, schrieb Stefan Priebe: > Am 30.08.2012 um 17:41 schrieb Andreas Färber : > >> Am 30.08.2012 11:06, schrieb Stefan Priebe: >>> I tried latest 1.2rc1 kvm-qemu with vanilla kernel v3.5.2 but the VM >>> just crashes when sending cpu_set X online through qm monitor. >> >> For SLES

Re: [Qemu-devel] CPU hotplug

2012-08-30 Thread Stefan Priebe
Am 30.08.2012 um 17:41 schrieb Andreas Färber : > Hello, > > Am 30.08.2012 11:06, schrieb Stefan Priebe: >> I tried latest 1.2rc1 kvm-qemu with vanilla kernel v3.5.2 but the VM >> just crashes when sending cpu_set X online through qm monitor. > > For SLES we're carrying a patch by Kamalesh Babul

Re: [Qemu-devel] Is is possible to virtualise or share the TPM?

2012-08-30 Thread Stefan Berger
On 08/30/2012 11:40 AM, Jordi Cucurull Juan wrote: Do you refer to the patches that add TPM support to the SeaBIOS? Sorry for the confusion. What I meant is that the patches adding support for a private vTPM for each QEMU VM are 'behind' those adding support for the passthrough device model.

Re: [Qemu-devel] Is is possible to virtualise or share the TPM?

2012-08-30 Thread Stefan Berger
On 08/30/2012 11:40 AM, Jordi Cucurull Juan wrote: Do you refer to the patches that add TPM support to the SeaBIOS? Sorry for the confusion. What I meant is that the patches adding support for a private vTPM for each QEMU VM are 'behind' those adding support for the passthrough device model.

Re: [Qemu-devel] CPU hotplug

2012-08-30 Thread Michael Tokarev
30.08.2012 19:41, Andreas Färber wrote: > Hello, > > Am 30.08.2012 11:06, schrieb Stefan Priebe: >> I tried latest 1.2rc1 kvm-qemu with vanilla kernel v3.5.2 but the VM >> just crashes when sending cpu_set X online through qm monitor. > > For SLES we're carrying a patch by Kamalesh Babulal that p

Re: [Qemu-devel] [Spice-devel] [PATCH] Add new client_present and client capabilities fields to QXLRom

2012-08-30 Thread Søren Sandmann
Gerd Hoffmann writes: >> The scheme I had in mind was this: >> >> - When a new non-a8-capable client appears, don't send it any of the >> a8 surfaces >> >> - If the client doesn't understand a8 surfaces, >> >> - keep all a8 surfaces rendered on the server side >> >>

Re: [Qemu-devel] [PATCH] sheepdog: fix savevm and loadvm

2012-08-30 Thread Kevin Wolf
Am 29.08.2012 20:39, schrieb MORITA Kazutaka: > This patch sets data to be sent to Sheepdog correctly and fixes savevm > and loadvm operations on a Sheepdog image. > > Signed-off-by: MORITA Kazutaka Thanks, applied to the block branch. Kevin

Re: [Qemu-devel] CPU hotplug

2012-08-30 Thread Andreas Färber
Hello, Am 30.08.2012 11:06, schrieb Stefan Priebe: > I tried latest 1.2rc1 kvm-qemu with vanilla kernel v3.5.2 but the VM > just crashes when sending cpu_set X online through qm monitor. For SLES we're carrying a patch by Kamalesh Babulal that prevents this (BNC#747339). Don't know why that patc

Re: [Qemu-devel] Is is possible to virtualise or share the TPM?

2012-08-30 Thread Jordi Cucurull Juan
Do you refer to the patches that add TPM support to the SeaBIOS? If this is the case, this is just a completely virtual TPM without any link with the TPM of the physical machine, right? Jordi. On 08/30/2012 04:50 PM, Stefan Berger wrote: On 08/30/2012 10:21 AM, Jordi Cucurull Juan wrote: D

Re: [Qemu-devel] [PATCH 03/18] block: add error parameter to bdrv_snapshot_goto() and related functions

2012-08-30 Thread Luiz Capitulino
On Wed, 15 Aug 2012 09:41:44 +0200 Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > block.c| 26 +++--- > block.h| 3 ++- > block/qcow2-snapshot.c | 11 --- > block/qcow2.h | 4 +++- > block/rbd.c| 6 ++

Re: [Qemu-devel] Is is possible to virtualise or share the TPM?

2012-08-30 Thread Stefan Berger
On 08/30/2012 10:21 AM, Jordi Cucurull Juan wrote: Dear Stefan, What does it mean that the patches with the VTPM functionality exist but they are behind the regular ones? Does it mean that they are not currently updated? That they have less priority? It means that in my patch queue they are

[Qemu-devel] [Bug 1037606] Re: vmwgfx does not work with kvm vmware vga

2012-08-30 Thread Michal Suchanek
** Bug watch added: Linux Kernel Bug Tracker #46711 http://bugzilla.kernel.org/show_bug.cgi?id=46711 ** Also affects: linux via http://bugzilla.kernel.org/show_bug.cgi?id=46711 Importance: Unknown Status: Unknown -- You received this bug notification because you are a member of q

Re: [Qemu-devel] [PATCH 02/18] block: add error parameter to bdrv_snapshot_create() and related functions

2012-08-30 Thread Luiz Capitulino
On Wed, 15 Aug 2012 09:41:43 +0200 Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > block.c| 25 + > block.h| 3 ++- > block/qcow2-snapshot.c | 9 - > block/qcow2.h | 4 +++- > block/rbd.c| 20 +

Re: [Qemu-devel] [PATCH for-1.2] msix: make [un]use vectors on reset/load optional

2012-08-30 Thread Michael S. Tsirkin
On Thu, Aug 30, 2012 at 03:34:42PM +0200, Andreas Färber wrote: > Am 29.08.2012 20:13, schrieb Michael S. Tsirkin: > > On Wed, Aug 29, 2012 at 06:54:35PM +0200, Andreas Färber wrote: > >> $subject: "[un]used vectors"? -- could be fixed by committer. > > > > Sorry I don't unedrstand. it's not 'unus

[Qemu-devel] [Bug 1037606] Re: vmwgfx does not work with kvm vmware vga

2012-08-30 Thread Joseph Salisbury
This issue appears to be an upstream bug, since you tested the latest upstream kernel. Would it be possible for you to open an upstream bug report[0]? That will allow the upstream Developers to examine the issue, and may provide a quicker resolution to the bug. If you are comfortable with openin

Re: [Qemu-devel] Is is possible to virtualise or share the TPM?

2012-08-30 Thread Jordi Cucurull Juan
Dear Stefan, What does it mean that the patches with the VTPM functionality exist but they are behind the regular ones? Does it mean that they are not currently updated? That they have less priority? Best regards, Jordi. On 08/29/2012 02:57 PM, Stefan Berger wrote: On 08/23/2012 04:05 PM,

Re: [Qemu-devel] [PATCH for-1.2] msix: make [un]use vectors on reset/load optional

2012-08-30 Thread Andreas Färber
Am 29.08.2012 20:13, schrieb Michael S. Tsirkin: > On Wed, Aug 29, 2012 at 06:54:35PM +0200, Andreas Färber wrote: >> $subject: "[un]used vectors"? -- could be fixed by committer. > > Sorry I don't unedrstand. it's not 'unused': it's use and unuse. > What is wrong with the subject? The grammar wi

Re: [Qemu-devel] [PATCH for-1.2] hw/arm_gic.c: Define .class_size in arm_gic_info TypeInfo

2012-08-30 Thread Andreas Färber
Am 29.08.2012 20:57, schrieb Stefan Weil: > PS. Are there perhaps more bugs of this sort? A quick test looking > for .class_init without .class_size shows a lot of files. That alone is not wrong. A problem only arises when a new struct ...Class is casted to but the object not sized appropriately

Re: [Qemu-devel] macvlan/macvtap: guest/host cannot communicate when network cable is unplugged

2012-08-30 Thread Stefan Hajnoczi
On Thu, Aug 30, 2012 at 1:13 PM, ching wrote: > >> Can you try the same test with two macvlan interfaces on the host (no >> macvtap)? You may need to use the ping -I >> argument to force the ping source address to a specific macvlan >> interface. >> >> If you see the same problem, it may just be

[Qemu-devel] [PATCH] xhci: allow 1 and 2 bytes accesses to capability registers

2012-08-30 Thread Alejandro Martinez Ruiz
Some xHC drivers (most notably on Windows and BSD systems) read the first capability registers using 1 and 2 bytes accesses, since this is how they are defined in section 5.3 of the xHCI specs. Enabling these kind of read accesses allows Windows and FreeBSD guests to properly recognize the host co

Re: [Qemu-devel] [PATCH V6 0/2] Add JSON output to qemu-img info

2012-08-30 Thread Benoît Canet
Le Monday 27 Aug 2012 à 11:52:59 (-0600), Eric Blake a écrit : > On 08/27/2012 01:15 AM, Benoît Canet wrote: > > This patchset add a JSON output mode to the qemu-img info command. > > It's a rewrite from scratch of the original patchset by Wenchao Xia > > following Anthony Liguori advices on JSON f

[Qemu-devel] Posix timer syscalls ; dealing with the timer_t type

2012-08-30 Thread Erik de Castro Lopo
Hi all, I'm working on implementing Posix timers in linux-user. I'm having trouble figuring out how to handle the timer_t type. Consider the following code with say 32 bit ARM being emulated on 64 bit x86-64: timer_t timerid; err = timer_create(clockid, &sev, &timerid); err = timer_

Re: [Qemu-devel] QEMU emulation per CPU

2012-08-30 Thread Naresh Bhat
Hi Santosa, Can you please forward a link of that discussion thread ?? Thanks and Regards -Naresh Bhat On Thu, Aug 30, 2012 at 2:39 PM, Mulyadi Santosa wrote: > Hi... > > On Thu, Aug 30, 2012 at 3:58 PM, Naresh Bhat wrote: >> Hi, >> >> Can you please explain me why qemu user mode doesn't get

Re: [Qemu-devel] [PATCH 01/18] qerror: introduce QERR_GENERIC_ERROR

2012-08-30 Thread Luiz Capitulino
On Wed, 15 Aug 2012 09:41:42 +0200 Pavel Hrdina wrote: > Signed-off-by: Pavel Hrdina > --- > qerror.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/qerror.h b/qerror.h > index d0a76a4..7e0bae7 100644 > --- a/qerror.h > +++ b/qerror.h > @@ -120,6 +120,9 @@ void assert_no_error(Err

Re: [Qemu-devel] macvlan/macvtap: guest/host cannot communicate when network cable is unplugged

2012-08-30 Thread ching
> Can you try the same test with two macvlan interfaces on the host (no > macvtap)? You may need to use the ping -I > argument to force the ping source address to a specific macvlan > interface. > > If you see the same problem, it may just be the macvlan design - it is > stacked on top of eth0 a

  1   2   >