Re: [Qemu-devel] Isuue assiging devices using VFIO on x86

2012-08-28 Thread Alex Williamson
On Tue, 2012-08-28 at 17:10 +, Bhushan Bharat-R65777 wrote: > > > -Original Message- > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Tuesday, August 28, 2012 9:27 PM > > To: Bhushan Bharat-R65777 > > Cc: k...@vger.kernel.org; Avi Kivity; qemu-devel@nongnu.org >

Re: [Qemu-devel] [PATCH] Fix buffer run out in eepro100.

2012-08-28 Thread Stefan Hajnoczi
On Wed, Aug 29, 2012 at 1:55 AM, Bo Yang wrote: > On 08/28/2012 06:59 PM, Stefan Hajnoczi wrote: >> On Tue, Aug 28, 2012 at 7:23 AM, Bo Yang wrote: >>> According >>> to liunux driver's implementation, the descriptor with EL bit set >>> must not be touched by hardware, usually, the buffer size of

Re: [Qemu-devel] [PATCH v4] configure: properly check if -lrt and -lm is needed

2012-08-28 Thread Natanael Copa
On Tue, 28 Aug 2012 17:16:18 + Blue Swirl wrote: > On Tue, Aug 28, 2012 at 7:33 AM, Natanael Copa > wrote: > > On Tue, 21 Aug 2012 18:12:05 + > > Blue Swirl wrote: > >> > >> Now I get this on mingw32: > >> config-host.mak is out-of-date, running configure > >> > >> Error: librt check fa

Re: [Qemu-devel] [PATCH] Add new client_present and client capabilities fields to QXLRom

2012-08-28 Thread Gerd Hoffmann
On 08/29/12 02:58, Søren Sandmann wrote: > Gerd Hoffmann writes: > >> On 08/27/12 19:20, Søren Sandmann Pedersen wrote: >>> From: Søren Sandmann Pedersen >>> >>> The client_present field is a byte that is set of non-zero when a >>> client is connected and to zero when no client is connected. >>>

Re: [Qemu-devel] [BUG 1.2] qemu-system-arm segfault

2012-08-28 Thread Stefan Weil
Am 28.08.2012 22:26, schrieb Adam Lackorzynski: Hi, I'm getting a segfault for qemu-system-arm (git). Git bisect points to 33e95c6328a3149a52615176617997c4f8f7088b. Host is x86-32, I'm not getting it in a 64bit environment. However, valgrind is showing a similar output for arm_gic_class_init and

[Qemu-devel] [PATCH v10 6/6] allower the user to disable pv event support

2012-08-28 Thread Wen Congyang
Signed-off-by: Wen Congyang --- hw/pc_piix.c|6 +- qemu-config.c |4 qemu-options.hx |3 ++- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 37eca23..10531a8 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -149,6 +149,8

[Qemu-devel] [PATCH v10 5/6] introduce a new qom device to deal with panicked event

2012-08-28 Thread Wen Congyang
If the target is x86/x86_64, the guest's kernel will write 0x01 to the port KVM_PV_EVENT_PORT when it is panciked. This patch introduces a new qom device kvm_pv_ioport to listen this I/O port, and deal with panicked event according to panicked_action's value. The possible actions are: 1. emit QEVEN

[Qemu-devel] [PATCH v10 4/6] add a new qevent: QEVENT_GUEST_PANICKED

2012-08-28 Thread Wen Congyang
This event will be emited when the guest is panicked. Signed-off-by: Wen Congyang --- monitor.c |1 + monitor.h |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index b17b1bb..f74dd2d 100644 --- a/monitor.c +++ b/monitor.c @@ -455,6 +455,7 @@ sta

[Qemu-devel] [PATCH v10 3/6] add a new runstate: RUN_STATE_GUEST_PANICKED

2012-08-28 Thread Wen Congyang
The guest will be in this state when it is panicked. Signed-off-by: Wen Congyang --- qapi-schema.json |6 +- qmp.c|3 ++- vl.c |7 ++- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index bd8ad74..ed

[Qemu-devel] [PATCH v10 2/6] kvm: Update kernel headers

2012-08-28 Thread Wen Congyang
Corresponding kvm.git hash: 1d92128f with my patch for kvm --- linux-headers/asm-s390/kvm.h |2 +- linux-headers/asm-s390/kvm_para.h |2 +- linux-headers/asm-x86/kvm.h |1 + linux-headers/asm-x86/kvm_para.h |9 + linux-headers/linux/kvm.h |3 +++ lin

[Qemu-devel] [PATCH v10 1/6] start vm after reseting it

2012-08-28 Thread Wen Congyang
The guest should run after reseting it, but it does not run if its old state is RUN_STATE_INTERNAL_ERROR or RUN_STATE_PAUSED. We don't set runstate to RUN_STATE_PAUSED when reseting the guest, so the runstate will be changed from RUN_STATE_INTERNAL_ERROR or RUN_STATE_PAUSED to RUN_STATE_RUNNING(no

[Qemu-devel] [PATCH v10] kvm: notify host when the guest is panicked

2012-08-28 Thread Wen Congyang
We can know the guest is panicked when the guest runs on xen. But we do not have such feature on kvm. Another purpose of this feature is: management app(for example: libvirt) can do auto dump when the guest is panicked. If management app does not do auto dump, the guest's user can do dump by hand

[Qemu-devel] [Bug 1037675] Re: Guest Kernel Panic if using "-cpu host" in qemu-kvm 1.1.1

2012-08-28 Thread Stefan Kuhn
I have the same issue, but not on hardened. Tried for 1-2 hours to send the output to serial console but failed. The text below is what I posted at https://bugs.gentoo.org/show_bug.cgi?id=431640#c8: ### Same issue here (same screenshot with qemu-kvm-1.1.1-r1), but not on hardened. Ha

Re: [Qemu-devel] [PATCH] Fix buffer run out in eepro100.

2012-08-28 Thread Bo Yang
On 08/28/2012 06:59 PM, Stefan Hajnoczi wrote: > On Tue, Aug 28, 2012 at 7:23 AM, Bo Yang wrote: >> According >> to liunux driver's implementation, the descriptor with EL bit set >> must not be touched by hardware, usually, the buffer size of this >> descriptor is set to 0. > > Please describe th

Re: [Qemu-devel] [PATCH] Add new client_present and client capabilities fields to QXLRom

2012-08-28 Thread Søren Sandmann
Gerd Hoffmann writes: > On 08/27/12 19:20, Søren Sandmann Pedersen wrote: >> From: Søren Sandmann Pedersen >> >> The client_present field is a byte that is set of non-zero when a >> client is connected and to zero when no client is connected. >> >> The client_capabilities[58] array contains 46

Re: [Qemu-devel] [PATCHv4 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Eduardo Habkost
On Wed, Aug 29, 2012 at 01:25:35AM +0300, Michael S. Tsirkin wrote: > On Wed, Aug 29, 2012 at 01:21:13AM +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 28, 2012 at 07:02:42PM -0300, Eduardo Habkost wrote: > > > On Wed, Aug 29, 2012 at 12:35:28AM +0300, Michael S. Tsirkin wrote: > > > > On Tue, Au

[Qemu-devel] qemu-system-arm segfault

2012-08-28 Thread Adam Lackorzynski
Hi, I'm getting a segfault for qemu-system-arm (git). Git bisect points to 33e95c6328a3149a52615176617997c4f8f7088b. Host is x86-32, I'm not getting it in a 64bit environment. However, valgrind is showing a similar output for arm_gic_class_init and arm_gic_init. $ arm-softmmu/qemu-system-arm -M r

[Qemu-devel] macvlan/macvtap: guest/host cannot communicate when network cable is unplugged

2012-08-28 Thread ching
Hi all, I try to setup guest network with macvlan, as guest cannot communicate with host directly, i try to workaround by configuring host to using a macvlan interface host: Gentoo x64, kernel 3.5.2, qemu-kvm 1.1.1-r1, libvirt 0.9.13 guest: Ubuntu 12.04, kernel 3.4.9, virtio-net The host is us

Re: [Qemu-devel] [PATCHv4 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Michael S. Tsirkin
On Wed, Aug 29, 2012 at 01:21:13AM +0300, Michael S. Tsirkin wrote: > On Tue, Aug 28, 2012 at 07:02:42PM -0300, Eduardo Habkost wrote: > > On Wed, Aug 29, 2012 at 12:35:28AM +0300, Michael S. Tsirkin wrote: > > > On Tue, Aug 28, 2012 at 04:13:38PM -0300, Eduardo Habkost wrote: > > > > On Tue, Aug 2

Re: [Qemu-devel] [PATCHv4 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 07:02:42PM -0300, Eduardo Habkost wrote: > On Wed, Aug 29, 2012 at 12:35:28AM +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 28, 2012 at 04:13:38PM -0300, Eduardo Habkost wrote: > > > On Tue, Aug 28, 2012 at 08:43:52PM +0300, Michael S. Tsirkin wrote: > > > > In preparatio

Re: [Qemu-devel] [PATCHv4 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Eduardo Habkost
On Wed, Aug 29, 2012 at 12:35:28AM +0300, Michael S. Tsirkin wrote: > On Tue, Aug 28, 2012 at 04:13:38PM -0300, Eduardo Habkost wrote: > > On Tue, Aug 28, 2012 at 08:43:52PM +0300, Michael S. Tsirkin wrote: > > > In preparation for adding PV EOI support, disable PV EOI by default for > > > 1.1 and

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-28 Thread Anthony Liguori
Blue Swirl writes: > On Tue, Aug 28, 2012 at 7:31 PM, Anthony Liguori > wrote: >> Blue Swirl writes: >> >>> On Tue, Aug 28, 2012 at 5:28 PM, Michael S. Tsirkin wrote: On Tue, Aug 28, 2012 at 05:01:55PM +, Blue Swirl wrote: > On Tue, Aug 28, 2012 at 7:35 AM, Michael Tokarev wrote

Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 09:02:05PM +0400, malc wrote: > On Tue, 28 Aug 2012, Michael S. Tsirkin wrote: > > > On Mon, Aug 27, 2012 at 07:40:56PM +, Blue Swirl wrote: > > > On Mon, Aug 27, 2012 at 7:24 PM, Michael S. Tsirkin > > > wrote: > > > > On Mon, Aug 27, 2012 at 07:12:27PM +, Blue S

Re: [Qemu-devel] [PATCH v2 4/4] kvm: i386: Add classic PCI device assignment

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 01:02:26PM +0200, Jan Kiszka wrote: > This adds PCI device assignment for i386 targets using the classic KVM > interfaces. This version is 100% identical to what is being maintained > in qemu-kvm for several years and is supported by libvirt as well. It is > expected to rema

Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 04:40:38PM -0300, Eduardo Habkost wrote: > On Tue, Aug 28, 2012 at 02:13:18PM -0500, Anthony Liguori wrote: > > "Michael S. Tsirkin" writes: > > > > > In preparation for adding PV EOI support, disable PV EOI by default for > > > 1.1 and older machine types, to avoid CPUID

Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 02:13:18PM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > In preparation for adding PV EOI support, disable PV EOI by default for > > 1.1 and older machine types, to avoid CPUID changing during migration. > > > > PV EOI can still be enabled/disabled by

Re: [Qemu-devel] [PATCHv4 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 04:13:38PM -0300, Eduardo Habkost wrote: > On Tue, Aug 28, 2012 at 08:43:52PM +0300, Michael S. Tsirkin wrote: > > In preparation for adding PV EOI support, disable PV EOI by default for > > 1.1 and older machine types, to avoid CPUID changing during migration. > > > > PV E

Re: [Qemu-devel] [PATCHv2 2/4] pc: refactor compat code

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 01:37:18PM -0300, Marcelo Tosatti wrote: > On Tue, Aug 28, 2012 at 07:31:24PM +0300, Michael S. Tsirkin wrote: > > On Tue, Aug 28, 2012 at 01:23:18PM -0300, Marcelo Tosatti wrote: > > > On Mon, Aug 27, 2012 at 03:20:13PM +0300, Michael S. Tsirkin wrote: > > > > In preparatio

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-28 Thread Peter Maydell
On 27 August 2012 13:15, Jan Kiszka wrote: > On 2012-08-27 14:07, Andreas Färber wrote: >> Am I correct to understand we compile this only for i386 / x86_64? > > This is correct. Did we ever make a decision about whether architecture specific KVM devices should all live in hw/kvm/ or in some dire

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 7:31 PM, Anthony Liguori wrote: > Blue Swirl writes: > >> On Tue, Aug 28, 2012 at 5:28 PM, Michael S. Tsirkin wrote: >>> On Tue, Aug 28, 2012 at 05:01:55PM +, Blue Swirl wrote: On Tue, Aug 28, 2012 at 7:35 AM, Michael Tokarev wrote: > On 27.08.2012 22:56, B

Re: [Qemu-devel] KVM call agenda for Tuesda, August 28th

2012-08-28 Thread Anthony Liguori
Eduardo Habkost writes: > On Tue, Aug 28, 2012 at 02:15:30PM -0500, Anthony Liguori wrote: >> Eduardo Habkost writes: >> >> > On Tue, Aug 28, 2012 at 07:59:47PM +0200, Andreas Färber wrote: >> >> Am 28.08.2012 16:27, schrieb Eduardo Habkost: >> >> > On Tue, Aug 28, 2012 at 02:55:56PM +0100, Pet

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-28 Thread malc
On Tue, 28 Aug 2012, Anthony Liguori wrote: > Blue Swirl writes: > > > On Tue, Aug 28, 2012 at 5:28 PM, Michael S. Tsirkin wrote: > >> On Tue, Aug 28, 2012 at 05:01:55PM +, Blue Swirl wrote: > >>> On Tue, Aug 28, 2012 at 7:35 AM, Michael Tokarev wrote: > >>> > On 27.08.2012 22:56, Blue Swi

Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Eduardo Habkost
On Tue, Aug 28, 2012 at 02:13:18PM -0500, Anthony Liguori wrote: > "Michael S. Tsirkin" writes: > > > In preparation for adding PV EOI support, disable PV EOI by default for > > 1.1 and older machine types, to avoid CPUID changing during migration. > > > > PV EOI can still be enabled/disabled by

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-28 Thread Anthony Liguori
Blue Swirl writes: > On Tue, Aug 28, 2012 at 5:28 PM, Michael S. Tsirkin wrote: >> On Tue, Aug 28, 2012 at 05:01:55PM +, Blue Swirl wrote: >>> On Tue, Aug 28, 2012 at 7:35 AM, Michael Tokarev wrote: >>> > On 27.08.2012 22:56, Blue Swirl wrote: >>> > [] >>> >>> +static uint32_t slow_bar_read

Re: [Qemu-devel] KVM call agenda for Tuesda, August 28th

2012-08-28 Thread Eduardo Habkost
On Tue, Aug 28, 2012 at 02:15:30PM -0500, Anthony Liguori wrote: > Eduardo Habkost writes: > > > On Tue, Aug 28, 2012 at 07:59:47PM +0200, Andreas Färber wrote: > >> Am 28.08.2012 16:27, schrieb Eduardo Habkost: > >> > On Tue, Aug 28, 2012 at 02:55:56PM +0100, Peter Maydell wrote: > >> >> On 28 A

Re: [Qemu-devel] KVM call agenda for Tuesda, August 28th

2012-08-28 Thread Anthony Liguori
Eduardo Habkost writes: > On Tue, Aug 28, 2012 at 07:59:47PM +0200, Andreas Färber wrote: >> Am 28.08.2012 16:27, schrieb Eduardo Habkost: >> > On Tue, Aug 28, 2012 at 02:55:56PM +0100, Peter Maydell wrote: >> >> On 28 August 2012 14:30, Eduardo Habkost wrote: >> >>> - 1.2 branching, or creation

Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Anthony Liguori
"Michael S. Tsirkin" writes: > In preparation for adding PV EOI support, disable PV EOI by default for > 1.1 and older machine types, to avoid CPUID changing during migration. > > PV EOI can still be enabled/disabled by specifying it explicitly. > Enable for 1.1 > -M pc-1.1 -cpu kvm64,+kv

Re: [Qemu-devel] [PATCHv4 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Eduardo Habkost
On Tue, Aug 28, 2012 at 08:43:52PM +0300, Michael S. Tsirkin wrote: > In preparation for adding PV EOI support, disable PV EOI by default for > 1.1 and older machine types, to avoid CPUID changing during migration. > > PV EOI can still be enabled/disabled by specifying it explicitly. > Enable

Re: [Qemu-devel] [PATCH v2 for-1.2 0/2] stream: complete early if end of backing file is reached

2012-08-28 Thread Kevin Wolf
Am 28.08.2012 16:26, schrieb Stefan Hajnoczi: > Image streaming hangs if the backing image is smaller than the image file. > The > problem is that the image streaming loop makes no progress when > bdrv_co_is_allocated() returns 0 with pnum=0. More details in the actual > patch. > > I have also

Re: [Qemu-devel] [PATCHv2 2/4] pc: refactor compat code

2012-08-28 Thread Marcelo Tosatti
On Tue, Aug 28, 2012 at 07:31:24PM +0300, Michael S. Tsirkin wrote: > On Tue, Aug 28, 2012 at 01:23:18PM -0300, Marcelo Tosatti wrote: > > On Mon, Aug 27, 2012 at 03:20:13PM +0300, Michael S. Tsirkin wrote: > > > In preparation to adding PV EOI migration for 1.2, > > > trivially refactor some some

Re: [Qemu-devel] PPC heathrow broken - update OpenBIOS to r1063?

2012-08-28 Thread Aurelien Jarno
On Mon, Aug 27, 2012 at 05:59:26PM -0700, Alexander Graf wrote: > > > On 27.08.2012, at 14:13, Aurelien Jarno wrote: > > > Hi, > > > > As you probably know, the PPC machines with a heathrow controller is > > broken following commit 9e56edcf ("vga: raise default vgamem size"). > > The PCI hole

[Qemu-devel] [PATCHv4 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Michael S. Tsirkin
In preparation for adding PV EOI support, disable PV EOI by default for 1.1 and older machine types, to avoid CPUID changing during migration. PV EOI can still be enabled/disabled by specifying it explicitly. Enable for 1.1 -M pc-1.1 -cpu kvm64,+kvm_pv_eoi Disable for 1.2 -M pc-1.2

Re: [Qemu-devel] KVM call agenda for Tuesda, August 28th

2012-08-28 Thread Eduardo Habkost
On Tue, Aug 28, 2012 at 07:59:47PM +0200, Andreas Färber wrote: > Am 28.08.2012 16:27, schrieb Eduardo Habkost: > > On Tue, Aug 28, 2012 at 02:55:56PM +0100, Peter Maydell wrote: > >> On 28 August 2012 14:30, Eduardo Habkost wrote: > >>> - 1.2 branching, or creation of a "cpu-next" tree where "goo

[Qemu-devel] [PATCHv4 4/4] kvm: get/set PV EOI MSR

2012-08-28 Thread Michael S. Tsirkin
Support get/set of new PV EOI MSR, for migration. Add an optional section for MSR value - send it out in case MSR was changed from the default value (0). Signed-off-by: Michael S. Tsirkin --- target-i386/cpu.h | 1 + target-i386/kvm.c | 13 + target-i386/machine.c | 21 +

Re: [Qemu-devel] KVM call agenda for Tuesda, August 28th

2012-08-28 Thread Andreas Färber
Am 28.08.2012 16:27, schrieb Eduardo Habkost: > On Tue, Aug 28, 2012 at 02:55:56PM +0100, Peter Maydell wrote: >> On 28 August 2012 14:30, Eduardo Habkost wrote: >>> - 1.2 branching, or creation of a "cpu-next" tree where "good to be >>> merged" patches can live until 1.2 is done; >> >> With 1.3

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 06:46:53PM +0100, Peter Maydell wrote: > On 28 August 2012 18:32, Michael S. Tsirkin wrote: > > What about _t in POSIX? That seems fairly safe if name is long and qemu > > specific enough. > > Depends what you mean by "safe". The spec says "don't use this"; > it isn't any

[Qemu-devel] [PATCHv4 2/4] pc: refactor compat code

2012-08-28 Thread Michael S. Tsirkin
In preparation to adding PV EOI migration for 1.2, trivially refactor some some compat code to make it easier to add version specific cpuid tweaks. Signed-off-by: Michael S. Tsirkin --- hw/pc_piix.c | 44 1 file changed, 36 insertions(+), 8 deletions(

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Peter Maydell
On 28 August 2012 18:32, Michael S. Tsirkin wrote: > What about _t in POSIX? That seems fairly safe if name is long and qemu > specific enough. Depends what you mean by "safe". The spec says "don't use this"; it isn't any different to the __ and _[A-Z] prohibitions in that respect. Other posix n

[Qemu-devel] [PATCHv4 1/4] linux-headers: update to 3.6-rc3

2012-08-28 Thread Michael S. Tsirkin
Update linux-headers to version present in Linux 3.6-rc3. Header asm-x96_64/kvm_para.h update is needed for the new PV EOI feature. Signed-off-by: Michael S. Tsirkin --- linux-headers/asm-s390/kvm.h | 2 +- linux-headers/asm-s390/kvm_para.h | 2 +- linux-headers/asm-x86/kvm.h | 1 + l

[Qemu-devel] [PATCHv4 0/4] migrate PV EOI MSR

2012-08-28 Thread Michael S. Tsirkin
It turns out PV EOI gets disabled after migration - until next guest reset. This is because we are missing code to actually migrate it. This patch fixes it up: it applies cleanly to qemu.git as well as qemu-kvm.git, so I think it's cleaner to apply it in qemu.git to keep diff to minimum. Note: the

Re: [Qemu-devel] [PATCHv3 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 5:22 PM, Michael S. Tsirkin wrote: > On Tue, Aug 28, 2012 at 05:05:25PM +, Blue Swirl wrote: >> > +static bool _kvm_pv_eoi_disabled; >> >> NACK. I find your lack of compliance disturbing. > > Compliance with what? Could you please add some > motivation for the NACK? Yo

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 5:28 PM, Michael S. Tsirkin wrote: > On Tue, Aug 28, 2012 at 05:01:55PM +, Blue Swirl wrote: >> On Tue, Aug 28, 2012 at 7:35 AM, Michael Tokarev wrote: >> > On 27.08.2012 22:56, Blue Swirl wrote: >> > [] >> >>> +static uint32_t slow_bar_readb(void *opaque, target_phys_

Re: [Qemu-devel] [PATCHv3 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 05:28:22PM +, Blue Swirl wrote: > On Tue, Aug 28, 2012 at 5:22 PM, Michael S. Tsirkin wrote: > > On Tue, Aug 28, 2012 at 05:05:25PM +, Blue Swirl wrote: > >> > +static bool _kvm_pv_eoi_disabled; > >> > >> NACK. I find your lack of compliance disturbing. > > > > Comp

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 09:33:16PM +0400, malc wrote: > On Tue, 28 Aug 2012, Peter Maydell wrote: > > > On 28 August 2012 18:21, Michael S. Tsirkin wrote: > > > We are talking about stuff like __kvm_pv_eoi - so the chance is exactly 0. > > > And if it does happen then you run a simple script and

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 06:27:59PM +0100, Peter Maydell wrote: > On 28 August 2012 18:21, Michael S. Tsirkin wrote: > > We are talking about stuff like __kvm_pv_eoi - so the chance is exactly 0. > > And if it does happen then you run a simple script and fix > > this one instance. > > Why not just

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Andreas Färber
Am 28.08.2012 18:01, schrieb Michael S. Tsirkin: > We copied HACKING from libvirt but it has some bogus stuff: > neither underscore capital, double underscore, or underscore 't' suffixes > are reserved in Posix/C: this appears to be based on misreading of the > C standard. Using sane prefixes is en

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread malc
On Tue, 28 Aug 2012, Peter Maydell wrote: > On 28 August 2012 18:21, Michael S. Tsirkin wrote: > > We are talking about stuff like __kvm_pv_eoi - so the chance is exactly 0. > > And if it does happen then you run a simple script and fix > > this one instance. > > Why not just use a name that doe

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 06:23:38PM +0100, Peter Maydell wrote: > On 28 August 2012 18:18, Michael S. Tsirkin wrote: > > On Tue, Aug 28, 2012 at 05:24:40PM +0100, Peter Maydell wrote: > >> C99 7.1.3 > >> reserves underscore capital and double underscore prefixes. > > > > This is taking it out of c

Re: [Qemu-devel] [Bug 1042388] Re: qemu: Unsupported syscall: 257 (timer_create)

2012-08-28 Thread Erik de Castro Lopo
Peter Maydell wrote: > A couple of days for somebody who knows what they're doing and has > a convenient test case. Working on it.

[Qemu-devel] [Bug 1042654] [NEW] Floppy disks and network not working on NT 3.1 on Qemu 1.2 rc1

2012-08-28 Thread TC1988
Public bug reported: When I try to put Floppy IMG/IMA/VFD images on NT 3.1 when it is running on Qemu 1.2 rc, they are not recognized and the network is not working even though I set it correctly (especially the AMD PCnet adapter) Here's some screenshot of the floppy error: http://i49.tinypic.co

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread malc
On Tue, 28 Aug 2012, Michael S. Tsirkin wrote: > On Tue, Aug 28, 2012 at 05:24:40PM +0100, Peter Maydell wrote: > > On 28 August 2012 17:01, Michael S. Tsirkin wrote: > > > We copied HACKING from libvirt but it has some bogus stuff: > > > neither underscore capital, double underscore, or undersco

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Peter Maydell
On 28 August 2012 18:21, Michael S. Tsirkin wrote: > We are talking about stuff like __kvm_pv_eoi - so the chance is exactly 0. > And if it does happen then you run a simple script and fix > this one instance. Why not just use a name that doesn't use a double underscore in the first place? The C

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 05:01:55PM +, Blue Swirl wrote: > On Tue, Aug 28, 2012 at 7:35 AM, Michael Tokarev wrote: > > On 27.08.2012 22:56, Blue Swirl wrote: > > [] > >>> +static uint32_t slow_bar_readb(void *opaque, target_phys_addr_t addr) > >>> +{ > >>> +AssignedDevRegion *d = opaque; >

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 5:21 PM, Michael S. Tsirkin wrote: > On Tue, Aug 28, 2012 at 05:13:24PM +, Blue Swirl wrote: >> On Tue, Aug 28, 2012 at 4:01 PM, Michael S. Tsirkin wrote: >> > We copied HACKING from libvirt but it has some bogus stuff: >> > neither underscore capital, double underscor

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Peter Maydell
On 28 August 2012 18:18, Michael S. Tsirkin wrote: > On Tue, Aug 28, 2012 at 05:24:40PM +0100, Peter Maydell wrote: >> C99 7.1.3 >> reserves underscore capital and double underscore prefixes. > > This is taking it out of context - reserved means different > things in different parts of the spec.

Re: [Qemu-devel] [PATCHv3 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 05:05:25PM +, Blue Swirl wrote: > > +static bool _kvm_pv_eoi_disabled; > > NACK. I find your lack of compliance disturbing. Compliance with what? Could you please add some motivation for the NACK? -- MST

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 05:13:24PM +, Blue Swirl wrote: > On Tue, Aug 28, 2012 at 4:01 PM, Michael S. Tsirkin wrote: > > We copied HACKING from libvirt but it has some bogus stuff: > > neither underscore capital, double underscore, or underscore 't' suffixes > > are reserved in Posix/C: this a

Re: [Qemu-devel] [RFC][PATCH v4 3/3] tcg: Optimize qemu_ld/st by generating slow paths at the end of a block

2012-08-28 Thread Andreas Färber
Am 27.08.2012 20:31, schrieb Peter Maydell: > On 27 August 2012 08:23, Yeongkyoon Lee wrote: >> BTW, who will finally confirm my patches? >> I have sent four version of my patches in which I have applied all the >> reasonable feedbacks from this community. > > If you'd like your patches committed

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 05:24:40PM +0100, Peter Maydell wrote: > On 28 August 2012 17:01, Michael S. Tsirkin wrote: > > We copied HACKING from libvirt but it has some bogus stuff: > > neither underscore capital, double underscore, or underscore 't' suffixes > > are reserved in Posix/C: this appear

Re: [Qemu-devel] [PATCH v4] configure: properly check if -lrt and -lm is needed

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 7:33 AM, Natanael Copa wrote: > On Tue, 21 Aug 2012 18:12:05 + > Blue Swirl wrote: >> >> Now I get this on mingw32: >> config-host.mak is out-of-date, running configure >> >> Error: librt check failed > > Any news on the v4 patch, which should fix this? No change: con

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 4:01 PM, Michael S. Tsirkin wrote: > We copied HACKING from libvirt but it has some bogus stuff: > neither underscore capital, double underscore, or underscore 't' suffixes > are reserved in Posix/C: this appears to be based on misreading of the > C standard. Using sane pre

Re: [Qemu-devel] Isuue assiging devices using VFIO on x86

2012-08-28 Thread Bhushan Bharat-R65777
> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Tuesday, August 28, 2012 9:27 PM > To: Bhushan Bharat-R65777 > Cc: k...@vger.kernel.org; Avi Kivity; qemu-devel@nongnu.org > Subject: Re: Isuue assiging devices using VFIO on x86 > > On Tue, 2012-08-

Re: [Qemu-devel] [PATCH V5 1/8] isa: add isa_address_space_io

2012-08-28 Thread Jan Kiszka
On 2012-08-28 17:42, Julien Grall wrote: > On 08/24/2012 05:10 PM, Andreas Färber wrote: >> Am 22.08.2012 14:27, schrieb Julien Grall: >> >>> This function permits to retrieve ISA IO address space. >>> It will be usefull when we need to pass IO address space as argument. >>> >>> Signed-off-by:

Re: [Qemu-devel] [PATCHv3 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 1:22 PM, Michael S. Tsirkin wrote: > In preparation for adding PV EOI support, disable PV EOI by default for > 1.1 and older machine types, to avoid CPUID changing during migration. > > PV EOI can still be enabled/disabled by specifying it explicitly. > Enable for 1.1 >

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 7:35 AM, Michael Tokarev wrote: > On 27.08.2012 22:56, Blue Swirl wrote: > [] >>> +static uint32_t slow_bar_readb(void *opaque, target_phys_addr_t addr) >>> +{ >>> +AssignedDevRegion *d = opaque; >>> +uint8_t *in = d->u.r_virtbase + addr; >> >> Don't perform arithme

Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread malc
On Tue, 28 Aug 2012, Michael S. Tsirkin wrote: > On Mon, Aug 27, 2012 at 07:40:56PM +, Blue Swirl wrote: > > On Mon, Aug 27, 2012 at 7:24 PM, Michael S. Tsirkin wrote: > > > On Mon, Aug 27, 2012 at 07:12:27PM +, Blue Swirl wrote: > > >> On Mon, Aug 27, 2012 at 7:06 PM, Michael S. Tsirkin

Re: [Qemu-devel] [RFC][PATCH v4 3/3] tcg: Optimize qemu_ld/st by generating slow paths at the end of a block

2012-08-28 Thread Blue Swirl
On Tue, Aug 28, 2012 at 6:52 AM, Yeongkyoon Lee wrote: > >>> It's been a long time. >>> >>> I've tested the performances of one jump difference when fast qemu_ld/st >>> (TLB hit). >>> The result shows 3.6% CoreMark enhancement when reducing one jump where >>> slow >>> paths are generated at the en

Re: [Qemu-devel] PPC heathrow broken - update OpenBIOS to r1063?

2012-08-28 Thread Blue Swirl
On Mon, Aug 27, 2012 at 9:13 PM, Aurelien Jarno wrote: > Hi, > > As you probably know, the PPC machines with a heathrow controller is > broken following commit 9e56edcf ("vga: raise default vgamem size"). > The PCI hole space is not big enough for such a new default size. > > Alexander has fixed i

Re: [Qemu-devel] Isuue assiging devices using VFIO on x86

2012-08-28 Thread Alex Williamson
On Tue, 2012-08-28 at 09:23 +, Bhushan Bharat-R65777 wrote: > Hi Alex, > > In my susyem I have following devices: > > I tried assigning a following PCI devices: > 00:03.0 Communication controller: Intel Corporation 4 Series Chipset HECI > Controller (rev 03) > 00:03.2 IDE interface: Intel Co

Re: [Qemu-devel] QEMU emulation per CPU

2012-08-28 Thread Mulyadi Santosa
Hi :) On Tue, Aug 28, 2012 at 3:39 PM, Naresh Bhat wrote: > Hi Mulyadi Santosa, > > Thank you very much for quick response. Can you share some documents > ? I want to do it practically. one of the google results you might find helpful is: http://www.cyberciti.biz/tips/setting-processor-affinity

Re: [Qemu-devel] [PATCHv2 2/4] pc: refactor compat code

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 01:23:18PM -0300, Marcelo Tosatti wrote: > On Mon, Aug 27, 2012 at 03:20:13PM +0300, Michael S. Tsirkin wrote: > > In preparation to adding PV EOI migration for 1.2, > > trivially refactor some some compat code > > to make it easier to add version specific > > cpuid tweaks.

Re: [Qemu-devel] [PATCHv2 2/4] pc: refactor compat code

2012-08-28 Thread Marcelo Tosatti
On Mon, Aug 27, 2012 at 03:20:13PM +0300, Michael S. Tsirkin wrote: > In preparation to adding PV EOI migration for 1.2, > trivially refactor some some compat code > to make it easier to add version specific > cpuid tweaks. > > Signed-off-by: Michael S. Tsirkin > --- > hw/pc_piix.c | 44

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Peter Maydell
On 28 August 2012 17:01, Michael S. Tsirkin wrote: > We copied HACKING from libvirt but it has some bogus stuff: > neither underscore capital, double underscore, or underscore 't' suffixes > are reserved in Posix/C: this appears to be based on misreading of the > C standard. Using sane prefixes is

Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread Michael S. Tsirkin
On Mon, Aug 27, 2012 at 07:40:56PM +, Blue Swirl wrote: > On Mon, Aug 27, 2012 at 7:24 PM, Michael S. Tsirkin wrote: > > On Mon, Aug 27, 2012 at 07:12:27PM +, Blue Swirl wrote: > >> On Mon, Aug 27, 2012 at 7:06 PM, Michael S. Tsirkin > >> wrote: > >> > On Mon, Aug 27, 2012 at 06:58:29PM

[Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Michael S. Tsirkin
We copied HACKING from libvirt but it has some bogus stuff: neither underscore capital, double underscore, or underscore 't' suffixes are reserved in Posix/C: this appears to be based on misreading of the C standard. Using sane prefixes is enough to avoid conflicts. These rules are also widely vio

Re: [Qemu-devel] [PATCH v1 4/4] hw: Add support for a dummy ARMv7-M board

2012-08-28 Thread Meador Inge
On 08/28/2012 07:48 AM, Peter Maydell wrote: > On 27 August 2012 21:37, Meador Inge wrote: >> This patch adds support for a "dummy" ARMv7-M board so that >> QEMU can be used as an ISS for ARMv7-M processors. For example, >> running an image compiled for the Cortex-M3 with -cpu cortex-m3 >> shoul

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread Michael S. Tsirkin
On Tue, Aug 28, 2012 at 07:01:16PM +0300, Michael S. Tsirkin wrote: > We copied HACKING from libvirt but it has some bogus stuff: > neither underscore capital, double underscore, or underscore 't' suffixes > are reserved in Posix/C: this appears to be based on misreading of the > C standard. Using

Re: [Qemu-devel] [PATCH V5 1/8] isa: add isa_address_space_io

2012-08-28 Thread Julien Grall
On 08/24/2012 05:10 PM, Andreas Färber wrote: Am 22.08.2012 14:27, schrieb Julien Grall: This function permits to retrieve ISA IO address space. It will be usefull when we need to pass IO address space as argument. Signed-off-by: Julien Grall --- hw/isa-bus.c |5 + hw/isa.h |

Re: [Qemu-devel] [PATCH]] audio: previous audio buffer should be flushed

2012-08-28 Thread malc
On Tue, 28 Aug 2012, munkyu.im wrote: > Winwave audio backend has problem with pausing and restart audio out. > Unlike other backends, Winwave pausing API does not flush audio buffer. > As a result, the previous audio data are playedin front of > user expected sound when user restart audio. > So c

Re: [Qemu-devel] [PATCH v2 for-1.2 2/2] qemu-iotests: add backing file smaller than image test case

2012-08-28 Thread Paolo Bonzini
Il 28/08/2012 16:26, Stefan Hajnoczi ha scritto: > This new test case checks that streaming completes successfully when the > backing file is smaller than the image file. > > Signed-off-by: Stefan Hajnoczi > --- > tests/qemu-iotests/030 | 33 + > tests/qemu-

Re: [Qemu-devel] [PATCH v2 for-1.2 1/2] stream: complete early if end of backing file is reached

2012-08-28 Thread Paolo Bonzini
Il 28/08/2012 16:26, Stefan Hajnoczi ha scritto: > It is possible to create an image that is larger than its backing file. > Reading beyond the end of the backing file produces zeroes if no writes > have been made to those sectors in the image file. > > This patch finishes streaming early when the

[Qemu-devel] KVM call minutes for Tuesday, August 28th

2012-08-28 Thread Juan Quintela
Hi As almost everybody was at LinuxCon, we only started talking about the cpu patches from Eduardo and decided to left things for the list/next week. - cpu patches until 1.2 * get a new tree somewhere - 1.3 discussion will wait until 1.2 is out people too busy right now - Remember than KVM

[Qemu-devel] [PATCH v2 for-1.2 1/2] stream: complete early if end of backing file is reached

2012-08-28 Thread Stefan Hajnoczi
It is possible to create an image that is larger than its backing file. Reading beyond the end of the backing file produces zeroes if no writes have been made to those sectors in the image file. This patch finishes streaming early when the end of the backing file is reached. Without this patch th

[Qemu-devel] [PATCH v2 for-1.2 2/2] qemu-iotests: add backing file smaller than image test case

2012-08-28 Thread Stefan Hajnoczi
This new test case checks that streaming completes successfully when the backing file is smaller than the image file. Signed-off-by: Stefan Hajnoczi --- tests/qemu-iotests/030 | 33 + tests/qemu-iotests/030.out |4 ++-- 2 files changed, 35 insertions(+),

[Qemu-devel] [PATCH v2 for-1.2 0/2] stream: complete early if end of backing file is reached

2012-08-28 Thread Stefan Hajnoczi
Image streaming hangs if the backing image is smaller than the image file. The problem is that the image streaming loop makes no progress when bdrv_co_is_allocated() returns 0 with pnum=0. More details in the actual patch. I have also included a qemu-iotest to check this scenario. It hangs when

Re: [Qemu-devel] KVM call agenda for Tuesda, August 28th

2012-08-28 Thread Eduardo Habkost
On Tue, Aug 28, 2012 at 02:55:56PM +0100, Peter Maydell wrote: > On 28 August 2012 14:30, Eduardo Habkost wrote: > > - 1.2 branching, or creation of a "cpu-next" tree where "good to be > > merged" patches can live until 1.2 is done; > > With 1.3 due for release in just over a week, it seems unl

Re: [Qemu-devel] [PATCH for-1.2] qed: refuse unaligned zero writes with a backing file

2012-08-28 Thread Paolo Bonzini
Il 28/08/2012 15:37, Stefan Hajnoczi ha scritto: >> > The "right fix" would not be much more complex though, something like >> > this, right? >> > (untested). > Yes but it's more complicated. To do a really good job we should > slice off the first/last clusters if they are unaligned, handle them

Re: [Qemu-devel] [PATCH for-1.2] stream: complete early if end of backing file is reached

2012-08-28 Thread Stefan Hajnoczi
On Tue, Aug 28, 2012 at 2:58 PM, Stefan Hajnoczi wrote: > It is possible to create an image that is larger than its backing file. > Reading beyond the end of the backing file produces zeroes if no writes > have been made to those sectors in the image file. > > This patch finishes streaming early w

[Qemu-devel] [PATCH for-1.2] stream: complete early if end of backing file is reached

2012-08-28 Thread Stefan Hajnoczi
It is possible to create an image that is larger than its backing file. Reading beyond the end of the backing file produces zeroes if no writes have been made to those sectors in the image file. This patch finishes streaming early when the end of the backing file is reached. Without this patch th

Re: [Qemu-devel] KVM call agenda for Tuesda, August 28th

2012-08-28 Thread Peter Maydell
On 28 August 2012 14:30, Eduardo Habkost wrote: > - 1.2 branching, or creation of a "cpu-next" tree where "good to be > merged" patches can live until 1.2 is done; With 1.3 due for release in just over a week, it seems unlikely that it's worth branching at this point... -- PMM

  1   2   >