Re: [Qemu-devel] [PATCH] kvm: Move kvm_allows_irq0_override() to target-i386

2012-07-20 Thread Jan Kiszka
On 2012-07-20 21:14, Peter Maydell wrote: > kvm_allows_irq0_override() is a totally x86 specific concept: > move it to the target-specific source file where it belongs. > This means we need a new header file for the prototype: > kvm_i386.h, in line with the existing kvm_ppc.h. First of all, the pa

Re: [Qemu-devel] [PATCH v2] Get tests/tcg building and fix an unused variable warning due to wrong extended asm operands.

2012-07-20 Thread Catalin Patulea
On Mon, Jul 16, 2012 at 5:19 PM, Peter Maydell wrote: > On 16 July 2012 21:11, Catalin Patulea wrote: >> To build/run the tests: >> $ cd $BUILD_PATH/tests/tcg >> $ SRC_PATH=path/to/qemu make >> >> Signed-off-by: Catalin Patulea >> --- >> This should also fix the lock nop error. I just peeked at

Re: [Qemu-devel] [PATCH] tests/tcg: add test-i386-fprem and make target for comparing QEMU to h/w

2012-07-20 Thread Catalin Patulea
On Tue, Jul 17, 2012 at 10:49 AM, Catalin Patulea wrote: > > the Windows build would not put the fields 'mantissa' and > > 'one' in the same 64 bit word, it would insert a padding bit. > Since floatx80 is not part of a Windows API (in fact, it's not part of > any API, it's in a test), could I give

Re: [Qemu-devel] [PATCH] alsa: fix configure detection of alsa

2012-07-20 Thread malc
On Fri, 20 Jul 2012, Anthony Liguori wrote: > Handle is uninitialized which causes the configure check to fail. > http://patchwork.ozlabs.org/patch/171688/ Has an advantage of not expecting alsa/asoundlib.h including stddef.h > Cc: malc > Signed-off-by: Anthony Liguori > --- > configure |

Re: [Qemu-devel] [PATCH] MAINTAINERS: Replace net maintainer Mark McLoughlin with Stefan Hajnoczi

2012-07-20 Thread Stefan Hajnoczi
On Fri, Jul 20, 2012 at 5:12 PM, Paolo Bonzini wrote: > Il 20/07/2012 15:51, Stefan Hajnoczi ha scritto: >> The net subsystem has lacked an active maintainer since 2009. I have >> built and tested a net-next tree to get the ball rolling again. > > Cool, are you going to take Laszlo's patches thro

Re: [Qemu-devel] [PATCH] alsa: fix configure detection of alsa

2012-07-20 Thread Stefan Weil
Am 20.07.2012 23:14, schrieb Anthony Liguori: Handle is uninitialized which causes the configure check to fail. Cc: malc Signed-off-by: Anthony Liguori --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index cef0a71..8335117 100755 -

[Qemu-devel] [PATCH] Fix some more Qemus in documentation and help text

2012-07-20 Thread Stefan Weil
Hopefully they will be eliminated one day. Signed-off-by: Stefan Weil --- docs/usb-storage.txt |2 +- qemu-options.hx |4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/usb-storage.txt b/docs/usb-storage.txt index ff97559..e58e849 100644 --- a/docs/usb-stor

[Qemu-devel] [PATCH] qdev: Fix Open Firmware comment

2012-07-20 Thread Stefan Weil
Commit 0d936928ef87ca1bb7b41b5b89c400c699a7691c removed code, but left the related comment at a location where it no longer belongs to. The patch moves the comment to the correct callback and improves the text. Signed-off-by: Stefan Weil --- hw/qdev.h | 11 +-- 1 file changed, 5 inser

[Qemu-devel] [PATCH] alsa: fix configure detection of alsa

2012-07-20 Thread Anthony Liguori
Handle is uninitialized which causes the configure check to fail. Cc: malc Signed-off-by: Anthony Liguori --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/configure b/configure index cef0a71..8335117 100755 --- a/configure +++ b/configure @@ -1888,7 +1888,

[Qemu-devel] [PATCH 3/3] migration: block migration when streaming block jobs are running.

2012-07-20 Thread benoit . canet
From: Benoît Canet Signed-off-by: Benoit Canet --- migration.c |5 + 1 file changed, 5 insertions(+) diff --git a/migration.c b/migration.c index 8db1b43..dfce680 100644 --- a/migration.c +++ b/migration.c @@ -425,6 +425,11 @@ void qmp_migrate(const char *uri, bool has_blk, bool blk,

[Qemu-devel] [PATCH 1/3] block: Add bdrv_have_block_jobs() so migration code abort if needed.

2012-07-20 Thread benoit . canet
From: Benoît Canet qmp_migrate() will be able to check if some block jobs are running using bdrv_have_block_jobs() and abort safely if needed. Signed-off-by: Benoit Canet --- block.c | 14 ++ block.h |2 ++ 2 files changed, 16 insertions(+) diff --git a/block.c b/block.c ind

[Qemu-devel] [PATCH 2/3] qerror: Add error telling that streaming blocks migration

2012-07-20 Thread benoit . canet
From: Benoît Canet Signed-off-by: Benoit Canet --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+) diff --git a/qerror.c b/qerror.c index 92c4eff..bcd74b7 100644 --- a/qerror.c +++ b/qerror.c @@ -283,6 +283,10 @@ static const QErrorStringTable qerror_table[] = {

[Qemu-devel] [PATCH 0/3] Block migration when streaming block jobs are running

2012-07-20 Thread benoit . canet
From: Benoît Canet This patchset is designed to avoid starting a live migration while one or more streaming block jobs are running. Tested with the following sequence: QEMU 1.1.50 monitor - type 'help' for more information (qemu) block_stream virtio0 1k (qemu) migrate tcp:localhost: migrate:

[Qemu-devel] SeaBIOS, FW_CFG_NUMA, and FW_CFG_MAX_CPUS

2012-07-20 Thread Eduardo Habkost
Hi, While working at the CPU index vs APIC ID changes, I stumbled upon another not-very-well-defined interface between SeaBIOS and QEMU, and I would like to clarify the semantics and constraints of some FW_CFG entries. First, the facts/assumptions: - There's no concept of "CPU index" or "CPU ide

Re: [Qemu-devel] [PATCH 7/7] RTC: Allow to migrate from old QEMU

2012-07-20 Thread Paolo Bonzini
Il 20/07/2012 19:38, Michael Roth ha scritto: >> > The new logic is compatible with old, and it should not block migration >> > from old QEMU. However, the new version cannot migrate to the old one. > Do we not plan to support 1.2 -> 1.1 with -M pc-1.1? No, we don't. That's why in general subsec

[Qemu-devel] [PATCH RFC] Makefile: fix parallel build after "make clean" execution

2012-07-20 Thread Igor Mitsyanko
If you configure qemu, then run "make clean" and then execute "make -jx" command, build will fail with error: cc1: error: qapi-generated: No such file or directory [-Werror] This happens because qemu guest agent build screws up its dependencies. This Makefile line: qemu-ga$(EXESUF): QEMU_CFLAGS

[Qemu-devel] [PATCH] kvm: Move kvm_allows_irq0_override() to target-i386

2012-07-20 Thread Peter Maydell
kvm_allows_irq0_override() is a totally x86 specific concept: move it to the target-specific source file where it belongs. This means we need a new header file for the prototype: kvm_i386.h, in line with the existing kvm_ppc.h. Signed-off-by: Peter Maydell --- I'm sure this isn't the only x86ism

Re: [Qemu-devel] [PATCH V3 1/3] linux-user: pass sockaddr from host to target

2012-07-20 Thread Peter Maydell
On 21 July 2012 02:28, Jing Huang wrote: > > Signed-off-by: Jing Huang When you send v4 of this series please can you include in this patch the deletion of the comment line "/* ??? Should this also swap msgh->name? */" from just above target_to_host_cmsg(). (This patch does the swapping of msgh

Re: [Qemu-devel] [PATCH V3 2/3] linux-user: make do_setsockopt support SOL_RAW ICMP_FILTER socket option

2012-07-20 Thread Peter Maydell
On 21 July 2012 02:29, Jing Huang wrote: > > Signed-off-by: Jing Huang Reviewed-by: Peter Maydell (when you do the next version of this patch series, if you include that line in the commit message for this patch it will let me know I've already looked at this patch and don't need to read it ag

Re: [Qemu-devel] [PATCH V3 3/3] linux-user: make host_to_target_cmsg support SO_TIMESTAMP cmsg_type

2012-07-20 Thread Peter Maydell
On 21 July 2012 02:30, Jing Huang wrote: This version of the patch is pretty close to correct -- just a few minor things to fix... > > Signed-off-by: Jing Huang > --- > linux-user/syscall.c | 15 +++-- > 1 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/linux-user/sy

Re: [Qemu-devel] [PATCH 7/7] RTC: Allow to migrate from old QEMU

2012-07-20 Thread Michael Roth
On Fri, Jul 20, 2012 at 12:53:53PM +0200, Paolo Bonzini wrote: > From: "Zhang, Yang Z" > > The new logic is compatible with old, and it should not block migration > from old QEMU. However, the new version cannot migrate to the old one. Do we not plan to support 1.2 -> 1.1 with -M pc-1.1? I'm no

[Qemu-devel] [PATCH V3 3/3] linux-user: make host_to_target_cmsg support SO_TIMESTAMP cmsg_type

2012-07-20 Thread Jing Huang
Signed-off-by: Jing Huang --- linux-user/syscall.c | 15 +++-- 1 files changed, 13 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 2228b1f..7521746 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -1350,8 +1350,17 @@ static i

[Qemu-devel] [PATCH V3 2/3] linux-user: make do_setsockopt support SOL_RAW ICMP_FILTER socket option

2012-07-20 Thread Jing Huang
Signed-off-by: Jing Huang --- linux-user/syscall.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 82aa83d..2228b1f 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -60,6 +60,7 @@ int __c

[Qemu-devel] [PATCH V3 1/3] linux-user: pass sockaddr from host to target

2012-07-20 Thread Jing Huang
Signed-off-by: Jing Huang --- linux-user/syscall.c | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 539af3f..82aa83d 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -1873,10 +1873,21 @@ static

[Qemu-devel] [PATCH V3 0/3] Fix ping issues in linux-user guest

2012-07-20 Thread Jing Huang
The following changes since commit 61dc008f3529fa74a63aad1907438dad857e255a: Revert "audio: Make PC speaker audio card available by default" These patches fix ping issues in linux-user guest: - do_sebdrecv() could not pass sockaddr to target after executing recvmsg(). Therefore, ping will shows:

Re: [Qemu-devel] [PATCH] configure: Support system emulation with large memory on w32 hosts

2012-07-20 Thread Stefan Weil
Am 20.07.2012 08:38, schrieb Alexey Kardashevskiy: On 20/07/12 16:05, Alexey Kardashevskiy wrote: On 20/07/12 15:37, Alexey Kardashevskiy wrote: On 20/07/12 15:23, Stefan Weil wrote: Am 20.07.2012 05:53, schrieb Alexey Kardashevskiy: On 19/07/12 02:37, Stefan Weil wrote: 32-bit applications

[Qemu-devel] [SeaBIOS PATCH 2/2] allow CPUs to have non-contiguous Local APIC IDs (v2)

2012-07-20 Thread Eduardo Habkost
Extract Local APIC IDs directly from the CPUs, and instead of check for "i < CountCPUs", check if the APIC ID was present on boot, when building ACPI tables and the MP-Table. This keeps ACPI Processor ID == APIC ID, but allows the hardware<->SeaBIOS interface be completely APIC-ID based and not de

[Qemu-devel] [SeaBIOS PATCH 1/2] acpi: report real I/O APIC ID (0) on MADT table (v2)

2012-07-20 Thread Eduardo Habkost
When resetting an I/O APIC, its ID is set to 0, and SeaBIOS doesn't change it, so report it correctly on the MADT table. Some hardware may require the BIOS to initialize I/O APIC ID to an unique value, but SeaBIOS doesn't do that. This patch at least makes the MADT table reflect reality. Changes

[Qemu-devel] [SeaBIOS PATCH 0/2] Allow non-contiguous APIC IDs (v2)

2012-07-20 Thread Eduardo Habkost
Small changes from the previous series: - Patch 1/2: cosmetic whitespace change - Patch 2/2: use size suffixes on asm instructions on smp.c - New patch descriptions Eduardo Habkost (2): acpi: report real I/O APIC ID (0) on MADT table allow CPUs to have non-contiguous Local APIC IDs (v2) s

Re: [Qemu-devel] [seabios PATCH 1/2] acpi: set I/O APIC ID to 0 by default

2012-07-20 Thread Eduardo Habkost
On Fri, Jul 20, 2012 at 12:18:59AM +0300, Gleb Natapov wrote: > On Thu, Jul 19, 2012 at 05:52:41PM -0300, Eduardo Habkost wrote: > > When resetting an I/O APIC, its ID is set to 0, so set it to 0 on the > > MADT table too. > > > Actually BIOS needs to configure ioapic id to a uniqe value. This doe

Re: [Qemu-devel] [PATCH] MAINTAINERS: Replace net maintainer Mark McLoughlin with Stefan Hajnoczi

2012-07-20 Thread Paolo Bonzini
Il 20/07/2012 15:51, Stefan Hajnoczi ha scritto: > The net subsystem has lacked an active maintainer since 2009. I have > built and tested a net-next tree to get the ball rolling again. Cool, are you going to take Laszlo's patches through your tree as well? Paolo

[Qemu-devel] [PATCH] unicore32: Split UniCore-F64 instruction helpers from helper.c

2012-07-20 Thread gxt
From: Guan Xuetao This patch just splits ucf64 instruction simulation helpers from helper.c. Also, two checkpatch warnings are solved. Signed-off-by: Guan Xuetao --- target-unicore32/Makefile.objs |2 + target-unicore32/helper.c | 330 - target-u

Re: [Qemu-devel] [PATCH 1/2] configure: Replace bash code by standard shell code

2012-07-20 Thread Olaf Hering
On Fri, Jul 20, Peter Maydell wrote: > I actually wrote a patch sitting on top of this one by Stefan > which moves the flag to QEMU_CFLAGS; > both are in the 11-patch series dealing with various configure > Werror issues: > http://patchwork.ozlabs.org/patch/171689/ The actual CFLAGS issue had to

[Qemu-devel] [PATCH] unicore32-softmmu: Add is_default setting for puv3 machine

2012-07-20 Thread gxt
From: Guan Xuetao This patch sets is_default to 1 for puv3 machine, so that find_default_machine() returns puv3 machine. Thanks Dunrong for pointing it out. Cc: Dunrong Huang Signed-off-by: Guan Xuetao --- hw/puv3.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/p

Re: [Qemu-devel] [PATCH 4/4] xen: Always set the vram dirty during migration.

2012-07-20 Thread Stefano Stabellini
On Fri, 20 Jul 2012, Anthony PERARD wrote: > On 17/07/12 19:30, Stefano Stabellini wrote: > > On Tue, 17 Jul 2012, Stefano Stabellini wrote: > >> On Tue, 17 Jul 2012, Anthony PERARD wrote: > >>> Because the call to track the dirty bit in the video ram during migration > >>> won't > >>> work (it re

[Qemu-devel] [PULL 00/10] arm-devs queue

2012-07-20 Thread Peter Maydell
Usual arm-devs pullreq; this one contains my changes to allow the vexpress-a15 to accept more than 2GB of RAM, the Exynos I2C device and a couple of minor bugfix patches. thanks -- PMM The following changes since commit 61dc008f3529fa74a63aad1907438dad857e255a: Revert "audio: Make PC speaker a

[Qemu-devel] [PATCH V2 0/5] Xen, introducing dirty log for migration.

2012-07-20 Thread Anthony PERARD
Hi, This patch set will fix live migration under Xen. For this I introduce a new QMP command to switch global-dirty log and few calls (in exec.c and memory.c) to xen set_dirty function. Change since the first patch set: - New patch to set dirty if not, in exec.c => only one place to add the

[Qemu-devel] [PATCH 08/10] hw/exynos4210_rtc.c: Fix calculating for value of year

2012-07-20 Thread Peter Maydell
From: Oleg Ogurtsov Signed-off-by: Oleg Ogurtsov Signed-off-by: Peter Maydell --- hw/exynos4210_rtc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/exynos4210_rtc.c b/hw/exynos4210_rtc.c index f781020..b42586e 100644 --- a/hw/exynos4210_rtc.c +++ b/hw/exynos4210_

Re: [Qemu-devel] q35 and ahci

2012-07-20 Thread Jason Baron
On Thu, Jul 05, 2012 at 05:07:43PM +0200, Alexander Graf wrote: > On 07/05/2012 04:06 PM, Jason Baron wrote: > >On Wed, Jul 04, 2012 at 10:33:18AM +0200, Alexander Graf wrote: > >>On 04.07.2012, at 03:29, Jason Baron wrote: > >> > >>>On Tue, Jul 03, 2012 at 10:54:37PM +0200, Alexander Graf wrote: >

[Qemu-devel] [PATCH 02/10] hw/arm_boot.c: Make ram_size a uint64_t

2012-07-20 Thread Peter Maydell
Make the RAM size in arm_boot_info a uint64_t so it can express the larger RAM sizes that may be seen in LPAE systems. Signed-off-by: Peter Maydell Reviewed-by: Peter A. G. Crosthwaite --- hw/arm-misc.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/arm-misc.h b/hw

[Qemu-devel] [PATCH 07/10] hw/vexpress.c: Allow >4GB of RAM for Cortex-A15 daughterboard

2012-07-20 Thread Peter Maydell
Now that we have LPAE support and can handle passing 64 bit RAM sizes to Linux via the device tree, we can lift the restriction in the Versatile Express A15 daughterboard model on not having more than 2GB of RAM. Allow up to 30GB, which is the maximum that can fit in the address map before running

[Qemu-devel] [PATCH 06/10] hw/arm_boot.c: Support DTBs which use 64 bit addresses

2012-07-20 Thread Peter Maydell
Support the case where the device tree blob specifies that #address-cells and #size-cells are greater than 1. (This is needed for device trees which can handle 64 bit physical addresses and thus total RAM sizes over 4GB.) Signed-off-by: Peter Maydell Reviewed-by: Peter A. G. Crosthwaite --- hw/

[Qemu-devel] [PATCH V2 2/5] xen: Introduce xen_modified_memory.

2012-07-20 Thread Anthony PERARD
This function is to be used during live migration. Every write access to the guest memory should call this funcion so the Xen tools knows which pages are dirty. Signed-off-by: Anthony PERARD --- hw/xen.h |1 + xen-all.c | 21 + xen-stub.c |4 3 files changed

[Qemu-devel] [PATCH 10/10] exynos4210: add Exynos4210 i2c implementation

2012-07-20 Thread Peter Maydell
From: Mitsyanko Igor Create 9 exynos4210 i2c interfaces. Signed-off-by: Igor Mitsyanko Reviewed-by: Andreas Färber Signed-off-by: Peter Maydell --- hw/arm/Makefile.objs |2 +- hw/exynos4210.c | 27 hw/exynos4210.h |3 + hw/exynos4210_i2c.c | 334 +++

[Qemu-devel] [PATCH 09/10] hw/exynos4210_rtc.c: remove unnecessary code

2012-07-20 Thread Peter Maydell
From: Oleg Ogurtsov Signed-off-by: Oleg Ogurtsov Signed-off-by: Peter Maydell --- hw/exynos4210_rtc.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/hw/exynos4210_rtc.c b/hw/exynos4210_rtc.c index b42586e..42a4ddc 100644 --- a/hw/exynos4210_rtc.c +++ b/hw/exynos42

Re: [Qemu-devel] [PATCH 1/2] vexpress: Add NOR0 Flash support

2012-07-20 Thread jagan
Was flash support on express is already there, I haven't seen this on mainline (master) that is the reason I worked this. Should I send the patches again with changing full name at Signed-off-by Regards, Jagan. On Fri, Jul 20, 2012 at 8:11 PM, Peter Maydell wrote: > On 18 July 2012 20:03, <40

[Qemu-devel] [PATCH 05/10] device_tree: Add support for reading device tree properties

2012-07-20 Thread Peter Maydell
Add support for reading device tree properties (both generic and single-cell ones) to QEMU's convenience wrapper layer. Signed-off-by: Peter Maydell Reviewed-by: Peter A. G. Crosthwaite --- device_tree.c | 30 ++ device_tree.h |4 2 files changed, 34 inser

[Qemu-devel] [PATCH 01/10] hw/pl011.c: Avoid crash on read when no chr backend present

2012-07-20 Thread Peter Maydell
Add a missing guard that meant we would segfault if the guest read UARTDR on a PL011 serial device which had no chr backend connected. (This didn't happen for Linux guests because Linux reads the flags register and doesn't try to read the UART if it's empty.) Reported-by: Christian Müller Signed-

[Qemu-devel] [PATCH 03/10] hw/arm_boot.c: Consistently use ram_size from arm_boot_info struct

2012-07-20 Thread Peter Maydell
Clean up the mix of getting the RAM size from the global ram_size and from the ram_size field in the arm_boot_info structure, so that we always use the structure field. Signed-off-by: Peter Maydell Reviewed-by: Peter A. G. Crosthwaite --- hw/arm_boot.c |5 +++-- 1 files changed, 3 insertion

[Qemu-devel] [PATCH 04/10] hw/arm_boot.c: Check for RAM sizes exceeding ATAGS capacity

2012-07-20 Thread Peter Maydell
The legacy ATAGS format for passing information to the kernel only allows RAM sizes which fit in 32 bits; enforce this restriction rather than silently doing something weird. Signed-off-by: Peter Maydell Reviewed-by: Peter A. G. Crosthwaite --- hw/arm_boot.c |6 ++ 1 files changed, 6 in

[Qemu-devel] [PATCH V2 1/5] QMP, Introduce xen-set-global-dirty-log command.

2012-07-20 Thread Anthony PERARD
This command is used during a migration of a guest under Xen. It calls memory_global_dirty_log_start or memory_global_dirty_log_stop according to the argument pass to the command. Signed-off-by: Anthony PERARD --- qapi-schema.json | 13 + qmp-commands.hx | 24 +++

[Qemu-devel] [PATCH V2 4/5] exec, memory: Call to xen_modified_memory.

2012-07-20 Thread Anthony PERARD
This patch add some calls to xen_modified_memory to notify Xen about dirtybits during migration. Signed-off-by: Anthony PERARD --- exec.c |1 + memory.c |2 ++ 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/exec.c b/exec.c index b24a03a..84f9557 100644 --- a/exec.c +++

Re: [Qemu-devel] [PATCH 2/2] vexpress: Add NOR1 Flash support

2012-07-20 Thread jagan
Thanks for your info, In fact I was thinking about to use drive_get(IF_PFLASH, 0, 0) for first and drive_get(IF_PFLASH, 0, 1) also. But the point I was still uncover is even I was using drive_get(IF_PFLASH, 0, 0) on both the flashes, If I tested through u-boot I was able to detect two flashes

[Qemu-devel] [PATCH V2 3/5] exec: Introduce helper to set dirty flags.

2012-07-20 Thread Anthony PERARD
This new helper/hook is used in the next patch to add an extra call in a single place. Signed-off-by: Anthony PERARD --- exec.c | 42 ++ 1 files changed, 14 insertions(+), 28 deletions(-) diff --git a/exec.c b/exec.c index feb4795..b24a03a 100644 --- a/

Re: [Qemu-devel] [PATCH 1/2] vexpress: Add NOR0 Flash support

2012-07-20 Thread Peter Maydell
On 18 July 2012 20:03, <402ja...@gmail.com> wrote: > From: Jagan <402ja...@gmail.com> > > This patch adds support for NOR0 flash (Bank #1) on > vexpress-a9 platform. It is 64MB CFI01 compliant flash. > > Tested on stable u-boot version through Linux. You might want to look at a previous attempt a

[Qemu-devel] [PATCH V2 5/5] xen: Always set the vram dirty during migration.

2012-07-20 Thread Anthony PERARD
Because the call to track the dirty bit in the video ram during migration won't work (it returns -1), we set dirtybit on the all video ram. Signed-off-by: Anthony PERARD --- xen-all.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/xen-all.c b/xen-all.c index 54e54cb

Re: [Qemu-devel] [PATCH v2 4/4] ARM: exynos4210_pmu: Add software reset support

2012-07-20 Thread Peter Maydell
On 12 July 2012 17:54, Maksim Kozlov wrote: > Signed-off-by: Maksim Kozlov > --- > hw/exynos4210_pmu.c | 40 +--- > 1 files changed, 33 insertions(+), 7 deletions(-) > > diff --git a/hw/exynos4210_pmu.c b/hw/exynos4210_pmu.c > index 7f09c79..96588d9 100644 >

Re: [Qemu-devel] [PATCH 2/4] ARM: exynos4210_pmu: changes in PRINT_DEBUG macro set.

2012-07-20 Thread Peter Maydell
On 6 July 2012 16:49, Maksim Kozlov wrote: > Subject: ARM: exynos4210_pmu: changes in PRINT_DEBUG macro set. This is a rather vague summary. > It make possible to set DEBUG_PMU and DEBUG_PMU_EXTEND "This makes it possible" > independently of each other The patch doesn't actually do this, tho

Re: [Qemu-devel] [PATCH 2/2] vexpress: Add NOR1 Flash support

2012-07-20 Thread Igor Mitsyanko
On 07/20/2012 05:30 PM, jagan wrote: I think I understand the situation, like when I called pflash_cfi01_register, it verifies BlockDriverState is < 0. Was my understanding correct? If ie so. I think I need to change drive_get(IF_PFLASH, 0, 0) to drive_get_next(IF_PFLASH) on second flash acce

Re: [Qemu-devel] [PATCH 2/2] vexpress: Add NOR1 Flash support

2012-07-20 Thread jagan
And one more point is when I tried drive_get(IF_PFLASH, 0, 0) and then drive_get_next(IF_PFLASH) individually on second flash. I didn't observe any issue on bdrv_attach_dev_nofail, as it seems to be failed on second case if we re-access the flash. Code snippet: -- + bdrv_attach_d

Re: [Qemu-devel] [PATCH 4/4] xen: Always set the vram dirty during migration.

2012-07-20 Thread Anthony PERARD
On 17/07/12 19:30, Stefano Stabellini wrote: On Tue, 17 Jul 2012, Stefano Stabellini wrote: On Tue, 17 Jul 2012, Anthony PERARD wrote: Because the call to track the dirty bit in the video ram during migration won't work (it returns -1), we set dirtybit on the all video ram. Signed-off-by: Anth

Re: [Qemu-devel] [PATCH 2/6] s390: sclp base support

2012-07-20 Thread Andreas Färber
Am 13.07.2012 12:52, schrieb Christian Borntraeger: > From: Heinz Graalfs > > This adds a more generic infrastructure for handling Service-Call > requests on s390. Currently we only support a small subset of Read > SCP Info directly in target-s390x. This patch provides the base > infrastructure f

Re: [Qemu-devel] [PATCH 1/4] ARM: exynos4210_pmu: just formatting changes

2012-07-20 Thread Peter Maydell
On 6 July 2012 16:49, Maksim Kozlov wrote: > Mainly to make 'exynos4210_pmu_regs' array more readable. > > static const Exynos4210PmuReg exynos4210_pmu_regs[] = { > -{"OM_STAT", OM_STAT, 0x}, > +{ "OM_STAT", OM_STAT, > 0x }, If

Re: [Qemu-devel] [PATCH 3/4] ARM: exynos4210_pmu: Introduced exynos4210_pmu_get_register_index

2012-07-20 Thread Peter Maydell
On 6 July 2012 16:49, Maksim Kozlov wrote: > This patch just introduces exynos4210_pmu_get_register_index function > to get index of the register's value in the array on its offset. And > functions _read and _write were modified accordingly. > > Signed-off-by: Maksim Kozlov Reviewed-by: Peter Ma

[Qemu-devel] [PATCH] MAINTAINERS: Replace net maintainer Mark McLoughlin with Stefan Hajnoczi

2012-07-20 Thread Stefan Hajnoczi
The net subsystem has lacked an active maintainer since 2009. I have built and tested a net-next tree to get the ball rolling again. Signed-off-by: Stefan Hajnoczi --- MAINTAINERS |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 30ed56d..2

Re: [Qemu-devel] [SeaBIOS] [PATCH 2/2] lsi53c895a boot support

2012-07-20 Thread Gerd Hoffmann
On 07/20/12 14:47, Kevin O'Connor wrote: > On Fri, Jul 20, 2012 at 09:33:05AM +0200, Gerd Hoffmann wrote: >> My concern isn't DMA'ing to the stack, but the size of the script and >> possible stack overruns. But maybe it is a moot point with the stack >> switching added to seabios recently. > > Di

Re: [Qemu-devel] [PATCH 2/2] vexpress: Add NOR1 Flash support

2012-07-20 Thread jagan
I think I understand the situation, like when I called pflash_cfi01_register, it verifies BlockDriverState is < 0. Was my understanding correct? If ie so. I think I need to change drive_get(IF_PFLASH, 0, 0) to drive_get_next(IF_PFLASH) on second flash access by keeping drive_get(IF_PFLASH, 0, 0

[Qemu-devel] [PATCH 2/4] trace/simple.c: remove unnecessary typecasting

2012-07-20 Thread Harsh Prateek Bora
Signed-off-by: Harsh Prateek Bora --- trace/simple.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/trace/simple.c b/trace/simple.c index 5d92939..a0e0f05 100644 --- a/trace/simple.c +++ b/trace/simple.c @@ -235,9 +235,9 @@ int trace_record_start(TraceBufferRecord *

[Qemu-devel] [PATCH 1/4] trace/simple.c: rename TraceRecordHeader to TraceLogHeader as appropriate.

2012-07-20 Thread Harsh Prateek Bora
Signed-off-by: Harsh Prateek Bora --- trace/simple.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/trace/simple.c b/trace/simple.c index b700ea3..5d92939 100644 --- a/trace/simple.c +++ b/trace/simple.c @@ -70,7 +70,7 @@ typedef struct { uint64_t header_event_id

Re: [Qemu-devel] [PATCH V4] exynos4210: add Exynos4210 i2c implementation

2012-07-20 Thread Peter Maydell
On 18 July 2012 19:18, Igor Mitsyanko wrote: > Create 9 exynos4210 i2c interfaces. > > Signed-off-by: Igor Mitsyanko > Reviewed-by: Andreas Färber Reviewed-by: Peter Maydell -- PMM

[Qemu-devel] [PATCH 2/2] net: add the support for -netdev socket, listen

2012-07-20 Thread Stefan Hajnoczi
From: Zhi Yong Wu The -net socket,listen option does not work with the newer -netdev syntax: http://lists.gnu.org/archive/html/qemu-devel/2011-11/msg01508.html This patch makes it work now. For the case where one vlan has multiple listenning sockets, the patch will also provide the support. S

[Qemu-devel] [PATCH 1/2] net: fix the coding style

2012-07-20 Thread Stefan Hajnoczi
From: Zhi Yong Wu Signed-off-by: Zhi Yong Wu Signed-off-by: Stefan Hajnoczi --- net/socket.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/socket.c b/net/socket.c index 312730a..4a093cb 100644 --- a/net/socket.c +++ b/net/socket.c @@ -301,7 +301,9 @@ static NetS

[Qemu-devel] [PATCH 0/2] net: Make -netdev socket,listen= work

2012-07-20 Thread Stefan Hajnoczi
The socket backend does not support the listen= option with -netdev. The problem is how the socket NetClientState lifecycle is implemented: the socket backend waits for an incoming client connection before creating a NetClientState. The guest -device wants a peer= on startup, so QEMU fails with a

[Qemu-devel] [PATCH 3/4] trace/simple.c: remove obsolete code

2012-07-20 Thread Harsh Prateek Bora
Signed-off-by: Harsh Prateek Bora --- trace/simple.c |2 -- trace/simple.h |1 - 2 files changed, 3 deletions(-) diff --git a/trace/simple.c b/trace/simple.c index a0e0f05..4fed07f 100644 --- a/trace/simple.c +++ b/trace/simple.c @@ -231,8 +231,6 @@ int trace_record_start(TraceBufferRec

[Qemu-devel] [PATCH 4/4] trace/simple.c: minor code refactoring

2012-07-20 Thread Harsh Prateek Bora
Signed-off-by: Harsh Prateek Bora --- trace/simple.c |9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/trace/simple.c b/trace/simple.c index 4fed07f..8e175ec 100644 --- a/trace/simple.c +++ b/trace/simple.c @@ -269,12 +269,11 @@ static unsigned int write_to_buffer(u

[Qemu-devel] [PATCH 0/4] Simpletrace v2: Code cleanup, refactoring.

2012-07-20 Thread Harsh Prateek Bora
Minor code cleanups, refactoring for Simpletrace v2. Harsh Prateek Bora (4): trace/simple.c: rename TraceRecordHeader to TraceLogHeader as appropriate. trace/simple.c: remove unnecessary typecasting trace/simple.c: remove obsolete code trace/simple.c: minor code refactoring trace/sim

Re: [Qemu-devel] [PATCH 2/2] hw/exynos4210_rtc.c: remove unnecessary code

2012-07-20 Thread Peter Maydell
On 11 July 2012 11:03, Oleg Ogurtsov wrote: > > Signed-off-by: Oleg Ogurtsov Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH 1/2] hw/exynos4210_rtc.c: Fix calculating for value of year

2012-07-20 Thread Peter Maydell
On 11 July 2012 11:03, Oleg Ogurtsov wrote: > > Signed-off-by: Oleg Ogurtsov Reviewed-by: Peter Maydell -- PMM

[Qemu-devel] [PATCH 05/16] net: Drop vlan argument to qemu_new_net_client()

2012-07-20 Thread Stefan Hajnoczi
Since hubs are now used to implement the 'vlan' feature and the vlan argument is always NULL, remove the argument entirely and update all net clients that use qemu_new_net_client(). Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 27 ++-

[Qemu-devel] [PATCH 00/16] net: Move legacy QEMU VLAN code into net/hub.c

2012-07-20 Thread Stefan Hajnoczi
[These patches are based on Laszlo Ersek's net OptsVisitor series.] The QEMU net subsystem has the concept of separate network segments, called "VLANs". Each VLAN is a broadcast domain so all net clients connected to the same VLAN can communicate with each other. Today this feature is mostly use

[Qemu-devel] [PATCH 13/16] net: Make "info network" output more readable info

2012-07-20 Thread Stefan Hajnoczi
From: Zhi Yong Wu Reviewed-by: Jan Kiszka Signed-off-by: Zhi Yong Wu Signed-off-by: Stefan Hajnoczi --- net.c | 14 +- net.h |1 + net/hub.c | 23 +-- net/hub.h |1 + 4 files changed, 32 insertions(+), 7 deletions(-) diff --git a/net.c b

[Qemu-devel] [PATCH 06/16] net: Convert qdev_prop_vlan to peer with hub

2012-07-20 Thread Stefan Hajnoczi
From: Zhi Yong Wu Instead of using VLANState use net/hub.h to support the vlan qdev property. The vlan qdev property becomes an alias for the peer qdev property but is represented as a VLAN ID number. When a VLAN ID is selected the device will really peer with a hub port. Signed-off-by: Zhi Yo

[Qemu-devel] [PATCH 12/16] net: Rename qemu_del_vlan_client() to qemu_del_net_client()

2012-07-20 Thread Stefan Hajnoczi
Another step in moving the vlan feature out of net core. Users only deal with NetClientState and therefore qemu_del_vlan_client() should be named qemu_del_net_client(). Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/e1000.c |2 +- hw/eepro100.c|2 +-

[Qemu-devel] [PATCH 01/16] net: Add a hub net client

2012-07-20 Thread Stefan Hajnoczi
The vlan feature can be implemented in terms of hubs. By introducing a hub net client it becomes possible to remove the special case vlan code from net.c and push the vlan feature out of generic networking code. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c |

[Qemu-devel] [PATCH 15/16] net: determine if packets can be sent before net queue deliver packets

2012-07-20 Thread Stefan Hajnoczi
From: Zhi Yong Wu Reviewed-by: Paolo Bonzini Signed-off-by: Zhi Yong Wu Signed-off-by: Stefan Hajnoczi --- net/queue.c |9 + net/slirp.c |7 --- slirp/if.c |5 - slirp/libslirp.h |1 - 4 files changed, 5 insertions(+), 17 deletions(-) diff --

Re: [Qemu-devel] [SeaBIOS] [PATCH 2/2] lsi53c895a boot support

2012-07-20 Thread Kevin O'Connor
On Fri, Jul 20, 2012 at 09:33:05AM +0200, Gerd Hoffmann wrote: > Hi, > > >> +/* FIXME: probably not the best idea to have this on the stack ... */ > >> +u32 script[] = { > > > > Several places in the code DMA to the stack already (usb-ehci, > > usb-uhci, ata). > > My concern isn't DMA'

[Qemu-devel] [PATCH 02/16] net: Use hubs for the vlan feature

2012-07-20 Thread Stefan Hajnoczi
Stop using the special-case vlan code in net.c. Instead use the hub net client to implement the vlan feature. The next patch will remove vlan code from net.c completely. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 38 +-

[Qemu-devel] [PATCH 16/16] hub: add the support for hub own flow control

2012-07-20 Thread Stefan Hajnoczi
From: Zhi Yong Wu Only when all other hub port's *peer* .can_receive() all return 1, the source hub port .can_receive() return 1. Reviewed-off-by: Paolo Bonzini Signed-off-by: Zhi Yong Wu Signed-off-by: Stefan Hajnoczi --- net/hub.c | 27 --- 1 file changed, 24 inse

[Qemu-devel] [PATCH 07/16] net: Remove vlan code from net.c

2012-07-20 Thread Stefan Hajnoczi
The vlan implementation in net.c has been replaced by hubs so we can remove the code. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/xen_nic.c |1 - net.c| 108 -- net.h|1 - 3 files changed, 110

[Qemu-devel] [PATCH 11/16] net: Rename vc local variables to nc

2012-07-20 Thread Stefan Hajnoczi
Now that VLANClientState has been renamed to NetClientState all 'vc' local variables should be 'nc'. Much of the code already used 'nc' but there are places where 'vc' needs to be renamed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/ne2000.h |4 +- hw/vhost_net.c

Re: [Qemu-devel] [PATCH 1/2] configure: Replace bash code by standard shell code

2012-07-20 Thread Peter Maydell
On 20 July 2012 13:28, Andreas Färber wrote: > Am 17.07.2012 21:19, schrieb Peter Maydell: >> On 17 July 2012 20:07, Stefan Weil wrote: >>> If the user overrides CFLAGS, I expect that he/she will notice >>> that compilation fails and hopefully find the cause (only >>> expert users should override

Re: [Qemu-devel] [PATCH 1/2] configure: Replace bash code by standard shell code

2012-07-20 Thread Andreas Färber
Am 17.07.2012 21:19, schrieb Peter Maydell: > On 17 July 2012 20:07, Stefan Weil wrote: >> If the user overrides CFLAGS, I expect that he/she will notice >> that compilation fails and hopefully find the cause (only >> expert users should override CFLAGS). Overriding -march=i486 >> might be useful

[Qemu-devel] [PATCH 04/16] hub: Check that hubs are configured correctly

2012-07-20 Thread Stefan Hajnoczi
Checks can be performed to make sure that hubs have at least one NIC and one host device, warning the user if this is not the case. Configurations which do not meet this rule tend to be broken but just emit a warning. This patch preserves compatibility with the checks performed by net core on vlan

[Qemu-devel] [PATCH 03/16] net: Look up 'vlan' net clients using hubs

2012-07-20 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- net.c | 28 +--- net/hub.c | 24 net/hub.h |2 ++ net/slirp.c |7 +-- 4 files changed, 32 insertions(+), 29 deletions(-) diff --git a/net.c b/net.c index f275

[Qemu-devel] [PATCH 09/16] net: Rename non_vlan_clients to net_clients

2012-07-20 Thread Stefan Hajnoczi
There is no longer a distinction between vlan clients and non-vlan clients in the net core. The net core only knows about point-to-point clients which are connected to a peer. It's time to rename the global list of net clients since it no longer refers to vlans at all. Signed-off-by: Stefan Hajn

[Qemu-devel] [PATCH 14/16] net: cleanup deliver/deliver_iov func pointers

2012-07-20 Thread Stefan Hajnoczi
From: Zhi Yong Wu Reviewed-by: Paolo Bonzini Signed-off-by: Zhi Yong Wu Signed-off-by: Stefan Hajnoczi --- net.c | 35 +++ net.h | 11 +++ net/queue.c | 13 - net/queue.h | 17 ++--- 4 files changed, 28 inse

[Qemu-devel] [PATCH 08/16] net: Remove VLANState

2012-07-20 Thread Stefan Hajnoczi
VLANState is no longer used and can be removed. Signed-off-by: Stefan Hajnoczi Signed-off-by: Zhi Yong Wu --- hw/dp8393x.c |1 - hw/exynos4_boards.c |2 +- hw/highbank.c|2 +- hw/integratorcp.c|2 +- hw/kzm.c |2 +- hw/mcf5208.c |

Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-20 Thread Paolo Bonzini
Il 20/07/2012 13:38, Daniel P. Berrange ha scritto: > There's two aspects to it. First we forbid use of malloc/free/realloc > in favour of an alternative set of APIs designed such that we can get > compile time errors when people don't check the result for NULL. > > > http://berrange.com/posts/

Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-20 Thread Daniel P. Berrange
On Thu, Jul 19, 2012 at 01:37:11PM +0200, Paolo Bonzini wrote: > Il 18/07/2012 17:35, Daniel P. Berrange ha scritto: > > Oh, and will this library depend on glib > > Yes, in all likelihood. > > , and will it have the > > abort-on-oom behaviour QEMU has ? From a libvirt POV, we won't > > use any l

[Qemu-devel] [PATCH 6/7] RTC: Do not fire timer periodically to catch next alarm

2012-07-20 Thread Paolo Bonzini
This patch limits further the usage of a periodic timer. It computes the time of the next alarm, and uses it to skip all intermediate occurrences of the timer. Cc: Yang Zhang Signed-off-by: Paolo Bonzini --- The patch from Yang had some problems, for example if the alarm was 9:X

  1   2   >