Re: [Qemu-devel] QEMU VNC Audio - All audio data null

2012-07-13 Thread agraham
On 07/14/2012 03:17 AM, agraham wrote: Hi Guys, I've written a VNC client that implements the VNC QEMU Audio extensions. Using QEMU 0.13 it works very very for remote sound, however after upgrading to QEMU 1.1.0 the audio stream contains only bytes of zeros, so this results in no sound on the cl

[Qemu-devel] In process NBD server

2012-07-13 Thread Eknath Venkataramani
Hello all, Has the GSoC 2012 project "In process NBD server" completed? If it hasn't, what would be a good way to pull out (only) files from a windows guest to the host machine, when the guest is in a stopped state? -- Eknath Venkataramani

Re: [Qemu-devel] [PATCHv4 07/14] unicore32-softmmu: Add puv3 soc/board support

2012-07-13 Thread guanxuetao
> 2012/7/13 Guan Xuetao : >> This patch only add puv3 soc/board support, which introduces puv3 >> machine description, and specifies console type. >> >> Signed-off-by: Guan Xuetao >> --- >> default-configs/unicore32-softmmu.mak |1 + >> hw/puv3.c | 93 >>

Re: [Qemu-devel] [PATCH] RFC: vfio-powerpc: added VFIO support (v3)

2012-07-13 Thread Alexey Kardashevskiy
On 14/07/12 01:07, Alex Williamson wrote: > On Fri, 2012-07-13 at 17:26 +1000, Alexey Kardashevskiy wrote: >> It literally does the following: >> >> 1. POWERPC IOMMU support (the kernel counterpart is required) >> >> 2. The patch assumes that IOAPIC calls are going to be replaced >> with something

[Qemu-devel] QEMU VNC Audio - All audio data null

2012-07-13 Thread agraham
Hi Guys, I've written a VNC client that implements the VNC QEMU Audio extensions. Using QEMU 0.13 it works very very for remote sound, however after upgrading to QEMU 1.1.0 the audio stream contains only bytes of zeros, so this results in no sound on the client. It is almost like the stream

Re: [Qemu-devel] [PATCH v2 05/17] qapi: introduce OptsVisitor

2012-07-13 Thread Laszlo Ersek
On 07/14/12 00:48, Laszlo Ersek wrote: > You're right. opts_do_parse() makes an exception with "id" and doesn't > call opt_set() for any occurrence of it. Would you accept the attached > fix, split up and squashed into previous parts appropriately? Sigh. I haven't looked at this code in a month,

Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-13 Thread Lluís Vilanova
Paolo Bonzini writes: > Il 13/07/2012 11:51, Paolo Bonzini ha scritto: >> Il 13/07/2012 11:16, Stefan Hajnoczi ha scritto: "Working around the QEMU block layer license" is not a goal per se, especially because you haven't a) assessed _what_ is the GPL code that the library would use

Re: [Qemu-devel] [PATCH v2 05/17] qapi: introduce OptsVisitor

2012-07-13 Thread Laszlo Ersek
On 07/13/12 18:51, Luiz Capitulino wrote: > On Wed, 13 Jun 2012 10:22:36 +0200 > Laszlo Ersek wrote: >> Repeating an optarg is supported; > > I see that the current code supports this too, but why? Something > like this should fail: > > -netdev type=tap,vhost=on,vhost=off,id=guest1,script=qemu-i

[Qemu-devel] [PATCH] SCSI: Fail medium writes with proper sense for readonly LUNs

2012-07-13 Thread Ronnie Sahlberg
Add sense code for DATA_PROTECT/WRITE_PROTECTED and return this error for any WRITE*/WRITE_VERIFY* calls if the device is readonly=on, i.e. write-protected Signed-off-by: Ronnie Sahlberg --- hw/scsi-bus.c |5 + hw/scsi-disk.c | 16 +--- hw/scsi.h |2 ++ 3 files ch

[Qemu-devel] [PATCH] SCSI: Make write commands fail if the device is readonly

2012-07-13 Thread Ronnie Sahlberg
List, Paolo Please find a patch that makes WRITE and WRITE_VERIFY fail with DATA_PROTECT/WRITE_PROTECTED sense code for devices that are write-protected via readonly=on Tests have been berformed to verify the functionality using : ./x86_64-softmmu/qemu-system-x86_64 -enable-kvm -m 128 -drive

[Qemu-devel] [PATCH 4/8] qemu-option: add alias support

2012-07-13 Thread Luiz Capitulino
Allow for specifying an alias for each option name, see next commits for examples. Signed-off-by: Luiz Capitulino --- qemu-option.c | 5 +++-- qemu-option.h | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 65ba1cf..b2f9e21 100644 --- a/qem

[Qemu-devel] [PATCH 3/8] qemu-option: qemu_opts_validate(): fix duplicated code

2012-07-13 Thread Luiz Capitulino
Use opts_accepts_any() and find_desc_by_name(). Signed-off-by: Luiz Capitulino --- qemu-option.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index d67e10f..65ba1cf 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -1060,23 +10

[Qemu-devel] [PATCH 1/8] qemu-option: qemu_opt_set_bool(): fix code duplication

2012-07-13 Thread Luiz Capitulino
Call qemu_opt_set() instead of duplicating opt_set(). Signed-off-by: Luiz Capitulino --- qemu-option.c | 28 +--- 1 file changed, 1 insertion(+), 27 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index bb3886c..2cb2835 100644 --- a/qemu-option.c +++ b/qemu-optio

[Qemu-devel] [PATCH 2/8] qemu-option: opt_set(): split it up into more functions

2012-07-13 Thread Luiz Capitulino
The new functions are opts_accepts_any() and find_desc_by_name(), which are also going to be used by qemu_opts_validate() (see next commit). This also makes opt_set() slightly more readable. --- qemu-option.c | 40 1 file changed, 24 insertions(+), 16 dele

[Qemu-devel] [PATCH 8/8] machine: rename dt_compatible to dt-compatible

2012-07-13 Thread Luiz Capitulino
QOM conversion wants option names with dashes. This commit does the change for the dt_compatible machine type option. The old option name is still supported through an option alias for backwards compatibility. Signed-off-by: Luiz Capitulino --- hw/ppce500_mpc8544ds.c | 2 +- qemu-config.c

[Qemu-devel] [PATCH 5/8] machine: rename kernel_irqchip to kernel-irqchip

2012-07-13 Thread Luiz Capitulino
QOM conversion wants option names with dashes. This commit does the change for the kernel_irqchip machine type option. The old option name is still supported through an option alias for backwards compatibility. Signed-off-by: Luiz Capitulino --- kvm-all.c | 2 +- qemu-config.c | 3 ++-

[Qemu-devel] [Bug 1018530] Re: No write access in a 9p/virtfs shared folder

2012-07-13 Thread Georg Poppe
Okay, it is working now. I am using the mapped security model but I wanted to avoid it at first. I hope proxy FS will be supported in quantal. But I am still wondering why passthrough security is working smoothly with NTFS-3G. -- You received this bug notification because you are a member of qe

[Qemu-devel] [PATCH v3] slirp: Handle whole 127.0.0.0/8 network as local addresses.

2012-07-13 Thread Anders Waldenborg
Changes so translation of remote address to the host's ip address in the virtual network happens for all addresses in the 127.0.0.0/8 network, not just 127.0.0.1. This fixes so that hostfwd bound to addresses such as 127.0.0.2 works. Signed-off-by: Anders Waldenborg --- On Fri, Jul 13, 2012 at

[Qemu-devel] [PATCH 7/8] machine: rename phandle_start to phandle-start

2012-07-13 Thread Luiz Capitulino
QOM conversion wants option names with dashes. This commit does the change for the phandle_start machine type option. The old option name is still supported through an option alias for backwards compatibility. Signed-off-by: Luiz Capitulino --- device_tree.c | 2 +- qemu-config.c | 3 ++- 2 fil

[Qemu-devel] [PATCH 6/8] machine: rename kvm_shadow_mem to kvm-shadow-mem

2012-07-13 Thread Luiz Capitulino
QOM conversion wants option names with dashes. This commit does the change for the kvm_shadow_mem machine type option. The old option name is still supported through an option alias for backwards compatibility. Signed-off-by: Luiz Capitulino --- qemu-config.c | 3 ++- qemu-options.hx | 4

[Qemu-devel] [PATCH v2 0/8]: rename machine options to use dashes

2012-07-13 Thread Luiz Capitulino
Today, machine options use underscores to separate words (eg. kernel_irqchip), however upcoming QOM conversion wants to use dashes instead. This series converts all machine type options to use dashes. Command-line backwards compatibility is maintained by adding an alias for each changed option. T

Re: [Qemu-devel] [PATCH v2 01/17] qapi: fix error propagation

2012-07-13 Thread Laszlo Ersek
On 07/13/12 21:11, Paolo Bonzini wrote: > Il 13/07/2012 19:30, Laszlo Ersek ha scritto: >> -if (errp == NULL) { >> +if (errp == NULL || *errp != NULL) { I think we should use assert() here. If the error is already set, that most probably indicates a bug in the >

Re: [Qemu-devel] [PATCH v2 00/17] introduce OptsVisitor, rebase -net/-netdev parsing

2012-07-13 Thread Laszlo Ersek
On 07/13/12 18:46, Luiz Capitulino wrote: > On Wed, 13 Jun 2012 10:22:31 +0200 > Laszlo Ersek wrote: > >> Inspired by [1], the first half of this series attempts to implement a new >> visitor that should clean up defining and processing command line options. >> For a more detailed description, pl

Re: [Qemu-devel] [PATCH v2 01/17] qapi: fix error propagation

2012-07-13 Thread Paolo Bonzini
Il 13/07/2012 19:30, Laszlo Ersek ha scritto: >>> >> -if (errp == NULL) { >>> >> +if (errp == NULL || *errp != NULL) { >> > >> > I think we should use assert() here. >> > >> > If the error is already set, that most probably indicates a bug in the >> > caller, as >> > it's the caller's re

Re: [Qemu-devel] [QEMU RFC PATCH 6/7] i386: topology & APIC ID utility functions

2012-07-13 Thread Eduardo Habkost
On Thu, Jul 12, 2012 at 07:37:26PM +, Blue Swirl wrote: > On Tue, Jul 10, 2012 at 8:22 PM, Eduardo Habkost wrote: [...] > > +#ifndef __QEMU_X86_TOPOLOGY_H__ > > +#define __QEMU_X86_TOPOLOGY_H__ > > Please remove the leading and trailing underscores. The name should > match the path, so it sho

[Qemu-devel] VM crashed after migration.

2012-07-13 Thread Ma, Stephen B.
Hello, Sometimes I am seeing my VM crash immediately after it has been migrated to a new host. The VM is running RHEL6.2 with the following devices: The VM has the following devices: [root@vmdev51 ~]# lspci 00:00.0 Host bridge: Intel Corporation 440FX - 82441FX PMC [Natoma] (rev 02) 00:01.0 ISA

Re: [Qemu-devel] [QEMU RFC PATCH 5/7] pc: write lapic info (apic IDs) to fw_cfg so seabios can use it

2012-07-13 Thread Eduardo Habkost
On Thu, Jul 12, 2012 at 07:29:02PM +, Blue Swirl wrote: [...] > CODING_STYLE requires CamelCase, also below. > [...] > > +struct lapic_info_table *lapic_table = g_malloc0(lapic_info_size);; > > ;-- > > > +lapic_table->count = max_cpus; > > +for (i = 0; i < max_cpus; i++) { > > +

Re: [Qemu-devel] [QEMU PATCH 2/7] hw/apic.c: rename bit functions to not conflict with bitops.h

2012-07-13 Thread Eduardo Habkost
On Thu, Jul 12, 2012 at 07:24:35PM +, Blue Swirl wrote: > On Tue, Jul 10, 2012 at 8:22 PM, Eduardo Habkost wrote: > > Signed-off-by: Eduardo Habkost > > Maybe the bitops functions should be renamed instead, for example > prefixed by 'qemu_'. That may be safer if one day the kernel find > the

Re: [Qemu-devel] [RFC PATCH v2 00/21] ACPI memory hotplug

2012-07-13 Thread Vasilis Liaskovitis
On Thu, Jul 12, 2012 at 08:04:56PM +, Blue Swirl wrote: > On Wed, Jul 11, 2012 at 10:31 AM, Vasilis Liaskovitis > wrote: > > This is v2 of the ACPI memory hotplug prototype for x86_64 target. > > I think the concept of DIMMs (what about SIMMs? SODIMMs? I liked > memslot) would be useful for m

Re: [Qemu-devel] [RFC PATCH v2 09/21] pc: Add dimm paravirt SRAT info

2012-07-13 Thread Vasilis Liaskovitis
On Thu, Jul 12, 2012 at 07:48:04PM +, Blue Swirl wrote: > On Wed, Jul 11, 2012 at 10:31 AM, Vasilis Liaskovitis > wrote: > > The numa_fw_cfg paravirt interface is extended to include SRAT information > > for > > all hotplug-able dimms. There are 3 words for each hotplug-able memory slot, > >

Re: [Qemu-devel] [RFC PATCH v2 06/21] dimm: Implement memory device abstraction

2012-07-13 Thread Vasilis Liaskovitis
Hi, On Thu, Jul 12, 2012 at 07:55:42PM +, Blue Swirl wrote: > On Wed, Jul 11, 2012 at 10:31 AM, Vasilis Liaskovitis > wrote: > > Each hotplug-able memory slot is a SysBusDevice. A hot-add operation for a > > particular dimm creates a new MemoryRegion of the given physical address > > offset,

Re: [Qemu-devel] [PATCH v2 01/17] qapi: fix error propagation

2012-07-13 Thread Laszlo Ersek
On 07/13/12 18:38, Luiz Capitulino wrote: > On Wed, 13 Jun 2012 10:22:32 +0200 > Laszlo Ersek wrote: > >> From: Paolo Bonzini >> >> Don't overwrite / leak previously set errors. > > Can you elaborate a bit more? It's not clear to me where the bug is. Suppose you encounter the first error on th

Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-13 Thread Stefan Weil
Am 13.07.2012 13:33, schrieb Paolo Bonzini: Il 13/07/2012 11:51, Paolo Bonzini ha scritto: Il 13/07/2012 11:16, Stefan Hajnoczi ha scritto: "Working around the QEMU block layer license" is not a goal per se, especially because you haven't a) assessed _what_ is the GPL code that the library woul

Re: [Qemu-devel] [PATCH v2 05/17] qapi: introduce OptsVisitor

2012-07-13 Thread Luiz Capitulino
On Wed, 13 Jun 2012 10:22:36 +0200 Laszlo Ersek wrote: > This visitor supports parsing > > -option [type=]discriminator[,optarg1=val1][,optarg2=val2][,...] > > style QemuOpts objects into "native" C structures. After defining the type > tree in the qapi schema (see below), a root type travers

[Qemu-devel] [PATCH 3/3] qapi: Convert getfd and closefd

2012-07-13 Thread Luiz Capitulino
From: Corey Bryant Signed-off-by: Corey Bryant Signed-off-by: Luiz Capitulino --- hmp-commands.hx | 6 ++ hmp.c| 18 ++ hmp.h| 2 ++ monitor.c| 32 ++-- qapi-schema.json | 35 +++

[Qemu-devel] [PATCH 2/3] qapi: input_type_enum(): fix error message

2012-07-13 Thread Luiz Capitulino
The enum string is pointed to by 'enum_str' not 'name'. This bug causes the error message to be: { "error": { "class": "InvalidParameter", "desc": "Invalid parameter 'null'", "data": { "name": "null" } } } Signed-off-by: Luiz Capitulino Reviewed-by: Amos Kong --- qapi

[Qemu-devel] [PATCH 1/3] qmp: dump-guest-memory: improve schema doc

2012-07-13 Thread Luiz Capitulino
Clarify a few points and makes it looks more like the other commands' documentation. Signed-off-by: Luiz Capitulino --- qapi-schema.json | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 1ab5dbd..52524

[Qemu-devel] [PULL 0/3]: QMP queue

2012-07-13 Thread Luiz Capitulino
Three little patches. Two fixes from me and a qapi conversion form Corey. The changes (since c0958559b1a589a0d189c45ea1adaa6b345f4256) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Corey Bryant (1): qapi: Convert getfd and closefd Luiz Cap

Re: [Qemu-devel] [PATCH v2 00/17] introduce OptsVisitor, rebase -net/-netdev parsing

2012-07-13 Thread Luiz Capitulino
On Wed, 13 Jun 2012 10:22:31 +0200 Laszlo Ersek wrote: > Inspired by [1], the first half of this series attempts to implement a new > visitor that should clean up defining and processing command line options. > For a more detailed description, please see "[PATCH 05/17] qapi: introduce > OptsVisit

Re: [Qemu-devel] [PATCH 2/6] s390: sclp base support

2012-07-13 Thread Christian Borntraeger
Thanks fpr the review, On 13/07/12 17:08, Blue Swirl wrote: >> + * Copyright IBM, Corp. 2007, 2012 > > 2007, really? Well, yes and no. The first userspace for kvm on s390 was kuli and some of that code was used for bringup. But it looks pretty different now, so we can change that to be 2012 as

Re: [Qemu-devel] [PATCH v2 01/17] qapi: fix error propagation

2012-07-13 Thread Luiz Capitulino
On Wed, 13 Jun 2012 10:22:32 +0200 Laszlo Ersek wrote: > From: Paolo Bonzini > > Don't overwrite / leak previously set errors. Can you elaborate a bit more? It's not clear to me where the bug is. More comments below. > Don't try to end a container that could not be started. > > Signed-off-b

Re: [Qemu-devel] [PATCH v2 1/2] coroutine-ucontext: Help valgrind understand coroutines

2012-07-13 Thread Kevin Wolf
Am 13.07.2012 18:13, schrieb Eric Blake: > On 07/13/2012 10:06 AM, Kevin Wolf wrote: >> Am 13.07.2012 17:37, schrieb Peter Maydell: >>> On 13 July 2012 16:31, Kevin Wolf wrote: +#ifdef CONFIG_VALGRIND_H +/* Work around an unused variable in the valgrind.h macro... */ +#pragma GCC di

Re: [Qemu-devel] [PATCH v2 1/2] coroutine-ucontext: Help valgrind understand coroutines

2012-07-13 Thread Eric Blake
On 07/13/2012 10:06 AM, Kevin Wolf wrote: > Am 13.07.2012 17:37, schrieb Peter Maydell: >> On 13 July 2012 16:31, Kevin Wolf wrote: >>> +#ifdef CONFIG_VALGRIND_H >>> +/* Work around an unused variable in the valgrind.h macro... */ >>> +#pragma GCC diagnostic ignored "-Wunused-but-set-variable" >>>

Re: [Qemu-devel] [PATCH v2 1/2] coroutine-ucontext: Help valgrind understand coroutines

2012-07-13 Thread Kevin Wolf
Am 13.07.2012 17:37, schrieb Peter Maydell: > On 13 July 2012 16:31, Kevin Wolf wrote: >> +#ifdef CONFIG_VALGRIND_H >> +/* Work around an unused variable in the valgrind.h macro... */ >> +#pragma GCC diagnostic ignored "-Wunused-but-set-variable" >> +static inline void valgrind_stack_deregister(Co

Re: [Qemu-devel] [PATCH v2 1/2] coroutine-ucontext: Help valgrind understand coroutines

2012-07-13 Thread Peter Maydell
On 13 July 2012 16:31, Kevin Wolf wrote: > +#ifdef CONFIG_VALGRIND_H > +/* Work around an unused variable in the valgrind.h macro... */ > +#pragma GCC diagnostic ignored "-Wunused-but-set-variable" > +static inline void valgrind_stack_deregister(CoroutineUContext *co) > +{ > +VALGRIND_STACK_DE

[Qemu-devel] [PATCH v2 1/2] coroutine-ucontext: Help valgrind understand coroutines

2012-07-13 Thread Kevin Wolf
valgrind tends to get confused and report false positives when you switch stacks and don't tell it about it. Signed-off-by: Kevin Wolf Reviewed-by: Paolo Bonzini --- v2: - Use unsigned for the stack ID - Older gccs don't know #pragma diagnostic push/pop, so replace them by explicitly switchin

Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-13 Thread Blue Swirl
On Fri, Jul 13, 2012 at 11:33 AM, Paolo Bonzini wrote: > Il 13/07/2012 11:51, Paolo Bonzini ha scritto: >> Il 13/07/2012 11:16, Stefan Hajnoczi ha scritto: "Working around the QEMU block layer license" is not a goal per se, especially because you haven't a) assessed _what_ is the GPL cod

Re: [Qemu-devel] [PATCH] net: Add interface to bridge when SIOCBRADDIF isn't available

2012-07-13 Thread Fabien Chouteau
On 07/12/2012 03:24 PM, Corey Bryant wrote: > The bridge helper uses the SIOCBRADDIF ioctl to add an inteface to > a bridge. SIOCBRADDIF is not available on old Linux versions. This > patch adds support to use the SIOCDEVPRIVATE ioctl with BRCTL_ADD_IF > if SIOCBRADDIF is not available. > I don

Re: [Qemu-devel] [PATCH 3/6] s390: sclp event support

2012-07-13 Thread Blue Swirl
On Fri, Jul 13, 2012 at 10:52 AM, Christian Borntraeger wrote: > From: Heinz Graalfs > > Several SCLP features are considered to be events. Those events don't > provide SCLP commands on their own, instead they are all based on > Read Event Data, Write Event Data, Write Event Mask and the service

Re: [Qemu-devel] [PATCH 2/6] s390: sclp base support

2012-07-13 Thread Blue Swirl
On Fri, Jul 13, 2012 at 10:52 AM, Christian Borntraeger wrote: > From: Heinz Graalfs > > This adds a more generic infrastructure for handling Service-Call > requests on s390. Currently we only support a small subset of Read > SCP Info directly in target-s390x. This patch provides the base > infra

Re: [Qemu-devel] [PATCH] RFC: vfio-powerpc: added VFIO support (v3)

2012-07-13 Thread Alex Williamson
On Fri, 2012-07-13 at 17:26 +1000, Alexey Kardashevskiy wrote: > It literally does the following: > > 1. POWERPC IOMMU support (the kernel counterpart is required) > > 2. The patch assumes that IOAPIC calls are going to be replaced > with something generic. > > 3. vfio_group_iommu_ioctl() has be

[Qemu-devel] [Bug 882997] Re: 64-bit linux guests fail to start on oneiric running 3.0 kernel

2012-07-13 Thread Serge Hallyn
*** This bug is a duplicate of bug 997311 *** https://bugs.launchpad.net/bugs/997311 ** Changed in: qemu-kvm (Ubuntu) Status: Incomplete => Confirmed ** This bug has been marked a duplicate of bug 997311 Problem when you run a SLES10 in QEMU/KVM -- You received this bug notificati

Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-13 Thread Michael Tokarev
On 13.07.2012 15:33, Paolo Bonzini wrote: [] > So I tried trimming down the list of files needed to compile > qemu tools, and here is a list: > > Easy to relicense to LGPLv2+: > block/raw.c none (GPLv2+: Red Hat, IBM) > error.c LGPLv2 (Red Hat, IBM, Stef

Re: [Qemu-devel] [PATCH v2] slirp: Handle whole 127.0.0.0/8 network as local addresses.

2012-07-13 Thread Blue Swirl
On Fri, Jul 13, 2012 at 10:37 AM, Anders Waldenborg wrote: > Changes so translation of remote address to the host's ip address in > the virtual network happens for all addresses in the 127.0.0.0/8 > network, not just 127.0.0.1. > > This fixes so that hostfwd bound to addresses such as 127.0.0.2 wo

Re: [Qemu-devel] [PATCH 1/5] Avoid GCC extension ?:

2012-07-13 Thread Blue Swirl
On Fri, Jul 13, 2012 at 9:05 AM, Kevin Wolf wrote: > Am 12.07.2012 22:28, schrieb Blue Swirl: >> On Wed, Jul 11, 2012 at 12:54 PM, Kevin Wolf wrote: >>> Am 08.07.2012 14:09, schrieb Andreas Schwab: blauwir...@gmail.com writes: > +pstrcpy(bs->backing_format, sizeof(bs->backing_fo

Re: [Qemu-devel] [PATCH 1/5] Avoid GCC extension ?:

2012-07-13 Thread Blue Swirl
On Thu, Jul 12, 2012 at 9:08 PM, Peter Maydell wrote: > On 12 July 2012 21:28, Blue Swirl wrote: >> On Wed, Jul 11, 2012 at 12:54 PM, Kevin Wolf wrote: >>> Am 08.07.2012 14:09, schrieb Andreas Schwab: >>> Which is why such changes are probably a bad idea. Even more so if they >>> aren't scripted

Re: [Qemu-devel] [PATCH] RFC: vfio-powerpc: added VFIO support (v3)

2012-07-13 Thread Blue Swirl
On Fri, Jul 13, 2012 at 7:26 AM, Alexey Kardashevskiy wrote: > It literally does the following: > > 1. POWERPC IOMMU support (the kernel counterpart is required) > > 2. The patch assumes that IOAPIC calls are going to be replaced > with something generic. > > 3. vfio_group_iommu_ioctl() has been a

Re: [Qemu-devel] [Qemu-ppc] [PATCH] RFC: vfio-powerpc: added VFIO support (v2)

2012-07-13 Thread Blue Swirl
On Fri, Jul 13, 2012 at 5:24 AM, Alexey Kardashevskiy wrote: > Two comments below. > > On 13/07/12 06:54, Blue Swirl wrote: >> On Thu, Jul 12, 2012 at 8:52 AM, Alexey Kardashevskiy wrote: >>> It literally does the following: >>> >>> 1. POWERPC IOMMU support (the kernel counterpart is required) >>

Re: [Qemu-devel] [PATCH 2/3] target-arm: kvm: use KVM_GET_MSRS/KVM_SET_MSRS for CP15 registers.

2012-07-13 Thread Blue Swirl
On Fri, Jul 13, 2012 at 3:43 AM, Rusty Russell wrote: > Recent kernels use this to set the CP15 registers, rather than putting > them in 'struct kvm_regs'. The changed size of that struct changes the > ioctl number, so we have a temporary hack to try both. > > Signed-off-by: Rusty Russell > > di

Re: [Qemu-devel] [PATCHv4 07/14] unicore32-softmmu: Add puv3 soc/board support

2012-07-13 Thread Dunrong Huang
2012/7/13 Guan Xuetao : > This patch only add puv3 soc/board support, which introduces puv3 > machine description, and specifies console type. > > Signed-off-by: Guan Xuetao > --- > default-configs/unicore32-softmmu.mak |1 + > hw/puv3.c | 93 > +

[Qemu-devel] [Bug 1024275] Re: bad iteraction between -daemonize and -nographic

2012-07-13 Thread Bug Watch Updater
** Changed in: qemu (Debian) Status: Unknown => New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1024275 Title: bad iteraction between -daemonize and -nographic Status in QEMU: Confirmed

[Qemu-devel] [Bug 1024275] Re: bad iteraction between -daemonize and -nographic

2012-07-13 Thread Michael Tokarev
FWIW, it has been present at least since version 0.10 of qemu, and still present in current 1.1 version. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1024275 Title: bad iteraction between -daemoni

[Qemu-devel] [Bug 1024275] [NEW] bad iteraction between -daemonize and -nographic

2012-07-13 Thread Michael Tokarev
Public bug reported: $ qemu -daemonize -nographic $ _ After this, the terminal is switched to some weird mode, not processing cr/lf, and not showing the characters being typed (it is fixable by using `stty sane'). Something is seriously wrong here: When -daemonize is given, qemu not touch tty

Re: [Qemu-devel] invoking monitor command without Ctrl+Alt+2

2012-07-13 Thread Eric Blake
On 07/12/2012 10:14 PM, siddharth srivastava wrote: > Hi > > I also see that qemu 0.13 has live migration in inbuilt.Does it also > uses libvirt behind the scenes to create live ram snapshot ? No, you've got it backwards. Qemu does not use libvirt. Rather, libvirt wraps qemu features to expose

[Qemu-devel] [PATCHv4 00/14] unicore32: Add unicore32-softmmu support

2012-07-13 Thread Guan Xuetao
These patches implement softmmu support on unicore32 architecture. Based on master branch of qemu, the patches can be fetched from: git://github.com/gxt/QEMU.git unicore32 UniCore32 CPU is embedded in PKUnity-3 SoC, so we add necessary puv3 devices simulation codes together. Only minimal syste

[Qemu-devel] [PATCHv4 02/14] unicore32-softmmu: Add coprocessor 0(sysctrl) and 1(ocd) instruction support

2012-07-13 Thread Guan Xuetao
Coprocessor 0 is system control coprocessor, and we need get/set its contents. Also, all cache/tlb ops shoule be implemented here, but just ignored with no harm. Coprocessor 1 is OCD (on-chip-debugger), which is used for faked console, so we could output chars to this console without graphic card

Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-13 Thread Paolo Bonzini
Il 13/07/2012 11:51, Paolo Bonzini ha scritto: > Il 13/07/2012 11:16, Stefan Hajnoczi ha scritto: >>> "Working around the QEMU block layer license" is not a goal per se, >>> especially because you haven't a) assessed _what_ is the GPL code that >>> the library would use; b) told us why the library

[Qemu-devel] [PATCHv4 08/14] unicore32-softmmu: Add puv3 interrupt support

2012-07-13 Thread Guan Xuetao
This patch adds puv3 interrupt support, include interrupt controler device simulation and interrupt handler in puv3 machine. Signed-off-by: Guan Xuetao --- hw/Makefile.objs |3 + hw/puv3.c| 23 +- hw/puv3_intc.c | 135 +

[Qemu-devel] [PATCHv4 14/14] unicore32-softmmu: Add maintainer information for UniCore32 machine

2012-07-13 Thread Guan Xuetao
Signed-off-by: Guan Xuetao --- MAINTAINERS |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 30ed56d..35dbbad 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -405,6 +405,14 @@ M: Alexander Graf S: Maintained F: hw/s390-*.c +UniCore3

[Qemu-devel] [PATCHv4 01/14] unicore32-softmmu: Add unicore32-softmmu build support

2012-07-13 Thread Guan Xuetao
This patch adds unicore32-softmmu build support, include configure, makefile, arch_init, and all missing functions needed by softmmu. Although all missing functions are empty, unicore32-softmmu could be build successfully. Signed-off-by: Guan Xuetao --- arch_init.c |

[Qemu-devel] [PATCHv4 12/14] unicore32-softmmu: Add puv3 dma support

2012-07-13 Thread Guan Xuetao
This patch adds puv3 dma (Direct Memory Access) support, include dma device simulation for kernel booting. Signed-off-by: Guan Xuetao --- hw/Makefile.objs |1 + hw/puv3.c|1 + hw/puv3_dma.c| 109 ++ 3 files changed, 111 ins

[Qemu-devel] [PATCHv4 07/14] unicore32-softmmu: Add puv3 soc/board support

2012-07-13 Thread Guan Xuetao
This patch only add puv3 soc/board support, which introduces puv3 machine description, and specifies console type. Signed-off-by: Guan Xuetao --- default-configs/unicore32-softmmu.mak |1 + hw/puv3.c | 93 + hw/puv3.h

[Qemu-devel] [PATCHv4 06/14] unicore32-softmmu: Make sure that kernel can access user space

2012-07-13 Thread Guan Xuetao
As a matter of course, we need to access user space in kernel code, so we need to correct load/store decoders to indicate correct memory region. Signed-off-by: Guan Xuetao --- target-unicore32/translate.c | 36 ++-- 1 files changed, 26 insertions(+), 10 deletion

[Qemu-devel] [PATCHv4 03/14] unicore32-softmmu: Make UniCore32 cpuid & exceptions correct and runable

2012-07-13 Thread Guan Xuetao
This patch initializes the cpuid to exactly correct value because linux kernel will check it. In addition, the exception types are specified in proper situations. Then it could make exceptions generated correctly and timely. Signed-off-by: Guan Xuetao --- cpu-exec.c |1 + linux-u

Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-13 Thread Kevin Wolf
Am 13.07.2012 12:55, schrieb Christoph Hellwig: > On Fri, Jul 13, 2012 at 12:42:41PM +0200, Kevin Wolf wrote: >> It still feels a bit more like qemu-io-style operations. Not sure what >> your use case looks like exactly, but adding a qemu-io command that >> reads data from a file and writes it at a

[Qemu-devel] [PATCHv4 10/14] unicore32-softmmu: Add puv3 gpio support

2012-07-13 Thread Guan Xuetao
This patch adds puv3 gpio (General Purpose Input/Output) support, include gpio device simulation and its interrupt support. Signed-off-by: Guan Xuetao --- hw/Makefile.objs |1 + hw/puv3.c|6 ++ hw/puv3_gpio.c | 141 ++ 3 file

[Qemu-devel] [PATCHv4 09/14] unicore32-softmmu: Add puv3 ostimer support

2012-07-13 Thread Guan Xuetao
This patch adds puv3 ostimer support, include os timer device simulation and ptimer support in puv3 machine. Signed-off-by: Guan Xuetao --- default-configs/unicore32-softmmu.mak |1 + hw/Makefile.objs |1 + hw/puv3.c |3 + hw/puv3_ost.

[Qemu-devel] [PATCHv4 13/14] unicore32-softmmu: Add ps2 support

2012-07-13 Thread Guan Xuetao
This patch adds ps2/keyboard support, and enables CONFIG_PCKBD. Signed-off-by: Guan Xuetao --- default-configs/unicore32-softmmu.mak |1 + hw/puv3.c |5 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/default-configs/unicore32-softmmu.mak

[Qemu-devel] [PATCHv4 05/14] unicore32-softmmu: Implement softmmu specific functions

2012-07-13 Thread Guan Xuetao
This patch implements softmmu specific functions, include tlb_fill, switch_mode, do_interrupt and uc32_cpu_handle_mmu_fault. So the full exception handlers and page table walking could work now. Signed-off-by: Guan Xuetao --- target-unicore32/op_helper.c | 22 - target-unicore32/softmmu.c

[Qemu-devel] [PATCHv4 11/14] unicore32-softmmu: Add puv3 pm support

2012-07-13 Thread Guan Xuetao
This patch adds puv3 pm (power management) support, include pm device simulation for kernel booting. Thank Blue Swirl for pointing out the missing "break". Signed-off-by: Guan Xuetao --- hw/Makefile.objs |1 + hw/puv3.c|1 + hw/puv3_pm.c | 149 +++

[Qemu-devel] [PATCHv4 04/14] target-unicore32: Drop UC32_CPUID macros

2012-07-13 Thread Guan Xuetao
From: Andreas Färber Any code that depends on a particular CPU type can now go through callbacks on the QOM UniCore32CPUClass. Signed-off-by: Andreas Färber --- target-unicore32/cpu.h |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/target-unicore32/cpu.h b/target-un

[Qemu-devel] [PULL 0/5] Trivial patches for July 3 to 13 2012

2012-07-13 Thread Stefan Hajnoczi
The following changes since commit c0958559b1a589a0d189c45ea1adaa6b345f4256: iov: Fix do_send_recv() for MinGW (also fixes a build breakage) (2012-07-11 08:51:50 -0500) are available in the git repository at: git://github.com/stefanha/qemu.git trivial-patches for you to fetch changes up to

Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-13 Thread Christoph Hellwig
On Fri, Jul 13, 2012 at 12:42:41PM +0200, Kevin Wolf wrote: > It still feels a bit more like qemu-io-style operations. Not sure what > your use case looks like exactly, but adding a qemu-io command that > reads data from a file and writes it at a given offset into the images > (or vice versa) shoul

[Qemu-devel] [PATCH 0/6v2] s390: several sclp patches

2012-07-13 Thread Christian Borntraeger
This patch-set improve the Service-Call Logical Processor support for s390. We tried to implement most of the comments that we got from the first patch review. We still have code in hw/ since sclp supports features like console etc. target-s390/op_helper.c now handles the basic checks for the inst

[Qemu-devel] [PATCH 2/6] s390: sclp base support

2012-07-13 Thread Christian Borntraeger
From: Heinz Graalfs This adds a more generic infrastructure for handling Service-Call requests on s390. Currently we only support a small subset of Read SCP Info directly in target-s390x. This patch provides the base infrastructure for supporting more commands and moves Read SCP Info. In the futu

[Qemu-devel] [PATCH 4/6] s390: sclp signal quiesce support

2012-07-13 Thread Christian Borntraeger
From: Heinz Graalfs This implements the sclp signal quiesce event via the SCLP Event Facility. This allows to gracefully shutdown a guest by using system_powerdown. It creates a service interrupt that will trigger a Read Event Data command from the guest. This code will then add an event that is

[Qemu-devel] [PATCH 3/6] s390: sclp event support

2012-07-13 Thread Christian Borntraeger
From: Heinz Graalfs Several SCLP features are considered to be events. Those events don't provide SCLP commands on their own, instead they are all based on Read Event Data, Write Event Data, Write Event Mask and the service interrupt. Follow-on patches will provide SCLP's Signal Quiesce (via syst

[Qemu-devel] [PATCH 5/6] s390: sclp ascii console support

2012-07-13 Thread Christian Borntraeger
From: Heinz Graalfs This code adds console support by implementing SCLP's ASCII Console Data event. This is the same console as LPARs ASCII console or z/VMs sysascii. When data is received from the character layer it creates a service interrupt to trigger a Read Event Data command from the gues

[Qemu-devel] [PATCH 1/6] s390: Fix error handling and condition code of service call

2012-07-13 Thread Christian Borntraeger
Invalid sccb addresses will cause specification or addressing exception. Lets add those checks. Furthermore, the good case (cc=0) was incorrect for KVM, we did not set the CC at all. Signed-off-by: Christian Borntraeger --- target-s390x/kvm.c |5 +++-- target-s390x/op_helper.c | 27 +

[Qemu-devel] [PATCH 6/6] s390: make sclp ascii console the default

2012-07-13 Thread Christian Borntraeger
This patch makes the sclp ascii default for S390. Signed-off-by: Christian Borntraeger --- hw/s390-virtio.c |1 - vl.c | 40 2 files changed, 40 insertions(+), 1 deletion(-) diff --git a/hw/s390-virtio.c b/hw/s390-virtio.c index 577fcee

[Qemu-devel] [PATCH 2/5] bitops: Fix documentation

2012-07-13 Thread Stefan Hajnoczi
From: Stefan Weil Signed-off-by: Stefan Weil Reviewed-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- bitops.h |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/bitops.h b/bitops.h index b967ef3..c456232 100644 --- a/bitops.h +++ b/bitops.h @@ -319,8 +319,8 @

[Qemu-devel] [PATCH 5/5] make: Remove 'build-all' rule

2012-07-13 Thread Stefan Hajnoczi
From: Stefan Weil It is not needed, because the 'all' rule does the same. Signed-off-by: Stefan Weil Signed-off-by: Stefan Hajnoczi --- Makefile |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 34d6a9e..6eeabd0 100644 --- a/Makefile +++ b/

Re: [Qemu-devel] [RFC] introduce a dynamic library to expose qemu block API

2012-07-13 Thread Kevin Wolf
Am 13.07.2012 11:43, schrieb Stefan Hajnoczi: > On Fri, Jul 13, 2012 at 11:27:55AM +0200, Christoph Hellwig wrote: >> On Fri, Jul 13, 2012 at 10:13:15AM +0100, Stefan Hajnoczi wrote: >>> How is that different from all the qemu-io commands? >> >> qemu-io has no modes to just dumb the output without

[Qemu-devel] [PATCH 4/5] qemu-keymaps: Finnish keyboard mapping broken

2012-07-13 Thread Stefan Hajnoczi
From: Michael Tokarev As mentioned in http://bugs.debian.org/660154 , finnish keyboard mapping is kind of broken. Fix it as Timo Sirainen suggests in #660154. Signed-off-by: Michael Tokarev Signed-off-by: Stefan Hajnoczi --- pc-bios/keymaps/fi |2 -- 1 file changed, 2 deletions(-) diff

[Qemu-devel] [PATCH 1/5] megasas: mark mfi_frame_desc as 'static'

2012-07-13 Thread Stefan Hajnoczi
From: Hannes Reinecke Suggested by blue swirl. Patch is on top of Paolo's scsi-next tree. Signed-off-by: Hannes Reinecke Cc: Paolo Bonzini Cc: Blue Swirl Signed-off-by: Stefan Hajnoczi --- hw/megasas.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/megasas.c b/hw/

[Qemu-devel] [PATCH 3/5] vnc: add a more descriptive error message

2012-07-13 Thread Stefan Hajnoczi
From: Amos Kong Currently qemu outputs some low-level error in qemu-sockets.c when failed to start vnc server. eg. 'getaddrinfo(127.0.0.1,5902): Name or service not known' Some libvirt users could not know what's happened with this unclear error message. This patch added a more descriptive error

[Qemu-devel] [PATCH v2] slirp: Handle whole 127.0.0.0/8 network as local addresses.

2012-07-13 Thread Anders Waldenborg
Changes so translation of remote address to the host's ip address in the virtual network happens for all addresses in the 127.0.0.0/8 network, not just 127.0.0.1. This fixes so that hostfwd bound to addresses such as 127.0.0.2 works. Signed-off-by: Anders Waldenborg --- Thanks for the review!

[Qemu-devel] [PATCH 2/2] usb-storage: fix SYNCHRONIZE_CACHE

2012-07-13 Thread Gerd Hoffmann
Commit 59310659073d85745854f2f10c4292555c5a1c51 is incomplete, we'll arrive in the scsi command complete callback in CSW state and must handle that case correctly. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-storage.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/hw/

[Qemu-devel] [PATCH 1/2] usb-storage: improve debug logging

2012-07-13 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/usb/dev-storage.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index 251e7de..f1d8082 100644 --- a/hw/usb/dev-storage.c +++ b/hw/usb/dev-storage.c @@ -383,6 +383,9 @@ static int usb_

Re: [Qemu-devel] Ask for help with estimate of disassembly speed

2012-07-13 Thread Peter Maydell
On 12 July 2012 16:30, Евгений Олегович wrote: > We will be very glad and grateful, if You can send to us pure DisAsm code > (DLL with parse function or another files), which speed we can measure. If > You have another materials(maybe any speed grafics, or a tests set that can > help us) or thinki

  1   2   >