Public bug reported:
Sorry for doing this, but QEMU should support text mode cursor blinking.
** Affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.ne
Blue Swirl writes:
> On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster wrote:
>> Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible,
>> except it was put into block.c. Device-specific functionality should
>> be kept in device code, not the block layer. Move it to
>> hw/hd-geomet
Blue Swirl writes:
> On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster wrote:
>> So far covers only IDE and tests only CMOS contents.
>>
>> Signed-off-by: Markus Armbruster
>> ---
>> tests/Makefile | 2 +
>> tests/hd-geo-test.c | 402
>> ++
Blue Swirl writes:
> On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster wrote:
>> Unless parameter ":floppy:" is given, vvfat creates a virtual image
>> with DOS MBR defining a single partition which holds the FAT file
>> system. The size of the virtual image depends on the width of the
>> FAT:
2012/6/30 Stefan Weil :
> commit c4baa0503d9623f1ce891f525ccd140c598bc29a improved SSE table
> type safety which now raises compiler errors when latest QEMU was
> configured with --enable-debug.
>
> Fix this by splitting the SSE tables even further to separate
> helper functions with different sign
From: Amos Kong
Currently qemu outputs some low-level error in qemu-sockets.c
when failed to start vnc server.
eg. 'getaddrinfo(127.0.0.1,5902): Name or service not known'
Some libvirt users could not know what's happened with this
unclear error message. This patch added a more descriptive
error
From: Amos Kong
Currently qemu would some low-level error in qemu-sockets.c
when failed to start vnc server.
eg. 'getaddrinfo(127.0.0.1,5902): Name or service not known'
This patch added a more descriptive error message.
Signed-off-by: Amos Kong
---
vl.c |5 -
1 file changed, 4 insert
On 06/30/2012 01:40 AM, Luiz Capitulino wrote:
> The enum string is pointed to by 'enum_str' not 'name'. This bug
> causes the error message to be:
>
> { "error": { "class": "InvalidParameter",
> "desc": "Invalid parameter 'null'",
> "data": { "name": "null" } } }
>
> Si
Hi Igor,
Are you able to make these changes you have negotiated with PMM? If
you send me an interdiff that fine, or an incremental patch thats fine
- I can remake the series with your changes rolled in.
Regards,
Peter
On Sat, Jun 30, 2012 at 1:22 AM, Igor Mitsyanko wrote:
> On 06/29/2012 07:01
On Mon, Jun 25, 2012 at 09:40:39AM -0600, Alex Williamson wrote:
> Anyone using these functions has to be prepared that irqchip
> support may not be present. It shouldn't be up to the core
> code to determine whether this is a fatal error. Currently
> code written as:
>
> virq = kvm_irqchip_add_
Am 29.06.2012 22:38, schrieb Stefan Weil:
> commit c4baa0503d9623f1ce891f525ccd140c598bc29a improved SSE table
> type safety which now raises compiler errors when latest QEMU was
> configured with --enable-debug.
>
> Fix this by splitting the SSE tables even further to separate
> helper functions
From: Scott Wood
Currently the only mpc8544ds-ism that is factored out is
toplevel compatible and model. In the future the generic e500
code is expected to become more generic.
Signed-off-by: Scott Wood
---
Patch 3/4 of the series didn't make it to the list archives or patchwork
despite sendin
Hi all,
I'm trying to edit the qemu source code so I can use qemu as a profiler for
a benchmark of ARM programs. A good start would be counting loads, stores,
int ops, float ops and branch instructions used by each of the binary
files. I have two (related) questions:
1. Where in the qemu implemen
commit c4baa0503d9623f1ce891f525ccd140c598bc29a improved SSE table
type safety which now raises compiler errors when latest QEMU was
configured with --enable-debug.
Fix this by splitting the SSE tables even further to separate
helper functions with different signatures.
Instead of crashing by cal
On 06/29/2012 04:00 PM, Blue Swirl wrote:
On Fri, Jun 29, 2012 at 3:27 PM, Corey Bryant wrote:
On 06/28/2012 03:49 PM, Blue Swirl wrote:
On Wed, Jun 27, 2012 at 9:25 PM, Anthony Liguori
wrote:
On 06/21/2012 03:04 AM, Avi Kivity wrote:
On 06/19/2012 09:58 PM, Blue Swirl wrote:
At
On Fri, Jun 29, 2012 at 7:35 PM, Stefan Weil wrote:
> Am 29.06.2012 08:41, schrieb Dunrong Huang:
>>
>> Commit c4baa0503d9623f1ce891f525ccd140c598bc29a improved SSE table type
>> safety but raises compile error of incompatible pointer type. Fix it by
>> casting to correct function type Signed-off-
On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster wrote:
> Best to use the same type, to avoid unwanted truncation or sign
> extension.
Awesome patch! :-)
>
> BlockConf can't use plain int for cyls, heads and secs, because
> integer properties require an exact width.
>
> Signed-off-by: Markus A
On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster wrote:
> Unless parameter ":floppy:" is given, vvfat creates a virtual image
> with DOS MBR defining a single partition which holds the FAT file
> system. The size of the virtual image depends on the width of the
> FAT: 32 MiB (CHS 64, 16, 63) fo
On Fri, Jun 29, 2012 at 4:43 PM, Juan Quintela wrote:
> This allows to know how long each section takes to save.
>
> An awk script like this tells us sections that takes more that 10ms
>
> $1 ~ /savevm_state_iterate_end/ {
> /* Print savevm_section_end line when > 10ms duration */
>
On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster wrote:
> Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible,
> except it was put into block.c. Device-specific functionality should
> be kept in device code, not the block layer. Move it to
> hw/hd-geometry.c, and make stylistic ch
On Fri, Jun 29, 2012 at 4:44 PM, Juan Quintela wrote:
> Refactor the code that is only needed for tcg to an static function.
> Call that only when tcg is enabled. We can't refactor to a dummy
> function in the kvm case, as qemu can be compiled at the same time
> with tcg and kvm.
>
> Signed-off-b
On Fri, Jun 29, 2012 at 4:43 PM, Juan Quintela wrote:
> From: Orit Wasserman
>
> Signed-off-by: Orit Wasserman
> Signed-off-by: Juan Quintela
> ---
> arch_init.c | 33 +++--
> 1 file changed, 27 insertions(+), 6 deletions(-)
>
> diff --git a/arch_init.c b/arch_ini
On Fri, Jun 29, 2012 at 4:44 PM, Juan Quintela wrote:
> Always use accessors to read/set the dirty bitmap.
>
> Signed-off-by: Juan Quintela
> ---
> exec-obsolete.h | 40
> exec.c | 3 +--
> 2 files changed, 21 insertions(+), 22 deletions(-)
On Fri, Jun 29, 2012 at 3:34 PM, Markus Armbruster wrote:
> So far covers only IDE and tests only CMOS contents.
>
> Signed-off-by: Markus Armbruster
> ---
> tests/Makefile | 2 +
> tests/hd-geo-test.c | 402
> +++
> 2 files changed, 404
On Fri, Jun 29, 2012 at 4:04 PM, Maksim Kozlov wrote:
> Add using of functionality provided by CMU - get_rate and
> register_clock_handler.
>
> Signed-off-by: Maksim Kozlov
> ---
> hw/exynos4210_uart.c | 36 +++-
> 1 files changed, 35 insertions(+), 1 deletions
On Fri, Jun 29, 2012 at 3:27 PM, Corey Bryant wrote:
>
>
> On 06/28/2012 03:49 PM, Blue Swirl wrote:
>>
>> On Wed, Jun 27, 2012 at 9:25 PM, Anthony Liguori
>> wrote:
>>>
>>> On 06/21/2012 03:04 AM, Avi Kivity wrote:
On 06/19/2012 09:58 PM, Blue Swirl wrote:
>>>
>>>
>>>
Am 29.06.2012 08:41, schrieb Dunrong Huang:
Commit c4baa0503d9623f1ce891f525ccd140c598bc29a improved SSE table
type safety but raises compile error of incompatible pointer type. Fix
it by casting to correct function type Signed-off-by: Dunrong Huang
--- target-i386/translate.c | 22
++
From: Isaku Yamahata
Signed-off-by: Isaku Yamahata
Signed-off-by: Juan Quintela
---
block-migration.c |8
migration.c | 13 -
migration.h |8 ++--
qemu-common.h |1 +
savevm.c | 13 +
sysemu.h |3 ++-
vm
Just code motion, with one long line wrapped to keep checkpatch.pl
happy.
Signed-off-by: Markus Armbruster
---
hw/qdev-properties.c | 144 +-
1 files changed, 72 insertions(+), 72 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-propertie
Unless parameter ":floppy:" is given, vvfat creates a virtual image
with DOS MBR defining a single partition which holds the FAT file
system. The size of the virtual image depends on the width of the
FAT: 32 MiB (CHS 64, 16, 63) for 12 bit FAT, 504 MiB (CHS 1024, 16,
63) for 16 and 32 bit FAT, lea
There are two producers of these hints: drive_init() on behalf of
-drive, and hd_geometry_guess().
The only consumer of the hint is hd_geometry_guess().
The callers of hd_geometry_guess() call it only when drive_init()
didn't set the hints. Therefore, drive_init()'s hints are never used.
Thus,
Checking each 64 pages is a random magic number as good as any other.
We don't want to test too many times, but on the other hand,
qemu_get_clock_ns() is not so expensive either. We want to be sure
that we spent less than 50ms (half of buffered_file timer), if we
spent more than 100ms, all the acc
PC BIOS setup needs IDE geometry information. Get it directly from
the device model rather than through the block layer. In preparation
of purging geometry from the block layer, which will happen later in
this series.
Signed-off-by: Markus Armbruster
---
hw/ide.h |4 +++-
hw/ide/c
Signed-off-by: Markus Armbruster
---
hw/hd-geometry.c |7 +++
trace-events |4
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c
index 9b22e3f..70eb116 100644
--- a/hw/hd-geometry.c
+++ b/hw/hd-geometry.c
@@ -23,6 +23,7 @@
*
2012/6/29 Andreas Färber :
> Am 29.06.2012 08:41, schrieb Dunrong Huang:
>> Commit c4baa0503d9623f1ce891f525ccd140c598bc29a improved SSE table type
>> safety but raises compile error of incompatible pointer type.
>
> What's the difference between the signatures?
>
The SSEFunc_0_pi is declared as:
t
32 patches may look discouraging, but most patches are small, and the
ones that aren't just move code around.
Goals of this series:
1. One more step towards a clean separation block device host and
guest part.
2. Purge CHS geometry from the block layer
Part I[PATCH 01-02/32]: Floppy geom
Signed-off-by: Markus Armbruster
---
tests/hd-geo-test.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c
index 0ab573c..02eb5c2 100644
--- a/tests/hd-geo-test.c
+++ b/tests/hd-geo-test.c
@@ -321,13 +321,15 @@ static void tes
Always use accessors to read/set the dirty bitmap.
Signed-off-by: Juan Quintela
---
exec-obsolete.h | 40
exec.c |3 +--
2 files changed, 21 insertions(+), 22 deletions(-)
diff --git a/exec-obsolete.h b/exec-obsolete.h
index 792c831..f8ffc
The enum string is pointed to by 'enum_str' not 'name'. This bug
causes the error message to be:
{ "error": { "class": "InvalidParameter",
"desc": "Invalid parameter 'null'",
"data": { "name": "null" } } }
Signed-off-by: Luiz Capitulino
---
I've caught this while revie
Signed-off-by: Markus Armbruster
---
block.h |8 +++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/block.h b/block.h
index 052d0ce..e0121d5 100644
--- a/block.h
+++ b/block.h
@@ -427,6 +427,8 @@ typedef struct BlockConf {
uint32_t opt_io_size;
int32_t bootinde
We add time spent for migration to the output of "info migrate"
command. 'total_time' means time since the start fo migration if
migration is 'active', and total time of migration if migration is
completed. As we are also interested in transferred ram when
migration completes, adding all ram stat
If buffers are full, don't iterate, just exit.
Signed-off-by: Juan Quintela
---
savevm.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/savevm.c b/savevm.c
index 987c6c0..a15c163 100644
--- a/savevm.c
+++ b/savevm.c
@@ -1626,6 +1626,9 @@ int qemu_savevm_state_iterate(QEMUFile *f)
Refactor the code that is only needed for tcg to an static function.
Call that only when tcg is enabled. We can't refactor to a dummy
function in the kvm case, as qemu can be compiled at the same time
with tcg and kvm.
Signed-off-by: Juan Quintela
---
exec.c | 31 +
From: Orit Wasserman
Signed-off-by: Orit Wasserman
Signed-off-by: Juan Quintela
---
arch_init.c |9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 78b3c0c..f5fd1f5 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -304,6 +304,11 @@ stati
From: Orit Wasserman
Signed-off-by: Benoit Hudzia
Signed-off-by: Petter Svard
Signed-off-by: Aidan Shribman
Signed-off-by: Orit Wasserman
Signed-off-by: Juan Quintela
---
arch_init.c | 26 ++
1 file changed, 14 insertions(+), 12 deletions(-)
diff --git a/arch_init
From: Orit Wasserman
Signed-off-by: Orit Wasserman
Signed-off-by: Juan Quintela
---
arch_init.c | 33 +++--
1 file changed, 27 insertions(+), 6 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index cfa1af2..78b3c0c 100644
--- a/arch_init.c
+++ b/arch_init.c
@
When hd_geometry_guess() picks a geometry, it also picks the
appropriate translation, but only when the prior translation hint is
BIOS_ATA_TRANSLATION_AUTO. Looks wrong, because such a prior
translation would be passed to the BIOS whether it's suitable for the
geometry or not.
Fortunately, that c
Signed-off-by: Markus Armbruster
---
hw/hd-geometry.c | 32
1 files changed, 20 insertions(+), 12 deletions(-)
diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c
index 3f3070b..4e47ec6 100644
--- a/hw/hd-geometry.c
+++ b/hw/hd-geometry.c
@@ -88,14 +88,31 @@ stat
ram_save_remaining() is an expensive operation when there is a lot of memory.
So we only call the function when we need it.
Signed-off-by: Juan Quintela
---
arch_init.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index f5fd1f5..64
In preparation of purging it from the block layer, which will happen
later in this series.
Signed-off-by: Markus Armbruster
---
blockdev.c |4
blockdev.h |1 +
2 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 9e0a72a..4d3b707 100644
--- a/
Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible,
except it was put into block.c. Device-specific functionality should
be kept in device code, not the block layer. Move it to
hw/hd-geometry.c, and make stylistic changes required to keep
checkpatch.pl happy.
Signed-off-by: Markus
So far covers only IDE and tests only CMOS contents.
Signed-off-by: Markus Armbruster
---
tests/Makefile |2 +
tests/hd-geo-test.c | 402 +++
2 files changed, 404 insertions(+), 0 deletions(-)
create mode 100644 tests/hd-geo-test.c
diff
Calculate the number of dirty pages takes a lot on hosts with lots
of memory. Just maintain how many pages are dirty.
Signed-off-by: Juan Quintela
---
arch_init.c | 15 +--
cpu-all.h |1 +
exec-obsolete.h | 10 ++
3 files changed, 12 insertions(+), 14 delet
New limits straight from ATA4 6.2 Register delivered data transfer
command sector addressing.
I figure the old sector limit 63 was blindly copied from the BIOS
int 13 limit. Doesn't apply to the hardware. No idea where the old
cylinder limit comes from.
Signed-off-by: Markus Armbruster
---
hw
Currently, it is split between hd_geometry_guess() and
pc_cmos_init_late(). Confusing. info qtree shows the result of the
former. Also confusing.
Fold the part done in pc_cmos_init_late() into hd_geometry_guess().
Signed-off-by: Markus Armbruster
---
blockdev.h |1 +
hw/hd-geometry
bdrv_get_floppy_geometry_hint() fails to store through its parameter
drive when bs has a geometry hint. Makes fd_revalidate() assign
random crap to drv->drive.
Has been broken that way for ages. Harmless, because:
* The only way to set a geometry hint is -drive if=none,cyls=...
Since commit c
To prepare move of guess_disk_lchs() into hw/, where it poking
BlockDriverState member io_limits_enabled directly would be unclean.
Signed-off-by: Markus Armbruster
---
block.c | 24 +---
block.h |2 ++
2 files changed, 19 insertions(+), 7 deletions(-)
diff --git a/blo
This allows to know how long each section takes to save.
An awk script like this tells us sections that takes more that 10ms
$1 ~ /savevm_state_iterate_end/ {
/* Print savevm_section_end line when > 10ms duration */
if ($2 > 1) {
printf("%s times_missing=%u\n",
Add exynos4210 Clock Management Units emulation
Signed-off-by: Maksim Kozlov
---
hw/arm/Makefile.objs |1 +
hw/exynos4210.c | 16 +
hw/exynos4210.h | 42 ++
hw/exynos4210_cmu.c | 1462 ++
4 files changed, 1521 insertions(+), 0 de
Each test litters /tmp with several files: a pid file and two
sockets. Tidy up.
Signed-off-by: Markus Armbruster
---
tests/libqtest.c | 29 -
1 files changed, 16 insertions(+), 13 deletions(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index 071b6be..02d0392
From: Orit Wasserman
Signed-off-by: Orit Wasserman
Signed-off-by: Juan Quintela
---
arch_init.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/arch_init.c b/arch_init.c
index a9e8b74..81c2e54 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -483,6 +483,9 @@ int ram_load(QEMUFile *f, vo
Signed-off-by: Markus Armbruster
---
hw/hd-geometry.c | 84 +++---
1 files changed, 42 insertions(+), 42 deletions(-)
diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c
index 70eb116..3f3070b 100644
--- a/hw/hd-geometry.c
+++ b/hw/hd-geometry.c
@@
Orit Wasserman wrote:
> It will return 0 if the page is unmodifed.
>
> Signed-off-by: Orit Wasserman
This does another thing, it adds stage parameter to ram_save_block(),
and it "shouldn't" need it (famous last words).
> -static int ram_save_block(QEMUFile *f)
> +static int ram_save_block(QEMUF
Geometry needs to be qdev properties, because it belongs to the
disk's guest part.
Maintain backward compatibility exactly like for serial: fall back to
DriveInfo's geometry, set with -drive cyls=...
Do this only for ide-hd. ide-drive is legacy. ide-cd doesn't have a
geometry.
Bonus: info qtre
Leave it to ide_init_drive().
Signed-off-by: Markus Armbruster
---
blockdev.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 37521b5..d5f2f57 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -330,15 +330,15 @@ DriveInfo *drive_init(QemuOpts
Hi
v3:
Anthony thinks that a Pull request v3 is a bit too much, so here we are
with a normal patch series. Only one change since pull request 2.
- Add missing chuck about migration_end() (Reported by eblake).
Please, review.
v2:
- Change Migration params from int to bool (Orit)
- Change %ld to
Commit 5bbdbb46 moved it to block.c because "other geometry guessing
functions already reside in block.c". Device-specific functionality
should be kept in device code, not the block layer. Move it back.
Disk geometry guessing is still in block.c. To be moved out in a
later patch series.
Bonus:
Instead of flushing pending coalesced MMIO requests on every vmexit,
this provides a mechanism to selectively flush when memory regions
related to the coalesced one are accessed. This first of all includes
the coalesced region itself but can also applied to other regions, e.g.
of the same device, b
Best to use the same type, to avoid unwanted truncation or sign
extension.
BlockConf can't use plain int for cyls, heads and secs, because
integer properties require an exact width.
Signed-off-by: Markus Armbruster
---
blockdev.h |2 +-
hw/hd-geometry.c |4 ++--
hw/ide/core.c|
Due to queuing/pipelining, there can now be multiple packets per
endpoint in flight. So the assertion in usb_packet_complete became wrong
and can cause bogus QEMU terminations. Seen with a passed-through USB
headset.
Signed-off-by: Jan Kiszka
---
I'm not 100% sure that the assertion that the ass
Geometry needs to be qdev properties, because it belongs to the
disk's guest part.
Maintain backward compatibility exactly like for serial: fall back to
DriveInfo's geometry, set with -drive cyls=...
Bonus: info qtree now shows the geometry.
Signed-off-by: Markus Armbruster
---
hw/s390-virtio-
Signed-off-by: Markus Armbruster
---
hw/hd-geometry.c | 22 --
1 files changed, 8 insertions(+), 14 deletions(-)
diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c
index 4e47ec6..40609a1 100644
--- a/hw/hd-geometry.c
+++ b/hw/hd-geometry.c
@@ -110,8 +110,7 @@ static void gue
vvfat creates a virtual VFAT filesystem with a certain logical
geometry that depends on its options. It sets the "geometry hint" to
this geometry. It is the only block driver to do this.
The geometry hint is about about *physical* geometry, and used only by
certain hard disk device models.
vvfa
Add using of functionality provided by CMU - get_rate and
register_clock_handler.
Signed-off-by: Maksim Kozlov
---
hw/exynos4210_uart.c | 36 +++-
1 files changed, 35 insertions(+), 1 deletions(-)
diff --git a/hw/exynos4210_uart.c b/hw/exynos4210_uart.c
index
These patches add exynos4210 Clock Management Unit emulation
and usage of it by exynos4210 UART
Maksim Kozlov (2):
ARM: exynos4210: CMU support
exynos4210: UART: Added using of CMU-callback functionality
hw/arm/Makefile.objs |1 +
hw/exynos4210.c | 16 +
hw/exynos4210.h | 4
Eric Blake wrote:
> On 06/29/2012 04:41 AM, Juan Quintela wrote:
>> Orit Wasserman wrote:
>>> Signed-off-by: Orit Wasserman
>>
>> Posted for pulling for Anthony.
>
> Did this include the hunk that I pointed out about 11/13 being in the
> wrong patch?
Nopis. Adding it.
>>> @@ -389,7 +509,7 @
Hi all,
I would like to use qemu to emulate a muliticore PowerPC PReP machine but it
see that the SMP is not
supported for the PReP architecture. In fact, running:
qemu-system-ppc -M prep -smp 2
It returns this message:
Number of SMP cpus requested (2), exceeds max cpus supported by mach
Signed-off-by: Markus Armbruster
---
tests/hd-geo-test.c | 22 ++
1 files changed, 22 insertions(+), 0 deletions(-)
diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c
index 94e6c30..ca1c1e9 100644
--- a/tests/hd-geo-test.c
+++ b/tests/hd-geo-test.c
@@ -368,6 +368,27 @@
Signed-off-by: Markus Armbruster
---
hw/qdev-properties.c | 15 +++
hw/qdev.h|3 +++
2 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 002c7f9..0b18f8c 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-pr
This isn't quite orthodox. CHS translation is firmware configuration,
communicated via the RTC's CMOS RAM, not a property of the disk. But
it's best to treat it just like geometry anyway.
Maintain backward compatibility exactly like for geometry: fall back
to DriveInfo's translation, set with -d
Signed-off-by: Markus Armbruster
---
tests/hd-geo-test.c | 13 +++--
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c
index 02eb5c2..94e6c30 100644
--- a/tests/hd-geo-test.c
+++ b/tests/hd-geo-test.c
@@ -321,15 +321,16 @@ static v
hd_geometry_guess() picks geometry and translation. Callers can get
the geometry directly, via parameters, but for translation they need
to go through the block layer.
Add a parameter for translation, so it can optionally be gotten just
like geometry. In preparation of purging translation from t
On Thu, Jun 28, 2012 at 04:06:24PM +0900, MORITA Kazutaka wrote:
>
> 'offset' is the offset of the sheepdog object. I think it should be
> 'done' since we need to pass the number of skip bytes.
Indeed. Odd that mny tests didn't catch this.
>
> > goto done;
> > }
Geometry needs to be qdev properties, because it belongs to the
disk's guest part.
Maintain backward compatibility exactly like for serial: fall back to
DriveInfo's geometry, set with -drive cyls=...
Do this only for scsi-hd. scsi-disk is legacy. scsi-cd doesn't have
a geometry. scsi-block sho
In particular, don't set disk type and geometry when a CD-ROM on bus
ide.0 has media during CMOS initialization.
Signed-off-by: Markus Armbruster
---
hw/ide/qdev.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
index bca53d0..077ba87 10064
On 06/28/2012 03:49 PM, Blue Swirl wrote:
On Wed, Jun 27, 2012 at 9:25 PM, Anthony Liguori wrote:
On 06/21/2012 03:04 AM, Avi Kivity wrote:
On 06/19/2012 09:58 PM, Blue Swirl wrote:
At least qemu-ifup/down scripts, migration exec and smbd have been
mentioned. Only the system calls made by
Am 29.06.2012 08:41, schrieb Dunrong Huang:
> Commit c4baa0503d9623f1ce891f525ccd140c598bc29a improved SSE table type
> safety but raises compile error of incompatible pointer type.
What's the difference between the signatures?
Regards,
Andreas
> Fix it by casting to correct function type
>
> S
On 06/29/2012 07:01 PM, Peter Maydell wrote:
On 29 June 2012 15:52, Igor Mitsyanko wrote:
On 06/29/2012 02:59 PM, Peter Maydell wrote:
The irq code looks dubious: we seem to have a single output
irq, but the code does things like:
qemu_set_irq(sdhci->irq, sdhci->errintsigen & sdhci->errin
Am 29.06.2012 02:34, schrieb Peter Crosthwaite:
> On Thu, Jun 28, 2012 at 11:05 PM, Andreas Färber wrote:
>> Am 28.06.2012 03:08, schrieb Peter Crosthwaite:
>>> On Thu, Jun 28, 2012 at 9:06 AM, Alexander Graf wrote:
>> [...]
[...] Why did commas in names work before, but now don't? Or p
On 29 June 2012 15:52, Igor Mitsyanko wrote:
> On 06/29/2012 02:59 PM, Peter Maydell wrote:
>> The irq code looks dubious: we seem to have a single output
>> irq, but the code does things like:
>> qemu_set_irq(sdhci->irq, sdhci->errintsigen & sdhci->errintsts);
>> but in other code paths:
>>
Allows to disable memory merge support (KSM on Linux), which is enabled
by default otherwise.
Signed-off-by: Luiz Capitulino
---
o v3: rename madvise_mergeable() to memory_try_enable_merging()
exec.c | 19 ---
qemu-config.c | 4
qemu-options.hx | 7 ++-
3
On 06/29/2012 02:59 PM, Peter Maydell wrote:
On 26 June 2012 06:13, Peter A. G. Crosthwaite
wrote:
target-ppc: Fix 2nd parameter for tcg_gen_shri_tl (2012-06-24 22:52:11 +0200)
are available in the git repository at:
git://developer.petalogix.com/public/qemu.git third-party/igor-sdhci.next
On Fri, 29 Jun 2012 16:30:19 +0200
Jan Kiszka wrote:
> On 2012-06-29 16:25, Anthony Liguori wrote:
> > On 06/29/2012 09:18 AM, Andreas Färber wrote:
> >> Am 25.06.2012 22:39, schrieb Luiz Capitulino:
> >>> On Mon, 25 Jun 2012 22:26:58 +0200
> >>> Jan Kiszka wrote:
> >>>
> On 2012-06-25 18:5
On 06/29/2012 09:18 AM, Andreas Färber wrote:
Am 25.06.2012 22:39, schrieb Luiz Capitulino:
On Mon, 25 Jun 2012 22:26:58 +0200
Jan Kiszka wrote:
On 2012-06-25 18:55, Luiz Capitulino wrote:
Allow for disabling memory merge support (KSM on Linux), which is
enabled by default otherwise.
-mach
On Fri, 29 Jun 2012 09:25:36 -0500
Anthony Liguori wrote:
> On 06/29/2012 09:18 AM, Andreas Färber wrote:
> > Am 25.06.2012 22:39, schrieb Luiz Capitulino:
> >> On Mon, 25 Jun 2012 22:26:58 +0200
> >> Jan Kiszka wrote:
> >>
> >>> On 2012-06-25 18:55, Luiz Capitulino wrote:
> Allow for disab
On 2012-06-29 16:25, Anthony Liguori wrote:
> On 06/29/2012 09:18 AM, Andreas Färber wrote:
>> Am 25.06.2012 22:39, schrieb Luiz Capitulino:
>>> On Mon, 25 Jun 2012 22:26:58 +0200
>>> Jan Kiszka wrote:
>>>
On 2012-06-25 18:55, Luiz Capitulino wrote:
> Allow for disabling memory merge supp
On Fri, 29 Jun 2012 16:18:14 +0200
Andreas Färber wrote:
> Am 25.06.2012 22:39, schrieb Luiz Capitulino:
> > On Mon, 25 Jun 2012 22:26:58 +0200
> > Jan Kiszka wrote:
> >
> >> On 2012-06-25 18:55, Luiz Capitulino wrote:
> >>> Allow for disabling memory merge support (KSM on Linux), which is
> >>
On Fri, 29 Jun 2012 09:18:09 -0500
Anthony Liguori wrote:
> On 06/29/2012 09:00 AM, Luiz Capitulino wrote:
> > Allows to disable memory merge support (KSM on Linux), which is enabled
> > by default otherwise.
> >
> > Signed-off-by: Luiz Capitulino
> > ---
> >
> > o v2: improve manpage description
On 06/29/2012 09:00 AM, Luiz Capitulino wrote:
Allows to disable memory merge support (KSM on Linux), which is enabled
by default otherwise.
Signed-off-by: Luiz Capitulino
---
o v2: improve manpage description
exec.c | 19 ---
qemu-config.c | 4
qemu-option
Am 25.06.2012 22:39, schrieb Luiz Capitulino:
> On Mon, 25 Jun 2012 22:26:58 +0200
> Jan Kiszka wrote:
>
>> On 2012-06-25 18:55, Luiz Capitulino wrote:
>>> Allow for disabling memory merge support (KSM on Linux), which is
>>> enabled by default otherwise.
>>
>> -machine mem_merge=on|off?
>
> Tha
1 - 100 of 141 matches
Mail list logo