Re: [Qemu-devel] Build broken for i386-softmmu with --enable-debug

2012-06-28 Thread Dunrong Huang
I also met this problem, I fix it by casting incompatible function type to correct function type. @@ -2950,20 +2950,20 @@ static const SSEFunc_0_pp sse_op_table2[3 * 8][2] = { static const SSEFunc_0_pi sse_op_table3a[4] = { gen_helper_cvtsi2ss, gen_helper_cvtsi2sd, -X86_64_ONLY(gen_

[Qemu-devel] [PATCH] target-i386: fix build with -Werror

2012-06-28 Thread Dunrong Huang
Commit c4baa0503d9623f1ce891f525ccd140c598bc29a improved SSE table type safety but raises compile error of incompatible pointer type. Fix it by casting to correct function type Signed-off-by: Dunrong Huang --- target-i386/translate.c | 22 +++--- 1 files changed, 11 insertions(

[Qemu-devel] [Bug 1014681] Re: BSOD with newer host kernels (x64) and W2k8S guest (x64)

2012-06-28 Thread Arndt Kritzner
Is there any hope to get this fixed in the near future or probably not? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1014681 Title: BSOD with newer host kernels (x64) and W2k8S guest (x64) Status

Re: [Qemu-devel] [PATCH v7 11/16] target-or32: Add a IIS dummy board

2012-06-28 Thread Peter Crosthwaite
Looks good to me, Peter On Fri, Jun 29, 2012 at 3:56 PM, Jia Liu wrote: > Hi Peter, > > On Fri, Jun 29, 2012 at 11:15 AM, Peter Crosthwaite > wrote: >> On Thu, Jun 28, 2012 at 11:56 PM, Jia Liu wrote: >>> Hi, Peter, Andreas, and Peter, >>> >>> I've replace env with cpu, and rewrite the load_ke

Re: [Qemu-devel] [PATCH v7 11/16] target-or32: Add a IIS dummy board

2012-06-28 Thread Jia Liu
Hi Peter, On Fri, Jun 29, 2012 at 11:15 AM, Peter Crosthwaite wrote: > On Thu, Jun 28, 2012 at 11:56 PM, Jia Liu wrote: >> Hi, Peter, Andreas, and Peter, >> >> I've replace env with cpu, and rewrite the load_kernel. >> Please review these new files: >> >> openrisc_pic.c >> >> #include "hw.h" >>

Re: [Qemu-devel] [PATCH v7 11/16] target-or32: Add a IIS dummy board

2012-06-28 Thread Jia Liu
On Fri, Jun 29, 2012 at 11:03 AM, 陳韋任 (Wei-Ren Chen) wrote: >> /* OpenRISC pic handler */ >> static void openrisc_pic_cpu_handler(void *opaque, int irq, int level) >> { >> OpenRISCCPU *cpu = (OpenRISCCPU *)opaque; > ^^ > Do we need casting before assigning

[Qemu-devel] Build broken for i386-softmmu with --enable-debug

2012-06-28 Thread Stefan Weil
Hi Blue, commit c4baa0503d9623f1ce891f525ccd140c598bc29a improved SSE table type safety which now raises compiler errors when latest QEMU was configured with --enable-debug. CC i386-softmmu/target-i386/translate.o cc1: warnings being treated as errors /qemu/target-i386/translate.c: In function ‘

Re: [Qemu-devel] [PATCH v1] xilinx_timer: Removed comma in device name

2012-06-28 Thread Peter Crosthwaite
Hi Edgar, I think for little ones like this, ill start a microblaze-devs patch queue and periodically send pull requests. Ill send the patches singly to qemu-devel for ACK and NACK as I create them, then [PULL] every couple of weeks to consolidate our testing/rebasing efforts. Sound like a plan?

Re: [Qemu-devel] [PATCH v7 11/16] target-or32: Add a IIS dummy board

2012-06-28 Thread Peter Crosthwaite
On Thu, Jun 28, 2012 at 11:56 PM, Jia Liu wrote: > Hi, Peter, Andreas, and Peter, > > I've replace env with cpu, and rewrite the load_kernel. > Please review these new files: > > openrisc_pic.c > > #include "hw.h" > #include "cpu.h" > > /* OpenRISC pic handler */ > static void openrisc_pic_cpu_han

Re: [Qemu-devel] [PATCH v7 11/16] target-or32: Add a IIS dummy board

2012-06-28 Thread Wei-Ren Chen
> /* OpenRISC pic handler */ > static void openrisc_pic_cpu_handler(void *opaque, int irq, int level) > { > OpenRISCCPU *cpu = (OpenRISCCPU *)opaque; ^^ Do we need casting before assigning opaque to cpu? Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Sy

Re: [Qemu-devel] [PATCH] target-i386: implement FPREM and FPREM1 using softfloat only

2012-06-28 Thread Catalin Patulea
On Thu, Jun 28, 2012 at 2:25 PM, Peter Maydell wrote: > >  /* > > +| Returns 1 if the extended double-precision floating-point value `a' is an > > +| unsupported; otherwise returns 0. > > an unsupported what? I think it sh

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-28 Thread Marcelo Tosatti
On Thu, Jun 28, 2012 at 09:10:39AM -0500, Anthony Liguori wrote: > On 06/26/2012 02:34 PM, Marcelo Tosatti wrote: > >On Sat, Jun 23, 2012 at 12:55:49AM +0200, Jan Kiszka wrote: > >>Should have declared this [RFC] in the subject and CC'ed kvm... > >> > >>On 2012-06-23 00:45, Jan Kiszka wrote: > >>>T

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-28 Thread Marcelo Tosatti
On Thu, Jun 28, 2012 at 09:10:39AM -0500, Anthony Liguori wrote: > > > >1. read_lock(memmap_lock) > >2. MemoryRegionSection mrs = lookup(addr) > >3. qom_ref(mrs.mr->dev) > >4. read_unlock(memmap_lock) > > > >5. mutex_lock(dev->lock) > >6. dispatch(&mrs, addr, data, size) > >7. mutex_unlock(d

Re: [Qemu-devel] [RFC] block: Removed coroutine ownership assumption

2012-06-28 Thread Peter Crosthwaite
Hi Stefan. On Thu, Jun 28, 2012 at 11:03 PM, Stefan Hajnoczi wrote: > On Thu, Jun 28, 2012 at 4:17 AM, Peter Crosthwaite > wrote: not at a valid yield point. But whats really wrong here is the block layer will be making assumption on re-entry of the coroutine, so I cant re-enter i

Re: [Qemu-devel] [PATCH v2 11/11] xilinx_axidma: changed device name

2012-06-28 Thread Peter Crosthwaite
On Thu, Jun 28, 2012 at 11:05 PM, Andreas Färber wrote: > Am 28.06.2012 03:08, schrieb Peter Crosthwaite: >> On Thu, Jun 28, 2012 at 9:06 AM, Alexander Graf wrote: >>> > [...] >>> [...] Why did commas in names work before, but now don't? Or put >>> differently: Was this change on purpose? > [...

[Qemu-devel] [PATCH] i386: use #defines instead of magic numbers for CPUID cache information

2012-06-28 Thread Eduardo Habkost
This is an attempt to make the CPUID cache topology code clearer, by replacing the magic number in the code with #defines, and moving all the cache information to the same place in the file. I took care of comparing the disassembled target-i386/cpu.o code before and after applying this change, to

[Qemu-devel] [Bug 1018530] Re: No write access in a 9p/virtfs shared folder

2012-06-28 Thread Georg Poppe
No, there are no results relating /data. I would have wondered about it, because I already configured apparmor to allow access to /data. The current rules in the profile of the virtual machine are "/storage/data/" rw, "/storage/data/**" rw, I also disabled the apparmor profile but it didn't

[Qemu-devel] [PATCH 08/12] savevm: split save_live into stage2 and stage3

2012-06-28 Thread Juan Quintela
We split it into 2 functions, foo_live_iterate, and foo_live_complete. At this point, we only remove the bits that are for the other stage, functionally this is equivalent to previous code. Signed-off-by: Juan Quintela --- arch_init.c | 71 +- block-mi

Re: [Qemu-devel] [PATCH 08/12] savevm: split save_live into stage2 and stage3

2012-06-28 Thread Blue Swirl
On Thu, Jun 28, 2012 at 7:22 PM, Juan Quintela wrote: > We split it into 2 functions, foo_live_iterate, and foo_live_complete. > At this point, we only remove the bits that are for the other stage, > functionally this is equivalent to previous code. > > Signed-off-by: Juan Quintela > --- >  arch_

[Qemu-devel] [PATCH 06/12] savevm: introduce is_active method

2012-06-28 Thread Juan Quintela
Enable the creation of a method to tell migration if that section is active and should be migrate. We use it for blk-migration, that is normally not active. We don't create the method for RAM, as setups without RAM are very strange O:-) Signed-off-by: Juan Quintela --- block-migration.c | 13

Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields

2012-06-28 Thread Blue Swirl
On Thu, Jun 28, 2012 at 5:58 AM, Markus Armbruster wrote: > Blue Swirl writes: > >> On Wed, Jun 27, 2012 at 6:01 AM, Markus Armbruster wrote: >>> Blue Swirl writes: >>> On Tue, Jun 26, 2012 at 6:41 PM, Peter Maydell wrote: > On 26 June 2012 19:25, Blue Swirl wrote: >> On Tu

[Qemu-devel] [PATCH 03/12] savevm: remove SaveSetParamsHandler

2012-06-28 Thread Juan Quintela
It was used only once, just unfold. Signed-off-by: Juan Quintela --- vmstate.h |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/vmstate.h b/vmstate.h index 4bce53b..5e1a7cc 100644 --- a/vmstate.h +++ b/vmstate.h @@ -26,13 +26,12 @@ #ifndef QEMU_VMSTATE_H #define QEMU_VM

[Qemu-devel] [PATCH 05/12] savevm: Refactor cancel operation in its own operation

2012-06-28 Thread Juan Quintela
Intead of abusing stage with value -1. Signed-off-by: Juan Quintela --- arch_init.c | 11 ++- block-migration.c | 10 ++ savevm.c |4 ++-- vmstate.h |1 + 4 files changed, 15 insertions(+), 11 deletions(-) diff --git a/arch_init.c b/arch_init.c

[Qemu-devel] [PATCH 07/12] savevm: split save_live_setup from save_live_state

2012-06-28 Thread Juan Quintela
This patch splits stage 1 to its own function for both save_live users, ram and block. It is just a copy of the function, removing the parts of the other stages. Optimizations would came later. Signed-off-by: Juan Quintela --- arch_init.c | 86 +++---

[Qemu-devel] [PATCH 01/12] savevm: Use a struct to pass all handlers

2012-06-28 Thread Juan Quintela
This would make easier to add more operations in the next patches. Signed-off-by: Juan Quintela --- savevm.c | 54 +- vmstate.h |7 +++ 2 files changed, 32 insertions(+), 29 deletions(-) diff --git a/savevm.c b/savevm.c index a15c16

[Qemu-devel] [PATCH 11/12] ram: iterate phase

2012-06-28 Thread Juan Quintela
We only need to synchronize the bitmap when the number of dirty pages is low. Not every time that we call the function. Signed-off-by: Juan Quintela --- arch_init.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/arch_init.c b/arch_init.c index fe843a7..8299c15 10

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-28 Thread Blue Swirl
On Wed, Jun 27, 2012 at 9:25 PM, Anthony Liguori wrote: > On 06/21/2012 03:04 AM, Avi Kivity wrote: >> >> On 06/19/2012 09:58 PM, Blue Swirl wrote: > > At least qemu-ifup/down scripts, migration exec and smbd have been > mentioned. Only the system calls made by smbd (for some version o

Re: [Qemu-devel] qemu-kvm-1.0.1 - unable to exit if vcpu is in infinite loop

2012-06-28 Thread Peter Lieven
Am 28.06.2012 um 18:32 schrieb Avi Kivity: > On 06/28/2012 07:29 PM, Peter Lieven wrote: >>> Yes. A signal is sent, and KVM returns from the guest to userspace on >>> pending signals. > >> is there a description available how this process exactly works? > > The kernel part is in vcpu_enter_gues

[Qemu-devel] [PATCH 12/12] ram: save_live_setup() we don't need to synchronize the dirty bitmap.

2012-06-28 Thread Juan Quintela
1st: we were synchonizing the dirty bitmap before calling memory_global_dirty_log_start(). 2nd: We are marking all pages as dirty anywhere, no reason to go through all the bitmap to "mark" dirty same pages twice. So, call removed. Signed-off-by: Juan Quintela --- arch_init.c |2

[Qemu-devel] [PATCH 10/12] ram: save_live_complete() only do one loop

2012-06-28 Thread Juan Quintela
We were doing the same loop that stage2, and a new one for stage3. We only need the one for stage3. Signed-off-by: Juan Quintela --- arch_init.c | 31 --- 1 file changed, 31 deletions(-) diff --git a/arch_init.c b/arch_init.c index 1eab331..fe843a7 100644 --- a/ar

[Qemu-devel] [PATCH 09/12] ram: save_live_setup() don't need to sent pages

2012-06-28 Thread Juan Quintela
We should send pages on interate phase, not in setup one. This was a "bug". Just removing the loop does what we want. Tested that it works with current ram_load(). Signed-off-by: Juan Quintela --- arch_init.c | 33 - 1 file changed, 33 deletions(-) diff --gi

[Qemu-devel] [PATCH 04/12] savevm: remove SaveLiveStateHandler

2012-06-28 Thread Juan Quintela
It was used only once, just unfold. Signed-off-by: Juan Quintela --- vmstate.h |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/vmstate.h b/vmstate.h index 5e1a7cc..0e24834 100644 --- a/vmstate.h +++ b/vmstate.h @@ -27,13 +27,12 @@ #define QEMU_VMSTATE_H 1 typedef void

[Qemu-devel] [PATCH 02/12] savevm: Live migration handlers register the struct directly

2012-06-28 Thread Juan Quintela
Notice that the live migration users never unregister, so no problem about freeing the ops structure. Signed-off-by: Juan Quintela --- arch_init.c |9 +++-- block-migration.c | 10 -- migration.h |4 ++-- savevm.c | 18 +++--- vl.c

[Qemu-devel] [PATCH 00/12] Split ram_save_live() function

2012-06-28 Thread Juan Quintela
Hi We have foo_save_live() functions that did 4 things depending on stage parameter: * -1: cancel * 1: setup phase * 2: iterate live phase * 3: complete phase So this series split this functions in 4 functions, one for each phase. We start just moving code, i.e. not doing any change. Once we do

Re: [Qemu-devel] [KVM][Kemari]: Build error fix

2012-06-28 Thread OHMURA Kei
On 2012/06/28 5:34, Sterling Windmill wrote: Is Kemari still in active development? No, it's not. Currently we have no intention to add new features into Kemari. Thanks, Kei Best regards, Sterling Windmill On Sun, Dec 4, 2011 at 9:45 PM, OHMURA Kei mailto:ohmura@lab.ntt.co.jp>> wrote:

[Qemu-devel] [PULL request 00/13] Migration tree

2012-06-28 Thread Juan Quintela
Hi Here are the patches that were reviewed and had no comments: Not changes for the ones posted, just rebased to be sure that there were no problem with merging (there weren't). - Huge memory series (Juan Quintela) - All that was not XBRLE (Orit) form orit series - missing check for host_from_st

Re: [Qemu-devel] [PATCH] target-i386: implement FPREM and FPREM1 using softfloat only

2012-06-28 Thread Peter Maydell
On 28 June 2012 00:00, Catalin Patulea wrote: > Hey guys, > > I've been hacking up the FPREM and FPREM1 i386 instructions (without KVM) to > be implemented using SoftFloat only. This was motivated by some correctness > issues > that we noticed with the current implementation which follows the AM

Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

2012-06-28 Thread Peter Maydell
On 20 June 2012 15:44, Anthony Liguori wrote: > This avoids the problem associated with having multiple target specific files > in a single directory with the current build system. > > We can eventually get rid of the hw/$BASE_ARCH/Makefiles.obj files too Ping? I can't figure out if this discussi

Re: [Qemu-devel] [PATCH V2] Exynos4: add RTC device

2012-06-28 Thread Peter Maydell
On 27 June 2012 07:06, Oleg Ogurtsov wrote: > > Signed-off-by: Oleg Ogurtsov Reviewed-by: Peter Maydell -- PMM

Re: [Qemu-devel] [PATCH 0/3] ARM: Exynos4210 bugfixes

2012-06-28 Thread Peter Maydell
On 27 June 2012 04:55, Evgeny Voevodin wrote: > First patch is on the list: > http://lists.gnu.org/archive/html/qemu-devel/2012-06/msg03717.html > It fixes a critical bug in MCT that leads to hanged linux kernel v3.0. I > preferred to pick this > patch into this patch set. > > Second patch fixes

Re: [Qemu-devel] [PATCH 3/3] hw/exynos4210.c: Fix misleading initialization of IROM mirror

2012-06-28 Thread Peter Maydell
On 27 June 2012 04:55, Evgeny Voevodin wrote: > We want to mirror whole IROM and should pass zero instead of > EXYNOS4210_IROM_BASE_ADDR (though it equals to zero too) since > memory_region_init_alias takes an offset within an original > region as an argument. > > Signed-off-by: Evgeny Voevodin

Re: [Qemu-devel] [PATCH 2/3] hw/exynos4210_pwm.c: Fix STOP status in tick handler.

2012-06-28 Thread Peter Maydell
On 27 June 2012 04:55, Evgeny Voevodin wrote: > START/STOP bit was not cleaned correctly. > > Signed-off-by: Evgeny Voevodin Reviewed-by: Peter Maydell -- PMM

[Qemu-devel] [Bug 1018530] Re: No write access in a 9p/virtfs shared folder

2012-06-28 Thread Serge Hallyn
Thanks for reporting this bug. Could you check your /var/log/syslog for apparmor messages relating to libvirt accessing /data? The command sudo grep DENIED /var/log/syslog | grep libvirt should return interesting results. ** Changed in: qemu-kvm (Ubuntu) Importance: Undecided => Medium

[Qemu-devel] [PATCH] pc_sysfw: old_pc_system_rom_init(): improve error messages

2012-06-28 Thread Luiz Capitulino
Also say why loading the bios has failed. Signed-off-by: Luiz Capitulino --- hw/pc_sysfw.c | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/hw/pc_sysfw.c b/hw/pc_sysfw.c index b45f0ac..5670651 100644 --- a/hw/pc_sysfw.c +++ b/hw/pc_sysfw.c @@ -144,

Re: [Qemu-devel] [PATCH 4/4] target-arm: add minimal dump-guest-memory support

2012-06-28 Thread Peter Maydell
On 20 June 2012 18:28, Rabin Vincent wrote: > Add a minimal dump-guest-memory support for ARM.  The -p option is not > supported and we don't add any QEMU-specific notes. So what does this patch give us? This commit message is pretty short and I couldn't find a cover message for the patchset...

Re: [Qemu-devel] [PATCH v4 2/2] xilinx_zynq: added pl330 to machine model

2012-06-28 Thread Peter Maydell
On 18 June 2012 01:42, Peter A. G. Crosthwaite wrote: > Signed-off-by: Peter A. G. Crosthwaite This looks OK but I won't mark it R-by because it will be affected by changing how the pl330 model exposes its configurable properties (see remarks in the pl330 patch review.) -- PMM

Re: [Qemu-devel] qemu-kvm-1.0.1 - unable to exit if vcpu is in infinite loop

2012-06-28 Thread Avi Kivity
On 06/28/2012 07:29 PM, Peter Lieven wrote: >> Yes. A signal is sent, and KVM returns from the guest to userspace on >> pending signals. > is there a description available how this process exactly works? The kernel part is in vcpu_enter_guest(), see the check for signal_pending(). But this hasn'

Re: [Qemu-devel] qemu-kvm-1.0.1 - unable to exit if vcpu is in infinite loop

2012-06-28 Thread Peter Lieven
On 28.06.2012 17:22, Jan Kiszka wrote: On 2012-06-28 17:02, Peter Lieven wrote: On 28.06.2012 15:25, Jan Kiszka wrote: On 2012-06-28 15:05, Peter Lieven wrote: Hi, i debugged my initial problem further and found out that the problem happens to be that the main thread is stuck in pause_all_vcp

Re: [Qemu-devel] [PATCH v2 0/7] kvm: Get coalesced MMIO flushing out of the hot-path

2012-06-28 Thread Avi Kivity
On 06/27/2012 07:27 PM, Jan Kiszka wrote: > Changes in v2: > - added memory_region_clear_flush_coalesced > - call memory_region_clear_flush_coalesced from >memory_region_clear_coalescing > - wrap all region manipulations via memory_region_transaction_begin/ >commit internally > - flush

Re: [Qemu-devel] [PATCH v2 2/7] memory: Flush coalesced MMIO on selected region access

2012-06-28 Thread Avi Kivity
On 06/27/2012 07:27 PM, Jan Kiszka wrote: > Instead of flushing pending coalesced MMIO requests on every vmexit, > this provides a mechanism to selectively flush when memory regions > related to the coalesced one are accessed. This first of all includes > the coalesced region itself but can also ap

[Qemu-devel] [PATCH 12/13] target-arm: Implement TTBCR changes for LPAE

2012-06-28 Thread Peter Maydell
Implement the changes to the TTBCR register required for LPAE: * many fewer bits should be RAZ/WI * since TTBCR changes can result in a change of ASID, we must flush the TLB on writes to it Signed-off-by: Peter Maydell --- target-arm/helper.c | 15 ++- 1 files changed, 14 inse

[Qemu-devel] [PATCH] configure: Remove help for --disable-vnc-thread, --enable-vnc-thread

2012-06-28 Thread Stefan Weil
Commit 2624bab836662d37f08336408a99d97652fc9c4d removed these configure arguments. Now the help text for both is removed, too. Signed-off-by: Stefan Weil --- configure |2 -- 1 file changed, 2 deletions(-) diff --git a/configure b/configure index 1459c52..c3e09fc 100755 --- a/configure +++

[Qemu-devel] [PATCH 04/13] ARM: Make target_phys_addr_t 64 bits and physaddrs 40 bits

2012-06-28 Thread Peter Maydell
Make target_phys_addr_t 64 bits for ARM targets, and set TARGET_PHYS_ADDR_SPACE_BITS to 40. This should have no effect for ARM boards where physical addresses really are 32 bits (except perhaps a slight performance hit on 32 bit hosts for system emulation) but allows us to implement the Large Phys

[Qemu-devel] [PATCH 03/13] bitops.h: Add functions to extract and deposit bitfields

2012-06-28 Thread Peter Maydell
Add functions deposit32(), deposit64(), extract32() and extract64() to extract and deposit bitfields in 32 and 64 bit words. Based on ideas by Jia Liu and Avi Kivity. Suggested-by: Jia Liu Suggested-by: Avi Kivity Signed-off-by: Peter Maydell Reviewed-by: Eric Blake --- bitops.h | 66 ++

[Qemu-devel] [PATCH 11/13] target-arm: Implement long-descriptor PAR format

2012-06-28 Thread Peter Maydell
Implement the different format of the PAR when long descriptor translation tables are in use. Note that we assume that get_phys_addr() returns a long-descriptor format DFSR value on failure if long descriptors are in use; this added subtlety tips the balance and makes it worth adding a comment docu

[Qemu-devel] [PATCH 01/13] hw/cadence_gem: Make rx_desc_addr and tx_desc_addr uint32_t

2012-06-28 Thread Peter Maydell
Make the state fields rx_desc_addr and tx_desc_addr uint32_t; this matches the VMStateDescription, and also conforms to how hardware works: the registers don't magically become larger if the device is attached to a CPU with a larger physical address size. It also fixes a compile failure if the targ

[Qemu-devel] [PATCH 05/13] target-arm: Implement privileged-execute-never (PXN)

2012-06-28 Thread Peter Maydell
Implement the privileged-execute-never (PXN) translation table bit. It is implementation-defined whether this is implemented, so we give it its own ARM_FEATURE_ flag. LPAE requires PXN, so add also an LPAE feature flag and the implication logic, as a placeholder for actually implementing LPAE at a

[Qemu-devel] [PATCH 09/13] target-arm: Add 64 bit PAR, TTBR0, TTBR1 for LPAE

2012-06-28 Thread Peter Maydell
Under LPAE, the cp15 registers PAR, TTBR0 and TTBR1 are extended to 64 bits, with a 64 bit (MRRC/MCRR) access path to read the full width of the register. Add the state fields for the top half and the 64 bit access path. Actual use of the top half of the register will come with the addition of the

Re: [Qemu-devel] qemu-kvm-1.0.1 - unable to exit if vcpu is in infinite loop

2012-06-28 Thread Jan Kiszka
On 2012-06-28 17:02, Peter Lieven wrote: > On 28.06.2012 15:25, Jan Kiszka wrote: >> On 2012-06-28 15:05, Peter Lieven wrote: >>> Hi, >>> >>> i debugged my initial problem further and found out that the problem >>> happens to be that >>> the main thread is stuck in pause_all_vcpus() on reset or qui

[Qemu-devel] [PATCH 06/13] target-arm: Extend feature flags to 64 bits

2012-06-28 Thread Peter Maydell
Extend feature flags to 64 bits, as we've just run out of space in the 32 bit integer we were using for them. Signed-off-by: Peter Maydell --- target-arm/cpu.c |2 +- target-arm/cpu.h |6 +++--- target-arm/machine.c |4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) d

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-28 Thread Avi Kivity
On 06/28/2012 05:10 PM, Anthony Liguori wrote: >> >> 1. read_lock(memmap_lock) >> 2. MemoryRegionSection mrs = lookup(addr) >> 3. qom_ref(mrs.mr->dev) >> 4. read_unlock(memmap_lock) >> >> 5. mutex_lock(dev->lock) >> 6. dispatch(&mrs, addr, data, size) >> 7. mutex_unlock(dev->lock) > > Just

[Qemu-devel] [PATCH 07/13] target-arm: Add AMAIR0, AMAIR1 LPAE cp15 registers

2012-06-28 Thread Peter Maydell
Add implementations of the AMAIR0 and AMAIR1 LPAE Auxiliary Memory Attribute Indirection Registers. These are implementation defined and we choose to implement them as RAZ/WI, matching the Cortex-A7 and Cortex-A15. Signed-off-by: Peter Maydell --- target-arm/helper.c | 16 1 f

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-06-28 Thread Corey Bryant
On 06/27/2012 05:51 AM, Kevin Wolf wrote: Am 27.06.2012 11:20, schrieb Daniel P. Berrange: On Wed, Jun 27, 2012 at 11:16:32AM +0200, Kevin Wolf wrote: The really bad case that nobody thought of is that, when block-commit has finished, we need to switch back to read-only. This is an event that

[Qemu-devel] [PATCH 10/13] target-arm: Use target_phys_addr_t in get_phys_addr()

2012-06-28 Thread Peter Maydell
In the implementation of get_phys_addr(), consistently use target_phys_addr_t to hold the physical address rather than uint32_t. Signed-off-by: Peter Maydell --- target-arm/helper.c | 29 +++-- 1 files changed, 15 insertions(+), 14 deletions(-) diff --git a/target-arm/

Re: [Qemu-devel] qemu-kvm-1.0.1 - unable to exit if vcpu is in infinite loop

2012-06-28 Thread Peter Lieven
On 28.06.2012 15:25, Jan Kiszka wrote: On 2012-06-28 15:05, Peter Lieven wrote: Hi, i debugged my initial problem further and found out that the problem happens to be that the main thread is stuck in pause_all_vcpus() on reset or quit commands in the monitor if one cpu is stuck in the do-while

[Qemu-devel] [PATCH] qmp: dump-guest-memory: improve schema doc

2012-06-28 Thread Luiz Capitulino
Clarify a few points and makes it looks more like the other commands' documentation. Signed-off-by: Luiz Capitulino --- qapi-schema.json | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 3b6e346..bc7ff

[Qemu-devel] [PATCH 02/13] target-arm: Fix typo that meant TTBR1 accesses went to TTBR0

2012-06-28 Thread Peter Maydell
Fix a copy-and-paste error in the register description for TTBR1 that meant it was a duplicate of TTBR0 rather than affecting the correct bit of CPU state. Signed-off-by: Peter Maydell --- target-arm/helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-arm/he

[Qemu-devel] [PATCH 13/13] target-arm: Add support for long format translation table walks

2012-06-28 Thread Peter Maydell
Implement the actual table walk code for LPAE's long format translation tables. Signed-off-by: Peter Maydell --- target-arm/helper.c | 182 +++ 1 files changed, 182 insertions(+), 0 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helpe

[Qemu-devel] [PATCH 08/13] target-arm: Add 64 bit variants of DBGDRAR and DBGDSAR for LPAE

2012-06-28 Thread Peter Maydell
LPAE extends the DBGDRAR and DBGDSAR debug registers to 64 bits; we only implement these as dummy RAZ versions; provide dummies for the 64 bit accesses as well. Signed-off-by: Peter Maydell --- target-arm/helper.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/targe

Re: [Qemu-devel] usb_packet_complete: Assertion ... failed

2012-06-28 Thread Jan Kiszka
On 2012-06-28 15:33, Jan Kiszka wrote: > On 2012-06-27 21:58, Erik Rull wrote: >> Jan Kiszka wrote: >>> On 2012-06-23 11:29, Erik Rull wrote: Jan Kiszka wrote: > Hi Gerd, > > I'm getting > > qemu/hw/usb/core.c:410: usb_packet_complete: Assertion > `((&ep->queue)->tqh_fi

Re: [Qemu-devel] qemu-system-ppc64 hanging occasionally in disk writes

2012-06-28 Thread Richard W.M. Jones
On Thu, Jun 28, 2012 at 04:25:26PM +0200, Alexander Graf wrote: > On 06/15/2012 12:01 AM, Richard W.M. Jones wrote: > >On Thu, Jun 14, 2012 at 11:34:37PM +0200, Alexander Graf wrote: > >>>/home/rjones/d/qemu/ppc64-softmmu/qemu-system-ppc64 \ > >>>-global virtio-blk-pci.scsi=off \ > >>>-node

[Qemu-devel] [PATCH 00/13] ARM: Add LPAE support

2012-06-28 Thread Peter Maydell
This patch series adds support for the ARM Large Physical Address Extensions, which allow 40 bit physical addressing by means of a new translation table format. Patches 1-3 are all dependencies which have been posted to the list separately already. Patch 4 makes target_phys_addr_t 64 bits for ARM.

Re: [Qemu-devel] qemu-system-ppc64 hanging occasionally in disk writes

2012-06-28 Thread Alexander Graf
On 06/15/2012 12:01 AM, Richard W.M. Jones wrote: On Thu, Jun 14, 2012 at 11:34:37PM +0200, Alexander Graf wrote: /home/rjones/d/qemu/ppc64-softmmu/qemu-system-ppc64 \ -global virtio-blk-pci.scsi=off \ -nodefconfig \ -nodefaults \ -nographic \ -device virtio-scsi-pci,id=scsi

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-28 Thread Anthony Liguori
On 06/26/2012 02:34 PM, Marcelo Tosatti wrote: On Sat, Jun 23, 2012 at 12:55:49AM +0200, Jan Kiszka wrote: Should have declared this [RFC] in the subject and CC'ed kvm... On 2012-06-23 00:45, Jan Kiszka wrote: This sketches a possible path to get rid of the iothread lock on vmexits in KVM mode

Re: [Qemu-devel] [PATCH v7 11/16] target-or32: Add a IIS dummy board

2012-06-28 Thread Jia Liu
Hi, Peter, Andreas, and Peter, I've replace env with cpu, and rewrite the load_kernel. Please review these new files: openrisc_pic.c #include "hw.h" #include "cpu.h" /* OpenRISC pic handler */ static void openrisc_pic_cpu_handler(void *opaque, int irq, int level) { OpenRISCCPU *cpu = (OpenR

Re: [Qemu-devel] [libvirt] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-06-28 Thread Luiz Capitulino
On Wed, 27 Jun 2012 10:58:01 +0200 Kevin Wolf wrote: > Am 26.06.2012 20:40, schrieb Corey Bryant: > >>> Here is a quick proof of concept (ie untested) patch to demonstrate > >>> what I mean. It relies on Cory's patch which converts everything > >>> to use qemu_open. It is also still valuable to m

Re: [Qemu-devel] [PATCH] kvm: First step to push iothread lock out of inner run loop

2012-06-28 Thread Marcelo Tosatti
On Wed, Jun 27, 2012 at 08:41:49AM +0100, Stefan Hajnoczi wrote: > On Wed, Jun 27, 2012 at 8:39 AM, Stefan Hajnoczi wrote: > > On Tue, Jun 26, 2012 at 8:34 PM, Marcelo Tosatti > > wrote: > >> On Sat, Jun 23, 2012 at 12:55:49AM +0200, Jan Kiszka wrote: > >> net.txt > >> > >> > >> > >> io

[Qemu-devel] [PATCH] target-arm: Fix some copy-and-paste errors in cp register names

2012-06-28 Thread Peter Maydell
Fix a couple of cases where cp register names were copy-and-pasted. These are harmless since we don't use the name for anything (except debugging convenience) but could be confusing. Signed-off-by: Peter Maydell --- target-arm/helper.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions

Re: [Qemu-devel] [PATCH] add -machine mem_merge=on|off option

2012-06-28 Thread Luiz Capitulino
On Thu, 28 Jun 2012 11:25:10 +0200 Jan Kiszka wrote: > On 2012-06-27 18:49, Luiz Capitulino wrote: > > Allows to disable memory merge support (KSM on Linux), which is enabled > > by default otherwise. > > > > Signed-off-by: Luiz Capitulino > > --- > > exec.c | 19 --- >

Re: [Qemu-devel] [PATCH 1/1] Add usb option in machine options.

2012-06-28 Thread Li Zhang
On Thu, Jun 28, 2012 at 9:22 PM, Alexander Graf wrote: > On 06/15/2012 02:46 PM, Li Zhang wrote: >> >> On Fri, Jun 15, 2012 at 7:09 PM, Andreas Färber  wrote: >>> >>> >>> You don't seem to be getting what I'm saying: As discussed in great >>> lengths for how to access a passed-in device tree for A

Re: [Qemu-devel] [PATCH 2/2] spapr: Add support for -vga option

2012-06-28 Thread Li Zhang
On Thu, Jun 28, 2012 at 7:03 PM, Alexander Graf wrote: > On 06/28/2012 09:34 AM, Li Zhang wrote: >> >> On Wed, Jun 27, 2012 at 10:37 PM, Alexander Graf  wrote: >>> >>> On 27.06.2012, at 16:32, Andreas Färber wrote: >>> Am 27.06.2012 15:55, schrieb Li Zhang: > > On Wed, Jun 27, 2012 at

Re: [Qemu-devel] usb_packet_complete: Assertion ... failed

2012-06-28 Thread Jan Kiszka
On 2012-06-27 21:58, Erik Rull wrote: > Jan Kiszka wrote: >> On 2012-06-23 11:29, Erik Rull wrote: >>> Jan Kiszka wrote: Hi Gerd, I'm getting qemu/hw/usb/core.c:410: usb_packet_complete: Assertion `((&ep->queue)->tqh_first) == p' failed. with a passed-through

Re: [Qemu-devel] [PATCH v3] bitops.h: Add functions to extract and deposit bitfields

2012-06-28 Thread Eric Blake
On 06/28/2012 06:55 AM, Peter Maydell wrote: > Add functions deposit32(), deposit64(), extract32() and extract64() > to extract and deposit bitfields in 32 and 64 bit words. Based on > ideas by Jia Liu and Avi Kivity. > > Suggested-by: Jia Liu > Suggested-by: Avi Kivity > Signed-off-by: Peter Ma

Re: [Qemu-devel] [PATCH v2 11/11] xilinx_axidma: changed device name

2012-06-28 Thread Edgar E. Iglesias
On Thu, Jun 28, 2012 at 02:53:13PM +0200, Andreas Färber wrote: > Am 16.06.2012 03:11, schrieb Edgar E. Iglesias: > > On Fri, Jun 15, 2012 at 01:30:17PM +0200, Andreas Färber wrote: > >> Am 13.06.2012 06:46, schrieb Peter A. G. Crosthwaite: > >>> Changed device name to xlnx,axi-dma. This is the exa

Re: [Qemu-devel] qemu-kvm-1.0.1 - unable to exit if vcpu is in infinite loop

2012-06-28 Thread Jan Kiszka
On 2012-06-28 15:05, Peter Lieven wrote: > Hi, > > i debugged my initial problem further and found out that the problem > happens to be that > the main thread is stuck in pause_all_vcpus() on reset or quit commands > in the monitor > if one cpu is stuck in the do-while loop kvm_cpu_exec. If I modi

Re: [Qemu-devel] [PATCH 1/1] Add usb option in machine options.

2012-06-28 Thread Alexander Graf
On 06/15/2012 02:46 PM, Li Zhang wrote: On Fri, Jun 15, 2012 at 7:09 PM, Andreas Färber wrote: You don't seem to be getting what I'm saying: As discussed in great lengths for how to access a passed-in device tree for ARM, the code checking this option (i.e., in spapr.c) is expected to call qem

Re: [Qemu-devel] [PATCH] pseries pci: spapr_populate_pci_devices renamed to spapr_populate_pci_dt

2012-06-28 Thread Alexander Graf
On 06/14/2012 06:40 AM, Alexey Kardashevskiy wrote: spapr_populate_pci_devices() populates the device tree only with bus properties and has nothing to do with the devices on it as PCI BAR allocation is done by the system firmware (SLOF). New name - spapr_populate_pci_dt() - describes the functio

Re: [Qemu-devel] [PATCH] pseries pci: removed redundand busdev

2012-06-28 Thread Alexander Graf
On 06/14/2012 06:38 AM, Alexey Kardashevskiy wrote: The PCIHostState struct already contains SysBusDevice so the one in sPAPRPHBState has to go. Signed-off-by: Alexey Kardashevskiy Thanks, applied to ppc-next. Alex

Re: [Qemu-devel] [PATCH v13 04/13] Add cache handling functions

2012-06-28 Thread Eric Blake
On 06/28/2012 06:06 AM, Max Filippov wrote: > On Wed, Jun 27, 2012 at 8:55 PM, Eric Blake wrote: >> On 06/27/2012 04:34 AM, Orit Wasserman wrote: > >> if (!is_power_of_2(num_pages)) { >>num_pages |= num_pages >> 1; >>num_pages |= num_pages >> 2; >>num_pages |= num_pages >> 4; >>n

[Qemu-devel] qemu-kvm-1.0.1 - unable to exit if vcpu is in infinite loop

2012-06-28 Thread Peter Lieven
Hi, i debugged my initial problem further and found out that the problem happens to be that the main thread is stuck in pause_all_vcpus() on reset or quit commands in the monitor if one cpu is stuck in the do-while loop kvm_cpu_exec. If I modify the condition from while (ret == 0) to while ((

Re: [Qemu-devel] [PATCH v2 11/11] xilinx_axidma: changed device name

2012-06-28 Thread Andreas Färber
Am 28.06.2012 03:08, schrieb Peter Crosthwaite: > On Thu, Jun 28, 2012 at 9:06 AM, Alexander Graf wrote: >> [...] >> [...] Why did commas in names work before, but now don't? Or put >> differently: Was this change on purpose? [...] > --- > hw/xilinx.h|2 +- > hw/xilinx_axid

Re: [Qemu-devel] [RFC] block: Removed coroutine ownership assumption

2012-06-28 Thread Stefan Hajnoczi
On Thu, Jun 28, 2012 at 4:17 AM, Peter Crosthwaite wrote: >>> not at a valid yield point. But whats really wrong here is the block >>> layer will be making assumption on re-entry of the coroutine, so I >>> cant re-enter it witout wildly changing the behaviour of the block >>> layer. If you adopt t

Re: [Qemu-devel] [PATCH] pseries pci: removed dt_irq from PCI host bus

2012-06-28 Thread Alexander Graf
On 06/14/2012 06:36 AM, Alexey Kardashevskiy wrote: As it is a very quick operation to resolve qirq from IRQ number, it makes no sense to cache it anywhere but its original source i.e. XICS. Signed-off-by: Alexey Kardashevskiy Ben, please ack/nack. Alex --- hw/spapr_pci.c | 14 +---

[Qemu-devel] [PATCH v3] bitops.h: Add functions to extract and deposit bitfields

2012-06-28 Thread Peter Maydell
Add functions deposit32(), deposit64(), extract32() and extract64() to extract and deposit bitfields in 32 and 64 bit words. Based on ideas by Jia Liu and Avi Kivity. Suggested-by: Jia Liu Suggested-by: Avi Kivity Signed-off-by: Peter Maydell --- Changes: v1->v2: added missing brackets v2->v3

Re: [Qemu-devel] [PATCH v2 11/11] xilinx_axidma: changed device name

2012-06-28 Thread Andreas Färber
Am 16.06.2012 03:11, schrieb Edgar E. Iglesias: > On Fri, Jun 15, 2012 at 01:30:17PM +0200, Andreas Färber wrote: >> Am 13.06.2012 06:46, schrieb Peter A. G. Crosthwaite: >>> Changed device name to xlnx,axi-dma. This is the exact name of the device >>> in the >>> Xilinx EDK development tools. >>>

Re: [Qemu-devel] [PATCH 0/4 v2] target-i386: move tcg intialization inside CPU object

2012-06-28 Thread Jan Kiszka
On 2012-06-25 15:55, Igor Mammedov wrote: > v2: > - drop usage of prev_debug_excp_handler consistently in all users > - split from reset patches to avoid confusion of inter-dependency > > Compile & Run tested: > target-i386: tcg and kvm mode > i386-linux-user: running of /bin/ls > Compile

Re: [Qemu-devel] qemu-kvm-1.0 crashes with threaded vnc server?

2012-06-28 Thread Corentin Chary
Please use "gdb -p " to attach qemu when stuck and use it to dump a full backtrace. Note that I never tested qemu-kvm and the vnc code was originally not written for it, so the locking stuff may be broken if the codebase differs from upstream qemu too much. Le 26 juin 2012 17:02, "Peter Lieven" a

Re: [Qemu-devel] [PATCH v13 04/13] Add cache handling functions

2012-06-28 Thread Max Filippov
On Wed, Jun 27, 2012 at 8:55 PM, Eric Blake wrote: > On 06/27/2012 04:34 AM, Orit Wasserman wrote: [...] >> + >> +    /* round down to the nearest power of 2 */ >> +    if (!is_power_of_2(num_pages)) { >> +        num_pages = 1 << ffs(num_pages); > > That's not how you round down.  For example,

Re: [Qemu-devel] [PATCH] qemu_find_file: check name as a straight path even if it has no '/'

2012-06-28 Thread Peter Maydell
Ping^2? -- PMM On 19 June 2012 16:13, Peter Maydell wrote: > Ping? (patch still applies cleanly to current master; patchwork URL > http://patchwork.ozlabs.org/patch/161324/ ) > > -- PMM > > On 25 May 2012 13:07, Peter Maydell wrote: >> Make qemu_find_file() check for the passed in name as a str

[Qemu-devel] Compiling static

2012-06-28 Thread Davide Ferraretto
Those is my post. This problem is only my. I don't find these library. I don't know where to download them. On 06/28/12 10:22, Dunrong Huang wrote: This post may give you some advice http://lists.gnu.org/archive/html/qemu-devel/2012-06/msg02319.html 2012/6/28 Davide Ferraretto : I want comp

  1   2   >