Here is v2 of the nested Makefile patches. Thanks all for the enthusiasm!
The main change is that rules can now be put in the per-directory snippets.
This is done for op_helper.o already.
Paolo
v1->v2:
do not call nested files "Makefile" (Andreas)
do not create directories at co
Signed-off-by: Paolo Bonzini
---
Makefile.target| 32 ++--
bsd-user/Makefile.objs |2 ++
configure |8 +++-
linux-user/Makefile.objs |7 +++
linux-user/arm/nwfpe/Makefile.objs |
qom/ already used a separate makefile. Convert it to use relative
paths, and make it declare both common-obj-y and user-obj-y. This
way, the upper makefiles do not need to know that some QOM files
are compiled twice.
Signed-off-by: Paolo Bonzini
---
Makefile.objs | 13 +++--
qom/
Signed-off-by: Paolo Bonzini
---
block/raw.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/block/raw.c b/block/raw.c
index 09d9b48..ff34ea4 100644
--- a/block/raw.c
+++ b/block/raw.c
@@ -12,12 +12,14 @@ static int raw_open(BlockDriverState *bs, int flags)
static int coroutine_fn raw_c
Signed-off-by: Paolo Bonzini
---
block/blkdebug.c |8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/block/blkdebug.c b/block/blkdebug.c
index 1eff940..1f79ef2 100644
--- a/block/blkdebug.c
+++ b/block/blkdebug.c
@@ -361,9 +361,7 @@ static BlockDriverAIOCB
*blkdebug_a
This makes blkdebug scripts more powerful, and independent of the
exact sequence of operations performed by streaming.
Signed-off-by: Paolo Bonzini
---
block/blkdebug.c | 26 --
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a/block/blkdebug.c b/block/blkd
The comment is stale, monitor.h is not needed anymore (only qerror.h
is, because it contains the schema for errors).
Signed-off-by: Paolo Bonzini
---
hmp.c |1 +
qapi/qapi-types-core.h |4 +---
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/hmp.c b/hmp.c
There is no reason why QAPI clients should use monitor.h at all,
qerror.h suffices.
qmp-commands.h uses the Monitor typedef, but it is only included
from files that already get the typedef from qemu-common.h.
Paolo Bonzini (2):
kvm: add missing include files
qmp: do not include monitor.h from
On Wed, Jun 6, 2012 at 1:42 PM, Anthony Liguori wrote:
> On 06/06/2012 11:31 AM, Benjamin Herrenschmidt wrote:
>
>> On Wed, 2012-06-06 at 10:52 +0800, li zhang wrote:
>>
>>> Hi Anthony,
>>>
>>>
>>> Any comment on this?
>>>
>>
>> Allright, this is all quite confusing...
>>
>> He's what I think sho
On 06/06/2012 11:31 AM, Benjamin Herrenschmidt wrote:
On Wed, 2012-06-06 at 10:52 +0800, li zhang wrote:
Hi Anthony,
Any comment on this?
Allright, this is all quite confusing...
He's what I think should happen:
When no option is passed -at-all-, we should have vga std and usb ohci +
usb m
On 06/06/2012 01:12 PM, Paolo Bonzini wrote:
Il 06/06/2012 01:40, Anthony Liguori ha scritto:
The only way I can think of getting around this is to do nasty things
like adding an
#include "qapi-generated/mc146818rtc-qapi-visit.c";
in hw/mc146818rtc.c.
It doesn't look that ugly, though perh
On Wed, 2012-06-06 at 01:52 +0200, Alexander Graf wrote:
> We want to get rid of the concept of loading an external device tree and
> instead
> generate our own. However, to do this we need to also create a device tree
> template programatically.
>
> This patch adds a helper to create an empty de
On Wed, 2012-06-06 at 01:52 +0200, Alexander Graf wrote:
> Usually we want to know when creating a subtree fails. However, while
> introducing this patch set we have to modify the device tree and some
> times have the code to create a subtree in both the binary tree and
> the dynamically created tr
On Wed, 2012-06-06 at 01:52 +0200, Alexander Graf wrote:
> Our subnode creation helper can't handle creation of root subnodes,
> like "/memory". Fix this by allowing the parent node to be an empty
> string, indicating the root node.
>
> Signed-off-by: Alexander Graf
Reviewed-by: Peter Crosthwait
On 06/01/2012 02:19 PM, Juan Quintela wrote:
> Orit Wasserman wrote:
>> Change XBZRLE cache size in bytes (the size should be a power of 2).
>> If XBZRLE cache size is too small there will be many cache miss.
>>
>> Signed-off-by: Benoit Hudzia
>> Signed-off-by: Petter Svard
>> Signed-off-by: Aid
On 06/01/2012 02:42 PM, Juan Quintela wrote:
> Orit Wasserman wrote:
>> In the outgoing migration check to see if the page is cached and
>> changed than send compressed page by using save_xbrle_page function.
>> In the incoming migration check to see if RAM_SAVE_FLAG_XBRLE is set
>> and decompress
On 06/01/2012 01:57 PM, Juan Quintela wrote:
> Orit Wasserman wrote:
>> Add migration capabiltes that can be queried by the management.
>> The managment can query the source QEMU and the destination QEMU in order to
>> verify both support some migration capability (currently only XBZRLE).
>> The
On Wed, 2012-06-06 at 01:52 +0200, Alexander Graf wrote:
> Some times in the device tree, we find an array of 2 u32 cells that
> really are a single u64 value. This patch adds a helper to make the
> creation of these easy.
>
> Signed-off-by: Alexander Graf
Reviewed-by: Peter Crosthwaite
> ---
On Wed, 2012-06-06 at 01:52 +0200, Alexander Graf wrote:
> Phandle references work by having 2 pieces:
>
> - a "phandle" 1-cell property in the device tree node
> - a reference to the same value in a property we want to point
> to the other node
>
> To generate the 1-cell property, we nee
Il 06/06/2012 01:40, Anthony Liguori ha scritto:
>>
>>> The only way I can think of getting around this is to do nasty things
>>> like adding an
>>>
>>> #include "qapi-generated/mc146818rtc-qapi-visit.c";
>>>
>>> in hw/mc146818rtc.c.
>>
>> It doesn't look that ugly, though perhaps I'm biased becaus
On Wed, 2012-06-06 at 01:52 +0200, Alexander Graf wrote:
> This patch adds a helper to search for a node's phandle by its path. This
> is especially useful when the phandle is part of an array, not just a single
> cell in which case qemu_devtree_setprop_phandle would be the easy choice.
>
> Signed
On Wed, 2012-06-06 at 01:52 +0200, Alexander Graf wrote:
> Phandles are the fancy device tree name for "pointer to another node".
> To create a phandle property, we most likely want to reference to the
> node we're pointing to by its path. So create a helper that allows
> us to do so.
>
> Signed-o
On Wed, 2012-06-06 at 01:52 +0200, Alexander Graf wrote:
> We have device tree helpers that allow us to create single cell (u32)
> wide properties. However, when creating properties that contain an array of
> cells, we need to jump through hoops, manually passing in an array with
> converted endian
Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built
around the FreeScale i.MX31.
Signed-off-by: Philip O'Sullivan
Signed-off-by: Peter Chubb
---
Makefile.target |2
hw/kzm.c| 155
2 files changed, 156 i
For Linux to be able to work out how fast its clocks are going, so
that timer ticks come approximately at the right time, it needs to
be able to query the clock control module (CCM).
This is the start of a CCM implementation. It currently knows only about
the MCU, HSP and IPG clocks --- i.e., t
Implement the FreeScale i.MX UART. This uart is used in a variety of
SoCs, including some by Motorola, as well as in the FreeScale i.MX
series.
This patch gives only a `bare-bones' implementation, enough to run Linux
or OKL4, but that's about it.
Signed-off-by: Philip O'Sullivan
Signed-off-by
There are no major changes since last time, just rebased to current
tip now that QEMU 1.2 is open.
For those who have come into the story late, this is a series of
patches to allow QEMU to emulate a Freescale i.MX31 on a Kyoto
Microsystems evaluation board. It's pretty bare-bones, but runs Linux
Implement the FreeSCALE i.MX31 advanced vectored interrupt controller, at least
to the extent it is used by Linux 3.0.x
Vectors are not implemented.
Signed-off-by: Philip O'Sullivan
Signed-off-by: Peter Chubb
Reviewed-by: Peter Maydell
---
Makefile.target |2
hw/imx_avic.c | 409
Implement the timers on the FreeScale i.MX31 SoC.
This is not a complete implementation, but gives enough for
Linux to boot and run. In particular external triggers, which are
not useful under QEMU, are not implemented.
Signed-off-by: Philip O'Sullivan
Signed-off-by: Peter Chubb
---
Makefile
Hi Brian,
Here are the information from our system.
We launched the VM using the following XML file.
The kernel version is 3.0.0.12
The Qemu version is 1.0.0(we upgraded it. Default one is 0.14.1)
===
We hit a kernel panic when a VM was configured with bridge mode. After the
IpTable was disabled using the following command lines, the kernel panic was
gone. We would like to know if there is any fix in latest kernel for this issue?
Note that we ran qemu 1.0 on Ubuntu 11.10
--
n
Hi Anthony,
Any comment on this?
Thanks.
On Tue, Jun 5, 2012 at 5:48 PM, li zhang wrote:
> Hi all,
>
> For pseries, when creating VMs with "-vga std",
> it requires usb mouse and usb kbd devices to be added.
>
> But with default options, vga is enabled and usb is disabled.
> User may use defau
On Tue, Jun 05, 2012 at 04:07:23PM +0200, Alexander Graf wrote:
>
> On 31.05.2012, at 12:55, David Gibson wrote:
>
> > On Wed, May 30, 2012 at 01:00:27PM +0200, Alexander Graf wrote:
> >> We want to get rid of the concept of loading an external device tree and
> >> instead
> >> generate our own.
Signed-off-by: Alexander Graf
---
hw/ppce500_mpc8544ds.c | 50
pc-bios/mpc8544ds.dtb | Bin 1810 -> 72 bytes
pc-bios/mpc8544ds.dts | 46
3 files changed, 50 insertions(+), 46 deletions(-)
diff --
Now that we are dynamically creating the dtb, it's really useful to
be able to dump the created blob for debugging.
This patch implements a -machine dumpdtb= option for e500 that
dumps the dtb exactly in the form the guest would get it to disk. It
can then be analyzed by dtc to get information abo
Phandles are the fancy device tree name for "pointer to another node".
To create a phandle property, we most likely want to reference to the
node we're pointing to by its path. So create a helper that allows
us to do so.
Signed-off-by: Alexander Graf
---
device_tree.c |7 +++
device_tree
Signed-off-by: Alexander Graf
---
hw/ppce500_mpc8544ds.c |8
pc-bios/mpc8544ds.dtb | Bin 2028 -> 1972 bytes
pc-bios/mpc8544ds.dts |5 -
3 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c
index f162cd3..650c910 10
We want to get rid of the concept of loading an external device tree and instead
generate our own. However, to do this we need to also create a device tree
template programatically.
This patch adds a helper to create an empty device tree in memory.
Signed-off-by: Alexander Graf
---
device_tree.
Our subnode creation helper can't handle creation of root subnodes,
like "/memory". Fix this by allowing the parent node to be an empty
string, indicating the root node.
Signed-off-by: Alexander Graf
---
device_tree.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a
Usually we want to know when creating a subtree fails. However, while
introducing this patch set we have to modify the device tree and some
times have the code to create a subtree in both the binary tree and
the dynamically created tree.
So ignore failures about this for now and enable them once w
We want to be able to override the automatically created device tree
by using the -dtb option. Implement this for the mpc8544ds machine.
Signed-off-by: Alexander Graf
---
hw/ppce500_mpc8544ds.c | 26 ++
1 files changed, 22 insertions(+), 4 deletions(-)
diff --git a/hw/
On 06.06.2012, at 01:07, Anthony Liguori wrote:
> On 06/06/2012 06:06 AM, Paul Moore wrote:
>> On Tuesday, June 05, 2012 11:51:40 PM Alexander Graf wrote:
>>> On 05.06.2012, at 23:45, Paul Moore wrote:
On Tuesday, June 05, 2012 03:08:26 AM Alexander Graf wrote:
> Which gets me to a new i
Signed-off-by: Alexander Graf
---
hw/ppce500_mpc8544ds.c |8
pc-bios/mpc8544ds.dtb | Bin 1904 -> 1810 bytes
pc-bios/mpc8544ds.dts |5 -
3 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c
index 6ad2897..39b221d 10
Signed-off-by: Alexander Graf
---
hw/ppce500_mpc8544ds.c | 16
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c
index 493ad6e..3d073dd 100644
--- a/hw/ppce500_mpc8544ds.c
+++ b/hw/ppce500_mpc8544ds.c
@@ -83,6 +83,8
This patch adds a helper to search for a node's phandle by its path. This
is especially useful when the phandle is part of an array, not just a single
cell in which case qemu_devtree_setprop_phandle would be the easy choice.
Signed-off-by: Alexander Graf
---
device_tree.c | 16 +++-
On 6 June 2012 00:51, Anthony Liguori wrote:
> In the case of a CharDriverState, the reference is always immutable. If we
> supported changing char backends dynamically, it would not happen by
> changing the reference, but almost certainly by having the ability to reopen
> the char driver in plac
Signed-off-by: Alexander Graf
---
hw/ppce500_mpc8544ds.c |1 +
pc-bios/mpc8544ds.dtb | Bin 1924 -> 1904 bytes
pc-bios/mpc8544ds.dts |3 ---
3 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c
index 106251e..6ad2897 100644
---
When generating serial port device tree nodes, we duplicate quite a bit
of code, because there are 2 of them in the mpc8544ds board we emulate.
Shove the generating code into a function, so we duplicate less code.
Signed-off-by: Alexander Graf
---
hw/ppce500_mpc8544ds.c | 54 +
Every time we use an address constant, it needs to potentially fit into
a 64bit physical address space. So let's define things accordingly.
Signed-off-by: Alexander Graf
---
hw/ppce500_mpc8544ds.c | 34 +-
1 files changed, 17 insertions(+), 17 deletions(-)
diff
Today we have two separate places where we keep information which device
is where:
- hw/ppce500_mpc8544ds.c to instantiate all devices
- pc-bios/mpc8544ds.dtb as device tree to tell the guest about devices
Every time we split crucial information, things can go terribly wrong. If
you update on
Signed-off-by: Alexander Graf
---
hw/ppce500_mpc8544ds.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c
index 39b221d..63515bb 100644
--- a/hw/ppce500_mpc8544ds.c
+++ b/hw/ppce500_mpc8544ds.c
@@ -101,6 +101,7 @@ static int
Signed-off-by: Alexander Graf
---
hw/ppce500_mpc8544ds.c |5 +
pc-bios/mpc8544ds.dtb | Bin 1972 -> 1924 bytes
pc-bios/mpc8544ds.dts |5 -
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c
index 650c910..106251e 10064
Now that all of the device tree bits are generated during runtime, we
can get rid of the device tree blob and instead start from scratch with
an empty device tree.
Signed-off-by: Alexander Graf
---
Makefile |1 -
hw/ppce500_mpc8544ds.c |8 +---
pc-bios/mpc8544ds.dtb |
Signed-off-by: Alexander Graf
---
hw/ppce500_mpc8544ds.c | 17 +
pc-bios/mpc8544ds.dts |9 -
2 files changed, 17 insertions(+), 9 deletions(-)
diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c
index 63515bb..5ff2d24 100644
--- a/hw/ppce500_mpc8544ds.c
++
Signed-off-by: Alexander Graf
---
hw/ppce500_mpc8544ds.c | 35 +++
pc-bios/mpc8544ds.dts | 26 --
2 files changed, 35 insertions(+), 26 deletions(-)
diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c
index 5ff2d24..493ad6e 10
This reverts commit "dt: temporarily disable subtree creation
failure check" which was meant as a temporary solution to keep
external and dynamic device tree construction intact.
Now that we switched to fully dynamic dt construction, it's no
longer necessary.
Signed-off-by: Alexander Graf
---
We have a nice 64bit helper to ease the device tree generation and
make the code more readable when creating 64bit 2-cell parameters.
Use it when generating the device tree.
Signed-off-by: Alexander Graf
---
v1 -> v2:
- rename cell64 -> u64
- don't treat memory as single u64
---
hw/ppce50
If anyone outside of QEMU wants to mess with a QEMU generated device tree,
he needs to know which range phandles are valid in. So let's expose a
machine option that an external program can use to set the start allocate
id for phandles in QEMU.
Signed-off-by: Alexander Graf
---
device_tree.c |
We're passing the ram size as uint32_t, capping it to 32 bits atm.
Change to target_phys_addr_t (uint64_t) to make sure we have all
the bits.
Signed-off-by: Alexander Graf
---
hw/ppce500_mpc8544ds.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/ppce500_mpc8544ds.c
Now that we're moving all of the device tree generation from an external
pre-execution generated blob to runtime generation using libfdt, we absolutely
must have libfdt around.
This requirement was there before already, as the only way to not require libfdt
with e500 was to not use -kernel, which
Due to popular demand, let's clean up the soc node a bit and use
more recent dt notions.
Requested-by: Scott Wood
Signed-off-by: Alexander Graf
---
hw/ppce500_mpc8544ds.c |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544
Am 05.06.2012 21:03, schrieb Jan Kiszka:
> A type definition and a KVMState field initialization escaped the
> required wrapping with KVM_CAP_IRQ_ROUTING. Also, we need to provide a
> dummy kvm_irqchip_release_virq as virtio-pci references (but does not
> use) it.
>
> Signed-off-by: Jan Kiszka
T
Phandle references work by having 2 pieces:
- a "phandle" 1-cell property in the device tree node
- a reference to the same value in a property we want to point
to the other node
To generate the 1-cell property, we need an allocation mechanism that
gives us a unique number space. This pat
On Tue, Jun 05, 2012 at 12:09:18PM -0400, Jason Baron wrote:
> I've been creating 256kb rom images with larger acpi tables for second level
> buses. After a recent re-base, my rom images no longer built. Bisected to:
>
> commit 46b82624c95b951e8825fab117d9352faeae0ec8
> Author: Kevin O'Connor
> D
Due to popular demand, we're updating the way we generate the MPIC
node and interrupt lines based on what the current state of art is.
Requested-by: Scott Wood
Signed-off-by: Alexander Graf
---
hw/ppce500_mpc8544ds.c | 33 ++---
roms/openbios |2 +-
2
Some times in the device tree, we find an array of 2 u32 cells that
really are a single u64 value. This patch adds a helper to make the
creation of these easy.
Signed-off-by: Alexander Graf
---
v1 -> v2:
- rename cell64 -> u64
---
device_tree.c |7 +++
device_tree.h |2 ++
2 fil
Hi Kevin, please take a look at the attached simple patches.
Paolo
Paolo Bonzini (2):
qemu-iotests: fill streaming test image with data
qemu-iotests: start vms in qtest mode
tests/qemu-iotests/030| 15 +--
tests/qemu-iotests/iotests.py |4 +++-
2 files changed, 16
Signed-off-by: Alexander Graf
---
hw/ppce500_mpc8544ds.c |9 +
pc-bios/mpc8544ds.dts |6 --
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/hw/ppce500_mpc8544ds.c b/hw/ppce500_mpc8544ds.c
index 3d073dd..3f6c6e3 100644
--- a/hw/ppce500_mpc8544ds.c
+++ b/hw/ppce5
We have device tree helpers that allow us to create single cell (u32)
wide properties. However, when creating properties that contain an array of
cells, we need to jump through hoops, manually passing in an array with
converted endianness.
To ease the pain of this a bit, create helpers for the mos
We want to be able to support >= 4GB of RAM. To do so, we need to be able
to tell the guest OS how much RAM it has.
However, that information today is capped to 32bit. So let's extend the
offset and size fields to 64bit, so we can fit in big addresses and even
one day - if we wish to do so - map d
On 06/05/2012 06:06 PM, Avi Kivity wrote:
On 06/05/2012 04:00 AM, Michael Roth wrote:
In addition, QC can decide at run time whether to
+suppress a field by assigning it a **default** value.
+
+## Immutable Fields
+
+If a field is only set during device construction, based on parameters passed
Am 05.06.2012 09:16, schrieb Jens Freimann:
> In kvm-all.c an #ifdef KVM_CAP_IRQ_ROUTING was missing in two
> places which broke the build when this capability is not enabled.
> Found when building the s390-softmmu target.
>
> Signed-off-by: Jens Freimann
A patch by Jan moves the first chunk ins
On 06/06/2012 03:56 AM, Paolo Bonzini wrote:
Il 05/06/2012 18:21, Michael Roth ha scritto:
The only way I can think of getting around this is to do nasty things
like adding an
#include "qapi-generated/mc146818rtc-qapi-visit.c";
in hw/mc146818rtc.c.
It doesn't look that ugly, though perhaps I
On 06/05/2012 08:19 PM, Gerd Hoffmann wrote:
Hi,
Suggestion: add a _guest marker for ordinary state. Fail the build on
unmarked fields. This ensures that some thought is given to each field,
instead of having a default that may be correct most of the time, but
not always.
Suggestion: ad
On 06/05/2012 06:26 PM, Avi Kivity wrote:
On 06/05/2012 04:00 AM, Michael Roth wrote:
Initial check-in of the qidl-generated vmstate fields for rtc.
Don't, please.
As Mike said in another note, we want to keep the device schema in the tree so
we can determine when it changes in 'make check
On 06/06/2012 05:44 AM, Michael Roth wrote:
On Tue, Jun 05, 2012 at 04:08:55PM +0200, Paolo Bonzini wrote:
Il 05/06/2012 03:00, Michael Roth ha scritto:
Signed-off-by: Michael Roth
---
qapi/qc.h | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
create mode 100644 qapi/q
On Wed, Jun 06, 2012 at 07:03:06AM +0800, Anthony Liguori wrote:
> On 06/05/2012 09:10 PM, Borislav Petkov wrote:
> >On Tue, Jun 05, 2012 at 10:01:17PM +0900, Yoshihiro YUNOMAE wrote:
> >>This patch adds a ring-buffer driver for IVShmem device, a virtual RAM
> >>device in
> >>QEMU. This driver can
On 06/06/2012 06:06 AM, Paul Moore wrote:
On Tuesday, June 05, 2012 11:51:40 PM Alexander Graf wrote:
On 05.06.2012, at 23:45, Paul Moore wrote:
On Tuesday, June 05, 2012 03:08:26 AM Alexander Graf wrote:
Which gets me to a new idea. Why not exit(1) when we detect FIPS and a
password is set? I
On 06/05/2012 09:10 PM, Borislav Petkov wrote:
On Tue, Jun 05, 2012 at 10:01:17PM +0900, Yoshihiro YUNOMAE wrote:
This patch adds a ring-buffer driver for IVShmem device, a virtual RAM device in
QEMU. This driver can be used as a ring-buffer for kernel logging or tracing of
a guest OS by recordi
Enabling or disabling the write cache is done with the SET FEATURES
command. The command can be issued with sg_sat_set_features from
sg3-utils.
Signed-off-by: Paolo Bonzini
---
hw/ide/core.c | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/hw/ide/core
Formats are entirely in charge of flushes for metadata writes. For
guest-initiated writes, a writethrough cache is faked in the block layer.
So we can always open in writeback mode.
Signed-off-by: Paolo Bonzini
---
block.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a
This is v3 of the alternative implementation of writethrough caching
for QEMU 1.2. By always opening drivers in writethrough mode and
doing flushes manually after every write, it achieves three objectives:
1) it makes flipping the cache mode extremely easy; 2) it lets formats
control flushes durin
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
block.c |5 +
block.h |1 +
2 files changed, 6 insertions(+)
diff --git a/block.c b/block.c
index 9bff401..e4396a6 100644
--- a/block.c
+++ b/block.c
@@ -2380,6 +2380,11 @@ int bdrv_enable_write_cache(BlockDriverState *bs)
Because the guest will be able to flip enable_write_cache, the actual
state may not match what is used to open the new snapshot.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
block.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/block.c b/block.c
index 7538112..9bff401 1
Writethrough does not need special-casing anymore in the qcow2 caches.
The block layer adds flushes after every guest-initiated data write,
and these will also flush the qcow2 caches to the OS.
Signed-off-by: Paolo Bonzini
---
block/qcow2-cache.c| 25 ++---
block/qcow2-
On 01.06.2012, at 00:12, Scott Wood wrote:
> On 05/30/2012 06:00 AM, Alexander Graf wrote:
>> Signed-off-by: Alexander Graf
>> ---
>> hw/ppce500_mpc8544ds.c | 50
>>
>> pc-bios/mpc8544ds.dtb | Bin 1810 -> 72 bytes
>> pc-bios/mpc8544ds.dts |
On Tue, Jun 05, 2012 at 03:42:30PM +0300, Avi Kivity wrote:
> On 06/05/2012 01:40 PM, Jan Kiszka wrote:
> > On 2012-06-05 12:25, Avi Kivity wrote:
> >> On 06/05/2012 04:00 AM, Michael Roth wrote:
> >>> Add our annotations according to QIDL documentation.
> >>>
> >>> +qc_declaration typedef struct R
On Tuesday, June 05, 2012 11:51:40 PM Alexander Graf wrote:
> On 05.06.2012, at 23:45, Paul Moore wrote:
> > On Tuesday, June 05, 2012 03:08:26 AM Alexander Graf wrote:
> >> Which gets me to a new idea. Why not exit(1) when we detect FIPS and a
> >> password is set? I agree with the assessment that
Writing vm state uses bdrv_pwrite, so it will automatically get flushes
in writethrough mode. But doing a flush at the end in writeback mode
is probably a good idea anyway.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
savevm.c |2 +-
1 file changed, 1 insertion(+), 1 deletion
We want to make the formats handle their own flushes
autonomously, while keeping for guests the ability to use a writethrough
cache. Since formats will write metadata via bs->file, bdrv_co_do_writev
is the only place where we need to add a flush.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin
On 05.06.2012, at 23:45, Paul Moore wrote:
> On Tuesday, June 05, 2012 03:08:26 AM Alexander Graf wrote:
>> Which gets me to a new idea. Why not exit(1) when we detect FIPS and a
>> password is set? I agree with the assessment that we should never silently
>> drop features. So the best way to mak
On Tuesday, June 05, 2012 03:08:26 AM Alexander Graf wrote:
> Which gets me to a new idea. Why not exit(1) when we detect FIPS and a
> password is set? I agree with the assessment that we should never silently
> drop features. So the best way to make sure that the user knows he did
> something stup
On Tue, Jun 05, 2012 at 04:08:55PM +0200, Paolo Bonzini wrote:
> Il 05/06/2012 03:00, Michael Roth ha scritto:
> > Signed-off-by: Michael Roth
> > ---
> > qapi/qc.h | 11 +++
> > 1 files changed, 11 insertions(+), 0 deletions(-)
> > create mode 100644 qapi/qc.h
> >
> > diff --git a/qa
On 06/05/2012 09:38 PM, Eric Blake wrote:
On 06/05/2012 07:15 AM, Gerd Hoffmann wrote:
Hi,
Absolutely not. This is hideously ugly and affects a bunch of code.
Spice is *not* getting a hook in migration where it gets to add
arbitrary amounts of downtime to the migration traffic. That's a
Il 05/06/2012 16:49, Markus Armbruster ha scritto:
> With this and the related fix for xen applied, block_int.h is finally
> gone from hw/.
>
> Markus Armbruster (2):
> block: New bdrv_get_flags()
> scsi-disk: Don't peek behind the BlockDriverState abstraction
>
> block.c|5 +
Il 05/06/2012 23:14, Eric Blake ha scritto:
> On 06/05/2012 03:02 PM, Paolo Bonzini wrote:
>> Il 22/05/2012 12:45, Laszlo Ersek ha scritto:
>>> +if (sock->has_fd + sock->has_listen + sock->has_connect +
>>> sock->has_mcast +
>>> +sock->has_udp != 1) {
>>
>> Please add a cast, this does
On 06/05/2012 03:02 PM, Paolo Bonzini wrote:
> Il 22/05/2012 12:45, Laszlo Ersek ha scritto:
>> +if (sock->has_fd + sock->has_listen + sock->has_connect +
>> sock->has_mcast +
>> +sock->has_udp != 1) {
>
> Please add a cast, this doesn't work with C99 bool.
Huh? Where does C99 state
Il 22/05/2012 12:45, Laszlo Ersek ha scritto:
> Inspired by [1], the first half of this series attempts to implement a new
> visitor that should clean up defining and processing command line options.
> For a more detailed description, please see "[PATCH 04/16] qapi: introduce
> OptsVisitor".
>
> T
Il 22/05/2012 12:45, Laszlo Ersek ha scritto:
> This visitor supports parsing
>
> -option [type=]discriminator[,optarg1=val1][,optarg2=val2][,...]
>
> style QemuOpts objects into "native" C structures. After defining the type
> tree in the qapi schema (see below), a root type traversal with thi
On Tue, Jun 05, 2012 at 01:06:10PM +0300, Avi Kivity wrote:
> On 06/05/2012 04:00 AM, Michael Roth wrote:
> > This is an import of Anthony's qidl compiler, with some changes squashed
> > in to add support for doing the visitor generation via QEMU's qapi code
> > generators rather than directly.
> >
1 - 100 of 242 matches
Mail list logo
