Re: [Qemu-devel] [QEMU] net: adapt dump to support the new syntax

2012-05-16 Thread Zhi Yong Wu
On Mon, Feb 6, 2012 at 6:18 AM, Paolo Bonzini wrote: > On 01/24/2012 11:42 AM, Stefan Hajnoczi wrote: >> >> I refactored the network subsystem to drop the "VLAN" concept a while >> back but never got around to submitting the patches: >> >> http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/

[Qemu-devel] [RFC PATCH V1 2/2] target-microblaze: lwx/swx: first implementation

2012-05-16 Thread Peter A. G. Crosthwaite
Signed-off-by: Peter A. G. Crosthwaite --- target-microblaze/cpu.h |1 + target-microblaze/helper.c|2 + target-microblaze/translate.c | 51 ++-- 3 files changed, 51 insertions(+), 3 deletions(-) diff --git a/target-microblaze/cpu.h b/targe

[Qemu-devel] [RFC PATCH V1 1/2] target-microblaze: impelemented swapx instructions

2012-05-16 Thread Peter A. G. Crosthwaite
Implemented the swapb and swaph byte/halfword reversal instructions added to microblaze v8.30 Signed-off-by: Peter A. G. Crosthwaite --- target-microblaze/translate.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/target-microblaze/translate.c b/target-micro

[Qemu-devel] [RFC PATCH V1 0/2] Microblaze CPU model v8.30 updates

2012-05-16 Thread Peter A. G. Crosthwaite
Microblaze CPU v8.30 has some new instructions that are implemented in this instructions are: swapb, swaph (PATCH 1) lwx, swx (PATCH 2) Peter A. G. Crosthwaite (2): target-microblaze: impelemented swapx instructions target-microblaze: lwx/swx: first implementation target-microblaze/cpu.h

Re: [Qemu-devel] [QEMU] net: adapt dump to support the new syntax

2012-05-16 Thread Zhi Yong Wu
On Mon, Feb 6, 2012 at 6:18 AM, Paolo Bonzini wrote: > On 01/24/2012 11:42 AM, Stefan Hajnoczi wrote: >> >> I refactored the network subsystem to drop the "VLAN" concept a while >> back but never got around to submitting the patches: >> >> http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/

[Qemu-devel] [PATCH] rtl8139: validate rx ring before receiving packets

2012-05-16 Thread Jason Wang
Commit ff71f2e8cacefae99179993204172bc65e4303df prevent the possible crash during initialization of linux driver by checking the operating mode.This seems too strict as: - the real card could still work in mode other than normal - some buggy driver who does not set correct opmode after eeprom acc

Re: [Qemu-devel] [PATCH 04/13] pci: New pci_dma_quirk()

2012-05-16 Thread Alex Williamson
On Thu, 2012-05-17 at 13:39 +1000, David Gibson wrote: > On Fri, May 11, 2012 at 04:55:55PM -0600, Alex Williamson wrote: > > Integrating IOMMU groups more closely into the driver core allows > > us to more easily work around DMA quirks. The Ricoh multifunction > > controller is a favorite example

Re: [Qemu-devel] [PATCH 03/13] iommu: IOMMU groups for VT-d and AMD-Vi

2012-05-16 Thread David Gibson
On Fri, May 11, 2012 at 04:55:48PM -0600, Alex Williamson wrote: > Add back group support for AMD & Intel. amd_iommu already tracks > devices and has init and uninit routines to manage groups. > intel-iommu does this on the fly, so we make use of the notifier > support built into iommu groups to c

Re: [Qemu-devel] [PATCH 04/13] pci: New pci_dma_quirk()

2012-05-16 Thread David Gibson
On Fri, May 11, 2012 at 04:55:55PM -0600, Alex Williamson wrote: > Integrating IOMMU groups more closely into the driver core allows > us to more easily work around DMA quirks. The Ricoh multifunction > controller is a favorite example of devices that are currently > incompatible with IOMMU isolat

Re: [Qemu-devel] [PATCH 02/13] iommu: IOMMU Groups

2012-05-16 Thread David Gibson
On Tue, May 15, 2012 at 12:34:03AM -0600, Alex Williamson wrote: > On Tue, 2012-05-15 at 12:03 +1000, David Gibson wrote: > > On Mon, May 14, 2012 at 11:11:42AM -0600, Alex Williamson wrote: > > > On Mon, 2012-05-14 at 11:16 +1000, David Gibson wrote: > > > > On Fri, May 11, 2012 at 04:55:41PM -060

Re: [Qemu-devel] [RFC/PATCH] Add a memory barrier to guest memory access functions

2012-05-16 Thread David Gibson
On Wed, May 16, 2012 at 09:28:39PM -0500, Anthony Liguori wrote: > On 05/16/2012 07:52 PM, Benjamin Herrenschmidt wrote: [snip] > >@@ -2794,6 +2795,9 @@ void *qemu_get_ram_ptr(ram_addr_t addr) > > { > > RAMBlock *block; > > > >+/* We ensure ordering for all DMA transactions */ > >+dma

Re: [Qemu-devel] [RFC PATCH] qemu spapr-pci: added IRQ list to PCIBus

2012-05-16 Thread Alexey Kardashevskiy
On 17/05/12 13:00, Benjamin Herrenschmidt wrote: > On Thu, 2012-05-17 at 12:16 +1000, Alexey Kardashevskiy wrote: > >>> It actually can change dynamically on x86 due to acpi interrupt links >>> which allow the guest a generic way to select from a set of possible >>> interrupt routing schemes. And

Re: [Qemu-devel] [RFC PATCH] qemu spapr-pci: added IRQ list to PCIBus

2012-05-16 Thread Alex Williamson
On Thu, 2012-05-17 at 13:00 +1000, Benjamin Herrenschmidt wrote: > On Thu, 2012-05-17 at 12:16 +1000, Alexey Kardashevskiy wrote: > > > > It actually can change dynamically on x86 due to acpi interrupt links > > > which allow the guest a generic way to select from a set of possible > > > interrupt

[Qemu-devel] Is it possible to retrieve pre-process information in QEMU?

2012-05-16 Thread 陳韋任
Hi all, I would like to know if I can retrieve pre-process information in QEMU system mode. For example, I want to know each process's page fault ratio. Is there a way to do that? Thanks. Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia

Re: [Qemu-devel] [RFC PATCH] qemu spapr-pci: added IRQ list to PCIBus

2012-05-16 Thread Benjamin Herrenschmidt
On Thu, 2012-05-17 at 12:16 +1000, Alexey Kardashevskiy wrote: > > It actually can change dynamically on x86 due to acpi interrupt links > > which allow the guest a generic way to select from a set of possible > > interrupt routing schemes. And of course a chipset driver could twiddle > > bits if

[Qemu-devel] [PATCH v6 4/7] RTC: Add divider reset support

2012-05-16 Thread Zhang, Yang Z
The first update cycle begins one - half seconds later when divider reset is removing. Signed-off-by: Yang Zhang --- hw/mc146818rtc.c | 46 -- 1 files changed, 40 insertions(+), 6 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index

Re: [Qemu-devel] [RFC/PATCH] Add a memory barrier to guest memory access functions

2012-05-16 Thread Benjamin Herrenschmidt
On Wed, 2012-05-16 at 21:28 -0500, Anthony Liguori wrote: > > @@ -2794,6 +2795,9 @@ void *qemu_get_ram_ptr(ram_addr_t addr) > > { > > RAMBlock *block; > > > > +/* We ensure ordering for all DMA transactions */ > > +dma_mb(); > > + > > I get being conservative, but I don't think th

[Qemu-devel] [PATCH v6 7/7] RTC:Allow to migrate from old QEMU

2012-05-16 Thread Zhang, Yang Z
The new logic is compatible with old. So should not block to migrate from old QEMU. But new version cannot migrate to old. Signed-off-by: Yang Zhang --- hw/mc146818rtc.c | 43 --- 1 files changed, 40 insertions(+), 3 deletions(-) diff --git a/hw/mc14681

Re: [Qemu-devel] [QEMU 1.1 PATCH] Expose CPUID leaf 7 only for -cpu host

2012-05-16 Thread Anthony Liguori
On 05/16/2012 03:58 PM, Eduardo Habkost wrote: Description of the bug: Since QEMU 0.15, the CPUID information on CPUID[EAX=7,ECX=0] is being returned unfiltered to the guest, directly from the GET_SUPPORTED_CPUID return value. The problem is that this makes the resulting CPU feature flags unpre

[Qemu-devel] [PATCH] ui/vnc: Only report/use TIGHT_PNG encoding if enabled.

2012-05-16 Thread Joel Martin
If TIGHT_PNG is not enabled by the --enable-vnc-png configure flag then do not report to the client that it is supported. Also, since TIGHT_PNG is the same as the TIGHT encoding but with the filter/copy replaced with PNG data, adding it to the supported encodings list when it is disabled will caus

[Qemu-devel] [Bug 498035] Re: qemu hangs on shutdown or reboot (XP guest)

2012-05-16 Thread Brian W. Neu
Confirming under Fedora 15, qemu 14.0 Very frustrating for clients using Microsoft RDP who just get a blank blue screen when it is stuck like this. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/49803

[Qemu-devel] [PATCH v6 6/7] RTC:Add alarm support

2012-05-16 Thread Zhang, Yang Z
Use a timer to emulate alarm. The timer runs only when the AF is cleared. Signed-off-by: Yang Zhang --- hw/mc146818rtc.c | 276 ++ 1 files changed, 257 insertions(+), 19 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index 461e

[Qemu-devel] [PATCH v6 5/7] RTC:Add RTC update-ended interrupt support

2012-05-16 Thread Zhang, Yang Z
There are no need to run a periodic timer to emulate updated-end logic. Only run the timer when the UF is cleared. Signed-off-by: Yang Zhang --- hw/mc146818rtc.c | 95 + 1 files changed, 87 insertions(+), 8 deletions(-) diff --git a/hw/mc146

[Qemu-devel] [PATCH v6 3/7] RTC: Add UIP(update in progress) check logic

2012-05-16 Thread Zhang, Yang Z
The UIP will be set when updating cycle begins and cleared after updated cycle ended. Signed-off-by: Yang Zhang --- hw/mc146818rtc.c | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index 24db5cf..b03c420 100644 --- a

[Qemu-devel] [PATCH v6 1/7] RTC: Remove the logic to update time format when DM bit changed

2012-05-16 Thread Zhang, Yang Z
Change DM(date mode) and 24/12 control bit doesn't affect the internal registers. It only indicates what format is using for those registers. Signed-off-by: Yang Zhang --- hw/mc146818rtc.c | 10 +- 1 files changed, 1 insertions(+), 9 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc1

[Qemu-devel] [PATCH v6 2/7] RTC: Update the RTC clock only when reading it

2012-05-16 Thread Zhang, Yang Z
Use offset instead of timer to calculate guest rtc. Guest rtc is calculated by (base_rtc + guest_time_now - guest_time_last_update_rtc + offset). Base_rtc means the rtc value of last update. Guest_time_now means the guest time that access happens. Guest_time_last_update means the guest time of la

Re: [Qemu-devel] [RFC/PATCH] Add a memory barrier to guest memory access functions

2012-05-16 Thread Anthony Liguori
On 05/16/2012 07:52 PM, Benjamin Herrenschmidt wrote: The emulated devices can run simultaneously with the guest, so we need to be careful with ordering of load and stores done by them to the guest system memory, which need to be observed in the right order by the guest operating system. In orde

[Qemu-devel] [PATCH v6 0/7] RTC: New logic to emulate RTC

2012-05-16 Thread Zhang, Yang Z
Changes in v6: Rebase to latest QEMU Fix a bug that fail to pass tests/rtc-test: In previous version, it uses host time as the base point to calculate guest RTC. It works when guest uses host based clock. But for vm and rt based clock, it's wrong. Because guest's clock may not synchronous

Re: [Qemu-devel] [RFC PATCH] qemu spapr-pci: added IRQ list to PCIBus

2012-05-16 Thread Alexey Kardashevskiy
On 17/05/12 06:39, Alex Williamson wrote: > On Mon, 2012-05-14 at 14:21 +1000, Alexey Kardashevskiy wrote: >> On 14/05/12 11:58, David Gibson wrote: >>> On Sat, May 12, 2012 at 05:29:53PM +1000, Alexey Kardashevskiy wrote: There is a need for a mechanism to obtain an IRQ line number to in

[Qemu-devel] buildbot failure in qemu on default_x86_64_rhel61

2012-05-16 Thread qemu
The Buildbot has detected a new failure on builder default_x86_64_rhel61 while building qemu. Full details are available at: http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel61/builds/266 Buildbot URL: http://buildbot.b1-systems.de/qemu/ Buildslave for this Build: kraxel_rhel61 B

[Qemu-devel] [RFC/PATCH] Add a memory barrier to guest memory access functions

2012-05-16 Thread Benjamin Herrenschmidt
The emulated devices can run simultaneously with the guest, so we need to be careful with ordering of load and stores done by them to the guest system memory, which need to be observed in the right order by the guest operating system. In order to avoid unnecessary overhead on i386, we define a new

Re: [Qemu-devel] [PATCH 13/13] iommu: Add a memory barrier to DMA RW function

2012-05-16 Thread Benjamin Herrenschmidt
On Thu, 2012-05-17 at 10:07 +1000, Benjamin Herrenschmidt wrote: .../... > Also, should I make the barrier conditional to kvm_enabled() ? IE. It's > pointless in full emulation and might actually be a performance hit on > something already quite slow... Finally ... something like smp_mb() in qe

Re: [Qemu-devel] [PATCH 2/2] Get system state configuration from QEMU and patcth DSDT with it.

2012-05-16 Thread Kevin O'Connor
On Wed, May 16, 2012 at 05:50:31PM +0200, Paolo Bonzini wrote: > Il 16/05/2012 15:46, Gleb Natapov ha scritto: > > I saw that, but I don't get why doing it this way instead of defining > > the object in AML and patching it? I can define Name(S4VL, 0x2) and path > > 0x2 to whatever QEMU wants me to

Re: [Qemu-devel] [PATCH 2/2] Get system state configuration from QEMU and patcth DSDT with it.

2012-05-16 Thread Kevin O'Connor
On Wed, May 16, 2012 at 04:46:57PM +0300, Gleb Natapov wrote: > On Tue, May 15, 2012 at 07:18:10PM -0400, Kevin O'Connor wrote: > > As in the other recent discussion, a struct can be built by the BIOS > > and a pointer passed in via a dynamic SSDT (eg, BDAT). Whatever data > > is needed can then b

Re: [Qemu-devel] [PATCH 13/13] iommu: Add a memory barrier to DMA RW function

2012-05-16 Thread Benjamin Herrenschmidt
So followup For those on the list: Anthony and I had a chat and we agree that a better thing to do is to have all cpu_physical_memory_* accesses to be ordered in program order from the perspective of the VCPUs. Devices that have performance critical accesses and want to do home made ordering

Re: [Qemu-devel] [PATCH next v2 00/74] QOM CPUState, part 3: CPU reset

2012-05-16 Thread Andreas Färber
Am 10.05.2012 02:13, schrieb Andreas Färber: > Andreas Färber (74): [...] > target-sh4: Let cpu_sh4_init() return SuperHCPU > r2d: Use cpu_sh4_init() to obtain SuperHCPU > r2d: Store SuperHCPU in ResetData Seeing that no one currently cares about sh4, I have re-tested the r2d test image and

Re: [Qemu-devel] [PATCH 13/13] iommu: Add a memory barrier to DMA RW function

2012-05-16 Thread Benjamin Herrenschmidt
On Thu, 2012-05-17 at 07:10 +1000, Benjamin Herrenschmidt wrote: > I have a long experience with dealing with ordering issues on large SMP > systems and believe me, anything "fine grained" is really really hard to > generally get right, and the resulting bugs are really nasty to track > down and e

Re: [Qemu-devel] [PATCH 13/13] iommu: Add a memory barrier to DMA RW function

2012-05-16 Thread Benjamin Herrenschmidt
On Wed, 2012-05-16 at 14:39 -0500, Anthony Liguori wrote: > I must confess, I have no idea what PCI et al guarantee with respect to > ordering. What's nasty about this patch is that you're not just ordering wrt > device writes/reads, but also with the other VCPUs. I don't suspect this > would

Re: [Qemu-devel] [PATCHv2 2/6] qemu-ga: don't leak a file descriptor upon failed lockf

2012-05-16 Thread Michael Roth
On Wed, May 16, 2012 at 10:19:55PM +0200, Jim Meyering wrote: > > Signed-off-by: Jim Meyering Acked-by: Michael Roth > --- > > qemu-ga.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/qemu-ga.c b/qemu-ga.c > index 680997e..24b236a 100644 > --- a/qemu-ga.c > +++ b/qemu-ga.c > @@

[Qemu-devel] [QEMU 1.1 PATCH] Expose CPUID leaf 7 only for -cpu host

2012-05-16 Thread Eduardo Habkost
Description of the bug: Since QEMU 0.15, the CPUID information on CPUID[EAX=7,ECX=0] is being returned unfiltered to the guest, directly from the GET_SUPPORTED_CPUID return value. The problem is that this makes the resulting CPU feature flags unpredictable and dependent on the host CPU and kernel

Re: [Qemu-devel] [PATCH next v2 73/74] linux-user: Use cpu_reset() after cpu_init() / cpu_copy()

2012-05-16 Thread Igor Mammedov
- Original Message - > From: "Peter Maydell" > To: "Igor Mammedov" > Cc: qemu-devel@nongnu.org > Sent: Wednesday, May 16, 2012 6:13:37 PM > Subject: Re: [Qemu-devel] [PATCH next v2 73/74] linux-user: Use cpu_reset() > after cpu_init() / cpu_copy() > > On 16 May 2012 17:05, Igor Mammedov

Re: [Qemu-devel] [RFC PATCH] qemu spapr-pci: added IRQ list to PCIBus

2012-05-16 Thread Alex Williamson
On Mon, 2012-05-14 at 14:21 +1000, Alexey Kardashevskiy wrote: > On 14/05/12 11:58, David Gibson wrote: > > On Sat, May 12, 2012 at 05:29:53PM +1000, Alexey Kardashevskiy wrote: > >> There is a need for a mechanism to obtain an IRQ line number to > >> initialize End-Of-Interrupt handler. > >> > >>

Re: [Qemu-devel] [RFC PATCH 2/2] Split fdd devices off the floppy controller

2012-05-16 Thread Markus Armbruster
Anthony Liguori writes: > On 05/11/2012 10:22 AM, Markus Armbruster wrote: >> For historical reasons, and unlike other block devices, our floppy >> devices isa-fdc, sysbus-fdc and SUNW,fdtwo integrate the controller >> and the drive(s) in a single qdev. This makes them weird: we need >> -global

Re: [Qemu-devel] [PATCH 13/13] iommu: Add a memory barrier to DMA RW function

2012-05-16 Thread Anthony Liguori
On 05/15/2012 11:35 PM, Benjamin Herrenschmidt wrote: +/* HACK: full memory barrier here */ +__sync_synchronize(); I thought you were going to limit this to the TCE iommu? So, it wasn't my intention to send this one with the rest, but I forgot to explain that to Ben when he resent.

[Qemu-devel] [PATCHv2 2/6] qemu-ga: don't leak a file descriptor upon failed lockf

2012-05-16 Thread Jim Meyering
Signed-off-by: Jim Meyering --- qemu-ga.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qemu-ga.c b/qemu-ga.c index 680997e..24b236a 100644 --- a/qemu-ga.c +++ b/qemu-ga.c @@ -246,6 +246,9 @@ static bool ga_open_pidfile(const char *pidfile) pidfd = open(pidfile, O_CREAT|O_WRONLY,

Re: [Qemu-devel] [PATCH 2/6] qemu-ga: avoid unconditional lockfile file descriptor leak

2012-05-16 Thread Jim Meyering
Michael Roth wrote: > On Wed, May 16, 2012 at 03:07:57PM +0200, Jim Meyering wrote: >> From: Jim Meyering >> >> Do not leak a file descriptor. >> Also, do not forget to unlink the lockfile upon failed lockf. >> Always close the lockfile file descriptor, taking care >> to diagnose close, as well as

Re: [Qemu-devel] [RFC PATCH 2/2] Split fdd devices off the floppy controller

2012-05-16 Thread Markus Armbruster
Kevin Wolf writes: > Am 14.05.2012 13:58, schrieb Andreas Färber: >> Am 14.05.2012 10:47, schrieb Kevin Wolf: >>> Am 11.05.2012 17:22, schrieb Markus Armbruster: For historical reasons, and unlike other block devices, our floppy devices isa-fdc, sysbus-fdc and SUNW,fdtwo integrate the c

[Qemu-devel] [PATCH v4 7/8] kvm: Add support for direct MSI injections

2012-05-16 Thread Jan Kiszka
If the kernel supports KVM_SIGNAL_MSI, we can avoid the route-based MSI injection mechanism. Signed-off-by: Jan Kiszka --- kvm-all.c | 22 +++--- 1 files changed, 19 insertions(+), 3 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index ff0534b..d222012 100644 --- a/kvm-all.c

[Qemu-devel] [PATCH v4 5/8] kvm: x86: Wire up MSI support for in-kernel irqchip

2012-05-16 Thread Jan Kiszka
Catch writes to the MSI MMIO region in the KVM APIC and forward them to the kernel. Provide the kernel support GSI routing, this allows to enable MSI support also for in-kernel irqchip mode. Signed-off-by: Jan Kiszka --- hw/kvm/apic.c | 34 -- 1 files changed, 3

Re: [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled()

2012-05-16 Thread Alex Williamson
On Wed, 2012-05-16 at 10:21 -0600, Alex Williamson wrote: > On Wed, 2012-05-16 at 09:29 -0400, Don Dutile wrote: > > On 05/15/2012 05:09 PM, Alex Williamson wrote: > > > On Tue, 2012-05-15 at 13:56 -0600, Bjorn Helgaas wrote: > > >> pci_acs_enabled(02:00.0) = 00:02.0 (acs_dev = 00:02.0, 02:00.0 has

Re: [Qemu-devel] [PATCH 08/13] iommu: Introduce IOMMU emulation infrastructure

2012-05-16 Thread Anthony Liguori
On 05/15/2012 08:20 PM, Benjamin Herrenschmidt wrote: On Tue, 2012-05-15 at 19:54 -0500, Anthony Liguori wrote: You certainly could do that but it may get a little weird dealing with the return path. You'd have to return something like -EWOULDBLOCK and make sure you handle that in the dispatch

Re: [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled()

2012-05-16 Thread Don Dutile
On 05/15/2012 05:09 PM, Alex Williamson wrote: On Tue, 2012-05-15 at 13:56 -0600, Bjorn Helgaas wrote: On Mon, May 14, 2012 at 4:49 PM, Alex Williamson wrote: On Mon, 2012-05-14 at 16:02 -0600, Bjorn Helgaas wrote: On Fri, May 11, 2012 at 4:56 PM, Alex Williamson wrote: In a PCIe environm

[Qemu-devel] [PATCH v4 8/8] kvm: Enable in-kernel irqchip support by default

2012-05-16 Thread Jan Kiszka
As MSI is now fully supported by KVM (/wrt available features in upstream), we can finally enable the in-kernel irqchip by default. Signed-off-by: Jan Kiszka --- kvm-all.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index d222012..1913d6a 10064

Re: [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled()

2012-05-16 Thread Bjorn Helgaas
> I tried to work through some examples to develop some intuition about this: Sorry, gmail inserted line breaks that ruined this picture. Here's a URL for it: http://www.asciiflow.com/#3736558963405980039

Re: [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled()

2012-05-16 Thread Bjorn Helgaas
On Mon, May 14, 2012 at 4:49 PM, Alex Williamson wrote: > On Mon, 2012-05-14 at 16:02 -0600, Bjorn Helgaas wrote: >> On Fri, May 11, 2012 at 4:56 PM, Alex Williamson >> wrote: >> > In a PCIe environment, transactions aren't always required to >> > reach the root bus before being re-routed.  Peer-

[Qemu-devel] [PATCH v4 2/8] Introduce MSIMessage structure

2012-05-16 Thread Jan Kiszka
Will be used for generating and distributing MSI messages, both in emulation mode and under KVM. Signed-off-by: Jan Kiszka --- hw/msi.h |5 + qemu-common.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/msi.h b/hw/msi.h index 3040bb0..75747ab 100644 ---

Re: [Qemu-devel] Add support for new image type

2012-05-16 Thread Kai Meyer
On 05/16/2012 11:48 AM, Paolo Bonzini wrote: Il 16/05/2012 19:06, Kai Meyer ha scritto: 1) It's been suggested to me that since we have the rights to distribute our closed source shared library, there is a precedence for being able to distributed a modified version of qemu that does run-time lin

Re: [Qemu-devel] Add support for new image type

2012-05-16 Thread Kai Meyer
On 03/01/2012 11:54 PM, Paolo Bonzini wrote: It does not matter whether it is upstream or not. When you distribute your modified QEMU binary, anyone who receives it has the right to ask you for the complete corresponding source code. I also suggest that you write a wrapper around your library

[Qemu-devel] [PATCH v4 6/8] kvm: Update kernel headers

2012-05-16 Thread Jan Kiszka
Corresponding kvm.git hash: f2569053e0 Signed-off-by: Jan Kiszka --- linux-headers/linux/kvm.h | 38 ++ 1 files changed, 38 insertions(+), 0 deletions(-) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index ee7bd9c..c4426ec 100644 --- a/

Re: [Qemu-devel] [PATCH] Add event notification for guest balloon changes

2012-05-16 Thread Luiz Capitulino
On Wed, 16 May 2012 13:58:34 -0500 Anthony Liguori wrote: > On 05/16/2012 01:42 PM, Luiz Capitulino wrote: > > On Wed, 16 May 2012 11:10:47 +0100 > > "Daniel P. Berrange" wrote: > > > >> From: "Daniel P. Berrange" > >> > >> After setting a balloon target value, applications have to > >> continua

Re: [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled()

2012-05-16 Thread Alex Williamson
On Tue, 2012-05-15 at 13:56 -0600, Bjorn Helgaas wrote: > On Mon, May 14, 2012 at 4:49 PM, Alex Williamson > wrote: > > On Mon, 2012-05-14 at 16:02 -0600, Bjorn Helgaas wrote: > >> On Fri, May 11, 2012 at 4:56 PM, Alex Williamson > >> wrote: > >> > In a PCIe environment, transactions aren't alway

Re: [Qemu-devel] [PATCH] Add event notification for guest balloon changes

2012-05-16 Thread Anthony Liguori
On 05/16/2012 01:42 PM, Luiz Capitulino wrote: On Wed, 16 May 2012 11:10:47 +0100 "Daniel P. Berrange" wrote: From: "Daniel P. Berrange" After setting a balloon target value, applications have to continually poll 'query-balloon' to determine whether the guest has reacted to this request. The

Re: [Qemu-devel] Add support for new image type

2012-05-16 Thread Kai Meyer
On 05/16/2012 12:21 PM, Anthony Liguori wrote: On 05/16/2012 12:48 PM, Paolo Bonzini wrote: Il 16/05/2012 19:06, Kai Meyer ha scritto: 1) It's been suggested to me that since we have the rights to distribute our closed source shared library, there is a precedence for being able to distributed

[Qemu-devel] [Bug 735454] Re: live kvm migration with non-shared storage corrupts file system

2012-05-16 Thread Sebastian J. Bronner
Now that Ubuntu 12.04 LTS is out, I retested. All my tests ran OK. As long as the local I/O was too high for the migration transfer speed, the migration wouldn't complete. When reduced far enough, migration completed successfully. The I/O on both nodes looked as one would expect now, and fsck di

[Qemu-devel] [PATCH v4 4/8] pc: Enable MSI support at APIC level

2012-05-16 Thread Jan Kiszka
Push msi_supported enabling to the APIC implementations where we can encapsulate the decision more cleanly, hiding the details from the generic code. Acked-by: Stefano Stabellini Signed-off-by: Jan Kiszka --- hw/apic.c |3 +++ hw/pc.c |9 - hw/xen.h | 10 ---

[Qemu-devel] [Bug 882997] Re: 64-bit linux guests fail to start on oneiric running 3.0 kernel

2012-05-16 Thread Serge Hallyn
Seems like this may be the same bug as 997311? I want to try installing grub1 into a lucid VM and see if I can get that to crash. ** Changed in: qemu-kvm (Ubuntu) Status: Incomplete => New ** Tags added: grub -- You received this bug notification because you are a member of qemu- devel-

Re: [Qemu-devel] [PATCH] Add event notification for guest balloon changes

2012-05-16 Thread Luiz Capitulino
On Wed, 16 May 2012 11:10:47 +0100 "Daniel P. Berrange" wrote: > From: "Daniel P. Berrange" > > After setting a balloon target value, applications have to > continually poll 'query-balloon' to determine whether the > guest has reacted to this request. The virtio-balloon backend > knows exactly

[Qemu-devel] [PATCH v4 3/8] kvm: Introduce basic MSI support for in-kernel irqchips

2012-05-16 Thread Jan Kiszka
This patch basically adds kvm_irqchip_send_msi, a service for sending arbitrary MSI messages to KVM's in-kernel irqchip models. As the original KVM API requires us to establish a static route from a pseudo GSI to the target MSI message and inject the MSI via toggling that virtual IRQ, we need to p

[Qemu-devel] [PATCH v4 1/8] kvm: Refactor KVMState::max_gsi to gsi_count

2012-05-16 Thread Jan Kiszka
Instead of the bitmap size, store the maximum of GSIs the kernel support. Move the GSI limit assertion to the API function kvm_irqchip_add_route and make it stricter. Signed-off-by: Jan Kiszka --- kvm-all.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/kvm-all.c

[Qemu-devel] [PATCH 1.1 0/4] sheepdog: various sheepdog fixes

2012-05-16 Thread MORITA Kazutaka
This patchset contains various fixes for Sheepdog. See individual patches for details. MORITA Kazutaka (4): sheepdog: mark image as snapshot when tag is specified sheepdog: fix return value of do_load_save_vm_state sheepdog: return -errno on error sheepdog: use heap instead of stack for B

[Qemu-devel] [PATCH v4 0/8] uq/master: MSI support for in-kernel irqchip mode

2012-05-16 Thread Jan Kiszka
Only minor change in v4: - fixed bisectability issue caused by "pc: Enable MSI support at APIC level" - renamed kvm_get_pseudo_gsi to kvm_irqchip_get_virq - introduce kvm_irqchip_release_virq directly (to avoid renaming in a later series) Jan Kiszka (8): kvm: Refactor KVMState::max_gsi

[Qemu-devel] [PATCH 1.1 4/4] sheepdog: use heap instead of stack for BDRVSheepdogState

2012-05-16 Thread MORITA Kazutaka
bdrv_create() is called in coroutine context now, so we cannot use more stack than 1 MB in the function if we use ucontext coroutine. This patch allocates BDRVSheepdogState, whose size is 4 MB, on the heap in sd_create(). Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 35 +++

Re: [Qemu-devel] [PATCH v10 8/9] Add set_cachesize command

2012-05-16 Thread Eric Blake
On 05/16/2012 05:59 AM, Orit Wasserman wrote: > Change XBZRLE cache size in bytes (the size should be a power of 2). > If XBZRLE cache size is too small there will be many cache miss. > > Signed-off-by: Benoit Hudzia > Signed-off-by: Petter Svard > Signed-off-by: Aidan Shribman > Signed-off-by:

Re: [Qemu-devel] [PATCH 2/2] Get system state configuration from QEMU and patcth DSDT with it.

2012-05-16 Thread Gleb Natapov
On Wed, May 16, 2012 at 06:47:55PM +0200, Paolo Bonzini wrote: > Il 16/05/2012 18:40, Gleb Natapov ha scritto: > > On Wed, May 16, 2012 at 05:50:31PM +0200, Paolo Bonzini wrote: > >> Il 16/05/2012 15:46, Gleb Natapov ha scritto: > >>> I saw that, but I don't get why doing it this way instead of def

Re: [Qemu-devel] [PATCH 2/2] Get system state configuration from QEMU and patcth DSDT with it.

2012-05-16 Thread Gleb Natapov
On Wed, May 16, 2012 at 05:50:31PM +0200, Paolo Bonzini wrote: > Il 16/05/2012 15:46, Gleb Natapov ha scritto: > > I saw that, but I don't get why doing it this way instead of defining > > the object in AML and patching it? I can define Name(S4VL, 0x2) and path > > 0x2 to whatever QEMU wants me to

Re: [Qemu-devel] [PATCH v3 3/8] kvm: Introduce basic MSI support for in-kernel irqchips

2012-05-16 Thread Marcelo Tosatti
On Wed, May 16, 2012 at 08:15:37AM -0300, Jan Kiszka wrote: > On 2012-05-16 00:27, Marcelo Tosatti wrote: > > On Thu, May 10, 2012 at 06:02:52PM -0300, Jan Kiszka wrote: > >> This patch basically adds kvm_irqchip_send_msi, a service for sending > >> arbitrary MSI messages to KVM's in-kernel irqchip

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Anthony Liguori
On 05/16/2012 12:26 PM, Amit Shah wrote: On (Wed) 16 May 2012 [14:45:34], Daniel P. Berrange wrote: On Wed, May 16, 2012 at 08:24:22AM -0500, Anthony Liguori wrote: On 05/16/2012 06:30 AM, Amit Shah wrote: The Linux kernel already has a virtio-rng driver, this is the device implementation. Wh

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Anthony Liguori
On 05/16/2012 12:21 PM, Amit Shah wrote: On (Wed) 16 May 2012 [08:24:22], Anthony Liguori wrote: On 05/16/2012 06:30 AM, Amit Shah wrote: The Linux kernel already has a virtio-rng driver, this is the device implementation. When Linux needs more entropy, it puts a buffer in the vq. We then put

Re: [Qemu-devel] Add support for new image type

2012-05-16 Thread Anthony Liguori
On 05/16/2012 12:48 PM, Paolo Bonzini wrote: Il 16/05/2012 19:06, Kai Meyer ha scritto: 1) It's been suggested to me that since we have the rights to distribute our closed source shared library, there is a precedence for being able to distributed a modified version of qemu that does run-time lin

Re: [Qemu-devel] [PATCH v3 3/8] kvm: Introduce basic MSI support for in-kernel irqchips

2012-05-16 Thread Jan Kiszka
On 2012-05-16 08:15, Jan Kiszka wrote: > On 2012-05-16 00:27, Marcelo Tosatti wrote: >> On Thu, May 10, 2012 at 06:02:52PM -0300, Jan Kiszka wrote: >>> This patch basically adds kvm_irqchip_send_msi, a service for sending >>> arbitrary MSI messages to KVM's in-kernel irqchip models. >>> >>> As the

[Qemu-devel] [PATCH 1.1 3/4] sheepdog: return -errno on error

2012-05-16 Thread MORITA Kazutaka
On error, BlockDriver APIs should return -errno instead of -1. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c | 78 +++-- 1 files changed, 46 insertions(+), 32 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 146a221..42f

Re: [Qemu-devel] [PATCH 2/6] qemu-ga: avoid unconditional lockfile file descriptor leak

2012-05-16 Thread Michael Roth
On Wed, May 16, 2012 at 03:07:57PM +0200, Jim Meyering wrote: > From: Jim Meyering > > Do not leak a file descriptor. > Also, do not forget to unlink the lockfile upon failed lockf. > Always close the lockfile file descriptor, taking care > to diagnose close, as well as open and write, failure. >

[Qemu-devel] [PATCH 1.1 2/4] sheepdog: fix return value of do_load_save_vm_state

2012-05-16 Thread MORITA Kazutaka
bdrv_save_vmstate and bdrv_load_vmstate should return the number of processed bytes on success. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 776a1cc..146a221 100644 --

[Qemu-devel] [PATCH 1.1 1/4] sheepdog: mark image as snapshot when tag is specified

2012-05-16 Thread MORITA Kazutaka
When a snapshot tag is specified in the filename, the opened image is a snapshot. Signed-off-by: MORITA Kazutaka --- block/sheepdog.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index e01d371..776a1cc 100644 --- a/block/sheepdog.c

Re: [Qemu-devel] [PATCH 00/12 v15] introducing a new, dedicated guest memory dump mechanism

2012-05-16 Thread Luiz Capitulino
On Mon, 07 May 2012 12:01:43 +0800 Wen Congyang wrote: > Hi, all > > 'virsh dump' can not work when host pci device is used by guest. We have > discussed this issue here: > http://lists.nongnu.org/archive/html/qemu-devel/2011-10/msg00736.html > > The last version is here: > http://lists.nongnu.

Re: [Qemu-devel] [PATCH v10 3/9] Add XBZRLE documentation

2012-05-16 Thread Orit Wasserman
On 05/16/2012 07:28 PM, Eric Blake wrote: > On 05/16/2012 05:59 AM, Orit Wasserman wrote: >> Signed-off-by: Orit Wasserman >> --- >> docs/xbzrle.txt | 97 >> +++ >> 1 files changed, 97 insertions(+), 0 deletions(-) >> create mode 100644 docs

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Amit Shah
On (Wed) 16 May 2012 [08:24:22], Anthony Liguori wrote: > On 05/16/2012 06:30 AM, Amit Shah wrote: > >The Linux kernel already has a virtio-rng driver, this is the device > >implementation. > > > >When Linux needs more entropy, it puts a buffer in the vq. We then put > >entropy into that buffer, a

[Qemu-devel] [PATCH v10 1/9] Add MigrationParams structure

2012-05-16 Thread Orit Wasserman
From: Isaku Yamahata Signed-off-by: Isaku Yamahata --- block-migration.c |8 migration.c | 13 - migration.h |8 ++-- qemu-common.h |1 + savevm.c | 11 --- sysemu.h |3 ++- vmstate.h |2 +- 7 fil

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Amit Shah
On (Wed) 16 May 2012 [09:02:03], Anthony Liguori wrote: > On 05/16/2012 08:53 AM, Daniel P. Berrange wrote: > >On Wed, May 16, 2012 at 08:48:20AM -0500, Anthony Liguori wrote: > >>On 05/16/2012 08:45 AM, Daniel P. Berrange wrote: > >>>On Wed, May 16, 2012 at 08:24:22AM -0500, Anthony Liguori wrote:

Re: [Qemu-devel] [PATCH 1.1] audio: Always call fini on exit

2012-05-16 Thread Jan Kiszka
On 2012-05-09 16:33, malc wrote: > On Wed, 9 May 2012, Jan Kiszka wrote: > >> On 2012-05-03 20:51, malc wrote: >>> On Thu, 3 May 2012, Jan Kiszka wrote: >>> On 2012-05-03 16:32, malc wrote: > On Thu, 3 May 2012, Jan Kiszka wrote: > >> Not only clean up enabled voices but any regis

Re: [Qemu-devel] [PATCH v10 8/9] Add set_cachesize command

2012-05-16 Thread Eric Blake
On 05/16/2012 11:04 AM, Orit Wasserman wrote: >>> +- "value": cache size in bytes (json-int) >> >> Would it be any easier to take 'order' (log2 of the size) instead of the >> actual cache size? That is, instead of calling "value":1048576, I would >> rather type "value":20. > Well the user is cons

[Qemu-devel] [PATCH 1.1 V2] xen: Fix PV-on-HVM

2012-05-16 Thread Anthony PERARD
In the context of PV-on-HVM under Xen, the emulated nics are supposed to be unplug before the guest drivers are initialized, when the guest write to a specific IO port. Without this patch, the guest end up with two nics with the same MAC, the emulated nic and the PV nic. Signed-off-by: Anthony PE

Re: [Qemu-devel] Add support for new image type

2012-05-16 Thread Paolo Bonzini
Il 16/05/2012 19:06, Kai Meyer ha scritto: > 1) It's been suggested to me that since we have the rights to distribute > our closed source shared library, there is a precedence for being able > to distributed a modified version of qemu that does run-time linking > against our shared library. The abs

Re: [Qemu-devel] [PATCH 1/1] virtio-rng: device to send host entropy to guest

2012-05-16 Thread Amit Shah
On (Wed) 16 May 2012 [14:45:34], Daniel P. Berrange wrote: > On Wed, May 16, 2012 at 08:24:22AM -0500, Anthony Liguori wrote: > > On 05/16/2012 06:30 AM, Amit Shah wrote: > > >The Linux kernel already has a virtio-rng driver, this is the device > > >implementation. > > > > > >When Linux needs more

Re: [Qemu-devel] [PATCH v10 8/9] Add set_cachesize command

2012-05-16 Thread Orit Wasserman
On 05/16/2012 07:45 PM, Eric Blake wrote: > On 05/16/2012 05:59 AM, Orit Wasserman wrote: >> Change XBZRLE cache size in bytes (the size should be a power of 2). >> If XBZRLE cache size is too small there will be many cache miss. >> >> Signed-off-by: Benoit Hudzia >> Signed-off-by: Petter Svard >

Re: [Qemu-devel] [PATCH v10 3/9] Add XBZRLE documentation

2012-05-16 Thread Eric Blake
On 05/16/2012 05:59 AM, Orit Wasserman wrote: > Signed-off-by: Orit Wasserman > --- > docs/xbzrle.txt | 97 > +++ > 1 files changed, 97 insertions(+), 0 deletions(-) > create mode 100644 docs/xbzrle.txt > > diff --git a/docs/xbzrle.txt b/do

Re: [Qemu-devel] [PATCH 2/2] Get system state configuration from QEMU and patcth DSDT with it.

2012-05-16 Thread Paolo Bonzini
Il 16/05/2012 18:40, Gleb Natapov ha scritto: > On Wed, May 16, 2012 at 05:50:31PM +0200, Paolo Bonzini wrote: >> Il 16/05/2012 15:46, Gleb Natapov ha scritto: >>> I saw that, but I don't get why doing it this way instead of defining >>> the object in AML and patching it? I can define Name(S4VL, 0x

Re: [Qemu-devel] [PATCH] Add 'query-events' command to QMP to query async events

2012-05-16 Thread Luiz Capitulino
On Wed, 16 May 2012 11:18:22 -0500 Anthony Liguori wrote: > On 05/16/2012 11:04 AM, Eric Blake wrote: > > On 05/16/2012 06:55 AM, Daniel P. Berrange wrote: > >> From: "Daniel P. Berrange" > >> > >> Sometimes it is neccessary for an application to determine > >> whether a particular QMP event is a

Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject.

2012-05-16 Thread Michael S. Tsirkin
On Wed, May 16, 2012 at 05:52:17PM +0200, Paolo Bonzini wrote: > Il 16/05/2012 15:20, Michael S. Tsirkin ha scritto: > >>> Because it's missing the object_unparent done by qdev_unplug. Does > >>> object_unparent+qdev_free work? (I believe object_unparent should be > >>> done by qdev_free rather t

Re: [Qemu-devel] [PATCH 1/4] Introduce a new hotplug state: Force eject.

2012-05-16 Thread Michael S. Tsirkin
On Wed, May 16, 2012 at 11:02:30AM -0500, Anthony Liguori wrote: > On 05/16/2012 06:23 AM, Paolo Bonzini wrote: > >Il 16/05/2012 13:15, Anthony PERARD ha scritto: > qdev_unplug(&(d->qdev), NULL); > +qdev_free(&(d->qdev)); > } > } > > > Anthony,

  1   2   >