On 05/11/2012 02:12 AM, Michael Roth wrote:
> On Thu, May 10, 2012 at 11:29:48AM -0600, Eric Blake wrote:
>> On 05/10/2012 10:27 AM, Amos Kong wrote:
>>> Those patches updated help functions in qemu-socket.c,
>>> and used them in migrate-tcp.c to supporting IPv6 migration.
>>>
>>
>>> ---
>>>
>>> Am
Il 11/05/2012 04:15, Amos Kong ha scritto:
> Start VM with 8 multiple-function block devs, hot-removing
> those block devs by 'device_del ...' would cause qemu abort.
>
> object_ref() is called in object_property_add_child(),
> but we don't unref it in object_property_del_child().
>
> | (qemu) de
good: 3.3.0 guest kernel & qemu-kvm-rhel6
guest panic: 3.3.0 guest kernel & qemu-upstream (contains fix [1])
I didn't change anything of guest kernel,
It seems a bug of qemu-upstream.
[1] http://marc.info/?l=qemu-devel&m=133670266801022&w=2
[PATCH] qom: fix refcounting in object_property_del
Am 02.05.2012 14:21, schrieb Andreas Färber:
> Am 02.05.2012 13:30, schrieb Paolo Bonzini:
>> This simple bit of functionality was missing and we'll need it soon,
>> so add it.
>>
>> Signed-off-by: Paolo Bonzini
>> ---
>> include/qemu/object.h |8
>> qom/object.c | 13
Start VM with 8 multiple-function block devs, hot-removing
those block devs by 'device_del ...' would cause qemu abort.
object_ref() is called in object_property_add_child(),
but we don't unref it in object_property_del_child().
| (qemu) device_del virti0-0-0
| (qemu) **
| ERROR:qom/object.c:389:
Am 02.05.2012 13:59, schrieb Andreas Färber:
> Am 02.05.2012 13:30, schrieb Paolo Bonzini:
>> Signed-off-by: Paolo Bonzini
>> ---
>> include/qemu/object.h |6 ++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/include/qemu/object.h b/include/qemu/object.h
>> index ca1649c..d315dfa 1
On 05/10/2012 08:49 PM, Andreas Färber wrote:
Am 29.04.2012 20:57, schrieb Anthony Liguori:
We'll run this release much like the last one. All bug fixing will
happen in master until 1.1 is released. If you plan on maintaining a
subsystem tree while we're in feature freeze, please respond to th
Am 29.04.2012 20:57, schrieb Anthony Liguori:
> We'll run this release much like the last one. All bug fixing will
> happen in master until 1.1 is released. If you plan on maintaining a
> subsystem tree while we're in feature freeze, please respond to this
> note with information about your tree.
Am 27.04.2012 22:21, schrieb Michael Roth:
> These patches apply on top of qemu.git master, and can also be obtained from:
> git://github.com/mdroth/qemu.git visitor-fixed-width-v5
>
> Some of these were being carried as part of Paolo's realize series due to some
> conflicts, but that looks to be
On 05/11/2012 07:54 AM, Amos Kong wrote:
> On 05/11/2012 02:55 AM, Michael S. Tsirkin wrote:
>> On Fri, May 11, 2012 at 01:09:13AM +0800, Jiang Liu wrote:
>>> On 05/10/2012 11:44 PM, Amos Kong wrote:
>>>
diff --git a/drivers/pci/hotplug/acpiphp_glue.c
b/drivers/pci/hotplug/acpiphp_glue.c
On 05/11/2012 02:55 AM, Michael S. Tsirkin wrote:
> On Fri, May 11, 2012 at 01:09:13AM +0800, Jiang Liu wrote:
>> On 05/10/2012 11:44 PM, Amos Kong wrote:
>>
>>> diff --git a/drivers/pci/hotplug/acpiphp_glue.c
>>> b/drivers/pci/hotplug/acpiphp_glue.c
>>> index 806c44f..a7442d9 100644
>>> --- a/dri
- Original Message -
> On 05/11/2012 01:42 AM, Michael S. Tsirkin wrote:
> > On Fri, May 11, 2012 at 01:17:38AM +0800, Jiang Liu wrote:
> >> On 05/09/2012 03:24 PM, Amos Kong wrote:
> >>
> >>> ---
> >>> src/ssdt-pcihp.dsl | 17
> >>> src/ssdt-pcihp.hex | 8869
> >>> +
Am 10.05.2012 23:41, schrieb Peter Maydell:
> On 10 May 2012 01:14, Andreas Färber wrote:
>> Allows us to use cpu_reset() in place of cpu_state_reset().
>>
>> Signed-off-by: Andreas Färber
>> ---
>> hw/arm_boot.c |9 ++---
>> 1 files changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --
As MSI is now fully supported by KVM (/wrt available features in
upstream), we can finally enable the in-kernel irqchip by default.
Signed-off-by: Jan Kiszka
---
kvm-all.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index 4e8c8f7..8f8cec5 10064
Am 10.05.2012 23:26, schrieb Peter Maydell:
> On 10 May 2012 22:05, Andreas Färber wrote:
>> This series is put together in such a way that it achieves a goal:
>> removing cpu_state_reset(). I can send you these and more patches
>> refactoring ARM devices but then it'll be perceived as "just churn
Push msi_supported enabling to the APIC implementations where we can
encapsulate the decision more cleanly, hiding the details from the
generic code.
CC: Stefano Stabellini
Signed-off-by: Jan Kiszka
---
hw/apic.c |2 ++
hw/pc.c |9 -
hw/xen.h | 10 --
hw
Public bug reported:
Hi,
well, I'm in a similar boat as the one in #992067. But regardless any
memory-settings.
It takes "ages" in a cold-boot Windows 2008R2 with qemu-1.0.1, qemu-1.0.50 and
latest-n-greatest from today ( 1.0.50 /qemu-1b3e76e ). It eats up 400%
host-cpu-load until login-prompt
On 10 May 2012 01:14, Andreas Färber wrote:
> Allows us to use cpu_reset() in place of cpu_state_reset().
>
> Signed-off-by: Andreas Färber
> ---
> hw/arm_boot.c | 9 ++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/hw/arm_boot.c b/hw/arm_boot.c
> index 7447f5c..e
Version 3 is mostly a rebase + the final consolidation over the direct
MSI inject mechanism that made it into kvm.git recently. I also
introduced an MSIMessage structure as it will be helpful for the
follow-up work on irqfd-driven MSI injection under KVM. And, finally,
this flips the default for ke
On 10 May 2012 01:14, Andreas Färber wrote:
> Fix tab indentations of comments, add braces, use cpu_reset().
>
> Signed-off-by: Andreas Färber
> ---
> hw/nseries.c | 6 +++---
> hw/omap.h | 2 +-
> hw/omap1.c | 20 +++-
> hw/omap2.c | 8
> hw/omap_s
Will be used for generating and distributing MSI messages, both in
emulation mode and under KVM.
Signed-off-by: Jan Kiszka
---
hw/msi.h |5 +
qemu-common.h |1 +
2 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/hw/msi.h b/hw/msi.h
index 3040bb0..75747ab 100644
---
dear sir,
this is vikas pandey,i am using qemu and i am abe to run some of kernel
image and initrd which is available on qemu site for testing purpose.
now my ami is to connect the host usb and access the content after running
iso image or specifing kernel and initrd image on qemu .
for this ta
On 05/09/2012 03:24 PM, Amos Kong wrote:
> ---
> src/ssdt-pcihp.dsl | 17
> src/ssdt-pcihp.hex | 8869
> +++-
> 2 files changed, 8781 insertions(+), 105 deletions(-)
>
> diff --git a/src/ssdt-pcihp.dsl b/src/ssdt-pcihp.dsl
> index 4b435b8..2a3c
Dear All,
I'm trying to compile Qemu with 3dnow support, but I don't
see any option in the configure file. Is 3DNOW supported in the last
package downloaded from the web site? In case not is there any patch
about that? The patch I found on internet in some old posts shows
several errors when
This patch basically adds kvm_irqchip_send_msi, a service for sending
arbitrary MSI messages to KVM's in-kernel irqchip models.
As the current KVI API requires us to establish a static route from a
pseudo GSI to the target MSI message and inject the MSI via toggling
that GSI, we need to play some
On 10 May 2012 22:05, Andreas Färber wrote:
> Am 10.05.2012 22:35, schrieb Peter Maydell:
>> Something this
>> big is just too painful to work with.
>
> I don't see your point. Our mailboxes have thousands of messages either
> way, you've only been cc'ed on those you are in MAINTAINERS for, and
>
On Thu, May 10, 2012 at 03:29:54PM +0300, Avi Kivity wrote:
> Currently when you mount a filesystem, you face two issues:
> - you have to be root
> - if the media is untrusted, it can exploit your kernel
>
> With kvm and fuse, we can have a virtualized kernel mount the
> filesystem, and re-export
Catch writes to the MSI MMIO region in the KVM APIC and forward them to
the kernel. Provide the kernel support GSI routing, this allows to
enable MSI support also for in-kernel irqchip mode.
Signed-off-by: Jan Kiszka
---
hw/apic.c |1 +
hw/kvm/apic.c | 34 ++
On 05/10/2012 11:44 PM, Amos Kong wrote:
> diff --git a/drivers/pci/hotplug/acpiphp_glue.c
> b/drivers/pci/hotplug/acpiphp_glue.c
> index 806c44f..a7442d9 100644
> --- a/drivers/pci/hotplug/acpiphp_glue.c
> +++ b/drivers/pci/hotplug/acpiphp_glue.c
> @@ -885,7 +885,7 @@ static void disable_bridges
On 05/09/2012 09:47 PM, Alex Williamson wrote:
>> ---
>> src/ssdt-pcihp.dsl | 17
>> src/ssdt-pcihp.hex | 8869
>> +++-
>> 2 files changed, 8781 insertions(+), 105 deletions(-)
>>
>> diff --git a/src/ssdt-pcihp.dsl b/src/ssdt-pcihp.dsl
>> index 4
Call msi_reset on device reset as still required by the core.
CC: Alexander Graf
CC: qemu-sta...@nongnu.org
Signed-off-by: Jan Kiszka
---
hw/ide/ich.c | 12 ++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/hw/ide/ich.c b/hw/ide/ich.c
index 560ae37..242254e 100644
-
On 05/11/2012 01:42 AM, Michael S. Tsirkin wrote:
> On Fri, May 11, 2012 at 01:17:38AM +0800, Jiang Liu wrote:
>> On 05/09/2012 03:24 PM, Amos Kong wrote:
>>
>>> ---
>>> src/ssdt-pcihp.dsl | 17
>>> src/ssdt-pcihp.hex | 8869
>>> +++-
>>> 2 files
Am 10.05.2012 22:35, schrieb Peter Maydell:
> On 10 May 2012 01:10, Andreas Färber wrote:
>> Again, target maintainers are requested to start queuing their patches on
>> their
>> -next branches, where available, to avoid collisions.
>
> Please, if you have patches you want me to put into target-
If the kernel supports KVM_SIGNAL_MSI, we can avoid the route-based
MSI injection mechanism.
Signed-off-by: Jan Kiszka
---
kvm-all.c | 22 +++---
1 files changed, 19 insertions(+), 3 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index e7ed510..4e8c8f7 100644
--- a/kvm-all.c
Corresponding kvm.git hash: f2569053e0
Signed-off-by: Jan Kiszka
---
linux-headers/linux/kvm.h | 38 ++
1 files changed, 38 insertions(+), 0 deletions(-)
diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h
index ee7bd9c..c4426ec 100644
--- a/
Instead of the bitmap size, store the maximum of GSIs the kernel
support. Move the GSI limit assertion to the API function
kvm_irqchip_add_route and make it stricter.
Signed-off-by: Jan Kiszka
---
kvm-all.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/kvm-all.c
On 2012-04-03 18:06, Anthony Liguori wrote:
> On 04/03/2012 06:15 AM, Paolo Bonzini wrote:
>> Otherwise, non-string properties without a legacy counterpart are missed.
>> Also fix error propagation in object_property_print itself, otherwise
>> pointer properties are printed as "".
>>
>> Signed-off-
Terminate msi/msix_write_config early if support is not enabled. This
allows to remove checks at the caller site if MSI is optional.
Signed-off-by: Jan Kiszka
---
hw/msi.c |3 ++-
hw/msix.c |2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/msi.c b/hw/msi.c
index b
Properly register reset function via the device class.
CC: Gerd Hoffmann
Signed-off-by: Jan Kiszka
---
hw/usb/hcd-xhci.c |7 +++
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index c4079eb..814117c 100644
--- a/hw/usb/hcd-xhci.c
+++
Signed-off-by: Jan Kiszka
---
hw/msi.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/hw/msi.c b/hw/msi.c
index 5d6ceb6..b2903fc 100644
--- a/hw/msi.c
+++ b/hw/msi.c
@@ -191,6 +191,10 @@ void msi_reset(PCIDevice *dev)
uint16_t flags;
bool msi64bit;
+if
Properly register reset functions via the device class.
CC: Alexander Graf
Signed-off-by: Jan Kiszka
---
hw/ide/ahci.c | 25 +++--
hw/ide/ahci.h |2 +-
hw/ide/ich.c | 10 --
3 files changed, 20 insertions(+), 17 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/
Call msi_reset on device reset as still required by the core.
CC: Gerd Hoffmann
CC: qemu-sta...@nongnu.org
Signed-off-by: Jan Kiszka
---
hw/usb/hcd-xhci.c | 13 ++---
1 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 5cf1a64..c
On 10 May 2012 01:10, Andreas Färber wrote:
> Again, target maintainers are requested to start queuing their patches on
> their
> -next branches, where available, to avoid collisions.
Please, if you have patches you want me to put into target-arm.next,
post them as their own series rather than r
Also this functions is better invoked by the core than by each and every
device. This allows to drop the config_write callbacks from ich and
intel-hda.
CC: Alexander Graf
CC: Gerd Hoffmann
CC: Isaku Yamahata
Signed-off-by: Jan Kiszka
---
hw/ide/ich.c|8
hw/intel-hda.c
There is no point in pushing this burden to the devices, they may rather
forget to call them (like intel-hda, ahci, xhci did). Instead, reset
functions are now called from pci_device_reset and pci_bridge_reset.
They do nothing if MSI/MSI-X is not in use.
CC: Alexander Graf
CC: Gerd Hoffmann
CC:
On 05/10/2012 01:50 PM, Luiz Capitulino wrote:
> The next commit wants to use it.
>
> Signed-off-by: Luiz Capitulino
> ---
> qemu-ga.c | 17 +
> qga/commands-posix.c | 19 ---
> qga/guest-agent-core.h |4
> 3 files changed, 21 insertion
On 05/10/2012 01:50 PM, Luiz Capitulino wrote:
> This fixes a bug where qemu-ga doesn't suspend the guest because it
> fails to detect suspend support even when the guest does support
> suspend. This happens because of the way qemu-ga fds are managed in
> daemon mode.
>
> When starting qemu-ga wit
Replace some open-coded msi/msix_present checks.
Signed-off-by: Jan Kiszka
---
hw/msi.c |2 +-
hw/msix.c | 13 -
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/hw/msi.c b/hw/msi.c
index 556c7c4..5233204 100644
--- a/hw/msi.c
+++ b/hw/msi.c
@@ -175,7 +175,7 @@ v
Call msi_reset on device reset as still required by the core.
CC: Gerd Hoffmann
CC: qemu-sta...@nongnu.org
Signed-off-by: Jan Kiszka
---
hw/intel-hda.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/intel-hda.c b/hw/intel-hda.c
index bb11af2..e38861e 100644
--- a/
Patches 1..3 are now targeting 1.1/stable, the rest are cleanups and
refactoring that can go in for 1.2. Not sure who will pick the pure
ahci/xhci refactorings, so I just left them in here for my convenience.
CC: Alexander Graf
CC: Gerd Hoffmann
CC: Isaku Yamahata
CC: qemu-sta...@nongnu.org
Ja
FYI (mea culpa for semi-spamming): On early June LinuxCon Japan will
host a virtualization track w/ some known faces and a parallel oVirt
developer workshop in Japan.
More details:
https://events.linuxfoundation.org/events/linuxcon-japan/schedule
Regards,
Dor
Original Message ---
This fixes a bug where qemu-ga doesn't suspend the guest because it
fails to detect suspend support even when the guest does support
suspend. This happens because of the way qemu-ga fds are managed in
daemon mode.
When starting qemu-ga with --daemon, become_daemon() will close all
standard fds. Th
The next commit wants to use it.
Signed-off-by: Luiz Capitulino
---
qemu-ga.c | 17 +
qga/commands-posix.c | 19 ---
qga/guest-agent-core.h |4
3 files changed, 21 insertions(+), 19 deletions(-)
diff --git a/qemu-ga.c b/qemu-ga.c
index
Hi Michael,
There's a problem on how we handle fds in daemon mode that may cause
suspend to fail. This series fixes it. Please, check patch 2/2 for full
details.
qemu-ga.c | 23 ---
qga/commands-posix.c | 19 ---
qga/guest-agent-core.h |
On 2012-05-10 15:58, Michael S. Tsirkin wrote:
> On Thu, May 10, 2012 at 03:22:11PM -0300, Jan Kiszka wrote:
>> These patches had been sent before. I now rebased them and reduced them
>> to a set that has a value independent of the ongoing MSI rework for KVM
>> integration.
>>
>> I'm not yet sure i
- Original Message -
> From: "Andreas Färber"
> To: qemu-devel@nongnu.org
> Cc: "Eduardo Habkost" , "Michael Roth"
> , "Anthony Liguori"
> , "Paolo Bonzini" ,
> imamm...@redhat.com, "Andreas Färber"
>
> Sent: Thursday, May 10, 2012 12:09:10 AM
> Subject: [Qemu-devel] [PATCH for-1.1] tar
On Thu, May 10, 2012 at 03:22:11PM -0300, Jan Kiszka wrote:
> These patches had been sent before. I now rebased them and reduced them
> to a set that has a value independent of the ongoing MSI rework for KVM
> integration.
>
> I'm not yet sure if patch 1&2 should be considered for 1.1 as they
> im
On Fri, May 11, 2012 at 01:09:13AM +0800, Jiang Liu wrote:
> On 05/10/2012 11:44 PM, Amos Kong wrote:
>
> > diff --git a/drivers/pci/hotplug/acpiphp_glue.c
> > b/drivers/pci/hotplug/acpiphp_glue.c
> > index 806c44f..a7442d9 100644
> > --- a/drivers/pci/hotplug/acpiphp_glue.c
> > +++ b/drivers/pci
Replace some open-coded msi/msix_present checks.
Signed-off-by: Jan Kiszka
---
hw/msi.c |2 +-
hw/msix.c | 13 -
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/hw/msi.c b/hw/msi.c
index 556c7c4..5233204 100644
--- a/hw/msi.c
+++ b/hw/msi.c
@@ -175,7 +175,7 @@ v
There is no point in pushing this burden to the devices, they may rather
forget to call them (like intel-hda and ahci ATM). Instead, reset
functions are now called from pci_device_reset and pci_bridge_reset.
They do nothing if MSI/MSI-X is not in use.
CC: Alexander Graf
CC: Gerd Hoffmann
CC: Isa
Terminate msi/msix_write_config early if support is not enabled. This
allows to remove checks at the caller site if MSI is optional.
Signed-off-by: Jan Kiszka
---
hw/msi.c |3 ++-
hw/msix.c |2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/msi.c b/hw/msi.c
index b
Also this functions is better invoked by the core than by each and every
device. This allows to drop the config_write callbacks from ich and
intel-hda.
CC: Alexander Graf
CC: Gerd Hoffmann
CC: Isaku Yamahata
Signed-off-by: Jan Kiszka
---
hw/ide/ich.c|8
hw/intel-hda.c
These patches had been sent before. I now rebased them and reduced them
to a set that has a value independent of the ongoing MSI rework for KVM
integration.
I'm not yet sure if patch 1&2 should be considered for 1.1 as they
implicitly fix the missing msi_reset for intel-hda and ahci. An
alternativ
Signed-off-by: Jan Kiszka
---
hw/msi.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/hw/msi.c b/hw/msi.c
index 5d6ceb6..b2903fc 100644
--- a/hw/msi.c
+++ b/hw/msi.c
@@ -191,6 +191,10 @@ void msi_reset(PCIDevice *dev)
uint16_t flags;
bool msi64bit;
+if
On Thu, May 10, 2012 at 11:29:48AM -0600, Eric Blake wrote:
> On 05/10/2012 10:27 AM, Amos Kong wrote:
> > Those patches updated help functions in qemu-socket.c,
> > and used them in migrate-tcp.c to supporting IPv6 migration.
> >
>
> > ---
> >
> > Amos Kong (4):
> > qerror: add five qerro
On Fri, May 11, 2012 at 01:17:38AM +0800, Jiang Liu wrote:
> On 05/09/2012 03:24 PM, Amos Kong wrote:
>
> > ---
> > src/ssdt-pcihp.dsl | 17
> > src/ssdt-pcihp.hex | 8869
> > +++-
> > 2 files changed, 8781 insertions(+), 105 deletions(-)
> >
>
On 05/10/2012 11:02 AM, Jim Meyering wrote:
Kevin Wolf wrote:
Am 09.05.2012 11:23, schrieb Jim Meyering:
[Argh. First attempt omitted the most important address: qemu-devel.
Sorry to all who get two copies. ]
Given qemu's HACKING comments, I'm sure many here have read "man strncpy",
where i
On 05/10/2012 10:27 AM, Amos Kong wrote:
> Those patches updated help functions in qemu-socket.c,
> and used them in migrate-tcp.c to supporting IPv6 migration.
>
> ---
>
> Amos Kong (4):
> qerror: add five qerror strings
> sockets: change inet_connect() to support nonblock socket
>
On 05/10/2012 11:02 AM, Jim Meyering wrote:
Kevin Wolf wrote:
Am 09.05.2012 11:23, schrieb Jim Meyering:
[Argh. First attempt omitted the most important address: qemu-devel.
Sorry to all who get two copies. ]
Given qemu's HACKING comments, I'm sure many here have read "man strncpy",
where i
On 2012-05-10 13:19, Jim Meyering wrote:
> From: Jim Meyering
>
> kvm_put_apic_state's attempt to clear *kapic before setting its
> bits cleared sizeof(void*) bytes (no more than 8) rather than the
> intended 1024 (KVM_APIC_REG_SIZE) bytes. Spotted by coverity.
>
> Signed-off-by: Jim Meyering
>
On Fri, May 11, 2012 at 12:28:08AM +0800, Amos Kong wrote:
> Add five new qerror strings, they are about listen/connect socket:
> QERR_SOCKET_CONNECT_IN_PROGRESS
> QERR_SOCKET_CONNECT_FAILED
> QERR_SOCKET_LISTEN_FAILED
> QERR_SOCKET_BIND_FAILED
> QERR_SOCKET_CREATE_FAILED
>
> Signed-off-
On Fri, May 11, 2012 at 12:50:37AM +0800, Jiang Liu wrote:
> On 05/09/2012 09:47 PM, Alex Williamson wrote:
> >> ---
> >> src/ssdt-pcihp.dsl | 17
> >> src/ssdt-pcihp.hex | 8869
> >> +++-
> >> 2 files changed, 8781 insertions(+), 105 deletions(-
On 05/10/2012 05:06 AM, Alexander Graf wrote:
>
> On 09.05.2012, at 23:05, Andreas Färber wrote:
>
>> Am 09.05.2012 23:00, schrieb Alexander Graf:
>>>
>>> On 09.05.2012, at 22:20, Andreas Färber wrote:
>>>
Am 14.02.2012 04:10, schrieb bo.nov...@gmail.com:
> From: Bo Yang
>
> Wi
Those patches updated help functions in qemu-socket.c,
and used them in migrate-tcp.c to supporting IPv6 migration.
---
Changes from v1:
- split different changes to small patches, it will be easier to review
- fixed some problem according to Kevin's comment
Changes from v2:
- fix issue of return
Use help functions in qemu-socket.c for tcp migration,
which already support ipv6 addresses.
Currently errp will be set to UNDEFINED_ERROR when migration fails,
qemu would output "migration failed: ...", and current user can
see a message("An undefined error has occurred") in monitor.
This patch
Add a new argument in inet_listen()/inet_listen_opts()
to pass back listen error.
Change nbd, qemu-char, vnc to use new interface.
Signed-off-by: Amos Kong
Reviewed-by: Orit Wasserman
Reviewed-by: Michael Roth
---
nbd.c |2 +-
qemu-char.c|2 +-
qemu-sockets.c | 17 +
Gerd Hoffmann wrote:
> anyone can explain what checkpatch tries to tell me here?
>
> ERROR: need consistent spacing around '*' (ctx:WxV)
> #11: FILE: hw/usb/hcd-ehci.c:1398:
> +static int ehci_execute(EHCIPacket *p)
Hi Gerd,
When I add that line to that file, creating the patch below,
checkpatch d
Add a bool argument to inet_connect() to assign if set socket
to block/nonblock, and delete original argument 'socktype'
that is unused.
Add a new argument to inet_connect()/inet_connect_opts(),
to pass back connect error by error class.
Retry to connect when -EINTR is got. Connect's successful
fo
Add five new qerror strings, they are about listen/connect socket:
QERR_SOCKET_CONNECT_IN_PROGRESS
QERR_SOCKET_CONNECT_FAILED
QERR_SOCKET_LISTEN_FAILED
QERR_SOCKET_BIND_FAILED
QERR_SOCKET_CREATE_FAILED
Signed-off-by: Amos Kong
Reviewed-by: Orit Wasserman
---
qerror.c | 20 ++
From: Jim Meyering
kvm_put_apic_state's attempt to clear *kapic before setting its
bits cleared sizeof(void*) bytes (no more than 8) rather than the
intended 1024 (KVM_APIC_REG_SIZE) bytes. Spotted by coverity.
Signed-off-by: Jim Meyering
---
hw/kvm/apic.c | 2 +-
1 file changed, 1 insertion(+
From: Jim Meyering
Use sizeof(rxbuf)-size (not sizeof(rxbuf-size)) as the number
of bytes to clear. The latter would always clear 4 or 8
bytes, possibly writing beyond the end of that stack buffer.
Alternatively, depending on the value of the "size" parameter,
it could fail to initialize the end
From: Jim Meyering
I ran coverity on all of qemu and have begun going through the results.
A couple problems jumped out as obvious and easy to fix:
Jim Meyering (2):
kvm/apic: correct short memset
cadence_gem: avoid stack-writing buffer-overrun
hw/cadence_gem.c | 2 +-
hw/kvm/apic.c| 2
On Tue, May 08, 2012 at 10:58:40PM +0800, Amos Kong wrote:
> Add a new argument in inet_listen()/inet_listen_opts()
> to pass back listen error.
>
> Change nbd, qemu-char, vnc to use new interface.
>
> Signed-off-by: Amos Kong
> Reviewed-by: Orit Wasserman
Reviewed-by: Michael Roth
> ---
>
Kevin Wolf wrote:
> Am 09.05.2012 11:23, schrieb Jim Meyering:
>> [Argh. First attempt omitted the most important address: qemu-devel.
>> Sorry to all who get two copies. ]
>>
>> Given qemu's HACKING comments, I'm sure many here have read "man strncpy",
>> where it indicates it is often not the b
On Tue, May 08, 2012 at 10:58:22PM +0800, Amos Kong wrote:
> Add five new qerror strings, they are about listen/connect socket:
> QERR_SOCKET_CONNECT_IN_PROGRESS
> QERR_SOCKET_CONNECT_FAILED
> QERR_SOCKET_LISTEN_FAILED
> QERR_SOCKET_BIND_FAILED
> QERR_SOCKET_CREATE_FAILED
>
> Signed-off-
Hotplug CallTrace:
int acpiphp_enable_slot(struct acpiphp_slot *slot)
\_enable_device(slot);
\_pci_bus_add_devices(bus);
# un-added new devs(all funcs in slot) will be added
list_for_each_entry(dev, &bus->devices, bus_list) {
if (dev->is_added)
While for the "normal" case (called from blk_send_response_all())
decrementing requests_finished is correct, doing so in the parse error
case is wrong; requests_inflight needs to be decremented instead.
Signed-off-by: Jan Beulich
--- a/hw/xen_disk.c
+++ b/hw/xen_disk.c
@@ -154,7 +154,7 @@ static
On 05/10/12 15:24, Uri Lublin wrote:
> Also move it up into switch(qxl->revision) block
Looks good.
Anthony, want a one-patch-pull-req for this one?
Or can you just pick it up directly?
cheers,
Gerd
On Thu, May 10, 2012 at 04:39:45PM +0300, Gleb Natapov wrote:
> On Thu, May 10, 2012 at 03:21:41PM +0200, Alexander Graf wrote:
> > On 05/10/2012 02:53 PM, Gleb Natapov wrote:
> > >On Wed, May 09, 2012 at 04:38:02PM -0300, Eduardo Habkost wrote:
> > >>On Wed, May 09, 2012 at 12:38:37PM +0300, Gleb
On 2012-05-10 09:29, Avi Kivity wrote:
> Currently when you mount a filesystem, you face two issues:
> - you have to be root
> - if the media is untrusted, it can exploit your kernel
>
> With kvm and fuse, we can have a virtualized kernel mount the
> filesystem, and re-export to the host, which mo
Am 10.05.2012 09:48, schrieb Kevin Wolf:
> Signed-off-by: Kevin Wolf
> ---
>
> To be applied on top of the floppy qtest patch.
Reviewed-by: Andreas Färber
/-F
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nü
Both solutions work for my application !
Thanks a lot. I think I will use one of them, even if I know it's not really
"clean".
Thanks again,
Alain
On Wed, May 09, 2012 at 08:44:45PM -0400, Kevin O'Connor wrote:
> On Wed, May 09, 2012 at 08:57:53AM -0700, Ala
On Thu, May 10, 2012 at 03:21:41PM +0200, Alexander Graf wrote:
> On 05/10/2012 02:53 PM, Gleb Natapov wrote:
> >On Wed, May 09, 2012 at 04:38:02PM -0300, Eduardo Habkost wrote:
> >>On Wed, May 09, 2012 at 12:38:37PM +0300, Gleb Natapov wrote:
> >>>On Wed, May 09, 2012 at 11:05:58AM +0200, Alexande
From: Paolo Bonzini
The limitation on not having I/O after cancellation cannot really be
kept. Even streaming has a very small race window where you could
cancel a job and have it report completion. If this window is hit,
bdrv_change_backing_file() will yield and possibly cause accesses to
dang
From: Paolo Bonzini
bdrv_close should leave fields in the same state as bdrv_new. It is
not up to bdrv_open_common to fix the mess.
Also, backing_format was not being re-initialized.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
block.c | 13 ++---
1 files changed, 6
From: Paolo Bonzini
A trailing space is left when qemu-img has no arguments, for example if
-nocache is not used. This becomes an empty argument after split()
and causes qemu-io to fail.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/iotests.py |6 +++---
1
From: Paolo Bonzini
This function abstracts the pretty complex semantics of the "busy"
member of BlockJob.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
block.c| 11 +++
block/stream.c | 23 +--
block_int.h| 22 +++---
Also move it up into switch(qxl->revision) block
Signed-off-by: Uri Lublin
---
hw/qxl.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/hw/qxl.c b/hw/qxl.c
index 6c11e70..3da3399 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1746,13 +1746,16 @@ static int qxl_init_comm
From: Paolo Bonzini
Because sector_num is not updated, the loop would either go on
forever or return garbage.
Signed-off-by: Paolo Bonzini
Signed-off-by: Kevin Wolf
---
qemu-io.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/qemu-io.c b/qemu-io.c
index b483
From: Paolo Bonzini
Also reuse elsewhere the new constant for sizeof(unsigned long) * 8.
The dirty bitmap is allocated in bits but declared as unsigned long.
Thus, its memory block is accessed beyond its end unless the image
is a multiple of 64 chunks (i.e. a multiple of 64 MB).
Signed-off-by:
1 - 100 of 176 matches
Mail list logo
