Re: [Qemu-devel] [PATCHv3] piix: fix up/down races

2012-04-02 Thread Igor Mammedov
- Original Message - > From: "Alex Williamson" > To: "Michael S. Tsirkin" > Cc: qemu-devel@nongnu.org, "Anthony Liguori" , "Gerd > Hoffmann" , "Isaku > Yamahata" , "Aurelien Jarno" , > "Paolo Bonzini" , > g...@redhat.com, imamm...@redhat.com > Sent: Monday, April 2, 2012 8:59:54 PM > Su

Re: [Qemu-devel] [PATCH 3/4] Switch from array based resource allocation to list

2012-04-02 Thread Alexey Korolev
Hi Kevin, Thank you for the patches! I've created a diff of final version of your changes over mine, to make it clear what has changed. Rather than including the complete diff, I've just left relevant parts and added comments. --- a/src/pciinit.c +++ b/src/pciinit.c@@ -12,8 +12,9 @@ @

[Qemu-devel] [PATCH v2 2/2] xilinx_zynq: added sdhci controller

2012-04-02 Thread Peter A. G. Crosthwaite
Signed-off-by: Peter A. G. Crosthwaite --- hw/xilinx_zynq.c | 13 - 1 files changed, 12 insertions(+), 1 deletions(-) diff --git a/hw/xilinx_zynq.c b/hw/xilinx_zynq.c index 31d9e81..e92ebe0 100644 --- a/hw/xilinx_zynq.c +++ b/hw/xilinx_zynq.c @@ -161,6 +161,18 @@ static void zynq_i

[Qemu-devel] [PATCH v2 1/2] SDHCI: inital version

2012-04-02 Thread Peter A. G. Crosthwaite
Device model for standard SD Host Controller Interface (SDHCI). Signed-off-by: Peter A. G. Crosthwaite --- changed from v1: Made undefined op behaviour consisistent. fixed compile warning. Makefile.target |1 + hw/sdhci.c | 736 +++

[Qemu-devel] [PATCH v2 0/2] SDHCI for Xilinx Zynq

2012-04-02 Thread Peter A. G. Crosthwaite
These two patched add a device model for the standard SD host controller interface (1) and instantiates it as a device to the Xilinx Zynq platform (2). Peter A. G. Crosthwaite (2): SDHCI: inital version xilinx_zynq: added sdhci controller Makefile.target |1 + hw/sdhci.c | 736 +

Re: [Qemu-devel] [PATCHv3] piix: fix up/down races

2012-04-02 Thread Igor Mammedov
- Original Message - > From: "Michael S. Tsirkin" > To: "Alex Williamson" > Cc: qemu-devel@nongnu.org, "Anthony Liguori" , "Gerd > Hoffmann" , "Isaku > Yamahata" , "Aurelien Jarno" , > "Paolo Bonzini" , > g...@redhat.com, imamm...@redhat.com > Sent: Monday, April 2, 2012 9:20:32 PM > Su

[Qemu-devel] [PATCH v2 3/4] xilinx_spi: initial version

2012-04-02 Thread Peter A. G. Crosthwaite
device model for xilinx XPS SPI controller (v2.0) Signed-off-by: Peter A. G. Crosthwaite --- changed from v1: converted spi api to modified txrx style Makefile.target |1 + hw/xilinx_spi.c | 482 +++ 2 files changed, 483 insertions(+), 0

[Qemu-devel] [PATCH v2 4/4] petalogix-ml605: added spi controller with m25p80

2012-04-02 Thread Peter A. G. Crosthwaite
Added spi controller to the reference design, with a single cs line and a m25p80 style spi-flash connected Signed-off-by: Peter A. G. Crosthwaite --- hw/petalogix_ml605_mmu.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/hw/petalogix_ml605_mmu.c b/hw

[Qemu-devel] [PATCH v2 2/4] m25p80: initial verion

2012-04-02 Thread Peter A. G. Crosthwaite
Added device model for m25p80 SPI flash Signed-off-by: Peter A. G. Crosthwaite --- changed from v1: converted spi api to modified txrx style factored out lots of common code and inlined overly short single call functions. undated for txrx style spi interface Makefile.target |1 + hw/m25p80.

[Qemu-devel] [PATCH v2 1/4] SPI: initial support

2012-04-02 Thread Peter A. G. Crosthwaite
Defined SPI bus and SPI slave QOM interfaces. Inspired by and loosely based on existing I2C framework. Signed-off-by: Peter A. G. Crosthwaite --- changed from v1: minor sylistic changes converted spi api to modified txrx style Makefile.objs |2 +- hw/spi.c | 148 ++

[Qemu-devel] [PATCH v2 0/4] SPI bus support + Xilinx SPI controller

2012-04-02 Thread Peter A. G. Crosthwaite
Add support for Serial Peripheral interface (SPI) as a proper bus standard. Includes an example device (m25p80 SPI flash), an example controller (Xilinx XPS SPI) and adds it to all to a machine model (petalogix_ml605_mmu.c). Patch 1 adds the Serial Peripheral Interface (SPI) protocol as a bus an

[Qemu-devel] [PATCH v2] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-02 Thread Liu Yuan
From: Liu Yuan Flush operation is supposed to flush the write-back cache of sheepdog cluster. By issuing flush operation, we can assure the Guest of data reaching the sheepdog cluster storage. Cc: Kevin Wolf Cc: Michael Tokarev Cc: MORITA Kazutaka Signed-off-by: Liu Yuan --- v1 -> v2: add

Re: [Qemu-devel] [PATCH] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-02 Thread Liu Yuan
On 04/03/2012 04:01 AM, Michael Tokarev wrote: > On 02.04.2012 21:35, Liu Yuan wrote: >> From: Liu Yuan >> >> Flush operation is supposed to flush the write-back cache of >> sheepdog cluster. >> >> By issuing flush operation, we can assure the Guest of data >> reaching the sheepdog cluster storag

Re: [Qemu-devel] [PATCH] use: fix bit test

2012-04-02 Thread Lai Jiangshan
On 04/02/2012 05:50 PM, Andreas Färber wrote: > Am 02.04.2012 08:35, schrieb Lai Jiangshan: >> >> use & instead of the wrong && >> >> Signed-off-by: Lai Jiangshan > > Patch looks okay but the subject should probably be fixed to say "usb:" > when applying. :) > Thank you!! Hi, Gerd, Does this

[Qemu-devel] [patch V5 3/5] FreeSCALE i.MX31 support: Timers

2012-04-02 Thread Peter Chubb
Implement the timers on the FreeScale i.MX31 SoC. This is not a complete implementation, but gives enough for Linux to boot and run. In particular external triggers, which are not useful under QEMU, are not implemented. Signed-off-by: Philip O'Sullivan Signed-off-by: Peter Chubb --- Makefile

[Qemu-devel] [patch V5 1/5] i.MX UART support

2012-04-02 Thread Peter Chubb
Implement the FreeScale i.MX UART. This uart is used in a variety of SoCs, including some by Motorola, as well as in the FreeScale i.MX series. This patch gives only a `bare-bones' implementation, enough to run Linux or OKL4, but that's about it. Signed-off-by: Philip O'Sullivan Signed-off-by

[Qemu-devel] [patch V5 4/5] FreeSCALE i.MX31 support: AVIC

2012-04-02 Thread Peter Chubb
Implement the FreeSCALE i.MX31 advanced vectored interrupt controller, at least to the extent it is used by Linux 3.0.x Vectors are not implemented. Signed-off-by: Philip O'Sullivan Signed-off-by: Peter Chubb Reviewed-by: Peter Maydell --- Makefile.target |2 hw/imx_avic.c | 409

[Qemu-devel] [patch V5 2/5] Implement i.MX31 Clock Control Module

2012-04-02 Thread Peter Chubb
For Linux to be able to work out how fast its clocks are going, so that timer ticks come approximately at the right time, it needs to be able to query the clock control module (CCM). This is the start of a CCM implementation. It currently knows only about the MCU, HSP and IPG clocks --- i.e., t

[Qemu-devel] [patch V5 0/5] i.MX31 support

2012-04-02 Thread Peter Chubb
This is the fifth round of patches for preliminary Freescale i.MX31 support. The only changes in the patches for imx UART and AVIC are the CamelCasing of the typedef names, and removal of unwanted #include files. The major change has been in the timer implementation. I've added a partial impleme

[Qemu-devel] [patch V5 5/5] FreeSCALE i.MX31 support: KZM-ARM11-01 evaluation board

2012-04-02 Thread Peter Chubb
Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built around the FreeScale i.MX31. Signed-off-by: Philip O'Sullivan Signed-off-by: Peter Chubb --- Makefile.target |2 hw/kzm.c| 161 2 files changed, 162 i

Re: [Qemu-devel] [PATCH] Better support for dma_addr_t variables

2012-04-02 Thread David Gibson
On Mon, Apr 02, 2012 at 09:49:12AM +0200, Andreas Färber wrote: > Am 31.03.2012 10:50, schrieb David Gibson: > > On Fri, Mar 30, 2012 at 11:34:25AM +0200, Andreas Färber wrote: > >> Am 30.03.2012 11:32, schrieb Andreas Färber: > >>> Am 27.03.2012 04:43, schrieb David Gibson: > diff --git a/hw/

Re: [Qemu-devel] [PATCH 2/2] usb-xhci: Use PCI DMA helper functions

2012-04-02 Thread David Gibson
On Mon, Apr 02, 2012 at 11:03:33AM +0200, Andreas Färber wrote: > Am 02.04.2012 06:10, schrieb David Gibson: > > Shortly before 1.0, we added helper functions / wrappers for doing PCI DMA > > from individual devices. This makes what's going on clearer and means that > > when we add IOMMU support s

Re: [Qemu-devel] [RFC PATCH v1 1/4] SPI: initial support

2012-04-02 Thread Peter Crosthwaite
Hi Peter, So ive looked into this further, and I think I better see the confusion between us. My api attempt is attempting to abstract away the clock wheras the txrx approach is true'er to the physical interface. This sense of one-sided communication that im trying to model is comming from the fac

[Qemu-devel] [PATCH v2 0/4] QOM'ify x86 CPU, part 1

2012-04-02 Thread Andreas Färber
Hello, This series strips down x86 CPU QOM'ification to the bare minimum, leaving out subclasses for builtin or external CPU models. It is ordered after the s390x conversion but is independent of it, again due to alphabetical ordering, so that it could be applied right away now. While I haven't s

Re: [Qemu-devel] [RFC PATCH v1 1/4] SPI: initial support

2012-04-02 Thread Andreas Färber
Am 03.04.2012 01:57, schrieb Peter Crosthwaite: > On Tue, Apr 3, 2012 at 3:39 AM, Peter Maydell > wrote: >> On 30 March 2012 07:37, Peter A. G. Crosthwaite >> wrote: >>> +typedef struct spi_bus { >>> +BusState qbus; >>> +SPISlave **slaves; >>> +uint8_t num_slaves; >>> +uint8_t cu

[Qemu-devel] [PATCH v2 3/4] target-i386: QOM'ify CPU init

2012-04-02 Thread Andreas Färber
Move code from cpu_x86_init() to new QOM x86_cpu_initfn(). Also move mce_init() to cpu.c since it's used nowhere else. Signed-off-by: Andreas Färber --- target-i386/cpu.c| 27 +++ target-i386/helper.c | 18 -- 2 files changed, 27 insertions(+), 18

[Qemu-devel] [PATCH v2 4/4] target-i386: QOM'ify CPU reset

2012-04-02 Thread Andreas Färber
Move code from cpu_state_reset() into QOM x86_cpu_reset(), fixing style issues for FPU init. Signed-off-by: Andreas Färber --- target-i386/cpu.c| 72 +- target-i386/helper.c | 71 + 2 files ch

[Qemu-devel] [PATCH v2 2/4] target-i386: QOM'ify CPU

2012-04-02 Thread Andreas Färber
Embed CPUX86State as first member of X86CPU. Drop cpu_x86_close() in favor of calling object_delete() directly. For now let CPUClass::reset() call cpu_state_reset(). Signed-off-by: Andreas Färber --- target-i386/cpu-qom.h | 71 + target-i386/cpu

[Qemu-devel] [PATCH v2 1/4] target-i386: Rename cpuid.c

2012-04-02 Thread Andreas Färber
Name it cpu.c to align with other QOM'ified targets. Signed-off-by: Andreas Färber --- Makefile.target|2 +- target-i386/{cpuid.c => cpu.c} |0 2 files changed, 1 insertions(+), 1 deletions(-) rename target-i386/{cpuid.c => cpu.c} (100%) diff --git a/Makefile.target b/M

Re: [Qemu-devel] [RFC PATCH v1 1/4] SPI: initial support

2012-04-02 Thread Peter Crosthwaite
On Tue, Apr 3, 2012 at 3:39 AM, Peter Maydell wrote: > On 30 March 2012 07:37, Peter A. G. Crosthwaite > wrote: >> defined spi bus and spi slave QOM interfaces. Inspired by and loosley based >> on > > "Define"; "loosely". > ack >> existing I2C framework. >> >> Signed-off-by: Peter A. G. Crosth

Re: [Qemu-devel] [RFC PATCH v1 1/4] SPI: initial support

2012-04-02 Thread Peter Crosthwaite
>> + >> +/* create a new spi bus */ >> +spi_bus *spi_init_bus(DeviceState *parent, int num_slaves, const char >> *name); >> +int spi_attach_slave(spi_bus *bus, SPISlave *s, int cs); >> + >> +/* change the chip select. Return 1 on failure. */ >> +int spi_set_cs(spi_bus *bus, int cs); >> +int spi_ge

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Jan Kiszka
On 2012-04-02 21:40, Paolo Bonzini wrote: > diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c > index a310cc7..923519c 100644 > --- a/hw/qdev-monitor.c > +++ b/hw/qdev-monitor.c > @@ -157,7 +157,7 @@ int qdev_device_help(QemuOpts *opts) > * for removal. This conditional should be remove

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Peter Maydell
On 2 April 2012 23:03, Paolo Bonzini wrote: > Il 02/04/2012 22:07, Peter Maydell ha scritto: >> On 2 April 2012 20:40, Paolo Bonzini wrote: >>> diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c >>> index a310cc7..923519c 100644 >>> --- a/hw/qdev-monitor.c >>> +++ b/hw/qdev-monitor.c >>> @@ -157,

[Qemu-devel] [PATCH v7 1/8] tracetool: Rewrite infrastructure as python modules

2012-04-02 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- Makefile.objs |6 Makefile.target | 13 - configure |4 scripts/tracetool | 648 - scripts/tracetool.py |

[Qemu-devel] [PATCH v7 3/8] tracetool: Add module for the 'h' format

2012-04-02 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/format/h.py | 45 + 1 files changed, 45 insertions(+), 0 deletions(-) create mode 100644 scripts/tracetool/format/h.py diff --git a/scripts/tracetool/format/h.py b/scripts/tracetool/format/h.py new fil

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Paolo Bonzini
Il 02/04/2012 22:07, Peter Maydell ha scritto: > On 2 April 2012 20:40, Paolo Bonzini wrote: >> diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c >> index a310cc7..923519c 100644 >> --- a/hw/qdev-monitor.c >> +++ b/hw/qdev-monitor.c >> @@ -157,7 +157,7 @@ int qdev_device_help(QemuOpts *opts) >>

[Qemu-devel] [PATCH v7 4/8] tracetool: Add support for the 'stderr' backend

2012-04-02 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/backend/stderr.py | 56 +++ 1 files changed, 56 insertions(+), 0 deletions(-) create mode 100644 scripts/tracetool/backend/stderr.py diff --git a/scripts/tracetool/backend/stderr.py b/scripts/tracetool/backen

[Qemu-devel] [PATCH v7 6/8] tracetool: Add support for the 'ust' backend

2012-04-02 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/backend/ust.py | 90 ++ 1 files changed, 90 insertions(+), 0 deletions(-) create mode 100644 scripts/tracetool/backend/ust.py diff --git a/scripts/tracetool/backend/ust.py b/scripts/tracetool/backend/ust.p

Re: [Qemu-devel] [PATCH v7 0/8] Rewrite tracetool using python modules

2012-04-02 Thread Lluís Vilanova
Lluís Vilanova writes: [...] > Changes in v7: > * Fix backend/format to module name translations. I'm really sorry for the late flooding. This time it's build-tested with future series that use the now-fixed features. Lluis -- "And it's much the same thing with knowledge, for whenever you le

[Qemu-devel] [PATCH v7 8/8] tracetool: Add MAINTAINERS info

2012-04-02 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- MAINTAINERS |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index f83d07c2..0e66dd8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -548,6 +548,8 @@ Tracing M: Stefan Hajnoczi S: Maintained F: trace/ +F: scrip

[Qemu-devel] [PATCH v7 5/8] tracetool: Add support for the 'simple' backend

2012-04-02 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/backend/simple.py | 55 +++ 1 files changed, 55 insertions(+), 0 deletions(-) create mode 100644 scripts/tracetool/backend/simple.py diff --git a/scripts/tracetool/backend/simple.py b/scripts/tracetool/backen

[Qemu-devel] [PATCH v7 7/8] tracetool: Add support for the 'dtrace' backend

2012-04-02 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool.py| 32 +++- scripts/tracetool/__init__.py | 11 scripts/tracetool/backend/dtrace.py | 97 +++ scripts/tracetool/format/d.py | 20 +++ scripts/tracetool/format/

[Qemu-devel] [PATCH v7 2/8] tracetool: Add module for the 'c' format

2012-04-02 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/format/c.py | 20 1 files changed, 20 insertions(+), 0 deletions(-) create mode 100644 scripts/tracetool/format/c.py diff --git a/scripts/tracetool/format/c.py b/scripts/tracetool/format/c.py new file mode 100644 index 0

[Qemu-devel] [PATCH v7 0/8] Rewrite tracetool using python modules

2012-04-02 Thread Lluís Vilanova
A full rewrite of the tracetool script using per-format and per-backend modules, so that it's easier to read and extend it in the future. Signed-off-by: Lluís Vilanova --- NOTE: This series applies in current master, ignoring the "Rewrite tracetool using python" series. Changes in v7: * F

[Qemu-devel] [RFC PATCH 3/3] iommu: Create attach/detach group interface

2012-04-02 Thread Alex Williamson
IOMMU ops should be working at a group level rather than a device level as we cannot arbitrarily assign devices from the same group to different domains. For now this is just a simple wrapper that makes use of the dma_dev within a group. Signed-off-by: Alex Williamson --- drivers/iommu/iommu.c

Re: [Qemu-devel] [PATCH 0/4] qdev: give all devices a canonical QOM path

2012-04-02 Thread Anthony Liguori
On 03/27/2012 11:38 AM, Paolo Bonzini wrote: A strong limitation of QOM right now is that unconverted ports (e.g. all...) do not give a canonical path to devices that are part of the board. This in turn makes it impossible to replace PROP_PTR with a QOM link for example. This series fixes this

[Qemu-devel] [RFC PATCH 2/3] iommu: Create basic group infrastructure and update AMD-Vi & Intel VT-d

2012-04-02 Thread Alex Williamson
IOMMU groups define the minimum granularity of the IOMMU. We therefore create groups using a dma_dev which is the effective requestor ID for the entire group. Additional devices can be added to groups based on system topology, IOMMU limitations, or device quirks. This implementation also include

[Qemu-devel] [RFC PATCH 1/3] iommu: Introduce iommu_group

2012-04-02 Thread Alex Williamson
IOMMUs often do not have visibility of individual devices in the system. Due to IOMMU design, bus topology, or device quirks, we can often only identify groups of devices. Examples include Intel VT-d & AMD-Vi which often have function level visibility compared to POWER partitionable endpoints whi

[Qemu-devel] [RFC PATCH 0/3] IOMMU groups

2012-04-02 Thread Alex Williamson
This series attempts to make IOMMU device grouping a slightly more integral part of the device model. iommu_device_groups were originally introduced to support the VFIO user space driver interface which needs to understand the granularity of device isolation in order to ensure security of devices

Re: [Qemu-devel] [PATCH 6/6] hw/sd.c: convert to QOM object

2012-04-02 Thread Paolo Bonzini
Il 02/04/2012 22:56, Igor Mitsyanko ha scritto: > 2) At first I made SD card child of SD host controller, but it most > certainly wrong, it should be a link. This is a bit thorny, because BlockDriverState exposes a slot and its medium, not just the medium (you can have an empty BDS, and that is no

Re: [Qemu-devel] KVM call agenda for April, Tuesday 3

2012-04-02 Thread Jan Kiszka
On 2012-04-02 13:30, Juan Quintela wrote: > > Hi > > Please send in any agenda items you are interested in covering. - MSI injection to KVM irqchips from userspace devices models: new direct MSI injection API for KVM and the right model for QEMU to deal with the old API - state of and plans

Re: [Qemu-devel] [PATCH 6/6] hw/sd.c: convert to QOM object

2012-04-02 Thread Peter Maydell
On 2 April 2012 21:56, Igor Mitsyanko wrote: > On 02.04.2012 7:48 PM, Peter Maydell wrote: >> Ideally rather than having a class specific init function we >> should make the 'is_spi' and 'bdrv' be object properties, >> >> This needs realize support for QOM objects, though. > I absolutely agree, t

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Anthony Liguori
On 04/02/2012 03:07 PM, Jan Kiszka wrote: On 2012-04-02 21:41, Anthony Liguori wrote: Is there a reason you're using info qtree instead of qom-list? qom-list gives you much more info than info qtree. BTW, the qom-list output is still, well, sparsely populated. Also, there is a "-r" (for recur

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Peter Maydell
On 2 April 2012 20:40, Paolo Bonzini wrote: > diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c > index a310cc7..923519c 100644 > --- a/hw/qdev-monitor.c > +++ b/hw/qdev-monitor.c > @@ -157,7 +157,7 @@ int qdev_device_help(QemuOpts *opts) >          * for removal.  This conditional should be remo

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Jan Kiszka
On 2012-04-02 21:41, Anthony Liguori wrote: > Is there a reason you're using info qtree instead of qom-list? qom-list > gives you much more info than info qtree. BTW, the qom-list output is still, well, sparsely populated. Also, there is a "-r" (for recursive) switch missing to make it similar us

Re: [Qemu-devel] [PATCH] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-02 Thread Michael Tokarev
On 02.04.2012 21:35, Liu Yuan wrote: > From: Liu Yuan > > Flush operation is supposed to flush the write-back cache of > sheepdog cluster. > > By issuing flush operation, we can assure the Guest of data > reaching the sheepdog cluster storage. > > Cc: Kevin Wolf > Reviewd-by: MORITA Kazutaka

Re: [Qemu-devel] [PATCH 6/6] hw/sd.c: convert to QOM object

2012-04-02 Thread Igor Mitsyanko
On 02.04.2012 7:48 PM, Peter Maydell wrote: On 2 April 2012 15:28, Igor Mitsyanko wrote: +s->card = SD_CARD(object_new(TYPE_SD_CARD)); dinfo = drive_get_next(IF_SD); -s->card = sd_init(dinfo ? dinfo->bdrv : NULL, 0); +SD_GET_CLASS(s->card)->init(s->card, dinfo ? dinfo->bdrv : N

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Jan Kiszka
On 2012-04-02 21:48, Anthony Liguori wrote: > On 04/02/2012 02:44 PM, Jan Kiszka wrote: >> On 2012-04-02 21:41, Anthony Liguori wrote: >>> On 04/02/2012 02:33 PM, Jan Kiszka wrote: Hi Anthony, I noticed that only properties with legacy names are printed via info qtree. >>> >>> Y

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Anthony Liguori
On 04/02/2012 02:44 PM, Jan Kiszka wrote: On 2012-04-02 21:41, Anthony Liguori wrote: On 04/02/2012 02:33 PM, Jan Kiszka wrote: Hi Anthony, I noticed that only properties with legacy names are printed via info qtree. Yes. Is that not what you expect? The qom properties and model is not sta

Re: [Qemu-devel] [PATCH 6/6] hw/sd.c: convert to QOM object

2012-04-02 Thread Paolo Bonzini
Il 02/04/2012 18:48, Peter Maydell ha scritto: > Ideally rather than having a class specific init function we > should make the 'is_spi' and 'bdrv' be object properties, and > then you do something like (syntax probably wrong but): > s->card = SD_CARD(object_new(TYPE_SD_CARD)); > if (dinfo) { >

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Jan Kiszka
On 2012-04-02 21:41, Anthony Liguori wrote: > On 04/02/2012 02:33 PM, Jan Kiszka wrote: >> Hi Anthony, >> >> I noticed that only properties with legacy names are printed via info >> qtree. > > Yes. Is that not what you expect? > > The qom properties and model is not stable for 1.1 so I was very

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Anthony Liguori
On 04/02/2012 02:40 PM, Paolo Bonzini wrote: Il 02/04/2012 21:33, Jan Kiszka ha scritto: Hi Anthony, I noticed that only properties with legacy names are printed via info qtree. After digging through the qdev and qom property maze, it turned out the property registration in qdev_property_add_le

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Anthony Liguori
On 04/02/2012 02:33 PM, Jan Kiszka wrote: Hi Anthony, I noticed that only properties with legacy names are printed via info qtree. Yes. Is that not what you expect? The qom properties and model is not stable for 1.1 so I was very careful in making sure they didn't leak into info qtree. A

Re: [Qemu-devel] qdev property listing broken

2012-04-02 Thread Paolo Bonzini
Il 02/04/2012 21:33, Jan Kiszka ha scritto: > Hi Anthony, > > I noticed that only properties with legacy names are printed via info > qtree. After digging through the qdev and qom property maze, it turned > out the property registration in qdev_property_add_legacy and > qdev_property_add_static is

[Qemu-devel] qdev property listing broken

2012-04-02 Thread Jan Kiszka
Hi Anthony, I noticed that only properties with legacy names are printed via info qtree. After digging through the qdev and qom property maze, it turned out the property registration in qdev_property_add_legacy and qdev_property_add_static is not consistent with the access in qdev_print_props. The

Re: [Qemu-devel] [PATCHv3] piix: fix up/down races

2012-04-02 Thread Michael S. Tsirkin
On Mon, Apr 02, 2012 at 12:59:54PM -0600, Alex Williamson wrote: > On Mon, 2012-04-02 at 13:03 +0300, Michael S. Tsirkin wrote: > > piix acpi interface suffers from the following 2 issues: > > > > 1. > > - delete device a > > - quickly add device b in another slot > > > > if we do this before gue

[Qemu-devel] [PATCH v6 7/8] tracetool: Add support for the 'dtrace' backend

2012-04-02 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool.py| 32 +++- scripts/tracetool/__init__.py | 11 scripts/tracetool/backend/dtrace.py | 97 +++ scripts/tracetool/format/d.py | 20 +++ scripts/tracetool/format/

Re: [Qemu-devel] [PATCH 1/6] hw/sd.c: convert wp_groups in SDState to bitfield

2012-04-02 Thread Igor Mitsyanko
On 02.04.2012 5:42 PM, Peter Maydell wrote: On 2 April 2012 15:28, Igor Mitsyanko wrote: Representing each group write protection flag with only one bit instead of int variable significantly reduces memory consumption. Can we use the bitmap.h functions here rather than doing things by hand? (

[Qemu-devel] [PATCH v6 4/8] tracetool: Add support for the 'stderr' backend

2012-04-02 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/backend/stderr.py | 56 +++ 1 files changed, 56 insertions(+), 0 deletions(-) create mode 100644 scripts/tracetool/backend/stderr.py diff --git a/scripts/tracetool/backend/stderr.py b/scripts/tracetool/backen

[Qemu-devel] [PATCH v6 6/8] tracetool: Add support for the 'ust' backend

2012-04-02 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/backend/ust.py | 90 ++ 1 files changed, 90 insertions(+), 0 deletions(-) create mode 100644 scripts/tracetool/backend/ust.py diff --git a/scripts/tracetool/backend/ust.py b/scripts/tracetool/backend/ust.p

Re: [Qemu-devel] [PATCHv3] piix: fix up/down races

2012-04-02 Thread Alex Williamson
On Mon, 2012-04-02 at 13:03 +0300, Michael S. Tsirkin wrote: > piix acpi interface suffers from the following 2 issues: > > 1. > - delete device a > - quickly add device b in another slot > > if we do this before guest reads the down register, > the down event is discarded and device will never >

[Qemu-devel] [PATCH] sheepdog: implement SD_OP_FLUSH_VDI operation

2012-04-02 Thread Liu Yuan
From: Liu Yuan Flush operation is supposed to flush the write-back cache of sheepdog cluster. By issuing flush operation, we can assure the Guest of data reaching the sheepdog cluster storage. Cc: Kevin Wolf Reviewd-by: MORITA Kazutaka Signed-off-by: Liu Yuan --- block/sheepdog.c | 50 +++

[Qemu-devel] [PATCH v6 1/8] tracetool: Rewrite infrastructure as python modules

2012-04-02 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- Makefile.objs |6 Makefile.target | 13 - configure |4 scripts/tracetool | 648 - scripts/tracetool.py |

[Qemu-devel] [PATCH v6 3/8] tracetool: Add module for the 'h' format

2012-04-02 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/format/h.py | 45 + 1 files changed, 45 insertions(+), 0 deletions(-) create mode 100644 scripts/tracetool/format/h.py diff --git a/scripts/tracetool/format/h.py b/scripts/tracetool/format/h.py new fil

[Qemu-devel] [PATCH v6 2/8] tracetool: Add module for the 'c' format

2012-04-02 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/format/c.py | 20 1 files changed, 20 insertions(+), 0 deletions(-) create mode 100644 scripts/tracetool/format/c.py diff --git a/scripts/tracetool/format/c.py b/scripts/tracetool/format/c.py new file mode 100644 index 0

[Qemu-devel] [PATCH v6 5/8] tracetool: Add support for the 'simple' backend

2012-04-02 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/backend/simple.py | 55 +++ 1 files changed, 55 insertions(+), 0 deletions(-) create mode 100644 scripts/tracetool/backend/simple.py diff --git a/scripts/tracetool/backend/simple.py b/scripts/tracetool/backen

Re: [Qemu-devel] [PATCH 6/9] Fix bit test to use & instead of && and enable -Wlogical-op warning

2012-04-02 Thread Maksim Kozlov
02.04.2012 16:27, Peter Maydell пишет: On 2 April 2012 11:50, Daniel P. Berrange wrote: diff --git a/hw/exynos4210_uart.c b/hw/exynos4210_uart.c index 73a9c18..4b20105 100644 --- a/hw/exynos4210_uart.c +++ b/hw/exynos4210_uart.c @@ -246,7 +246,7 @@ static uint32_t exynos4210_uart_Tx_FIFO_trigg

qemu-devel@nongnu.org

2012-04-02 Thread Maksim Kozlov
02.04.2012 17:43, Daniel P. Berrange пишет: From: "Daniel P. Berrange" * hw/exynos4210_uart.c: s/&&/&/ Signed-off-by: Daniel P. Berrange --- hw/exynos4210_uart.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/exynos4210_uart.c b/hw/exynos4210_uart.c index 73

[Qemu-devel] [PATCH v6 8/8] tracetool: Add MAINTAINERS info

2012-04-02 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- MAINTAINERS |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index f83d07c2..0e66dd8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -548,6 +548,8 @@ Tracing M: Stefan Hajnoczi S: Maintained F: trace/ +F: scrip

[Qemu-devel] [PATCH v6 0/8] Rewrite tracetool using python modules

2012-04-02 Thread Lluís Vilanova
A full rewrite of the tracetool script using per-format and per-backend modules, so that it's easier to read and extend it in the future. Signed-off-by: Lluís Vilanova --- NOTE: This series applies in current master, ignoring the "Rewrite tracetool using python" series. Changes in v6: * S

[Qemu-devel] [PATCH] usb-host: fix handling of zero-length packets

2012-04-02 Thread Johannes Stezenbach
Zero-length packets are valid but currently cause qemu to crash: Program terminated with signal 11, Segmentation fault. #0 0xf7589f26 in usb_host_handle_data (dev=0xf8fd4820, p=0xf91606b0) at qemu/hw/usb/host-linux.c:886 886 prem = p->iov.iov[v].iov_len; (gdb) bt #0 0xf7589f26 in usb_ho

Re: [Qemu-devel] Why we need unlink tb when cpu_interrupt/cpu_exit get called?

2012-04-02 Thread 陳韋任
> Try following with and without tb unlinking on aforementioned image to > feel the difference: > > sh-2.05b# echo "char main[]={0xeb,-2};" >h.c > sh-2.05b# tcc -run h.c I think the example you gave me is an infinite loop, right? O.K., here is what I got. Case 1. With tb unlinking - tcc

Re: [Qemu-devel] [PATCHv5 00/11] cleanup/consolidate iovec functions

2012-04-02 Thread Michael Tokarev
Hello again.. Can we do something with this stuff, or should it finally die in peace? :) Thanks! /mjt On 20.03.2012 01:22, Michael Tokarev wrote: > This is my last attempt. It is pointless to bother so much > people with so much trivial stuff again and again and again. > > This is cleanup/con

Re: [Qemu-devel] [RFC PATCH v1 1/4] SPI: initial support

2012-04-02 Thread Peter Maydell
On 30 March 2012 07:37, Peter A. G. Crosthwaite wrote: > defined spi bus and spi slave QOM interfaces. Inspired by and loosley based on "Define"; "loosely". > existing I2C framework. > > Signed-off-by: Peter A. G. Crosthwaite > --- >  Makefile.target |    1 + >  hw/spi.c        |  175 > ++

[Qemu-devel] [PATCH v2 0/4] QOM'ify S/390 CPU

2012-04-02 Thread Andreas Färber
Hello, This series breaks down my S/390 QOM'ification patch from the qom-cpu-others.v1 RFC series into better digestable pieces and reorders it next. s390x ignores any user-specified -cpu argument, thus needs only one CPU type. I've tested both TCG by running SLES installation and briefly KVM on

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH 01/15] hvm: Modify interface to support multiple ioreq server

2012-04-02 Thread Ian Jackson
Julien Grall writes ("[Xen-devel] [XEN][RFC PATCH 01/15] hvm: Modify interface to support multiple ioreq server"): > Add structure to handle ioreq server. It's server which can > handle a range of IO (MMIO and/or PIO) and emulate a PCI. > Each server as its own shared page to receive ioreq. So > w

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH 14/15] xl-parsing: Parse the new option device_models

2012-04-02 Thread Ian Jackson
Julien Grall writes ("[Xen-devel] [XEN][RFC PATCH 14/15] xl-parsing: Parse the new option device_models"): > For the support of multiple ioreq server, we add a new option "device_models". > It's an array of device model, for each device model, we need to specify > which pci, IO range (MMIO, PIO) w

[Qemu-devel] [PATCH v2 4/4] target-s390x: Update s390x_{tod, cpu}_timer to use S390CPU

2012-04-02 Thread Andreas Färber
In place of CPUS390XState pass S390CPU as opaque from the new initfn. cpu_interrupt() is anticipated to take a CPUState in the future. Signed-off-by: Andreas Färber --- target-s390x/cpu.c|4 ++-- target-s390x/helper.c |6 -- 2 files changed, 6 insertions(+), 4 deletions(-) diff

[Qemu-devel] [PATCH v2 2/4] target-s390x: QOM'ify CPU reset

2012-04-02 Thread Andreas Färber
Move code from cpu_state_reset() to s390_cpu_reset(). Signed-off-by: Andreas Färber Cc: Ulrich Hecht --- target-s390x/cpu.c| 13 - target-s390x/helper.c | 12 ++-- 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/target-s390x/cpu.c b/target-s390x/cpu.

[Qemu-devel] [PATCH v2 3/4] target-s390x: QOM'ify CPU init

2012-04-02 Thread Andreas Färber
Move code from cpu_s390x_init() into an initfn. Signed-off-by: Andreas Färber --- target-s390x/cpu.c| 25 + target-s390x/cpu.h|3 +++ target-s390x/helper.c | 21 +++-- 3 files changed, 31 insertions(+), 18 deletions(-) diff --git a/target-

[Qemu-devel] [PATCH v2 1/4] target-s390x: QOM'ify CPU

2012-04-02 Thread Andreas Färber
Embed CPUS390XState as first member of S390CPU. Since -cpu is being ignored, make TYPE_S390_CPU non-abstract. Signed-off-by: Andreas Färber --- Makefile.target|1 + target-s390x/cpu-qom.h | 71 target-s390x/cpu.c | 60 +

Re: [Qemu-devel] [PATCH 1/2] serial: fix retry logic

2012-04-02 Thread Anthony Liguori
On 04/02/2012 11:18 AM, Stefano Stabellini wrote: On Mon, 2 Apr 2012, Anthony Liguori wrote: I'm not sure if the retry logic has ever worked when not using FIFO mode. I found this while writing a test case although code inspection confirms it is definitely broken. The TSR retry logic will neve

Re: [Qemu-devel] [PATCH 5/6] hw/sd.c: add SD card save/load support

2012-04-02 Thread Peter Maydell
On 2 April 2012 15:28, Igor Mitsyanko wrote: > This patch updates SD card emulation to support save/load of card's state. > > Signed-off-by: Igor Mitsyanko Looks OK apart from the bits that will need to change to use the bitops/bitmap functions (see earlier patch comments.) -- PMM

Re: [Qemu-devel] [PATCH 6/6] hw/sd.c: convert to QOM object

2012-04-02 Thread Peter Maydell
On 2 April 2012 15:28, Igor Mitsyanko wrote: > +    s->card = SD_CARD(object_new(TYPE_SD_CARD)); >     dinfo = drive_get_next(IF_SD); > -    s->card = sd_init(dinfo ? dinfo->bdrv : NULL, 0); > +    SD_GET_CLASS(s->card)->init(s->card, dinfo ? dinfo->bdrv : NULL, false); Ideally rather than having

Re: [Qemu-devel] [PATCH 9/9] Add note about some other options potentially worth enabling

2012-04-02 Thread Stefan Weil
Am 02.04.2012 12:50, schrieb Daniel P. Berrange: From: "Daniel P. Berrange" There are a few other GCC warning options likely worth enabling, but it is not practical with the level of warnings generated. Add a note about them for anyone motiviated to address it in the future * configure: Add -W

Re: [Qemu-devel] [PATCH 2/6] hw/sd.c: convert binary variables to bool

2012-04-02 Thread Peter Maydell
On 2 April 2012 15:28, Igor Mitsyanko wrote: > Several members of SDState have type int when they actually are binary > variables. > Change type of these variables to bool to improve code readability. Change SD > API > to be in consistency with new variables type. > > Signed-off-by: Igor Mitsyan

Re: [Qemu-devel] [PATCH 3/6] hw/sd.c: make sd_dataready() return bool

2012-04-02 Thread Peter Maydell
On 2 April 2012 15:28, Igor Mitsyanko wrote: > For the sake of code clarity > > Signed-off-by: Igor Mitsyanko Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH 3/9] Print out progress when checking compiler flags

2012-04-02 Thread Stefan Weil
Am 02.04.2012 12:50, schrieb Daniel P. Berrange: From: "Daniel P. Berrange" Normal practice for autoconf style scripts is to print out progress. The QEMU configure script is getting increasingly slow& has no progress feedback. Print out the progress of checking each compiler flag Signed-off-by

Re: [Qemu-devel] [RFC PATCH v2] Replication agent module

2012-04-02 Thread Eric Blake
On 04/01/2012 06:05 AM, Ori Mamluk wrote: > Repagent is a new block driver that allows an external replication system > to hook to the Qemu storage stack to replicate a volume of a VM. > This RFC patch adds the repagent client module to Qemu. > Completely non-technical review of just your documen

Re: [Qemu-devel] [PATCH 2/9] Fix checking for compiler flag support

2012-04-02 Thread Stefan Weil
Am 02.04.2012 12:50, schrieb Daniel P. Berrange: From: "Daniel P. Berrange" Some warning flags have dependancies, eg -Wformat-security cannot be enabled if -Wformat is not already enabled. The compiler flag checking code was checking each flag in isolation so several were not getting enabled. T

  1   2   3   >